From owner-freebsd-rc@FreeBSD.ORG Mon Jan 16 11:07:11 2012 Return-Path: Delivered-To: freebsd-rc@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 1E73B106566B for ; Mon, 16 Jan 2012 11:07:11 +0000 (UTC) (envelope-from owner-bugmaster@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 035028FC27 for ; Mon, 16 Jan 2012 11:07:11 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id q0GB7AqV057748 for ; Mon, 16 Jan 2012 11:07:10 GMT (envelope-from owner-bugmaster@FreeBSD.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.5/8.14.5/Submit) id q0GB79PH057746 for freebsd-rc@FreeBSD.org; Mon, 16 Jan 2012 11:07:09 GMT (envelope-from owner-bugmaster@FreeBSD.org) Date: Mon, 16 Jan 2012 11:07:09 GMT Message-Id: <201201161107.q0GB79PH057746@freefall.freebsd.org> X-Authentication-Warning: freefall.freebsd.org: gnats set sender to owner-bugmaster@FreeBSD.org using -f From: FreeBSD bugmaster To: freebsd-rc@FreeBSD.org Cc: Subject: Current problem reports assigned to freebsd-rc@FreeBSD.org X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Jan 2012 11:07:11 -0000 Note: to view an individual PR, use: http://www.freebsd.org/cgi/query-pr.cgi?pr=(number). The following is a listing of current problems submitted by FreeBSD users. These represent problem reports covering all versions including experimental development code and obsolete releases. S Tracker Resp. Description -------------------------------------------------------------------------------- o conf/163508 rc [rc.subr] [patch] Add "enable" and "disable" commands o conf/163488 rc Confusing explanation in defaults/rc.conf o conf/163321 rc [rc.conf] [patch] allow _fib syntax in rc.conf o conf/162642 rc .sh scripts in /usr/local/etc/rc.d get executed, not s o conf/161107 rc [rc] stop_boot in mountcritlocal usage is incorrect. o conf/160403 rc [rc] [patch] concurrently running rc-scripts during bo o conf/160240 rc rc.d/mdconfig and mdconfig2 should autoset $_type to v o conf/159846 rc [rc.conf] routing_stop_inet6() logic doesn't handle ip o conf/158557 rc [patch] /etc/rc.d/pf broken messages o conf/158127 rc [patch] remount_optional option in rc.initdiskless doe o conf/154554 rc [rc.d] [patch] statd and lockd fail to start o conf/153666 rc [rc.d][patch] mount filesystems from fstab over zfs da o conf/153200 rc post-boot /etc/rc.d/network_ipv6 start can miss neighb o conf/153123 rc [rc] [patch] add gsched rc file to automatically inser o conf/150474 rc [patch] rc.d/accounting: Add ability to set location o o conf/149867 rc [PATCH] rc.d script to manage multiple FIBS (kern opti o conf/149831 rc [PATCH] add support to /etc/rc.d/jail for delegating Z o conf/148656 rc rc.firewall(8): {oip} and {iip} variables in rc.firewa o conf/147685 rc [rc.d] [patch] new feature for /etc/rc.d/fsck o conf/147444 rc [rc.d] [patch] /etc/rc.d/zfs stop not called on reboot o conf/146053 rc [patch] [request] shutdown of jails breaks inter-jail o conf/145445 rc [rc.d] error in /etc/rc.d/jail (bad logic) o conf/145440 rc [rc.d] [patch] add multiple fib support (setfib) in /e o conf/145399 rc [patch] rc.d scripts are unable to start/stop programs o conf/145009 rc [patch] rc.subr(8): rc.conf should allow mac label con o conf/144213 rc [rc.d] [patch] Disappearing zvols on reboot o conf/143637 rc [patch] ntpdate(8) support for ntp-servers supplied by o conf/143085 rc [patch] ftp-proxy(8) rc(8) with multiple instances o conf/143084 rc [jail] [patch]: fix rc.d/jail creating stray softlinks o conf/142973 rc [jail] [patch] Strange counter init value in jail rc o conf/142434 rc [patch] Add cpuset(1) support to rc.subr(8) o conf/142304 rc rc.conf(5): mdconfig and mdconfig2 rc.d scripts lack e o conf/141909 rc rc.subr(8): [patch] add rc.conf.d support to /usr/loca o conf/141907 rc [rc.d] Bug if mtu (maybe others?) is set as first argu o conf/141678 rc [patch] A minor enhancement to how /etc/rc.d/jail dete o conf/141275 rc [request] dhclient(8) rc script should print something o conf/140440 rc [patch] allow local command files in rc.{suspend,resum o conf/140261 rc [patch] Improve flexibility of mdconfig2 startup scrip o conf/138208 rc [rc.d] [patch] Making rc.firewall (workstation) IPv6 a o conf/137629 rc [rc.d] background_dhclient rc.conf option causing doub o conf/137470 rc [PATCH] /etc/rc.d/mdconfig2 : prioritize cli parameter o conf/137271 rc [rc.d] Cannot update /etc/host.conf when root filesyst o conf/136624 rc [rc.d] sysctl variables for ipnat are not applied on b o conf/135338 rc [rc.d] pf startup order seems broken [regression] o conf/134918 rc [patch] rc.subr fails to detect perl daemons o conf/134660 rc [patch] rc-script for initializing ng_netflow+ng_ipfw o conf/134333 rc PPP configuration problem in the rc.d scripts in combi o conf/134006 rc [patch] Unload console screensaver kernel modules if s o conf/133890 rc [patch] sshd(8): add multiple profiles to the rc.d scr o conf/132483 rc rc.subr(8) [patch] setfib(1) support for rc.subr o conf/132476 rc [rc.d] [patch] add support setfib(1) in rc.d/routing o conf/128299 rc [patch] /etc/rc.d/geli does not mount partitions using o conf/126392 rc [patch] rc.conf ifconfig_xx keywords cannot be escaped p bin/126324 rc [patch] rc.d/tmp: Prevent mounting /tmp in second tim o conf/124747 rc [patch] savecore can't create dump from encrypted swap o conf/124248 rc [jail] [patch] add support for nice value for rc.d/jai o conf/123734 rc [patch] Chipset VIA CX700 requires extra initializatio o conf/123222 rc [patch] Add rtprio(1)/idprio(1) support to rc.subr(8). o conf/123119 rc [patch] rc script for ipfw does not handle IPv6 o conf/122968 rc [rc.d] /etc/rc.d/addswap: md swapfile multiplication a o conf/122477 rc [patch] /etc/rc.d/mdconfig and mdconfig2 are ignoring o conf/122170 rc [patch] [request] New feature: notify admin via page o o kern/121566 rc [nfs] [request] [patch] ethernet iface should be broug o conf/120431 rc [patch] devfs.rules are not initialized under certain o conf/120406 rc [devd] [patch] Handle newly attached pcm devices (eg. o conf/119874 rc [patch] "/etc/rc.d/pf reload" fails if there are macro o conf/119076 rc [patch] [rc.d] /etc/rc.d/netif tries to remove alias a o bin/118325 rc [patch] [request] new periodic script to test statuses o conf/118255 rc savecore never finding kernel core dumps (rcorder prob o conf/117935 rc [patch] ppp fails to start at boot because of missing o conf/113915 rc [patch] ndis wireless driver fails to associate when i o conf/109980 rc /etc/rc.d/netif restart doesn't destroy cloned_interfa o conf/109562 rc [rc.d] [patch] [request] Make rc.d/devfs usable from c o conf/109272 rc [request] increase default rc shutdown timeout o conf/108589 rc rtsol(8) fails due to default ipfw rules o conf/106009 rc [ppp] [patch] [request] Fix pppoed startup script to p o conf/105689 rc [ppp] [request] syslogd starts too late at boot o conf/105145 rc [ppp] [patch] [request] add redial function to rc.d/pp o conf/104549 rc [patch] rc.d/nfsd needs special _find_processes functi o conf/102700 rc [geli] [patch] Add encrypted /tmp support to GELI/GBDE o conf/99721 rc [patch] /etc/rc.initdiskless problem copy dotfile in s o conf/99444 rc [patch] Enhancement: rc.subr could easily support star o conf/96343 rc [patch] rc.d order change to start inet6 before pf o conf/93815 rc [patch] Adds in the ability to save ipfw rules to rc.d o conf/92523 rc [patch] allow rc scripts to kill process after a timeo o conf/89870 rc [patch] [request] make netif verbose rc.conf toggle o conf/88913 rc [patch] wrapper support for rc.subr o conf/85819 rc [patch] script allowing multiuser mode in spite of fsc o kern/81006 rc ipnat not working with tunnel interfaces on startup o conf/77663 rc Suggestion: add /etc/rc.d/addnetswap after addcritremo o conf/73677 rc [patch] add support for powernow states to power_profi o conf/58939 rc [patch] dumb little hack for /etc/rc.firewall{,6} o conf/56934 rc [patch] rc.firewall rules for natd expect an interface o conf/44170 rc [patch] Add ability to run multiple pppoed(8) on start 94 problems total. From owner-freebsd-rc@FreeBSD.ORG Tue Jan 17 04:38:29 2012 Return-Path: Delivered-To: freebsd-rc@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 54C8C106566C for ; Tue, 17 Jan 2012 04:38:29 +0000 (UTC) (envelope-from erdgeist@erdgeist.org) Received: from elektropost.org (elektropost.org [217.13.206.130]) by mx1.freebsd.org (Postfix) with ESMTP id 828868FC0A for ; Tue, 17 Jan 2012 04:38:28 +0000 (UTC) Received: (qmail 67449 invoked from network); 17 Jan 2012 04:12:48 -0000 Received: from elektropost.org (HELO elektropost.org) (erdgeist@erdgeist.org) by elektropost.org with CAMELLIA256-SHA encrypted SMTP; 17 Jan 2012 04:12:48 -0000 Message-ID: <4F14F4FF.902@erdgeist.org> Date: Tue, 17 Jan 2012 05:11:43 +0100 From: Dirk Engling User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:9.0) Gecko/20111222 Thunderbird/9.0.1 MIME-Version: 1.0 To: freebsd-rc@freebsd.org X-Enigmail-Version: 1.3.4 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Bumping a pet bug X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Jan 2012 04:38:29 -0000 Dear rc team, I know your time is precious, but there is an annoying bug in rc.d/jail that keeps littering my (and my user's) servers with stray soft links whenever we start jails. I've described the bug two years ago here http://www.FreeBSD.org/cgi/query-pr.cgi?pr=conf/143084 and even conveniently applied a simple and effective patch. tl;dr: If rc.d/jail can not access $_devdir, a soft link is created in ./log => ../var/run/log no matter where I was. Unfortunally I am still busy answering emails from users of ezjail who first look for the problem with themselves, then blame it on ezjail and finally complain about FreeBSD. Also I have to clean up my systems from all the littering links called "log" pointing nowhere. If please a committer could take the five minutes to look into the bug and fix the problem, he could save me and my users a lot of trouble and time. Thanks in advance, erdgeist From owner-freebsd-rc@FreeBSD.ORG Tue Jan 17 19:19:03 2012 Return-Path: Delivered-To: freebsd-rc@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 8BC5A1065674 for ; Tue, 17 Jan 2012 19:19:03 +0000 (UTC) (envelope-from utisoft@gmail.com) Received: from mail-iy0-f182.google.com (mail-iy0-f182.google.com [209.85.210.182]) by mx1.freebsd.org (Postfix) with ESMTP id 1CA778FC16 for ; Tue, 17 Jan 2012 19:19:02 +0000 (UTC) Received: by iagz16 with SMTP id z16so8582878iag.13 for ; Tue, 17 Jan 2012 11:19:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:from:date :x-google-sender-auth:message-id:subject:to:cc:content-type :content-transfer-encoding; bh=wrRGVfwp1yicASyHmaQBaJNn9y9C8CJkLb7jq5G11Sw=; b=KTiUGN39dGIdY9+ExY+nUKURBl+8dTWfxEjk070FCTsungP1wiXo31Cs1Y8qIAVqcc P8a56Y/lLATkw+RnzNQ5sf4N4qtgTIGUezmGVSG7plrehvbhEFyBgDzTQzPqpvLStIwu 7plkHyFY5RnTu/k7Y2YjsZYsD2GUtJjN0JBcE= Received: by 10.42.142.129 with SMTP id s1mr14872756icu.42.1326827942523; Tue, 17 Jan 2012 11:19:02 -0800 (PST) MIME-Version: 1.0 Sender: utisoft@gmail.com Received: by 10.231.207.7 with HTTP; Tue, 17 Jan 2012 11:18:31 -0800 (PST) In-Reply-To: <4F14F4FF.902@erdgeist.org> References: <4F14F4FF.902@erdgeist.org> From: Chris Rees Date: Tue, 17 Jan 2012 19:18:31 +0000 X-Google-Sender-Auth: 4f5dc0JRE6Cd81q3hJSd1siSC9w Message-ID: To: Dirk Engling Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: freebsd-rc@freebsd.org Subject: Re: Bumping a pet bug X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Jan 2012 19:19:03 -0000 On 17 January 2012 04:11, Dirk Engling wrote: > Dear rc team, > > I know your time is precious, but there is an annoying bug in rc.d/jail > that keeps littering my (and my user's) servers with stray soft links > whenever we start jails. > > I've described the bug two years ago here > > http://www.FreeBSD.org/cgi/query-pr.cgi?pr=3Dconf/143084 > > and even conveniently applied a simple and effective patch. > > tl;dr: If rc.d/jail can not access $_devdir, a soft link is created in > ./log =3D> ../var/run/log =A0no matter where I was. > > Unfortunally I am still busy answering emails from users of ezjail who > first look for the problem with themselves, then blame it on ezjail and > finally complain about FreeBSD. Also I have to clean up my systems from > all the littering links called "log" pointing nowhere. > > If please a committer could take the five minutes to look into the bug > and fix the problem, he could save me and my users a lot of trouble and > time. Hmm... # Transitional symlink for old binaries Can we just remove this? Chris From owner-freebsd-rc@FreeBSD.ORG Fri Jan 20 10:41:40 2012 Return-Path: Delivered-To: freebsd-rc@FreeBSD.org Received: from mx2.freebsd.org (mx2.freebsd.org [IPv6:2001:4f8:fff6::35]) by hub.freebsd.org (Postfix) with ESMTP id 856A5106566C for ; Fri, 20 Jan 2012 10:41:40 +0000 (UTC) (envelope-from dougb@FreeBSD.org) Received: from 172-17-198-245.globalsuite.net (hub.freebsd.org [IPv6:2001:4f8:fff6::36]) by mx2.freebsd.org (Postfix) with ESMTP id 1A64114EF09 for ; Fri, 20 Jan 2012 10:41:38 +0000 (UTC) Date: Fri, 20 Jan 2012 02:41:38 -0800 (PST) From: Doug Barton To: freebsd-rc@FreeBSD.org Message-ID: User-Agent: Alpine 2.00 (BSF 1167 2008-08-23) X-message-flag: Outlook -- Not just for spreading viruses anymore! OpenPGP: id=1A1ABC84 Organization: http://SupersetSolutions.com/ MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: Subject: svn commit: r230374 - head/etc (fwd) X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 Jan 2012 10:41:40 -0000 FYI. This was discussed when the PR was submitted, and I didn't see any objection. Now that the release is done I'd like to see this get wider exposure. I don't plan to MFC this right away. I'm inclined to wait about a month before moving it to stable/9, then wait till after 8.3 to merge it to stable/8. All assuming that there are no problems of course. Doug -- It's always a long day; 86400 doesn't fit into a short. Breadth of IT experience, and depth of knowledge in the DNS. Yours for the right price. :) http://SupersetSolutions.com/ ---------- Forwarded message ---------- From: Doug Barton To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Date: Fri, 20 Jan 2012 02:31:27 Subject: svn commit: r230374 - head/etc Author: dougb Date: Fri Jan 20 10:31:27 2012 New Revision: 230374 URL: http://svn.freebsd.org/changeset/base/230374 Log: If we're booting there is no need to waste time determining if the service is running or not. PR: conf/150752 Submitted by: YIN Xiaofeng <75394094@qq.com> Modified: head/etc/rc.subr Modified: head/etc/rc.subr ============================================================================== --- head/etc/rc.subr Fri Jan 20 10:06:28 2012 (r230373) +++ head/etc/rc.subr Fri Jan 20 10:31:27 2012 (r230374) @@ -641,7 +641,7 @@ run_rc_command() fi fi - eval $_pidcmd # determine the pid if necessary + [ -z "$autoboot" ] && eval $_pidcmd # determine the pid if necessary for _elem in $_keywords; do if [ "$_elem" != "$rc_arg" ]; then From owner-freebsd-rc@FreeBSD.ORG Fri Jan 20 12:55:23 2012 Return-Path: Delivered-To: freebsd-rc@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id E5323106566C; Fri, 20 Jan 2012 12:55:23 +0000 (UTC) (envelope-from utisoft@gmail.com) Received: from mail-iy0-f182.google.com (mail-iy0-f182.google.com [209.85.210.182]) by mx1.freebsd.org (Postfix) with ESMTP id 9D3C68FC14; Fri, 20 Jan 2012 12:55:23 +0000 (UTC) Received: by iagz16 with SMTP id z16so1373397iag.13 for ; Fri, 20 Jan 2012 04:55:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=pZj+28aDE8G/4vsIO+byKQ5a0Xd4Ih7SKjPYGBg8oOg=; b=v5qUB5UbLSIrJp1RE/HbPhMyXdtq8neR2Hj4cBEW/6S6eZ31u6g8UVuqUo/xeqbjUF uDs4w45BUWOE5+Bofl3LbPNFtaLUA7RGuAb4ByO/9kjKD+QJFP+KZ4gE2KGY8NCb8DHB x76lHHRVAdY/5B3k55kenEsiFEttsTeb1lhW0= MIME-Version: 1.0 Received: by 10.50.180.233 with SMTP id dr9mr2543267igc.11.1327064122762; Fri, 20 Jan 2012 04:55:22 -0800 (PST) Received: by 10.231.207.7 with HTTP; Fri, 20 Jan 2012 04:55:22 -0800 (PST) Received: by 10.231.207.7 with HTTP; Fri, 20 Jan 2012 04:55:22 -0800 (PST) In-Reply-To: References: Date: Fri, 20 Jan 2012 12:55:22 +0000 Message-ID: From: Chris Rees To: Doug Barton Content-Type: text/plain; charset=ISO-8859-1 X-Content-Filtered-By: Mailman/MimeDel 2.1.5 Cc: freebsd-rc@freebsd.org Subject: Re: svn commit: r230374 - head/etc (fwd) X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 Jan 2012 12:55:24 -0000 On 20 Jan 2012 10:41, "Doug Barton" wrote: > > FYI. > > This was discussed when the PR was submitted, and I didn't see any objection. Now that the release is done I'd like to see this get wider exposure. > > I don't plan to MFC this right away. I'm inclined to wait about a month before moving it to stable/9, then wait till after 8.3 to merge it to stable/8. All assuming that there are no problems of course. > > > Doug > > -- > > It's always a long day; 86400 doesn't fit into a short. > > Breadth of IT experience, and depth of knowledge in the DNS. > Yours for the right price. :) http://SupersetSolutions.com/ > > > ---------- Forwarded message ---------- > From: Doug Barton > To: src-committers@freebsd.org, svn-src-all@freebsd.org, > svn-src-head@freebsd.org > Date: Fri, 20 Jan 2012 02:31:27 > Subject: svn commit: r230374 - head/etc > > Author: dougb > Date: Fri Jan 20 10:31:27 2012 > New Revision: 230374 > URL: http://svn.freebsd.org/changeset/base/230374 > > Log: > If we're booting there is no need to waste time determining if the service > is running or not. > > PR: conf/150752 > Submitted by: YIN Xiaofeng <75394094@qq.com> > > Modified: > head/etc/rc.subr > > Modified: head/etc/rc.subr > ============================================================================== > --- head/etc/rc.subr Fri Jan 20 10:06:28 2012 (r230373) > +++ head/etc/rc.subr Fri Jan 20 10:31:27 2012 (r230374) > @@ -641,7 +641,7 @@ run_rc_command() > fi > fi > > - eval $_pidcmd # determine the pid if necessary > + [ -z "$autoboot" ] && eval $_pidcmd # determine the pid if necessary > > for _elem in $_keywords; do > if [ "$_elem" != "$rc_arg" ]; then > Awesome- any data on speed? Chris From owner-freebsd-rc@FreeBSD.ORG Fri Jan 20 22:56:01 2012 Return-Path: Delivered-To: freebsd-rc@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 6A379106567A; Fri, 20 Jan 2012 22:56:01 +0000 (UTC) (envelope-from brooks@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 4048B8FC08; Fri, 20 Jan 2012 22:56:01 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id q0KMu1hQ012520; Fri, 20 Jan 2012 22:56:01 GMT (envelope-from brooks@freefall.freebsd.org) Received: (from brooks@localhost) by freefall.freebsd.org (8.14.5/8.14.5/Submit) id q0KMu0HV012514; Fri, 20 Jan 2012 22:56:00 GMT (envelope-from brooks) Date: Fri, 20 Jan 2012 22:56:00 GMT Message-Id: <201201202256.q0KMu0HV012514@freefall.freebsd.org> To: erdgeist@erdgeist.org, brooks@FreeBSD.org, freebsd-rc@FreeBSD.org, brooks@FreeBSD.org From: brooks@FreeBSD.org Cc: Subject: Re: conf/143084: [jail] [patch]: fix rc.d/jail creating stray softlinks X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 Jan 2012 22:56:01 -0000 Synopsis: [jail] [patch]: fix rc.d/jail creating stray softlinks State-Changed-From-To: open->patched State-Changed-By: brooks State-Changed-When: Fri Jan 20 22:55:30 UTC 2012 State-Changed-Why: Committed to head. Responsible-Changed-From-To: freebsd-rc->brooks Responsible-Changed-By: brooks Responsible-Changed-When: Fri Jan 20 22:55:30 UTC 2012 Responsible-Changed-Why: Committed to head. http://www.freebsd.org/cgi/query-pr.cgi?pr=143084 From owner-freebsd-rc@FreeBSD.ORG Fri Jan 20 23:43:02 2012 Return-Path: Delivered-To: freebsd-rc@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 4AD8E106564A; Fri, 20 Jan 2012 23:43:02 +0000 (UTC) (envelope-from brooks@lor.one-eyed-alien.net) Received: from lor.one-eyed-alien.net (lor.one-eyed-alien.net [69.66.77.232]) by mx1.freebsd.org (Postfix) with ESMTP id 9D9148FC0A; Fri, 20 Jan 2012 23:43:00 +0000 (UTC) Received: from lor.one-eyed-alien.net (localhost [127.0.0.1]) by lor.one-eyed-alien.net (8.14.4/8.14.4) with ESMTP id q0KN306u089274; Fri, 20 Jan 2012 17:03:00 -0600 (CST) (envelope-from brooks@lor.one-eyed-alien.net) Received: (from brooks@localhost) by lor.one-eyed-alien.net (8.14.4/8.14.4/Submit) id q0KN30oj089273; Fri, 20 Jan 2012 17:03:00 -0600 (CST) (envelope-from brooks) Date: Fri, 20 Jan 2012 17:03:00 -0600 From: Brooks Davis To: Dirk Engling Message-ID: <20120120230300.GE87357@lor.one-eyed-alien.net> References: <4F14F4FF.902@erdgeist.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="wTWi5aaYRw9ix9vO" Content-Disposition: inline In-Reply-To: <4F14F4FF.902@erdgeist.org> User-Agent: Mutt/1.5.21 (2010-09-15) Cc: freebsd-rc@freebsd.org Subject: Re: Bumping a pet bug X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 Jan 2012 23:43:02 -0000 --wTWi5aaYRw9ix9vO Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jan 17, 2012 at 05:11:43AM +0100, Dirk Engling wrote: > Dear rc team, >=20 > I know your time is precious, but there is an annoying bug in rc.d/jail > that keeps littering my (and my user's) servers with stray soft links > whenever we start jails. >=20 > I've described the bug two years ago here >=20 > http://www.FreeBSD.org/cgi/query-pr.cgi?pr=3Dconf/143084 >=20 > and even conveniently applied a simple and effective patch. >=20 > tl;dr: If rc.d/jail can not access $_devdir, a soft link is created in > ./log =3D> ../var/run/log no matter where I was. >=20 > Unfortunally I am still busy answering emails from users of ezjail who > first look for the problem with themselves, then blame it on ezjail and > finally complain about FreeBSD. Also I have to clean up my systems from > all the littering links called "log" pointing nowhere. >=20 > If please a committer could take the five minutes to look into the bug > and fix the problem, he could save me and my users a lot of trouble and > time. I've committed a similar fixed to head after talking it over a bit with Simon. We probably would be checking for success on mounting devfs and failed the jail entirely if it doesn't happen, but that's a bigger step and from your description it appears to me that might cause problems in some scenarios. -- Brooks P.S. rc.d/jail fixes are the sort of thing that will often need active followup when assigned to freebsd-rc. There's a note at the top that most of us take to mean "don't touch this file without so approval" which is a moderate psychological barrier to handling these PRs. --wTWi5aaYRw9ix9vO Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (FreeBSD) iD8DBQFPGfKjXY6L6fI4GtQRAkFwAJ9qp0TbImNQQdk0UqugD0Y5WojcWACfXRia 3S5UvLjsToJXndvoB5+hKcY= =X2Xb -----END PGP SIGNATURE----- --wTWi5aaYRw9ix9vO-- From owner-freebsd-rc@FreeBSD.ORG Sat Jan 21 22:43:10 2012 Return-Path: Delivered-To: freebsd-rc@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 7FE94106564A; Sat, 21 Jan 2012 22:43:10 +0000 (UTC) (envelope-from simon@FreeBSD.org) Received: from emx.nitro.dk (emx.nitro.dk [IPv6:2a01:4f8:120:7384::102]) by mx1.freebsd.org (Postfix) with ESMTP id 145778FC13; Sat, 21 Jan 2012 22:43:10 +0000 (UTC) Received: from mailscan.leto.nitro.dk (mailscan.leto.nitro.dk [127.0.1.4]) by emx.nitro.dk (Postfix) with ESMTP id 2D3CF1B1DD6; Sat, 21 Jan 2012 22:43:09 +0000 (UTC) Received: from emx.nitro.dk ([127.0.1.2]) by mailscan.leto.nitro.dk (mailscan.leto.nitro.dk [127.0.1.4]) (amavisd-new, port 10024) with LMTP id ANf6knWGuK4j; Sat, 21 Jan 2012 22:43:06 +0000 (UTC) Received: from webmail.nitro.dk (webmail.nitro.dk [127.0.1.8]) by emx.nitro.dk (Postfix) with ESMTP id 8A1E71B1DC9; Sat, 21 Jan 2012 22:43:06 +0000 (UTC) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Date: Sat, 21 Jan 2012 23:43:06 +0100 From: "Simon L. B. Nielsen" To: Brooks Davis In-Reply-To: <20120120230300.GE87357@lor.one-eyed-alien.net> References: <4F14F4FF.902@erdgeist.org> <20120120230300.GE87357@lor.one-eyed-alien.net> Message-ID: X-Sender: simon@FreeBSD.org User-Agent: Roundcube Webmail/42.7 Cc: freebsd-rc@freebsd.org Subject: Re: Bumping a pet bug X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 21 Jan 2012 22:43:10 -0000 On Fri, 20 Jan 2012 17:03:00 -0600, Brooks Davis wrote: > On Tue, Jan 17, 2012 at 05:11:43AM +0100, Dirk Engling wrote: >> Dear rc team, >> >> I know your time is precious, but there is an annoying bug in >> rc.d/jail >> that keeps littering my (and my user's) servers with stray soft >> links >> whenever we start jails. >> >> I've described the bug two years ago here >> >> http://www.FreeBSD.org/cgi/query-pr.cgi?pr=conf/143084 >> >> and even conveniently applied a simple and effective patch. >> >> tl;dr: If rc.d/jail can not access $_devdir, a soft link is created >> in >> ./log => ../var/run/log no matter where I was. >> >> Unfortunally I am still busy answering emails from users of ezjail >> who >> first look for the problem with themselves, then blame it on ezjail >> and >> finally complain about FreeBSD. Also I have to clean up my systems >> from >> all the littering links called "log" pointing nowhere. >> >> If please a committer could take the five minutes to look into the >> bug >> and fix the problem, he could save me and my users a lot of trouble >> and >> time. > > I've committed a similar fixed to head after talking it over a bit > with > Simon. We probably would be checking for success on mounting devfs > and > failed the jail entirely if it doesn't happen, but that's a bigger > step > and from your description it appears to me that might cause problems > in > some scenarios. I think in most cases if devfs mount fails you will likely not end up with a jail where you can do much... rather many things expect /dev/null etc. It is possible to just disable the devfs mount completely for a jail if you want the jail to start up anyway without devfs so I think it would be OK to simply skip the jail if we cannot mount devfs - and complain loudly. Anybody have any cases where this would be a problem? > P.S. rc.d/jail fixes are the sort of thing that will often need > active > followup when assigned to freebsd-rc. There's a note at the top that > most of us take to mean "don't touch this file without so approval" > which is a moderate psychological barrier to handling these PRs. Yes, that is unfortunate but it's easy to introduce serious security issues if people are not aware of the quirks related to handling untrusted file system data, so I still think the warning should be there... -- Simon L. B. Nielsen