From owner-freebsd-rc@FreeBSD.ORG Mon Mar 26 11:07:12 2012 Return-Path: Delivered-To: freebsd-rc@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id D79121065678 for ; Mon, 26 Mar 2012 11:07:12 +0000 (UTC) (envelope-from owner-bugmaster@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id C0CD98FC31 for ; Mon, 26 Mar 2012 11:07:12 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id q2QB7Co3018383 for ; Mon, 26 Mar 2012 11:07:12 GMT (envelope-from owner-bugmaster@FreeBSD.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.5/8.14.5/Submit) id q2QB7CbU018381 for freebsd-rc@FreeBSD.org; Mon, 26 Mar 2012 11:07:12 GMT (envelope-from owner-bugmaster@FreeBSD.org) Date: Mon, 26 Mar 2012 11:07:12 GMT Message-Id: <201203261107.q2QB7CbU018381@freefall.freebsd.org> X-Authentication-Warning: freefall.freebsd.org: gnats set sender to owner-bugmaster@FreeBSD.org using -f From: FreeBSD bugmaster To: freebsd-rc@FreeBSD.org Cc: Subject: Current problem reports assigned to freebsd-rc@FreeBSD.org X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 26 Mar 2012 11:07:12 -0000 Note: to view an individual PR, use: http://www.freebsd.org/cgi/query-pr.cgi?pr=(number). The following is a listing of current problems submitted by FreeBSD users. These represent problem reports covering all versions including experimental development code and obsolete releases. S Tracker Resp. Description -------------------------------------------------------------------------------- o kern/165769 rc [rc][jai][ipv6] IPv6 Initialization on external iface o bin/165477 rc [rc] dhclient is run twice o conf/164393 rc [rc.d] restarting netif with static addresses doesn't o conf/163508 rc [rc.subr] [patch] Add "enable" and "disable" commands o conf/163488 rc Confusing explanation in defaults/rc.conf o conf/163321 rc [rc.conf] [patch] allow _fib syntax in rc.conf o conf/162642 rc .sh scripts in /usr/local/etc/rc.d get executed, not s p kern/161899 rc [route] ntpd(8): Repeating RTM_MISS packets causing hi o conf/161107 rc [rc] stop_boot in mountcritlocal usage is incorrect. o conf/160403 rc [rc] [patch] concurrently running rc-scripts during bo o conf/160240 rc rc.d/mdconfig and mdconfig2 should autoset $_type to v o conf/159846 rc [rc.conf] routing_stop_inet6() logic doesn't handle ip o conf/158557 rc [patch] /etc/rc.d/pf broken messages o conf/158127 rc [patch] remount_optional option in rc.initdiskless doe o conf/153666 rc [rc.d][patch] mount filesystems from fstab over zfs da o conf/153200 rc post-boot /etc/rc.d/network_ipv6 start can miss neighb o conf/153123 rc [rc] [patch] add gsched rc file to automatically inser o conf/150474 rc [patch] rc.d/accounting: Add ability to set location o o conf/149867 rc [PATCH] rc.d script to manage multiple FIBS (kern opti o conf/149831 rc [PATCH] add support to /etc/rc.d/jail for delegating Z o conf/148656 rc rc.firewall(8): {oip} and {iip} variables in rc.firewa o conf/147685 rc [rc.d] [patch] new feature for /etc/rc.d/fsck o conf/147444 rc [rc.d] [patch] /etc/rc.d/zfs stop not called on reboot o conf/146053 rc [patch] [request] shutdown of jails breaks inter-jail o conf/145445 rc [rc.d] error in /etc/rc.d/jail (bad logic) o conf/145399 rc [patch] rc.d scripts are unable to start/stop programs o conf/145009 rc [patch] rc.subr(8): rc.conf should allow mac label con o conf/144213 rc [rc.d] [patch] Disappearing zvols on reboot o conf/143637 rc [patch] ntpdate(8) support for ntp-servers supplied by o conf/143085 rc [patch] ftp-proxy(8) rc(8) with multiple instances o conf/142973 rc [jail] [patch] Strange counter init value in jail rc o conf/142434 rc [patch] Add cpuset(1) support to rc.subr(8) o conf/142304 rc rc.conf(5): mdconfig and mdconfig2 rc.d scripts lack e o conf/141909 rc rc.subr(8): [patch] add rc.conf.d support to /usr/loca o conf/141907 rc [rc.d] Bug if mtu (maybe others?) is set as first argu o conf/141678 rc [patch] A minor enhancement to how /etc/rc.d/jail dete o conf/141275 rc [request] dhclient(8) rc script should print something o conf/140440 rc [patch] allow local command files in rc.{suspend,resum o conf/140261 rc [patch] Improve flexibility of mdconfig2 startup scrip o conf/138208 rc [rc.d] [patch] Making rc.firewall (workstation) IPv6 a o conf/137629 rc [rc.d] background_dhclient rc.conf option causing doub o conf/137470 rc [PATCH] /etc/rc.d/mdconfig2 : prioritize cli parameter o conf/137271 rc [rc.d] Cannot update /etc/host.conf when root filesyst o conf/136624 rc [rc.d] sysctl variables for ipnat are not applied on b o conf/135338 rc [rc.d] pf startup order seems broken [regression] o conf/134918 rc [patch] rc.subr fails to detect perl daemons o conf/134660 rc [patch] rc-script for initializing ng_netflow+ng_ipfw o conf/134333 rc PPP configuration problem in the rc.d scripts in combi o conf/134006 rc [patch] Unload console screensaver kernel modules if s o conf/133890 rc [patch] sshd(8): add multiple profiles to the rc.d scr o conf/132483 rc rc.subr(8) [patch] setfib(1) support for rc.subr o conf/128299 rc [patch] /etc/rc.d/geli does not mount partitions using o conf/126392 rc [patch] rc.conf ifconfig_xx keywords cannot be escaped p bin/126324 rc [patch] rc.d/tmp: Prevent mounting /tmp in second tim o conf/124747 rc [patch] savecore can't create dump from encrypted swap o conf/124248 rc [jail] [patch] add support for nice value for rc.d/jai o conf/123734 rc [patch] Chipset VIA CX700 requires extra initializatio o conf/123222 rc [patch] Add rtprio(1)/idprio(1) support to rc.subr(8). o conf/123119 rc [patch] rc script for ipfw does not handle IPv6 o conf/122968 rc [rc.d] /etc/rc.d/addswap: md swapfile multiplication a o conf/122477 rc [patch] /etc/rc.d/mdconfig and mdconfig2 are ignoring o conf/122170 rc [patch] [request] New feature: notify admin via page o o kern/121566 rc [nfs] [request] [patch] ethernet iface should be broug o conf/120406 rc [devd] [patch] Handle newly attached pcm devices (eg. o conf/119874 rc [patch] "/etc/rc.d/pf reload" fails if there are macro o conf/119076 rc [patch] [rc.d] /etc/rc.d/netif tries to remove alias a o bin/118325 rc [patch] [request] new periodic script to test statuses o conf/118255 rc savecore never finding kernel core dumps (rcorder prob o conf/117935 rc [patch] ppp fails to start at boot because of missing o conf/113915 rc [patch] ndis wireless driver fails to associate when i o conf/109980 rc /etc/rc.d/netif restart doesn't destroy cloned_interfa o conf/108589 rc rtsol(8) fails due to default ipfw rules o conf/106009 rc [ppp] [patch] [request] Fix pppoed startup script to p o conf/105689 rc [ppp] [request] syslogd starts too late at boot o conf/105145 rc [ppp] [patch] [request] add redial function to rc.d/pp o conf/104549 rc [patch] rc.d/nfsd needs special _find_processes functi o conf/102700 rc [geli] [patch] Add encrypted /tmp support to GELI/GBDE o conf/99721 rc [patch] /etc/rc.initdiskless problem copy dotfile in s o conf/99444 rc [patch] Enhancement: rc.subr could easily support star o conf/96343 rc [patch] rc.d order change to start inet6 before pf o conf/93815 rc [patch] Adds in the ability to save ipfw rules to rc.d o conf/92523 rc [patch] allow rc scripts to kill process after a timeo o conf/89870 rc [patch] [request] make netif verbose rc.conf toggle o conf/88913 rc [patch] wrapper support for rc.subr o conf/85819 rc [patch] script allowing multiuser mode in spite of fsc o kern/81006 rc ipnat not working with tunnel interfaces on startup o conf/77663 rc Suggestion: add /etc/rc.d/addnetswap after addcritremo o conf/73677 rc [patch] add support for powernow states to power_profi o conf/58939 rc [patch] dumb little hack for /etc/rc.firewall{,6} o conf/56934 rc [patch] rc.firewall rules for natd expect an interface o conf/44170 rc [patch] Add ability to run multiple pppoed(8) on start 91 problems total. From owner-freebsd-rc@FreeBSD.ORG Tue Mar 27 17:34:34 2012 Return-Path: Delivered-To: rc@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 6C290106564A; Tue, 27 Mar 2012 17:34:34 +0000 (UTC) (envelope-from jhelfman@experts-exchange.com) Received: from mail.dw.redsrci.com (mail.pub.dw.redsrci.com [72.29.183.251]) by mx1.freebsd.org (Postfix) with ESMTP id 496A88FC08; Tue, 27 Mar 2012 17:34:33 +0000 (UTC) Received: from mail.dw.redsrci.com (localhost [127.0.0.1]) by mail.dw.redsrci.com (Postfix) with ESMTP id 494946F30DA; Tue, 27 Mar 2012 10:26:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d= experts-exchange.com; h=message-id:date:date:from:from:subject :subject:received:received:received; s=ee; t=1332869200; x= 1334683600; bh=pVZprJB6BcYDMr6P4qd8AdoXqMpGOEf2bv4nhrCPpJg=; b=C a86PekHKHsfFJj3VD0blWD2C5L0LB1PpU7L9iZeqTbH/yC6Wq3eUi4+dSqpaUI8t /nkk+7msE0Uhj3KqTo1I1Wvuj9A2UdN8BrDz33xdeyutvMku8Em9sq5r205Tl2+R CjfynabPF0b/OoH3gbuxMux3atP3DV86R2rN0TCOlQ= X-Virus-Scanned: amavisd-new at experts-exchange.com Received: from mail.dw.redsrci.com ([127.0.0.1]) by mail.dw.redsrci.com (mail.dw.redsrci.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id y6bGYmgp1k-9; Tue, 27 Mar 2012 10:26:40 -0700 (PDT) Received: from experts-exchange.com (unknown [192.168.103.120]) by mail.dw.redsrci.com (Postfix) with SMTP id 21E466F30D3; Tue, 27 Mar 2012 10:26:40 -0700 (PDT) Received: (nullmailer pid 86669 invoked by uid 1001); Tue, 27 Mar 2012 17:25:46 -0000 To: FreeBSD-gnats-submit@freebsd.org From: Jason Helfman X-send-pr-version: 3.113 X-GNATS-Notify: Date: Tue, 27 Mar 2012 10:25:46 -0700 Message-Id: <1332869146.439481.86668.nullmailer@experts-exchange.com> Cc: 5u623l20@gmail.com, rc@freebsd.org Subject: [PATCH] www/resin3: reorganize rc script X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 Mar 2012 17:34:34 -0000 >Submitter-Id: current-users >Originator: Jason Helfman >Organization: >Confidential: no >Synopsis: [PATCH] www/resin3: reorganize rc script >Severity: non-critical >Priority: low >Category: ports >Class: change-request >Release: FreeBSD 8.2-RELEASE amd64 >Environment: System: FreeBSD dormouse.experts-exchange.com 8.2-RELEASE FreeBSD 8.2-RELEASE #0: Thu Feb 17 02:41:51 UTC 2011 >Description: Modifications were requested to the resin rc script from dougb@ I am putting this pr in for approval and review Added file(s): - files/resin3.in Removed file(s): - files/resin3.sh.in Port maintainer (5u623l20@gmail.com) is cc'd. Generated with FreeBSD Port Tools 0.99_5 (mode: change, diff: CVS) >How-To-Repeat: >Fix: --- resin-3.1.12_1.patch begins here --- Index: Makefile =================================================================== RCS file: /home/pcvs/ports/www/resin3/Makefile,v retrieving revision 1.46 diff -u -r1.46 Makefile --- Makefile 14 Mar 2012 18:09:37 -0000 1.46 +++ Makefile 27 Mar 2012 17:24:38 -0000 @@ -7,6 +7,7 @@ PORTNAME= resin PORTVERSION= 3.1.12 +PORTREVISION= 1 CATEGORIES= www java MASTER_SITES= http://www.caucho.com/download/ @@ -44,7 +45,7 @@ # Other settings APXS?= ${LOCALBASE}/sbin/apxs SUB_FILES= pkg-message resin3ctl -USE_RC_SUBR= resin3.sh +USE_RC_SUBR= resin3 .include Index: files/resin3.in =================================================================== RCS file: files/resin3.in diff -N files/resin3.in --- /dev/null 1 Jan 1970 00:00:00 -0000 +++ files/resin3.in 27 Mar 2012 17:24:38 -0000 @@ -0,0 +1,43 @@ +#!/bin/sh +# +# $FreeBSD: ports/www/resin3/files/resin3.sh.in,v 1.1 2012/03/13 16:29:23 jgh Exp $ +# + +# PROVIDE: %%APP_NAME%% +# REQUIRE: LOGIN NETWORKING SERVERS +# BEFORE: DAEMON +# KEYWORD: shutdown + +# +# Add the following line to /etc/rc.conf to enable %%APP_NAME%%: +# +# %%APP_NAME%%_enable="YES" +# + + +%%APP_NAME%%_enable=${%%APP_NAME%%_enable:-"NO"} +%%APP_NAME%%_user=${%%APP_NAME%%_user:-"%%USERS%%"} +%%APP_NAME%%_group=${%%APP_NAME%%_group:-"%%GROUPS%%"} + +. /etc/rc.subr + +name=%%APP_NAME%% +rcvar=%%APP_NAME%%_enable + +load_rc_config ${name} + +command="%%PREFIX%%/sbin/%%APP_NAME%%ctl" +command_args="start" +pidfile=%%PID_FILE%% + +if test -n "${%%APP_NAME%%_java_version}" ; then + JAVA_HOME=$(JAVA_VERSION="${%%APP_NAME%%_java_version}" JAVAVM_DRYRUN=1 %%LOCALBASE%%/bin/java | grep JAVA_HOME | cut -d= -f2) + procname=$(JAVA_VERSION="${%%APP_NAME%%_java_version}" JAVAVM_DRYRUN=1 %%LOCALBASE%%/bin/java | grep JAVAVM_PROG | cut -d= -f2) +else + JAVA_HOME=$(JAVAVM_DRYRUN=1 %%LOCALBASE%%/bin/java | grep JAVA_HOME | cut -d= -f2) + procname=$(JAVAVM_DRYRUN=1 %%LOCALBASE%%/bin/java | grep JAVAVM_PROG | cut -d= -f2) +fi + +export JAVA_HOME + +run_rc_command "$1" Index: files/resin3.sh.in =================================================================== RCS file: files/resin3.sh.in diff -N files/resin3.sh.in --- files/resin3.sh.in 13 Mar 2012 16:29:23 -0000 1.1 +++ /dev/null 1 Jan 1970 00:00:00 -0000 @@ -1,43 +0,0 @@ -#!/bin/sh -# -# $FreeBSD: ports/www/resin3/files/resin3.sh.in,v 1.1 2012/03/13 16:29:23 jgh Exp $ -# - -# PROVIDE: %%APP_NAME%% -# REQUIRE: LOGIN -# KEYWORD: shutdown - -# -# Add the following line to /etc/rc.conf to enable %%APP_NAME%%: -# -# %%APP_NAME%%_enable="YES" -# - -. /etc/rc.subr - -name=%%APP_NAME%% -rcvar=%%APP_NAME%%_enable - -command="%%PREFIX%%/sbin/%%APP_NAME%%ctl" -command_args="start" -pidfile=%%PID_FILE%% - -# set defaults - -%%APP_NAME%%_enable=${%%APP_NAME%%_enable:-"NO"} -%%APP_NAME%%_user=${%%APP_NAME%%_user:-"%%USERS%%"} -%%APP_NAME%%_group=${%%APP_NAME%%_group:-"%%GROUPS%%"} - -load_rc_config ${name} - -if test -n "${%%APP_NAME%%_java_version}" ; then - JAVA_HOME=$(JAVA_VERSION="${%%APP_NAME%%_java_version}" JAVAVM_DRYRUN=1 %%LOCALBASE%%/bin/java | grep JAVA_HOME | cut -d= -f2) - procname=$(JAVA_VERSION="${%%APP_NAME%%_java_version}" JAVAVM_DRYRUN=1 %%LOCALBASE%%/bin/java | grep JAVAVM_PROG | cut -d= -f2) -else - JAVA_HOME=$(JAVAVM_DRYRUN=1 %%LOCALBASE%%/bin/java | grep JAVA_HOME | cut -d= -f2) - procname=$(JAVAVM_DRYRUN=1 %%LOCALBASE%%/bin/java | grep JAVAVM_PROG | cut -d= -f2) -fi - -export JAVA_HOME - -run_rc_command "$1" --- resin-3.1.12_1.patch ends here --- From owner-freebsd-rc@FreeBSD.ORG Tue Mar 27 18:10:59 2012 Return-Path: Delivered-To: rc@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id A5FBB106566B; Tue, 27 Mar 2012 18:10:59 +0000 (UTC) (envelope-from 5u623l20@gmail.com) Received: from mail-vx0-f182.google.com (mail-vx0-f182.google.com [209.85.220.182]) by mx1.freebsd.org (Postfix) with ESMTP id 343238FC08; Tue, 27 Mar 2012 18:10:59 +0000 (UTC) Received: by vcmm1 with SMTP id m1so208511vcm.13 for ; Tue, 27 Mar 2012 11:10:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=X/lgrleohDPRC9+cwhbT9Yqx6kEfox7STuwbrb1owag=; b=rHWauhxUkLZtV6rlYKj0zzzONRUZ+v+oD6NV8pDWhY4S2gIQ+SqEhfsgSxh10BHnW0 9YVakP1G15TFrr1e5um7QekKjahKfeR3rF0aGsvHT5PiwrYr6FCt84Xu54b4GgBAFAD9 OeTbNm86BuzVaKBT8A8SID4RPzO9oO/hjyNDfsCIMWFz74j0QvqJEGfr19kHjB4ZGRWK jIBhSIBeCY0zbRLmyUAzsunXU538VBNNQU8pTFo3XnSfGz5yGyTMOqaJTIhr3OsyDNCm qRG1jXLezvWuCEAqsLmvzgNDKU9XtSlYwa9aztqnJzwAT0vCBAqR9F9Si3WzZnFhEaPc ZRtQ== MIME-Version: 1.0 Received: by 10.52.38.167 with SMTP id h7mr10411728vdk.109.1332871858662; Tue, 27 Mar 2012 11:10:58 -0700 (PDT) Received: by 10.220.181.9 with HTTP; Tue, 27 Mar 2012 11:10:58 -0700 (PDT) In-Reply-To: <1332869146.439481.86668.nullmailer@experts-exchange.com> References: <1332869146.439481.86668.nullmailer@experts-exchange.com> Date: Wed, 28 Mar 2012 00:10:58 +0600 Message-ID: From: Muhammad Moinur Rahman <5u623l20@gmail.com> To: Jason Helfman Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.5 Cc: rc@freebsd.org, FreeBSD-gnats-submit@freebsd.org Subject: Re: [PATCH] www/resin3: reorganize rc script X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 Mar 2012 18:10:59 -0000 Hi Jason, Good to see you again. :D As far as I remember we got rid off the users problem running the application with www user and group. In that case don't you think we can get rid off the following variables from the rc file : +%%APP_NAME%%_user=${%%APP_NAME%%_user:-"%%USERS%%"} +%%APP_NAME%%_group=${%%APP_NAME%%_group:-"%%GROUPS%%"} Let me know your opinion please. Regards, Muhammad On Tue, Mar 27, 2012 at 11:25 PM, Jason Helfman wrote: > > >Submitter-Id: current-users > >Originator: Jason Helfman > >Organization: > >Confidential: no > >Synopsis: [PATCH] www/resin3: reorganize rc script > >Severity: non-critical > >Priority: low > >Category: ports > >Class: change-request > >Release: FreeBSD 8.2-RELEASE amd64 > >Environment: > System: FreeBSD dormouse.experts-exchange.com 8.2-RELEASE FreeBSD > 8.2-RELEASE #0: Thu Feb 17 02:41:51 UTC 2011 > >Description: > Modifications were requested to the resin rc script from dougb@ > I am putting this pr in for approval and review > > Added file(s): > - files/resin3.in > > Removed file(s): > - files/resin3.sh.in > > Port maintainer (5u623l20@gmail.com) is cc'd. > > Generated with FreeBSD Port Tools 0.99_5 (mode: change, diff: CVS) > >How-To-Repeat: > >Fix: > > --- resin-3.1.12_1.patch begins here --- > Index: Makefile > =================================================================== > RCS file: /home/pcvs/ports/www/resin3/Makefile,v > retrieving revision 1.46 > diff -u -r1.46 Makefile > --- Makefile 14 Mar 2012 18:09:37 -0000 1.46 > +++ Makefile 27 Mar 2012 17:24:38 -0000 > @@ -7,6 +7,7 @@ > > PORTNAME= resin > PORTVERSION= 3.1.12 > +PORTREVISION= 1 > CATEGORIES= www java > MASTER_SITES= http://www.caucho.com/download/ > > @@ -44,7 +45,7 @@ > # Other settings > APXS?= ${LOCALBASE}/sbin/apxs > SUB_FILES= pkg-message resin3ctl > -USE_RC_SUBR= resin3.sh > +USE_RC_SUBR= resin3 > > .include > > Index: files/resin3.in > =================================================================== > RCS file: files/resin3.in > diff -N files/resin3.in > --- /dev/null 1 Jan 1970 00:00:00 -0000 > +++ files/resin3.in 27 Mar 2012 17:24:38 -0000 > @@ -0,0 +1,43 @@ > +#!/bin/sh > +# > +# $FreeBSD: ports/www/resin3/files/resin3.sh.in,v 1.1 2012/03/13 > 16:29:23 jgh Exp $ > +# > + > +# PROVIDE: %%APP_NAME%% > +# REQUIRE: LOGIN NETWORKING SERVERS > +# BEFORE: DAEMON > +# KEYWORD: shutdown > + > +# > +# Add the following line to /etc/rc.conf to enable %%APP_NAME%%: > +# > +# %%APP_NAME%%_enable="YES" > +# > + > + > +%%APP_NAME%%_enable=${%%APP_NAME%%_enable:-"NO"} > +%%APP_NAME%%_user=${%%APP_NAME%%_user:-"%%USERS%%"} > +%%APP_NAME%%_group=${%%APP_NAME%%_group:-"%%GROUPS%%"} > + > +. /etc/rc.subr > + > +name=%%APP_NAME%% > +rcvar=%%APP_NAME%%_enable > + > +load_rc_config ${name} > + > +command="%%PREFIX%%/sbin/%%APP_NAME%%ctl" > +command_args="start" > +pidfile=%%PID_FILE%% > + > +if test -n "${%%APP_NAME%%_java_version}" ; then > + JAVA_HOME=$(JAVA_VERSION="${%%APP_NAME%%_java_version}" > JAVAVM_DRYRUN=1 %%LOCALBASE%%/bin/java | grep JAVA_HOME | cut -d= -f2) > + procname=$(JAVA_VERSION="${%%APP_NAME%%_java_version}" > JAVAVM_DRYRUN=1 %%LOCALBASE%%/bin/java | grep JAVAVM_PROG | cut -d= -f2) > +else > + JAVA_HOME=$(JAVAVM_DRYRUN=1 %%LOCALBASE%%/bin/java | grep JAVA_HOME | > cut -d= -f2) > + procname=$(JAVAVM_DRYRUN=1 %%LOCALBASE%%/bin/java | grep JAVAVM_PROG > | cut -d= -f2) > +fi > + > +export JAVA_HOME > + > +run_rc_command "$1" > Index: files/resin3.sh.in > =================================================================== > RCS file: files/resin3.sh.in > diff -N files/resin3.sh.in > --- files/resin3.sh.in 13 Mar 2012 16:29:23 -0000 1.1 > +++ /dev/null 1 Jan 1970 00:00:00 -0000 > @@ -1,43 +0,0 @@ > -#!/bin/sh > -# > -# $FreeBSD: ports/www/resin3/files/resin3.sh.in,v 1.1 2012/03/13 > 16:29:23 jgh Exp $ > -# > - > -# PROVIDE: %%APP_NAME%% > -# REQUIRE: LOGIN > -# KEYWORD: shutdown > - > -# > -# Add the following line to /etc/rc.conf to enable %%APP_NAME%%: > -# > -# %%APP_NAME%%_enable="YES" > -# > - > -. /etc/rc.subr > - > -name=%%APP_NAME%% > -rcvar=%%APP_NAME%%_enable > - > -command="%%PREFIX%%/sbin/%%APP_NAME%%ctl" > -command_args="start" > -pidfile=%%PID_FILE%% > - > -# set defaults > - > -%%APP_NAME%%_enable=${%%APP_NAME%%_enable:-"NO"} > -%%APP_NAME%%_user=${%%APP_NAME%%_user:-"%%USERS%%"} > -%%APP_NAME%%_group=${%%APP_NAME%%_group:-"%%GROUPS%%"} > - > -load_rc_config ${name} > - > -if test -n "${%%APP_NAME%%_java_version}" ; then > - JAVA_HOME=$(JAVA_VERSION="${%%APP_NAME%%_java_version}" > JAVAVM_DRYRUN=1 %%LOCALBASE%%/bin/java | grep JAVA_HOME | cut -d= -f2) > - procname=$(JAVA_VERSION="${%%APP_NAME%%_java_version}" > JAVAVM_DRYRUN=1 %%LOCALBASE%%/bin/java | grep JAVAVM_PROG | cut -d= -f2) > -else > - JAVA_HOME=$(JAVAVM_DRYRUN=1 %%LOCALBASE%%/bin/java | grep JAVA_HOME | > cut -d= -f2) > - procname=$(JAVAVM_DRYRUN=1 %%LOCALBASE%%/bin/java | grep JAVAVM_PROG > | cut -d= -f2) > -fi > - > -export JAVA_HOME > - > -run_rc_command "$1" > --- resin-3.1.12_1.patch ends here --- > > From owner-freebsd-rc@FreeBSD.ORG Tue Mar 27 18:19:58 2012 Return-Path: Delivered-To: rc@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 08DD7106566B for ; Tue, 27 Mar 2012 18:19:58 +0000 (UTC) (envelope-from bsd-src@helfman.org) Received: from mail-gx0-f182.google.com (mail-gx0-f182.google.com [209.85.161.182]) by mx1.freebsd.org (Postfix) with ESMTP id A85D58FC12 for ; Tue, 27 Mar 2012 18:19:57 +0000 (UTC) Received: by ggnk4 with SMTP id k4so244055ggn.13 for ; Tue, 27 Mar 2012 11:19:57 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:x-operating-system :organization:x-living-the-dream:x-pgp-fingerprint:x-pgp-key :user-agent:x-gm-message-state; bh=c9jBs6XxLfyx0QN/LShQb248lOe50K3LIluEyILQBs8=; b=IDRWxOkIqexzEeHEPpKsqFs55OiNSBNehnttrIksfAErlEU9pZa584q8Pny3zm2Ify bBuajW2UTnbNWgyPCxkAa7CIp7A8ldooxX9m7pKZYSy+SZ9xK1zEPtxJf4LkFwz1sxTD i1KDQ7QMfS9Rw0VC2h2LSrfm0W/s1N7SLTDeappC0YYA6RPq0mm7TvutvmtBB/FnxTWD o0QxOa9PWKl4+ItN70103qAIr/t0pjJ4abZ1yXGEaM7AutUGEskaFY8kMziShvZ7r1PK pdExXS1rtmus1NYLa8hzqp1ZgyOQ2o2RgvkVE65TAStAQVktivnoz4nNOamJUIqI+qIT qBIQ== Received: by 10.60.0.196 with SMTP id 4mr33792688oeg.0.1332872396913; Tue, 27 Mar 2012 11:19:56 -0700 (PDT) Received: from dormouse.experts-exchange.com ([72.29.164.238]) by mx.google.com with ESMTPS id c6sm432075oec.13.2012.03.27.11.19.54 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 27 Mar 2012 11:19:55 -0700 (PDT) Sender: Jason Helfman Date: Tue, 27 Mar 2012 11:18:59 -0700 From: Jason Helfman To: Muhammad Moinur Rahman <5u623l20@gmail.com> Message-ID: <20120327181859.GD82277@dormouse.experts-exchange.com> References: <1332869146.439481.86668.nullmailer@experts-exchange.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="2oS5YaxWCcQjTEyO" Content-Disposition: inline In-Reply-To: X-Operating-System: FreeBSD 8.2-RELEASE amd64 Organization: The FreeBSD Project, http://www.freebsd.org X-Living-The-Dream: I love the SLO Life! X-PGP-FingerPrint: 8E0D C457 9A0F C91C 23F3 0454 2059 9A63 4150 D3DC X-PGP-Key: http://people.freebsd.org/~jgh/jgh.asc User-Agent: Mutt/1.5.21 (2010-09-15) X-Gm-Message-State: ALoCoQkkgNIglnTOQaYuYbfPV9ZAr2iCXTM9+XC8Fgq+PhO5FS0DjCxLKOTIJmlC89wJmyNgQKhj Cc: rc@freebsd.org, bug-followup@freebsd.org Subject: Re: [PATCH] www/resin3: reorganize rc script X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 Mar 2012 18:19:58 -0000 --2oS5YaxWCcQjTEyO Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline On Wed, Mar 28, 2012 at 12:10:58AM +0600, Muhammad Moinur Rahman thus spake: >Hi Jason, > >Good to see you again. :D Good to see you too :) > >As far as I remember we got rid off the users problem running the >application with www user and group. In that case don't you think we can >get rid off the following variables from the rc file : > >+%%APP_NAME%%_user=${%%APP_NAME%%_user:-"%%USERS%%"} >+%%APP_NAME%%_group=${%%APP_NAME%%_group:-"%%GROUPS%%"} > >Let me know your opinion please. > >Regards, >Muhammad We didn't get rid of the USERS/GROUPS usage, though. We are using both of these, but using the www user and www group. Since it isn't configurable now, though, you have a a point, so it should at least be non-configurable in the rc script. Included is an updated patch. -jgh -- Jason Helfman | FreeBSD Committer jgh@FreeBSD.org | http://people.freebsd.org/~jgh --2oS5YaxWCcQjTEyO Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename="newpatch.txt" Index: Makefile =================================================================== RCS file: /home/pcvs/ports/www/resin3/Makefile,v retrieving revision 1.46 diff -u -r1.46 Makefile --- Makefile 14 Mar 2012 18:09:37 -0000 1.46 +++ Makefile 27 Mar 2012 18:17:47 -0000 @@ -7,6 +7,7 @@ PORTNAME= resin PORTVERSION= 3.1.12 +PORTREVISION= 1 CATEGORIES= www java MASTER_SITES= http://www.caucho.com/download/ @@ -44,7 +45,7 @@ # Other settings APXS?= ${LOCALBASE}/sbin/apxs SUB_FILES= pkg-message resin3ctl -USE_RC_SUBR= resin3.sh +USE_RC_SUBR= resin3 .include Index: files/resin3.in =================================================================== RCS file: files/resin3.in diff -N files/resin3.in --- /dev/null 1 Jan 1970 00:00:00 -0000 +++ files/resin3.in 27 Mar 2012 18:17:47 -0000 @@ -0,0 +1,43 @@ +#!/bin/sh +# +# $FreeBSD: ports/www/resin3/files/resin3.sh.in,v 1.1 2012/03/13 16:29:23 jgh Exp $ +# + +# PROVIDE: %%APP_NAME%% +# REQUIRE: LOGIN NETWORKING SERVERS +# BEFORE: DAEMON +# KEYWORD: shutdown + +# +# Add the following line to /etc/rc.conf to enable %%APP_NAME%%: +# +# %%APP_NAME%%_enable="YES" +# + + +%%APP_NAME%%_enable=${%%APP_NAME%%_enable:-"NO"} +%%APP_NAME%%_user=${%%APP_NAME%%_user:"www"} +%%APP_NAME%%_group=${%%APP_NAME%%_group:"www"} + +. /etc/rc.subr + +name=%%APP_NAME%% +rcvar=%%APP_NAME%%_enable + +load_rc_config ${name} + +command="%%PREFIX%%/sbin/%%APP_NAME%%ctl" +command_args="start" +pidfile=%%PID_FILE%% + +if test -n "${%%APP_NAME%%_java_version}" ; then + JAVA_HOME=$(JAVA_VERSION="${%%APP_NAME%%_java_version}" JAVAVM_DRYRUN=1 %%LOCALBASE%%/bin/java | grep JAVA_HOME | cut -d= -f2) + procname=$(JAVA_VERSION="${%%APP_NAME%%_java_version}" JAVAVM_DRYRUN=1 %%LOCALBASE%%/bin/java | grep JAVAVM_PROG | cut -d= -f2) +else + JAVA_HOME=$(JAVAVM_DRYRUN=1 %%LOCALBASE%%/bin/java | grep JAVA_HOME | cut -d= -f2) + procname=$(JAVAVM_DRYRUN=1 %%LOCALBASE%%/bin/java | grep JAVAVM_PROG | cut -d= -f2) +fi + +export JAVA_HOME + +run_rc_command "$1" Index: files/resin3.sh.in =================================================================== RCS file: files/resin3.sh.in diff -N files/resin3.sh.in --- files/resin3.sh.in 13 Mar 2012 16:29:23 -0000 1.1 +++ /dev/null 1 Jan 1970 00:00:00 -0000 @@ -1,43 +0,0 @@ -#!/bin/sh -# -# $FreeBSD: ports/www/resin3/files/resin3.sh.in,v 1.1 2012/03/13 16:29:23 jgh Exp $ -# - -# PROVIDE: %%APP_NAME%% -# REQUIRE: LOGIN -# KEYWORD: shutdown - -# -# Add the following line to /etc/rc.conf to enable %%APP_NAME%%: -# -# %%APP_NAME%%_enable="YES" -# - -. /etc/rc.subr - -name=%%APP_NAME%% -rcvar=%%APP_NAME%%_enable - -command="%%PREFIX%%/sbin/%%APP_NAME%%ctl" -command_args="start" -pidfile=%%PID_FILE%% - -# set defaults - -%%APP_NAME%%_enable=${%%APP_NAME%%_enable:-"NO"} -%%APP_NAME%%_user=${%%APP_NAME%%_user:-"%%USERS%%"} -%%APP_NAME%%_group=${%%APP_NAME%%_group:-"%%GROUPS%%"} - -load_rc_config ${name} - -if test -n "${%%APP_NAME%%_java_version}" ; then - JAVA_HOME=$(JAVA_VERSION="${%%APP_NAME%%_java_version}" JAVAVM_DRYRUN=1 %%LOCALBASE%%/bin/java | grep JAVA_HOME | cut -d= -f2) - procname=$(JAVA_VERSION="${%%APP_NAME%%_java_version}" JAVAVM_DRYRUN=1 %%LOCALBASE%%/bin/java | grep JAVAVM_PROG | cut -d= -f2) -else - JAVA_HOME=$(JAVAVM_DRYRUN=1 %%LOCALBASE%%/bin/java | grep JAVA_HOME | cut -d= -f2) - procname=$(JAVAVM_DRYRUN=1 %%LOCALBASE%%/bin/java | grep JAVAVM_PROG | cut -d= -f2) -fi - -export JAVA_HOME - -run_rc_command "$1" --2oS5YaxWCcQjTEyO-- From owner-freebsd-rc@FreeBSD.ORG Wed Mar 28 03:52:13 2012 Return-Path: Delivered-To: rc@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 615F2106564A; Wed, 28 Mar 2012 03:52:13 +0000 (UTC) (envelope-from 5u623l20@gmail.com) Received: from mail-vx0-f182.google.com (mail-vx0-f182.google.com [209.85.220.182]) by mx1.freebsd.org (Postfix) with ESMTP id E266A8FC12; Wed, 28 Mar 2012 03:52:12 +0000 (UTC) Received: by vcmm1 with SMTP id m1so635274vcm.13 for ; Tue, 27 Mar 2012 20:52:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=t5jdsJe3/36kxklEEnkpMCLOyrdu4JJ5auFExdILnKE=; b=S+gV5Q9+VyayJEUu+VYjsi4mO1eiChxPcLwTHVp+dG3vO2QVCZP30XA+snAWo+1wSk qYYn7qwxWN9LsNkhIk2zju54bVn5Jrpal7geWpTNf1XaPUHYxE0pTvZNoWlvplxza9i9 uSPsCqJfiw5Lyozg/bfodWBVUsO/dKPquKJc7N3Y3169KIxWPDKGwllLEcxpAE4+g+uN SvevKfuysEoKHOElZHYbcImvKaaocdJ0X+CVEF2nXpGQe0NoHXBTNWJ3szIDX8RueMVs spav2sQqMzNjync3FVwM2d1cVqq/Us2Eg6844ywHm/zkaKpB+wzuhZSWM2WlcgKcvnYu RMDw== MIME-Version: 1.0 Received: by 10.220.149.5 with SMTP id r5mr10230345vcv.10.1332906731919; Tue, 27 Mar 2012 20:52:11 -0700 (PDT) Received: by 10.220.181.9 with HTTP; Tue, 27 Mar 2012 20:52:11 -0700 (PDT) In-Reply-To: <20120327181859.GD82277@dormouse.experts-exchange.com> References: <1332869146.439481.86668.nullmailer@experts-exchange.com> <20120327181859.GD82277@dormouse.experts-exchange.com> Date: Wed, 28 Mar 2012 09:52:11 +0600 Message-ID: From: Muhammad Moinur Rahman <5u623l20@gmail.com> To: Jason Helfman Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.5 Cc: rc@freebsd.org, bug-followup@freebsd.org Subject: Re: [PATCH] www/resin3: reorganize rc script X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 28 Mar 2012 03:52:13 -0000 Approved for commit. Regards, Muhammad On Wed, Mar 28, 2012 at 12:18 AM, Jason Helfman wrote: > On Wed, Mar 28, 2012 at 12:10:58AM +0600, Muhammad Moinur Rahman thus > spake: > > Hi Jason, >> >> Good to see you again. :D >> > > Good to see you too :) > > > >> As far as I remember we got rid off the users problem running the >> application with www user and group. In that case don't you think we can >> get rid off the following variables from the rc file : >> >> +%%APP_NAME%%_user=${%%APP_**NAME%%_user:-"%%USERS%%"} >> +%%APP_NAME%%_group=${%%APP_**NAME%%_group:-"%%GROUPS%%"} >> >> Let me know your opinion please. >> >> Regards, >> Muhammad >> > > We didn't get rid of the USERS/GROUPS usage, though. We are using both > of these, but using the www user and www group. > > Since it isn't configurable now, though, you have a a point, so it should > at > least be non-configurable in the rc script. > > Included is an updated patch. > > -jgh > > -- > Jason Helfman | FreeBSD Committer > jgh@FreeBSD.org | http://people.freebsd.org/~jgh > From owner-freebsd-rc@FreeBSD.ORG Thu Mar 29 19:07:42 2012 Return-Path: Delivered-To: freebsd-rc@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id C453A106566B; Thu, 29 Mar 2012 19:07:42 +0000 (UTC) (envelope-from linimon@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 96DF78FC1C; Thu, 29 Mar 2012 19:07:42 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id q2TJ7gLJ099173; Thu, 29 Mar 2012 19:07:42 GMT (envelope-from linimon@freefall.freebsd.org) Received: (from linimon@localhost) by freefall.freebsd.org (8.14.5/8.14.5/Submit) id q2TJ7gEZ099169; Thu, 29 Mar 2012 19:07:42 GMT (envelope-from linimon) Date: Thu, 29 Mar 2012 19:07:42 GMT Message-Id: <201203291907.q2TJ7gEZ099169@freefall.freebsd.org> To: linimon@FreeBSD.org, freebsd-bugs@FreeBSD.org, freebsd-rc@FreeBSD.org From: linimon@FreeBSD.org Cc: Subject: Re: conf/166484: [rc] [patch] rc.initdiskless patch for different major versions living together X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Mar 2012 19:07:42 -0000 Old Synopsis: rc.initdiskless patch for different major versions living together New Synopsis: [rc] [patch] rc.initdiskless patch for different major versions living together Responsible-Changed-From-To: freebsd-bugs->freebsd-rc Responsible-Changed-By: linimon Responsible-Changed-When: Thu Mar 29 19:07:22 UTC 2012 Responsible-Changed-Why: Over to maintainer(s). http://www.freebsd.org/cgi/query-pr.cgi?pr=166484