From owner-freebsd-rc@FreeBSD.ORG Mon Nov 26 11:06:50 2012 Return-Path: Delivered-To: freebsd-rc@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id BA43658E for ; Mon, 26 Nov 2012 11:06:50 +0000 (UTC) (envelope-from owner-bugmaster@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) by mx1.freebsd.org (Postfix) with ESMTP id 9F3DC8FC23 for ; Mon, 26 Nov 2012 11:06:50 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id qAQB6ouY019517 for ; Mon, 26 Nov 2012 11:06:50 GMT (envelope-from owner-bugmaster@FreeBSD.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.5/8.14.5/Submit) id qAQB6oEg019515 for freebsd-rc@FreeBSD.org; Mon, 26 Nov 2012 11:06:50 GMT (envelope-from owner-bugmaster@FreeBSD.org) Date: Mon, 26 Nov 2012 11:06:50 GMT Message-Id: <201211261106.qAQB6oEg019515@freefall.freebsd.org> X-Authentication-Warning: freefall.freebsd.org: gnats set sender to owner-bugmaster@FreeBSD.org using -f From: FreeBSD bugmaster To: freebsd-rc@FreeBSD.org Subject: Current problem reports assigned to freebsd-rc@FreeBSD.org X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 26 Nov 2012 11:06:50 -0000 Note: to view an individual PR, use: http://www.freebsd.org/cgi/query-pr.cgi?pr=(number). The following is a listing of current problems submitted by FreeBSD users. These represent problem reports covering all versions including experimental development code and obsolete releases. S Tracker Resp. Description -------------------------------------------------------------------------------- o bin/173153 rc [rc.d] [patch] $netwait_ip should be more parallel o conf/172532 rc [rc] [patch] service routing restart always fails o conf/169373 rc mountd starts too early when exporting fs marked as la o conf/169047 rc [rc.subr] [patch] /etc/rc.subr not checking some scrip o bin/168544 rc [patch] [rc]: addswap-mounted swapfiles cause panic on o conf/167566 rc [rc.d] [patch] ipdivert module loading vs. ipfw rc.d o o conf/166484 rc [rc] [patch] rc.initdiskless patch for different major o conf/165769 rc [rc][jai][ipv6] IPv6 Initialization on external iface o conf/164393 rc [rc.d] restarting netif with static addresses doesn't o conf/163508 rc [rc.subr] [patch] Add "enable" and "disable" commands o conf/163488 rc Confusing explanation in defaults/rc.conf o conf/163321 rc [rc.conf] [patch] allow _fib syntax in rc.conf o conf/162642 rc .sh scripts in /usr/local/etc/rc.d get executed, not s p kern/161899 rc [route] ntpd(8): Repeating RTM_MISS packets causing hi o conf/161107 rc [rc] stop_boot in mountcritlocal usage is incorrect. o conf/160403 rc [rc] [patch] concurrently running rc-scripts during bo o conf/160240 rc rc.d/mdconfig and mdconfig2 should autoset $_type to v o conf/159846 rc [rc.conf] routing_stop_inet6() logic doesn't handle ip o conf/158557 rc [patch] /etc/rc.d/pf broken messages o conf/158127 rc [patch] remount_optional option in rc.initdiskless doe o conf/153666 rc [rc.d][patch] mount filesystems from fstab over zfs da o conf/153200 rc post-boot /etc/rc.d/network_ipv6 start can miss neighb o conf/153123 rc [rc] [patch] add gsched rc file to automatically inser o conf/150474 rc [patch] rc.d/accounting: Add ability to set location o o conf/149867 rc [PATCH] rc.d script to manage multiple FIBS (kern opti o conf/149831 rc [PATCH] add support to /etc/rc.d/jail for delegating Z o conf/148656 rc rc.firewall(8): {oip} and {iip} variables in rc.firewa o conf/147685 rc [rc.d] [patch] new feature for /etc/rc.d/fsck o conf/147444 rc [rc.d] [patch] /etc/rc.d/zfs stop not called on reboot o conf/146053 rc [patch] [request] shutdown of jails breaks inter-jail o conf/145399 rc [patch] rc.d scripts are unable to start/stop programs o conf/145009 rc [patch] rc.subr(8): rc.conf should allow mac label con o conf/143637 rc [patch] ntpdate(8) support for ntp-servers supplied by o conf/143085 rc [patch] ftp-proxy(8) rc(8) with multiple instances a conf/142973 rc [jail] [patch] Strange counter init value in jail rc o conf/142434 rc [patch] Add cpuset(1) support to rc.subr(8) o conf/142304 rc rc.conf(5): mdconfig and mdconfig2 rc.d scripts lack e o conf/141909 rc rc.subr(8): [patch] add rc.conf.d support to /usr/loca o conf/141678 rc [patch] A minor enhancement to how /etc/rc.d/jail dete o conf/140440 rc [patch] allow local command files in rc.{suspend,resum o conf/140261 rc [patch] Improve flexibility of mdconfig2 startup scrip p conf/138208 rc [rc.d] [patch] Making rc.firewall (workstation) IPv6 a o conf/137271 rc [rc.d] Cannot update /etc/host.conf when root filesyst o conf/136624 rc [rc.d] sysctl variables for ipnat are not applied on b o conf/134918 rc [patch] rc.subr fails to detect perl daemons o conf/134660 rc [patch] rc-script for initializing ng_netflow+ng_ipfw o conf/134333 rc PPP configuration problem in the rc.d scripts in combi o conf/133890 rc [patch] sshd(8): add multiple profiles to the rc.d scr o conf/128299 rc [patch] /etc/rc.d/geli does not mount partitions using o conf/126392 rc [patch] rc.conf ifconfig_xx keywords cannot be escaped o conf/124747 rc [patch] savecore can't create dump from encrypted swap o conf/124248 rc [jail] [patch] add support for nice value for rc.d/jai o conf/123734 rc [patch] Chipset VIA CX700 requires extra initializatio o conf/123222 rc [patch] Add rtprio(1)/idprio(1) support to rc.subr(8). p conf/123119 rc [patch] rc script for ipfw does not handle IPv6 o conf/122968 rc [rc.d] /etc/rc.d/addswap: md swapfile multiplication a o conf/122477 rc [patch] /etc/rc.d/mdconfig and mdconfig2 are ignoring o conf/122170 rc [patch] [request] New feature: notify admin via page o o kern/121566 rc [nfs] [request] [patch] ethernet iface should be broug a conf/119874 rc [patch] "/etc/rc.d/pf reload" fails if there are macro o conf/119076 rc [patch] [rc.d] /etc/rc.d/netif tries to remove alias a o bin/118325 rc [patch] [request] new periodic script to test statuses f conf/118255 rc savecore never finding kernel core dumps (rcorder prob f conf/117935 rc [patch] ppp fails to start at boot because of missing f conf/113915 rc [patch] ndis wireless driver fails to associate when i o conf/108589 rc rtsol(8) fails due to default ipfw rules o conf/106009 rc [ppp] [patch] [request] Fix pppoed startup script to p f conf/105689 rc [ppp] [request] syslogd starts too late at boot f conf/105145 rc [ppp] [patch] [request] add redial function to rc.d/pp f conf/104549 rc [patch] rc.d/nfsd needs special _find_processes functi o conf/102700 rc [geli] [patch] Add encrypted /tmp support to GELI/GBDE o conf/93815 rc [patch] Adds in the ability to save ipfw rules to rc.d f conf/92523 rc [patch] allow rc scripts to kill process after a timeo o conf/89870 rc [patch] [request] make netif verbose rc.conf toggle a conf/88913 rc [patch] wrapper support for rc.subr o conf/85819 rc [patch] script allowing multiuser mode in spite of fsc o kern/81006 rc ipnat not working with tunnel interfaces on startup o conf/77663 rc Suggestion: add /etc/rc.d/addnetswap after addcritremo o conf/73677 rc [patch] add support for powernow states to power_profi a conf/58939 rc [patch] dumb little hack for /etc/rc.firewall{,6} f conf/56934 rc [patch] rc.firewall rules for natd expect an interface 81 problems total. From owner-freebsd-rc@FreeBSD.ORG Mon Nov 26 17:28:38 2012 Return-Path: Delivered-To: freebsd-rc@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id BBA542F3; Mon, 26 Nov 2012 17:28:38 +0000 (UTC) (envelope-from mike.jakubik@intertainservices.com) Received: from mail.intertainservices.com (mail.intertainservices.com [69.77.177.114]) by mx1.freebsd.org (Postfix) with ESMTP id 4E9B08FC13; Mon, 26 Nov 2012 17:28:38 +0000 (UTC) Received: from [172.16.10.200] (unknown [172.16.10.200]) by mail.intertainservices.com (Postfix) with ESMTPSA id 4CFE656E23; Mon, 26 Nov 2012 12:28:31 -0500 (EST) Message-ID: <1353950911.1893.1.camel@mjakubik.localdomain> Subject: Re: jail: unknown parameter: ip6.addr From: Mike Jakubik To: Chris Rees Date: Mon, 26 Nov 2012 12:28:31 -0500 In-Reply-To: <1352756987.7967.10.camel@mjakubik.localdomain> References: <1352756987.7967.10.camel@mjakubik.localdomain> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.4.4 (3.4.4-2.fc17) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-intertainservices-MailScanner-Information: Please contact the ISP for more information X-intertainservices-MailScanner-ID: 4CFE656E23.AF6D8 X-intertainservices-MailScanner: Found to be clean X-intertainservices-MailScanner-From: mike.jakubik@intertainservices.com X-Spam-Status: No Cc: jail@freebsd.org, "freebsd-rc@freebsd.org" , Eitan Adler X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 26 Nov 2012 17:28:38 -0000 On Mon, 2012-11-12 at 16:49 -0500, Mike Jakubik wrote: > On Sun, 2012-11-11 at 12:30 +0000, Chris Rees wrote: > > > > > Patch as promised-- please would you test and confirm? > > > > Chris, > > This patch also works for me, i am able to stop and start jails. > > Thanks. > Hello, Any chance that this can get committed before 9.1 is released? As is, 9.1 will break any system using jails that have INET6 disabled. Thanks. From owner-freebsd-rc@FreeBSD.ORG Mon Nov 26 17:53:10 2012 Return-Path: Delivered-To: freebsd-rc@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 4D592BDC for ; Mon, 26 Nov 2012 17:53:10 +0000 (UTC) (envelope-from lists@eitanadler.com) Received: from mail-lb0-f182.google.com (mail-lb0-f182.google.com [209.85.217.182]) by mx1.freebsd.org (Postfix) with ESMTP id 9DC318FC0C for ; Mon, 26 Nov 2012 17:53:09 +0000 (UTC) Received: by mail-lb0-f182.google.com with SMTP id go10so8358692lbb.13 for ; Mon, 26 Nov 2012 09:53:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=eitanadler.com; s=0xdeadbeef; h=mime-version:sender:in-reply-to:references:from:date :x-google-sender-auth:message-id:subject:to:cc:content-type; bh=jOBxGd/J04QGsN7zdhIbuR1DzbNOnQ4LUQV74lUgk/E=; b=lx/BzVlRIYrKaVgxjd2JUxO99MPb4X534j+MrdXeZi7TmcPRRnm9u+xn4hXSefTKeP Wva/lD0ICJulyrIB39axqRRFb6DVzJ/pcJsVuHOfLpI5mLjRYAxclqv6vCSN2sg6wMp8 PEhzdRMPcLbHlYF2b56FQG+ATGoXkHbajCWPc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date :x-google-sender-auth:message-id:subject:to:cc:content-type :x-gm-message-state; bh=jOBxGd/J04QGsN7zdhIbuR1DzbNOnQ4LUQV74lUgk/E=; b=bqfjQkRg4lerV4QtVMbZESCPACU7wXk7GacA83FEN9lXGNpir+LJ4p66TiYu1RkKTE 1kMTBTQxiFDSB4Mrtq61+0WhX6EcJw8A/wX/U9MoM7NWtuwhODZp2CeQbZkG1Tr/6Zcj mS64tPkGXFvvY/b/D2+flPqv1l/qf17VDtpUfsOSnen8Jgfihx04Ofunp8TyZOKqLU7M CHVQAtRpocI6wibe2+xTGabnGTyz0+SSupluN2/FB8s01R5+ex3rz9wjEZT7DtEPxdMl zJkMh+F6CcrDYKCxwoNlYERA/W96G5UlBgYzj9WYoKjDG1+58m9hy6lm6tkrgUnOUCkG EICQ== Received: by 10.152.103.100 with SMTP id fv4mr11688877lab.39.1353952387983; Mon, 26 Nov 2012 09:53:07 -0800 (PST) MIME-Version: 1.0 Sender: lists@eitanadler.com Received: by 10.112.154.168 with HTTP; Mon, 26 Nov 2012 09:52:36 -0800 (PST) In-Reply-To: <1353950911.1893.1.camel@mjakubik.localdomain> References: <1352756987.7967.10.camel@mjakubik.localdomain> <1353950911.1893.1.camel@mjakubik.localdomain> From: Eitan Adler Date: Mon, 26 Nov 2012 12:52:36 -0500 X-Google-Sender-Auth: NX7CR1mOAqSwtZ2G6-hJUsaNPz8 Message-ID: Subject: Re: jail: unknown parameter: ip6.addr To: Mike Jakubik Content-Type: text/plain; charset=UTF-8 X-Gm-Message-State: ALoCoQkBQ/1tfKq4e/16YoiT0l6Yd/uB5e5j03Sr+5n8OJseTaFEt2GlqFOSsGLPP6G1Rsuk7MSC Cc: jail@freebsd.org, "freebsd-rc@freebsd.org" , Chris Rees X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 26 Nov 2012 17:53:10 -0000 On 26 November 2012 12:28, Mike Jakubik wrote: > On Mon, 2012-11-12 at 16:49 -0500, Mike Jakubik wrote: >> On Sun, 2012-11-11 at 12:30 +0000, Chris Rees wrote: >> >> > >> > Patch as promised-- please would you test and confirm? >> > >> >> Chris, >> >> This patch also works for me, i am able to stop and start jails. >> >> Thanks. >> > > Hello, > > Any chance that this can get committed before 9.1 is released? As is, > 9.1 will break any system using jails that have INET6 disabled. It has been committed. I don't think I MFCed it (but may have forgotten if I did). In any case there is zero chance of getting it in to 9.1-RELEASE. It will be in 9.2. -- Eitan Adler Source, Ports, Doc committer Bugmeister, Ports Security teams From owner-freebsd-rc@FreeBSD.ORG Mon Nov 26 18:22:26 2012 Return-Path: Delivered-To: freebsd-rc@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 5942B34F; Mon, 26 Nov 2012 18:22:26 +0000 (UTC) (envelope-from mjguzik@gmail.com) Received: from mail-wi0-f174.google.com (mail-wi0-f174.google.com [209.85.212.174]) by mx1.freebsd.org (Postfix) with ESMTP id AFC768FC15; Mon, 26 Nov 2012 18:22:25 +0000 (UTC) Received: by mail-wi0-f174.google.com with SMTP id hm9so3155202wib.13 for ; Mon, 26 Nov 2012 10:22:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=kCMgskCNE9+Z7AAuMsUypNaIqi9oQYgTFHyigan6Fa8=; b=V7/WzyGdP58lSxkaCUW+1NOHAA7Ml6+hwkh1M5HvBJV4VtOv+0zyrYU1He1u7868p7 A4pXqrm0m6FH0GHqAdOvPTSRgK42VotNMLafDsHDmEJ68z3kODtCYSaTlu71SagR4Nu4 67g7cG1Mww+i1UbLcuX6TCxA8pL404wE13fwDNzOiECaC9Jhem16OIj4ONau5EE6VKzw ULItccNqG1zu51znm0H80Xn3fhVinliPl35JmjM9wsSmyysV4iXHrDjEBQHOaYvo4PT7 1p9ni5D7g0QvozatS6KwXKiUsc0buJNPq8YzAzEe59pDEHQtMKADrlk4+03A3GR6zsGh u+Hw== Received: by 10.180.74.108 with SMTP id s12mr19218512wiv.12.1353954143931; Mon, 26 Nov 2012 10:22:23 -0800 (PST) Received: from dft-labs.eu (n1x0n-1-pt.tunnel.tserv5.lon1.ipv6.he.net. [2001:470:1f08:1f7::2]) by mx.google.com with ESMTPS id bz12sm127354wib.5.2012.11.26.10.22.21 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 26 Nov 2012 10:22:22 -0800 (PST) Date: Mon, 26 Nov 2012 19:22:14 +0100 From: Mateusz Guzik To: freebsd-rc@FreeBSD.org Subject: Re: after upgrade, can't restart apache via cron Message-ID: <20121126182214.GA17080@dft-labs.eu> References: <20121123031753.GA59632@bewilderbeast.blackhelicopters.org> <20121123.233754.1596631883684484110.hrs@allbsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20121123.233754.1596631883684484110.hrs@allbsd.org> User-Agent: Mutt/1.5.20 (2009-06-14) Cc: current@FreeBSD.org, mwlucas@michaelwlucas.com X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 26 Nov 2012 18:22:26 -0000 On Fri, Nov 23, 2012 at 11:37:54PM +0900, Hiroki Sato wrote: > "Michael W. Lucas" wrote > in <20121123031753.GA59632@bewilderbeast.blackhelicopters.org>: > > mw> eval: setfib: not found > mw> /usr/local/etc/rc.d/apache22: WARNING: failed to start apache22 > mw> > mw> If I run /usr/local/etc/rc.d/apache22 restart from the command line, I > mw> can restart httpd without trouble. > mw> > mw> Any thoughts? > > This was due to $PATH in the cron job as already pointed out, but > this should not happen. I attached a patch to use full-path for > external commands in rc.subr. If there is no objection to this > change I will commit it. > service(8) tries to sanitize stuff before executing scripts. How about making this the default behaviour? Currently stuff like PATH "leak" to rc scripts and this can be harmful (for instance daemon was happily executing stuff from /usr/local/bin, yet after reboot it stopped working). Also I doubt anyone relies on current environment and what not to start a service, but we can provide another target tha would start the service without sanitizing in case this is needed. -- Mateusz Guzik From owner-freebsd-rc@FreeBSD.ORG Tue Nov 27 11:16:20 2012 Return-Path: Delivered-To: freebsd-rc@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id ACEC5BD; Tue, 27 Nov 2012 11:16:20 +0000 (UTC) (envelope-from mjguzik@gmail.com) Received: from mail-wi0-f178.google.com (mail-wi0-f178.google.com [209.85.212.178]) by mx1.freebsd.org (Postfix) with ESMTP id D56008FC08; Tue, 27 Nov 2012 11:16:19 +0000 (UTC) Received: by mail-wi0-f178.google.com with SMTP id hm6so3583729wib.13 for ; Tue, 27 Nov 2012 03:16:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=YbpamqEXrbvYGt6lH3SV8cFkssZM0tAomrb26bIlh7A=; b=Ay1B3GNBP5vflA/T174mG7lZ3Q9LtpvaFpe+J9fSABjGy5IZzYc4k9lAJwijhLmjjM in5/wVbZG2FGsNM/1KFMlA0E03c1bh5Aim7oO1Eubexj28ihC/OlpFTTB4q2C4wqt0bQ cnTX29nAJYbPnmLiUYUUiwwXG/qb3Nn0ujPYMBDOFyOVKWGQKSYZH+0LawcEJKR9Qlxf 3HIZmSoVMSnbGEmuC30PE0NFVJAoUKO392tkpwZUdLxE0fqfUzHihuMfUlAfyBty55vF tadBr5nfm2VKcLV6JDzgHEO5mEMc83pL6jLRDrqeFoIOnKRR0JDNCs7ItFKrRz+TLSNg wRfw== Received: by 10.180.83.132 with SMTP id q4mr13495750wiy.9.1354014973104; Tue, 27 Nov 2012 03:16:13 -0800 (PST) Received: from dft-labs.eu (n1x0n-1-pt.tunnel.tserv5.lon1.ipv6.he.net. [2001:470:1f08:1f7::2]) by mx.google.com with ESMTPS id eu8sm2075640wib.1.2012.11.27.03.16.11 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 27 Nov 2012 03:16:12 -0800 (PST) Date: Tue, 27 Nov 2012 12:16:06 +0100 From: Mateusz Guzik To: Chris Rees Subject: Re: mountlate being too mount-happy Message-ID: <20121127111606.GB15606@dft-labs.eu> References: <20121118.074325.564844639489846824.hrs@allbsd.org> <20121118002245.GB15055@dft-labs.eu> <20121118.150935.240651183336258002.hrs@allbsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.20 (2009-06-14) Cc: "freebsd-rc@freebsd.org" , Mateusz Guzik X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 Nov 2012 11:16:20 -0000 On Sun, Nov 18, 2012 at 02:28:28PM +0000, Chris Rees wrote: > On 18 November 2012 06:09, Hiroki Sato wrote: > > Mateusz Guzik wrote > > in <20121118002245.GB15055@dft-labs.eu>: > > > > mj> On Sun, Nov 18, 2012 at 07:43:25AM +0900, Hiroki Sato wrote: > > mj> > Chris Rees wrote > > mj> > in : > > mj> > > > mj> > ut> On 2 November 2012 14:21, Eitan Adler wrote: > > mj> > ut> > On 2 November 2012 09:56, Chris Rees wrote: > > mj> > ut> >> I'll take a look. > > mj> > ut> > > > mj> > ut> > untested: > > mj> > ut> > > mj> > ut> Based on Eitan's patch, I've tested this one, and documented it in mount(8) too: > > mj> > ut> > > mj> > ut> http://www.bayofrum.net/~crees/patches/mountonlylate.diff > > mj> > ut> > > mj> > ut> Does anyone have any suggestions/objections/urge to approve it? > > mj> > > > mj> > Is the original problem due to backgrounding of NFS mount only? If > > mj> > so, implementing prevention of duplicate invocation into mount(8) > > mj> > would be more reasonable, I think. > > mj> > > > mj> > > mj> We have 2 distinct scripts that try to mount same set of filesystems. > > mj> I think this is the real bug here and proposed patches makes it go away in > > mj> an IMHO acceptable way. > > > > I just wanted to make sure if the case is limited to background NFS > > mount or not. > > > > rc.d/mountlate just tries to mount the filesystems that are not > > mounted yet at that time in addition to the "late" ones, not always > > to mount the same set twice. If it is a bug, it is better to simply > > fix -l to exclude not-yet-mounted ones without "late" keyword than > > adding another option. > > I don't think it's a bug as such-- -l option is clearly labelled in > the manpage (emphasis mine): > > When used in conjunction with the -a option, *also* mount those > file systems which are marked as ``late''. > > I think that for POLA and to avoid changing behaviour of an option > that's been there a long time we need the -L option. > > I disagree with Mateusz here-- split operations in rc makes two > scripts necessary; mount and mountlate are two separate operations, > done at different times. > So it turns out I expressed myself incorrectly. I'm fine with two separate scripts doing mounts. I'm not fine with the fact that both scripts may try to mount very same filesystem (which is the case now with background nfs). crees's patch fixes this problem in a way that I think is ok. -- Mateusz Guzik From owner-freebsd-rc@FreeBSD.ORG Fri Nov 30 05:00:01 2012 Return-Path: Delivered-To: freebsd-rc@smarthost.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 4A5AFCF5 for ; Fri, 30 Nov 2012 05:00:01 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) by mx1.freebsd.org (Postfix) with ESMTP id 166A48FC12 for ; Fri, 30 Nov 2012 05:00:01 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id qAU500Pe065504 for ; Fri, 30 Nov 2012 05:00:00 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.5/8.14.5/Submit) id qAU500Y9065500; Fri, 30 Nov 2012 05:00:00 GMT (envelope-from gnats) Date: Fri, 30 Nov 2012 05:00:00 GMT Message-Id: <201211300500.qAU500Y9065500@freefall.freebsd.org> To: freebsd-rc@FreeBSD.org Cc: From: mitsuru y Subject: Re: conf/92523: [patch] allow rc scripts to kill process after a timeout X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: mitsuru y List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 30 Nov 2012 05:00:01 -0000 The following reply was made to PR conf/92523; it has been noted by GNATS. From: mitsuru y To: bug-followup@FreeBSD.org, lawrance@FreeBSD.org Cc: Subject: Re: conf/92523: [patch] allow rc scripts to kill process after a timeout Date: Fri, 30 Nov 2012 13:52:55 +0900 It is archived at http://web.archive.org/web/20060921232848/http://people.freebsd.org/~lawrance/patch-rc.subr -- mitsuru From owner-freebsd-rc@FreeBSD.ORG Fri Nov 30 09:50:01 2012 Return-Path: Delivered-To: freebsd-rc@smarthost.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 69D8ABD9 for ; Fri, 30 Nov 2012 09:50:01 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) by mx1.freebsd.org (Postfix) with ESMTP id 339D58FC08 for ; Fri, 30 Nov 2012 09:50:01 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id qAU9o1VL086225 for ; Fri, 30 Nov 2012 09:50:01 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.5/8.14.5/Submit) id qAU9o1Yq086220; Fri, 30 Nov 2012 09:50:01 GMT (envelope-from gnats) Date: Fri, 30 Nov 2012 09:50:01 GMT Message-Id: <201211300950.qAU9o1Yq086220@freefall.freebsd.org> To: freebsd-rc@FreeBSD.org Cc: From: mitsuru y Subject: Re: conf/92523: [patch] allow rc scripts to kill process after a timeout X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: mitsuru y List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 30 Nov 2012 09:50:01 -0000 The following reply was made to PR conf/92523; it has been noted by GNATS. From: mitsuru y To: bug-followup@FreeBSD.org, lawrance@FreeBSD.org Cc: Subject: Re: conf/92523: [patch] allow rc scripts to kill process after a timeout Date: Fri, 30 Nov 2012 18:48:08 +0900 --f46d04479f3d0d266304cfb34c15 Content-Type: text/plain; charset=UTF-8 I have modified the patch. - to be applied cleanly for 8.2-RELEASE ( and 9-STABLE). - introduce default_stop_timeout - kill -KILL only if timeout -- mitsuru --f46d04479f3d0d266304cfb34c15 Content-Type: application/octet-stream; name="patch-rc.subr" Content-Disposition: attachment; filename="patch-rc.subr" Content-Transfer-Encoding: base64 X-Attachment-Id: f_ha54nbi90 LS0tIHJjLnN1YnIub3JpZwkyMDEyLTExLTMwIDE3OjI5OjQ5LjAwMDAwMDAwMCArMDkwMAorKysg cmMuc3VicgkyMDEyLTExLTMwIDE4OjMyOjM2LjAwMDAwMDAwMCArMDkwMApAQCAtMzk4LDYgKzM5 OCw0MiBAQAogfQogCiAjCisjIHdhaXRfbWF4X2Zvcl9waWRzIHRpbWVvdXQgcGlkIFtwaWQgLi4u XQorIwlzcGlucyB1bnRpbCBub25lIG9mIHRoZSBwaWRzIGV4aXN0LCBvciB1bnRpbCBhIG1heGlt dW0gb2YKKyMJInRpbWVvdXQiIHNlY29uZHMgaGF2ZSBlbGFwc2VkICh3aGljaGV2ZXIgY29tZXMg Zmlyc3QpLgorIword2FpdF9tYXhfZm9yX3BpZHMoKQoreworCV90aW1lb3V0PSQxCisJc2hpZnQK KwlfbGlzdD0iJEAiCisJaWYgWyAteiAiJF9saXN0IiBdOyB0aGVuCisJCXJldHVybiAwCisJZmkK KwlfcHJlZml4PQorCXdoaWxlIFsgJF90aW1lb3V0IC1ndCAwIF0gOyBkbworCQlfbmxpc3Q9IiI7 CisJCWZvciBfaiBpbiAkX2xpc3Q7IGRvCisJCQlpZiBraWxsIC0wICRfaiAyPi9kZXYvbnVsbDsg dGhlbgorCQkJCV9ubGlzdD0iJHtfbmxpc3R9JHtfbmxpc3Q6KyB9JF9qIgorCQkJZmkKKwkJZG9u ZQorCQlpZiBbIC16ICIkX25saXN0IiBdOyB0aGVuCisJCQlyZXR1cm4gMAorCQlmaQorCQlfbGlz dD0kX25saXN0CisJCWVjaG8gLW4gJHtfcHJlZml4Oi0iV2FpdGluZyAobWF4ICRfdGltZW91dCBz ZWNzKSBmb3IgUElEUzogIn0kX2xpc3QKKwkJX3ByZWZpeD0iLCAiCisJCXNsZWVwIDIKKwkJX3Rp bWVvdXQ9JCgoJF90aW1lb3V0LTIpKQorCWRvbmUKKwlpZiBbIC1uICIkX3ByZWZpeCIgXTsgdGhl bgorCQllY2hvICIuIgorCWZpCisJcmV0dXJuIDEKK30KKworIwogIyBydW5fcmNfY29tbWFuZCBh cmd1bWVudAogIwlTZWFyY2ggZm9yIGFyZ3VtZW50IGluIHRoZSBsaXN0IG9mIHN1cHBvcnRlZCBj b21tYW5kcywgd2hpY2ggaXM6CiAjCQkic3RhcnQgc3RvcCByZXN0YXJ0IHJjdmFyIHN0YXR1cyBw b2xsICR7ZXh0cmFfY29tbWFuZHN9IgpAQCAtNzU3LDggKzc5MywxOCBAQAogCQkJX3J1bl9yY19k b2l0ICIkX2RvaXQiIHx8IHJldHVybiAxCiAKIAkJCQkJIyB3YWl0IGZvciB0aGUgY29tbWFuZCB0 byBleGl0LAorCQkJCQkjIGtpbGwgaXQgaWYgYSB0aW1lb3V0IGlzIHNwZWNpZmllZCwKIAkJCQkJ IyBhbmQgcnVuIHBvc3RjbWQuCi0JCQl3YWl0X2Zvcl9waWRzICRyY19waWQKKwkJCWV2YWwgX3Rp bWVvdXQ9XCQke25hbWV9X3N0b3BfdGltZW91dAorCQkJaWYgWyAteiAkX3RpbWVvdXQgXTsgdGhl bgorCQkJCWV2YWwgX3RpbWVvdXQ9JGRlZmF1bHRfc3RvcF90aW1lb3V0CisJCQlmaQorCQkJaWYg WyAke190aW1lb3V0Oi0wfSAtZ3QgMCBdOyB0aGVuCisJCQkJd2FpdF9tYXhfZm9yX3BpZHMgJHtf dGltZW91dH0gJHJjX3BpZCB8fCBcCisJCQkJZWNobyBraWxsIC1LSUxMICRyY19waWQKKwkJCWVs c2UKKwkJCQl3YWl0X2Zvcl9waWRzICRyY19waWQKKwkJCWZpCiAKIAkJCV9ydW5fcmNfcG9zdGNt ZAogCQkJOzsK --f46d04479f3d0d266304cfb34c15-- From owner-freebsd-rc@FreeBSD.ORG Sat Dec 1 22:10:22 2012 Return-Path: Delivered-To: rc@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id F3543ED0; Sat, 1 Dec 2012 22:10:21 +0000 (UTC) (envelope-from yanegomi@gmail.com) Received: from mail-oa0-f54.google.com (mail-oa0-f54.google.com [209.85.219.54]) by mx1.freebsd.org (Postfix) with ESMTP id 961928FC0C; Sat, 1 Dec 2012 22:10:21 +0000 (UTC) Received: by mail-oa0-f54.google.com with SMTP id n9so2099963oag.13 for ; Sat, 01 Dec 2012 14:10:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=JldwXiYEvlndzPi1Qr8krwwoP7ZCVpuMuxei7RmMbV8=; b=prVeIBoV96ffzPPgSxsw9FUNyud7KFH3HSOSg0pnXPUxk3RUUTRDbCdzkZqjLInU8A 646uRW/9RthmjX/aqGZ7RMXJs5+4OdmEIZCM0Oz2OK6VsVxj0oVbA4YQJKwPAMC7gZKh 6dCdcRbzXIskfkD/ojCIlCk5I9rPu+LtkvTTmPSu4tzTufCo7jEJqsgRUQmj12lJwIZg 7lp4/ggjIUg9ZbASygn8a8DjMq4OT0xxv2q+NwNLZrARdXOqR+upDcShOz0eQn9wHiCm o8tv5wVmSmYBDdhDXtbF7RbW5+GShlcty6lUM6/Cleb/v0aphv6R/NIv867+9DREbUfZ QVQg== MIME-Version: 1.0 Received: by 10.60.10.133 with SMTP id i5mr4608090oeb.24.1354399820833; Sat, 01 Dec 2012 14:10:20 -0800 (PST) Received: by 10.76.143.33 with HTTP; Sat, 1 Dec 2012 14:10:20 -0800 (PST) In-Reply-To: <20121202.015048.1122480556487090170.hrs@allbsd.org> References: <20121202.015048.1122480556487090170.hrs@allbsd.org> Date: Sat, 1 Dec 2012 14:10:20 -0800 Message-ID: Subject: Re: RFC: sysctl -f filename From: Garrett Cooper To: Hiroki Sato Content-Type: text/plain; charset=ISO-8859-1 Cc: rc@freebsd.org, current@freebsd.org X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 01 Dec 2012 22:10:22 -0000 On Sat, Dec 1, 2012 at 8:50 AM, Hiroki Sato wrote: > Hi, > > I would like comments about the attached patch for sysctl(8) to add a > new option "-f filename". It supports reading of a file with > key=value lines. > > As you probably know, we already have /etc/sysctl.conf and it is > processed by rc.d/sysctl shell script in a line-by-line basis. The > problem I want to fix is a confusing syntax of /etc/sysctl.conf. The > file supports a typical configuration file syntax but problematic in > some cases. For example: > > kern.coredump=1 > > works well in /etc/sysctl.conf, but > > kern.coredump="1" > > does not work. Similarly, it is difficult to use whitespaces and "#" > in the value: > > OK: kern.domainname=domain\ name\ with\ spaces > NG: kern.domainname="domain name with spaces" > NG: kern.domainname=domain\ name\ including\ #\ character > NG: kern.domainname=domain\ name\ including\ \#\ character > > The attached patch solves them, and in addition it displays an error > message with a line number if there is something wrong in the file > like this: > > % cat -n /etc/sysctl.conf > ... > 10 kern.coredump=1 > 11 kern.coredump2=1 > ... > > % /etc/rc.d/sysctl start > sysctl: kern.coredump at line 10: Operation not permitted > sysctl: unknown oid 'kern.coredump2' at line 11 > > # /etc/rc.d/sysctl start > kern.coredump: 1 -> 1 > sysctl: unknown oid 'kern.coredump2' at line 11 > > Any comments are welcome. Why change the tool when we can change the rc script to do the right thing? I have a patch I'm working on to resolve this (you hit an itch I've been meaning to scratch for a little while). Thanks! -Garrett From owner-freebsd-rc@FreeBSD.ORG Sat Dec 1 22:33:44 2012 Return-Path: Delivered-To: rc@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 1C896968; Sat, 1 Dec 2012 22:33:44 +0000 (UTC) (envelope-from yanegomi@gmail.com) Received: from mail-ob0-f182.google.com (mail-ob0-f182.google.com [209.85.214.182]) by mx1.freebsd.org (Postfix) with ESMTP id AC8328FC0C; Sat, 1 Dec 2012 22:33:43 +0000 (UTC) Received: by mail-ob0-f182.google.com with SMTP id 16so1850083obc.13 for ; Sat, 01 Dec 2012 14:33:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=BYhZlpAhqXB64AqTiS/QHgU9h5yeXPytc0OX8p5ZUqM=; b=NuBV2poVUXvaKPW9R35OHAHD0eNJjWF7miaafwuWKtld7wqbkS4vhl0F78EKXU3EY5 3VB4mQ4qLl8DJATGtOTzp0+iVZcg/BSH/O4MgH1cbDBi6ZVdb4BTfPhVVkunsvoHWBux RYZ3XdGGD7ozMJpJUEOBPqj4Byl4ytHWrdJ/k+F1y96S97G5zzqha+is94dLFnq8Wc9Z h7e40l+kr6zTNFR/wdvXG3qQAhnbTn8jEcx1qU3rxMViFFeB702/pWRRnfkNENoDk0v7 3GjjpV+vNigWFw3J6Vn/gCJu+/Un2RMfNYQjv4ueZ6Au2KX62X4MPxfEXYGWzwyPJKvz He/w== MIME-Version: 1.0 Received: by 10.182.172.74 with SMTP id ba10mr962946obc.83.1354401223193; Sat, 01 Dec 2012 14:33:43 -0800 (PST) Received: by 10.76.143.33 with HTTP; Sat, 1 Dec 2012 14:33:42 -0800 (PST) In-Reply-To: References: <20121202.015048.1122480556487090170.hrs@allbsd.org> Date: Sat, 1 Dec 2012 14:33:42 -0800 Message-ID: Subject: Re: RFC: sysctl -f filename From: Garrett Cooper To: Hiroki Sato Content-Type: multipart/mixed; boundary=e89a8f839f6fcab2b704cfd21bbb Cc: rc@freebsd.org, current@freebsd.org X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 01 Dec 2012 22:33:44 -0000 --e89a8f839f6fcab2b704cfd21bbb Content-Type: text/plain; charset=ISO-8859-1 On Sat, Dec 1, 2012 at 2:10 PM, Garrett Cooper wrote: > On Sat, Dec 1, 2012 at 8:50 AM, Hiroki Sato wrote: >> Hi, >> >> I would like comments about the attached patch for sysctl(8) to add a >> new option "-f filename". It supports reading of a file with >> key=value lines. >> >> As you probably know, we already have /etc/sysctl.conf and it is >> processed by rc.d/sysctl shell script in a line-by-line basis. The >> problem I want to fix is a confusing syntax of /etc/sysctl.conf. The >> file supports a typical configuration file syntax but problematic in >> some cases. For example: >> >> kern.coredump=1 >> >> works well in /etc/sysctl.conf, but >> >> kern.coredump="1" >> >> does not work. Similarly, it is difficult to use whitespaces and "#" >> in the value: >> >> OK: kern.domainname=domain\ name\ with\ spaces >> NG: kern.domainname="domain name with spaces" >> NG: kern.domainname=domain\ name\ including\ #\ character >> NG: kern.domainname=domain\ name\ including\ \#\ character >> >> The attached patch solves them, and in addition it displays an error >> message with a line number if there is something wrong in the file >> like this: >> >> % cat -n /etc/sysctl.conf >> ... >> 10 kern.coredump=1 >> 11 kern.coredump2=1 >> ... >> >> % /etc/rc.d/sysctl start >> sysctl: kern.coredump at line 10: Operation not permitted >> sysctl: unknown oid 'kern.coredump2' at line 11 >> >> # /etc/rc.d/sysctl start >> kern.coredump: 1 -> 1 >> sysctl: unknown oid 'kern.coredump2' at line 11 >> >> Any comments are welcome. > > Why change the tool when we can change the rc script to do the > right thing? I have a patch I'm working on to resolve this (you hit an > itch I've been meaning to scratch for a little while). This should work. I also refactored the script to get it down to 80 columns. I've attached the debug output and the diff for the debug version of the script. Cheers, -Garrett # diff -u etc/rc.d/sysctl etc/rc.d/sysctl.debug | sed -e 's,\.debug,,' --- etc/rc.d/sysctl 2012-12-01 14:29:31.948502097 -0800 +++ etc/rc.d/sysctl 2012-12-01 14:29:21.694501765 -0800 @@ -38,6 +38,10 @@ val="${val#\"*}" val="${val%%\"*}" + debug "line -> '$line'" + debug "mib -> '$mib'" + debug "val -> '$val'" + if current_value=`${SYSCTL} -n "${mib}" 2>/dev/null`; then if [ "${current_value}" = "${val}" ]; then continue ./etc/rc.d/sysctl: DEBUG: run_rc_command: doit: sysctl_start ./etc/rc.d/sysctl: DEBUG: line -> 'net.inet.tcp.recvspace=262144' ./etc/rc.d/sysctl: DEBUG: mib -> 'net.inet.tcp.recvspace' ./etc/rc.d/sysctl: DEBUG: val -> '262144' ./etc/rc.d/sysctl: DEBUG: line -> 'net.inet.tcp.sendspace="231072' ./etc/rc.d/sysctl: DEBUG: mib -> 'net.inet.tcp.sendspace' ./etc/rc.d/sysctl: DEBUG: val -> '231072' ./etc/rc.d/sysctl: DEBUG: line -> 'net.inet.tcp.sendspace="131074"' ./etc/rc.d/sysctl: DEBUG: mib -> 'net.inet.tcp.sendspace' ./etc/rc.d/sysctl: DEBUG: val -> '131074' ./etc/rc.d/sysctl: DEBUG: line -> 'net.inet.udp.recvspace=131072' ./etc/rc.d/sysctl: DEBUG: mib -> 'net.inet.udp.recvspace' ./etc/rc.d/sysctl: DEBUG: val -> '131072' ./etc/rc.d/sysctl: DEBUG: line -> 'kern.corefile=' ./etc/rc.d/sysctl: DEBUG: mib -> 'kern.corefile' ./etc/rc.d/sysctl: DEBUG: val -> '' ./etc/rc.d/sysctl: DEBUG: line -> 'kern.corefile="#' ./etc/rc.d/sysctl: DEBUG: mib -> 'kern.corefile' ./etc/rc.d/sysctl: DEBUG: val -> '#' ./etc/rc.d/sysctl: DEBUG: line -> 'kern.corefile="# abcd' ./etc/rc.d/sysctl: DEBUG: mib -> 'kern.corefile' ./etc/rc.d/sysctl: DEBUG: val -> '# abcd' ./etc/rc.d/sysctl: DEBUG: line -> 'kern.corefile="# abcd" #' ./etc/rc.d/sysctl: DEBUG: mib -> 'kern.corefile' ./etc/rc.d/sysctl: DEBUG: val -> '# abcd' ./etc/rc.d/sysctl: DEBUG: line -> 'kern.corefile="# abcd" #' ./etc/rc.d/sysctl: DEBUG: mib -> 'kern.corefile' ./etc/rc.d/sysctl: DEBUG: val -> '# abcd' ./etc/rc.d/sysctl: DEBUG: line -> 'kern.corefile="# abcd " #' ./etc/rc.d/sysctl: DEBUG: mib -> 'kern.corefile' ./etc/rc.d/sysctl: DEBUG: val -> '# abcd ' ./etc/rc.d/sysctl: DEBUG: line -> 'kern.corefile="# abcd " #' ./etc/rc.d/sysctl: DEBUG: mib -> 'kern.corefile' ./etc/rc.d/sysctl: DEBUG: val -> '# abcd ' ./etc/rc.d/sysctl: DEBUG: line -> 'kern.corefile="%N.core"' ./etc/rc.d/sysctl: DEBUG: mib -> 'kern.corefile' ./etc/rc.d/sysctl: DEBUG: val -> '%N.core' --e89a8f839f6fcab2b704cfd21bbb Content-Type: application/octet-stream; name="make-etc-rc.d-sysctl-quote-comment-and-space-aware.patch" Content-Disposition: attachment; filename="make-etc-rc.d-sysctl-quote-comment-and-space-aware.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_ha7bej930 SW5kZXg6IGV0Yy9yYy5kL3N5c2N0bAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBldGMvcmMuZC9zeXNjdGwJKHJl dmlzaW9uIDI0Mzc0NykKKysrIGV0Yy9yYy5kL3N5c2N0bAkod29ya2luZyBjb3B5KQpAQCAtMTks MzMgKzE5LDM2IEBACiAjCiBwYXJzZV9maWxlKCkKIHsKLQlpZiBbIC1mICQxIF07IHRoZW4KLQkJ d2hpbGUgcmVhZCB2YXIgY29tbWVudHMKLQkJZG8KLQkJCWNhc2UgJHt2YXJ9IGluCi0JCQlcIyp8 JycpCi0JCQkJOzsKLQkJCSopCi0JCQkJbWliPSR7dmFyJT0qfQotCQkJCXZhbD0ke3ZhciMqPX0K KwlpZiBbICEgLWYgIiQxIiBdOyB0aGVuCisJCXJldHVybiAwCisJZmkKKwlsb2NhbCBJRlM9Igor IgorCXdoaWxlIHJlYWQgbGluZQorCWRvCisJCWNhc2UgIiR7bGluZSVcIyp9IiBpbgorCQknJykK KwkJCWNvbnRpbnVlCisJCQk7OworCQllc2FjCisJCWxpbmU9IiR7bGluZSVcICp9IgogCi0JCQkJ aWYgY3VycmVudF92YWx1ZT1gJHtTWVNDVEx9IC1uICR7bWlifSAyPi9kZXYvbnVsbGA7IHRoZW4K LQkJCQkJY2FzZSAke2N1cnJlbnRfdmFsdWV9IGluCi0JCQkJCSR7dmFsfSkKLQkJCQkJCTs7Ci0J CQkJCSopCi0JCQkJCQlpZiAhIHN5c2N0bCAiJHt2YXJ9IiA+L2Rldi9udWxsIDI+JjE7IHRoZW4K LQkJCQkJCQl3YXJuICJ1bmFibGUgdG8gc2V0ICR7dmFyfSIKLQkJCQkJCWZpCi0JCQkJCQk7Owot CQkJCQllc2FjCi0JCQkJZWxpZiBbICIkMiIgPSAibGFzdCIgXTsgdGhlbgotCQkJCQl3YXJuICJz eXNjdGwgJHttaWJ9IGRvZXMgbm90IGV4aXN0LiIKLQkJCQlmaQotCQkJCTs7Ci0JCQllc2FjCi0J CWRvbmUgPCAkMQotCWZpCisJCW1pYj0iJHtsaW5lJT0qfSIKKwkJdmFsPSIke2xpbmUjKj19Igor CQl2YWw9IiR7dmFsI1wiKn0iCisJCXZhbD0iJHt2YWwlJVwiKn0iCisKKwkJaWYgY3VycmVudF92 YWx1ZT1gJHtTWVNDVEx9IC1uICIke21pYn0iIDI+L2Rldi9udWxsYDsgdGhlbgorCQkJaWYgWyAi JHtjdXJyZW50X3ZhbHVlfSIgPSAiJHt2YWx9IiBdOyB0aGVuCisJCQkJY29udGludWUKKwkJCWZp CisJCQlpZiAhIHN5c2N0bCAiJHttaWJ9PSR7dmFsfSIgPi9kZXYvbnVsbCAyPiYxOyB0aGVuCisJ CQkJd2FybiAidW5hYmxlIHRvIHNldCAke21pYn09JHt2YWx9IgorCQkJZmkKKwkJZWxpZiBbICIk MiIgPSAibGFzdCIgXTsgdGhlbgorCQkJd2FybiAic3lzY3RsICR7bWlifSBkb2VzIG5vdCBleGlz dC4iCisJCWZpCisJZG9uZSA8ICIkMSIKIH0KIAogc3lzY3RsX3N0YXJ0KCkK --e89a8f839f6fcab2b704cfd21bbb-- From owner-freebsd-rc@FreeBSD.ORG Sat Dec 1 23:32:31 2012 Return-Path: Delivered-To: rc@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id E610294; Sat, 1 Dec 2012 23:32:31 +0000 (UTC) (envelope-from hrs@FreeBSD.org) Received: from mail.allbsd.org (gatekeeper.allbsd.org [IPv6:2001:2f0:104:e001::32]) by mx1.freebsd.org (Postfix) with ESMTP id AB1F88FC12; Sat, 1 Dec 2012 23:32:27 +0000 (UTC) Received: from alph.allbsd.org (p1137-ipbf1505funabasi.chiba.ocn.ne.jp [118.7.212.137]) (authenticated bits=128) by mail.allbsd.org (8.14.5/8.14.5) with ESMTP id qB1NWACj098678 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sun, 2 Dec 2012 08:32:20 +0900 (JST) (envelope-from hrs@FreeBSD.org) Received: from localhost (localhost [127.0.0.1]) (authenticated bits=0) by alph.allbsd.org (8.14.5/8.14.5) with ESMTP id qB1NW8Vn050788; Sun, 2 Dec 2012 08:32:09 +0900 (JST) (envelope-from hrs@FreeBSD.org) Date: Sun, 02 Dec 2012 08:21:50 +0900 (JST) Message-Id: <20121202.082150.896017277887885294.hrs@allbsd.org> To: yanegomi@gmail.com Subject: Re: RFC: sysctl -f filename From: Hiroki Sato In-Reply-To: References: <20121202.015048.1122480556487090170.hrs@allbsd.org> X-PGPkey-fingerprint: BDB3 443F A5DD B3D0 A530 FFD7 4F2C D3D8 2793 CF2D X-Mailer: Mew version 6.5 on Emacs 23.4 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Multipart/Signed; protocol="application/pgp-signature"; micalg=pgp-sha1; boundary="--Security_Multipart(Sun_Dec__2_08_21_50_2012_024)--" Content-Transfer-Encoding: 7bit X-Virus-Scanned: clamav-milter 0.97.4 at gatekeeper.allbsd.org X-Virus-Status: Clean X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7 (mail.allbsd.org [133.31.130.32]); Sun, 02 Dec 2012 08:32:20 +0900 (JST) X-Spam-Status: No, score=-98.1 required=13.0 tests=CONTENT_TYPE_PRESENT, ONLY1HOPDIRECT,SAMEHELOBY2HOP,USER_IN_WHITELIST autolearn=no version=3.3.2 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on gatekeeper.allbsd.org Cc: rc@FreeBSD.org, current@FreeBSD.org X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 01 Dec 2012 23:32:32 -0000 ----Security_Multipart(Sun_Dec__2_08_21_50_2012_024)-- Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Garrett Cooper wrote in : ya> On Sat, Dec 1, 2012 at 2:10 PM, Garrett Cooper wrote: ya> > Why change the tool when we can change the rc script to do the ya> > right thing? I have a patch I'm working on to resolve this (you hit an ya> > itch I've been meaning to scratch for a little while). ya> ya> This should work. I also refactored the script to get it down to ya> 80 columns. I've attached the debug output and the diff for the debug ya> version of the script. You will find out the following test case does not work (this is one of the test strings I used): kern.domainname="c$EDITOR.\"\ hoge\ \"\#hoge2\\$ \# h$$\#oge"# The reason why I changed sysctl(8) was that the rc.d/sysctl script was too complex and slow even if it could support meta characters in shell script syntax. I created several prototypes as script but noticed that keeping consistency was quite difficult and maintainability was poor due to tricky handling of variables. Although my patch in the previous email does not support meta characters completely, I still think it is more reasonable to implement this functionality on the sysctl(8) side. -- Hiroki ----Security_Multipart(Sun_Dec__2_08_21_50_2012_024)-- Content-Type: application/pgp-signature Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (FreeBSD) iEYEABECAAYFAlC6kQ4ACgkQTyzT2CeTzy1sjQCguq+9gj8qNTMzQJbV1uVmyoCL RagAoNktNXOzlZuAk5aZC9Ax7MH0oyiN =ZWBX -----END PGP SIGNATURE----- ----Security_Multipart(Sun_Dec__2_08_21_50_2012_024)---- From owner-freebsd-rc@FreeBSD.ORG Sat Dec 1 23:38:00 2012 Return-Path: Delivered-To: rc@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 2C680290; Sat, 1 Dec 2012 23:38:00 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) by mx1.freebsd.org (Postfix) with ESMTP id BBB708FC08; Sat, 1 Dec 2012 23:37:59 +0000 (UTC) Received: from tom.home (localhost [127.0.0.1]) by kib.kiev.ua (8.14.5/8.14.5) with ESMTP id qB1NbuZp010540; Sun, 2 Dec 2012 01:37:56 +0200 (EET) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.7.1 kib.kiev.ua qB1NbuZp010540 Received: (from kostik@localhost) by tom.home (8.14.5/8.14.5/Submit) id qB1NbutC010539; Sun, 2 Dec 2012 01:37:56 +0200 (EET) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Sun, 2 Dec 2012 01:37:56 +0200 From: Konstantin Belousov To: Hiroki Sato Subject: Re: RFC: sysctl -f filename Message-ID: <20121201233756.GS3013@kib.kiev.ua> References: <20121202.015048.1122480556487090170.hrs@allbsd.org> <20121202.082150.896017277887885294.hrs@allbsd.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="lfL9iWt62hyVv4Jn" Content-Disposition: inline In-Reply-To: <20121202.082150.896017277887885294.hrs@allbsd.org> User-Agent: Mutt/1.5.21 (2010-09-15) X-Spam-Status: No, score=-2.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FREEMAIL_FROM,NML_ADSP_CUSTOM_MED autolearn=no version=3.3.2 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on tom.home Cc: yanegomi@gmail.com, rc@freebsd.org, current@freebsd.org X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 01 Dec 2012 23:38:00 -0000 --lfL9iWt62hyVv4Jn Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Dec 02, 2012 at 08:21:50AM +0900, Hiroki Sato wrote: > Garrett Cooper wrote > in : >=20 > ya> On Sat, Dec 1, 2012 at 2:10 PM, Garrett Cooper w= rote: > ya> > Why change the tool when we can change the rc script to do the > ya> > right thing? I have a patch I'm working on to resolve this (you hit= an > ya> > itch I've been meaning to scratch for a little while). > ya> > ya> This should work. I also refactored the script to get it down to > ya> 80 columns. I've attached the debug output and the diff for the debug > ya> version of the script. >=20 > You will find out the following test case does not work (this is one > of the test strings I used): >=20 > kern.domainname=3D"c$EDITOR.\"\ hoge\ \"\#hoge2\\$ \# h$$\#oge"# >=20 > The reason why I changed sysctl(8) was that the rc.d/sysctl script > was too complex and slow even if it could support meta characters in > shell script syntax. I created several prototypes as script but > noticed that keeping consistency was quite difficult and > maintainability was poor due to tricky handling of variables. >=20 > Although my patch in the previous email does not support meta > characters completely, I still think it is more reasonable to > implement this functionality on the sysctl(8) side. >=20 > -- Hiroki I fully agree with the proposal to add the -f switch to the sysctl(8). This is consistent with several other administrative tools. Putting the ability to parse and apply arbitrary sysctl.conf-like file into=20 the rc script is weird. --lfL9iWt62hyVv4Jn Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (FreeBSD) iQIcBAEBAgAGBQJQupTTAAoJEJDCuSvBvK1BSLEQAIKuOn4rfK6jKjfEL1dbQV5k Ioqan+cvl4GoDZVBfF+NL6U22qBQdbuRa0rV8V1SnG8UYc/hjqd65Xxl00G6CRAb zhuR1kccpxjp2IN4wyYdGecXi00iRqdJeWGinL03Z/NpCr0zrgMR9RA5zM9KcJrZ vofQbkY/28VqsxxS6S/i8avbV3060T81EeupzFW5olv8Gf97M3nDiRJbP0S4EwXV QXs3rIONv+Y8+Ny00sVDfyBxfQ66nRYbmvlJcs/5SNW7cfk6BGg+4g81hNhmGlCb L4SKBMoiW+1Ls1AxhFOFUSFCL4xVINP6px4LqL/TJYR0mTrIYe7YCPDih4KYkIL4 U8DTbCbZTwBegnExNyDNeDgBug/JyIMrjBfFJeoNhKc6Kqw2inL5eO5lY49bE0hB ypiy8FXNjU0cW0OwrC8TvANstJ4Gif98DKjc9OufoatK7LKCDLgxPJ0gtV6mL+V4 605dXtURT6sIWgrrmSbYWVukUlEF7IOgCU/S2OZzz3mrsFC1kTlpOKboH+TLvLd8 OWaDJMnNEj5IOyQUJJ5RSAAKD9K9Pyy2StOLQOtoMCa5FdFANtVLnY3IXfh+wP2+ dqb2Wxg6r9h1iseaETCKxsDtroIw5GDqnYx1qZIUozD26q0hoiF5POn26jZKIMZ9 R7ym6rVAvCTGZlxULVyk =2uEK -----END PGP SIGNATURE----- --lfL9iWt62hyVv4Jn--