From owner-freebsd-scsi@FreeBSD.ORG Sun Jul 1 05:50:09 2012 Return-Path: Delivered-To: freebsd-scsi@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 7418A10656B8 for ; Sun, 1 Jul 2012 05:50:09 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 582F68FC12 for ; Sun, 1 Jul 2012 05:50:09 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id q615o9hn037094 for ; Sun, 1 Jul 2012 05:50:09 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.5/8.14.5/Submit) id q615o9R1037093; Sun, 1 Jul 2012 05:50:09 GMT (envelope-from gnats) Date: Sun, 1 Jul 2012 05:50:09 GMT Message-Id: <201207010550.q615o9R1037093@freefall.freebsd.org> To: freebsd-scsi@FreeBSD.org From: dfilter@FreeBSD.ORG (dfilter service) Cc: Subject: Re: kern/169497: commit references a PR X-BeenThere: freebsd-scsi@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: dfilter service List-Id: SCSI subsystem List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 01 Jul 2012 05:50:09 -0000 The following reply was made to PR kern/169497; it has been noted by GNATS. From: dfilter@FreeBSD.ORG (dfilter service) To: bug-followup@FreeBSD.org Cc: Subject: Re: kern/169497: commit references a PR Date: Sun, 1 Jul 2012 05:44:15 +0000 (UTC) Author: ken Date: Sun Jul 1 05:39:49 2012 New Revision: 237879 URL: http://svn.freebsd.org/changeset/base/237879 Log: MFC 237682: r237682 | ken | 2012-06-27 21:36:13 -0600 (Wed, 27 Jun 2012) | 6 lines Fix a typo in a panic() call. PR: kern/169497 Submitted by: Steven Hartland Modified: stable/9/sys/cam/cam_periph.c Directory Properties: stable/9/sys/ (props changed) Modified: stable/9/sys/cam/cam_periph.c ============================================================================== --- stable/9/sys/cam/cam_periph.c Sun Jul 1 05:32:26 2012 (r237878) +++ stable/9/sys/cam/cam_periph.c Sun Jul 1 05:39:49 2012 (r237879) @@ -273,7 +273,7 @@ failure: /* No cleanup to perform. */ break; default: - panic("cam_periph_alloc: Unkown init level"); + panic("%s: Unknown init level", __func__); } return(status); } _______________________________________________ svn-src-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org" From owner-freebsd-scsi@FreeBSD.ORG Sun Jul 1 05:50:12 2012 Return-Path: Delivered-To: freebsd-scsi@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 2097510656B7 for ; Sun, 1 Jul 2012 05:50:12 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 0BC2D8FC16 for ; Sun, 1 Jul 2012 05:50:12 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id q615oBSM037104 for ; Sun, 1 Jul 2012 05:50:11 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.5/8.14.5/Submit) id q615oBCg037102; Sun, 1 Jul 2012 05:50:11 GMT (envelope-from gnats) Date: Sun, 1 Jul 2012 05:50:11 GMT Message-Id: <201207010550.q615oBCg037102@freefall.freebsd.org> To: freebsd-scsi@FreeBSD.org From: dfilter@FreeBSD.ORG (dfilter service) Cc: Subject: Re: kern/169497: commit references a PR X-BeenThere: freebsd-scsi@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: dfilter service List-Id: SCSI subsystem List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 01 Jul 2012 05:50:12 -0000 The following reply was made to PR kern/169497; it has been noted by GNATS. From: dfilter@FreeBSD.ORG (dfilter service) To: bug-followup@FreeBSD.org Cc: Subject: Re: kern/169497: commit references a PR Date: Sun, 1 Jul 2012 05:44:36 +0000 (UTC) Author: ken Date: Sun Jul 1 05:40:33 2012 New Revision: 237880 URL: http://svn.freebsd.org/changeset/base/237880 Log: MFC 237682: r237682 | ken | 2012-06-27 21:36:13 -0600 (Wed, 27 Jun 2012) | 6 lines Fix a typo in a panic() call. PR: kern/169497 Submitted by: Steven Hartland Modified: stable/8/sys/cam/cam_periph.c Directory Properties: stable/8/sys/ (props changed) Modified: stable/8/sys/cam/cam_periph.c ============================================================================== --- stable/8/sys/cam/cam_periph.c Sun Jul 1 05:39:49 2012 (r237879) +++ stable/8/sys/cam/cam_periph.c Sun Jul 1 05:40:33 2012 (r237880) @@ -268,7 +268,7 @@ failure: /* No cleanup to perform. */ break; default: - panic("cam_periph_alloc: Unkown init level"); + panic("%s: Unknown init level", __func__); } return(status); } _______________________________________________ svn-src-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org" From owner-freebsd-scsi@FreeBSD.ORG Mon Jul 2 11:07:21 2012 Return-Path: Delivered-To: freebsd-scsi@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id F3C52106566B for ; Mon, 2 Jul 2012 11:07:20 +0000 (UTC) (envelope-from owner-bugmaster@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id DED658FC21 for ; Mon, 2 Jul 2012 11:07:20 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id q62B7KcX012735 for ; Mon, 2 Jul 2012 11:07:20 GMT (envelope-from owner-bugmaster@FreeBSD.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.5/8.14.5/Submit) id q62B7Kuq012733 for freebsd-scsi@FreeBSD.org; Mon, 2 Jul 2012 11:07:20 GMT (envelope-from owner-bugmaster@FreeBSD.org) Date: Mon, 2 Jul 2012 11:07:20 GMT Message-Id: <201207021107.q62B7Kuq012733@freefall.freebsd.org> X-Authentication-Warning: freefall.freebsd.org: gnats set sender to owner-bugmaster@FreeBSD.org using -f From: FreeBSD bugmaster To: freebsd-scsi@FreeBSD.org Cc: Subject: Current problem reports assigned to freebsd-scsi@FreeBSD.org X-BeenThere: freebsd-scsi@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SCSI subsystem List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 02 Jul 2012 11:07:21 -0000 Note: to view an individual PR, use: http://www.freebsd.org/cgi/query-pr.cgi?pr=(number). The following is a listing of current problems submitted by FreeBSD users. These represent problem reports covering all versions including experimental development code and obsolete releases. S Tracker Resp. Description -------------------------------------------------------------------------------- o kern/169431 scsi [mps] [cam] SAS bus scan generates thousands of lines o kern/165982 scsi [mpt] mpt instability, drive resets, and losses on Fre o kern/165740 scsi [cam] SCSI code must drain callbacks before free o kern/163713 scsi [aic7xxx] [patch] Add Adaptec29329LPE to aic79xx_pci.c o kern/162256 scsi [mpt] QUEUE FULL EVENT and 'mpt_cam_event: 0x0' o kern/161809 scsi [cam] [patch] set kern.cam.boot_delay via build option o kern/159412 scsi [ciss] 7.3 RELEASE: ciss0 ADAPTER HEARTBEAT FAILED err o kern/157770 scsi [iscsi] [panic] iscsi_initiator panic o kern/154432 scsi [xpt] run_interrupt_driven_hooks: still waiting after o kern/153514 scsi [cam] [panic] CAM related panic o kern/153361 scsi [ciss] Smart Array 5300 boot/detect drive problem o kern/152250 scsi [ciss] [patch] Kernel panic when hw.ciss.expose_hidden o kern/151564 scsi [ciss] ciss(4) should increase CISS_MAX_LOGICAL to 10 o docs/151336 scsi Missing documentation of scsi_ and ata_ functions in c s kern/149927 scsi [cam] hard drive not stopped before removing power dur o kern/148083 scsi [aac] Strange device reporting o kern/147704 scsi [mpt] sys/dev/mpt: new chip revision, partially unsupp o kern/146287 scsi [ciss] ciss(4) cannot see more than one SmartArray con o kern/145768 scsi [mpt] can't perform I/O on SAS based SAN disk in freeb o kern/144648 scsi [aac] Strange values of speed and bus width in dmesg o kern/144301 scsi [ciss] [hang] HP proliant server locks when using ciss o kern/142351 scsi [mpt] LSILogic driver performance problems o kern/134488 scsi [mpt] MPT SCSI driver probes max. 8 LUNs per device o kern/132250 scsi [ciss] ciss driver does not support more then 15 drive o kern/132206 scsi [mpt] system panics on boot when mirroring and 2nd dri o kern/130621 scsi [mpt] tranfer rate is inscrutable slow when use lsi213 o kern/129602 scsi [ahd] ahd(4) gets confused and wedges SCSI bus o kern/128452 scsi [sa] [panic] Accessing SCSI tape drive randomly crashe o kern/128245 scsi [scsi] "inquiry data fails comparison at DV1 step" [re o kern/127927 scsi [isp] isp(4) target driver crashes kernel when set up o kern/127717 scsi [ata] [patch] [request] - support write cache toggling o kern/123674 scsi [ahc] ahc driver dumping o kern/123520 scsi [ahd] unable to boot from net while using ahd o sparc/121676 scsi [iscsi] iscontrol do not connect iscsi-target on sparc o kern/120487 scsi [sg] scsi_sg incompatible with scanners o kern/120247 scsi [mpt] FreeBSD 6.3 and LSI Logic 1030 = only 3.300MB/s o kern/114597 scsi [sym] System hangs at SCSI bus reset with dual HBAs o kern/110847 scsi [ahd] Tyan U320 onboard problem with more than 3 disks o kern/99954 scsi [ahc] reading from DVD failes on 6.x [regression] o kern/92798 scsi [ahc] SCSI problem with timeouts o kern/90282 scsi [sym] SCSI bus resets cause loss of ch device o kern/76178 scsi [ahd] Problem with ahd and large SCSI Raid system o kern/74627 scsi [ahc] [hang] Adaptec 2940U2W Can't boot 5.3 s kern/61165 scsi [panic] kernel page fault after calling cam_send_ccb o kern/60641 scsi [sym] Sporadic SCSI bus resets with 53C810 under load o kern/60598 scsi wire down of scsi devices conflicts with config s kern/57398 scsi [mly] Current fails to install on mly(4) based RAID di o kern/52638 scsi [panic] SCSI U320 on SMP server won't run faster than o kern/44587 scsi dev/dpt/dpt.h is missing defines required for DPT_HAND o kern/39388 scsi ncr/sym drivers fail with 53c810 and more than 256MB m o kern/35234 scsi World access to /dev/pass? (for scanner) requires acce 51 problems total. From owner-freebsd-scsi@FreeBSD.ORG Mon Jul 2 21:55:25 2012 Return-Path: Delivered-To: freebsd-scsi@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id DD91E106566C; Mon, 2 Jul 2012 21:55:25 +0000 (UTC) (envelope-from ken@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id B37CB8FC17; Mon, 2 Jul 2012 21:55:25 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id q62LtPRK009015; Mon, 2 Jul 2012 21:55:25 GMT (envelope-from ken@freefall.freebsd.org) Received: (from ken@localhost) by freefall.freebsd.org (8.14.5/8.14.5/Submit) id q62LtPjB009011; Mon, 2 Jul 2012 21:55:25 GMT (envelope-from ken) Date: Mon, 2 Jul 2012 21:55:25 GMT Message-Id: <201207022155.q62LtPjB009011@freefall.freebsd.org> To: wollman@csail.mit.edu, ken@FreeBSD.org, freebsd-scsi@FreeBSD.org From: ken@FreeBSD.org Cc: Subject: Re: kern/169431: [mps] [cam] SAS bus scan generates thousands of lines to log X-BeenThere: freebsd-scsi@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SCSI subsystem List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 02 Jul 2012 21:55:26 -0000 Synopsis: [mps] [cam] SAS bus scan generates thousands of lines to log State-Changed-From-To: open->closed State-Changed-By: ken State-Changed-When: Mon Jul 2 21:54:20 UTC 2012 State-Changed-Why: Fixed in head in change 237683, stable/9 in change 237876, and stable/8 in change 237877. http://www.freebsd.org/cgi/query-pr.cgi?pr=169431 From owner-freebsd-scsi@FreeBSD.ORG Tue Jul 3 13:47:49 2012 Return-Path: Delivered-To: freebsd-scsi@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 4BE211065673 for ; Tue, 3 Jul 2012 13:47:49 +0000 (UTC) (envelope-from aboyer@averesystems.com) Received: from mail.averesystems.com (50-73-27-109-cpennsylvania.hfc.comcastbusiness.net [50.73.27.109]) by mx1.freebsd.org (Postfix) with ESMTP id 192218FC0C for ; Tue, 3 Jul 2012 13:47:49 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by mail.averesystems.com (Postfix) with ESMTP id C705248068D; Tue, 3 Jul 2012 09:47:51 -0400 (EDT) X-Virus-Scanned: amavisd-new at mail.averesystems.com Received: from mail.averesystems.com ([127.0.0.1]) by localhost (mail.averesystems.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id YmEz+AzK6hM8; Tue, 3 Jul 2012 09:47:51 -0400 (EDT) Received: from riven.arriad.com (206.193.225.214.nauticom.net [206.193.225.214]) by mail.averesystems.com (Postfix) with ESMTPSA id F3E3148067A; Tue, 3 Jul 2012 09:47:50 -0400 (EDT) From: Andrew Boyer Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Date: Tue, 3 Jul 2012 09:47:46 -0400 Message-Id: <909AAC62-7BB4-43E7-B04B-27466B038A07@averesystems.com> To: freebsd-scsi@freebsd.org Mime-Version: 1.0 (Apple Message framework v1278) X-Mailer: Apple Mail (2.1278) Cc: Sean Bruno Subject: [patch] MFI should set bio_resid on command failure X-BeenThere: freebsd-scsi@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SCSI subsystem List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Jul 2012 13:47:49 -0000 When an MFI command fails, the driver needs to set bio->bio_resid so = that the upper levels notice. Otherwise we see commands silently = failing leading to data corruption. This mirrors dadone(). -Andrew Index: sys/dev/mfi/mfi_disk.c =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D --- sys/dev/mfi/mfi_disk.c (revision 238071) +++ sys/dev/mfi/mfi_disk.c (working copy) @@ -298,6 +298,7 @@ hdr =3D bio->bio_driver1; =20 if (bio->bio_flags & BIO_ERROR) { + bio->bio_resid =3D bio->bio_bcount; if (bio->bio_error =3D=3D 0) bio->bio_error =3D EIO; disk_err(bio, "hard error", -1, 1); -------------------------------------------------- Andrew Boyer aboyer@averesystems.com From owner-freebsd-scsi@FreeBSD.ORG Tue Jul 3 18:42:21 2012 Return-Path: Delivered-To: freebsd-scsi@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 86DB51065670 for ; Tue, 3 Jul 2012 18:42:21 +0000 (UTC) (envelope-from seanbru@yahoo-inc.com) Received: from mrout2-b.corp.bf1.yahoo.com (mrout2-b.corp.bf1.yahoo.com [98.139.253.105]) by mx1.freebsd.org (Postfix) with ESMTP id 49CEA8FC08 for ; Tue, 3 Jul 2012 18:42:21 +0000 (UTC) Received: from [IPv6:::1] (rideseveral.corp.yahoo.com [10.73.160.231]) by mrout2-b.corp.bf1.yahoo.com (8.14.4/8.14.4/y.out) with ESMTP id q63Ifv7k041885; Tue, 3 Jul 2012 11:41:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=yahoo-inc.com; s=cobra; t=1341340918; bh=9PGzXkP2GvEGWAaPa7vLkGpQhXSAvoqjatI6BashtAk=; h=Subject:From:To:Cc:In-Reply-To:References:Content-Type:Date: Message-ID:Mime-Version:Content-Transfer-Encoding; b=SULppmPf5DgXZeTss3VB7nWGVrZmSSM16/bkqw3Xf/LPqKpzekGcpOYEYkvspAj6+ mxdmfq4H4QPc3Q8pICUtpKW4CP/zZ+/FLb0cI3FG/LotB3g5x5VItPWJa8uvqh5t/r rdqoAR5NWp/zU1Adb0GjBek8kFixxAIJNs6ajQuE= From: Sean Bruno To: Andrew Boyer In-Reply-To: <909AAC62-7BB4-43E7-B04B-27466B038A07@averesystems.com> References: <909AAC62-7BB4-43E7-B04B-27466B038A07@averesystems.com> Content-Type: text/plain; charset="UTF-8" Date: Tue, 03 Jul 2012 11:41:56 -0700 Message-ID: <1341340916.3370.6.camel@powernoodle.corp.yahoo.com> Mime-Version: 1.0 X-Mailer: Evolution 2.32.1 FreeBSD GNOME Team Port Content-Transfer-Encoding: 7bit X-Milter-Version: master.31+4-gbc07cd5+ X-CLX-ID: 340917003 Cc: "freebsd-scsi@freebsd.org" Subject: Re: [patch] MFI should set bio_resid on command failure X-BeenThere: freebsd-scsi@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SCSI subsystem List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Jul 2012 18:42:21 -0000 On Tue, 2012-07-03 at 06:47 -0700, Andrew Boyer wrote: > When an MFI command fails, the driver needs to set bio->bio_resid so that the upper levels notice. Otherwise we see commands silently failing leading to data corruption. This mirrors dadone(). > > -Andrew > > Index: sys/dev/mfi/mfi_disk.c > =================================================================== > --- sys/dev/mfi/mfi_disk.c (revision 238071) > +++ sys/dev/mfi/mfi_disk.c (working copy) > @@ -298,6 +298,7 @@ > hdr = bio->bio_driver1; > > if (bio->bio_flags & BIO_ERROR) { > + bio->bio_resid = bio->bio_bcount; > if (bio->bio_error == 0) > bio->bio_error = EIO; > disk_err(bio, "hard error", -1, 1); > > -------------------------------------------------- > Andrew Boyer aboyer@averesystems.com > This looks right to me. It mirrors the behavior in mfi_disk_strategy() as well. Sean