From owner-freebsd-scsi@FreeBSD.ORG Mon Jul 9 11:07:19 2012 Return-Path: Delivered-To: freebsd-scsi@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id AF3B21065676 for ; Mon, 9 Jul 2012 11:07:19 +0000 (UTC) (envelope-from owner-bugmaster@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 98D298FC29 for ; Mon, 9 Jul 2012 11:07:19 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id q69B7J21075546 for ; Mon, 9 Jul 2012 11:07:19 GMT (envelope-from owner-bugmaster@FreeBSD.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.5/8.14.5/Submit) id q69B7IQA075544 for freebsd-scsi@FreeBSD.org; Mon, 9 Jul 2012 11:07:18 GMT (envelope-from owner-bugmaster@FreeBSD.org) Date: Mon, 9 Jul 2012 11:07:18 GMT Message-Id: <201207091107.q69B7IQA075544@freefall.freebsd.org> X-Authentication-Warning: freefall.freebsd.org: gnats set sender to owner-bugmaster@FreeBSD.org using -f From: FreeBSD bugmaster To: freebsd-scsi@FreeBSD.org Cc: Subject: Current problem reports assigned to freebsd-scsi@FreeBSD.org X-BeenThere: freebsd-scsi@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SCSI subsystem List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 09 Jul 2012 11:07:19 -0000 Note: to view an individual PR, use: http://www.freebsd.org/cgi/query-pr.cgi?pr=(number). The following is a listing of current problems submitted by FreeBSD users. These represent problem reports covering all versions including experimental development code and obsolete releases. S Tracker Resp. Description -------------------------------------------------------------------------------- o kern/165982 scsi [mpt] mpt instability, drive resets, and losses on Fre o kern/165740 scsi [cam] SCSI code must drain callbacks before free o kern/163713 scsi [aic7xxx] [patch] Add Adaptec29329LPE to aic79xx_pci.c o kern/162256 scsi [mpt] QUEUE FULL EVENT and 'mpt_cam_event: 0x0' o kern/161809 scsi [cam] [patch] set kern.cam.boot_delay via build option o kern/159412 scsi [ciss] 7.3 RELEASE: ciss0 ADAPTER HEARTBEAT FAILED err o kern/157770 scsi [iscsi] [panic] iscsi_initiator panic o kern/154432 scsi [xpt] run_interrupt_driven_hooks: still waiting after o kern/153514 scsi [cam] [panic] CAM related panic o kern/153361 scsi [ciss] Smart Array 5300 boot/detect drive problem o kern/152250 scsi [ciss] [patch] Kernel panic when hw.ciss.expose_hidden o kern/151564 scsi [ciss] ciss(4) should increase CISS_MAX_LOGICAL to 10 o docs/151336 scsi Missing documentation of scsi_ and ata_ functions in c s kern/149927 scsi [cam] hard drive not stopped before removing power dur o kern/148083 scsi [aac] Strange device reporting o kern/147704 scsi [mpt] sys/dev/mpt: new chip revision, partially unsupp o kern/146287 scsi [ciss] ciss(4) cannot see more than one SmartArray con o kern/145768 scsi [mpt] can't perform I/O on SAS based SAN disk in freeb o kern/144648 scsi [aac] Strange values of speed and bus width in dmesg o kern/144301 scsi [ciss] [hang] HP proliant server locks when using ciss o kern/142351 scsi [mpt] LSILogic driver performance problems o kern/134488 scsi [mpt] MPT SCSI driver probes max. 8 LUNs per device o kern/132250 scsi [ciss] ciss driver does not support more then 15 drive o kern/132206 scsi [mpt] system panics on boot when mirroring and 2nd dri o kern/130621 scsi [mpt] tranfer rate is inscrutable slow when use lsi213 o kern/129602 scsi [ahd] ahd(4) gets confused and wedges SCSI bus o kern/128452 scsi [sa] [panic] Accessing SCSI tape drive randomly crashe o kern/128245 scsi [scsi] "inquiry data fails comparison at DV1 step" [re o kern/127927 scsi [isp] isp(4) target driver crashes kernel when set up o kern/127717 scsi [ata] [patch] [request] - support write cache toggling o kern/123674 scsi [ahc] ahc driver dumping o kern/123520 scsi [ahd] unable to boot from net while using ahd o sparc/121676 scsi [iscsi] iscontrol do not connect iscsi-target on sparc o kern/120487 scsi [sg] scsi_sg incompatible with scanners o kern/120247 scsi [mpt] FreeBSD 6.3 and LSI Logic 1030 = only 3.300MB/s o kern/114597 scsi [sym] System hangs at SCSI bus reset with dual HBAs o kern/110847 scsi [ahd] Tyan U320 onboard problem with more than 3 disks o kern/99954 scsi [ahc] reading from DVD failes on 6.x [regression] o kern/92798 scsi [ahc] SCSI problem with timeouts o kern/90282 scsi [sym] SCSI bus resets cause loss of ch device o kern/76178 scsi [ahd] Problem with ahd and large SCSI Raid system o kern/74627 scsi [ahc] [hang] Adaptec 2940U2W Can't boot 5.3 s kern/61165 scsi [panic] kernel page fault after calling cam_send_ccb o kern/60641 scsi [sym] Sporadic SCSI bus resets with 53C810 under load o kern/60598 scsi wire down of scsi devices conflicts with config s kern/57398 scsi [mly] Current fails to install on mly(4) based RAID di o kern/52638 scsi [panic] SCSI U320 on SMP server won't run faster than o kern/44587 scsi dev/dpt/dpt.h is missing defines required for DPT_HAND o kern/39388 scsi ncr/sym drivers fail with 53c810 and more than 256MB m o kern/35234 scsi World access to /dev/pass? (for scanner) requires acce 50 problems total. From owner-freebsd-scsi@FreeBSD.ORG Tue Jul 10 06:20:12 2012 Return-Path: Delivered-To: freebsd-scsi@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id E3254106566C for ; Tue, 10 Jul 2012 06:20:12 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id B5AFB8FC12 for ; Tue, 10 Jul 2012 06:20:12 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id q6A6KCuF036981 for ; Tue, 10 Jul 2012 06:20:12 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.5/8.14.5/Submit) id q6A6KCWq036980; Tue, 10 Jul 2012 06:20:12 GMT (envelope-from gnats) Date: Tue, 10 Jul 2012 06:20:12 GMT Message-Id: <201207100620.q6A6KCWq036980@freefall.freebsd.org> To: freebsd-scsi@FreeBSD.org From: Randy Bush Cc: Subject: Re: kern/169431: [mps] [cam] SAS bus scan generates thousands of lines to log X-BeenThere: freebsd-scsi@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Randy Bush List-Id: SCSI subsystem List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Jul 2012 06:20:13 -0000 The following reply was made to PR kern/169431; it has been noted by GNATS. From: Randy Bush To: bug-followup@FreeBSD.org, wollman@csail.mit.edu Cc: Subject: Re: kern/169431: [mps] [cam] SAS bus scan generates thousands of lines to log Date: Tue, 10 Jul 2012 15:18:15 +0900 problem exists with hpt on releng_9 cvsupped as of today From owner-freebsd-scsi@FreeBSD.ORG Tue Jul 10 16:37:12 2012 Return-Path: Delivered-To: freebsd-scsi@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id BF4F3106564A for ; Tue, 10 Jul 2012 16:37:11 +0000 (UTC) (envelope-from aboyer@averesystems.com) Received: from mail.averesystems.com (50-73-27-109-cpennsylvania.hfc.comcastbusiness.net [50.73.27.109]) by mx1.freebsd.org (Postfix) with ESMTP id 873CD8FC17 for ; Tue, 10 Jul 2012 16:37:11 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by mail.averesystems.com (Postfix) with ESMTP id B12C048064B; Tue, 10 Jul 2012 12:37:14 -0400 (EDT) X-Virus-Scanned: amavisd-new at mail.averesystems.com Received: from mail.averesystems.com ([127.0.0.1]) by localhost (mail.averesystems.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id VCjxvPf-U+ND; Tue, 10 Jul 2012 12:37:10 -0400 (EDT) Received: from riven.arriad.com (206.193.225.214.nauticom.net [206.193.225.214]) by mail.averesystems.com (Postfix) with ESMTPSA id 0C6064804AE; Tue, 10 Jul 2012 12:37:09 -0400 (EDT) Mime-Version: 1.0 (Apple Message framework v1278) Content-Type: text/plain; charset=windows-1252 From: Andrew Boyer In-Reply-To: <1341340916.3370.6.camel@powernoodle.corp.yahoo.com> Date: Tue, 10 Jul 2012 12:37:03 -0400 Content-Transfer-Encoding: quoted-printable Message-Id: <2936EBFD-CA1E-4EC4-9790-80D1A5DC5567@averesystems.com> References: <909AAC62-7BB4-43E7-B04B-27466B038A07@averesystems.com> <1341340916.3370.6.camel@powernoodle.corp.yahoo.com> To: Sean Bruno X-Mailer: Apple Mail (2.1278) Cc: "freebsd-scsi@freebsd.org" Subject: Re: [patch] MFI should set bio_resid on command failure X-BeenThere: freebsd-scsi@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SCSI subsystem List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Jul 2012 16:37:12 -0000 On Jul 3, 2012, at 2:41 PM, Sean Bruno wrote: > On Tue, 2012-07-03 at 06:47 -0700, Andrew Boyer wrote: >> When an MFI command fails, the driver needs to set bio->bio_resid so = that the upper levels notice. Otherwise we see commands silently = failing leading to data corruption. This mirrors dadone(). >>=20 >> -Andrew >>=20 >> Index: sys/dev/mfi/mfi_disk.c >> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D >> --- sys/dev/mfi/mfi_disk.c (revision 238071) >> +++ sys/dev/mfi/mfi_disk.c (working copy) >> @@ -298,6 +298,7 @@ >> hdr =3D bio->bio_driver1; >>=20 >> if (bio->bio_flags & BIO_ERROR) { >> + bio->bio_resid =3D bio->bio_bcount; >> if (bio->bio_error =3D=3D 0) >> bio->bio_error =3D EIO; >> disk_err(bio, "hard error", -1, 1); >>=20 >> -------------------------------------------------- >> Andrew Boyer aboyer@averesystems.com >>=20 >=20 > This looks right to me. It mirrors the behavior in = mfi_disk_strategy() > as well. >=20 > Sean >=20 Anyone interested in committing? (And MFC'ing to stable/8=85) -Andrew -------------------------------------------------- Andrew Boyer aboyer@averesystems.com From owner-freebsd-scsi@FreeBSD.ORG Tue Jul 10 16:44:03 2012 Return-Path: Delivered-To: freebsd-scsi@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 99F171065673 for ; Tue, 10 Jul 2012 16:44:03 +0000 (UTC) (envelope-from aboyer@averesystems.com) Received: from mail.averesystems.com (50-73-27-109-cpennsylvania.hfc.comcastbusiness.net [50.73.27.109]) by mx1.freebsd.org (Postfix) with ESMTP id 661888FC17 for ; Tue, 10 Jul 2012 16:44:03 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by mail.averesystems.com (Postfix) with ESMTP id 184DE4806C8 for ; Tue, 10 Jul 2012 12:44:05 -0400 (EDT) X-Virus-Scanned: amavisd-new at mail.averesystems.com Received: from mail.averesystems.com ([127.0.0.1]) by localhost (mail.averesystems.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id WVABv4TnDkBT for ; Tue, 10 Jul 2012 12:44:04 -0400 (EDT) Received: from riven.arriad.com (206.193.225.214.nauticom.net [206.193.225.214]) by mail.averesystems.com (Postfix) with ESMTPSA id A84664804AE for ; Tue, 10 Jul 2012 12:44:04 -0400 (EDT) From: Andrew Boyer Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Date: Tue, 10 Jul 2012 12:43:59 -0400 Message-Id: To: freebsd-scsi@freebsd.org Mime-Version: 1.0 (Apple Message framework v1278) X-Mailer: Apple Mail (2.1278) Subject: [patch] MFI mfivar.h needs to include the option header X-BeenThere: freebsd-scsi@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SCSI subsystem List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Jul 2012 16:44:03 -0000 sys/dev/mfivar.h contains references to MFI_DEBUG, but it never gets = turned on unless the file also includes opt_mfi.h. -Andrew Index: sys/dev/mfi/mfivar.h =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D --- sys/dev/mfi/mfivar.h (revision 238348) +++ sys/dev/mfi/mfivar.h (working copy) @@ -61,6 +61,7 @@ =20 #include #include +#include "opt_mfi.h" =20 /* * SCSI structures and definitions are used from here, but no linking -------------------------------------------------- Andrew Boyer aboyer@averesystems.com From owner-freebsd-scsi@FreeBSD.ORG Tue Jul 10 17:02:06 2012 Return-Path: Delivered-To: freebsd-scsi@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 66B7E1065670; Tue, 10 Jul 2012 17:02:06 +0000 (UTC) (envelope-from seanbru@yahoo-inc.com) Received: from mrout1-b.corp.bf1.yahoo.com (mrout1-b.corp.bf1.yahoo.com [98.139.253.104]) by mx1.freebsd.org (Postfix) with ESMTP id 247208FC0A; Tue, 10 Jul 2012 17:02:06 +0000 (UTC) Received: from [IPv6:::1] (rideseveral.corp.yahoo.com [10.73.160.231]) by mrout1-b.corp.bf1.yahoo.com (8.14.4/8.14.4/y.out) with ESMTP id q6AH0sY6009755; Tue, 10 Jul 2012 10:00:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=yahoo-inc.com; s=cobra; t=1341939656; bh=IR1KNwLcw7qQh7pNG8nj1Z8K91kGCAiTOvPm/jt+1Tc=; h=Subject:From:To:Cc:In-Reply-To:References:Content-Type:Date: Message-ID:Mime-Version:Content-Transfer-Encoding; b=obunHMdu3YF3WFZH3r61fqmho8m1m8AzYhLFoSTgy801MPDLqoBVqltE3N0zgqI0M Eg8sOm6IRaLcJtw4Zer2UTlkg92A5eTPxB3+Z9kq4jPKP79EVCt1RMEP6qb7MxSLxo Aa9Xi3njCklY0F9/+ZD1UUW42aLT8mVQuOyjSFq4= From: Sean Bruno To: Andrew Boyer In-Reply-To: <2936EBFD-CA1E-4EC4-9790-80D1A5DC5567@averesystems.com> References: <909AAC62-7BB4-43E7-B04B-27466B038A07@averesystems.com> <1341340916.3370.6.camel@powernoodle.corp.yahoo.com> <2936EBFD-CA1E-4EC4-9790-80D1A5DC5567@averesystems.com> Content-Type: text/plain; charset="UTF-8" Date: Tue, 10 Jul 2012 09:43:49 -0700 Message-ID: <1341938629.2573.7.camel@powernoodle.corp.yahoo.com> Mime-Version: 1.0 X-Mailer: Evolution 2.32.1 FreeBSD GNOME Team Port Content-Transfer-Encoding: 8bit X-Milter-Version: master.31+4-gbc07cd5+ X-CLX-ID: 939655002 Cc: "freebsd-scsi@freebsd.org" , scottl@freebsd.org, "ambrisko@FreeBSD.ORG" Subject: Re: [patch] MFI should set bio_resid on command failure X-BeenThere: freebsd-scsi@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SCSI subsystem List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Jul 2012 17:02:06 -0000 On Tue, 2012-07-10 at 09:37 -0700, Andrew Boyer wrote: > On Jul 3, 2012, at 2:41 PM, Sean Bruno wrote: > > > On Tue, 2012-07-03 at 06:47 -0700, Andrew Boyer wrote: > >> When an MFI command fails, the driver needs to set bio->bio_resid so that the upper levels notice. Otherwise we see commands silently failing leading to data corruption. This mirrors dadone(). > >> > >> -Andrew > >> > >> Index: sys/dev/mfi/mfi_disk.c > >> =================================================================== > >> --- sys/dev/mfi/mfi_disk.c (revision 238071) > >> +++ sys/dev/mfi/mfi_disk.c (working copy) > >> @@ -298,6 +298,7 @@ > >> hdr = bio->bio_driver1; > >> > >> if (bio->bio_flags & BIO_ERROR) { > >> + bio->bio_resid = bio->bio_bcount; > >> if (bio->bio_error == 0) > >> bio->bio_error = EIO; > >> disk_err(bio, "hard error", -1, 1); > >> > >> -------------------------------------------------- > >> Andrew Boyer aboyer@averesystems.com > >> > > > > This looks right to me. It mirrors the behavior in mfi_disk_strategy() > > as well. > > > > Sean > > > > Anyone interested in committing? (And MFC'ing to stable/8…) > > -Andrew > > -------------------------------------------------- > Andrew Boyer aboyer@averesystems.com > > > Let me hit dougA and scottl for validation. Their wisdom here can validate my naivete. Sean From owner-freebsd-scsi@FreeBSD.ORG Tue Jul 10 19:59:13 2012 Return-Path: Delivered-To: freebsd-scsi@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 471AD106564A for ; Tue, 10 Jul 2012 19:59:13 +0000 (UTC) (envelope-from scott4long@yahoo.com) Received: from nm26-vm0.bullet.mail.sp2.yahoo.com (nm26-vm0.bullet.mail.sp2.yahoo.com [98.139.91.230]) by mx1.freebsd.org (Postfix) with SMTP id 1214A8FC0C for ; Tue, 10 Jul 2012 19:59:13 +0000 (UTC) Received: from [98.139.91.69] by nm26.bullet.mail.sp2.yahoo.com with NNFMP; 10 Jul 2012 19:59:07 -0000 Received: from [98.139.91.1] by tm9.bullet.mail.sp2.yahoo.com with NNFMP; 10 Jul 2012 19:59:07 -0000 Received: from [127.0.0.1] by omp1001.mail.sp2.yahoo.com with NNFMP; 10 Jul 2012 19:59:07 -0000 X-Yahoo-Newman-Property: ymail-3 X-Yahoo-Newman-Id: 221399.40610.bm@omp1001.mail.sp2.yahoo.com Received: (qmail 97568 invoked by uid 60001); 10 Jul 2012 19:59:07 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s1024; t=1341950347; bh=NPTdvVmO2OAVtqqerzvd9UUo05Jir9CW1gOP3lXf4w0=; h=X-YMail-OSG:Received:X-Mailer:References:Message-ID:Date:From:Reply-To:Subject:To:Cc:In-Reply-To:MIME-Version:Content-Type:Content-Transfer-Encoding; b=juKdBAE0xPdHEeeVlGhVoJSG5KcrLfRmw2QJHhZh8F6v/F2Yk8CqR5Nj4rkn5hG0k0/L72Ock61gJIsZRU1uL3JcizMvQwS8eZr5FgRIeJ83Er+u/Ym6fqida6wHBsq5yeACVCwuSOJ2bns9jFE7cW8abY35l8Ru6S8WSGVc3NU= DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=s1024; d=yahoo.com; h=X-YMail-OSG:Received:X-Mailer:References:Message-ID:Date:From:Reply-To:Subject:To:Cc:In-Reply-To:MIME-Version:Content-Type:Content-Transfer-Encoding; b=poj30jD7oJttAMZs8q/vc66N/h7hFv0e9H13nUQDoSRrlvSYGx1iNF/sSAAuv0PgYsiS+5ftB6/9iB2ZeYDcO7XKtAzjl5bzszIDuB8XxfBjanf9EsIr+EmtsjDbbOTAX4CnEosD0vrW7PVB2x6lXMIwFGgzB9dl2ViAW7R4ot4=; X-YMail-OSG: xkX94CgVM1mIQWbvlrtbACZHoOdjML5EEMoaSTIdx.qV0C1 PJ7MC6eLXB4MvAdQ6wkTukThH2L6_BVVHJXDOZr._AV9ncgTil99snWgHVnQ d.1nJmofL5SoXU3CKxhiG560UAe7lLGOtcAbLWPxEgj5BQ1FKY4N0agr6ROz 7aGq_iZvgYrmcBaOzej96pUS.bd1J7h4yqMMEqTlsQoGtfSrhZPW_fCCAT3Q CoZosigtsdDpRhQgUejeCgaDAoobofwvorRw_3kxmbyg1P3xAt3Rh8JvMdH6 YUC6R.fkSt3GJPZ_jhbIKgOJ_TBCRbFLM5Qp1KziDDourjSHu1xuWD5gfWH3 vxW642WC0nvgJY.6Ky9xVwsJfD7qSAk6SycOaJQjm1bi3GAou6wmNGl5YN87 p1xKNUjMfcB8tzqIXkr3wj_B94wvuZG.FNnBw2oXkhdDDRpwI6HjtwwNZ5ux ZxVvaE4Jip_U- Received: from [69.53.237.66] by web45701.mail.sp1.yahoo.com via HTTP; Tue, 10 Jul 2012 12:59:07 PDT X-Mailer: YahooMailWebService/0.8.120.356233 References: <909AAC62-7BB4-43E7-B04B-27466B038A07@averesystems.com> <1341340916.3370.6.camel@powernoodle.corp.yahoo.com> <2936EBFD-CA1E-4EC4-9790-80D1A5DC5567@averesystems.com> <1341938629.2573.7.camel@powernoodle.corp.yahoo.com> Message-ID: <1341950347.63294.YahooMailNeo@web45701.mail.sp1.yahoo.com> Date: Tue, 10 Jul 2012 12:59:07 -0700 (PDT) From: Scott Long To: Sean Bruno , Andrew Boyer In-Reply-To: <1341938629.2573.7.camel@powernoodle.corp.yahoo.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Cc: "freebsd-scsi@freebsd.org" , "scottl@freebsd.org" , "ambrisko@FreeBSD.ORG" Subject: Re: [patch] MFI should set bio_resid on command failure X-BeenThere: freebsd-scsi@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Scott Long List-Id: SCSI subsystem List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Jul 2012 19:59:13 -0000 =0A=0A=0A=0A----- Original Message -----=0A> From: Sean Bruno =0A> To: Andrew Boyer =0A> Cc: "freebsd-= scsi@freebsd.org" ; scottl@freebsd.org; "ambrisko= @FreeBSD.ORG" =0A> Sent: Tuesday, July 10, 2012 10:43= AM=0A> Subject: Re: [patch] MFI should set bio_resid on command failure=0A= > =0A> On Tue, 2012-07-10 at 09:37 -0700, Andrew Boyer wrote:=0A>> On Jul = 3, 2012, at 2:41 PM, Sean Bruno wrote:=0A>> =0A>> > On Tue, 2012-07-03 at = 06:47 -0700, Andrew Boyer wrote:=0A>> >> When an MFI command fails, the dr= iver needs to set =0A> bio->bio_resid so that the upper levels notice.=C2= =A0 Otherwise we see commands =0A> silently failing leading to data corrupt= ion.=C2=A0 This mirrors dadone().=0A>> >> =0A>> >> -Andrew=0A>> >> =0A>>= >> Index: sys/dev/mfi/mfi_disk.c=0A>> >> =0A> =3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=0A>> >> --- sys/dev/mfi/mfi_disk.c=C2=A0=C2=A0= =C2=A0 (revision 238071)=0A>> >> +++ sys/dev/mfi/mfi_disk.c=C2=A0=C2=A0=C2= =A0 (working copy)=0A>> >> @@ -298,6 +298,7 @@=0A>> >> =C2=A0=C2=A0=C2=A0= hdr =3D bio->bio_driver1;=0A>> >> =0A>> >> =C2=A0=C2=A0=C2=A0 if (bio->b= io_flags & BIO_ERROR) {=0A>> >> +=C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0 bio= ->bio_resid =3D bio->bio_bcount;=0A>> >> =C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0= =C2=A0 if (bio->bio_error =3D=3D 0)=0A>> >> =C2=A0=C2=A0=C2=A0 =C2=A0=C2= =A0=C2=A0 =C2=A0=C2=A0=C2=A0 bio->bio_error =3D EIO;=0A>> >> =C2=A0=C2=A0= =C2=A0 =C2=A0=C2=A0=C2=A0 disk_err(bio, "hard error", -1, 1);=0A>> >> =0A>= > >> --------------------------------------------------=0A>> >> Andrew Bo= yer=C2=A0=C2=A0=C2=A0 aboyer@averesystems.com=0A>> >> =0A>> > =0A>> > Th= is looks right to me.=C2=A0 It mirrors the behavior in =0A> mfi_disk_strate= gy()=0A>> > as well.=0A>> > =0A>> > Sean=0A>> > =0A>> =0A>> Anyone int= erested in committing?=C2=A0 (And MFC'ing to stable/8=E2=80=A6)=0A>> =0A>> = -Andrew=0A>> =0A>> --------------------------------------------------=0A>= > Andrew Boyer=C2=A0=C2=A0=C2=A0 aboyer@averesystems.com=0A>> =0A>> =0A>> = =0A> =0A> Let me hit dougA and scottl for validation.=C2=A0 Their wisdom he= re can=0A> validate my naivete.=0A> =0A=0A=0AYeah, b_resid needs to be set,= and a lot of drivers get this wrong.=0A=0AScott=0A From owner-freebsd-scsi@FreeBSD.ORG Wed Jul 11 15:53:53 2012 Return-Path: Delivered-To: freebsd-scsi@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 46220106566B for ; Wed, 11 Jul 2012 15:53:53 +0000 (UTC) (envelope-from miles.kuo@gmail.com) Received: from mail-pb0-f54.google.com (mail-pb0-f54.google.com [209.85.160.54]) by mx1.freebsd.org (Postfix) with ESMTP id 165B88FC14 for ; Wed, 11 Jul 2012 15:53:53 +0000 (UTC) Received: by pbbro2 with SMTP id ro2so2462263pbb.13 for ; Wed, 11 Jul 2012 08:53:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type; bh=mOdJsEsWP8hb+QvrNjRhrdTI6SBD7Um9gpnsulQeRUI=; b=soolpDeTaO3AffYaSK9kdnfX8fa8jOW4k7YHhuEsO+/+pRmteDlyAGUBEC7+hGdDJx jkx9LQLtAOqulnSNL4jVYRxJMV2JId7TdfE5Q27R9S5UjGcYsVeQKVPzzt2mvzBWGkk3 ioQkuSt/mfjccqZcO1CYhKWCTuGHnJyZBPcFEYtK6wnn7EqJCHirOlTWWlsjHgzkoknm 9X32g78RXpQLA42s+04xT/fOLYUErHbS0FseACcWL65eLpmaNBhMj10ojm/d2dl1U4cb 0rvNjPNG17Am7EWxSWydRJrSsENnOTcSQquTnNxdZ2SPDh6CXfCdu/UL41G3aIdKGfRg shYQ== MIME-Version: 1.0 Received: by 10.68.237.105 with SMTP id vb9mr79480017pbc.103.1342022032598; Wed, 11 Jul 2012 08:53:52 -0700 (PDT) Received: by 10.67.14.72 with HTTP; Wed, 11 Jul 2012 08:53:52 -0700 (PDT) In-Reply-To: <81701ED3-B8DA-41DA-9911-5CF3DD28E84C@FreeBSD.org> References: <81701ED3-B8DA-41DA-9911-5CF3DD28E84C@FreeBSD.org> Date: Wed, 11 Jul 2012 23:53:52 +0800 Message-ID: From: miles kuo To: freebsd-scsi@freebsd.org Content-Type: text/plain; charset=ISO-8859-1 X-Content-Filtered-By: Mailman/MimeDel 2.1.5 Subject: Fwd: Does the FreeBSD support ServeRAID M5110 (LSI SAS2208 ROC) in plan? X-BeenThere: freebsd-scsi@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SCSI subsystem List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 11 Jul 2012 15:53:53 -0000 Does anyone know if the FreeBSD support ServeRAID M5110 (LSI SAS2208 ROC) in plan? ---------- Forwarded message ---------- From: Philip Paeps Date: 2012/7/11 Subject: Re: Does the FreeBSD support ServeRAID M5110 (LSI SAS2208 ROC) in plan? To: miles kuo On 11 Jul 2012, at 10:41, miles kuo wrote: > I fond you submitted a patch about the ServeRAID M5110. The patch you quote is an update to the PCI IDs database. This file just lists all known PCI devices and their vendors, so that the 'pciconf' tool can identify them by name. Unfortunately, just because we know what a device is called and who manufactures it, does not mean that we actually support it. > Does it mean that the FreeBSD has been support the ServeRAID M5110 adapter? I don't know if FreeBSD supports this hardware. A good place to ask this question would be on the freebsd-scsi mailing list or perhaps on freebsd-questions. Best wishes. - Philip -- Philip Paeps Senior Reality Engineer Ministry of Information From owner-freebsd-scsi@FreeBSD.ORG Wed Jul 11 19:16:50 2012 Return-Path: Delivered-To: freebsd-scsi@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id AB9B2106564A for ; Wed, 11 Jul 2012 19:16:50 +0000 (UTC) (envelope-from seanbru@yahoo-inc.com) Received: from mrout1-b.corp.bf1.yahoo.com (mrout1-b.corp.bf1.yahoo.com [98.139.253.104]) by mx1.freebsd.org (Postfix) with ESMTP id 534B18FC0C for ; Wed, 11 Jul 2012 19:16:50 +0000 (UTC) Received: from [IPv6:::1] (rideseveral.corp.yahoo.com [10.73.160.231]) by mrout1-b.corp.bf1.yahoo.com (8.14.4/8.14.4/y.out) with ESMTP id q6BJFAcl071531; Wed, 11 Jul 2012 12:15:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=yahoo-inc.com; s=cobra; t=1342034111; bh=1h3eMI1x901TVG0MwmLxi4I5jYozgIxAUZqM9PPB5pA=; h=Subject:From:To:Cc:In-Reply-To:References:Content-Type:Date: Message-ID:Mime-Version:Content-Transfer-Encoding; b=J9qdMWHqvUn2WNrrMKbjDCbNpilJRGQgLP7va64NgBIL8ufc4433VjDTiAnTpNYm3 4VkHOdUSyoHgWnLeR+FGI8Tqw0wWJtFIiSzTMXpncDBdSrWzw8X8wLOs3Zm16IUPMA q+c5IkP12O0cjg+22i9aZIRTsFBrfHr/SYLdbQRA= From: Sean Bruno To: Andrew Boyer In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Date: Wed, 11 Jul 2012 12:15:09 -0700 Message-ID: <1342034109.9662.7.camel@powernoodle.corp.yahoo.com> Mime-Version: 1.0 X-Mailer: Evolution 2.32.1 FreeBSD GNOME Team Port Content-Transfer-Encoding: 7bit X-Milter-Version: master.31+4-gbc07cd5+ X-CLX-ID: 034110001 Cc: "freebsd-scsi@freebsd.org" Subject: Re: [patch] MFI mfivar.h needs to include the option header X-BeenThere: freebsd-scsi@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SCSI subsystem List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 11 Jul 2012 19:16:50 -0000 On Tue, 2012-07-10 at 09:43 -0700, Andrew Boyer wrote: > sys/dev/mfivar.h contains references to MFI_DEBUG, but it never gets turned on unless the file also includes opt_mfi.h. > > -Andrew > > Index: sys/dev/mfi/mfivar.h > =================================================================== > --- sys/dev/mfi/mfivar.h (revision 238348) > +++ sys/dev/mfi/mfivar.h (working copy) > @@ -61,6 +61,7 @@ > > #include > #include > +#include "opt_mfi.h" > > /* > * SCSI structures and definitions are used from here, but no linking > > -------------------------------------------------- > Andrew Boyer aboyer@averesystems.com > Committed at svn r238373 Sean From owner-freebsd-scsi@FreeBSD.ORG Wed Jul 11 19:17:16 2012 Return-Path: Delivered-To: freebsd-scsi@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 79AEB1065676; Wed, 11 Jul 2012 19:17:16 +0000 (UTC) (envelope-from seanbru@yahoo-inc.com) Received: from mrout1-b.corp.bf1.yahoo.com (mrout1-b.corp.bf1.yahoo.com [98.139.253.104]) by mx1.freebsd.org (Postfix) with ESMTP id 365308FC14; Wed, 11 Jul 2012 19:17:16 +0000 (UTC) Received: from [IPv6:::1] (rideseveral.corp.yahoo.com [10.73.160.231]) by mrout1-b.corp.bf1.yahoo.com (8.14.4/8.14.4/y.out) with ESMTP id q6BJGIRb072054; Wed, 11 Jul 2012 12:16:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=yahoo-inc.com; s=cobra; t=1342034179; bh=KqPDAGENBg4uy2apjLk1xKhWgFArK0cCr3tP67JdB6g=; h=Subject:From:To:Cc:In-Reply-To:References:Content-Type:Date: Message-ID:Mime-Version:Content-Transfer-Encoding; b=tD6zhUc1BUjNgBn91SDG/Vn0ItxS9DB5qEMtkTwLanMg6NfZNAlpldSPtKmWRIQXJ 1Saf9uZfGOIzQiJ40F0qzZjakTNUFPMWhvT15kYn/zb1V0jPRqUfLJ4NoB18k44KP+ /vVa7xmpGRMu9euvWowpHFHT9slWEYodvllnbShw= From: Sean Bruno To: Scott Long In-Reply-To: <1341950347.63294.YahooMailNeo@web45701.mail.sp1.yahoo.com> References: <909AAC62-7BB4-43E7-B04B-27466B038A07@averesystems.com> <1341340916.3370.6.camel@powernoodle.corp.yahoo.com> <2936EBFD-CA1E-4EC4-9790-80D1A5DC5567@averesystems.com> <1341938629.2573.7.camel@powernoodle.corp.yahoo.com> <1341950347.63294.YahooMailNeo@web45701.mail.sp1.yahoo.com> Content-Type: text/plain; charset="UTF-8" Date: Wed, 11 Jul 2012 12:16:18 -0700 Message-ID: <1342034178.9662.8.camel@powernoodle.corp.yahoo.com> Mime-Version: 1.0 X-Mailer: Evolution 2.32.1 FreeBSD GNOME Team Port Content-Transfer-Encoding: 7bit X-Milter-Version: master.31+4-gbc07cd5+ X-CLX-ID: 034178002 Cc: "freebsd-scsi@freebsd.org" , "ambrisko@FreeBSD.ORG" , "scottl@freebsd.org" Subject: Re: [patch] MFI should set bio_resid on command failure X-BeenThere: freebsd-scsi@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SCSI subsystem List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 11 Jul 2012 19:17:16 -0000 > >> >> When an MFI command fails, the driver needs to set > > bio->bio_resid so that the upper levels notice. Otherwise we see commands > > silently failing leading to data corruption. This mirrors dadone(). > >> >> > >> >> -Andrew > >> >> > >> >> Index: sys/dev/mfi/mfi_disk.c > >> >> > > =================================================================== > >> >> --- sys/dev/mfi/mfi_disk.c (revision 238071) > >> >> +++ sys/dev/mfi/mfi_disk.c (working copy) > >> >> @@ -298,6 +298,7 @@ > >> >> hdr = bio->bio_driver1; > >> >> > >> >> if (bio->bio_flags & BIO_ERROR) { > >> >> + bio->bio_resid = bio->bio_bcount; > >> >> if (bio->bio_error == 0) > >> >> bio->bio_error = EIO; > >> >> disk_err(bio, "hard error", -1, 1); > >> >> > >> >> -------------------------------------------------- > >> >> Andrew Boyer aboyer@averesystems.com Committed at svn r238371 Sean From owner-freebsd-scsi@FreeBSD.ORG Fri Jul 13 19:44:08 2012 Return-Path: Delivered-To: freebsd-scsi@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 507681065672; Fri, 13 Jul 2012 19:44:08 +0000 (UTC) (envelope-from linimon@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 238848FC16; Fri, 13 Jul 2012 19:44:08 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id q6DJi8QP043585; Fri, 13 Jul 2012 19:44:08 GMT (envelope-from linimon@freefall.freebsd.org) Received: (from linimon@localhost) by freefall.freebsd.org (8.14.5/8.14.5/Submit) id q6DJi8VB043581; Fri, 13 Jul 2012 19:44:08 GMT (envelope-from linimon) Date: Fri, 13 Jul 2012 19:44:08 GMT Message-Id: <201207131944.q6DJi8VB043581@freefall.freebsd.org> To: linimon@FreeBSD.org, freebsd-bugs@FreeBSD.org, freebsd-scsi@FreeBSD.org From: linimon@FreeBSD.org Cc: Subject: Re: kern/169835: [patch] remove some unused variables from scsi_da probe setup X-BeenThere: freebsd-scsi@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SCSI subsystem List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 Jul 2012 19:44:08 -0000 Old Synopsis: Path to remove some unused variables from scsi_da probe setup New Synopsis: [patch] remove some unused variables from scsi_da probe setup Responsible-Changed-From-To: freebsd-bugs->freebsd-scsi Responsible-Changed-By: linimon Responsible-Changed-When: Fri Jul 13 19:43:41 UTC 2012 Responsible-Changed-Why: Over to maintainer(s). http://www.freebsd.org/cgi/query-pr.cgi?pr=169835 From owner-freebsd-scsi@FreeBSD.ORG Fri Jul 13 22:35:42 2012 Return-Path: Delivered-To: freebsd-scsi@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id A8253106566C for ; Fri, 13 Jul 2012 22:35:42 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: from mail-pb0-f54.google.com (mail-pb0-f54.google.com [209.85.160.54]) by mx1.freebsd.org (Postfix) with ESMTP id 73C558FC0A for ; Fri, 13 Jul 2012 22:35:42 +0000 (UTC) Received: by pbbro2 with SMTP id ro2so6757867pbb.13 for ; Fri, 13 Jul 2012 15:35:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=xR4QllR6d9UyYEWNS5LT9Rg/Mdrtny+3kfRdU4ZtY7A=; b=HFrqejEGGwoTV3Dohf/Ec/eY/Mi/Z08RH/0jqKxN0UEClsfa44OCJVrv0L0xCKwMAR 0how/1QPolLFixsQyRl/dp1s+xqKVcy7yG/fJV9gvBW1VASSS2nUu2lqMpdt3wmC7Ck8 kPjr7pD9AnVGiuozJ9Uom+OHHzqag4gH3ne1NCTf/g+hI0LUhWuCP9QhVQeYj3HJWFs2 EkH7+7VkpEBFUk4ZY8Lz5vMW+BXbeRMkamb2cCMpmggH/NTR7WeXQzRVjlqCorHbPID1 EtYbxYj1bE5e+P/Tu1Dz+D7KWICWmAvzl9/vsLHH5x0nzDi2Xiq98rtq2wKJn1gtw3hi YGKA== Received: by 10.68.226.131 with SMTP id rs3mr6901817pbc.62.1342218942042; Fri, 13 Jul 2012 15:35:42 -0700 (PDT) Received: from oddish.sandvine.com ([64.7.137.182]) by mx.google.com with ESMTPS id oi5sm5493914pbb.39.2012.07.13.15.35.39 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 13 Jul 2012 15:35:40 -0700 (PDT) Date: Fri, 13 Jul 2012 18:37:20 -0400 From: Mark Johnston To: Scott Long Message-ID: <20120713223720.GA51989@oddish.sandvine.com> References: <909AAC62-7BB4-43E7-B04B-27466B038A07@averesystems.com> <1341340916.3370.6.camel@powernoodle.corp.yahoo.com> <2936EBFD-CA1E-4EC4-9790-80D1A5DC5567@averesystems.com> <1341938629.2573.7.camel@powernoodle.corp.yahoo.com> <1341950347.63294.YahooMailNeo@web45701.mail.sp1.yahoo.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1341950347.63294.YahooMailNeo@web45701.mail.sp1.yahoo.com> User-Agent: Mutt/1.5.21 (2010-09-15) Cc: freebsd-scsi@freebsd.org Subject: Re: [patch] MFI should set bio_resid on command failure X-BeenThere: freebsd-scsi@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SCSI subsystem List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 Jul 2012 22:35:42 -0000 On Tue, Jul 10, 2012 at 12:59:07PM -0700, Scott Long wrote: > > > > > ----- Original Message ----- > > From: Sean Bruno > > To: Andrew Boyer > > Cc: "freebsd-scsi@freebsd.org" ; scottl@freebsd.org; "ambrisko@FreeBSD.ORG" > > Sent: Tuesday, July 10, 2012 10:43 AM > > Subject: Re: [patch] MFI should set bio_resid on command failure > > > > On Tue, 2012-07-10 at 09:37 -0700, Andrew Boyer wrote: > >> On Jul 3, 2012, at 2:41 PM, Sean Bruno wrote: > >> > >> > On Tue, 2012-07-03 at 06:47 -0700, Andrew Boyer wrote: > >> >> When an MFI command fails, the driver needs to set > > bio->bio_resid so that the upper levels notice.  Otherwise we see commands > > silently failing leading to data corruption.  This mirrors dadone(). > >> >> > >> >> -Andrew > >> >> > >> >> Index: sys/dev/mfi/mfi_disk.c > >> >> > > =================================================================== > >> >> --- sys/dev/mfi/mfi_disk.c    (revision 238071) > >> >> +++ sys/dev/mfi/mfi_disk.c    (working copy) > >> >> @@ -298,6 +298,7 @@ > >> >>     hdr = bio->bio_driver1; > >> >> > >> >>     if (bio->bio_flags & BIO_ERROR) { > >> >> +        bio->bio_resid = bio->bio_bcount; > >> >>         if (bio->bio_error == 0) > >> >>             bio->bio_error = EIO; > >> >>         disk_err(bio, "hard error", -1, 1); > >> >> > >> >> -------------------------------------------------- > >> >> Andrew Boyer    aboyer@averesystems.com > >> >> > >> > > >> > This looks right to me.  It mirrors the behavior in > > mfi_disk_strategy() > >> > as well. > >> > > >> > Sean > >> > > >> > >> Anyone interested in committing?  (And MFC'ing to stable/8…) > >> > >> -Andrew > >> > >> -------------------------------------------------- > >> Andrew Boyer    aboyer@averesystems.com > >> > >> > >> > > > > Let me hit dougA and scottl for validation.  Their wisdom here can > > validate my naivete. > > > > > Yeah, b_resid needs to be set, and a lot of drivers get this wrong. > > Scott It seems that the analogous line is also missing from aac(4). Is the patch below correct? Or am I missing something? Thanks, -Mark diff --git a/sys/dev/aac/aac_disk.c b/sys/dev/aac/aac_disk.c index e4042f7..f2f6636 100644 --- a/sys/dev/aac/aac_disk.c +++ b/sys/dev/aac/aac_disk.c @@ -334,8 +334,10 @@ aac_biodone(struct bio *bp) { fwprintf(NULL, HBA_FLAGS_DBG_FUNCTION_ENTRY_B, ""); - if (bp->bio_flags & BIO_ERROR) + if (bp->bio_flags & BIO_ERROR) { + bp->bio_resid = bp->bio_bcount; disk_err(bp, "hard error", -1, 1); + } biodone(bp); }