From owner-freebsd-scsi@FreeBSD.ORG Sun Aug 12 00:40:16 2012 Return-Path: Delivered-To: freebsd-scsi@FreeBSD.ORG Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 22EEC106568B; Sun, 12 Aug 2012 00:40:16 +0000 (UTC) (envelope-from mj@feral.com) Received: from ns1.feral.com (ns1.feral.com [192.67.166.1]) by mx1.freebsd.org (Postfix) with ESMTP id CB8CC8FC08; Sun, 12 Aug 2012 00:40:09 +0000 (UTC) Received: from [192.168.135.103] (c-76-126-166-136.hsd1.ca.comcast.net [76.126.166.136]) (authenticated bits=0) by ns1.feral.com (8.14.4/8.14.4) with ESMTP id q7C0e3cf071378 (version=TLSv1/SSLv3 cipher=DHE-RSA-CAMELLIA256-SHA bits=256 verify=NO); Sat, 11 Aug 2012 17:40:04 -0700 (PDT) (envelope-from mj@feral.com) Message-ID: <5026FB5E.8010800@feral.com> Date: Sat, 11 Aug 2012 17:39:58 -0700 From: Matthew Jacob Organization: Feral Software User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:14.0) Gecko/20120713 Thunderbird/14.0 MIME-Version: 1.0 To: John References: <4FDB6F06.6080108@feral.com> <201208102144.25605.bruce@cran.org.uk> <5026772D.9040502@feral.com> <20120811215848.30d107ae@parvati.thanelange.no> <20120811202623.GA29895@FreeBSD.org> In-Reply-To: <20120811202623.GA29895@FreeBSD.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7 (ns1.feral.com [192.67.166.1]); Sat, 11 Aug 2012 17:40:05 -0700 (PDT) Cc: Bruce Cran , freebsd-scsi@FreeBSD.ORG Subject: Re: headsup on enclosure driver X-BeenThere: freebsd-scsi@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Matt Jacob List-Id: SCSI subsystem List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 12 Aug 2012 00:40:16 -0000 On 8/11/2012 1:26 PM, John wrote: > ----- Gyrd Thane Lange's Original Message ----- >> ..e messages. :-) > Reducing these msgs is straight forward. However, is their implementation > incorrect, or are they returning a format the driver doesn't understand? > > Thoughts? > > Cheers! > John Looks like noncompliant hardware. What a surprise. From owner-freebsd-scsi@FreeBSD.ORG Sun Aug 12 17:18:13 2012 Return-Path: Delivered-To: freebsd-scsi@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 995EA106564A for ; Sun, 12 Aug 2012 17:18:13 +0000 (UTC) (envelope-from mj@feral.com) Received: from ns1.feral.com (ns1.feral.com [192.67.166.1]) by mx1.freebsd.org (Postfix) with ESMTP id 6AB498FC12 for ; Sun, 12 Aug 2012 17:18:13 +0000 (UTC) Received: from [192.168.135.103] (c-76-126-166-136.hsd1.ca.comcast.net [76.126.166.136]) (authenticated bits=0) by ns1.feral.com (8.14.4/8.14.4) with ESMTP id q7CHI2Lc006947 (version=TLSv1/SSLv3 cipher=DHE-RSA-CAMELLIA256-SHA bits=256 verify=NO); Sun, 12 Aug 2012 10:18:02 -0700 (PDT) (envelope-from mj@feral.com) Message-ID: <5027E545.30100@feral.com> Date: Sun, 12 Aug 2012 10:17:57 -0700 From: Matthew Jacob Organization: Feral Software User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:14.0) Gecko/20120713 Thunderbird/14.0 MIME-Version: 1.0 To: Bruce Cran References: <4FDB6F06.6080108@feral.com> <201208102144.25605.bruce@cran.org.uk> In-Reply-To: <201208102144.25605.bruce@cran.org.uk> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7 (ns1.feral.com [192.67.166.1]); Sun, 12 Aug 2012 10:18:03 -0700 (PDT) Cc: freebsd-scsi@freebsd.org Subject: Re: headsup on enclosure driver X-BeenThere: freebsd-scsi@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Matt Jacob List-Id: SCSI subsystem List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 12 Aug 2012 17:18:13 -0000 On 8/10/2012 1:44 PM, Bruce Cran wrote: > On Friday 15 June 2012 18:21:10 Matthew Jacob wrote: >> 2) Default logging via enc_log to not be chatty unless a new sysctl >> enc_verbose or bootverbose is set. >> This is all motivated by my hudson case system's log that is filled full >> of charm like: > Did you get around to committing this? Done. From owner-freebsd-scsi@FreeBSD.ORG Mon Aug 13 11:07:18 2012 Return-Path: Delivered-To: freebsd-scsi@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 893311065672 for ; Mon, 13 Aug 2012 11:07:18 +0000 (UTC) (envelope-from owner-bugmaster@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 737598FC14 for ; Mon, 13 Aug 2012 11:07:18 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id q7DB7I09007234 for ; Mon, 13 Aug 2012 11:07:18 GMT (envelope-from owner-bugmaster@FreeBSD.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.5/8.14.5/Submit) id q7DB7Hqr007232 for freebsd-scsi@FreeBSD.org; Mon, 13 Aug 2012 11:07:17 GMT (envelope-from owner-bugmaster@FreeBSD.org) Date: Mon, 13 Aug 2012 11:07:17 GMT Message-Id: <201208131107.q7DB7Hqr007232@freefall.freebsd.org> X-Authentication-Warning: freefall.freebsd.org: gnats set sender to owner-bugmaster@FreeBSD.org using -f From: FreeBSD bugmaster To: freebsd-scsi@FreeBSD.org Cc: Subject: Current problem reports assigned to freebsd-scsi@FreeBSD.org X-BeenThere: freebsd-scsi@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SCSI subsystem List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 Aug 2012 11:07:18 -0000 Note: to view an individual PR, use: http://www.freebsd.org/cgi/query-pr.cgi?pr=(number). The following is a listing of current problems submitted by FreeBSD users. These represent problem reports covering all versions including experimental development code and obsolete releases. S Tracker Resp. Description -------------------------------------------------------------------------------- o kern/169976 scsi [cam] [patch] make scsi_da use sysctl values where app o kern/169974 scsi [cam] [patch] add Quirks for SSD that are 4k optimised o kern/169835 scsi [patch] remove some unused variables from scsi_da prob o kern/169801 scsi [cam] [patc] make changes to delete_method in scsi_da o kern/169403 scsi [cam] [patch] CAM layer, I/O starvation, no fairness o kern/165982 scsi [mpt] mpt instability, drive resets, and losses on Fre o kern/165740 scsi [cam] SCSI code must drain callbacks before free o kern/163713 scsi [aic7xxx] [patch] Add Adaptec29329LPE to aic79xx_pci.c o kern/162256 scsi [mpt] QUEUE FULL EVENT and 'mpt_cam_event: 0x0' o kern/161809 scsi [cam] [patch] set kern.cam.boot_delay via build option o kern/159412 scsi [ciss] 7.3 RELEASE: ciss0 ADAPTER HEARTBEAT FAILED err o kern/157770 scsi [iscsi] [panic] iscsi_initiator panic o kern/154432 scsi [xpt] run_interrupt_driven_hooks: still waiting after o kern/153514 scsi [cam] [panic] CAM related panic o kern/153361 scsi [ciss] Smart Array 5300 boot/detect drive problem o kern/152250 scsi [ciss] [patch] Kernel panic when hw.ciss.expose_hidden o kern/151564 scsi [ciss] ciss(4) should increase CISS_MAX_LOGICAL to 10 o docs/151336 scsi Missing documentation of scsi_ and ata_ functions in c s kern/149927 scsi [cam] hard drive not stopped before removing power dur o kern/148083 scsi [aac] Strange device reporting o kern/147704 scsi [mpt] sys/dev/mpt: new chip revision, partially unsupp o kern/146287 scsi [ciss] ciss(4) cannot see more than one SmartArray con o kern/145768 scsi [mpt] can't perform I/O on SAS based SAN disk in freeb o kern/144648 scsi [aac] Strange values of speed and bus width in dmesg o kern/144301 scsi [ciss] [hang] HP proliant server locks when using ciss o kern/142351 scsi [mpt] LSILogic driver performance problems o kern/134488 scsi [mpt] MPT SCSI driver probes max. 8 LUNs per device o kern/132250 scsi [ciss] ciss driver does not support more then 15 drive o kern/132206 scsi [mpt] system panics on boot when mirroring and 2nd dri o kern/130621 scsi [mpt] tranfer rate is inscrutable slow when use lsi213 o kern/129602 scsi [ahd] ahd(4) gets confused and wedges SCSI bus o kern/128452 scsi [sa] [panic] Accessing SCSI tape drive randomly crashe o kern/128245 scsi [scsi] "inquiry data fails comparison at DV1 step" [re o kern/127927 scsi [isp] isp(4) target driver crashes kernel when set up o kern/127717 scsi [ata] [patch] [request] - support write cache toggling o kern/123674 scsi [ahc] ahc driver dumping o kern/123520 scsi [ahd] unable to boot from net while using ahd o sparc/121676 scsi [iscsi] iscontrol do not connect iscsi-target on sparc o kern/120487 scsi [sg] scsi_sg incompatible with scanners o kern/120247 scsi [mpt] FreeBSD 6.3 and LSI Logic 1030 = only 3.300MB/s o kern/114597 scsi [sym] System hangs at SCSI bus reset with dual HBAs o kern/110847 scsi [ahd] Tyan U320 onboard problem with more than 3 disks o kern/99954 scsi [ahc] reading from DVD failes on 6.x [regression] o kern/92798 scsi [ahc] SCSI problem with timeouts o kern/90282 scsi [sym] SCSI bus resets cause loss of ch device o kern/76178 scsi [ahd] Problem with ahd and large SCSI Raid system o kern/74627 scsi [ahc] [hang] Adaptec 2940U2W Can't boot 5.3 s kern/61165 scsi [panic] kernel page fault after calling cam_send_ccb o kern/60641 scsi [sym] Sporadic SCSI bus resets with 53C810 under load o kern/60598 scsi wire down of scsi devices conflicts with config s kern/57398 scsi [mly] Current fails to install on mly(4) based RAID di o kern/52638 scsi [panic] SCSI U320 on SMP server won't run faster than o kern/44587 scsi dev/dpt/dpt.h is missing defines required for DPT_HAND o kern/39388 scsi ncr/sym drivers fail with 53c810 and more than 256MB m o kern/35234 scsi World access to /dev/pass? (for scanner) requires acce 55 problems total. From owner-freebsd-scsi@FreeBSD.ORG Tue Aug 14 15:30:52 2012 Return-Path: Delivered-To: freebsd-scsi@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 32FBB106564A for ; Tue, 14 Aug 2012 15:30:52 +0000 (UTC) (envelope-from mitya@cabletv.dp.ua) Received: from mail.cabletv.dp.ua (mail.cabletv.dp.ua [193.34.20.8]) by mx1.freebsd.org (Postfix) with ESMTP id E1C318FC12 for ; Tue, 14 Aug 2012 15:30:51 +0000 (UTC) Received: from [193.34.20.2] (helo=m18.cabletv.dp.ua) by mail.cabletv.dp.ua with esmtp (Exim 4.72 (FreeBSD)) (envelope-from ) id 1T1IqZ-000MvT-Jb for freebsd-scsi@freebsd.org; Tue, 14 Aug 2012 18:15:55 +0300 Message-ID: <502A6351.8000904@cabletv.dp.ua> Date: Tue, 14 Aug 2012 17:40:17 +0300 From: Mitya User-Agent: Mozilla/5.0 (X11; FreeBSD i386; rv:12.0) Gecko/20120425 Thunderbird/12.0 MIME-Version: 1.0 To: freebsd-scsi@freebsd.org Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: variable generation in struct periph_driver X-BeenThere: freebsd-scsi@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SCSI subsystem List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 Aug 2012 15:30:52 -0000 Hi. I found some logical inconsistency in file cam_periph.c in function cam_periph_alloc() if (cur_periph != NULL) { KASSERT(cur_periph->unit_number != periph->unit_number, ("duplic ate units on periph list")); TAILQ_INSERT_BEFORE(cur_periph, periph, unit_links); } else { TAILQ_INSERT_TAIL(&(*p_drv)->units, periph, unit_links); (*p_drv)->generation++; } Why variable "generation" increments only in second condition ? From owner-freebsd-scsi@FreeBSD.ORG Tue Aug 14 19:03:33 2012 Return-Path: Delivered-To: scsi@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 5FF78106566B for ; Tue, 14 Aug 2012 19:03:33 +0000 (UTC) (envelope-from mjacob@freebsd.org) Received: from ns1.feral.com (ns1.feral.com [192.67.166.1]) by mx1.freebsd.org (Postfix) with ESMTP id 1CBE08FC16 for ; Tue, 14 Aug 2012 19:03:32 +0000 (UTC) Received: from centos62.localhost (bastis [10.3.0.2]) by ns1.feral.com (8.14.4/8.14.4) with ESMTP id q7EJ3Ujf024271 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Tue, 14 Aug 2012 12:03:32 -0700 (PDT) (envelope-from mjacob@freebsd.org) Message-ID: <502AA102.8020109@freebsd.org> Date: Tue, 14 Aug 2012 12:03:30 -0700 From: Matthew Jacob Organization: FreeBSD User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0.6esrpre) Gecko/20120717 Thunderbird/10.0.6 MIME-Version: 1.0 To: scsi@freebsd.org Content-Type: multipart/mixed; boundary="------------020909090709090106090301" X-Greylist: Default is to whitelist mail, not delayed by milter-greylist-4.2.7 (ns1.feral.com [172.16.1.79]); Tue, 14 Aug 2012 12:03:32 -0700 (PDT) X-Content-Filtered-By: Mailman/MimeDel 2.1.5 Cc: Subject: tired of mangled xpt_print output? X-BeenThere: freebsd-scsi@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: mjacob@freebsd.org List-Id: SCSI subsystem List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 Aug 2012 19:03:33 -0000 This is a multi-part message in MIME format. --------------020909090709090106090301 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit I sure am. ctlfe_onoffline: SIM isp1 (path id 1) target disable succeeded (ctl2:isp0:0:0:0): disabling lun 0 (ctl2:isp0:0:0:0): lun now disabled for target mode (ctl2:isp0:0:0:0): LUN removed, 1024 ATIOs outstanding, 1024 INOTs outstanding, 1 refs (ctl3:isp1:0:0:0): (ctl2:disabling lun 0 isp0:0:0:(ctl3:0): isp1:0:now releasing locked 0:(ctl2:0): isp0:0:lun now disabled for target mode 0:(ctl3:0): isp1:0:ctlfecleanup: Called 0:0): LUN removed, 1024 ATIOs outstanding, 1024 INOTs outstanding, 1 refs (ctl3:isp1:0:0:0): now releasing locked (ctl3:isp1:0:0:0): ctlfecleanup: Called The attached patch mitigates this and produces instead: ctlfe_onoffline: SIM isp1 (path id 1) target disable succeeded (ctl2:isp0:0:0:0): disabling lun 0 (ctl2:isp0:0:0:0): lun now disabled for target mode (ctl2:isp0:0:0:0): LUN being removed, 1024 ATIOs still outstanding, 1024 INOTs still outstanding, 1 refs (ctl3:isp1:0:0:0): disabling lun 0 (ctl2:isp0:0:0:0): All ATIOs and INOTs now returned (ctl3:isp1:0:0:0): lun now disabled for target mode (ctl2:isp0:0:0:0): ctlfecleanup: Called (ctl3:isp1:0:0:0): LUN being removed, 1024 ATIOs still outstanding, 1024 INOTs still outstanding, 1 refs (ctl3:isp1:0:0:0): All ATIOs and INOTs now returned (ctl3:isp1:0:0:0): ctlfecleanup: Called This won't play into PRINTF_BUFR_SIZE stuff, but at least will be more readable. An alternative would be sprintf, but then we'd have to do dork around with sbuf stuff or more stack,..... Comments about putting it in? --------------020909090709090106090301 Content-Type: text/plain; name="cam_xpt.c.diff" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="cam_xpt.c.diff" Index: cam/cam_xpt.c =================================================================== --- cam/cam_xpt.c (revision 239240) +++ cam/cam_xpt.c (working copy) @@ -158,6 +158,8 @@ static cam_simq_t cam_simq; static struct mtx cam_simq_lock; +static struct mtx xpt_print_lock; + /* Pointers to software interrupt handlers */ static void *cambio_ih; @@ -900,6 +902,7 @@ xsoftc.num_highpower = CAM_MAX_HIGHPOWER; mtx_init(&cam_simq_lock, "CAM SIMQ lock", NULL, MTX_DEF); + mtx_init(&xpt_print_lock, "XPT print lock", NULL, MTX_DEF); mtx_init(&xsoftc.xpt_lock, "XPT lock", NULL, MTX_DEF); mtx_init(&xsoftc.xpt_topo_lock, "XPT topology lock", NULL, MTX_DEF); @@ -3650,10 +3653,12 @@ xpt_print(struct cam_path *path, const char *fmt, ...) { va_list ap; + mtx_lock(&xpt_print_lock); xpt_print_path(path); va_start(ap, fmt); vprintf(fmt, ap); va_end(ap); + mtx_unlock(&xpt_print_lock); } int --------------020909090709090106090301--