From owner-freebsd-standards@FreeBSD.ORG Mon Aug 20 10:44:19 2012 Return-Path: Delivered-To: freebsd-standards@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 8FE92106566C for ; Mon, 20 Aug 2012 10:44:19 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from mail.zoral.com.ua (mx0.zoral.com.ua [91.193.166.200]) by mx1.freebsd.org (Postfix) with ESMTP id E2A988FC0A for ; Mon, 20 Aug 2012 10:44:18 +0000 (UTC) Received: from skuns.kiev.zoral.com.ua (localhost [127.0.0.1]) by mail.zoral.com.ua (8.14.2/8.14.2) with ESMTP id q7KAiQmW015682; Mon, 20 Aug 2012 13:44:26 +0300 (EEST) (envelope-from kostikbel@gmail.com) Received: from deviant.kiev.zoral.com.ua (kostik@localhost [127.0.0.1]) by deviant.kiev.zoral.com.ua (8.14.5/8.14.5) with ESMTP id q7KAiEI8085892; Mon, 20 Aug 2012 13:44:14 +0300 (EEST) (envelope-from kostikbel@gmail.com) Received: (from kostik@localhost) by deviant.kiev.zoral.com.ua (8.14.5/8.14.5/Submit) id q7KAiENY085891; Mon, 20 Aug 2012 13:44:14 +0300 (EEST) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: deviant.kiev.zoral.com.ua: kostik set sender to kostikbel@gmail.com using -f Date: Mon, 20 Aug 2012 13:44:14 +0300 From: Konstantin Belousov To: "Jukka A. Ukkonen" Message-ID: <20120820104414.GK33100@deviant.kiev.zoral.com.ua> References: <201208181010.q7IAABqP017818@freefall.freebsd.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="bgLLobvf7eP6VP5c" Content-Disposition: inline In-Reply-To: <201208181010.q7IAABqP017818@freefall.freebsd.org> User-Agent: Mutt/1.4.2.3i X-Virus-Scanned: clamav-milter 0.95.2 at skuns.kiev.zoral.com.ua X-Virus-Status: Clean X-Spam-Status: No, score=-4.0 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.2.5 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on skuns.kiev.zoral.com.ua Cc: freebsd-standards@freebsd.org Subject: Re: standards/170346: Changes to support waitid() and related stuff X-BeenThere: freebsd-standards@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Standards compliance List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 20 Aug 2012 10:44:19 -0000 --bgLLobvf7eP6VP5c Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Sat, Aug 18, 2012 at 10:10:11AM +0000, Jukka A. Ukkonen wrote: Some my notes: - the style requires tab after #define, not space, in particular, in sys/wait.h. Other style notes: there should be no space between () and variable for type cast, and space, not tab, between 'case' and case constant. You are adding uneccessary blank lines, esp. in the kern_wait6. The libc/gen/waitid.c shall be reformatted fully. - you can reduce the namespace pollution by using struct __siginfo instead of siginfo_t in the new prototypes added into sys/wait.h. - do not use the low syscall numbers for new syscalls, just add at the end of the table. - you need to provide compat32 translation for new syscalls, see compat/freebsd32/syscalls.master as the starting point. - the comment 'New siginfo stuff...' seems to not provide any useful information. - I do not think we need to enumerate other OSes in comments which provide similar functionality. Just noting that resource usage is provided for both zombies and snapshotted for live process will be good. - please wrap long line in kern_wait6. - why do you zero siginfo in case of returning EINVAL from kern_wait6 ? Same question for assigning -1 to td_reval[0]. td_retval is ignored at all if error is indicated. There seems to be similar fragment for WNOHANG, why do you zero siginfo for the case when the process is not found ? Shouldn't the caller not to copy out the siginfo at all in this case ? - in waitid.c, why do you even consider the case of ret != 0 or -1 ? How can it be ? --bgLLobvf7eP6VP5c Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (FreeBSD) iEYEARECAAYFAlAyFP4ACgkQC3+MBN1Mb4gYWACgyfnSJcg7g5ivfS5vDRzVdKIK +g8AnA99Y0qkn+9wTFTBvYLoNIvahOKG =+zTx -----END PGP SIGNATURE----- --bgLLobvf7eP6VP5c-- From owner-freebsd-standards@FreeBSD.ORG Mon Aug 20 11:08:04 2012 Return-Path: Delivered-To: freebsd-standards@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 9A67D1065678 for ; Mon, 20 Aug 2012 11:08:04 +0000 (UTC) (envelope-from owner-bugmaster@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 79EFF8FC17 for ; Mon, 20 Aug 2012 11:08:04 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id q7KB84o0048121 for ; Mon, 20 Aug 2012 11:08:04 GMT (envelope-from owner-bugmaster@FreeBSD.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.5/8.14.5/Submit) id q7KB83CA048097 for freebsd-standards@FreeBSD.org; Mon, 20 Aug 2012 11:08:03 GMT (envelope-from owner-bugmaster@FreeBSD.org) Date: Mon, 20 Aug 2012 11:08:03 GMT Message-Id: <201208201108.q7KB83CA048097@freefall.freebsd.org> X-Authentication-Warning: freefall.freebsd.org: gnats set sender to owner-bugmaster@FreeBSD.org using -f From: FreeBSD bugmaster To: freebsd-standards@FreeBSD.org Cc: Subject: Current problem reports assigned to freebsd-standards@FreeBSD.org X-BeenThere: freebsd-standards@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Standards compliance List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 20 Aug 2012 11:08:04 -0000 Note: to view an individual PR, use: http://www.freebsd.org/cgi/query-pr.cgi?pr=(number). The following is a listing of current problems submitted by FreeBSD users. These represent problem reports covering all versions including experimental development code and obsolete releases. S Tracker Resp. Description -------------------------------------------------------------------------------- o stand/170403 standards wrong ntohs expression type tickling clang o stand/170346 standards Changes to support waitid() and related stuff o stand/169697 standards syslogd(8) is not BOM aware o stand/166349 standards Support the assignment-allocation character for fscanf o stand/165236 standards The NONE Wi-Fi regulatory restricts use of channels 12 o stand/164787 standards dirfd() function not available when _POSIX_C_SOURCE is o kern/164674 standards [patch] [libc] vfprintf/vfwprintf return error (EOF) o o stand/162434 standards getaddrinfo: addrinfo.ai_family is an address family, o stand/154842 standards invalid request authenticator in the second and subseq o stand/150093 standards C++ std::locale support is broken o stand/130067 standards Wrong numeric limits in system headers? o stand/124860 standards flockfile(3) doesn't work when the memory has been exh o stand/121921 standards [patch] Add leap second support to at(1), atrun(8) o stand/116477 standards rm(1): rm behaves unexpectedly when using -r and relat o bin/116413 standards incorrect getconf(1) handling of unsigned constants gi o stand/116081 standards make does not work with the directive sinclude p stand/107561 standards [libc] [patch] [request] Missing SUS function tcgetsid o stand/100017 standards [Patch] Add fuser(1) functionality to fstat(1) a stand/86484 standards [patch] mkfifo(1) uses wrong permissions o stand/82654 standards C99 long double math functions are missing o stand/81287 standards [patch] fingerd(8) might send a line not ending in CRL a stand/80293 standards sysconf() does not support well-defined unistd values o stand/79056 standards [feature request] [atch] regex(3) regression tests o stand/70813 standards [patch] ls(1) not Posix compliant o stand/66357 standards make POSIX conformance problem ('sh -e' & '+' command- s kern/64875 standards [libc] [patch] [request] add a system call: fdatasync( o stand/56476 standards [patch] cd9660 unicode support simple hack o stand/54410 standards one-true-awk not POSIX compliant (no extended REs) o stand/46119 standards Priority problems for SCHED_OTHER using pthreads o stand/44365 standards [headers] [patch] [request] introduce ulong and unchar a stand/41576 standards ln(1): replacing old dir-symlinks a docs/26003 standards getgroups(2) lists NGROUPS_MAX but not syslimits.h s stand/24590 standards timezone function not compatible witn Single Unix Spec o stand/21519 standards sys/dir.h should be deprecated some more s bin/14925 standards getsubopt isn't poisonous enough 35 problems total. From owner-freebsd-standards@FreeBSD.ORG Wed Aug 22 14:18:50 2012 Return-Path: Delivered-To: freebsd-standards@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 178F3106566C for ; Wed, 22 Aug 2012 14:18:50 +0000 (UTC) (envelope-from sylviabotha@telkomsa.net) Received: from hercules.telkomsa.net (hercules.telkomsa.net [196.25.211.23]) by mx1.freebsd.org (Postfix) with ESMTP id 988EC8FC1B for ; Wed, 22 Aug 2012 14:18:49 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by hercules.telkomsa.net (Postfix) with ESMTP id 0062F24BC7A for ; Tue, 21 Aug 2012 11:55:34 +0200 (SAST) X-Virus-Scanned: amavisd-new at hercules.telkomsa.net Received: from hercules.telkomsa.net ([127.0.0.1]) by localhost (hercules.telkomsa.net [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id l6rNUk09yoXD for ; Tue, 21 Aug 2012 11:55:34 +0200 (SAST) Received: from telkomsa.net (host.arabsgate10.com [209.59.164.170]) by hercules.telkomsa.net (Postfix) with ESMTPA id 082DD6181EA for ; Mon, 20 Aug 2012 16:45:13 +0200 (SAST) Date: Mon, 20 Aug 2012 17:45:11 +0400 From: =?windows-1251?Q?=CB=E5=F1=E8=EA_=CA=EE=F0=ED=E8=EB=EE=E2=E0?= Organization: xputzmcvp X-Priority: 3 (Normal) Message-ID: <295207787.20120820174511@telkomsa.net> To: freebsd-standards@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=windows-1251 Content-Transfer-Encoding: 8bit Subject: =?windows-1251?b?5fHr6CDs7ubl8iDy5eHlIOfg9e735fLx/yDi8fLw5fLo?= =?windows-1251?b?8vzx/w==?= X-BeenThere: freebsd-standards@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Standards compliance List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 Aug 2012 14:18:50 -0000