From owner-freebsd-toolchain@FreeBSD.ORG Mon Dec 3 18:40:40 2012 Return-Path: Delivered-To: toolchain@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id C0EE4FD7; Mon, 3 Dec 2012 18:40:40 +0000 (UTC) (envelope-from hans@beastielabs.net) Received: from mail.beastielabs.net (beasties.demon.nl [82.161.3.114]) by mx1.freebsd.org (Postfix) with ESMTP id 491558FC13; Mon, 3 Dec 2012 18:40:39 +0000 (UTC) Received: from merom.hotsoft.nl (merom.hotsoft.nl [192.168.0.12]) by mail.beastielabs.net (8.14.5/8.14.5) with ESMTP id qB3IeWDv070911; Mon, 3 Dec 2012 19:40:32 +0100 (CET) (envelope-from hans@beastielabs.net) Message-ID: <50BCF220.6040905@beastielabs.net> Date: Mon, 03 Dec 2012 19:40:32 +0100 From: Hans Ottevanger User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:17.0) Gecko/17.0 Thunderbird/17.0 MIME-Version: 1.0 To: Niclas Zeising Subject: Re: [CFT] devel/binutils 2.23 References: <201211141445.qAEEjTXQ047896@mech-cluster241.men.bris.ac.uk> <50A3FCEF.9060204@freebsd.org> <50A4A5A2.2000902@beastielabs.net> <50A4A69B.7030200@freebsd.org> <50B76AC2.4050207@freebsd.org> <50BA27F1.3080002@beastielabs.net> In-Reply-To: <50BA27F1.3080002@beastielabs.net> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: toolchain@freebsd.org X-BeenThere: freebsd-toolchain@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Maintenance of FreeBSD's integrated toolchain List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 03 Dec 2012 18:40:41 -0000 On 12/01/12 16:53, Hans Ottevanger wrote: > On 11/29/12 15:01, Niclas Zeising wrote: >> On 11/15/12 09:23, Niclas Zeising wrote: >>> On 2012-11-15 09:19, Hans Ottevanger wrote: >>>> On 11/14/12 21:19, Niclas Zeising wrote: >>>>> On 11/14/12 15:45, Anton Shterenlikht wrote: >>>>>> It installed fine on ia64 and sparc64, both -current. >>>>>> I don't know how to test. Please advise if there are >>>>>> simple tests. >>>>>> >>>>>> Also, just to check, I manually deleted *orig files >>>>>> from under files/ after applying the patch: >>>>>> >>>>>> # ls -al /usr/ports/devel/binutils/files/ >>>>>> total 20 >>>>>> drwxr-xr-x 2 root wheel 1024 Nov 14 12:58 . >>>>>> drwxr-xr-x 4 root wheel 512 Nov 14 13:00 .. >>>>>> -rw-r--r-- 1 root wheel 353 Nov 14 12:55 patch-bfd_Makefile.in >>>>>> -rw-r--r-- 1 root wheel 297 Nov 14 12:55 patch-gold_Makefile.in >>>>>> -rw-r--r-- 1 root wheel 471 Nov 14 12:55 patch-gold_script.cc >>>>>> # >>>>>> >>>>>> because I think all files in this directory >>>>>> will be used as patches, no matter the name. >>>>>> Am I wrong? >>>>>> >>>>>> Anton >>>>> >>>>> Just compile test some binaries and see that they link and work ok. >>>>> The .orig files are left over when running patch, and has to be removed. >>>>> Sorry if I wasn't clear on that in my previous mail. >>>>> Thanks for testing! >>>>> Regards! >>>> >>>> Please be aware that apparently something went wrong with the release of >>>> binutils-2.23 (see the discussion ending in: >>>> >>>> http://sourceware.org/ml/binutils/2012-10/msg00339.html >>>> >>>> though I doubt the glitches will affect your usage) and it has been >>>> re-released as binutils-2.23.1. Maybe it is better to base the update if >>>> the binutils port on that release. >>>> >>> >>> I noticed that late last night, but haven't had time to update the patch >>> yet. Thank you for pointing it out. >>> Regards! >>> >> >> Hi! >> Apologies for the delay. Attached is a patch that updates binutils from >> 2.22 to 2.23.1. Please test it. The plan is to commit it once 9.1 is >> out the door and the feature freeze on the ports tree is lifted. >> Regards! >> > > I tested your patch on amd64 and i386 systems (all a recent 8.3-STABLE > r243569). > > The patch applied cleanly and the resulting port compiled without > problems, both by directly using make and by using portmaster. I tested > the results by recompiling a fairly large application (my gcc based > cross-build environment for embedded development) using gcc 4.7 from the > ports and the new binutils-2.23.1 on both i386 and amd64, Everything > functioned as it should and up to now there were no surprises whatsoever. > > I do not have the systems to test the other architectures, but I will > retest on the 10.0-CURRENT i386 and amd64 systems that I expect to > install one of these days. I will come back to you to report on that. > > Kind regards, > > Hans Ottevanger > I have been taking a closer look at the output of make and find the following: => SHA256 Checksum OK for binutils-2.23.1.tar.bz2. ===> Patching for binutils-2.23.1 ===> Applying FreeBSD patches for binutils-2.23.1 I can't seem to find a patch in there anywhere. I can't seem to find a patch in there anywhere. I can't seem to find a patch in there anywhere. I can't seem to find a patch in there anywhere. I can't seem to find a patch in there anywhere. I can't seem to find a patch in there anywhere. I can't seem to find a patch in there anywhere. I can't seem to find a patch in there anywhere. I can't seem to find a patch in there anywhere. I can't seem to find a patch in there anywhere. I can't seem to find a patch in there anywhere. ===> binutils-2.23.1 depends on file: /usr/local/lib/libgmp.so - found This happens on both 8.3-STABLE and 10.0-CURRENT. It implies that 11 of the 14 patches in the directory "files" are not applied. I wonder how the binutils get to function at all without them, but the patches are probably for exceptional situations and other architectures then amd64 and i386. Kind regards, Hans Ottevanger From owner-freebsd-toolchain@FreeBSD.ORG Mon Dec 3 19:19:38 2012 Return-Path: Delivered-To: toolchain@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 2A8611D9 for ; Mon, 3 Dec 2012 19:19:38 +0000 (UTC) (envelope-from zeising@freebsd.org) Received: from mail.lysator.liu.se (mail.lysator.liu.se [IPv6:2001:6b0:17:f0a0::3]) by mx1.freebsd.org (Postfix) with ESMTP id 78F208FC16 for ; Mon, 3 Dec 2012 19:19:37 +0000 (UTC) Received: from mail.lysator.liu.se (localhost [127.0.0.1]) by mail.lysator.liu.se (Postfix) with ESMTP id 5A40640008 for ; Mon, 3 Dec 2012 20:19:36 +0100 (CET) Received: by mail.lysator.liu.se (Postfix, from userid 1004) id 48B9540007; Mon, 3 Dec 2012 20:19:36 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on bernadotte.lysator.liu.se X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=AWL autolearn=disabled version=3.3.1 X-Spam-Score: 0.0 Received: from mx.daemonic.se (h-45-105.a163.priv.bahnhof.se [94.254.45.105]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.lysator.liu.se (Postfix) with ESMTPSA id 62DF340004; Mon, 3 Dec 2012 20:19:35 +0100 (CET) Received: from mailscanner.daemonic.se (mailscanner.daemonic.se [IPv6:2001:470:dca9:0:1::6]) by mx.daemonic.se (Postfix) with ESMTPS id 3YFbcQ73l1z8hVt; Mon, 3 Dec 2012 20:19:34 +0100 (CET) X-Virus-Scanned: amavisd-new at daemonic.se Received: from mx.daemonic.se ([10.1.0.3]) (using TLS with cipher CAMELLIA256-SHA) by mailscanner.daemonic.se (mailscanner.daemonic.se [10.1.0.6]) (amavisd-new, port 10025) with ESMTPS id 1cq6CUT9mwXj; Mon, 3 Dec 2012 20:19:32 +0100 (CET) Received: from mail.daemonic.se (mail.daemonic.se [10.1.0.4]) by mx.daemonic.se (Postfix) with ESMTPS id 3YFbcM6Kl1z8hVn; Mon, 3 Dec 2012 20:19:31 +0100 (CET) Received: from vivi.daemonic.se (vivi.daemonic.se [IPv6:2001:470:dca9:1::4]) by mail.daemonic.se (Postfix) with ESMTPSA id 3YFbcM5zgDz9Ctj; Mon, 3 Dec 2012 20:19:31 +0100 (CET) Message-ID: <50BCFB43.8040906@freebsd.org> Date: Mon, 03 Dec 2012 20:19:31 +0100 From: Niclas Zeising User-Agent: Mutt/1.5.21 MIME-Version: 1.0 To: Hans Ottevanger Subject: Re: [CFT] devel/binutils 2.23 References: <201211141445.qAEEjTXQ047896@mech-cluster241.men.bris.ac.uk> <50A3FCEF.9060204@freebsd.org> <50A4A5A2.2000902@beastielabs.net> <50A4A69B.7030200@freebsd.org> <50B76AC2.4050207@freebsd.org> <50BA27F1.3080002@beastielabs.net> <50BCF220.6040905@beastielabs.net> In-Reply-To: <50BCF220.6040905@beastielabs.net> Content-Type: text/plain; charset=GB2312 Content-Transfer-Encoding: 7bit X-Virus-Scanned: ClamAV using ClamSMTP Cc: toolchain@freebsd.org X-BeenThere: freebsd-toolchain@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Maintenance of FreeBSD's integrated toolchain List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 03 Dec 2012 19:19:38 -0000 On 12/03/12 19:40, Hans Ottevanger wrote: > On 12/01/12 16:53, Hans Ottevanger wrote: >> On 11/29/12 15:01, Niclas Zeising wrote: >>> On 11/15/12 09:23, Niclas Zeising wrote: >>>> On 2012-11-15 09:19, Hans Ottevanger wrote: >>>>> On 11/14/12 21:19, Niclas Zeising wrote: >>>>>> On 11/14/12 15:45, Anton Shterenlikht wrote: >>>>>>> It installed fine on ia64 and sparc64, both -current. >>>>>>> I don't know how to test. Please advise if there are >>>>>>> simple tests. >>>>>>> >>>>>>> Also, just to check, I manually deleted *orig files >>>>>>> from under files/ after applying the patch: >>>>>>> >>>>>>> # ls -al /usr/ports/devel/binutils/files/ >>>>>>> total 20 >>>>>>> drwxr-xr-x 2 root wheel 1024 Nov 14 12:58 . >>>>>>> drwxr-xr-x 4 root wheel 512 Nov 14 13:00 .. >>>>>>> -rw-r--r-- 1 root wheel 353 Nov 14 12:55 patch-bfd_Makefile.in >>>>>>> -rw-r--r-- 1 root wheel 297 Nov 14 12:55 patch-gold_Makefile.in >>>>>>> -rw-r--r-- 1 root wheel 471 Nov 14 12:55 patch-gold_script.cc >>>>>>> # >>>>>>> >>>>>>> because I think all files in this directory >>>>>>> will be used as patches, no matter the name. >>>>>>> Am I wrong? >>>>>>> >>>>>>> Anton >>>>>> >>>>>> Just compile test some binaries and see that they link and work ok. >>>>>> The .orig files are left over when running patch, and has to be removed. >>>>>> Sorry if I wasn't clear on that in my previous mail. >>>>>> Thanks for testing! >>>>>> Regards! >>>>> >>>>> Please be aware that apparently something went wrong with the release of >>>>> binutils-2.23 (see the discussion ending in: >>>>> >>>>> http://sourceware.org/ml/binutils/2012-10/msg00339.html >>>>> >>>>> though I doubt the glitches will affect your usage) and it has been >>>>> re-released as binutils-2.23.1. Maybe it is better to base the update if >>>>> the binutils port on that release. >>>>> >>>> >>>> I noticed that late last night, but haven't had time to update the patch >>>> yet. Thank you for pointing it out. >>>> Regards! >>>> >>> >>> Hi! >>> Apologies for the delay. Attached is a patch that updates binutils from >>> 2.22 to 2.23.1. Please test it. The plan is to commit it once 9.1 is >>> out the door and the feature freeze on the ports tree is lifted. >>> Regards! >>> >> >> I tested your patch on amd64 and i386 systems (all a recent 8.3-STABLE >> r243569). >> >> The patch applied cleanly and the resulting port compiled without >> problems, both by directly using make and by using portmaster. I tested >> the results by recompiling a fairly large application (my gcc based >> cross-build environment for embedded development) using gcc 4.7 from the >> ports and the new binutils-2.23.1 on both i386 and amd64, Everything >> functioned as it should and up to now there were no surprises whatsoever. >> >> I do not have the systems to test the other architectures, but I will >> retest on the 10.0-CURRENT i386 and amd64 systems that I expect to >> install one of these days. I will come back to you to report on that. >> >> Kind regards, >> >> Hans Ottevanger >> > > I have been taking a closer look at the output of make and find the > following: > > => SHA256 Checksum OK for binutils-2.23.1.tar.bz2. > ===> Patching for binutils-2.23.1 > ===> Applying FreeBSD patches for binutils-2.23.1 > I can't seem to find a patch in there anywhere. > I can't seem to find a patch in there anywhere. > I can't seem to find a patch in there anywhere. > I can't seem to find a patch in there anywhere. > I can't seem to find a patch in there anywhere. > I can't seem to find a patch in there anywhere. > I can't seem to find a patch in there anywhere. > I can't seem to find a patch in there anywhere. > I can't seem to find a patch in there anywhere. > I can't seem to find a patch in there anywhere. > I can't seem to find a patch in there anywhere. > ===> binutils-2.23.1 depends on file: /usr/local/lib/libgmp.so - found > > This happens on both 8.3-STABLE and 10.0-CURRENT. It implies that 11 of > the 14 patches in the directory "files" are not applied. I wonder how > the binutils get to function at all without them, but the patches are > probably for exceptional situations and other architectures then amd64 > and i386. > > Kind regards, > > Hans Ottevanger > Have a look at the files/ directory. It is probably only the .orig files that are left from applying the patch, or if you didn't apply the patch with -E, the files are probably still there but empty. Regards! -- Niclas Zeising From owner-freebsd-toolchain@FreeBSD.ORG Tue Dec 4 01:31:43 2012 Return-Path: Delivered-To: freebsd-toolchain@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 761AED67 for ; Tue, 4 Dec 2012 01:31:43 +0000 (UTC) (envelope-from prvs=1685a61a7f=evendas@krazer.com.br) Received: from krazer.com.br (usaimport.com.br [74.208.147.131]) by mx1.freebsd.org (Postfix) with ESMTP id 12BB88FC2F for ; Tue, 4 Dec 2012 01:31:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple; d=krazer.com.br; s=MDaemon; t=1354583464; x=1355188264; q=dns/txt; h=DomainKey-Signature: Received:From:To:Subject:Date:MIME-Version:Content-Type: Message-ID; bh=/AGF6JRzB/J7iTsWt8UkF/2jJ0/KNRujXWNnXTa6qHA=; b=Y FnAyz/yOAP9vAZMzylPhFvFzrQVWuXG73AKeGQ+evmO89aYisva1jO7czAOm/2ys YnCJBSvJ8z4dihKPAmo2oi3jK9rCHcCkBYAalS/i7nenHdMJyEK2Z781rfTHvDC8 0uHhJCobrxngpRCfYfWBYS6LLazeToPhnKAg9+RCHw= DomainKey-Signature: a=rsa-sha1; s=MDaemon; d=krazer.com.br; c=simple; q=dns; h=from:message-id; b=OW6o3H1+apfhJPzWQyppY6Q69UK2tRgGW3sVYB6ExOGvOfrTMYUYtSY0coBY IXkqjmbIDXIO1dw/ywt40AAOWZ/z22cXTJqdQPXueJIJTnH0KorNoHS82 xO9+ZW38jIGx0HRekF2TytIJ48gIcZdzD3XEyilSPvxgUCaMBGynXo=; X-MDAV-Processed: allearth.com.br, Mon, 03 Dec 2012 23:11:04 -0200 Received: from krazer by allearth.com.br (MDaemon PRO v11.0.0) with ESMTP id md50003170665.msg for ; Mon, 03 Dec 2012 23:11:03 -0200 X-Spam-Processed: allearth.com.br, Mon, 03 Dec 2012 23:11:03 -0200 (not processed: message from trusted or authenticated source) X-Authenticated-Sender: evendas@krazer.com.br X-MDRemoteIP: 74.208.167.75 X-Return-Path: prvs=1685a61a7f=evendas@krazer.com.br X-Envelope-From: evendas@krazer.com.br X-MDaemon-Deliver-To: freebsd-toolchain@freebsd.org From: "Vendas Krazer Technologies" To: Subject: =?utf-8?B?Tm92YSBDUEUgS3JhemVyIFNreSBTdGF0aW9uIDVHSHo=?= =?utf-8?B?IE4gLSBDUEUgQW50ZW5hIEludGVncmFkYSBkZSAxOGRCaQ==?= =?utf-8?B?IGUgQ29tIFNhw61kYSBwYXJhIEFudGVuYSBFeHRlcm5h?= Date: Mon, 03 Dec 2012 22:08:17 -0200 MIME-Version: 1.0 Content-Type: multipart/related; boundary="----=45652905_3502_4801_0078_850943129657" Message-ID: X-Mailer: Clientes Krazer X-Content-Filtered-By: Mailman/MimeDel 2.1.14 X-BeenThere: freebsd-toolchain@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Maintenance of FreeBSD's integrated toolchain List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 04 Dec 2012 01:31:43 -0000 This is a multi-part message in MIME format. ------=45652905_3502_4801_0078_850943129657 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Lan=C3=A7amento CPE Krazer Sky Station 5GHz N Voc=C3=AA cliente pediu que a Krazer fizesse uma nova CPE num formato mais = estiloso, pequena, de menor tamanho e que tivesse novas funcionabilidade, m= ais especificamente acesso f=C3=A1cil ao bot=C3=A3o de reset, prote=C3=A7= =C3=A3o contra queima e a t=C3=A3o desejada SA=C3=8DDA PARA ANTENA EXTERNA!= !! R$ 179.90 Antena Integrada de 18dBi 60=C2=BA Duas Portas de Rede Lan e Wan PA Real de 630mW e LNA Ultra Ganho PoE Passivo com Prote=C3=A7=C3=A3o Dupla de 12 a 24V Fonte Chaveada 12V Full Range 110 a 220V Exclusiva Sa=C3=ADda para Antena Externa Homologa=C3=A7=C3=A3o Anatel 0269-11-5280 Instala=C3=A7=C3=A3o R=C3=A1pida e Simples. Software Amigavel e em Portugu=C3=AAs! Suporte a PPPoE Wisp Cliente! Controle de Banda! Excelente sinal de recep=C3=A7=C3=A3o! Longa Dist=C3=A2ncia! Fa=C3=A7a um teste em sua rede e compare com os concorrentes, muito mais si= nal que UBNT, muito mais dados, transmiss=C3=A3o de quase 90Mbps TCP/IP con= tinuamente! Lat=C3=AAncia de rede de 1 a 5 ms com carga completa! Contate-nos Val Campos // Carla Maria // Eder Roberto Email / MSN: vendas@allearth.com.br Vendas / SAC (19) 3256-5557 (19) 3245-0708 www.krazer.com.br Envio de Email n=C3=A3o autorizado =C3=A9 crime, n=C3=A3o seja o vil=C3=A3o= da hist=C3=B3ria! Email =C3=A9 protegido sobre sigilo fiscal e federal. Le= i Federal Brasil. ------=45652905_3502_4801_0078_850943129657-- From owner-freebsd-toolchain@FreeBSD.ORG Wed Dec 5 07:22:13 2012 Return-Path: Delivered-To: toolchain@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id D534E777; Wed, 5 Dec 2012 07:22:13 +0000 (UTC) (envelope-from hans@beastielabs.net) Received: from mail.beastielabs.net (beasties.demon.nl [82.161.3.114]) by mx1.freebsd.org (Postfix) with ESMTP id 17ACC8FC08; Wed, 5 Dec 2012 07:22:12 +0000 (UTC) Received: from merom.hotsoft.nl (merom.hotsoft.nl [192.168.0.12]) by mail.beastielabs.net (8.14.5/8.14.5) with ESMTP id qB57M4aC076570; Wed, 5 Dec 2012 08:22:04 +0100 (CET) (envelope-from hans@beastielabs.net) Message-ID: <50BEF61C.2050908@beastielabs.net> Date: Wed, 05 Dec 2012 08:22:04 +0100 From: Hans Ottevanger User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:17.0) Gecko/17.0 Thunderbird/17.0 MIME-Version: 1.0 To: Niclas Zeising Subject: Re: [CFT] devel/binutils 2.23 References: <201211141445.qAEEjTXQ047896@mech-cluster241.men.bris.ac.uk> <50A3FCEF.9060204@freebsd.org> <50A4A5A2.2000902@beastielabs.net> <50A4A69B.7030200@freebsd.org> <50B76AC2.4050207@freebsd.org> <50BA27F1.3080002@beastielabs.net> <50BCF220.6040905@beastielabs.net> <50BCFB43.8040906@freebsd.org> In-Reply-To: <50BCFB43.8040906@freebsd.org> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: toolchain@freebsd.org X-BeenThere: freebsd-toolchain@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Maintenance of FreeBSD's integrated toolchain List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 05 Dec 2012 07:22:14 -0000 On 12/03/12 20:19, Niclas Zeising wrote: > On 12/03/12 19:40, Hans Ottevanger wrote: >> On 12/01/12 16:53, Hans Ottevanger wrote: >>> On 11/29/12 15:01, Niclas Zeising wrote: >>>> On 11/15/12 09:23, Niclas Zeising wrote: >>>>> On 2012-11-15 09:19, Hans Ottevanger wrote: >>>>>> On 11/14/12 21:19, Niclas Zeising wrote: >>>>>>> On 11/14/12 15:45, Anton Shterenlikht wrote: >>>>>>>> It installed fine on ia64 and sparc64, both -current. >>>>>>>> I don't know how to test. Please advise if there are >>>>>>>> simple tests. >>>>>>>> >>>>>>>> Also, just to check, I manually deleted *orig files >>>>>>>> from under files/ after applying the patch: >>>>>>>> >>>>>>>> # ls -al /usr/ports/devel/binutils/files/ >>>>>>>> total 20 >>>>>>>> drwxr-xr-x 2 root wheel 1024 Nov 14 12:58 . >>>>>>>> drwxr-xr-x 4 root wheel 512 Nov 14 13:00 .. >>>>>>>> -rw-r--r-- 1 root wheel 353 Nov 14 12:55 patch-bfd_Makefile.in >>>>>>>> -rw-r--r-- 1 root wheel 297 Nov 14 12:55 patch-gold_Makefile.in >>>>>>>> -rw-r--r-- 1 root wheel 471 Nov 14 12:55 patch-gold_script.cc >>>>>>>> # >>>>>>>> >>>>>>>> because I think all files in this directory >>>>>>>> will be used as patches, no matter the name. >>>>>>>> Am I wrong? >>>>>>>> >>>>>>>> Anton >>>>>>> >>>>>>> Just compile test some binaries and see that they link and work ok. >>>>>>> The .orig files are left over when running patch, and has to be removed. >>>>>>> Sorry if I wasn't clear on that in my previous mail. >>>>>>> Thanks for testing! >>>>>>> Regards! >>>>>> >>>>>> Please be aware that apparently something went wrong with the release of >>>>>> binutils-2.23 (see the discussion ending in: >>>>>> >>>>>> http://sourceware.org/ml/binutils/2012-10/msg00339.html >>>>>> >>>>>> though I doubt the glitches will affect your usage) and it has been >>>>>> re-released as binutils-2.23.1. Maybe it is better to base the update if >>>>>> the binutils port on that release. >>>>>> >>>>> >>>>> I noticed that late last night, but haven't had time to update the patch >>>>> yet. Thank you for pointing it out. >>>>> Regards! >>>>> >>>> >>>> Hi! >>>> Apologies for the delay. Attached is a patch that updates binutils from >>>> 2.22 to 2.23.1. Please test it. The plan is to commit it once 9.1 is >>>> out the door and the feature freeze on the ports tree is lifted. >>>> Regards! >>>> >>> >>> I tested your patch on amd64 and i386 systems (all a recent 8.3-STABLE >>> r243569). >>> >>> The patch applied cleanly and the resulting port compiled without >>> problems, both by directly using make and by using portmaster. I tested >>> the results by recompiling a fairly large application (my gcc based >>> cross-build environment for embedded development) using gcc 4.7 from the >>> ports and the new binutils-2.23.1 on both i386 and amd64, Everything >>> functioned as it should and up to now there were no surprises whatsoever. >>> >>> I do not have the systems to test the other architectures, but I will >>> retest on the 10.0-CURRENT i386 and amd64 systems that I expect to >>> install one of these days. I will come back to you to report on that. >>> >>> Kind regards, >>> >>> Hans Ottevanger >>> >> >> I have been taking a closer look at the output of make and find the >> following: >> >> => SHA256 Checksum OK for binutils-2.23.1.tar.bz2. >> ===> Patching for binutils-2.23.1 >> ===> Applying FreeBSD patches for binutils-2.23.1 >> I can't seem to find a patch in there anywhere. >> I can't seem to find a patch in there anywhere. >> I can't seem to find a patch in there anywhere. >> I can't seem to find a patch in there anywhere. >> I can't seem to find a patch in there anywhere. >> I can't seem to find a patch in there anywhere. >> I can't seem to find a patch in there anywhere. >> I can't seem to find a patch in there anywhere. >> I can't seem to find a patch in there anywhere. >> I can't seem to find a patch in there anywhere. >> I can't seem to find a patch in there anywhere. >> ===> binutils-2.23.1 depends on file: /usr/local/lib/libgmp.so - found >> >> This happens on both 8.3-STABLE and 10.0-CURRENT. It implies that 11 of >> the 14 patches in the directory "files" are not applied. I wonder how >> the binutils get to function at all without them, but the patches are >> probably for exceptional situations and other architectures then amd64 >> and i386. >> >> Kind regards, >> >> Hans Ottevanger >> > > Have a look at the files/ directory. It is probably only the .orig > files that are left from applying the patch, or if you didn't apply the > patch with -E, the files are probably still there but empty. > Regards! > Yep, those files are all empty, I should have looked there before grabbing my mailer. Using patch -E indeed solves the problem. BTW, good to see that only 3 patches are left. In other news, I also tested your pathes on an i386 10-CURRENT installation (r243831 and everything seems to work fine. I had to change my plans a bit concerning a test on amd64 10-CURRENT. That will have to wait till a system reshuffle over here, taking place only after 9.1 is released. I hope this helps. Kind regards, Hans Ottevanger From owner-freebsd-toolchain@FreeBSD.ORG Wed Dec 5 09:06:58 2012 Return-Path: Delivered-To: toolchain@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 40B051AB for ; Wed, 5 Dec 2012 09:06:58 +0000 (UTC) (envelope-from zeising@freebsd.org) Received: from mail.lysator.liu.se (mail.lysator.liu.se [IPv6:2001:6b0:17:f0a0::3]) by mx1.freebsd.org (Postfix) with ESMTP id 8F0AF8FC15 for ; Wed, 5 Dec 2012 09:06:57 +0000 (UTC) Received: from mail.lysator.liu.se (localhost [127.0.0.1]) by mail.lysator.liu.se (Postfix) with ESMTP id 0417140026 for ; Wed, 5 Dec 2012 10:06:56 +0100 (CET) Received: by mail.lysator.liu.se (Postfix, from userid 1004) id C2F2440025; Wed, 5 Dec 2012 10:06:55 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on bernadotte.lysator.liu.se X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=AWL autolearn=disabled version=3.3.1 X-Spam-Score: 0.0 Received: from mx.daemonic.se (h-45-105.a163.priv.bahnhof.se [94.254.45.105]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.lysator.liu.se (Postfix) with ESMTPSA id BACC940021; Wed, 5 Dec 2012 10:06:53 +0100 (CET) Received: from mailscanner.daemonic.se (mailscanner.daemonic.se [IPv6:2001:470:dca9:0:1::6]) by mx.daemonic.se (Postfix) with ESMTPS id 3YGYwY22R4z8hVt; Wed, 5 Dec 2012 10:06:53 +0100 (CET) X-Virus-Scanned: amavisd-new at daemonic.se Received: from mx.daemonic.se ([10.1.0.3]) (using TLS with cipher CAMELLIA256-SHA) by mailscanner.daemonic.se (mailscanner.daemonic.se [10.1.0.6]) (amavisd-new, port 10025) with ESMTPS id P-QfaQAoQeVf; Wed, 5 Dec 2012 10:06:47 +0100 (CET) Received: from mail.daemonic.se (mail.daemonic.se [IPv6:2001:470:dca9:0:1::4]) by mx.daemonic.se (Postfix) with ESMTPS id 3YGYwP5S3mz8hVn; Wed, 5 Dec 2012 10:06:45 +0100 (CET) Received: from tifa.daemonic.se (tifa.daemonic.se [10.32.0.6]) by mail.daemonic.se (Postfix) with ESMTPSA id 3YGYwP4vjMz9Ctj; Wed, 5 Dec 2012 10:06:45 +0100 (CET) Received: from tifa.daemonic.se (localhost [IPv6:::1]) by tifa.daemonic.se (Postfix) with ESMTP id 615F5228F2; Wed, 5 Dec 2012 10:06:44 +0100 (CET) Message-ID: <50BF0EA3.2080600@freebsd.org> Date: Wed, 05 Dec 2012 10:06:43 +0100 From: Niclas Zeising User-Agent: Mutt/1.5.21 MIME-Version: 1.0 To: Hans Ottevanger Subject: Re: [CFT] devel/binutils 2.23 References: <201211141445.qAEEjTXQ047896@mech-cluster241.men.bris.ac.uk> <50A3FCEF.9060204@freebsd.org> <50A4A5A2.2000902@beastielabs.net> <50A4A69B.7030200@freebsd.org> <50B76AC2.4050207@freebsd.org> <50BA27F1.3080002@beastielabs.net> <50BCF220.6040905@beastielabs.net> <50BCFB43.8040906@freebsd.org> <50BEF61C.2050908@beastielabs.net> In-Reply-To: <50BEF61C.2050908@beastielabs.net> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Scanned: ClamAV using ClamSMTP Cc: toolchain@freebsd.org X-BeenThere: freebsd-toolchain@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Maintenance of FreeBSD's integrated toolchain List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 05 Dec 2012 09:06:58 -0000 On 12/05/12 08:22, Hans Ottevanger wrote: > On 12/03/12 20:19, Niclas Zeising wrote: >> On 12/03/12 19:40, Hans Ottevanger wrote: >>> On 12/01/12 16:53, Hans Ottevanger wrote: >>>> On 11/29/12 15:01, Niclas Zeising wrote: >>>>> On 11/15/12 09:23, Niclas Zeising wrote: >>>>>> On 2012-11-15 09:19, Hans Ottevanger wrote: >>>>>>> On 11/14/12 21:19, Niclas Zeising wrote: >>>>>>>> On 11/14/12 15:45, Anton Shterenlikht wrote: >>>>>>>>> It installed fine on ia64 and sparc64, both -current. >>>>>>>>> I don't know how to test. Please advise if there are >>>>>>>>> simple tests. >>>>>>>>> >>>>>>>>> Also, just to check, I manually deleted *orig files >>>>>>>>> from under files/ after applying the patch: >>>>>>>>> >>>>>>>>> # ls -al /usr/ports/devel/binutils/files/ >>>>>>>>> total 20 >>>>>>>>> drwxr-xr-x 2 root wheel 1024 Nov 14 12:58 . >>>>>>>>> drwxr-xr-x 4 root wheel 512 Nov 14 13:00 .. >>>>>>>>> -rw-r--r-- 1 root wheel 353 Nov 14 12:55 patch-bfd_Makefile.in >>>>>>>>> -rw-r--r-- 1 root wheel 297 Nov 14 12:55 patch-gold_Makefile.in >>>>>>>>> -rw-r--r-- 1 root wheel 471 Nov 14 12:55 patch-gold_script.cc >>>>>>>>> # >>>>>>>>> >>>>>>>>> because I think all files in this directory >>>>>>>>> will be used as patches, no matter the name. >>>>>>>>> Am I wrong? >>>>>>>>> >>>>>>>>> Anton >>>>>>>> >>>>>>>> Just compile test some binaries and see that they link and work ok. >>>>>>>> The .orig files are left over when running patch, and has to be removed. >>>>>>>> Sorry if I wasn't clear on that in my previous mail. >>>>>>>> Thanks for testing! >>>>>>>> Regards! >>>>>>> >>>>>>> Please be aware that apparently something went wrong with the release of >>>>>>> binutils-2.23 (see the discussion ending in: >>>>>>> >>>>>>> http://sourceware.org/ml/binutils/2012-10/msg00339.html >>>>>>> >>>>>>> though I doubt the glitches will affect your usage) and it has been >>>>>>> re-released as binutils-2.23.1. Maybe it is better to base the update if >>>>>>> the binutils port on that release. >>>>>>> >>>>>> >>>>>> I noticed that late last night, but haven't had time to update the patch >>>>>> yet. Thank you for pointing it out. >>>>>> Regards! >>>>>> >>>>> >>>>> Hi! >>>>> Apologies for the delay. Attached is a patch that updates binutils from >>>>> 2.22 to 2.23.1. Please test it. The plan is to commit it once 9.1 is >>>>> out the door and the feature freeze on the ports tree is lifted. >>>>> Regards! >>>>> >>>> >>>> I tested your patch on amd64 and i386 systems (all a recent 8.3-STABLE >>>> r243569). >>>> >>>> The patch applied cleanly and the resulting port compiled without >>>> problems, both by directly using make and by using portmaster. I tested >>>> the results by recompiling a fairly large application (my gcc based >>>> cross-build environment for embedded development) using gcc 4.7 from the >>>> ports and the new binutils-2.23.1 on both i386 and amd64, Everything >>>> functioned as it should and up to now there were no surprises whatsoever. >>>> >>>> I do not have the systems to test the other architectures, but I will >>>> retest on the 10.0-CURRENT i386 and amd64 systems that I expect to >>>> install one of these days. I will come back to you to report on that. >>>> >>>> Kind regards, >>>> >>>> Hans Ottevanger >>>> >>> >>> I have been taking a closer look at the output of make and find the >>> following: >>> >>> => SHA256 Checksum OK for binutils-2.23.1.tar.bz2. >>> ===> Patching for binutils-2.23.1 >>> ===> Applying FreeBSD patches for binutils-2.23.1 >>> I can't seem to find a patch in there anywhere. >>> I can't seem to find a patch in there anywhere. >>> I can't seem to find a patch in there anywhere. >>> I can't seem to find a patch in there anywhere. >>> I can't seem to find a patch in there anywhere. >>> I can't seem to find a patch in there anywhere. >>> I can't seem to find a patch in there anywhere. >>> I can't seem to find a patch in there anywhere. >>> I can't seem to find a patch in there anywhere. >>> I can't seem to find a patch in there anywhere. >>> I can't seem to find a patch in there anywhere. >>> ===> binutils-2.23.1 depends on file: /usr/local/lib/libgmp.so - found >>> >>> This happens on both 8.3-STABLE and 10.0-CURRENT. It implies that 11 of >>> the 14 patches in the directory "files" are not applied. I wonder how >>> the binutils get to function at all without them, but the patches are >>> probably for exceptional situations and other architectures then amd64 >>> and i386. >>> >>> Kind regards, >>> >>> Hans Ottevanger >>> >> >> Have a look at the files/ directory. It is probably only the .orig >> files that are left from applying the patch, or if you didn't apply the >> patch with -E, the files are probably still there but empty. >> Regards! >> > > Yep, those files are all empty, I should have looked there before > grabbing my mailer. Using patch -E indeed solves the problem. BTW, good > to see that only 3 patches are left. > > In other news, I also tested your pathes on an i386 10-CURRENT > installation (r243831 and everything seems to work fine. I had to change > my plans a bit concerning a test on amd64 10-CURRENT. That will have to > wait till a system reshuffle over here, taking place only after 9.1 is > released. Thank you very much for your help in testing binutils! There is no need for you to test amd64, unless you want to. I have an amd64 installation here that I've tested on, and it works fine. Regards! -- Niclas Zeising From owner-freebsd-toolchain@FreeBSD.ORG Wed Dec 5 16:36:32 2012 Return-Path: Delivered-To: toolchain@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 30FF47DA; Wed, 5 Dec 2012 16:36:32 +0000 (UTC) (envelope-from mexas@bristol.ac.uk) Received: from dirj.bris.ac.uk (dirj.bris.ac.uk [137.222.10.78]) by mx1.freebsd.org (Postfix) with ESMTP id DA1338FC08; Wed, 5 Dec 2012 16:36:31 +0000 (UTC) Received: from ncsc.bris.ac.uk ([137.222.10.41]) by dirj.bris.ac.uk with esmtp (Exim 4.72) (envelope-from ) id 1TgHq4-0005CQ-IT; Wed, 05 Dec 2012 16:28:48 +0000 Received: from mech-cluster241.men.bris.ac.uk ([137.222.187.241]) by ncsc.bris.ac.uk with esmtpsa (TLSv1:AES256-SHA:256) (Exim 4.72) (envelope-from ) id 1TgHq3-0004ln-JP; Wed, 05 Dec 2012 16:28:47 +0000 Received: from mech-cluster241.men.bris.ac.uk (localhost [127.0.0.1]) by mech-cluster241.men.bris.ac.uk (8.14.5/8.14.5) with ESMTP id qB5GSlxk003484; Wed, 5 Dec 2012 16:28:47 GMT (envelope-from mexas@mech-cluster241.men.bris.ac.uk) Received: (from mexas@localhost) by mech-cluster241.men.bris.ac.uk (8.14.5/8.14.5/Submit) id qB5GSlvV003483; Wed, 5 Dec 2012 16:28:47 GMT (envelope-from mexas) Date: Wed, 5 Dec 2012 16:28:47 GMT From: Anton Shterenlikht Message-Id: <201212051628.qB5GSlvV003483@mech-cluster241.men.bris.ac.uk> To: hans@beastielabs.net, zeising@freebsd.org Subject: Re: [CFT] devel/binutils 2.23 In-Reply-To: <50B76AC2.4050207@freebsd.org> Cc: toolchain@freebsd.org X-BeenThere: freebsd-toolchain@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: mexas@bristol.ac.uk List-Id: Maintenance of FreeBSD's integrated toolchain List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 05 Dec 2012 16:36:32 -0000 Date: Thu, 29 Nov 2012 15:01:38 +0100 From: Niclas Zeising Hi! Apologies for the delay. Attached is a patch that updates binutils from 2.22 to 2.23.1. Please test it. The plan is to commit it once 9.1 is out the door and the feature freeze on the ports tree is lifted. Regards! seems fine on ia64 r238596 and sparc64 r239940. I just compiled and run a simple c programme, both statically and dynamically linked. Thanks Anton From owner-freebsd-toolchain@FreeBSD.ORG Thu Dec 6 05:23:05 2012 Return-Path: Delivered-To: freebsd-toolchain@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 581F913D5 for ; Thu, 6 Dec 2012 05:23:05 +0000 (UTC) (envelope-from yanegomi@gmail.com) Received: from mail-oa0-f54.google.com (mail-oa0-f54.google.com [209.85.219.54]) by mx1.freebsd.org (Postfix) with ESMTP id 197548FC0C for ; Thu, 6 Dec 2012 05:23:04 +0000 (UTC) Received: by mail-oa0-f54.google.com with SMTP id n9so7693474oag.13 for ; Wed, 05 Dec 2012 21:23:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:date:message-id:subject:from:to:content-type; bh=1/VMsiKjxF8xNMukxfqetWjj8+fixPmwGBdGaXA6GdU=; b=xgA8we4kt1plfxsOi5k67oewn/ob06YL6KGCLd0+BY/PWZg4JczY3LRpLr0FxuSSWY Wudvqc1W4fDSrx2M/I9/gmKg2LxynkVI0ukLBUNy8wtrrVhg595XrctXGHwtD+6QUq3w NkdcVSnQFENvnLb5Bes3g1Z09tVWZhEMU7HNcCcDEwZsTleZI79qs9C2jrf0LqZdSsYQ QtkXau6wmo1Eoq8NilmumbNP0mnf5ppz8qnSjhDY+sN0jxHMdNlxd0ErXqwrcMvqnew1 u1z0BJT7bKBZJayG/6b+P9fvQht2yYFDJbMuzQANMyJg3c39kBgnky2XFzRXfNOjZyA7 GAfA== MIME-Version: 1.0 Received: by 10.60.172.178 with SMTP id bd18mr157320oec.133.1354771384284; Wed, 05 Dec 2012 21:23:04 -0800 (PST) Received: by 10.76.143.33 with HTTP; Wed, 5 Dec 2012 21:23:03 -0800 (PST) Date: Wed, 5 Dec 2012 21:23:03 -0800 Message-ID: Subject: [RFC] teach config(8) about KERNCONFDIR From: Garrett Cooper To: freebsd-toolchain@freebsd.org Content-Type: text/plain; charset=ISO-8859-1 X-BeenThere: freebsd-toolchain@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Maintenance of FreeBSD's integrated toolchain List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 06 Dec 2012 05:23:05 -0000 (Sorry in advance for GMail mangling). I recently moved all of my svn trees to git and in order to ensure that my trees are in as pristine a state as possible I've started setting KERNCONFDIR=/root in /etc/src.conf and I specify KERNCONF?= -DEBUG. This works pretty well in a standard setup (when files are located in /sys//conf, are standalone, etc). In order to eliminate duplication, I wrote -DEBUG to include and augment it a bit (enable WITNESS, INVARIANTS, etc). However, I discovered that if I do this, config fails to find the file because it only knows how to find 1) absolute paths, 2) relative paths to the obj dir, and 3) as a last ditch effort it tries to use ../../conf/ (/sys/conf I believe for the generic KERNCONF directory). I added the patch below to teach config(8) about KERNCONFDIR for my own local use (and I think fixed a subtle bug with asprintf and free usage), but the support seems hacky. Another alternative (after doing a bit of research) that looks better is NetBSD's concept of prefix paths: prefix [path] If path is given, it pushes a new prefix for include and cinclude. prefix statements act like a stack, and an empty path argument has the latest prefix popped out. The path argument is either absolute or rela- tive to the current defined prefix, which defaults to the top of ther kernel source tree. This sounds like a more generic way to resolve the issue when combined with defparam as described in config(5) [1]. I was wondering if anyone would be interested in this support or not (assuming that porting over the feature is trivial enough to do). If so I'll look at just porting over the support for defparam and prefix directives and will submit a PR for it if successful. If no one's interested in it, I can just hack my src.conf to use /root or autoprefix the path to the ${KERNCONF} and be done with it. Thanks! -Garrett PS Please CC me when replying as I'm not currently subscribed to toolchain@. 1. http://netbsd.gw.com/cgi-bin/man-cgi?config+5+NetBSD-current $ git diff usr.sbin/config/ diff --git a/usr.sbin/config/lang.l b/usr.sbin/config/lang.l index 81f820f..2eba2b8 100644 --- a/usr.sbin/config/lang.l +++ b/usr.sbin/config/lang.l @@ -34,6 +34,8 @@ #include #include #include +#include +#include #include #include "y.tab.h" #include "config.h" @@ -255,22 +257,31 @@ include(const char *fname, int ateof) { FILE *fp; struct incl *in; - char *fnamebuf; + char *fnamebuf, *kernconfdir; fnamebuf = NULL; fp = fopen(fname, "r"); if (fp == NULL && fname[0] != '.' && fname[0] != '/') { asprintf(&fnamebuf, "../../conf/%s", fname); - if (fnamebuf != NULL) { + if (fnamebuf != NULL) fp = fopen(fnamebuf, "r"); - free(fnamebuf); + } + /* If the first attempt failed, try again in ${KERNCONFDIR}. */ + if (fp == NULL) { + kernconfdir = getenv("KERNCONFDIR"); + if (kernconfdir != NULL) { + asprintf(&fnamebuf, "%s/%s", kernconfdir, fname); + if (fnamebuf != NULL) + fp = fopen(fnamebuf, "r"); } } if (fp == NULL) { + free(fnamebuf); yyerror("cannot open included file"); return (-1); } cfgfile_add(fnamebuf == NULL ? fname : fnamebuf); + free(fnamebuf); in = malloc(sizeof(*in)); assert(in != NULL); in->in_prev = inclp; From owner-freebsd-toolchain@FreeBSD.ORG Thu Dec 6 07:30:57 2012 Return-Path: Delivered-To: freebsd-toolchain@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 3F1068A1 for ; Thu, 6 Dec 2012 07:30:57 +0000 (UTC) (envelope-from yanegomi@gmail.com) Received: from mail-oa0-f54.google.com (mail-oa0-f54.google.com [209.85.219.54]) by mx1.freebsd.org (Postfix) with ESMTP id F254B8FC0C for ; Thu, 6 Dec 2012 07:30:56 +0000 (UTC) Received: by mail-oa0-f54.google.com with SMTP id n9so7777539oag.13 for ; Wed, 05 Dec 2012 23:30:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type; bh=ddY9AZO7LWLaHKyFV8iy187WcnWF0/t0p3inlZTmGag=; b=o1e7DKnXrhW6Wn+z3PghaG5pHu5utS1v3UR7+434z8sPblMegGNZyzA38232vF4Ymz JBsozGFtp9xYgydbYExQqh2FPk324I/ztCVXgeEwgm9esJr+qAUdXEZtnq3FVItSzRTG j94DNGhLO2xNf9dm66DTohDJr82uYFfmizO9CWz0sqsD6kuJJNlMqyspuUMkRgakD/Ml 50NFUvT11RDG6Cpuxamf9EGYKOQSeGBnoVQVwVmDag4WgcubSKWodoxkLzb/JSbadaBm YJ0TLb6lzBzFjJJyUUkHGkmQj5tU6VHS/KsSq1eEFLtOnssR/+1M3Kjk36OUU2sOCMby JoYQ== MIME-Version: 1.0 Received: by 10.182.95.205 with SMTP id dm13mr336877obb.9.1354778696705; Wed, 05 Dec 2012 23:24:56 -0800 (PST) Received: by 10.76.143.33 with HTTP; Wed, 5 Dec 2012 23:24:56 -0800 (PST) In-Reply-To: References: Date: Wed, 5 Dec 2012 23:24:56 -0800 Message-ID: Subject: Re: [RFC] teach config(8) about KERNCONFDIR From: Garrett Cooper To: freebsd-toolchain@freebsd.org Content-Type: text/plain; charset=ISO-8859-1 X-BeenThere: freebsd-toolchain@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Maintenance of FreeBSD's integrated toolchain List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 06 Dec 2012 07:30:57 -0000 On Wed, Dec 5, 2012 at 9:23 PM, Garrett Cooper wrote: > (Sorry in advance for GMail mangling). > > I recently moved all of my svn trees to git and in order to ensure > that my trees are in as pristine a state as possible I've started > setting KERNCONFDIR=/root in /etc/src.conf and I specify KERNCONF?= > -DEBUG. This works pretty well in a standard setup (when > files are located in /sys//conf, are standalone, etc). In order > to eliminate duplication, I wrote -DEBUG to include and > augment it a bit (enable WITNESS, INVARIANTS, etc). However, I > discovered that if I do this, config fails to find the file because it > only knows how to find 1) absolute paths, 2) relative paths to the obj > dir, and 3) as a last ditch effort it tries to use ../../conf/ > (/sys/conf I believe for the generic KERNCONF directory). I added the > patch below to teach config(8) about KERNCONFDIR for my own local use > (and I think fixed a subtle bug with asprintf and free usage), but the > support seems hacky. Another alternative (after doing a bit of > research) that looks better is NetBSD's concept of prefix paths: (for the archive's sake) I ran buildkernel again and the patch doesn't work as-is if it's not defined in the environment as it isn't one of the variables that's passed through by default via make to buildkernel when running config(8), so one needs to modify Makefile.inc1 as well in order for things to function properly as described with my patch. Thanks, -Garrett