From owner-freebsd-usb@FreeBSD.ORG  Sun Nov  4 10:50:40 2012
Return-Path: <owner-freebsd-usb@FreeBSD.ORG>
Delivered-To: freebsd-usb@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
 by hub.freebsd.org (Postfix) with ESMTP id 6DA741FD
 for <freebsd-usb@freebsd.org>; Sun,  4 Nov 2012 10:50:40 +0000 (UTC)
 (envelope-from hselasky@c2i.net)
Received: from swip.net (mailfe05.c2i.net [212.247.154.130])
 by mx1.freebsd.org (Postfix) with ESMTP id E2E668FC18
 for <freebsd-usb@freebsd.org>; Sun,  4 Nov 2012 10:50:39 +0000 (UTC)
X-T2-Spam-Status: No, hits=-0.2 required=5.0 tests=ALL_TRUSTED,
	BAYES_50
Received: from [176.74.213.204] (account mc467741@c2i.net HELO
 laptop015.hselasky.homeunix.org)
 by mailfe05.swip.net (CommuniGate Pro SMTP 5.4.4)
 with ESMTPA id 336437763; Sun, 04 Nov 2012 11:45:31 +0100
From: Hans Petter Selasky <hselasky@c2i.net>
To: Marcel Moolenaar <marcel@xcllnt.net>
Subject: Re: RFC: new USB quirk
Date: Sun, 4 Nov 2012 11:47:11 +0100
User-Agent: KMail/1.13.7 (FreeBSD/9.1-PRERELEASE; KDE/4.8.4; amd64; ; )
References: <5D9BFA84-4B90-4769-BE02-F771C3AE5441@xcllnt.net>
In-Reply-To: <5D9BFA84-4B90-4769-BE02-F771C3AE5441@xcllnt.net>
X-Face: 'mmZ:T{)),Oru^0c+/}w'`gU1$ubmG?lp!=R4Wy\ELYo2)@'UZ24N@d2+AyewRX}mAm; Yp
 |U[@, _z/([?1bCfM{_"B<.J>mICJCHAzzGHI{y7{%JVz%R~yJHIji`y>Y}k1C4TfysrsUI
 -%GU9V5]iUZF&nRn9mJ'?&>O
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="iso-8859-15"
Content-Transfer-Encoding: 7bit
Message-Id: <201211041147.11076.hselasky@c2i.net>
Cc: freebsd-usb@freebsd.org
X-BeenThere: freebsd-usb@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: FreeBSD support for USB <freebsd-usb.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-usb>,
 <mailto:freebsd-usb-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-usb>
List-Post: <mailto:freebsd-usb@freebsd.org>
List-Help: <mailto:freebsd-usb-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-usb>,
 <mailto:freebsd-usb-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 04 Nov 2012 10:50:40 -0000

On Saturday 03 November 2012 22:42:33 Marcel Moolenaar wrote:
> Hans,
> 
> Juniper has a few products that use STmicro USB-NAND controllers
> (the ST72682 in particular) and they really don't like the SCSI
> command for prevent/allow medium removal. The attached patch
> adds a quirk for this to avoid spamming the console with errors
> or warnings.
> 
> Does it look good to you?
> Ok to commit?
> 
> Thanks,

Hi,

You also need to update this table in usb_quirk.c:

static const char *usb_quirk_str[USB_QUIRK_MAX] = {
        [UQ_NONE]               = "UQ_NONE",
 
Can you do that and send a new patch for review?

--HPS