From owner-freebsd-virtualization@FreeBSD.ORG Mon Jun 11 11:07:37 2012 Return-Path: Delivered-To: freebsd-virtualization@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 18FFF1065673 for ; Mon, 11 Jun 2012 11:07:37 +0000 (UTC) (envelope-from owner-bugmaster@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 032888FC17 for ; Mon, 11 Jun 2012 11:07:37 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id q5BB7aPe053480 for ; Mon, 11 Jun 2012 11:07:36 GMT (envelope-from owner-bugmaster@FreeBSD.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.5/8.14.5/Submit) id q5BB7abJ053478 for freebsd-virtualization@FreeBSD.org; Mon, 11 Jun 2012 11:07:36 GMT (envelope-from owner-bugmaster@FreeBSD.org) Date: Mon, 11 Jun 2012 11:07:36 GMT Message-Id: <201206111107.q5BB7abJ053478@freefall.freebsd.org> X-Authentication-Warning: freefall.freebsd.org: gnats set sender to owner-bugmaster@FreeBSD.org using -f From: FreeBSD bugmaster To: freebsd-virtualization@FreeBSD.org Cc: Subject: Current problem reports assigned to freebsd-virtualization@FreeBSD.org X-BeenThere: freebsd-virtualization@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion of various virtualization techniques FreeBSD supports." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Jun 2012 11:07:37 -0000 Note: to view an individual PR, use: http://www.freebsd.org/cgi/query-pr.cgi?pr=(number). The following is a listing of current problems submitted by FreeBSD users. These represent problem reports covering all versions including experimental development code and obsolete releases. S Tracker Resp. Description -------------------------------------------------------------------------------- o kern/167551 virtualization[vimage] Fatal trap 12 jails, vimage, ifconfig destroy o kern/165252 virtualization[vimage] [pf] [panic] kernel panics with VIMAGE and PF o kern/161094 virtualization[vimage] [pf] [panic] kernel panic with pf + VIMAGE wh o kern/160541 virtualization[vimage][pf][patch] panic: userret: Returning on td 0x o kern/160496 virtualization[vimage] [pf] [patch] kernel panic with pf + VIMAGE o kern/158686 virtualization[vimage] [tap] [patch] Add VIMAGE support to if_tap a kern/152047 virtualization[vimage] [panic] TUN\TAP under jail with vimage crashe o kern/148155 virtualization[vimage] [pf] Kernel panic with PF/IPFilter + VIMAGE k a kern/147950 virtualization[vimage] [carp] VIMAGE + CARP = kernel crash s kern/143808 virtualization[pf] pf does not work inside jail a kern/141696 virtualization[rum] [vimage] [panic] rum(4)+ vimage = kernel panic 11 problems total. From owner-freebsd-virtualization@FreeBSD.ORG Mon Jun 11 21:37:32 2012 Return-Path: Delivered-To: freebsd-virtualization@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 73BDC106564A for ; Mon, 11 Jun 2012 21:37:32 +0000 (UTC) (envelope-from girgen@FreeBSD.org) Received: from melon.pingpong.net (melon.pingpong.net [79.136.116.200]) by mx1.freebsd.org (Postfix) with ESMTP id 2EA018FC19 for ; Mon, 11 Jun 2012 21:37:32 +0000 (UTC) Received: from girgBook.local (c-fb57e155.1521-1-64736c12.cust.bredbandsbolaget.se [85.225.87.251]) by melon.pingpong.net (Postfix) with ESMTPA id 92A98249A6 for ; Mon, 11 Jun 2012 23:37:30 +0200 (CEST) Message-ID: <4FD66519.8030503@FreeBSD.org> Date: Mon, 11 Jun 2012 23:37:29 +0200 From: Palle Girgensohn User-Agent: Postbox 3.0.3 (Macintosh/20120304) MIME-Version: 1.0 To: freebsd-virtualization@FreeBSD.org X-Enigmail-Version: 1.2.2 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: Subject: VIMAGE, epair/if_bridge or netgraph? X-BeenThere: freebsd-virtualization@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion of various virtualization techniques FreeBSD supports." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Jun 2012 21:37:32 -0000 -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hi, I'm updating some jail servers, and want to use VIMAGE. Compiled it into the kernel, learned the hard way not to even include PF in the same kernel [1], so now it works quite well. I am setting up many similar jails, some for testing, some for production. The applications are web servers, som tomcat+apache's, and some other standard type of services like email and ldap, simple stuff. I need no fancy network control, I just need it to work. For each jail there are two interfaces, one public, connected to a software bridge (if_bridge or ng_bridge) acting as a switch, and one internal, for maintenance, connected to a different software bridge. To each software bridge, I connect a physical external interface from the jail host. I am trying to decide whether to use epair and if_bridge, or to use netgraph. For netgraph, there is a nice package at DruidBSD [3]. When I found that, I had already rewritten the standard jail script, using the v2 patches from polymorf [4]. They work equally fine for my purpose. So now I need to know which scales best, is there a difference in performance or stability between netgraph and epair/if_bridge? Cheers, Palle [1] http://forums.freebsd.org/showthread.php?t=31765 [2] http://forums.freebsd.org/showthread.php?t=31949 [3] http://druidbsd.sourceforge.net/vimage.shtml [4] http://wiki.polymorf.fr/index.php?title=Howto:FreeBSD_jail_vnet -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0.17 (Darwin) Comment: GPGTools - http://gpgtools.org Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQEcBAEBAgAGBQJP1mUZAAoJEIhV+7FrxBJD8ycH/RtOx/++XQUn9xylf73McA/z Y2hBeYDhhdl/aJGi1rrwpq17RTS818yUpV1nuAf1fS8+jPxo30qwmYncAok69v6K h2YVKKx/xF+kczdkl4I9ySh7GfLGYdNcNofwSlY038BZegMMR+FdAVAbYh7QT33d jHOU2xBZoPGqS1bkfrt2vpM9eb9+889jUPfORsJlD0ZfkYQkt41CXo22GYiBNulV t8m64B999ullh+Z+I9dAoT7di9IoaRJKtrsyXeCMwiybMi2Ce9G91mniEL/LBmps jm+NouPkovp6N0/oPFrJM/C3ntvxDqfWTtKwp79LdBY7648IFkP8VVIcfd6PdUU= =aw34 -----END PGP SIGNATURE----- From owner-freebsd-virtualization@FreeBSD.ORG Sat Jun 16 00:03:03 2012 Return-Path: Delivered-To: freebsd-virtualization@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 83840106564A for ; Sat, 16 Jun 2012 00:03:03 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 640348FC08 for ; Sat, 16 Jun 2012 00:03:03 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id q5G033Gd069551 for ; Sat, 16 Jun 2012 00:03:03 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.5/8.14.5/Submit) id q5G033P4069550; Sat, 16 Jun 2012 00:03:03 GMT (envelope-from gnats) Date: Sat, 16 Jun 2012 00:03:03 GMT Message-Id: <201206160003.q5G033P4069550@freefall.freebsd.org> To: freebsd-virtualization@FreeBSD.org From: dfilter@FreeBSD.ORG (dfilter service) Cc: Subject: Re: kern/152047: commit references a PR X-BeenThere: freebsd-virtualization@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: dfilter service List-Id: "Discussion of various virtualization techniques FreeBSD supports." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 16 Jun 2012 00:03:03 -0000 The following reply was made to PR kern/152047; it has been noted by GNATS. From: dfilter@FreeBSD.ORG (dfilter service) To: bug-followup@FreeBSD.org Cc: Subject: Re: kern/152047: commit references a PR Date: Fri, 15 Jun 2012 20:25:54 +0000 (UTC) Author: trociny Date: Fri Jun 15 20:25:44 2012 New Revision: 237144 URL: http://svn.freebsd.org/changeset/base/237144 Log: MFC 236724, 236725: MFC 236724: Add VIMAGE support to if_tap. PR: kern/152047, kern/158686 Submitted by: Daan Vreeken MFC 236725: Sort includes. Submitted by: Daan Vreeken Modified: stable/9/sys/net/if_tap.c Directory Properties: stable/9/sys/ (props changed) Modified: stable/9/sys/net/if_tap.c ============================================================================== --- stable/9/sys/net/if_tap.c Fri Jun 15 20:08:13 2012 (r237143) +++ stable/9/sys/net/if_tap.c Fri Jun 15 20:25:44 2012 (r237144) @@ -42,6 +42,7 @@ #include #include #include +#include #include #include #include @@ -64,8 +65,9 @@ #include #include #include -#include #include +#include +#include #include @@ -214,6 +216,7 @@ tap_destroy(struct tap_softc *tp) KASSERT(!(tp->tap_flags & TAP_OPEN), ("%s flags is out of sync", ifp->if_xname)); + CURVNET_SET(ifp->if_vnet); seldrain(&tp->tap_rsel); knlist_destroy(&tp->tap_rsel.si_note); destroy_dev(tp->tap_dev); @@ -222,6 +225,7 @@ tap_destroy(struct tap_softc *tp) mtx_destroy(&tp->tap_mtx); free(tp, M_TAP); + CURVNET_RESTORE(); } static void @@ -363,6 +367,7 @@ tapclone(void *arg, struct ucred *cred, if (unit == -1) append_unit = 1; + CURVNET_SET(CRED_TO_VNET(cred)); /* find any existing device, or allocate new unit number */ i = clone_create(&tapclones, &tap_cdevsw, &unit, dev, extra); if (i) { @@ -381,6 +386,7 @@ tapclone(void *arg, struct ucred *cred, } if_clone_create(name, namelen, NULL); + CURVNET_RESTORE(); } /* tapclone */ @@ -521,6 +527,7 @@ tapclose(struct cdev *dev, int foo, int /* junk all pending output */ mtx_lock(&tp->tap_mtx); + CURVNET_SET(ifp->if_vnet); IF_DRAIN(&ifp->if_snd); /* @@ -544,6 +551,8 @@ tapclose(struct cdev *dev, int foo, int } if_link_state_change(ifp, LINK_STATE_DOWN); + CURVNET_RESTORE(); + funsetown(&tp->tap_sigio); selwakeuppri(&tp->tap_rsel, PZERO+1); KNOTE_LOCKED(&tp->tap_rsel.si_note, 0); @@ -945,7 +954,9 @@ tapwrite(struct cdev *dev, struct uio *u } /* Pass packet up to parent. */ + CURVNET_SET(ifp->if_vnet); (*ifp->if_input)(ifp, m); + CURVNET_RESTORE(); ifp->if_ipackets ++; /* ibytes are counted in parent */ return (0); _______________________________________________ svn-src-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org" From owner-freebsd-virtualization@FreeBSD.ORG Sat Jun 16 00:03:08 2012 Return-Path: Delivered-To: freebsd-virtualization@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 61273106566B for ; Sat, 16 Jun 2012 00:03:08 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 415F38FC18 for ; Sat, 16 Jun 2012 00:03:08 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id q5G0387w069680 for ; Sat, 16 Jun 2012 00:03:08 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.5/8.14.5/Submit) id q5G038xJ069674; Sat, 16 Jun 2012 00:03:08 GMT (envelope-from gnats) Date: Sat, 16 Jun 2012 00:03:08 GMT Message-Id: <201206160003.q5G038xJ069674@freefall.freebsd.org> To: freebsd-virtualization@FreeBSD.org From: dfilter@FreeBSD.ORG (dfilter service) Cc: Subject: Re: kern/158686: commit references a PR X-BeenThere: freebsd-virtualization@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: dfilter service List-Id: "Discussion of various virtualization techniques FreeBSD supports." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 16 Jun 2012 00:03:08 -0000 The following reply was made to PR kern/158686; it has been noted by GNATS. From: dfilter@FreeBSD.ORG (dfilter service) To: bug-followup@FreeBSD.org Cc: Subject: Re: kern/158686: commit references a PR Date: Fri, 15 Jun 2012 20:25:55 +0000 (UTC) Author: trociny Date: Fri Jun 15 20:25:44 2012 New Revision: 237144 URL: http://svn.freebsd.org/changeset/base/237144 Log: MFC 236724, 236725: MFC 236724: Add VIMAGE support to if_tap. PR: kern/152047, kern/158686 Submitted by: Daan Vreeken MFC 236725: Sort includes. Submitted by: Daan Vreeken Modified: stable/9/sys/net/if_tap.c Directory Properties: stable/9/sys/ (props changed) Modified: stable/9/sys/net/if_tap.c ============================================================================== --- stable/9/sys/net/if_tap.c Fri Jun 15 20:08:13 2012 (r237143) +++ stable/9/sys/net/if_tap.c Fri Jun 15 20:25:44 2012 (r237144) @@ -42,6 +42,7 @@ #include #include #include +#include #include #include #include @@ -64,8 +65,9 @@ #include #include #include -#include #include +#include +#include #include @@ -214,6 +216,7 @@ tap_destroy(struct tap_softc *tp) KASSERT(!(tp->tap_flags & TAP_OPEN), ("%s flags is out of sync", ifp->if_xname)); + CURVNET_SET(ifp->if_vnet); seldrain(&tp->tap_rsel); knlist_destroy(&tp->tap_rsel.si_note); destroy_dev(tp->tap_dev); @@ -222,6 +225,7 @@ tap_destroy(struct tap_softc *tp) mtx_destroy(&tp->tap_mtx); free(tp, M_TAP); + CURVNET_RESTORE(); } static void @@ -363,6 +367,7 @@ tapclone(void *arg, struct ucred *cred, if (unit == -1) append_unit = 1; + CURVNET_SET(CRED_TO_VNET(cred)); /* find any existing device, or allocate new unit number */ i = clone_create(&tapclones, &tap_cdevsw, &unit, dev, extra); if (i) { @@ -381,6 +386,7 @@ tapclone(void *arg, struct ucred *cred, } if_clone_create(name, namelen, NULL); + CURVNET_RESTORE(); } /* tapclone */ @@ -521,6 +527,7 @@ tapclose(struct cdev *dev, int foo, int /* junk all pending output */ mtx_lock(&tp->tap_mtx); + CURVNET_SET(ifp->if_vnet); IF_DRAIN(&ifp->if_snd); /* @@ -544,6 +551,8 @@ tapclose(struct cdev *dev, int foo, int } if_link_state_change(ifp, LINK_STATE_DOWN); + CURVNET_RESTORE(); + funsetown(&tp->tap_sigio); selwakeuppri(&tp->tap_rsel, PZERO+1); KNOTE_LOCKED(&tp->tap_rsel.si_note, 0); @@ -945,7 +954,9 @@ tapwrite(struct cdev *dev, struct uio *u } /* Pass packet up to parent. */ + CURVNET_SET(ifp->if_vnet); (*ifp->if_input)(ifp, m); + CURVNET_RESTORE(); ifp->if_ipackets ++; /* ibytes are counted in parent */ return (0); _______________________________________________ svn-src-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org" From owner-freebsd-virtualization@FreeBSD.ORG Sat Jun 16 00:03:13 2012 Return-Path: Delivered-To: freebsd-virtualization@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 14F291065673 for ; Sat, 16 Jun 2012 00:03:13 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id E8C478FC1C for ; Sat, 16 Jun 2012 00:03:12 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id q5G03Cwo069832 for ; Sat, 16 Jun 2012 00:03:12 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.5/8.14.5/Submit) id q5G03CjN069825; Sat, 16 Jun 2012 00:03:12 GMT (envelope-from gnats) Date: Sat, 16 Jun 2012 00:03:12 GMT Message-Id: <201206160003.q5G03CjN069825@freefall.freebsd.org> To: freebsd-virtualization@FreeBSD.org From: dfilter@FreeBSD.ORG (dfilter service) Cc: Subject: Re: kern/152047: commit references a PR X-BeenThere: freebsd-virtualization@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: dfilter service List-Id: "Discussion of various virtualization techniques FreeBSD supports." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 16 Jun 2012 00:03:13 -0000 The following reply was made to PR kern/152047; it has been noted by GNATS. From: dfilter@FreeBSD.ORG (dfilter service) To: bug-followup@FreeBSD.org Cc: Subject: Re: kern/152047: commit references a PR Date: Fri, 15 Jun 2012 20:27:30 +0000 (UTC) Author: trociny Date: Fri Jun 15 20:27:15 2012 New Revision: 237145 URL: http://svn.freebsd.org/changeset/base/237145 Log: MFC 236724, 236725: MFC 236724: Add VIMAGE support to if_tap. PR: kern/152047, kern/158686 Submitted by: Daan Vreeken MFC 236725: Sort includes. Submitted by: Daan Vreeken Modified: stable/8/sys/net/if_tap.c Directory Properties: stable/8/sys/ (props changed) Modified: stable/8/sys/net/if_tap.c ============================================================================== --- stable/8/sys/net/if_tap.c Fri Jun 15 20:25:44 2012 (r237144) +++ stable/8/sys/net/if_tap.c Fri Jun 15 20:27:15 2012 (r237145) @@ -42,6 +42,7 @@ #include #include #include +#include #include #include #include @@ -64,8 +65,9 @@ #include #include #include -#include #include +#include +#include #include @@ -214,6 +216,7 @@ tap_destroy(struct tap_softc *tp) KASSERT(!(tp->tap_flags & TAP_OPEN), ("%s flags is out of sync", ifp->if_xname)); + CURVNET_SET(ifp->if_vnet); seldrain(&tp->tap_rsel); knlist_destroy(&tp->tap_rsel.si_note); destroy_dev(tp->tap_dev); @@ -222,6 +225,7 @@ tap_destroy(struct tap_softc *tp) mtx_destroy(&tp->tap_mtx); free(tp, M_TAP); + CURVNET_RESTORE(); } static void @@ -363,6 +367,7 @@ tapclone(void *arg, struct ucred *cred, if (unit == -1) append_unit = 1; + CURVNET_SET(CRED_TO_VNET(cred)); /* find any existing device, or allocate new unit number */ i = clone_create(&tapclones, &tap_cdevsw, &unit, dev, extra); if (i) { @@ -381,6 +386,7 @@ tapclone(void *arg, struct ucred *cred, } if_clone_create(name, namelen, NULL); + CURVNET_RESTORE(); } /* tapclone */ @@ -521,6 +527,7 @@ tapclose(struct cdev *dev, int foo, int /* junk all pending output */ mtx_lock(&tp->tap_mtx); + CURVNET_SET(ifp->if_vnet); IF_DRAIN(&ifp->if_snd); /* @@ -544,6 +551,8 @@ tapclose(struct cdev *dev, int foo, int } if_link_state_change(ifp, LINK_STATE_DOWN); + CURVNET_RESTORE(); + funsetown(&tp->tap_sigio); selwakeuppri(&tp->tap_rsel, PZERO+1); KNOTE_LOCKED(&tp->tap_rsel.si_note, 0); @@ -945,7 +954,9 @@ tapwrite(struct cdev *dev, struct uio *u } /* Pass packet up to parent. */ + CURVNET_SET(ifp->if_vnet); (*ifp->if_input)(ifp, m); + CURVNET_RESTORE(); ifp->if_ipackets ++; /* ibytes are counted in parent */ return (0); _______________________________________________ svn-src-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org" From owner-freebsd-virtualization@FreeBSD.ORG Sat Jun 16 00:03:17 2012 Return-Path: Delivered-To: freebsd-virtualization@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id D7F5F106566B for ; Sat, 16 Jun 2012 00:03:17 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id B88518FC14 for ; Sat, 16 Jun 2012 00:03:17 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id q5G03Hjx069988 for ; Sat, 16 Jun 2012 00:03:17 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.5/8.14.5/Submit) id q5G03Hr6069982; Sat, 16 Jun 2012 00:03:17 GMT (envelope-from gnats) Date: Sat, 16 Jun 2012 00:03:17 GMT Message-Id: <201206160003.q5G03Hr6069982@freefall.freebsd.org> To: freebsd-virtualization@FreeBSD.org From: dfilter@FreeBSD.ORG (dfilter service) Cc: Subject: Re: kern/158686: commit references a PR X-BeenThere: freebsd-virtualization@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: dfilter service List-Id: "Discussion of various virtualization techniques FreeBSD supports." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 16 Jun 2012 00:03:18 -0000 The following reply was made to PR kern/158686; it has been noted by GNATS. From: dfilter@FreeBSD.ORG (dfilter service) To: bug-followup@FreeBSD.org Cc: Subject: Re: kern/158686: commit references a PR Date: Fri, 15 Jun 2012 20:27:30 +0000 (UTC) Author: trociny Date: Fri Jun 15 20:27:15 2012 New Revision: 237145 URL: http://svn.freebsd.org/changeset/base/237145 Log: MFC 236724, 236725: MFC 236724: Add VIMAGE support to if_tap. PR: kern/152047, kern/158686 Submitted by: Daan Vreeken MFC 236725: Sort includes. Submitted by: Daan Vreeken Modified: stable/8/sys/net/if_tap.c Directory Properties: stable/8/sys/ (props changed) Modified: stable/8/sys/net/if_tap.c ============================================================================== --- stable/8/sys/net/if_tap.c Fri Jun 15 20:25:44 2012 (r237144) +++ stable/8/sys/net/if_tap.c Fri Jun 15 20:27:15 2012 (r237145) @@ -42,6 +42,7 @@ #include #include #include +#include #include #include #include @@ -64,8 +65,9 @@ #include #include #include -#include #include +#include +#include #include @@ -214,6 +216,7 @@ tap_destroy(struct tap_softc *tp) KASSERT(!(tp->tap_flags & TAP_OPEN), ("%s flags is out of sync", ifp->if_xname)); + CURVNET_SET(ifp->if_vnet); seldrain(&tp->tap_rsel); knlist_destroy(&tp->tap_rsel.si_note); destroy_dev(tp->tap_dev); @@ -222,6 +225,7 @@ tap_destroy(struct tap_softc *tp) mtx_destroy(&tp->tap_mtx); free(tp, M_TAP); + CURVNET_RESTORE(); } static void @@ -363,6 +367,7 @@ tapclone(void *arg, struct ucred *cred, if (unit == -1) append_unit = 1; + CURVNET_SET(CRED_TO_VNET(cred)); /* find any existing device, or allocate new unit number */ i = clone_create(&tapclones, &tap_cdevsw, &unit, dev, extra); if (i) { @@ -381,6 +386,7 @@ tapclone(void *arg, struct ucred *cred, } if_clone_create(name, namelen, NULL); + CURVNET_RESTORE(); } /* tapclone */ @@ -521,6 +527,7 @@ tapclose(struct cdev *dev, int foo, int /* junk all pending output */ mtx_lock(&tp->tap_mtx); + CURVNET_SET(ifp->if_vnet); IF_DRAIN(&ifp->if_snd); /* @@ -544,6 +551,8 @@ tapclose(struct cdev *dev, int foo, int } if_link_state_change(ifp, LINK_STATE_DOWN); + CURVNET_RESTORE(); + funsetown(&tp->tap_sigio); selwakeuppri(&tp->tap_rsel, PZERO+1); KNOTE_LOCKED(&tp->tap_rsel.si_note, 0); @@ -945,7 +954,9 @@ tapwrite(struct cdev *dev, struct uio *u } /* Pass packet up to parent. */ + CURVNET_SET(ifp->if_vnet); (*ifp->if_input)(ifp, m); + CURVNET_RESTORE(); ifp->if_ipackets ++; /* ibytes are counted in parent */ return (0); _______________________________________________ svn-src-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org" From owner-freebsd-virtualization@FreeBSD.ORG Sat Jun 16 06:58:12 2012 Return-Path: Delivered-To: freebsd-virtualization@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 343EE106566C; Sat, 16 Jun 2012 06:58:12 +0000 (UTC) (envelope-from trociny@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 07A488FC08; Sat, 16 Jun 2012 06:58:12 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id q5G6wBgS069731; Sat, 16 Jun 2012 06:58:11 GMT (envelope-from trociny@freefall.freebsd.org) Received: (from trociny@localhost) by freefall.freebsd.org (8.14.5/8.14.5/Submit) id q5G6wBRF069727; Sat, 16 Jun 2012 06:58:11 GMT (envelope-from trociny) Date: Sat, 16 Jun 2012 06:58:11 GMT Message-Id: <201206160658.q5G6wBRF069727@freefall.freebsd.org> To: x86mail@gmail.com, trociny@FreeBSD.org, freebsd-virtualization@FreeBSD.org From: trociny@FreeBSD.org Cc: Subject: Re: kern/152047: [vimage] [panic] TUN\TAP under jail with vimage crashes system X-BeenThere: freebsd-virtualization@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion of various virtualization techniques FreeBSD supports." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 16 Jun 2012 06:58:12 -0000 Synopsis: [vimage] [panic] TUN\TAP under jail with vimage crashes system State-Changed-From-To: analyzed->feedback State-Changed-By: trociny State-Changed-When: Sat Jun 16 06:56:13 UTC 2012 State-Changed-Why: Asking the reporter to check on a recent system. http://www.freebsd.org/cgi/query-pr.cgi?pr=152047 From owner-freebsd-virtualization@FreeBSD.ORG Sat Jun 16 07:00:29 2012 Return-Path: Delivered-To: freebsd-virtualization@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 494EB106566B for ; Sat, 16 Jun 2012 07:00:29 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 118F98FC08 for ; Sat, 16 Jun 2012 07:00:29 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id q5G70SlR069838 for ; Sat, 16 Jun 2012 07:00:28 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.5/8.14.5/Submit) id q5G70S4h069837; Sat, 16 Jun 2012 07:00:28 GMT (envelope-from gnats) Date: Sat, 16 Jun 2012 07:00:28 GMT Message-Id: <201206160700.q5G70S4h069837@freefall.freebsd.org> To: freebsd-virtualization@FreeBSD.org From: Mikolaj Golub Cc: Subject: Re: kern/152047: [vimage] [panic] TUN\TAP under jail with vimage crashes system X-BeenThere: freebsd-virtualization@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Mikolaj Golub List-Id: "Discussion of various virtualization techniques FreeBSD supports." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 16 Jun 2012 07:00:29 -0000 The following reply was made to PR kern/152047; it has been noted by GNATS. From: Mikolaj Golub To: Anton Cc: bug-followup@FreeBSD.org Subject: Re: kern/152047: [vimage] [panic] TUN\TAP under jail with vimage crashes system Date: Sat, 16 Jun 2012 09:54:39 +0300 Hi, Anton, I just have merged VIMAGE support for tap to STABLE branches. Could you please try a recent kernel to see if it has fixed the issues for you. -- Mikolaj Golub From owner-freebsd-virtualization@FreeBSD.ORG Sat Jun 16 07:27:41 2012 Return-Path: Delivered-To: freebsd-virtualization@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 2A9C7106566B; Sat, 16 Jun 2012 07:27:41 +0000 (UTC) (envelope-from trociny@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id F1EFD8FC17; Sat, 16 Jun 2012 07:27:40 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id q5G7ReYd098330; Sat, 16 Jun 2012 07:27:40 GMT (envelope-from trociny@freefall.freebsd.org) Received: (from trociny@localhost) by freefall.freebsd.org (8.14.5/8.14.5/Submit) id q5G7ReSC098326; Sat, 16 Jun 2012 07:27:40 GMT (envelope-from trociny) Date: Sat, 16 Jun 2012 07:27:40 GMT Message-Id: <201206160727.q5G7ReSC098326@freefall.freebsd.org> To: pa4dan@Bliksem.VEHosting.nl, trociny@FreeBSD.org, freebsd-virtualization@FreeBSD.org From: trociny@FreeBSD.org Cc: Subject: Re: kern/158686: [vimage] [tap] [patch] Add VIMAGE support to if_tap X-BeenThere: freebsd-virtualization@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion of various virtualization techniques FreeBSD supports." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 16 Jun 2012 07:27:41 -0000 Synopsis: [vimage] [tap] [patch] Add VIMAGE support to if_tap State-Changed-From-To: open->closed State-Changed-By: trociny State-Changed-When: Sat Jun 16 07:26:59 UTC 2012 State-Changed-Why: Fixed. http://www.freebsd.org/cgi/query-pr.cgi?pr=158686 From owner-freebsd-virtualization@FreeBSD.ORG Sat Jun 16 07:30:24 2012 Return-Path: Delivered-To: freebsd-virtualization@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 896B8106564A for ; Sat, 16 Jun 2012 07:30:24 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 740C38FC19 for ; Sat, 16 Jun 2012 07:30:24 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id q5G7UOD5000660 for ; Sat, 16 Jun 2012 07:30:24 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.5/8.14.5/Submit) id q5G7UOjq000657; Sat, 16 Jun 2012 07:30:24 GMT (envelope-from gnats) Date: Sat, 16 Jun 2012 07:30:24 GMT Message-Id: <201206160730.q5G7UOjq000657@freefall.freebsd.org> To: freebsd-virtualization@FreeBSD.org From: Mikolaj Golub Cc: Subject: Re: kern/158686: [vimage] [tap] [patch] Add VIMAGE support to if_tap X-BeenThere: freebsd-virtualization@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Mikolaj Golub List-Id: "Discussion of various virtualization techniques FreeBSD supports." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 16 Jun 2012 07:30:24 -0000 The following reply was made to PR kern/158686; it has been noted by GNATS. From: Mikolaj Golub To: "Daan Vreeken \[PA4DAN\]" Cc: bug-followup@FreeBSD.org, Alexander V. Chernikov Subject: Re: kern/158686: [vimage] [tap] [patch] Add VIMAGE support to if_tap Date: Sat, 16 Jun 2012 10:25:26 +0300 Hi Daan, The patch is committed. Thank you! Note, I have not committed the "FIB" part of the patch though because I am not sure it was supposed to be done in this way. Your change looks reasonable for me, as it looks like without it mbufs of all incoming packets are not tagged on tap interface. On the other hand I don't see examples in kernel where tag is set before if_input() call (only before netisr_queue() or netisr_dispatch()). if_input() is actually ether_input(). May be it is supposed to just add this tag in ether_input()? I cc Alexander Chernikov, who is the author of the original patch that added mbuf tagging of incoming packets (r223741), and close this pr as the vimage part is fixed. -- Mikolaj Golub