From owner-freebsd-wireless@FreeBSD.ORG Sun Jan 8 18:46:56 2012 Return-Path: Delivered-To: freebsd-wireless@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C31CC106566C for ; Sun, 8 Jan 2012 18:46:56 +0000 (UTC) (envelope-from lev@FreeBSD.org) Received: from onlyone.friendlyhosting.spb.ru (onlyone.friendlyhosting.spb.ru [IPv6:2a01:4f8:131:60a2::2]) by mx1.freebsd.org (Postfix) with ESMTP id 5FCEF8FC0A for ; Sun, 8 Jan 2012 18:46:56 +0000 (UTC) Received: from lion.home.serebryakov.spb.ru (unknown [IPv6:2001:470:923f:1:1d3e:4d27:b4ee:e1e2]) (Authenticated sender: lev@serebryakov.spb.ru) by onlyone.friendlyhosting.spb.ru (Postfix) with ESMTPA id 982134AC1C for ; Sun, 8 Jan 2012 22:46:53 +0400 (MSK) Date: Sun, 8 Jan 2012 22:46:50 +0400 From: Lev Serebryakov X-Priority: 3 (Normal) Message-ID: <1445063345.20120108224650@serebryakov.spb.ru> To: freebsd-wireless@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=windows-1251 Content-Transfer-Encoding: quoted-printable Cc: Subject: ath0: device timeout X-BeenThere: freebsd-wireless@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussions of 802.11 stack, tools device driver development." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 08 Jan 2012 18:46:56 -0000 Hello, Freebsd-wireless. Notso-fresh 10.0-CURRENT/i386, ar9820, host-AP mode (WPA2). I've got this under load: ath0: stuck beacon; resetting (bmiss count 4) ar5212StopDmaReceive: dma failed to stop in 10ms AR_CR=3D0x00000024 AR_DIAG_SW=3D0x42000020 ath0: device timeout >> PREVIOUS LINE REPEARTED MANY TIMES ath0: device timeout ath0: ath_tx_tid_drain: node 0xc41a5000: tid 16: txq_depth=3D51, txq_aggr_d= epth=3D0, sched=3D0, paused=3D0, hwq_depth=3D0, incomp=3D0, baw_head=3D0, b= aw_tail=3D0 txa_start=3D-1, ni_txseqs=3D17 ath0: device timeout >> PREVIOUS LINE REPEARTED MANY TIMES ath0: device timeout >> I'm run "ifconfig wlan0 down && ifconfig wlan0 up" here ath0: ath_tx_tid_drain: node 0xc3385000: tid 16: txq_depth=3D0, txq_aggr_de= pth=3D0, sched=3D1, paused=3D0, hwq_depth=3D0, incomp=3D0, baw_head=3D0, ba= w_tail=3D0 txa_start=3D-1, ni_txseqs=3D2661 ath0: ath_tx_tid_drain: node 0xc41a5000: tid 16: txq_depth=3D0, txq_aggr_de= pth=3D0, sched=3D1, paused=3D0, hwq_depth=3D0, incomp=3D0, baw_head=3D0, ba= w_tail=3D0 txa_start=3D-1, ni_txseqs=3D2 ath0: ath_tx_tid_drain: node 0xc41aa000: tid 16: txq_depth=3D0, txq_aggr_de= pth=3D0, sched=3D1, paused=3D0, hwq_depth=3D0, incomp=3D0, baw_head=3D0, ba= w_tail=3D0 txa_start=3D-1, ni_txseqs=3D1 ath0: ath_tx_tid_drain: node 0xc41af000: tid 16: txq_depth=3D0, txq_aggr_de= pth=3D0, sched=3D1, paused=3D0, hwq_depth=3D0, incomp=3D0, baw_head=3D0, ba= w_tail=3D0 txa_start=3D-1, ni_txseqs=3D1 ar5416PerCalibrationN: NF calibration didn't finish; delaying CCA After that "reset" everything works. When NIC is stuck, clients could see SSID bbut could not associate (and associated clients lost association). Mow I'm building fresh current kernel. --=20 // Black Lion AKA Lev Serebryakov From owner-freebsd-wireless@FreeBSD.ORG Sun Jan 8 19:25:24 2012 Return-Path: Delivered-To: freebsd-wireless@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id A5719106566B; Sun, 8 Jan 2012 19:25:24 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Received: from mail-vw0-f54.google.com (mail-vw0-f54.google.com [209.85.212.54]) by mx1.freebsd.org (Postfix) with ESMTP id 4B0C38FC13; Sun, 8 Jan 2012 19:25:23 +0000 (UTC) Received: by vbbfr13 with SMTP id fr13so3667585vbb.13 for ; Sun, 08 Jan 2012 11:25:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=P82rvTo6sygOKUzvSqlNu0UrmxocidBPexgiWBkifqs=; b=aKXhV+xjwGAkEdxLmsdC4nTH5jOREYeeEBY5EQYO2vuOVkPWT6JAAoEJerxiW9qCrn sUXzFbeTmStWeEx+zWj2kZ8rymgKZ0WKauCmSfLS5p2s2odxME83sthUT7IudXF1ew5A oyW4xDNRaEQsL9B8nPcOlMRhfFKWRjubx6L3c= MIME-Version: 1.0 Received: by 10.52.26.66 with SMTP id j2mr6256377vdg.98.1326050722408; Sun, 08 Jan 2012 11:25:22 -0800 (PST) Sender: adrian.chadd@gmail.com Received: by 10.52.36.5 with HTTP; Sun, 8 Jan 2012 11:25:22 -0800 (PST) In-Reply-To: <1445063345.20120108224650@serebryakov.spb.ru> References: <1445063345.20120108224650@serebryakov.spb.ru> Date: Sun, 8 Jan 2012 11:25:22 -0800 X-Google-Sender-Auth: cT60BdmAYnFEd0HPtp1-y8POelA Message-ID: From: Adrian Chadd To: Lev Serebryakov Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: freebsd-wireless@freebsd.org Subject: Re: ath0: device timeout X-BeenThere: freebsd-wireless@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussions of 802.11 stack, tools device driver development." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 08 Jan 2012 19:25:24 -0000 Which NIC is this again? I know there are some subtle software TX bugs. I'm trying to hunt them down and squish them.. Adrian 2012/1/8 Lev Serebryakov : > Hello, Freebsd-wireless. > > =A0Notso-fresh 10.0-CURRENT/i386, ar9820, host-AP mode (WPA2). I've got > this under load: > > ath0: stuck beacon; resetting (bmiss count 4) > ar5212StopDmaReceive: dma failed to stop in 10ms > AR_CR=3D0x00000024 > AR_DIAG_SW=3D0x42000020 > ath0: device timeout >>> PREVIOUS LINE REPEARTED MANY TIMES > ath0: device timeout > ath0: ath_tx_tid_drain: node 0xc41a5000: tid 16: txq_depth=3D51, txq_aggr= _depth=3D0, sched=3D0, paused=3D0, hwq_depth=3D0, incomp=3D0, baw_head=3D0,= baw_tail=3D0 txa_start=3D-1, ni_txseqs=3D17 > ath0: device timeout >>> PREVIOUS LINE REPEARTED MANY TIMES > ath0: device timeout >>> I'm run "ifconfig wlan0 down && ifconfig wlan0 up" here > ath0: ath_tx_tid_drain: node 0xc3385000: tid 16: txq_depth=3D0, txq_aggr_= depth=3D0, sched=3D1, paused=3D0, hwq_depth=3D0, incomp=3D0, baw_head=3D0, = baw_tail=3D0 txa_start=3D-1, ni_txseqs=3D2661 > ath0: ath_tx_tid_drain: node 0xc41a5000: tid 16: txq_depth=3D0, txq_aggr_= depth=3D0, sched=3D1, paused=3D0, hwq_depth=3D0, incomp=3D0, baw_head=3D0, = baw_tail=3D0 txa_start=3D-1, ni_txseqs=3D2 > ath0: ath_tx_tid_drain: node 0xc41aa000: tid 16: txq_depth=3D0, txq_aggr_= depth=3D0, sched=3D1, paused=3D0, hwq_depth=3D0, incomp=3D0, baw_head=3D0, = baw_tail=3D0 txa_start=3D-1, ni_txseqs=3D1 > ath0: ath_tx_tid_drain: node 0xc41af000: tid 16: txq_depth=3D0, txq_aggr_= depth=3D0, sched=3D1, paused=3D0, hwq_depth=3D0, incomp=3D0, baw_head=3D0, = baw_tail=3D0 txa_start=3D-1, ni_txseqs=3D1 > ar5416PerCalibrationN: NF calibration didn't finish; delaying CCA > > =A0After that "reset" everything works. When NIC is stuck, clients > could see SSID bbut could not associate (and associated clients lost > association). > > =A0Mow I'm building fresh current kernel. > > -- > // Black Lion AKA Lev Serebryakov > > _______________________________________________ > freebsd-wireless@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-wireless > To unsubscribe, send any mail to "freebsd-wireless-unsubscribe@freebsd.or= g" From owner-freebsd-wireless@FreeBSD.ORG Sun Jan 8 19:48:00 2012 Return-Path: Delivered-To: freebsd-wireless@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 132EE106564A; Sun, 8 Jan 2012 19:48:00 +0000 (UTC) (envelope-from lev@freebsd.org) Received: from onlyone.friendlyhosting.spb.ru (onlyone.friendlyhosting.spb.ru [IPv6:2a01:4f8:131:60a2::2]) by mx1.freebsd.org (Postfix) with ESMTP id C88728FC13; Sun, 8 Jan 2012 19:47:59 +0000 (UTC) Received: from lion.home.serebryakov.spb.ru (unknown [IPv6:2001:470:923f:1:1d3e:4d27:b4ee:e1e2]) (Authenticated sender: lev@serebryakov.spb.ru) by onlyone.friendlyhosting.spb.ru (Postfix) with ESMTPA id 587884AC1C; Sun, 8 Jan 2012 23:47:57 +0400 (MSK) Date: Sun, 8 Jan 2012 23:47:54 +0400 From: Lev Serebryakov X-Priority: 3 (Normal) Message-ID: <814439520.20120108234754@serebryakov.spb.ru> To: Adrian Chadd In-Reply-To: References: <1445063345.20120108224650@serebryakov.spb.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=windows-1251 Content-Transfer-Encoding: quoted-printable Cc: freebsd-wireless@freebsd.org Subject: Re: ath0: device timeout X-BeenThere: freebsd-wireless@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussions of 802.11 stack, tools device driver development." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 08 Jan 2012 19:48:00 -0000 Hello, Adrian. You wrote 8 =FF=ED=E2=E0=F0=FF 2012 =E3., 23:25:22: > Which NIC is this again? ath0: mem 0xa0060000-0xa006ffff irq 15 at device 17.0 on pci0 ath0: [HT] enabling HT modes ath0: [HT] 2 RX streams; 2 TX streams ath0: AR9220 mac 128.2 RF5133 phy 13.0 2.4Ghz only TP-Link Mini-PCI card. > I know there are some subtle software TX bugs. I'm trying to hunt them It is more like hardware problem -- DMA timeout and many timeouts after that. > down and squish them.. It is not so fresh Current: FreeBSD gateway.home.serebryakov.spb.ru 10.0-CURRENT FreeBSD 10.0-CURRENT = #0: Wed Nov 23 16:54:37 MSK 2011 I'm building fresh 10-CURRENT now... --=20 // Black Lion AKA Lev Serebryakov From owner-freebsd-wireless@FreeBSD.ORG Sun Jan 8 19:54:40 2012 Return-Path: Delivered-To: freebsd-wireless@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 26A641065672; Sun, 8 Jan 2012 19:54:40 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Received: from mail-vx0-f182.google.com (mail-vx0-f182.google.com [209.85.220.182]) by mx1.freebsd.org (Postfix) with ESMTP id BE6E88FC0C; Sun, 8 Jan 2012 19:54:39 +0000 (UTC) Received: by vcbfk1 with SMTP id fk1so3668462vcb.13 for ; Sun, 08 Jan 2012 11:54:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=/t6zkrBWg78VhoKVvXhjEn5GgM6RdV3vqmL0Hbv1oZA=; b=l7VcWGo6wX4hfhWYvB6R1Csi3CBNcGnhLqqIX1gFtkITwcT6VDH/HPGCAzZUNfO4Yf xxgu5D6Ys20iJmL/CW8SjM2Yw9eesYycb3n+H1nNIxbpWi/e42/HFsmt5wRPiYPiDTAi +AdaPIwI4bPO4ivYa7X+awsPh2xqpnItCExEM= MIME-Version: 1.0 Received: by 10.220.149.207 with SMTP id u15mr7760778vcv.27.1326052477202; Sun, 08 Jan 2012 11:54:37 -0800 (PST) Sender: adrian.chadd@gmail.com Received: by 10.52.36.5 with HTTP; Sun, 8 Jan 2012 11:54:37 -0800 (PST) In-Reply-To: <814439520.20120108234754@serebryakov.spb.ru> References: <1445063345.20120108224650@serebryakov.spb.ru> <814439520.20120108234754@serebryakov.spb.ru> Date: Sun, 8 Jan 2012 11:54:37 -0800 X-Google-Sender-Auth: kxCQD4R5ADGL9dneVjGnH22L7Ok Message-ID: From: Adrian Chadd To: Lev Serebryakov Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Cc: freebsd-wireless@freebsd.org Subject: Re: ath0: device timeout X-BeenThere: freebsd-wireless@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussions of 802.11 stack, tools device driver development." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 08 Jan 2012 19:54:40 -0000 It's not a hardware problem. :) Adrian 2012/1/8 Lev Serebryakov : > Hello, Adrian. > You wrote 8 =D1=8F=D0=BD=D0=B2=D0=B0=D1=80=D1=8F 2012 =D0=B3., 23:25:22: > >> Which NIC is this again? > > ath0: mem 0xa0060000-0xa006ffff irq 15 at device 17.0 on p= ci0 > ath0: [HT] enabling HT modes > ath0: [HT] 2 RX streams; 2 TX streams > ath0: AR9220 mac 128.2 RF5133 phy 13.0 > > 2.4Ghz only TP-Link Mini-PCI card. > > >> I know there are some subtle software TX bugs. I'm trying to hunt them > =C2=A0It is more like hardware problem -- DMA timeout and many timeouts > after that. > >> down and squish them.. > =C2=A0It is not so fresh Current: > > =C2=A0FreeBSD gateway.home.serebryakov.spb.ru 10.0-CURRENT FreeBSD 10.0-C= URRENT #0: Wed Nov 23 16:54:37 MSK 2011 > > =C2=A0I'm building fresh 10-CURRENT now... > > -- > // Black Lion AKA Lev Serebryakov > From owner-freebsd-wireless@FreeBSD.ORG Mon Jan 9 11:07:17 2012 Return-Path: Delivered-To: freebsd-wireless@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id A59D3106566B for ; Mon, 9 Jan 2012 11:07:17 +0000 (UTC) (envelope-from owner-bugmaster@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 930CF8FC18 for ; Mon, 9 Jan 2012 11:07:17 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id q09B7H6P042364 for ; Mon, 9 Jan 2012 11:07:17 GMT (envelope-from owner-bugmaster@FreeBSD.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.5/8.14.5/Submit) id q09B7GBG042362 for freebsd-wireless@FreeBSD.org; Mon, 9 Jan 2012 11:07:16 GMT (envelope-from owner-bugmaster@FreeBSD.org) Date: Mon, 9 Jan 2012 11:07:16 GMT Message-Id: <201201091107.q09B7GBG042362@freefall.freebsd.org> X-Authentication-Warning: freefall.freebsd.org: gnats set sender to owner-bugmaster@FreeBSD.org using -f From: FreeBSD bugmaster To: freebsd-wireless@FreeBSD.org Cc: Subject: Current problem reports assigned to freebsd-wireless@FreeBSD.org X-BeenThere: freebsd-wireless@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussions of 802.11 stack, tools device driver development." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 09 Jan 2012 11:07:17 -0000 Note: to view an individual PR, use: http://www.freebsd.org/cgi/query-pr.cgi?pr=(number). The following is a listing of current problems submitted by FreeBSD users. These represent problem reports covering all versions including experimental development code and obsolete releases. S Tracker Resp. Description -------------------------------------------------------------------------------- o kern/163759 wireless [ath] ath(4) "stops working" in hostap mode o kern/163724 wireless [mwl] [patch] NULL check before dereference o kern/163719 wireless [ath] ath interface do not receive multicast o kern/163689 wireless [ath] TX timeouts when sending probe/mgmt frames durin o kern/163574 wireless [net80211] overly-frequent HT occupancy changes o kern/163573 wireless [ath] hostap mode TX buffer hang o kern/163318 wireless [ath] ath(4) stops working o kern/163312 wireless [panic] [ath driver] kernel panic: page fault with ath o kern/163082 wireless [ath] ar9285 diversity fixes o kern/162648 wireless [ath] AR9227 ADC DC calibration failure o kern/162647 wireless [ath] 11n TX aggregation session / TX hang o kern/161293 wireless [iwn] hang at startup when starting network o kern/161035 wireless [ieee80211] Incorrect number describing 11ng MCS rate o kern/160391 wireless [ieee80211] [patch] Panic in mesh mode o kern/160296 wireless [zyd] [panic] 802.11 usb device reboots system on 'ifc o misc/160176 wireless [mips] [panic] Kernel panic on AR7161 platform with AR o kern/157449 wireless [ath] MAC address conflict causes system to freeze o kern/157243 wireless [ath] investigate beacon TX (AP) / RX (STA) when under o kern/156904 wireless [ath] AR9285 antenna diversity algorithm is buggy and o kern/156884 wireless [ath] ath instablity o kern/156327 wireless [bwn] bwn driver causes 20%-50% packet loss o kern/156322 wireless [wpi] no ahdemo support for if_wpi o kern/156321 wireless [ath] ahdemo doesn't work with if_ath o kern/155498 wireless [ral] ral(4) needs to be resynced with OpenBSD's to ga o kern/155100 wireless [ath] ath driver on busy channel: "stuck beacon" p kern/154598 wireless [ath] Atheros 5424/2424 can't connect to WPA network o kern/154567 wireless [ath] ath(4) lot of bad series(0) o kern/154327 wireless [ath] AR5416 in station mode hangs when transmitting f o kern/154284 wireless [ath] Modern ath wifi cards (such as AR9285) have miss o kern/154153 wireless [ath] AR5213 + MIPS + WPA group key packet corruption o kern/153448 wireless [ath] ath networking device loses association after a o kern/152750 wireless [ath] ath0 lot of bad series hwrate o kern/151198 wireless [ath] ath/5416 fails bgscan with "ath0: ath_chan_set: o kern/149786 wireless [bwn] bwn on Dell Inspiron 1150: connections stall o kern/149516 wireless [ath] ath(4) hostap with fake MAC/BSSID results in sta o kern/149373 wireless [realtek/atheros]: None of my network card working o kern/148322 wireless [ath] Triggering atheros wifi beacon misses in hostap o kern/148317 wireless [ath] FreeBSD 7.x hostap memory leak in net80211 or At o kern/148078 wireless [ath] wireless networking stops functioning o kern/145826 wireless [panic] [ath] Unable to configure adhoc mode on ath0/w o kern/144987 wireless [wpi] [panic] injecting packets with wlaninject using o bin/144109 wireless hostapd(8) uses the MAC of the wireless interface, but o conf/143079 wireless hostapd(8) startup missing multi wlan functionality p kern/140567 wireless [ath] [patch] ath is not worked on my notebook PC o kern/140245 wireless [ath] [panic] Kernel panic during network activity on o kern/137592 wireless [ath] panic - 7-STABLE (Aug 7, 2009 UTC) crashes on ne p bin/137484 wireless [patch] Integer overflow in wpa_supplicant(8) base64 e o kern/136943 wireless [wpi] [lor] wpi0_com_lock / wpi0 o kern/136836 wireless [ath] atheros card stops functioning after about 12 ho o kern/132722 wireless [ath] Wifi ath0 associates fine with AP, but DHCP or I o bin/131549 wireless ifconfig(8) can't clear 'monitor' mode on the wireless o kern/126475 wireless [ath] [panic] ath pcmcia card inevitably panics under o kern/125721 wireless [ath] Terrible throughput/high ping latency with Ubiqu o kern/125617 wireless [ath] [panic] ath(4) related panic o kern/125501 wireless [ath] atheros cardbus driver hangs o kern/125332 wireless [ath] [panic] crash under any non-tiny networking unde o kern/124767 wireless [iwi] Wireless connection using iwi0 driver (Intel 220 o kern/124753 wireless [ieee80211] net80211 discards power-save queue packets o docs/120456 wireless ath(4) needs to specify requirement on wlan_scan_sta o kern/119513 wireless [ath] [irq] inserting dlink dwl-g630 wireless card res o kern/116747 wireless [ndis] FreeBSD 7.0-CURRENT crash with Dell TrueMobile f kern/105348 wireless [ath] ath device stopps TX 62 problems total. From owner-freebsd-wireless@FreeBSD.ORG Mon Jan 9 17:34:19 2012 Return-Path: Delivered-To: freebsd-wireless@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 55214106564A for ; Mon, 9 Jan 2012 17:34:19 +0000 (UTC) (envelope-from monthadar@gmail.com) Received: from mail-gy0-f182.google.com (mail-gy0-f182.google.com [209.85.160.182]) by mx1.freebsd.org (Postfix) with ESMTP id 1A7168FC15 for ; Mon, 9 Jan 2012 17:34:18 +0000 (UTC) Received: by ghrr16 with SMTP id r16so1900637ghr.13 for ; Mon, 09 Jan 2012 09:34:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:date:message-id:subject:from:to:content-type; bh=8sMCN2AZByh8qfmlbihX0ESpt6BxbLsjkIG2/q3+Bgg=; b=Qca3se87Mn3JLkGwp1v2Z+/BeQQtwW+1gfkwWC8YgmWvpMCJ1SYcfkcAGurLKGUj4A qGHeZBwVEA2eyxwsja5h4oTg2DBDLnEEqtCE4Dg9l11F+d3dRcvdZBJOWRnpiUvTwFID RKHOmpE4PUygM46wMGcgPyJRuTmIpqPiWe4so= MIME-Version: 1.0 Received: by 10.101.24.16 with SMTP id b16mr7108044anj.36.1326128975660; Mon, 09 Jan 2012 09:09:35 -0800 (PST) Received: by 10.100.34.11 with HTTP; Mon, 9 Jan 2012 09:09:35 -0800 (PST) Date: Mon, 9 Jan 2012 18:09:35 +0100 Message-ID: From: Monthadar Al Jaberi To: freebsd-wireless@freebsd.org Content-Type: text/plain; charset=ISO-8859-1 Subject: kick mesh node X-BeenThere: freebsd-wireless@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussions of 802.11 stack, tools device driver development." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 09 Jan 2012 17:34:19 -0000 Hi, I dont know if this is the correct way to do it. if you run "ifconfig wlan0 mac:kick address" you will get Invalid argument error because there is no code for MBSS. This is patch makes it possible to kick a mesh node, useful when for example you have some entries left "dead" in your table awaiting node reclaim timeout. Because there is no auth/assoc code for mesh I guess this is enough (maybe we can try to send CLOSE LINK to the entry we kick so that it updates its entries?): --- a/sys/net80211/ieee80211_ioctl.c +++ b/sys/net80211/ieee80211_ioctl.c @@ -1397,6 +1397,17 @@ setmlme_common(struct ieee80211vap *vap, int op, IEEE80211_FC0_SUBTYPE_DEAUTH, reason); ieee80211_free_node(ni); break; + case IEEE80211_M_MBSS: + IEEE80211_NODE_LOCK(nt); + ni = ieee80211_find_node_locked(nt, mac); + if (ni != NULL) { + ieee80211_node_leave(ni); + ieee80211_free_node(ni); + }else{ + error = ENOENT; + } + IEEE80211_NODE_UNLOCK(nt); + break; default: error = EINVAL; break; -- Monthadar Al Jaberi From owner-freebsd-wireless@FreeBSD.ORG Mon Jan 9 19:43:40 2012 Return-Path: Delivered-To: freebsd-wireless@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 49FC7106566C for ; Mon, 9 Jan 2012 19:43:40 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Received: from mail-vx0-f182.google.com (mail-vx0-f182.google.com [209.85.220.182]) by mx1.freebsd.org (Postfix) with ESMTP id 038698FC0C for ; Mon, 9 Jan 2012 19:43:39 +0000 (UTC) Received: by vcbfk1 with SMTP id fk1so4626998vcb.13 for ; Mon, 09 Jan 2012 11:43:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type; bh=YXMBUPg1VdHipZmOjC3pEwV0NIOa02ddn/9oaitqiGE=; b=iFMY5+Fv692ft7uVAwKuZnCGJEkU1oSiSd44mYQVmNdbGrkhOnhj81FbLRQVabEiI+ gFPJw9UuejqyI5Ilf0DLZHCqqwc45412TxfLUgPVNdHCii/u7ojJ+JIFZnJf0SNrk+k5 ker62CtDdWMwN8JgnT2aTpeB7wWBErKbfXDYA= MIME-Version: 1.0 Received: by 10.220.156.134 with SMTP id x6mr10032596vcw.17.1326138219407; Mon, 09 Jan 2012 11:43:39 -0800 (PST) Sender: adrian.chadd@gmail.com Received: by 10.52.36.5 with HTTP; Mon, 9 Jan 2012 11:43:39 -0800 (PST) In-Reply-To: References: Date: Mon, 9 Jan 2012 11:43:39 -0800 X-Google-Sender-Auth: 8GH4TAGh3ggN1ZPviyovpJ0_ILQ Message-ID: From: Adrian Chadd To: Monthadar Al Jaberi Content-Type: text/plain; charset=ISO-8859-1 Cc: freebsd-wireless@freebsd.org Subject: Re: kick mesh node X-BeenThere: freebsd-wireless@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussions of 802.11 stack, tools device driver development." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 09 Jan 2012 19:43:40 -0000 Hi, That sounds fine. On 9 January 2012 09:09, Monthadar Al Jaberi wrote: > Hi, > > I dont know if this is the correct way to do it. > > if you run "ifconfig wlan0 mac:kick address" you will get Invalid > argument error because there is no code for MBSS. > > This is patch makes it possible to kick a mesh node, useful when for > example you have some entries left "dead" in your table awaiting node > reclaim timeout. > > Because there is no auth/assoc code for mesh I guess this is enough > (maybe we can try to send CLOSE LINK to the entry we kick so that it > updates its entries?): That also sounds like a good idea for a future project. I wonder if these ioctls should be broken out per-VAP.. Adrian From owner-freebsd-wireless@FreeBSD.ORG Tue Jan 10 08:13:04 2012 Return-Path: Delivered-To: freebsd-wireless@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 143171065670; Tue, 10 Jan 2012 08:13:04 +0000 (UTC) (envelope-from monthadar@gmail.com) Received: from mail-tul01m020-f182.google.com (mail-tul01m020-f182.google.com [209.85.214.182]) by mx1.freebsd.org (Postfix) with ESMTP id C214D8FC0C; Tue, 10 Jan 2012 08:13:03 +0000 (UTC) Received: by obbwd18 with SMTP id wd18so7070495obb.13 for ; Tue, 10 Jan 2012 00:13:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=MUtzmfcA9qyBWqt9O4Pr3UPvPuODvwFMgMOGxzloW58=; b=lZFjcp7af64dCnz5sIA9DPnEnv1pQb7CRxKfPM4x43vAsAjoaA4l8NGcV3kg3TQej4 cDAy/IvZcHimlkckoIIk3Q/vDinOk79s25X5hVhxFx9/whE8if3LJO/uTAaQyK0sQNWr +BkWB+Zid7I0jxjlxdcluTo+gyEUO6MmerCbQ= MIME-Version: 1.0 Received: by 10.50.193.229 with SMTP id hr5mr1432739igc.15.1326183182988; Tue, 10 Jan 2012 00:13:02 -0800 (PST) Received: by 10.50.237.68 with HTTP; Tue, 10 Jan 2012 00:13:02 -0800 (PST) In-Reply-To: References: Date: Tue, 10 Jan 2012 09:13:02 +0100 Message-ID: From: Monthadar Al Jaberi To: Adrian Chadd Content-Type: text/plain; charset=ISO-8859-1 Cc: freebsd-wireless@freebsd.org Subject: Re: kick mesh node X-BeenThere: freebsd-wireless@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussions of 802.11 stack, tools device driver development." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Jan 2012 08:13:04 -0000 On Mon, Jan 9, 2012 at 8:43 PM, Adrian Chadd wrote: > Hi, > > That sounds fine. > > On 9 January 2012 09:09, Monthadar Al Jaberi wrote: >> Hi, >> >> I dont know if this is the correct way to do it. >> >> if you run "ifconfig wlan0 mac:kick address" you will get Invalid >> argument error because there is no code for MBSS. >> >> This is patch makes it possible to kick a mesh node, useful when for >> example you have some entries left "dead" in your table awaiting node >> reclaim timeout. >> >> Because there is no auth/assoc code for mesh I guess this is enough >> (maybe we can try to send CLOSE LINK to the entry we kick so that it >> updates its entries?): > > That also sounds like a good idea for a future project. > > I wonder if these ioctls should be broken out per-VAP.. I think if mesh code has assoc/auth code case IEEE80211_M_MBSS would looks excatly like case IEEE80211_M_HOSTAP. > > > Adrian Btw, ifconfig man should be updated, there is a missing ACL command: mac:detach which is not described in the man page. -- Monthadar Al Jaberi From owner-freebsd-wireless@FreeBSD.ORG Tue Jan 10 18:00:24 2012 Return-Path: Delivered-To: freebsd-wireless@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id ED076106564A for ; Tue, 10 Jan 2012 18:00:24 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id DC29E8FC08 for ; Tue, 10 Jan 2012 18:00:24 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id q0AI0Ols088372 for ; Tue, 10 Jan 2012 18:00:24 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.5/8.14.5/Submit) id q0AI0Oxx088371; Tue, 10 Jan 2012 18:00:24 GMT (envelope-from gnats) Date: Tue, 10 Jan 2012 18:00:24 GMT Message-Id: <201201101800.q0AI0Oxx088371@freefall.freebsd.org> To: freebsd-wireless@FreeBSD.org From: Joel Dahl Cc: Subject: Re: kern/163318: [ath] ath(4) stops working X-BeenThere: freebsd-wireless@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Joel Dahl List-Id: "Discussions of 802.11 stack, tools device driver development." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Jan 2012 18:00:25 -0000 The following reply was made to PR kern/163318; it has been noted by GNATS. From: Joel Dahl To: bug-followup@freebsd.org Cc: Subject: Re: kern/163318: [ath] ath(4) stops working Date: Tue, 10 Jan 2012 18:50:37 +0100 For the record: I put in another PCI ath(4) card and I'm seeing the same thing with this card. After a while, wireless stops working. It seems to go in to some power save mode, and then gets stuck. ifconfig wlan0 scan fixes it, as usual. One thing I've noticed though is that it seems to take much longer for this card to stop working. Usually around 9-10 hours. Could be a coincidence of course. This card is identified as: joel@crashbox [~] dmesg | grep ath ath0: mem 0xf0600000-0xf060ffff irq 20 at device 0.0 on pci16 ath0: AR2413 mac 7.9 RF2413 phy 4.5 ath0: 2GHz radio: 0x0000; 5GHz radio: 0x0056 ath0@pci0:16:0:0: class=0x020000 card=0x3a131186 chip=0x0013168c rev=0x01 hdr=0x00 vendor = 'Atheros Communications Inc.' device = 'Atheros AR5001X+ Wireless Network Adapter' class = network subclass = ethernet bar [10] = type Memory, range 32, base 0xf0600000, size 65536, enabled cap 01[44] = powerspec 2 supports D0 D3 current D0 -- Joel From owner-freebsd-wireless@FreeBSD.ORG Tue Jan 10 18:30:25 2012 Return-Path: Delivered-To: freebsd-wireless@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id A892E106566C; Tue, 10 Jan 2012 18:30:25 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Received: from mail-vw0-f54.google.com (mail-vw0-f54.google.com [209.85.212.54]) by mx1.freebsd.org (Postfix) with ESMTP id 55C368FC0A; Tue, 10 Jan 2012 18:30:24 +0000 (UTC) Received: by vbbfr13 with SMTP id fr13so5842069vbb.13 for ; Tue, 10 Jan 2012 10:30:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; bh=ooy5nHkZAj2csH3xbozdr6piijWDhMHRPqjkNlj3Tnw=; b=EBNLIZEijUQg1k5W0IrikKIGPG5/PMzD4OuHXidieBhmzNrsnSU2K2baanA/L4aY6b u/HdKQq3Hx8kFhXiyNx3DkROgCYd4cClqsTiaP2jiENY1AoKDCi2DYe6DorzCBu/V+6t PiVNX2UqUT1azrbck9NJ7A1hg55FE1QXa7R+g= MIME-Version: 1.0 Received: by 10.52.173.80 with SMTP id bi16mr9896294vdc.115.1326220224522; Tue, 10 Jan 2012 10:30:24 -0800 (PST) Received: by 10.52.36.5 with HTTP; Tue, 10 Jan 2012 10:30:24 -0800 (PST) In-Reply-To: <201201101800.q0AI0Oxx088371@freefall.freebsd.org> References: <201201101800.q0AI0Oxx088371@freefall.freebsd.org> Date: Tue, 10 Jan 2012 10:30:24 -0800 Message-ID: From: Adrian Chadd To: Joel Dahl Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: freebsd-wireless@freebsd.org Subject: Re: kern/163318: [ath] ath(4) stops working X-BeenThere: freebsd-wireless@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussions of 802.11 stack, tools device driver development." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Jan 2012 18:30:25 -0000 Hi, On 10 January 2012 10:00, Joel Dahl wrote: > =A0For the record: I put in another PCI ath(4) card and I'm seeing the sa= me > =A0thing with this card. After a while, wireless stops working. It seems = to > =A0go in to some power save mode, and then gets stuck. ifconfig wlan0 sca= n > =A0fixes it, as usual. > > =A0One thing I've noticed though is that it seems to take much longer for= this > =A0card to stop working. Usually around 9-10 hours. Could be a coincidenc= e of > =A0course. Hm. Right, I didn't think it was chipset specific. I think it's very likely another subtle race condition inside net80211 which we just haven't properly fixed. The scan stuff _should_ be running in the net80211 taskqueue (which one exists per interface, iirc.) So it shouldn't be racing with itself, but it may be racing with other bits. I'm trying to reproduce it here, but I won't have a dual-core machine w/ an AR9220 ready for another week or two. Adrian From owner-freebsd-wireless@FreeBSD.ORG Tue Jan 10 21:24:35 2012 Return-Path: Delivered-To: freebsd-wireless@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 5B456106564A; Tue, 10 Jan 2012 21:24:35 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Received: from mail-vw0-f54.google.com (mail-vw0-f54.google.com [209.85.212.54]) by mx1.freebsd.org (Postfix) with ESMTP id F0E2B8FC0C; Tue, 10 Jan 2012 21:24:34 +0000 (UTC) Received: by mail-vw0-f54.google.com with SMTP id fr13so33214vbb.13 for ; Tue, 10 Jan 2012 13:24:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=jBT7hmuYAzTriMeGxt7JcEtpaxtLNcois9BZMsOCm+s=; b=gCyFSvI3JMYQ7gfd1l/1K3g5oNQB5ykyt400W2fKCp0zWWtSsfS/7SgYKbEJKJ98KF SmmHv6Xttrp5OA4bXCW4MM7w9DLBJa7YfNcp0aeK1W/mU+4reaQSdt9lseKPTI8zuXuk DC9mL37g8OBa4UGIIuOT4N/cQcQ3SG7VEk3iU= MIME-Version: 1.0 Received: by 10.52.24.35 with SMTP id r3mr10277571vdf.81.1326230674788; Tue, 10 Jan 2012 13:24:34 -0800 (PST) Received: by 10.52.36.5 with HTTP; Tue, 10 Jan 2012 13:24:34 -0800 (PST) In-Reply-To: References: <201201101800.q0AI0Oxx088371@freefall.freebsd.org> Date: Tue, 10 Jan 2012 13:24:34 -0800 Message-ID: From: Adrian Chadd To: Joel Dahl Content-Type: text/plain; charset=ISO-8859-1 Cc: freebsd-wireless@freebsd.org Subject: Re: kern/163318: [ath] ath(4) stops working X-BeenThere: freebsd-wireless@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussions of 802.11 stack, tools device driver development." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Jan 2012 21:24:35 -0000 .. cool, I've finally reproduced it on this laptop, with an AR9280. Now to figure out how to always reproduce it.. Adrian From owner-freebsd-wireless@FreeBSD.ORG Wed Jan 11 04:40:59 2012 Return-Path: Delivered-To: freebsd-wireless@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 9BE5A1065729 for ; Wed, 11 Jan 2012 04:40:59 +0000 (UTC) (envelope-from monthadar@gmail.com) Received: from mail-iy0-f182.google.com (mail-iy0-f182.google.com [209.85.210.182]) by mx1.freebsd.org (Postfix) with ESMTP id 64AA68FC0A for ; Wed, 11 Jan 2012 04:40:59 +0000 (UTC) Received: by iazz13 with SMTP id z13so728409iaz.13 for ; Tue, 10 Jan 2012 20:40:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:date:message-id:subject:from:to:content-type; bh=HS5V38v8jPmLjgTPvbUsjYhk6abGltF94oZkTqxi25A=; b=GtzbBQK62zEBVZlQ40Xykh0RwfGgCU+rahgn+FaGIuRLzc6JGhqddbEq+rArusd4+w JrgxCo5BE9KUil3BuGhaxSfLMYw3syq8PZPx87azx9640vXpRMpNaQ1MjbTQnsIY/IaE Qsn9z9r4c7Qgu9perJ1GXzfsr5v6zhHlck0tw= MIME-Version: 1.0 Received: by 10.50.180.233 with SMTP id dr9mr4942074igc.11.1326256858984; Tue, 10 Jan 2012 20:40:58 -0800 (PST) Received: by 10.50.237.68 with HTTP; Tue, 10 Jan 2012 20:40:58 -0800 (PST) Date: Wed, 11 Jan 2012 05:40:58 +0100 Message-ID: From: Monthadar Al Jaberi To: freebsd-wireless@freebsd.org Content-Type: multipart/mixed; boundary=14dae9340cc7f5f09404b6393c41 Subject: 11s mesh path setup problem X-BeenThere: freebsd-wireless@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussions of 802.11 stack, tools device driver development." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 11 Jan 2012 04:40:59 -0000 --14dae9340cc7f5f09404b6393c41 Content-Type: text/plain; charset=ISO-8859-1 Hi, Current hwmp cant handle to setup a path between 4 nodes in a line topology (among other things it cant handle) Below you will find a small patch to correct this with some debug output cleanup and comments. After the patch, you should be able to e.g. ping from node 4 to node 1 and get a ping reply back, he is what the output from ifconfig list mesh should look like on all 4 nodes after one ping packet. Node1# ifconfig wlan1 list mesh DEST NEXT HOP HOPS METRIC LIFETIME MSEQ FLAGS Node2 Node2 1 17018 5000 0 V Node3 Node2 2 34036 5000 0 V Node4 Node2 3 34036 5000 3 V Node2# ifconfig wlan1 list mesh DEST NEXT HOP HOPS METRIC LIFETIME MSEQ FLAGS Node1 Node1 1 17018 5000 3 V Node3 Node3 1 17018 5000 0 V Node4 Node3 2 17018 5000 3 V Node3# ifconfig wlan1 list mesh DEST NEXT HOP HOPS METRIC LIFETIME MSEQ FLAGS Node2 Node2 1 0 5000 0 V Node4 Node4 1 0 5000 3 V Node1 Node2 2 34036 5000 3 V Node4# ifconfig wlan1 list mesh DEST NEXT HOP HOPS METRIC LIFETIME MSEQ FLAGS Node3 Node3 1 0 5000 0 V Node1 Node3 3 51054 5000 3 V If anyone could try it that would be nice, either on real hardware as I did above, or in a simulated environment (https://github.com/monthadar/FreeBSD-IEEE80211s-simulator/wiki) :) and please do test other scenarios :) patch is attached. -- Monthadar Al Jaberi --14dae9340cc7f5f09404b6393c41 Content-Type: text/x-patch; charset=US-ASCII; name="patch_11s_4_nodes_in_line.patch" Content-Disposition: attachment; filename="patch_11s_4_nodes_in_line.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_gx9v1nv70 ZGlmZiAtLWdpdCBhL3N5cy9uZXQvaWZfZXRoZXJzdWJyLmMgYi9zeXMvbmV0L2lmX2V0aGVyc3Vi ci5jCmluZGV4IDFkMTZhZTYuLmZjODZjOTQgMTAwNjQ0Ci0tLSBhL3N5cy9uZXQvaWZfZXRoZXJz dWJyLmMKKysrIGIvc3lzL25ldC9pZl9ldGhlcnN1YnIuYwpAQCAtOTY4LDkgKzk2OCwxMyBAQCBk aXNjYXJkOgogY2hhciAqCiBldGhlcl9zcHJpbnRmKGNvbnN0IHVfY2hhciAqYXApCiB7Ci0Jc3Rh dGljIGNoYXIgZXRoZXJidWZbMThdOwotCXNucHJpbnRmKGV0aGVyYnVmLCBzaXplb2YgKGV0aGVy YnVmKSwgIiU2RCIsIGFwLCAiOiIpOwotCXJldHVybiAoZXRoZXJidWYpOworCXN0YXRpYyBjaGFy IGV0aGVyYnVmWzZdWzE4XTsKKwlzdGF0aWMgaW50IGkgPSAwOworCWNoYXIgKmJ1ZjsKKwlzbnBy aW50ZihldGhlcmJ1ZltpXSwgc2l6ZW9mIChldGhlcmJ1ZlswXSksICIlNkQiLCBhcCwgIjoiKTsK KwlidWYgPSBldGhlcmJ1ZltpXTsKKwlpID0gKGkrMSklMjsKKwlyZXR1cm4gKGJ1Zik7CiB9CiAK IC8qCmRpZmYgLS1naXQgYS9zeXMvbmV0ODAyMTEvaWVlZTgwMjExX2h3bXAuYyBiL3N5cy9uZXQ4 MDIxMS9pZWVlODAyMTFfaHdtcC5jCmluZGV4IDc4NzI5ZmMuLjdjOTkzNTEgMTAwNjQ0Ci0tLSBh L3N5cy9uZXQ4MDIxMS9pZWVlODAyMTFfaHdtcC5jCisrKyBiL3N5cy9uZXQ4MDIxMS9pZWVlODAy MTFfaHdtcC5jCkBAIC0xMzksOSArMTM5LDEzIEBAIHN0YXRpYyBjb25zdCB1aW50OF90CWJyb2Fk Y2FzdGFkZHJbSUVFRTgwMjExX0FERFJfTEVOXSA9CiB0eXBlZGVmIHVpbnQzMl90IGllZWU4MDIx MV9od21wX3NlcTsKICNkZWZpbmUJSFdNUF9TRVFfTFQoYSwgYikJKChpbnQzMl90KSgoYSktKGIp KSA8IDApCiAjZGVmaW5lCUhXTVBfU0VRX0xFUShhLCBiKQkoKGludDMyX3QpKChhKS0oYikpIDw9 IDApCisjZGVmaW5lCUhXTVBfU0VRX0VRKGEsIGIpCSgoaW50MzJfdCkoKGEpLShiKSkgPT0gMCkK ICNkZWZpbmUJSFdNUF9TRVFfR1QoYSwgYikJKChpbnQzMl90KSgoYSktKGIpKSA+IDApCiAjZGVm aW5lCUhXTVBfU0VRX0dFUShhLCBiKQkoKGludDMyX3QpKChhKS0oYikpID49IDApCiAKKy8qIFRo ZSBsb25nZXIgb25lIG9mIHRoZSBsaWZldGltZSBzaG91bGQgYmUgc3RvcmVkIGFzIG5ldyBsaWZl dGltZSAqLworI2RlZmluZSBNRVNIX1JPVVRFX0xJRkVUSU1FX01BWChhLCBiKQkoYSA+IGIgPyBh IDogYikKKwogLyoKICAqIFByaXZhdGUgZXh0ZW5zaW9uIG9mIGllZWU4MDIxMV9tZXNoX3JvdXRl LgogICovCkBAIC02NzYsOCArNjgwLDEwIEBAIGh3bXBfcmVjdl9wcmVxKHN0cnVjdCBpZWVlODAy MTF2YXAgKnZhcCwgc3RydWN0IGllZWU4MDIxMV9ub2RlICpuaSwKIHsKIAlzdHJ1Y3QgaWVlZTgw MjExX21lc2hfc3RhdGUgKm1zID0gdmFwLT5pdl9tZXNoOwogCXN0cnVjdCBpZWVlODAyMTFfbWVz aF9yb3V0ZSAqcnQgPSBOVUxMOwotCXN0cnVjdCBpZWVlODAyMTFfbWVzaF9yb3V0ZSAqcnRvcmln ID0gTlVMTDsKLQlzdHJ1Y3QgaWVlZTgwMjExX2h3bXBfcm91dGUgKmhyb3JpZzsKKwlzdHJ1Y3Qg aWVlZTgwMjExX21lc2hfcm91dGUgKnJ0b3JpZyA9IE5VTEw7IC8vIE9yaWdpbmF0b3Igcm91dGUK KwlzdHJ1Y3QgaWVlZTgwMjExX21lc2hfcm91dGUgKnJ0dGFyZyA9IE5VTEw7IC8vIFRhcmdldCBy b3V0ZQorCXN0cnVjdCBpZWVlODAyMTFfaHdtcF9yb3V0ZSAqaHJvcmlnID0gTlVMTDsKKwlzdHJ1 Y3QgaWVlZTgwMjExX2h3bXBfcm91dGUgKmhydGFyZyA9IE5VTEw7CiAJc3RydWN0IGllZWU4MDIx MV9od21wX3N0YXRlICpocyA9IHZhcC0+aXZfaHdtcDsKIAlzdHJ1Y3QgaWVlZTgwMjExX21lc2hw cmVwX2llIHByZXA7CiAKQEAgLTY5Miw0NiArNjk4LDgzIEBAIGh3bXBfcmVjdl9wcmVxKHN0cnVj dCBpZWVlODAyMTF2YXAgKnZhcCwgc3RydWN0IGllZWU4MDIxMV9ub2RlICpuaSwKIAkJcmV0dXJu OwogCiAJSUVFRTgwMjExX05PVEUodmFwLCBJRUVFODAyMTFfTVNHX0hXTVAsIG5pLAotCSAgICAi cmVjZWl2ZWQgUFJFUSwgc291cmNlICVzIiwgZXRoZXJfc3ByaW50ZihwcmVxLT5wcmVxX29yaWdh ZGRyKSk7CisJICAgICJyZWNlaXZlZCBQUkVRLCBvcmlnaW5hdG9yICVzLCB0YXJnZXQgJXMiLCBl dGhlcl9zcHJpbnRmKHByZXEtPnByZXFfb3JpZ2FkZHIpLCBldGhlcl9zcHJpbnRmKFBSRVFfVEFE RFIoMCkpKTsKIAogCS8qCi0JICogQWNjZXB0YW5jZSBjcml0ZXJpYTogaWYgdGhlIFBSRVEgaXMg bm90IGZvciB1cyBhbmQKLQkgKiBmb3J3YXJkaW5nIGlzIGRpc2FibGVkLCBkaXNjYXJkIHRoaXMg UFJFUS4KKwkgKiBBY2NlcHRhbmNlIGNyaXRlcmlhOiBpZiB0aGUgUFJFUSBpcyBub3QgZm9yIHVz IG9yIG5vdCBicm9hZGNhc3QKKwkgKiBBTkQgZm9yd2FyZGluZyBpcyBkaXNhYmxlZCwgZGlzY2Fy ZCB0aGlzIFBSRVEuCiAJICovCi0JaWYgKCFJRUVFODAyMTFfQUREUl9FUSh2YXAtPml2X215YWRk ciwgUFJFUV9UQUREUigwKSkgJiYKKwlpZiAoKCFJRUVFODAyMTFfQUREUl9FUSh2YXAtPml2X215 YWRkciwgUFJFUV9UQUREUigwKSkgfHwgLyogbmVlZCB0byBjaGVjayBQUk9YWSAqLworCQkhSUVF RTgwMjExX0lTX01VTFRJQ0FTVChQUkVRX1RBRERSKDApKSkgJiYKIAkgICAgIShtcy0+bXNfZmxh Z3MgJiBJRUVFODAyMTFfTUVTSEZMQUdTX0ZXRCkpIHsKIAkJSUVFRTgwMjExX0RJU0NBUkRfTUFD KHZhcCwgSUVFRTgwMjExX01TR19IV01QLAogCQkgICAgcHJlcS0+cHJlcV9vcmlnYWRkciwgTlVM TCwgIiVzIiwgIm5vdCBhY2NlcHRpbmcgUFJFUSIpOwogCQlyZXR1cm47CiAJfQorCS8qCisJICog QWNjZXB0YW5jZSBjcml0ZXJpYTogaWYgdW5pY2FzdCBhZGRyZXNzZWQgCisJICogQU5EIG5vIHZh bGlkIGZvcndhcmRpbmcgZm9yIFRhcmdldCBvZiBQUkVRLCBkaXNjYXJkIHRoaXMgUFJFUS4KKwkg Ki8KKwlydHRhcmcgPSBpZWVlODAyMTFfbWVzaF9ydF9maW5kKHZhcCwgUFJFUV9UQUREUigwKSk7 CisJaWYocnR0YXJnICE9IE5VTEwpCisJCWhydGFyZyA9IElFRUU4MDIxMV9NRVNIX1JPVVRFX1BS SVYocnR0YXJnLCBzdHJ1Y3QgaWVlZTgwMjExX2h3bXBfcm91dGUpOworCWlmKChwcmVxLT5wcmVx X2ZsYWdzICYgSUVFRTgwMjExX01FU0hQUkVRX0ZMQUdTX0FNKSA9PSAwICYmIC8qIGFkZHJlc3Mg bW9kZTogdWNhc3QgKi8KKwkJcnR0YXJnID09IE5VTEwgJiYKKwkJIUlFRUU4MDIxMV9BRERSX0VR KHZhcC0+aXZfbXlhZGRyLCBQUkVRX1RBRERSKDApKSkgeworCQlJRUVFODAyMTFfRElTQ0FSRF9N QUModmFwLCBJRUVFODAyMTFfTVNHX0hXTVAsCisJCSAgICBwcmVxLT5wcmVxX29yaWdhZGRyLCBO VUxMLCAidW5pY2FzdCBhZGRyZXNzZWQgUFJFUSBvZiB1bmtub3duIHRhcmdldCAlcyIsCisJCQkJ ICAgICAgZXRoZXJfc3ByaW50ZihQUkVRX1RBRERSKDApKSk7CisJCXJldHVybjsKKwl9CisJCisJ LyogUFJFUSBBQ0NFUFRFRCAqLworCiAJcnRvcmlnID0gaWVlZTgwMjExX21lc2hfcnRfZmluZCh2 YXAsIHByZXEtPnByZXFfb3JpZ2FkZHIpOwotCWlmIChydG9yaWcgPT0gTlVMTCkKKwlpZiAocnRv cmlnID09IE5VTEwpewogCQlydG9yaWcgPSBpZWVlODAyMTFfbWVzaF9ydF9hZGQodmFwLCBwcmVx LT5wcmVxX29yaWdhZGRyKTsKKwkJSUVFRTgwMjExX05PVEUodmFwLCBJRUVFODAyMTFfTVNHX0hX TVAsIG5pLAorCQkJImFkZGluZyBvcmlnaW5hdG9yICVzIiwgZXRoZXJfc3ByaW50ZihwcmVxLT5w cmVxX29yaWdhZGRyKSk7CisJfQogCWlmIChydG9yaWcgPT0gTlVMTCkgewogCQkvKiBYWFggc3Rh dCAqLwogCQlyZXR1cm47CiAJfQogCWhyb3JpZyA9IElFRUU4MDIxMV9NRVNIX1JPVVRFX1BSSVYo cnRvcmlnLCBzdHJ1Y3QgaWVlZTgwMjExX2h3bXBfcm91dGUpOwotCS8qCi0JICogU2VxdWVuY2Ug bnVtYmVyIHZhbGlkYXRpb24uCisKKwkvKiBEYXRhIGNyZWF0aW9uIGFuZCB1cGRhdGUgb2YgZm9y d2FyZGluZyBpbmZvcm1hdGlvbgorCSAqIGFjY29yZGluZyB0byBUYWJsZSAxMUMtOCBmb3Igb3Jp Z2luYXRvciBtZXNoIFNUQS4KIAkgKi8KLQlpZiAoSFdNUF9TRVFfTEVRKHByZXEtPnByZXFfaWQs IGhyb3JpZy0+aHJfcHJlcWlkKSAmJgotCSAgICBIV01QX1NFUV9MRVEocHJlcS0+cHJlcV9vcmln c2VxLCBocm9yaWctPmhyX3NlcSkpIHsKKwlpZihIV01QX1NFUV9HVChwcmVxLT5wcmVxX29yaWdz ZXEsIGhyb3JpZy0+aHJfc2VxKSB8fAorCQkoSFdNUF9TRVFfRVEocHJlcS0+cHJlcV9vcmlnc2Vx LCBocm9yaWctPmhyX3NlcSkgJiYgcHJlcS0+cHJlcV9tZXRyaWMgPCBydG9yaWctPnJ0X21ldHJp YykpeworCQlocm9yaWctPmhyX3NlcSA9IHByZXEtPnByZXFfb3JpZ3NlcTsKKwkJSUVFRTgwMjEx X0FERFJfQ09QWShydG9yaWctPnJ0X25leHRob3AsIHdoLT5pX2FkZHIyKTsKKwkJcnRvcmlnLT5y dF9tZXRyaWMgPSBwcmVxLT5wcmVxX21ldHJpYyArCisJCQltcy0+bXNfcG1ldHJpYy0+bXBtX21l dHJpYyhuaSk7CisJCXJ0b3JpZy0+cnRfbmhvcHMgID0gcHJlcS0+cHJlcV9ob3Bjb3VudCArIDE7 CisJCXJ0b3JpZy0+cnRfbGlmZXRpbWUgID0gTUVTSF9ST1VURV9MSUZFVElNRV9NQVgocHJlcS0+ cHJlcV9saWZldGltZSwgcnRvcmlnLT5ydF9saWZldGltZSk7CisJCXJ0b3JpZy0+cnRfZmxhZ3Mg fD0gSUVFRTgwMjExX01FU0hSVF9GTEFHU19WQUxJRDsgLyogcGF0aCB0byBvcmlnIGlzIHZhbGlk IG5vdyAqLworCX1lbHNlIGlmKGhydGFyZyAhPSBOVUxMICYmIAorCQlIV01QX1NFUV9FUShocnRh cmctPmhyX3NlcSwgUFJFUV9UU0VRKDApKSAmJgorCQkocnRvcmlnLT5ydF9mbGFncyAmIElFRUU4 MDIxMV9NRVNIUlRfRkxBR1NfVkFMSUQpID09IDApewogCQlJRUVFODAyMTFfTk9URSh2YXAsIElF RUU4MDIxMV9NU0dfSFdNUCwgbmksCi0JCSAgICAiZGlzY2FyZCBQUkVRIGZyb20gJXMsIG9sZCBz ZXEgbm8gJXUgPD0gJXUiLAotCQkgICAgZXRoZXJfc3ByaW50ZihwcmVxLT5wcmVxX29yaWdhZGRy KSwKLQkJICAgIHByZXEtPnByZXFfb3JpZ3NlcSwgaHJvcmlnLT5ocl9zZXEpOworCQkJInJlY2Vp dmVkIFBSRVEsIG9yaWdpbmF0b3IgJXMiLCAidW5rbm93biIpOworCX1lbHNleworCQlJRUVFODAy MTFfRElTQ0FSRF9NQUModmFwLCBJRUVFODAyMTFfTVNHX0hXTVAsCisJCSAgICBwcmVxLT5wcmVx X29yaWdhZGRyLCBOVUxMLCAiJXMsIGxhc3Qgc2VlbiBvcmlnLnNlcSAlZCwgcHJlcSBvcmlnLnNl cSAlZCIsICJkaXNjYXJkaW5nIFBSRVEiLCBocm9yaWctPmhyX3NlcSwgcHJlcS0+cHJlcV9vcmln c2VxKTsKIAkJcmV0dXJuOwogCX0KLQlocm9yaWctPmhyX3ByZXFpZCA9IHByZXEtPnByZXFfaWQ7 Ci0JaHJvcmlnLT5ocl9zZXEgPSBwcmVxLT5wcmVxX29yaWdzZXE7CisJCisJLyogCisJICogRm9y d2FyZGluZyBpbmZvcm1hdGlvbiBmb3IgdHJhbnNtaXR0ZXIgbWVzaCBTVEEgCisJICogW09QVElP TkFMOiBpZiBtZXRyaWMgaW1wcm92ZWRdCisJICovCiAKIAkvKgogCSAqIENoZWNrIGlmIHRoZSBQ UkVRIGlzIGFkZHJlc3NlZCB0byB1cy4KIAkgKi8KIAlpZiAoSUVFRTgwMjExX0FERFJfRVEodmFw LT5pdl9teWFkZHIsIFBSRVFfVEFERFIoMCkpKSB7CiAJCUlFRUU4MDIxMV9OT1RFKHZhcCwgSUVF RTgwMjExX01TR19IV01QLCBuaSwKLQkJICAgICJyZXBseSB0byAlcyIsIGV0aGVyX3NwcmludGYo cHJlcS0+cHJlcV9vcmlnYWRkcikpOworCQkgICAgInJlcGx5IFBSRVAsIG9yaWdpbmF0b3IgJXMi LCBldGhlcl9zcHJpbnRmKHByZXEtPnByZXFfb3JpZ2FkZHIpKTsKIAkJLyoKIAkJICogQnVpbGQg YW5kIHNlbmQgYSBQUkVQIGZyYW1lLgogCQkgKi8KQEAgLTgxOSwxMSArODYyLDEzIEBAIGh3bXBf cmVjdl9wcmVxKHN0cnVjdCBpZWVlODAyMTF2YXAgKnZhcCwgc3RydWN0IGllZWU4MDIxMV9ub2Rl ICpuaSwKIAkJCWlmIChwcmVxLT5wcmVxX3R0bCA+IDEgJiYKIAkJCSAgICBwcmVxLT5wcmVxX2hv cGNvdW50IDwgaHMtPmhzX21heGhvcHMpIHsKIAkJCQlJRUVFODAyMTFfTk9URSh2YXAsIElFRUU4 MDIxMV9NU0dfSFdNUCwgbmksCi0JCQkJICAgICJmb3J3YXJkIFBSRVEgZnJvbSAlcyIsCi0JCQkJ ICAgIGV0aGVyX3NwcmludGYocHJlcS0+cHJlcV9vcmlnYWRkcikpOworCQkJCSAgICAiZm9yd2Fy ZCBQUkVRLCBvcmlnaW5hdG9yICVzLCB0byAlcyIsCisJCQkJICAgIGV0aGVyX3NwcmludGYocHJl cS0+cHJlcV9vcmlnYWRkciksIGV0aGVyX3NwcmludGYocnQtPnJ0X25leHRob3ApKTsKIAkJCQkv KgogCQkJCSAqIFByb3BhZ2F0ZSB0aGUgb3JpZ2luYWwgUFJFUS4KKwkJCQkgKiBQUkVRIGlzIHVu aWNhc3Qgbm93IHRvIHJ0LT5ydF9uZXh0aG9wCiAJCQkJICovCisJCQkJcHByZXEucHJlcV9mbGFn cyAmPSB+SUVFRTgwMjExX01FU0hQUkVRX0ZMQUdTX0FNOwogCQkJCXBwcmVxLnByZXFfaG9wY291 bnQgKz0gMTsKIAkJCQlwcHJlcS5wcmVxX3R0bCAtPSAxOwogCQkJCXBwcmVxLnByZXFfbWV0cmlj ICs9CkBAIC04MzcsNyArODgyLDcgQEAgaHdtcF9yZWN2X3ByZXEoc3RydWN0IGllZWU4MDIxMXZh cCAqdmFwLCBzdHJ1Y3QgaWVlZTgwMjExX25vZGUgKm5pLAogCQkJCXBwcmVxLnByZXFfdGFyZ2V0 c1swXS50YXJnZXRfZmxhZ3MgJj0KIAkJCQkgICAgfklFRUU4MDIxMV9NRVNIUFJFUV9URkxBR1Nf UkY7CiAJCQkJaHdtcF9zZW5kX3ByZXEobmksIHZhcC0+aXZfbXlhZGRyLAotCQkJCSAgICBicm9h ZGNhc3RhZGRyLCAmcHByZXEpOworCQkJCSAgICBydC0+cnRfbmV4dGhvcCwgJnBwcmVxKTsKIAkJ CX0KIAkJCS8qCiAJCQkgKiBDaGVjayBpZiB3ZSBjYW4gc2VuZCBhbiBpbnRlcm1lZGlhdGUgUGF0 aCBSZXBseSwKQEAgLTg3MCwyNiArOTE1LDExIEBAIGh3bXBfcmVjdl9wcmVxKHN0cnVjdCBpZWVl ODAyMTF2YXAgKnZhcCwgc3RydWN0IGllZWU4MDIxMV9ub2RlICpuaSwKIAkJICovCiAJCX0gZWxz ZSBpZiAocHJlcS0+cHJlcV90dGwgPiAxICYmCiAJCSAgICBwcmVxLT5wcmVxX2hvcGNvdW50IDwg aHMtPmhzX21heGhvcHMpIHsKLQkJCWlmIChydCA9PSBOVUxMKSB7Ci0JCQkJcnQgPSBpZWVlODAy MTFfbWVzaF9ydF9hZGQodmFwLCBQUkVRX1RBRERSKDApKTsKLQkJCQlpZiAocnQgPT0gTlVMTCkg ewotCQkJCQlJRUVFODAyMTFfTk9URSh2YXAsIElFRUU4MDIxMV9NU0dfSFdNUCwKLQkJCQkJICAg IG5pLCAidW5hYmxlIHRvIGFkZCBQUkVRIHBhdGggdG8gJXMiLAotCQkJCQkgICAgZXRoZXJfc3By aW50ZihQUkVRX1RBRERSKDApKSk7Ci0JCQkJCXZhcC0+aXZfc3RhdHMuaXNfbWVzaF9ydGFkZGZh aWxlZCsrOwotCQkJCQlyZXR1cm47Ci0JCQkJfQotCQkJfQotCQkJcnQtPnJ0X21ldHJpYyA9IHBy ZXEtPnByZXFfbWV0cmljOwotCQkJcnQtPnJ0X2xpZmV0aW1lID0gcHJlcS0+cHJlcV9saWZldGlt ZTsKLQkJCWhyb3JpZyA9IElFRUU4MDIxMV9NRVNIX1JPVVRFX1BSSVYocnQsCi0JCQkgICAgc3Ry dWN0IGllZWU4MDIxMV9od21wX3JvdXRlKTsKLQkJCWhyb3JpZy0+aHJfc2VxID0gcHJlcS0+cHJl cV9vcmlnc2VxOwotCQkJaHJvcmlnLT5ocl9wcmVxaWQgPSBwcmVxLT5wcmVxX2lkOwotCiAJCQlJ RUVFODAyMTFfTk9URSh2YXAsIElFRUU4MDIxMV9NU0dfSFdNUCwgbmksCi0JCQkgICAgImZvcndh cmQgUFJFUSBmcm9tICVzIiwKLQkJCSAgICBldGhlcl9zcHJpbnRmKHByZXEtPnByZXFfb3JpZ2Fk ZHIpKTsKKwkJCSAgICAiYnJvYWRjYXN0IFBSRVEsIG9yaWdpbmF0b3IgJXMsIHRhcmdldCAlcyIs CisJCQkgICAgZXRoZXJfc3ByaW50ZihwcmVxLT5wcmVxX29yaWdhZGRyKSwKKwkJCQkgICAgICAg ZXRoZXJfc3ByaW50ZihQUkVRX1RBRERSKDApKSk7CisJCQlwcHJlcS5wcmVxX2ZsYWdzIHw9IElF RUU4MDIxMV9NRVNIUFJFUV9GTEFHU19BTTsKIAkJCXBwcmVxLnByZXFfaG9wY291bnQgKz0gMTsK IAkJCXBwcmVxLnByZXFfdHRsIC09IDE7CiAJCQlwcHJlcS5wcmVxX21ldHJpYyArPSBtcy0+bXNf cG1ldHJpYy0+bXBtX21ldHJpYyhuaSk7CkBAIC05NTYsMTIgKzk4NiwxNCBAQCBod21wX3JlY3Zf cHJlcChzdHJ1Y3QgaWVlZTgwMjExdmFwICp2YXAsIHN0cnVjdCBpZWVlODAyMTFfbm9kZSAqbmks CiAJCXJldHVybjsKIAogCUlFRUU4MDIxMV9OT1RFKHZhcCwgSUVFRTgwMjExX01TR19IV01QLCBu aSwKLQkgICAgInJlY2VpdmVkIFBSRVAgZnJvbSAlcyIsIGV0aGVyX3NwcmludGYocHJlcC0+cHJl cF90YXJnZXRhZGRyKSk7CisJICAgICJyZWNlaXZlZCBQUkVQLCBvcmlnaW5hdG9yICVzLCB0YXJn ZXQgJXMiLCBldGhlcl9zcHJpbnRmKHByZXAtPnByZXBfb3JpZ2FkZHIpLCBldGhlcl9zcHJpbnRm KHByZXAtPnByZXBfdGFyZ2V0YWRkcikpOwogCiAJcnQgPSBpZWVlODAyMTFfbWVzaF9ydF9maW5k KHZhcCwgcHJlcC0+cHJlcF90YXJnZXRhZGRyKTsKIAlpZiAocnQgPT0gTlVMTCkgewogCQkvKgot CQkgKiBJZiB3ZSBoYXZlIG5vIGVudHJ5IHRoaXMgY291bGQgYmUgYSByZXBseSB0byBhIHJvb3Qg UFJFUS4KKwkJICogSWYgd2UgaGF2ZSBubyBlbnRyeSB0aGlzIGNvdWxkIGJlIGEgcmVwbHkgdG8g YSByb290IFBSRVEuIAorCQkgKiBYWFg6IG5vdCB0cnVlIGFueW1vcmUgY2F1c2Ugd2UgZG9udCBj cmVhdGUgZW50cnkgZm9yIHRhcmdldCB3aGVuCisJCSAqIHByb3BhZ2F0aW5nIFBSRVFzIGxpa2Ug dGhlIG9sZCBjb2RlIGRpZC4KIAkJICovCiAJCWlmIChocy0+aHNfcm9vdG1vZGUgIT0gSUVFRTgw MjExX0hXTVBfUk9PVE1PREVfRElTQUJMRUQpIHsKIAkJCXJ0ID0gaWVlZTgwMjExX21lc2hfcnRf YWRkKHZhcCwgcHJlcC0+cHJlcF90YXJnZXRhZGRyKTsKQEAgLTk4OSwxMyArMTAyMSwyMyBAQCBo d21wX3JlY3ZfcHJlcChzdHJ1Y3QgaWVlZTgwMjExdmFwICp2YXAsIHN0cnVjdCBpZWVlODAyMTFf bm9kZSAqbmksCiAJICogU2VxdWVuY2UgbnVtYmVyIHZhbGlkYXRpb24uCiAJICovCiAJaHIgPSBJ RUVFODAyMTFfTUVTSF9ST1VURV9QUklWKHJ0LCBzdHJ1Y3QgaWVlZTgwMjExX2h3bXBfcm91dGUp OwotCWlmIChIV01QX1NFUV9MRVEocHJlcC0+cHJlcF90YXJnZXRzZXEsIGhyLT5ocl9zZXEpKSB7 CisJaWYoKHJ0LT5ydF9mbGFncyAmIElFRUU4MDIxMV9NRVNIUlRfRkxBR1NfVkFMSUQpKXsgLy8g QWNjZXB0IGlmIHJvdXRlIGlzIG5vdCB2YWxpZAorCSAgaWYgKEhXTVBfU0VRX0xUKHByZXAtPnBy ZXBfdGFyZ2V0c2VxLCBoci0+aHJfc2VxKSkgewogCQlJRUVFODAyMTFfTk9URSh2YXAsIElFRUU4 MDIxMV9NU0dfSFdNUCwgbmksCi0JCSAgICAiZGlzY2FyZCBQUkVQIGZyb20gJXMsIG9sZCBzZXEg bm8gJXUgPD0gJXUiLAorCQkgICAgImRpc2NhcmQgUFJFUCBmcm9tICVzLCBvbGQgc2VxIG5vICV1 IDwgJXUiLAogCQkgICAgZXRoZXJfc3ByaW50ZihwcmVwLT5wcmVwX3RhcmdldGFkZHIpLAogCQkg ICAgcHJlcC0+cHJlcF90YXJnZXRzZXEsIGhyLT5ocl9zZXEpOwogCQlyZXR1cm47CisJICB9ZWxz ZSBpZihIV01QX1NFUV9MRVEocHJlcC0+cHJlcF90YXJnZXRzZXEsIGhyLT5ocl9zZXEpICYmIC8v SWYgc2FtZSBzZXFubyBjb21wYXJlIG1ldHJpYworCQlwcmVwLT5wcmVwX21ldHJpYyA+IHJ0LT5y dF9tZXRyaWMpIHsKKwkJSUVFRTgwMjExX05PVEUodmFwLCBJRUVFODAyMTFfTVNHX0hXTVAsIG5p LAorCQkgICAgImRpc2NhcmQgUFJFUCBmcm9tICVzLCBuZXcgbWV0cmljICV1ID4gJXUiLAorCQkg ICAgZXRoZXJfc3ByaW50ZihwcmVwLT5wcmVwX3RhcmdldGFkZHIpLAorCQkgICAgcHJlcC0+cHJl cF9tZXRyaWMsIHJ0LT5ydF9tZXRyaWMpOworCQlyZXR1cm47CisJICB9CiAJfQorCQogCWhyLT5o cl9zZXEgPSBwcmVwLT5wcmVwX3RhcmdldHNlcTsKIAkvKgogCSAqIElmIGl0J3MgTk9UIGZvciB1 cywgcHJvcGFnYXRlIHRoZSBQUkVQLgpAQCAtMTAxMiw3ICsxMDU0LDYgQEAgaHdtcF9yZWN2X3By ZXAoc3RydWN0IGllZWU4MDIxMXZhcCAqdmFwLCBzdHJ1Y3QgaWVlZTgwMjExX25vZGUgKm5pLAog CQlwcHJlcC5wcmVwX2hvcGNvdW50ICs9IDE7CiAJCXBwcmVwLnByZXBfdHRsIC09IDE7CiAJCXBw cmVwLnByZXBfbWV0cmljICs9IG1zLT5tc19wbWV0cmljLT5tcG1fbWV0cmljKG5pKTsKLQkJSUVF RTgwMjExX0FERFJfQ09QWShwcHJlcC5wcmVwX3RhcmdldGFkZHIsIHZhcC0+aXZfbXlhZGRyKTsK IAkJaHdtcF9zZW5kX3ByZXAobmksIHZhcC0+aXZfbXlhZGRyLCBicm9hZGNhc3RhZGRyLCAmcHBy ZXApOwogCX0KIAlociA9IElFRUU4MDIxMV9NRVNIX1JPVVRFX1BSSVYocnQsIHN0cnVjdCBpZWVl ODAyMTFfaHdtcF9yb3V0ZSk7CkBAIC0xMDIyLDcgKzEwNjMsNyBAQCBod21wX3JlY3ZfcHJlcChz dHJ1Y3QgaWVlZTgwMjExdmFwICp2YXAsIHN0cnVjdCBpZWVlODAyMTFfbm9kZSAqbmksCiAJCSAg ICAiZGlzY2FyZCBQUkVQIGZvciAlcywgcm91dGUgaXMgbWFya2VkIFBST1hZIiwKIAkJICAgIGV0 aGVyX3NwcmludGYocHJlcC0+cHJlcF90YXJnZXRhZGRyKSk7CiAJCXZhcC0+aXZfc3RhdHMuaXNf aHdtcF9wcm94eSsrOwotCX0gZWxzZSBpZiAocHJlcC0+cHJlcF9vcmlnc2VxID09IGhyLT5ocl9v cmlnc2VxKSB7CisJfSBlbHNlIGlmIChoci0+aHJfb3JpZ3NlcSA9PSAwIHx8IHByZXAtPnByZXBf b3JpZ3NlcSA9PSBoci0+aHJfb3JpZ3NlcSkgeyAvL2ZpcnN0IHBhdGggZGlzY292ZXJ5IGFsd2F5 cyBmYWlsIQogCQkvKgogCQkgKiBDaGVjayBpZiB3ZSBhbHJlYWR5IGhhdmUgYSBwYXRoIHRvIHRo aXMgbm9kZS4KIAkJICogSWYgd2UgZG8sIGNoZWNrIGlmIHRoaXMgcGF0aCByZXBseSBjb250YWlu cyBhCkBAIC0xMDMxLDE1ICsxMDcyLDE2IEBAIGh3bXBfcmVjdl9wcmVwKHN0cnVjdCBpZWVlODAy MTF2YXAgKnZhcCwgc3RydWN0IGllZWU4MDIxMV9ub2RlICpuaSwKIAkJaWYgKChydC0+cnRfZmxh Z3MgJiBJRUVFODAyMTFfTUVTSFJUX0ZMQUdTX1ZBTElEKSA9PSAwIHx8CiAJCSAgICAocHJlcC0+ cHJlcF9ob3Bjb3VudCA8IHJ0LT5ydF9uaG9wcyB8fAogCQkgICAgIHByZXAtPnByZXBfbWV0cmlj IDwgcnQtPnJ0X21ldHJpYykpIHsKKwkJCWhyLT5ocl9vcmlnc2VxID0gcHJlcC0+cHJlcF9vcmln c2VxOwogCQkJSUVFRTgwMjExX05PVEUodmFwLCBJRUVFODAyMTFfTVNHX0hXTVAsIG5pLAogCQkJ ICAgICIlcyBwYXRoIHRvICVzLCBob3Bjb3VudCAlZDolZCBtZXRyaWMgJWQ6JWQiLAogCQkJICAg IHJ0LT5ydF9mbGFncyAmIElFRUU4MDIxMV9NRVNIUlRfRkxBR1NfVkFMSUQgPwogCQkJCSJwcmVm ZXIiIDogInVwZGF0ZSIsCi0JCQkgICAgZXRoZXJfc3ByaW50ZihwcmVwLT5wcmVwX29yaWdhZGRy KSwKLQkJCSAgICBydC0+cnRfbmhvcHMsIHByZXAtPnByZXBfaG9wY291bnQsCisJCQkgICAgZXRo ZXJfc3ByaW50ZihwcmVwLT5wcmVwX3RhcmdldGFkZHIpLAorCQkJICAgIHJ0LT5ydF9uaG9wcywg cHJlcC0+cHJlcF9ob3Bjb3VudCArIDEsCiAJCQkgICAgcnQtPnJ0X21ldHJpYywgcHJlcC0+cHJl cF9tZXRyaWMpOwogCQkJSUVFRTgwMjExX0FERFJfQ09QWShydC0+cnRfbmV4dGhvcCwgd2gtPmlf YWRkcjIpOwotCQkJcnQtPnJ0X25ob3BzID0gcHJlcC0+cHJlcF9ob3Bjb3VudDsKKwkJCXJ0LT5y dF9uaG9wcyA9IHByZXAtPnByZXBfaG9wY291bnQgKyAxOwogCQkJcnQtPnJ0X2xpZmV0aW1lID0g cHJlcC0+cHJlcF9saWZldGltZTsKIAkJCXJ0LT5ydF9tZXRyaWMgPSBwcmVwLT5wcmVwX21ldHJp YzsKIAkJCXJ0LT5ydF9mbGFncyB8PSBJRUVFODAyMTFfTUVTSFJUX0ZMQUdTX1ZBTElEOwpAQCAt MTA1Miw5ICsxMDk0LDkgQEAgaHdtcF9yZWN2X3ByZXAoc3RydWN0IGllZWU4MDIxMXZhcCAqdmFw LCBzdHJ1Y3QgaWVlZTgwMjExX25vZGUgKm5pLAogCQl9CiAJfSBlbHNlIHsKIAkJSUVFRTgwMjEx X05PVEUodmFwLCBJRUVFODAyMTFfTVNHX0hXTVAsIG5pLAotCQkgICAgImRpc2NhcmQgUFJFUCBm b3IgJXMsIHdyb25nIHNlcW5vICV1ICE9ICV1IiwKKwkJICAgICJkaXNjYXJkIFBSRVAgZm9yICVz LCB3cm9uZyBvcmlnIHNlcW5vICV1ICE9ICV1IiwKIAkJICAgIGV0aGVyX3NwcmludGYocHJlcC0+ cHJlcF90YXJnZXRhZGRyKSwgcHJlcC0+cHJlcF9vcmlnc2VxLAotCQkgICAgaHItPmhyX3NlcSk7 CisJCSAgICBoci0+aHJfb3JpZ3NlcSk7CiAJCXZhcC0+aXZfc3RhdHMuaXNfaHdtcF93cm9uZ3Nl cSsrOwogCX0gCiAJLyoKQEAgLTEzMjMsMTMgKzEzNjUsMTMgQEAgaHdtcF9kaXNjb3ZlcihzdHJ1 Y3QgaWVlZTgwMjExdmFwICp2YXAsCiAJCQkvKiBYWFggY2hlY2sgcHJlcSByZXRyaWVzICovCiAJ CQlzZW5kcHJlcSA9IDE7CiAJCQlJRUVFODAyMTFfTk9URV9NQUModmFwLCBJRUVFODAyMTFfTVNH X0hXTVAsIGRlc3QsCi0JCQkgICAgInN0YXJ0IHBhdGggZGlzY292ZXJ5IChzcmMgJXMpIiwKKwkJ CSAgICAic3RhcnQgcGF0aCBkaXNjb3ZlcnkgKHNyYyAlcyksIHRhcmdldCBzZXEgJXUiLAogCQkJ ICAgIG0gPT0gTlVMTCA/ICI8bm9uZT4iIDogZXRoZXJfc3ByaW50ZigKLQkJCQltdG9kKG0sIHN0 cnVjdCBldGhlcl9oZWFkZXIgKiktPmV0aGVyX3Nob3N0KSk7CisJCQkJbXRvZChtLCBzdHJ1Y3Qg ZXRoZXJfaGVhZGVyICopLT5ldGhlcl9zaG9zdCksIGhyLT5ocl9zZXEpOwogCQkJLyoKIAkJCSAq IFRyeSB0byBkaXNjb3ZlciB0aGUgcGF0aCBmb3IgdGhpcyBub2RlLgogCQkJICovCi0JCQlwcmVx LnByZXFfZmxhZ3MgPSAwOworCQkJcHJlcS5wcmVxX2ZsYWdzID0gSUVFRTgwMjExX01FU0hQUkVR X0ZMQUdTX0FNOyAvKiBHcm91cCBhZGRyZXNzZWQgUFJFUSBDYXNlIEEgKi8KIAkJCXByZXEucHJl cV9ob3Bjb3VudCA9IDA7CiAJCQlwcmVxLnByZXFfdHRsID0gbXMtPm1zX3R0bDsKIAkJCXByZXEu cHJlcV9pZCA9ICsraHMtPmhzX3ByZXFpZDsKQEAgLTEzNDUsNyArMTM4Nyw3IEBAIGh3bXBfZGlz Y292ZXIoc3RydWN0IGllZWU4MDIxMXZhcCAqdmFwLAogCQkJaWYgKGllZWU4MDIxMV9od21wX3Jl cGx5Zm9yd2FyZCkKIAkJCQlQUkVRX1RGTEFHUygwKSB8PSBJRUVFODAyMTFfTUVTSFBSRVFfVEZM QUdTX1JGOwogCQkJUFJFUV9URkxBR1MoMCkgfD0gSUVFRTgwMjExX01FU0hQUkVRX1RGTEFHU19V U047Ci0JCQlQUkVRX1RTRVEoMCkgPSAwOworCQkJUFJFUV9UU0VRKDApID0gaHItPmhyX3NlcTsK IAkJCS8qIFhYWCBjaGVjayByZXR1cm4gdmFsdWUgKi8KIAkJCWh3bXBfc2VuZF9wcmVxKHZhcC0+ aXZfYnNzLCB2YXAtPml2X215YWRkciwKIAkJCSAgICBicm9hZGNhc3RhZGRyLCAmcHJlcSk7Cg== --14dae9340cc7f5f09404b6393c41-- From owner-freebsd-wireless@FreeBSD.ORG Wed Jan 11 17:23:31 2012 Return-Path: Delivered-To: freebsd-wireless@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 88F8A1065673 for ; Wed, 11 Jan 2012 17:23:31 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Received: from mail-gx0-f182.google.com (mail-gx0-f182.google.com [209.85.161.182]) by mx1.freebsd.org (Postfix) with ESMTP id 4A1008FC16 for ; Wed, 11 Jan 2012 17:23:31 +0000 (UTC) Received: by ggki1 with SMTP id i1so597931ggk.13 for ; Wed, 11 Jan 2012 09:23:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type; bh=y8bxYezx0nx0eSsU20b+WABRgUBjPfi7IBdDcuQzMOM=; b=ObDFUrHGL6RYhW9Qbp6RKXfPkwW6P2YzhpLd0eyb2nAxDFdjFn4sTwOdKaUWCdxYqO MOKCUQj+ULN+Gkx8KLhtPSJjZmjDgkuPhUZkmFKGqkapGZsEXVVClgvxlVYz5W1m/bxI yXDq5GQrzORpM+n1A+3M4TEvhX1uYz66CjA2Q= MIME-Version: 1.0 Received: by 10.50.236.67 with SMTP id us3mr7638717igc.14.1326302609990; Wed, 11 Jan 2012 09:23:29 -0800 (PST) Sender: adrian.chadd@gmail.com Received: by 10.42.243.65 with HTTP; Wed, 11 Jan 2012 09:23:29 -0800 (PST) In-Reply-To: References: Date: Wed, 11 Jan 2012 09:23:29 -0800 X-Google-Sender-Auth: LRDicUr4Ng9R1LlmrY0NrtPnlfA Message-ID: From: Adrian Chadd To: Monthadar Al Jaberi Content-Type: text/plain; charset=ISO-8859-1 Cc: freebsd-wireless@freebsd.org Subject: Re: 11s mesh path setup problem X-BeenThere: freebsd-wireless@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussions of 802.11 stack, tools device driver development." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 11 Jan 2012 17:23:31 -0000 Hi! I've just done a bit of a code review. Here are my comments: * ether_sprintf() can't be implemented the way you've implemented it - it just won't work at all in a multithreaded, concurrent environment. We'll have to find an alternative way. Maybe something like: char * ether_sprintf2(const u_char *ap, char *buf, int len) { .. do things to buf, rather than the static buf. } Then maybe this'd work: char a[32], b[32]; IEEE80211_NOTE(..., ether_sprintf2(addr1, a, 32), ether_sprintf2(addr2, a, 32)); does that make sense? * We shouldn't be using '//' comments in the code? Or are they elsewhere in net80211? * You have a lot of >80 length lines in this code. :) * You have at least one instance where you have an extra space after the end of a line * I think you need to have spaces between braces, ie: +>......if (rtorig == NULL){ Should be: if (rtorig == NULL) { Other than that, I haven't yet sat down to test this out. It may be worthwhile to finally just get the simulator into -HEAD - or at least the device side of things. Adrian From owner-freebsd-wireless@FreeBSD.ORG Wed Jan 11 17:43:49 2012 Return-Path: Delivered-To: freebsd-wireless@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 773691065676 for ; Wed, 11 Jan 2012 17:43:49 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Received: from mail-gx0-f182.google.com (mail-gx0-f182.google.com [209.85.161.182]) by mx1.freebsd.org (Postfix) with ESMTP id 3AA228FC17 for ; Wed, 11 Jan 2012 17:43:48 +0000 (UTC) Received: by ggki1 with SMTP id i1so618859ggk.13 for ; Wed, 11 Jan 2012 09:43:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:date:message-id:subject:from:to:cc:content-type; bh=F1i+/FBDra/0vxGfLWCcgRw8BIiT/Te+CSctwcLvHOA=; b=r88qq1K6oIC3x4cdPMEmdnzMYEsyyZ3s1ZCLW7Rsjl/IvoIkVWQTnc6BXQxFZPtvGS r/elAYgNQnNzQzGK0Y59S5SLWdhCWXGyPkSNCkyUlChuzo722I/E76cPHYDHGhtvQndp bxCIFG6qKevmy1OQyiUMvLa/QzuJbmoZYGAUM= MIME-Version: 1.0 Received: by 10.50.190.196 with SMTP id gs4mr8144541igc.14.1326303828433; Wed, 11 Jan 2012 09:43:48 -0800 (PST) Received: by 10.42.243.65 with HTTP; Wed, 11 Jan 2012 09:43:48 -0800 (PST) Date: Wed, 11 Jan 2012 09:43:48 -0800 Message-ID: From: Adrian Chadd To: Monthadar Al Jaberi Content-Type: text/plain; charset=ISO-8859-1 Cc: freebsd-wireless@freebsd.org Subject: I've committed the 802.11 simulator X-BeenThere: freebsd-wireless@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussions of 802.11 stack, tools device driver development." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 11 Jan 2012 17:43:49 -0000 Hi, I've committed monthadar's wifi simulator to -HEAD. The userland tools aren't there yet but I'll work towards getting those included in the base system. It only builds as a module for now - it doesn't have sys/conf/files entries and the Makefile isn't included in sys/modules/Makefile. I'll chase these up in subsequent commits. Monthadar - I had to do a couple of modifications in order to make it compile on -HEAD with no warnings. Otherwise, it's basically a copy of 'src' in your git tree. Please send diffs to what's in -HEAD. :-) Adrian From owner-freebsd-wireless@FreeBSD.ORG Wed Jan 11 17:52:26 2012 Return-Path: Delivered-To: freebsd-wireless@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id ACDC11065672 for ; Wed, 11 Jan 2012 17:52:26 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Received: from mail-iy0-f182.google.com (mail-iy0-f182.google.com [209.85.210.182]) by mx1.freebsd.org (Postfix) with ESMTP id 7ACEC8FC1D for ; Wed, 11 Jan 2012 17:52:26 +0000 (UTC) Received: by iazz13 with SMTP id z13so2125350iaz.13 for ; Wed, 11 Jan 2012 09:52:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=8zUm1bk06d4BBgKx0643xwCzFj6jFfwC9LlhNDi5sBU=; b=v7dTeU6qOCXNqyPyg+JIPUT+xt2VDKuGyp9NtGPKxKbFycd07a8sdmF6OUxYNCzA5K Ksmon1ZE+Mz+iG5Qlbf0RddAdrB9GumDgDtYmBagAyDloitXlvJXj0wra3/ZYwKELWqb /3zohFIuGE+4OGyM9L5J7JlP/fVQ37GW7K7tY= MIME-Version: 1.0 Received: by 10.42.142.129 with SMTP id s1mr57826icu.42.1326304346010; Wed, 11 Jan 2012 09:52:26 -0800 (PST) Received: by 10.42.243.65 with HTTP; Wed, 11 Jan 2012 09:52:25 -0800 (PST) In-Reply-To: References: Date: Wed, 11 Jan 2012 09:52:25 -0800 Message-ID: From: Adrian Chadd To: Monthadar Al Jaberi Content-Type: text/plain; charset=ISO-8859-1 Cc: freebsd-wireless@freebsd.org Subject: Re: I've committed the 802.11 simulator X-BeenThere: freebsd-wireless@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussions of 802.11 stack, tools device driver development." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 11 Jan 2012 17:52:26 -0000 On 11 January 2012 09:43, Adrian Chadd wrote: > Hi, > > I've committed monthadar's wifi simulator to -HEAD. The userland tools > aren't there yet but I'll work towards getting those included in the > base system. .. I've now included the wtap create/destroy program in src/tools/tools/wtap/wtap/ (ew, I know.) adrian From owner-freebsd-wireless@FreeBSD.ORG Wed Jan 11 18:39:21 2012 Return-Path: Delivered-To: freebsd-wireless@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id D432510657C0 for ; Wed, 11 Jan 2012 18:39:21 +0000 (UTC) (envelope-from monthadar@gmail.com) Received: from mail-iy0-f182.google.com (mail-iy0-f182.google.com [209.85.210.182]) by mx1.freebsd.org (Postfix) with ESMTP id A03E28FC17 for ; Wed, 11 Jan 2012 18:39:21 +0000 (UTC) Received: by iazz13 with SMTP id z13so2197528iaz.13 for ; Wed, 11 Jan 2012 10:39:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=1pWPXSujVerGOBmcrDDu104SfwArfOnWqe4oD8pdFc0=; b=qqqVr7/7qAoHPiSKBAzl/8iRYcVu3KQqPsj0euAVVu3cu7oXrPmm/8wl9el+LxIM/4 uL31K4mu4RfEusSpkPL7i7kJTi/8pNECJPoGFqjToryCzTU1B0OxYWR1nHecLJdidDCO LsYoYE/EkTMIX1QHUFFivreUDt20MGPjV627w= MIME-Version: 1.0 Received: by 10.43.45.137 with SMTP id uk9mr164825icb.52.1326307160943; Wed, 11 Jan 2012 10:39:20 -0800 (PST) Received: by 10.50.213.74 with HTTP; Wed, 11 Jan 2012 10:39:20 -0800 (PST) In-Reply-To: References: Date: Wed, 11 Jan 2012 19:39:20 +0100 Message-ID: From: Monthadar Al Jaberi To: Adrian Chadd Content-Type: text/plain; charset=ISO-8859-1 Cc: freebsd-wireless@freebsd.org Subject: Re: I've committed the 802.11 simulator X-BeenThere: freebsd-wireless@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussions of 802.11 stack, tools device driver development." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 11 Jan 2012 18:39:21 -0000 Nice, hope more people will benefit from it and contribute back! A lot of work still need to be done though... as usual :) Thank you On Wed, Jan 11, 2012 at 6:52 PM, Adrian Chadd wrote: > On 11 January 2012 09:43, Adrian Chadd wrote: >> Hi, >> >> I've committed monthadar's wifi simulator to -HEAD. The userland tools >> aren't there yet but I'll work towards getting those included in the >> base system. > > .. I've now included the wtap create/destroy program in > src/tools/tools/wtap/wtap/ (ew, I know.) > > > > adrian -- Monthadar Al Jaberi From owner-freebsd-wireless@FreeBSD.ORG Wed Jan 11 19:03:40 2012 Return-Path: Delivered-To: freebsd-wireless@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id A41F9106564A; Wed, 11 Jan 2012 19:03:40 +0000 (UTC) (envelope-from bschmidt@techwires.net) Received: from mail-ee0-f54.google.com (mail-ee0-f54.google.com [74.125.83.54]) by mx1.freebsd.org (Postfix) with ESMTP id 0BA258FC12; Wed, 11 Jan 2012 19:03:39 +0000 (UTC) Received: by eekd49 with SMTP id d49so536240eek.13 for ; Wed, 11 Jan 2012 11:03:38 -0800 (PST) Received: by 10.213.14.71 with SMTP id f7mr1399793eba.61.1326308618800; Wed, 11 Jan 2012 11:03:38 -0800 (PST) Received: from amy.lab.techwires.net (dslb-094-217-142-099.pools.arcor-ip.net. [94.217.142.99]) by mx.google.com with ESMTPS id 76sm9184670eeh.0.2012.01.11.11.03.36 (version=SSLv3 cipher=OTHER); Wed, 11 Jan 2012 11:03:37 -0800 (PST) Sender: Bernhard Schmidt From: Bernhard Schmidt To: freebsd-wireless@freebsd.org Date: Wed, 11 Jan 2012 20:03:44 +0100 User-Agent: KMail/1.13.7 (FreeBSD/9.0-PRERELEASE; KDE/4.7.3; amd64; ; ) References: In-Reply-To: MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201201112003.44891.bschmidt@freebsd.org> Cc: Subject: Re: 11s mesh path setup problem X-BeenThere: freebsd-wireless@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussions of 802.11 stack, tools device driver development." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 11 Jan 2012 19:03:40 -0000 On Wednesday 11 January 2012 18:23:29 Adrian Chadd wrote: > Hi! > > I've just done a bit of a code review. Here are my comments: > > * ether_sprintf() can't be implemented the way you've implemented it - > it just won't work at all in a multithreaded, concurrent environment. > We'll have to find an alternative way. > > Maybe something like: > > char * > ether_sprintf2(const u_char *ap, char *buf, int len) > { > .. do things to buf, rather than the static buf. > } > > Then maybe this'd work: > > char a[32], b[32]; > IEEE80211_NOTE(..., ether_sprintf2(addr1, a, 32), ether_sprintf2(addr2, a, 32)); > > does that make sense? Isn't there an example in net80211 with %D? printf("%6D %6D", addr1, ":", addr2, ":"); The saner alternative is to call printf() multiple times, see ieee80211_dump_pkt() as an example. -- Bernhard From owner-freebsd-wireless@FreeBSD.ORG Fri Jan 13 16:27:12 2012 Return-Path: Delivered-To: freebsd-wireless@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 98006106566C for ; Fri, 13 Jan 2012 16:27:12 +0000 (UTC) (envelope-from pancakeking79@gmail.com) Received: from mail-lpp01m010-f54.google.com (mail-lpp01m010-f54.google.com [209.85.215.54]) by mx1.freebsd.org (Postfix) with ESMTP id 162218FC19 for ; Fri, 13 Jan 2012 16:27:11 +0000 (UTC) Received: by lahd3 with SMTP id d3so542078lah.13 for ; Fri, 13 Jan 2012 08:27:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:date:message-id:subject:from:to:content-type; bh=72J5uMXzpEHbUfr03TFS9GchViNHE1Vuv4YVYmHK2nk=; b=Eqp0SpdclqtLkuZRjh/kwCNLRO9kHciKo6y9DoMfA50LdEX6s1u+wKM9L3Vkmx9gxu 5riku04mDdadfgJKqF9TdhHpZxTY28Ay8vOZoO0Y7nLgsVNvLRlC03aofN+jjk+P+F8b e00V3dF3QF1MRErVMYXZLqd6CP+nVU9x96X/0= MIME-Version: 1.0 Received: by 10.152.103.169 with SMTP id fx9mr750595lab.34.1326470258013; Fri, 13 Jan 2012 07:57:38 -0800 (PST) Received: by 10.152.6.5 with HTTP; Fri, 13 Jan 2012 07:57:37 -0800 (PST) Date: Fri, 13 Jan 2012 16:57:37 +0100 Message-ID: From: _ To: freebsd-wireless@freebsd.org Content-Type: text/plain; charset=ISO-8859-1 X-Content-Filtered-By: Mailman/MimeDel 2.1.5 Subject: NetGear WG511T and WPA support on FreeBSD 8.2 X-BeenThere: freebsd-wireless@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussions of 802.11 stack, tools device driver development." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 Jan 2012 16:27:12 -0000 Hi, By its description, this mailing list seems to be rather technical in nature and my question is - depending on how one sees it - quasi technical or at least too specific as I think for the standard user mailing list, so I'm just giving it a try here... Since I've run into problems getting an ndisgen generated driver for my Realtek RTL8185 54M to work on my FreeBSD 8.2 (i386) system - kldload on the driver generates a permanent kernel crash-, I am currently thinking about buying the NetGear WG511T PCMCIA bus driven card. I would like to ask if there are any users on this list that make use of this card and that can confirm whether or not this cards works fine alongside with WPA on 8.2 or 9.0 if I decide to upgrade? I am aware of the supported hardware list. The card in discussion is not listed as supported. However, this could still be the case, since I read in an older 7.0 related thread http://www.daemonforums.org/showthread.php?t=1424 that it did work, at least at one point in time. Thanks From owner-freebsd-wireless@FreeBSD.ORG Fri Jan 13 19:56:19 2012 Return-Path: Delivered-To: freebsd-wireless@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id DD639106566B for ; Fri, 13 Jan 2012 19:56:19 +0000 (UTC) (envelope-from bschmidt@techwires.net) Received: from mail-ey0-f182.google.com (mail-ey0-f182.google.com [209.85.215.182]) by mx1.freebsd.org (Postfix) with ESMTP id 735EB8FC13 for ; Fri, 13 Jan 2012 19:56:19 +0000 (UTC) Received: by eaai12 with SMTP id i12so354498eaa.13 for ; Fri, 13 Jan 2012 11:56:18 -0800 (PST) Received: by 10.213.22.129 with SMTP id n1mr292263ebb.12.1326484578328; Fri, 13 Jan 2012 11:56:18 -0800 (PST) Received: from amy.lab.techwires.net (dslb-088-067-220-217.pools.arcor-ip.net. [88.67.220.217]) by mx.google.com with ESMTPS id u53sm33573353eeu.6.2012.01.13.11.56.16 (version=SSLv3 cipher=OTHER); Fri, 13 Jan 2012 11:56:17 -0800 (PST) Sender: Bernhard Schmidt From: Bernhard Schmidt To: freebsd-wireless@freebsd.org Date: Fri, 13 Jan 2012 20:56:23 +0100 User-Agent: KMail/1.13.7 (FreeBSD/9.0-PRERELEASE; KDE/4.7.3; amd64; ; ) References: In-Reply-To: MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201201132056.23627.bschmidt@freebsd.org> Cc: Subject: Re: NetGear WG511T and WPA support on FreeBSD 8.2 X-BeenThere: freebsd-wireless@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussions of 802.11 stack, tools device driver development." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 Jan 2012 19:56:19 -0000 On Friday 13 January 2012 16:57:37 _ wrote: > Hi, > > By its description, this mailing list seems to be rather technical in > nature and my question is - depending > on how one sees it - quasi technical or at least too specific as I think > for the standard user mailing list, so > I'm just giving it a try here... > > Since I've run into problems getting an ndisgen generated driver for my > Realtek RTL8185 54M to work on > my FreeBSD 8.2 (i386) system - kldload on the driver generates a permanent > kernel crash-, I am currently > thinking about buying the NetGear WG511T PCMCIA bus driven card. > > I would like to ask if there are any users on this list that make use of > this card and that can confirm whether > or not this cards works fine alongside with WPA on 8.2 or 9.0 if I decide > to upgrade? > > I am aware of the supported hardware list. The card in discussion is not > listed as supported. > However, this could still be the case, since I read in an older 7.0 related > thread > http://www.daemonforums.org/showthread.php?t=1424 that it did work, at > least at one point in time. Afaik the WG511T is supported by ath(4) (it's at least mentioned in the man page) so I think it should work pretty good even without ndis. Btw, you should give 9.0 a shot with ndis, there have been a lot changes there, several of them fixing panics. -- Bernhard From owner-freebsd-wireless@FreeBSD.ORG Sat Jan 14 20:54:45 2012 Return-Path: Delivered-To: freebsd-wireless@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id D40A41065673; Sat, 14 Jan 2012 20:54:45 +0000 (UTC) (envelope-from adrian@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id A72108FC12; Sat, 14 Jan 2012 20:54:45 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id q0EKsjKj060434; Sat, 14 Jan 2012 20:54:45 GMT (envelope-from adrian@freefall.freebsd.org) Received: (from adrian@localhost) by freefall.freebsd.org (8.14.5/8.14.5/Submit) id q0EKsjS1060430; Sat, 14 Jan 2012 20:54:45 GMT (envelope-from adrian) Date: Sat, 14 Jan 2012 20:54:45 GMT Message-Id: <201201142054.q0EKsjS1060430@freefall.freebsd.org> To: adrian@FreeBSD.org, freebsd-net@FreeBSD.org, freebsd-wireless@FreeBSD.org From: adrian@FreeBSD.org Cc: Subject: Re: bin/164102: hostapd not configured for 802.11n X-BeenThere: freebsd-wireless@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussions of 802.11 stack, tools device driver development." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 14 Jan 2012 20:54:45 -0000 Synopsis: hostapd not configured for 802.11n Responsible-Changed-From-To: freebsd-net->freebsd-wireless Responsible-Changed-By: adrian Responsible-Changed-When: Sat Jan 14 20:54:35 UTC 2012 Responsible-Changed-Why: Flip to -wireless. http://www.freebsd.org/cgi/query-pr.cgi?pr=164102 From owner-freebsd-wireless@FreeBSD.ORG Sat Jan 14 21:00:36 2012 Return-Path: Delivered-To: freebsd-wireless@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 8C05A1065673 for ; Sat, 14 Jan 2012 21:00:36 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 7737D8FC12 for ; Sat, 14 Jan 2012 21:00:36 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id q0EL0aLa060760 for ; Sat, 14 Jan 2012 21:00:36 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.5/8.14.5/Submit) id q0EL0aRN060758; Sat, 14 Jan 2012 21:00:36 GMT (envelope-from gnats) Date: Sat, 14 Jan 2012 21:00:36 GMT Message-Id: <201201142100.q0EL0aRN060758@freefall.freebsd.org> To: freebsd-wireless@FreeBSD.org From: Adrian Chadd Cc: Subject: Re: bin/164102: hostapd not configured for 802.11n X-BeenThere: freebsd-wireless@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Adrian Chadd List-Id: "Discussions of 802.11 stack, tools device driver development." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 14 Jan 2012 21:00:36 -0000 The following reply was made to PR bin/164102; it has been noted by GNATS. From: Adrian Chadd To: bug-followup@FreeBSD.org, ntai@smartfruit.com Cc: Subject: Re: bin/164102: hostapd not configured for 802.11n Date: Sat, 14 Jan 2012 12:57:30 -0800 Hi, I haven't tried mwl yet, but you should just be able to configure the interface as an 802.11n one: ifconfig wlan0 create wlandev mwl0 wlanmode hostap ifconfig wlan0 channel 6:ht/40 ifconfig wlan0 up .. then start hostapd. Hostapd doesn't require any 802.11n "stuff" to be configured - just make sure you only enable CCMP encryption. 802.11n doesn't work with TKIP. Please make sure you update to FreeBSD-8 STABLE as the -RELEASE code has significant issues with 802.11n. Adrian