From owner-freebsd-wireless@FreeBSD.ORG Mon Mar 5 11:07:23 2012 Return-Path: Delivered-To: freebsd-wireless@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 04035106567A for ; Mon, 5 Mar 2012 11:07:23 +0000 (UTC) (envelope-from owner-bugmaster@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id E5CAB8FC28 for ; Mon, 5 Mar 2012 11:07:22 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id q25B7MGO035086 for ; Mon, 5 Mar 2012 11:07:22 GMT (envelope-from owner-bugmaster@FreeBSD.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.5/8.14.5/Submit) id q25B7Mji035084 for freebsd-wireless@FreeBSD.org; Mon, 5 Mar 2012 11:07:22 GMT (envelope-from owner-bugmaster@FreeBSD.org) Date: Mon, 5 Mar 2012 11:07:22 GMT Message-Id: <201203051107.q25B7Mji035084@freefall.freebsd.org> X-Authentication-Warning: freefall.freebsd.org: gnats set sender to owner-bugmaster@FreeBSD.org using -f From: FreeBSD bugmaster To: freebsd-wireless@FreeBSD.org Cc: Subject: Current problem reports assigned to freebsd-wireless@FreeBSD.org X-BeenThere: freebsd-wireless@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussions of 802.11 stack, tools device driver development." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 05 Mar 2012 11:07:23 -0000 Note: to view an individual PR, use: http://www.freebsd.org/cgi/query-pr.cgi?pr=(number). The following is a listing of current problems submitted by FreeBSD users. These represent problem reports covering all versions including experimental development code and obsolete releases. S Tracker Resp. Description -------------------------------------------------------------------------------- o kern/165595 wireless [ipw] ipw(4): Can't load firmare for ipw2200bg o kern/165543 wireless [ath] ath0 endless scanning of channels without connec o kern/165517 wireless [net80211] bgscan isn't triggered when invalid beacons o kern/165475 wireless [ath] operational mode change doesn't poke the underly o kern/165382 wireless [kernel] taskqueue_unblock doesn't unblock currently q o kern/165306 wireless [ath] race conditions between scanning and beacon time o kern/165220 wireless [ath] "ath_rx_tasklet: sc_inreset_cnt > 0; skipping" m o kern/165214 wireless [ieee80211] Kernel panic in ieee80211_output.c:2505 o kern/165212 wireless [ath] No WiFi on Acer Aspire One 751h (Atheros AR5BHB6 o kern/165149 wireless [ath] [net80211] Ping with data length more than iv_fr o kern/165146 wireless [net80211] Net802.11 Fragment number is assigned 1 (sh o kern/165060 wireless [ath] vap->iv_bss race conditions causing crashes insi o kern/165021 wireless [ath] ath device timeout during scan/attach, if wlan_c o kern/164721 wireless [ath] ath device timeouts o kern/164499 wireless [wi] [patch] if_wi needs fix for big endian architectu o kern/164382 wireless [ath] crash when down/deleting a vap - inside ieee8021 o kern/164365 wireless [iwi] iwi0: UP/DOWN in o bin/164102 wireless hostapd not configured for 802.11n o kern/163759 wireless [ath] ath(4) "stops working" in hostap mode o kern/163724 wireless [mwl] [patch] NULL check before dereference o kern/163719 wireless [ath] ath interface do not receive multicast o kern/163689 wireless [ath] TX timeouts when sending probe/mgmt frames durin o kern/163574 wireless [net80211] overly-frequent HT occupancy changes o kern/163573 wireless [ath] hostap mode TX buffer hang o kern/163559 wireless [ath] kernel panic AH_DEBUG o kern/163318 wireless [ath] ath(4) stops working p kern/163312 wireless [panic] [ath driver] kernel panic: page fault with ath o kern/163082 wireless [ath] ar9285 diversity fixes o kern/162648 wireless [ath] AR9227 ADC DC calibration failure o kern/162647 wireless [ath] 11n TX aggregation session / TX hang o kern/161293 wireless [iwn] hang at startup when starting network o kern/161035 wireless [ieee80211] Incorrect number describing 11ng MCS rate o kern/160391 wireless [ieee80211] [patch] Panic in mesh mode o kern/160296 wireless [zyd] [panic] 802.11 usb device reboots system on 'ifc o misc/160176 wireless [mips] [panic] Kernel panic on AR7161 platform with AR o kern/157449 wireless [ath] MAC address conflict causes system to freeze o kern/157243 wireless [ath] investigate beacon TX (AP) / RX (STA) when under o kern/156904 wireless [ath] AR9285 antenna diversity algorithm is buggy and o kern/156884 wireless [ath] ath instablity o kern/156327 wireless [bwn] bwn driver causes 20%-50% packet loss o kern/156322 wireless [wpi] no ahdemo support for if_wpi o kern/156321 wireless [ath] ahdemo doesn't work with if_ath o kern/155498 wireless [ral] ral(4) needs to be resynced with OpenBSD's to ga o kern/155100 wireless [ath] ath driver on busy channel: "stuck beacon" p kern/154598 wireless [ath] Atheros 5424/2424 can't connect to WPA network o kern/154567 wireless [ath] ath(4) lot of bad series(0) o kern/154327 wireless [ath] AR5416 in station mode hangs when transmitting f o kern/154284 wireless [ath] Modern ath wifi cards (such as AR9285) have miss o kern/154153 wireless [ath] AR5213 + MIPS + WPA group key packet corruption o kern/153448 wireless [ath] ath networking device loses association after a o kern/152750 wireless [ath] ath0 lot of bad series hwrate o kern/151198 wireless [ath] ath/5416 fails bgscan with "ath0: ath_chan_set: o kern/149786 wireless [bwn] bwn on Dell Inspiron 1150: connections stall o kern/149516 wireless [ath] ath(4) hostap with fake MAC/BSSID results in sta o kern/149373 wireless [realtek/atheros]: None of my network card working o kern/148322 wireless [ath] Triggering atheros wifi beacon misses in hostap o kern/148317 wireless [ath] FreeBSD 7.x hostap memory leak in net80211 or At o kern/148078 wireless [ath] wireless networking stops functioning o kern/145826 wireless [panic] [ath] Unable to configure adhoc mode on ath0/w o kern/144987 wireless [wpi] [panic] injecting packets with wlaninject using o bin/144109 wireless hostapd(8) uses the MAC of the wireless interface, but o conf/143079 wireless hostapd(8) startup missing multi wlan functionality p kern/140567 wireless [ath] [patch] ath is not worked on my notebook PC o kern/140245 wireless [ath] [panic] Kernel panic during network activity on o kern/137592 wireless [ath] panic - 7-STABLE (Aug 7, 2009 UTC) crashes on ne p bin/137484 wireless [patch] Integer overflow in wpa_supplicant(8) base64 e o kern/136943 wireless [wpi] [lor] wpi0_com_lock / wpi0 o kern/136836 wireless [ath] atheros card stops functioning after about 12 ho o kern/132722 wireless [ath] Wifi ath0 associates fine with AP, but DHCP or I o bin/131549 wireless ifconfig(8) can't clear 'monitor' mode on the wireless o kern/126475 wireless [ath] [panic] ath pcmcia card inevitably panics under o kern/125721 wireless [ath] Terrible throughput/high ping latency with Ubiqu o kern/125617 wireless [ath] [panic] ath(4) related panic o kern/125501 wireless [ath] atheros cardbus driver hangs o kern/125332 wireless [ath] [panic] crash under any non-tiny networking unde o kern/124767 wireless [iwi] Wireless connection using iwi0 driver (Intel 220 o kern/124753 wireless [ieee80211] net80211 discards power-save queue packets o docs/120456 wireless ath(4) needs to specify requirement on wlan_scan_sta o kern/119513 wireless [ath] [irq] inserting dlink dwl-g630 wireless card res o kern/116747 wireless [ndis] FreeBSD 7.0-CURRENT crash with Dell TrueMobile f kern/105348 wireless [ath] ath device stopps TX 81 problems total. From owner-freebsd-wireless@FreeBSD.ORG Mon Mar 5 19:19:37 2012 Return-Path: Delivered-To: freebsd-wireless@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id A9BCD106564A; Mon, 5 Mar 2012 19:19:37 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Received: from mail-ww0-f42.google.com (mail-ww0-f42.google.com [74.125.82.42]) by mx1.freebsd.org (Postfix) with ESMTP id 0F4318FC0C; Mon, 5 Mar 2012 19:19:36 +0000 (UTC) Received: by wgbds11 with SMTP id ds11so1572349wgb.1 for ; Mon, 05 Mar 2012 11:19:36 -0800 (PST) Received-SPF: pass (google.com: domain of adrian.chadd@gmail.com designates 10.216.131.2 as permitted sender) client-ip=10.216.131.2; Authentication-Results: mr.google.com; spf=pass (google.com: domain of adrian.chadd@gmail.com designates 10.216.131.2 as permitted sender) smtp.mail=adrian.chadd@gmail.com; dkim=pass header.i=adrian.chadd@gmail.com Received: from mr.google.com ([10.216.131.2]) by 10.216.131.2 with SMTP id l2mr4742129wei.3.1330975176070 (num_hops = 1); Mon, 05 Mar 2012 11:19:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=I5FCyQFOIlLAti9VNpacw9jFBH9d5Fdga9RewEnCMPo=; b=St86WwEb8kINnXYtX95QX1OSrijmpNIFdEK9ZWUabUC1P4pt2gmaf8BPnzDxN0xExJ BDm01iV0fZ2EW77T0ckyVTscyDpXGwErOrJOoSqjT7Edk/LE7GfXjTN9YxTuiFn4b7cg RR0JIHJsNT0IooogRl441/7IJuaMvcLvehDdLhftHO4t9dCe88C34uXY8fpyRXkMZrby ZjUQJRVFzIuTVCYmgsTm/Qxbws1bhOzYBjZfsU9rFOYE7NwCAd4EARKbjZkLbpyJ018f FvhQk5XymHbF0lWVfzofpqouYaXN3dq9SYfCxiT31+LaRhQzy0iO9RMlBQjop1dBdBDg ku7g== MIME-Version: 1.0 Received: by 10.216.131.2 with SMTP id l2mr3793808wei.3.1330975175962; Mon, 05 Mar 2012 11:19:35 -0800 (PST) Sender: adrian.chadd@gmail.com Received: by 10.216.198.81 with HTTP; Mon, 5 Mar 2012 11:19:35 -0800 (PST) In-Reply-To: <20120306.024212.108736612.iwasaki@jp.FreeBSD.org> References: <20120306.024212.108736612.iwasaki@jp.FreeBSD.org> Date: Mon, 5 Mar 2012 11:19:35 -0800 X-Google-Sender-Auth: rq7qe7XVu2mkQlmciWxbFbZo_ts Message-ID: From: Adrian Chadd To: Mitsuru IWASAKI Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: freebsd-current@freebsd.org, freebsd-wireless@freebsd.org Subject: Re: patches for if_iwi and wlan for WEP mode X-BeenThere: freebsd-wireless@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussions of 802.11 stack, tools device driver development." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 05 Mar 2012 19:19:37 -0000 Hi! (cc'ing freebsd-wireless, where we try to talk about this kind of stuff...) On 5 March 2012 09:42, Mitsuru IWASAKI wrote: > Hi, > > I've fixed iwi(4) so that Intel(R) PRO/Wireless 2915ABG work > in WEP mode, which seems to be broken since 8.0-RELEASE. Thanks for looking into this! I've not looked into ath(4) and WEP (ever, to be honest) - I really should. I wonder if it's similarly broken. But if it isn't, ath(4) doesn't yet use if_transmit/if_flush. That's on my TODO list (in order to fix fragment handling, rather than WEP.) Would you please open a PR with this particular issue and then attach the patch to it? I'd rather you not commit the net80211 change until I've verified that WEP works or doesn't work with ath(4). Thanks! Adrian > > The patches against HEAD at: > http://people.freebsd.org/~iwasaki/iwi/iwi-20120305.diff > > I'm not sure that changes on ieee80211 layer are right fixes, > but all of mbufs were discarded in ieee80211_start() in WEP mode. > > ---- > void > ieee80211_start(struct ifnet *ifp) > { > [snip] > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0if (ni->ni_associd =3D=3D = 0 && > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0(ni->ni_flags & IE= EE80211_NODE_ASSOCID)) { > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0IEEE80211_= DISCARD_MAC(vap, IEEE80211_MSG_OUTPUT, > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0eh= ->ether_dhost, NULL, > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0"s= ta not associated (type 0x%04x)", > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0ht= ons(eh->ether_type)); > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0vap->iv_st= ats.is_tx_notassoc++; > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0ifp->if_oe= rrors++; > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0m_freem(m)= ; > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0ieee80211_= free_node(ni); > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0continue; > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0} > ---- > > My patches set IEEE80211_NODE_ASSOCID bit only if ni->ni_associd > is set. =A0Any suggestions on this part are welcome. > > I'm going to commit the changes coming weekend. > > Thanks! > _______________________________________________ > freebsd-current@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-current > To unsubscribe, send any mail to "freebsd-current-unsubscribe@freebsd.org= " From owner-freebsd-wireless@FreeBSD.ORG Mon Mar 5 22:14:10 2012 Return-Path: Delivered-To: freebsd-wireless@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id A91291065677 for ; Mon, 5 Mar 2012 22:14:10 +0000 (UTC) (envelope-from bschmidt@techwires.net) Received: from mail-ey0-f182.google.com (mail-ey0-f182.google.com [209.85.215.182]) by mx1.freebsd.org (Postfix) with ESMTP id 2EF378FC17 for ; Mon, 5 Mar 2012 22:14:09 +0000 (UTC) Received: by eaaf13 with SMTP id f13so1667098eaa.13 for ; Mon, 05 Mar 2012 14:14:09 -0800 (PST) Received-SPF: pass (google.com: domain of bschmidt@techwires.net designates 10.14.37.78 as permitted sender) client-ip=10.14.37.78; Authentication-Results: mr.google.com; spf=pass (google.com: domain of bschmidt@techwires.net designates 10.14.37.78 as permitted sender) smtp.mail=bschmidt@techwires.net Received: from mr.google.com ([10.14.37.78]) by 10.14.37.78 with SMTP id x54mr1667498eea.42.1330985649187 (num_hops = 1); Mon, 05 Mar 2012 14:14:09 -0800 (PST) Received: by 10.14.37.78 with SMTP id x54mr1265681eea.42.1330985648987; Mon, 05 Mar 2012 14:14:08 -0800 (PST) Received: from amy.lab.techwires.net (dslb-088-067-212-216.pools.arcor-ip.net. [88.67.212.216]) by mx.google.com with ESMTPS id y11sm5185684eem.3.2012.03.05.14.14.07 (version=SSLv3 cipher=OTHER); Mon, 05 Mar 2012 14:14:08 -0800 (PST) Sender: Bernhard Schmidt From: Bernhard Schmidt To: freebsd-current@freebsd.org Date: Mon, 5 Mar 2012 23:14:21 +0100 User-Agent: KMail/1.13.7 (FreeBSD/9.0-STABLE; KDE/4.7.4; amd64; ; ) References: <20120306.024212.108736612.iwasaki@jp.FreeBSD.org> In-Reply-To: <20120306.024212.108736612.iwasaki@jp.FreeBSD.org> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201203052314.22050.bschmidt@freebsd.org> X-Gm-Message-State: ALoCoQnxcYWiX9zNl/eQM+mVWxwKWzFdFaFQUxbjjVigw2tw5Zb+l4yQQY8K0lrVe6PQeSZ6iTfB Cc: freebsd-wireless@freebsd.org, Mitsuru IWASAKI Subject: Re: patches for if_iwi and wlan for WEP mode X-BeenThere: freebsd-wireless@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussions of 802.11 stack, tools device driver development." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 05 Mar 2012 22:14:10 -0000 On Monday 05 March 2012 18:42:12 Mitsuru IWASAKI wrote: > Hi, > > I've fixed iwi(4) so that Intel(R) PRO/Wireless 2915ABG work > in WEP mode, which seems to be broken since 8.0-RELEASE. > > The patches against HEAD at: > http://people.freebsd.org/~iwasaki/iwi/iwi-20120305.diff > > I'm not sure that changes on ieee80211 layer are right fixes, > but all of mbufs were discarded in ieee80211_start() in WEP mode. > > ---- > void > ieee80211_start(struct ifnet *ifp) > { > [snip] > if (ni->ni_associd == 0 && > (ni->ni_flags & IEEE80211_NODE_ASSOCID)) { > IEEE80211_DISCARD_MAC(vap, IEEE80211_MSG_OUTPUT, > eh->ether_dhost, NULL, > "sta not associated (type 0x%04x)", > htons(eh->ether_type)); > vap->iv_stats.is_tx_notassoc++; > ifp->if_oerrors++; > m_freem(m); > ieee80211_free_node(ni); > continue; > } > ---- > > My patches set IEEE80211_NODE_ASSOCID bit only if ni->ni_associd > is set. Any suggestions on this part are welcome. Are you sure the net80211 part is correct? It looks to me as if you are just masking the real issue. The IEEE80211_NODE_ASSOCID flag is ment to be used to verify that an associd has actually been set, not doing so will break other things I guess. iwi(4) is a bit tricky in that regard, as it sets the associd itself, check iwi_checkforqos(). I'd verify that function is actually called and if so if the parameters are correct. I fumbled around there once, might have wrong WEP.. > I'm going to commit the changes coming weekend. What's the reason behing adding if_qflush()/if_transmit()? -- Bernhard From owner-freebsd-wireless@FreeBSD.ORG Tue Mar 6 11:09:15 2012 Return-Path: Delivered-To: freebsd-wireless@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 16CCE106564A for ; Tue, 6 Mar 2012 11:09:15 +0000 (UTC) (envelope-from jhugo@meraka.csir.co.za) Received: from marge.meraka.csir.co.za (marge.meraka.csir.co.za [IPv6:2001:4200:7000:3::1]) by mx1.freebsd.org (Postfix) with ESMTP id 076208FC1E for ; Tue, 6 Mar 2012 11:09:13 +0000 (UTC) Received: from jeep.localnet (unknown [IPv6:2001:4200:7000:3:223:aeff:fea7:a3c2]) by marge.meraka.csir.co.za (Postfix) with ESMTP id C7F37D0CC03 for ; Tue, 6 Mar 2012 13:09:11 +0200 (SAST) From: Johann Hugo To: freebsd-wireless@freebsd.org Date: Tue, 6 Mar 2012 13:09:11 +0200 User-Agent: KMail/1.13.7 (FreeBSD/9.0-RELEASE; KDE/4.7.3; amd64; ; ) References: <201202281639.05140.jhugo@meraka.csir.co.za> <201202291151.10365.jhugo@meraka.csir.co.za> In-Reply-To: X-KMail-Markup: true MIME-Version: 1.0 Message-Id: <201203061309.11139.jhugo@meraka.csir.co.za> Content-Type: Multipart/Mixed; boundary="Boundary-00=_XBfVPZ7MRU0LBax" X-Content-Filtered-By: Mailman/MimeDel 2.1.5 Subject: Re: performance in adhoc mode X-BeenThere: freebsd-wireless@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussions of 802.11 stack, tools device driver development." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 06 Mar 2012 11:09:15 -0000 --Boundary-00=_XBfVPZ7MRU0LBax Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit On Wednesday 29 February 2012 19:48:53 you wrote: > Ok, long_retry means that the hardware had to try more times to get > the frame out. > > Either it's picking too high a rate, or the ACKs can't be heard. Should be ok, they are one meter apart. > > I wonder what changes in the MAC and driver when we flip on adhoc > mode. I know it changes how the beacon queue is handled, I didn't > think anything else changed.. > > Can you try forcing a lower rate on both ends (ifconfig wlanX > ucastrate Y) and do your tests? Are the parameters that one get with (ifconfig -m wlanX) still valid ? See attached for tests. B.t.w. I get better performance with our old FreeBSD-7.2 distro in adhoc mode than with our new FreeBSD-9.0 distro on the same hardware. FreeBSD-7.2 NodeA: iperf = 25.1 Mbits/sec NodeB: iperf = 25.2 Mbits/sec FreeBSD-9.0 NodeA: iperf = 20.5 Mbits/sec NodeB: iperf =20.8 Mbits/sec > > Please file a PR with this. :) Will do so. Regards Johann > > Thanks! > > > Adrian > > On 29 February 2012 01:51, Johann Hugo wrote: > > On Tuesday 28 February 2012 17:50:39 Adrian Chadd wrote: > >> I've not looked into adhoc _at all_. > > > > please_do > > > >> I'd start by looking at the behaviour of the rate control code - do > >> > >> 'sysctl dev.ath.X sample_stats=1' after you've done some traffic and > >> > >> check dmesg. > >> > >> > >> > >> Just ensure that the same rates are being used and the error rate is > >> low. > > > > The rates differ a bit and also some of the dev.ath.0 sysctl's. > > dev.ath.0.stats.ast_tx_longretry is more than double in adhoc mode. > > > > > > > > Johann --Boundary-00=_XBfVPZ7MRU0LBax Content-Type: text/plain; charset="utf-8"; name="longretry.txt" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="longretry.txt" ifconfig wlan0 ucastrate 54Mbps NodeA: iperf = 21.3 Mbits/sec mesh-2893:~ # sysctl dev.ath.0.sample_stats=1 dev.ath.0.sample_stats: 0 [00:80:48:4f:28:93] refcnt 4 static_rix 0 ratemask 0x0 [ 250] cur rix 0 (6 Mb ) since switch: packets 0 ticks 0 [ 250] last sample 0 cur sample 0 packets sent 0 [ 250] packets since sample 0 sample tt 0 [1600] cur rix 0 (6 Mb ) since switch: packets 0 ticks 0 [1600] last sample 0 cur sample 0 packets sent 0 [1600] packets since sample 0 sample tt 0 [00:80:48:4f:28:70] refcnt 3 static_rix 7 ratemask 0xff [ 250] cur rix 0 (6 Mb ) since switch: packets 0 ticks 0 [ 250] last sample 0 cur sample -1 packets sent 13008 [ 250] packets since sample 0 sample tt 0 [1600] cur rix 0 (6 Mb ) since switch: packets 0 ticks 0 [1600] last sample 0 cur sample -1 packets sent 0 [1600] packets since sample 0 sample tt 0 [54 Mb : 250] 13007:13006 ( 99%) T 14574 F 0 avg 463 last 1491 [54 Mb :1600] 1:0 ( 0%) T 12 F 1 avg 644 last 1712 mesh-2893:~ # sysctl dev.ath.0.stats.ast_tx_longretry dev.ath.0.stats.ast_tx_longretry: 1567 NodeB: iperf = 21.7 Mbits/sec mesh-2870:~ # sysctl dev.ath.0.sample_stats=1 dev.ath.0.sample_stats: 0 [00:80:48:4f:28:70] refcnt 4 static_rix 0 ratemask 0x0 [ 250] cur rix 0 (6 Mb ) since switch: packets 0 ticks 0 [ 250] last sample 0 cur sample 0 packets sent 0 [ 250] packets since sample 0 sample tt 0 [1600] cur rix 0 (6 Mb ) since switch: packets 0 ticks 0 [1600] last sample 0 cur sample 0 packets sent 0 [1600] packets since sample 0 sample tt 0 [00:80:48:4f:28:93] refcnt 3 static_rix 7 ratemask 0xff [ 250] cur rix 0 (6 Mb ) since switch: packets 0 ticks 0 [ 250] last sample 0 cur sample -1 packets sent 13 [ 250] packets since sample 0 sample tt 0 [1600] cur rix 0 (6 Mb ) since switch: packets 0 ticks 0 [1600] last sample 0 cur sample -1 packets sent 18967 [1600] packets since sample 0 sample tt 0 [54 Mb : 250] 13:13 (100%) T 13 F 0 avg 444 last 2039 [54 Mb :1600] 18831:18830 ( 99%) T 20559 F 0 avg 681 last 2040 mesh-2870:~ # sysctl dev.ath.0.stats.ast_tx_longretry dev.ath.0.stats.ast_tx_longretry: 1728 --------------------------------------------------------------------------------------- ifconfig wlan0 ucastrate 48Mbps NodeA: iperf = 21.1 Mbits/sec dev.ath.0.sample_stats: 0 [00:80:48:4f:28:93] refcnt 4 static_rix 0 ratemask 0x0 [ 250] cur rix 0 (6 Mb ) since switch: packets 0 ticks 0 [ 250] last sample 0 cur sample 0 packets sent 0 [ 250] packets since sample 0 sample tt 0 [1600] cur rix 0 (6 Mb ) since switch: packets 0 ticks 0 [1600] last sample 0 cur sample 0 packets sent 0 [1600] packets since sample 0 sample tt 0 [00:80:48:4f:28:70] refcnt 3 static_rix 6 ratemask 0xff [ 250] cur rix 0 (6 Mb ) since switch: packets 0 ticks 0 [ 250] last sample 0 cur sample -1 packets sent 12522 [ 250] packets since sample 0 sample tt 0 [1600] cur rix 0 (6 Mb ) since switch: packets 0 ticks 0 [1600] last sample 0 cur sample -1 packets sent 0 [1600] packets since sample 0 sample tt 0 [48 Mb : 250] 12522:12522 (100%) T 13980 F 0 avg 695 last 16081 mesh-2893:~ # sysctl dev.ath.0.stats.ast_tx_longretry dev.ath.0.stats.ast_tx_longretry: 1476 NodeB: iperf = 21.4 Mbits/sec dev.ath.0.sample_stats: 0 [00:80:48:4f:28:93] refcnt 4 static_rix 0 ratemask 0x0 [ 250] cur rix 0 (6 Mb ) since switch: packets 0 ticks 0 [ 250] last sample 0 cur sample 0 packets sent 0 [ 250] packets since sample 0 sample tt 0 [1600] cur rix 0 (6 Mb ) since switch: packets 0 ticks 0 [1600] last sample 0 cur sample 0 packets sent 0 [1600] packets since sample 0 sample tt 0 [00:80:48:4f:28:70] refcnt 3 static_rix 6 ratemask 0xff [ 250] cur rix 0 (6 Mb ) since switch: packets 0 ticks 0 [ 250] last sample 0 cur sample -1 packets sent 12522 [ 250] packets since sample 0 sample tt 0 [1600] cur rix 0 (6 Mb ) since switch: packets 0 ticks 0 [1600] last sample 0 cur sample -1 packets sent 0 [1600] packets since sample 0 sample tt 0 [48 Mb : 250] 12522:12522 (100%) T 13980 F 0 avg 695 last 16081 mesh-2870:~ # sysctl dev.ath.0.stats.ast_tx_longretry dev.ath.0.stats.ast_tx_longretry: 1516 --------------------------------------------------------------------------------------- ifconfig wlan0 ucastrate 36Mbps NodeA: iperf = 18.0 Mbits/sec ^Cmesh-2893:~ # sysctl dev.ath.0.sample_stats=1 dev.ath.0.sample_stats: 0 [00:80:48:4f:28:93] refcnt 4 static_rix 0 ratemask 0x0 [ 250] cur rix 0 (6 Mb ) since switch: packets 0 ticks 0 [ 250] last sample 0 cur sample 0 packets sent 0 [ 250] packets since sample 0 sample tt 0 [1600] cur rix 0 (6 Mb ) since switch: packets 0 ticks 0 [1600] last sample 0 cur sample 0 packets sent 0 [1600] packets since sample 0 sample tt 0 [00:80:48:4f:28:70] refcnt 3 static_rix 5 ratemask 0xff [ 250] cur rix 0 (6 Mb ) since switch: packets 0 ticks 0 [ 250] last sample 0 cur sample -1 packets sent 10664 [ 250] packets since sample 0 sample tt 0 [1600] cur rix 0 (6 Mb ) since switch: packets 0 ticks 0 [1600] last sample 0 cur sample -1 packets sent 0 [1600] packets since sample 0 sample tt 0 [36 Mb : 250] 10664:10664 (100%) T 11876 F 0 avg 548 last 1505 mesh-2893:~ # sysctl dev.ath.0.stats.ast_tx_longretry dev.ath.0.stats.ast_tx_longretry: 1240 NodeB: iperf = 18.3 Mbits/sec mesh-2870:~ # sysctl dev.ath.0.sample_stats=1 dev.ath.0.sample_stats: 0 [00:80:48:4f:28:70] refcnt 4 static_rix 0 ratemask 0x0 [ 250] cur rix 0 (6 Mb ) since switch: packets 0 ticks 0 [ 250] last sample 0 cur sample 0 packets sent 0 [ 250] packets since sample 0 sample tt 0 [1600] cur rix 0 (6 Mb ) since switch: packets 0 ticks 0 [1600] last sample 0 cur sample 0 packets sent 0 [1600] packets since sample 0 sample tt 0 [00:80:48:4f:28:93] refcnt 3 static_rix 5 ratemask 0xff [ 250] cur rix 0 (6 Mb ) since switch: packets 0 ticks 0 [ 250] last sample 0 cur sample -1 packets sent 5 [ 250] packets since sample 0 sample tt 0 [1600] cur rix 0 (6 Mb ) since switch: packets 0 ticks 0 [1600] last sample 0 cur sample -1 packets sent 15841 [1600] packets since sample 0 sample tt 0 [36 Mb : 250] 5:5 (100%) T 5 F 0 avg 464 last 1679 [36 Mb :1600] 15841:15841 (100%) T 17056 F 0 avg 878 last 1682 mesh-2870:~ # sysctl dev.ath.0.stats.ast_tx_longretry dev.ath.0.stats.ast_tx_longretry: 1223 --Boundary-00=_XBfVPZ7MRU0LBax-- From owner-freebsd-wireless@FreeBSD.ORG Tue Mar 6 17:42:58 2012 Return-Path: Delivered-To: freebsd-wireless@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 79BCE106564A; Tue, 6 Mar 2012 17:42:58 +0000 (UTC) (envelope-from iwasaki@jp.FreeBSD.org) Received: from locore.org (ns01.locore.org [218.45.21.227]) by mx1.freebsd.org (Postfix) with ESMTP id 0CC948FC0A; Tue, 6 Mar 2012 17:42:57 +0000 (UTC) Received: from localhost (celeron.v4.locore.org [192.168.0.10]) by locore.org (8.14.5/8.14.5/iwasaki) with ESMTP/inet id q26HUlFe014376; Wed, 7 Mar 2012 02:30:47 +0900 (JST) (envelope-from iwasaki@jp.FreeBSD.org) Date: Wed, 07 Mar 2012 02:30:46 +0900 (JST) Message-Id: <20120307.023046.27956263.iwasaki@jp.FreeBSD.org> To: bschmidt@freebsd.org, adrian@freebsd.org From: Mitsuru IWASAKI In-Reply-To: <201203052314.22050.bschmidt@freebsd.org> References: <20120306.024212.108736612.iwasaki@jp.FreeBSD.org> <201203052314.22050.bschmidt@freebsd.org> X-Mailer: Mew version 3.3 on Emacs 20.7 / Mule 4.0 (HANANOEN) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: freebsd-current@freebsd.org, freebsd-wireless@freebsd.org Subject: Re: patches for if_iwi and wlan for WEP mode X-BeenThere: freebsd-wireless@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussions of 802.11 stack, tools device driver development." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 06 Mar 2012 17:42:58 -0000 Thanks Bernhard and Adrian, I think the problem seems to be solved. > > My patches set IEEE80211_NODE_ASSOCID bit only if ni->ni_associd > > is set. Any suggestions on this part are welcome. > > Are you sure the net80211 part is correct? It looks to me as if you > are just masking the real issue. The IEEE80211_NODE_ASSOCID flag is > ment to be used to verify that an associd has actually been set, not > doing so will break other things I guess. iwi(4) is a bit tricky in > that regard, as it sets the associd itself, check iwi_checkforqos(). > I'd verify that function is actually called and if so if the parameters > are correct. I fumbled around there once, might have wrong WEP.. As you suggested, iwi_checkforqos() has problems, wrong asresp frame parsing. ---- @@ -1357,8 +1365,8 @@ frm += 2; wme = NULL; - while (frm < efrm) { - IEEE80211_VERIFY_LENGTH(efrm - frm, frm[1], return); + while (efrm - frm > 1) { + IEEE80211_VERIFY_LENGTH(efrm - frm, frm[1] + 2, return); switch (*frm) { case IEEE80211_ELEMID_VENDOR: if (iswmeoui(frm)) ---- Bacause of the condition `while (frm < efrm)', IEEE80211_VERIFY_LENGTH() was checking item length beyond the ieee80211_frame region, and returned from iwi_checkforqos() without setting flags, capinfo and associd! I made above changes referring to net80211 code such as ieee80211_sta.c. Today's version of patches at: http://people.freebsd.org/~iwasaki/iwi/iwi-20120306.diff This one don't have changes on net80211 part at all. > What's the reason behing adding if_qflush()/if_transmit()? In RELENG_7, data frame is transmitted by iwi_tx_start() like this. ether_output ether_output_frame IFQ_HANDOFF/IFQ_HANDOFF_ADJ if_start iwi_start iwi_tx_start After 8.0-RELEASE, device specific if_transmit() is called via net80211 layer. ether_output ether_output_frame if_transmit IFQ_HANDOFF/IFQ_HANDOFF_ADJ if_start ieee80211_start parent->if_transmit(ie. iwi_transmit()) There was not if_transmit method in iwi(4), so I add it. On if_qflush(), CURRENT kernel complains that `transmit and qflush must both either be set or both be NULL' from if.c. I wrote iwi_qflush(), but actually never tested it... From: Adrian Chadd > Would you please open a PR with this particular issue and then attach > the patch to it? I prefer committing changes on iwi(4) by myself, because grimreaper@ keep giving pressure to me `Your src commit bit is still idle.' for long time :) I just want to stop it. > I'd rather you not commit the net80211 change until I've verified that > WEP works or doesn't work with ath(4). Never mind, I think I don't need to touch on net80211. Thanks! From owner-freebsd-wireless@FreeBSD.ORG Tue Mar 6 17:48:29 2012 Return-Path: Delivered-To: freebsd-wireless@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id A3449106567C; Tue, 6 Mar 2012 17:48:29 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Received: from mail-we0-f182.google.com (mail-we0-f182.google.com [74.125.82.182]) by mx1.freebsd.org (Postfix) with ESMTP id DBD598FC15; Tue, 6 Mar 2012 17:48:28 +0000 (UTC) Received: by werl4 with SMTP id l4so4274834wer.13 for ; Tue, 06 Mar 2012 09:48:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type; bh=Bw9Zy0lZpAHPXxKvuLLllil9LD+LH/haktQmv8unWTY=; b=x3Rtpps8s1kZwus3ydOBfW+WXLDBVv/DIqG/Ohh5jTawUPKvURmlAUhdZsd0KLjReJ g3VgiavVX7vwMIpovytLcWIpFvv3Zd2sxS29ErArD/2IVVEXyqiySkGmpmmgxgUoEmL2 0xqBrH+FsY/UdI9vYqR1oOAagllt2mg3FWK2fEwOMcj5xPQtuouNz/NURnehWi6aL4JH mDU3Is3UaQLDBCx0okjhnDmBqU2qzHwmuyTDwdV/qe8S4h3EClzrLXcugAcds7WrGhFj ogRIqKT4wC0OMLk+1JrH+RSUBxtIR4t1nTpk33PimhuRFBB2w0flrXqz9kWey+3QvbS1 da3Q== MIME-Version: 1.0 Received: by 10.180.78.6 with SMTP id x6mr20325638wiw.18.1331056102079; Tue, 06 Mar 2012 09:48:22 -0800 (PST) Sender: adrian.chadd@gmail.com Received: by 10.216.198.81 with HTTP; Tue, 6 Mar 2012 09:48:22 -0800 (PST) In-Reply-To: <20120307.023046.27956263.iwasaki@jp.FreeBSD.org> References: <20120306.024212.108736612.iwasaki@jp.FreeBSD.org> <201203052314.22050.bschmidt@freebsd.org> <20120307.023046.27956263.iwasaki@jp.FreeBSD.org> Date: Tue, 6 Mar 2012 09:48:22 -0800 X-Google-Sender-Auth: ajzTUrSvm8Lj45qfTCiBa9DOvfM Message-ID: From: Adrian Chadd To: Mitsuru IWASAKI Content-Type: text/plain; charset=ISO-8859-1 Cc: freebsd-current@freebsd.org, freebsd-wireless@freebsd.org, bschmidt@freebsd.org Subject: Re: patches for if_iwi and wlan for WEP mode X-BeenThere: freebsd-wireless@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussions of 802.11 stack, tools device driver development." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 06 Mar 2012 17:48:29 -0000 Hi, I'd rather you file a PR first describing what you just did, then commit the fix and close the PR. Since you've found a problem, it sounds like a great reason to open a Problem Report. :) You can then link the commit against the PR so they reference each other. I've been doing it for my ath/net80211 bugfixes, no matter how quickly I find/fix the bug. Adrian From owner-freebsd-wireless@FreeBSD.ORG Tue Mar 6 19:05:07 2012 Return-Path: Delivered-To: freebsd-wireless@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 9D12C1065670 for ; Tue, 6 Mar 2012 19:05:07 +0000 (UTC) (envelope-from bschmidt@techwires.net) Received: from mail-we0-f182.google.com (mail-we0-f182.google.com [74.125.82.182]) by mx1.freebsd.org (Postfix) with ESMTP id 14CA98FC13 for ; Tue, 6 Mar 2012 19:05:06 +0000 (UTC) Received: by werl4 with SMTP id l4so4338107wer.13 for ; Tue, 06 Mar 2012 11:05:05 -0800 (PST) Received-SPF: pass (google.com: domain of bschmidt@techwires.net designates 10.216.135.141 as permitted sender) client-ip=10.216.135.141; Authentication-Results: mr.google.com; spf=pass (google.com: domain of bschmidt@techwires.net designates 10.216.135.141 as permitted sender) smtp.mail=bschmidt@techwires.net Received: from mr.google.com ([10.216.135.141]) by 10.216.135.141 with SMTP id u13mr6746785wei.79.1331060705774 (num_hops = 1); Tue, 06 Mar 2012 11:05:05 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=sender:from:to:subject:date:user-agent:cc:references:in-reply-to :mime-version:content-type:content-transfer-encoding:message-id :x-gm-message-state; bh=fA+jnk3dGVPHulyIvYOTwjlb6rdfzRZIoQ4b/vo0itc=; b=VFSoKYuGp2u8ijaxA2MwXc0O5OCtGtXgdFIdOXxm6GI9SKl5n7hoIQtYjyY+zrN9Wt AX+uvUiHzoV5HNPimxxrSlrdvnpIfHcYvpJxL83kI/+Xv3OOQPZVGUMHH8UvjQ5+wLiF DRk3nsZoHcdZOUERgSffSwWML5745LqTIVQ3z8Xp8fcCMAW1KakLerMdMdhlMv9DKUYs IQ+EZH/3VznF1C5MfuaWiV7/EXlw/sOi2CyzEoF+DEtA0VZUuO04AK+jyXQVtnKFf+l9 XZzrBvxwezWmBmwosAFn49EEeveh6dXcjmsCHRleAFaFaEO768sJ36fxTQzjBzWc99eT bJJA== Received: by 10.216.135.141 with SMTP id u13mr5428843wei.79.1331060705661; Tue, 06 Mar 2012 11:05:05 -0800 (PST) Received: from amy.lab.techwires.net (dslb-088-065-215-057.pools.arcor-ip.net. [88.65.215.57]) by mx.google.com with ESMTPS id df3sm30222699wib.1.2012.03.06.11.05.01 (version=SSLv3 cipher=OTHER); Tue, 06 Mar 2012 11:05:05 -0800 (PST) Sender: Bernhard Schmidt From: Bernhard Schmidt To: Mitsuru IWASAKI Date: Tue, 6 Mar 2012 20:05:15 +0100 User-Agent: KMail/1.13.7 (FreeBSD/9.0-STABLE; KDE/4.7.4; amd64; ; ) References: <20120306.024212.108736612.iwasaki@jp.FreeBSD.org> <201203052314.22050.bschmidt@freebsd.org> <20120307.023046.27956263.iwasaki@jp.FreeBSD.org> In-Reply-To: <20120307.023046.27956263.iwasaki@jp.FreeBSD.org> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201203062005.15276.bschmidt@freebsd.org> X-Gm-Message-State: ALoCoQnjeZTisBSmeuGltkOkbQ8olvs41Hg/HV0G+LXSATXaMoTNuSmR4aUIHhbZ5hKkXqtpRe5N Cc: freebsd-current@freebsd.org, freebsd-wireless@freebsd.org Subject: Re: patches for if_iwi and wlan for WEP mode X-BeenThere: freebsd-wireless@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussions of 802.11 stack, tools device driver development." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 06 Mar 2012 19:05:07 -0000 On Tuesday 06 March 2012 18:30:46 Mitsuru IWASAKI wrote: > Thanks Bernhard and Adrian, I think the problem seems to be solved. > > > > My patches set IEEE80211_NODE_ASSOCID bit only if ni->ni_associd > > > is set. Any suggestions on this part are welcome. > > > > Are you sure the net80211 part is correct? It looks to me as if you > > are just masking the real issue. The IEEE80211_NODE_ASSOCID flag is > > ment to be used to verify that an associd has actually been set, not > > doing so will break other things I guess. iwi(4) is a bit tricky in > > that regard, as it sets the associd itself, check iwi_checkforqos(). > > I'd verify that function is actually called and if so if the parameters > > are correct. I fumbled around there once, might have wrong WEP.. > > As you suggested, iwi_checkforqos() has problems, wrong asresp > frame parsing. > > ---- > @@ -1357,8 +1365,8 @@ > frm += 2; > > wme = NULL; > - while (frm < efrm) { > - IEEE80211_VERIFY_LENGTH(efrm - frm, frm[1], return); > + while (efrm - frm > 1) { > + IEEE80211_VERIFY_LENGTH(efrm - frm, frm[1] + 2, return); > switch (*frm) { > case IEEE80211_ELEMID_VENDOR: > if (iswmeoui(frm)) > ---- > > Bacause of the condition `while (frm < efrm)', > IEEE80211_VERIFY_LENGTH() was checking item length beyond the > ieee80211_frame region, and returned from iwi_checkforqos() without > setting flags, capinfo and associd! > I made above changes referring to net80211 code such as > ieee80211_sta.c. > > Today's version of patches at: > http://people.freebsd.org/~iwasaki/iwi/iwi-20120306.diff > > This one don't have changes on net80211 part at all. Looks good to me, please get that into the tree. > > What's the reason behing adding if_qflush()/if_transmit()? > > In RELENG_7, data frame is transmitted by iwi_tx_start() like this. > > ether_output > ether_output_frame > IFQ_HANDOFF/IFQ_HANDOFF_ADJ > if_start > iwi_start > iwi_tx_start > > After 8.0-RELEASE, device specific if_transmit() is called via net80211 layer. > > ether_output > ether_output_frame > if_transmit > IFQ_HANDOFF/IFQ_HANDOFF_ADJ > if_start > ieee80211_start > parent->if_transmit(ie. iwi_transmit()) > > There was not if_transmit method in iwi(4), so I add it. > On if_qflush(), CURRENT kernel complains that `transmit and qflush > must both either be set or both be NULL' from if.c. > I wrote iwi_qflush(), but actually never tested it... Hmm, it still is the case for >= 8 afaik, there is a default if_transmit() which is used for all wireless drivers which seems to work pretty well. That's why I'm wondering, iwi(4) would be the first driver to have it's own if_transmit() function. I'm not aware of any technical reason for adding one, or did I miss something? If not I'd rather not have one added, for sake of consistency. > From: Adrian Chadd > > Would you please open a PR with this particular issue and then attach > > the patch to it? > > I prefer committing changes on iwi(4) by myself, because grimreaper@ > keep giving pressure to me `Your src commit bit is still idle.' for > long time :) > I just want to stop it. ;) -- Bernhard From owner-freebsd-wireless@FreeBSD.ORG Tue Mar 6 20:12:57 2012 Return-Path: Delivered-To: freebsd-wireless@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 1595A1065679; Tue, 6 Mar 2012 20:12:57 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Received: from mail-we0-f182.google.com (mail-we0-f182.google.com [74.125.82.182]) by mx1.freebsd.org (Postfix) with ESMTP id 475878FC29; Tue, 6 Mar 2012 20:12:55 +0000 (UTC) Received: by werl4 with SMTP id l4so4389245wer.13 for ; Tue, 06 Mar 2012 12:12:55 -0800 (PST) Received-SPF: pass (google.com: domain of adrian.chadd@gmail.com designates 10.180.85.69 as permitted sender) client-ip=10.180.85.69; Authentication-Results: mr.google.com; spf=pass (google.com: domain of adrian.chadd@gmail.com designates 10.180.85.69 as permitted sender) smtp.mail=adrian.chadd@gmail.com; dkim=pass header.i=adrian.chadd@gmail.com Received: from mr.google.com ([10.180.85.69]) by 10.180.85.69 with SMTP id f5mr26625069wiz.18.1331064775395 (num_hops = 1); Tue, 06 Mar 2012 12:12:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=h9UBg5vjAHop1HuH9oml5K0R3u9LxjGSxcFWluMGNGI=; b=k7EyCV0J73py7V9VKDJ8nYrkx5iwArvBKsj8PolvJr3b/yUcAauYrKC5sgq18UkOkf EMZUK2q40kpwKhyKFRCj+sZOe0J8rHso6p3GYktJX/WjwnEX+CevZ87EsN9+2Ifbpy2Q pMu1Qsn7q0SrKvBW/EDcBOFIGTbnftzt1kO8KDYiwPJOCT/SXxq4zheQewWRziGTWe1v v0p6z9NJs0qg7duTZqdpPnhz3C3dqvU3rXDyEreUCw53mHqARb7MTe9T3uBBaKXkwf+L J36Q4BT1+9MvPrEr3FcuBOpgNvxJOsNFGqJpOrE7mTMC7Uo02vzwJ16powTxnTphBPyo svgg== MIME-Version: 1.0 Received: by 10.180.85.69 with SMTP id f5mr21087563wiz.18.1331064775193; Tue, 06 Mar 2012 12:12:55 -0800 (PST) Sender: adrian.chadd@gmail.com Received: by 10.216.198.81 with HTTP; Tue, 6 Mar 2012 12:12:55 -0800 (PST) In-Reply-To: <201203062005.15276.bschmidt@freebsd.org> References: <20120306.024212.108736612.iwasaki@jp.FreeBSD.org> <201203052314.22050.bschmidt@freebsd.org> <20120307.023046.27956263.iwasaki@jp.FreeBSD.org> <201203062005.15276.bschmidt@freebsd.org> Date: Tue, 6 Mar 2012 12:12:55 -0800 X-Google-Sender-Auth: PM46MTeTZNVa05vAfUDYlOfrzWg Message-ID: From: Adrian Chadd To: Bernhard Schmidt Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: freebsd-current@freebsd.org, Mitsuru IWASAKI , freebsd-wireless@freebsd.org Subject: Re: patches for if_iwi and wlan for WEP mode X-BeenThere: freebsd-wireless@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussions of 802.11 stack, tools device driver development." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 06 Mar 2012 20:12:57 -0000 .. except that the default if_transmit handling breaks fragments. Sigh. So we're going to have to implement if_transmit for all net80211 drivers soon and fix fragment handling. Adrian On 6 March 2012 11:05, Bernhard Schmidt wrote: > On Tuesday 06 March 2012 18:30:46 Mitsuru IWASAKI wrote: >> Thanks Bernhard and Adrian, I think the problem seems to be solved. >> >> > > My patches set IEEE80211_NODE_ASSOCID bit only if ni->ni_associd >> > > is set. =A0Any suggestions on this part are welcome. >> > >> > Are you sure the net80211 part is correct? It looks to me as if you >> > are just masking the real issue. The IEEE80211_NODE_ASSOCID flag is >> > ment to be used to verify that an associd has actually been set, not >> > doing so will break other things I guess. iwi(4) is a bit tricky in >> > that regard, as it sets the associd itself, check iwi_checkforqos(). >> > I'd verify that function is actually called and if so if the parameter= s >> > are correct. I fumbled around there once, might have wrong WEP.. >> >> As you suggested, iwi_checkforqos() has problems, wrong asresp >> frame parsing. >> >> ---- >> @@ -1357,8 +1365,8 @@ >> =A0 =A0 =A0 frm +=3D 2; >> >> =A0 =A0 =A0 wme =3D NULL; >> - =A0 =A0 while (frm < efrm) { >> - =A0 =A0 =A0 =A0 =A0 =A0 IEEE80211_VERIFY_LENGTH(efrm - frm, frm[1], re= turn); >> + =A0 =A0 while (efrm - frm > 1) { >> + =A0 =A0 =A0 =A0 =A0 =A0 IEEE80211_VERIFY_LENGTH(efrm - frm, frm[1] + 2= , return); >> =A0 =A0 =A0 =A0 =A0 =A0 =A0 switch (*frm) { >> =A0 =A0 =A0 =A0 =A0 =A0 =A0 case IEEE80211_ELEMID_VENDOR: >> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 if (iswmeoui(frm)) >> ---- >> >> Bacause of the condition `while (frm < efrm)', >> IEEE80211_VERIFY_LENGTH() was checking item length beyond the >> ieee80211_frame region, and returned from iwi_checkforqos() without >> setting flags, capinfo and associd! >> I made above changes referring to net80211 code such as >> ieee80211_sta.c. >> >> Today's version of patches at: >> http://people.freebsd.org/~iwasaki/iwi/iwi-20120306.diff >> >> This one don't have changes on net80211 part at all. > > Looks good to me, please get that into the tree. > >> > What's the reason behing adding if_qflush()/if_transmit()? >> >> In RELENG_7, data frame is transmitted by iwi_tx_start() like this. >> >> =A0 ether_output >> =A0 =A0 ether_output_frame >> =A0 =A0 =A0 IFQ_HANDOFF/IFQ_HANDOFF_ADJ >> =A0 =A0 =A0 =A0 if_start >> =A0 =A0 =A0 =A0 =A0 iwi_start >> =A0 =A0 =A0 =A0 =A0 =A0 iwi_tx_start >> >> After 8.0-RELEASE, device specific if_transmit() is called via net80211 = layer. >> >> =A0 ether_output >> =A0 =A0 ether_output_frame >> =A0 =A0 =A0 if_transmit >> =A0 =A0 =A0 =A0 IFQ_HANDOFF/IFQ_HANDOFF_ADJ >> =A0 =A0 =A0 =A0 =A0 if_start >> =A0 =A0 =A0 =A0 =A0 =A0 ieee80211_start >> =A0 =A0 =A0 =A0 =A0 =A0 =A0 parent->if_transmit(ie. iwi_transmit()) >> >> There was not if_transmit method in iwi(4), so I add it. >> On if_qflush(), CURRENT kernel complains that `transmit and qflush >> must both either be set or both be NULL' from if.c. >> I wrote iwi_qflush(), but actually never tested it... > > Hmm, it still is the case for >=3D 8 afaik, there is a default > if_transmit() which is used for all wireless drivers which seems to > work pretty well. That's why I'm wondering, iwi(4) would be the first > driver to have it's own if_transmit() function. I'm not aware of any > technical reason for adding one, or did I miss something? If not I'd > rather not have one added, for sake of consistency. > >> From: Adrian Chadd >> > Would you please open a PR with this particular issue and then attach >> > the patch to it? >> >> I prefer committing changes on iwi(4) by myself, because grimreaper@ >> keep giving pressure to me `Your src commit bit is still idle.' for >> long time :) >> I just want to stop it. > > ;) > > -- > Bernhard From owner-freebsd-wireless@FreeBSD.ORG Wed Mar 7 13:30:36 2012 Return-Path: Delivered-To: freebsd-wireless@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id A3192106566C for ; Wed, 7 Mar 2012 13:30:36 +0000 (UTC) (envelope-from jhugo@meraka.csir.co.za) Received: from marge.meraka.csir.co.za (marge.meraka.csir.co.za [IPv6:2001:4200:7000:3::1]) by mx1.freebsd.org (Postfix) with ESMTP id 3DB038FC14 for ; Wed, 7 Mar 2012 13:30:34 +0000 (UTC) Received: from jeep.localnet (unknown [IPv6:2001:4200:7000:3:223:aeff:fea7:a3c2]) by marge.meraka.csir.co.za (Postfix) with ESMTP id D82DCD0CC03 for ; Wed, 7 Mar 2012 15:30:32 +0200 (SAST) Resent-From: Johann Hugo Resent-To: freebsd-wireless@freebsd.org Resent-Date: Wed, 7 Mar 2012 15:30:32 +0200 Resent-Message-ID: <201203071530.32330.jhugo@meraka.csir.co.za> From: Johann Hugo To: Adrian Chadd Date: Wed, 7 Mar 2012 14:39:01 +0200 User-Agent: KMail/1.13.7 (FreeBSD/9.0-RELEASE; KDE/4.7.3; amd64; ; ) References: <201202281639.05140.jhugo@meraka.csir.co.za> <201203061258.16786.jhugo@meraka.csir.co.za> In-Reply-To: X-KMail-Markup: true MIME-Version: 1.0 Content-Type: Multipart/Mixed; boundary="Boundary-00=_lb1VPMasuW8zRQA" Message-Id: <201203071439.01993.jhugo@meraka.csir.co.za> X-Content-Filtered-By: Mailman/MimeDel 2.1.5 Cc: Subject: Re: performance in adhoc mode X-BeenThere: freebsd-wireless@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussions of 802.11 stack, tools device driver development." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Mar 2012 13:30:36 -0000 --Boundary-00=_lb1VPMasuW8zRQA Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit On Tuesday 06 March 2012 18:19:21 Adrian Chadd wrote: > Can you please try 8.0-REL too? We have a wireless (olsr) mesh and we recently moved it from 7.2 to 9.0, skipping 8. I've just installed 8.0 on my two test nodes in the lab and got more or less the same results as with 9. FreeBSD 8.0-STABLE #10: Sun Feb 7 20:16:49 SAST 2010 Adhoc mode: nodeA iperf = 21.3 Mbits/sec NodeB iperf = 21.5 Mbits/sec AP/client mode NodeA iperf = 27.0 Mbits/sec NodeB iperf = 27.0 Mbits/sec Johann > > > adrian > > On 6 March 2012 02:58, Johann Hugo wrote: > > On Wednesday 29 February 2012 19:48:53 you wrote: > >> Ok, long_retry means that the hardware had to try more times to get > >> > >> the frame out. > >> > >> > >> > >> Either it's picking too high a rate, or the ACKs can't be heard. > > > > Should be ok, they are one meter apart. > > > >> I wonder what changes in the MAC and driver when we flip on adhoc > >> > >> mode. I know it changes how the beacon queue is handled, I didn't > >> > >> think anything else changed.. > >> > >> > >> > >> Can you try forcing a lower rate on both ends (ifconfig wlanX > >> > >> ucastrate Y) and do your tests? > > > > Are the parameters that one get with (ifconfig -m wlanX) still valid ? > > > > > > > > See attached for tests. > > > > > > > > B.t.w. I get better performance with our old FreeBSD-7.2 distro in adhoc > > mode than with our new FreeBSD-9.0 distro on the same hardware. > > > > > > > > FreeBSD-7.2 > > > > NodeA: iperf = 25.1 Mbits/sec > > > > NodeB: iperf = 25.2 Mbits/sec > > > > > > > > FreeBSD-9.0 > > > > NodeA: iperf = 20.5 Mbits/sec > > > > NodeB: iperf =20.8 Mbits/sec > > > >> Please file a PR with this. :) > > > > Will do so. > > > > > > > > Regards > > > > Johann > > > >> Thanks! > >> > >> > >> > >> > >> > >> Adrian > >> > >> On 29 February 2012 01:51, Johann Hugo wrote: > >> > On Tuesday 28 February 2012 17:50:39 Adrian Chadd wrote: > >> >> I've not looked into adhoc _at all_. > >> > > >> > please_do > >> > > >> >> I'd start by looking at the behaviour of the rate control code - do > >> >> > >> >> > >> >> > >> >> 'sysctl dev.ath.X sample_stats=1' after you've done some traffic and > >> >> > >> >> > >> >> > >> >> check dmesg. > >> >> > >> >> > >> >> > >> >> > >> >> > >> >> > >> >> > >> >> Just ensure that the same rates are being used and the error rate is > >> >> > >> >> low. > >> > > >> > The rates differ a bit and also some of the dev.ath.0 sysctl's. > >> > > >> > dev.ath.0.stats.ast_tx_longretry is more than double in adhoc mode. > >> > > >> > > >> > > >> > > >> > > >> > > >> > > >> > Johann --Boundary-00=_lb1VPMasuW8zRQA Content-Type: text/plain; charset="UTF-8"; name="FreeBSD-8-tests.txt" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="FreeBSD-8-tests.txt" FreeBSD mesh-2893 8.0-STABLE FreeBSD 8.0-STABLE #10: Sun Feb 7 20:16:49 SAST 2010 nodeA iperf = 21.3 Mbits/sec mesh-2893:/var/db/pkg # sysctl dev.ath.0.sample_stats=1 dev.ath.0.sample_stats: 0 [00:80:48:4f:28:93] refcnt 4 static_rix 0 ratemask 0x0 [ 250] cur rix 0 since switch: packets 0 ticks 0 [ 250] last sample 0 cur sample 0 packets sent 0 [ 250] packets since sample 0 sample tt 0 [1600] cur rix 0 since switch: packets 0 ticks 0 [1600] last sample 0 cur sample 0 packets sent 0 [1600] packets since sample 0 sample tt 0 [00:80:48:4f:28:70] refcnt 3 static_rix -1 ratemask 0xff [ 250] cur rix 5 since switch: packets 1216 ticks 144811 [ 250] last sample 6 cur sample -1 packets sent 25295 [ 250] packets since sample 6 sample tt 448 [1600] cur rix 0 since switch: packets 0 ticks 0 [1600] last sample 0 cur sample -1 packets sent 0 [1600] packets since sample 0 sample tt 0 [ 6: 250] 1:1 (100%) T 1 F 0 avg 760 last 28755 [ 9: 250] 12:12 (100%) T 13 F 0 avg 722 last 28451 [12: 250] 67:67 (100%) T 81 F 0 avg 751 last 28356 [18: 250] 243:243 (100%) T 275 F 0 avg 667 last 28346 [24: 250] 2739:2737 ( 99%) T 3097 F 0 avg 507 last 28343 [24:1600] 2:0 ( 0%) T 10 F 2 avg 940 last 29173 [36: 250] 6338:6338 (100%) T 7116 F 0 avg 490 last 28343 [48: 250] 7427:7426 ( 99%) T 8300 F 0 avg 664 last 28344 [48:1600] 1:0 ( 0%) T 5 F 1 avg 672 last 28886 [54: 250] 8472:8471 ( 99%) T 9463 F 0 avg 495 last 28347 [54:1600] 1:0 ( 0%) T 5 F 1 avg 644 last 47852 NodeB iperf = 21.5 Mbits/sec mesh-2870:~ # sysctl dev.ath.0.sample_stats=1 dev.ath.0.sample_stats: 0 [00:80:48:4f:28:70] refcnt 4 static_rix 0 ratemask 0x0 [ 250] cur rix 0 since switch: packets 0 ticks 0 [ 250] last sample 0 cur sample 0 packets sent 0 [ 250] packets since sample 0 sample tt 0 [1600] cur rix 0 since switch: packets 0 ticks 0 [1600] last sample 0 cur sample 0 packets sent 0 [1600] packets since sample 0 sample tt 0 [00:80:48:4f:28:93] refcnt 3 static_rix -1 ratemask 0xff [ 250] cur rix 7 since switch: packets 1 ticks 28012 [ 250] last sample 0 cur sample -1 packets sent 9 [ 250] packets since sample 9 sample tt 0 [1600] cur rix 7 since switch: packets 1558 ticks 27917 [1600] last sample 6 cur sample -1 packets sent 36287 [1600] packets since sample 0 sample tt 672 [18:1600] 1:1 (100%) T 1 F 0 avg 1124 last 58722 [24:1600] 9:9 (100%) T 10 F 0 avg 1072 last 39726 [36: 250] 1:1 (100%) T 1 F 0 avg 464 last 59433 [36:1600] 418:418 (100%) T 457 F 0 avg 859 last 39338 [48:1600] 20590:20590 (100%) T 22300 F 0 avg 744 last 39336 [54: 250] 8:8 (100%) T 8 F 0 avg 444 last 39335 [54:1600] 15270:15269 ( 99%) T 16876 F 0 avg 664 last 39337 --------------------------------------------------------------- AP/ client mode: --------------------------------------------------------------- NodeA iperf = 27.0 Mbits/sec mesh-2893:~ # sysctl dev.ath.0.sample_stats=1 dev.ath.0.sample_stats: 0 [00:80:48:4f:28:93] refcnt 4 static_rix 0 ratemask 0x0 [ 250] cur rix 0 since switch: packets 0 ticks 0 [ 250] last sample 0 cur sample 0 packets sent 0 [ 250] packets since sample 0 sample tt 0 [1600] cur rix 0 since switch: packets 0 ticks 0 [1600] last sample 0 cur sample 0 packets sent 0 [1600] packets since sample 0 sample tt 0 [00:80:48:4f:28:70] refcnt 3 static_rix -1 ratemask 0xff [ 250] cur rix 7 since switch: packets 1340 ticks 14608 [ 250] last sample 5 cur sample -1 packets sent 14895 [ 250] packets since sample 15 sample tt 464 [1600] cur rix 0 since switch: packets 0 ticks 0 [1600] last sample 0 cur sample -1 packets sent 0 [1600] packets since sample 0 sample tt 0 [ 6: 250] 1:1 (100%) T 1 F 0 avg 760 last 12719 [18: 250] 3:3 (100%) T 3 F 0 avg 524 last 727 [24: 250] 1:1 (100%) T 1 F 0 avg 492 last 863 [36: 250] 89:89 (100%) T 90 F 0 avg 464 last 472 [48: 250] 2996:2996 (100%) T 3055 F 0 avg 448 last 474 [54: 250] 11806:11806 (100%) T 12032 F 0 avg 453 last 470 mesh-2893:~ # sysctl dev.ath.0 dev.ath.0.%desc: Atheros 5413 dev.ath.0.%driver: ath dev.ath.0.%location: slot=1 function=0 dev.ath.0.%pnpinfo: vendor=0x168c device=0x001b subvendor=0x168c subdevice=0x2063 class=0x020000 dev.ath.0.%parent: pci0 dev.ath.0.smoothing_rate: 95 dev.ath.0.sample_rate: 10 dev.ath.0.sample_stats: 0 dev.ath.0.countrycode: 0 dev.ath.0.regdomain: 0 dev.ath.0.slottime: 9 dev.ath.0.acktimeout: 25 dev.ath.0.ctstimeout: 25 dev.ath.0.softled: 0 dev.ath.0.ledpin: 0 dev.ath.0.ledon: 0 dev.ath.0.ledidle: 270 dev.ath.0.txantenna: 1 dev.ath.0.rxantenna: 1 dev.ath.0.diversity: 0 dev.ath.0.txintrperiod: 5 dev.ath.0.diag: 0 dev.ath.0.tpscale: 0 dev.ath.0.tpc: 0 dev.ath.0.tpack: 63 dev.ath.0.tpcts: 63 dev.ath.0.intmit: 1 dev.ath.0.monpass: 24 dev.ath.0.dbaprep: 2 dev.ath.0.swbaprep: 10 dev.ath.0.guardtime: 0 dev.ath.0.superframe: 0 dev.ath.0.setcca: 0 NodeB: iperf = 27.0 Mbits/sec mesh-2870:~ # sysctl dev.ath.0.sample_stats=1 dev.ath.0.sample_stats: 0 [00:80:48:4f:28:93] refcnt 4 static_rix -1 ratemask 0xff [ 250] cur rix 7 since switch: packets 1 ticks 14179 [ 250] last sample 0 cur sample -1 packets sent 6 [ 250] packets since sample 6 sample tt 0 [1600] cur rix 7 since switch: packets 2106 ticks 14084 [1600] last sample 6 cur sample -1 packets sent 23377 [1600] packets since sample 19 sample tt 672 [36: 250] 1:1 (100%) T 1 F 0 avg 464 last 12893 [36:1600] 5:5 (100%) T 5 F 0 avg 764 last 975 [48:1600] 430:430 (100%) T 435 F 0 avg 672 last 646 [54: 250] 5:5 (100%) T 5 F 0 avg 444 last 644 [54:1600] 22942:22942 (100%) T 23497 F 0 avg 688 last 645 mesh-2870:~ # sysctl dev.ath.0 dev.ath.0.%desc: Atheros 5413 dev.ath.0.%driver: ath dev.ath.0.%location: slot=1 function=0 dev.ath.0.%pnpinfo: vendor=0x168c device=0x001b subvendor=0x168c subdevice=0x2063 class=0x020000 dev.ath.0.%parent: pci0 dev.ath.0.smoothing_rate: 95 dev.ath.0.sample_rate: 10 dev.ath.0.sample_stats: 0 dev.ath.0.countrycode: 0 dev.ath.0.regdomain: 0 dev.ath.0.slottime: 9 dev.ath.0.acktimeout: 25 dev.ath.0.ctstimeout: 25 dev.ath.0.softled: 0 dev.ath.0.ledpin: 0 dev.ath.0.ledon: 0 dev.ath.0.ledidle: 270 dev.ath.0.txantenna: 1 dev.ath.0.rxantenna: 1 dev.ath.0.diversity: 0 dev.ath.0.txintrperiod: 5 dev.ath.0.diag: 0 dev.ath.0.tpscale: 0 dev.ath.0.tpc: 0 dev.ath.0.tpack: 63 dev.ath.0.tpcts: 63 dev.ath.0.intmit: 1 dev.ath.0.monpass: 24 dev.ath.0.dbaprep: 2 dev.ath.0.swbaprep: 10 dev.ath.0.guardtime: 0 dev.ath.0.superframe: 0 dev.ath.0.setcca: 0 --Boundary-00=_lb1VPMasuW8zRQA-- From owner-freebsd-wireless@FreeBSD.ORG Wed Mar 7 15:23:52 2012 Return-Path: Delivered-To: freebsd-wireless@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id AD8F1106564A; Wed, 7 Mar 2012 15:23:52 +0000 (UTC) (envelope-from iwasaki@jp.FreeBSD.org) Received: from locore.org (ns01.locore.org [218.45.21.227]) by mx1.freebsd.org (Postfix) with ESMTP id 3EAF78FC1B; Wed, 7 Mar 2012 15:23:52 +0000 (UTC) Received: from localhost (celeron.v4.locore.org [192.168.0.10]) by locore.org (8.14.5/8.14.5/iwasaki) with ESMTP/inet id q27FNobV022225; Thu, 8 Mar 2012 00:23:50 +0900 (JST) (envelope-from iwasaki@jp.FreeBSD.org) Date: Thu, 08 Mar 2012 00:23:49 +0900 (JST) Message-Id: <20120308.002349.126757388.iwasaki@jp.FreeBSD.org> To: adrian@freebsd.org From: Mitsuru IWASAKI In-Reply-To: References: <20120307.023046.27956263.iwasaki@jp.FreeBSD.org> X-Mailer: Mew version 3.3 on Emacs 20.7 / Mule 4.0 (HANANOEN) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: freebsd-current@freebsd.org, freebsd-wireless@freebsd.org, bschmidt@freebsd.org Subject: Re: patches for if_iwi and wlan for WEP mode X-BeenThere: freebsd-wireless@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussions of 802.11 stack, tools device driver development." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Mar 2012 15:23:52 -0000 > I'd rather you file a PR first describing what you just did, then > commit the fix and close the PR. OK, I've just submitted a PR. I'll follow the procedure you suggested. http://www.freebsd.org/cgi/query-pr.cgi?pr=kern/165819 Thanks From owner-freebsd-wireless@FreeBSD.ORG Wed Mar 7 15:38:47 2012 Return-Path: Delivered-To: freebsd-wireless@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 0C0AF106566C; Wed, 7 Mar 2012 15:38:47 +0000 (UTC) (envelope-from iwasaki@jp.FreeBSD.org) Received: from locore.org (ns01.locore.org [218.45.21.227]) by mx1.freebsd.org (Postfix) with ESMTP id 926078FC0C; Wed, 7 Mar 2012 15:38:45 +0000 (UTC) Received: from localhost (celeron.v4.locore.org [192.168.0.10]) by locore.org (8.14.5/8.14.5/iwasaki) with ESMTP/inet id q27Fcigv022293; Thu, 8 Mar 2012 00:38:44 +0900 (JST) (envelope-from iwasaki@jp.FreeBSD.org) Date: Thu, 08 Mar 2012 00:38:44 +0900 (JST) Message-Id: <20120308.003844.08316346.iwasaki@jp.FreeBSD.org> To: bschmidt@freebsd.org From: Mitsuru IWASAKI In-Reply-To: <201203062005.15276.bschmidt@freebsd.org> References: <201203052314.22050.bschmidt@freebsd.org> <20120307.023046.27956263.iwasaki@jp.FreeBSD.org> <201203062005.15276.bschmidt@freebsd.org> X-Mailer: Mew version 3.3 on Emacs 20.7 / Mule 4.0 (HANANOEN) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: freebsd-current@freebsd.org, freebsd-wireless@freebsd.org Subject: Re: patches for if_iwi and wlan for WEP mode X-BeenThere: freebsd-wireless@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussions of 802.11 stack, tools device driver development." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Mar 2012 15:38:47 -0000 > > In RELENG_7, data frame is transmitted by iwi_tx_start() like this. > > > > ether_output > > ether_output_frame > > IFQ_HANDOFF/IFQ_HANDOFF_ADJ > > if_start > > iwi_start > > iwi_tx_start > > > > After 8.0-RELEASE, device specific if_transmit() is called via net80211 layer. > > > > ether_output > > ether_output_frame > > if_transmit > > IFQ_HANDOFF/IFQ_HANDOFF_ADJ > > if_start > > ieee80211_start > > parent->if_transmit(ie. iwi_transmit()) > > > > There was not if_transmit method in iwi(4), so I add it. > > On if_qflush(), CURRENT kernel complains that `transmit and qflush > > must both either be set or both be NULL' from if.c. > > I wrote iwi_qflush(), but actually never tested it... > > Hmm, it still is the case for >= 8 afaik, there is a default > if_transmit() which is used for all wireless drivers which seems to > work pretty well. That's why I'm wondering, iwi(4) would be the first > driver to have it's own if_transmit() function. I'm not aware of any > technical reason for adding one, or did I miss something? If not I'd > rather not have one added, for sake of consistency. By your this comment, I noticed that my understanding on iwi_start() call stack > 8.0 was wrong a bit, correct one is like this; ether_output ether_output_frame if_transmit IFQ_HANDOFF/IFQ_HANDOFF_ADJ if_start ieee80211_start parent->if_transmit(ie. if_transmit()) IFQ_HANDOFF/IFQ_HANDOFF_ADJ if_start iwi_start iwi_start_locked iwi_tx_start So iwi_transmit and iwi_qflush would not be necessary. Today's version of patches at: http://people.freebsd.org/~iwasaki/iwi/iwi-20120307.diff This would be the final version I hope. Thanks! From owner-freebsd-wireless@FreeBSD.ORG Wed Mar 7 18:45:14 2012 Return-Path: Delivered-To: freebsd-wireless@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 820291065672; Wed, 7 Mar 2012 18:45:14 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Received: from mail-we0-f182.google.com (mail-we0-f182.google.com [74.125.82.182]) by mx1.freebsd.org (Postfix) with ESMTP id AEABB8FC13; Wed, 7 Mar 2012 18:45:12 +0000 (UTC) Received: by werl4 with SMTP id l4so5281850wer.13 for ; Wed, 07 Mar 2012 10:45:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type; bh=vZJLp3zUzmD+Cur6UNk7ly3yxIzO5jTF6+XWtELSo6c=; b=T/0wT1WW+gBoH2FxCbaHNAFZ40F/NR2w0NJaXEGdnUuTLv/iIG2rsCD/8HXwzDuE4u ghWSV1Fa+Dg25+y2MbuxO+VCX9LF2hg5G1w+JPurvylNPVYzIowx85ptuYGJLlXdUPJ7 WW8GzHG8SDjQizn77RHlBH3TPJmTuQ7Q7spvjYIqYEeX7Bok7Mlq/4SHEpWH6fJB0FlR mDizAUfkoSNSRQM6RUiub8HoEhyqi5cTTS32ueddil98S1wZv+keY4Mq/UqRJzA+y7fH 9SAZDvoGQ8fXPEupZhTwdHyJzp6mQ/oXyGG325AtgGuJ0FKYLwfVIymokQKDC2Q+WwlC QBUQ== MIME-Version: 1.0 Received: by 10.180.96.8 with SMTP id do8mr28227482wib.21.1331145911774; Wed, 07 Mar 2012 10:45:11 -0800 (PST) Sender: adrian.chadd@gmail.com Received: by 10.216.198.81 with HTTP; Wed, 7 Mar 2012 10:45:11 -0800 (PST) In-Reply-To: <20120308.003844.08316346.iwasaki@jp.FreeBSD.org> References: <201203052314.22050.bschmidt@freebsd.org> <20120307.023046.27956263.iwasaki@jp.FreeBSD.org> <201203062005.15276.bschmidt@freebsd.org> <20120308.003844.08316346.iwasaki@jp.FreeBSD.org> Date: Wed, 7 Mar 2012 10:45:11 -0800 X-Google-Sender-Auth: PK0IEVcb8RFMaOC6Pdp60IJOZaE Message-ID: From: Adrian Chadd To: Mitsuru IWASAKI Content-Type: text/plain; charset=ISO-8859-1 Cc: freebsd-current@freebsd.org, freebsd-wireless@freebsd.org, bschmidt@freebsd.org Subject: Re: patches for if_iwi and wlan for WEP mode X-BeenThere: freebsd-wireless@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussions of 802.11 stack, tools device driver development." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Mar 2012 18:45:14 -0000 Hi, I'd rather you didn't commit iwi_update_mcast() unless you absolutely know that the NIC doesn't need to be notified of multicast group membership changes. If so, please commit that as a separate fix. I'll look at iwi later and give you feedback on that particular change. Thanks for chasing this down! Adrian From owner-freebsd-wireless@FreeBSD.ORG Wed Mar 7 19:11:30 2012 Return-Path: Delivered-To: freebsd-wireless@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C5ABA1065672 for ; Wed, 7 Mar 2012 19:11:30 +0000 (UTC) (envelope-from bschmidt@techwires.net) Received: from mail-ey0-f182.google.com (mail-ey0-f182.google.com [209.85.215.182]) by mx1.freebsd.org (Postfix) with ESMTP id 594C68FC19 for ; Wed, 7 Mar 2012 19:11:30 +0000 (UTC) Received: by eaaf13 with SMTP id f13so2492401eaa.13 for ; Wed, 07 Mar 2012 11:11:29 -0800 (PST) Received: by 10.14.28.199 with SMTP id g47mr1438845eea.16.1331147489156; Wed, 07 Mar 2012 11:11:29 -0800 (PST) Received: from amy.lab.techwires.net (dslb-088-065-223-042.pools.arcor-ip.net. [88.65.223.42]) by mx.google.com with ESMTPS id h47sm26160550eea.10.2012.03.07.11.11.26 (version=SSLv3 cipher=OTHER); Wed, 07 Mar 2012 11:11:28 -0800 (PST) Sender: Bernhard Schmidt From: Bernhard Schmidt To: Mitsuru IWASAKI Date: Wed, 7 Mar 2012 20:11:39 +0100 User-Agent: KMail/1.13.7 (FreeBSD/9.0-STABLE; KDE/4.7.4; amd64; ; ) References: <201203052314.22050.bschmidt@freebsd.org> <201203062005.15276.bschmidt@freebsd.org> <20120308.003844.08316346.iwasaki@jp.FreeBSD.org> In-Reply-To: <20120308.003844.08316346.iwasaki@jp.FreeBSD.org> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201203072011.40102.bschmidt@freebsd.org> X-Gm-Message-State: ALoCoQn142MlvB5OH+0KP6C+OOP7whhtbpRc9uC+1Q8ls4die3B7GL8I4wceDF/tWrQ2UH50KoHV Cc: freebsd-current@freebsd.org, freebsd-wireless@freebsd.org Subject: Re: patches for if_iwi and wlan for WEP mode X-BeenThere: freebsd-wireless@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussions of 802.11 stack, tools device driver development." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Mar 2012 19:11:30 -0000 On Wednesday 07 March 2012 16:38:44 Mitsuru IWASAKI wrote: > So iwi_transmit and iwi_qflush would not be necessary. correct > Today's version of patches at: > http://people.freebsd.org/~iwasaki/iwi/iwi-20120307.diff > > This would be the final version I hope. I gave it a quick spin, works for me. You can add "Tested/Reviewed by: bschmidt" if you like. Thanks! -- Bernhard From owner-freebsd-wireless@FreeBSD.ORG Wed Mar 7 19:17:32 2012 Return-Path: Delivered-To: freebsd-wireless@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 1C1FA1065672 for ; Wed, 7 Mar 2012 19:17:32 +0000 (UTC) (envelope-from bschmidt@techwires.net) Received: from mail-ee0-f54.google.com (mail-ee0-f54.google.com [74.125.83.54]) by mx1.freebsd.org (Postfix) with ESMTP id 9AC5C8FC16 for ; Wed, 7 Mar 2012 19:17:31 +0000 (UTC) Received: by eekd17 with SMTP id d17so2592645eek.13 for ; Wed, 07 Mar 2012 11:17:30 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=sender:from:to:subject:date:user-agent:cc:references:in-reply-to :mime-version:content-type:content-transfer-encoding:message-id :x-gm-message-state; bh=veWY2QvanRFb35nDDcBSTCbw1WxGrA1/Q/CqMp8GW4c=; b=BZLG/ecLn0660RJuCuKmTgJCCrQkc96gfe1qLK2nBuMxZhaVbNtskTfNMLJxy0ouCo 3SX3g9fqMHYQ/nH/2fvSlX8M4KOsws1a0P2n/6Ua7XCDdowEo+SdqIGFz7FZt5HNldM7 ikWr/JM8YgL+54fMDvBgzr04Adp7N162T0C8fZHt53A3fKWkMGJrzQLywGkuUXD3R4Y4 AGb3skOAxUDVLwkzPYByxZjCqK6FTFY5s6XKkFplJsGOPTCpTTUzV5Eu67jTvAUg4DhP wbmMwKHq/rVzjiHw1NAQLpU6Lg+l7NfROyMr0ZEaOOMF0rxTMP4HOyBhTbEeYzq8QU+4 yQsw== Received: by 10.213.15.14 with SMTP id i14mr830980eba.209.1331147850154; Wed, 07 Mar 2012 11:17:30 -0800 (PST) Received: from amy.lab.techwires.net (dslb-088-065-223-042.pools.arcor-ip.net. [88.65.223.42]) by mx.google.com with ESMTPS id u9sm90317155eem.11.2012.03.07.11.17.28 (version=SSLv3 cipher=OTHER); Wed, 07 Mar 2012 11:17:29 -0800 (PST) Sender: Bernhard Schmidt From: Bernhard Schmidt To: Adrian Chadd Date: Wed, 7 Mar 2012 20:17:44 +0100 User-Agent: KMail/1.13.7 (FreeBSD/9.0-STABLE; KDE/4.7.4; amd64; ; ) References: <20120306.024212.108736612.iwasaki@jp.FreeBSD.org> <201203062005.15276.bschmidt@freebsd.org> In-Reply-To: MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201203072017.44409.bschmidt@freebsd.org> X-Gm-Message-State: ALoCoQmQdckSph3bbNsUZZN4DhXYHT+zREBXJeyCFGrOnMB45w3TNAE63po0UvaJNTcv+q76ydD0 Cc: freebsd-current@freebsd.org, Mitsuru IWASAKI , freebsd-wireless@freebsd.org Subject: Re: patches for if_iwi and wlan for WEP mode X-BeenThere: freebsd-wireless@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussions of 802.11 stack, tools device driver development." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Mar 2012 19:17:32 -0000 On Tuesday 06 March 2012 21:12:55 Adrian Chadd wrote: > .. except that the default if_transmit handling breaks fragments. Sigh. > > So we're going to have to implement if_transmit for all net80211 > drivers soon and fix fragment handling. Not saying that you are wrong, it is unrelated to the issue at hand though and I'm not even sure it can be fixed just by replacing if_transmit(). Anyways, a bug going unnoticed for 3 years or something isn't that high on my priority list. -- Bernhard From owner-freebsd-wireless@FreeBSD.ORG Wed Mar 7 19:43:54 2012 Return-Path: Delivered-To: freebsd-wireless@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id F3DD0106566B; Wed, 7 Mar 2012 19:43:53 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Received: from mail-we0-f182.google.com (mail-we0-f182.google.com [74.125.82.182]) by mx1.freebsd.org (Postfix) with ESMTP id 387478FC0C; Wed, 7 Mar 2012 19:43:53 +0000 (UTC) Received: by werl4 with SMTP id l4so5327173wer.13 for ; Wed, 07 Mar 2012 11:43:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type; bh=duhEarhHKkD2PuJmQDnbsTYps7koz+q2oQiYyTv5EwU=; b=lhYBlZ+XOM0zzuaJIgAx627apkYDNdriUv283dce1zjmijz7FyJ7hxy36n77oP+/pO 2eos24rRxxiHyhCqhUTdREK2luo3Z6a5EgEVT43d+CupU0ZQLQZ+AQTs6GhkRkOxZuUa VQI2cdw8BL3DcrSasbyJIig3uMRu5QO+Y6hVBo1ufw8u1yfoTGOqVDl7BRMfhAaHVknr x00DW4OxOw0DlLGGkujjDzenPQPbyCvI3cNmQUPfYoRT82ddGThKHmWJEDHR6SWnHw37 Lw3XA09hoVDehwLyaKS5OB4u11MEJiAUOpXVU8KqH8pQw26EYV+Eidr6rmOpDFcAhbRw lIrA== MIME-Version: 1.0 Received: by 10.216.131.2 with SMTP id l2mr1646647wei.3.1331149432182; Wed, 07 Mar 2012 11:43:52 -0800 (PST) Sender: adrian.chadd@gmail.com Received: by 10.216.198.81 with HTTP; Wed, 7 Mar 2012 11:43:52 -0800 (PST) In-Reply-To: <201203072017.44409.bschmidt@freebsd.org> References: <20120306.024212.108736612.iwasaki@jp.FreeBSD.org> <201203062005.15276.bschmidt@freebsd.org> <201203072017.44409.bschmidt@freebsd.org> Date: Wed, 7 Mar 2012 11:43:52 -0800 X-Google-Sender-Auth: GRFf6pCJKWU8bMKx1oRPpmFVKLw Message-ID: From: Adrian Chadd To: Bernhard Schmidt Content-Type: text/plain; charset=ISO-8859-1 Cc: freebsd-current@freebsd.org, Mitsuru IWASAKI , freebsd-wireless@freebsd.org Subject: Re: patches for if_iwi and wlan for WEP mode X-BeenThere: freebsd-wireless@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussions of 802.11 stack, tools device driver development." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Mar 2012 19:43:54 -0000 On 7 March 2012 11:17, Bernhard Schmidt wrote: > On Tuesday 06 March 2012 21:12:55 Adrian Chadd wrote: >> .. except that the default if_transmit handling breaks fragments. Sigh. >> >> So we're going to have to implement if_transmit for all net80211 >> drivers soon and fix fragment handling. > > Not saying that you are wrong, it is unrelated to the issue at hand > though and I'm not even sure it can be fixed just by replacing > if_transmit(). Anyways, a bug going unnoticed for 3 years or something > isn't that high on my priority list. Oh, it's absolutely not a requirement here. It was more a comment that he didn't need to implement if_transmit just yet in order to fix this bug, but it's likely a good idea moving forward. I have recently acquired an iwi(4) NIC so I'll also test this out. Don't let me stop you though. :) Adrian From owner-freebsd-wireless@FreeBSD.ORG Wed Mar 7 20:18:41 2012 Return-Path: Delivered-To: freebsd-wireless@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 547B8106564A for ; Wed, 7 Mar 2012 20:18:41 +0000 (UTC) (envelope-from bschmidt@techwires.net) Received: from mail-ey0-f182.google.com (mail-ey0-f182.google.com [209.85.215.182]) by mx1.freebsd.org (Postfix) with ESMTP id D14D48FC0A for ; Wed, 7 Mar 2012 20:18:40 +0000 (UTC) Received: by eaaf13 with SMTP id f13so2511521eaa.13 for ; Wed, 07 Mar 2012 12:18:34 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=sender:from:to:subject:date:user-agent:cc:references:in-reply-to :mime-version:content-type:content-transfer-encoding:message-id :x-gm-message-state; bh=Er4Jpdj/SEaozeEE3hvL85bFix/Bh9l/+h6vQjEXS2I=; b=foDm/MuX0tdpq5LvS8id5ZgOAfIS4x92+0CWW1VyZu2y8LDkAhj9oTV8PMtrtnTHje kSdcRpvhRIstGWcrRb+0lfZ93ThIrB2kGaiwWBkos7D7ArgmdElYwb8U+OGNcMhk3HkU M6/4JQEO8rrM6Sakhm7UY+N01Vp54+T4N0IF/xnevjP21rWWwN/9zuXHrV+7O4iNbRQz FQntStp0zgE/eDCvPT8JMqaZYPgdmpKQ2EHsa+SlOzKNgs9+cByp1nnz+y6xtfP1cQ2a I4LIVZJDa2IoD9qh/skbKJOCGgdN5A0LXIjFbGESscSj3b+7zoi+nLiU6kQ7o4ZPhXSs nq0w== Received: by 10.213.4.131 with SMTP id 3mr803042ebr.22.1331151514327; Wed, 07 Mar 2012 12:18:34 -0800 (PST) Received: from amy.lab.techwires.net (dslb-088-065-223-042.pools.arcor-ip.net. [88.65.223.42]) by mx.google.com with ESMTPS id n55sm50909816eef.6.2012.03.07.12.18.31 (version=SSLv3 cipher=OTHER); Wed, 07 Mar 2012 12:18:33 -0800 (PST) Sender: Bernhard Schmidt From: Bernhard Schmidt To: Adrian Chadd Date: Wed, 7 Mar 2012 21:18:47 +0100 User-Agent: KMail/1.13.7 (FreeBSD/9.0-STABLE; KDE/4.7.4; amd64; ; ) References: <201203052314.22050.bschmidt@freebsd.org> <20120308.003844.08316346.iwasaki@jp.FreeBSD.org> In-Reply-To: MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201203072118.47751.bschmidt@freebsd.org> X-Gm-Message-State: ALoCoQnY5SDkk+nT2ItKL/LEsl4+Z2mTvo6YkMTS0aVKPuOsMeouAPcr1rVRDODVwg/8bHZycgfI Cc: freebsd-current@freebsd.org, Mitsuru IWASAKI , freebsd-wireless@freebsd.org Subject: Re: patches for if_iwi and wlan for WEP mode X-BeenThere: freebsd-wireless@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussions of 802.11 stack, tools device driver development." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Mar 2012 20:18:41 -0000 On Wednesday 07 March 2012 19:45:11 Adrian Chadd wrote: > Hi, > > I'd rather you didn't commit iwi_update_mcast() unless you absolutely > know that the NIC doesn't need to be notified of multicast group > membership changes. If so, please commit that as a separate fix. Oh well, iwi(4) receives multicast frames just fine, they are discarded somewhere else though last time I've checked, another offtopic issue ;) > I'll look at iwi later and give you feedback on that particular change. I did look into this once for ipw it was I guess, the firmware doesn't support filtering based on addresses so everything one could achieve here is enable/disable filtering of all multicast frames. Check iwi_configuration.enable_multicast_filtering, which is a bool actually not an uint8_t. -- Bernhard From owner-freebsd-wireless@FreeBSD.ORG Wed Mar 7 20:52:24 2012 Return-Path: Delivered-To: freebsd-wireless@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 3901B1065674; Wed, 7 Mar 2012 20:52:24 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Received: from mail-yw0-f54.google.com (mail-yw0-f54.google.com [209.85.213.54]) by mx1.freebsd.org (Postfix) with ESMTP id A88A08FC0A; Wed, 7 Mar 2012 20:52:23 +0000 (UTC) Received: by yhgm50 with SMTP id m50so3679812yhg.13 for ; Wed, 07 Mar 2012 12:52:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:to:cc:reply-to:subject:in-reply-to:x-mailer :mime-version:content-type; bh=m44sS8yHZwgivinqVfYwfYUXa7dBhuSrS+CV3P2/p9Q=; b=I80PRiFUS24F4pIz/Z5IqQm1ZfkDqeIZqG5lZ5BJu0NSxxFrme51q5Yj04zdgwOpC3 BOOFaiJYzXrKBMqCMk2ErfYpCtcqJowuKZZU7JjHA+z64v4GDU0H7almsXHx/0Y8ABtL ndw+9qI77XBrOJFseNfkAMqtim49PTu1+Jd3Vv/C4hZ2wQZhsuAnSOcXvzEz/+eL0aVf InqLe0Y5fJrrZfVbr4Gxipxlxpr7Rn04tKvdVDyM5zna+P6Sz1ZWuJoAjxn/a55zo6NF fC4onNEAhgKt4d0uz4TFZj8M/uHlEK+wDsqUlu8jN799Y+RipmCdt1DvODK3+nMCqGgu BE0Q== Received: by 10.60.4.71 with SMTP id i7mr1481761oei.39.1331153543084; Wed, 07 Mar 2012 12:52:23 -0800 (PST) Received: from www.palm.com ([32.175.144.149]) by mx.google.com with ESMTPS id q5sm2879697oef.3.2012.03.07.12.52.16 (version=SSLv3 cipher=OTHER); Wed, 07 Mar 2012 12:52:21 -0800 (PST) Message-ID: <4f57ca85.05183c0a.7cf8.ffffb656@mx.google.com> Date: Wed, 7 Mar 2012 12:52:19 -0800 From: "Adrian Chadd" To: "Bernhard Schmidt" , "Adrian Chadd" In-Reply-To: <201203072118.47751.bschmidt@freebsd.org> X-Mailer: Palm webOS v1.0.1 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.5 Cc: "freebsd-current@freebsd.org" , Mitsuru IWASAKI , "freebsd-wireless@freebsd.org" Subject: Re: patches for if_iwi and wlan for WEP mode X-BeenThere: freebsd-wireless@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Adrian Chadd List-Id: "Discussions of 802.11 stack, tools device driver development." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Mar 2012 20:52:24 -0000 It's on topic because he included that in his patch. :) Adrian Sent from my Palm Pre on AT&T On Mar 7, 2012 12:18 PM, Bernhard Schmidt <bschmidt@freebsd.org> wrot= e:=20 On Wednesday 07 March 2012 19:45:11 Adrian Chadd wrote: > Hi, >=20 > I'd rather you didn't commit iwi_update_mcast() unless you absolutely > know that the NIC doesn't need to be notified of multicast group > membership changes. If so, please commit that as a separate fix. Oh well, iwi(4) receives multicast frames just fine, they are discarded somewhere else though last time I've checked, another offtopic issue ;) > I'll look at iwi later and give you feedback on that particular change. I did look into this once for ipw it was I guess, the firmware doesn't support filtering based on addresses so everything one could achieve here is enable/disable filtering of all multicast frames. Check iwi_configuration.enable_multicast_filtering, which is a bool actually not an uint8_t. --=20 Bernhard From owner-freebsd-wireless@FreeBSD.ORG Thu Mar 8 13:42:54 2012 Return-Path: Delivered-To: freebsd-wireless@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 4DB54106566B for ; Thu, 8 Mar 2012 13:42:54 +0000 (UTC) (envelope-from moonlightakkiy@yahoo.ca) Received: from nm37-vm4.bullet.mail.ne1.yahoo.com (nm37-vm4.bullet.mail.ne1.yahoo.com [98.138.229.132]) by mx1.freebsd.org (Postfix) with SMTP id E5F758FC1B for ; Thu, 8 Mar 2012 13:42:53 +0000 (UTC) Received: from [98.138.90.49] by nm37.bullet.mail.ne1.yahoo.com with NNFMP; 08 Mar 2012 13:42:47 -0000 Received: from [98.138.226.125] by tm2.bullet.mail.ne1.yahoo.com with NNFMP; 08 Mar 2012 13:42:47 -0000 Received: from [127.0.0.1] by smtp204.mail.ne1.yahoo.com with NNFMP; 08 Mar 2012 13:42:47 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.ca; s=s1024; t=1331214167; bh=RkcIOOgpLPc9CszQiHo1p0Uhsjy4JM/BRXsv3udrt8E=; h=X-Yahoo-Newman-Id:X-Yahoo-Newman-Property:X-YMail-OSG:X-Yahoo-SMTP:Received:Received:MIME-Version:Received:Received:Date:Message-ID:Subject:From:To:Cc:Content-Type:Content-Transfer-Encoding; b=EsNDUL3YBl3Yv+wiQVxFvJ8W4tUhNSuNUCVIuSGbq2kavDzRe1+DihX0OyKT3pfQMttZWFxdXqoAsFXvrgMSe8b1TvZ7zuE74g0ATS8IvOOuUf9+mFmgnhFrvPn4Vw/O/5oA8HvmbjsLw/FwoG9gB0ZeLgXH1RfgvrHjgPEJnmU= X-Yahoo-Newman-Id: 505096.96953.bm@smtp204.mail.ne1.yahoo.com X-Yahoo-Newman-Property: ymail-3 X-YMail-OSG: s2OiHVMVM1nmFCihq3EQjoJpLucMZn9aTPZOxznh01WGtxG _iIOpQGYqiQz4i3uIpZJfLxnwefUS.4d_xbLVlFFhwbESusW31nhQIrxJcWd h5_4vt6JIIB3pRwXvJqqqjziusy6SWDY8l7hDYRVVOpMPWlgpNl3AK6CuTgr m_QSfNfLn_GbPiYZsMnpqPvtT2CzveeE7pThXAFzAFX6QnP7VqTfXklZ6HVb kqZ5YMdjQ99GlwVb1HbHQ19me_8hPf8huQLLFdhKjgVxTZ_bnJVACGP3.FcL v9k2.vGaeFb3vawOEjFdNdv5pXJ7YDyORu_V_nlgYl.BoyoyX3b2FDHgyJl1 LKEShDHFVXFmMG7qtLSgtEsbLSTLON3nAY7xjPC5TfXYgiV3I_plEGpBjrU3 1ptaNRBnxRDB0MGKou9HMJlo2hq8.dDVts8o- X-Yahoo-SMTP: Xr6qjFWswBAEmd20sAvB4Q3keqXvXsIH9TjJ Received: from mail-iy0-f182.google.com (moonlightakkiy@209.85.210.182 with plain) by smtp204.mail.ne1.yahoo.com with SMTP; 08 Mar 2012 05:42:47 -0800 PST Received: by iahk25 with SMTP id k25so956018iah.13 for ; Thu, 08 Mar 2012 05:42:47 -0800 (PST) MIME-Version: 1.0 Received: by 10.50.179.98 with SMTP id df2mr6814164igc.32.1331214167002; Thu, 08 Mar 2012 05:42:47 -0800 (PST) Received: by 10.231.108.133 with HTTP; Thu, 8 Mar 2012 05:42:46 -0800 (PST) Date: Thu, 8 Mar 2012 06:42:46 -0700 Message-ID: From: PseudoCylon To: Mitsuru IWASAKI Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: freebsd-current@freebsd.org, freebsd-wireless@freebsd.org, bschmidt@freebsd.org Subject: Re: patches for if_iwi and wlan for WEP mode X-BeenThere: freebsd-wireless@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussions of 802.11 stack, tools device driver development." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 08 Mar 2012 13:42:54 -0000 > ------------------------------ > > Message: 4 > Date: Wed, 7 Mar 2012 10:45:11 -0800 > From: Adrian Chadd > Subject: Re: patches for if_iwi and wlan for WEP mode > To: Mitsuru IWASAKI > Cc: freebsd-current@freebsd.org, freebsd-wireless@freebsd.org, > =A0 =A0 =A0 =A0bschmidt@freebsd.org > Message-ID: > =A0 =A0 =A0 =A0 > Content-Type: text/plain; charset=3DISO-8859-1 > > Hi, > > I'd rather you didn't commit iwi_update_mcast() unless you absolutely > know that the NIC doesn't need to be notified of multicast group > membership changes. If so, IFF_ALLMULTI flag should be set. http://lists.freebsd.org/pipermail/svn-src-head/2010-May/016983.html AK From owner-freebsd-wireless@FreeBSD.ORG Thu Mar 8 17:32:37 2012 Return-Path: Delivered-To: freebsd-wireless@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 22CF51065673; Thu, 8 Mar 2012 17:32:37 +0000 (UTC) (envelope-from iwasaki@jp.FreeBSD.org) Received: from locore.org (ns01.locore.org [218.45.21.227]) by mx1.freebsd.org (Postfix) with ESMTP id B4CA88FC15; Thu, 8 Mar 2012 17:32:35 +0000 (UTC) Received: from localhost (celeron.v4.locore.org [192.168.0.10]) by locore.org (8.14.5/8.14.5/iwasaki) with ESMTP/inet id q28HWSoP028066; Fri, 9 Mar 2012 02:32:28 +0900 (JST) (envelope-from iwasaki@jp.FreeBSD.org) Date: Fri, 09 Mar 2012 02:32:27 +0900 (JST) Message-Id: <20120309.023227.95065896.iwasaki@jp.FreeBSD.org> To: adrian@freebsd.org From: Mitsuru IWASAKI In-Reply-To: References: <201203062005.15276.bschmidt@freebsd.org> <20120308.003844.08316346.iwasaki@jp.FreeBSD.org> X-Mailer: Mew version 3.3 on Emacs 20.7 / Mule 4.0 (HANANOEN) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: freebsd-current@freebsd.org, freebsd-wireless@freebsd.org, bschmidt@freebsd.org Subject: Re: patches for if_iwi and wlan for WEP mode X-BeenThere: freebsd-wireless@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussions of 802.11 stack, tools device driver development." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 08 Mar 2012 17:32:37 -0000 Hi, > I'd rather you didn't commit iwi_update_mcast() unless you absolutely > know that the NIC doesn't need to be notified of multicast group > membership changes. If so, please commit that as a separate fix. OK, I'd do so. I don't need mcast stuff for the time being, instead I'd check other area such as suspend/resume for the next target. Today's one at: http://people.freebsd.org/~iwasaki/iwi/iwi-20120308.diff # 2 lines fix, after all ;) Thanks! From owner-freebsd-wireless@FreeBSD.ORG Thu Mar 8 17:51:02 2012 Return-Path: Delivered-To: freebsd-wireless@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id A61D2106564A; Thu, 8 Mar 2012 17:51:02 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Received: from mail-pw0-f54.google.com (mail-pw0-f54.google.com [209.85.160.54]) by mx1.freebsd.org (Postfix) with ESMTP id 679748FC19; Thu, 8 Mar 2012 17:51:02 +0000 (UTC) Received: by pbcwz17 with SMTP id wz17so1989651pbc.13 for ; Thu, 08 Mar 2012 09:51:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=h2+JSl0qSY/YiIotcfBU03LL9Xe3zqgeXsb+uGyi8Po=; b=gRoX+BDDbFpl5lKO9/v0ZeWZaf5ZUejjyPfB91nRskwmL/Bj98VCaJ43iqav2zxGha j4TweekS8tRQK7i1ok6F3bhf21uppWqBnd0QPNLD0Jcrn8iwiiYbWtW4bPSb9BWU7M6G C9/SfCF2we2QyfH+Qgnc4UUY5KJNjols3zUyv+k4MJHejii4di3o87hPMkbHSJBBLfIr iwvsnthWP7dR97exVYqwnmHTzzoQYaIngwAbUYSrFyg7VPOTuegu0fAaJmFBFHf35psm fcxOas8qww9h/5yyeofju0GECENyM8EdIqGgd/C1E9JbY5SOv/YYZuLbXwMTQIw6sbBT GeMQ== MIME-Version: 1.0 Received: by 10.68.240.41 with SMTP id vx9mr11093351pbc.10.1331229062114; Thu, 08 Mar 2012 09:51:02 -0800 (PST) Sender: adrian.chadd@gmail.com Received: by 10.142.72.11 with HTTP; Thu, 8 Mar 2012 09:51:02 -0800 (PST) In-Reply-To: <20120309.023227.95065896.iwasaki@jp.FreeBSD.org> References: <201203062005.15276.bschmidt@freebsd.org> <20120308.003844.08316346.iwasaki@jp.FreeBSD.org> <20120309.023227.95065896.iwasaki@jp.FreeBSD.org> Date: Thu, 8 Mar 2012 09:51:02 -0800 X-Google-Sender-Auth: HErUkLdsiywsQ2P8EyzWdbC3pEU Message-ID: From: Adrian Chadd To: Mitsuru IWASAKI Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: freebsd-current@freebsd.org, freebsd-wireless@freebsd.org, bschmidt@freebsd.org Subject: Re: patches for if_iwi and wlan for WEP mode X-BeenThere: freebsd-wireless@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussions of 802.11 stack, tools device driver development." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 08 Mar 2012 17:51:02 -0000 On 8 March 2012 09:32, Mitsuru IWASAKI wrote: > Hi, > >> I'd rather you didn't commit iwi_update_mcast() unless you absolutely >> know that the NIC doesn't need to be notified of multicast group >> membership changes. If so, please commit that as a separate fix. > > OK, I'd do so. =A0I don't need mcast stuff for the time being, > instead I'd check other area such as suspend/resume for the next target. > > Today's one at: > http://people.freebsd.org/~iwasaki/iwi/iwi-20120308.diff > > # 2 lines fix, after all ;) :-) Thanks for this! Once it's done, let's sort out the multicast stuff. Either we set IFF_ALLMULTI as AK suggested or we figure out and write a proper _update_mcast() function. We can commit that as a separate patch. I found my 2945 NIC btw, so hopefully I can get some test in on saturday. Adrian From owner-freebsd-wireless@FreeBSD.ORG Thu Mar 8 19:26:27 2012 Return-Path: Delivered-To: freebsd-wireless@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 123E6106564A; Thu, 8 Mar 2012 19:26:27 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42]) by mx1.freebsd.org (Postfix) with ESMTP id D734D8FC0C; Thu, 8 Mar 2012 19:26:26 +0000 (UTC) Received: from bigwig.baldwin.cx (bigwig.baldwin.cx [96.47.65.170]) by cyrus.watson.org (Postfix) with ESMTPSA id 783BC46B0A; Thu, 8 Mar 2012 14:26:26 -0500 (EST) Received: from jhbbsd.localnet (unknown [209.249.190.124]) by bigwig.baldwin.cx (Postfix) with ESMTPSA id 06897B93B; Thu, 8 Mar 2012 14:26:26 -0500 (EST) From: John Baldwin To: freebsd-current@freebsd.org Date: Thu, 8 Mar 2012 10:43:44 -0500 User-Agent: KMail/1.13.5 (FreeBSD/8.2-CBSD-20110714-p10; KDE/4.5.5; amd64; ; ) References: <20120306.024212.108736612.iwasaki@jp.FreeBSD.org> <201203072017.44409.bschmidt@freebsd.org> In-Reply-To: MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201203081043.44801.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7 (bigwig.baldwin.cx); Thu, 08 Mar 2012 14:26:26 -0500 (EST) Cc: freebsd-wireless@freebsd.org, Bernhard Schmidt Subject: Re: patches for if_iwi and wlan for WEP mode X-BeenThere: freebsd-wireless@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussions of 802.11 stack, tools device driver development." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 08 Mar 2012 19:26:27 -0000 On Wednesday, March 07, 2012 2:43:52 pm Adrian Chadd wrote: > On 7 March 2012 11:17, Bernhard Schmidt wrote: > > On Tuesday 06 March 2012 21:12:55 Adrian Chadd wrote: > >> .. except that the default if_transmit handling breaks fragments. Sigh. > >> > >> So we're going to have to implement if_transmit for all net80211 > >> drivers soon and fix fragment handling. > > > > Not saying that you are wrong, it is unrelated to the issue at hand > > though and I'm not even sure it can be fixed just by replacing > > if_transmit(). Anyways, a bug going unnoticed for 3 years or something > > isn't that high on my priority list. > > Oh, it's absolutely not a requirement here. It was more a comment that > he didn't need to implement if_transmit just yet in order to fix this > bug, but it's likely a good idea moving forward. > > I have recently acquired an iwi(4) NIC so I'll also test this out. > Don't let me stop you though. :) However, you could do that by having a net80211_ifattach() type thing that sets if_transmit and invokes the driver-provided if_start. I don't think wireless devices are using multiple transmit queues in such a way that if_transmit would be a benefit, and if_start is a simpler model. -- John Baldwin From owner-freebsd-wireless@FreeBSD.ORG Thu Mar 8 19:38:10 2012 Return-Path: Delivered-To: freebsd-wireless@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id D0694106567C; Thu, 8 Mar 2012 19:38:10 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Received: from mail-pw0-f54.google.com (mail-pw0-f54.google.com [209.85.160.54]) by mx1.freebsd.org (Postfix) with ESMTP id 8FC258FC12; Thu, 8 Mar 2012 19:38:10 +0000 (UTC) Received: by pbcwz17 with SMTP id wz17so2086137pbc.13 for ; Thu, 08 Mar 2012 11:38:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=8xn50JUy7ebRHhjydgsfQSkBeuFjZT8oix1HAScfp1Q=; b=Ucxy0WcQdImFYV3me8hJQC0ws8uLsMBYZAK8zw41Ti1gb6JjUaZNKo+cOPsjx6HGw1 Im/9ecZunB6VMNACZsy6ceQvkNNvricOzSIrXB8BzUtFVVF444enwTAQmdIbKGeatug0 PLRLon0gdjrcipp5VHMaWSEtchFyOxAtsMcQaLvRTDcbwFh7utLZSbfOPK9GFMEfMng8 z2WgzX7y7vzB3PkbWdr4LfGX28estN1x5ZD02usjHrzs5nsBSuUeiS6he/TruejYjGZx 80HlDwTonGPCfP/GHAw0xQFJNG3NCypDSDys28a0mfIYCQR8VHnCHlVU2gWpU+BBoFRS uDxg== MIME-Version: 1.0 Received: by 10.68.204.6 with SMTP id ku6mr11414651pbc.157.1331235490114; Thu, 08 Mar 2012 11:38:10 -0800 (PST) Sender: adrian.chadd@gmail.com Received: by 10.142.72.11 with HTTP; Thu, 8 Mar 2012 11:38:09 -0800 (PST) In-Reply-To: <201203081043.44801.jhb@freebsd.org> References: <20120306.024212.108736612.iwasaki@jp.FreeBSD.org> <201203072017.44409.bschmidt@freebsd.org> <201203081043.44801.jhb@freebsd.org> Date: Thu, 8 Mar 2012 11:38:09 -0800 X-Google-Sender-Auth: eg5-9A87MZ7bEdcqdkVTl0uhcE8 Message-ID: From: Adrian Chadd To: John Baldwin Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: freebsd-current@freebsd.org, freebsd-wireless@freebsd.org, Bernhard Schmidt Subject: Re: patches for if_iwi and wlan for WEP mode X-BeenThere: freebsd-wireless@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussions of 802.11 stack, tools device driver development." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 08 Mar 2012 19:38:10 -0000 On 8 March 2012 07:43, John Baldwin wrote: > However, you could do that by having a net80211_ifattach() type thing tha= t > sets if_transmit and invokes the driver-provided if_start. =A0I don't thi= nk > wireless devices are using multiple transmit queues in such a way that > if_transmit would be a benefit, and if_start is a simpler model. THe problem is that the default if_transmit uses IFQ_ENQUEUE and the _start() versions out there use IFQ_DEQUEUE without necessarily handling fragments at all. We end up having m->m_nextpkt NULL'ed upon IFQ_ENQUEUE, thus not only making a fragment list entirely broken, the fragments themselves are actually leaked. So we end up running out of mbufs. The solution I can see working at the moment is creating if_transmit for each wireless device and correctly handling any fragments in the head mbuf before calling IFQ_DEQUEUE. Adrian From owner-freebsd-wireless@FreeBSD.ORG Thu Mar 8 21:30:58 2012 Return-Path: Delivered-To: freebsd-wireless@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 56EA6106567A; Thu, 8 Mar 2012 21:30:58 +0000 (UTC) (envelope-from linimon@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 2E6068FC1A; Thu, 8 Mar 2012 21:30:58 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id q28LUwhW003138; Thu, 8 Mar 2012 21:30:58 GMT (envelope-from linimon@freefall.freebsd.org) Received: (from linimon@localhost) by freefall.freebsd.org (8.14.5/8.14.5/Submit) id q28LUwh2003133; Thu, 8 Mar 2012 21:30:58 GMT (envelope-from linimon) Date: Thu, 8 Mar 2012 21:30:58 GMT Message-Id: <201203082130.q28LUwh2003133@freefall.freebsd.org> To: linimon@FreeBSD.org, freebsd-bugs@FreeBSD.org, freebsd-wireless@FreeBSD.org From: linimon@FreeBSD.org Cc: Subject: Re: kern/165849: [ath] [hang] network ath driver freeze X-BeenThere: freebsd-wireless@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussions of 802.11 stack, tools device driver development." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 08 Mar 2012 21:30:58 -0000 Old Synopsis: network ath driver freeze New Synopsis: [ath] [hang] network ath driver freeze Responsible-Changed-From-To: freebsd-bugs->freebsd-wireless Responsible-Changed-By: linimon Responsible-Changed-When: Thu Mar 8 21:30:43 UTC 2012 Responsible-Changed-Why: Over to maintainer(s). http://www.freebsd.org/cgi/query-pr.cgi?pr=165849 From owner-freebsd-wireless@FreeBSD.ORG Thu Mar 8 23:50:44 2012 Return-Path: Delivered-To: freebsd-wireless@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 41773106566B; Thu, 8 Mar 2012 23:50:44 +0000 (UTC) (envelope-from adrian@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 184FF8FC0A; Thu, 8 Mar 2012 23:50:44 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id q28Nohe6052628; Thu, 8 Mar 2012 23:50:43 GMT (envelope-from adrian@freefall.freebsd.org) Received: (from adrian@localhost) by freefall.freebsd.org (8.14.5/8.14.5/Submit) id q28NohGR052622; Thu, 8 Mar 2012 23:50:43 GMT (envelope-from adrian) Date: Thu, 8 Mar 2012 23:50:43 GMT Message-Id: <201203082350.q28NohGR052622@freefall.freebsd.org> To: adrian@FreeBSD.org, freebsd-bugs@FreeBSD.org, freebsd-wireless@FreeBSD.org From: adrian@FreeBSD.org Cc: Subject: Re: kern/165866: [ath] TX hangs, requiring a "scan" to properly reset the interface X-BeenThere: freebsd-wireless@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussions of 802.11 stack, tools device driver development." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 08 Mar 2012 23:50:44 -0000 Synopsis: [ath] TX hangs, requiring a "scan" to properly reset the interface Responsible-Changed-From-To: freebsd-bugs->freebsd-wireless Responsible-Changed-By: adrian Responsible-Changed-When: Thu Mar 8 23:50:34 UTC 2012 Responsible-Changed-Why: Change to owner http://www.freebsd.org/cgi/query-pr.cgi?pr=165866 From owner-freebsd-wireless@FreeBSD.ORG Thu Mar 8 23:54:20 2012 Return-Path: Delivered-To: freebsd-wireless@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 8AD91106567A; Thu, 8 Mar 2012 23:54:20 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Received: from mail-pz0-f54.google.com (mail-pz0-f54.google.com [209.85.210.54]) by mx1.freebsd.org (Postfix) with ESMTP id 56C258FC21; Thu, 8 Mar 2012 23:54:19 +0000 (UTC) Received: by dald2 with SMTP id d2so1058259dal.13 for ; Thu, 08 Mar 2012 15:54:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:content-type; bh=Pm9B+pr76esvYAzTPndhauOviX5EbTqZPHN6BqwT6rU=; b=qsqJznQjOcGVbIE2eKvfWbCvVcnpPSzAAObxMF8cZs4Ka77djU0g9yJh34EvN1NENg JVDSF2Wd3x4P7fei2rTIHEUGdj5aBFbrgpSBXdxu8Uxv8Al2JWEx3e66W/EidTyX99FV yruerGzg+7Vc4Zg4O4m+TrDpPavzM+SrCyahKvKWq5TinAg0W+LFcDGnpZtpARX9XqVl WfMR5c6GCd5C8ttMGvAzhYEKu0ZnnVeXyDvib6Rfg87MPI1f2ZoElz7WGmR1y9sdBhav xN5OZK2SOoN29p1bP4mVfuM7RD1A+NTXVA88mLd7KeXEUZ/qDVfnV6Ho+AF9z1AHkOVg A9VA== MIME-Version: 1.0 Received: by 10.68.134.33 with SMTP id ph1mr1037490pbb.81.1331250859827; Thu, 08 Mar 2012 15:54:19 -0800 (PST) Sender: adrian.chadd@gmail.com Received: by 10.142.72.11 with HTTP; Thu, 8 Mar 2012 15:54:18 -0800 (PST) In-Reply-To: References: <201203082350.q28NohGR052622@freefall.freebsd.org> Date: Thu, 8 Mar 2012 15:54:18 -0800 X-Google-Sender-Auth: dnmKlesl5DaeblN5FZbzPw5Zrws Message-ID: From: Adrian Chadd To: freebsd-wireless@freebsd.org, bug-followup@freebsd.org Content-Type: multipart/mixed; boundary=047d7b10d1b19b60d004bac3fe34 X-Content-Filtered-By: Mailman/MimeDel 2.1.5 Cc: Subject: Re: kern/165866: [ath] TX hangs, requiring a "scan" to properly reset the interface X-BeenThere: freebsd-wireless@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussions of 802.11 stack, tools device driver development." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 08 Mar 2012 23:54:20 -0000 --047d7b10d1b19b60d004bac3fe34 Content-Type: text/plain; charset=ISO-8859-1 .. and a compressed version. adrian --047d7b10d1b19b60d004bac3fe34-- From owner-freebsd-wireless@FreeBSD.ORG Fri Mar 9 00:00:34 2012 Return-Path: Delivered-To: freebsd-wireless@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 2EEA81065673 for ; Fri, 9 Mar 2012 00:00:34 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 05B878FC13 for ; Fri, 9 Mar 2012 00:00:34 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id q2900XNc060434 for ; Fri, 9 Mar 2012 00:00:33 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.5/8.14.5/Submit) id q2900XKP060428; Fri, 9 Mar 2012 00:00:33 GMT (envelope-from gnats) Date: Fri, 9 Mar 2012 00:00:33 GMT Message-Id: <201203090000.q2900XKP060428@freefall.freebsd.org> To: freebsd-wireless@FreeBSD.org From: dfilter@FreeBSD.ORG (dfilter service) Cc: Subject: Re: kern/165866: commit references a PR X-BeenThere: freebsd-wireless@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: dfilter service List-Id: "Discussions of 802.11 stack, tools device driver development." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 09 Mar 2012 00:00:34 -0000 The following reply was made to PR kern/165866; it has been noted by GNATS. From: dfilter@FreeBSD.ORG (dfilter service) To: bug-followup@FreeBSD.org Cc: Subject: Re: kern/165866: commit references a PR Date: Thu, 8 Mar 2012 23:53:47 +0000 (UTC) Author: adrian Date: Thu Mar 8 23:53:38 2012 New Revision: 232707 URL: http://svn.freebsd.org/changeset/base/232707 Log: Correctly initialise the TXQ link pointer to the last descriptor in the last buffer in the list. The current behaviour (due to me, so pointy hat is firmly on my head here) was incorrect - it was setting the link pointer to the last descriptor of the _first_ buffer in the TXQ. Instead, it should have set it to the last descriptor in the _last_ buffer in the TXQ. This showed up as occasional TX stalls with frames in the TXQ but no TX progress being made. Further inspection showed the TXQ looked like it contained multiple "lists" of frames - there'd be a list of correct frames, then a NULL link pointer, but there'd be a next buffer in the list. Since this code is only called upon an interface reset, it's likely this only began showing up when I started doing stress testing in environments which annoy the radios enough to cause lockups. I've not yet any TX stalls with this patch applied. PR: kern/165866 Modified: head/sys/dev/ath/if_ath_tx.c Modified: head/sys/dev/ath/if_ath_tx.c ============================================================================== --- head/sys/dev/ath/if_ath_tx.c Thu Mar 8 23:52:22 2012 (r232706) +++ head/sys/dev/ath/if_ath_tx.c Thu Mar 8 23:53:38 2012 (r232707) @@ -623,19 +623,22 @@ void ath_txq_restart_dma(struct ath_softc *sc, struct ath_txq *txq) { struct ath_hal *ah = sc->sc_ah; - struct ath_buf *bf; + struct ath_buf *bf, *bf_last; ATH_TXQ_LOCK_ASSERT(txq); /* This is always going to be cleared, empty or not */ txq->axq_flags &= ~ATH_TXQ_PUTPENDING; + /* XXX make this ATH_TXQ_FIRST */ bf = TAILQ_FIRST(&txq->axq_q); + bf_last = ATH_TXQ_LAST(txq, axq_q_s); + if (bf == NULL) return; ath_hal_puttxbuf(ah, txq->axq_qnum, bf->bf_daddr); - txq->axq_link = &bf->bf_lastds->ds_link; + txq->axq_link = &bf_last->bf_lastds->ds_link; ath_hal_txstart(ah, txq->axq_qnum); } _______________________________________________ svn-src-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org" From owner-freebsd-wireless@FreeBSD.ORG Fri Mar 9 00:00:44 2012 Return-Path: Delivered-To: freebsd-wireless@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 9BEC3106566B for ; Fri, 9 Mar 2012 00:00:44 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 89FAA8FC15 for ; Fri, 9 Mar 2012 00:00:44 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id q2900ik3060514 for ; Fri, 9 Mar 2012 00:00:44 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.5/8.14.5/Submit) id q2900i6p060512; Fri, 9 Mar 2012 00:00:44 GMT (envelope-from gnats) Date: Fri, 9 Mar 2012 00:00:44 GMT Message-Id: <201203090000.q2900i6p060512@freefall.freebsd.org> To: freebsd-wireless@FreeBSD.org From: Adrian Chadd Cc: Subject: Re: kern/165866: [ath] TX hangs, requiring a "scan" to properly reset the interface X-BeenThere: freebsd-wireless@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Adrian Chadd List-Id: "Discussions of 802.11 stack, tools device driver development." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 09 Mar 2012 00:00:44 -0000 The following reply was made to PR kern/165866; it has been noted by GNATS. From: Adrian Chadd To: freebsd-wireless@freebsd.org, bug-followup@freebsd.org Cc: Subject: Re: kern/165866: [ath] TX hangs, requiring a "scan" to properly reset the interface Date: Thu, 8 Mar 2012 15:54:18 -0800 --047d7b10d1b19b60d004bac3fe34 Content-Type: text/plain; charset=ISO-8859-1 .. and a compressed version. adrian --047d7b10d1b19b60d004bac3fe34 Content-Type: application/x-gzip; name="b.txt.gz" Content-Disposition: attachment; filename="b.txt.gz" Content-Transfer-Encoding: base64 X-Attachment-Id: f_gzkgfhj01 H4sIANZBWU8CA+29W5PcxpXv++pQhD6BX3BiHra9w57J+23C+xyqSdkKiyJNtmxNKOYwgExAYoxE ySRtyfvhfPaTicqFQkIXZPU2c1Adi5KoXuiqanRV4Vfr8l9r/Uv3cvLfvJpeftF991X/inRvfP/q l59T+7B/++Xr8Ys33W/DLz//4y/++otf/CL+/5ef64dv/vHGv/2qC+Pf/zXe5l/Jv779vv/ii9/R 99/bHHKvvuneft8Nf5vedL8av/727T+6r16+eftr1wmi4s3X3/6ufxO/evOP+E2mhBHvvxcf4HX3 5uWrL74au297/1/jW9eRHzvcffdv3QcP/tL5r755M4bzjV598+q3Q//dD+6c/hq/6N/uPexX33zX ffndX1ff9l+O4Tfxcbvvvnn9X/Pxjrhu+UO6jpYmK01emPHeovy+LE1Vmnp7b1N+3xYmLc+M0s29 aXlutDw3Wp4Zldt7l+dGy3Oj5ZlRu7k3K8+NlefGyjNj22eNlefGynNj5Zmx7bPGynNj5bnx8sz4 9lnj5bnx8tx4eWZ8+6zx8tx4eW68PDO+fdZEeW6iPDdRnpnYPmuiPDdRnpsoz0xsnzVRnpsoz02W Zya3z5osz02W5ybLM5PbZ02W5ybLc5Plmcnts6bKc1PluanyzNT2WXv/vT/8pbv97E/pOu+//+uL MH779svfkd/MRoICHFluSNc3pEb8zE1Z7WPy2hua4of/2A0/iIx18fJ+/73bb972X8V7JQBP4+s3 8aj89257dIZy/FZCXffb/5WY9y/dT30C/PJzJh7+6OfJH3/sI+X99/704vazR/Nznf90XTr0cHvo 2cP/uP3o8fM/PDwdpYSk+z755NHzPzy5ffDs8YvnN8XtV9+5OX8n3udz8p/xl3v49Hzrmw+enY30 c87W44/gYU20nt8+Lx6JLo/Uc6rF/8EjsX/aOfF/2iOJf9ojyX/aI6l/2iPpf9ojmfO7QHppfvSR 4tuVmfKRFPvBI9nlkQZi68+p3z7Sv3TLZfbX5LKl/+KRCLBh6L7sX30Rr9u3o387hu5X5Hvx6+jc zN+Nf794Pb5J/pDvv/pqDOtvvHn7zbdvvw9f9y65bH/92/i3sUtnTL4/nexvomf36r9mT2m5z9vv 57tt7hQvwAtuTdOPOF1fcKfv+3zB7d+bXfSz+EW3NvOZza/5+szigTHd+7VklD2Pd3v4df9s9OPL v4+uiw/RTf3L+Nx2b7/p0oN2L19FT+3rN++/9+DZi5tnvyPfn15GJuYjDz968PsXz/8SDws2Hz6d 2Hw+r0f/d9e9hhMi31tJmVqfjJVk8vEezz7v4rP+q4fP//XP7nScxkfqov3UzXeL1q+7jx2ZvxPf ww8docGL9J79nxH8858p/zlfCnSgigQy5vdeoHDTyG7BmTJ0AFyLjvZUU0VNZ8jpnx/5Ir+F+XzG dHvGpjhjszrjcT5jEvRAyjMep0lvznigJp7E6QcNoTxjLSxbPmA6OsabKtpXnzHbnvFYnPF4PmMq Tmc89WbzHA/zv8UZC8oozT9J9OUZGyan1RmnZ/iS55hvzng+r+WMo3U+4z6fMfP77wq+PuOpPGNr J7Y54/hf9RmL7Rn3xRn35zOO18vpfTxfOT9/xvG1GUmA09o8xz23YXXGLN5nijeuPWO5OeP5vJYz jtb5jBU8x5pUPMeUTD/xrujHflydsaIyPse67oxXnwX9dy++//pl/Dh441+8fDV/NLzwr9520Qn8 926IGIvR8h3u8PiD588/etg9jxH28PJtjPa6b6Yusu757YMX8Xj8RDGeKqNU8r5vnsHvlX/V7ln6 jDwdsZL1Pn5Ofvj71W3i6xc/Hp/dru8VGfjRo2fFA9EuOpTljeLHb36ombSEyvjDzkfSHxlP/6MP bjZ3e/L0+fqIiXf75Ontk/WR2/IITVR++vv5yOoz/unNJ7fnI3TqHj+4mT/qz7d5/vTmBSl/tXSI Fg/0+9vPNg/9+9vbx+U53jy/XZ6Q6fRADx8/ePjB7+Ojm/ynOx2hqwc6HWFdvBBYxKWw+Qhfn9Hp kPjB3eQPjqj5iGDxn3xEFw908/jFg3SSYezDMI5Tl4483BzJr9FyBA7kN0TyFG5uPj0dhEPdzdMb UtwoHaE/OMK2D/T0hv/gRk/+/OH6yMMXzz/68DkcYX4+8vGTWzjCqYm/2otH5xtpr9ONTq91OhI/ Wcl8t0d/Or9qQsUjHz69uf24eI5iwPT0+aPT3U7e4YObFx8/erjciHfPbsrLKL6PbsrrIV0in9w+ ffTJw/WNPtzcqHt689HqecxHHj19fFO8IZ89+nN5twd/+ODxk4ePVkc+evD8Pz65ebw+kg+sH+jR s4ePnhenPR9h63f204+efPSk2xx58qh4oHTo6ZOPt3dLp7k+8vjTz+gPjrDygZ784EZPyhvlI6sL onvywfPtk/3s9ubFs5vi6o9Hnn68PscTEVMiUI2E2uVI/PFnRkaanm603O10ZH2O6c0Xcffo/AmS rBdPPr3tkieV3mzxjCKWX9z+Iccc2tDu0+ePTu8bysYEP9198OjBzZNP1md98+HTF08TW+cz8pN+ /7302M9IQch0hMIRYfXpCIMjcEbP0qV1OiMbHyg99sNPn62fo88+/Ojj20fPzg/0+ObB89tExEjs /O6fj+Rfn54ukZMb3XViOaPnH774mM+vWvwcJUbPRz7l69fxNj7Mg4cPToGWOD3Qow9fPEiMXj5F /vTk+YvHD57/ccao12aKb9E/LUfSnym9/I+e/bl4H50O5ZNk0QvsPk5nHX/k/KEsvB26Tx78eXP1 Pbt9/uLJHzfvo+cvPnzw0cera+3mj+sjkYcf3pS3GebX8UX6sFldax8/evSUFtdaOnJ6jcTqSHqN 4mfT6ZeN77XHz//48dlJmd+Q8dCnpwea/Zbbpzfwi/Ap/dPdfgifdJxyYyIzny1HqBz8pJLzdAOH RG+iIx8i2OGIDKNQMZ7906cfPbqly0d2PMf5CFsdiW/I+NI+ffDs8elQcsA+eRKfpfNTK1n39A// 8eLRs/V7Lb2yN7fPPs5c7aOTlQ49f5QvUc7oKRCfyUbMRGLA5Lv0Bn3y4cPH5wdKR27Sj8uhXTyj +NPib7K+RNOR+LTR8sgnt+yHt2GrV+32sydPPzv/IvHJ/uSz29sPbue3KKU83S0eefjBg+50ZE5E xCPP/5IOpSPp6nv/vXgoXm7d+VC60R9uPly/IdIDxcu0PDI/36szioc+efg0302lB/rg5pOZEKcj In2uffBgcySdznwIjswYOd/o5DLAofNrlH7400erPEn82eVDZx7FF6nLn486vo+fcgZHpvnnpyN/ efDHs9s8H/nok/nqp6M5XSLZQVtdIk+jP7g+wuK1cnpDACEefXZ7eifH99BEmPLx5b/59PazDz79 MKP29NLefvrsgyfZQQgi5XF+JJO69rf9l/2rF3O+RnW/YoJHGP7hf/+mm77qv3gT3ej4bvz1f1ci wipfJiKs7H80EWHVOhxKFoRDVkE4JOcA7v8qw6FhFQ4RS3j8z8NzPq7CISKoEcaeX1cyxmAoBvbn l+wnv5A/log4ndf5jNXqjH1OREi1H8DFV2U5iXEoz9gySVcBnIn/9FRcGsD99+bsBBl9mbPT3hwg Z/djt8Zn6uefqT/Rz7vyyu2FGM8JuZN1ug56pXqTr4ORy/SJ6NJnyvkdfvvZh27+mOmej391kTo8 fXJ2b757+/of8Rvdg4fx8+Ev/3f68uGT/NX53ozyKd6XnrwSekrbpFQlXASQdbRy/UHZbQOgfGN/ PsKnn/ziB4j4yQe86xfpAT8fX4X/jJ+gTx6mfL6j1o3EKTX/a377v+Ihwp2enBDOx6/lr35wo193 377+ZhhTHv/bjjyODyrn36MnM094pychOh/Rll4A241EqRhdKLM1JRlOzNz+NX9a85TRnV9BwcX8 l+mEFKwTk7SdnDiNNxFj+srGrzjvePokJMawLtJ46CLofYwqqOmYiGcVX8aIQh3/klLyjs03HujY sfnEWXTLieCkEyayV3me9Amn3yie1dTH1/DnTTafPQsd7UXKjMW3yMLjS//i8VFUOl1J6aX3DfN9 U708JUEpnOTJFD9rsnRfczbTd0+vAmFdz8X8C+quF/MPSi8Fl+lXVazjjE35h8cwrrMxuug4/z9+ ItLj9cvjiTs+JRkuxYcsICTDZbYyXCJnBGT7fSVc4qcxwmUPLtI4K5wa3MDdEL/wl8FFGiu6GJDx bhDK78ClR7jsw4UjXLZw4XeECys9lxNCwHNJVoYLGQYofhIZquBC02MhXC7zXIy9u+cyh3I7cBkR Lui5tPJciho6ICTDZbYyXLhiIsNFKlkJF6kQLkeCy4BwQbg0hEshdwGEZLjMVoYLVQIkRcFUwsUy 9Fx24cKE0zrxhVGnpRvMZXBhQusuVYo6LQezA5cJ4YJwaQiXQpkGCMlwmS3IuUwa4DKKyrDIGoFw 2fVcjKPUWeWMclzHQxd6LiY+aVYZ1XGt9uDCyTAhXBAureCiypzLCSGQc0lWhovUuWpKg6qEy1wO RrgcCC4C4YJwaQgXXcAlIyTDZbYg5zJa8FyMlpVwiW8fhMsOXJRwTM9Y6R0Znb2wFK1EfPNFrvQd Ge1eKVohXBAuDeFiypzLCSGQc0kWeC7RW4EWI1/rucR3J8LlQHDRCBcsRTcsRdvSczkhBDyXZAFc hhH6F0dR67kozLkcKqFrEC4Il3ZwoaVCNyME4JKsDBfNllI0q4aLxVL0oXIuPcIF4dIQLqVCNyMk w2W2oBStNckKXVapc5kfC+GyAxcdD8WASDjLnbDODpfBRRMaIyJheSesHXarRZ4gXDDn0ijnQkuF bkYIlKKTtcBlXBS6qjLnwjQmdA8FF4lwQbg0hAvfwGXduDhbABejIOcykUq4cBTRXaLQjV/0buB3 U+jGn9kPfDfngnBBuLSDS6nQzQgBuJhlnkHP6QjVIi8rwyKOIroL4aLcYO8MFzXsyf89wgVzLg1z LqVCNyMEStHJynBhcoKRC2Gq9FwEiuiOBZeAcEG4NIRLqdDNCMlwmS3oimYhJ3QnW9lbxATFalEN XJhyonejcpy4iVwKF6Y60Y8qXukT2YHLiHBBuDSES6nQzQiBruhkQVjkOQxNI6QWLiiiOxZcCPEU 4YJwaQWXjUL3hBAIi5IFjYtmmUTHanuLBIrojhUWUYQLwqUhXEqFbkYINC6a8yQ6JgdI6Pa21nPB MZfH8lwYwgXh0g4ujGxyLoNf51yGxXMhZACFbj9UwkUK9Fwq4eK1M9ZZ6Zi/A1y8NraLz8zemEuF cMFSdLtSNCsVuhkhkHNJ1hIWnQfV88qwCGfoHgwuGuGCcGkIl80MXbMeuTBbMP3fQkJ30roSLgoV usfqLRoRLhgWNQyLSoVuRghM/7fnhG78pXJCd6K1IjpNMCw6FFwI8Qzhgp5LK89lM0NXruX/swVw Ics8F18bFmmU/x8LLhThgnBpCJeNQpes57nMFoxcEAK6ommtQje92xEu+zkXqpyfnKLOezdeChdC VecnRTvvx/0xlwgXhEs7uJQK3YwQGLmQrBNc8kUzey6BVsLFoM7lWHDpES4Il4Zw0ZvGxbDuik4W dEVLu8xzWZWiz/uYfxQvlh49pbtenCwIKx6QcZM3FJbo+JkFzNtNzLSyXqQdJWnigldOXF4v0vHJ FrbzSvj97iLEC6Z0m6V0S41uhgjgJVnLcpER6kVE1uPl8FqXn8XLNJp7hpcJ8YJ4aYiXjUp3WndG zxbM0VUDVIy4qcfL4dUuP4cXPmrZz6/T/FotX1TjZQr8YHghxHPEC+KlEV74ZpKuWi91nS3Ai6fg vVwSHGl1xXgR0oThfuGFIl4QLw3xUip1M0QAL8kCMd0EuZeJ0Xq82GvOvYhhMPx+4YUhXhAvDfFS anUzREBON51zL1wbaASwqw1GP48XTtg1516kDoNogpf1Unoi776Unsj9sjTiBfHSDC+lWjdDBDQv yYLgaFxSu9bW40Vec3Cke8nE/fJeFOIF8dIQL6VeN0MEgqPxnNpVxkBqV4yyGi/6moMjPcnoDtwr vGjEC+pe2uleeKnYzRCB4ChZgBdCAS+SVOOFmmsOjowmo3n3eDHe9dYZ5gR3U3Dhwgkvxve2M0zw bgqhYvAl4gW9l2beS6nZzRABvCQLdC+ih26jsT44YuSaC9Nm6uMveq/wMiFe0Htp6L2Uqt0MEdC9 JAum0w0WvBdTXTnijF5z7sXq0CL30hIvhHiBeEG8tMJLqdrNEIH5dMkCvIxsGX4p6r0Xfs25l56y /p4FRxTxgnhpiJdStZshAnhJFuDFLqpdoaq9F37VTQG9nUb67vGihRulI4OT2g3EeXXholcxynjR St0NxKv9XYyIF8RLK7yIzXRdu1btzhZM1/UwAHMaeDVeBDFXjJdBjfEyeud48cIJlY7a0VnvzIXe ixdCddTasbPe7HkvHvGCeGmIl818Xb8egTlb0DGtBsDLWF+YFuKaU7uDHbm6X3gZES9YOWpXORKl ajdDBDqm1Wo3QO9Nzr0IU48Xc83eixf92KYpgBrHrSPWmd7Ri1W78WrmltjO9FTu514k4gXx0gov pWo3QwS8l2RBYZqB7iWQ+uBIsmv2XnxPdWgjqxMuaOd755lT4mJZneiC9n3nmRI7eOGIFwyOGgZH pWo3QwQK02yleyFaQM/RUF05kvyaC9N+lKa/X3gRiBfES0O8lKrdDBHAS7KWZfXngQy6Hi9XrdoN zKrpfuFFI14QLw3xojbr6tcDGWYL8DL/Cqcx3vV4UVet2g392KrnqBVeDOIF8dIQL6VqN0ME8JIs qBzp3i+6l3q8iGtO7Y4xOhzvV+VoQLxgardhancza1evmwJmC/DS6/Os3Xq8qGsOjkZP2HDvdC+I F/RemnkvpWo3QwTwkizYcSR7qBxRUV050le9KWDiY6PcS7NxUhPiBfHSDi+yVO1miMCWo2SB98I8 5F6ErscLu+bgaOq5jj6BGvlgqIi/kPZcx59egxeWTiKw4WC5F3LqG0C8YHDUIjiSpWo3QwS8l2RB alcGCI76vjo40tfcc0TT08qa4KWZ90IRL4iXhngpVbsZIpDaTRbM2lUWOqZNfXBk2FXjxdpG3kvG S3RjmBvF3fASfyYb97wXhXjB4KhhcLSZtXuCCMzaTdaClwBNAWO9atdc8zDMeDJ6GJp7L8be3XuZ t779HF4s4gXx0hAvYoOX9RLY2QLVLlUi40XXV47iKV4zXpSIl+W9wsuAeMHgqGFwtFHtniACqt1k gfciOTQFjPWLSOw19xxRGiSx9yv34hEviJeGeClVuxki4L0kCxaR0GWFvWL1eLnmniPKU1tDw8rR NLdOa3KnytEUr02j93QvAfGCeGmIl1K1myECi0joeY0aHRSkdmWox4u85tyL0FrFazPGHEqNJ7kI r9W9yPks5EWLSIx2xDsj7rSIxOiOeLOX2h0RL4iXhnjZqHaH9Tip2YLgaJQgq1O+OrVrr7mlkUpL tGmCFzo4rV0vkvRFXZx7ic+M1n0Mjnpl93UvGvGCqd1Wqd1StZshAsFRsiA4CiCrm3S17kWQa25p TD0RrIX3YhylzipnlOM6HroQLyY+aVYZ1XH9YzzZ6l4QL4iXVnhRpWo3QwSCo3CW1XEjAC/xAq/G yzVvCqCD0IHeL7xwxAvipSFeStVuhgh4L8mCnqN0JZ6Co0nXey/X3NJIffxNzf3Ci0S8IF4a4qVU 7WaIQM9RsmAJrNVLSyOvxgu95p4jGvwwhfuV2rWIF8RLQ7yUqt0MEVgCmyzIvbBhWQI71uPlqnuO xnjJ+PuFlx7xgnhpiJdStZshArkXdt4UIAYOeBH1wRG75k0BdGJGyyZ4aSar4xFBiBfESyu8bFS7 J4iAajdZJ7zky3EOjoZqWV1861yx9xJfajOOLfESv+jdwO/a0kj6ge+P8ka8IF6a4aVU7Wq27jma rWUJLEyrC1P1vBchr3qcVIwDvd8+MiH146TiQ1TgRRpnhVOD6yfnveP+MrxIY0Wnhn7qvOd+vzBt ES+Il1Z40ZslsOtpdbMFeAmQ2p2Yr8fLVY+Tiqc08vuFF4Z4Qbw0xEup2s0QAbyEc2qXag4d05zU 4+WqV9izqSfT/cILR7wgXhriZTNrV69bGmcLCtOSQMc0r94UIPRV7zkSKbp793hpmdqN3kuPeMGe o0Y9R7pU7WaIQGE6WYAXn5sCaBinau/FXPWeIzFKJu4XXjjiBb2Xdt6LLlW7GSKAF39uCpBsgml1 k6j2XsxV7zmSXJrpfuFFIV4QLw3xwja6l8msdS/TknvRSi6zdoda7yVeA1eNl5744d3jJQjHoh0c GVNtemCX4SUIFq/NQMZOkIHtd0wPiBfESyu8lKrdDBEoTCcLvBfCoHI0VDcFSHLNo7zTujiu7xde KOIF8dIQLxvV7gki4L0kCxaRWAWyOkPrvRdxzbkXRT2l9wsvDPGCeGmIl1K1myECi0iSBandMABe el6Pl2tuCiDKBqKa5F6ocn5yiqbC9GguHielOj8p2nk/VnRMI14QL83wUqp2M0QgtZss8F6iLwOq 3epR3pJe8yjveF2krU/vHC9auFE6Mjipk/QlXDhrV4vUsDDI+B6cwt6sXY14Qbw0xEup2s0QAe8l WT/oOZpCvfdCr1r3ouNbJrTxXqzTo2PWTTE+urhyFAGiR2a7aRR7laMB8YJ4aYiXUrWrjFildmdr ixcaxuqOacnVNXsvMTrSYxO85B3Tgxu0m8zddkwP3aAns1+Y9ogXxEsrvNhNcDSu8ZIsyL1MElS7 aqjGi7jmLY2E+MmrtnhRo5PirnhRo9yb9xIQL4iXdngxG9XuCSKAl2TBrF0xQMe0nqrxoqi65o7p MYRGwdHolExrAibr6MV7juL1qqTvu8lSsu+9BMQLNgU0agowm1m7Yj1OarYW78VnvEx2rMfLNY/y jl6BZnJ+naYpTPmLynkv80n0Az8YXjTiBfHSEC9s4734dXCULOiY9kHAQIYLvBd11R3To+xpE7w0 awqwiBcMjhoGR6VqN0MEOqaTBcMwrQXV7liv2lX2moMjLqbxnnkvA+IFvZeG3kup2s0QgWGYyYKe Iwaq3YiX6sK0vup5L9x6ae4XXkbEC+KlIV7kZhjmWrU7W+C9TNwso7zr8XLVhWnufXx57xVeJsQL 4qUhXkrVboYIeC/JWua9EEjt9vXBkbbXnNrlE5uGlrmXdz/KmxI/Il4w99Iq96I3817IOrWbLOiY HnoYhmlINV7MVXdMC90P6n55Lxzxgt5LQ++lVO1miEDHdLJglLehUDm6BC9X3TEteiqn+1U5EogX xEtDvJSq3QwRGOWdLEjtSrXoXlg9XuQ1V47EFOzQHC/G3h0vxu53TCNeMDhqFRzZUrWbIQKp3WQt wzBhhf3EWW1qV5GrltUpRifTEC+UOGGc7e+EF5quUtvvT6ubEC+Il1Z4oZthmKQYhrlaYc9GqByF qR4vVy2rU0NP7xleGOIFg6N2wZHdqHZPEIHUbrIAL3RZYW+qVbuKXnVhWnPjeZvUbvxqciTM37N3 GCelpviEUTvuBUcG8YLeS0PvpVTtZogAXuiq54j1gJf6PUeKq2ueVqeNHNqodgVxVrleO6qdudh7 ie9Bq3rdUW363dxLIIgXxEsrvIiN99Kv8ZIswIsdljVq1ZUjdd1bGo00fYPgiBrHg+uZU72TwY0X DmSgJl4ZPVN9J8ModnMvgSJeMDhqFRyVqt0MEcBLsmAgw0ChKcCHaryoq9a9WOLjRXuvCtMS8YLe S0PvpVTtZojAQIZkLfNeljVqvropQKmrLkzb+FKS+4UXjXhBvDTEi97Me1mvUZutH87arR8npfRV 516stWMDvAThbJ92kUjjvIycuXQRie3jlStN56WedlsaES+Il3Z4KVW7fJrW46SSBbI6bmBanVp1 TP8cXAw5/ArYzRc/+YB3/aICLsa73jrDnLZpGuY4XgYX43vbGaZt54dx3IeLQrggXFrBpdTsZoSA qC5Z0BLQcxjkzWUtXAxBuBxJsZvmmCJcEC5t4EJJqdjNCIGGgGRB3sVrUOz6qQ4uVh5+BckR4GIc pakkbZTjOh66EC4mPmlWGdVxrcy+54JDvLFm1KhmFJ+JMiw6IQTComTBAjXai2WBWiVcFIZFx4IL IwHnvKDn0sxzKdW6GSGwPo2eO6U5U9ApLVdyup+FSwIBwmVP7SKc7B2RbvRp9Su9cMoLFbKPr//o O+8p3y9HYyMjwqUZXEqtbkYIeC7JAs+FWYDLQGrhotBzOVQxWiFcEC4N4VIqdTNCwHNJFiR0vck5 l+D7WrhgzuVYnotGuGDOpWHOpdTpZoRAQjdZEBbRAZbWy7qEriBYLarcyshdRAwZnBjd5C/eysjT RTl0Ypz87lZGhAt6Lu08l41K94QQCIuSBToXMoHnEkKogwulmHM5FFwmhAvCpSFcSo1uRgjoXMiP aXSDUpVw4ZjQvUBEN1hnRxfuJqIbbGfHUCGiw+ELCJdmcCkVunRSK7jM1uK5LPukqyfTxVO76rm6 ZBCif/f7pG30XbQbRRrBEL/B2GV4sentN4r4TI+EsV0Z3YgNAIiXZnjZaHTJerbLbC0NABS2Asja 4Qvx1PQ1D76kzHB/v/DCEC+Y1G2X1KWbubp8PbZ7tqAcLXtoXwyqHi/mmtsXqWYy3C+8cMQL4qUh XkqdboYIFKSTBevq+VIz0rIaL5pdc3BEx5GN9wsvEvGCeGmIl1KpmyECuRd+rhoxzaANQPXVeDHm mvHCaNDTu8dLqhsp51Wa2e0HF9TFdSPV+dRy4Ye5+fnn60aIF8y9NMu90FKrmyECipdkLXgJMDqK jdWpXUuvOffCRM9sE7ycF74qN9g7L3xVw16HNCUjQ7yg99LKexEbvIS1oC5ZgJdBQuVoNNXei73q ubosTH5oiZd33wzAES+Il4Z42eh1TxABvCRrwUuAylF/gfdy3evqKZvo/QqOFOIFg6OGwZHa4CWs g6NkAV5GBYpdImvxEmOva56rywcVyLvHS5g1u2FIyjpJHbtw6UhImt0wxCtcUtbv514QL4iXZngp NbsZIoCXUa26jTR4L6x2K0DEi7xm70Vwy9n9wgshI0e8YHDUKjjazNU9QWTpN9LiR8Z2xwi/Fi/p 9b9ivJjJ922CI522vTLqgncDuTg40vHJZhE0fiD7uRfEC+KlGV7sZiuAWOMlWctOIwGpXa3qeqWp 0NhxVAUX4YJ2o3beOHt5O6Pogh51543da2cUZN6phnBBuLSACyObjUZivRMgWQtcPKheBlEJF0UV wuVIcAkIF8y7tMu7sM1k3RNCFrj4s+fiYdnrNFUOYqCKo+dyKLiMCBeES0O4sM3Y7vWq19kCuASo GU3cV8JF45SXw+ldJMIFw6JWYdFmsm5YV4xmC9bU9yP0GvWiFi4MJ+seCi4C4YJwaQiXUqubEQJL 6pO1eC4Al4mNlXAxDCfrHmpVWo9wwbCoYVgkN57LGi6zBVK6+NNgRX1tQtdgtehYcAkIF/RcGnou G53uCSEgpEsWeC4T8bBwhNXCxWBYdKiwaES4oOfS0HPRm/X0pFhPT5ZStCADbJAeaGVYFE8Q4XIk z2VCuCBcGsKl1OhmhGS4zNYy+tJDh5GpDYtwD+PBPBdGRoVwQbi0gstmru4JIcvgS3/uL5oEzHax Yy1ccA/j4UrRCBeESyu48I1C94SQJSwSC1wE85BzGSs9l/hUoUL3gt4in0R0Xtytt8h33nixP3gB 4YJwaQaXUqGbEQJhUbKWnAsHEZ2u1LkwggrdCxS6vncm3FWh6/vOhF2Frka4IFwawoVtci7crHMu fPFcqLeQc1FDreciMCw6lOdiEC4Il4ZwKRW6GSEwrjtZyzxdBSK6ntfCRWG16FCei0W4IFwawmU7 TVeR9TRdtVSLpAjguXhVCxdcT38sz6VHuCBcGsKlVOhmhGS4zNai0BWL/L86oWsxoXsouAwIF4RL Q7hsFbpi7bkkCxK6QoOITlSOXGAUu6KPFRZ5hAvCpSFcSoVuRggkdJMFYZEJMCyK9pWeC8PGxQt0 LtF5McqF6U46F0o6o8K0r3PRCBeESyu4lArdjBAIi8xqBwBb5P9cVnouTGJYVAMXOjolnR4dS39f Cpd4tSqp4yWb/tpd7opwwcbFVo2LvFToZoRAWMTO8n+pBMDF8Fq4YFf0seCiEC4Il3ZwEaVCNyME PBe1yrkwuSxHo7Vwwa7oY8FFI1wQLg3hslXoSrFW6MpzWEQnkP9PlcOiGMeu6GPBxSBcEC4N4VIq dDNCICxKFngu0ma4DFOtzoUz1LkcCi4W4YIJ3XYJXVEqdDNCwHNJFuRceO9zWETHWrhwTOgeCi49 wgXh0hAupUI3IwRyLsmC3iLBoHGxOufCcZ7LseAyIFwQLg3hUip0M0KgtyhZEBZZ0LlMQtfCBee5 HAsuHuGCcGkIl1KhmxECYZE961ykNJDQ1ZUzdJnAeS51Cl3uqHCGuBDiFxcrdHm8KONHQgh0T/4/ IVwQLg3hUip0M0IgLEoW7C3yAhoXqxO6AkcuHGuGLiWjQbggXFrBpVToZoTA3iJ/nkRHGZSiQ7C1 cMGu6H24GO966wxzg3WcO8kug4vxve0MG+LlzuenZkf+j3BBuDSDS6nQzQiBnAs7l6KVtjBD19NK uEhsXDzWDF2JcEGdSzudiywVuhkh4Lno87AooZbp/7ZWRKewcfESuMQvejfwu8El/sx+4PsJXYQL ei6tPBe5Ueiq9fT/2VoSuhS6orWu9FwUyv8vhIuKwdGd4aKGvZwLIaNFuCBcWsGFbRK6dN0VnSzw XDwDEZ1XlZ6L1VgtOtreoh7hgnBpBZeNQveEEPBckgVL0dSic5GmFi4Wcy4XlaL96Hp/11K0H3u/ n9BFuCBcmsGlVOhmhMBSNHXWuYiBwJhLUjmgm6e90wiXas+FppF0Yrib50LjBS2G/ZELCBeESzO4 lArdjBDwXJIFXdEGRHSBsTrPhadXH+FyILgQMg4IF4RLK7hsZuiatYhutjJcCJNQilay0nNhqHPZ h4v2TlFnuWO9E6ObwmVw0V7RznLWd2Kcwn4pGuGCcGkGl1KhmxGS4TJbIKIbOEyi81MtXHD6/7Hg ohAuCJeGcCkVuhkhIKJLFoRF4whwYZU6Fx5dF4TLkeBiEC4oomsootvM0D0hBMKiZC17i6alK7pS ocsFiuiOVYoeES7oubTzXBTZ7C2axHpv0bRUi9SoYIYuD7Vwwen/x4ILIaNHuCBcWsGlVOhmhID8 P1kAF6Vg5MJAKuGiOOpcqnQuzE2989zRGCKRi3UurIvXGu+oV2R/WBTCBcOiVmGRKhW6GSEAl2QB XBiHsEixWrjgyIVjwcUjXNBzaei5lArdjBCAS7KgWkRGENGFoTKhqxTmXA4Fl4BwQbg0hEup0M0I gWoROSd0xegBLqpyET3XWC2qg4tyXqVdrmxyY38xXFTnlVEdm2b57c6wqIBwQbi0gstGoXtCCCh0 k7V0RS8jF4baapHBrujLdkWL0Rl5113RYjRyP+eCcEG4NIOL2nRFr0cuzBbAhUrIuYTKAd3c4oDu w1WLRoQLwqUVXDYzdOl64+JsQUKXLOtcp8pqUXyDYbXoUDN0BcIF4dIQLpsZumQNl9kCuNilK1pX jlyIZ4YJ3UPBRSFcEC4N4VIqdDNCAC723BWthIfGRcpq4YK9Rftwkd6F3gXhNHUDc0ZfBhfpQ98F oWk3MKP35f8IF4RLK7jozQxdsc65zNaycTHAJLqpchKdoFgtOlbOpUe4oIiunYhO083GxbCe/p8s GLlAGcxzmXgtXBSOXDgUXDzCBeHSEC6lQjcjBEYu0POYS2kpdEXrykX0gmEp+lgDugUZJ4QLwqUV XEqFbkYIVIuSBZ6L0FCKjmdQBxdcilYpohMuaOd7p62jl8/QFV3Qvu+0pX63FD0RhAvmXFrlXEqF bkYIeC7JArhIlkV0k62coRvfmFgtusxzGZyid/ZcBkV3PReEC8KlHVxKhW5GCMAlWQAXvsj/va+F C64WqagWGWeFU4Ojk5PKiQs9F2ms6NRAp04q4XdL0QgXhEs7uJQK3YwQgAs/y/8JX3ZFG1YLF1wt ciy4aIQLwqUhXDYzdPl6V/Rsgc6FEtC5DJUbF4UimNA9FFwMwgXh0hAuG4XuCSGgc0nWIqKTEBb1 lb1FAndFHwwuFuGCcGkIl41C94SQRUQnzwrdMcAkOlOb0FU45vJYcBkQLgiXdnAxG4XuuBbRzRYM 6KYedC5hqvVcNOZcDgUXj3BBuDSES6nQzQiBAd30nNBlTENXtK0c0C00wbCoXucyMmf9XXUuI+us 39W5jAgXFNG1E9GZUqGbEQJwYSudi6KgcwmqFi4cw6JDwSW+eBThgp5LK8+lVOhmhEC1KFkLXGBY VCB9JVwM7oquW4oWnGJOc9dLN8mLl6KFTjHNu15Ocl9Eh3BBuDSDy0ahq9bzXGYL4GI4hEWycoau sCiiu2BAd6BO9870dxrQHSJmerM3Q3dCuCBcGsJlo9A16+n/s5XhwvniuXBZCxcU0R0LLmR+CyNc EC5t4FIqdDNCMlxmCxK6vM86l0BpXbVIxqcS4XKksIgjXBAuDeFSKnQzQiChmyzwXPwy5jKEWrhg KfqyhO44OmnumtAdR2l24CIRLgiXhnApFboZIeC5+POYSz5SENH1YyVcKFaLquBCjQujGyJlghMX L0WL13IYB9KxIMi+QhfhgqXoZqXoUqGbEQJwSRbAxRBI6I6VvUWSSvRcDgWXHuGCcGkHF1sqdDNC AC7JynDRHHqLQi8rPReGpehjwSUgXDAsahcW2VKhmxGS4TJbMKDbSpD/D5UiOsmxWlQBF+ModXZe 58p1PHQhXEx80mxa58q1MvthEUe4IFxawaVU6GaEwIBue4YLNwOMXKjOuQgcuXAsuPQIF4RLQ7jw TVg0mHVYNCwK3TTxEqb/11aLBJaijwUXj3BBuDSES6nQzQiBRfTJAriYEQZ0U1ILFyxFHwsuI8IF 4dIQLqVCNyME4JKsRUQH81wCmSpzLgJXixxrb9GEcEG4NISL2ojo1vNcZgtyLmQZ0M0qRy5IhYvo KxS68VDviHCWO2GdHS5U6BLax/es5Z2wdtgfcykQLgiXVnApFboZIZBzIed5LsL30Ftkaz0XjRsX a0vR3DpinekdlXcoRXNLbGd6Kvd7iyTCBeHSCi6lQjcjBMKiZC1hkQIR3TRUwsXgDN06+b9yXjsT 3Rbp2OXzXFTntbFdfGb25rkIhAvCpSFc7CYsUuthUcmCda7CQs4l2MqErsGE7rHgohEuqNBtptCN r0+5zvWEEFjnmqwFLgw8F145Q1dahmHRoXZF9wgX9FyaeS7xt9nAhYk1XNjZc7EeStGS1cIFe4uO BRePcEG4NIQL2yyi92u4JAvk/0MPCt3R18LFYM7laDoXhAvCpRlcSoVuRgjI/5MF1SIKi+iru6IV wcbFfbgo4ZiesdI7Mjp7YbVIifjmi1zpOzLaCp0LwgXh0gwuG4UuXS+iny2AC5/Ac9E8VMKF4jyX Q8ElxrQK4YJwaQWXjUL3hBCAS7Jg46KWUC2yvtZzEajQPVRYxBAuCJeGcCkVuhkhsHExWUvj4rQs RaucoauowJzLpfJ/Y+8u/zd2X6GLcEG4NIOL3jQuTmsRXbKWkQsLXDyp9FwoznM5FlwGhAvCpSFc NjN0zVRMolvBheeNi/FXqdxbpBjOczlW46JHuCBcGsJlM0OXrzcuzhbkXHiAda7jUBkWMVToHgsu 8cXTCBeESyO40FKhmxECOZdkgc4lCJj+L2wtXHDkQp38XztKUku0V05cLv/X6cm2nVdiT/5PES4I l4ZwKRW6GSGgc0kWwGUcoCtaVyp0FUf5/7HgwhEuCJeGcNnM0D0hBOCSLOiKZiN4LrRWRMdRobsP F2mcFU4NbuBuiF9cCBdprOjUMPBuEKqicRHhgo2LrRoXaanQzQiBruhkLSI6Agpd1ld6LgKHRR0L Lj3CBT2Xhp7LRqF7QsgioiPmPInOQFhU27ioIhwQLkeCS0C4IFwawkVuJtGZdSk6WUtYxJfeosqR C0rh9P99uHjhhEpH7eisd+bCpWheCNVRa8fOekP2wyKDcEG4tILLZobuCSFLWMTPvUX9Ui0ytQpd TTDncii4DAgXhEtDuGwUuv26WjRb4LlIAxsX+1qdi8Gu6GPBhZLJIlwQLq3gUip0M0LAc0kW5Fwo h65oVrnOVRNU6NYN6B6c1q4XzvdOXSz/j8+M1r3ofK/25P8jwgXh0hAuG4UuXYdFswVw0bCIftKm Fi6YczlWV3R88XqEC5aiG5WiWanQzQgBuOjVInpFFvm/CZVwkTjP5VBwoQgX9FzaeS5so9BV61L0 bIHnMp1L0bTWc8HeosPNc0G4IFyawaVU6GaEgOcynUvRXClI6Bpd6blQlP8fCy4S4YJwaQiXUqGb EQJwSRZUi4wEuPDahC5VmNA9VFe0QbggXBrCpVToZoRAtcisci4jAbioynkuOn6WIlz24MJEKhVF vjDqtHTDhZ4LE1p3hDPaaTlUeC4DwgXh0gouctO4SMi6cZGcS9GDgVJ0GCvDIokiugv3FvVu4Hfe W9QPfF/+j3DBalGzalGp0M0IgbAoWRkuxC7DoqbKrmgtOXouVSMXhAs6iVy8dtPlIxdEF7TvO6+n vd6iCeGCnktDz6VU6GaEZLjMFsBl0gAXKWo9F9y4eCy4xBfPI1wQLq3gUip0M0IALsmCnItQMKBb jLWeCyZ0jwUXinBBuDSES6nQzQiBnEuywHMJAXZF99VwwWFRx4ILQ7ggXNrBhZcK3YwQ8FySBXDh AkYumNqwSOHGxX24GO966wxzgrspuHBh46Lxve0ME7ybQthrXBQIF0zotkvo8lKhmxECcEkW6Fy8 h7DIyErPReEkumPBRSJcEC4N4VIqdDNCQOeSLMi5eJYbFwPntZ4LTqI7FlwMwgXh0hAupUI3IwRy LskCuDAIi6b4XquEi8Ww6FBwsQgXhEtDuJQK3YwQgAs7h0Vk0DCJTlVOotOaYlh0KLj0CBeES0O4 lArdjBDIuSRrGdA9edgVXdu4aLEUXVctUmljEdepg1H1F1eLVOcV1x2lqt+HS0C4YLWoVbVoo9A9 IWQZ0D0tcNFkGXPpQ11YNKMB4XIguHiEC8KlIVxKhW5GSIbLbEHOxRoIi6bKYVGGYM7lWF3RjEwj wgXh0goupUI3IwRyLsmCRfRDAM/FVlaLDBUootuFSxCORTs4MqbexYFdBpcgWLwyAxk7QQa2X4pG uCBcmsGlVOhmhMAi+mTBahHJYBKdqqwWGWoxoXup52Ls3T0XY/dL0QgXTOi2SuiKUqGbEQKrRZIF Cd3AclgUgq/0XBhDz+VQYVGPcEHPpZ3nIkqFbkYIJHSTBZ6LhlJ08LbSc2EGq0WHgsuIcEHPpaHn Uip0M0LAc9HnUrSaKAyLErXVIo4jF+qqRdrRGBBpR7wz4uJqkY5PttEd8UbsJ3QnhAt6Lq08l1Kh mxECOZdkZbjISUFX9CQrwyKOOpdjwYUjXBAuDeFSKnQzQjJcZgsaF/sePJcx1MIFRy4cq1okEC4I l4ZwKRW6GSHQuJgsgAuRABdZOUPXCBy5cCy4KIQL5lwa5lxKhW5GCMAlWcsMXQYjFxirhQuOXDgW XDTCBT2Xhp7LdobuuhQ9W5DQNXmeCxmmykl0RgjMuezCRQk3xEPGKe8kdWy4DC5KDBEfRvlOUjbs 61wQLgiXZnApFboZIZDQNed5LqrvIaFL+lq44DyXY8GlR7hgWNQwLNoodE8IAbgka4GLgjGXvaiF C/YWHQsuA8IF4dIOLpJs4KLWpehkLdWiEeT/hlTmXCTOczlWKdojXDAsahcWSbqpFo3rMZfJgpEL VC+Ni7U6F6kwLKqf/j/F7xmnyZ2m/0/xyjR6b1jUhHBBz6Wh51IqdDNCYORCsiAs4haGRfU1jYuI lUNh5SffCIgVxMo7wMpGm3uCBwREyYIi9EjBZyFVRWhMtByKKxS5grFQw1iolOVmekD9OVkLVwxk cVVNQxGWno/FFY5cQa405MpmZu64Xjw/W8u0fwOiOT9UcAWrzsfiikSuYBzUMA5Sm0H/Zr25NVnL dIVhaYCuUfrj2JZLt7Yyp8Sdt7YytVcUGhEsCJaGYNGbyQqDWU9WGM4OCx8hbytrhvwnQS+C5UBg mRAsCJaGYNmMyT3hAzyWZAFYRA9LFT2viIRQxnKhjIUOTt5ZxkIHKfZLQgzBgimWVimWUoCb8QFg SRaARUqxDJqr8FgUeizHGjJnECwIlnZgUaX4NuMDwJKsBSweJlhSXeGxKI0ey8FG4yJYECztwEI3 YPHrUChZoOoXNodCE60JhTTB5O0FYIlf9G7gdwNL/Jn9wHcV/QgWBEs7sJSi24wPUPQnC1QsYgB1 XKipNmuGodChwBIQLAiWhmApZbcZHyBjSRaEQmrZztrXTK3UOGv7WKHQhGBBsDQES6m7zfiAUEid N7OeLpqTPq4meatxzvYFYKHECeNsfyew0HR92n6/KsQRLAiWVmDZCG9P+ACPJf2BIf5hEd7yGo/F YKfQhaGQcoO9cyikBruv6EewoI6llY5FlcrbjA8Y4B/Oyls2URDIhbq9ZhLJsksWGd0U4dTg+sl5 77i/jCzSWNGpoZ8677nf3Tt0etciWdBlaeGylNLbzA/I3iYLNP2WQVmI181jwYLzscjCkSxIloZk KbW3mR8g6k8W+CxhAu2tGGrIQjn6LPXi2xBjosF5cifxbYgh0eD3+hA1kgXJ0pAspfg28wN8lmRB /tYvAyoHU0UWrAwdbWg/kgXJ0owsulTfZn5AAtefp1Nye16UWJVnobgl8WgT+5EsSJZ2ZCnlt5kf mSyzBXmWkLckkinU6PppeumRLIca149kQbK0I0upv838gDxLOK9IVNRABtf4KrLgfsRjZXADkgWr zu2qznoz95audXKzBT4Ls6CTm2rGslAuMBraJYs2Lqg0Ro7oJJST6jKyaBNUUtbqLi1G2N0ZP4t0 kSzoszTxWUoFbuYH+Czs3DOkJYfaEKvaX8Y11oYORRaFZEGyNCRLKcHN/IAVIMmC2tDEQSmnVY3P InAyS1XVmVI3STcZN4iImEurzvFJm+RkukFMZD+Di2RBsjQjS6nBzfyA2lCyQM9CSZ7MMlUNqaQS a0PHyuBGEigkC+ZZWuVZNhrcEz9Az5IsaBuiFKrOk63aL4S1oWORRSBZ0Gdp6LOUGtzMD+gbShZE Q1pkpdw0kpo8i8KOxGORRSJZkCwNyVJqcDM/IBpKFpDFLHucRVXfkMLtZccii0ayYDTULhoyGw2u WS9xnq2FLD1kcOMrUUEWzZAsu2Qx3vXWGeb45Bh35MLxLMb3tjOMTx3jZG88i0eyoM/SzmcxdEOW fp3BTRaQJUjI4PZVtSGtMM9y6UQ5Y+8+Uc7szWcZkSxIloZkKTW4mR9AlmQteRbQ4Ia+ZgYu1ahn ORZZJiQLkqUhWTZDcPVagztbUBvyAchi+xqyGFy6eqwpuCwp6pAsmGdplGcpNbiZH1AbShaQZeTQ kah4FVlw8tOxyCKRLEiWhmQpNbiZH0CWZC0+i4X5LLKqI9HifJY6DW78anIkzN+7OBqiERtTfMKo He2+BhfJgmRpRpbNHNwTPxafxZ63I/YEyKJYFVlwdP+xyDIgWZAsDclSanAzP2AnSLJg8pPRUHVm NXoWRlApVzetUrignR+cGu+yKl50QfuhU+PuqvgRyYJkaUiWUoOb+QGTn5IFtSG+9A1xXUUWnM9y LLJMSBYkS0OybDS4fN03NFsQDfElgzsaWUMW1OAeiyzxXgbJgmRpRBZbanAzPyAa4ucMbiQKzJRT ospnsRgNHYosHMmCepZ2eha70eCSqViReJ7dr6hYMrg1k58YpRgNHYosAsmCZGlIFraZVrnuSJwt IAtX4LMEX+OzUJxWeayORIVkwWioYTS0mYN74geQJVkw+YmcNbi0ymdBdf/h9g0hWZAszchSanAz P2DyEwmraZUDRENV0yoZtRgNVUVD3IngGJ2jofHiaIh3IjCaoqFxhywWyYJkaUgWuZlWOaznsyQL akNEQW1ooDVkYQRrQ0fbZIZkQbI0I0upwc38gNpQspbZ/bB9dbJVGVyGHYmH22SGZEGyNCOL3szu X29fna1F3S8gzzJUaXAZzu4/Flk8kgXJ0pAsZqPuF2St7hfnqjNnkGchocpnwV7nw01+QrIgWZqR xW5qQ2xddU4WkEVQkfuGqjoSmUCl3CVkiV/0buB3I0v8mf3A930Wi2RBPUsbPUt8d5RkOfEDyJIs IItmEA35sSYakjgHt67XeXRKOt+7yTp6+SazsVPS991kKdn3WZAs6LM08lk4KTW4mR9AlmRBr7Pl MLvfhyqyoFLuWGSZkCxIloZkKTW4mR/Q62zP21eF4GLxWWqiIYkTto9FlnivHsmC0VCraKjU4GZ+ wMb4ZAFZerpsjO+ryIIa3GORhSJZkCwNyVJqcDM/gCzJAnW/pxANyaEmGlKoZzkWWQSSBcnSkCyl BjfzA9T9fkWWATK4U526X0n0WY7WkYhkQbI0I0upwc38ALIM5wyupB6mVdqqXmdlsDZ0tI5EJAtm cJtlcPVmY7z3643xfpkpp9Si7qc121eZJhgNHYosFsmCPktDn6XU4GZ+QNVZndX98W0AHYm2qiPR 4Bzcul5n5bxywjozuOAv7nVWnVfCdmYIfj+DOyBZkCytyLKZgyvW0ypnCzoSmYUJ27Yqg2ux6nwB WbR1PYnP6J3Iom1qZCb7PguSBaOhVtEQLTW4mR/QkZgsqDoHmPw0jVWz+y1WnY9Flh7Jgj5LO5+F lhrczA+oOofz5Cc+LjPl+podiZxg1flY21cDkgXJ0pAsGw3uuCbLbC17nTVkcPuaaZXzOxXJciCf JV6LHsmC0VCraIhv9jrr9fbVZAFZJmZy1ZmKKrIwzLMciiwcyYJkaUiWUoOb+QFkSRbkWZRc9g1N oYYsuNf5cEo5JAtGQ82ioVKDm/kBeZZkLVMUAsxnYazKZzEYDR2KLBrJgmRpSBa1maIQ1nqWZMG0 Skuh11nW6Fl4eumRLMfS4CJZkCzNyFJqcDM/YFqlPU9+olRCnkVPNT4LQ6Xc4Wb3I1mQLM3IspmD e+IHkCVZoMEdBPQ6M1JDFo5KuQuqzpQ4oV2427RKGi9QHfh+bSggWZAsrciy0eAO6wnbswU+i6Tg s9ihiiyolDuWnoUjWZAs7cjCSg1u5gf4LMmCqnOYQN1vajS48bywNnQoskgkC5KlIVlKDW7mB1Sd k7Uo5YZcdR4mW+OzCNwKsk8W411vnWFOcDcxx8RlZDG+t51hgndTWhy32zeEZEGyNCML2yjlBrJW yg3nvc491IYmJqt8FpzPciyy9EgWJEtDspQa3MwPyLP059oQj+5LrjqPqsZnkaiU2yeLNM4KpwZn x1Qh4hdOUZDGik4NduxGw/emKExIFiRLQ7KUGtzMD+gbShZMUdAi51lC1V5nLlEpdyyyxHuNSBYk SyuylBrczA+YopAsyLMMDMhCq2pDimJtaD8aimSZ3NSnfwNz44V6FmPs1E391HeBjcN+1RnJgn1D rfqGWKnBzfyAPEuyFj3LBHkWUxUNKVTKHYssHMmCZGlIFr3Rs0zrPEuylmjILxvja2bKcaUwGjoU WSSSBcnSkCxmEw15sY6G/HmKgln2Oosqdb8yqME9VJ5FIVkwz9Iwz1JqcDM/IBoy560glCx5lqlq 8pOymGc5FFk0kgXJ0o4sfKPBJes8y2wBWUadZ/eHocpn0QyrzofqG7JIFiRLQ7KUGtzMDyBLsmBH IhXQN+THmjyLxo7EY/U6D0gWJEtDspQa3MwP2JGYLCBLfJuBut9U+SzYkXgssngkC5KlIVlKDW7m B5AlWQtZPHQkcl7ls1isOh+KLAHJgmRpSBaxIct6++pswRzc+UeelHK8xmcxuBXkWGSZkCxYdW5X deabObgnfsAc3GQBWbhZJj9VZXCNwDzLocgS7zUhWZAsrchSanAzP4AsyYIJ232uOtOgqzK4Bqco HKvqzJAsGA01jIZKDW7mB0zY7tkqGgpL31CVut/gFIVjkYUjWZAsDcliNtFQ8OtoKJzJogyQpe9r yGI51ob29SzGUeqsckY5ruOhC/UsJj5pVhmVivxmX4OLZEGyNCOL3ewbMmuyJGvpGzKglONVGtxE ASTLgciikSxIlnZkEWTTN2TMum/InHck8gHyLLxqDq7F+SzHIotFsiBZGpKFbjK4w9pnSRZkcImF 2pD3FT6LILjJ7Fhk6ZEsSJaGZCk1uJkfkMFNFpDFUNjrLH2oIQvOZ6nqG6LK+ckp6rx346VkIVR1 flK08340+xpcJAtWnVtVnUWpwc38ALIkC+bg+gnIEkKVzyKwNnQonyUgWdBnaeizbObgnvgBc3CT BT4L0xANDbzKZ8HJT8ciy4hkQbI0JEupwc38AJ8lWZDB1QRmyvm6aAjnsxwrGkrPLJIFydKKLBsN 7okfkMFNFvgsdomGzFRDFnphRyLpM1mI/UmyyHAPyTI4rV3PXEhrEi8my9Bp3bMupMnoe3qW+0eW /9brOl9BG62pXXv9swX5BKugp9fWbEYX7MIto3gFveMrSOMV9E6uoFJTma8TiJuTBconZbPyaRpD zWcQu7B3Fa+gd3wFGbyC3skVVGoH83UCCp9kLdpBqJaFMFZdQRf2aOIV9I6vIItX0Lu4guRWI7eu Cs0W7AORSuTcLamqCjGp8Ao60hXU4xX0Tq6gUguWrxPYe5EsuII0Af06qcokcILVj/pJryJdPo7I O016FSLJMeRuXRVzlJijbJajlKUWLPMDyJIsIIsZgSyTrSILx8/mQ302T/jZ/E4+mze7v0/XCVxB yYIp7P0AGRZes6FXCNRpX/zZbOzdP5uN3e2H/wnM4mczfja/g8/mUvOU+QFT2JMFn80KJpoGxqrI gmrKY5FFIVlQp91Opy1LzVPmB/gs6jzRlKkeyEKq1JQC1ZRVZGHCBe187wx19GKvn4kuaN93htKK uiqSBcnSjCyl5inzA2YlJwsUG2yZDkZqJm0ISbG37FCZyh7JgtFQw2io1IJlfoCShZ2ng3EO0dAw 1UzaiO9K9Fl2yaJ9Umhb7ljvxOimcBlZtFe0s5z1nRinsNu1imRBsrQjy0Yjx9fR0GwBWeTSW6ZI FVlw292xyBKQLEiWhmQptYOZH0AWee4tk0yA8slWzfCRuO3uWGQZkSxIlnZkUaWmMvMjk2W2IINr POg2qKnxWRTB2tChyBJNhmRBsrQiS6k1zfyADG6yIBrqA/TDy5op7ELhtrtjkYUiWZAsDclSak0z PyAaShYo5aZlJ9VYpWJXEqOhQ5GFI1mw6tyu6qxKDW7mByjlpvNOKkot5FlC1QwfhTupjjXDRyJZ 0Gdp6LNsNLgnfgBZkgXRUOgFVJ2relc1dt5doGehxBnhprtpcCmJF/dUocFFsiBZmpGl1OBmfkA0 lCyYOxjoopSr6hvSDKvOhyKLRrIgWRqSZTN38MQPmDuYLJhYIyYBM5+qqs4at93VqftjNKScJU5I N7GL1f0xGlI2XqAyvTn3JtYgWZAszchSanAzP2CST7KWDC5EQ5PUVWRRmGc5FFl6JAuSpSFZzCaD u46GZgvIEpYpe6pq0qvGPZrHioYGJAuSpSFZSg1u5geQJZynD4pgwWcxVfM7DW672yeL9C70abaR pm5gzujLyCJ96LsgNO0GZvS+BhfJgmRpRRZNNnmWdW1otkDdT3rY7zBVTVFIS8SRLAfaSRXf9RzJ gmRpRZZSg5v5Aer+ZAFZrIGZcrZKg2sZ5lkumKIQv1BuuOPkp/gz1bAXDQkkC5KlIVlKDW7mB5Al WUCWnix5FlVFFpyicCyySCQLkqUhWUoNbuYHkCVZS21oXDb01uhZJNGYZznajHokC5KlGVk2GtwT P5ba0Hje/T1Ik8nC+4o8i2Q4rfJY6n5LqECyYN9Qo74hvdn9feIH7BdN1kIWqA2FSdb4LByjocuq zsLGL+5adRZWT/u1ISQL+izNfBa1Icu6NjRbQBa5aHB9qCILTn6qU8pxR4Ujw9zr7C9WyvF0RQ6p 19nvz2eRSBYkSyuybHaiy7UGd7aALMLATvTJVJHFYp7lUGShSBYkS0OylBrczA8gS7Jg35Dvl13x qibPInDy07HIwpEsSJaGZCk1uJkfsG8oWUCWwEApN9b0DUmBk5/2yaKEG+Ih45R3kjo2XEYWJYbI DqN8Jykb9qvOSBYkSyuymFKDm/kBZEkWkGVa9CxWVPksOPnpWGTRSBYkS0OylBrczA8gy7TSsxDo dQ6+Rt0vJU5+OhZZDJIFydKQLKUGN/MD9Cxk1etMKczB7Ws2mUlFMRo6lFJuQrIgWRqSZTMHl64n P80WkEVNkMGlsoosFsmySxbjXW+dYclzsaML42VkMb63nWHRcbFjGPf7hhSSBcnSiiwbDe6JH0CW ZMG+oSmAuj9UVZ017nU+FlkkkgXJ0pAspQY38wP2DSUL9CyKA1nkVEUW7HU+FlkUkgXJ0pAsGw3u iR+gZ0kW9DoLBVVnUqVn0aiUOxZZeiQL9g216xsypQY38wN6nZMF0RCB2f2ToDVkMaiUq1PK6dQ0 xAc3UOfJxUo53VHCh25Ir87Pk8UjWdBnaeizlBrczA+Ihsgqg2sskIVU6VmMwJlyhyJLQLIgWRqS ZTMH98QPyOAmC/Is3iyz+4eaPItBpdyxyBJNjWRBsjQiiy01uJkfkGdJFuwboj3oWaaqaMiiUu5Y ZKFIFiRLQ7KUGtzMD9g3lCyY3T8MoMEdaqKhuRKBZDmQUs4gWZAsDclSanAzP2B2f7Kgb0iMS56F yhqy4FaQY/ksFsmCZGlIllKDm/kBfUPJWraCBNjrbFkVWQTmWQ5Flh7JgmRpSBax2QoS/HorSFjI wgQ1QBZeFQ3hHNxjRUMDkgXJ0pAsGw3uiR9QdU7W0pG4qPu1qfJZcJPZPlmCcLZ3jDhpnJcXz8EN wvbxopWm83J3Dq5HsiBZGpJFbToS1+r+2YIMrpVQG2I1GlxFUYO7TxbtnQpOMae566WbLvRZtFeh U0zzrpfTns/CCTVIFiRLK7KUGtzMD8jgJgvI4tWyI3GqIYvAXucLN5n1buB33mTWD3y/b8giWZAs rchSanAzP4AsyYI8iwYNbmA10yqVxI7Ew1WdkSxIlmZkKTW4mR+QZ9FnDS5RFqZVDjWTn5RUmGc5 FFl6JAuSpRlZ4kmXVecTP6DqnKxldv8yRWGQVT4L5lmOtdfZI1mw17lZr3P8XTez+9dTFGYLyKKX mXJ8rPFZFPY6X6Bn0aMjwVFxJz2Lju+oMC9A3NmRiGRBsjQjS6nBzfwAsujzTDk6jKDuV7aKLNjr fAFZGHXBu+FuSjlGu+CHPaXchGTBaKhhNLSZg3viB1Sdk7XMZ7FLr7OviYYU7hs6Flmi2SNZkCyt yCI281nWe51nC3qdFYM8S1+VZ1E4ReFYZGFIFiRLQ7KUGtzMD+h1VudNZvEtA9EQ4zVk0ThF4Vh5 Fo5kQbI0JEupwc38AJ+FnuezsMCh19mIKrJwjIYORRaJZMEMbsMMbqnBzfwAsiRrmSk3ZXV/fK9W kUVi1flSPYuxd9ezGLuvwUWyoM/SzGcxm5lyk1/PlJvOZAnc5DyLqNkKogxOfjqcUg7JgmRpRpZS g5v5AWRJ1kIWDbWhUNU3ZHDy0+GmKCBZkCytyEI3c3BP/FjIos97ncclzzJVRUMGOxKPtTF+QrJg nqVdnoWWGtzMD9CzjOc8CxkFTFEgVfNZLG5fPRZZlqcRyYI+SwOfZaPBPfEDNLjJgmho7KEj0fY1 0ZDFXudjkYUiWZAsDclSanAzPyAaShb4LAMRsDG+SoNrsdf5WGThSBaMhhpGQ6UGN/MDfJZkwYRt ZkCDy1mFz6IJ9g3V6VmU88r11A3GMX+xnkV1XvW0Gwzz+/NZkCzoszTzWUoNbuYHTNhO1tLrPCx7 nWs0uJpg39CxyGKRLEiWhmRRm17nYZ1nSRb0DYkBZvdLXUUWjRncQ5GlR7IgWRqSpdTgZn5A31Cy ltqQh76hcaoiC3YkHossA5IFydKQLGZTG/LrPEuyYMK2VFAbIr4mz0IZ5lkORZaAZEGyNCRLqcHN /IAJ28layBJA3e9NFVmwI/FYZBmRLEiWdmRhZEOWsJ7dn6xlK8i4bDIbqsiCHYnHIsuEZEGyNCQL 3WwFGdc+S7IWdf8E0ZDWVWRRmGc5FFmWZwbJgmRpQBa2UfdP6x2JyQI9i5qgI5EMNRlchttXj0UW jWRBsjQkS6nBzfwAPUuyIBriAmpDdWTh2Dd0OD0LkgXJ0owspQY38wOioWQBWYYlGqrT4HLsGzqc ngXJgmRpRpZSg5v5AWQZztEQ9RK2r1btddaRSkiWg+lZkCzYN9Sqb4iVGtzMD8iz+PPGeBrMMlOu qjbEsSPxWJOfPJIFfZaGPkupwc38ALIkCyZsSwLqfktq8iwC1f37ZJHeSeuEcWRyw+RCuIws0ser Pj5RUzdMIez3OgckC5KlFVlKDW7mB0zYThaQhTPYvmqqMrgSt4IciywSyYLRUMNoqNTgZn4AWZIF HYl0BJ9lqtLgGoIZ3AuiIZaioYneLRpiMdSZ6P4UhRHJgmRpRBZeanAzP6AjMVnLTDkGeRY51vgs BjsS98livOutM8wNypngrLqMLMb3tjNsUJ0JVu33DSFZkCzNyEI3M+XWPstsQTQ09melXI3PYrEj scpnodKlv3sXuAsX7xui8rSvOfBg99X9SBbMs7TKs/BSg5v5AdFQsqA2xJetIL2oIguq+4/ls8R3 7oRkQbK0Ikupwc38gNoQP28Fic8/6FniBb5PlhjVY6/zoarOEsmCZGlIls0cXLLeCjJb4LNYDxlc rqrIItBnORRZNJIFydKQLKUGN/MDfJZkLbUhDrP7+VRFFuxIvIAslDijXJjuRBZKOqPCtN83hGRB sjQji9rUhrhY14b4uW+oXzS4sibPYgjuSDwWWXokC5KlIVlKDW7mB/QN9WcNLmfLJjNa5bNQ7Eg8 Flk8kgXJ0pAspQY38yOTZbYgg0sV+CxVVWdDsW9onyyTcXSMQElHiXbDhbWhycRLNUxj/Jl62KsN jUgWJEtDspQa3MwPyOAmC6KhcYLaEB2ryGKxb+hQZIlvU4JkQaVcI6Wc2MzBPfEDoqFkLR2JMPlp YjXqfsNwk9klehbrOHeS3U3PEq91Pj81P0cWgWRBsjQkC910JK4nP80WqPuJhx2JMaavIAs32JFY pcGdks+ilZu0k/piDe4UfRatuklLvZtnQbJgNNQsGhKlBjfzA9T9yVp2JGqIhmTNFAWTng8ky4HI EpAsSJaGZOGbHYnar3ck6oUs8eeAUs6bKrKgBvdYZBmRLEiWhmQpNbiZH1AbEuf5LLxnsG9I9jXR kOCYwT0UWSYkC5KlIVlKDW7mB5AlWbAVxEuoOvc10ZDF+SyH6xtiCsmCZGlFllKDm/kBW0GStczu 1xANjTU+izVYG9onixKpKjQap7yT1LHhMrIoMUR2GOU7SdmwO/kJyYJkaUeWjQb3xI9ldr9e6VkE +CzGV5EF5+AeiywWyYJkaUgWs9GziDVZkgXREOewycyTKrLgTLljkaVHsiBZGpKl1OBmfkA0xM8d iZJryOAqXkMWixO2j0WWAcmCZGlHFkk2ZNFkTRa9ZHCZAp9lolUZXJxWeTCyeCQLkqUhWTYaXLX2 WWZrIcsyu3+smSlH4wuGiZaqJYk6dToz77xxXly8JFHHp5r5zhsvdhcOMY1oQbS0QstmEK5aD++f LUBLr7IId5h0HVoUxkMXzVEQozPyrnMUxGgq6s6IFkRLM7SUKtwMEEBLskArpz1Uh6o2DkW04Fi5 Oq9FuKCd7+ch25evdhZd0L5PQ7b3VjsrRAuipSFaNjJcvR5YOVsntOSLZkaLrgyIcK7csdCiES2I ljZo6d9+SVwX/37x9vsXb1+GF+F1//KV6159E+Ipfu+J9Dre1nXxe/Hpi////q8vwvjt2y9/R34z G/0XX7w+H3njvxzD7+hvum/7v72JX8VDX363usfLV/6br79NXw39dy++HPsAX7/tX371OxIfsn/x 5m3/+u3vfhsf5dXLeF5vxr+++Z0y7BgXp8eLEy/ONhfn4w+eP//oYfyYftsNL992jHXfTN2DZy+e 3z54EY+T7wfjqTJKra9j/2X/6sWb8a3rVPcrJrjuHv/hf/+mm77qv3gT78LSx/Wv4x1eS0bZ87ff fPvw6/7Z6MeXfx9dF77uuyleiGPo3n7TvYnfjVdsdBG+fvP+e/EH3zz7Hfn+9JHJxHzk4UcPfv/i +V/iYcHmwyemvEh3fT36v7vu9ffdX/82/i3RxEqrWbzcv3r56r+65MbEA0rFezz7vCsqSen4OXI6 WSf35vQQuTM6OR7d/wRvYMp/Tp/q6Vt0oCL+F/LnvPGl40C1yjem6cZTGt0dnarT/370i+wu8PXz nX7Tt9/HJy6xMf+qn9v/7JbfcwPZdPvNrclFt6b/2c09nfE6WD2VpwP792YX/Sx+0a3NT9z6CE/R kZ6ZS67r11JQ9XR8fdN/9XJ43b99+c2rT1z3yYedPx/owsvw6n+87aaXr16++fLfuzB+1f/j5asv upubB++/9/57/9/7733+6Mlt9G778Ppl/+r/+bp//fKrf7xyv/ycfv1vX37z9fhvp2/88vOv//Nf uv/34S9+MX7/8u3777333L9++e3bLnzzauziz/lL5MLj/nXX6Y5qx1M7Wlo2xd77/wEq/SUAW+EH AA== --047d7b10d1b19b60d004bac3fe34-- From owner-freebsd-wireless@FreeBSD.ORG Fri Mar 9 09:40:10 2012 Return-Path: Delivered-To: freebsd-wireless@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 71A0E106566B for ; Fri, 9 Mar 2012 09:40:10 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Received: from mail-lpp01m010-f54.google.com (mail-lpp01m010-f54.google.com [209.85.215.54]) by mx1.freebsd.org (Postfix) with ESMTP id E65D28FC17 for ; Fri, 9 Mar 2012 09:40:09 +0000 (UTC) Received: by lagv3 with SMTP id v3so1955054lag.13 for ; Fri, 09 Mar 2012 01:40:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:date:x-google-sender-auth:message-id:subject :from:to:content-type; bh=7ed7shQBAhOH8f9wNUecvPJt9lfw0bi8D68YMcd3/1s=; b=G87OUQ8mfzxNopXYtbmOTA14dyWzuUatMbGp+ul/aqhcnschvwG45y2yF4ZecHJzrG fUsNbREOBUc0cJ9qaAI9cz2QNHD5SHpK8WqdTbOtwbhXBRxrNTd68Ms9zuvBmxPuMXdl ZzpqzpBmVlR8NZXwvHzEkTgYgsPQPltdK78+3UJrbNQ2d+gvUWfJfrKNrRB+mDekqNXD B4rMXz+akOkRcFaorl/nnOta8czLhC4HXRwLewVWtx2vbNVMewzXlRvLqS7iqszis/ih yl35KXz2glOi9pXnoS8tYiMqONsnbi4JKxDF3hlmfze1qNEiJ1QnmVbAM+G2SMjjZbRi EqoA== MIME-Version: 1.0 Received: by 10.152.148.230 with SMTP id tv6mr1119777lab.12.1331286008645; Fri, 09 Mar 2012 01:40:08 -0800 (PST) Sender: adrian.chadd@gmail.com Received: by 10.112.13.18 with HTTP; Fri, 9 Mar 2012 01:40:08 -0800 (PST) Date: Fri, 9 Mar 2012 01:40:08 -0800 X-Google-Sender-Auth: EL7EDPEFgCuaIblZ10cTS5bLYyg Message-ID: From: Adrian Chadd To: freebsd-wireless@freebsd.org Content-Type: text/plain; charset=ISO-8859-1 Subject: (more) bugs fixed in -HEAD, AP mode is now mostly (again) stable! X-BeenThere: freebsd-wireless@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussions of 802.11 stack, tools device driver development." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 09 Mar 2012 09:40:10 -0000 Hi all, I just fixed a rather silly/ridiculous bug that I introduced into ath(4) when I reworked the reset path to not just purge frames during an interface reset. The 11na/11ng stuff is now stable again. I didn't notice it before because I didn't have enough background traffic _and_ interface rests. Silly me. :( In any case, if you've been waiting to upgrade to a -HEAD checkout to do more 11n testing, now would be a good time. Just remember to disable background scan or things will definitely hang on you. Next - BAR handling and correct queue pause/resume handling. Then I can flip it on by default! Adrian From owner-freebsd-wireless@FreeBSD.ORG Fri Mar 9 10:38:19 2012 Return-Path: Delivered-To: freebsd-wireless@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 549C91065673; Fri, 9 Mar 2012 10:38:19 +0000 (UTC) (envelope-from vince@unsane.co.uk) Received: from unsane.co.uk (unsane-pt.tunnel.tserv5.lon1.ipv6.he.net [IPv6:2001:470:1f08:110::2]) by mx1.freebsd.org (Postfix) with ESMTP id BCE4D8FC18; Fri, 9 Mar 2012 10:38:18 +0000 (UTC) Received: from vhoffman-macbooklocal.local (lon.namesco.net [195.7.254.102]) (authenticated bits=0) by unsane.co.uk (8.14.5/8.14.5) with ESMTP id q29AcGU5018837 (version=TLSv1/SSLv3 cipher=DHE-RSA-CAMELLIA256-SHA bits=256 verify=NO); Fri, 9 Mar 2012 10:38:17 GMT (envelope-from vince@unsane.co.uk) Message-ID: <4F59DD98.8080905@unsane.co.uk> Date: Fri, 09 Mar 2012 10:38:16 +0000 From: Vincent Hoffman User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:10.0.2) Gecko/20120216 Thunderbird/10.0.2 MIME-Version: 1.0 To: Adrian Chadd References: In-Reply-To: X-Enigmail-Version: 1.3.5 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: freebsd-wireless@freebsd.org Subject: Re: (more) bugs fixed in -HEAD, AP mode is now mostly (again) stable! X-BeenThere: freebsd-wireless@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussions of 802.11 stack, tools device driver development." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 09 Mar 2012 10:38:19 -0000 On 09/03/2012 09:40, Adrian Chadd wrote: > Hi all, > > I just fixed a rather silly/ridiculous bug that I introduced into > ath(4) when I reworked the reset path to not just purge frames during > an interface reset. > > The 11na/11ng stuff is now stable again. > > I didn't notice it before because I didn't have enough background > traffic _and_ interface rests. Silly me. :( > > In any case, if you've been waiting to upgrade to a -HEAD checkout to > do more 11n testing, now would be a good time. Just remember to > disable background scan or things will definitely hang on you. > > Next - BAR handling and correct queue pause/resume handling. Then I > can flip it on by default! > Excellent maybe its finally time to take the plunge and move to -HEAD. Any other advise than what's on the page here http://wiki.freebsd.org/dev/ath%284%29/80211n* ath0@pci0:4:0:0: class=0x028000 card=0x10671a3b chip=0x002a168c rev=0x01 hdr=0x00 vendor = 'Atheros Communications Inc.' device = 'AR928X Wireless Network Adapter (PCI-Express)' class = network *Its only an atom box so it'll take me a while to pull myself up. Vince > > > Adrian > _______________________________________________ > freebsd-wireless@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-wireless > To unsubscribe, send any mail to "freebsd-wireless-unsubscribe@freebsd.org" From owner-freebsd-wireless@FreeBSD.ORG Fri Mar 9 20:13:06 2012 Return-Path: Delivered-To: freebsd-wireless@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 5BE661065706; Fri, 9 Mar 2012 20:13:06 +0000 (UTC) (envelope-from nlopes.ml@gmail.com) Received: from mail-vx0-f182.google.com (mail-vx0-f182.google.com [209.85.220.182]) by mx1.freebsd.org (Postfix) with ESMTP id EE6EE8FC12; Fri, 9 Mar 2012 20:13:05 +0000 (UTC) Received: by vcmm1 with SMTP id m1so2097886vcm.13 for ; Fri, 09 Mar 2012 12:13:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; bh=cTZe/bblYRNLRSuEeztbkIlPFtL6mJIsH8nSjtGtnmw=; b=C7RSYcMqDVXvTZnJUPuU71A1UHELB4ITjk4GaXpooMUQPWIUpa9n9bGzSSH5+AA2rE XzSfanKbae8OzefMWOdr7N2y81RgNo3/T1n91UuekOgmDl+4yVM4/T8Jt8s+hzDE23dt Jk/oP1wfl9corr2T67d2S2lDNMSPZkBNvvzpPGkNywLtJmuJImelSXCOzLbDKGiHzOvE 86hGRK67XPEsiCZabRllsNzlIidNDkJ9RbxStVh90zCIwycuS0T7hrCSCBg/u02GeqVg Nny10zbs+b2ugTb8TtNqtLmHw816cvokciKf+0iO9TNeS1SFlPqgQ0oCU2pjS4ThiOSD DJyA== MIME-Version: 1.0 Received: by 10.52.91.47 with SMTP id cb15mr5813555vdb.76.1331323985143; Fri, 09 Mar 2012 12:13:05 -0800 (PST) Received: by 10.52.116.103 with HTTP; Fri, 9 Mar 2012 12:13:04 -0800 (PST) In-Reply-To: <4F4828C0.6020705@gmail.com> References: <4F41DDE8.6060004@gmail.com> <4F48166A.5040301@gmail.com> <4F4828C0.6020705@gmail.com> Date: Fri, 9 Mar 2012 12:13:04 -0800 Message-ID: From: Norberto Lopes To: matt Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Cc: freebsd-wireless@freebsd.org Subject: Re: Linksys WMP600N driver (Ralink RT2800 802.11n PCI) X-BeenThere: freebsd-wireless@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussions of 802.11 stack, tools device driver development." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 09 Mar 2012 20:13:06 -0000 On Fri, Feb 24, 2012 at 4:18 PM, matt wrote: > On 02/24/12 15:29, Norberto Lopes wrote: >> >> Oh by the way, drivers from http://repo.or.cz/w/ralink_drivers.git did >> not work at all. >> I haven't had a lot of time to play around with this so it may have >> been pebcak but it definitely didn't look good. >> >> On Fri, Feb 24, 2012 at 3:07 PM, Adrian Chadd =C2=A0= wrote: >>> >>> Hi, >>> >>> That'd be great, thanks! >>> >>> >>> >>> Adrian >>> >>> On 24 February 2012 14:59, matt =C2=A0wrote: >>>> >>>> On 02/19/12 23:16, Adrian Chadd wrote: >>>>> >>>>> Hiya, >>>>> >>>>> Do you have a semi-working driver? If so, let's get it tested and int= o >>>>> _a_ freebsd repo. Whether it's in projects or HEAD. >>>>> >>>>> I'd rather see it in the freebsd repo then bitrotting anywhere. >>>>> >>>>> >>>>> >>>>> Adrian >>>>> . >>>>> >>>> It looks like the git repo is actually Alexandr's earlier >>>> rt2860/rt2870/rt3090 driver that I'd already merged into the ral drive= r. >>>> It is 20months old, so I assume I merged as new a version as is in git= . >>>> >>>> I'm going to test my old driver against HEAD/CURRENT and repost a link >>>> with >>>> tarball, diffs, etc w/ changes if necessary. >>>> >>>> I have the rt3090 in a pcie carrier on my desktop now, so I can contin= ue >>>> testing. >>>> >>>> Matt > > Norberto, are you running HEAD / recent CURRENT? > I'm guessing you are since those drivers are for older versions... > I'm not so sure about backporting what I have, but I'm pretty sure I can = get > it to work on latest HEAD. > > Thanks, > Matt I only realized I replied directly to Matt and not to the list. Your guess is correct Matt. How can I help getting this to a working state? From owner-freebsd-wireless@FreeBSD.ORG Fri Mar 9 22:13:17 2012 Return-Path: Delivered-To: freebsd-wireless@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 5A1CA106566B; Fri, 9 Mar 2012 22:13:17 +0000 (UTC) (envelope-from sendtomatt@gmail.com) Received: from mail-yx0-f182.google.com (mail-yx0-f182.google.com [209.85.213.182]) by mx1.freebsd.org (Postfix) with ESMTP id EC0AD8FC12; Fri, 9 Mar 2012 22:13:16 +0000 (UTC) Received: by yenl9 with SMTP id l9so1438312yen.13 for ; Fri, 09 Mar 2012 14:13:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:x-enigmail-version:content-type :content-transfer-encoding; bh=gdnAP4k4zPl5lWriz8Phf98COqGi+jGuNFWhWTdwmC0=; b=Rf/ssWl4XbST5JJ5kIqmz4fF4TzAiTmsKz/IQF7m0tASchlU7rcnjbZ9oPloGvWclK 554xwhHcvZfcHmXkFiinlgUT52POkDiRBsEjvrSEZ9AoT2sNdk0zWu1yAn35gBtFAQov oxOpzlMc28wGRMWRScL+pe5cSwVYZKUnNqpTYoOMrpoeHz1YbEXl9/Te5fi8Uf/Q8R7r /VVM9kMLm1/1XpTPKMqn4qa9oH2Pk/tNCUoWrgw8VEnoYIK6DmLpJ1eXopice9hBtPYB rM5WaZMekuZbK3dWObOi1IeCgaa8eP3dJ/GKJH4dqpnUId+UTx7jI2O1idAaYi5qkm7y v5Xg== Received: by 10.60.0.195 with SMTP id 3mr1508155oeg.2.1331331196083; Fri, 09 Mar 2012 14:13:16 -0800 (PST) Received: from bakeneko.local ([69.12.160.180]) by mx.google.com with ESMTPS id n7sm3380741oeh.4.2012.03.09.14.13.13 (version=SSLv3 cipher=OTHER); Fri, 09 Mar 2012 14:13:13 -0800 (PST) Message-ID: <4F5A8023.1090705@gmail.com> Date: Fri, 09 Mar 2012 14:11:47 -0800 From: matt User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0.1) Gecko/20120301 Thunderbird/10.0.1 MIME-Version: 1.0 To: Norberto Lopes References: <4F41DDE8.6060004@gmail.com> <4F48166A.5040301@gmail.com> <4F4828C0.6020705@gmail.com> In-Reply-To: X-Enigmail-Version: 1.3.5 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Cc: freebsd-wireless@freebsd.org Subject: Re: Linksys WMP600N driver (Ralink RT2800 802.11n PCI) X-BeenThere: freebsd-wireless@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussions of 802.11 stack, tools device driver development." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 09 Mar 2012 22:13:17 -0000 On 03/09/12 12:13, Norberto Lopes wrote: > On Fri, Feb 24, 2012 at 4:18 PM, matt wrote: >> On 02/24/12 15:29, Norberto Lopes wrote: >>> Oh by the way, drivers from http://repo.or.cz/w/ralink_drivers.git di= d >>> not work at all. >>> I haven't had a lot of time to play around with this so it may have >>> been pebcak but it definitely didn't look good. >>> >>> On Fri, Feb 24, 2012 at 3:07 PM, Adrian Chadd wr= ote: >>>> Hi, >>>> >>>> That'd be great, thanks! >>>> >>>> >>>> >>>> Adrian >>>> >>>> On 24 February 2012 14:59, matt wrote: >>>>> On 02/19/12 23:16, Adrian Chadd wrote: >>>>>> Hiya, >>>>>> >>>>>> Do you have a semi-working driver? If so, let's get it tested and = into >>>>>> _a_ freebsd repo. Whether it's in projects or HEAD. >>>>>> >>>>>> I'd rather see it in the freebsd repo then bitrotting anywhere. >>>>>> >>>>>> >>>>>> >>>>>> Adrian >>>>>> . >>>>>> >>>>> It looks like the git repo is actually Alexandr's earlier >>>>> rt2860/rt2870/rt3090 driver that I'd already merged into the ral dr= iver. >>>>> It is 20months old, so I assume I merged as new a version as is in = git. >>>>> >>>>> I'm going to test my old driver against HEAD/CURRENT and repost a l= ink >>>>> with >>>>> tarball, diffs, etc w/ changes if necessary. >>>>> >>>>> I have the rt3090 in a pcie carrier on my desktop now, so I can con= tinue >>>>> testing. >>>>> >>>>> Matt >> Norberto, are you running HEAD / recent CURRENT? >> I'm guessing you are since those drivers are for older versions... >> I'm not so sure about backporting what I have, but I'm pretty sure I c= an get >> it to work on latest HEAD. >> >> Thanks, >> Matt > I only realized I replied directly to Matt and not to the list. > Your guess is correct Matt. > How can I help getting this to a working state? Test it...I need to do last formatting on patch, but it compiles cleanly and runs on HEAD. I was able to download the minix3 iso, while browsing and posting. I will upload it somewhere tonight and post with links. The only modification from the google docs link I posted yesteryear was that "int opmode" become an enum. I think the OLD link might apply to 9, but I'm trying to make one nicer patch. Just to make sure it will attach on your machine what is pciconf -lv result for your card? Thanks! Matt From owner-freebsd-wireless@FreeBSD.ORG Sat Mar 10 03:17:43 2012 Return-Path: Delivered-To: freebsd-wireless@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 9B357106564A; Sat, 10 Mar 2012 03:17:43 +0000 (UTC) (envelope-from sendtomatt@gmail.com) Received: from mail-gy0-f182.google.com (mail-gy0-f182.google.com [209.85.160.182]) by mx1.freebsd.org (Postfix) with ESMTP id 3A5628FC08; Sat, 10 Mar 2012 03:17:42 +0000 (UTC) Received: by ghrr20 with SMTP id r20so1609495ghr.13 for ; Fri, 09 Mar 2012 19:17:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:content-type:content-transfer-encoding; bh=dk+v1zqb+JqMU2LCS0Xm8Md6n5EkrJvXv5cEayjtUPE=; b=st7wKgCxFk1BRWBQOcSSZ1dBbgN9KK2QIwzxK6bSRmGre3NOnmLAILETFc1hdNolP5 UsbGBie1dkuhHZm4+iRqtwsrNiB013zVj13nz/+Tmf46jdl3e3so9JpA9yhuy3Yju9oP A4cPq3KVD1z3i5YUcJOVSSDIYQAsqCE+ZlWjD/JkejXrk9zBEpNc3IpgOiOJ1xie+D4/ 1f1kS1ybfVL8nhwjZcJq4gh9EfU6rU/FkbQy7Fj+dDoyQZkuTI38XessINYuKF0VRgJM yiyF0NR1N5A/TloOMlIvfXanrTfP/mNkykp5vj446ePv2Fj/nuNgfG2rLc02IQA7xzOp 8X4Q== Received: by 10.60.18.163 with SMTP id x3mr1591746oed.64.1331349462382; Fri, 09 Mar 2012 19:17:42 -0800 (PST) Received: from flatline.local (70-36-223-154.dsl.dynamic.sonic.net. [70.36.223.154]) by mx.google.com with ESMTPS id d9sm10126360obq.0.2012.03.09.19.17.40 (version=SSLv3 cipher=OTHER); Fri, 09 Mar 2012 19:17:41 -0800 (PST) Message-ID: <4F5AC7CF.3090409@gmail.com> Date: Fri, 09 Mar 2012 19:17:35 -0800 From: matt User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:10.0.2) Gecko/20120218 Thunderbird/10.0.2 MIME-Version: 1.0 To: Adrian Chadd , freebsd-wireless@freebsd.org, Norberto Lopes References: <4F41DDE8.6060004@gmail.com> <4F48166A.5040301@gmail.com> <4F4828C0.6020705@gmail.com> <4F5A8023.1090705@gmail.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Subject: Please Test: Updated Ral Driver Patch for rt2860/rt3090 X-BeenThere: freebsd-wireless@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussions of 802.11 stack, tools device driver development." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 10 Mar 2012 03:17:43 -0000 Hi Folks! Thanks for the patience :) Here's the patch for HEAD: https://docs.google.com/open?id=0B6YlMzJxarGbR1lSZ0hnTEFSREt6MU1MbGFKeURhUQ It may work on 9, but if it doesn't let me know what fails and I'll see how hard it is to backport. The patch expects to live at /usr/src, and be applied "patch -p1 < ralplus.diff" I have not tested almost anything other than connecting and browsing, so anyone that can test adhoc, hostap or anything else please let me know. Signal levels look fine. Please ignore the printfs you see at attach, I'm under the impression that they're spurious and related to certain parts of wireless N, but please let me know if you have issues with APs above channel 9. You will see an invalid eeprom low-noise amplifier gain for low-noise amplifiers you don't have. If it doesn't attach at all, send me your PCI ids and we can add them to the attach code and see if they work. My expectation is everything from rt2860-rt3090 at least will work. There are no changes to the other ral devices, but testers with other ral devices are probably necessary to be sure no regressions have occurred, especially with attach. Thanks! Matt From owner-freebsd-wireless@FreeBSD.ORG Sat Mar 10 04:15:39 2012 Return-Path: Delivered-To: freebsd-wireless@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 0B245106567D; Sat, 10 Mar 2012 04:15:39 +0000 (UTC) (envelope-from linimon@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id D2DE68FC12; Sat, 10 Mar 2012 04:15:38 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id q2A4Fcd4018421; Sat, 10 Mar 2012 04:15:38 GMT (envelope-from linimon@freefall.freebsd.org) Received: (from linimon@localhost) by freefall.freebsd.org (8.14.5/8.14.5/Submit) id q2A4Fc4m018417; Sat, 10 Mar 2012 04:15:38 GMT (envelope-from linimon) Date: Sat, 10 Mar 2012 04:15:38 GMT Message-Id: <201203100415.q2A4Fc4m018417@freefall.freebsd.org> To: linimon@FreeBSD.org, freebsd-bugs@FreeBSD.org, freebsd-wireless@FreeBSD.org From: linimon@FreeBSD.org Cc: Subject: Re: kern/165895: [ath] overly busy cabq can tie up all tx buffers X-BeenThere: freebsd-wireless@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussions of 802.11 stack, tools device driver development." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 10 Mar 2012 04:15:39 -0000 Synopsis: [ath] overly busy cabq can tie up all tx buffers Responsible-Changed-From-To: freebsd-bugs->freebsd-wireless Responsible-Changed-By: linimon Responsible-Changed-When: Sat Mar 10 04:15:18 UTC 2012 Responsible-Changed-Why: Over to maintainer(s). http://www.freebsd.org/cgi/query-pr.cgi?pr=165895 From owner-freebsd-wireless@FreeBSD.ORG Sat Mar 10 04:20:07 2012 Return-Path: Delivered-To: freebsd-wireless@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id F00C1106564A for ; Sat, 10 Mar 2012 04:20:06 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id D3C838FC08 for ; Sat, 10 Mar 2012 04:20:06 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id q2A4K6Kj018988 for ; Sat, 10 Mar 2012 04:20:06 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.5/8.14.5/Submit) id q2A4K6Mi018987; Sat, 10 Mar 2012 04:20:06 GMT (envelope-from gnats) Date: Sat, 10 Mar 2012 04:20:06 GMT Message-Id: <201203100420.q2A4K6Mi018987@freefall.freebsd.org> To: freebsd-wireless@FreeBSD.org From: dfilter@FreeBSD.ORG (dfilter service) Cc: Subject: Re: kern/165895: commit references a PR X-BeenThere: freebsd-wireless@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: dfilter service List-Id: "Discussions of 802.11 stack, tools device driver development." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 10 Mar 2012 04:20:07 -0000 The following reply was made to PR kern/165895; it has been noted by GNATS. From: dfilter@FreeBSD.ORG (dfilter service) To: bug-followup@FreeBSD.org Cc: Subject: Re: kern/165895: commit references a PR Date: Sat, 10 Mar 2012 04:14:19 +0000 (UTC) Author: adrian Date: Sat Mar 10 04:14:04 2012 New Revision: 232764 URL: http://svn.freebsd.org/changeset/base/232764 Log: Don't flood the cabq/mcastq with frames. In a very noisy 2.4GHz environment (with HT/40 enabled, making it worse) I saw the following occur: * the air was considered "busy" a lot of the time; * the cabq time is quite short due to staggered beacons being enabled; * it just wasn't able to keep up TX'ing CABQ frames; * .. and the cabq would swallow up all the TX ath_buf's. This patch introduces a twiddle which allows the maximum cabq depth to be set, forcing further frames to be dropped. It defaults to the TX buffer count at the moment, so the default behaviour isn't changed. I've also started fleshing out a similar setup for the data path, so it doesn't swallow up all the available TX buffers and preventing management frames (such as ADDBA) out. PR: kern/165895 Modified: head/sys/dev/ath/if_ath.c head/sys/dev/ath/if_ath_sysctl.c head/sys/dev/ath/if_ath_tx.c head/sys/dev/ath/if_athioctl.h head/sys/dev/ath/if_athvar.h Modified: head/sys/dev/ath/if_ath.c ============================================================================== --- head/sys/dev/ath/if_ath.c Sat Mar 10 04:02:52 2012 (r232763) +++ head/sys/dev/ath/if_ath.c Sat Mar 10 04:14:04 2012 (r232764) @@ -637,6 +637,19 @@ ath_attach(u_int16_t devid, struct ath_s #endif /* + * TODO: enforce that at least this many frames are available + * in the txbuf list before allowing data frames (raw or + * otherwise) to be transmitted. + */ + sc->sc_txq_data_minfree = 10; + /* + * Leave this as default to maintain legacy behaviour. + * Shortening the cabq/mcastq may end up causing some + * undesirable behaviour. + */ + sc->sc_txq_mcastq_maxdepth = ath_txbuf; + + /* * Allow the TX and RX chainmasks to be overridden by * environment variables and/or device.hints. * Modified: head/sys/dev/ath/if_ath_sysctl.c ============================================================================== --- head/sys/dev/ath/if_ath_sysctl.c Sat Mar 10 04:02:52 2012 (r232763) +++ head/sys/dev/ath/if_ath_sysctl.c Sat Mar 10 04:14:04 2012 (r232764) @@ -605,6 +605,17 @@ ath_sysctlattach(struct ath_softc *sc) "tid_hwq_hi", CTLFLAG_RW, &sc->sc_tid_hwq_hi, 0, ""); +#if 0 + SYSCTL_ADD_INT(ctx, SYSCTL_CHILDREN(tree), OID_AUTO, + "txq_data_minfree", CTLFLAG_RW, &sc->sc_txq_data_minfree, + 0, "Minimum free buffers before adding a data frame" + " to the TX queue"); +#endif + SYSCTL_ADD_INT(ctx, SYSCTL_CHILDREN(tree), OID_AUTO, + "txq_mcastq_maxdepth", CTLFLAG_RW, + &sc->sc_txq_mcastq_maxdepth, 0, + "Maximum buffer depth for multicast/broadcast frames"); + #ifdef IEEE80211_SUPPORT_TDMA if (ath_hal_macversion(ah) > 0x78) { sc->sc_tdmadbaprep = 2; @@ -885,7 +896,10 @@ ath_sysctl_stats_attach(struct ath_softc &sc->sc_stats.ast_rx_intr, 0, "RX interrupts"); SYSCTL_ADD_UINT(ctx, child, OID_AUTO, "ast_tx_intr", CTLFLAG_RD, &sc->sc_stats.ast_tx_intr, 0, "TX interrupts"); - + SYSCTL_ADD_UINT(ctx, child, OID_AUTO, "ast_tx_mcastq_overflow", + CTLFLAG_RD, &sc->sc_stats.ast_tx_mcastq_overflow, 0, + "Number of multicast frames exceeding maximum mcast queue depth"); + /* Attach the RX phy error array */ ath_sysctl_stats_attach_rxphyerr(sc, child); } Modified: head/sys/dev/ath/if_ath_tx.c ============================================================================== --- head/sys/dev/ath/if_ath_tx.c Sat Mar 10 04:02:52 2012 (r232763) +++ head/sys/dev/ath/if_ath_tx.c Sat Mar 10 04:14:04 2012 (r232764) @@ -1369,7 +1369,7 @@ ath_tx_start(struct ath_softc *sc, struc { struct ieee80211vap *vap = ni->ni_vap; struct ath_vap *avp = ATH_VAP(vap); - int r; + int r = 0; u_int pri; int tid; struct ath_txq *txq; @@ -1402,6 +1402,30 @@ ath_tx_start(struct ath_softc *sc, struc type = wh->i_fc[0] & IEEE80211_FC0_TYPE_MASK; subtype = wh->i_fc[0] & IEEE80211_FC0_SUBTYPE_MASK; + /* + * Enforce how deep the multicast queue can grow. + * + * XXX duplicated in ath_raw_xmit(). + */ + if (IEEE80211_IS_MULTICAST(wh->i_addr1)) { + ATH_TXQ_LOCK(sc->sc_cabq); + ATH_TXQ_LOCK(&avp->av_mcastq); + + if ((sc->sc_cabq->axq_depth + avp->av_mcastq.axq_depth) > + sc->sc_txq_mcastq_maxdepth) { + sc->sc_stats.ast_tx_mcastq_overflow++; + r = ENOBUFS; + } + + ATH_TXQ_UNLOCK(&avp->av_mcastq); + ATH_TXQ_UNLOCK(sc->sc_cabq); + + if (r != 0) { + m_freem(m0); + return r; + } + } + /* A-MPDU TX */ is_ampdu_tx = ath_tx_ampdu_running(sc, ATH_NODE(ni), tid); is_ampdu_pending = ath_tx_ampdu_pending(sc, ATH_NODE(ni), tid); @@ -1734,7 +1758,10 @@ ath_raw_xmit(struct ieee80211_node *ni, struct ifnet *ifp = ic->ic_ifp; struct ath_softc *sc = ifp->if_softc; struct ath_buf *bf; - int error; + struct ieee80211_frame *wh = mtod(m, struct ieee80211_frame *); + struct ieee80211vap *vap = ni->ni_vap; + struct ath_vap *avp = ATH_VAP(vap); + int error = 0; ATH_PCU_LOCK(sc); if (sc->sc_inreset_cnt > 0) { @@ -1755,6 +1782,31 @@ ath_raw_xmit(struct ieee80211_node *ni, error = ENETDOWN; goto bad; } + + /* + * Enforce how deep the multicast queue can grow. + * + * XXX duplicated in ath_tx_start(). + */ + if (IEEE80211_IS_MULTICAST(wh->i_addr1)) { + ATH_TXQ_LOCK(sc->sc_cabq); + ATH_TXQ_LOCK(&avp->av_mcastq); + + if ((sc->sc_cabq->axq_depth + avp->av_mcastq.axq_depth) > + sc->sc_txq_mcastq_maxdepth) { + sc->sc_stats.ast_tx_mcastq_overflow++; + error = ENOBUFS; + } + + ATH_TXQ_UNLOCK(&avp->av_mcastq); + ATH_TXQ_UNLOCK(sc->sc_cabq); + + if (error != 0) { + m_freem(m); + goto bad; + } + } + /* * Grab a TX buffer and associated resources. */ Modified: head/sys/dev/ath/if_athioctl.h ============================================================================== --- head/sys/dev/ath/if_athioctl.h Sat Mar 10 04:02:52 2012 (r232763) +++ head/sys/dev/ath/if_athioctl.h Sat Mar 10 04:14:04 2012 (r232764) @@ -155,7 +155,8 @@ struct ath_stats { u_int32_t ast_rx_intr; u_int32_t ast_tx_aggr_ok; /* aggregate TX ok */ u_int32_t ast_tx_aggr_fail; /* aggregate TX failed */ - u_int32_t ast_pad[2]; + u_int32_t ast_tx_mcastq_overflow; /* multicast queue overflow */ + u_int32_t ast_pad[1]; }; #define SIOCGATHSTATS _IOWR('i', 137, struct ifreq) Modified: head/sys/dev/ath/if_athvar.h ============================================================================== --- head/sys/dev/ath/if_athvar.h Sat Mar 10 04:02:52 2012 (r232763) +++ head/sys/dev/ath/if_athvar.h Sat Mar 10 04:14:04 2012 (r232764) @@ -530,6 +530,31 @@ struct ath_softc { int sc_txchainmask; /* currently configured TX chainmask */ int sc_rxchainmask; /* currently configured RX chainmask */ + /* Queue limits */ + + /* + * To avoid queue starvation in congested conditions, + * these parameters tune the maximum number of frames + * queued to the data/mcastq before they're dropped. + * + * This is to prevent: + * + a single destination overwhelming everything, including + * management/multicast frames; + * + multicast frames overwhelming everything (when the + * air is sufficiently busy that cabq can't drain.) + * + * These implement: + * + data_minfree is the maximum number of free buffers + * overall to successfully allow a data frame. + * + * + mcastq_maxdepth is the maximum depth allowe dof the avp+cabq + * queue. The avp is included in each comparison just to be + * a little overly conservative and this may end up being + * unhelpful with multiple VAPs. + */ + int sc_txq_data_minfree; + int sc_txq_mcastq_maxdepth; + /* * Aggregation twiddles * _______________________________________________ svn-src-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org" From owner-freebsd-wireless@FreeBSD.ORG Sat Mar 10 05:45:56 2012 Return-Path: Delivered-To: freebsd-wireless@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 1B650106564A; Sat, 10 Mar 2012 05:45:56 +0000 (UTC) (envelope-from linimon@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id E695D8FC14; Sat, 10 Mar 2012 05:45:55 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id q2A5jt08001508; Sat, 10 Mar 2012 05:45:55 GMT (envelope-from linimon@freefall.freebsd.org) Received: (from linimon@localhost) by freefall.freebsd.org (8.14.5/8.14.5/Submit) id q2A5jtwX001504; Sat, 10 Mar 2012 05:45:55 GMT (envelope-from linimon) Date: Sat, 10 Mar 2012 05:45:55 GMT Message-Id: <201203100545.q2A5jtwX001504@freefall.freebsd.org> To: linimon@FreeBSD.org, freebsd-bugs@FreeBSD.org, freebsd-wireless@FreeBSD.org From: linimon@FreeBSD.org Cc: Subject: Re: kern/165870: [bwn] bwn driver does not attach on HP Pavilion dv9420us X-BeenThere: freebsd-wireless@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussions of 802.11 stack, tools device driver development." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 10 Mar 2012 05:45:56 -0000 Old Synopsis: bwn driver does not attach on HP Pavilion dv9420us New Synopsis: [bwn] bwn driver does not attach on HP Pavilion dv9420us Responsible-Changed-From-To: freebsd-bugs->freebsd-wireless Responsible-Changed-By: linimon Responsible-Changed-When: Sat Mar 10 05:45:38 UTC 2012 Responsible-Changed-Why: Over to maintainer(s). http://www.freebsd.org/cgi/query-pr.cgi?pr=165870 From owner-freebsd-wireless@FreeBSD.ORG Sat Mar 10 20:00:35 2012 Return-Path: Delivered-To: freebsd-wireless@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id DB4791065672 for ; Sat, 10 Mar 2012 20:00:35 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id BB02A8FC0C for ; Sat, 10 Mar 2012 20:00:35 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id q2AK0Z0P013818 for ; Sat, 10 Mar 2012 20:00:35 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.5/8.14.5/Submit) id q2AK0Zp9013809; Sat, 10 Mar 2012 20:00:35 GMT (envelope-from gnats) Date: Sat, 10 Mar 2012 20:00:35 GMT Message-Id: <201203102000.q2AK0Zp9013809@freefall.freebsd.org> To: freebsd-wireless@FreeBSD.org From: dfilter@FreeBSD.ORG (dfilter service) Cc: Subject: Re: kern/165895: commit references a PR X-BeenThere: freebsd-wireless@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: dfilter service List-Id: "Discussions of 802.11 stack, tools device driver development." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 10 Mar 2012 20:00:35 -0000 The following reply was made to PR kern/165895; it has been noted by GNATS. From: dfilter@FreeBSD.ORG (dfilter service) To: bug-followup@FreeBSD.org Cc: Subject: Re: kern/165895: commit references a PR Date: Sat, 10 Mar 2012 19:58:37 +0000 (UTC) Author: adrian Date: Sat Mar 10 19:58:23 2012 New Revision: 232794 URL: http://svn.freebsd.org/changeset/base/232794 Log: Fix a panic introduced in a previous commit - non-beaconing modes (eg STA) don't setup the avp mcast queue. This is a bit annoying though - it turns out the mcast queue isn't initialised for STA mode but it's then touched to see whether anything is in it. That should be fixed in a subsequent commit. Noticed by: gperez@entel.upc.edu PR: kern/165895 Modified: head/sys/dev/ath/if_ath_tx.c head/sys/dev/ath/if_athvar.h Modified: head/sys/dev/ath/if_ath_tx.c ============================================================================== --- head/sys/dev/ath/if_ath_tx.c Sat Mar 10 18:56:16 2012 (r232793) +++ head/sys/dev/ath/if_ath_tx.c Sat Mar 10 19:58:23 2012 (r232794) @@ -1409,15 +1409,12 @@ ath_tx_start(struct ath_softc *sc, struc */ if (IEEE80211_IS_MULTICAST(wh->i_addr1)) { ATH_TXQ_LOCK(sc->sc_cabq); - ATH_TXQ_LOCK(&avp->av_mcastq); - if ((sc->sc_cabq->axq_depth + avp->av_mcastq.axq_depth) > - sc->sc_txq_mcastq_maxdepth) { + if (sc->sc_cabq->axq_depth > sc->sc_txq_mcastq_maxdepth) { sc->sc_stats.ast_tx_mcastq_overflow++; r = ENOBUFS; } - ATH_TXQ_UNLOCK(&avp->av_mcastq); ATH_TXQ_UNLOCK(sc->sc_cabq); if (r != 0) { @@ -1759,8 +1756,6 @@ ath_raw_xmit(struct ieee80211_node *ni, struct ath_softc *sc = ifp->if_softc; struct ath_buf *bf; struct ieee80211_frame *wh = mtod(m, struct ieee80211_frame *); - struct ieee80211vap *vap = ni->ni_vap; - struct ath_vap *avp = ATH_VAP(vap); int error = 0; ATH_PCU_LOCK(sc); @@ -1790,15 +1785,12 @@ ath_raw_xmit(struct ieee80211_node *ni, */ if (IEEE80211_IS_MULTICAST(wh->i_addr1)) { ATH_TXQ_LOCK(sc->sc_cabq); - ATH_TXQ_LOCK(&avp->av_mcastq); - if ((sc->sc_cabq->axq_depth + avp->av_mcastq.axq_depth) > - sc->sc_txq_mcastq_maxdepth) { + if (sc->sc_cabq->axq_depth > sc->sc_txq_mcastq_maxdepth) { sc->sc_stats.ast_tx_mcastq_overflow++; error = ENOBUFS; } - ATH_TXQ_UNLOCK(&avp->av_mcastq); ATH_TXQ_UNLOCK(sc->sc_cabq); if (error != 0) { Modified: head/sys/dev/ath/if_athvar.h ============================================================================== --- head/sys/dev/ath/if_athvar.h Sat Mar 10 18:56:16 2012 (r232793) +++ head/sys/dev/ath/if_athvar.h Sat Mar 10 19:58:23 2012 (r232794) @@ -547,10 +547,7 @@ struct ath_softc { * + data_minfree is the maximum number of free buffers * overall to successfully allow a data frame. * - * + mcastq_maxdepth is the maximum depth allowe dof the avp+cabq - * queue. The avp is included in each comparison just to be - * a little overly conservative and this may end up being - * unhelpful with multiple VAPs. + * + mcastq_maxdepth is the maximum depth allowed of the cabq. */ int sc_txq_data_minfree; int sc_txq_mcastq_maxdepth; _______________________________________________ svn-src-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org" From owner-freebsd-wireless@FreeBSD.ORG Sat Mar 10 20:29:30 2012 Return-Path: Delivered-To: freebsd-wireless@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 47E401065672 for ; Sat, 10 Mar 2012 20:29:30 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Received: from mail-pz0-f54.google.com (mail-pz0-f54.google.com [209.85.210.54]) by mx1.freebsd.org (Postfix) with ESMTP id 1BEE88FC08 for ; Sat, 10 Mar 2012 20:29:30 +0000 (UTC) Received: by dald2 with SMTP id d2so3434071dal.13 for ; Sat, 10 Mar 2012 12:29:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; bh=YcwPrP2myQ0WQSV4azSlSZ7ANgs9rBXmwdLg8MCLaFM=; b=X4hSGP9+TaXRjtojg7qn8w1MwWQxRBhwWrEw0mVwDpl0ItxwYln8FljjEPiMKijkvs iosE1E/w5VBKTGQBk4tZ1tBRius+S62T8R+j0MVN8wPDhMm67gGyApio7FiNn35TsxBH jC7hFnuqznfJ+wbm9jp91s2TmHi/5dLr9AN608/xgfmLn9psA++iHeV9OgbsZbC4Ufem XiMQoMxLVg69ZAl+rHuAn8FSOumGwo2YgEEBdgQYhFAG3AKJxqiQ87JslmQbKACcqjFd UmMyk1nwBL568e/invSE9IY2lL+wc44LLQUXp6bUrtx+B7H1AaK1KVZeIRfWMmm6tCav h1TQ== MIME-Version: 1.0 Received: by 10.68.191.168 with SMTP id gz8mr11130678pbc.37.1331411369826; Sat, 10 Mar 2012 12:29:29 -0800 (PST) Received: by 10.143.33.5 with HTTP; Sat, 10 Mar 2012 12:29:29 -0800 (PST) In-Reply-To: <4F5B4FE9.4040809@entel.upc.edu> References: <4F5B4FE9.4040809@entel.upc.edu> Date: Sat, 10 Mar 2012 12:29:29 -0800 Message-ID: From: Adrian Chadd To: =?ISO-8859-1?Q?Gustau_P=E9rez?= Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: freebsd-wireless@freebsd.org Subject: Re: Panic when scanning with an AR9287 with r232777 X-BeenThere: freebsd-wireless@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussions of 802.11 stack, tools device driver development." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 10 Mar 2012 20:29:30 -0000 Hi, I've just fixed this. Oops. :-) -head works again for station and access point modes. Adrian 2012/3/10 Gustau P=E9rez : > > =A0Hi Adrian, > > =A0I was going to test the last 11n changes with both my laptop and my AP= box. > > =A0 I'm tracked HEAD (r232777). I'm tracking that revision from kib's git > repository + his kms changes for the intel video devices (I did the merge > locally without any conflict). > > =A0The machine has an AR9287 on it. > > =A0When wpa_supplicant starts on the laptop the machine panics. The core > points to $SOURCE_DIR/sys/dev/ath/if_ath_tx.c:1793, telling me the mutex = is > null. > > =A0 I'm attaching the core file just in case. > > =A0 Gustau From owner-freebsd-wireless@FreeBSD.ORG Sat Mar 10 21:26:39 2012 Return-Path: Delivered-To: freebsd-wireless@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 1F32D1065675 for ; Sat, 10 Mar 2012 21:26:39 +0000 (UTC) (envelope-from vince@unsane.co.uk) Received: from unsane.co.uk (unsane-pt.tunnel.tserv5.lon1.ipv6.he.net [IPv6:2001:470:1f08:110::2]) by mx1.freebsd.org (Postfix) with ESMTP id 9FFAC8FC1A for ; Sat, 10 Mar 2012 21:26:38 +0000 (UTC) Received: from badger.unsane.co.uk (badger.unsane.co.uk [85.233.185.165]) (authenticated bits=0) by unsane.co.uk (8.14.5/8.14.5) with ESMTP id q2ALQWgK012829 (version=TLSv1/SSLv3 cipher=DHE-RSA-CAMELLIA256-SHA bits=256 verify=NO); Sat, 10 Mar 2012 21:26:32 GMT (envelope-from vince@unsane.co.uk) Message-ID: <4F5BC708.9010404@unsane.co.uk> Date: Sat, 10 Mar 2012 21:26:32 +0000 From: Vincent Hoffman User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:10.0.2) Gecko/20120216 Thunderbird/10.0.2 MIME-Version: 1.0 To: Adrian Chadd References: <4F5B4FE9.4040809@entel.upc.edu> In-Reply-To: X-Enigmail-Version: 1.3.5 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8bit Cc: freebsd-wireless@freebsd.org Subject: Re: Panic when scanning with an AR9287 with r232777 X-BeenThere: freebsd-wireless@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussions of 802.11 stack, tools device driver development." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 10 Mar 2012 21:26:39 -0000 Was about to report a panic on boot (ar9280) generic HEAD. I'll update and try again. Vince On 10/03/2012 20:29, Adrian Chadd wrote: > Hi, > > I've just fixed this. Oops. :-) > > -head works again for station and access point modes. > > > Adrian > > 2012/3/10 Gustau Pérez : >> Hi Adrian, >> >> I was going to test the last 11n changes with both my laptop and my AP box. >> >> I'm tracked HEAD (r232777). I'm tracking that revision from kib's git >> repository + his kms changes for the intel video devices (I did the merge >> locally without any conflict). >> >> The machine has an AR9287 on it. >> >> When wpa_supplicant starts on the laptop the machine panics. The core >> points to $SOURCE_DIR/sys/dev/ath/if_ath_tx.c:1793, telling me the mutex is >> null. >> >> I'm attaching the core file just in case. >> >> Gustau > _______________________________________________ > freebsd-wireless@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-wireless > To unsubscribe, send any mail to "freebsd-wireless-unsubscribe@freebsd.org" From owner-freebsd-wireless@FreeBSD.ORG Sat Mar 10 22:15:15 2012 Return-Path: Delivered-To: freebsd-wireless@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 7D62B106566B for ; Sat, 10 Mar 2012 22:15:15 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Received: from mail-iy0-f182.google.com (mail-iy0-f182.google.com [209.85.210.182]) by mx1.freebsd.org (Postfix) with ESMTP id 3C2BA8FC08 for ; Sat, 10 Mar 2012 22:15:14 +0000 (UTC) Received: by iahk25 with SMTP id k25so5645836iah.13 for ; Sat, 10 Mar 2012 14:15:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:to:cc:reply-to:subject:in-reply-to:x-mailer :mime-version:content-type; bh=GMLwOkmH8GrUifm2PNLskYlZ7XKjR5oHtId6k0nLmRc=; b=AEGTgje5ahCgs5R+BWfNqGGB/aCPh1Hk+TbdlfGABFtIuiZDIWWVj1xwmkjbM9fi/w hod1Sa+uhHhwmxlwnioOyhmCrI6Icv7QJXXPcWHnL9ur1FIBCaht8L/qAJl+h8lXTMUI F+99iqnikZuSTBidCzYYpnXZPOqFXOczKV3+MxqzgYHMOp4rMT7exwBXjBZFi3ZywEuX I07NUrwfXkB9M3QZl4WWi5HwqPyCncNKB46yuON92y3RTYgXHt9p/0azln3dnicv+Npy CCdUTGcA46UjKYyrAc9rRLK4s+2F0Gt6IMhwpKpbJOeO8bw4UQeNaSNSl6Nu5s4l1h5B Al6w== Received: by 10.182.38.3 with SMTP id c3mr2915147obk.42.1331417707746; Sat, 10 Mar 2012 14:15:07 -0800 (PST) Received: from www.palm.com ([64.134.236.119]) by mx.google.com with ESMTPS id x9sm5635526oea.7.2012.03.10.14.15.03 (version=SSLv3 cipher=OTHER); Sat, 10 Mar 2012 14:15:06 -0800 (PST) Message-ID: <4f5bd26a.49093c0a.722c.318e@mx.google.com> Date: Sat, 10 Mar 2012 14:13:45 -0800 From: "Adrian Chadd" To: "Vincent Hoffman" In-Reply-To: <4F5BC708.9010404@unsane.co.uk> X-Mailer: Palm webOS v1.0.1 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.5 Cc: "freebsd-wireless@freebsd.org" Subject: Re: Panic when scanning with an AR9287 with r232777 X-BeenThere: freebsd-wireless@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Adrian Chadd List-Id: "Discussions of 802.11 stack, tools device driver development." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 10 Mar 2012 22:15:15 -0000 Cool-o. Adrian Sent from my Palm Pre on AT&T On Mar 10, 2012 1:26 PM, Vincent Hoffman <vince@unsane.co.uk> wrote:= Was about to report a panic on boot (ar9280) generic HEAD. I'll update and try again. Vince On 10/03/2012 20:29, Adrian Chadd wrote: > Hi, > > I've just fixed this. Oops. :-) > > -head works again for station and access point modes. > > > Adrian > > 2012/3/10 Gustau P=C3=A9rez <gperez@entel.upc.edu>: >> Hi Adrian, >> >> I was going to test the last 11n changes with both my laptop and= my AP box. >> >> I'm tracked HEAD (r232777). I'm tracking that revision from kib'= s git >> repository + his kms changes for the intel video devices (I did th= e merge >> locally without any conflict). >> >> The machine has an AR9287 on it. >> >> When wpa_supplicant starts on the laptop the machine panics. The= core >> points to $SOURCE_DIR/sys/dev/ath/if_ath_tx.c:1793, telling me the= mutex is >> null. >> >> I'm attaching the core file just in case. >> >> Gustau > _______________________________________________ > freebsd-wireless@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-wireless > To unsubscribe, send any mail to "freebsd-wireless-unsubscribe@freebsd= =2Eorg"