Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 6 Oct 2012 17:19:52 -0700
From:      Marcel Moolenaar <marcel@xcllnt.net>
To:        Dimitry Andric <dim@FreeBSD.org>
Cc:        svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org
Subject:   Re: svn commit: r241298 - in head: . gnu/usr.bin/cc/cc_int gnu/usr.bin/cc/include kerberos5 kerberos5/tools/asn1_compile kerberos5/tools/slc lib/clang/include share/mk tools/build/make_check usr.sbin/c...
Message-ID:  <31A2ABA0-49C8-458B-A055-152C3266D9B0@xcllnt.net>
In-Reply-To: <5070A4FC.4080802@FreeBSD.org>
References:  <201210062001.q96K16Or030755@svn.freebsd.org> <5070A4FC.4080802@FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help

On Oct 6, 2012, at 2:39 PM, Dimitry Andric <dim@FreeBSD.org> wrote:

> On 2012-10-06 22:01, Marcel Moolenaar wrote:
>>   2.  Remove the use of -E. It's not needed in our build because we =
use ?=3D for
>>       the respective variables, which means that we'll take the =
environment
>>       value (if any) anyway.
>=20
> No, this will break builds of 32-bit libraries on amd64, at least when
> CC/CXX etc are set in make.conf.  I put this in specifically in =
r227120.
>=20
> Please revert this particular change, unless you have tested that it
> works correctly, with e.g.  CC=3Dclang in make.conf.

I'll double-check to make sure all is fine. I'll revert if I hit
a problem and don't have an immediate fix for it.

FYI,

--=20
Marcel Moolenaar
marcel@xcllnt.net





Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?31A2ABA0-49C8-458B-A055-152C3266D9B0>