Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 28 Oct 2012 02:15:36 +0000 (UTC)
From:      Nathan Whitehorn <nwhitehorn@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r242203 - in head/sys/modules/drm: r128 radeon via
Message-ID:  <201210280215.q9S2Fajw007456@svn.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: nwhitehorn
Date: Sun Oct 28 02:15:35 2012
New Revision: 242203
URL: http://svn.freebsd.org/changeset/base/242203

Log:
  Extend dim's hack from r228978: not only clang but gcc on non-x86 platforms
  warns about unused variables in this code, so always add -Wno-unused to
  the warning flags. Why gcc on x86 *doesn't* warn about this, I will never
  know. The code itself should probably be fixed at some point.

Modified:
  head/sys/modules/drm/r128/Makefile
  head/sys/modules/drm/radeon/Makefile
  head/sys/modules/drm/via/Makefile

Modified: head/sys/modules/drm/r128/Makefile
==============================================================================
--- head/sys/modules/drm/r128/Makefile	Sat Oct 27 23:42:41 2012	(r242202)
+++ head/sys/modules/drm/r128/Makefile	Sun Oct 28 02:15:35 2012	(r242203)
@@ -7,6 +7,6 @@ SRCS	+=device_if.h bus_if.h pci_if.h opt
 
 .include <bsd.kmod.mk>
 
-CWARNFLAGS.r128_cce.c=		${NO_WUNUSED_VALUE} ${NO_WCONSTANT_CONVERSION}
-CWARNFLAGS.r128_state.c=	${NO_WUNUSED_VALUE}
+CWARNFLAGS.r128_cce.c=		-Wno-unused ${NO_WCONSTANT_CONVERSION}
+CWARNFLAGS.r128_state.c=	-Wno-unused
 CWARNFLAGS+=			${CWARNFLAGS.${.IMPSRC:T}}

Modified: head/sys/modules/drm/radeon/Makefile
==============================================================================
--- head/sys/modules/drm/radeon/Makefile	Sat Oct 27 23:42:41 2012	(r242202)
+++ head/sys/modules/drm/radeon/Makefile	Sun Oct 28 02:15:35 2012	(r242203)
@@ -8,6 +8,6 @@ SRCS	+=device_if.h bus_if.h pci_if.h opt
 
 .include <bsd.kmod.mk>
 
-CWARNFLAGS.r600_cp.c=	${NO_WUNUSED_VALUE} ${NO_WCONSTANT_CONVERSION}
-CWARNFLAGS.radeon_cp.c=	${NO_WUNUSED_VALUE} ${NO_WCONSTANT_CONVERSION}
+CWARNFLAGS.r600_cp.c=	-Wno-unused ${NO_WCONSTANT_CONVERSION}
+CWARNFLAGS.radeon_cp.c=	-Wno-unused ${NO_WCONSTANT_CONVERSION}
 CWARNFLAGS+=		${CWARNFLAGS.${.IMPSRC:T}}

Modified: head/sys/modules/drm/via/Makefile
==============================================================================
--- head/sys/modules/drm/via/Makefile	Sat Oct 27 23:42:41 2012	(r242202)
+++ head/sys/modules/drm/via/Makefile	Sun Oct 28 02:15:35 2012	(r242203)
@@ -22,6 +22,6 @@ opt_drm.h:
 
 .include <bsd.kmod.mk>
 
-CWARNFLAGS.via_dma.c=		${NO_WUNUSED_VALUE}
-CWARNFLAGS.via_dmablit.c=	${NO_WUNUSED_VALUE}
+CWARNFLAGS.via_dma.c=		-Wno-unused-value
+CWARNFLAGS.via_dmablit.c=	-Wno-unused-value
 CWARNFLAGS+=			${CWARNFLAGS.${.IMPSRC:T}}



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201210280215.q9S2Fajw007456>