From owner-freebsd-dtrace@FreeBSD.ORG Thu Oct 9 08:14:19 2014 Return-Path: Delivered-To: freebsd-dtrace@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id B2D173C1; Thu, 9 Oct 2014 08:14:19 +0000 (UTC) Received: from citadel.icyb.net.ua (citadel.icyb.net.ua [212.40.38.140]) by mx1.freebsd.org (Postfix) with ESMTP id CC8AC850; Thu, 9 Oct 2014 08:14:18 +0000 (UTC) Received: from porto.starpoint.kiev.ua (porto-e.starpoint.kiev.ua [212.40.38.100]) by citadel.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id LAA11364; Thu, 09 Oct 2014 11:14:17 +0300 (EEST) (envelope-from avg@FreeBSD.org) Received: from localhost ([127.0.0.1]) by porto.starpoint.kiev.ua with esmtp (Exim 4.34 (FreeBSD)) id 1Xc8rZ-0004v9-2d; Thu, 09 Oct 2014 11:14:17 +0300 Message-ID: <543643A1.6030002@FreeBSD.org> Date: Thu, 09 Oct 2014 11:13:21 +0300 From: Andriy Gapon User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:31.0) Gecko/20100101 Thunderbird/31.1.2 MIME-Version: 1.0 To: freebsd-dtrace@FreeBSD.org Subject: removing solaris cyclic Content-Type: text/plain; charset=X-VIET-VPS Content-Transfer-Encoding: 8bit X-BeenThere: freebsd-dtrace@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: "A discussion list for developers working on DTrace in FreeBSD." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 Oct 2014 08:14:19 -0000 I would like to ask for a review and/or testing of the following branch for a phased removal of solaris cyclic code: https://github.com/avg-I/freebsd/compare/review/no-cyclic Raw diff: https://github.com/avg-I/freebsd/compare/master...review/no-cyclic.diff The only user of cyclic now is DTrace profile provider, so I am converting it to use our improved callout(9). cyclic is almost a complete implementation of an alternative to our callout(9), so having that big chunk of foreign code which duplicates a core function is not nice. One thing that I am not sure about is what PROF_ARTIFICIAL_FRAMES should be on different platforms. Also, I am not sure if the number of interrupt, timer, etc frames depends on a timer being used. I'd appreciate any help on this. Thanks! -- Andriy Gapon From owner-freebsd-dtrace@FreeBSD.ORG Thu Oct 9 15:35:23 2014 Return-Path: Delivered-To: freebsd-dtrace@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 979F4FFE; Thu, 9 Oct 2014 15:35:23 +0000 (UTC) Received: from vps.hungerhost.com (vps.hungerhost.com [216.38.53.176]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 6A8EFF22; Thu, 9 Oct 2014 15:35:23 +0000 (UTC) Received: from mobile-107-107-58-90.mycingular.net ([107.107.58.90]:60108 helo=[172.20.10.3]) by vps.hungerhost.com with esmtpsa (TLSv1:DHE-RSA-AES256-SHA:256) (Exim 4.82) (envelope-from ) id 1XcFkE-0000o5-KF; Thu, 09 Oct 2014 11:35:13 -0400 From: "George Neville-Neil" To: "Andriy Gapon" Subject: Re: removing solaris cyclic Date: Thu, 09 Oct 2014 11:34:56 -0400 Message-ID: <49A880FD-F346-4033-A1E5-BA1BB69FD2DA@neville-neil.com> In-Reply-To: <543643A1.6030002@FreeBSD.org> References: <543643A1.6030002@FreeBSD.org> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=_MailMate_70B6A742-7FD8-47F6-99F4-C81A91743D1B_="; micalg=pgp-sha1; protocol="application/pgp-signature" X-Mailer: MailMate (1.8r4551) X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - vps.hungerhost.com X-AntiAbuse: Original Domain - freebsd.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - neville-neil.com X-Get-Message-Sender-Via: vps.hungerhost.com: authenticated_id: gnn@neville-neil.com Cc: freebsd-dtrace@FreeBSD.org X-BeenThere: freebsd-dtrace@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: "A discussion list for developers working on DTrace in FreeBSD." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 Oct 2014 15:35:23 -0000 This is an OpenPGP/MIME signed message (RFC 3156 and 4880). --=_MailMate_70B6A742-7FD8-47F6-99F4-C81A91743D1B_= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable On 9 Oct 2014, at 4:13, Andriy Gapon wrote: > I would like to ask for a review and/or testing of the following branch= for a > phased removal of solaris cyclic code: > https://github.com/avg-I/freebsd/compare/review/no-cyclic > Raw diff: https://github.com/avg-I/freebsd/compare/master...review/no-c= yclic.diff > > The only user of cyclic now is DTrace profile provider, so I am convert= ing it to > use our improved callout(9). cyclic is almost a complete implementatio= n of an > alternative to our callout(9), so having that big chunk of foreign code= which > duplicates a core function is not nice. > > One thing that I am not sure about is what PROF_ARTIFICIAL_FRAMES shoul= d be on > different platforms. Also, I am not sure if the number of interrupt, t= imer, etc > frames depends on a timer being used. I'd appreciate any help on this.= Can you create a reviews.freebsd.org patch for this? Thanks, George --=_MailMate_70B6A742-7FD8-47F6-99F4-C81A91743D1B_= Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- Comment: GPGTools - http://gpgtools.org iEYEARECAAYFAlQ2qyAACgkQYdh2wUQKM9JiAgCfV8TPbKT6kdumjvIyiXgj0zgf 5gIAnirdixA/e3wz8BHtClNGeZlBjSjy =1tVc -----END PGP SIGNATURE----- --=_MailMate_70B6A742-7FD8-47F6-99F4-C81A91743D1B_=--