Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 17 Oct 2014 01:10:12 +0000
From:      "Pokala, Ravi" <rpokala@panasas.com>
To:        "freebsd-geom@freebsd.org" <freebsd-geom@freebsd.org>
Subject:   Minor addition to confdot (w/ patch)
Message-ID:  <D065BA81.120898%rpokala@panasas.com>

next in thread | raw e-mail | index | archive | help
Hi folks,

The GEOM stack diagrams created by 'sysctl -b kern.geom.confdot' (and then
run through `dot') are really quite handy. One thing that we really needed
at Panasas, but which is not included in the diagram, is the providers'
sectorsize and stripesize. This small change adds that info; if there are
no objections, could someone submit it on my behalf?

Thanks,

Ravi


Index: sys/geom/geom_dump.c
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
--- sys/geom/geom_dump.c	(revision 273186)
+++ sys/geom/geom_dump.c	(working copy)
@@ -61,8 +61,8 @@
 g_confdot_provider(struct sbuf *sb, struct g_provider *pp)
 {
=20
-	sbuf_printf(sb, "z%p
[shape=3Dhexagon,label=3D\"%s\\nr%dw%de%d\\nerr#%d\"];\n",
-	    pp, pp->name, pp->acr, pp->acw, pp->ace, pp->error);
+	sbuf_printf(sb, "z%p
[shape=3Dhexagon,label=3D\"%s\\nr%dw%de%d\\nerr#%d\\nsector=3D%d\\nstripe=
=3D%d\"];\
n",
+	    pp, pp->name, pp->acr, pp->acw, pp->ace, pp->error, pp->sectorsize,
pp->stripesize);
 }
=20
 static void





Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?D065BA81.120898%rpokala>