Date: Sat, 13 Sep 2014 23:10:15 -0700 From: Adrian Chadd <adrian@freebsd.org> To: Eric Joyner <ricera10@gmail.com> Cc: Jack F Vogel <jfv@freebsd.org>, FreeBSD Net <freebsd-net@freebsd.org>, "Joyner, Eric" <eric.joyner@intel.com> Subject: Re: [igb] add DROP_EN to each RX queue config if TX flow control is disabled Message-ID: <CAJ-VmonvT7YAxLm3L-%2B=nz9fsbMDF-Td4iVmqr4%2BZo=98Pz2Rg@mail.gmail.com> In-Reply-To: <CA%2Bb0zg_Eq7wLP6SRCpBUT5DXDPSxSk=WFZ7-c98W_Xg74-Krzg@mail.gmail.com> References: <CAJ-Vmok6aSE=ZFZcrBCZUTdHTXosE2eAzG%2Bxkhwn=XM7c7P3Pg@mail.gmail.com> <CA%2Bb0zg_Eq7wLP6SRCpBUT5DXDPSxSk=WFZ7-c98W_Xg74-Krzg@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 13 September 2014 13:09, Eric Joyner <ricera10@gmail.com> wrote: > This looks good to me. The only comment I have is that according to the I350 > datasheet, DROP_EN is already set on all the queues but 0 by default, but I > haven't checked for the other adapters covered by igb. Right, but the igb_initialize_receive_units() function actually overrides the queue SRRCTL; it doesn't do a read-modify-write of what the initial defaults are. -a
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAJ-VmonvT7YAxLm3L-%2B=nz9fsbMDF-Td4iVmqr4%2BZo=98Pz2Rg>