From owner-svn-ports-svnadmin@FreeBSD.ORG Sun Aug 10 22:38:54 2014 Return-Path: Delivered-To: svn-ports-svnadmin@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 6EF83FEA for ; Sun, 10 Aug 2014 22:38:54 +0000 (UTC) Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:1900:2254:2068::e6a:0]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 452522802 for ; Sun, 10 Aug 2014 22:38:54 +0000 (UTC) Received: from wg (uid 1317) (envelope-from wg@FreeBSD.org) id 2a02 by svn.freebsd.org (DragonFly Mail Agent v0.9+); Sun, 10 Aug 2014 22:38:54 +0000 From: William Grzybowski Date: Sun, 10 Aug 2014 22:38:54 +0000 (UTC) To: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-svnadmin@freebsd.org Subject: svn commit: r364580 - svnadmin/conf X-SVN-Group: ports-svnadmin MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Message-Id: <53e7f47e.2a02.4502c6f@svn.freebsd.org> X-BeenThere: svn-ports-svnadmin@freebsd.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: SVN commit messages for svnadmin of the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 10 Aug 2014 22:38:54 -0000 Author: wg Date: Sun Aug 10 22:38:53 2014 New Revision: 364580 URL: http://svnweb.freebsd.org/changeset/ports/364580 QAT: https://qat.redports.org/buildarchive/r364580/ Log: Please welcome Dan Langille (dvl@) as a new ports commiter! mat@ and I will mentor him. Approved by: portmgr (implicit) Modified: svnadmin/conf/access svnadmin/conf/mentors Modified: svnadmin/conf/access ============================================================================== --- svnadmin/conf/access Sun Aug 10 22:34:50 2014 (r364579) +++ svnadmin/conf/access Sun Aug 10 22:38:53 2014 (r364580) @@ -63,6 +63,7 @@ des dhn dinoex dryice +dvl eadler edwin ehaupt Modified: svnadmin/conf/mentors ============================================================================== --- svnadmin/conf/mentors Sun Aug 10 22:34:50 2014 (r364579) +++ svnadmin/conf/mentors Sun Aug 10 22:38:53 2014 (r364580) @@ -15,6 +15,7 @@ # Mentee Mentor Optional comment alexey wg bmah mat +dvl wg Co-mentor: mat gnn skreuzer grembo flo Co-mentor: bapt jsa wxs Co-mentor: kwm From owner-svn-ports-svnadmin@FreeBSD.ORG Fri Aug 15 19:12:59 2014 Return-Path: Delivered-To: svn-ports-svnadmin@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id BA78EC97; Fri, 15 Aug 2014 19:12:59 +0000 (UTC) Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:1900:2254:2068::e6a:0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 8C5072DBE; Fri, 15 Aug 2014 19:12:59 +0000 (UTC) Received: from svn.freebsd.org ([127.0.1.70]) by svn.freebsd.org (8.14.9/8.14.9) with ESMTP id s7FJCxpH035917; Fri, 15 Aug 2014 19:12:59 GMT (envelope-from wg@FreeBSD.org) Received: (from wg@localhost) by svn.freebsd.org (8.14.9/8.14.9/Submit) id s7FJCxqj035915; Fri, 15 Aug 2014 19:12:59 GMT (envelope-from wg@FreeBSD.org) Message-Id: <201408151912.s7FJCxqj035915@svn.freebsd.org> X-Authentication-Warning: svn.freebsd.org: wg set sender to wg@FreeBSD.org using -f From: William Grzybowski Date: Fri, 15 Aug 2014 19:12:59 +0000 (UTC) To: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-svnadmin@freebsd.org Subject: svn commit: r365025 - in svnadmin/hooks: . scripts X-SVN-Group: ports-svnadmin MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: svn-ports-svnadmin@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: SVN commit messages for svnadmin of the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 15 Aug 2014 19:12:59 -0000 Author: wg Date: Fri Aug 15 19:12:58 2014 New Revision: 365025 URL: http://svnweb.freebsd.org/changeset/ports/365025 QAT: https://qat.redports.org/buildarchive/r365025/ Log: Add a svn hook to disable filenames containing a colon (:). Phabric: D504 Approved by: portmgr (mat, bdrewery) Added: svnadmin/hooks/scripts/detect-filename.sh (contents, props changed) Modified: svnadmin/hooks/pre-commit Modified: svnadmin/hooks/pre-commit ============================================================================== --- svnadmin/hooks/pre-commit Fri Aug 15 19:09:17 2014 (r365024) +++ svnadmin/hooks/pre-commit Fri Aug 15 19:12:58 2014 (r365025) @@ -98,6 +98,9 @@ stage-only.sh "$REPO" "$TXN" || exit 1 # check commits to vulk.xml don't have other files vulnxml-unique.sh "$REPO" "$TXN" || exit 1 +# check for filenames with invalid chars +detect-filename.sh "$REPO" "$TXN" || exit 1 + # check for merge debris detect-merge-conflicts.sh "$REPO" "$TXN" || exit 1 Added: svnadmin/hooks/scripts/detect-filename.sh ============================================================================== --- /dev/null 00:00:00 1970 (empty, because file is newly added) +++ svnadmin/hooks/scripts/detect-filename.sh Fri Aug 15 19:12:58 2014 (r365025) @@ -0,0 +1,30 @@ +#!/bin/sh +# pre-commit hook to detect files containing not allowed characters +# $FreeBSD$ + +REPO=$1 +TXN=$2 + +SVNLOOK=/usr/local/bin/svnlook + +# Check arguments +if [ -z "$REPO" -o -z "$TXN" ]; then + echo "Syntax: $0 path_to_repos txn_id" >&2 + exit 1 +fi + +# Approved by portmgr gets a free pass +$SVNLOOK log -t "$TXN" "$REPO" | grep -q 'portmgr' && exit 0 + +# We scan through the transaction diff, looking for files with colon in the name +if $SVNLOOK changed -t "$TXN" "$REPO" | grep -q -E '^A.*:'; then + echo "Some files in your commit have a colon (:) in the name" >&2 + echo "which is not allowed. Use __ instead of :: for patches ." >&2 + echo "For further information please read:" >&2 + echo "http://www.freebsd.org/doc/en/books/porters-handbook/slow-patch.html" >&2 + echo "Please fix this and try committing again." >&2 + exit 1 +fi + +# No files with invalid chars were detected +exit 0