Date: Sun, 10 May 2015 12:04:56 -0500 From: "Matthew D. Fuller" <fullermd@over-yonder.net> To: Fabian Keil <freebsd-listen@fabiankeil.de> Cc: freebsd-geom@freebsd.org Subject: Re: RFC: Pass TRIM through GELI Message-ID: <20150510170456.GZ2092@over-yonder.net> In-Reply-To: <4ea2ed80.2a96d87b@fabiankeil.de> References: <20150308000131.GP1742@over-yonder.net> <20150324021924.GQ52331@over-yonder.net> <20150502125220.GS78376@over-yonder.net> <4ea2ed80.2a96d87b@fabiankeil.de>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, May 03, 2015 at 03:25:30PM +0200 I heard the voice of Fabian Keil, and lo! it spake thus: > > One minor issue I ran into is that a patched kernel will reject > onetime requests from an unpatched userland: Updated the patch on <https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=198863>; with trim and detach fixed there. While I was at it, I also made some similar changes on the boot/trim flags in 'configure' handling so it works with old userland too. Of course, it still throws errors up on the terminal when you try, but then it goes ahead and does the stuff. I sorta think that's unnecessary, and maybe we oughta bypass gctl_get_paraml()'s error spouting; in these cases it's not really fatal if the param isn't there. It does point up the being-out-of-sync, but I dunno if that's worth bugging the user in such a roundabout way. But either way, that's a whole different issue from just adding trim. With the new patch, it should at least work with stuff unsync'd. So, where's the best place to hide out on the road and waylay a committer? -- Matthew Fuller (MF4839) | fullermd@over-yonder.net Systems/Network Administrator | http://www.over-yonder.net/~fullermd/ On the Internet, nobody can hear you scream.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20150510170456.GZ2092>