From owner-freebsd-pf@FreeBSD.ORG Sun Dec 28 00:21:11 2014 Return-Path: Delivered-To: freebsd-pf@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id DEC2E449 for ; Sun, 28 Dec 2014 00:21:11 +0000 (UTC) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id C664F167A for ; Sun, 28 Dec 2014 00:21:11 +0000 (UTC) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.14.9/8.14.9) with ESMTP id sBS0LBYf028994 for ; Sun, 28 Dec 2014 00:21:11 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-pf@FreeBSD.org Subject: [Bug 183198] [pf] pf tables not loaded if only used inside anchor Date: Sun, 28 Dec 2014 00:21:11 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 10.0-BETA1 X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: krichy@cflinux.hu X-Bugzilla-Status: In Progress X-Bugzilla-Priority: Normal X-Bugzilla-Assigned-To: freebsd-pf@FreeBSD.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: cc attachments.created Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-pf@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: "Technical discussion and general questions about packet filter \(pf\)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 28 Dec 2014 00:21:12 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=183198 krichy@cflinux.hu changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |krichy@cflinux.hu --- Comment #2 from krichy@cflinux.hu --- Created attachment 151017 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=151017&action=edit pf anchor generated table fix -- You are receiving this mail because: You are the assignee for the bug. From owner-freebsd-pf@FreeBSD.ORG Sun Dec 28 11:17:47 2014 Return-Path: Delivered-To: freebsd-pf@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 8E84CA03 for ; Sun, 28 Dec 2014 11:17:47 +0000 (UTC) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 757A12EA2 for ; Sun, 28 Dec 2014 11:17:47 +0000 (UTC) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.14.9/8.14.9) with ESMTP id sBSBHlQq031719 for ; Sun, 28 Dec 2014 11:17:47 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-pf@FreeBSD.org Subject: [Bug 183198] [pf] pf tables not loaded if only used inside anchor Date: Sun, 28 Dec 2014 11:17:46 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 10.0-BETA1 X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: krichy@cflinux.hu X-Bugzilla-Status: In Progress X-Bugzilla-Priority: Normal X-Bugzilla-Assigned-To: freebsd-pf@FreeBSD.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: attachments.isobsolete attachments.created Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-pf@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: "Technical discussion and general questions about packet filter \(pf\)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 28 Dec 2014 11:17:47 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=183198 krichy@cflinux.hu changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151017|0 |1 is obsolete| | --- Comment #3 from krichy@cflinux.hu --- Created attachment 151030 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=151030&action=edit pf inline anchor optimization fix Loads all generated tables into the ruleset (anchor) where the rules occur. -- You are receiving this mail because: You are the assignee for the bug. From owner-freebsd-pf@FreeBSD.ORG Mon Dec 29 17:06:20 2014 Return-Path: Delivered-To: freebsd-pf@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id A6AB2B15 for ; Mon, 29 Dec 2014 17:06:20 +0000 (UTC) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 8E05A34D9 for ; Mon, 29 Dec 2014 17:06:20 +0000 (UTC) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.14.9/8.14.9) with ESMTP id sBTH6KLH043706 for ; Mon, 29 Dec 2014 17:06:20 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-pf@FreeBSD.org Subject: [Bug 183198] [pf] pf tables not loaded if only used inside anchor Date: Mon, 29 Dec 2014 17:06:20 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 10.0-BETA1 X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: krichy@cflinux.hu X-Bugzilla-Status: In Progress X-Bugzilla-Priority: Normal X-Bugzilla-Assigned-To: freebsd-pf@FreeBSD.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: attachments.created Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-pf@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: "Technical discussion and general questions about packet filter \(pf\)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 29 Dec 2014 17:06:20 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=183198 --- Comment #4 from krichy@cflinux.hu --- Created attachment 151074 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=151074&action=edit pf table reference count increment for root tables This places a rule reference count on root tables also, thus making them active. This solves the automatic tables's problem also, but maybe it is desirable to have automatic tables created in the correct ruleset. -- You are receiving this mail because: You are the assignee for the bug. From owner-freebsd-pf@FreeBSD.ORG Mon Dec 29 22:07:14 2014 Return-Path: Delivered-To: freebsd-pf@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 0158AFC8 for ; Mon, 29 Dec 2014 22:07:13 +0000 (UTC) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id DD07D1C2D for ; Mon, 29 Dec 2014 22:07:13 +0000 (UTC) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.14.9/8.14.9) with ESMTP id sBTM7DHd068453 for ; Mon, 29 Dec 2014 22:07:13 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-pf@FreeBSD.org Subject: [Bug 183198] [pf] pf tables not loaded if only used inside anchor Date: Mon, 29 Dec 2014 22:07:13 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 10.0-BETA1 X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: krichy@cflinux.hu X-Bugzilla-Status: In Progress X-Bugzilla-Priority: Normal X-Bugzilla-Assigned-To: freebsd-pf@FreeBSD.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: attachments.isobsolete attachments.created Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-pf@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: "Technical discussion and general questions about packet filter \(pf\)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 29 Dec 2014 22:07:14 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=183198 krichy@cflinux.hu changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151030|0 |1 is obsolete| | Attachment #151074|0 |1 is obsolete| | --- Comment #5 from krichy@cflinux.hu --- Created attachment 151094 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=151094&action=edit pf table keep active flag conditions A more elegant way to solve previous problems: keep a table active when either it has PFR_TFLAG_REFDANCHOR set. -- You are receiving this mail because: You are the assignee for the bug. From owner-freebsd-pf@FreeBSD.ORG Sat Jan 3 00:26:22 2015 Return-Path: Delivered-To: freebsd-pf@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 42AD8E18 for ; Sat, 3 Jan 2015 00:26:22 +0000 (UTC) Received: from mail-lb0-x22c.google.com (mail-lb0-x22c.google.com [IPv6:2a00:1450:4010:c04::22c]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id B1F482578 for ; Sat, 3 Jan 2015 00:26:21 +0000 (UTC) Received: by mail-lb0-f172.google.com with SMTP id z12so7724409lbi.31 for ; Fri, 02 Jan 2015 16:26:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:date:message-id:subject:from:to:content-type; bh=tYzMrlIK7b+vmcPtTCrjBWA2/GA50Avr1TdhvEn21Qo=; b=OcvlDpmkVB5DiWxQj9L/dtIUv/RlQeuXhjbFBYVzup3qRRuzPfX12SQdGkOAzm7jSb B1bVlBXQHZXLS+nX3su2Do6AgxE4Y67IUGets6cdAbrV9Rf7H56Wh8Q3AhJEJtTCtTOX P//3dMDb6/7K/n1Jmv7K8Urt8Kd9IEpZUWV7D+Py9TSQ0FVav94/ANMrGNIMuwpQi8V6 hwO5RgSNgY102lEb89FtyCo3Hli6pkygxM1AQ9qBg/QqLqfrZf6xgjhUEj/Y9GbYflv+ RwjAe95gnXVf6qvg6d8/8DiWKOSI8djdNgmFqE5Z+DGH52h+SY6bCQH8MRhtOpbLVgct 1TqQ== MIME-Version: 1.0 X-Received: by 10.112.148.73 with SMTP id tq9mr78965283lbb.37.1420244779663; Fri, 02 Jan 2015 16:26:19 -0800 (PST) Sender: crodr001@gmail.com Received: by 10.112.141.5 with HTTP; Fri, 2 Jan 2015 16:26:19 -0800 (PST) Date: Fri, 2 Jan 2015 16:26:19 -0800 X-Google-Sender-Auth: ABFrLLEiWnafqWSHZENIjAGmw8Q Message-ID: Subject: Fixes for VIMAGE + PF From: Craig Rodrigues To: freebsd-pf@freebsd.org Content-Type: text/plain; charset=ISO-8859-1 X-Content-Filtered-By: Mailman/MimeDel 2.1.18-1 X-BeenThere: freebsd-pf@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: "Technical discussion and general questions about packet filter \(pf\)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 03 Jan 2015 00:26:22 -0000 Hi, Please review these fixes for VIMAGE + PF: https://reviews.freebsd.org/D1309 https://reviews.freebsd.org/D1312 https://reviews.freebsd.org/D1313 https://reviews.freebsd.org/D1315 If you need to get set up with using the review tool, read: https://wiki.freebsd.org/CodeReview -- Craig