From owner-freebsd-ports-bugs@freebsd.org Sun Sep 27 00:15:11 2015 Return-Path: Delivered-To: freebsd-ports-bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 972C09CFB98 for ; Sun, 27 Sep 2015 00:15:11 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 82E58BAF for ; Sun, 27 Sep 2015 00:15:11 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id t8R0FBDB049510 for ; Sun, 27 Sep 2015 00:15:11 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 200853] databases/sqlite3: enable DBSTAT by default for firefox 41+ Date: Sun, 27 Sep 2015 00:15:11 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: easy, feature, needs-qa, patch X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: milios@ccsys.com X-Bugzilla-Status: Open X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-ports-bugs@FreeBSD.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: maintainer-feedback- X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 27 Sep 2015 00:15:11 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=200853 --- Comment #9 from milios@ccsys.com --- it's my understanding that the ABI/API impact should be none. furthermore, an application must explicitly ask for this virtual table to be created before using it so there shouldn't be any namespace collisions. i have not done any comparative benchmarks but at a glance it seems to me this dbstat.c module is, upon being queried, only extracting and presenting information already in core rather than stashing additional data at runtime, so the performance impact should also be zero or near-zero to apps not using it. it does increase the size of the lib by about 1.0 percent. perhaps maintainer reversed his approval on Aug 10 due to issues which were later fixed here https://www.sqlite.org/src/info/6beb512c7a3c3649 and included in port here https://svnweb.freebsd.org/ports?view=revision&revision=395101 . i've just emailed him asking for a clarification. i am no expert. these comments are my own, not my employer's. -- You are receiving this mail because: You are the assignee for the bug.