From owner-freebsd-tcltk@freebsd.org Tue Nov 10 16:07:31 2015 Return-Path: Delivered-To: freebsd-tcltk@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 75395A2B88C for ; Tue, 10 Nov 2015 16:07:31 +0000 (UTC) (envelope-from mailing-machine@vniz.net) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id 4DC561DB0 for ; Tue, 10 Nov 2015 16:07:31 +0000 (UTC) (envelope-from mailing-machine@vniz.net) Received: by mailman.ysv.freebsd.org (Postfix) id 49F97A2B887; Tue, 10 Nov 2015 16:07:31 +0000 (UTC) Delivered-To: tcltk@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 498F2A2B885 for ; Tue, 10 Nov 2015 16:07:31 +0000 (UTC) (envelope-from mailing-machine@vniz.net) Received: from mail-lf0-f51.google.com (mail-lf0-f51.google.com [209.85.215.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id C6E511DAC for ; Tue, 10 Nov 2015 16:07:30 +0000 (UTC) (envelope-from mailing-machine@vniz.net) Received: by lffu14 with SMTP id u14so778416lff.1 for ; Tue, 10 Nov 2015 08:07:28 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to:content-type; bh=WiopZ85Xf1/fpwM9XbLw5axSvlJK4AlO651CWwtXdGA=; b=EA4pLcZ2YqwHXnNNH6w04sPaD3IhzK9G5CsRsuNSh/xYmZ2dh7edNe54KSpvlDPa5K uZa5vArPVr5gxwuNhBJsUC42wqU5nlDwboCkwzqd/y7zUFDETlx0JrsvcltC3KKrhrnx 2+UqFkcOUvxzj63iNyow8xLBLpzL5J3mUfjFQRhBzhJgqPrCCsfSPBLKcDNXYNujb6z1 067kuiekZ/ZNPoS6/E7Sew+j2H9R1JQdCe55eXLvBYmbyDiTNjZJ0AMs+fSyM4bN6idZ hwphue/cJwrjuxyUlHYAbSX9T79Dr7EpxDXTYz3fjmWuAIYMUDXEdr5q+xveBd+oQZFf vsyQ== X-Gm-Message-State: ALoCoQkjC6y+dTNfrf6EIQJ3N9dDMqCO8UU4C9M8NR9VT3ememyY0PRXdg+IRA1XUdBg80a6ptp3 X-Received: by 10.25.170.11 with SMTP id t11mr1976559lfe.20.1447171648290; Tue, 10 Nov 2015 08:07:28 -0800 (PST) Received: from [192.168.1.2] ([89.169.173.68]) by smtp.gmail.com with ESMTPSA id ai8sm641446lbd.11.2015.11.10.08.07.27 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 10 Nov 2015 08:07:27 -0800 (PST) Subject: Re: svn commit: r290637 - head/lib/libc/locale To: Baptiste Daroussin , tcltk@FreeBSD.org References: <201511100811.tAA8BR0R034338@repo.freebsd.org> <5641E7B4.2070508@freebsd.org> <20151110130430.GK10134@ivaldir.etoilebsd.net> <5641EF26.8060600@freebsd.org> <20151110133615.GL10134@ivaldir.etoilebsd.net> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org From: Andrey Chernov X-Enigmail-Draft-Status: N1110 Message-ID: <5642163E.1050405@freebsd.org> Date: Tue, 10 Nov 2015 19:07:26 +0300 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <20151110133615.GL10134@ivaldir.etoilebsd.net> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="7eBmxXoclN9i9Gr1lbf6o14rJp3IvHNmN" X-BeenThere: freebsd-tcltk@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FreeBSD-specific Tcl/Tk discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Nov 2015 16:07:31 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --7eBmxXoclN9i9Gr1lbf6o14rJp3IvHNmN Content-Type: text/plain; charset=koi8-r Content-Transfer-Encoding: quoted-printable On 10.11.2015 16:36, Baptiste Daroussin wrote: > On Tue, Nov 10, 2015 at 04:20:38PM +0300, Andrey Chernov wrote: >> On 10.11.2015 16:04, Baptiste Daroussin wrote: >>> On Tue, Nov 10, 2015 at 03:48:52PM +0300, Andrey Chernov wrote: >>>> On 10.11.2015 11:11, Baptiste Daroussin wrote: >>>>> Author: bapt >>>>> Date: Tue Nov 10 08:11:27 2015 >>>>> New Revision: 290637 >>>>> URL: https://svnweb.freebsd.org/changeset/base/290637 >>>>> >>>>> Log: >>>>> return "US-ASCII" instead of "POSIX" for "C" and "POSIX" locales >>>>> as it used to be in previous version of the locales. Returning >>>>> "POSIX" has too many fallouts. >>>> >>>> You can return "ANSI_X3.4-1968" (another name of "US-ASCII") to be >>>> different with real US-ASCII. It is what glibc returns for C/POSIX >>>> locale and most ports expected, being linux-oriented. >>>> >>> I thought about it, but in the end it is probably safer for now that = nl_langinfo >>> return US-ASCII as it did in the past, to reduce breakage with FreeBS= D only code >>> that maybe be existing ou there. >> >> All FreeBSD code I know never check locale this way. IMHO probability = of >> potential danger to meet some linux-oriented port with this check is >> much much higher than to meet similar FreeBSD only code in the wild. I= n >> any case, changing collate order from A-Za-z to aA-zZ we do just now >> have much higher probability to break unknown FreeBSD only code, so on= e >> breaking change can go with other one together. >> > That is true, except that the new collation thing is invalidated as soo= n as you > set LC_COLLATE=3DC which bring your back to A-Za-z. So you have a worka= round while > changing the return value of nl_langinfo() is not workaroundable. Well, forget my improper comparison with collate and see this bug in action right now, in our port tcl8.6.4/unix/tclUnixInit.c: See localeTable and comment above it, there is internal "ansi_x3.4-1968" (i.e. POSIX locale), internal "ascii" and even no alias for our "us-ascii" at all. It gets info through nl_langinfo(CODESET), lowercased. I.e. not using "ANSI_X3.4-1968" breaks all tcl ports right now, this is more essential than hypothetical private FreeBSD only code no one see. --=20 http://ache.vniz.net/ --7eBmxXoclN9i9Gr1lbf6o14rJp3IvHNmN Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQEcBAEBCAAGBQJWQhY+AAoJEKUckv0MjfbKqXUH/0uiAxp2+xqp1Z1B8p5JlqBT YRHkQyGWiJRYaw+HceXwhfGFe3LhIpPAgLaND0H7AIPOFjKP5B9kDr4OKwY6CjFI 2ogBIlkJkLJvSshS2DzSICiGrsAbs2hAGx7FHIODtaSEx6jSrlbDX8a/sBETopeT uT0Z95hnBWfut5eEQuymQnrAS0rCr2IcJECuzFInZ57KJ0RmruLdSZtNO/VSCIEU 99YDp5MAMk9/YdQvS9nAWF/mlu/nQSEN0dHSXWt0q507OovOkFtPvihIYUCMFZxe BkbNwYXCSMJ5q4W9FvklGHXz6qJkkOKiwh0EQYklXeMaEBfdbRPItKL/SchFyYg= =mbgi -----END PGP SIGNATURE----- --7eBmxXoclN9i9Gr1lbf6o14rJp3IvHNmN-- From owner-freebsd-tcltk@freebsd.org Tue Nov 10 16:12:10 2015 Return-Path: Delivered-To: freebsd-tcltk@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id CBDFAA2BAF2 for ; Tue, 10 Nov 2015 16:12:10 +0000 (UTC) (envelope-from baptiste.daroussin@gmail.com) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id A68471175 for ; Tue, 10 Nov 2015 16:12:10 +0000 (UTC) (envelope-from baptiste.daroussin@gmail.com) Received: by mailman.ysv.freebsd.org (Postfix) id A50E9A2BAEE; Tue, 10 Nov 2015 16:12:10 +0000 (UTC) Delivered-To: tcltk@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 8973FA2BAED; Tue, 10 Nov 2015 16:12:10 +0000 (UTC) (envelope-from baptiste.daroussin@gmail.com) Received: from mail-wm0-x235.google.com (mail-wm0-x235.google.com [IPv6:2a00:1450:400c:c09::235]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 22A721173; Tue, 10 Nov 2015 16:12:10 +0000 (UTC) (envelope-from baptiste.daroussin@gmail.com) Received: by wmww144 with SMTP id w144so7268222wmw.0; Tue, 10 Nov 2015 08:12:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=gPqXue4glG7mR5MmrhGgYJfAs5JqTqWPEuiQk+Yd8Ik=; b=e+T5k1/VblgdQBLkh9Df1JnNq3j9P9qLhgtUPswb87LAohArH/YbjY0CYupJcTtYdE qL9h7Gp7ypUWVzXR1Kn9yJ3d70wG290YwXZ303y1PmYO5dVtDUMWwz7yTiDsEx3vROMD LeI4VJucq7ePI+iWV1SCEO1GujDLAO3tu7PpSN/Z//8tSX/R4A3fdPzCmcJtpmgJDwzx eXSRaCiFaWdcE7vTwUDkWIsmrdSnAnb4RHxW71u77ddN5jDoFB7HDNyi1EZ62Z0in9ek OBq4BjP26A2/bNIOBu9/7S32s6R7rYJ61a+YgnO/v3/WtG/3uJeRDaZ6A7Y76Yt4IQsJ NYZw== X-Received: by 10.28.229.212 with SMTP id c203mr30979745wmh.11.1447171927743; Tue, 10 Nov 2015 08:12:07 -0800 (PST) Received: from ivaldir.etoilebsd.net ([2001:41d0:8:db4c::1]) by smtp.gmail.com with ESMTPSA id w66sm4841068wme.11.2015.11.10.08.12.06 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 10 Nov 2015 08:12:06 -0800 (PST) Sender: Baptiste Daroussin Date: Tue, 10 Nov 2015 17:12:04 +0100 From: Baptiste Daroussin To: Andrey Chernov Cc: tcltk@FreeBSD.org, svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r290637 - head/lib/libc/locale Message-ID: <20151110161204.GM10134@ivaldir.etoilebsd.net> References: <201511100811.tAA8BR0R034338@repo.freebsd.org> <5641E7B4.2070508@freebsd.org> <20151110130430.GK10134@ivaldir.etoilebsd.net> <5641EF26.8060600@freebsd.org> <20151110133615.GL10134@ivaldir.etoilebsd.net> <5642163E.1050405@freebsd.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="OGW1Z2JKiS9bXo17" Content-Disposition: inline In-Reply-To: <5642163E.1050405@freebsd.org> User-Agent: Mutt/1.5.24 (2015-08-30) X-BeenThere: freebsd-tcltk@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FreeBSD-specific Tcl/Tk discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Nov 2015 16:12:10 -0000 --OGW1Z2JKiS9bXo17 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Nov 10, 2015 at 07:07:26PM +0300, Andrey Chernov wrote: > On 10.11.2015 16:36, Baptiste Daroussin wrote: > > On Tue, Nov 10, 2015 at 04:20:38PM +0300, Andrey Chernov wrote: > >> On 10.11.2015 16:04, Baptiste Daroussin wrote: > >>> On Tue, Nov 10, 2015 at 03:48:52PM +0300, Andrey Chernov wrote: > >>>> On 10.11.2015 11:11, Baptiste Daroussin wrote: > >>>>> Author: bapt > >>>>> Date: Tue Nov 10 08:11:27 2015 > >>>>> New Revision: 290637 > >>>>> URL: https://svnweb.freebsd.org/changeset/base/290637 > >>>>> > >>>>> Log: > >>>>> return "US-ASCII" instead of "POSIX" for "C" and "POSIX" locales > >>>>> as it used to be in previous version of the locales. Returning > >>>>> "POSIX" has too many fallouts. > >>>> > >>>> You can return "ANSI_X3.4-1968" (another name of "US-ASCII") to be > >>>> different with real US-ASCII. It is what glibc returns for C/POSIX > >>>> locale and most ports expected, being linux-oriented. > >>>> > >>> I thought about it, but in the end it is probably safer for now that = nl_langinfo > >>> return US-ASCII as it did in the past, to reduce breakage with FreeBS= D only code > >>> that maybe be existing ou there. > >> > >> All FreeBSD code I know never check locale this way. IMHO probability = of > >> potential danger to meet some linux-oriented port with this check is > >> much much higher than to meet similar FreeBSD only code in the wild. In > >> any case, changing collate order from A-Za-z to aA-zZ we do just now > >> have much higher probability to break unknown FreeBSD only code, so one > >> breaking change can go with other one together. > >> > > That is true, except that the new collation thing is invalidated as soo= n as you > > set LC_COLLATE=3DC which bring your back to A-Za-z. So you have a worka= round while > > changing the return value of nl_langinfo() is not workaroundable. >=20 > Well, forget my improper comparison with collate and see this bug in > action right now, in our port tcl8.6.4/unix/tclUnixInit.c: >=20 > See localeTable and comment above it, there is internal "ansi_x3.4-1968" > (i.e. POSIX locale), internal "ascii" and even no alias for our > "us-ascii" at all. >=20 > It gets info through nl_langinfo(CODESET), lowercased. I.e. not using > "ANSI_X3.4-1968" breaks all tcl ports right now, this is more essential > than hypothetical private FreeBSD only code no one see. That one is a valid point, that also means that is is broken right now on FreeBSD 10 and below? Best regards, Bapt --OGW1Z2JKiS9bXo17 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAlZCF1QACgkQ8kTtMUmk6EyP/QCfWiV1aNhs9KSkUD9jju/7ms0L KXYAnRYIik2hzCtx9XwqnBHg1Tzl4GG/ =ZF+g -----END PGP SIGNATURE----- --OGW1Z2JKiS9bXo17-- From owner-freebsd-tcltk@freebsd.org Tue Nov 10 16:19:52 2015 Return-Path: Delivered-To: freebsd-tcltk@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id E73F8A2BECF for ; Tue, 10 Nov 2015 16:19:51 +0000 (UTC) (envelope-from mailing-machine@vniz.net) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id BE4711C07 for ; Tue, 10 Nov 2015 16:19:51 +0000 (UTC) (envelope-from mailing-machine@vniz.net) Received: by mailman.ysv.freebsd.org (Postfix) id BCB62A2BECD; Tue, 10 Nov 2015 16:19:51 +0000 (UTC) Delivered-To: tcltk@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id BC499A2BECC for ; Tue, 10 Nov 2015 16:19:51 +0000 (UTC) (envelope-from mailing-machine@vniz.net) Received: from mail-lf0-f41.google.com (mail-lf0-f41.google.com [209.85.215.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 632A01C06 for ; Tue, 10 Nov 2015 16:19:51 +0000 (UTC) (envelope-from mailing-machine@vniz.net) Received: by lfdo63 with SMTP id o63so971313lfd.2 for ; Tue, 10 Nov 2015 08:19:49 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to:content-type; bh=tjWdaLCu5hj4eQNuZLNiVQBjcgV6Jy+MUNB0yvtZQ5Q=; b=FOUXA0Ek0rRKjkYJEl00Zmyy0RtUNgzcwiVHtnjm3j0cQ8Yi6iXwRC0hJeIuMq01RU Mbfv556MhThEL4XIJgLSTQ2J8gJt2AyKqrmzjJIn71CZuQzjFm+3zU/CEhvbpuXGbpg6 Ni5mA6hNCfIhwowuSCuPpznVSwOg0S6QUmvbIFJlwjQ1iYL1Huh00F6wIsqkPJjzW5bT UpcIKCqPFGT93s+ZUGmTSleN732JYpzSUN2Fwe1JQ9fpham+Cjn16j/kfbu7Fb1QwNR2 2Xd3OhHROIl9OiCbsGsL7mFV4IdzelyNR2fpdCfq7Bp36JfqxWfJQBfj2zd5iMgXJVKN J3ug== X-Gm-Message-State: ALoCoQng5qWxJ0qCt/KMDpSXm5Jp6XkSScHIBp/hE1vXley8Dv/jPguzUvsSXzHzAUSb/qXIRLcI X-Received: by 10.25.211.210 with SMTP id k201mr1764310lfg.30.1447172389308; Tue, 10 Nov 2015 08:19:49 -0800 (PST) Received: from [192.168.1.2] ([89.169.173.68]) by smtp.gmail.com with ESMTPSA id k1sm655730lfe.23.2015.11.10.08.19.48 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 10 Nov 2015 08:19:48 -0800 (PST) Subject: Re: svn commit: r290637 - head/lib/libc/locale To: Baptiste Daroussin References: <201511100811.tAA8BR0R034338@repo.freebsd.org> <5641E7B4.2070508@freebsd.org> <20151110130430.GK10134@ivaldir.etoilebsd.net> <5641EF26.8060600@freebsd.org> <20151110133615.GL10134@ivaldir.etoilebsd.net> <5642163E.1050405@freebsd.org> <20151110161204.GM10134@ivaldir.etoilebsd.net> Cc: tcltk@FreeBSD.org, svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org From: Andrey Chernov Message-ID: <56421923.7080601@freebsd.org> Date: Tue, 10 Nov 2015 19:19:47 +0300 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <20151110161204.GM10134@ivaldir.etoilebsd.net> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="PuKg2eHPNNvjl8UeQ6v8WHta5mjDtdWw2" X-BeenThere: freebsd-tcltk@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FreeBSD-specific Tcl/Tk discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Nov 2015 16:19:52 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --PuKg2eHPNNvjl8UeQ6v8WHta5mjDtdWw2 Content-Type: text/plain; charset=koi8-r Content-Transfer-Encoding: quoted-printable On 10.11.2015 19:12, Baptiste Daroussin wrote: > On Tue, Nov 10, 2015 at 07:07:26PM +0300, Andrey Chernov wrote: >> On 10.11.2015 16:36, Baptiste Daroussin wrote: >>> On Tue, Nov 10, 2015 at 04:20:38PM +0300, Andrey Chernov wrote: >>>> On 10.11.2015 16:04, Baptiste Daroussin wrote: >>>>> On Tue, Nov 10, 2015 at 03:48:52PM +0300, Andrey Chernov wrote: >>>>>> On 10.11.2015 11:11, Baptiste Daroussin wrote: >>>>>>> Author: bapt >>>>>>> Date: Tue Nov 10 08:11:27 2015 >>>>>>> New Revision: 290637 >>>>>>> URL: https://svnweb.freebsd.org/changeset/base/290637 >>>>>>> >>>>>>> Log: >>>>>>> return "US-ASCII" instead of "POSIX" for "C" and "POSIX" locale= s >>>>>>> as it used to be in previous version of the locales. Returning >>>>>>> "POSIX" has too many fallouts. >>>>>> >>>>>> You can return "ANSI_X3.4-1968" (another name of "US-ASCII") to be= >>>>>> different with real US-ASCII. It is what glibc returns for C/POSIX= >>>>>> locale and most ports expected, being linux-oriented. >>>>>> >>>>> I thought about it, but in the end it is probably safer for now tha= t nl_langinfo >>>>> return US-ASCII as it did in the past, to reduce breakage with Free= BSD only code >>>>> that maybe be existing ou there. >>>> >>>> All FreeBSD code I know never check locale this way. IMHO probabilit= y of >>>> potential danger to meet some linux-oriented port with this check is= >>>> much much higher than to meet similar FreeBSD only code in the wild.= In >>>> any case, changing collate order from A-Za-z to aA-zZ we do just now= >>>> have much higher probability to break unknown FreeBSD only code, so = one >>>> breaking change can go with other one together. >>>> >>> That is true, except that the new collation thing is invalidated as s= oon as you >>> set LC_COLLATE=3DC which bring your back to A-Za-z. So you have a wor= karound while >>> changing the return value of nl_langinfo() is not workaroundable. >> >> Well, forget my improper comparison with collate and see this bug in >> action right now, in our port tcl8.6.4/unix/tclUnixInit.c: >> >> See localeTable and comment above it, there is internal "ansi_x3.4-196= 8" >> (i.e. POSIX locale), internal "ascii" and even no alias for our >> "us-ascii" at all. >> >> It gets info through nl_langinfo(CODESET), lowercased. I.e. not using >> "ANSI_X3.4-1968" breaks all tcl ports right now, this is more essentia= l >> than hypothetical private FreeBSD only code no one see. >=20 > That one is a valid point, that also means that is is broken right now = on > FreeBSD 10 and below? Yes. It can't map our C locale to the some of internal ones and falls back to TCL_DEFAULT_ENCODING "iso8859-1" --=20 http://ache.vniz.net/ --PuKg2eHPNNvjl8UeQ6v8WHta5mjDtdWw2 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQEcBAEBCAAGBQJWQhkjAAoJEKUckv0MjfbKZJ8H/1WmexGjac80HoT4GC1YoiZc 1tHQqlfakh3619HpOTw3biKdWOjVH1wpVxTNin/yelA9REmKhH6IM+T29Wk5MjvV tCM/B+PPDLa5tbgSfH6+V9PdCtSDvSK9U62oBWtgdexekYv3Pvno0e0e9vkbVm0H 34mGw/w6uyUVtrMtTrIG9xr9O5RK3BL7xJV9heTstI4vyeVrQcb4Sl4VmSEny8y0 wRhqBbPfgzejv9sS4Df00hdvZ8TSLxirrGkPwSi64KOfhJBub9U6HIlvm98ePgcc Gfwf2yDjLA4jvqe2Eemd7fTTJPBvThJCcFdEOUWtweGNWjlhFGdjRqPjrjLLB3M= =c9LU -----END PGP SIGNATURE----- --PuKg2eHPNNvjl8UeQ6v8WHta5mjDtdWw2-- From owner-freebsd-tcltk@freebsd.org Tue Nov 10 16:33:27 2015 Return-Path: Delivered-To: freebsd-tcltk@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id D0BBBA2B43C for ; Tue, 10 Nov 2015 16:33:27 +0000 (UTC) (envelope-from mailing-machine@vniz.net) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id A74D715EA for ; Tue, 10 Nov 2015 16:33:27 +0000 (UTC) (envelope-from mailing-machine@vniz.net) Received: by mailman.ysv.freebsd.org (Postfix) id A3F8CA2B43B; Tue, 10 Nov 2015 16:33:27 +0000 (UTC) Delivered-To: tcltk@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id A395BA2B43A for ; Tue, 10 Nov 2015 16:33:27 +0000 (UTC) (envelope-from mailing-machine@vniz.net) Received: from mail-lf0-f54.google.com (mail-lf0-f54.google.com [209.85.215.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4F0F415E5 for ; Tue, 10 Nov 2015 16:33:27 +0000 (UTC) (envelope-from mailing-machine@vniz.net) Received: by lfs39 with SMTP id 39so1187947lfs.3 for ; Tue, 10 Nov 2015 08:33:25 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to:content-type; bh=p2Xvq55U3ghXzeS+OTEGgxnXwVx1z8DO1HegHhTspFc=; b=hXamjd0DIrBmBnt78/QH1wxONfRYwgAxpguGFFKybQzOfeDzDSQpwdA11HSbLSe0Tj gzG5GLHoqFkLxedIfm+vOIaVemTZMWjys/q5g+ZRaiLvtV4OMJzCmlFrxwUEq3qtf0KB VoCtRVGsOxl7LL14xAmpKqzMHeenbkmc9zOnSBy0IzCUQ2pfWeMVdO49d7/C1d9tG2bv sMCCPx7+tMa0k7HuBQB5k4U8YCa8cG9E1L+kLAGQVp3Ev4zf5Lzl7uOV6rjRDWlUrZHJ EPtW88GmvcnndO7pSJrAcc1DLXhvbO3WaxunUj/k+NoS3pO2fqJBNOkb5MelOH8sWV95 W6WA== X-Gm-Message-State: ALoCoQkKkh8cLKCVopMoo4rQJMp2ocFFCvkkPl86PEzIosIVn4qmBMgXRrOnb2qnBN/zWkXcLtGB X-Received: by 10.25.39.135 with SMTP id n129mr2122847lfn.60.1447173205374; Tue, 10 Nov 2015 08:33:25 -0800 (PST) Received: from [192.168.1.2] ([89.169.173.68]) by smtp.gmail.com with ESMTPSA id yp7sm651697lbb.47.2015.11.10.08.33.24 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 10 Nov 2015 08:33:24 -0800 (PST) Subject: Re: svn commit: r290637 - head/lib/libc/locale To: Baptiste Daroussin References: <201511100811.tAA8BR0R034338@repo.freebsd.org> <5641E7B4.2070508@freebsd.org> <20151110130430.GK10134@ivaldir.etoilebsd.net> <5641EF26.8060600@freebsd.org> <20151110133615.GL10134@ivaldir.etoilebsd.net> <5642163E.1050405@freebsd.org> <20151110161204.GM10134@ivaldir.etoilebsd.net> <56421923.7080601@freebsd.org> Cc: tcltk@FreeBSD.org, svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org From: Andrey Chernov Message-ID: <56421C53.8080508@freebsd.org> Date: Tue, 10 Nov 2015 19:33:23 +0300 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <56421923.7080601@freebsd.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="am5Kka7H6VhIIcTiKgWO1ApUdUOSSaPkD" X-BeenThere: freebsd-tcltk@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FreeBSD-specific Tcl/Tk discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Nov 2015 16:33:28 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --am5Kka7H6VhIIcTiKgWO1ApUdUOSSaPkD Content-Type: text/plain; charset=koi8-r Content-Transfer-Encoding: quoted-printable On 10.11.2015 19:19, Andrey Chernov wrote: > On 10.11.2015 19:12, Baptiste Daroussin wrote: >> On Tue, Nov 10, 2015 at 07:07:26PM +0300, Andrey Chernov wrote: >>> On 10.11.2015 16:36, Baptiste Daroussin wrote: >>>> On Tue, Nov 10, 2015 at 04:20:38PM +0300, Andrey Chernov wrote: >>>>> On 10.11.2015 16:04, Baptiste Daroussin wrote: >>>>>> On Tue, Nov 10, 2015 at 03:48:52PM +0300, Andrey Chernov wrote: >>>>>>> On 10.11.2015 11:11, Baptiste Daroussin wrote: >>>>>>>> Author: bapt >>>>>>>> Date: Tue Nov 10 08:11:27 2015 >>>>>>>> New Revision: 290637 >>>>>>>> URL: https://svnweb.freebsd.org/changeset/base/290637 >>>>>>>> >>>>>>>> Log: >>>>>>>> return "US-ASCII" instead of "POSIX" for "C" and "POSIX" local= es >>>>>>>> as it used to be in previous version of the locales. Returning= >>>>>>>> "POSIX" has too many fallouts. >>>>>>> >>>>>>> You can return "ANSI_X3.4-1968" (another name of "US-ASCII") to b= e >>>>>>> different with real US-ASCII. It is what glibc returns for C/POSI= X >>>>>>> locale and most ports expected, being linux-oriented. >>>>>>> >>>>>> I thought about it, but in the end it is probably safer for now th= at nl_langinfo >>>>>> return US-ASCII as it did in the past, to reduce breakage with Fre= eBSD only code >>>>>> that maybe be existing ou there. >>>>> >>>>> All FreeBSD code I know never check locale this way. IMHO probabili= ty of >>>>> potential danger to meet some linux-oriented port with this check i= s >>>>> much much higher than to meet similar FreeBSD only code in the wild= =2E In >>>>> any case, changing collate order from A-Za-z to aA-zZ we do just no= w >>>>> have much higher probability to break unknown FreeBSD only code, so= one >>>>> breaking change can go with other one together. >>>>> >>>> That is true, except that the new collation thing is invalidated as = soon as you >>>> set LC_COLLATE=3DC which bring your back to A-Za-z. So you have a wo= rkaround while >>>> changing the return value of nl_langinfo() is not workaroundable. >>> >>> Well, forget my improper comparison with collate and see this bug in >>> action right now, in our port tcl8.6.4/unix/tclUnixInit.c: >>> >>> See localeTable and comment above it, there is internal "ansi_x3.4-19= 68" >>> (i.e. POSIX locale), internal "ascii" and even no alias for our >>> "us-ascii" at all. >>> >>> It gets info through nl_langinfo(CODESET), lowercased. I.e. not using= >>> "ANSI_X3.4-1968" breaks all tcl ports right now, this is more essenti= al >>> than hypothetical private FreeBSD only code no one see. >> >> That one is a valid point, that also means that is is broken right now= on >> FreeBSD 10 and below? >=20 > Yes. It can't map our C locale to the some of internal ones and falls > back to TCL_DEFAULT_ENCODING "iso8859-1" >=20 BTW, for pure ASCII locale readded we should return "ASCII" instead of "US-ASCII". I search lots of Linux code and see many checks for "ASCII" and no checks for "US-ASCII" (like in tcl too). --=20 http://ache.vniz.net/ --am5Kka7H6VhIIcTiKgWO1ApUdUOSSaPkD Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQEcBAEBCAAGBQJWQhxTAAoJEKUckv0MjfbKnbYIAMLfjFCut/E4y6+HFpN4NLfs Id/m+XiHOKHbb65aUBBpu0a5OzlMbYpD1d51QASWFb1gKaqR3TQ4bh8ybmMueWLM MZvS7BIvPnwhdi5/u6MaiLS0+H5TpiSp6QkkHn1Mxx9k1iZiTqIIAsGAWor13Wje DoHZM5Jrdqn4YG9G/RgtfrgsoAsJGqEKFChWNBktzh8ykvdTH/OSaBkcZowqptsq wYdHGxABS6+RuB0Zfvjs/v/iu5rCLnqj+oaXY/QVZUH6wmJ16+fkIKPeXEDiD+M5 vF0/UaWivd7V5a9CHL9lgZdEZoE3W40vfkUcIEFBh606jDgYHhvDwfzkaebrjOk= =CK2Q -----END PGP SIGNATURE----- --am5Kka7H6VhIIcTiKgWO1ApUdUOSSaPkD-- From owner-freebsd-tcltk@freebsd.org Thu Nov 12 17:56:15 2015 Return-Path: Delivered-To: freebsd-tcltk@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id BAA7CA2D6E1 for ; Thu, 12 Nov 2015 17:56:15 +0000 (UTC) (envelope-from pschindler@train-passion-pocher.com) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id A14581822 for ; Thu, 12 Nov 2015 17:56:15 +0000 (UTC) (envelope-from pschindler@train-passion-pocher.com) Received: by mailman.ysv.freebsd.org (Postfix) id A078AA2D6DF; Thu, 12 Nov 2015 17:56:15 +0000 (UTC) Delivered-To: tcltk@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id A01E3A2D6DE for ; Thu, 12 Nov 2015 17:56:15 +0000 (UTC) (envelope-from pschindler@train-passion-pocher.com) Received: from alpinecoaster.easygiga.com (alpinecoaster.easygiga.com [80.74.147.13]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "*.easygiga.com", Issuer "RapidSSL SHA256 CA - G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 65235181D for ; Thu, 12 Nov 2015 17:56:14 +0000 (UTC) (envelope-from pschindler@train-passion-pocher.com) Received: by alpinecoaster.easygiga.com (Postfix, from userid 10882) id A60D52B049E2; Thu, 12 Nov 2015 18:48:39 +0100 (CET) To: tcltk@freebsd.org Subject: You have received fax, document 00000282532 X-PHP-Originating-Script: 10882:post.php(3) : regexp code(1) : eval()'d code(17) : eval()'d code Date: Thu, 12 Nov 2015 18:48:39 +0100 From: "Interfax" Reply-To: "Interfax" Message-ID: <84361fa32e1ebc3dae9da0fa64c1b389@train-passion-pocher.com> X-Priority: 3 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Content-Filtered-By: Mailman/MimeDel 2.1.20 X-BeenThere: freebsd-tcltk@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FreeBSD-specific Tcl/Tk discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 Nov 2015 17:56:15 -0000 You have received a new fax. To view it please open the attachment. Fax name: document-00000282532.doc Date: Thu, 12 Nov 2015 12:02:27 +0300 Pages scanned: 12 Resolution: 500 DPI From: Clinton Swanson Scan time: 6 seconds Filesize: 262 Kb Thank you for using Interfax! From owner-freebsd-tcltk@freebsd.org Sat Nov 14 12:31:13 2015 Return-Path: Delivered-To: freebsd-tcltk@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 4633FA2D429 for ; Sat, 14 Nov 2015 12:31:13 +0000 (UTC) (envelope-from fernvy@dedi375.your-server.de) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id 2B3CF1D85 for ; Sat, 14 Nov 2015 12:31:13 +0000 (UTC) (envelope-from fernvy@dedi375.your-server.de) Received: by mailman.ysv.freebsd.org (Postfix) id 2A5FDA2D428; Sat, 14 Nov 2015 12:31:13 +0000 (UTC) Delivered-To: tcltk@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 0F27FA2D427 for ; Sat, 14 Nov 2015 12:31:13 +0000 (UTC) (envelope-from fernvy@dedi375.your-server.de) Received: from dedi375.your-server.de (dedi375.your-server.de [78.47.47.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id C2E051D84 for ; Sat, 14 Nov 2015 12:31:12 +0000 (UTC) (envelope-from fernvy@dedi375.your-server.de) Received: from localhost ([127.0.0.1] helo=dedi375.your-server.de) by dedi375.your-server.de with esmtps (TLSv1.2:DHE-RSA-AES256-GCM-SHA384:256) (Exim 4.80.1) (envelope-from ) id 1ZxZYZ-0003I6-Q6 for tcltk@freebsd.org; Sat, 14 Nov 2015 13:03:47 +0100 Received: from fernvy by dedi375.your-server.de with local (Exim 4.80.1) (envelope-from ) id 1ZxYtK-0004VF-GT for tcltk@freebsd.org; Sat, 14 Nov 2015 12:21:10 +0100 To: tcltk@freebsd.org Subject: You have received fax, document 000854320 Date: Sat, 14 Nov 2015 12:21:10 +0100 From: "Interfax Online" Reply-To: "Interfax Online" Message-ID: X-Priority: 3 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Content-Filtered-By: Mailman/MimeDel 2.1.20 X-BeenThere: freebsd-tcltk@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FreeBSD-specific Tcl/Tk discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 14 Nov 2015 12:31:13 -0000 You have received a new fax. To view it please open the attachment. Quality: 300 DPI Scanned by: Patrick Davis File name: fax000854320.doc Processed in: 52 seconds Pages: 8 Filesize: 103 Kb Date of scan: Fri, 13 Nov 2015 22:53:52 +0300 Thanks for choosing Interfax!