From owner-freebsd-testing@FreeBSD.ORG Sun Mar 22 21:02:59 2015 Return-Path: Delivered-To: freebsd-testing@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 39361B3; Sun, 22 Mar 2015 21:02:59 +0000 (UTC) Received: from mail-la0-x233.google.com (mail-la0-x233.google.com [IPv6:2a00:1450:4010:c03::233]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id C4024798; Sun, 22 Mar 2015 21:02:58 +0000 (UTC) Received: by lagg8 with SMTP id g8so120704244lag.1; Sun, 22 Mar 2015 14:02:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:content-type; bh=QfmWkRN5Fl2Wf9XElIglde6sdrnsLBq2kJPTO7FY43k=; b=fH86xQF3n+Vbcv9maDHUHMGPQA0rd4gnnx9+vTRTs9Ud/D9gKSlZlih9ovUDbbW6Np QsFthcknYIOE2aHLIhzVGAX67/GFuRQMaMgvzBmzY85dG7FN0NHTd6yMgTuTvBbeLJZL CmEAP5vY+NpF1YfVmnnFOsPc8xMm7eC6ikIaSBp/1i6Z0BeJFiuUhz67qCqpUjgUZwOP jlxuHCuzZfcarQeSWSp5nxGeb0xsFBaNgwSbbfRQtScFpttYDq68Z9loNqbNoXgCWTSw C/4u0SIFCj0qZPGbM2ZJEx1aoDjRZ+sK8+tkSPJ/GYIPBAGaWWu4Btk9YJXoWc2RCwCE 1JMw== MIME-Version: 1.0 X-Received: by 10.112.223.7 with SMTP id qq7mr81441963lbc.81.1427058176678; Sun, 22 Mar 2015 14:02:56 -0700 (PDT) Sender: crodr001@gmail.com Received: by 10.112.82.164 with HTTP; Sun, 22 Mar 2015 14:02:56 -0700 (PDT) In-Reply-To: <799490341.14.1427048792932.JavaMail.jenkins@jenkins-9.freebsd.org> References: <1669399171.13.1427029129760.JavaMail.jenkins@jenkins-9.freebsd.org> <799490341.14.1427048792932.JavaMail.jenkins@jenkins-9.freebsd.org> Date: Sun, 22 Mar 2015 14:02:56 -0700 X-Google-Sender-Auth: tgE9gRRCr953zeFtkM5q5VYXZh0 Message-ID: Subject: Re: Jenkins build is still unstable: FreeBSD_HEAD-tests2 #867 From: Craig Rodrigues To: "jenkins-admin@freebsd.org" , freebsd-current Current , "freebsd-testing@freebsd.org" , freebsd-toolchain@freebsd.org Content-Type: text/plain; charset=ISO-8859-1 X-Content-Filtered-By: Mailman/MimeDel 2.1.18-1 X-BeenThere: freebsd-testing@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Testing on FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 22 Mar 2015 21:02:59 -0000 On Sun, Mar 22, 2015 at 11:26 AM, wrote: > See > Can someone with toolchain expertise look at this? After the clang 3.6.1 import, /bin/expr behaves differently. With clang 3.5.0: # expr 4611686018427387904 + 4611686018427387904 expr: overflow With clang 3.6.1: # expr 4611686018427387904 + 4611686018427387904 -9223372036854775808 -- Craig From owner-freebsd-testing@FreeBSD.ORG Sun Mar 22 21:03:57 2015 Return-Path: Delivered-To: freebsd-testing@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id B5A401F2; Sun, 22 Mar 2015 21:03:57 +0000 (UTC) Received: from mail-pa0-x22a.google.com (mail-pa0-x22a.google.com [IPv6:2607:f8b0:400e:c03::22a]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 76CA67A6; Sun, 22 Mar 2015 21:03:57 +0000 (UTC) Received: by pabxg6 with SMTP id xg6so156998519pab.0; Sun, 22 Mar 2015 14:03:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=content-type:mime-version:subject:from:in-reply-to:date:cc :message-id:references:to; bh=GaN6pm5V1eHaodeICvzChrHs/JYk2irjzDvVngnf+IY=; b=Bc2+uICEiefB+7C9sLo5rLLCmMAQESJ020fqqKpGY/jOBwgs2CjIhGEQdAYD2eFXcS pfYiF7uI+zYoMDm4xCG3qUqVPn/ymYCJDQzPRRA/uLBCQT41Sr7Rs0fwokdiOlYsv1iK n5uHA9MINjI5qXmW+NW3vjh0yNmuZveq1qUUEITZZ3rhRkqiWaNOBonizI7770ZDRpsx /WSwZtuJo90OF4jAiKQ7HS5wuLP8tSdtUpmoxRbV5CIVFnT/Q8dj05EV2YrokF0d/Uq1 r/6XuVMgXyQWEOgtbBzFRxIOEoHStFEa1liRyrKfr3ETf+OSF2jFrSD2vwvR0BidjIVD qCLg== X-Received: by 10.68.143.227 with SMTP id sh3mr14952002pbb.166.1427058236996; Sun, 22 Mar 2015 14:03:56 -0700 (PDT) Received: from ?IPv6:2601:8:ab80:7d6:7544:258:ce3d:185a? ([2601:8:ab80:7d6:7544:258:ce3d:185a]) by mx.google.com with ESMTPSA id lr1sm14825850pab.39.2015.03.22.14.03.55 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Sun, 22 Mar 2015 14:03:56 -0700 (PDT) Content-Type: multipart/signed; boundary="Apple-Mail=_901EC205-2D1E-4777-B4AD-2C7189EA400D"; protocol="application/pgp-signature"; micalg=pgp-sha512 Mime-Version: 1.0 (Mac OS X Mail 7.3 \(1878.6\)) Subject: Re: Jenkins build is still unstable: FreeBSD_HEAD-tests2 #867 From: Garrett Cooper In-Reply-To: Date: Sun, 22 Mar 2015 14:03:53 -0700 Message-Id: <97AAE9BA-C748-4E8E-8DAF-20C145BCC0CD@gmail.com> References: <1669399171.13.1427029129760.JavaMail.jenkins@jenkins-9.freebsd.org> <799490341.14.1427048792932.JavaMail.jenkins@jenkins-9.freebsd.org> To: Craig Rodrigues X-Mailer: Apple Mail (2.1878.6) Cc: "freebsd-testing@freebsd.org" , freebsd-current Current , "jenkins-admin@freebsd.org" , freebsd-toolchain@freebsd.org X-BeenThere: freebsd-testing@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Testing on FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 22 Mar 2015 21:03:57 -0000 --Apple-Mail=_901EC205-2D1E-4777-B4AD-2C7189EA400D Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=us-ascii On Mar 22, 2015, at 14:02, Craig Rodrigues wrote: > On Sun, Mar 22, 2015 at 11:26 AM, wrote: > >> See >> > > Can someone with toolchain expertise look at this? > After the clang 3.6.1 import, /bin/expr behaves differently. > > With clang 3.5.0: > > # expr 4611686018427387904 + 4611686018427387904 > expr: overflow > > With clang 3.6.1: > > # expr 4611686018427387904 + 4611686018427387904 > -9223372036854775808 I suspect -fwrapv is at fault, but I need to do some digging first.. Thanks! --Apple-Mail=_901EC205-2D1E-4777-B4AD-2C7189EA400D Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQEcBAEBCgAGBQJVDy46AAoJEMZr5QU6S73euwwH/ROWznnMtty1kQl1kyReLqtV 7jdtDECAVrG23TyO2rcxqU1c61NHTYo5RztwKTQhexDHI58xcrnfWrXfrafDVXAy FjrD2MgKL4T8wtrFwPwV0aKPsDFEYBOgWGzmfsWNdTTGmUYyIZXCZ3HBgi5YrSXR kAYzXb3j+k1B6095njceqoRkFlrlkWK+2ZJKg+2M8GHZrdukLQSGLPEuXamxkqSQ RjoOb9H5XUt63c/uzRvOKmilomhlE0bdNbT47UDF1aeT1HNjpeW5SHS8I9IOM9vo xhDhKzGyPmoXD7rkZOjNN3MB7P/9G0YgnRMIsp2ElweNnKSg94yiFWMXC4Konm8= =eLQE -----END PGP SIGNATURE----- --Apple-Mail=_901EC205-2D1E-4777-B4AD-2C7189EA400D-- From owner-freebsd-testing@FreeBSD.ORG Sun Mar 22 21:23:51 2015 Return-Path: Delivered-To: freebsd-testing@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 933AAC75; Sun, 22 Mar 2015 21:23:51 +0000 (UTC) Received: from tensor.andric.com (tensor.andric.com [87.251.56.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "tensor.andric.com", Issuer "COMODO RSA Domain Validation Secure Server CA" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46F36983; Sun, 22 Mar 2015 21:23:51 +0000 (UTC) Received: from [IPv6:2001:7b8:3a7::b11b:b36a:c2e8:f12e] (unknown [IPv6:2001:7b8:3a7:0:b11b:b36a:c2e8:f12e]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by tensor.andric.com (Postfix) with ESMTPSA id 76CEB5C4C; Sun, 22 Mar 2015 22:23:41 +0100 (CET) Subject: Re: Jenkins build is still unstable: FreeBSD_HEAD-tests2 #867 Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2070.6\)) Content-Type: multipart/signed; boundary="Apple-Mail=_6462D90B-46B0-43F8-9FF1-609FA2EB4A90"; protocol="application/pgp-signature"; micalg=pgp-sha1 X-Pgp-Agent: GPGMail 2.5b6 From: Dimitry Andric In-Reply-To: Date: Sun, 22 Mar 2015 22:23:30 +0100 Message-Id: References: <1669399171.13.1427029129760.JavaMail.jenkins@jenkins-9.freebsd.org> <799490341.14.1427048792932.JavaMail.jenkins@jenkins-9.freebsd.org> To: Craig Rodrigues X-Mailer: Apple Mail (2.2070.6) Cc: "freebsd-testing@freebsd.org" , freebsd-current Current , "jenkins-admin@freebsd.org" , freebsd-toolchain@freebsd.org X-BeenThere: freebsd-testing@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Testing on FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 22 Mar 2015 21:23:51 -0000 --Apple-Mail=_6462D90B-46B0-43F8-9FF1-609FA2EB4A90 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=us-ascii On 22 Mar 2015, at 22:02, Craig Rodrigues wrote: > > On Sun, Mar 22, 2015 at 11:26 AM, wrote: > >> See >> > > Can someone with toolchain expertise look at this? > After the clang 3.6.1 import, /bin/expr behaves differently. > > With clang 3.5.0: > > # expr 4611686018427387904 + 4611686018427387904 > expr: overflow > > With clang 3.6.1: > > # expr 4611686018427387904 + 4611686018427387904 > -9223372036854775808 It works fine for me: $ /usr/obj/usr/src/bin/expr/expr 4611686018427387904 + 4611686018427387904 expr: overflow Are you using any special compilation flags? That said, having taken a quick look at expr.y, it does seem to rely on signed integer wrapping. -Dimitry --Apple-Mail=_6462D90B-46B0-43F8-9FF1-609FA2EB4A90 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0.27 iEYEARECAAYFAlUPMtwACgkQsF6jCi4glqN6HgCg7DTYA/komyK13OWbbDYo4nxx QaUAoKvbdLwLKUDPGRpXU6EA9RdhPofH =WhMV -----END PGP SIGNATURE----- --Apple-Mail=_6462D90B-46B0-43F8-9FF1-609FA2EB4A90-- From owner-freebsd-testing@FreeBSD.ORG Sun Mar 22 21:29:47 2015 Return-Path: Delivered-To: freebsd-testing@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 158C1E9C; Sun, 22 Mar 2015 21:29:47 +0000 (UTC) Received: from tensor.andric.com (tensor.andric.com [87.251.56.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "tensor.andric.com", Issuer "COMODO RSA Domain Validation Secure Server CA" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id BE03F9C2; Sun, 22 Mar 2015 21:29:46 +0000 (UTC) Received: from [IPv6:2001:7b8:3a7::b11b:b36a:c2e8:f12e] (unknown [IPv6:2001:7b8:3a7:0:b11b:b36a:c2e8:f12e]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by tensor.andric.com (Postfix) with ESMTPSA id C15E35C4C; Sun, 22 Mar 2015 22:29:44 +0100 (CET) Subject: Re: Jenkins build is still unstable: FreeBSD_HEAD-tests2 #867 Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2070.6\)) Content-Type: multipart/signed; boundary="Apple-Mail=_1B247339-B440-44BF-81CB-2C53DA7C0EB4"; protocol="application/pgp-signature"; micalg=pgp-sha1 X-Pgp-Agent: GPGMail 2.5b6 From: Dimitry Andric In-Reply-To: Date: Sun, 22 Mar 2015 22:29:43 +0100 Message-Id: <494AEF4B-0AF8-449A-9B41-9AC4F4552AF0@FreeBSD.org> References: <1669399171.13.1427029129760.JavaMail.jenkins@jenkins-9.freebsd.org> <799490341.14.1427048792932.JavaMail.jenkins@jenkins-9.freebsd.org> To: Craig Rodrigues X-Mailer: Apple Mail (2.2070.6) Cc: "freebsd-testing@freebsd.org" , freebsd-current Current , "jenkins-admin@freebsd.org" , freebsd-toolchain@freebsd.org X-BeenThere: freebsd-testing@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Testing on FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 22 Mar 2015 21:29:47 -0000 --Apple-Mail=_1B247339-B440-44BF-81CB-2C53DA7C0EB4 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii On 22 Mar 2015, at 22:23, Dimitry Andric wrote: >=20 > On 22 Mar 2015, at 22:02, Craig Rodrigues wrote: >>=20 >> On Sun, Mar 22, 2015 at 11:26 AM, wrote: >>=20 >>> See >>>=20 >>=20 >> Can someone with toolchain expertise look at this? >> After the clang 3.6.1 import, /bin/expr behaves differently. >>=20 >> With clang 3.5.0: >>=20 >> # expr 4611686018427387904 + 4611686018427387904 >> expr: overflow >>=20 >> With clang 3.6.1: >>=20 >> # expr 4611686018427387904 + 4611686018427387904 >> -9223372036854775808 >=20 > It works fine for me: >=20 > $ /usr/obj/usr/src/bin/expr/expr 4611686018427387904 + = 4611686018427387904 > expr: overflow Ah right, that was on i386, on amd64 it does result in -2^63. It is = indeed caused by reliance on signed integer wrapping. This diff should fix it, without rewriting the utility: Index: bin/expr/Makefile =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D --- bin/expr/Makefile (revision 280156) +++ bin/expr/Makefile (working copy) @@ -6,6 +6,9 @@ PROG=3D expr SRCS=3D expr.y YFLAGS=3D +# expr relies on signed integer wrapping +CFLAGS+=3D -fwrapv + NO_WMISSING_VARIABLE_DECLARATIONS=3D .if ${MK_TESTS} !=3D "no" -Dimitry --Apple-Mail=_1B247339-B440-44BF-81CB-2C53DA7C0EB4 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0.27 iEYEARECAAYFAlUPNEcACgkQsF6jCi4glqP5HwCeKYgKWHDn47Xr4qJQROpKmJo5 jxYAoO+QWs7JjiiTgzGMaXmRrepUcuHD =pRHL -----END PGP SIGNATURE----- --Apple-Mail=_1B247339-B440-44BF-81CB-2C53DA7C0EB4-- From owner-freebsd-testing@FreeBSD.ORG Sun Mar 22 21:33:01 2015 Return-Path: Delivered-To: freebsd-testing@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id E5EE0E3; Sun, 22 Mar 2015 21:33:01 +0000 (UTC) Received: from mail-lb0-x231.google.com (mail-lb0-x231.google.com [IPv6:2a00:1450:4010:c04::231]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 5FBF6A72; Sun, 22 Mar 2015 21:33:01 +0000 (UTC) Received: by lbbrr9 with SMTP id rr9so42186406lbb.0; Sun, 22 Mar 2015 14:32:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=Gx3r0ha82yDviFrhVbvVDE+vg24lBDCrOmqdvrxIflw=; b=mTs5DGfm1LNQCkdnCH+QwTlZnOMfENUsdwKDJcCudhT1yeqHBsqJtAiVnO7JvanEal BMzxsvS4N4NArnTvS02Ursk8mEC0CrD97GwJcbvyS77Wln+Mfdc7VLqVLAA3wOd4myBy +CRyQGOR+OigRpyoIWblAvQEPjB9y84qP5VWGGI5aTLiLy9a01TD6dKzHI2Avjq72bew Qky4onzZ0Bv/buNvtKZ9ugVKude+twVSmTN92XnyXvNynpieO+uEci153gRYJcdZ9wMm lFvNd0w15S0t5SQ6MD9EKOLvx2QPQ1eSutijkDui43CSR4M32xK+SfqeR6ypTsi3SzCs 5FtA== MIME-Version: 1.0 X-Received: by 10.152.3.42 with SMTP id 10mr80677543laz.84.1427059979554; Sun, 22 Mar 2015 14:32:59 -0700 (PDT) Sender: crodr001@gmail.com Received: by 10.112.82.164 with HTTP; Sun, 22 Mar 2015 14:32:59 -0700 (PDT) In-Reply-To: <494AEF4B-0AF8-449A-9B41-9AC4F4552AF0@FreeBSD.org> References: <1669399171.13.1427029129760.JavaMail.jenkins@jenkins-9.freebsd.org> <799490341.14.1427048792932.JavaMail.jenkins@jenkins-9.freebsd.org> <494AEF4B-0AF8-449A-9B41-9AC4F4552AF0@FreeBSD.org> Date: Sun, 22 Mar 2015 14:32:59 -0700 X-Google-Sender-Auth: 64PjJ_U7jWUfawIxHSroAkBtAPA Message-ID: Subject: Re: Jenkins build is still unstable: FreeBSD_HEAD-tests2 #867 From: Craig Rodrigues To: Dimitry Andric Content-Type: text/plain; charset=ISO-8859-1 X-Content-Filtered-By: Mailman/MimeDel 2.1.18-1 Cc: "freebsd-testing@freebsd.org" , freebsd-current Current , "jenkins-admin@freebsd.org" , freebsd-toolchain@freebsd.org X-BeenThere: freebsd-testing@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Testing on FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 22 Mar 2015 21:33:02 -0000 On Sun, Mar 22, 2015 at 2:29 PM, Dimitry Andric wrote: > > Ah right, that was on i386, on amd64 it does result in -2^63. It is > indeed caused by reliance on signed integer wrapping. > > This diff should fix it, without rewriting the utility: > > Index: bin/expr/Makefile > =================================================================== > --- bin/expr/Makefile (revision 280156) > +++ bin/expr/Makefile (working copy) > @@ -6,6 +6,9 @@ PROG= expr > SRCS= expr.y > YFLAGS= > > +# expr relies on signed integer wrapping > +CFLAGS+= -fwrapv > + > NO_WMISSING_VARIABLE_DECLARATIONS= > > .if ${MK_TESTS} != "no" > Well, another alternative is to patch expr.y: Index: expr.y =================================================================== --- expr.y (revision 280353) +++ expr.y (working copy) @@ -393,7 +393,7 @@ } void -assert_plus(intmax_t a, intmax_t b, intmax_t r) +assert_plus(intmax_t a, intmax_t b, volatile intmax_t r) { /* * sum of two positive numbers must be positive, @@ -420,7 +420,7 @@ } void -assert_minus(intmax_t a, intmax_t b, intmax_t r) +assert_minus(intmax_t a, intmax_t b, volatile intmax_t r) { /* special case subtraction of INTMAX_MIN */ if (b == INTMAX_MIN && a < 0) There were already some patches previously done to this file to add "volatile", so maybe this would be OK to do. What do you think? -- Craig From owner-freebsd-testing@FreeBSD.ORG Sun Mar 22 21:36:18 2015 Return-Path: Delivered-To: freebsd-testing@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 1DC70480; Sun, 22 Mar 2015 21:36:18 +0000 (UTC) Received: from tensor.andric.com (tensor.andric.com [87.251.56.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "tensor.andric.com", Issuer "COMODO RSA Domain Validation Secure Server CA" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 9B514AB7; Sun, 22 Mar 2015 21:36:17 +0000 (UTC) Received: from [IPv6:2001:7b8:3a7::b11b:b36a:c2e8:f12e] (unknown [IPv6:2001:7b8:3a7:0:b11b:b36a:c2e8:f12e]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by tensor.andric.com (Postfix) with ESMTPSA id 0CD355C4C; Sun, 22 Mar 2015 22:36:15 +0100 (CET) Subject: Re: Jenkins build is still unstable: FreeBSD_HEAD-tests2 #867 Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2070.6\)) Content-Type: multipart/signed; boundary="Apple-Mail=_C4B1A8DE-DE41-4ED5-BDEB-8B71E05450F7"; protocol="application/pgp-signature"; micalg=pgp-sha1 X-Pgp-Agent: GPGMail 2.5b6 From: Dimitry Andric In-Reply-To: Date: Sun, 22 Mar 2015 22:36:14 +0100 Message-Id: <864EB4DB-2DF7-4294-9498-95E54E6B49CC@FreeBSD.org> References: <1669399171.13.1427029129760.JavaMail.jenkins@jenkins-9.freebsd.org> <799490341.14.1427048792932.JavaMail.jenkins@jenkins-9.freebsd.org> <494AEF4B-0AF8-449A-9B41-9AC4F4552AF0@FreeBSD.org> To: Craig Rodrigues X-Mailer: Apple Mail (2.2070.6) Cc: "freebsd-testing@freebsd.org" , freebsd-current Current , "jenkins-admin@freebsd.org" , freebsd-toolchain@freebsd.org X-BeenThere: freebsd-testing@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Testing on FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 22 Mar 2015 21:36:18 -0000 --Apple-Mail=_C4B1A8DE-DE41-4ED5-BDEB-8B71E05450F7 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=iso-8859-1 On 22 Mar 2015, at 22:32, Craig Rodrigues wrote: >=20 > On Sun, Mar 22, 2015 at 2:29 PM, Dimitry Andric = wrote: >=20 > Ah right, that was on i386, on amd64 it does result in -2^63. It is = indeed caused by reliance on signed integer wrapping. >=20 > This diff should fix it, without rewriting the utility: >=20 > Index: bin/expr/Makefile > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > --- bin/expr/Makefile (revision 280156) > +++ bin/expr/Makefile (working copy) > @@ -6,6 +6,9 @@ PROG=3D expr > SRCS=3D expr.y > YFLAGS=3D >=20 > +# expr relies on signed integer wrapping > +CFLAGS+=3D -fwrapv > + > NO_WMISSING_VARIABLE_DECLARATIONS=3D >=20 > .if ${MK_TESTS} !=3D "no" >=20 >=20 > Well, another alternative is to patch expr.y: >=20 > Index: expr.y > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > --- expr.y (revision 280353) > +++ expr.y (working copy) > @@ -393,7 +393,7 @@ > } >=20 > void > -assert_plus(intmax_t a, intmax_t b, intmax_t r) > +assert_plus(intmax_t a, intmax_t b, volatile intmax_t r) > { > /* > * sum of two positive numbers must be positive, > @@ -420,7 +420,7 @@ > } >=20 > void > -assert_minus(intmax_t a, intmax_t b, intmax_t r) > +assert_minus(intmax_t a, intmax_t b, volatile intmax_t r) > { > /* special case subtraction of INTMAX_MIN */ > if (b =3D=3D INTMAX_MIN && a < 0) >=20 >=20 > There were already some patches previously done to this > file to add "volatile", so maybe this would be OK to do. >=20 > What do you think? Volatile is not the solution, it is completely orthogonal. The correct way would be to use unsigned integers, for which wrapping is defined, then convert those back and forth when presenting the results to the user. -Dimitry --Apple-Mail=_C4B1A8DE-DE41-4ED5-BDEB-8B71E05450F7 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0.27 iEYEARECAAYFAlUPNc4ACgkQsF6jCi4glqO/9wCfbYOH487q9/Xe+cpNxEuEGkNU G78An3RQijg4XLH7Ca2YhJS7gyMCgzIQ =rYXe -----END PGP SIGNATURE----- --Apple-Mail=_C4B1A8DE-DE41-4ED5-BDEB-8B71E05450F7-- From owner-freebsd-testing@FreeBSD.ORG Sun Mar 22 21:37:31 2015 Return-Path: Delivered-To: freebsd-testing@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id AFE216EF; Sun, 22 Mar 2015 21:37:31 +0000 (UTC) Received: from mail-pa0-x229.google.com (mail-pa0-x229.google.com [IPv6:2607:f8b0:400e:c03::229]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 6B550AC3; Sun, 22 Mar 2015 21:37:31 +0000 (UTC) Received: by pabxg6 with SMTP id xg6so157560019pab.0; Sun, 22 Mar 2015 14:37:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=content-type:mime-version:subject:from:in-reply-to:date:cc :message-id:references:to; bh=AnCijlR/ZSj7VqR8tlOleZ1dNaysWJNmoyDTkbs+5cI=; b=NERHttlR76bRFiuJFjTcHV6R+0BiriEfYt4dM948+HHxX13EFVtp0kHC9swf2Zp6Jn fB+nTH+x34D4b29o8zPo5AvDPOwKsmS4ECiXo1WFAFFMoSwxMYSneZpDkoYpkerW62qY iTmKdlbv9v/zv2kBprXoCPeSumnD0GO65vEtHblxruxxS1y/tcO5BgnqHb2HhQiZWvbD dulzRnegFHsrODOyDr35VWo1sE0RHAp6JGuZCCcg9PozOxUcqxLUGSW+oE4uFCF9v8VY kTdocJ/aQb90D8ffFWelio6fcKafIvy6686MC7saWczi2pksLgtKO7K3k/IOBPyN6NJ1 wUtg== X-Received: by 10.66.154.17 with SMTP id vk17mr205034907pab.5.1427060251000; Sun, 22 Mar 2015 14:37:31 -0700 (PDT) Received: from ?IPv6:2601:8:ab80:7d6:7544:258:ce3d:185a? ([2601:8:ab80:7d6:7544:258:ce3d:185a]) by mx.google.com with ESMTPSA id jh2sm5157475pbb.25.2015.03.22.14.37.29 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Sun, 22 Mar 2015 14:37:30 -0700 (PDT) Content-Type: multipart/signed; boundary="Apple-Mail=_304F0F11-EC28-4252-9E60-0A9BD13758EF"; protocol="application/pgp-signature"; micalg=pgp-sha512 Mime-Version: 1.0 (Mac OS X Mail 7.3 \(1878.6\)) Subject: Re: Jenkins build is still unstable: FreeBSD_HEAD-tests2 #867 From: Garrett Cooper In-Reply-To: <864EB4DB-2DF7-4294-9498-95E54E6B49CC@FreeBSD.org> Date: Sun, 22 Mar 2015 14:37:28 -0700 Message-Id: <3E288A39-D7DB-458A-B425-8B449DD57E35@gmail.com> References: <1669399171.13.1427029129760.JavaMail.jenkins@jenkins-9.freebsd.org> <799490341.14.1427048792932.JavaMail.jenkins@jenkins-9.freebsd.org> <494AEF4B-0AF8-449A-9B41-9AC4F4552AF0@FreeBSD.org> <864EB4DB-2DF7-4294-9498-95E54E6B49CC@FreeBSD.org> To: Dimitry Andric X-Mailer: Apple Mail (2.1878.6) Cc: "freebsd-testing@freebsd.org" , freebsd-current Current , "jenkins-admin@freebsd.org" , freebsd-toolchain@freebsd.org X-BeenThere: freebsd-testing@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Testing on FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 22 Mar 2015 21:37:31 -0000 --Apple-Mail=_304F0F11-EC28-4252-9E60-0A9BD13758EF Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=windows-1252 On Mar 22, 2015, at 14:36, Dimitry Andric wrote: > On 22 Mar 2015, at 22:32, Craig Rodrigues wrote: >>=20 >> On Sun, Mar 22, 2015 at 2:29 PM, Dimitry Andric = wrote: >>=20 >> Ah right, that was on i386, on amd64 it does result in -2^63. It is = indeed caused by reliance on signed integer wrapping. >>=20 >> This diff should fix it, without rewriting the utility: >>=20 >> Index: bin/expr/Makefile >> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D >> --- bin/expr/Makefile (revision 280156) >> +++ bin/expr/Makefile (working copy) >> @@ -6,6 +6,9 @@ PROG=3D expr >> SRCS=3D expr.y >> YFLAGS=3D >>=20 >> +# expr relies on signed integer wrapping >> +CFLAGS+=3D -fwrapv >> + >> NO_WMISSING_VARIABLE_DECLARATIONS=3D >>=20 >> .if ${MK_TESTS} !=3D "no" >>=20 >>=20 >> Well, another alternative is to patch expr.y: >>=20 >> Index: expr.y >> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D >> --- expr.y (revision 280353) >> +++ expr.y (working copy) >> @@ -393,7 +393,7 @@ >> } >>=20 >> void >> -assert_plus(intmax_t a, intmax_t b, intmax_t r) >> +assert_plus(intmax_t a, intmax_t b, volatile intmax_t r) >> { >> /* >> * sum of two positive numbers must be positive, >> @@ -420,7 +420,7 @@ >> } >>=20 >> void >> -assert_minus(intmax_t a, intmax_t b, intmax_t r) >> +assert_minus(intmax_t a, intmax_t b, volatile intmax_t r) >> { >> /* special case subtraction of INTMAX_MIN */ >> if (b =3D=3D INTMAX_MIN && a < 0) >>=20 >>=20 >> There were already some patches previously done to this >> file to add "volatile", so maybe this would be OK to do. >>=20 >> What do you think? >=20 > Volatile is not the solution, it is completely orthogonal. The = correct > way would be to use unsigned integers, for which wrapping is defined, > then convert those back and forth when presenting the results to the > user. Before doing that =97 what changed in the past week that changed the = behavior of expr? Thanks! --Apple-Mail=_304F0F11-EC28-4252-9E60-0A9BD13758EF Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQEcBAEBCgAGBQJVDzYYAAoJEMZr5QU6S73eHW0H/RWRCspXwSZo7vbqsy6iRuOU 3Sr+rFduyTFuY1/TTnbLZYEUG/RmzS0hHDzw78r9XGh/5omjsiVXCIbV0GPIP07r Xy3T2qAuSdTi140mwcJMDCXpQQPXhtrIw4y1ZkrMJEe1+fVuOldRAPJJfiI5hJMC SnKLvAxhQ/KdQVTkB/DUN9XvZ2TeWRlinChGNA4Ca+5UoPZlHYI+cQWcybsSyQEA Z3Fho4XY3Tt8O6SUKramxaE638WgTD+0TWTxcz2kCo+hSdJnZ0T5cF9xQNb6DwR0 XzMoWsnOJVRgB7N3TDb5FhdBgJLYX8rwkwL0/ByAmoyc9r8oGlMlT8XtF/gxHNw= =DmrI -----END PGP SIGNATURE----- --Apple-Mail=_304F0F11-EC28-4252-9E60-0A9BD13758EF-- From owner-freebsd-testing@FreeBSD.ORG Sun Mar 22 22:01:27 2015 Return-Path: Delivered-To: freebsd-testing@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 74909E09; Sun, 22 Mar 2015 22:01:27 +0000 (UTC) Received: from mail-la0-x234.google.com (mail-la0-x234.google.com [IPv6:2a00:1450:4010:c03::234]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id E0409D8E; Sun, 22 Mar 2015 22:01:26 +0000 (UTC) Received: by lagg8 with SMTP id g8so121216876lag.1; Sun, 22 Mar 2015 15:01:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=iL70EmHePH1o/E5SGc4YhyCEgj/7f3plGUrw3c0qOFk=; b=CUvBRllErHmA0TfSDH2IOgqajuzqjlfPvQYalo6cNNDR5+ZzcRKcmqSrJD6F2nRIGf Zx/6W4CH32SFhCxy6I5z+SL8b1OE3qggu9VUdewJnVQpOITYFipoEjV3p0reiHhnpsy7 lsRro7+zCUN7Ib+r07w8PlyYNcaMonF9zYRTmp8sQ+6FHTVQMaB2/tsRRslKtK4XtGTl PyDbpRVL8Rb2alTRccClnti2Y6ZCm/hnq6YSm2bvUwGp7hdgzlDar8Li1rEV9L6mY00C wdr2nkCnOvVs9aA+tcjYt5BO547twbo4atvci3MTjsUlZFeTyg/HAv6uf1src84MybhD giFQ== MIME-Version: 1.0 X-Received: by 10.152.3.42 with SMTP id 10mr80747513laz.84.1427061685096; Sun, 22 Mar 2015 15:01:25 -0700 (PDT) Sender: crodr001@gmail.com Received: by 10.112.82.164 with HTTP; Sun, 22 Mar 2015 15:01:25 -0700 (PDT) In-Reply-To: <864EB4DB-2DF7-4294-9498-95E54E6B49CC@FreeBSD.org> References: <1669399171.13.1427029129760.JavaMail.jenkins@jenkins-9.freebsd.org> <799490341.14.1427048792932.JavaMail.jenkins@jenkins-9.freebsd.org> <494AEF4B-0AF8-449A-9B41-9AC4F4552AF0@FreeBSD.org> <864EB4DB-2DF7-4294-9498-95E54E6B49CC@FreeBSD.org> Date: Sun, 22 Mar 2015 15:01:25 -0700 X-Google-Sender-Auth: ZYeQeFL3AW0rAaA67H01MfnpFQo Message-ID: Subject: Re: Jenkins build is still unstable: FreeBSD_HEAD-tests2 #867 From: Craig Rodrigues To: Dimitry Andric Content-Type: text/plain; charset=ISO-8859-1 X-Content-Filtered-By: Mailman/MimeDel 2.1.18-1 Cc: "freebsd-testing@freebsd.org" , freebsd-current Current , "jenkins-admin@freebsd.org" , freebsd-toolchain@freebsd.org X-BeenThere: freebsd-testing@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Testing on FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 22 Mar 2015 22:01:27 -0000 On Sun, Mar 22, 2015 at 2:36 PM, Dimitry Andric wrote: > On 22 Mar 2015, at 22:32, Craig Rodrigues wrote: > > > > On Sun, Mar 22, 2015 at 2:29 PM, Dimitry Andric wrote: > > > > Ah right, that was on i386, on amd64 it does result in -2^63. It is > indeed caused by reliance on signed integer wrapping. > > > > This diff should fix it, without rewriting the utility: > > > > Index: bin/expr/Makefile > > =================================================================== > > --- bin/expr/Makefile (revision 280156) > > +++ bin/expr/Makefile (working copy) > > @@ -6,6 +6,9 @@ PROG= expr > > SRCS= expr.y > > YFLAGS= > > > > +# expr relies on signed integer wrapping > > +CFLAGS+= -fwrapv > > + > > NO_WMISSING_VARIABLE_DECLARATIONS= > > > > .if ${MK_TESTS} != "no" > > > > > > Well, another alternative is to patch expr.y: > > > > Index: expr.y > > =================================================================== > > --- expr.y (revision 280353) > > +++ expr.y (working copy) > > @@ -393,7 +393,7 @@ > > } > > > > void > > -assert_plus(intmax_t a, intmax_t b, intmax_t r) > > +assert_plus(intmax_t a, intmax_t b, volatile intmax_t r) > > { > > /* > > * sum of two positive numbers must be positive, > > @@ -420,7 +420,7 @@ > > } > > > > void > > -assert_minus(intmax_t a, intmax_t b, intmax_t r) > > +assert_minus(intmax_t a, intmax_t b, volatile intmax_t r) > > { > > /* special case subtraction of INTMAX_MIN */ > > if (b == INTMAX_MIN && a < 0) > > > > > > There were already some patches previously done to this > > file to add "volatile", so maybe this would be OK to do. > > > > What do you think? > > Volatile is not the solution, it is completely orthogonal. The correct > way would be to use unsigned integers, for which wrapping is defined, > then convert those back and forth when presenting the results to the > user. > OK, converting expr.y to use unsigned integers would require a bit of work. Can you commit your patch to the Makefile? It fixes the problem for now. -- Craig From owner-freebsd-testing@FreeBSD.ORG Sun Mar 22 22:04:04 2015 Return-Path: Delivered-To: freebsd-testing@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 89BD6F71; Sun, 22 Mar 2015 22:04:04 +0000 (UTC) Received: from mail-pd0-x22c.google.com (mail-pd0-x22c.google.com [IPv6:2607:f8b0:400e:c02::22c]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4545DDA9; Sun, 22 Mar 2015 22:04:04 +0000 (UTC) Received: by pdnc3 with SMTP id c3so167254832pdn.0; Sun, 22 Mar 2015 15:04:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=content-type:mime-version:subject:from:in-reply-to:date:cc :message-id:references:to; bh=0H9njTI3ohQspDWEx/Iy5IEuOhSr4VzatijPpGIKmzU=; b=y4+s18PMd7MSejTm0cNf2+gSWk9E2lC2x6Ww2FRvBH9SAUz81EYWOj6y3ks/xbFvy1 SHgsipzlYFVO9/pP9gXYSY0NfkuCAP29T4wacdygHe+n0Y4E3ePOJSBVed/MG2JBvi2E /2zcA+Xf6RVb41SK84//czCMZ2LDuIhj0Z0vXuG7KwI6hwW8wzfpzI9nnryS0uzqufIi UCwyLhyleauItKfxTYbo8Rok8zugQ8kOS+sajYSQuryb+F1j6yhl+QpRXNbUMAZSIDoa vKT16kOKsKrt1NKkge6VgQLb8DaV44ZbMoOJyJa5hgtY0C/+F3GTds6HamQLcP2pa3+w XlXw== X-Received: by 10.68.163.101 with SMTP id yh5mr15494328pbb.92.1427061843888; Sun, 22 Mar 2015 15:04:03 -0700 (PDT) Received: from ?IPv6:2601:8:ab80:7d6:7544:258:ce3d:185a? ([2601:8:ab80:7d6:7544:258:ce3d:185a]) by mx.google.com with ESMTPSA id pu9sm14829192pdb.49.2015.03.22.15.04.02 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Sun, 22 Mar 2015 15:04:03 -0700 (PDT) Content-Type: multipart/signed; boundary="Apple-Mail=_72593F52-BBFE-4F0E-87BF-012C28BD9D22"; protocol="application/pgp-signature"; micalg=pgp-sha512 Mime-Version: 1.0 (Mac OS X Mail 7.3 \(1878.6\)) Subject: Re: Jenkins build is still unstable: FreeBSD_HEAD-tests2 #867 From: Garrett Cooper In-Reply-To: Date: Sun, 22 Mar 2015 15:04:02 -0700 Message-Id: <08BB20A2-7B71-4ECF-B246-F3096CABA5E9@gmail.com> References: <1669399171.13.1427029129760.JavaMail.jenkins@jenkins-9.freebsd.org> <799490341.14.1427048792932.JavaMail.jenkins@jenkins-9.freebsd.org> <494AEF4B-0AF8-449A-9B41-9AC4F4552AF0@FreeBSD.org> <864EB4DB-2DF7-4294-9498-95E54E6B49CC@FreeBSD.org> To: Craig Rodrigues X-Mailer: Apple Mail (2.1878.6) Cc: "freebsd-testing@freebsd.org" , "jenkins-admin@freebsd.org" , freebsd-current Current , Dimitry Andric , freebsd-toolchain@freebsd.org X-BeenThere: freebsd-testing@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Testing on FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 22 Mar 2015 22:04:04 -0000 --Apple-Mail=_72593F52-BBFE-4F0E-87BF-012C28BD9D22 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=windows-1252 On Mar 22, 2015, at 15:01, Craig Rodrigues wrote: ... > OK, converting expr.y to use unsigned integers would require a bit of = work. >=20 > Can you commit your patch to the Makefile? It fixes the problem for = now. +1 I=92d still like to know why clang 3.5 doesn=92t have this behavior = though =97 there might be other potential issues lurking around that = need to be solved (either here, in ports, or both). Thanks! --Apple-Mail=_72593F52-BBFE-4F0E-87BF-012C28BD9D22 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQEcBAEBCgAGBQJVDzxSAAoJEMZr5QU6S73ecAwH/07zmJK44HOANECcgXC63Xgy 2TVGP3kd1OtbkQ83Vl/bYoJb1QpAyc9pQwneeB4/8BQ2mowWv2tdNrj+d+fdaL0I Ib9eJBhfsPvEfSxZnoRNHaD0cSAxFnqy3IWYN2LzBc6bvgWsQfsVph96Ytt8w77U ZeNo1+KtWETtgy0uvR/Aw4b+hkggN96xTIWrnOpZTiA9ikSaE4HLq+C1xY42LwdE ARUv+emCFs6JI9QsCNcTvlBEyUKXWNI1dWiFOX/2OwA7jB07zFETBteTYpOtjayO Lb/oN91K+E4zT4MSSjZB8DuzA7SgLpgaLLTsrlOQSNxF/UGrKqJeXQSRphdXqKI= =0mqv -----END PGP SIGNATURE----- --Apple-Mail=_72593F52-BBFE-4F0E-87BF-012C28BD9D22-- From owner-freebsd-testing@FreeBSD.ORG Sun Mar 22 22:09:58 2015 Return-Path: Delivered-To: freebsd-testing@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 906A927A; Sun, 22 Mar 2015 22:09:58 +0000 (UTC) Received: from tensor.andric.com (tensor.andric.com [87.251.56.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "tensor.andric.com", Issuer "COMODO RSA Domain Validation Secure Server CA" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 3F432DDE; Sun, 22 Mar 2015 22:09:57 +0000 (UTC) Received: from [IPv6:2001:7b8:3a7::b11b:b36a:c2e8:f12e] (unknown [IPv6:2001:7b8:3a7:0:b11b:b36a:c2e8:f12e]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by tensor.andric.com (Postfix) with ESMTPSA id 44E495C4C; Sun, 22 Mar 2015 23:09:54 +0100 (CET) Subject: Re: Jenkins build is still unstable: FreeBSD_HEAD-tests2 #867 Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2070.6\)) Content-Type: multipart/signed; boundary="Apple-Mail=_6336E6D8-6C10-4D78-BE7A-09B4801AA740"; protocol="application/pgp-signature"; micalg=pgp-sha1 X-Pgp-Agent: GPGMail 2.5b6 From: Dimitry Andric In-Reply-To: <08BB20A2-7B71-4ECF-B246-F3096CABA5E9@gmail.com> Date: Sun, 22 Mar 2015 23:09:40 +0100 Message-Id: <72ABF177-320F-4CB1-8B05-36B133714C55@FreeBSD.org> References: <1669399171.13.1427029129760.JavaMail.jenkins@jenkins-9.freebsd.org> <799490341.14.1427048792932.JavaMail.jenkins@jenkins-9.freebsd.org> <494AEF4B-0AF8-449A-9B41-9AC4F4552AF0@FreeBSD.org> <864EB4DB-2DF7-4294-9498-95E54E6B49CC@FreeBSD.org> <08BB20A2-7B71-4ECF-B246-F3096CABA5E9@gmail.com> To: Garrett Cooper X-Mailer: Apple Mail (2.2070.6) Cc: "freebsd-testing@freebsd.org" , freebsd-current Current , "jenkins-admin@freebsd.org" , freebsd-toolchain@freebsd.org X-BeenThere: freebsd-testing@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Testing on FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 22 Mar 2015 22:09:58 -0000 --Apple-Mail=_6336E6D8-6C10-4D78-BE7A-09B4801AA740 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=windows-1252 On 22 Mar 2015, at 23:04, Garrett Cooper wrote: >=20 > On Mar 22, 2015, at 15:01, Craig Rodrigues = wrote: >=20 > ... >=20 >> OK, converting expr.y to use unsigned integers would require a bit of = work. >>=20 >> Can you commit your patch to the Makefile? It fixes the problem for = now. >=20 > +1 >=20 > I=92d still like to know why clang 3.5 doesn=92t have this behavior = though =97 there might be other potential issues lurking around that = need to be solved (either here, in ports, or both). Because this version optimizes better around undefined behavior. There are most likely many issues lurking around, and most certainly in ports. I would recommend using UBSan to tackle this kind of thing. -Dimitry --Apple-Mail=_6336E6D8-6C10-4D78-BE7A-09B4801AA740 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0.27 iEYEARECAAYFAlUPPbEACgkQsF6jCi4glqO+EQCfRV0coLqzbq/b7W2YbXnWWhiA wwUAnjhvUfeCwftSkCrah8o/tttHyjk3 =PUdl -----END PGP SIGNATURE----- --Apple-Mail=_6336E6D8-6C10-4D78-BE7A-09B4801AA740-- From owner-freebsd-testing@FreeBSD.ORG Sun Mar 22 22:11:26 2015 Return-Path: Delivered-To: freebsd-testing@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id A778B4A1; Sun, 22 Mar 2015 22:11:26 +0000 (UTC) Received: from mail-pd0-x231.google.com (mail-pd0-x231.google.com [IPv6:2607:f8b0:400e:c02::231]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 628E1E8D; Sun, 22 Mar 2015 22:11:26 +0000 (UTC) Received: by pdnc3 with SMTP id c3so167378325pdn.0; Sun, 22 Mar 2015 15:11:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=content-type:mime-version:subject:from:in-reply-to:date:cc :message-id:references:to; bh=cUvNI2mNl/LLuCKDsxT+AGYmKAIaaSwQ81n136ydiwM=; b=WMXxwk6JCW/YUTCrCCIvBtsEBqSDMUg77fQp+5GoV8tSA9RCBscnn+ikw16ddDNdP2 49+T3ZlPmSsYtavSpY+vNd+yXuxaHpobG3YzhCbJFcJvgZQGnEwvDdLNumWfK1F4Chnr 7c1wHb5v+4Sih/AR1zDhlebxhHbY0GW1Mac0rSQUcaOqTgBs+Rd6PlFu4mbLLPFOESUm k8aefepY/3P/lqI1/xJVf00z7qZkLPYZmN2pa908moE1U9uU8LZ5kXjkRJUwnwdwwDHN FRD2pkoxrZF9DXLLBHLxZOkiNTfoaiONmUJbjl4zVnb5Q7osg9O4ey6TVrp2c4xgta1K M7WA== X-Received: by 10.68.97.65 with SMTP id dy1mr15499666pbb.10.1427062285909; Sun, 22 Mar 2015 15:11:25 -0700 (PDT) Received: from ?IPv6:2601:8:ab80:7d6:7544:258:ce3d:185a? ([2601:8:ab80:7d6:7544:258:ce3d:185a]) by mx.google.com with ESMTPSA id ha5sm5194700pbb.34.2015.03.22.15.11.24 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Sun, 22 Mar 2015 15:11:25 -0700 (PDT) Content-Type: multipart/signed; boundary="Apple-Mail=_029FC81D-E914-4D1C-8C87-527A0BE03AA8"; protocol="application/pgp-signature"; micalg=pgp-sha512 Mime-Version: 1.0 (Mac OS X Mail 7.3 \(1878.6\)) Subject: Re: Jenkins build is still unstable: FreeBSD_HEAD-tests2 #867 From: Garrett Cooper In-Reply-To: <72ABF177-320F-4CB1-8B05-36B133714C55@FreeBSD.org> Date: Sun, 22 Mar 2015 15:11:22 -0700 Message-Id: References: <1669399171.13.1427029129760.JavaMail.jenkins@jenkins-9.freebsd.org> <799490341.14.1427048792932.JavaMail.jenkins@jenkins-9.freebsd.org> <494AEF4B-0AF8-449A-9B41-9AC4F4552AF0@FreeBSD.org> <864EB4DB-2DF7-4294-9498-95E54E6B49CC@FreeBSD.org> <08BB20A2-7B71-4ECF-B246-F3096CABA5E9@gmail.com> <72ABF177-320F-4CB1-8B05-36B133714C55@FreeBSD.org> To: Dimitry Andric X-Mailer: Apple Mail (2.1878.6) Cc: "freebsd-testing@freebsd.org" , freebsd-current Current , "jenkins-admin@freebsd.org" , freebsd-toolchain@freebsd.org X-BeenThere: freebsd-testing@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Testing on FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 22 Mar 2015 22:11:26 -0000 --Apple-Mail=_029FC81D-E914-4D1C-8C87-527A0BE03AA8 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=windows-1252 On Mar 22, 2015, at 15:09, Dimitry Andric wrote: > On 22 Mar 2015, at 23:04, Garrett Cooper = wrote: >>=20 >> On Mar 22, 2015, at 15:01, Craig Rodrigues = wrote: >>=20 >> ... >>=20 >>> OK, converting expr.y to use unsigned integers would require a bit = of work. >>>=20 >>> Can you commit your patch to the Makefile? It fixes the problem for = now. >>=20 >> +1 >>=20 >> I=92d still like to know why clang 3.5 doesn=92t have this behavior = though =97 there might be other potential issues lurking around that = need to be solved (either here, in ports, or both). >=20 > Because this version optimizes better around undefined behavior. = There > are most likely many issues lurking around, and most certainly in = ports. >=20 > I would recommend using UBSan to tackle this kind of thing. I hope this got a ports tinderbox run first=85 Adding UBSan to tinderbox = runs for toolchain upgrades [in the future] might be a good idea. --Apple-Mail=_029FC81D-E914-4D1C-8C87-527A0BE03AA8 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQEcBAEBCgAGBQJVDz4KAAoJEMZr5QU6S73e3rcH/1ZT6l5PyKPV3xGX0YGSjSPn J2bSOr8vpBx60voNtrHLslpsqUQEDVXGSing0mhXxHDNx4+QzZqCvP6N3BRXr02c mYm/ikZBJ0fE6AjplOKX4DrVUh65PEGnp9+9z/3XezBebvQKmdbt2Uo3mHfQUQcq 08wj/nc5wtpf2W3bcCDE6iYU1bwWDZYpbwlTQjCpegzWW2Q+EDYMdIE2bEXkEBmq up55M5pVqbIhelY1D/d5BlW/PYDGKop5JDDmH8STiG1eSBNuUJtv6T/9+3inVZAk y9iWvP0GzkE+oD8mJOKVZ1MFF/Z24qzH0VszhWvdBW41r4aIVyj4SK5UFtTTnCY= =jFNA -----END PGP SIGNATURE----- --Apple-Mail=_029FC81D-E914-4D1C-8C87-527A0BE03AA8-- From owner-freebsd-testing@FreeBSD.ORG Sun Mar 22 22:19:25 2015 Return-Path: Delivered-To: freebsd-testing@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 0171E820; Sun, 22 Mar 2015 22:19:24 +0000 (UTC) Received: from tensor.andric.com (tensor.andric.com [87.251.56.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "tensor.andric.com", Issuer "COMODO RSA Domain Validation Secure Server CA" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 74C41EBE; Sun, 22 Mar 2015 22:19:24 +0000 (UTC) Received: from [IPv6:2001:7b8:3a7::b11b:b36a:c2e8:f12e] (unknown [IPv6:2001:7b8:3a7:0:b11b:b36a:c2e8:f12e]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by tensor.andric.com (Postfix) with ESMTPSA id A0C745C4D; Sun, 22 Mar 2015 23:19:21 +0100 (CET) Subject: Re: Jenkins build is still unstable: FreeBSD_HEAD-tests2 #867 Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2070.6\)) Content-Type: multipart/signed; boundary="Apple-Mail=_A2E23188-C424-494C-B941-7BF4A9BACA97"; protocol="application/pgp-signature"; micalg=pgp-sha1 X-Pgp-Agent: GPGMail 2.5b6 From: Dimitry Andric In-Reply-To: Date: Sun, 22 Mar 2015 23:19:20 +0100 Message-Id: References: <1669399171.13.1427029129760.JavaMail.jenkins@jenkins-9.freebsd.org> <799490341.14.1427048792932.JavaMail.jenkins@jenkins-9.freebsd.org> <494AEF4B-0AF8-449A-9B41-9AC4F4552AF0@FreeBSD.org> <864EB4DB-2DF7-4294-9498-95E54E6B49CC@FreeBSD.org> <08BB20A2-7B71-4ECF-B246-F3096CABA5E9@gmail.com> <72ABF177-320F-4CB1-8B05-36B133714C55@FreeBSD.org> To: Garrett Cooper X-Mailer: Apple Mail (2.2070.6) Cc: "freebsd-testing@freebsd.org" , freebsd-current Current , "jenkins-admin@freebsd.org" , freebsd-toolchain@freebsd.org X-BeenThere: freebsd-testing@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Testing on FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 22 Mar 2015 22:19:25 -0000 --Apple-Mail=_A2E23188-C424-494C-B941-7BF4A9BACA97 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=windows-1252 On 22 Mar 2015, at 23:11, Garrett Cooper wrote: >=20 > On Mar 22, 2015, at 15:09, Dimitry Andric wrote: >=20 >> On 22 Mar 2015, at 23:04, Garrett Cooper = wrote: >>>=20 >>> On Mar 22, 2015, at 15:01, Craig Rodrigues = wrote: >>>=20 >>> ... >>>=20 >>>> OK, converting expr.y to use unsigned integers would require a bit = of work. >>>>=20 >>>> Can you commit your patch to the Makefile? It fixes the problem = for now. >>>=20 >>> +1 >>>=20 >>> I=92d still like to know why clang 3.5 doesn=92t have this behavior = though =97 there might be other potential issues lurking around that = need to be solved (either here, in ports, or both). >>=20 >> Because this version optimizes better around undefined behavior. = There >> are most likely many issues lurking around, and most certainly in = ports. >>=20 >> I would recommend using UBSan to tackle this kind of thing. >=20 > I hope this got a ports tinderbox run first=85 It is called an "exp-run" in ports land, but that only really tests whether ports *build* successfully. For most ports, there is no good way of testing them, certainly not if they don't have their own testing facilities. That said, I have built quite a number of ports with 3.6.0, even before the import, and saw zero problems until now. Then again, I'm just one user, and that is a very low sample size. ;) I don't expect a great many problems with integer wrapping though. You have to realize that quite a lot of open source projects already went through this phase, when gcc started optimizing integer wrapping a few years ago. We are just slowly catching up. > Adding UBSan to tinderbox runs for toolchain upgrades [in the future] = might be a good idea. Maybe, but please note that both ASan and UBSan are still beta-ish under FreeBSD, there will most likely be bumps along the road. Any bug reports in that area are welcome. -Dimitry --Apple-Mail=_A2E23188-C424-494C-B941-7BF4A9BACA97 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0.27 iEYEARECAAYFAlUPP+gACgkQsF6jCi4glqNNQgCdEyuU258imuu7h+koQkg2q/B0 SWEAmwaAd9VLhiRiz2+5Th9OyPxyxlGO =lsge -----END PGP SIGNATURE----- --Apple-Mail=_A2E23188-C424-494C-B941-7BF4A9BACA97-- From owner-freebsd-testing@FreeBSD.ORG Sun Mar 22 23:21:50 2015 Return-Path: Delivered-To: freebsd-testing@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id E0D952C8; Sun, 22 Mar 2015 23:21:50 +0000 (UTC) Received: from mail-la0-x22b.google.com (mail-la0-x22b.google.com [IPv6:2a00:1450:4010:c03::22b]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 709046E4; Sun, 22 Mar 2015 23:21:50 +0000 (UTC) Received: by lagg8 with SMTP id g8so121918103lag.1; Sun, 22 Mar 2015 16:21:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=oiL2vrrT5PIPZmTnbWngtkHzy9QqKDZJBZC84uZyYuY=; b=DtVxJii3lPpTB9gvNoD5P/GsN5aVPCecKp7QQ7ptYTaGC5KHErdztA4vS+HxYozjZB U5xDP9p3on8BWcS8gkiF5Kpc2qWHkD/JNnuxyK5M2sRdQVxZYMR/H8FhKxYawjTntd56 Fs/KfCLIuJ0fZ25hyU0hVZj8Cr4lcNu+OAoEsrf9epJ2/SamvMfEKkg8veQPSdWBMszT IS525yyZq61UOG29223zyzVgBG9IdDKpBFAh9yt2uAyUblBagPVPvEBnCBIV31lICaPT oLUt9VzfaMB67zoEqmOgILQhX1QiV5uHA3eqjYYHukTSDwHrwMOg0c8B4tjYcb1Ud/ek /oBg== MIME-Version: 1.0 X-Received: by 10.152.234.108 with SMTP id ud12mr61998006lac.81.1427066508535; Sun, 22 Mar 2015 16:21:48 -0700 (PDT) Sender: crodr001@gmail.com Received: by 10.112.82.164 with HTTP; Sun, 22 Mar 2015 16:21:48 -0700 (PDT) In-Reply-To: References: <1669399171.13.1427029129760.JavaMail.jenkins@jenkins-9.freebsd.org> <799490341.14.1427048792932.JavaMail.jenkins@jenkins-9.freebsd.org> <494AEF4B-0AF8-449A-9B41-9AC4F4552AF0@FreeBSD.org> <864EB4DB-2DF7-4294-9498-95E54E6B49CC@FreeBSD.org> Date: Sun, 22 Mar 2015 16:21:48 -0700 X-Google-Sender-Auth: ZPKE2ILuCH-vTojAgLI-Pf3tUDA Message-ID: Subject: Re: Jenkins build is still unstable: FreeBSD_HEAD-tests2 #867 From: Craig Rodrigues To: Dimitry Andric Content-Type: text/plain; charset=ISO-8859-1 X-Content-Filtered-By: Mailman/MimeDel 2.1.18-1 Cc: "freebsd-testing@freebsd.org" , freebsd-current Current , "jenkins-admin@freebsd.org" , freebsd-toolchain@freebsd.org X-BeenThere: freebsd-testing@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Testing on FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 22 Mar 2015 23:21:51 -0000 On Sun, Mar 22, 2015 at 3:01 PM, Craig Rodrigues wrote: > > > On Sun, Mar 22, 2015 at 2:36 PM, Dimitry Andric wrote: > >> On 22 Mar 2015, at 22:32, Craig Rodrigues wrote: >> > >> > On Sun, Mar 22, 2015 at 2:29 PM, Dimitry Andric >> wrote: >> > >> > Ah right, that was on i386, on amd64 it does result in -2^63. It is >> indeed caused by reliance on signed integer wrapping. >> > >> > This diff should fix it, without rewriting the utility: >> > >> > Index: bin/expr/Makefile >> > =================================================================== >> > --- bin/expr/Makefile (revision 280156) >> > +++ bin/expr/Makefile (working copy) >> > @@ -6,6 +6,9 @@ PROG= expr >> > SRCS= expr.y >> > YFLAGS= >> > >> > +# expr relies on signed integer wrapping >> > +CFLAGS+= -fwrapv >> > + >> > NO_WMISSING_VARIABLE_DECLARATIONS= >> > >> > .if ${MK_TESTS} != "no" >> > >> > >> > Well, another alternative is to patch expr.y: >> > >> > Index: expr.y >> > =================================================================== >> > --- expr.y (revision 280353) >> > +++ expr.y (working copy) >> > @@ -393,7 +393,7 @@ >> > } >> > >> > void >> > -assert_plus(intmax_t a, intmax_t b, intmax_t r) >> > +assert_plus(intmax_t a, intmax_t b, volatile intmax_t r) >> > { >> > /* >> > * sum of two positive numbers must be positive, >> > @@ -420,7 +420,7 @@ >> > } >> > >> > void >> > -assert_minus(intmax_t a, intmax_t b, intmax_t r) >> > +assert_minus(intmax_t a, intmax_t b, volatile intmax_t r) >> > { >> > /* special case subtraction of INTMAX_MIN */ >> > if (b == INTMAX_MIN && a < 0) >> > >> > >> > There were already some patches previously done to this >> > file to add "volatile", so maybe this would be OK to do. >> > >> > What do you think? >> >> Volatile is not the solution, it is completely orthogonal. The correct >> way would be to use unsigned integers, for which wrapping is defined, >> then convert those back and forth when presenting the results to the >> user. >> > > OK, converting expr.y to use unsigned integers would require a bit of work. > > Can you commit your patch to the Makefile? It fixes the problem for now. > > Thanks for committing the fix. I wasn't aware of this topic, but it is explained quite nicely in this LLVM blog post: http://blog.llvm.org/2011/05/what-every-c-programmer-should-know.html#signed_overflow Do you think we should further change expr.y with something like this: Index: expr.y =================================================================== --- expr.y (revision 280357) +++ expr.y (working copy) @@ -445,12 +445,13 @@ } /* - * We depend on undefined behaviour giving a result (in r). - * To test this result, pass it as volatile. This prevents - * optimizing away of the test based on the undefined behaviour. + * We depend on undefined signed integer overflow behaviour + * giving a result (in r). + * This file must be compiled with the "-fwrapv" compiler + * flag which forces defined behavior for signed integer overflow. */ void -assert_times(intmax_t a, intmax_t b, volatile intmax_t r) +assert_times(intmax_t a, intmax_t b, intmax_t r) { /* * If the first operand is 0, no overflow is possible, -- Craig From owner-freebsd-testing@FreeBSD.ORG Mon Mar 23 00:49:22 2015 Return-Path: Delivered-To: freebsd-testing@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id DA0CE954; Mon, 23 Mar 2015 00:49:22 +0000 (UTC) Received: from mail-la0-x236.google.com (mail-la0-x236.google.com [IPv6:2a00:1450:4010:c03::236]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 5B69AEEA; Mon, 23 Mar 2015 00:49:22 +0000 (UTC) Received: by labto5 with SMTP id to5so14939710lab.0; Sun, 22 Mar 2015 17:49:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:date:message-id:subject:from:to:content-type; bh=ZCoAY1/5cFcgWaBdLgZ6QlzDlswQ1DsKlqkGQdyizRE=; b=So4D2A59QFCSC6XwiN6sBPMuDI/kEIe2S9scZaMfl5coecBKE8dwD7r4D1TUa20CqU PCSbyRzI9eV/1x90HIslj4ujg2cjKPmRp5LgoXgWeJVmbjxp9GYegEAY5WzCsSKkKwQh lO93w7LPniThnbiK829y3689f8pxrnXcXMhd1/T5HNj+vjPL4eC3dwZuOHIwGE4n/J2E Mdz2GiQ+uoxrbn7zltDhyhJ3kppVHxHLp/uBZu9VCKIgAlhF2mRc6+EuHpCj88rfuAsG 5muCqikmyfv5xhB03JVjg3/Lt3S9yqx9IPdy9TU4gj0NsvMDXZzUavcCt2vbzPI5aQpL ZT/g== MIME-Version: 1.0 X-Received: by 10.112.17.8 with SMTP id k8mr10631215lbd.26.1427071760150; Sun, 22 Mar 2015 17:49:20 -0700 (PDT) Sender: crodr001@gmail.com Received: by 10.112.82.164 with HTTP; Sun, 22 Mar 2015 17:49:20 -0700 (PDT) Date: Sun, 22 Mar 2015 17:49:20 -0700 X-Google-Sender-Auth: vupqQNDAKvrWzmb2PRHLUB3LrjA Message-ID: Subject: CROSS_TOOLCHAIN=amd64-gcc fails to build after clang 3.6.0 import From: Craig Rodrigues To: freebsd-toolchain@freebsd.org, "freebsd-testing@freebsd.org" Content-Type: text/plain; charset=ISO-8859-1 X-Content-Filtered-By: Mailman/MimeDel 2.1.18-1 X-BeenThere: freebsd-testing@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Testing on FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 Mar 2015 00:49:23 -0000 Hi, I tried to build HEAD with gcc 4.9.1 after the latest clang 3.6.0 import, and am getting new build failures related to C++ such as: /builds/FreeBSD_HEAD_external_toolchain_gcc/obj/builds/FreeBSD_HEAD_external_toolchain_gcc/tmp/usr/include/c++/v1/type_traits:881:87: error: use of deleted function 'clang::Sema::TypoExprState::TypoExprState(const clang::Sema::TypoExprState&)' sizeof(__is_convertible_imp::__test<_T2>(__is_convertible_imp::__source<_T1>())) == 1 See full build logs here: https://jenkins.freebsd.org/job/FreeBSD_HEAD_external_toolchain_gcc/21/console Any ideas what the problem might be? Thanks. -- Craig From owner-freebsd-testing@FreeBSD.ORG Mon Mar 23 07:13:03 2015 Return-Path: Delivered-To: freebsd-testing@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 4CC3616B; Mon, 23 Mar 2015 07:13:03 +0000 (UTC) Received: from tensor.andric.com (unknown [IPv6:2001:7b8:3a7:1:2d0:b7ff:fea0:8c26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "tensor.andric.com", Issuer "COMODO RSA Domain Validation Secure Server CA" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 0692F9D0; Mon, 23 Mar 2015 07:13:03 +0000 (UTC) Received: from [IPv6:2001:7b8:3a7::b11b:b36a:c2e8:f12e] (unknown [IPv6:2001:7b8:3a7:0:b11b:b36a:c2e8:f12e]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by tensor.andric.com (Postfix) with ESMTPSA id C0EC75C4D; Mon, 23 Mar 2015 08:12:58 +0100 (CET) Subject: Re: CROSS_TOOLCHAIN=amd64-gcc fails to build after clang 3.6.0 import Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2070.6\)) Content-Type: multipart/signed; boundary="Apple-Mail=_01478318-A03E-4546-90F2-CAF8BC69E45E"; protocol="application/pgp-signature"; micalg=pgp-sha1 X-Pgp-Agent: GPGMail 2.5b6 From: Dimitry Andric In-Reply-To: Date: Mon, 23 Mar 2015 08:12:48 +0100 Message-Id: <5F90BE99-E82C-4444-9E4C-5963B40AA3B0@FreeBSD.org> References: To: Craig Rodrigues X-Mailer: Apple Mail (2.2070.6) Cc: "freebsd-testing@freebsd.org" , freebsd-toolchain@freebsd.org X-BeenThere: freebsd-testing@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Testing on FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 Mar 2015 07:13:03 -0000 --Apple-Mail=_01478318-A03E-4546-90F2-CAF8BC69E45E Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii On 23 Mar 2015, at 01:49, Craig Rodrigues wrote: >=20 > Hi, >=20 > I tried to build HEAD with gcc 4.9.1 after the latest clang 3.6.0 = import, > and am getting > new build failures related to C++ such as: >=20 > = /builds/FreeBSD_HEAD_external_toolchain_gcc/obj/builds/FreeBSD_HEAD_extern= al_toolchain_gcc/tmp/usr/include/c++/v1/type_traits:881:87: > error: use of deleted function > 'clang::Sema::TypoExprState::TypoExprState(const > clang::Sema::TypoExprState&)' >=20 > = sizeof(__is_convertible_imp::__test<_T2>(__is_convertible_imp::__source<_T= 1>())) > =3D=3D 1 >=20 > See full build logs here: > = https://jenkins.freebsd.org/job/FreeBSD_HEAD_external_toolchain_gcc/21/con= sole >=20 > Any ideas what the problem might be? Yes, this is a bug in libc++, when compiling it with newer versions of gcc. I reported this upstream some time ago: https://llvm.org/PR22771 Still haven't had enough time to test Eric Fiselier's patch for it. I hope I see the bottom of my TODO list anytime soon... -Dimitry --Apple-Mail=_01478318-A03E-4546-90F2-CAF8BC69E45E Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0.27 iEYEARECAAYFAlUPvPkACgkQsF6jCi4glqM44QCggtP/UKqPA8Ab8U42C88CrM9Y 1JAAnjrQ7BSCcnZedVr+rW0GpMWFRqBp =jUkP -----END PGP SIGNATURE----- --Apple-Mail=_01478318-A03E-4546-90F2-CAF8BC69E45E-- From owner-freebsd-testing@FreeBSD.ORG Mon Mar 23 09:39:30 2015 Return-Path: Delivered-To: freebsd-testing@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id AC3F2F5A; Mon, 23 Mar 2015 09:39:30 +0000 (UTC) Received: from theravensnest.org (theraven.freebsd.your.org [216.14.102.27]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "cloud.theravensnest.org", Issuer "StartCom Class 1 Primary Intermediate Server CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 6C361C94; Mon, 23 Mar 2015 09:39:29 +0000 (UTC) Received: from [192.168.0.7] (cpc16-cmbg15-2-0-cust60.5-4.cable.virginm.net [86.5.162.61]) (authenticated bits=0) by theravensnest.org (8.15.1/8.14.9) with ESMTPSA id t2N9b8Ld024621 (version=TLSv1 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Mon, 23 Mar 2015 09:38:23 GMT (envelope-from theraven@FreeBSD.org) X-Authentication-Warning: theravensnest.org: Host cpc16-cmbg15-2-0-cust60.5-4.cable.virginm.net [86.5.162.61] claimed to be [192.168.0.7] Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2070.6\)) Subject: Re: Jenkins build is still unstable: FreeBSD_HEAD-tests2 #867 From: David Chisnall In-Reply-To: Date: Mon, 23 Mar 2015 09:33:15 +0000 Content-Transfer-Encoding: quoted-printable Message-Id: References: <1669399171.13.1427029129760.JavaMail.jenkins@jenkins-9.freebsd.org> <799490341.14.1427048792932.JavaMail.jenkins@jenkins-9.freebsd.org> <494AEF4B-0AF8-449A-9B41-9AC4F4552AF0@FreeBSD.org> <864EB4DB-2DF7-4294-9498-95E54E6B49CC@FreeBSD.org> To: Craig Rodrigues X-Mailer: Apple Mail (2.2070.6) Cc: "freebsd-testing@freebsd.org" , "jenkins-admin@freebsd.org" , freebsd-current Current , Dimitry Andric , freebsd-toolchain@freebsd.org X-BeenThere: freebsd-testing@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Testing on FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 Mar 2015 09:39:30 -0000 On 22 Mar 2015, at 22:01, Craig Rodrigues wrote: >=20 >> Volatile is not the solution, it is completely orthogonal. The = correct >> way would be to use unsigned integers, for which wrapping is defined, >> then convert those back and forth when presenting the results to the >> user. >>=20 >=20 > OK, converting expr.y to use unsigned integers would require a bit of = work. Note that clang has, for a few releases, had builtins that allow = overflow-checked operations and will generate very efficient code. In = op_times, I believe the following should work: long long mul; #if __has_builtin(__builtin_smulll_overflow) if (__builtin_smulll_overflow(a->u.i, b->u.i, &mul)) errx(ERR_EXIT, "overflow");=20 #else mul =3D a->u.i * b->u.i; #endif r =3D make_integer(mul); I don't know if recent versions of gcc implement these builtins yet. I = think they were added to clang around 3.4, possibly slightly earlier. =20= David From owner-freebsd-testing@FreeBSD.ORG Tue Mar 24 06:58:18 2015 Return-Path: Delivered-To: freebsd-testing@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 364A6382 for ; Tue, 24 Mar 2015 06:58:18 +0000 (UTC) Received: from vps.hungerhost.com (vps.hungerhost.com [216.38.53.176]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 088D9639 for ; Tue, 24 Mar 2015 06:58:17 +0000 (UTC) Received: from em119-72-197-39.pool.e-mobile.ne.jp ([119.72.197.39]:61340 helo=[192.168.13.102]) by vps.hungerhost.com with esmtpsa (TLSv1:DHE-RSA-AES256-SHA:256) (Exim 4.82) (envelope-from ) id 1YaIn1-0000fD-QI; Tue, 24 Mar 2015 02:58:16 -0400 From: "George Neville-Neil" To: "Craig Rodrigues" Subject: Re: Jenkins builds for non X86 Date: Tue, 24 Mar 2015 15:58:03 +0900 Message-ID: In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; format=flowed X-Mailer: MailMate (1.9r5077) X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - vps.hungerhost.com X-AntiAbuse: Original Domain - freebsd.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - neville-neil.com X-Get-Message-Sender-Via: vps.hungerhost.com: authenticated_id: gnn@neville-neil.com Cc: freebsd-testing@freebsd.org X-BeenThere: freebsd-testing@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Testing on FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Mar 2015 06:58:18 -0000 On 20 Mar 2015, at 11:15, Craig Rodrigues wrote: > On Mar 19, 2015 6:23 PM, "George Neville-Neil" > wrote: >> >> On 20 Mar 2015, at 10:22, Craig Rodrigues wrote: >> >>> On Thu, Mar 19, 2015 at 6:14 PM, George Neville-Neil < > gnn@neville-neil.com> >>> wrote: >>> >>>> On 20 Mar 2015, at 5:53, Craig Rodrigues wrote: >>>> >>>> On Thu, Mar 19, 2015 at 1:42 AM, George Neville-Neil < >>>>> gnn@neville-neil.com> >>>>> wrote: >>>>> >>>>>> >>>>>> >>>>>> Remind me, do the Jenkins builds try to build non-X86 stuff? >>>>>> ARM? >>>>>> >>>>> >>>>> >>>>> At http://jenkins.freebsd.org we currently have: >>>>> >>>>> FreeBSD_HEAD_sparc64 -> builds sparc64 with existing gcc in >>>>> base >>>>> >>>>> FreeBSD_HEAD_mip32_be >>>>> FreeBSD_HEAD_mips32_le >>>>> FreeBSD_HEAD_mips64_be >>>>> FreeBSD_HEAD_mips64_le >>>>> -> builds various mips >>>>> targets with existing gcc in base. >>>>> These are not running >>>>> every day. >>>>> >>>>> Nothing for ARM yet. >>>>> >>>>> >>>>> I set up this build: >>>>> FreeBSD_HEAD_external_toolchain_gcc >>>>> >>>>> but it is failing due to a bug in the FreeBSD Makefiles with >>>>> respect > to >>>>> setting --sysroot >>>>> https://lists.freebsd.org/pipermail/freebsd-toolchain/ >>>>> 2015-March/001458.html >>>>> >>>>> Is that something you can help with? >>>>> >>>>> Proper external toolchain support will be helpful for ARM, ARM64, >>>>> etc. >>>>> >>>>> >>>> Warner (imp@) is working on this. Do the MIPS builds use QEMU? If >>>> so, >>>> then why >>>> not do ARM the same way for now? >>>> >>>> >>> >>> No, we don't build mips inside QEMU. QEMU is very slow. >>> Do you know when Warner will fix the --sysroot stuff with external >>> toolchain? >>> I sent an e-mail to freebsd-toolchain@ but got no response. >> Email him directly. >> >> If you do not use QEMU what do you use? > > I follow these instructions: > > https://wiki.freebsd.org/FreeBSD/MipsEmulation > Ah, so you just do the build part of that page right? If so I can get you a similar recipe for ARM. Bet, George From owner-freebsd-testing@FreeBSD.ORG Wed Mar 25 03:18:03 2015 Return-Path: Delivered-To: freebsd-testing@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id B816D85B; Wed, 25 Mar 2015 03:18:03 +0000 (UTC) Received: from mail-la0-x22b.google.com (mail-la0-x22b.google.com [IPv6:2a00:1450:4010:c03::22b]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 27C5A85D; Wed, 25 Mar 2015 03:18:03 +0000 (UTC) Received: by labe2 with SMTP id e2so9464197lab.3; Tue, 24 Mar 2015 20:18:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=E92csWhiKNxWS43fpdGDbKfHFe4cZVaaP63qhQ2BJb8=; b=HKCZoAZZ4AqBBNw4gqOIMdLyB+7O2O0a5Ax9BHwHS7Yuta11scMA25ImlkLQa7N3Vw yF0zsPy2fLHtYHPwxu7lBZiip9988EzgDEXLgkmQGON0QFg4SWsCe2SMGzdAFUhkkTta rvIQOo8NFbrs2Wa5pfTsxoG97U1HQmgNpgPApjbh679sTbXz2hg741Th2yhDZtpNfkd1 d8hwHwLbf+Snx3NA33hwK7zRpCa70qNOF+MHh6OggOL6qRKMU8gULyg3q5KFCGETMNn/ dA0+BDuI6h1ovQLiUIoqjqV6pT+KjX+XQtgcx2S0SQAL/2J3VRBUBl3XF8pDWNNM3Edy bmrQ== MIME-Version: 1.0 X-Received: by 10.112.140.38 with SMTP id rd6mr6399718lbb.116.1427253480841; Tue, 24 Mar 2015 20:18:00 -0700 (PDT) Sender: crodr001@gmail.com Received: by 10.112.108.168 with HTTP; Tue, 24 Mar 2015 20:18:00 -0700 (PDT) In-Reply-To: References: <1857A2A3-0C19-4F52-BCAF-6C72FE7D8DF3@FreeBSD.org> Date: Tue, 24 Mar 2015 20:18:00 -0700 X-Google-Sender-Auth: VwrNYb59ny0Lp_Jp1cXjO4K7JWU Message-ID: Subject: Re: Failed to build with external toolchain From: Craig Rodrigues To: Dimitry Andric Content-Type: text/plain; charset=ISO-8859-1 X-Content-Filtered-By: Mailman/MimeDel 2.1.18-1 Cc: "freebsd-testing@freebsd.org" , freebsd-toolchain@freebsd.org X-BeenThere: freebsd-testing@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Testing on FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 Mar 2015 03:18:03 -0000 On Sat, Mar 7, 2015 at 3:48 PM, Dimitry Andric wrote: > On 07 Mar 2015, at 21:12, Craig Rodrigues wrote: > > I ran the build again and this time I am getting errors about undefined > > symbol utimensat(): > > > > > https://jenkins.freebsd.org/job/FreeBSD_HEAD_external_toolchain_gcc/14/console > > > > Any ideas? > > It's linking against the wrong libc, the one from the FreeBSD-10 host > system, which does not have utimensat(): > > --- cp --- > /usr/local/bin/x86_64-portbld-freebsd10.0-gcc -isystem > /builds/FreeBSD_HEAD_external_toolchain_gcc/obj/builds/FreeBSD_HEAD_external_toolchain_gcc/tmp/usr/include > -L/builds/FreeBSD_HEAD_external_toolchain_gcc/obj/builds/FreeBSD_HEAD_external_toolchain_gcc/tmp/usr/lib > -O2 -pipe -DVM_AND_BUFFER_CACHE_SYNCHRONIZED -D_ACL_PRIVATE -std=gnu99 > -fstack-protector -Wsystem-headers -Wall -Wno-format-y2k -W > -Wno-unused-parameter -Wstrict-prototypes -Wmissing-prototypes > -Wpointer-arith -Wreturn-type -Wcast-qual -Wwrite-strings -Wswitch -Wshadow > -Wunused-parameter -Wcast-align -Wchar-subscripts -Winline -Wnested-externs > -Wredundant-decls -Wold-style-definition -Wno-pointer-sign -o cp cp.o > utils.o > [...] > utils.o: In function `setfile': > utils.c:(.text+0x83): undefined reference to `utimensat' > utils.c:(.text+0x1ce): undefined reference to `utimensat' > utils.c:(.text+0x38c): undefined reference to `utimensat' > collect2: error: ld returned 1 exit status > > There should probably be a --sysroot flag in there, pointing to the > ${WORLDTMP} built during the earlier stages. > > For some reason, this flag is not added for gcc, in Makefile.inc1. No > idea why that was done. > > -Dimitry > > I eliminated the problem with this patch: Index: Makefile.inc1 =================================================================== --- Makefile.inc1 (revision 280353) +++ Makefile.inc1 (working copy) @@ -381,9 +381,9 @@ TARGET_ABI?= unknown TARGET_TRIPLE?= ${TARGET_ARCH:C/amd64/x86_64/}-${TARGET_ABI}-freebsd11.0 XCFLAGS+= -target ${TARGET_TRIPLE} +.endif XCFLAGS+= --sysroot=${WORLDTMP} ${BFLAGS} XCXXFLAGS+= --sysroot=${WORLDTMP} ${BFLAGS} -.endif .else .if defined(CROSS_BINUTILS_PREFIX) && exists(${CROSS_BINUTILS_PREFIX}) BFLAGS+= -B${CROSS_BINUTILS_PREFIX} This sets --sysroot when doing CROSS_TOOLCHAIN for both clang *or* gcc. Right now, --sysroot is only set for clang. I did a "make universe" and "make buildworld CROSS_TOOLCHAIN_PREFIX=/usr/bin/" Is it OK if I commit it? -- Craig From owner-freebsd-testing@FreeBSD.ORG Wed Mar 25 03:39:33 2015 Return-Path: Delivered-To: freebsd-testing@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id C1C06A82 for ; Wed, 25 Mar 2015 03:39:33 +0000 (UTC) Received: from mail-pd0-f176.google.com (mail-pd0-f176.google.com [209.85.192.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 884FDA36 for ; Wed, 25 Mar 2015 03:39:33 +0000 (UTC) Received: by pdbni2 with SMTP id ni2so14329896pdb.1 for ; Tue, 24 Mar 2015 20:39:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:subject:mime-version:content-type:from :in-reply-to:date:cc:message-id:references:to; bh=OlQsQ5HeT1DaljqbvmkocyFw4OAXFUUtYiIXLYCOI60=; b=KHYLqO4OzOgYLRou1N1WL9fIL7Mj6SIUAVxIe+TxTXpXse/kzOp0nT8xv/rvy3Xbau FraLxzpmh+dWC1UVarwEF3HJwfGFcYuf11RirZOhK/HuOcro0KS5uoGpsf7Wm9ZqSNCY p0RQW2tdfQDAJ7sghxSJnusaRj1ofECHrnYVqPfJxDCn6qKP0d2zi31R1RJJp5kLe+e8 2gFmTwHwtDAG5r7gz98l+0asWqMax3vzgHJ9/xn3ru4HiOA2mYQVh6MwZX+47hJDUh58 EhPZSqFmSXZRaJRnKycRGHo9DXhWCtv5gKpL1WheXjSgv7PrCGM467EQF/FQpBP3XvnH bpGA== X-Gm-Message-State: ALoCoQnz2kTiGmA1xiwOCKzfiQaIINs0Jh06wtp5G83Ben9OnWIJb6DlpKMDwrJqSyHBmxYcCti/ X-Received: by 10.66.63.72 with SMTP id e8mr12842657pas.3.1427254767117; Tue, 24 Mar 2015 20:39:27 -0700 (PDT) Received: from lgmc-adee.corp.netflix.com ([69.53.236.236]) by mx.google.com with ESMTPSA id v7sm759745pds.72.2015.03.24.20.39.25 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 24 Mar 2015 20:39:26 -0700 (PDT) Sender: Warner Losh Subject: Re: Failed to build with external toolchain Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2070.6\)) Content-Type: multipart/signed; boundary="Apple-Mail=_641C2192-3CD7-4E25-B1D7-F00B73C5AFA3"; protocol="application/pgp-signature"; micalg=pgp-sha512 X-Pgp-Agent: GPGMail 2.5b6 From: Warner Losh In-Reply-To: Date: Tue, 24 Mar 2015 21:39:23 -0600 Message-Id: References: <1857A2A3-0C19-4F52-BCAF-6C72FE7D8DF3@FreeBSD.org> To: Craig Rodrigues X-Mailer: Apple Mail (2.2070.6) Cc: "freebsd-testing@freebsd.org" , freebsd-toolchain@freebsd.org, Dimitry Andric X-BeenThere: freebsd-testing@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Testing on FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 Mar 2015 03:39:33 -0000 --Apple-Mail=_641C2192-3CD7-4E25-B1D7-F00B73C5AFA3 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > On Mar 24, 2015, at 9:18 PM, Craig Rodrigues = wrote: >=20 > On Sat, Mar 7, 2015 at 3:48 PM, Dimitry Andric = wrote: >=20 >> On 07 Mar 2015, at 21:12, Craig Rodrigues = wrote: >>> I ran the build again and this time I am getting errors about = undefined >>> symbol utimensat(): >>>=20 >>>=20 >> = https://jenkins.freebsd.org/job/FreeBSD_HEAD_external_toolchain_gcc/14/con= sole >>>=20 >>> Any ideas? >>=20 >> It's linking against the wrong libc, the one from the FreeBSD-10 host >> system, which does not have utimensat(): >>=20 >> --- cp --- >> /usr/local/bin/x86_64-portbld-freebsd10.0-gcc -isystem >> = /builds/FreeBSD_HEAD_external_toolchain_gcc/obj/builds/FreeBSD_HEAD_extern= al_toolchain_gcc/tmp/usr/include >> = -L/builds/FreeBSD_HEAD_external_toolchain_gcc/obj/builds/FreeBSD_HEAD_exte= rnal_toolchain_gcc/tmp/usr/lib >> -O2 -pipe -DVM_AND_BUFFER_CACHE_SYNCHRONIZED -D_ACL_PRIVATE = -std=3Dgnu99 >> -fstack-protector -Wsystem-headers -Wall -Wno-format-y2k -W >> -Wno-unused-parameter -Wstrict-prototypes -Wmissing-prototypes >> -Wpointer-arith -Wreturn-type -Wcast-qual -Wwrite-strings -Wswitch = -Wshadow >> -Wunused-parameter -Wcast-align -Wchar-subscripts -Winline = -Wnested-externs >> -Wredundant-decls -Wold-style-definition -Wno-pointer-sign -o cp = cp.o >> utils.o >> [...] >> utils.o: In function `setfile': >> utils.c:(.text+0x83): undefined reference to `utimensat' >> utils.c:(.text+0x1ce): undefined reference to `utimensat' >> utils.c:(.text+0x38c): undefined reference to `utimensat' >> collect2: error: ld returned 1 exit status >>=20 >> There should probably be a --sysroot flag in there, pointing to the >> ${WORLDTMP} built during the earlier stages. >>=20 >> For some reason, this flag is not added for gcc, in Makefile.inc1. = No >> idea why that was done. >>=20 >> -Dimitry >>=20 >> I eliminated the problem with this patch: >=20 > Index: Makefile.inc1 > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > --- Makefile.inc1 (revision 280353) > +++ Makefile.inc1 (working copy) > @@ -381,9 +381,9 @@ > TARGET_ABI?=3D unknown > TARGET_TRIPLE?=3D > ${TARGET_ARCH:C/amd64/x86_64/}-${TARGET_ABI}-freebsd11.0 > XCFLAGS+=3D -target ${TARGET_TRIPLE} > +.endif > XCFLAGS+=3D --sysroot=3D${WORLDTMP} ${BFLAGS} > XCXXFLAGS+=3D --sysroot=3D${WORLDTMP} ${BFLAGS} > -.endif > .else > .if defined(CROSS_BINUTILS_PREFIX) && exists(${CROSS_BINUTILS_PREFIX}) > BFLAGS+=3D -B${CROSS_BINUTILS_PREFIX} >=20 >=20 > This sets --sysroot when doing CROSS_TOOLCHAIN for both clang *or* = gcc. > Right now, --sysroot is only set for clang. >=20 > I did a "make universe" and "make buildworld > CROSS_TOOLCHAIN_PREFIX=3D/usr/bin/" >=20 > Is it OK if I commit it? No. The in-tree gcc doesn=E2=80=99t grok =E2=80=94sysroot. We assume that version gcc 4.2.1 is special and our in-tree compiler = elsewhere, so please add a check for that and just go ahead and duplicate those two = lines. Eg +.else if ${COMPILER_VERSION} > 40201 +XCFLAGS+=3D --sysroot=3D${WORLDTMP} ${BFLAGS} +XCXXFLAGS+=3D --sysroot=3D${WORLDTMP} ${BFLAGS} .endif Warner --Apple-Mail=_641C2192-3CD7-4E25-B1D7-F00B73C5AFA3 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQIcBAEBCgAGBQJVEi3rAAoJEGwc0Sh9sBEARtkQAJzItEx8Yklzea9yHxdSS2RS 187LYuMKib7kOUHszlU2A6OmksDHAGyVhkQby9DIhozhSGy8ON64Ncmxf9BiudQi WrF7Q5+zW1Pb4FJFnn52E5EuEzyNnoE+f8ryFYNz73RuXgqKm7fVDMeQCQXRDWu9 lVeN479524mJZgkM6kC8tB2UpgHNd42vEpaV02s39qxAUHQrOSW9PE1cmJeufBU9 NjSZmklaHJKckRAYbcX5JKSAcjPPj5nY4zU0VoODMaMbt7h85zNLRjAqSb0MM1KJ OX7ylaqp/Or7JYTI7UliwKSKbw8U0gqiYdCB3Tr458NFc+KHbmKQvBFpb9UAYAtU bQXDBWzfQMzxrHtFgRO5Y6nLEPfZbCcvbQLhoGyhivcnzkB3VCQvbpfnMlBYgwHx 2RhymvBSgNlHglM2FDtWoA2nCl6DYHtKjMNNJOpvLJajUfNvzxVh8YvZJatdsSr9 +HvzNS3YgOznVRHCnMh6FS2g21fJbhD9hzS1Pqa5TgJmEy17MOI6Xw5PIlVtCcAS B0RYLL0CRL20h6ylyEQTwHj0rTd6TF/Y71fG1kmvknHBHKWV75FmBp8sXZVKMrWh 4x5obOd6t8gZx7MMF9Wn2WYtMKDQr8F08g59bQFFm4r7Uho9GSPW+CrepQU2Z1aI FBlqfZj+wVOLitpeNqze =79L+ -----END PGP SIGNATURE----- --Apple-Mail=_641C2192-3CD7-4E25-B1D7-F00B73C5AFA3-- From owner-freebsd-testing@FreeBSD.ORG Thu Mar 26 08:12:48 2015 Return-Path: Delivered-To: freebsd-testing@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 14E7B2F4; Thu, 26 Mar 2015 08:12:48 +0000 (UTC) Received: from mail-la0-x233.google.com (mail-la0-x233.google.com [IPv6:2a00:1450:4010:c03::233]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 82AEFF4A; Thu, 26 Mar 2015 08:12:47 +0000 (UTC) Received: by labe2 with SMTP id e2so39198737lab.3; Thu, 26 Mar 2015 01:12:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=gMMvSyGSI7z+Zoabnwo8vrQpsmZxvQDjgP0SGRYGM7Q=; b=bh0fC3q5g2p03B0TmX/KI9L6Ad7AZfawrSxKjOJWzEBzEUygJKtFejIVMoeaZKGzMJ 4T5yIIaYBynTXeNWO9bkijsijsuvATE5n/M9xRm7okkciONmOyP2wDAZmmCl54de8Rog Ao3SRFAyyjJFEXUD1L98rPUwZsRVRU/ppjnwYtKAKs4c/iIfutUEdgNfmrZqn+cSpogN XYzauWBaJP7mCQXERVQICdTi8QytWqR37QxDt+AvoBBZaUR5d1frO1kiz8DhdPXz159m Fa5pdOtp04AvTNDtIIw4P/mj056IQkmcuMUA4HLUSM7cqYpPHHHjE8BugPVLIsMTD3G/ GepQ== MIME-Version: 1.0 X-Received: by 10.152.6.71 with SMTP id y7mr12071184lay.116.1427357565563; Thu, 26 Mar 2015 01:12:45 -0700 (PDT) Sender: crodr001@gmail.com Received: by 10.112.108.168 with HTTP; Thu, 26 Mar 2015 01:12:45 -0700 (PDT) In-Reply-To: References: <1857A2A3-0C19-4F52-BCAF-6C72FE7D8DF3@FreeBSD.org> Date: Thu, 26 Mar 2015 01:12:45 -0700 X-Google-Sender-Auth: 60bBjmpzhI5JM2RKs5w61nHOFNY Message-ID: Subject: Re: Failed to build with external toolchain From: Craig Rodrigues To: Warner Losh Content-Type: text/plain; charset=ISO-8859-1 X-Content-Filtered-By: Mailman/MimeDel 2.1.18-1 Cc: "freebsd-testing@freebsd.org" , freebsd-toolchain@freebsd.org X-BeenThere: freebsd-testing@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Testing on FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 Mar 2015 08:12:48 -0000 On Tue, Mar 24, 2015 at 8:39 PM, Warner Losh wrote: > > > No. The in-tree gcc doesn't grok --sysroot. > > We assume that version gcc 4.2.1 is special and our in-tree compiler > elsewhere, > so please add a check for that and just go ahead and duplicate those two > lines. > > Eg > > +.else if ${COMPILER_VERSION} > 40201 > +XCFLAGS+= --sysroot=${WORLDTMP} ${BFLAGS} > +XCXXFLAGS+= --sysroot=${WORLDTMP} ${BFLAGS} > .endif > > The following worked for me. Is it OK to commit? Index: Makefile.inc1 =================================================================== --- Makefile.inc1 (revision 280353) +++ Makefile.inc1 (working copy) @@ -375,10 +375,14 @@ .endif .if defined(X_COMPILER_TYPE) && ${X_COMPILER_TYPE} == gcc XCFLAGS+= -isystem ${WORLDTMP}/usr/include -L${WORLDTMP}/usr/lib XCXXFLAGS+= -I${WORLDTMP}/usr/include/c++/v1 -std=gnu++11 -L${WORLDTMP}/../lib/libc++ DEPFLAGS+= -I${WORLDTMP}/usr/include/c++/v1 +.if ${COMPILER_VERSION} > 40201 +XCFLAGS+= --sysroot=${WORLDTMP} ${BFLAGS} +XCXXFLAGS+= --sysroot=${WORLDTMP} ${BFLAGS} +.endif .else TARGET_ABI?= unknown TARGET_TRIPLE?= ${TARGET_ARCH:C/amd64/x86_64/}-${TARGET_ABI}-freebsd11.0 XCFLAGS+= -target ${TARGET_TRIPLE} XCFLAGS+= --sysroot=${WORLDTMP} ${BFLAGS} -- Craig From owner-freebsd-testing@FreeBSD.ORG Thu Mar 26 18:47:21 2015 Return-Path: Delivered-To: freebsd-testing@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 610294E6 for ; Thu, 26 Mar 2015 18:47:21 +0000 (UTC) Received: from mail-pa0-f41.google.com (mail-pa0-f41.google.com [209.85.220.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 270497FB for ; Thu, 26 Mar 2015 18:47:20 +0000 (UTC) Received: by padcy3 with SMTP id cy3so70984174pad.3 for ; Thu, 26 Mar 2015 11:47:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:subject:mime-version:content-type:from :in-reply-to:date:cc:message-id:references:to; bh=0ElUQpL8X92qD8gzZFUaPzJ/155Xxu/s0Dv7DbIVXqI=; b=Xm7dnr1kUfWOSmK3ZGhsU9L9l2HQS1Q6rd4cNj4OcNEe858dfkVs2B84y6Ycnaxoz+ EMzFM7cWUIvpZJO+JDzJr1NKKgNgBdUrj6YCtFkfvlNXfyxOXZY9df2s+sfUGsw6iFvq g9Pa5RDob8H8pSFk8XHdos/70fOrTZDmCFjmMnl0cCs5NpTim+MUOr7+iEy7nu3VWQTd +E+/bFy/sqAuDNWCqN6hUmzCa8MyrHmPeF/Eslhk7TZhiIJFS0LDJ+SU8xrVrS980iim EcoN9I6pwg9s63ymqwl++sZGBPPNgBtzBbnHhU9zd6X6qe8KuGH21cTq1NRIbed1Lx0D gy6g== X-Gm-Message-State: ALoCoQnWriYwlL7nWcytCGopb5viFxrxLykrWftHPZsM8qjmPC0hIXIQ0m5C8L08mGAhKLWjPfoB X-Received: by 10.68.113.161 with SMTP id iz1mr28976698pbb.30.1427395633669; Thu, 26 Mar 2015 11:47:13 -0700 (PDT) Received: from [10.64.25.105] ([69.53.236.236]) by mx.google.com with ESMTPSA id pr1sm6290423pbc.66.2015.03.26.11.47.12 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 26 Mar 2015 11:47:12 -0700 (PDT) Sender: Warner Losh Subject: Re: Failed to build with external toolchain Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2070.6\)) Content-Type: multipart/signed; boundary="Apple-Mail=_53C848BF-B03D-4A9E-BD33-490E9A632FF2"; protocol="application/pgp-signature"; micalg=pgp-sha512 X-Pgp-Agent: GPGMail 2.5b6 From: Warner Losh In-Reply-To: Date: Thu, 26 Mar 2015 12:47:26 -0600 Message-Id: <1A90C16A-1A23-4EFD-BB61-0E956C8CB49D@bsdimp.com> References: <1857A2A3-0C19-4F52-BCAF-6C72FE7D8DF3@FreeBSD.org> To: Craig Rodrigues X-Mailer: Apple Mail (2.2070.6) Cc: "freebsd-testing@freebsd.org" , freebsd-toolchain@freebsd.org X-BeenThere: freebsd-testing@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Testing on FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 Mar 2015 18:47:21 -0000 --Apple-Mail=_53C848BF-B03D-4A9E-BD33-490E9A632FF2 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=windows-1252 > On Mar 26, 2015, at 2:12 AM, Craig Rodrigues = wrote: >=20 >=20 >=20 > On Tue, Mar 24, 2015 at 8:39 PM, Warner Losh wrote: >=20 >=20 > No. The in-tree gcc doesn=92t grok =97sysroot. >=20 > We assume that version gcc 4.2.1 is special and our in-tree compiler = elsewhere, > so please add a check for that and just go ahead and duplicate those = two lines. >=20 > Eg >=20 > +.else if ${COMPILER_VERSION} > 40201 > +XCFLAGS+=3D --sysroot=3D${WORLDTMP} ${BFLAGS} > +XCXXFLAGS+=3D --sysroot=3D${WORLDTMP} ${BFLAGS} > .endif >=20 >=20 > The following worked for me. Is it OK to commit? >=20 > Index: Makefile.inc1 > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > --- Makefile.inc1 (revision 280353) > +++ Makefile.inc1 (working copy) > @@ -375,10 +375,14 @@ > .endif > .if defined(X_COMPILER_TYPE) && ${X_COMPILER_TYPE} =3D=3D gcc > XCFLAGS+=3D -isystem ${WORLDTMP}/usr/include = -L${WORLDTMP}/usr/lib > XCXXFLAGS+=3D -I${WORLDTMP}/usr/include/c++/v1 -std=3Dgnu++11 = -L${WORLDTMP}/../lib/libc++ > DEPFLAGS+=3D -I${WORLDTMP}/usr/include/c++/v1 > +.if ${COMPILER_VERSION} > 40201 > +XCFLAGS+=3D --sysroot=3D${WORLDTMP} ${BFLAGS} > +XCXXFLAGS+=3D --sysroot=3D${WORLDTMP} ${BFLAGS} > +.endif > .else > TARGET_ABI?=3D unknown > TARGET_TRIPLE?=3D = ${TARGET_ARCH:C/amd64/x86_64/}-${TARGET_ABI}-freebsd11.0 > XCFLAGS+=3D -target ${TARGET_TRIPLE} > XCFLAGS+=3D --sysroot=3D${WORLDTMP} ${BFLAGS} OK. I have a bit of egg on my face=85 The test is for X_COMPILER_TYPE, so COMPILER_VERSION isn=92t relevant. = It=92s always outside the tree. So your original patch is correct. Please go ahead and commit that and = accept my apologies for the wild goose chase. Warner --Apple-Mail=_53C848BF-B03D-4A9E-BD33-490E9A632FF2 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQIcBAEBCgAGBQJVFFQ+AAoJEGwc0Sh9sBEAyi0QAKD7MsHe58oHThFw0Du2jmRi 9Y2qpVuaWa3RmHVRb1cZewowtxWOIGnaFE8MWWSd8S0PE3gaO8nOzzUQV9FndMHp FETLvRX7bL0I+sJ/nZwQt4Sb4oOH4hv5KgoeXz/aShO5MKdAFOp7CjG6iLlkpGwg qts/d313jeeqkPBiwtAMhtXzVIW8LALHF0YyEE6bGlyO9k9f9ZLCVgZmFF+sNN1x S+I9qGNI3Oum3eTJ36uHMQmteJbKjIf1HgqMlhlms0UAJRUcKBlKQuqMExRGCtu/ 1AWL66smfYe2ofFutsFlmTVSXs/yNdDz0dwpbcYx2OgUMEH2h6ngNtRIgXyRj6fK eIouQp5/WKrMg6dgVibkPX923MOfG2xAJ3YmhlM13kq+s6ilocJ4GrZ75zDitdAg bDabyuMMRU2CF2qWQgDKPo69ICEcORrnG6rC5gjJNjR+c0F6LUejfYnxYs8Sui81 AMhGRBWv8I6V6vPC0jX1BamsM7dtTD+u0OKVFlc8GaiZJteRrk+U/WhFD7rHNxcC +L4t6zjh/2q/fXkxTfIPXWqzsAAPBa2KI/EOPvwxebIy/bjbz3g08fzZzAB/sDdy Olty3pnjETZbnsKxI9VVgJzc+DIumRjlnJyIgVWUhIEaFfEabQRmKobIdAzdp/ON /9rdAMWvh8v/9Qz92EIX =t/wk -----END PGP SIGNATURE----- --Apple-Mail=_53C848BF-B03D-4A9E-BD33-490E9A632FF2-- From owner-freebsd-testing@FreeBSD.ORG Fri Mar 27 00:39:55 2015 Return-Path: Delivered-To: freebsd-testing@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id E0E64A1A; Fri, 27 Mar 2015 00:39:54 +0000 (UTC) Received: from mail-la0-x233.google.com (mail-la0-x233.google.com [IPv6:2a00:1450:4010:c03::233]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 58690388; Fri, 27 Mar 2015 00:39:54 +0000 (UTC) Received: by labto5 with SMTP id to5so59090870lab.0; Thu, 26 Mar 2015 17:39:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=+zVipZEMxyzje19wJgm8QnlC9QlpwCB2DR7uG828yz0=; b=TgA2Yz2y07cc6qOQJ8wKlPGQ8cDZ9ymomWaMjUxKVpbkgVTmyv5Yh+EMZZ41HzkiYF XEuuzZA01skWhZbb+xx+QA6DCm7uEdVn/UzE+niubd0WQd0vws8s3y33UHEtMp0xv7E5 9ATUN/3Fkjno9i3+ev0OqUa23Zz4wsEVqI8FwiX75UaiBuEe+bCXrJpoXOGg78t8KCTU rpuennbaEno62CXYhlOF+LsnD/v0o8Dnr7ztVTOZ5RUb9joNTAbY9QqFpn76BAjjhYWj lkYNW/rFbl7dzdt0bp1SfG+H+XN2JmYD1dsReYqVFMJEeODTjCqKwzkN4hZlxzGSjFHG rsRQ== MIME-Version: 1.0 X-Received: by 10.112.146.70 with SMTP id ta6mr15875326lbb.59.1427416790989; Thu, 26 Mar 2015 17:39:50 -0700 (PDT) Sender: crodr001@gmail.com Received: by 10.112.108.168 with HTTP; Thu, 26 Mar 2015 17:39:50 -0700 (PDT) In-Reply-To: <1A90C16A-1A23-4EFD-BB61-0E956C8CB49D@bsdimp.com> References: <1857A2A3-0C19-4F52-BCAF-6C72FE7D8DF3@FreeBSD.org> <1A90C16A-1A23-4EFD-BB61-0E956C8CB49D@bsdimp.com> Date: Thu, 26 Mar 2015 17:39:50 -0700 X-Google-Sender-Auth: gMJikbBQ6KlcTCkMQfJyA7WT6N4 Message-ID: Subject: Re: Failed to build with external toolchain From: Craig Rodrigues To: Warner Losh Content-Type: text/plain; charset=ISO-8859-1 X-Content-Filtered-By: Mailman/MimeDel 2.1.18-1 Cc: "freebsd-testing@freebsd.org" , freebsd-toolchain@freebsd.org X-BeenThere: freebsd-testing@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Testing on FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 Mar 2015 00:39:55 -0000 On Thu, Mar 26, 2015 at 11:47 AM, Warner Losh wrote: > > > On Mar 26, 2015, at 2:12 AM, Craig Rodrigues > wrote: > > OK. I have a bit of egg on my face... > > The test is for X_COMPILER_TYPE, so COMPILER_VERSION isn't relevant. It's > always outside the tree. > So your original patch is correct. Please go ahead and commit that and > accept my apologies for the wild goose chase. > Okee dokee, I committed my original patch: http://lists.freebsd.org/pipermail/svn-src-all/2015-March/101492.html No worries about geese. External toolchain support is important to the future of FreeBSD, and I appreciate your work. I'm just trying to help as best I can by testing things, reporting problems, and fixing things where I can. -- Craig From owner-freebsd-testing@FreeBSD.ORG Sat Mar 28 04:26:17 2015 Return-Path: Delivered-To: freebsd-testing@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 05AE7E27; Sat, 28 Mar 2015 04:26:17 +0000 (UTC) Received: from mail-lb0-x231.google.com (mail-lb0-x231.google.com [IPv6:2a00:1450:4010:c04::231]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 78514A42; Sat, 28 Mar 2015 04:26:16 +0000 (UTC) Received: by lbbug6 with SMTP id ug6so76259007lbb.3; Fri, 27 Mar 2015 21:26:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=4b6gUUQjtzA0ePVC8D8lFrIXvvNnGc9Dnkk9KQDfG0A=; b=I0/vz5LQ97LoE6thFDkGZgQLUNoE9ukh3Ab8/B5uBvmSW0EC4uazW3hWLZFJbR9O1E TT+RvQf8ZrL35JPfT3PFLqs0V3TM+qt9ikNy7tweD9vPRwx4Gn1U4UIFXorr9lOM8Fr4 ashyuTvGjInInJmmYZFUDCRHZYn0cNVHLhRBV8oa/JI7WSB4xfGPqGX3mF4Irp57T1wF +N1tJ5nlzBKbhPFPqc0NrUPs6FFTMQgsRZOQ3aYqxiqWQn1tb/udj0juXZa9mM2Tt93C di8ZwZeaEw27pX+AIjgIgRdGYUUiHUMfr5JMrD/A+c7c1Iix2lDia+GE0OPa0Bwy8pjY +3bQ== MIME-Version: 1.0 X-Received: by 10.112.170.132 with SMTP id am4mr20044985lbc.89.1427516774253; Fri, 27 Mar 2015 21:26:14 -0700 (PDT) Sender: crodr001@gmail.com Received: by 10.112.108.168 with HTTP; Fri, 27 Mar 2015 21:26:14 -0700 (PDT) In-Reply-To: <5F90BE99-E82C-4444-9E4C-5963B40AA3B0@FreeBSD.org> References: <5F90BE99-E82C-4444-9E4C-5963B40AA3B0@FreeBSD.org> Date: Fri, 27 Mar 2015 21:26:14 -0700 X-Google-Sender-Auth: 1xzIwwiPc1pnDYDnuJXFlBnYn6E Message-ID: Subject: Re: CROSS_TOOLCHAIN=amd64-gcc fails to build after clang 3.6.0 import From: Craig Rodrigues To: Dimitry Andric Content-Type: text/plain; charset=ISO-8859-1 X-Content-Filtered-By: Mailman/MimeDel 2.1.18-1 Cc: "freebsd-testing@freebsd.org" , freebsd-toolchain@freebsd.org X-BeenThere: freebsd-testing@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Testing on FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 28 Mar 2015 04:26:17 -0000 On Mon, Mar 23, 2015 at 12:12 AM, Dimitry Andric wrote: > On 23 Mar 2015, at 01:49, Craig Rodrigues wrote: > > > > Hi, > > > > I tried to build HEAD with gcc 4.9.1 after the latest clang 3.6.0 import, > > and am getting > > new build failures related to C++ such as: > > > > > /builds/FreeBSD_HEAD_external_toolchain_gcc/obj/builds/FreeBSD_HEAD_external_toolchain_gcc/tmp/usr/include/c++/v1/type_traits:881:87: > > error: use of deleted function > > 'clang::Sema::TypoExprState::TypoExprState(const > > clang::Sema::TypoExprState&)' > > > > > sizeof(__is_convertible_imp::__test<_T2>(__is_convertible_imp::__source<_T1>())) > > == 1 > > > > See full build logs here: > > > https://jenkins.freebsd.org/job/FreeBSD_HEAD_external_toolchain_gcc/21/console > > > > Any ideas what the problem might be? > > Yes, this is a bug in libc++, when compiling it with newer versions of > gcc. I reported this upstream some time ago: https://llvm.org/PR22771 > > Still haven't had enough time to test Eric Fiselier's patch for it. I > hope I see the bottom of my TODO list anytime soon... > > -Dimitry > > Eric Fiselier's patch in http://reviews.llvm.org/D8461 works for me. I could compile libc++ with gcc 4.9 with this patch. There are other gcc 4.9 compilation problems, but I will report those separately. -- Craig From owner-freebsd-testing@FreeBSD.ORG Sat Mar 28 21:34:12 2015 Return-Path: Delivered-To: freebsd-testing@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id CBB49B80; Sat, 28 Mar 2015 21:34:12 +0000 (UTC) Received: from mail-lb0-x22a.google.com (mail-lb0-x22a.google.com [IPv6:2a00:1450:4010:c04::22a]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 3A66FC7A; Sat, 28 Mar 2015 21:34:12 +0000 (UTC) Received: by lbbug6 with SMTP id ug6so84709600lbb.3; Sat, 28 Mar 2015 14:34:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:date:message-id:subject:from:to:content-type; bh=OgbkIbOFWrdqPE+apjwN29yOXJwS8M0SP6KaRwvLeCs=; b=qvZNuq/k/uOKcUFa23WYCPHQtJTPvcZ3wzNYft8J8bg5YgjSqNhCJKdvJ/vgMQly6W yQqnKJ+AAfuAwKXgvbru/AhPed2RqQ1R+wEen2/aOm8jNcBrK+Pn0oDo4a9c5/l07kKy nLqTFlLuhc7ELmZKLmpkANNOxnyI3lw3ZBFU7CqQIYqqXA0gbDNSRHKM5nskCCLgRtQK YmmPE+osbxBW6zs5uvjFIuZ4G9Bk2b5u/Rc2c1MJoQS596FtQGxdKK6Y75wg/gH/miKW 2NFD3d9Os2t5qvO9BWogtgTN6AgE/J29JNmt2hXjM3yXlALVwf9fxVfNO0MeMMib6Wqj cCAQ== MIME-Version: 1.0 X-Received: by 10.112.223.7 with SMTP id qq7mr22810094lbc.81.1427578450162; Sat, 28 Mar 2015 14:34:10 -0700 (PDT) Sender: crodr001@gmail.com Received: by 10.112.108.168 with HTTP; Sat, 28 Mar 2015 14:34:10 -0700 (PDT) Date: Sat, 28 Mar 2015 14:34:10 -0700 X-Google-Sender-Auth: 4JG9f52w8XTCZXdAbPe68XHCrho Message-ID: Subject: Failed to build rescue with gcc 4.9 From: Craig Rodrigues To: freebsd-toolchain@freebsd.org, "freebsd-testing@freebsd.org" Content-Type: text/plain; charset=ISO-8859-1 X-Content-Filtered-By: Mailman/MimeDel 2.1.18-1 X-BeenThere: freebsd-testing@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Testing on FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 28 Mar 2015 21:34:13 -0000 Hi, The build host VM that I used was FreeBSD 10.1-RELEASE, amd64. I took this patch for libc++ and applied it to my tree: http://reviews.llvm.org/D8461 I used this script to build with gcc 4.9: https://github.com/freebsd/freebsd-ci/blob/master/scripts/build/cross-build.sh Building rescue failed. You can see the full build log here: https://jenkins.freebsd.org/job/FreeBSD_HEAD_external_toolchain_gcc/26/console The relevant section seems to be this: --- rescue --- /usr/local/bin/x86_64-portbld-freebsd10.0-gcc -isystem /builds/FreeBSD_HEAD_external_toolchain_gcc/obj/builds/FreeBSD_HEAD_external_toolchain_gcc/tmp/usr/include -L/builds/FreeBSD_HEAD_external_toolchain_gcc/obj/builds/FreeBSD_HEAD_external_toolchain_gcc/tmp/usr/lib --sysroot=/builds/FreeBSD_HEAD_external_toolchain_gcc/obj/builds/FreeBSD_HEAD_external_toolchain_gcc/tmp -B/usr/local/x86_64-freebsd/bin/ -static -o rescue rescue.o cat.lo chflags.lo chio.lo chmod.lo cp.lo date.lo dd.lo df.lo echo.lo ed.lo expr.lo getfacl.lo hostname.lo kenv.lo kill.lo ln.lo ls.lo mkdir.lo mv.lo pkill.lo ps.lo pwd.lo realpath.lo rm.lo rmdir.lo setfacl.lo sh.lo sleep.lo stty.lo sync.lo test.lo rcp.lo csh.lo badsect.lo camcontrol.lo ccdconfig.lo clri.lo devfs.lo dmesg.lo dump.lo dumpfs.lo dumpon.lo fsck.lo fsck_ffs.lo fsck_msdosfs.lo fsdb.lo fsirand.lo gbde.lo geom.lo ifconfig.lo init.lo kldconfig.lo kldload.lo kldstat.lo kldunload.lo ldconfig.lo md5.lo mdconfig.lo mdmfs.lo mknod.lo mount.lo mount_cd9660.lo mount_msdosfs.lo mount_nfs.lo mount_nullfs.lo mount_udf.lo mount_unionfs.lo newfs.lo newfs_msdos.lo nos-tun.lo ping.lo reboot.lo restore.lo rcorder.lo route.lo routed.lo rtquery.lo rtsol.lo savecore.lo spppcontrol.lo swapon.lo sysctl.lo tunefs.lo umount.lo atmconfig.lo ping6.lo ipf.lo zfs.lo zpool.lo bsdlabel.lo fdisk.lo dhclient.lo head.lo mt.lo nc.lo sed.lo tail.lo tee.lo gzip.lo bzip2.lo less.lo xz.lo tar.lo vi.lo id.lo zdb.lo chroot.lo chown.lo /builds/FreeBSD_HEAD_external_toolchain_gcc/obj/builds/FreeBSD_HEAD_external_toolchain_gcc/rescue/rescue/../librescue/exec.o /builds/FreeBSD_HEAD_external_toolchain_gcc/obj/builds/FreeBSD_HEAD_external_toolchain_gcc/rescue/rescue/../librescue/getusershell.o /builds/FreeBSD_HEAD_external_toolchain_gcc/obj/builds/FreeBSD_HEAD_external_toolchain_gcc/rescue/rescue/../librescue/login_class.o /builds/FreeBSD_HEAD_external_toolchain_gcc/obj/builds/FreeBSD_HEAD_external_toolchain_gcc/rescue/rescue/../librescue/popen.o /builds/FreeBSD_HEAD_external_toolchain_gcc/obj/builds/FreeBSD_HEAD_external_toolchain_gcc/rescue/rescue/../librescue/rcmdsh.o /builds/FreeBSD_HEAD_external_toolchain_gcc/obj/builds/FreeBSD_HEAD_external_toolchain_gcc/rescue/rescue/../librescue/sysctl.o /builds/FreeBSD_HEAD_external_toolchain_gcc/obj/builds/FreeBSD_HEAD_external_toolchain_gcc/rescue/rescue/../librescue/system.o -lcrypt -ledit -ljail -lkvm -ll -ltermcapw -lutil -lxo -lalias -lcam -lncursesw -ldevstat -lipsec -llzma -lavl -lzpool -lzfs_core -lzfs -lnvpair -lpthread -luutil -lumem -lgeom -lbsdxml -lkiconv -lmt -lsbuf -lufs -lz -lbz2 -larchive -lcrypto -lmd -lm cat.lo: file not recognized: File truncated collect2: error: ld returned 1 exit status *** [rescue] Error code 1 make[5]: stopped in /builds/FreeBSD_HEAD_external_toolchain_gcc/obj/builds/FreeBSD_HEAD_external_toolchain_gcc/rescue/rescue 1 error I double checked. cat.lo is not a truncated file. # ls -l cat.lo ; file cat.lo -rw-r--r-- 1 jenkins wheel 13112 Mar 28 21:17 cat.lo cat.lo: ELF 64-bit LSB relocatable, x86-64, version 1 (FreeBSD), stripped Any ideas? -- Craig From owner-freebsd-testing@FreeBSD.ORG Sat Mar 28 22:53:54 2015 Return-Path: Delivered-To: freebsd-testing@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 17AFE3BD; Sat, 28 Mar 2015 22:53:54 +0000 (UTC) Received: from mail-la0-x236.google.com (mail-la0-x236.google.com [IPv6:2a00:1450:4010:c03::236]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 8BDF06C7; Sat, 28 Mar 2015 22:53:53 +0000 (UTC) Received: by labe2 with SMTP id e2so93762702lab.3; Sat, 28 Mar 2015 15:53:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:content-type; bh=4I/yP7elJuvILz1n7cnBqDvVD3qop+0TZg+qpf9x0YM=; b=S7QAA+be+bLigQnbX98+doBmKyrPq0g4ny06Na65QoyfIYz6SvWM5BV9SPGlVUF20r j5v+Yd+Tkyrq/VuBiXC/SuSp506jYDe/+AqT0Ksa/KbJRBeFu0v2rJcoVun64iqeaNco 3/xsscKMtXxZtdOHllJTljaxUO2odSok0zfZn9rDN5wOki9LWUzECj49OOetl7xnIsLp RdsLxhGPQgJGL3BEhuZ9p1YqnU4F2wiIIpcSlkBWMXCqIN/eHLT4ogxfxcj3KA9SoGr6 42Tzjh0V4LdVah3q/aBeyIDs3y3PmMHaopvSqWuZKdu4Y617NeQGKCXMJg1dTMDjFz7o cRUQ== MIME-Version: 1.0 X-Received: by 10.112.140.38 with SMTP id rd6mr22774465lbb.116.1427583231652; Sat, 28 Mar 2015 15:53:51 -0700 (PDT) Sender: crodr001@gmail.com Received: by 10.112.108.168 with HTTP; Sat, 28 Mar 2015 15:53:51 -0700 (PDT) In-Reply-To: References: Date: Sat, 28 Mar 2015 15:53:51 -0700 X-Google-Sender-Auth: Z43gx8DvnBJmElDzd8RODXngl5c Message-ID: Subject: Re: Failed to build rescue with gcc 4.9 From: Craig Rodrigues To: freebsd-toolchain@freebsd.org, "freebsd-testing@freebsd.org" Content-Type: text/plain; charset=ISO-8859-1 X-Content-Filtered-By: Mailman/MimeDel 2.1.18-1 X-BeenThere: freebsd-testing@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Testing on FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 28 Mar 2015 22:53:54 -0000 On Sat, Mar 28, 2015 at 2:34 PM, Craig Rodrigues wrote: > > > I double checked. cat.lo is not a truncated file. > # ls -l cat.lo ; file cat.lo > -rw-r--r-- 1 jenkins wheel 13112 Mar 28 21:17 cat.lo > cat.lo: ELF 64-bit LSB relocatable, x86-64, version 1 (FreeBSD), stripped > > Hmm, so file reports that it is an ELF file, but readelf barfs on the file. I have the file here for anyone who wants to look at it: http://people.freebsd.org/~rodrigc/cat.lo # file cat.lo ; readelf -a cat.lo cat.lo: ELF 64-bit LSB relocatable, x86-64, version 1 (FreeBSD), stripped readelf: Error: Unable to read in 0x40 bytes of section headers ELF Header: Magic: 7f 45 4c 46 02 01 01 09 00 00 00 00 00 00 00 00 Class: ELF64 Data: 2's complement, little endian Version: 1 (current) OS/ABI: UNIX - FreeBSD ABI Version: 0 Type: REL (Relocatable file) Machine: Advanced Micro Devices X86-64 Version: 0x1 Entry point address: 0x0 Start of program headers: 0 (bytes into file) Start of section headers: 51092930964640 (bytes into file) Flags: 0x0 Size of this header: 64 (bytes) Size of program headers: 0 (bytes) Number of program headers: 0 Size of section headers: 64 (bytes) Number of section headers: 19 Section header string table index: 16 readelf: Error: Unable to read in 0x4c0 bytes of section headers readelf: Error: Section headers are not available! Abort trap (core dumped) -- Craig From owner-freebsd-testing@FreeBSD.ORG Sat Mar 28 23:05:48 2015 Return-Path: Delivered-To: freebsd-testing@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 7161B859; Sat, 28 Mar 2015 23:05:48 +0000 (UTC) Received: from mail-la0-x22b.google.com (mail-la0-x22b.google.com [IPv6:2a00:1450:4010:c03::22b]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id CF169847; Sat, 28 Mar 2015 23:05:47 +0000 (UTC) Received: by labto5 with SMTP id to5so94212365lab.0; Sat, 28 Mar 2015 16:05:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:date:message-id:subject:from:to:content-type; bh=L/LsqcRVtBWz+wxvMpth4zMtU4ZX03xxs+kpAhXx9u0=; b=tShmgGrUo7ujrhkFFlNNhhLHd0cCBLxST9IsQ14TkGix/4614qx+mhyK3lfMB2ggG7 QF7yjtGzDHpGEqp5JZnAPv4ed20UkyBRlRRGroiAvjQyc5xPdlZZwXb9KaAIdkYD1dun mgUGE7WZ3tGmCFrObVqb3GLIIULe+o/0b5zX02dujiy5+MThDRjrfyqDmdDtM0Lwgl+k 2PDVYWm5b6yPV17gG/2UqBno76Nu2lMRAbbTOTFXAWDKBm+Mhi/i9Hfgp3My3sfCDmRy WMpcAeU8z07+hCtLs64HGDZKU5RGdJpSMza5mDYnIPr68yOc6KjDsSHoxnlCO8MKI+OF ndZw== MIME-Version: 1.0 X-Received: by 10.112.223.7 with SMTP id qq7mr23016607lbc.81.1427583945855; Sat, 28 Mar 2015 16:05:45 -0700 (PDT) Sender: crodr001@gmail.com Received: by 10.112.108.168 with HTTP; Sat, 28 Mar 2015 16:05:45 -0700 (PDT) Date: Sat, 28 Mar 2015 16:05:45 -0700 X-Google-Sender-Auth: -zFerbF32r6NNSrjCGcuQAC8M0E Message-ID: Subject: Fails to build sys/i386/boot2 with gcc 4.9 From: Craig Rodrigues To: freebsd-toolchain@freebsd.org, "freebsd-testing@freebsd.org" Content-Type: text/plain; charset=ISO-8859-1 X-Content-Filtered-By: Mailman/MimeDel 2.1.18-1 X-BeenThere: freebsd-testing@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Testing on FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 28 Mar 2015 23:05:48 -0000 Hi, To work around the problems build rescue, this time I used a build host running FreeBSD-CURRENT at svn revision r280353 I took this patch for libc++ and applied it to my tree: http://reviews.llvm.org/D8461 I used this script to build with gcc 4.9: https://github.com/freebsd/freebsd-ci/blob/master/scripts/build/cross-build.sh Buildling sys/i386/boot2 failed: ===> sys/boot/i386/boot2 (all) objcopy -S -O binary boot1.out boot1 dd if=/dev/zero of=boot2.ldr bs=512 count=1 1+0 records in 1+0 records out 512 bytes transferred in 0.000034 secs (14989607 bytes/sec) /usr/local/bin/x86_64-portbld-freebsd11.0-gcc -isystem /usr/obj/opt2/branches/head/tmp/usr/include -L/usr/obj/opt2/branches/head/tmp/usr/lib --sysroot=/usr/obj/opt2/branches/head/tmp -B/usr/local/x86_64-freebsd/bin/ -fomit-frame-pointer -mrtd -mregparm=3 -DUSE_XREAD -DUFS1_AND_UFS2 -DFLAGS=0x80 -DSIOPRT=0x3f8 -DSIOFMT=0x3 -DSIOSPD=9600 -I/opt2/branches/head/sys/boot/i386/boot2/../../common -I/opt2/branches/head/sys/boot/i386/boot2/../btx/lib -I. -Wall -Waggregate-return -Wbad-function-cast -Wcast-align -Wmissing-declarations -Wmissing-prototypes -Wnested-externs -Wpointer-arith -Wshadow -Wstrict-prototypes -Wwrite-strings -Winline -march=i386 -ffreestanding -mno-mmx -mno-3dnow -mno-sse -mno-sse2 -mno-sse3 -msoft-float -m32 -std=gnu99 -Os -fno-guess-branch-probability -fno-unit-at-a-time --param max-inline-insns-single=100 -mpreferred-stack-boundary=2 -S -o boot2.s.tmp /opt2/branches/head/sys/boot/i386/boot2/boot2.c /opt2/branches/head/sys/boot/i386/boot2/boot2.c: In function 'parse': /opt2/branches/head/sys/boot/i386/boot2/boot2.c:484:6: warning: suggest parentheses around assignment used as truth value [-Wparentheses] if (k = ep - arg) { ^ /opt2/branches/head/sys/boot/i386/boot2/boot2.c: In function 'load': /opt2/branches/head/sys/boot/i386/boot2/boot2.c:187:1: warning: inlining failed in call to 'xfsread': call is unlikely and code size would grow [-Winline] xfsread(ufs_ino_t inode, void *buf, size_t nbyte) ^ /opt2/branches/head/sys/boot/i386/boot2/boot2.c:334:9: warning: called from here [-Winline] if (xfsread(ino, &hdr, sizeof(hdr))) ^ /opt2/branches/head/sys/boot/i386/boot2/boot2.c:187:1: warning: inlining failed in call to 'xfsread': call is unlikely and code size would grow [-Winline] xfsread(ufs_ino_t inode, void *buf, size_t nbyte) ^ /opt2/branches/head/sys/boot/i386/boot2/boot2.c:341:6: warning: called from here [-Winline] if (xfsread(ino, p, hdr.ex.a_text)) ^ /opt2/branches/head/sys/boot/i386/boot2/boot2.c:187:1: warning: inlining failed in call to 'xfsread': call is unlikely and code size would grow [-Winline] xfsread(ufs_ino_t inode, void *buf, size_t nbyte) ^ /opt2/branches/head/sys/boot/i386/boot2/boot2.c:344:6: warning: called from here [-Winline] if (xfsread(ino, p, hdr.ex.a_data)) ^ /opt2/branches/head/sys/boot/i386/boot2/boot2.c:187:1: warning: inlining failed in call to 'xfsread': call is unlikely and code size would grow [-Winline] xfsread(ufs_ino_t inode, void *buf, size_t nbyte) ^ /opt2/branches/head/sys/boot/i386/boot2/boot2.c:349:10: warning: called from here [-Winline] if (xfsread(ino, ep + j, sizeof(ep[0]))) ^ /opt2/branches/head/sys/boot/i386/boot2/boot2.c:187:1: warning: inlining failed in call to 'xfsread': call is unlikely and code size would grow [-Winline] xfsread(ufs_ino_t inode, void *buf, size_t nbyte) ^ /opt2/branches/head/sys/boot/i386/boot2/boot2.c:357:10: warning: called from here [-Winline] if (xfsread(ino, p, ep[i].p_filesz)) ^ /opt2/branches/head/sys/boot/i386/boot2/boot2.c:187:1: warning: inlining failed in call to 'xfsread': call is unlikely and code size would grow [-Winline] xfsread(ufs_ino_t inode, void *buf, size_t nbyte) ^ /opt2/branches/head/sys/boot/i386/boot2/boot2.c:365:10: warning: called from here [-Winline] if (xfsread(ino, &es, sizeof(es))) ^ /opt2/branches/head/sys/boot/i386/boot2/boot2.c:187:1: warning: inlining failed in call to 'xfsread': call is unlikely and code size would grow [-Winline] xfsread(ufs_ino_t inode, void *buf, size_t nbyte) ^ /opt2/branches/head/sys/boot/i386/boot2/boot2.c:371:7: warning: called from here [-Winline] if (xfsread(ino, p, es[i].sh_size)) ^ sed -e '/align/d' -e '/nop/d' < boot2.s.tmp > boot2.s rm -f boot2.s.tmp /usr/local/bin/x86_64-portbld-freebsd11.0-gcc -isystem /usr/obj/opt2/branches/head/tmp/usr/include -L/usr/obj/opt2/branches/head/tmp/usr/lib --sysroot=/usr/obj/opt2/branches/head/tmp -B/usr/local/x86_64-freebsd/bin/ -m32 -c boot2.s /usr/local/bin/x86_64-portbld-freebsd11.0-gcc -isystem /usr/obj/opt2/branches/head/tmp/usr/include -L/usr/obj/opt2/branches/head/tmp/usr/lib --sysroot=/usr/obj/opt2/branches/head/tmp -B/usr/local/x86_64-freebsd/bin/ -fomit-frame-pointer -mrtd -mregparm=3 -DUSE_XREAD -DUFS1_AND_UFS2 -DFLAGS=0x80 -DSIOPRT=0x3f8 -DSIOFMT=0x3 -DSIOSPD=9600 -I/opt2/branches/head/sys/boot/i386/boot2/../../common -I/opt2/branches/head/sys/boot/i386/boot2/../btx/lib -I. -Wall -Waggregate-return -Wbad-function-cast -Wcast-align -Wmissing-declarations -Wmissing-prototypes -Wnested-externs -Wpointer-arith -Wshadow -Wstrict-prototypes -Wwrite-strings -Winline -march=i386 -ffreestanding -mno-mmx -mno-3dnow -mno-sse -mno-sse2 -mno-sse3 -msoft-float -m32 -std=gnu99 -Os -fno-guess-branch-probability -fno-unit-at-a-time --param max-inline-insns-single=100 -mpreferred-stack-boundary=2 -m32 -c /opt2/branches/head/sys/boot/i386/boot2/sio.S -o sio.o /usr/local/x86_64-freebsd/bin/ld -static -N --gc-sections -m elf_i386_fbsd -Ttext 0x2000 -o boot2.out /usr/obj/opt2/branches/head/sys/boot/i386/boot2/../btx/lib/crt0.o boot2.o sio.o objcopy -S -O binary boot2.out boot2.bin btxld -v -E 0x2000 -f bin -b /usr/obj/opt2/branches/head/sys/boot/i386/boot2/../btx/btx/btx -l boot2.ldr -o boot2.ld -P 1 boot2.bin kernel: ver=1.02 size=690 load=9000 entry=9010 map=16M pgctl=1:1 client: fmt=bin size=195f text=0 data=0 bss=0 entry=0 output: fmt=bin size=21ef text=200 data=1fef org=0 entry=0 -1007 bytes available *** Error code 1 Stop. make[6]: stopped in /opt2/branches/head/sys/boot/i386/boot2 *** Error code 1 Stop. make[5]: stopped in /opt2/branches/head/sys/boot/i386 *** Error code 1 Stop. make[4]: stopped in /opt2/branches/head/sys/boot *** Error code 1 Stop. make[3]: stopped in /opt2/branches/head/sys *** Error code 1 Stop. make[2]: stopped in /opt2/branches/head *** Error code 1 Stop. make[1]: stopped in /opt2/branches/head *** Error code 1 Stop. make: stopped in /opt2/branches/head Script done on Sat Mar 28 13:44:24 2015 -- Craig From owner-freebsd-testing@FreeBSD.ORG Sat Mar 28 23:34:08 2015 Return-Path: Delivered-To: freebsd-testing@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 560DAF15; Sat, 28 Mar 2015 23:34:08 +0000 (UTC) Received: from tensor.andric.com (unknown [IPv6:2001:7b8:3a7:1:2d0:b7ff:fea0:8c26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "tensor.andric.com", Issuer "COMODO RSA Domain Validation Secure Server CA" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 106CBB77; Sat, 28 Mar 2015 23:34:08 +0000 (UTC) Received: from [IPv6:2001:7b8:3a7::81a8:baf0:98fb:d610] (unknown [IPv6:2001:7b8:3a7:0:81a8:baf0:98fb:d610]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by tensor.andric.com (Postfix) with ESMTPSA id 6EF6F5C2E; Sun, 29 Mar 2015 00:34:00 +0100 (CET) Subject: Re: Fails to build sys/i386/boot2 with gcc 4.9 Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2070.6\)) Content-Type: multipart/signed; boundary="Apple-Mail=_7FBCFB16-3962-4838-B230-2ABD3225C862"; protocol="application/pgp-signature"; micalg=pgp-sha1 X-Pgp-Agent: GPGMail 2.5b6 From: Dimitry Andric In-Reply-To: Date: Sun, 29 Mar 2015 00:33:54 +0100 Message-Id: <20683705-0EBA-4B8F-A0CE-9C06B8003BBE@FreeBSD.org> References: To: Craig Rodrigues X-Mailer: Apple Mail (2.2070.6) Cc: "freebsd-testing@freebsd.org" , FreeBSD Toolchain X-BeenThere: freebsd-testing@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Testing on FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 28 Mar 2015 23:34:08 -0000 --Apple-Mail=_7FBCFB16-3962-4838-B230-2ABD3225C862 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii On 29 Mar 2015, at 00:05, Craig Rodrigues wrote: >=20 > To work around the problems build rescue, this time I used a build = host > running FreeBSD-CURRENT at svn revision r280353 >=20 > I took this patch for libc++ and applied it to my tree: >=20 > http://reviews.llvm.org/D8461 I've only got one minor remark left on that fix, which is that it doesn't work for gcc 4.7. Once we either say that version of gcc is just buggy and can't be helped, or have some other way of fixing the original problem, I'll import it. > I used this script to build with gcc 4.9: >=20 > = https://github.com/freebsd/freebsd-ci/blob/master/scripts/build/cross-buil= d.sh >=20 > Buildling sys/i386/boot2 failed: ... > output: fmt=3Dbin size=3D21ef text=3D200 data=3D1fef org=3D0 entry=3D0 > -1007 bytes available > *** Error code 1 Oof, this is going to be hard to fix. For some reason, boot2 is one of those programs that keeps getting worse (i.e. larger) with *each* new compiler version, be it gcc or clang! The last few times when we imported a new clang version, we had to jump through several hoops, and attempted to shrink the code again with various cleanups. Even then, we don't have a lot of headroom. If it is now also becoming a problem with gcc 4.9, we should really start looking for a more permanent solution, e.g.: * Getting rid of the 7680 byte limit (seems to be impossible?) * Rewrite most of (or all of) boot2 in assembly -Dimitry --Apple-Mail=_7FBCFB16-3962-4838-B230-2ABD3225C862 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0.27 iEYEARECAAYFAlUXOmcACgkQsF6jCi4glqOMOgCfZVgxqN6KtSCY0LxCHNtlSpfd pCkAn0jJHcKrPrKJ8l3n8MVC6dbFX+OW =ZNCv -----END PGP SIGNATURE----- --Apple-Mail=_7FBCFB16-3962-4838-B230-2ABD3225C862--