From owner-freebsd-testing@freebsd.org Sun Jul 26 14:44:21 2015 Return-Path: Delivered-To: freebsd-testing@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 4DE159ABDEA for ; Sun, 26 Jul 2015 14:44:21 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 3A05B107 for ; Sun, 26 Jul 2015 14:44:21 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id t6QEiLXw064790 for ; Sun, 26 Jul 2015 14:44:21 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-testing@freebsd.org Subject: [Bug 200896] fifo_misc generates "ioctl sign-extension ioctl ffffffff8004667e" warnings Date: Sun, 26 Jul 2015 14:44:21 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 11.0-CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: rodrigc@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-testing@freebsd.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: assigned_to cc Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-testing@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Testing on FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 26 Jul 2015 14:44:21 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=200896 Craig Rodrigues changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|freebsd-bugs@FreeBSD.org |freebsd-testing@freebsd.org CC| |rodrigc@FreeBSD.org -- You are receiving this mail because: You are the assignee for the bug. From owner-freebsd-testing@freebsd.org Sun Jul 26 14:47:06 2015 Return-Path: Delivered-To: freebsd-testing@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 691C99ABF56 for ; Sun, 26 Jul 2015 14:47:06 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 5573A366 for ; Sun, 26 Jul 2015 14:47:06 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id t6QEl6sP066353 for ; Sun, 26 Jul 2015 14:47:06 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-testing@freebsd.org Subject: [Bug 200896] fifo_misc generates "ioctl sign-extension ioctl ffffffff8004667e" warnings Date: Sun, 26 Jul 2015 14:47:06 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 11.0-CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: commit-hook@freebsd.org X-Bugzilla-Status: New X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-testing@freebsd.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-testing@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Testing on FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 26 Jul 2015 14:47:06 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=200896 --- Comment #1 from commit-hook@freebsd.org --- A commit references this bug: Author: rodrigc Date: Sun Jul 26 14:46:43 UTC 2015 New revision: 285891 URL: https://svnweb.freebsd.org/changeset/base/285891 Log: Pass unsigned long argument to ioctl(). Eliminates "ioctl sign-extension" warnings. PR: 200896 Changes: head/tests/sys/fifo/fifo_misc.c -- You are receiving this mail because: You are the assignee for the bug. From owner-freebsd-testing@freebsd.org Sun Jul 26 18:49:47 2015 Return-Path: Delivered-To: freebsd-testing@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 175A59ABFC2; Sun, 26 Jul 2015 18:49:47 +0000 (UTC) (envelope-from lwhsu.freebsd@gmail.com) Received: from mail-lb0-x22b.google.com (mail-lb0-x22b.google.com [IPv6:2a00:1450:4010:c04::22b]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 8F6AD6E1; Sun, 26 Jul 2015 18:49:46 +0000 (UTC) (envelope-from lwhsu.freebsd@gmail.com) Received: by lblf12 with SMTP id f12so41089305lbl.2; Sun, 26 Jul 2015 11:49:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=JEDwn4FHC6q4qOiCaEkUVsoJUGyg++yNZJ97WgjTcqY=; b=ryhAnFgdST59SNWALQeD9g8NDbl/lmhaaVbrNBnnsg8+tE1yV1QLCoAmC9+ueGyymw t4d9RTDroeh1HqnZCfBS9AU1Pry4jSTt+Tylo0oshm/pWqmpeRpqFqm0cykYtpmTJ4y/ rzNaCz5E6VX1P9YA7lV/HfE+BoTE8dDc5b4ZJQhbxacQtyozQf+inxO6zcZnoLwzWRj9 3lAXXbzttwrdmCkBxUpF+RYlHSTwwzQHMN3RA3kkOGkGn9FsGQ0TAhdSHL9KC1FpYg4z HjLFDsA2A/2rnVe8280PIj+1l9uGWfZCz6UicD6SohGT0S3GXIt9EEiUHoj9fDbh4L0s lBJg== MIME-Version: 1.0 X-Received: by 10.152.1.227 with SMTP id 3mr23309779lap.61.1437936584807; Sun, 26 Jul 2015 11:49:44 -0700 (PDT) Sender: lwhsu.freebsd@gmail.com Received: by 10.25.197.195 with HTTP; Sun, 26 Jul 2015 11:49:44 -0700 (PDT) In-Reply-To: References: <8CA148D7-81AF-41F8-AA41-9D7700B27242@neville-neil.com> <558C62B6.6030004@FreeBSD.org> <559173E7.30603@FreeBSD.org> <1435614385.5387.0@smtp.gmail.com> Date: Mon, 27 Jul 2015 02:49:44 +0800 X-Google-Sender-Auth: ki9WBiae-Fm8ibn_0qGclOd98dc Message-ID: Subject: Re: Requests for Help: add FreeBSD procstat support to akuma library for Jenkins From: Li-Wen Hsu To: Michael Zhilin Cc: Craig Rodrigues , "freebsd-testing@freebsd.org" , "freebsd-java@freebsd.org" Content-Type: text/plain; charset=UTF-8 X-BeenThere: freebsd-testing@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Testing on FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 26 Jul 2015 18:49:47 -0000 Jenkins 1.621 seems to have this in changelog: http://jenkins-ci.org/changelog#v1.621 But I've tried 1.621 downloaded from jenkins-ci.org and build myself, there is no such checkbox. The build from the latest master branch does work, so there might be still something missed in 1.621. Li-Wen On Thu, Jul 23, 2015 at 6:44 AM, Michael Zhilin wrote: > Excellent news! Thank you!!! > > On Wed, Jul 22, 2015 at 10:10 PM, Craig Rodrigues > wrote: > >> >> >> On Mon, Jun 29, 2015 at 5:46 PM, Michael Zhilin wrote: >> >>> Hi, >>> >>> Here is possible fix (at least works for me @FBSD10-stable): >>> https://github.com/kohsuke/akuma/pull/9 >>> >>> >> Your change was merged. Kohsuke Kawaguchi (lead Jenkins developer) built >> a new version of akuma with this change. >> >> Kohsuke then merged this change which I submitted to the Jenkins core to >> use the new akuma: >> https://github.com/jenkinsci/jenkins/pull/1770 >> >> So one of the next Jenkins releases will have your change which improves >> Jenkins restarting under FreeBSD after updating plugins. >> Thanks again for your submission!! >> >> -- >> Craig >> > _______________________________________________ > freebsd-testing@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/freebsd-testing > To unsubscribe, send any mail to "freebsd-testing-unsubscribe@freebsd.org" -- Li-Wen Hsu http://lwhsu.org From owner-freebsd-testing@freebsd.org Wed Jul 29 16:43:19 2015 Return-Path: Delivered-To: freebsd-testing@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id F1AFC9AC66A; Wed, 29 Jul 2015 16:43:19 +0000 (UTC) (envelope-from lwhsu.freebsd@gmail.com) Received: from mail-lb0-x230.google.com (mail-lb0-x230.google.com [IPv6:2a00:1450:4010:c04::230]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 7673E2DE3; Wed, 29 Jul 2015 16:43:19 +0000 (UTC) (envelope-from lwhsu.freebsd@gmail.com) Received: by lblf12 with SMTP id f12so10796761lbl.2; Wed, 29 Jul 2015 09:43:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=gsh3pT1QXX1VxAkvn6Uoe8dgwSRigQdRXI7hUXIGYks=; b=j62cGsU/ibrAeETW9jaL7BdzllvTJieM/OUKTNTdtXANdYf0GQJst6+JQjA8ug5+Ch IIa9IaJu7Fm50QU5/y4cUTqetaGbS5dMuQ1LGYe6oMq2OwZxhZ6fH6H2lZWzcSkIoHtU 9qnkxD6AL7xfiP1FMIq3QTm67Ldicc7ZsYaroLEGqSty2g7bn4N/euJepZIOMgu2jBal wYURvZYWPkv5lItdZXkL4McCc4LLw7u78RV5WYO18KCZ72d8v1Suav/j2f59HM1muKz7 jjwawdRjyRMglZr9v7Z0zsmpKAONz2/ZjQ1v6sca1/nGoXDkPO5nR6zpdxsWKwSJf/jo D4qw== MIME-Version: 1.0 X-Received: by 10.112.142.196 with SMTP id ry4mr1120425lbb.68.1438188197728; Wed, 29 Jul 2015 09:43:17 -0700 (PDT) Sender: lwhsu.freebsd@gmail.com Received: by 10.25.197.195 with HTTP; Wed, 29 Jul 2015 09:43:17 -0700 (PDT) In-Reply-To: References: <8CA148D7-81AF-41F8-AA41-9D7700B27242@neville-neil.com> <558C62B6.6030004@FreeBSD.org> <559173E7.30603@FreeBSD.org> <1435614385.5387.0@smtp.gmail.com> Date: Thu, 30 Jul 2015 00:43:17 +0800 X-Google-Sender-Auth: p9hz5EZYRbWGmDhVJ4hdO9vXegY Message-ID: Subject: Re: Requests for Help: add FreeBSD procstat support to akuma library for Jenkins From: Li-Wen Hsu To: Michael Zhilin Cc: Craig Rodrigues , "freebsd-testing@freebsd.org" , "freebsd-java@freebsd.org" Content-Type: text/plain; charset=UTF-8 X-BeenThere: freebsd-testing@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Testing on FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Jul 2015 16:43:20 -0000 On Mon, Jul 27, 2015 at 2:49 AM, Li-Wen Hsu wrote: > Jenkins 1.621 seems to have this in changelog: > > http://jenkins-ci.org/changelog#v1.621 > > But I've tried 1.621 downloaded from jenkins-ci.org and build myself, > there is no such checkbox. > The build from the latest master branch does work, so there might be > still something missed in 1.621. This is in 1.622 and ports tree now. -- Li-Wen Hsu http://lwhsu.org From owner-freebsd-testing@freebsd.org Wed Jul 29 17:59:59 2015 Return-Path: Delivered-To: freebsd-testing@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id A99249AEBC8 for ; Wed, 29 Jul 2015 17:59:59 +0000 (UTC) (envelope-from jim.harris@gmail.com) Received: from mail-oi0-x231.google.com (mail-oi0-x231.google.com [IPv6:2607:f8b0:4003:c06::231]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 7443CD65 for ; Wed, 29 Jul 2015 17:59:59 +0000 (UTC) (envelope-from jim.harris@gmail.com) Received: by oihq81 with SMTP id q81so9342436oih.2 for ; Wed, 29 Jul 2015 10:59:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:date:message-id:subject:from:to:content-type; bh=pcZe3/xYuruwkEuryAAykTOUui15UP90gys9XmbVAu4=; b=GblnjCw1WwyeZxai1BOnp7kyOZBcmIXUlgKq6lsb/qnT3pglyUGWqxlXiRsZHqGl14 XOwhLBk1pM0f2urx537BcPS73q0yQunAz94Tk7tj3RDcwL7/EdALCj61ZP0UB/Q5NV1z gIXxSjZRmI5EpMUc9EWfASDgxiXkwQ66Cb3gUFtb2f0URZXBpA1KHh0a3RjG3ZiOVaj/ bb3PQWfs/r44mCYmkyoH33K7x2jtU5uQIKOHfMAFOzL7HFk2Qh1TVgxXB2jIwbzdMZus RRHLWINVnGjEVW6u00Dnxqn3kjN9A8GCBZnEeD/JANTLZAWOcioRqF2m8uYPev0SciGA LpEQ== MIME-Version: 1.0 X-Received: by 10.202.180.133 with SMTP id d127mr39896050oif.104.1438192798835; Wed, 29 Jul 2015 10:59:58 -0700 (PDT) Sender: jim.harris@gmail.com Received: by 10.202.104.65 with HTTP; Wed, 29 Jul 2015 10:59:58 -0700 (PDT) Date: Wed, 29 Jul 2015 10:59:58 -0700 X-Google-Sender-Auth: NH-7b_PdTj9BjPDZCgwpZ4PVp8s Message-ID: Subject: NVMe unit tests From: Jim Harris To: freebsd-testing@freebsd.org Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.20 X-BeenThere: freebsd-testing@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Testing on FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Jul 2015 17:59:59 -0000 Hi, I have a CUnit-based infrastructure with quite a few unit tests for the FreeBSD nvme driver. It enables testing a number of corner cases within the driver without requiring real hardware and stubbing kernel behavior in some cases to induce the corner cases. Which leads me to a few questions: 1) Is there interest here in having this pushed into HEAD? Or would a user branch be more appropriate? 2) Where in the tree should I put it? In our internal repo, I have it under tools/regression/nvme, but maybe sys/dev/nvme/tests is more appropriate? Feedback is welcome. Thanks, -Jim From owner-freebsd-testing@freebsd.org Wed Jul 29 19:02:58 2015 Return-Path: Delivered-To: freebsd-testing@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 71A279AE8A6 for ; Wed, 29 Jul 2015 19:02:58 +0000 (UTC) (envelope-from asomers@gmail.com) Received: from mail-ob0-x235.google.com (mail-ob0-x235.google.com [IPv6:2607:f8b0:4003:c01::235]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 32674FE2; Wed, 29 Jul 2015 19:02:58 +0000 (UTC) (envelope-from asomers@gmail.com) Received: by obnw1 with SMTP id w1so14372001obn.3; Wed, 29 Jul 2015 12:02:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=RRMO8HJQl+8DYif/KD26ANdVawP15BuuAfAh0LY4j+w=; b=vizPxfvYEkEF5E+LZC8H6UBu0wjSus6TVahtjyBuaEezxvbtMoCLHTRs7E/4RszuIo F9TF4l+EqWwLw17vpA997Z+Vz5U3czKxy0A6P1YcvouC4mqemN+vH95AlY+Ij7GWrpoK ofaTNBILJx98YU67E2QD2tDaAO0BpTmp8xbjIs1veNv+mNQrfEbGs0IOzRa95/B7jQGA t2g0RggcMyRHclVak3QM5TO1Cz8t8wJgFtbKOn89jv9jD4YljfDvJ83UeP4H+IpCR2Ij 2OtRV7oggJPTRnGOlrhAGO26mECbszaGQolMaqNLR6oZU3wC5IhZ6TgrN6H8/ZmwNILi krCQ== MIME-Version: 1.0 X-Received: by 10.60.79.193 with SMTP id l1mr41123720oex.60.1438196577567; Wed, 29 Jul 2015 12:02:57 -0700 (PDT) Sender: asomers@gmail.com Received: by 10.202.80.4 with HTTP; Wed, 29 Jul 2015 12:02:57 -0700 (PDT) In-Reply-To: References: Date: Wed, 29 Jul 2015 13:02:57 -0600 X-Google-Sender-Auth: 058g-S6FHt-ozQH9T0lPFwTSCTc Message-ID: Subject: Re: NVMe unit tests From: Alan Somers To: Jim Harris Cc: "freebsd-testing@freebsd.org" Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.20 X-BeenThere: freebsd-testing@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Testing on FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Jul 2015 19:02:58 -0000 On Wed, Jul 29, 2015 at 11:59 AM, Jim Harris wrote: > Hi, > > I have a CUnit-based infrastructure with quite a few unit tests for the > FreeBSD nvme driver. It enables testing a number of corner cases within > the driver without requiring real hardware and stubbing kernel behavior in > some cases to induce the corner cases. Which leads me to a few questions: > > 1) Is there interest here in having this pushed into HEAD? Or would a user > branch be more appropriate? > Head would be ideal. The tests won't get run if they stay in a user branch. > 2) Where in the tree should I put it? In our internal repo, I have it > under tools/regression/nvme, but maybe sys/dev/nvme/tests is more > appropriate? > Ngie, jmmv, and I debated this awhile back. We concluded that the way our build system works, it isn't appropriate to put ATF tests in sys. Instead, they should go in tests/sys/X, where X mirrors the location of the code in sys. For nvme, that would be tests/sys/dev/nvme. Kyua doesn't natively understand CUnit. So you have two options: run the tests with the plain test adapter, or convert them all to ATF-C tests. The main disadvantage to the plain test adapter is that Kyua won't be aware of the detailed test results. For example, if you have 500 CUnit test cases, Kyua will only report whether the whole suite passed or failed rather than whether each test case passed or failed. -Alan > > Feedback is welcome. > > Thanks, > > -Jim > _______________________________________________ > freebsd-testing@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/freebsd-testing > To unsubscribe, send any mail to "freebsd-testing-unsubscribe@freebsd.org" > From owner-freebsd-testing@freebsd.org Thu Jul 30 12:20:44 2015 Return-Path: Delivered-To: freebsd-testing@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 6FD4E9AD53A for ; Thu, 30 Jul 2015 12:20:44 +0000 (UTC) (envelope-from crodr001@gmail.com) Received: from mail-yk0-x229.google.com (mail-yk0-x229.google.com [IPv6:2607:f8b0:4002:c07::229]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 29E51D24; Thu, 30 Jul 2015 12:20:44 +0000 (UTC) (envelope-from crodr001@gmail.com) Received: by ykay190 with SMTP id y190so32231586yka.3; Thu, 30 Jul 2015 05:20:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=o/pLLYVMDeXUnt94KEjupNXL7oVTKWQ1QoQ09ZjMYw0=; b=jLWIravlB3zan+KQ5CRzHk/pEDDkjo0Bc/GlMrL0U80GZnuH72wdiBPC1qCi+LdSG/ x2SNdRnidKA+Ty0avhiwQFZ5g2SRwTfMzMRJyQQyDuMMgeSjC3/a4QFJht6wR1g/fh2W sJqaYoCPnNqrXaGy6uddrWT4DqykWRGbmPWTzKAjL7551LFrjzPqkCP+0hKko9258ph9 44+FYsQ8BSOW6GTodyDFDk4+7yRhSy8f0aU51yL8wbjspCCko2pzYbIy5f+DM/3Qltbf deXtj7Z5ihxE/njW9Mgv8TpexDRT4mdw5eWm2OC6DOaPIxbu6mpekIbX4Kkcb406JQl1 MZfA== MIME-Version: 1.0 X-Received: by 10.13.244.195 with SMTP id d186mr50890352ywf.73.1438258843238; Thu, 30 Jul 2015 05:20:43 -0700 (PDT) Sender: crodr001@gmail.com Received: by 10.37.79.2 with HTTP; Thu, 30 Jul 2015 05:20:43 -0700 (PDT) In-Reply-To: References: Date: Thu, 30 Jul 2015 08:20:43 -0400 X-Google-Sender-Auth: -FEJ99I09y-6EE6ekBP4iz0zo0Q Message-ID: Subject: Re: NVMe unit tests From: Craig Rodrigues To: Alan Somers Cc: Jim Harris , "freebsd-testing@freebsd.org" Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.20 X-BeenThere: freebsd-testing@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Testing on FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 30 Jul 2015 12:20:44 -0000 On Wed, Jul 29, 2015 at 3:02 PM, Alan Somers wrote: > On Wed, Jul 29, 2015 at 11:59 AM, Jim Harris > wrote: > > Kyua doesn't natively understand CUnit. So you have two options: run the > tests with the plain test adapter, or convert them all to ATF-C tests. The > main disadvantage to the plain test adapter is that Kyua won't be aware of > the detailed test results. For example, if you have 500 CUnit test cases, > Kyua will only report whether the whole suite passed or failed rather than > whether each test case passed or failed. > In the May/June 2015 issue of FreeBSD Journal ( http://freebsdjournal.com ), there is a good interview with Julio Merino (jmmv). In the interview, Julio says: "If you happen to be an atf-sh user, I'd like ot suggest you have a look at shtk's unittest module, which is my latest attempt at implementing a more modern testing library for the shell that follows the common xUnit idioms. And if you use atf-c++, consider googletest as an alternative, a much more mature C++ testing library". On a similar note, I have used CUnit, and find it to be a perfectly fine library for writing unit tests in C. CUnit and googletest can both generate xUnit XML test result output which can be used as input to continuous integration systems such as Jenkins. Based on the comments from Julio, I have a very hard time encouraging people to write new tests using ATF. I have a harder time encouraging people to migrate existing tests from other test libraries to ATF, if they have stuff already working with things like googletest or CUnit. At my work, I originally tried to steer people to write new tests in ATF and migrate tests from CUnit to ATF, but then gave up, because of pushback from developers. The combination we have that seems to work for us is: CUnit for unit tests in C, pyunit tests in Python for tests which can run in a scripting language, and all tests results reported in Jenkins. This combination may not work for everyone, but it is what seems to be OK for us. If kyua could be extended to natively run CUnit and googletest, that would be very useful. That would allow us to run more types of test libraries and have the test results reported natively in kyua. I don't have the time to work on extending kyua in this way. I'm not sure if Julio does either. In that interview, he states that he is quite busy. The alternative is to run CUnit or googletests directly (even if they are in the FreeBSD src tree), and report the results in the Jenkins test report viewer. That option may not be attractive, but it would work. -- Craig From owner-freebsd-testing@freebsd.org Thu Jul 30 15:59:37 2015 Return-Path: Delivered-To: freebsd-testing@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 517289AE75A for ; Thu, 30 Jul 2015 15:59:37 +0000 (UTC) (envelope-from jim.harris@gmail.com) Received: from mail-oi0-x22e.google.com (mail-oi0-x22e.google.com [IPv6:2607:f8b0:4003:c06::22e]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 174661D9A; Thu, 30 Jul 2015 15:59:37 +0000 (UTC) (envelope-from jim.harris@gmail.com) Received: by oigi136 with SMTP id i136so24120874oig.1; Thu, 30 Jul 2015 08:59:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=m3G4bdkMQBS0EFE2GcK1UjWaW/vDlA80V1rxEV7St/0=; b=YJkbQlq8ExmzdTqH/R9FknI7poSlHrbU/hH9eP5ciO1VcuoRirOwBBleLjodhQmBCf cQ25QymMJHNHmrvHJRW/kl42Qt41PBl9arRM1HdYqOsp12yKYHkUXGW6TnQu0/wqpoPM axZB4G2adQfWMhmf4BNXfd2WcpUbiGHP8lRR0LMHTxEF5vxsVbJFycFt1zgECXgLm5j8 tcO9nmjOHjD1gaa9+p9JMDSUXZHYgA5Mw5GXAYXIjddZb4UBQKB5RdP4lc+qA7HIG/V/ n0jKYn9IiEkAl02CHSIXzjJ0r+3P0tJIJdyPsAqgWyCt7ZXMupKgv7Y50iPuAOQBk3Xo 91Cg== MIME-Version: 1.0 X-Received: by 10.202.180.133 with SMTP id d127mr44667917oif.104.1438271976498; Thu, 30 Jul 2015 08:59:36 -0700 (PDT) Received: by 10.202.104.65 with HTTP; Thu, 30 Jul 2015 08:59:36 -0700 (PDT) In-Reply-To: References: Date: Thu, 30 Jul 2015 08:59:36 -0700 Message-ID: Subject: Re: NVMe unit tests From: Jim Harris To: Craig Rodrigues Cc: Alan Somers , "freebsd-testing@freebsd.org" Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.20 X-BeenThere: freebsd-testing@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Testing on FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 30 Jul 2015 15:59:37 -0000 On Thu, Jul 30, 2015 at 5:20 AM, Craig Rodrigues wrote: > > > On Wed, Jul 29, 2015 at 3:02 PM, Alan Somers wrote: > >> On Wed, Jul 29, 2015 at 11:59 AM, Jim Harris >> wrote: >> >> Kyua doesn't natively understand CUnit. So you have two options: run the >> tests with the plain test adapter, or convert them all to ATF-C tests. >> The >> main disadvantage to the plain test adapter is that Kyua won't be aware of >> the detailed test results. For example, if you have 500 CUnit test cases, >> Kyua will only report whether the whole suite passed or failed rather than >> whether each test case passed or failed. >> > > In the May/June 2015 issue of FreeBSD Journal ( http://freebsdjournal.com > ), there is > a good interview with Julio Merino (jmmv). In the interview, Julio says: > > "If you happen to be an atf-sh user, I'd like ot suggest you have a look > at shtk's unittest module, which is my latest attempt at implementing a > more modern testing library for the shell that follows the common xUnit > idioms. And if you use atf-c++, consider googletest as an alternative, a > much more mature C++ testing library". > > On a similar note, I have used CUnit, and find it to be a perfectly fine > library > for writing unit tests in C. CUnit and googletest can both generate xUnit > XML test result > output which can be used as input to continuous integration systems such > as Jenkins. > > Based on the comments from Julio, I have a very hard time encouraging > people > to write new tests using ATF. I have a harder time encouraging people to > migrate > existing tests from other test libraries to ATF, if they have stuff > already working with things like > googletest or CUnit. > > At my work, I originally tried to steer people to write new tests in ATF > and migrate tests from CUnit to ATF, but then > gave up, because of pushback from developers. The combination we have that > seems to work for us is: CUnit for unit tests in C, pyunit tests in > Python for tests which can run in a scripting language, and all tests > results reported in Jenkins. This combination may not work for everyone, > but it is what seems to be OK for us. > > If kyua could be extended to natively run CUnit and googletest, that would > be > very useful. That would allow us to run more types of test libraries and > have the test results reported natively in kyua. I don't have the time to > work on extending kyua in this way. > I'm not sure if Julio does either. In that interview, he states that he > is quite busy. > > The alternative is to run CUnit or googletests directly (even if they are > in the FreeBSD src tree), and report the results in the Jenkins test report > viewer. That option may not be attractive, but it would work. > Alan and Craig, Thanks for the feedback. I will integrate these into HEAD soonish, under tests/sys/dev/nvme as Alan suggested. I do not plan to switch these tests from CUnit to something else, but would be willing to add code to spit out XML files with per-test results if that would be helpful. Otherwise the tests currently are organized per nvme source file, so we would at least get per-file granularity on the test results. -Jim > -- > Craig >