From owner-freebsd-toolchain@freebsd.org Sun Jul 19 11:13:15 2015 Return-Path: Delivered-To: freebsd-toolchain@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id D59919A4837 for ; Sun, 19 Jul 2015 11:13:15 +0000 (UTC) (envelope-from daemon-user@freebsd.org) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) by mx1.freebsd.org (Postfix) with ESMTP id B5E0A1E84 for ; Sun, 19 Jul 2015 11:13:15 +0000 (UTC) (envelope-from daemon-user@freebsd.org) Received: by phabric-backend.isc.freebsd.org (Postfix, from userid 1346) id B0166F557; Sun, 19 Jul 2015 11:13:15 +0000 (UTC) Date: Sun, 19 Jul 2015 11:13:15 +0000 To: freebsd-toolchain@freebsd.org From: "emaste (Ed Maste)" Reply-to: D2338+334+aa8d418be5da1de7@FreeBSD.org Subject: [Differential] [Updated, 62 lines] D2338: readelf: avoid division by zero for files with invalid sh_entsize Message-ID: <7c59257489905e00b12a6a1519c33dd8@localhost.localdomain> X-Priority: 3 Thread-Topic: D2338: readelf: avoid division by zero for files with invalid sh_entsize X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: X-Phabricator-Cc: In-Reply-To: References: Thread-Index: ZmMzNDdkZjZhNjRlYTVmZjk2ZjhhYzllZGEwIFWrhks= Precedence: bulk X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: , , , MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="b1_7c59257489905e00b12a6a1519c33dd8" X-BeenThere: freebsd-toolchain@freebsd.org X-Mailman-Version: 2.1.20 List-Id: Maintenance of FreeBSD's integrated toolchain List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 19 Jul 2015 11:13:15 -0000 --b1_7c59257489905e00b12a6a1519c33dd8 Content-Type: text/plain; charset = "utf-8" Content-Transfer-Encoding: 8bit emaste updated this revision to Diff 7069. emaste added a comment. This revision now requires review to proceed. Add a `get_ent_count` helper to check for 0 entsize instead of expanding the check inline everywhere. CHANGES SINCE LAST UPDATE https://reviews.freebsd.org/D2338?vs=4930&id=7069 REVISION DETAIL https://reviews.freebsd.org/D2338 AFFECTED FILES contrib/elftoolchain/readelf/readelf.c EMAIL PREFERENCES https://reviews.freebsd.org/settings/panel/emailpreferences/ To: emaste, brooks Cc: brooks, freebsd-toolchain-list --b1_7c59257489905e00b12a6a1519c33dd8 Content-Type: text/x-patch; charset=utf-8; name="D2338.7069.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="D2338.7069.patch" ZGlmZiAtLWdpdCBhL2NvbnRyaWIvZWxmdG9vbGNoYWluL3JlYWRlbGYvcmVhZGVsZi5jIGIvY29u dHJpYi9lbGZ0b29sY2hhaW4vcmVhZGVsZi9yZWFkZWxmLmMKLS0tIGEvY29udHJpYi9lbGZ0b29s Y2hhaW4vcmVhZGVsZi9yZWFkZWxmLmMKKysrIGIvY29udHJpYi9lbGZ0b29sY2hhaW4vcmVhZGVs Zi9yZWFkZWxmLmMKQEAgLTI3LDYgKzI3LDcgQEAKICNpbmNsdWRlIDxzeXMvcGFyYW0uaD4KICNp bmNsdWRlIDxzeXMvcXVldWUuaD4KICNpbmNsdWRlIDxhci5oPgorI2luY2x1ZGUgPGFzc2VydC5o PgogI2luY2x1ZGUgPGN0eXBlLmg+CiAjaW5jbHVkZSA8ZHdhcmYuaD4KICNpbmNsdWRlIDxlcnIu aD4KQEAgLTMxNCw2ICszMTUsNyBAQAogc3RhdGljIGNvbnN0IGNoYXIgKmR3YXJmX3JlZ25hbWUo c3RydWN0IHJlYWRlbGYgKnJlLCB1bnNpZ25lZCBpbnQgbnVtKTsKIHN0YXRpYyBzdHJ1Y3QgZHVt cG9wICpmaW5kX2R1bXBvcChzdHJ1Y3QgcmVhZGVsZiAqcmUsIHNpemVfdCBzaSwKICAgICBjb25z dCBjaGFyICpzbiwgaW50IG9wLCBpbnQgdCk7CitzdGF0aWMgaW50IGdldF9lbnRfY291bnQoc3Ry dWN0IHNlY3Rpb24gKnMsIGludCAqZW50X2NvdW50KTsKIHN0YXRpYyBjaGFyICpnZXRfcmVnb2Zm X3N0cihzdHJ1Y3QgcmVhZGVsZiAqcmUsIER3YXJmX0hhbGYgcmVnLAogICAgIER3YXJmX0FkZHIg b2ZmKTsKIHN0YXRpYyBjb25zdCBjaGFyICpnZXRfc3RyaW5nKHN0cnVjdCByZWFkZWxmICpyZSwg aW50IHN0cnRhYiwgc2l6ZV90IG9mZik7CkBAIC0yOTAwLDYgKzI5MDIsMjQgQEAKICN1bmRlZglT VF9DVEwKIH0KIAorLyoKKyAqIFJldHVybiBudW1iZXIgb2YgZW50cmllcyBpbiB0aGUgZ2l2ZW4g c2VjdGlvbi4gV2UnZCBwcmVmZXIgZW50X2NvdW50IGJlIGEKKyAqIHNpemVfdCAqLCBidXQgbGli ZWxmIEFQSXMgYWxyZWFkeSB1c2UgaW50IGZvciBzZWN0aW9uIGluZGljZXMuCisgKi8KK3N0YXRp YyBpbnQKK2dldF9lbnRfY291bnQoc3RydWN0IHNlY3Rpb24gKnMsIGludCAqZW50X2NvdW50KQor eworCWlmIChzLT5lbnRzaXplID09IDApIHsKKwkJd2FybngoInNlY3Rpb24gJXMgaGFzIGVudHJ5 IHNpemUgMCIsIHMtPm5hbWUpOworCQlyZXR1cm4gKDApOworCX0gZWxzZSBpZiAocy0+c3ogLyBz LT5lbnRzaXplID4gSU5UX01BWCkgeworCQl3YXJueCgic2VjdGlvbiAlcyBoYXMgaW52YWxpZCBz ZWN0aW9uIGNvdW50Iiwgcy0+bmFtZSk7CisJCXJldHVybiAoMCk7CisJfQorCSplbnRfY291bnQg PSAoaW50KShzLT5zeiAvIHMtPmVudHNpemUpOworCXJldHVybiAoMSk7Cit9CisKIHN0YXRpYyB2 b2lkCiBkdW1wX2R5bmFtaWMoc3RydWN0IHJlYWRlbGYgKnJlKQogewpAQCAtMjkyOCw4ICsyOTQ4 LDggQEAKIAogCQkvKiBEZXRlcm1pbmUgdGhlIGFjdHVhbCBudW1iZXIgb2YgdGFibGUgZW50cmll cy4gKi8KIAkJbmVudHJpZXMgPSAwOwotCQlqbWF4ID0gKGludCkgKHMtPnN6IC8gcy0+ZW50c2l6 ZSk7Ci0KKwkJaWYgKCFnZXRfZW50X2NvdW50KHMsICZqbWF4KSkKKwkJCWNvbnRpbnVlOwogCQlm b3IgKGogPSAwOyBqIDwgam1heDsgaisrKSB7CiAJCQlpZiAoZ2VsZl9nZXRkeW4oZCwgaiwgJmR5 bikgIT0gJmR5bikgewogCQkJCXdhcm54KCJnZWxmX2dldGR5biBmYWlsZWQ6ICVzIiwKQEAgLTMx NzUsNyArMzE5NSw5IEBACiAJCWVsc2UKIAkJCXByaW50ZigiJS0xMnMgJS0xMnMgJS0xOXMgJS0x NnMgJXNcbiIsIFJFTF9IRFIpOwogCX0KLQlsZW4gPSBkLT5kX3NpemUgLyBzLT5lbnRzaXplOwor CWFzc2VydChkLT5kX3NpemUgPT0gcy0+c3opOworCWlmICghZ2V0X2VudF9jb3VudChzLCAmbGVu KSkKKwkJcmV0dXJuOwogCWZvciAoaSA9IDA7IGkgPCBsZW47IGkrKykgewogCQlpZiAoZ2VsZl9n ZXRyZWwoZCwgaSwgJnIpICE9ICZyKSB7CiAJCQl3YXJueCgiZ2VsZl9nZXRyZWwgZmFpbGVkOiAl cyIsIGVsZl9lcnJtc2coLTEpKTsKQEAgLTMyMzEsNyArMzI1Myw5IEBACiAJCWVsc2UKIAkJCXBy aW50ZigiJS0xMnMgJS0xMnMgJS0xOXMgJS0xNnMgJXNcbiIsIFJFTEFfSERSKTsKIAl9Ci0JbGVu ID0gZC0+ZF9zaXplIC8gcy0+ZW50c2l6ZTsKKwlhc3NlcnQoZC0+ZF9zaXplID09IHMtPnN6KTsK KwlpZiAoIWdldF9lbnRfY291bnQocywgJmxlbikpCisJCXJldHVybjsKIAlmb3IgKGkgPSAwOyBp IDwgbGVuOyBpKyspIHsKIAkJaWYgKGdlbGZfZ2V0cmVsYShkLCBpLCAmcikgIT0gJnIpIHsKIAkJ CXdhcm54KCJnZWxmX2dldHJlbCBmYWlsZWQ6ICVzIiwgZWxmX2Vycm1zZygtMSkpOwpAQCAtMzI5 Niw3ICszMzIwLDcgQEAKIAlFbGZfRGF0YSAqZDsKIAlHRWxmX1N5bSBzeW07CiAJY29uc3QgY2hh ciAqbmFtZTsKLQlpbnQgZWxmZXJyLCBzdGFiLCBqOworCWludCBlbGZlcnIsIHN0YWIsIGosIGxl bjsKIAogCXMgPSAmcmUtPnNsW2ldOwogCXN0YWIgPSBzLT5saW5rOwpAQCAtMzMwOSwxMiArMzMz MywxNCBAQAogCX0KIAlpZiAoZC0+ZF9zaXplIDw9IDApCiAJCXJldHVybjsKKwlpZiAoIWdldF9l bnRfY291bnQocywgJmxlbikpCisJCXJldHVybjsKIAlwcmludGYoIlN5bWJvbCB0YWJsZSAoJXMp Iiwgcy0+bmFtZSk7Ci0JcHJpbnRmKCIgY29udGFpbnMgJWp1IGVudHJpZXM6XG4iLCBzLT5zeiAv IHMtPmVudHNpemUpOworCXByaW50ZigiIGNvbnRhaW5zICVkIGVudHJpZXM6XG4iLCBsZW4pOwog CXByaW50ZigiJTdzJTlzJTE0cyU1cyU4cyU2cyU5cyU1c1xuIiwgIk51bToiLCAiVmFsdWUiLCAi U2l6ZSIsICJUeXBlIiwKIAkgICAgIkJpbmQiLCAiVmlzIiwgIk5keCIsICJOYW1lIik7CiAKLQlm b3IgKGogPSAwOyAodWludDY0X3QpaiA8IHMtPnN6IC8gcy0+ZW50c2l6ZTsgaisrKSB7CisJZm9y IChqID0gMDsgaiA8IGxlbjsgaisrKSB7CiAJCWlmIChnZWxmX2dldHN5bShkLCBqLCAmc3ltKSAh PSAmc3ltKSB7CiAJCQl3YXJueCgiZ2VsZl9nZXRzeW0gZmFpbGVkOiAlcyIsIGVsZl9lcnJtc2co LTEpKTsKIAkJCWNvbnRpbnVlOwpAQCAtMzM1Miw3ICszMzc4LDcgQEAKIAlFbGZfRGF0YSAqZDsK IAlzdHJ1Y3Qgc2VjdGlvbiAqczsKIAl1aW50NjRfdCBkeW5fb2ZmOwotCWludCBlbGZlcnIsIGk7 CisJaW50IGVsZmVyciwgaSwgbGVuOwogCiAJLyoKIAkgKiBJZiAtRCBpcyBzcGVjaWZpZWQsIG9u bHkgZHVtcCB0aGUgc3ltYm9sIHRhYmxlIHNwZWNpZmllZCBieQpAQCAtMzM3Nyw4ICszNDAzLDEw IEBACiAJCX0KIAkJaWYgKGQtPmRfc2l6ZSA8PSAwKQogCQkJcmV0dXJuOworCQlpZiAoIWdldF9l bnRfY291bnQocywgJmxlbikpCisJCQlyZXR1cm47CiAKLQkJZm9yIChpID0gMDsgKHVpbnQ2NF90 KWkgPCBzLT5zeiAvIHMtPmVudHNpemU7IGkrKykgeworCQlmb3IgKGkgPSAwOyBpIDwgbGVuOyBp KyspIHsKIAkJCWlmIChnZWxmX2dldGR5bihkLCBpLCAmZHluKSAhPSAmZHluKSB7CiAJCQkJd2Fy bngoImdlbGZfZ2V0ZHluIGZhaWxlZDogJXMiLCBlbGZfZXJybXNnKC0xKSk7CiAJCQkJY29udGlu dWU7CkBAIC0zNTY2LDcgKzM1OTQsOCBAQAogCW1hc2t3b3JkcyA9IGJ1ZlsyXTsKIAlidWYgKz0g NDsKIAlkcyA9ICZyZS0+c2xbcy0+bGlua107Ci0JZHluc3ltY291bnQgPSBkcy0+c3ogLyBkcy0+ ZW50c2l6ZTsKKwlpZiAoIWdldF9lbnRfY291bnQoZHMsICZkeW5zeW1jb3VudCkpCisJCXJldHVy bjsKIAluY2hhaW4gPSBkeW5zeW1jb3VudCAtIHN5bW5keDsKIAlpZiAoZC0+ZF9zaXplICE9IDQg KiBzaXplb2YodWludDMyX3QpICsgbWFza3dvcmRzICoKIAkgICAgKHJlLT5lYyA9PSBFTEZDTEFT UzMyID8gc2l6ZW9mKHVpbnQzMl90KSA6IHNpemVvZih1aW50NjRfdCkpICsKQEAgLTM5OTUsNyAr NDAyNCw3IEBACiAJY2hhciB0YnVmWzIwXTsKIAlFbGZfRGF0YSAqZDsKIAlFbGZfTGliICpsaWI7 Ci0JaW50IGksIGosIGssIGVsZmVyciwgZmlyc3Q7CisJaW50IGksIGosIGssIGVsZmVyciwgZmly c3QsIGxlbjsKIAogCWZvciAoaSA9IDA7IChzaXplX3QpIGkgPCByZS0+c2hudW07IGkrKykgewog CQlzID0gJnJlLT5zbFtpXTsKQEAgLTQwMTIsOCArNDA0MSwxMCBAQAogCQlpZiAoZC0+ZF9zaXpl IDw9IDApCiAJCQljb250aW51ZTsKIAkJbGliID0gZC0+ZF9idWY7CisJCWlmICghZ2V0X2VudF9j b3VudChzLCAmbGVuKSkKKwkJCWNvbnRpbnVlOwogCQlwcmludGYoIlxuTGlicmFyeSBsaXN0IHNl Y3Rpb24gJyVzJyAiLCBzLT5uYW1lKTsKLQkJcHJpbnRmKCJjb250YWlucyAlanUgZW50cmllczpc biIsIHMtPnN6IC8gcy0+ZW50c2l6ZSk7CisJCXByaW50ZigiY29udGFpbnMgJWQgZW50cmllczpc biIsIGxlbik7CiAJCXByaW50ZigiJTEycyUyNHMlMThzJTEwcyU2c1xuIiwgIkxpYnJhcnkiLCAi VGltZSBTdGFtcCIsCiAJCSAgICAiQ2hlY2tzdW0iLCAiVmVyc2lvbiIsICJGbGFncyIpOwogCQlm b3IgKGogPSAwOyAodWludDY0X3QpIGogPCBzLT5zeiAvIHMtPmVudHNpemU7IGorKykgewpAQCAt NDM5OCw3ICs0NDI5LDcgQEAKIGR1bXBfbWlwc19yZWdpbmZvKHN0cnVjdCByZWFkZWxmICpyZSwg c3RydWN0IHNlY3Rpb24gKnMpCiB7CiAJRWxmX0RhdGEgKmQ7Ci0JaW50IGVsZmVycjsKKwlpbnQg ZWxmZXJyLCBsZW47CiAKIAkodm9pZCkgZWxmX2Vycm5vKCk7CiAJaWYgKChkID0gZWxmX3Jhd2Rh dGEocy0+c2NuLCBOVUxMKSkgPT0gTlVMTCkgewpAQCAtNDQxMCw5ICs0NDQxLDEwIEBACiAJfQog CWlmIChkLT5kX3NpemUgPD0gMCkKIAkJcmV0dXJuOworCWlmICghZ2V0X2VudF9jb3VudChzLCAm bGVuKSkKKwkJcmV0dXJuOwogCi0JcHJpbnRmKCJcblNlY3Rpb24gJyVzJyBjb250YWlucyAlanUg ZW50cmllczpcbiIsIHMtPm5hbWUsCi0JICAgIHMtPnN6IC8gcy0+ZW50c2l6ZSk7CisJcHJpbnRm KCJcblNlY3Rpb24gJyVzJyBjb250YWlucyAlZCBlbnRyaWVzOlxuIiwgcy0+bmFtZSwgbGVuKTsK IAlkdW1wX21pcHNfb2RrX3JlZ2luZm8ocmUsIGQtPmRfYnVmLCBkLT5kX3NpemUpOwogfQogCgo= --b1_7c59257489905e00b12a6a1519c33dd8-- From owner-freebsd-toolchain@freebsd.org Thu Jul 23 17:32:52 2015 Return-Path: Delivered-To: freebsd-toolchain@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 74B799A9A7B for ; Thu, 23 Jul 2015 17:32:52 +0000 (UTC) (envelope-from daemon-user@freebsd.org) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) by mx1.freebsd.org (Postfix) with ESMTP id 5D99F1C28 for ; Thu, 23 Jul 2015 17:32:52 +0000 (UTC) (envelope-from daemon-user@freebsd.org) Received: by phabric-backend.isc.freebsd.org (Postfix, from userid 1346) id 4CD5DF5A2; Thu, 23 Jul 2015 17:32:52 +0000 (UTC) Date: Thu, 23 Jul 2015 17:32:52 +0000 To: freebsd-toolchain@freebsd.org From: "brooks (Brooks Davis)" Reply-to: D2338+334+aa8d418be5da1de7@FreeBSD.org Subject: [Differential] [Commented On] D2338: readelf: avoid division by zero for files with invalid sh_entsize Message-ID: <5f4dde4ec87be82f114fd7df43631a4c@localhost.localdomain> X-Priority: 3 Thread-Topic: D2338: readelf: avoid division by zero for files with invalid sh_entsize X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: X-Phabricator-Cc: In-Reply-To: References: Thread-Index: ZmMzNDdkZjZhNjRlYTVmZjk2ZjhhYzllZGEwIFWxJUQ= Precedence: bulk X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-toolchain@freebsd.org X-Mailman-Version: 2.1.20 List-Id: Maintenance of FreeBSD's integrated toolchain List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Jul 2015 17:32:52 -0000 brooks added a comment. Is this still live? REVISION DETAIL https://reviews.freebsd.org/D2338 EMAIL PREFERENCES https://reviews.freebsd.org/settings/panel/emailpreferences/ To: emaste, brooks Cc: brooks, freebsd-toolchain-list From owner-freebsd-toolchain@freebsd.org Thu Jul 23 17:47:46 2015 Return-Path: Delivered-To: freebsd-toolchain@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id AF2E89A9BDC for ; Thu, 23 Jul 2015 17:47:46 +0000 (UTC) (envelope-from daemon-user@freebsd.org) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) by mx1.freebsd.org (Postfix) with ESMTP id 8E34E1045 for ; Thu, 23 Jul 2015 17:47:46 +0000 (UTC) (envelope-from daemon-user@freebsd.org) Received: by phabric-backend.isc.freebsd.org (Postfix, from userid 1346) id 7EFCEF1C2; Thu, 23 Jul 2015 17:47:46 +0000 (UTC) Date: Thu, 23 Jul 2015 17:47:46 +0000 To: freebsd-toolchain@freebsd.org From: "emaste (Ed Maste)" Reply-to: D2338+334+aa8d418be5da1de7@FreeBSD.org Subject: [Differential] [Commented On] D2338: readelf: avoid division by zero for files with invalid sh_entsize Message-ID: <9c898d825acd187bbf4ddd8a8afeb84b@localhost.localdomain> X-Priority: 3 Thread-Topic: D2338: readelf: avoid division by zero for files with invalid sh_entsize X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: X-Phabricator-Cc: In-Reply-To: References: Thread-Index: ZmMzNDdkZjZhNjRlYTVmZjk2ZjhhYzllZGEwIFWxKMI= Precedence: bulk X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-toolchain@freebsd.org X-Mailman-Version: 2.1.20 List-Id: Maintenance of FreeBSD's integrated toolchain List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Jul 2015 17:47:46 -0000 emaste added a comment. Yes - sorry for the delay. I realized I had a newer implementation that factored the divide-by-zero checks into a helper function, and uploaded the new diff a few days ago. REVISION DETAIL https://reviews.freebsd.org/D2338 EMAIL PREFERENCES https://reviews.freebsd.org/settings/panel/emailpreferences/ To: emaste, brooks Cc: brooks, freebsd-toolchain-list From owner-freebsd-toolchain@freebsd.org Thu Jul 23 19:32:03 2015 Return-Path: Delivered-To: freebsd-toolchain@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 46B779A9F72 for ; Thu, 23 Jul 2015 19:32:03 +0000 (UTC) (envelope-from daemon-user@freebsd.org) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) by mx1.freebsd.org (Postfix) with ESMTP id 322B11CF0 for ; Thu, 23 Jul 2015 19:32:03 +0000 (UTC) (envelope-from daemon-user@freebsd.org) Received: by phabric-backend.isc.freebsd.org (Postfix, from userid 1346) id 2AF3DF573; Thu, 23 Jul 2015 19:32:03 +0000 (UTC) Date: Thu, 23 Jul 2015 19:32:03 +0000 To: freebsd-toolchain@freebsd.org From: "brooks (Brooks Davis)" Reply-to: D2338+334+aa8d418be5da1de7@FreeBSD.org Subject: [Differential] [Accepted] D2338: readelf: avoid division by zero for files with invalid sh_entsize Message-ID: <597b4235502b977b7b1f9348eec4e393@localhost.localdomain> X-Priority: 3 Thread-Topic: D2338: readelf: avoid division by zero for files with invalid sh_entsize X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: X-Phabricator-Cc: In-Reply-To: References: Thread-Index: ZmMzNDdkZjZhNjRlYTVmZjk2ZjhhYzllZGEwIFWxQTM= Precedence: bulk X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: , , MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-toolchain@freebsd.org X-Mailman-Version: 2.1.20 List-Id: Maintenance of FreeBSD's integrated toolchain List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Jul 2015 19:32:03 -0000 brooks accepted this revision. brooks added a comment. This revision has a positive review. Looks good to me. REVISION DETAIL https://reviews.freebsd.org/D2338 EMAIL PREFERENCES https://reviews.freebsd.org/settings/panel/emailpreferences/ To: emaste, brooks Cc: brooks, freebsd-toolchain-list From owner-freebsd-toolchain@freebsd.org Thu Jul 23 19:40:58 2015 Return-Path: Delivered-To: freebsd-toolchain@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id EA6E89A9261 for ; Thu, 23 Jul 2015 19:40:58 +0000 (UTC) (envelope-from daemon-user@freebsd.org) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) by mx1.freebsd.org (Postfix) with ESMTP id D529A1FD1 for ; Thu, 23 Jul 2015 19:40:58 +0000 (UTC) (envelope-from daemon-user@freebsd.org) Received: by phabric-backend.isc.freebsd.org (Postfix, from userid 1346) id D15E7FCCC; Thu, 23 Jul 2015 19:40:58 +0000 (UTC) Date: Thu, 23 Jul 2015 19:40:58 +0000 To: freebsd-toolchain@freebsd.org From: "emaste (Ed Maste)" Reply-to: D3175+334+32b8b29263f87821@FreeBSD.org Subject: [Differential] [Request, 39 lines] D3175: ar: add -U (unique) option to disable -D (deterministic) mode Message-ID: X-Priority: 3 Thread-Topic: D3175: ar: add -U (unique) option to disable -D (deterministic) mode X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: Thread-Index: MTI4YzAwYTA4NWZiNmYzMzcwMmM5MjU2Njhi Precedence: bulk X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: , , , MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="b1_6dc2362b3e8e4c6211d736c09095df5c" X-BeenThere: freebsd-toolchain@freebsd.org X-Mailman-Version: 2.1.20 List-Id: Maintenance of FreeBSD's integrated toolchain List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Jul 2015 19:40:59 -0000 --b1_6dc2362b3e8e4c6211d736c09095df5c Content-Type: text/plain; charset = "utf-8" Content-Transfer-Encoding: 8bit emaste created this revision. emaste added reviewers: brooks, bapt. emaste added a subscriber: freebsd-toolchain-list. REVISION SUMMARY I'd like to make ar(1) produce deterministic output by default. In order to do so we'll first need an option to turn off deterministic mode. Note that this is against upstream ELF Tool Chain ar(1), which is a little different from the one in the FreeBSD tree. I plan to migrate to ELF Tool Chain's eventually, but this change should apply (perhaps with trivial modification) to FreeBSD's. REVISION DETAIL https://reviews.freebsd.org/D3175 AFFECTED FILES ar/ar.1 ar/ar.c EMAIL PREFERENCES https://reviews.freebsd.org/settings/panel/emailpreferences/ To: emaste, brooks, bapt Cc: freebsd-toolchain-list --b1_6dc2362b3e8e4c6211d736c09095df5c Content-Type: text/x-patch; charset=utf-8; name="D3175.7235.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="D3175.7235.patch" ZGlmZiAtLWdpdCBhL2FyL2FyLmMgYi9hci9hci5jCi0tLSBhL2FyL2FyLmMKKysrIGIvYXIvYXIu YwpAQCAtMTIzLDE1ICsxMjMsMTggQEAKIAlsZW4gPSBzdHJsZW4oYnNkYXItPnByb2duYW1lKTsK IAlpZiAobGVuID49IHN0cmxlbigicmFubGliIikgJiYKIAkgICAgc3RyY21wKGJzZGFyLT5wcm9n bmFtZSArIGxlbiAtIHN0cmxlbigicmFubGliIiksICJyYW5saWIiKSA9PSAwKSB7Ci0JCXdoaWxl ICgob3B0ID0gZ2V0b3B0X2xvbmcoYXJnYywgYXJndiwgInREViIsIGxvbmdvcHRzLAorCQl3aGls ZSAoKG9wdCA9IGdldG9wdF9sb25nKGFyZ2MsIGFyZ3YsICJ0RFVWIiwgbG9uZ29wdHMsCiAJCSAg ICBOVUxMKSkgIT0gLTEpIHsKIAkJCXN3aXRjaChvcHQpIHsKIAkJCWNhc2UgJ3QnOgogCQkJCS8q IElnbm9yZWQuICovCiAJCQkJYnJlYWs7CiAJCQljYXNlICdEJzoKIAkJCQlic2Rhci0+b3B0aW9u cyB8PSBBUl9EOwogCQkJCWJyZWFrOworCQkJY2FzZSAnVSc6CisJCQkJYnNkYXItPm9wdGlvbnMg Jj0gfkFSX0Q7CisJCQkJYnJlYWs7CiAJCQljYXNlICdWJzoKIAkJCQlic2Rhcl92ZXJzaW9uKCk7 CiAJCQkJYnJlYWs7CkBAIC0xNjksNyArMTcyLDcgQEAKIAkJfQogCX0KIAotCXdoaWxlICgob3B0 ID0gZ2V0b3B0X2xvbmcoYXJnYywgYXJndiwgImFiQ2NkRGZGOmlqbE1tb3BxclNzVHR1VnZ4eiIs CisJd2hpbGUgKChvcHQgPSBnZXRvcHRfbG9uZyhhcmdjLCBhcmd2LCAiYWJDY2REZkY6aWpsTW1v cHFyU3NUdFV1VnZ4eiIsCiAJICAgIGxvbmdvcHRzLCBOVUxMKSkgIT0gLTEpIHsKIAkJc3dpdGNo KG9wdCkgewogCQljYXNlICdhJzoKQEAgLTIzNyw2ICsyNDAsOSBAQAogCQljYXNlICd0JzoKIAkJ CXNldF9tb2RlKGJzZGFyLCBvcHQpOwogCQkJYnJlYWs7CisJCWNhc2UgJ1UnOgorCQkJYnNkYXIt Pm9wdGlvbnMgJj0gfkFSX0Q7CisJCQlicmVhazsKIAkJY2FzZSAndSc6CiAJCQlic2Rhci0+b3B0 aW9ucyB8PSBBUl9VOwogCQkJYnJlYWs7CkBAIC00MDAsNyArNDA2LDggQEAKICAgLUQgICAgICAg ICAgICBVc2UgZml4ZWQgbWV0YWRhdGEsIGZvciBjb25zaXN0ZW50IGFyY2hpdmUgY2hlY2tzdW1z LlxuXAogICAtRiBGT1JNQVQgfCAtLWZsYXZvcj1GT1JNQVRcblwKICAgICAgICAgICAgICAgICBD cmVhdGUgYXJjaGl2ZXMgd2l0aCB0aGUgc3BlY2lmaWVkIGZvcm1hdC5cblwKLSAgLVMgICAgICAg ICAgICBEbyBub3QgZ2VuZXJhdGUgYW4gYXJjaGl2ZSBzeW1ib2wgdGFibGUuXG4iCisgIC1TICAg ICAgICAgICAgRG8gbm90IGdlbmVyYXRlIGFuIGFyY2hpdmUgc3ltYm9sIHRhYmxlLlxuXAorICAt VSAgICAgICAgICAgIFVzZSBvcmlnaW5hbCBtZXRhZGF0YSwgZm9yIHVuaXF1ZSBhcmNoaXZlIGNo ZWNrc3Vtcy5cbiIKIAogc3RhdGljIHZvaWQKIGJzZGFyX3VzYWdlKHZvaWQpCkBAIC00MTUsNiAr NDIyLDcgQEAKICAgT3B0aW9uczpcblwKICAgLXQgICAgICAgICAgICAgIChUaGlzIG9wdGlvbiBp cyBhY2NlcHRlZCwgYnV0IGlnbm9yZWQpLlxuXAogICAtRCAgICAgICAgICAgICAgVXNlIGZpeGVk IG1ldGFkYXRhLCBmb3IgY29uc2lzdGVudCBhcmNoaXZlIGNoZWNrc3Vtcy5cblwKKyAgLVUgICAg ICAgICAgICAgIFVzZSBvcmlnaW5hbCBtZXRhZGF0YSwgZm9yIHVuaXF1ZSBhcmNoaXZlIGNoZWNr c3Vtcy5cblwKICAgLVYgICAgICAgICAgICAgIFByaW50IGEgdmVyc2lvbiBpZGVudGlmaWVyIGFu ZCBleGl0LlxuIgogCiBzdGF0aWMgdm9pZApkaWZmIC0tZ2l0IGEvYXIvYXIuMSBiL2FyL2FyLjEK LS0tIGEvYXIvYXIuMQorKysgYi9hci9hci4xCkBAIC0yMyw3ICsyMyw3IEBACiAuXCIKIC5cIiAk SWQkCiAuXCIKLS5EZCBEZWNlbWJlciAxMCwgMjAxMgorLkRkIEp1bHkgMjMsIDIwMTUKIC5Pcwog LkR0IEFSIDEKIC5TaCBOQU1FCkBAIC02Niw2ICs2Niw3IEBACiAuT3AgRmwgZgogLk9wIEZsIEYg QXIgZmxhdm9yIHwgRmwgLWZsYXZvciBBciBmbGF2b3IKIC5PcCBGbCBzIHwgRmwgUworLk9wIEZs IFUKIC5PcCBGbCB2CiAuT3AgRmwgegogLkFyIGFyY2hpdmUKQEAgLTgzLDE0ICs4NCwxNiBAQAog Lk9wIEZsIGoKIC5PcCBGbCBzIHwgRmwgUwogLk9wIEZsIHUKKy5PcCBGbCBVCiAuT3AgRmwgdgog Lk9wIEZsIHoKIC5BciBhcmNoaXZlCiAuQXIKIC5ObQogLkZsIHMKIC5PcCBGbCBECiAuT3AgRmwg agorLk9wIEZsIFUKIC5PcCBGbCB6CiAuQXIgYXJjaGl2ZQogLk5tCkBAIC0yMDMsNiArMjA2LDEy IEBACiAuQXIgLgogVGhpcyBlbnN1cmVzIHRoYXQgY2hlY2tzdW1zIG9uIHRoZSByZXN1bHRpbmcg YXJjaGl2ZXMgYXJlIHJlcHJvZHVjaWJsZQogd2hlbiBtZW1iZXIgY29udGVudHMgYXJlIGlkZW50 aWNhbC4KK0lmIHRoZQorLkl0IEZsIEQKK2FuZAorLkl0IEZsIFUKK29wdGlvbnMgYXJlIGJvdGgg c3BlY2lmaWVkLCB0aGUgb25lIHNwZWNpZmllZCBsYXRlciBpbiB0aGUgY29tbWFuZCBsaW5lCit0 YWtlcyBlZmZlY3QuCiAuSXQgRmwgZgogU3lub255bW91cyB3aXRoIG9wdGlvbgogLkZsIFQgLgpA QCAtMzM1LDYgKzM0NCwyMCBAQAogLkFyCiB3aWxsIGJlIGV4dHJhY3RlZCBvbmx5IGlmIHRoZXkg YXJlIG5ld2VyIHRoYW4gdGhlIGNvcnJlc3BvbmRpbmcKIGZpbGVzIGluIHRoZSBmaWxlIHN5c3Rl bS4KKy5JdCBGbCBVCitXaGVuIHVzZWQgaW4gY29tYmluYXRpb24gd2l0aCB0aGUKKy5GbCByCitv cgorLkZsIHEKK29wdGlvbiwgaW5zZXJ0IHRoZSByZWFsIG10aW1lLCB1aWQgYW5kIGdpZCwgYW5k IGZpbGUgbW9kZSB2YWx1ZXMKK2Zyb20gdGhlIG1lbWJlcnMgbmFtZWQgYnkgYXJndW1lbnRzCisu QXIgLgorSWYgdGhlCisuSXQgRmwgRAorYW5kCisuSXQgRmwgVQorb3B0aW9ucyBhcmUgYm90aCBz cGVjaWZpZWQsIHRoZSBvbmUgc3BlY2lmaWVkIGxhdGVyIGluIHRoZSBjb21tYW5kIGxpbmUKK3Rh a2VzIGVmZmVjdC4KIC5JdCBGbCB2CiBQcm92aWRlIHZlcmJvc2Ugb3V0cHV0LgogV2hlbiB1c2Vk IHdpdGggdGhlCgo= --b1_6dc2362b3e8e4c6211d736c09095df5c-- From owner-freebsd-toolchain@freebsd.org Thu Jul 23 19:44:37 2015 Return-Path: Delivered-To: freebsd-toolchain@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 7DBB69A927E for ; Thu, 23 Jul 2015 19:44:37 +0000 (UTC) (envelope-from daemon-user@freebsd.org) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) by mx1.freebsd.org (Postfix) with ESMTP id 6855A10D9 for ; Thu, 23 Jul 2015 19:44:37 +0000 (UTC) (envelope-from daemon-user@freebsd.org) Received: by phabric-backend.isc.freebsd.org (Postfix, from userid 1346) id 61032F018; Thu, 23 Jul 2015 19:44:37 +0000 (UTC) Date: Thu, 23 Jul 2015 19:44:37 +0000 To: freebsd-toolchain@freebsd.org From: "imp (Warner Losh)" Reply-to: D3175+334+32b8b29263f87821@FreeBSD.org Subject: [Differential] [Accepted] D3175: ar: add -U (unique) option to disable -D (deterministic) mode Message-ID: <810e9974dfcabc26805f8f6696b7d06a@localhost.localdomain> X-Priority: 3 Thread-Topic: D3175: ar: add -U (unique) option to disable -D (deterministic) mode X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: In-Reply-To: References: Thread-Index: MTI4YzAwYTA4NWZiNmYzMzcwMmM5MjU2NjhiIFWxRCU= Precedence: bulk X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: , MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-toolchain@freebsd.org X-Mailman-Version: 2.1.20 List-Id: Maintenance of FreeBSD's integrated toolchain List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Jul 2015 19:44:37 -0000 imp accepted this revision. imp added a reviewer: imp. This revision has a positive review. REVISION DETAIL https://reviews.freebsd.org/D3175 EMAIL PREFERENCES https://reviews.freebsd.org/settings/panel/emailpreferences/ To: emaste, brooks, bapt, imp Cc: freebsd-toolchain-list From owner-freebsd-toolchain@freebsd.org Thu Jul 23 20:03:26 2015 Return-Path: Delivered-To: freebsd-toolchain@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 698779A97AC for ; Thu, 23 Jul 2015 20:03:26 +0000 (UTC) (envelope-from daemon-user@freebsd.org) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) by mx1.freebsd.org (Postfix) with ESMTP id 51A7C16AA for ; Thu, 23 Jul 2015 20:03:26 +0000 (UTC) (envelope-from daemon-user@freebsd.org) Received: by phabric-backend.isc.freebsd.org (Postfix, from userid 1346) id 43E2BFE6D; Thu, 23 Jul 2015 20:03:26 +0000 (UTC) Date: Thu, 23 Jul 2015 20:03:26 +0000 To: freebsd-toolchain@freebsd.org From: "brooks (Brooks Davis)" Reply-to: D3175+334+32b8b29263f87821@FreeBSD.org Subject: [Differential] [Accepted] D3175: ar: add -U (unique) option to disable -D (deterministic) mode Message-ID: <41b188e3bcf47e53244a0fdd282e28c7@localhost.localdomain> X-Priority: 3 Thread-Topic: D3175: ar: add -U (unique) option to disable -D (deterministic) mode X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: In-Reply-To: References: Thread-Index: MTI4YzAwYTA4NWZiNmYzMzcwMmM5MjU2NjhiIFWxSI4= Precedence: bulk X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: , , MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-toolchain@freebsd.org X-Mailman-Version: 2.1.20 List-Id: Maintenance of FreeBSD's integrated toolchain List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Jul 2015 20:03:26 -0000 brooks accepted this revision. brooks added a comment. Looks good to me REVISION DETAIL https://reviews.freebsd.org/D3175 EMAIL PREFERENCES https://reviews.freebsd.org/settings/panel/emailpreferences/ To: emaste, bapt, imp, brooks Cc: freebsd-toolchain-list From owner-freebsd-toolchain@freebsd.org Thu Jul 23 20:08:30 2015 Return-Path: Delivered-To: freebsd-toolchain@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id E91149A980C for ; Thu, 23 Jul 2015 20:08:30 +0000 (UTC) (envelope-from daemon-user@freebsd.org) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) by mx1.freebsd.org (Postfix) with ESMTP id CB67A1999 for ; Thu, 23 Jul 2015 20:08:30 +0000 (UTC) (envelope-from daemon-user@freebsd.org) Received: by phabric-backend.isc.freebsd.org (Postfix, from userid 1346) id C1246F2D1; Thu, 23 Jul 2015 20:08:30 +0000 (UTC) Date: Thu, 23 Jul 2015 20:08:30 +0000 To: freebsd-toolchain@freebsd.org From: "bapt (Baptiste Daroussin)" Reply-to: D3175+334+32b8b29263f87821@FreeBSD.org Subject: [Differential] [Accepted] D3175: ar: add -U (unique) option to disable -D (deterministic) mode Message-ID: X-Priority: 3 Thread-Topic: D3175: ar: add -U (unique) option to disable -D (deterministic) mode X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: In-Reply-To: References: Thread-Index: MTI4YzAwYTA4NWZiNmYzMzcwMmM5MjU2NjhiIFWxSb4= Precedence: bulk X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: , , MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-toolchain@freebsd.org X-Mailman-Version: 2.1.20 List-Id: Maintenance of FreeBSD's integrated toolchain List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Jul 2015 20:08:31 -0000 bapt accepted this revision. bapt added a comment. This is one of the changes I really needed! REVISION DETAIL https://reviews.freebsd.org/D3175 EMAIL PREFERENCES https://reviews.freebsd.org/settings/panel/emailpreferences/ To: emaste, imp, brooks, bapt Cc: freebsd-toolchain-list From owner-freebsd-toolchain@freebsd.org Fri Jul 24 17:47:03 2015 Return-Path: Delivered-To: freebsd-toolchain@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id B3B809AA511 for ; Fri, 24 Jul 2015 17:47:03 +0000 (UTC) (envelope-from daemon-user@freebsd.org) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) by mx1.freebsd.org (Postfix) with ESMTP id 9A0C6163D for ; Fri, 24 Jul 2015 17:47:03 +0000 (UTC) (envelope-from daemon-user@freebsd.org) Received: by phabric-backend.isc.freebsd.org (Postfix, from userid 1346) id 8757AF5D7; Fri, 24 Jul 2015 17:47:03 +0000 (UTC) Date: Fri, 24 Jul 2015 17:47:03 +0000 To: freebsd-toolchain@freebsd.org From: "emaste (Ed Maste)" Reply-to: D3175+334+32b8b29263f87821@FreeBSD.org Subject: [Differential] [Closed] D3175: ar: add -U (unique) option to disable -D (deterministic) mode Message-ID: <8ba5fbd0c905887b8c24784fad71eaad@localhost.localdomain> X-Priority: 3 Thread-Topic: D3175: ar: add -U (unique) option to disable -D (deterministic) mode X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: In-Reply-To: References: Thread-Index: MTI4YzAwYTA4NWZiNmYzMzcwMmM5MjU2NjhiIFWyehc= Precedence: bulk X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: , MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="b1_8ba5fbd0c905887b8c24784fad71eaad" X-BeenThere: freebsd-toolchain@freebsd.org X-Mailman-Version: 2.1.20 List-Id: Maintenance of FreeBSD's integrated toolchain List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Jul 2015 17:47:03 -0000 --b1_8ba5fbd0c905887b8c24784fad71eaad Content-Type: text/plain; charset = "utf-8" Content-Transfer-Encoding: 8bit This revision was automatically updated to reflect the committed changes. Closed by commit rS285844: ar: add -U (unique) option to disable -D (deterministic) mode (authored by emaste). CHANGED PRIOR TO COMMIT https://reviews.freebsd.org/D3175?vs=7235&id=7268#toc REPOSITORY rS FreeBSD src repository CHANGES SINCE LAST UPDATE https://reviews.freebsd.org/D3175?vs=7235&id=7268 REVISION DETAIL https://reviews.freebsd.org/D3175 AFFECTED FILES head/usr.bin/ar/ar.1 head/usr.bin/ar/ar.c EMAIL PREFERENCES https://reviews.freebsd.org/settings/panel/emailpreferences/ To: emaste, imp, brooks, bapt Cc: freebsd-toolchain-list --b1_8ba5fbd0c905887b8c24784fad71eaad Content-Type: text/x-patch; charset=utf-8; name="D3175.7268.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="D3175.7268.patch" ZGlmZiAtLWdpdCBhL2hlYWQvdXNyLmJpbi9hci9hci4xIGIvaGVhZC91c3IuYmluL2FyL2FyLjEK LS0tIGEvaGVhZC91c3IuYmluL2FyL2FyLjEKKysrIGIvaGVhZC91c3IuYmluL2FyL2FyLjEKQEAg LTIzLDcgKzIzLDcgQEAKIC5cIgogLlwiICRGcmVlQlNEJAogLlwiCi0uRGQgRGVjZW1iZXIgMjIs IDIwMTEKKy5EZCBKdWx5IDI0LCAyMDE1CiAuRHQgQVIgMQogLk9zCiAuU2ggTkFNRQpAQCAtNjYs NiArNjYsNyBAQAogLk9wIEZsIEQKIC5PcCBGbCBmCiAuT3AgRmwgcyB8IEZsIFMKKy5PcCBGbCBV CiAuT3AgRmwgdgogLk9wIEZsIHoKIC5BciBhcmNoaXZlCkBAIC04Miw2ICs4Myw3IEBACiAuT3Ag RmwgagogLk9wIEZsIHMgfCBGbCBTCiAuT3AgRmwgdQorLk9wIEZsIFUKIC5PcCBGbCB2CiAuT3Ag RmwgegogLkFyIGFyY2hpdmUKQEAgLTExMiw2ICsxMTQsNyBAQAogLkZsIE0KIC5ObSByYW5saWIK IC5PcCBGbCBECisuT3AgRmwgVQogLkFyIGFyY2hpdmUgLi4uCiAuU2ggREVTQ1JJUFRJT04KIFRo ZQpAQCAtMjA3LDYgKzIxMCwxMSBAQAogLkFyIC4KIFRoaXMgZW5zdXJlcyB0aGF0IGNoZWNrc3Vt cyBvbiB0aGUgcmVzdWx0aW5nIGFyY2hpdmVzIGFyZSByZXByb2R1Y2libGUKIHdoZW4gbWVtYmVy IGNvbnRlbnRzIGFyZSBpZGVudGljYWwuCitJZiBtdWx0aXBsZQorLkZsIEQKK2FuZAorLkZsIFUK K29wdGlvbnMgYXJlIHNwZWNpZmllZCBvbiB0aGUgY29tbWFuZCBsaW5lLCB0aGUgZmluYWwgb25l IHRha2VzIHByZWNlZGVuY2UuCiAuSXQgRmwgZgogU3lub255bW91cyB3aXRoIG9wdGlvbgogLkZs IFQgLgpAQCAtMzE2LDYgKzMyNCwxOSBAQAogLkFyCiB3aWxsIGJlIGV4dHJhY3RlZCBvbmx5IGlm IHRoZXkgYXJlIG5ld2VyIHRoYW4gdGhlIGNvcnJlc3BvbmRpbmcKIGZpbGVzIGluIHRoZSBmaWxl IHN5c3RlbS4KKy5JdCBGbCBVCitXaGVuIHVzZWQgaW4gY29tYmluYXRpb24gd2l0aCB0aGUKKy5G bCByCitvcgorLkZsIHEKK29wdGlvbiwgaW5zZXJ0IHRoZSByZWFsIG10aW1lLCB1aWQgYW5kIGdp ZCwgYW5kIGZpbGUgbW9kZSB2YWx1ZXMKK2Zyb20gdGhlIG1lbWJlcnMgbmFtZWQgYnkgYXJndW1l bnRzCisuQXIgLgorSWYgbXVsdGlwbGUKKy5GbCBECithbmQKKy5GbCBVCitvcHRpb25zIGFyZSBz cGVjaWZpZWQgb24gdGhlIGNvbW1hbmQgbGluZSwgdGhlIGZpbmFsIG9uZSB0YWtlcyBwcmVjZWRl bmNlLgogLkl0IEZsIHYKIFByb3ZpZGUgdmVyYm9zZSBvdXRwdXQuCiBXaGVuIHVzZWQgd2l0aCB0 aGUKZGlmZiAtLWdpdCBhL2hlYWQvdXNyLmJpbi9hci9hci5jIGIvaGVhZC91c3IuYmluL2FyL2Fy LmMKLS0tIGEvaGVhZC91c3IuYmluL2FyL2FyLmMKKysrIGIvaGVhZC91c3IuYmluL2FyL2FyLmMK QEAgLTExMywxNSArMTEzLDE4IEBACiAJbGVuID0gc3RybGVuKGJzZGFyLT5wcm9nbmFtZSk7CiAJ aWYgKGxlbiA+PSBzdHJsZW4oInJhbmxpYiIpICYmCiAJICAgIHN0cmNtcChic2Rhci0+cHJvZ25h bWUgKyBsZW4gLSBzdHJsZW4oInJhbmxpYiIpLCAicmFubGliIikgPT0gMCkgewotCQl3aGlsZSAo KG9wdCA9IGdldG9wdF9sb25nKGFyZ2MsIGFyZ3YsICJ0RFYiLCBsb25nb3B0cywKKwkJd2hpbGUg KChvcHQgPSBnZXRvcHRfbG9uZyhhcmdjLCBhcmd2LCAidERVViIsIGxvbmdvcHRzLAogCQkgICAg TlVMTCkpICE9IC0xKSB7CiAJCQlzd2l0Y2gob3B0KSB7CiAJCQljYXNlICd0JzoKIAkJCQkvKiBJ Z25vcmVkLiAqLwogCQkJCWJyZWFrOwogCQkJY2FzZSAnRCc6CiAJCQkJYnNkYXItPm9wdGlvbnMg fD0gQVJfRDsKIAkJCQlicmVhazsKKwkJCWNhc2UgJ1UnOgorCQkJCWJzZGFyLT5vcHRpb25zICY9 IH5BUl9EOworCQkJCWJyZWFrOwogCQkJY2FzZSAnVic6CiAJCQkJcmFubGliX3ZlcnNpb24oKTsK IAkJCQlicmVhazsKQEAgLTE1Nyw3ICsxNjAsNyBAQAogCQl9CiAJfQogCi0Jd2hpbGUgKChvcHQg PSBnZXRvcHRfbG9uZyhhcmdjLCBhcmd2LCAiYWJDY2REZmlqbE1tb3BxclNzVHR1VnZ4eiIsCisJ d2hpbGUgKChvcHQgPSBnZXRvcHRfbG9uZyhhcmdjLCBhcmd2LCAiYWJDY2REZmlqbE1tb3BxclNz VHRVdVZ2eHoiLAogCSAgICBsb25nb3B0cywgTlVMTCkpICE9IC0xKSB7CiAJCXN3aXRjaChvcHQp IHsKIAkJY2FzZSAnYSc6CkBAIC0yMTYsNiArMjE5LDkgQEAKIAkJY2FzZSAndCc6CiAJCQlzZXRf bW9kZShic2Rhciwgb3B0KTsKIAkJCWJyZWFrOworCQljYXNlICdVJzoKKwkJCWJzZGFyLT5vcHRp b25zICY9IH5BUl9EOworCQkJYnJlYWs7CiAJCWNhc2UgJ3UnOgogCQkJYnNkYXItPm9wdGlvbnMg fD0gQVJfVTsKIAkJCWJyZWFrOwpAQCAtMzY0LDkgKzM3MCw5IEBACiAJKHZvaWQpZnByaW50Zihz dGRlcnIsICJcdGFyIC1tIFstVGpzdnpdIGFyY2hpdmUgZmlsZSAuLi5cbiIpOwogCSh2b2lkKWZw cmludGYoc3RkZXJyLCAiXHRhciAtbSBbLVRhYmlqc3Z6XSBwb3NpdGlvbiBhcmNoaXZlIGZpbGUg Li4uXG4iKTsKIAkodm9pZClmcHJpbnRmKHN0ZGVyciwgIlx0YXIgLXAgWy1Udl0gYXJjaGl2ZSBb ZmlsZSAuLi5dXG4iKTsKLQkodm9pZClmcHJpbnRmKHN0ZGVyciwgIlx0YXIgLXEgWy1UY0Rqc3Z6 XSBhcmNoaXZlIGZpbGUgLi4uXG4iKTsKLQkodm9pZClmcHJpbnRmKHN0ZGVyciwgIlx0YXIgLXIg Wy1UY0Rqc3V2el0gYXJjaGl2ZSBmaWxlIC4uLlxuIik7Ci0JKHZvaWQpZnByaW50ZihzdGRlcnIs ICJcdGFyIC1yIFstVGFiY0RpanN1dnpdIHBvc2l0aW9uIGFyY2hpdmUgZmlsZSAuLi5cbiIpOwor CSh2b2lkKWZwcmludGYoc3RkZXJyLCAiXHRhciAtcSBbLVRjRGpzVXZ6XSBhcmNoaXZlIGZpbGUg Li4uXG4iKTsKKwkodm9pZClmcHJpbnRmKHN0ZGVyciwgIlx0YXIgLXIgWy1UY0Rqc1V1dnpdIGFy Y2hpdmUgZmlsZSAuLi5cbiIpOworCSh2b2lkKWZwcmludGYoc3RkZXJyLCAiXHRhciAtciBbLVRh YmNEaWpzVXV2el0gcG9zaXRpb24gYXJjaGl2ZSBmaWxlIC4uLlxuIik7CiAJKHZvaWQpZnByaW50 ZihzdGRlcnIsICJcdGFyIC1zIFstanpdIGFyY2hpdmVcbiIpOwogCSh2b2lkKWZwcmludGYoc3Rk ZXJyLCAiXHRhciAtdCBbLVR2XSBhcmNoaXZlIFtmaWxlIC4uLl1cbiIpOwogCSh2b2lkKWZwcmlu dGYoc3RkZXJyLCAiXHRhciAteCBbLUNUb3V2XSBhcmNoaXZlIFtmaWxlIC4uLl1cbiIpOwpAQCAt Mzc4LDcgKzM4NCw3IEBACiByYW5saWJfdXNhZ2Uodm9pZCkKIHsKIAotCSh2b2lkKWZwcmludGYo c3RkZXJyLCAidXNhZ2U6CXJhbmxpYiBbLXRdIGFyY2hpdmUgLi4uXG4iKTsKKwkodm9pZClmcHJp bnRmKHN0ZGVyciwgInVzYWdlOglyYW5saWIgWy1EdFVdIGFyY2hpdmUgLi4uXG4iKTsKIAkodm9p ZClmcHJpbnRmKHN0ZGVyciwgIlx0cmFubGliIC1WXG4iKTsKIAlleGl0KEVYX1VTQUdFKTsKIH0K Cg== --b1_8ba5fbd0c905887b8c24784fad71eaad-- From owner-freebsd-toolchain@freebsd.org Fri Jul 24 18:01:09 2015 Return-Path: Delivered-To: freebsd-toolchain@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 81B219AA85E for ; Fri, 24 Jul 2015 18:01:09 +0000 (UTC) (envelope-from daemon-user@freebsd.org) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) by mx1.freebsd.org (Postfix) with ESMTP id 67EA91F4D for ; Fri, 24 Jul 2015 18:01:09 +0000 (UTC) (envelope-from daemon-user@freebsd.org) Received: by phabric-backend.isc.freebsd.org (Postfix, from userid 1346) id 57DB8F62D; Fri, 24 Jul 2015 18:01:09 +0000 (UTC) Date: Fri, 24 Jul 2015 18:01:09 +0000 To: freebsd-toolchain@freebsd.org From: "emaste (Ed Maste)" Reply-to: D2338+334+aa8d418be5da1de7@FreeBSD.org Subject: [Differential] [Closed] D2338: readelf: avoid division by zero for files with invalid sh_entsize Message-ID: <627afc60ec88d368400d3ad626d694d0@localhost.localdomain> X-Priority: 3 Thread-Topic: D2338: readelf: avoid division by zero for files with invalid sh_entsize X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: X-Phabricator-Cc: In-Reply-To: References: Thread-Index: ZmMzNDdkZjZhNjRlYTVmZjk2ZjhhYzllZGEwIFWyfWU= Precedence: bulk X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: , MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="b1_627afc60ec88d368400d3ad626d694d0" X-BeenThere: freebsd-toolchain@freebsd.org X-Mailman-Version: 2.1.20 List-Id: Maintenance of FreeBSD's integrated toolchain List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Jul 2015 18:01:09 -0000 --b1_627afc60ec88d368400d3ad626d694d0 Content-Type: text/plain; charset = "utf-8" Content-Transfer-Encoding: 8bit This revision was automatically updated to reflect the committed changes. Closed by commit rS285845: readelf: avoid division by zero on section entry size (authored by emaste). CHANGED PRIOR TO COMMIT https://reviews.freebsd.org/D2338?vs=7069&id=7269#toc REPOSITORY rS FreeBSD src repository CHANGES SINCE LAST UPDATE https://reviews.freebsd.org/D2338?vs=7069&id=7269 REVISION DETAIL https://reviews.freebsd.org/D2338 AFFECTED FILES head/contrib/elftoolchain/readelf/readelf.c EMAIL PREFERENCES https://reviews.freebsd.org/settings/panel/emailpreferences/ To: emaste, brooks Cc: brooks, freebsd-toolchain-list --b1_627afc60ec88d368400d3ad626d694d0 Content-Type: text/x-patch; charset=utf-8; name="D2338.7269.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="D2338.7269.patch" ZGlmZiAtLWdpdCBhL2hlYWQvY29udHJpYi9lbGZ0b29sY2hhaW4vcmVhZGVsZi9yZWFkZWxmLmMg Yi9oZWFkL2NvbnRyaWIvZWxmdG9vbGNoYWluL3JlYWRlbGYvcmVhZGVsZi5jCi0tLSBhL2hlYWQv Y29udHJpYi9lbGZ0b29sY2hhaW4vcmVhZGVsZi9yZWFkZWxmLmMKKysrIGIvaGVhZC9jb250cmli L2VsZnRvb2xjaGFpbi9yZWFkZWxmL3JlYWRlbGYuYwpAQCAtMjcsNiArMjcsNyBAQAogI2luY2x1 ZGUgPHN5cy9wYXJhbS5oPgogI2luY2x1ZGUgPHN5cy9xdWV1ZS5oPgogI2luY2x1ZGUgPGFyLmg+ CisjaW5jbHVkZSA8YXNzZXJ0Lmg+CiAjaW5jbHVkZSA8Y3R5cGUuaD4KICNpbmNsdWRlIDxkd2Fy Zi5oPgogI2luY2x1ZGUgPGVyci5oPgpAQCAtMzE0LDYgKzMxNSw3IEBACiBzdGF0aWMgY29uc3Qg Y2hhciAqZHdhcmZfcmVnbmFtZShzdHJ1Y3QgcmVhZGVsZiAqcmUsIHVuc2lnbmVkIGludCBudW0p Owogc3RhdGljIHN0cnVjdCBkdW1wb3AgKmZpbmRfZHVtcG9wKHN0cnVjdCByZWFkZWxmICpyZSwg c2l6ZV90IHNpLAogICAgIGNvbnN0IGNoYXIgKnNuLCBpbnQgb3AsIGludCB0KTsKK3N0YXRpYyBp bnQgZ2V0X2VudF9jb3VudChzdHJ1Y3Qgc2VjdGlvbiAqcywgaW50ICplbnRfY291bnQpOwogc3Rh dGljIGNoYXIgKmdldF9yZWdvZmZfc3RyKHN0cnVjdCByZWFkZWxmICpyZSwgRHdhcmZfSGFsZiBy ZWcsCiAgICAgRHdhcmZfQWRkciBvZmYpOwogc3RhdGljIGNvbnN0IGNoYXIgKmdldF9zdHJpbmco c3RydWN0IHJlYWRlbGYgKnJlLCBpbnQgc3RydGFiLCBzaXplX3Qgb2ZmKTsKQEAgLTI5MDEsNiAr MjkwMywyNCBAQAogI3VuZGVmCVNUX0NUTAogfQogCisvKgorICogUmV0dXJuIG51bWJlciBvZiBl bnRyaWVzIGluIHRoZSBnaXZlbiBzZWN0aW9uLiBXZSdkIHByZWZlciBlbnRfY291bnQgYmUgYQor ICogc2l6ZV90ICosIGJ1dCBsaWJlbGYgQVBJcyBhbHJlYWR5IHVzZSBpbnQgZm9yIHNlY3Rpb24g aW5kaWNlcy4KKyAqLworc3RhdGljIGludAorZ2V0X2VudF9jb3VudChzdHJ1Y3Qgc2VjdGlvbiAq cywgaW50ICplbnRfY291bnQpCit7CisJaWYgKHMtPmVudHNpemUgPT0gMCkgeworCQl3YXJueCgi c2VjdGlvbiAlcyBoYXMgZW50cnkgc2l6ZSAwIiwgcy0+bmFtZSk7CisJCXJldHVybiAoMCk7CisJ fSBlbHNlIGlmIChzLT5zeiAvIHMtPmVudHNpemUgPiBJTlRfTUFYKSB7CisJCXdhcm54KCJzZWN0 aW9uICVzIGhhcyBpbnZhbGlkIHNlY3Rpb24gY291bnQiLCBzLT5uYW1lKTsKKwkJcmV0dXJuICgw KTsKKwl9CisJKmVudF9jb3VudCA9IChpbnQpKHMtPnN6IC8gcy0+ZW50c2l6ZSk7CisJcmV0dXJu ICgxKTsKK30KKwogc3RhdGljIHZvaWQKIGR1bXBfZHluYW1pYyhzdHJ1Y3QgcmVhZGVsZiAqcmUp CiB7CkBAIC0yOTI5LDggKzI5NDksOCBAQAogCiAJCS8qIERldGVybWluZSB0aGUgYWN0dWFsIG51 bWJlciBvZiB0YWJsZSBlbnRyaWVzLiAqLwogCQluZW50cmllcyA9IDA7Ci0JCWptYXggPSAoaW50 KSAocy0+c3ogLyBzLT5lbnRzaXplKTsKLQorCQlpZiAoIWdldF9lbnRfY291bnQocywgJmptYXgp KQorCQkJY29udGludWU7CiAJCWZvciAoaiA9IDA7IGogPCBqbWF4OyBqKyspIHsKIAkJCWlmIChn ZWxmX2dldGR5bihkLCBqLCAmZHluKSAhPSAmZHluKSB7CiAJCQkJd2FybngoImdlbGZfZ2V0ZHlu IGZhaWxlZDogJXMiLApAQCAtMzE3Niw3ICszMTk2LDkgQEAKIAkJZWxzZQogCQkJcHJpbnRmKCIl LTEycyAlLTEycyAlLTE5cyAlLTE2cyAlc1xuIiwgUkVMX0hEUik7CiAJfQotCWxlbiA9IGQtPmRf c2l6ZSAvIHMtPmVudHNpemU7CisJYXNzZXJ0KGQtPmRfc2l6ZSA9PSBzLT5zeik7CisJaWYgKCFn ZXRfZW50X2NvdW50KHMsICZsZW4pKQorCQlyZXR1cm47CiAJZm9yIChpID0gMDsgaSA8IGxlbjsg aSsrKSB7CiAJCWlmIChnZWxmX2dldHJlbChkLCBpLCAmcikgIT0gJnIpIHsKIAkJCXdhcm54KCJn ZWxmX2dldHJlbCBmYWlsZWQ6ICVzIiwgZWxmX2Vycm1zZygtMSkpOwpAQCAtMzIzMiw3ICszMjU0 LDkgQEAKIAkJZWxzZQogCQkJcHJpbnRmKCIlLTEycyAlLTEycyAlLTE5cyAlLTE2cyAlc1xuIiwg UkVMQV9IRFIpOwogCX0KLQlsZW4gPSBkLT5kX3NpemUgLyBzLT5lbnRzaXplOworCWFzc2VydChk LT5kX3NpemUgPT0gcy0+c3opOworCWlmICghZ2V0X2VudF9jb3VudChzLCAmbGVuKSkKKwkJcmV0 dXJuOwogCWZvciAoaSA9IDA7IGkgPCBsZW47IGkrKykgewogCQlpZiAoZ2VsZl9nZXRyZWxhKGQs IGksICZyKSAhPSAmcikgewogCQkJd2FybngoImdlbGZfZ2V0cmVsIGZhaWxlZDogJXMiLCBlbGZf ZXJybXNnKC0xKSk7CkBAIC0zMjk3LDcgKzMzMjEsNyBAQAogCUVsZl9EYXRhICpkOwogCUdFbGZf U3ltIHN5bTsKIAljb25zdCBjaGFyICpuYW1lOwotCWludCBlbGZlcnIsIHN0YWIsIGo7CisJaW50 IGVsZmVyciwgc3RhYiwgaiwgbGVuOwogCiAJcyA9ICZyZS0+c2xbaV07CiAJc3RhYiA9IHMtPmxp bms7CkBAIC0zMzEwLDEyICszMzM0LDE0IEBACiAJfQogCWlmIChkLT5kX3NpemUgPD0gMCkKIAkJ cmV0dXJuOworCWlmICghZ2V0X2VudF9jb3VudChzLCAmbGVuKSkKKwkJcmV0dXJuOwogCXByaW50 ZigiU3ltYm9sIHRhYmxlICglcykiLCBzLT5uYW1lKTsKLQlwcmludGYoIiBjb250YWlucyAlanUg ZW50cmllczpcbiIsIHMtPnN6IC8gcy0+ZW50c2l6ZSk7CisJcHJpbnRmKCIgY29udGFpbnMgJWQg ZW50cmllczpcbiIsIGxlbik7CiAJcHJpbnRmKCIlN3MlOXMlMTRzJTVzJThzJTZzJTlzJTVzXG4i LCAiTnVtOiIsICJWYWx1ZSIsICJTaXplIiwgIlR5cGUiLAogCSAgICAiQmluZCIsICJWaXMiLCAi TmR4IiwgIk5hbWUiKTsKIAotCWZvciAoaiA9IDA7ICh1aW50NjRfdClqIDwgcy0+c3ogLyBzLT5l bnRzaXplOyBqKyspIHsKKwlmb3IgKGogPSAwOyBqIDwgbGVuOyBqKyspIHsKIAkJaWYgKGdlbGZf Z2V0c3ltKGQsIGosICZzeW0pICE9ICZzeW0pIHsKIAkJCXdhcm54KCJnZWxmX2dldHN5bSBmYWls ZWQ6ICVzIiwgZWxmX2Vycm1zZygtMSkpOwogCQkJY29udGludWU7CkBAIC0zMzUzLDcgKzMzNzks NyBAQAogCUVsZl9EYXRhICpkOwogCXN0cnVjdCBzZWN0aW9uICpzOwogCXVpbnQ2NF90IGR5bl9v ZmY7Ci0JaW50IGVsZmVyciwgaTsKKwlpbnQgZWxmZXJyLCBpLCBsZW47CiAKIAkvKgogCSAqIElm IC1EIGlzIHNwZWNpZmllZCwgb25seSBkdW1wIHRoZSBzeW1ib2wgdGFibGUgc3BlY2lmaWVkIGJ5 CkBAIC0zMzc4LDggKzM0MDQsMTAgQEAKIAkJfQogCQlpZiAoZC0+ZF9zaXplIDw9IDApCiAJCQly ZXR1cm47CisJCWlmICghZ2V0X2VudF9jb3VudChzLCAmbGVuKSkKKwkJCXJldHVybjsKIAotCQlm b3IgKGkgPSAwOyAodWludDY0X3QpaSA8IHMtPnN6IC8gcy0+ZW50c2l6ZTsgaSsrKSB7CisJCWZv ciAoaSA9IDA7IGkgPCBsZW47IGkrKykgewogCQkJaWYgKGdlbGZfZ2V0ZHluKGQsIGksICZkeW4p ICE9ICZkeW4pIHsKIAkJCQl3YXJueCgiZ2VsZl9nZXRkeW4gZmFpbGVkOiAlcyIsIGVsZl9lcnJt c2coLTEpKTsKIAkJCQljb250aW51ZTsKQEAgLTM1NjcsNyArMzU5NSw4IEBACiAJbWFza3dvcmRz ID0gYnVmWzJdOwogCWJ1ZiArPSA0OwogCWRzID0gJnJlLT5zbFtzLT5saW5rXTsKLQlkeW5zeW1j b3VudCA9IGRzLT5zeiAvIGRzLT5lbnRzaXplOworCWlmICghZ2V0X2VudF9jb3VudChkcywgJmR5 bnN5bWNvdW50KSkKKwkJcmV0dXJuOwogCW5jaGFpbiA9IGR5bnN5bWNvdW50IC0gc3ltbmR4Owog CWlmIChkLT5kX3NpemUgIT0gNCAqIHNpemVvZih1aW50MzJfdCkgKyBtYXNrd29yZHMgKgogCSAg ICAocmUtPmVjID09IEVMRkNMQVNTMzIgPyBzaXplb2YodWludDMyX3QpIDogc2l6ZW9mKHVpbnQ2 NF90KSkgKwpAQCAtMzk5Niw3ICs0MDI1LDcgQEAKIAljaGFyIHRidWZbMjBdOwogCUVsZl9EYXRh ICpkOwogCUVsZl9MaWIgKmxpYjsKLQlpbnQgaSwgaiwgaywgZWxmZXJyLCBmaXJzdDsKKwlpbnQg aSwgaiwgaywgZWxmZXJyLCBmaXJzdCwgbGVuOwogCiAJZm9yIChpID0gMDsgKHNpemVfdCkgaSA8 IHJlLT5zaG51bTsgaSsrKSB7CiAJCXMgPSAmcmUtPnNsW2ldOwpAQCAtNDAxMyw4ICs0MDQyLDEw IEBACiAJCWlmIChkLT5kX3NpemUgPD0gMCkKIAkJCWNvbnRpbnVlOwogCQlsaWIgPSBkLT5kX2J1 ZjsKKwkJaWYgKCFnZXRfZW50X2NvdW50KHMsICZsZW4pKQorCQkJY29udGludWU7CiAJCXByaW50 ZigiXG5MaWJyYXJ5IGxpc3Qgc2VjdGlvbiAnJXMnICIsIHMtPm5hbWUpOwotCQlwcmludGYoImNv bnRhaW5zICVqdSBlbnRyaWVzOlxuIiwgcy0+c3ogLyBzLT5lbnRzaXplKTsKKwkJcHJpbnRmKCJj b250YWlucyAlZCBlbnRyaWVzOlxuIiwgbGVuKTsKIAkJcHJpbnRmKCIlMTJzJTI0cyUxOHMlMTBz JTZzXG4iLCAiTGlicmFyeSIsICJUaW1lIFN0YW1wIiwKIAkJICAgICJDaGVja3N1bSIsICJWZXJz aW9uIiwgIkZsYWdzIik7CiAJCWZvciAoaiA9IDA7ICh1aW50NjRfdCkgaiA8IHMtPnN6IC8gcy0+ ZW50c2l6ZTsgaisrKSB7CkBAIC00Mzk5LDcgKzQ0MzAsNyBAQAogZHVtcF9taXBzX3JlZ2luZm8o c3RydWN0IHJlYWRlbGYgKnJlLCBzdHJ1Y3Qgc2VjdGlvbiAqcykKIHsKIAlFbGZfRGF0YSAqZDsK LQlpbnQgZWxmZXJyOworCWludCBlbGZlcnIsIGxlbjsKIAogCSh2b2lkKSBlbGZfZXJybm8oKTsK IAlpZiAoKGQgPSBlbGZfcmF3ZGF0YShzLT5zY24sIE5VTEwpKSA9PSBOVUxMKSB7CkBAIC00NDEx LDkgKzQ0NDIsMTAgQEAKIAl9CiAJaWYgKGQtPmRfc2l6ZSA8PSAwKQogCQlyZXR1cm47CisJaWYg KCFnZXRfZW50X2NvdW50KHMsICZsZW4pKQorCQlyZXR1cm47CiAKLQlwcmludGYoIlxuU2VjdGlv biAnJXMnIGNvbnRhaW5zICVqdSBlbnRyaWVzOlxuIiwgcy0+bmFtZSwKLQkgICAgcy0+c3ogLyBz LT5lbnRzaXplKTsKKwlwcmludGYoIlxuU2VjdGlvbiAnJXMnIGNvbnRhaW5zICVkIGVudHJpZXM6 XG4iLCBzLT5uYW1lLCBsZW4pOwogCWR1bXBfbWlwc19vZGtfcmVnaW5mbyhyZSwgZC0+ZF9idWYs IGQtPmRfc2l6ZSk7CiB9CiAKCg== --b1_627afc60ec88d368400d3ad626d694d0-- From owner-freebsd-toolchain@freebsd.org Fri Jul 24 19:01:37 2015 Return-Path: Delivered-To: freebsd-toolchain@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id A9DD59A961D for ; Fri, 24 Jul 2015 19:01:37 +0000 (UTC) (envelope-from daemon-user@freebsd.org) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) by mx1.freebsd.org (Postfix) with ESMTP id 8E2E41A1F for ; Fri, 24 Jul 2015 19:01:37 +0000 (UTC) (envelope-from daemon-user@freebsd.org) Received: by phabric-backend.isc.freebsd.org (Postfix, from userid 1346) id 766CEF516; Fri, 24 Jul 2015 19:01:37 +0000 (UTC) Date: Fri, 24 Jul 2015 19:01:37 +0000 To: freebsd-toolchain@freebsd.org From: "emaste (Ed Maste)" Reply-to: D3190+334+e8196c498a0a8881@FreeBSD.org Subject: [Differential] [Request, 2 lines] D3190: ar: enable deterministic mode by default Message-ID: X-Priority: 3 Thread-Topic: D3190: ar: enable deterministic mode by default X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: Thread-Index: MzVlMzIyZDNiYWU2MDVjNDdkNGI1NGVjMmJi Precedence: bulk X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: , , , MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="b1_57e0bd5c6188a79df5dd800d8b8d4dde" X-BeenThere: freebsd-toolchain@freebsd.org X-Mailman-Version: 2.1.20 List-Id: Maintenance of FreeBSD's integrated toolchain List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Jul 2015 19:01:37 -0000 --b1_57e0bd5c6188a79df5dd800d8b8d4dde Content-Type: text/plain; charset = "utf-8" Content-Transfer-Encoding: 8bit emaste created this revision. emaste added reviewers: bapt, brooks. emaste added a subscriber: freebsd-toolchain-list. REVISION SUMMARY Ar cannot handle UIDs with more than 6 digits, and there's little value in storing the mtime, uid, gid and mode anyhow. Turn on deterministic (-D) mode by default; it can be disabled by the user with -U. PR: 196929 Relnotes: Yes Sponsored by: The FreeBSD Foundation REVISION DETAIL https://reviews.freebsd.org/D3190 AFFECTED FILES usr.bin/ar/ar.c CHANGE DETAILS diff --git a/usr.bin/ar/ar.c b/usr.bin/ar/ar.c --- a/usr.bin/ar/ar.c +++ b/usr.bin/ar/ar.c @@ -104,6 +104,8 @@ bsdar = &bsdar_storage; memset(bsdar, 0, sizeof(*bsdar)); + /* Enable deterministic mode by default. */ + bsdar->options |= AR_D; if ((bsdar->progname = getprogname()) == NULL) bsdar->progname = "ar"; EMAIL PREFERENCES https://reviews.freebsd.org/settings/panel/emailpreferences/ To: emaste, bapt, brooks Cc: freebsd-toolchain-list --b1_57e0bd5c6188a79df5dd800d8b8d4dde Content-Type: text/x-patch; charset=utf-8; name="D3190.7271.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="D3190.7271.patch" ZGlmZiAtLWdpdCBhL3Vzci5iaW4vYXIvYXIuYyBiL3Vzci5iaW4vYXIvYXIuYwotLS0gYS91c3Iu YmluL2FyL2FyLmMKKysrIGIvdXNyLmJpbi9hci9hci5jCkBAIC0xMDQsNiArMTA0LDggQEAKIAog CWJzZGFyID0gJmJzZGFyX3N0b3JhZ2U7CiAJbWVtc2V0KGJzZGFyLCAwLCBzaXplb2YoKmJzZGFy KSk7CisJLyogRW5hYmxlIGRldGVybWluaXN0aWMgbW9kZSBieSBkZWZhdWx0LiAqLworCWJzZGFy LT5vcHRpb25zIHw9IEFSX0Q7CiAKIAlpZiAoKGJzZGFyLT5wcm9nbmFtZSA9IGdldHByb2duYW1l KCkpID09IE5VTEwpCiAJCWJzZGFyLT5wcm9nbmFtZSA9ICJhciI7Cgo= --b1_57e0bd5c6188a79df5dd800d8b8d4dde-- From owner-freebsd-toolchain@freebsd.org Fri Jul 24 19:05:57 2015 Return-Path: Delivered-To: freebsd-toolchain@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 78DE39A96CC for ; Fri, 24 Jul 2015 19:05:57 +0000 (UTC) (envelope-from daemon-user@freebsd.org) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) by mx1.freebsd.org (Postfix) with ESMTP id 636A31E7C for ; Fri, 24 Jul 2015 19:05:57 +0000 (UTC) (envelope-from daemon-user@freebsd.org) Received: by phabric-backend.isc.freebsd.org (Postfix, from userid 1346) id 5F122F7EB; Fri, 24 Jul 2015 19:05:57 +0000 (UTC) Date: Fri, 24 Jul 2015 19:05:57 +0000 To: freebsd-toolchain@freebsd.org From: "emaste (Ed Maste)" Reply-to: D3190+334+e8196c498a0a8881@FreeBSD.org Subject: [Differential] [Updated, 3 lines] D3190: ar: enable deterministic mode by default Message-ID: <923e5ec594a7681f2b169e3bcd00397c@localhost.localdomain> X-Priority: 3 Thread-Topic: D3190: ar: enable deterministic mode by default X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: In-Reply-To: References: Thread-Index: MzVlMzIyZDNiYWU2MDVjNDdkNGI1NGVjMmJiIFWyjJU= Precedence: bulk X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: , MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="b1_923e5ec594a7681f2b169e3bcd00397c" X-BeenThere: freebsd-toolchain@freebsd.org X-Mailman-Version: 2.1.20 List-Id: Maintenance of FreeBSD's integrated toolchain List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Jul 2015 19:05:57 -0000 --b1_923e5ec594a7681f2b169e3bcd00397c Content-Type: text/plain; charset = "utf-8" Content-Transfer-Encoding: 8bit emaste updated this revision to Diff 7272. emaste added a comment. Add note of -D default in man page. CHANGES SINCE LAST UPDATE https://reviews.freebsd.org/D3190?vs=7271&id=7272 REVISION DETAIL https://reviews.freebsd.org/D3190 AFFECTED FILES usr.bin/ar/ar.1 usr.bin/ar/ar.c CHANGE DETAILS diff --git a/usr.bin/ar/ar.c b/usr.bin/ar/ar.c --- a/usr.bin/ar/ar.c +++ b/usr.bin/ar/ar.c @@ -104,6 +104,8 @@ bsdar = &bsdar_storage; memset(bsdar, 0, sizeof(*bsdar)); + /* Enable deterministic mode by default. */ + bsdar->options |= AR_D; if ((bsdar->progname = getprogname()) == NULL) bsdar->progname = "ar"; diff --git a/usr.bin/ar/ar.1 b/usr.bin/ar/ar.1 --- a/usr.bin/ar/ar.1 +++ b/usr.bin/ar/ar.1 @@ -210,6 +210,7 @@ .Ar . This ensures that checksums on the resulting archives are reproducible when member contents are identical. +This option is enabled by default. If multiple .Fl D and EMAIL PREFERENCES https://reviews.freebsd.org/settings/panel/emailpreferences/ To: emaste, bapt, brooks Cc: freebsd-toolchain-list --b1_923e5ec594a7681f2b169e3bcd00397c Content-Type: text/x-patch; charset=utf-8; name="D3190.7272.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="D3190.7272.patch" ZGlmZiAtLWdpdCBhL3Vzci5iaW4vYXIvYXIuYyBiL3Vzci5iaW4vYXIvYXIuYwotLS0gYS91c3Iu YmluL2FyL2FyLmMKKysrIGIvdXNyLmJpbi9hci9hci5jCkBAIC0xMDQsNiArMTA0LDggQEAKIAog CWJzZGFyID0gJmJzZGFyX3N0b3JhZ2U7CiAJbWVtc2V0KGJzZGFyLCAwLCBzaXplb2YoKmJzZGFy KSk7CisJLyogRW5hYmxlIGRldGVybWluaXN0aWMgbW9kZSBieSBkZWZhdWx0LiAqLworCWJzZGFy LT5vcHRpb25zIHw9IEFSX0Q7CiAKIAlpZiAoKGJzZGFyLT5wcm9nbmFtZSA9IGdldHByb2duYW1l KCkpID09IE5VTEwpCiAJCWJzZGFyLT5wcm9nbmFtZSA9ICJhciI7CmRpZmYgLS1naXQgYS91c3Iu YmluL2FyL2FyLjEgYi91c3IuYmluL2FyL2FyLjEKLS0tIGEvdXNyLmJpbi9hci9hci4xCisrKyBi L3Vzci5iaW4vYXIvYXIuMQpAQCAtMjEwLDYgKzIxMCw3IEBACiAuQXIgLgogVGhpcyBlbnN1cmVz IHRoYXQgY2hlY2tzdW1zIG9uIHRoZSByZXN1bHRpbmcgYXJjaGl2ZXMgYXJlIHJlcHJvZHVjaWJs ZQogd2hlbiBtZW1iZXIgY29udGVudHMgYXJlIGlkZW50aWNhbC4KK1RoaXMgb3B0aW9uIGlzIGVu YWJsZWQgYnkgZGVmYXVsdC4KIElmIG11bHRpcGxlCiAuRmwgRAogYW5kCgo= --b1_923e5ec594a7681f2b169e3bcd00397c-- From owner-freebsd-toolchain@freebsd.org Fri Jul 24 20:44:43 2015 Return-Path: Delivered-To: freebsd-toolchain@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 20DE49AACE0 for ; Fri, 24 Jul 2015 20:44:43 +0000 (UTC) (envelope-from daemon-user@freebsd.org) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) by mx1.freebsd.org (Postfix) with ESMTP id 03D33194D for ; Fri, 24 Jul 2015 20:44:43 +0000 (UTC) (envelope-from daemon-user@freebsd.org) Received: by phabric-backend.isc.freebsd.org (Postfix, from userid 1346) id EB51CF372; Fri, 24 Jul 2015 20:44:42 +0000 (UTC) Date: Fri, 24 Jul 2015 20:44:42 +0000 To: freebsd-toolchain@freebsd.org From: "brooks (Brooks Davis)" Reply-to: D3190+334+e8196c498a0a8881@FreeBSD.org Subject: [Differential] [Accepted] D3190: ar: enable deterministic mode by default Message-ID: X-Priority: 3 Thread-Topic: D3190: ar: enable deterministic mode by default X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: In-Reply-To: References: Thread-Index: MzVlMzIyZDNiYWU2MDVjNDdkNGI1NGVjMmJiIFWyo7o= Precedence: bulk X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: , , MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-toolchain@freebsd.org X-Mailman-Version: 2.1.20 List-Id: Maintenance of FreeBSD's integrated toolchain List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Jul 2015 20:44:43 -0000 brooks accepted this revision. brooks added a comment. This revision has a positive review. Looks good to me REVISION DETAIL https://reviews.freebsd.org/D3190 EMAIL PREFERENCES https://reviews.freebsd.org/settings/panel/emailpreferences/ To: emaste, bapt, brooks Cc: freebsd-toolchain-list From owner-freebsd-toolchain@freebsd.org Fri Jul 24 23:51:06 2015 Return-Path: Delivered-To: freebsd-toolchain@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id A52089AAF51 for ; Fri, 24 Jul 2015 23:51:06 +0000 (UTC) (envelope-from daemon-user@freebsd.org) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) by mx1.freebsd.org (Postfix) with ESMTP id 8A7F016D6 for ; Fri, 24 Jul 2015 23:51:06 +0000 (UTC) (envelope-from daemon-user@freebsd.org) Received: by phabric-backend.isc.freebsd.org (Postfix, from userid 1346) id 6E02DF229; Fri, 24 Jul 2015 23:51:06 +0000 (UTC) Date: Fri, 24 Jul 2015 23:51:06 +0000 To: freebsd-toolchain@freebsd.org From: "bapt (Baptiste Daroussin)" Reply-to: D3190+334+e8196c498a0a8881@FreeBSD.org Subject: [Differential] [Accepted] D3190: ar: enable deterministic mode by default Message-ID: <3e0d0ab917140911de6399802b8c64ca@localhost.localdomain> X-Priority: 3 Thread-Topic: D3190: ar: enable deterministic mode by default X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: In-Reply-To: References: Thread-Index: MzVlMzIyZDNiYWU2MDVjNDdkNGI1NGVjMmJiIFWyz2o= Precedence: bulk X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: , MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-toolchain@freebsd.org X-Mailman-Version: 2.1.20 List-Id: Maintenance of FreeBSD's integrated toolchain List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Jul 2015 23:51:06 -0000 bapt accepted this revision. REVISION DETAIL https://reviews.freebsd.org/D3190 EMAIL PREFERENCES https://reviews.freebsd.org/settings/panel/emailpreferences/ To: emaste, brooks, bapt Cc: freebsd-toolchain-list From owner-freebsd-toolchain@freebsd.org Sat Jul 25 02:32:43 2015 Return-Path: Delivered-To: freebsd-toolchain@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id DA9BE9A9CDE for ; Sat, 25 Jul 2015 02:32:43 +0000 (UTC) (envelope-from lists@eitanadler.com) Received: from mail-wi0-x231.google.com (mail-wi0-x231.google.com [IPv6:2a00:1450:400c:c05::231]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 74E4B9C5 for ; Sat, 25 Jul 2015 02:32:43 +0000 (UTC) (envelope-from lists@eitanadler.com) Received: by wibud3 with SMTP id ud3so81287219wib.1 for ; Fri, 24 Jul 2015 19:32:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=eitanadler.com; s=0xdeadbeef; h=mime-version:from:date:message-id:subject:to:content-type; bh=cMSbdcGlo2EkgobC//aXGxlr9WXxl27g+/bNcyk9Klk=; b=YYoP57yWLsHniGOKO7K38ujdU/LMd1cSX91XgMrXAVb85alakFEMMZ4y7QvRbNpc/c LcCEXJoSdSy6DGgaFCa5MExxpIMA9sGMttyodnig0iJQjvZ1Py90UKJ9NOHsONoVOwHW QKuY8ijfUXTHk8KcnxDUTJCeeNMbH6Oivjmak= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:from:date:message-id:subject:to :content-type; bh=cMSbdcGlo2EkgobC//aXGxlr9WXxl27g+/bNcyk9Klk=; b=B8PMYml5y8dG2UpKKXAS3pdvJ+1P8LPgfx1oMoQVMHqNrNN9vwE4o37byKu5m+yzgS h5WeXo0xJRhOwOPXJb/RZJ55Pp8zMvcn28Sx40gzulqKOEctIGcE58oJjgIbXY8XPYmC Q7zgVR1kfB/nP1y3pYaBbD8p6YRkuF9kL6zw8WGrR77IHWSzUaNFlmwOvvY8mp4QinfB lZpQ4ay/HIROToPUcnS7rg97rF++qdpjpsRIAjuMPe9ZNHo7RXUCLpLIR35WYKfsVFFm Ugi4Ya5q4+nkrfW75t4vuS4pB0LTnpAlw5axBmLp/DbaGbNxsDUQYFox7lUHa5RliV+k e4SQ== X-Gm-Message-State: ALoCoQn9GnFfw/6y2hcOpEcQmUau406nYtuY1Sk3wcEGTTc4PR2NtfxGWwpxl7j4zfWOgCzSagEP X-Received: by 10.194.119.161 with SMTP id kv1mr31365381wjb.157.1437791561980; Fri, 24 Jul 2015 19:32:41 -0700 (PDT) MIME-Version: 1.0 Received: by 10.28.30.79 with HTTP; Fri, 24 Jul 2015 19:32:12 -0700 (PDT) From: Eitan Adler Date: Fri, 24 Jul 2015 19:32:12 -0700 Message-ID: Subject: reduced phabricator spam To: FreeBSD Toolchain , phabric-admin@freebsd.org Content-Type: text/plain; charset=UTF-8 X-BeenThere: freebsd-toolchain@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Maintenance of FreeBSD's integrated toolchain List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 25 Jul 2015 02:32:43 -0000 Hi all, I changed the default mailing settings for freebsd-toolchain to only send phabricator mail when a diff is created but not otherwise update the mailing list. If you want to follow a diff you should subscribe to the diff when you see. -- Eitan Adler