From owner-svn-src-svnadmin@freebsd.org Thu Aug 6 18:18:08 2015 Return-Path: Delivered-To: svn-src-svnadmin@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 464A09B5921; Thu, 6 Aug 2015 18:18:08 +0000 (UTC) (envelope-from peter@FreeBSD.org) Received: from repo.freebsd.org (repo.freebsd.org [IPv6:2001:1900:2254:2068::e6a:0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 34B9AFDB; Thu, 6 Aug 2015 18:18:08 +0000 (UTC) (envelope-from peter@FreeBSD.org) Received: from repo.freebsd.org ([127.0.1.70]) by repo.freebsd.org (8.14.9/8.14.9) with ESMTP id t76II8BY060078; Thu, 6 Aug 2015 18:18:08 GMT (envelope-from peter@FreeBSD.org) Received: (from peter@localhost) by repo.freebsd.org (8.14.9/8.14.9/Submit) id t76II8IF060077; Thu, 6 Aug 2015 18:18:08 GMT (envelope-from peter@FreeBSD.org) Message-Id: <201508061818.t76II8IF060077@repo.freebsd.org> X-Authentication-Warning: repo.freebsd.org: peter set sender to peter@FreeBSD.org using -f From: Peter Wemm Date: Thu, 6 Aug 2015 18:18:08 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-svnadmin@freebsd.org Subject: svn commit: r286376 - svnadmin/hooks/scripts X-SVN-Group: svnadmin MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-svnadmin@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the admin / configuration tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 06 Aug 2015 18:18:08 -0000 Author: peter Date: Thu Aug 6 18:18:07 2015 New Revision: 286376 URL: https://svnweb.freebsd.org/changeset/base/286376 Log: Catch cases where a log message is canonified all the way down to nothing due to an empty template being sent. Modified: svnadmin/hooks/scripts/log-police.py Modified: svnadmin/hooks/scripts/log-police.py ============================================================================== --- svnadmin/hooks/scripts/log-police.py Thu Aug 6 18:15:56 2015 (r286375) +++ svnadmin/hooks/scripts/log-police.py Thu Aug 6 18:18:07 2015 (r286376) @@ -64,8 +64,14 @@ def fix_txn(fs, txn_name): log_message = svn.fs.svn_fs_txn_prop(txn, "svn:log") if log_message is not None: new_message = fix_log_message(log_message) + if new_message.strip() == "": + sys.stderr.write("Log message required\n") + sys.exit(1) if new_message != log_message: svn.fs.svn_fs_change_txn_prop(txn, "svn:log", new_message) + else: + sys.stderr.write("Log message required\n") + sys.exit(1) def fix_rev(fs, revnum): From owner-svn-src-svnadmin@freebsd.org Thu Aug 6 18:19:31 2015 Return-Path: Delivered-To: svn-src-svnadmin@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id E320B9B59C6; Thu, 6 Aug 2015 18:19:31 +0000 (UTC) (envelope-from peter@FreeBSD.org) Received: from repo.freebsd.org (repo.freebsd.org [IPv6:2001:1900:2254:2068::e6a:0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id BAC0A118B; Thu, 6 Aug 2015 18:19:31 +0000 (UTC) (envelope-from peter@FreeBSD.org) Received: from repo.freebsd.org ([127.0.1.70]) by repo.freebsd.org (8.14.9/8.14.9) with ESMTP id t76IJVxO060184; Thu, 6 Aug 2015 18:19:31 GMT (envelope-from peter@FreeBSD.org) Received: (from peter@localhost) by repo.freebsd.org (8.14.9/8.14.9/Submit) id t76IJVKV060183; Thu, 6 Aug 2015 18:19:31 GMT (envelope-from peter@FreeBSD.org) Message-Id: <201508061819.t76IJVKV060183@repo.freebsd.org> X-Authentication-Warning: repo.freebsd.org: peter set sender to peter@FreeBSD.org using -f From: Peter Wemm Date: Thu, 6 Aug 2015 18:19:31 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-svnadmin@freebsd.org Subject: svn commit: r286377 - svnadmin/hooks/scripts X-SVN-Group: svnadmin MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-svnadmin@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the admin / configuration tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 06 Aug 2015 18:19:32 -0000 Author: peter Date: Thu Aug 6 18:19:30 2015 New Revision: 286377 URL: https://svnweb.freebsd.org/changeset/base/286377 Log: Check for some specific forms of broken commit templates. Added: svnadmin/hooks/scripts/stomp_bad_formatting.pl (contents, props changed) Added: svnadmin/hooks/scripts/stomp_bad_formatting.pl ============================================================================== --- /dev/null 00:00:00 1970 (empty, because file is newly added) +++ svnadmin/hooks/scripts/stomp_bad_formatting.pl Thu Aug 6 18:19:30 2015 (r286377) @@ -0,0 +1,54 @@ +#!/usr/bin/perl -w +# +# $FreeBSD$ + +use strict; +my $debug = 0; + +# $ svnlook changed /home/svnmirror/base -r 12348 +# UU head/sbin/mountd/mountd.c +# UU head/usr.sbin/mountd/mountd.c +# $ svnlook log /home/svnmirror/base -r 12348 +# Avoid bogus free() of a junk pointer. +# +# Detected by: phkmalloc +# Submitted by: grog@lemis.de (Greg Lehey) +# +# Except that when called to vette a commit, it'll be "-t txn", not "-r rev" + + +my $repo = $ARGV[0]; +my $txn = $ARGV[1]; + +my $log = ""; + +open(LOG, "svnlook log $repo -t $txn |") || die "cannot open svnlook log: $!"; +foreach () { + print "$$: log: $_" if ($debug); + $log .= $_; +} +close(LOG); + +if (stomp_bad_formatting($log)) { + exit 1; +} +exit 0; + +# ============================================================ +# Look for a few specific mangled/broken template cases as a +# stopgap for checking for a proper template. + +sub stomp_bad_formatting { + my ($log) = @_; + my $rv = 0; + if ($log =~ m|\n\nReviewers:[\t ]+|s) { + printf STDERR "**** Non-standard/badly formatted template - found 'Reviewers:' instead of 'Reviewed by:'.\n"; + $rv = 1; + } + # There is really no need for this spam in log messages. + if ($log =~ m|\n\nSubscribers:[\t ]+|s) { + printf STDERR "**** Non-standard/badly formatted template - found 'Subscribers:'.\n"; + $rv = 1; + } + $rv; +} From owner-svn-src-svnadmin@freebsd.org Thu Aug 6 18:29:27 2015 Return-Path: Delivered-To: svn-src-svnadmin@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id E6AEF9B5BF7; Thu, 6 Aug 2015 18:29:27 +0000 (UTC) (envelope-from peter@FreeBSD.org) Received: from repo.freebsd.org (repo.freebsd.org [IPv6:2001:1900:2254:2068::e6a:0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id D82DB19D2; Thu, 6 Aug 2015 18:29:27 +0000 (UTC) (envelope-from peter@FreeBSD.org) Received: from repo.freebsd.org ([127.0.1.70]) by repo.freebsd.org (8.14.9/8.14.9) with ESMTP id t76ITRnH064301; Thu, 6 Aug 2015 18:29:27 GMT (envelope-from peter@FreeBSD.org) Received: (from peter@localhost) by repo.freebsd.org (8.14.9/8.14.9/Submit) id t76ITR8L064300; Thu, 6 Aug 2015 18:29:27 GMT (envelope-from peter@FreeBSD.org) Message-Id: <201508061829.t76ITR8L064300@repo.freebsd.org> X-Authentication-Warning: repo.freebsd.org: peter set sender to peter@FreeBSD.org using -f From: Peter Wemm Date: Thu, 6 Aug 2015 18:29:27 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-svnadmin@freebsd.org Subject: svn commit: r286379 - svnadmin/hooks X-SVN-Group: svnadmin MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-svnadmin@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the admin / configuration tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 06 Aug 2015 18:29:28 -0000 Author: peter Date: Thu Aug 6 18:29:26 2015 New Revision: 286379 URL: https://svnweb.freebsd.org/changeset/base/286379 Log: Check for some particularly bad manglings of the commit template. Modified: svnadmin/hooks/pre-commit Modified: svnadmin/hooks/pre-commit ============================================================================== --- svnadmin/hooks/pre-commit Thu Aug 6 18:28:15 2015 (r286378) +++ svnadmin/hooks/pre-commit Thu Aug 6 18:29:26 2015 (r286379) @@ -93,6 +93,9 @@ detect-mergeinfo-bloat.pl "$REPO" -t "$T # check for upper/lowercase filename conflicts on clients case-insensitive.py "$REPO" "$TXN" || exit 1 +# catch some gross violations of commit template mangling. +stomp_bad_formatting.pl "$REPO" "$TXN" || exit 1 + # fix log message. log-police.py -t "$TXN" "$REPO" || exit 1 From owner-svn-src-svnadmin@freebsd.org Sat Aug 8 05:58:44 2015 Return-Path: Delivered-To: svn-src-svnadmin@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 279D39AC0F4; Sat, 8 Aug 2015 05:58:44 +0000 (UTC) (envelope-from rpaulo@FreeBSD.org) Received: from repo.freebsd.org (repo.freebsd.org [IPv6:2001:1900:2254:2068::e6a:0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id F34DA1525; Sat, 8 Aug 2015 05:58:43 +0000 (UTC) (envelope-from rpaulo@FreeBSD.org) Received: from repo.freebsd.org ([127.0.1.70]) by repo.freebsd.org (8.14.9/8.14.9) with ESMTP id t785whFd068328; Sat, 8 Aug 2015 05:58:43 GMT (envelope-from rpaulo@FreeBSD.org) Received: (from rpaulo@localhost) by repo.freebsd.org (8.14.9/8.14.9/Submit) id t785whpi068327; Sat, 8 Aug 2015 05:58:43 GMT (envelope-from rpaulo@FreeBSD.org) Message-Id: <201508080558.t785whpi068327@repo.freebsd.org> X-Authentication-Warning: repo.freebsd.org: rpaulo set sender to rpaulo@FreeBSD.org using -f From: Rui Paulo Date: Sat, 8 Aug 2015 05:58:43 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-svnadmin@freebsd.org Subject: svn commit: r286440 - svnadmin/conf X-SVN-Group: svnadmin MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-svnadmin@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the admin / configuration tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 08 Aug 2015 05:58:44 -0000 Author: rpaulo Date: Sat Aug 8 05:58:42 2015 New Revision: 286440 URL: https://svnweb.freebsd.org/changeset/base/286440 Log: Add myself for the iwm import. Modified: svnadmin/conf/sizelimit.conf Modified: svnadmin/conf/sizelimit.conf ============================================================================== --- svnadmin/conf/sizelimit.conf Sat Aug 8 04:59:27 2015 (r286439) +++ svnadmin/conf/sizelimit.conf Sat Aug 8 05:58:42 2015 (r286440) @@ -44,3 +44,4 @@ rwatson sam stas thompsa +rpaulo From owner-svn-src-svnadmin@freebsd.org Sat Aug 8 12:29:04 2015 Return-Path: Delivered-To: svn-src-svnadmin@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id D2DE19B6FED; Sat, 8 Aug 2015 12:29:04 +0000 (UTC) (envelope-from bapt@FreeBSD.org) Received: from repo.freebsd.org (repo.freebsd.org [IPv6:2001:1900:2254:2068::e6a:0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id C4039B85; Sat, 8 Aug 2015 12:29:04 +0000 (UTC) (envelope-from bapt@FreeBSD.org) Received: from repo.freebsd.org ([127.0.1.70]) by repo.freebsd.org (8.14.9/8.14.9) with ESMTP id t78CT4BE028692; Sat, 8 Aug 2015 12:29:04 GMT (envelope-from bapt@FreeBSD.org) Received: (from bapt@localhost) by repo.freebsd.org (8.14.9/8.14.9/Submit) id t78CT44O028690; Sat, 8 Aug 2015 12:29:04 GMT (envelope-from bapt@FreeBSD.org) Message-Id: <201508081229.t78CT44O028690@repo.freebsd.org> X-Authentication-Warning: repo.freebsd.org: bapt set sender to bapt@FreeBSD.org using -f From: Baptiste Daroussin Date: Sat, 8 Aug 2015 12:29:04 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-svnadmin@freebsd.org Subject: svn commit: r286449 - svnadmin/conf X-SVN-Group: svnadmin MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-svnadmin@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the admin / configuration tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 08 Aug 2015 12:29:04 -0000 Author: bapt Date: Sat Aug 8 12:29:03 2015 New Revision: 286449 URL: https://svnweb.freebsd.org/changeset/base/286449 Log: Welcome Marcelo to the rank of src committer, Craig and I will be mentoring him Approved by: core Modified: svnadmin/conf/access svnadmin/conf/mentors Modified: svnadmin/conf/access ============================================================================== --- svnadmin/conf/access Sat Aug 8 11:48:11 2015 (r286448) +++ svnadmin/conf/access Sat Aug 8 12:29:03 2015 (r286449) @@ -31,6 +31,7 @@ andre andreast andrew antoine +araujo arybchik asomers avatar Modified: svnadmin/conf/mentors ============================================================================== --- svnadmin/conf/mentors Sat Aug 8 11:48:11 2015 (r286448) +++ svnadmin/conf/mentors Sat Aug 8 12:29:03 2015 (r286449) @@ -13,6 +13,7 @@ achim scottl Co-mentor: emaste agc scottl Co-mentor: emax allanjude bapt Co-mentor: marcel +araujo bapt Co-mentor: rodrigc benl philip Co-mentor: simon carl jimharris cem markj