From owner-freebsd-testing@freebsd.org Mon Aug 15 17:24:13 2016 Return-Path: Delivered-To: freebsd-testing@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id F3FE0BBA5E8 for ; Mon, 15 Aug 2016 17:24:12 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id D8C4C1007 for ; Mon, 15 Aug 2016 17:24:12 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id u7FHOCpN069127 for ; Mon, 15 Aug 2016 17:24:12 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-testing@freebsd.org Subject: [Bug 211873] lib/libc/gen/basedirname_test:dirname_posix fails: "Input buffer was modified." Date: Mon, 15 Aug 2016 17:24:13 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: tests X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: ngie@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-testing@freebsd.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-testing@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: Testing on FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Aug 2016 17:24:13 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D211873 Bug ID: 211873 Summary: lib/libc/gen/basedirname_test:dirname_posix fails: "Input buffer was modified." Product: Base System Version: CURRENT Hardware: Any OS: Any Status: New Severity: Affects Only Me Priority: --- Component: tests Assignee: freebsd-testing@freebsd.org Reporter: ngie@FreeBSD.org Looks like the behavior for dirname(3) on FreeBSD deviates from NetBSD. Bringing this up because we may or may not want to follow suit. Assigning to ed@ because he's been heading up the recent basename(3)/dirnam= e(3) POSIXification. $ svn info /usr/src/svn/ Path: /usr/src/svn Working Copy Root Path: /usr/src/svn URL: svn+ssh://ngie@repo.freebsd.org/base/projects/netbsd-tests-update-12 Relative URL: ^/projects/netbsd-tests-update-12 Repository Root: svn+ssh://ngie@repo.freebsd.org/base Repository UUID: ccf9f872-aa2e-dd11-9fc8-001c23d0bc1f Revision: 304099 Node Kind: directory Schedule: normal Last Changed Author: ngie Last Changed Rev: 304099 Last Changed Date: 2016-08-14 12:54:40 -0700 (Sun, 14 Aug 2016) $ kyua debug -k lib/libc/gen/Kyuafile basedirname_test:dirname_posix Input buffer for "/usr/lib" was modified basedirname_test:dirname_posix -> failed: Input buffer was modified. 165 /* 166 * dirname(3) is allowed to modify the input buffer. 167 * However, that is considered hostile by some programs, 168 * and so we elect to consider this an error. 169 * 170 * This is not a problem, as dirname(3) is also allowed 171 * to return a pointer to a statically-allocated buffer 172 * (it is explicitly not required to be reentrant). 173 */ 174 if (test_dirname_table[i].input !=3D NULL && 175 strcmp(test_dirname_table[i].input, testbuf) !=3D 0= ) { 176 fprintf(stderr, 177 "Input buffer for \"%s\" was modified\n", 178 test_dirname_table[i].input); 179 atf_tc_fail("Input buffer was modified."); 180 } --=20 You are receiving this mail because: You are the assignee for the bug.=