From owner-freebsd-transport@freebsd.org Sun Jul 3 15:15:56 2016 Return-Path: Delivered-To: freebsd-transport@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 23D65B8F0B2 for ; Sun, 3 Jul 2016 15:15:56 +0000 (UTC) (envelope-from jtl@freebsd.org) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id BFD6A29A0 for ; Sun, 3 Jul 2016 15:15:55 +0000 (UTC) (envelope-from jtl@freebsd.org) Received: by mailman.ysv.freebsd.org (Postfix) id BF352B8F0B1; Sun, 3 Jul 2016 15:15:55 +0000 (UTC) Delivered-To: transport@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id BECDDB8F0AF for ; Sun, 3 Jul 2016 15:15:55 +0000 (UTC) (envelope-from jtl@freebsd.org) Received: from NAM01-SN1-obe.outbound.protection.outlook.com (mail-sn1nam01on0046.outbound.protection.outlook.com [104.47.32.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (Client CN "mail.protection.outlook.com", Issuer "Microsoft IT SSL SHA2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 44BDE299F for ; Sun, 3 Jul 2016 15:15:51 +0000 (UTC) (envelope-from jtl@freebsd.org) Received: from SN1PR06CA0009.namprd06.prod.outlook.com (10.163.69.19) by BLUPR06MB1828.namprd06.prod.outlook.com (10.162.225.18) with Microsoft SMTP Server (TLS) id 15.1.528.16; Sat, 2 Jul 2016 20:38:21 +0000 Received: from BY2FFO11FD036.protection.gbl (2a01:111:f400:7c0c::146) by SN1PR06CA0009.outlook.office365.com (2a01:111:e400:5198::19) with Microsoft SMTP Server (TLS) id 15.1.534.14 via Frontend Transport; Sat, 2 Jul 2016 20:38:20 +0000 Authentication-Results: spf=softfail (sender IP is 66.129.239.19) smtp.mailfrom=freebsd.org; freebsd.org; dkim=none (message not signed) header.d=none;freebsd.org; dmarc=none action=none header.from=freebsd.org; Received-SPF: SoftFail (protection.outlook.com: domain of transitioning freebsd.org discourages use of 66.129.239.19 as permitted sender) Received: from P-EMFE01C-SAC.jnpr.net (66.129.239.19) by BY2FFO11FD036.mail.protection.outlook.com (10.1.14.221) with Microsoft SMTP Server (TLS) id 15.1.523.9 via Frontend Transport; Sat, 2 Jul 2016 20:38:20 +0000 Received: from magenta.juniper.net (172.17.27.123) by P-EMFE01C-SAC.jnpr.net (172.24.192.21) with Microsoft SMTP Server (TLS) id 14.3.123.3; Sat, 2 Jul 2016 13:38:19 -0700 Received: from [172.29.32.176] (jwaller-sslvpn-nc.jnpr.net [172.29.32.176]) by magenta.juniper.net (8.11.3/8.11.3) with ESMTP id u62KcJE04474 for ; Sat, 2 Jul 2016 13:38:19 -0700 (PDT) (envelope-from jtl@freebsd.org) User-Agent: Microsoft-MacOutlook/f.17.0.160611 Date: Sat, 2 Jul 2016 16:37:50 -0400 Subject: TCP stack "long" cleanup From: "Jonathan T. Looney" To: Message-ID: <615C3255-4941-43C9-8CBD-4754661DBDAD@freebsd.org> Thread-Topic: TCP stack "long" cleanup MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-Matching-Connectors: 131119655008868619; (b40943b3-8b14-4aea-7aef-08d1afa05a60,c4b95726-c406-4b16-9318-08d1297f1edb); () X-Forefront-Antispam-Report: CIP:66.129.239.19; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(7916002)(2980300002)(189002)(199003)(81156014)(81166006)(77096005)(19580395003)(229853001)(69596002)(15975445007)(5820100001)(2351001)(86362001)(305945005)(4001350100001)(50986999)(54356999)(83716003)(7846002)(356003)(6806005)(68736007)(97736004)(82746002)(50466002)(33656002)(83506001)(87936001)(92566002)(586003)(230700001)(16796002)(36756003)(8936002)(106466001)(23676002)(2906002)(110136002)(105596002)(107886002)(47776003)(189998001)(450100001)(8676002)(11100500001)(42262002)(104396002); DIR:OUT; SFP:1101; SCL:1; SRVR:BLUPR06MB1828; H:P-EMFE01C-SAC.jnpr.net; FPR:; SPF:SoftFail; PTR:InfoDomainNonexistent; MX:1; A:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BY2FFO11FD036; 1:1+/kpUUTm1z0F0dq1zIrvnkPtDKU+rpkJGmM46kTODfbWPVFGJfvM+BLE1B1eiRxE8g59bzNhR1JUWtzRJ4deytLJxmEPdW51hYeliM/6WGHSfJYc7PbH9YPqpB8KFgS0YmCqqOzoxEc0iE3seFC64RcP9U0t0hy1WYwzgBaZ/PmBzSC7AarqaclGBpBcTLYId7PTSm4ifGy46jno63rMimJH9Y25627tIUhTRyAenhI8/XOfr8beCqugbmZzBqMeHl5oDP7VRkEfHorD+HkVu2XdvZq8XPPTyf06hRxGNZ8+PmjhAeELCVO9HrbAd2fbEV73qO3eOJguX164CsUn87X/gt3ER1K84mZB4B3ldo0/6bXNoz1NPq/gfGeRL0rrEeny2n2StHFnMifqm2xhvufkOu4QQadrAyz8h7qbJv/9HBx4vBu4JQ2j64PNqyoHitbq+4J84qaa/rg094XedFoG61yJuWfism//bSsbKcHZNc84nPIanho07NDOiSVn0MKuWpB5uKrOauo0SN+mno9pkqzrnYBHntj3/hkaqsUIVNe9DHPr6gQ/lov4t7bKyam7K1qiIDe3IM0N3LDKiyo0OHl9vs02P/XFwRl9iU= X-MS-Office365-Filtering-Correlation-Id: 421f22d7-460d-4f96-190b-08d3a2b8ce57 X-Microsoft-Exchange-Diagnostics: 1; BLUPR06MB1828; 2:PJpngWsS24rFEA3g7EXptjmbua8a/ECQji6RdQwf3N4Qph20Y8DgAUfp4icdu0JlJXuxTbZG9khhHYUau6tLGFQhlJDHKOOoFREzAjs4CpV3SSdgFSwYgPfLizzjwUynJlaNxVjPOVa7ZrUV+Ok4W8o1iXZ9511J8oeou8baVUuezXOUqn3wO6GI4K7pfM6g; 3:nPvc1GYYJ2AKncOYOd6lYaFU3z1Qf3Wm3sHJjFXQMGggyu2VpLLzktQOUf4mtq7ln+HPm4phMAQ17aN7FYnaZSKyrbTpKlg+KAJwkx/mJOgqTOeC3UWnfncuVCa5akhWrOUWVmNd+hjlNm4qWmlDt3lA9X0Or//s6Ekefb4IlBpVe8eY+csOz0ec20G15itMSb4BoE26z1zGQAC2Nfp8JJKGtRyffh/KvUhBcM7nsFM=; 25:D1z/E35gM0B2siowuZ1NLFqIoIKcYOBw0CKkOl/mgg4ilowYDI+P6L1sre+k90SODE7N6X3+27iiQN6OMNLtg5S/uzvAqzPU3ypZeGDXzgFAiPYSa5Qf1v9p+al6qq7Xww4kicvhG84zG8jbdvbmrPoYbmcpArfkEf1bAdO9y69+dtg7RpyDbfkvbuoWOpMAmfF978Z5ZX870xIpTVddqja+jsGrljAbVJS6cnKTyyqiCKxcDptIZ5LBi0e9eAdsimWYk3uk73ONcrl8Ill1txaUWSKsV4gjgbL1pB5XF4tObpOLssyxqYPt9RSAs+JsBRRihVbHaFh7By0IiRVQUzfk6ye0i22+pn4sxoSkiNcWVnPhz81xsK08UVYKTUCxLXI4xaqNza/z6rZZUw/NY1+CQaZZ1Zc9eqTxs4+l3F4= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BLUPR06MB1828; X-Microsoft-Exchange-Diagnostics: 1; BLUPR06MB1828; 31:wITmwgWMJSVkCPqZnSWDs8NelKikvpIN7kIPFafSOGq2PqvxW6UpsNumOc/B+xLZxWTXJS8e6ECAIWI5+90e2UzbOfzzj5wOme73zR1L6e4fjFYRZf7Y7XdU8It3gbyno6U9yzUq6AxEnFVDcb2oYXRwll9AYc5Iux8hjz1lR57FLdI/w7DDvkgNu8W27NXjnUfSMObLx+xfM2yaqI5Nrw==; 4:K+eYCZfZjNzFafW/y7SSoEjKOaNYkVc7aW92w/mvBjVtpWFLs27nHHTpkfvHJiOMYPMQmzvL4pyzHZpVF2cZo5c/IeAK7A0YxOM74N+XdpynxW01/gJu4n2Dpygd7bkZf1cUOWIL675mvutk/jRsCp0aGhPuNIKXWDiJPe1ImPMIpSVOIHGLNz4nTs1PUYHM2Ai/td85pmy+aBLSFqaYMRNWhVglP4iVn9Bo7kh+TLp6bovNxoAfrN61yXCccYczjegMwgbVtp0zXhgiUa1uk/gtY53C7XPt0WjhcYjOkKv1tmP7VdbBsH7W1upLfhLKP85UeBKj0DheCz1keM4zX4Bi9t/7CSp/itho5k+dtCY8z3AEKp1r7BJTB1YiDGyYhwEYpZoTuJgxfYZnuAnCf/PDm+W7grgGMZCnBCRnenAamzi+5HzYv8MxFf+tIfPqNYi+eOXi8rH81QpoMRJl/cAWEV2MUcuJBlanUQ3ilig= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(601004)(2401047)(13024025)(13023025)(13017025)(13015025)(13018025)(5005006)(8121501046)(10201501046)(3002001)(6055026); SRVR:BLUPR06MB1828; BCL:0; PCL:0; RULEID:(400006); SRVR:BLUPR06MB1828; X-Forefront-PRVS: 0991CAB7B3 X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtCTFVQUjA2TUIxODI4OzIzOnd1dng0ZTFpUjl0b2h5WjN6dWFXK2g1RzN3?= =?utf-8?B?S0tBUS8wTlB4bkh1RFdjQ0dxNlJiTlo3NG5sQWp2bkQxMzh1N1lENks3ekZG?= =?utf-8?B?WUVqUXNwd0xZODVYNG5YOUNNbEZGUkh0bUpoL3NZNTd3bE5Sd0lEMFZnUFNq?= =?utf-8?B?Y21Seng5T3hyeE9vSEprL1JIM0VSM0k0eE9CVXViWTEwN29xS2lEUU0yMFJo?= =?utf-8?B?QmZqMHVDOFl4Si83V21iVEdSeEYxdFNYZzhWZHFhYzlUc3dXMEkxOE8wNGZI?= =?utf-8?B?Y21oS05TbUVXR25uZVJOY05ZWTZDdHZGcTF6TFhHbUFPZEo3MDBTZVltb3FC?= =?utf-8?B?aFBaaC9hMkFZalBJQVdKQmNiNnhsMGxWTGtZT3ZMWWhlYTNqMWRBMHIxSGtx?= =?utf-8?B?RjRrVHR6d25jQ0JCRXBsTnVvWU5XRmVtWm5RZ2oxbkljWFF6c3kya0lPbk16?= =?utf-8?B?anhwa3c2dGl1Zzd4bGV4ZEdRVlp4OEp5a2ZxYzZ4dWlkYWpMZVdhUHBLbSs0?= =?utf-8?B?V0VPWFdzVWtHQW5lekFsZnJkeEVZM3JBMGFlU1k0Yk90SWtvNDlzemMrZWpL?= =?utf-8?B?VmFieGlEMGlSazJ1bmQyZWEyTnJlL0x2WnFmVmFWTXdKZjYyWkdqVlFYWC8r?= =?utf-8?B?blZ6UVVPWGZHNGxLWnF2Mm51WDl2bVB1Mmx6aEFjRUkybHg3YzllekZoMHRj?= =?utf-8?B?dml0UGVSMEQ4YkszcXpxY3Y4UlJ2aXBMaUdKc0VIUElUbWpEMUVOQlNSb09o?= =?utf-8?B?TmIxRE1lR2N5Q2VEMEtiWFZENkFqWm03c0FmRHRPT3lEL2JialJoUVcybFIz?= =?utf-8?B?SGVqaC9iSEJPS2tZUlBIUDBKWnlOenJUekp1MTRLWlUydU9ua3FaeFpmV0pR?= =?utf-8?B?ZXpTQUl1OGVGaHF5OHcvcmlJR3VWNjZ6d204MzVScTNHUTBOYVliVGZxcDdD?= =?utf-8?B?UFlLdnZQTEs5eElhVFZCZW92M1Zvc09sTkdPSlpBYkVvMnd1QlB2Sml3TUdq?= =?utf-8?B?cktENHQ1TDdGb1Urd0JWY2lRREJRM2xkeG05NXRFZEJvN2pBb29DOVdtamlL?= =?utf-8?B?QTdseWZFQUNmL2s2L1hjUVRZdGN2Vi9ua0xPS0IreVNFWWcyZWxSa3RxeWZO?= =?utf-8?B?SEJXZkpzZ3Q2bytHYXcvbjRZTUFDMXBFRi9RWWdDcEcxSmZ0UlNrVDR3ZzF6?= =?utf-8?B?cFplWklzcktTL3VKREE0WDJSNHBjSCt3Q0dON1Q5VXo3VU5hbWpYVUwvTGFN?= =?utf-8?B?SGJHWHNWT2R2Q1RYaG9MYTdXSnVOSFlWZEdFam9NcEpWR3FMUm1xOEMxK0lp?= =?utf-8?B?RFFOY3FJSktPQUhqTlR0WDNlSnowTFBLcllSa01wZm9sWXRMRnlKQXJEa3Qx?= =?utf-8?B?V094Y0lwdjU2OHkyY2JQOTlVRURCV2hML1g1NkFmdjE1dWFBejlSVWp2N3Zv?= =?utf-8?B?eGUyRDlQUXBVZnd5MmhiM1hrbHZwRDdpLzVaNWJyb005N1RsZUZ0MmFRemk5?= =?utf-8?B?NWtPWEVaRitqWnBtelhyQ25EVWU5bDZBaDR6RlNuVEZPc1V6NnlHSHRtWDVF?= =?utf-8?B?RktoQVRGMmtFcm15NlVkK3ZHYlp1WkpDUVJvN2U0U1VYZGFuV1VpVnE5b0My?= =?utf-8?B?cGYxSVBPNlJTSElxZTZwaGE5OGdzcXRubm1MVE45MzkzRzc2WDhQZGNBPT0=?= X-Microsoft-Exchange-Diagnostics: 1; BLUPR06MB1828; 6:zRhHnFyPzxr7HghOVSF3KOhZeK+ueYv9x6eN46ROBU94eYsZfaRtsXBkizfKecXWFyOSyFuhFIGoo5NZ9qch6QzNZB+NpFjtXMri7nn+zEN2MjR2b+l5dw/gvtEgQAMfLk8hd5pQBzkljVV1n7vKzDSKXb50dKMDMq8JJaMJLYtqaG10IABdT8QUoF1gxENw9qeCBZEb2JagLC5Q4stg3orlzO1xYQzDvzHtX2NrXcAz43NXG/kAu6BNMKIiPfV8b1HnZhX4WvyfYvRrsp/tDBsvwIFHqUgS6QAoEuvlFtY=; 5:P6eABp5A6kti6CKDkDvhiNdODWAw65UgGa11H944ZxykWEgYYhkOcbC5CAZjoKYeCwzH0quXlchooWnTF9syIwtsn+ocTyR/ACd4HUYP8XVl8kdYPpWNO/rspuOoKm5qwCp5OSfQB1rZ1BAz1iLz+nMBNkaW3b/Es6kp/vySwOY=; 24:ut9OCEl3cv9rNS2YihhjfX5PDt9to6RiMJyr2i5LvjYlMQnZ0nhlr/IHmpMz67ZYyMcx5EdtK1hA1duuPFxxBFoiCKw5eKi3WkaDAGaAT0s=; 7:Ja5PYC6Hdy7lurftMExRgnoJ6s6vbKaMuuicRKJSzQxI3OjcyOq3xzgAv2nqsZzTIJEyUcfQEWuX7+mjzvj10w4bT2X5mRZ1/NtUJ9sgZk6RijA1jKFrL+UTfQi+UknTtN9OUvdl0xJL17wRo6JnP2ln7QXVZTIiNk7EMi7IukoU2QzDbCvwrSMaEwPqRgmpzF0GbcrtcONMK5YaSUSZWBIR/M2kVyfr2xtBnYyMJNcEmhKnZN8iWSpsV0w2MOG5 SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Jul 2016 20:38:20.6372 (UTC) X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[66.129.239.19]; Helo=[P-EMFE01C-SAC.jnpr.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR06MB1828 X-BeenThere: freebsd-transport@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: Discussions of transport level network protocols in FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 03 Jul 2016 15:15:56 -0000 After the last 64-bit-specific bug, I decided to go on a mission to eliminate the use of "long" types in the TCP stack. This causes architecture-specific problems when we expect to use modulo 2^32 arithmetic for TCP values. Along the way, I think I found a few bugs, noticed a few things that we should cleanup, etc. As we discussed on the transport call on Thursday, I opened a separate Phabricator review for roughly each variable. That means I opened a boat-load of reviews, but they should each be digestable. I prefixed them all with FFL (short of "Freedom from Longs" :-) ). I also tried to highlight the one or two areas that I think need especially close attention. The full patch is here: https://people.freebsd.org/~jtl/freedom-from-longs.diff . It passed a tinderbox build, and seems to work fine with my (admittedly very little) preliminary testing. It could use some wider testing. I don't expect to commit any of this until after stable/11 branches. Some of the changes would not break the KBI/ABI, so would be eligible for MFC; many are not MFC candidates. In general, I only expect to MFC a few small things. Enjoy! Jonathan