From owner-freebsd-transport@freebsd.org Wed Aug 17 23:52:05 2016 Return-Path: Delivered-To: freebsd-transport@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id A2B9ABBDB9A for ; Wed, 17 Aug 2016 23:52:05 +0000 (UTC) (envelope-from hiren@strugglingcoder.info) Received: from mail.strugglingcoder.info (strugglingcoder.info [104.236.146.68]) by mx1.freebsd.org (Postfix) with ESMTP id 904471608; Wed, 17 Aug 2016 23:52:05 +0000 (UTC) (envelope-from hiren@strugglingcoder.info) Received: from localhost (unknown [10.1.1.3]) (Authenticated sender: hiren@strugglingcoder.info) by mail.strugglingcoder.info (Postfix) with ESMTPA id DF1B117357; Wed, 17 Aug 2016 16:51:58 -0700 (PDT) Date: Wed, 17 Aug 2016 16:51:58 -0700 From: hiren panchasara To: Peter Sewell Cc: "Jonathan T. Looney" , "freebsd-transport@freebsd.org" , Sam Kumar Subject: Re: TCP_HAVERCVDFIN Message-ID: <20160817235158.GE68615@strugglingcoder.info> References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="cYtjc4pxslFTELvY" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) X-BeenThere: freebsd-transport@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: Discussions of transport level network protocols in FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Aug 2016 23:52:05 -0000 --cYtjc4pxslFTELvY Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Resurrecting this thread. https://reviews.freebsd.org/D7475 I like this new behavior and it is being tested at NF and LLNW without any known problems. Any strong objection against it other than it _may_ break something? :-) I don't see us getting a conformance test suite anytime soon so I suggest we go ahead with this fix without any MFC and see how it goes? Cheers, Hiren --cYtjc4pxslFTELvY Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQF8BAABCgBmBQJXtPicXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXRBNEUyMEZBMUQ4Nzg4RjNGMTdFNjZGMDI4 QjkyNTBFMTU2M0VERkU1AAoJEIuSUOFWPt/lXJgH/1LlScChWlQp+UzcUKTO/80N +Zosqk/SKmIJxgEZ8S6NpFKO5Ty6OGJSlSXlKd6uxUYvERsp1eX/9VA1WOb+9EVj XiGMdfpyz9ArDaRsPtpwUHMBbh+6JOspYAteKfczVY9FqN9LbUIVTYFEm/Z9Hu8l yLC2O6karcju3yJyDyzy+6cUdCop5UfVj3lJPS1SmHaxh+3QgrVqlArj7X6ow+2x y5AxxQankGNmew9MPS55FnpkOH4A0iL2/o8VLm20NPqu6YMiZuMvC6YccpT0Qc1A fiVCRfghkRnbUTcftwzWE4lbo+pIGQlNEw3vRbzmqIFjqucbOBCDs2YVsB/DT/s= =icaX -----END PGP SIGNATURE----- --cYtjc4pxslFTELvY-- From owner-freebsd-transport@freebsd.org Thu Aug 18 13:43:39 2016 Return-Path: Delivered-To: freebsd-transport@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id D8255BBE3F5 for ; Thu, 18 Aug 2016 13:43:39 +0000 (UTC) (envelope-from shivanshrai84@gmail.com) Received: from mail-oi0-x236.google.com (mail-oi0-x236.google.com [IPv6:2607:f8b0:4003:c06::236]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 9CA4018CB; Thu, 18 Aug 2016 13:43:39 +0000 (UTC) (envelope-from shivanshrai84@gmail.com) Received: by mail-oi0-x236.google.com with SMTP id f189so22467724oig.3; Thu, 18 Aug 2016 06:43:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=jB/NEHbsNIxwqBd4GmlxLQdlnxi+Ci6cBTZ2W2W2nuE=; b=1DpbJrqHtlTqGwr0YtrTxH7TvtTz8vD56rpjLTbfw6NtPPXTHl+h6rt5f8nkMt6uFG UWH2CNltGw+ZFlcxQUJVF1f9hSgtjvtbkovqjg2tMv0Tw8GJ+NKE3ilEVlvGsvhcn0Jw M/EP1OZ1w8bLthscMBb8NsUJwWZhnExYLlLHO5lQvAJ5ssdxR2qAduD7nFGIMhQpZ/dV C6XULkEJzYtugXiS6SedIdgJS0zHd4A7xeTHaTQJfNU3Erlo7Lzc9xwWqpjjFfhv8UtA /Adu8JIe/3wD3bQ8h6LMGvBXBK/OmH+vDBdFwHWXXSg/DWej7Vizzf9PttziL1/KZCAq De5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=jB/NEHbsNIxwqBd4GmlxLQdlnxi+Ci6cBTZ2W2W2nuE=; b=JexzuNnwC5NL7RR5XHS4anNoMFszZg+vj0SyHkIE/J6h9Y9vAL6GMglwV1srtcyyQi VwuUeNdOBizlOb7ICw7JDgKCKdCNC0ST6Iy7+v8dEi42aIWrSVPtSIgMy0tZx9xZo7xV V+mM7SvUHvAH/SicaEkPXMtUjvN+5Vmo5eiHPwwTTI58aIQ0+dSsSpDCslZTwRllHNqi uPA2jixv/GwR483jdmD2MZcAn5DOQxj5j9MRbVsOaqEnRf8PM73X26I6uneZotMXLhWt vg9aD8S5Qjc2/DX6A+U8qk60DZTWp10XheDPBJ1JGdCyYa2oOsuaJh5vqu0MK3be11EL b61g== X-Gm-Message-State: AEkooutJJtpFKF+KdfHEQs1P72KBdme4Pu6DZfLtfFvmSusjLa6DmeQvf93deKIZmEaTlAZOdDL5nvGn26H16w== X-Received: by 10.157.31.109 with SMTP id x42mr1306093otx.105.1471527818963; Thu, 18 Aug 2016 06:43:38 -0700 (PDT) MIME-Version: 1.0 References: <20160817235158.GE68615@strugglingcoder.info> In-Reply-To: <20160817235158.GE68615@strugglingcoder.info> From: Shivansh Rai Date: Thu, 18 Aug 2016 13:43:28 +0000 Message-ID: Subject: Re: TCP_HAVERCVDFIN To: hiren panchasara , Peter Sewell Cc: "freebsd-transport@freebsd.org" , "Jonathan T. Looney" , Sam Kumar Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.22 X-BeenThere: freebsd-transport@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: Discussions of transport level network protocols in FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Aug 2016 13:43:39 -0000 Hi Hiren, I have updated the test suite *[1]* with the relevant tests *[2]* that were pointed out in D7475 *[3]*. I hope they can be used for the verification. Please let me know in case of any discrepancies. [1] : https://github.com/shivrai/TCP-IP-Regression-TestSuite [2] : https://github.com/shivrai/TCP-IP-Regression-TestSuite/tree/master/fin [3] : https://reviews.freebsd.org/D7475 Thank you. With Best Regards, Shivansh Rai On Thu, Aug 18, 2016 at 5:22 AM hiren panchasara wrote: > Resurrecting this thread. > > https://reviews.freebsd.org/D7475 > > I like this new behavior and it is being tested at NF and LLNW without > any known problems. > > Any strong objection against it other than it _may_ break something? :-) > I don't see us getting a conformance test suite anytime soon so I > suggest we go ahead with this fix without any MFC and see how it goes? > > Cheers, > Hiren > -- Regards, Shivansh Rai From owner-freebsd-transport@freebsd.org Thu Aug 18 17:32:05 2016 Return-Path: Delivered-To: freebsd-transport@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 0365EBBE69D for ; Thu, 18 Aug 2016 17:32:05 +0000 (UTC) (envelope-from shivanshrai84@gmail.com) Received: from mail-oi0-f52.google.com (mail-oi0-f52.google.com [209.85.218.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id C3DFF1DC3; Thu, 18 Aug 2016 17:32:04 +0000 (UTC) (envelope-from shivanshrai84@gmail.com) Received: by mail-oi0-f52.google.com with SMTP id l203so31600389oib.1; Thu, 18 Aug 2016 10:32:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=tKGIXLeqA4liwPwNFKA79JOnSAupg6necd5QGcAjpfM=; b=Ielmwvgp87BjvDdDRgLNSHIg9kEe/oAFHuOLaQSsa5EghGCyby29h7GcVFOufbtGGK ucnqXNGyxVkgH7DwFc11lB9Pr331pr7iim4KpFUCFnFuglPXh+KWuiS28SOH5q5dPQFY Eu7aY1gOhsHg7/GBWrtxYvxPv0i7qq1bY913yjQh3tSDPLMlOu93hKJoEGGFJiSLMC8Y IU8zMEtBTAZ+uu5yh8wbhuHN8pbCFySpLmFY3uYNRQ74yxgrtZVNEWV/io1Sx10hgAZX bdg9fozPC0yUzGreYmtXbevs/5rEntbXm+1UekGonubhrgfKzA7QVad0iD0jq8G7G3XR tT0w== X-Gm-Message-State: AEkoousUv2ZXBUEi2USjXxBWfPJCIsjAfk9GQ0Jz9lckEcuaKnWpMFcVyjEurdZ4xnKmSw== X-Received: by 10.157.46.212 with SMTP id w78mr2188137ota.170.1471541182815; Thu, 18 Aug 2016 10:26:22 -0700 (PDT) Received: from mail-oi0-f54.google.com (mail-oi0-f54.google.com. [209.85.218.54]) by smtp.gmail.com with ESMTPSA id q77sm1549403ota.0.2016.08.18.10.26.21 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 18 Aug 2016 10:26:22 -0700 (PDT) Received: by mail-oi0-f54.google.com with SMTP id f189so31223508oig.3; Thu, 18 Aug 2016 10:26:21 -0700 (PDT) X-Received: by 10.202.71.79 with SMTP id u76mr1897768oia.122.1471541181805; Thu, 18 Aug 2016 10:26:21 -0700 (PDT) MIME-Version: 1.0 References: <20160817235158.GE68615@strugglingcoder.info> In-Reply-To: From: Shivansh Rai Date: Thu, 18 Aug 2016 17:26:11 +0000 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: TCP_HAVERCVDFIN To: hiren panchasara , Peter Sewell Cc: "freebsd-transport@freebsd.org" , "Jonathan T. Looney" , Sam Kumar Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.22 X-BeenThere: freebsd-transport@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: Discussions of transport level network protocols in FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Aug 2016 17:32:05 -0000 Hi, I deeply apologize for my mistake. The tests which I have made do not test the intended behavior, as I misunderstood the issue which was being discussed. Hiren has pointed out how to go about testing the issue, so I will update the tests soon. Thank you. Regards, Shivansh Rai On Thu, Aug 18, 2016 at 7:13 PM Shivansh Rai wrote: > Hi Hiren, > > I have updated the test suite *[1]* with the relevant tests *[2]* that > were pointed out in D7475 *[3]*. I hope they can be used for the > verification. > Please let me know in case of any discrepancies. > > [1] : https://github.com/shivrai/TCP-IP-Regression-TestSuite > [2] : > https://github.com/shivrai/TCP-IP-Regression-TestSuite/tree/master/fin > [3] : https://reviews.freebsd.org/D7475 > > Thank you. > With Best Regards, > Shivansh Rai > > On Thu, Aug 18, 2016 at 5:22 AM hiren panchasara < > hiren@strugglingcoder.info> wrote: > >> Resurrecting this thread. >> >> https://reviews.freebsd.org/D7475 >> >> I like this new behavior and it is being tested at NF and LLNW without >> any known problems. >> >> Any strong objection against it other than it _may_ break something? :-) >> I don't see us getting a conformance test suite anytime soon so I >> suggest we go ahead with this fix without any MFC and see how it goes? >> >> Cheers, >> Hiren >> > -- > Regards, > Shivansh Rai >