From owner-freebsd-wireless@freebsd.org Mon Aug 1 01:36:51 2016 Return-Path: Delivered-To: freebsd-wireless@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 0B9F4BAA4F1; Mon, 1 Aug 2016 01:36:51 +0000 (UTC) (envelope-from ler@lerctr.org) Received: from thebighonker.lerctr.org (thebighonker.lerctr.org [IPv6:2001:470:1f0f:3ad:223:7dff:fe9e:6e8a]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "thebighonker.lerctr.org", Issuer "COMODO RSA Domain Validation Secure Server CA" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id DA6DA100C; Mon, 1 Aug 2016 01:36:50 +0000 (UTC) (envelope-from ler@lerctr.org) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lerctr.org; s=lerami; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=6lfQX42BdBYtw3CjLfjEYBtJP0GTd/UZ4C335xElPJ0=; b=J7GFjffyvJUdwhuzBJ7/8M8N2q q8KSA3xiA8FwZ/ZQxte021ZvfzYUe056reTlHnkMgtIO1egUy5PV3w4W6+wn8t8ONwpItjV+EPllD xicpbrpS5+0t0QicJB5k2/Cv56IOEQLINew8jwN49i0qjj9wRtxkwdOaffbqAH57voks=; Received: from [2001:470:1f0f:42c:2247:47ff:fe73:75f] (port=17583 helo=pita) by thebighonker.lerctr.org with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.87 (FreeBSD)) (envelope-from ) id 1bU29x-000Is7-QG; Sun, 31 Jul 2016 20:36:49 -0500 Date: Sun, 31 Jul 2016 20:36:47 -0500 From: Larry Rosenman To: Adrian Chadd Cc: Imre Vad??sz , Andriy Voskoboinyk , "freebsd-wireless@freebsd.org" , freebsd-current , owner-freebsd-current@freebsd.org Subject: Re: IWM(7260), no connect Message-ID: <20160801013647.GA1294@pita> Mail-Followup-To: Adrian Chadd , Imre Vad??sz , Andriy Voskoboinyk , "freebsd-wireless@freebsd.org" , freebsd-current , owner-freebsd-current@freebsd.org References: <20160728023954.GA1321@pita> <20160728233504.GA1226@pita> <4ee03d28cc2711ed9bc56a725cac344a@thebighonker.lerctr.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.6.1 (2016-04-27) X-BeenThere: freebsd-wireless@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: "Discussions of 802.11 stack, tools device driver development." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Aug 2016 01:36:51 -0000 Even with that reverted, I'm still having iffy connections. Current code: FreeBSD pita 12.0-CURRENT FreeBSD 12.0-CURRENT #4 r303597M: Sun Jul 31 16:02:39 CDT 2016 root@pita:/usr/obj/usr/src/sys/IWM-DEBUG amd64 1200001 1200001 Current diff to that SVN Rev: Index: sys/dev/iwm/if_iwm.c =================================================================== --- sys/dev/iwm/if_iwm.c (revision 303597) +++ sys/dev/iwm/if_iwm.c (working copy) @@ -3357,15 +3357,12 @@ uint8_t subtype = wh->i_fc[0] & IEEE80211_FC0_SUBTYPE_MASK; if (subtype == IEEE80211_FC0_SUBTYPE_ASSOC_REQ || - subtype == IEEE80211_FC0_SUBTYPE_REASSOC_REQ) { - tx->pm_frame_timeout = htole16(IWM_PM_FRAME_ASSOC); - } else if (subtype == IEEE80211_FC0_SUBTYPE_ACTION) { - tx->pm_frame_timeout = htole16(IWM_PM_FRAME_NONE); - } else { - tx->pm_frame_timeout = htole16(IWM_PM_FRAME_MGMT); - } + subtype == IEEE80211_FC0_SUBTYPE_REASSOC_REQ) + tx->pm_frame_timeout = htole16(3); + else + tx->pm_frame_timeout = htole16(2); } else { - tx->pm_frame_timeout = htole16(IWM_PM_FRAME_NONE); + tx->pm_frame_timeout = htole16(0); } if (hdrlen & 3) { Index: sys/dev/iwm/if_iwmreg.h =================================================================== --- sys/dev/iwm/if_iwmreg.h (revision 303597) +++ sys/dev/iwm/if_iwmreg.h (working copy) @@ -4244,18 +4244,6 @@ IWM_TX_CMD_FLG_HCCA_CHUNK = (1 << 31) }; /* IWM_TX_FLAGS_BITS_API_S_VER_1 */ -/** - * enum iwm_tx_pm_timeouts - pm timeout values in TX command - * @IWM_PM_FRAME_NONE: no need to suspend sleep mode - * @IWM_PM_FRAME_MGMT: fw suspend sleep mode for 100TU - * @IWM_PM_FRAME_ASSOC: fw suspend sleep mode for 10sec - */ -enum iwm_tx_pm_timeouts { - IWM_PM_FRAME_NONE = 0, - IWM_PM_FRAME_MGMT = 2, - IWM_PM_FRAME_ASSOC = 3, -}; - /* * TX command security control */ Scan Debug: http://www.lerctr.org/~ler/FreeBSD/WIFI-Scan.txt What next? On Thu, Jul 28, 2016 at 06:06:47PM -0700, Adrian Chadd wrote: > +imre, > > Hi! Larry is having issues with r303418. Would you be able to help him out? > > (If it's not too bad, can we back this out until you figure out what's > going on?) > > Thanks! > > > -a > > > On 28 July 2016 at 18:05, Larry Rosenman wrote: > > On 2016-07-28 20:02, Adrian Chadd wrote: > >> > >> Hi, > >> > >> Which commit(s) did you revert? > >> > >> > >> > >> -a > > > > > > revert r303418 > > > > and now it connects again. > > > > > > -- > > Larry Rosenman http://www.lerctr.org/~ler > > Phone: +1 214-642-9640 E-Mail: ler@lerctr.org > > US Mail: 17716 Limpia Crk, Round Rock, TX 78664-7281 -- Larry Rosenman http://www.lerctr.org/~ler Phone: +1 214-642-9640 E-Mail: ler@lerctr.org US Mail: 17716 Limpia Crk, Round Rock, TX 78664-7281