From owner-svn-src-head@freebsd.org Sun Jun 19 00:06:37 2016 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 5A5CFA79BB9; Sun, 19 Jun 2016 00:06:37 +0000 (UTC) (envelope-from cy.schubert@komquats.com) Received: from smtp-out-so.shaw.ca (smtp-out-so.shaw.ca [64.59.136.139]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "Client", Issuer "CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id E9B4216E0; Sun, 19 Jun 2016 00:06:36 +0000 (UTC) (envelope-from cy.schubert@komquats.com) Received: from spqr.komquats.com ([96.50.22.10]) by shaw.ca with SMTP id EQFvbNWpVN9d0EQFwb3vwr; Sat, 18 Jun 2016 18:06:29 -0600 X-Authority-Analysis: v=2.2 cv=QZUkhYTv c=1 sm=1 tr=0 a=jvE2nwUzI0ECrNeyr98KWA==:117 a=jvE2nwUzI0ECrNeyr98KWA==:17 a=L9H7d07YOLsA:10 a=9cW_t1CCXrUA:10 a=s5jvgZ67dGcA:10 a=pD_ry4oyNxEA:10 a=6I5d2MoRAAAA:8 a=YxBL1-UpAAAA:8 a=6bjs4j2-ulXUaOp-ORUA:9 a=IjZwj45LgO3ly-622nXo:22 a=Ia-lj3WSrqcvXOmTRaiG:22 Received: from slippy.cwsent.com (slippy [10.1.1.91]) by spqr.komquats.com (Postfix) with ESMTPS id 0479913752; Sat, 18 Jun 2016 17:06:27 -0700 (PDT) Received: from slippy (localhost [127.0.0.1]) by slippy.cwsent.com (8.15.2/8.15.2) with ESMTP id u5J06Qk6009591; Sat, 18 Jun 2016 17:06:26 -0700 (PDT) (envelope-from Cy.Schubert@cschubert.com) Message-Id: <201606190006.u5J06Qk6009591@slippy.cwsent.com> X-Mailer: exmh version 2.8.0 04/21/2012 with nmh-1.6 Reply-to: Cy Schubert From: Cy Schubert X-os: FreeBSD X-Sender: cy@cwsent.com X-URL: http://www.cschubert.com/ To: Niclas Zeising cc: Adrian Chadd , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r288291 - head/etc In-Reply-To: Message from Niclas Zeising of "Sun, 19 Jun 2016 00:06:32 +0200." <2171b966-35c7-2dad-2c0f-f23061cb677a@freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Sat, 18 Jun 2016 17:06:26 -0700 X-CMAE-Envelope: MS4wfNEk94othDyAawdxAUUBXXWjvvMz70gz8uaG1KddphgPc9DOGr+uUBu8MUpaxq2X6PrqyQHlS0rDO865IGakQubgFFtuGkxuyOqLI5cTCwM6r8xiiY0h zh3m+w1pFLMSVG2kYBOj/KCEgIbdqVM+yvyRG7tK97iBDsFKMFraFCMqc2OPTpf+V1mwuLrvOkgWRrp+7sGCtkHPjxS7eF8voPqcW2j56rt2SOfygPcwG3XG A5X5hrUaeOWyNAtI+gF6JU78K7Hl5Jfyke8viTnj9gekkr9NV1sOTanODa3nNPJri6OqeWiL9n/kIHwEDQmNYA== X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 19 Jun 2016 00:06:37 -0000 In message <2171b966-35c7-2dad-2c0f-f23061cb677a@freebsd.org>, Niclas Zeising w rites: > On 09/27/15 06:03, Adrian Chadd wrote: > > Author: adrian > > Date: Sun Sep 27 04:03:11 2015 > > New Revision: 288291 > > URL: https://svnweb.freebsd.org/changeset/base/288291 > > > > Log: > > Enforce consistent limits of daemons run from rc.subr: > > > > * Allow the user to configure the login class to use in rc.conf > > by using {daemon}_login_class, which; > > * Use the daemon class by default; > > * .. and then use 'limits' to set the login class so it works both > > via init at startup (which runs this in 'daemon' class) and via > > whichever root environment (eg command line, other daemons, etc.) > > > > Reviewed by: dteske > > Differential Revision: https://reviews.freebsd.org/D3630 > > > > Modified: > > head/etc/rc.subr > > > > Modified: head/etc/rc.subr > > =========================================================================== > === > > --- head/etc/rc.subr Sun Sep 27 03:46:55 2015 (r288290) > > +++ head/etc/rc.subr Sun Sep 27 04:03:11 2015 (r288291) > > @@ -768,6 +768,8 @@ check_startmsgs() > > # > > # ${name}_prepend n Command added before ${command}. > > # > > +# ${name}_login_class n Login class to use, else "daemon". > > +# > > # ${rc_arg}_cmd n If set, use this as the method when invoked; > > # Otherwise, use default command (see below) > > # > > @@ -942,7 +944,7 @@ run_rc_command() > > _nice=\$${name}_nice _user=\$${name}_user \ > > _group=\$${name}_group _groups=\$${name}_groups \ > > _fib=\$${name}_fib _env=\$${name}_env \ > > - _prepend=\$${name}_prepend > > + _prepend=\$${name}_prepend _login_class=\${${name}_login_class:-da > emon} > > > > if [ -n "$_user" ]; then # unset $_user if running as that user > > if [ "$_user" = "$(eval $IDCMD)" ]; then > > @@ -1050,6 +1052,9 @@ $command $rc_flags $command_args" > > fi > > fi > > > > + # Prepend default limits > > + _doit="limits -C $_login_class $_doit" > ^^^^^^^^^^ > > + > > # run the full command > > # > > if ! _run_rc_doit "$_doit"; then > > Apologies for waking so late. > This breaks the start of scripts running before file systems are > mounted, for example /etc/rc.d/ddb, if / and /usr are on separate > partitions. The issue is that limits is /usr/bin/limits, and for > obvious reasons can't be found before /usr is mounted. > I suggest either move /usr/bin/limits to /bin/limits or avoid using it > altogether. > Do you want me to open a PR to track this issue? > Regards! A simple solution might be, Index: rc.subr =================================================================== --- rc.subr (revision 302001) +++ rc.subr (working copy) @@ -1071,8 +1071,13 @@ fi fi + # Before we prepend limits, test if limits is + # available (/usr is mounted) so that limits can + # be run. + if limits >/dev/null 2>&1; then # Prepend default limits - _doit="limits -C $_login_class $_doit" + _doit="limits -C $_login_class $_doit" + fi # run the full command # -- Cheers, Cy Schubert FreeBSD UNIX: Web: http://www.FreeBSD.org The need of the many outweighs the greed of the few. From owner-svn-src-head@freebsd.org Sun Jun 19 03:32:28 2016 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 9DED2A7A319; Sun, 19 Jun 2016 03:32:28 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Received: from mail-io0-x22e.google.com (mail-io0-x22e.google.com [IPv6:2607:f8b0:4001:c06::22e]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 630522B48; Sun, 19 Jun 2016 03:32:28 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Received: by mail-io0-x22e.google.com with SMTP id f30so98107825ioj.2; Sat, 18 Jun 2016 20:32:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=P1JsJPb3unPZtLMZIZSL20vvHQcYN9ktddSV4IIQ05M=; b=E/le8PaySYylMSmzkaX+GF4UjWsi3Mpn3HwtAhzrqsRAFRiN+A6W8TWzGlWkBjjN3y 2vQahlO+RHOrRiALcX8LlnwA/DNJryqMO1p3oV4EjJzTJUJbZ93AmBQ9jEtdcUP8xbse f8SnLP9/8Uk+bGpY6YUL2n6wbpc5A4rPqsYaOcQuZuvaVHZYbr2QoDLHuQR8Z5cDMmIz tk2wUGH4ylmEPPJq3VM57+dF2v2NSNtHpcUSuW8ZThQ9t3xDs3HDjVYhhcRTC+yAUfol 45c5bgkbOCZleCaHRACH5WeXvFdmg2PKVmlphWONdp09u01bSsNW7OarHgqeowS07Q6F bbMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=P1JsJPb3unPZtLMZIZSL20vvHQcYN9ktddSV4IIQ05M=; b=BodpDUsQ+PDH3OmGs4SC9yOVapsmu5ESNuCsUmh1LOo3iqoS37FDUUiMauK2wpWvUb mD+lStfAEF+QfCSJ9vAcbzdjCFwILAKrrfq0e0OgR8tJC/cNWrVzQWIQWUkJfX0baH9Z OhzRszW9T5bUgBmCDS270MACZEXJbd9kc1WpTayhsveiSqvkIekqeSXBT/6diymtcsJ2 /XCLApqdWXr6cue59xg9wliaOdRirXKntWNxBY1C2Bjz4ONGUU8s53RXfrc1IVDFRaiZ wtGSizyleFKDW6SCcsuA3ss8OgC0nR4wyk1ar6D7BNrvqauNVEDr+qU7aULnuwpMsby9 N6QQ== X-Gm-Message-State: ALyK8tKW9KdIhbASJfRbP3NpnuHZ4iAS85ETUicQlpNmF3OLQycb8fkeIteHGBd9oeQoZ4uLFpr5C+PHzWmbng== X-Received: by 10.107.144.2 with SMTP id s2mr12322349iod.165.1466307147600; Sat, 18 Jun 2016 20:32:27 -0700 (PDT) MIME-Version: 1.0 Sender: adrian.chadd@gmail.com Received: by 10.36.113.3 with HTTP; Sat, 18 Jun 2016 20:32:26 -0700 (PDT) In-Reply-To: <201606190006.u5J06Qk6009591@slippy.cwsent.com> References: <2171b966-35c7-2dad-2c0f-f23061cb677a@freebsd.org> <201606190006.u5J06Qk6009591@slippy.cwsent.com> From: Adrian Chadd Date: Sat, 18 Jun 2016 20:32:26 -0700 X-Google-Sender-Auth: pGY9XasTuOiq20l4LYAMBYCbDds Message-ID: Subject: Re: svn commit: r288291 - head/etc To: Cy Schubert Cc: Niclas Zeising , "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Content-Type: text/plain; charset=UTF-8 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 19 Jun 2016 03:32:28 -0000 i think that's fine for -11. I'd like to just move limits to /bin for 12. (I mean, it's 2016, why are you splitting / and /usr again? But..) I don't want to see differing system behaviour between limits but it's likely unavoidable for 11 and could do with some errata notice so people know what to expect. Thanks, -adrian On 18 June 2016 at 17:06, Cy Schubert wrote: > In message <2171b966-35c7-2dad-2c0f-f23061cb677a@freebsd.org>, Niclas > Zeising w > rites: >> On 09/27/15 06:03, Adrian Chadd wrote: >> > Author: adrian >> > Date: Sun Sep 27 04:03:11 2015 >> > New Revision: 288291 >> > URL: https://svnweb.freebsd.org/changeset/base/288291 >> > >> > Log: >> > Enforce consistent limits of daemons run from rc.subr: >> > >> > * Allow the user to configure the login class to use in rc.conf >> > by using {daemon}_login_class, which; >> > * Use the daemon class by default; >> > * .. and then use 'limits' to set the login class so it works both >> > via init at startup (which runs this in 'daemon' class) and via >> > whichever root environment (eg command line, other daemons, etc.) >> > >> > Reviewed by: dteske >> > Differential Revision: https://reviews.freebsd.org/D3630 >> > >> > Modified: >> > head/etc/rc.subr >> > >> > Modified: head/etc/rc.subr >> > =========================================================================== >> === >> > --- head/etc/rc.subr Sun Sep 27 03:46:55 2015 (r288290) >> > +++ head/etc/rc.subr Sun Sep 27 04:03:11 2015 (r288291) >> > @@ -768,6 +768,8 @@ check_startmsgs() >> > # >> > # ${name}_prepend n Command added before ${command}. >> > # >> > +# ${name}_login_class n Login class to use, else "daemon". >> > +# >> > # ${rc_arg}_cmd n If set, use this as the method when invoked; >> > # Otherwise, use default command (see below) >> > # >> > @@ -942,7 +944,7 @@ run_rc_command() >> > _nice=\$${name}_nice _user=\$${name}_user \ >> > _group=\$${name}_group _groups=\$${name}_groups \ >> > _fib=\$${name}_fib _env=\$${name}_env \ >> > - _prepend=\$${name}_prepend >> > + _prepend=\$${name}_prepend _login_class=\${${name}_login_class:-da >> emon} >> > >> > if [ -n "$_user" ]; then # unset $_user if running as that user >> > if [ "$_user" = "$(eval $IDCMD)" ]; then >> > @@ -1050,6 +1052,9 @@ $command $rc_flags $command_args" >> > fi >> > fi >> > >> > + # Prepend default limits >> > + _doit="limits -C $_login_class $_doit" >> ^^^^^^^^^^ >> > + >> > # run the full command >> > # >> > if ! _run_rc_doit "$_doit"; then >> >> Apologies for waking so late. >> This breaks the start of scripts running before file systems are >> mounted, for example /etc/rc.d/ddb, if / and /usr are on separate >> partitions. The issue is that limits is /usr/bin/limits, and for >> obvious reasons can't be found before /usr is mounted. >> I suggest either move /usr/bin/limits to /bin/limits or avoid using it >> altogether. >> Do you want me to open a PR to track this issue? >> Regards! > > A simple solution might be, > > Index: rc.subr > =================================================================== > --- rc.subr (revision 302001) > +++ rc.subr (working copy) > @@ -1071,8 +1071,13 @@ > fi > fi > > + # Before we prepend limits, test if limits is > + # available (/usr is mounted) so that limits can > + # be run. > + if limits >/dev/null 2>&1; then > # Prepend default limits > - _doit="limits -C $_login_class $_doit" > + _doit="limits -C $_login_class $_doit" > + fi > > # run the full command > # > > > -- > Cheers, > Cy Schubert > FreeBSD UNIX: Web: http://www.FreeBSD.org > > The need of the many outweighs the greed of the few. > > > From owner-svn-src-head@freebsd.org Sun Jun 19 03:44:36 2016 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id B5DD4A7A4B7; Sun, 19 Jun 2016 03:44:36 +0000 (UTC) (envelope-from ume@FreeBSD.org) Received: from repo.freebsd.org (repo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 86C8F2F97; Sun, 19 Jun 2016 03:44:36 +0000 (UTC) (envelope-from ume@FreeBSD.org) Received: from repo.freebsd.org ([127.0.1.37]) by repo.freebsd.org (8.15.2/8.15.2) with ESMTP id u5J3iZ2D079685; Sun, 19 Jun 2016 03:44:35 GMT (envelope-from ume@FreeBSD.org) Received: (from ume@localhost) by repo.freebsd.org (8.15.2/8.15.2/Submit) id u5J3iWO6079652; Sun, 19 Jun 2016 03:44:32 GMT (envelope-from ume@FreeBSD.org) Message-Id: <201606190344.u5J3iWO6079652@repo.freebsd.org> X-Authentication-Warning: repo.freebsd.org: ume set sender to ume@FreeBSD.org using -f From: Hajimu UMEMOTO Date: Sun, 19 Jun 2016 03:44:32 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r302016 - in head: share/timedef tools/tools/locale/tools X-SVN-Group: head MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 19 Jun 2016 03:44:36 -0000 Author: ume Date: Sun Jun 19 03:44:32 2016 New Revision: 302016 URL: https://svnweb.freebsd.org/changeset/base/302016 Log: - Prefer to use %d over %e where the day of the month should be zero filled. - Since %e means the day of the month as well, regard %e as same as %d in md_order. Reported by: vangyzen Approved by: re (gjb) Modified: head/share/timedef/ar_JO.UTF-8.src head/share/timedef/ar_MA.UTF-8.src head/share/timedef/ar_SA.UTF-8.src head/share/timedef/be_BY.CP1131.src head/share/timedef/be_BY.CP1251.src head/share/timedef/be_BY.ISO8859-5.src head/share/timedef/be_BY.UTF-8.src head/share/timedef/bg_BG.CP1251.src head/share/timedef/bg_BG.UTF-8.src head/share/timedef/ca_IT.ISO8859-15.src head/share/timedef/ca_IT.UTF-8.src head/share/timedef/el_GR.ISO8859-7.src head/share/timedef/el_GR.UTF-8.src head/share/timedef/en_SG.UTF-8.src head/share/timedef/en_US.UTF-8.src head/share/timedef/es_AR.ISO8859-1.src head/share/timedef/es_CR.UTF-8.src head/share/timedef/es_ES.ISO8859-15.src head/share/timedef/es_ES.UTF-8.src head/share/timedef/fi_FI.ISO8859-15.src head/share/timedef/fi_FI.UTF-8.src head/share/timedef/fr_BE.ISO8859-15.src head/share/timedef/fr_BE.UTF-8.src head/share/timedef/he_IL.UTF-8.src head/share/timedef/hi_IN.ISCII-DEV.src head/share/timedef/hi_IN.UTF-8.src head/share/timedef/is_IS.ISO8859-15.src head/share/timedef/is_IS.UTF-8.src head/share/timedef/ko_KR.UTF-8.src head/share/timedef/ko_KR.eucKR.src head/share/timedef/nl_BE.UTF-8.src head/share/timedef/sl_SI.ISO8859-2.src head/share/timedef/sl_SI.UTF-8.src head/share/timedef/sr_Cyrl_RS.ISO8859-5.src head/share/timedef/sr_Latn_RS.ISO8859-2.src head/share/timedef/sr_Latn_RS.UTF-8.src head/share/timedef/tr_TR.ISO8859-9.src head/share/timedef/tr_TR.UTF-8.src head/share/timedef/zh_Hans_CN.GB2312.src head/share/timedef/zh_Hans_CN.GBK.src head/share/timedef/zh_Hans_CN.UTF-8.src head/share/timedef/zh_Hans_CN.eucCN.src head/share/timedef/zh_Hant_HK.UTF-8.src head/share/timedef/zh_Hant_TW.Big5.src head/share/timedef/zh_Hant_TW.UTF-8.src head/tools/tools/locale/tools/cldr2def.pl Modified: head/share/timedef/ar_JO.UTF-8.src ============================================================================== Binary file (source and/or target). No diff available. Modified: head/share/timedef/ar_MA.UTF-8.src ============================================================================== Binary file (source and/or target). No diff available. Modified: head/share/timedef/ar_SA.UTF-8.src ============================================================================== Binary file (source and/or target). No diff available. Modified: head/share/timedef/be_BY.CP1131.src ============================================================================== Binary file (source and/or target). No diff available. Modified: head/share/timedef/be_BY.CP1251.src ============================================================================== Binary file (source and/or target). No diff available. Modified: head/share/timedef/be_BY.ISO8859-5.src ============================================================================== Binary file (source and/or target). No diff available. Modified: head/share/timedef/be_BY.UTF-8.src ============================================================================== Binary file (source and/or target). No diff available. Modified: head/share/timedef/bg_BG.CP1251.src ============================================================================== --- head/share/timedef/bg_BG.CP1251.src Sun Jun 19 00:39:23 2016 (r302015) +++ head/share/timedef/bg_BG.CP1251.src Sun Jun 19 03:44:32 2016 (r302016) @@ -53,7 +53,7 @@ %H:%M:%S # # x_fmt -%e.%m.%y г. +%d.%m.%y г. # # c_fmt %A %e %B %Y ã. %H:%M:%S @@ -80,7 +80,7 @@ äåêåìâðè # # md_order -m +dm # # ampm_fmt %I:%M:%S %p Modified: head/share/timedef/bg_BG.UTF-8.src ============================================================================== Binary file (source and/or target). No diff available. Modified: head/share/timedef/ca_IT.ISO8859-15.src ============================================================================== --- head/share/timedef/ca_IT.ISO8859-15.src Sun Jun 19 00:39:23 2016 (r302015) +++ head/share/timedef/ca_IT.ISO8859-15.src Sun Jun 19 03:44:32 2016 (r302016) @@ -53,7 +53,7 @@ dissabte %H:%M:%S # # x_fmt -%e/%m/%y +%d/%m/%y # # c_fmt %A %e %B de %Y, %H:%M:%S @@ -80,7 +80,7 @@ de novembre de desembre # # md_order -m +dm # # ampm_fmt %I:%M:%S %p Modified: head/share/timedef/ca_IT.UTF-8.src ============================================================================== --- head/share/timedef/ca_IT.UTF-8.src Sun Jun 19 00:39:23 2016 (r302015) +++ head/share/timedef/ca_IT.UTF-8.src Sun Jun 19 03:44:32 2016 (r302016) @@ -53,7 +53,7 @@ dissabte %H:%M:%S # # x_fmt -%e/%m/%y +%d/%m/%y # # c_fmt %A %e %B de %Y, %H:%M:%S @@ -80,7 +80,7 @@ de novembre de desembre # # md_order -m +dm # # ampm_fmt %I:%M:%S %p Modified: head/share/timedef/el_GR.ISO8859-7.src ============================================================================== Binary file (source and/or target). No diff available. Modified: head/share/timedef/el_GR.UTF-8.src ============================================================================== Binary file (source and/or target). No diff available. Modified: head/share/timedef/en_SG.UTF-8.src ============================================================================== --- head/share/timedef/en_SG.UTF-8.src Sun Jun 19 00:39:23 2016 (r302015) +++ head/share/timedef/en_SG.UTF-8.src Sun Jun 19 03:44:32 2016 (r302016) @@ -53,7 +53,7 @@ Saturday %I:%M:%S %p # # x_fmt -%e/%m/%y +%d/%m/%y # # c_fmt %A %e %B %Y at %I:%M:%S %p @@ -80,7 +80,7 @@ November December # # md_order -m +dm # # ampm_fmt %I:%M:%S %p Modified: head/share/timedef/en_US.UTF-8.src ============================================================================== --- head/share/timedef/en_US.UTF-8.src Sun Jun 19 00:39:23 2016 (r302015) +++ head/share/timedef/en_US.UTF-8.src Sun Jun 19 03:44:32 2016 (r302016) @@ -53,7 +53,7 @@ Saturday %I:%M:%S %p # # x_fmt -%m/%e/%y +%m/%d/%y # # c_fmt %A, %B %e, %Y at %I:%M:%S %p @@ -80,7 +80,7 @@ November December # # md_order -m +md # # ampm_fmt %I:%M:%S %p Modified: head/share/timedef/es_AR.ISO8859-1.src ============================================================================== --- head/share/timedef/es_AR.ISO8859-1.src Sun Jun 19 00:39:23 2016 (r302015) +++ head/share/timedef/es_AR.ISO8859-1.src Sun Jun 19 03:44:32 2016 (r302016) @@ -53,7 +53,7 @@ sábado %I:%M:%S %p # # x_fmt -%e/%m/%y +%d/%m/%y # # c_fmt %e de %B de %Y, %I:%M:%S %p @@ -80,7 +80,7 @@ noviembre diciembre # # md_order -m +dm # # ampm_fmt %I:%M:%S %p Modified: head/share/timedef/es_CR.UTF-8.src ============================================================================== --- head/share/timedef/es_CR.UTF-8.src Sun Jun 19 00:39:23 2016 (r302015) +++ head/share/timedef/es_CR.UTF-8.src Sun Jun 19 03:44:32 2016 (r302016) @@ -53,7 +53,7 @@ sábado %I:%M:%S %p # # x_fmt -%e/%m/%y +%d/%m/%y # # c_fmt %e de %B de %Y, %I:%M:%S %p @@ -80,7 +80,7 @@ noviembre diciembre # # md_order -m +dm # # ampm_fmt %I:%M:%S %p Modified: head/share/timedef/es_ES.ISO8859-15.src ============================================================================== --- head/share/timedef/es_ES.ISO8859-15.src Sun Jun 19 00:39:23 2016 (r302015) +++ head/share/timedef/es_ES.ISO8859-15.src Sun Jun 19 03:44:32 2016 (r302016) @@ -53,7 +53,7 @@ sábado %H:%M:%S # # x_fmt -%e/%m/%y +%d/%m/%y # # c_fmt %e de %B de %Y, %H:%M:%S @@ -80,7 +80,7 @@ noviembre diciembre # # md_order -m +dm # # ampm_fmt %I:%M:%S %p Modified: head/share/timedef/es_ES.UTF-8.src ============================================================================== --- head/share/timedef/es_ES.UTF-8.src Sun Jun 19 00:39:23 2016 (r302015) +++ head/share/timedef/es_ES.UTF-8.src Sun Jun 19 03:44:32 2016 (r302016) @@ -53,7 +53,7 @@ sábado %H:%M:%S # # x_fmt -%e/%m/%y +%d/%m/%y # # c_fmt %e de %B de %Y, %H:%M:%S @@ -80,7 +80,7 @@ noviembre diciembre # # md_order -m +dm # # ampm_fmt %I:%M:%S %p Modified: head/share/timedef/fi_FI.ISO8859-15.src ============================================================================== --- head/share/timedef/fi_FI.ISO8859-15.src Sun Jun 19 00:39:23 2016 (r302015) +++ head/share/timedef/fi_FI.ISO8859-15.src Sun Jun 19 03:44:32 2016 (r302016) @@ -53,7 +53,7 @@ lauantaina %H.%M.%S # # x_fmt -%e.%m.%Y +%d.%m.%Y # # c_fmt %e. %B %Y klo %H.%M.%S @@ -80,7 +80,7 @@ marraskuuta joulukuuta # # md_order -m +dm # # ampm_fmt %I.%M.%S %p Modified: head/share/timedef/fi_FI.UTF-8.src ============================================================================== --- head/share/timedef/fi_FI.UTF-8.src Sun Jun 19 00:39:23 2016 (r302015) +++ head/share/timedef/fi_FI.UTF-8.src Sun Jun 19 03:44:32 2016 (r302016) @@ -53,7 +53,7 @@ lauantaina %H.%M.%S # # x_fmt -%e.%m.%Y +%d.%m.%Y # # c_fmt %e. %B %Y klo %H.%M.%S @@ -80,7 +80,7 @@ marraskuuta joulukuuta # # md_order -m +dm # # ampm_fmt %I.%M.%S %p Modified: head/share/timedef/fr_BE.ISO8859-15.src ============================================================================== --- head/share/timedef/fr_BE.ISO8859-15.src Sun Jun 19 00:39:23 2016 (r302015) +++ head/share/timedef/fr_BE.ISO8859-15.src Sun Jun 19 03:44:32 2016 (r302016) @@ -53,7 +53,7 @@ samedi %H:%M:%S # # x_fmt -%e/%m/%y +%d/%m/%y # # c_fmt %A %e %B %Y %H:%M:%S @@ -80,7 +80,7 @@ novembre décembre # # md_order -m +dm # # ampm_fmt %I:%M:%S %p Modified: head/share/timedef/fr_BE.UTF-8.src ============================================================================== --- head/share/timedef/fr_BE.UTF-8.src Sun Jun 19 00:39:23 2016 (r302015) +++ head/share/timedef/fr_BE.UTF-8.src Sun Jun 19 03:44:32 2016 (r302016) @@ -53,7 +53,7 @@ samedi %H:%M:%S # # x_fmt -%e/%m/%y +%d/%m/%y # # c_fmt %A %e %B %Y %H:%M:%S @@ -80,7 +80,7 @@ novembre décembre # # md_order -m +dm # # ampm_fmt %I:%M:%S %p Modified: head/share/timedef/he_IL.UTF-8.src ============================================================================== Binary file (source and/or target). No diff available. Modified: head/share/timedef/hi_IN.ISCII-DEV.src ============================================================================== --- head/share/timedef/hi_IN.ISCII-DEV.src Sun Jun 19 00:39:23 2016 (r302015) +++ head/share/timedef/hi_IN.ISCII-DEV.src Sun Jun 19 03:44:32 2016 (r302016) @@ -53,7 +53,7 @@ %I:%M:%S %p # # x_fmt -%e/%m/%y +%d/%m/%y # # c_fmt %A %e %B %Y ³å %I:%M:%S %p @@ -80,7 +80,7 @@ ÄÛ×¢ÊÏ # # md_order -m +dm # # ampm_fmt %I:%M:%S %p Modified: head/share/timedef/hi_IN.UTF-8.src ============================================================================== Binary file (source and/or target). No diff available. Modified: head/share/timedef/is_IS.ISO8859-15.src ============================================================================== --- head/share/timedef/is_IS.ISO8859-15.src Sun Jun 19 00:39:23 2016 (r302015) +++ head/share/timedef/is_IS.ISO8859-15.src Sun Jun 19 03:44:32 2016 (r302016) @@ -53,7 +53,7 @@ laugardagur %H:%M:%S # # x_fmt -%e.%m.%Y +%d.%m.%Y # # c_fmt %e. %B %Y kl. %H:%M:%S @@ -80,7 +80,7 @@ nóvember desember # # md_order -m +dm # # ampm_fmt %I:%M:%S %p Modified: head/share/timedef/is_IS.UTF-8.src ============================================================================== --- head/share/timedef/is_IS.UTF-8.src Sun Jun 19 00:39:23 2016 (r302015) +++ head/share/timedef/is_IS.UTF-8.src Sun Jun 19 03:44:32 2016 (r302016) @@ -53,7 +53,7 @@ laugardagur %H:%M:%S # # x_fmt -%e.%m.%Y +%d.%m.%Y # # c_fmt %e. %B %Y kl. %H:%M:%S @@ -80,7 +80,7 @@ nóvember desember # # md_order -m +dm # # ampm_fmt %I:%M:%S %p Modified: head/share/timedef/ko_KR.UTF-8.src ============================================================================== --- head/share/timedef/ko_KR.UTF-8.src Sun Jun 19 00:39:23 2016 (r302015) +++ head/share/timedef/ko_KR.UTF-8.src Sun Jun 19 03:44:32 2016 (r302016) @@ -80,7 +80,7 @@ 12ì›” # # md_order -m +md # # ampm_fmt %p %I:%M:%S Modified: head/share/timedef/ko_KR.eucKR.src ============================================================================== --- head/share/timedef/ko_KR.eucKR.src Sun Jun 19 00:39:23 2016 (r302015) +++ head/share/timedef/ko_KR.eucKR.src Sun Jun 19 03:44:32 2016 (r302016) @@ -80,7 +80,7 @@ 12¿ù # # md_order -m +md # # ampm_fmt %p %I:%M:%S Modified: head/share/timedef/nl_BE.UTF-8.src ============================================================================== --- head/share/timedef/nl_BE.UTF-8.src Sun Jun 19 00:39:23 2016 (r302015) +++ head/share/timedef/nl_BE.UTF-8.src Sun Jun 19 03:44:32 2016 (r302016) @@ -53,7 +53,7 @@ zaterdag %H:%M:%S # # x_fmt -%e/%m/%y +%d/%m/%y # # c_fmt %A %e %B %Y %H:%M:%S @@ -80,7 +80,7 @@ november december # # md_order -m +dm # # ampm_fmt %I:%M:%S %p Modified: head/share/timedef/sl_SI.ISO8859-2.src ============================================================================== --- head/share/timedef/sl_SI.ISO8859-2.src Sun Jun 19 00:39:23 2016 (r302015) +++ head/share/timedef/sl_SI.ISO8859-2.src Sun Jun 19 03:44:32 2016 (r302016) @@ -80,7 +80,7 @@ november december # # md_order -m +dm # # ampm_fmt %I:%M:%S %p Modified: head/share/timedef/sl_SI.UTF-8.src ============================================================================== --- head/share/timedef/sl_SI.UTF-8.src Sun Jun 19 00:39:23 2016 (r302015) +++ head/share/timedef/sl_SI.UTF-8.src Sun Jun 19 03:44:32 2016 (r302016) @@ -80,7 +80,7 @@ november december # # md_order -m +dm # # ampm_fmt %I:%M:%S %p Modified: head/share/timedef/sr_Cyrl_RS.ISO8859-5.src ============================================================================== --- head/share/timedef/sr_Cyrl_RS.ISO8859-5.src Sun Jun 19 00:39:23 2016 (r302015) +++ head/share/timedef/sr_Cyrl_RS.ISO8859-5.src Sun Jun 19 03:44:32 2016 (r302016) @@ -87,7 +87,7 @@ subota %H.%M.%S""%H.%M.%S # # x_fmt -%e.%m.%y.""%e.%m.%y. +%d.%m.%y.""%e.%m.%y. # # c_fmt %d. %B %Y. %H.%M.%S""%d. %B %Y. %H.%M.%S %Z @@ -126,7 +126,7 @@ novembar decembar # # md_order -mm +dmdm # # ampm_fmt %I.%M.%S %p""%I.%M.%S %p Modified: head/share/timedef/sr_Latn_RS.ISO8859-2.src ============================================================================== --- head/share/timedef/sr_Latn_RS.ISO8859-2.src Sun Jun 19 00:39:23 2016 (r302015) +++ head/share/timedef/sr_Latn_RS.ISO8859-2.src Sun Jun 19 03:44:32 2016 (r302016) @@ -87,7 +87,7 @@ subota %H.%M.%S""%H.%M.%S # # x_fmt -%e.%m.%y.""%e.%m.%y. +%d.%m.%y.""%d.%m.%y. # # c_fmt %d. %B %Y. %H.%M.%S""%d. %B %Y. %H.%M.%S %Z @@ -126,7 +126,7 @@ novembar decembar # # md_order -mm +dmdm # # ampm_fmt %I.%M.%S %p""%I.%M.%S %p Modified: head/share/timedef/sr_Latn_RS.UTF-8.src ============================================================================== Binary file (source and/or target). No diff available. Modified: head/share/timedef/tr_TR.ISO8859-9.src ============================================================================== --- head/share/timedef/tr_TR.ISO8859-9.src Sun Jun 19 00:39:23 2016 (r302015) +++ head/share/timedef/tr_TR.ISO8859-9.src Sun Jun 19 03:44:32 2016 (r302016) @@ -53,7 +53,7 @@ Cumartesi %H:%M:%S # # x_fmt -%e.%m.%Y +%d.%m.%Y # # c_fmt %A %e %B %Y %H:%M:%S @@ -80,7 +80,7 @@ Kasým Aralýk # # md_order -m +dm # # ampm_fmt %p %I:%M:%S Modified: head/share/timedef/tr_TR.UTF-8.src ============================================================================== --- head/share/timedef/tr_TR.UTF-8.src Sun Jun 19 00:39:23 2016 (r302015) +++ head/share/timedef/tr_TR.UTF-8.src Sun Jun 19 03:44:32 2016 (r302016) @@ -53,7 +53,7 @@ Cumartesi %H:%M:%S # # x_fmt -%e.%m.%Y +%d.%m.%Y # # c_fmt %A %e %B %Y %H:%M:%S @@ -80,7 +80,7 @@ Kasım Aralık # # md_order -m +dm # # ampm_fmt %p %I:%M:%S Modified: head/share/timedef/zh_Hans_CN.GB2312.src ============================================================================== --- head/share/timedef/zh_Hans_CN.GB2312.src Sun Jun 19 00:39:23 2016 (r302015) +++ head/share/timedef/zh_Hans_CN.GB2312.src Sun Jun 19 03:44:32 2016 (r302016) @@ -53,7 +53,7 @@ PGFZAy %p%I:%M:%S # # x_fmt -%y#/%m#/%e +%y#/%m#/%d # # c_fmt %YDj%mTB%eHU %p%I:%M:%S @@ -80,7 +80,7 @@ J.R;TB J.6~TB # # md_order -m +md # # ampm_fmt %p%I:%M:%S Modified: head/share/timedef/zh_Hans_CN.GBK.src ============================================================================== --- head/share/timedef/zh_Hans_CN.GBK.src Sun Jun 19 00:39:23 2016 (r302015) +++ head/share/timedef/zh_Hans_CN.GBK.src Sun Jun 19 03:44:32 2016 (r302016) @@ -53,7 +53,7 @@ %p%I:%M:%S # # x_fmt -%y/%m/%e +%y/%m/%d # # c_fmt %YÄê%mÔÂ%eÈÕ %p%I:%M:%S @@ -80,7 +80,7 @@ Ê®¶þÔ # # md_order -m +md # # ampm_fmt %p%I:%M:%S Modified: head/share/timedef/zh_Hans_CN.UTF-8.src ============================================================================== Binary file (source and/or target). No diff available. Modified: head/share/timedef/zh_Hans_CN.eucCN.src ============================================================================== --- head/share/timedef/zh_Hans_CN.eucCN.src Sun Jun 19 00:39:23 2016 (r302015) +++ head/share/timedef/zh_Hans_CN.eucCN.src Sun Jun 19 03:44:32 2016 (r302016) @@ -53,7 +53,7 @@ %p%I:%M:%S # # x_fmt -%y£¯%m£¯%e +%y£¯%m£¯%d # # c_fmt %YÄê%mÔÂ%eÈÕ %p%I:%M:%S @@ -80,7 +80,7 @@ Ê®¶þÔ # # md_order -m +md # # ampm_fmt %p%I:%M:%S Modified: head/share/timedef/zh_Hant_HK.UTF-8.src ============================================================================== --- head/share/timedef/zh_Hant_HK.UTF-8.src Sun Jun 19 00:39:23 2016 (r302015) +++ head/share/timedef/zh_Hant_HK.UTF-8.src Sun Jun 19 03:44:32 2016 (r302016) @@ -53,7 +53,7 @@ %p%I:%M:%S # # x_fmt -%e/%m/%y +%d/%m/%y # # c_fmt %Yå¹´%m月%eæ—¥ %p%I:%M:%S [%Z] @@ -80,7 +80,7 @@ 12月 # # md_order -m +dm # # ampm_fmt %p%I:%M:%S Modified: head/share/timedef/zh_Hant_TW.Big5.src ============================================================================== --- head/share/timedef/zh_Hant_TW.Big5.src Sun Jun 19 00:39:23 2016 (r302015) +++ head/share/timedef/zh_Hant_TW.Big5.src Sun Jun 19 03:44:32 2016 (r302016) @@ -53,7 +53,7 @@ %p%I:%M:%S # # x_fmt -%Y¢A%m¢A%e +%Y¢A%m¢A%d # # c_fmt %Y¦~%m¤ë%e¤é %p%I:%M:%S [%Z] @@ -80,7 +80,7 @@ ¢°¢±¤ë # # md_order -m +md # # ampm_fmt %p%I:%M:%S Modified: head/share/timedef/zh_Hant_TW.UTF-8.src ============================================================================== --- head/share/timedef/zh_Hant_TW.UTF-8.src Sun Jun 19 00:39:23 2016 (r302015) +++ head/share/timedef/zh_Hant_TW.UTF-8.src Sun Jun 19 03:44:32 2016 (r302016) @@ -53,7 +53,7 @@ %p%I:%M:%S # # x_fmt -%Y/%m/%e +%Y/%m/%d # # c_fmt %Yå¹´%m月%eæ—¥ %p%I:%M:%S [%Z] @@ -80,7 +80,7 @@ 12月 # # md_order -m +md # # ampm_fmt %p%I:%M:%S Modified: head/tools/tools/locale/tools/cldr2def.pl ============================================================================== --- head/tools/tools/locale/tools/cldr2def.pl Sun Jun 19 00:39:23 2016 (r302015) +++ head/tools/tools/locale/tools/cldr2def.pl Sun Jun 19 03:44:32 2016 (r302016) @@ -68,6 +68,7 @@ my %callback = ( mdorder => \&callback_mdorder, altmon => \&callback_altmon, cformat => \&callback_cformat, + dformat => \&callback_dformat, dtformat => \&callback_dtformat, cbabmon => \&callback_abmon, cbampm => \&callback_ampm, @@ -183,10 +184,9 @@ if ($TYPE eq "timedef") { "abday" => "as", "day" => "as", "t_fmt" => "s", - "d_fmt" => "s", + "d_fmt" => " " " "s", "d_t_fmt" => " " "|[-.]))%e/$1%d/; + $s =~ s/%e((|[-.])%m)/%d$1/; + return $s; +}; + sub callback_dtformat { my $s = shift; my $nl = $callback{data}{l} . "_" . $callback{data}{c}; @@ -241,7 +249,8 @@ sub callback_dtformat { sub callback_mdorder { my $s = shift; return undef if (!defined $s); - $s =~ s/[^dm]//g; + $s =~ s/[^dem]//g; + $s =~ s/e/d/g; return $s; }; From owner-svn-src-head@freebsd.org Sun Jun 19 03:45:33 2016 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id DCB65A7A516; Sun, 19 Jun 2016 03:45:33 +0000 (UTC) (envelope-from adrian@FreeBSD.org) Received: from repo.freebsd.org (repo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id B7C091237; Sun, 19 Jun 2016 03:45:33 +0000 (UTC) (envelope-from adrian@FreeBSD.org) Received: from repo.freebsd.org ([127.0.1.37]) by repo.freebsd.org (8.15.2/8.15.2) with ESMTP id u5J3jW4S079769; Sun, 19 Jun 2016 03:45:32 GMT (envelope-from adrian@FreeBSD.org) Received: (from adrian@localhost) by repo.freebsd.org (8.15.2/8.15.2/Submit) id u5J3jWKi079768; Sun, 19 Jun 2016 03:45:32 GMT (envelope-from adrian@FreeBSD.org) Message-Id: <201606190345.u5J3jWKi079768@repo.freebsd.org> X-Authentication-Warning: repo.freebsd.org: adrian set sender to adrian@FreeBSD.org using -f From: Adrian Chadd Date: Sun, 19 Jun 2016 03:45:32 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r302017 - head/sys/dev/ath X-SVN-Group: head MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 19 Jun 2016 03:45:34 -0000 Author: adrian Date: Sun Jun 19 03:45:32 2016 New Revision: 302017 URL: https://svnweb.freebsd.org/changeset/base/302017 Log: [ath] add support for batching frames to the general TX queues. It turns out the frame scheduling policies (eg DBA_GATED) operate on a single TX FIFO entry. ASAP scheduling is fine; those frames always go out. DBA-gated sets the TX queue ready when the DBA timer fires, which triggers a beacon transmit. Normally this is used for content-after-beacon queue (CABQ) work, which needs to burst out immediately after a beacon. (eg broadcast, multicast, etc frames.) This is a general policy that you can use for any queue, and Sam's TDMA code uses it. When DBA_GATED is used and something like say, an 11e TX burst window, it only operates on a single TX FIFO entry. If you have a single frame per TX FIFO entry and say, a 2.5ms long burst window (eg TDMA!) then it'll only burst a single frame every 2.5ms. If there's no gating (eg ASAP) then the burst window is fine, and multiple TX FIFO slots get used. The CABQ code does pack in a list of frames (ie, the whole cabq) but up until this commit, the normal TX queues didn't. It showed up when I started to debug TDMA on the AR9380 and later. This commit doesn't fix the TDMA case - that's still broken here, because all I'm doing here is allowing 'some' frames to be bursting, but I'm certainly not filling the whole TX FIFO slot entry with frames. Doing that 'properly' kind of requires me to take into account how long packets should take to transmit and say, doing 1.5 or something times that per TX FIFO slot, as if you partially transmit a slot, when it's next gated it'll just finish that TX FIFO slot, then not advance to the next one. Now, I /also/ think queuing a new packet restarts DMA, but you have to push new frames into the TX FIFO. I need to experiment some more with this because if it's really the case, I will be able to do TDMA support without the egregious hacks I have in my local tree. Sam's TDMA code for previous chips would just kick the TXE bit to push along DMA again, but we can't do that for EDMA chips - we /have/ to push a new frame into the TX FIFO to restart DMA. Ugh. Tested: * AR9380, STA mode * AR9380, hostap mode * AR9580, hostap mode Approved by: re (gjb) Modified: head/sys/dev/ath/if_ath_tx_edma.c Modified: head/sys/dev/ath/if_ath_tx_edma.c ============================================================================== --- head/sys/dev/ath/if_ath_tx_edma.c Sun Jun 19 03:44:32 2016 (r302016) +++ head/sys/dev/ath/if_ath_tx_edma.c Sun Jun 19 03:45:32 2016 (r302017) @@ -138,79 +138,186 @@ MALLOC_DECLARE(M_ATHDEV); static void ath_edma_tx_processq(struct ath_softc *sc, int dosched); -/* - * Push some frames into the TX FIFO if we have space. - */ +#ifdef ATH_DEBUG_ALQ static void -ath_edma_tx_fifo_fill(struct ath_softc *sc, struct ath_txq *txq) +ath_tx_alq_edma_push(struct ath_softc *sc, int txq, int nframes, + int fifo_depth, int frame_cnt) +{ + struct if_ath_alq_tx_fifo_push aq; + + aq.txq = htobe32(txq); + aq.nframes = htobe32(nframes); + aq.fifo_depth = htobe32(fifo_depth); + aq.frame_cnt = htobe32(frame_cnt); + + if_ath_alq_post(&sc->sc_alq, ATH_ALQ_TX_FIFO_PUSH, + sizeof(aq), + (const char *) &aq); +} +#endif /* ATH_DEBUG_ALQ */ + +static void +ath_tx_edma_push_staging_list(struct ath_softc *sc, struct ath_txq *txq, + int limit) { struct ath_buf *bf, *bf_last; - int i = 0; + struct ath_buf *bfi, *bfp; + int i, sqdepth; + TAILQ_HEAD(axq_q_f_s, ath_buf) sq; ATH_TXQ_LOCK_ASSERT(txq); - DPRINTF(sc, ATH_DEBUG_TX_PROC, "%s: Q%d: called\n", - __func__, - txq->axq_qnum); + /* + * Don't bother doing any work if it's full. + */ + if (txq->axq_fifo_depth >= HAL_TXFIFO_DEPTH) + return; - TAILQ_FOREACH(bf, &txq->axq_q, bf_list) { - if (txq->axq_fifo_depth >= HAL_TXFIFO_DEPTH) - break; + if (TAILQ_EMPTY(&txq->axq_q)) + return; - /* - * We have space in the FIFO - so let's push a frame - * into it. - */ + TAILQ_INIT(&sq); - /* - * Remove it from the normal list - */ + /* + * First pass - walk sq, queue up to 'limit' entries, + * subtract them from the staging queue. + */ + sqdepth = 0; + for (i = 0; i < limit; i++) { + /* Grab the head entry */ + bf = ATH_TXQ_FIRST(txq); + if (bf == NULL) + break; ATH_TXQ_REMOVE(txq, bf, bf_list); - /* - * XXX for now, we only dequeue a frame at a time, so - * that's only one buffer. Later on when we just - * push this staging _list_ into the queue, we'll - * set bf_last to the end pointer in the list. - */ - bf_last = bf; - DPRINTF(sc, ATH_DEBUG_TX_PROC, - "%s: Q%d: depth=%d; pushing %p->%p\n", - __func__, - txq->axq_qnum, - txq->axq_fifo_depth, - bf, - bf_last); + /* Queue it into our staging list */ + TAILQ_INSERT_TAIL(&sq, bf, bf_list); + sqdepth++; + } - /* - * Append it to the FIFO staging list - */ - ATH_TXQ_INSERT_TAIL(&txq->fifo, bf, bf_list); + /* + * Ok, so now we have a staging list of up to 'limit' + * frames from the txq. Now let's wrap that up + * into its own list and pass that to the hardware + * as one FIFO entry. + */ - /* - * Set fifo start / fifo end flags appropriately - * - */ - bf->bf_flags |= ATH_BUF_FIFOPTR; - bf_last->bf_flags |= ATH_BUF_FIFOEND; + bf = TAILQ_FIRST(&sq); + bf_last = TAILQ_LAST(&sq, axq_q_s); - /* - * Push _into_ the FIFO. - */ - ath_hal_puttxbuf(sc->sc_ah, txq->axq_qnum, bf->bf_daddr); + /* + * Ok, so here's the gymnastics reqiured to make this + * all sensible. + */ + + /* + * Tag the first/last buffer appropriately. + */ + bf->bf_flags |= ATH_BUF_FIFOPTR; + bf_last->bf_flags |= ATH_BUF_FIFOEND; + + /* + * Walk the descriptor list and link them appropriately. + */ + bfp = NULL; + TAILQ_FOREACH(bfi, &sq, bf_list) { + if (bfp != NULL) { + ath_hal_settxdesclink(sc->sc_ah, bfp->bf_lastds, + bfi->bf_daddr); + } + bfp = bfi; + } + + i = 0; + TAILQ_FOREACH(bfi, &sq, bf_list) { #ifdef ATH_DEBUG if (sc->sc_debug & ATH_DEBUG_XMIT_DESC) - ath_printtxbuf(sc, bf, txq->axq_qnum, i, 0); + ath_printtxbuf(sc, bfi, txq->axq_qnum, i, 0); #endif/* ATH_DEBUG */ #ifdef ATH_DEBUG_ALQ if (if_ath_alq_checkdebug(&sc->sc_alq, ATH_ALQ_EDMA_TXDESC)) - ath_tx_alq_post(sc, bf); + ath_tx_alq_post(sc, bfi); #endif /* ATH_DEBUG_ALQ */ - txq->axq_fifo_depth++; i++; } - if (i > 0) - ath_hal_txstart(sc->sc_ah, txq->axq_qnum); + + /* + * We now need to push this set of frames onto the tail + * of the FIFO queue. We don't adjust the aggregate + * count, only the queue depth counter(s). + * We also need to blank the link pointer now. + */ + + TAILQ_CONCAT(&txq->fifo.axq_q, &sq, bf_list); + /* Bump total queue tracking in FIFO queue */ + txq->fifo.axq_depth += sqdepth; + + /* Bump FIFO queue */ + txq->axq_fifo_depth++; + DPRINTF(sc, ATH_DEBUG_XMIT, + "%s: queued %d packets; depth=%d, fifo depth=%d\n", + __func__, sqdepth, txq->fifo.axq_depth, txq->axq_fifo_depth); + + /* Push the first entry into the hardware */ + ath_hal_puttxbuf(sc->sc_ah, txq->axq_qnum, bf->bf_daddr); + + /* Push start on the DMA if it's not already started */ + ath_hal_txstart(sc->sc_ah, txq->axq_qnum); + +#ifdef ATH_DEBUG_ALQ + ath_tx_alq_edma_push(sc, txq->axq_qnum, sqdepth, + txq->axq_fifo_depth, + txq->fifo.axq_depth); +#endif /* ATH_DEBUG_ALQ */ +} + +/* + * Push some frames into the TX FIFO if we have space. + */ +static void +ath_edma_tx_fifo_fill(struct ath_softc *sc, struct ath_txq *txq) +{ + + ATH_TXQ_LOCK_ASSERT(txq); + + DPRINTF(sc, ATH_DEBUG_TX_PROC, "%s: Q%d: called\n", + __func__, + txq->axq_qnum); + + /* + * For now, push up to 4 frames per TX FIFO slot. + * If more are in the hardware queue then they'll + * get populated when we try to send another frame + * or complete a frame - so at most there'll be + * 32 non-AMPDU frames per TXQ. + * + * Note that the hardware staging queue will limit + * how many frames in total we will have pushed into + * here. + * + * Later on, we'll want to push less frames into + * the TX FIFO since we don't want to necessarily + * fill tens or hundreds of milliseconds of potential + * frames. + * + * However, we need more frames right now because of + * how the MAC implements the frame scheduling policy. + * It only ungates a single FIFO entry at a time, + * and will run that until CHNTIME expires or the + * end of that FIFO entry descriptor list is reached. + * So for TDMA we suffer a big performance penalty - + * single TX FIFO entries mean the MAC only sends out + * one frame per DBA event, which turned out on average + * 6ms per TX frame. + * + * So, for aggregates it's okay - it'll push two at a + * time and this will just do them more efficiently. + * For non-aggregates it'll do 4 at a time, up to the + * non-aggr limit (non_aggr, which is 32.) They should + * be time based rather than a hard count, but I also + * do need sleep. + */ + ath_tx_edma_push_staging_list(sc, txq, 4); } /* From owner-svn-src-head@freebsd.org Sun Jun 19 03:45:43 2016 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 84410A7A53C; Sun, 19 Jun 2016 03:45:43 +0000 (UTC) (envelope-from allanjude@freebsd.org) Received: from mx1.scaleengine.net (mx1.scaleengine.net [209.51.186.6]) by mx1.freebsd.org (Postfix) with ESMTP id 66AC91391; Sun, 19 Jun 2016 03:45:42 +0000 (UTC) (envelope-from allanjude@freebsd.org) Received: from [10.1.1.2] (unknown [10.1.1.2]) (Authenticated sender: allanjude.freebsd@scaleengine.com) by mx1.scaleengine.net (Postfix) with ESMTPSA id 33493DE21; Sun, 19 Jun 2016 03:45:36 +0000 (UTC) Subject: Re: svn commit: r288291 - head/etc To: Adrian Chadd , Cy Schubert References: <2171b966-35c7-2dad-2c0f-f23061cb677a@freebsd.org> <201606190006.u5J06Qk6009591@slippy.cwsent.com> Cc: Niclas Zeising , "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" From: Allan Jude Message-ID: <9ca0ba1b-d9b3-6028-5645-d8d03e730f5e@freebsd.org> Date: Sat, 18 Jun 2016 23:45:35 -0400 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.1.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 19 Jun 2016 03:45:43 -0000 On 2016-06-18 23:32, Adrian Chadd wrote: > i think that's fine for -11. I'd like to just move limits to /bin for > 12. (I mean, it's 2016, why are you splitting / and /usr again? But..) > bsdinstall for UFS just uses one big /, and ZFS does something similar for boot environments. Only people who have partitioned manually, or upgraded in place from 8.x or earlier, will still have separate / and /usr. We can't throw those people under the bus, but, it is reasonable to consider switching things around for 12. > I don't want to see differing system behaviour between limits but it's > likely unavoidable for 11 and could do with some errata notice so > people know what to expect. > > Thanks, > > > -adrian > -- Allan Jude From owner-svn-src-head@freebsd.org Sun Jun 19 04:58:00 2016 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id EEF4CA7801E for ; Sun, 19 Jun 2016 04:58:00 +0000 (UTC) (envelope-from mailing-machine@vniz.net) Received: from mail-lf0-f51.google.com (mail-lf0-f51.google.com [209.85.215.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 782A32C42 for ; Sun, 19 Jun 2016 04:58:00 +0000 (UTC) (envelope-from mailing-machine@vniz.net) Received: by mail-lf0-f51.google.com with SMTP id f6so19660801lfg.0 for ; Sat, 18 Jun 2016 21:58:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=gUz0urVfuDPnzYt754mRo+HTlub/Of3e/6PtZ/GXshI=; b=CxnE2GMqYC/J0y+hVyw45P7ae8Pl0hLOlhe0VUXUzUFI7Ef9IpuFXYN3hGVS4LhPSB XIUbqhDwH8nvq1dmlw917CL4cDKCexCths9EMoM1+9rOF6/Vb4524hBOFk6gYEl1aVhN Gbwgx+RV4NvdGf2gLryni3iQm4r3BS85kE8yLxJwnzyDo+YVHDFUoHYbPGiivgJca0iE Pa0tdNgjWyIA8SB1LXtQXwm+uvsWbu8lE3qpaQ/+R3xVWsB07yE5UrYW4UveRKSRjnMu 3iDc1IVlZPXFiUBaqgu/m1FUx7NT1Q5Kthv/Z2tsdPOBpG+dErNgNB1XaR2hWWPvvmpr g7eA== X-Gm-Message-State: ALyK8tLqQKlxbccwYGz/1Q2LYcBn1oK/LR03xDru0PFh4JiGZ51m6/GvmATCwaPG/BGgzQ== X-Received: by 10.25.153.148 with SMTP id b142mr2696747lfe.61.1466312271479; Sat, 18 Jun 2016 21:57:51 -0700 (PDT) Received: from [192.168.1.2] ([89.169.173.68]) by smtp.gmail.com with ESMTPSA id m71sm2931372lfb.48.2016.06.18.21.57.50 (version=TLSv1/SSLv3 cipher=OTHER); Sat, 18 Jun 2016 21:57:50 -0700 (PDT) Subject: Re: svn commit: r302016 - in head: share/timedef tools/tools/locale/tools To: Hajimu UMEMOTO , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org References: <201606190344.u5J3iWO6079652@repo.freebsd.org> From: Andrey Chernov Message-ID: <3387744f-7abd-417c-599f-163e78b4170e@freebsd.org> Date: Sun, 19 Jun 2016 07:57:49 +0300 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.1.1 MIME-Version: 1.0 In-Reply-To: <201606190344.u5J3iWO6079652@repo.freebsd.org> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 19 Jun 2016 04:58:01 -0000 On 19.06.2016 6:44, Hajimu UMEMOTO wrote: > Log: > - Prefer to use %d over %e where the day of the month should be zero > filled. > - Since %e means the day of the month as well, regard %e as same as %d > in md_order. Nonsense doubled formats in sr_*_RS locales and nonsense md_order there too. From owner-svn-src-head@freebsd.org Sun Jun 19 05:12:45 2016 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 78750A78603; Sun, 19 Jun 2016 05:12:45 +0000 (UTC) (envelope-from cy.schubert@komquats.com) Received: from smtp-out-no.shaw.ca (smtp-out-no.shaw.ca [64.59.134.9]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "Client", Issuer "CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 1E7FC1689; Sun, 19 Jun 2016 05:12:44 +0000 (UTC) (envelope-from cy.schubert@komquats.com) Received: from spqr.komquats.com ([96.50.22.10]) by shaw.ca with SMTP id EV2CbY2XWEWlrEV2Dbvmlr; Sat, 18 Jun 2016 23:12:38 -0600 X-Authority-Analysis: v=2.2 cv=P7p4vWIu c=1 sm=1 tr=0 a=jvE2nwUzI0ECrNeyr98KWA==:117 a=jvE2nwUzI0ECrNeyr98KWA==:17 a=L9H7d07YOLsA:10 a=9cW_t1CCXrUA:10 a=s5jvgZ67dGcA:10 a=pD_ry4oyNxEA:10 a=YxBL1-UpAAAA:8 a=6I5d2MoRAAAA:8 a=zi7m5VRXUajJoAgkUkEA:9 a=Ia-lj3WSrqcvXOmTRaiG:22 a=IjZwj45LgO3ly-622nXo:22 Received: from slippy.cwsent.com (slippy [10.1.1.91]) by spqr.komquats.com (Postfix) with ESMTPS id 6493013753; Sat, 18 Jun 2016 22:12:36 -0700 (PDT) Received: from slippy (localhost [127.0.0.1]) by slippy.cwsent.com (8.15.2/8.15.2) with ESMTP id u5J5CYoL045032; Sat, 18 Jun 2016 22:12:34 -0700 (PDT) (envelope-from Cy.Schubert@cschubert.com) Message-Id: <201606190512.u5J5CYoL045032@slippy.cwsent.com> X-Mailer: exmh version 2.8.0 04/21/2012 with nmh-1.6 Reply-to: Cy Schubert From: Cy Schubert X-os: FreeBSD X-Sender: cy@cwsent.com X-URL: http://www.cschubert.com/ To: Adrian Chadd cc: Cy Schubert , Niclas Zeising , "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Subject: Re: svn commit: r288291 - head/etc In-Reply-To: Message from Adrian Chadd of "Sat, 18 Jun 2016 20:32:26 -0700." Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Sat, 18 Jun 2016 22:12:34 -0700 X-CMAE-Envelope: MS4wfIh0upPgUsAsKi6HCn3NWleg9IS/MG2ZlAltD4zcGFHu5S9F3ENwmt+ReZqY9urSxqax4P9F/xX4HK8tjE0tnGpaua+lm14eQ3fmzNCypRtDsUyUDIl/ aFGRMReGFKZZLUoIO2RN2OUA4m7njyxQqPbhbKDPZYFAJ4OAs6mdvriwIYBT3KE3uZm9pRfyYWkEnMMUfqMMAQhC+sOW6y14XrFYkB+JgrUHIGrPuZe7bJIu s9Fttz73yQHGEnPSyM+JtHBBuONBWnSvEaRixIxAEceGj9ukdsE5I97n2k8lrTdywue/+YjVKSk/F/J0Ity0nQ== X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 19 Jun 2016 05:12:45 -0000 In message , Adrian Chadd writes: > i think that's fine for -11. I'd like to just move limits to /bin for > 12. (I mean, it's 2016, why are you splitting / and /usr again? But..) > > I don't want to see differing system behaviour between limits but it's > likely unavoidable for 11 and could do with some errata notice so > people know what to expect. There aren't any daemons started prior to critical local filesystems being mounted. I suppose one day there could be but none at this point in time. Setting limits before filesystems are mounted is practically a NOP anyway. (Except it could negatively affect fsck of huge UFS filesystems some day.) -- Cheers, Cy Schubert FreeBSD UNIX: Web: http://www.FreeBSD.org The need of the many outweighs the greed of the few. From owner-svn-src-head@freebsd.org Sun Jun 19 05:31:19 2016 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 6A75EA788B6; Sun, 19 Jun 2016 05:31:19 +0000 (UTC) (envelope-from cy.schubert@komquats.com) Received: from smtp-out-so.shaw.ca (smtp-out-so.shaw.ca [64.59.136.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "Client", Issuer "CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id F11351CC0; Sun, 19 Jun 2016 05:31:18 +0000 (UTC) (envelope-from cy.schubert@komquats.com) Received: from spqr.komquats.com ([96.50.22.10]) by shaw.ca with SMTP id EVK9bOiRXN9d0EVKAb4eTu; Sat, 18 Jun 2016 23:31:11 -0600 X-Authority-Analysis: v=2.2 cv=QZUkhYTv c=1 sm=1 tr=0 a=jvE2nwUzI0ECrNeyr98KWA==:117 a=jvE2nwUzI0ECrNeyr98KWA==:17 a=L9H7d07YOLsA:10 a=9cW_t1CCXrUA:10 a=s5jvgZ67dGcA:10 a=pD_ry4oyNxEA:10 a=6I5d2MoRAAAA:8 a=YxBL1-UpAAAA:8 a=L_FtLdo2QMd5WKjfqdYA:9 a=IjZwj45LgO3ly-622nXo:22 a=Ia-lj3WSrqcvXOmTRaiG:22 Received: from slippy.cwsent.com (slippy [10.1.1.91]) by spqr.komquats.com (Postfix) with ESMTPS id 2E1AF13753; Sat, 18 Jun 2016 22:31:09 -0700 (PDT) Received: from slippy (localhost [127.0.0.1]) by slippy.cwsent.com (8.15.2/8.15.2) with ESMTP id u5J5V84J049670; Sat, 18 Jun 2016 22:31:08 -0700 (PDT) (envelope-from Cy.Schubert@cschubert.com) Message-Id: <201606190531.u5J5V84J049670@slippy.cwsent.com> X-Mailer: exmh version 2.8.0 04/21/2012 with nmh-1.6 Reply-to: Cy Schubert From: Cy Schubert X-os: FreeBSD X-Sender: cy@cwsent.com X-URL: http://www.cschubert.com/ To: Allan Jude cc: Adrian Chadd , Cy Schubert , Niclas Zeising , "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Subject: Re: svn commit: r288291 - head/etc In-Reply-To: Message from Allan Jude of "Sat, 18 Jun 2016 23:45:35 -0400." <9ca0ba1b-d9b3-6028-5645-d8d03e730f5e@freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Sat, 18 Jun 2016 22:31:08 -0700 X-CMAE-Envelope: MS4wfJoYz4WasfekSuvV3THq/bVs8YiCUJVbLbf10grECaKsaHo661eKwuAKeif0/+y7BbU1gCWMGWrBBEKa+YRw9QCzeUWjDuKE+sOpgzeJ1U6cQJyMUd/S ztXQFlnMUD7DgOb4P1l8RACINVJrMIM/3Qpzlojpq0WcPLKA7ITD9rmSm1ZNSceedPCNkOQNgdsEDGHaS6t//yk3hthOT2IRRumAkYfJvW2tp9erMGoFE3iQ kRQ3PCnxWGbIoqut7RMZGBvM32wY6Tp4/qiUv8mk/ZU5ZjvETsBfY6VeIg6WYGhf42r3biCY0wFoCYQYrwIbNjujyM2Tiy8YC4rLWILHmIXh4qSGKRXA2QZ7 Tlj2DT0a X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 19 Jun 2016 05:31:19 -0000 In message <9ca0ba1b-d9b3-6028-5645-d8d03e730f5e@freebsd.org>, Allan Jude write s: > On 2016-06-18 23:32, Adrian Chadd wrote: > > i think that's fine for -11. I'd like to just move limits to /bin for > > 12. (I mean, it's 2016, why are you splitting / and /usr again? But..) > > > > bsdinstall for UFS just uses one big /, and ZFS does something similar > for boot environments. Only people who have partitioned manually, or > upgraded in place from 8.x or earlier, will still have separate / and > /usr. We can't throw those people under the bus, but, it is reasonable > to consider switching things around for 12. This is only an issue legacy systems, systems that have had their disks be installed on faster systems and systems which have been cloned from older systems (dump | restore). There's something to be said about an O/S that doesn't need to be re-imaged every hardware/software upgrade or migration. It's also an issue for systems which have a small local root/ramdisk, and mount /usr via NFS. I managed a setup like this (not FreeBSD) once. -- Cheers, Cy Schubert FreeBSD UNIX: Web: http://www.FreeBSD.org The need of the many outweighs the greed of the few. From owner-svn-src-head@freebsd.org Sun Jun 19 05:32:37 2016 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 1D772A78A3C; Sun, 19 Jun 2016 05:32:37 +0000 (UTC) (envelope-from ume@mahoroba.org) Received: from mail.mahoroba.org (ent.mahoroba.org [IPv6:2001:2f0:104:8010::1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "asuka.mahoroba.org", Issuer "ca.mahoroba.org" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id BEE9A1EF0; Sun, 19 Jun 2016 05:32:36 +0000 (UTC) (envelope-from ume@mahoroba.org) Received: from vsuiko.mahoroba.org (vsuiko.mahoroba.org [IPv6:2001:2f0:104:8010:a00:27ff:feb0:c2e]) (user=ume mech=DIGEST-MD5 bits=0) by mail.mahoroba.org (8.15.2/8.15.2) with ESMTPSA/inet6 id u5J5WUQG085806 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NO); Sun, 19 Jun 2016 14:32:31 +0900 (JST) (envelope-from ume@mahoroba.org) Date: Sun, 19 Jun 2016 14:31:53 +0900 Message-ID: From: Hajimu UMEMOTO To: Andrey Chernov Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r302016 - in head: share/timedef tools/tools/locale/tools In-Reply-To: <3387744f-7abd-417c-599f-163e78b4170e@freebsd.org> References: <201606190344.u5J3iWO6079652@repo.freebsd.org> <3387744f-7abd-417c-599f-163e78b4170e@freebsd.org> User-Agent: xcite1.60> Wanderlust/2.15.9 (Almost Unreal) Emacs/24.5 Mule/6.0 (HANACHIRUSATO) X-Operating-System: FreeBSD 10.3-STABLE X-PGP-Key: http://www.mahoroba.org/~ume/publickey.asc X-PGP-Fingerprint: 1F00 0B9E 2164 70FC 6DC5 BF5F 04E9 F086 BF90 71FE MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.6 (mail.mahoroba.org [IPv6:2001:2f0:104:8010::1]); Sun, 19 Jun 2016 14:32:31 +0900 (JST) X-Virus-Scanned: clamav-milter 0.99.2 at asuka.mahoroba.org X-Virus-Status: Clean X-Spam-Status: No, score=-3.9 required=5.0 tests=ALL_TRUSTED,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,RP_MATCHES_RCVD autolearn=ham autolearn_force=no version=3.4.1 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on asuka.mahoroba.org X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 19 Jun 2016 05:32:37 -0000 Hi, >>>>> On Sun, 19 Jun 2016 07:57:49 +0300 >>>>> Andrey Chernov said: ache> Nonsense doubled formats in sr_*_RS locales and nonsense md_order there too. It seems there was the problem before my commit. Only saw a little, I'm not sure were it comes. Sincerely, -- Hajimu UMEMOTO ume@mahoroba.org ume@FreeBSD.org http://www.mahoroba.org/~ume/ From owner-svn-src-head@freebsd.org Sun Jun 19 07:31:03 2016 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id EABF4A7AEF8; Sun, 19 Jun 2016 07:31:03 +0000 (UTC) (envelope-from adrian@FreeBSD.org) Received: from repo.freebsd.org (repo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id B908D28FE; Sun, 19 Jun 2016 07:31:03 +0000 (UTC) (envelope-from adrian@FreeBSD.org) Received: from repo.freebsd.org ([127.0.1.37]) by repo.freebsd.org (8.15.2/8.15.2) with ESMTP id u5J7V36W063668; Sun, 19 Jun 2016 07:31:03 GMT (envelope-from adrian@FreeBSD.org) Received: (from adrian@localhost) by repo.freebsd.org (8.15.2/8.15.2/Submit) id u5J7V22Q063663; Sun, 19 Jun 2016 07:31:02 GMT (envelope-from adrian@FreeBSD.org) Message-Id: <201606190731.u5J7V22Q063663@repo.freebsd.org> X-Authentication-Warning: repo.freebsd.org: adrian set sender to adrian@FreeBSD.org using -f From: Adrian Chadd Date: Sun, 19 Jun 2016 07:31:02 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r302018 - head/sys/net80211 X-SVN-Group: head MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 19 Jun 2016 07:31:04 -0000 Author: adrian Date: Sun Jun 19 07:31:02 2016 New Revision: 302018 URL: https://svnweb.freebsd.org/changeset/base/302018 Log: [net80211] remove node scan lock / generation number + fix few LORs Drop scan generation number and node table scan lock - the only place where ni_scangen is checked is in ieee80211_timeout_stations() (and it is used to prevent duplicate checking of the same node); node scan lock protects only this variable + node table scan generation number. This will fix (at least) next LOR (hostap mode): lock order reversal: 1st 0xc175f84c urtwm0_scan_loc (urtwm0_scan_loc) @ /usr/src/sys/modules/wlan/../../net80211/ieee80211_node.c:2019 2nd 0xc175e018 urtwm0_com_lock (urtwm0_com_lock) @ /usr/src/sys/modules/wlan/../../net80211/ieee80211_node.c:2693 stack backtrace: #0 0xa070d1c5 at witness_debugger+0x75 #1 0xa070d0f6 at witness_checkorder+0xd46 #2 0xa0694cce at __mtx_lock_flags+0x9e #3 0xb03ad9ef at ieee80211_node_leave+0x12f #4 0xb03afd13 at ieee80211_timeout_stations+0x483 #5 0xb03aa1c2 at ieee80211_node_timeout+0x42 #6 0xa06c6fa1 at softclock_call_cc+0x1e1 #7 0xa06c7518 at softclock+0xc8 #8 0xa06789ae at intr_event_execute_handlers+0x8e #9 0xa0678fa0 at ithread_loop+0x90 #10 0xa0675fbe at fork_exit+0x7e #11 0xa08af910 at fork_trampoline+0x8 In addition to the above: * switch to ieee80211_iterate_nodes(); * do not assert that node table lock is held, while calling node_age(); that's not really needed (there are no resources, which can be protected by this lock) + this fixes LOR/deadlock between ieee80211_timeout_stations() and ieee80211_set_tim() (easy to reproduce in HOSTAP mode while sending something to an STA with enabled power management). Tested: * (avos) urtwn0, hostap mode * (adrian) AR9380, STA mode * (adrian) AR9380, AR9331, AR9580, hostap mode Notes: * This changes the net80211 internals, so you have to recompile all of it and the wifi drivers. Submitted by: avos Approved by: re (delphij) Differential Revision: https://reviews.freebsd.org/D6833 Modified: head/sys/net80211/ieee80211_ddb.c head/sys/net80211/ieee80211_freebsd.h head/sys/net80211/ieee80211_node.c head/sys/net80211/ieee80211_node.h head/sys/net80211/ieee80211_superg.c Modified: head/sys/net80211/ieee80211_ddb.c ============================================================================== --- head/sys/net80211/ieee80211_ddb.c Sun Jun 19 03:45:32 2016 (r302017) +++ head/sys/net80211/ieee80211_ddb.c Sun Jun 19 07:31:02 2016 (r302018) @@ -233,9 +233,8 @@ _db_show_sta(const struct ieee80211_node db_printf("\tvap %p wdsvap %p ic %p table %p\n", ni->ni_vap, ni->ni_wdsvap, ni->ni_ic, ni->ni_table); db_printf("\tflags=%b\n", ni->ni_flags, IEEE80211_NODE_BITS); - db_printf("\tscangen %u authmode %u ath_flags 0x%x ath_defkeyix %u\n", - ni->ni_scangen, ni->ni_authmode, - ni->ni_ath_flags, ni->ni_ath_defkeyix); + db_printf("\tauthmode %u ath_flags 0x%x ath_defkeyix %u\n", + ni->ni_authmode, ni->ni_ath_flags, ni->ni_ath_defkeyix); db_printf("\tassocid 0x%x txpower %u vlan %u\n", ni->ni_associd, ni->ni_txpower, ni->ni_vlan); db_printf("\tjointime %d (%lu secs) challenge %p\n", @@ -688,8 +687,6 @@ _db_show_node_table(const char *tag, con db_printf("%s%s@%p:\n", tag, nt->nt_name, nt); db_printf("%s nodelock %p", tag, &nt->nt_nodelock); db_printf(" inact_init %d", nt->nt_inact_init); - db_printf(" scanlock %p", &nt->nt_scanlock); - db_printf(" scangen %u\n", nt->nt_scangen); db_printf("%s keyixmax %d keyixmap %p\n", tag, nt->nt_keyixmax, nt->nt_keyixmap); for (i = 0; i < nt->nt_keyixmax; i++) { Modified: head/sys/net80211/ieee80211_freebsd.h ============================================================================== --- head/sys/net80211/ieee80211_freebsd.h Sun Jun 19 03:45:32 2016 (r302017) +++ head/sys/net80211/ieee80211_freebsd.h Sun Jun 19 07:31:02 2016 (r302018) @@ -107,28 +107,6 @@ typedef struct { mtx_assert(IEEE80211_NODE_LOCK_OBJ(_nt), MA_OWNED) /* - * Node table iteration locking definitions; this protects the - * scan generation # used to iterate over the station table - * while grabbing+releasing the node lock. - */ -typedef struct { - char name[16]; /* e.g. "ath0_scan_lock" */ - struct mtx mtx; -} ieee80211_scan_lock_t; -#define IEEE80211_NODE_ITERATE_LOCK_INIT(_nt, _name) do { \ - ieee80211_scan_lock_t *sl = &(_nt)->nt_scanlock; \ - snprintf(sl->name, sizeof(sl->name), "%s_scan_lock", _name); \ - mtx_init(&sl->mtx, sl->name, NULL, MTX_DEF); \ -} while (0) -#define IEEE80211_NODE_ITERATE_LOCK_OBJ(_nt) (&(_nt)->nt_scanlock.mtx) -#define IEEE80211_NODE_ITERATE_LOCK_DESTROY(_nt) \ - mtx_destroy(IEEE80211_NODE_ITERATE_LOCK_OBJ(_nt)) -#define IEEE80211_NODE_ITERATE_LOCK(_nt) \ - mtx_lock(IEEE80211_NODE_ITERATE_LOCK_OBJ(_nt)) -#define IEEE80211_NODE_ITERATE_UNLOCK(_nt) \ - mtx_unlock(IEEE80211_NODE_ITERATE_LOCK_OBJ(_nt)) - -/* * Power-save queue definitions. */ typedef struct mtx ieee80211_psq_lock_t; Modified: head/sys/net80211/ieee80211_node.c ============================================================================== --- head/sys/net80211/ieee80211_node.c Sun Jun 19 03:45:32 2016 (r302017) +++ head/sys/net80211/ieee80211_node.c Sun Jun 19 07:31:02 2016 (r302018) @@ -1099,8 +1099,6 @@ node_age(struct ieee80211_node *ni) { struct ieee80211vap *vap = ni->ni_vap; - IEEE80211_NODE_LOCK_ASSERT(&vap->iv_ic->ic_sta); - /* * Age frames on the power save queue. */ @@ -1922,10 +1920,8 @@ ieee80211_node_table_init(struct ieee802 nt->nt_ic = ic; IEEE80211_NODE_LOCK_INIT(nt, ic->ic_name); - IEEE80211_NODE_ITERATE_LOCK_INIT(nt, ic->ic_name); TAILQ_INIT(&nt->nt_node); nt->nt_name = name; - nt->nt_scangen = 1; nt->nt_inact_init = inact; nt->nt_keyixmax = keyixmax; if (nt->nt_keyixmax > 0) { @@ -1994,159 +1990,137 @@ ieee80211_node_table_cleanup(struct ieee IEEE80211_FREE(nt->nt_keyixmap, M_80211_NODE); nt->nt_keyixmap = NULL; } - IEEE80211_NODE_ITERATE_LOCK_DESTROY(nt); IEEE80211_NODE_LOCK_DESTROY(nt); } -/* - * Timeout inactive stations and do related housekeeping. - * Note that we cannot hold the node lock while sending a - * frame as this would lead to a LOR. Instead we use a - * generation number to mark nodes that we've scanned and - * drop the lock and restart a scan if we have to time out - * a node. Since we are single-threaded by virtue of - * controlling the inactivity timer we can be sure this will - * process each node only once. - */ static void -ieee80211_timeout_stations(struct ieee80211com *ic) +timeout_stations(void *arg __unused, struct ieee80211_node *ni) { - struct ieee80211_node_table *nt = &ic->ic_sta; - struct ieee80211vap *vap; - struct ieee80211_node *ni; - int gen = 0; + struct ieee80211com *ic = ni->ni_ic; + struct ieee80211vap *vap = ni->ni_vap; - IEEE80211_NODE_ITERATE_LOCK(nt); - gen = ++nt->nt_scangen; -restart: - IEEE80211_NODE_LOCK(nt); - TAILQ_FOREACH(ni, &nt->nt_node, ni_list) { - if (ni->ni_scangen == gen) /* previously handled */ - continue; - ni->ni_scangen = gen; - /* - * Ignore entries for which have yet to receive an - * authentication frame. These are transient and - * will be reclaimed when the last reference to them - * goes away (when frame xmits complete). - */ - vap = ni->ni_vap; - /* - * Only process stations when in RUN state. This - * insures, for example, that we don't timeout an - * inactive station during CAC. Note that CSA state - * is actually handled in ieee80211_node_timeout as - * it applies to more than timeout processing. - */ - if (vap->iv_state != IEEE80211_S_RUN) - continue; - /* XXX can vap be NULL? */ - if ((vap->iv_opmode == IEEE80211_M_HOSTAP || - vap->iv_opmode == IEEE80211_M_STA) && - (ni->ni_flags & IEEE80211_NODE_AREF) == 0) - continue; + /* + * Only process stations when in RUN state. This + * insures, for example, that we don't timeout an + * inactive station during CAC. Note that CSA state + * is actually handled in ieee80211_node_timeout as + * it applies to more than timeout processing. + */ + if (vap->iv_state != IEEE80211_S_RUN) + return; + /* + * Ignore entries for which have yet to receive an + * authentication frame. These are transient and + * will be reclaimed when the last reference to them + * goes away (when frame xmits complete). + */ + if ((vap->iv_opmode == IEEE80211_M_HOSTAP || + vap->iv_opmode == IEEE80211_M_STA) && + (ni->ni_flags & IEEE80211_NODE_AREF) == 0) + return; + /* + * Free fragment if not needed anymore + * (last fragment older than 1s). + * XXX doesn't belong here, move to node_age + */ + if (ni->ni_rxfrag[0] != NULL && + ticks > ni->ni_rxfragstamp + hz) { + m_freem(ni->ni_rxfrag[0]); + ni->ni_rxfrag[0] = NULL; + } + if (ni->ni_inact > 0) { + ni->ni_inact--; + IEEE80211_NOTE(vap, IEEE80211_MSG_INACT, ni, + "%s: inact %u inact_reload %u nrates %u", + __func__, ni->ni_inact, ni->ni_inact_reload, + ni->ni_rates.rs_nrates); + } + /* + * Special case ourself; we may be idle for extended periods + * of time and regardless reclaiming our state is wrong. + * XXX run ic_node_age + */ + /* XXX before inact decrement? */ + if (ni == vap->iv_bss) + return; + if (ni->ni_associd != 0 || + (vap->iv_opmode == IEEE80211_M_IBSS || + vap->iv_opmode == IEEE80211_M_AHDEMO)) { /* - * Free fragment if not needed anymore - * (last fragment older than 1s). - * XXX doesn't belong here, move to node_age + * Age/drain resources held by the station. */ - if (ni->ni_rxfrag[0] != NULL && - ticks > ni->ni_rxfragstamp + hz) { - m_freem(ni->ni_rxfrag[0]); - ni->ni_rxfrag[0] = NULL; - } - if (ni->ni_inact > 0) { - ni->ni_inact--; - IEEE80211_NOTE(vap, IEEE80211_MSG_INACT, ni, - "%s: inact %u inact_reload %u nrates %u", - __func__, ni->ni_inact, ni->ni_inact_reload, - ni->ni_rates.rs_nrates); - } + ic->ic_node_age(ni); /* - * Special case ourself; we may be idle for extended periods - * of time and regardless reclaiming our state is wrong. - * XXX run ic_node_age + * Probe the station before time it out. We + * send a null data frame which may not be + * universally supported by drivers (need it + * for ps-poll support so it should be...). + * + * XXX don't probe the station unless we've + * received a frame from them (and have + * some idea of the rates they are capable + * of); this will get fixed more properly + * soon with better handling of the rate set. */ - if (ni == vap->iv_bss) - continue; - if (ni->ni_associd != 0 || - (vap->iv_opmode == IEEE80211_M_IBSS || - vap->iv_opmode == IEEE80211_M_AHDEMO)) { - /* - * Age/drain resources held by the station. - */ - ic->ic_node_age(ni); - /* - * Probe the station before time it out. We - * send a null data frame which may not be - * universally supported by drivers (need it - * for ps-poll support so it should be...). - * - * XXX don't probe the station unless we've - * received a frame from them (and have - * some idea of the rates they are capable - * of); this will get fixed more properly - * soon with better handling of the rate set. - */ - if ((vap->iv_flags_ext & IEEE80211_FEXT_INACT) && - (0 < ni->ni_inact && - ni->ni_inact <= vap->iv_inact_probe) && - ni->ni_rates.rs_nrates != 0) { - IEEE80211_NOTE(vap, - IEEE80211_MSG_INACT | IEEE80211_MSG_NODE, - ni, "%s", - "probe station due to inactivity"); - /* - * Grab a reference before unlocking the table - * so the node cannot be reclaimed before we - * send the frame. ieee80211_send_nulldata - * understands we've done this and reclaims the - * ref for us as needed. - */ - ieee80211_ref_node(ni); - IEEE80211_NODE_UNLOCK(nt); - ieee80211_send_nulldata(ni); - /* XXX stat? */ - goto restart; - } - } if ((vap->iv_flags_ext & IEEE80211_FEXT_INACT) && - ni->ni_inact <= 0) { + (0 < ni->ni_inact && + ni->ni_inact <= vap->iv_inact_probe) && + ni->ni_rates.rs_nrates != 0) { IEEE80211_NOTE(vap, - IEEE80211_MSG_INACT | IEEE80211_MSG_NODE, ni, - "station timed out due to inactivity " - "(refcnt %u)", ieee80211_node_refcnt(ni)); + IEEE80211_MSG_INACT | IEEE80211_MSG_NODE, + ni, "%s", + "probe station due to inactivity"); /* - * Send a deauthenticate frame and drop the station. - * This is somewhat complicated due to reference counts - * and locking. At this point a station will typically - * have a reference count of 1. ieee80211_node_leave - * will do a "free" of the node which will drop the - * reference count. But in the meantime a reference - * wil be held by the deauth frame. The actual reclaim - * of the node will happen either after the tx is - * completed or by ieee80211_node_leave. - * - * Separately we must drop the node lock before sending - * in case the driver takes a lock, as this can result - * in a LOR between the node lock and the driver lock. + * Grab a reference so the node cannot + * be reclaimed before we send the frame. + * ieee80211_send_nulldata understands + * we've done this and reclaims the + * ref for us as needed. */ + /* XXX fix this (not required anymore). */ ieee80211_ref_node(ni); - IEEE80211_NODE_UNLOCK(nt); - if (ni->ni_associd != 0) { - IEEE80211_SEND_MGMT(ni, - IEEE80211_FC0_SUBTYPE_DEAUTH, - IEEE80211_REASON_AUTH_EXPIRE); - } - ieee80211_node_leave(ni); - ieee80211_free_node(ni); - vap->iv_stats.is_node_timeout++; - goto restart; + /* XXX useless */ + ieee80211_send_nulldata(ni); + /* XXX stat? */ + return; } } - IEEE80211_NODE_UNLOCK(nt); + if ((vap->iv_flags_ext & IEEE80211_FEXT_INACT) && + ni->ni_inact <= 0) { + IEEE80211_NOTE(vap, + IEEE80211_MSG_INACT | IEEE80211_MSG_NODE, ni, + "station timed out due to inactivity " + "(refcnt %u)", ieee80211_node_refcnt(ni)); + /* + * Send a deauthenticate frame and drop the station. + * This is somewhat complicated due to reference counts + * and locking. At this point a station will typically + * have a reference count of 2. ieee80211_node_leave + * will do a "free" of the node which will drop the + * reference count. But in the meantime a reference + * wil be held by the deauth frame. The actual reclaim + * of the node will happen either after the tx is + * completed or by ieee80211_node_leave. + */ + if (ni->ni_associd != 0) { + IEEE80211_SEND_MGMT(ni, + IEEE80211_FC0_SUBTYPE_DEAUTH, + IEEE80211_REASON_AUTH_EXPIRE); + } + ieee80211_node_leave(ni); + vap->iv_stats.is_node_timeout++; + } +} - IEEE80211_NODE_ITERATE_UNLOCK(nt); +/* + * Timeout inactive stations and do related housekeeping. + */ +static void +ieee80211_timeout_stations(struct ieee80211com *ic) +{ + struct ieee80211_node_table *nt = &ic->ic_sta; + + ieee80211_iterate_nodes(nt, timeout_stations, NULL); } /* @@ -2247,23 +2221,12 @@ int ieee80211_iterate_nt(struct ieee80211_node_table *nt, struct ieee80211_node **ni_arr, uint16_t max_aid) { - u_int gen; int i, j, ret; struct ieee80211_node *ni; - IEEE80211_NODE_ITERATE_LOCK(nt); IEEE80211_NODE_LOCK(nt); - gen = ++nt->nt_scangen; i = ret = 0; - - /* - * We simply assume here that since the node - * scan generation doesn't change (as - * we are holding both the node table and - * node table iteration locks), we can simply - * assign it to the node here. - */ TAILQ_FOREACH(ni, &nt->nt_node, ni_list) { if (i >= max_aid) { ret = E2BIG; @@ -2272,7 +2235,6 @@ ieee80211_iterate_nt(struct ieee80211_no break; } ni_arr[i] = ieee80211_ref_node(ni); - ni_arr[i]->ni_scangen = gen; i++; } @@ -2287,7 +2249,6 @@ ieee80211_iterate_nt(struct ieee80211_no * ieee80211_free_node(). */ IEEE80211_NODE_UNLOCK(nt); - IEEE80211_NODE_ITERATE_UNLOCK(nt); /* * If ret is non-zero, we hit some kind of error. @@ -2362,8 +2323,8 @@ ieee80211_dump_node(struct ieee80211_nod { printf("0x%p: mac %s refcnt %d\n", ni, ether_sprintf(ni->ni_macaddr), ieee80211_node_refcnt(ni)); - printf("\tscangen %u authmode %u flags 0x%x\n", - ni->ni_scangen, ni->ni_authmode, ni->ni_flags); + printf("\tauthmode %u flags 0x%x\n", + ni->ni_authmode, ni->ni_flags); printf("\tassocid 0x%x txpower %u vlan %u\n", ni->ni_associd, ni->ni_txpower, ni->ni_vlan); printf("\ttxseq %u rxseq %u fragno %u rxfragstamp %u\n", Modified: head/sys/net80211/ieee80211_node.h ============================================================================== --- head/sys/net80211/ieee80211_node.h Sun Jun 19 03:45:32 2016 (r302017) +++ head/sys/net80211/ieee80211_node.h Sun Jun 19 07:31:02 2016 (r302018) @@ -115,7 +115,6 @@ struct ieee80211_node { TAILQ_ENTRY(ieee80211_node) ni_list; /* list of all nodes */ LIST_ENTRY(ieee80211_node) ni_hash; /* hash collision list */ u_int ni_refcnt; /* count of held references */ - u_int ni_scangen; /* gen# for timeout scan */ u_int ni_flags; #define IEEE80211_NODE_AUTH 0x000001 /* authorized for data */ #define IEEE80211_NODE_QOS 0x000002 /* QoS enabled */ @@ -360,8 +359,6 @@ struct ieee80211_node_table { struct ieee80211_node **nt_keyixmap; /* key ix -> node map */ int nt_keyixmax; /* keyixmap size */ const char *nt_name; /* table name for debug msgs */ - ieee80211_scan_lock_t nt_scanlock; /* on nt_scangen */ - u_int nt_scangen; /* gen# for iterators */ int nt_inact_init; /* initial node inact setting */ }; Modified: head/sys/net80211/ieee80211_superg.c ============================================================================== --- head/sys/net80211/ieee80211_superg.c Sun Jun 19 03:45:32 2016 (r302017) +++ head/sys/net80211/ieee80211_superg.c Sun Jun 19 07:31:02 2016 (r302018) @@ -912,6 +912,12 @@ ieee80211_ff_node_init(struct ieee80211_ ieee80211_ff_node_cleanup(ni); } +/* + * Note: this comlock acquisition LORs with the node lock: + * + * 1: sta_join1 -> NODE_LOCK -> node_free -> node_cleanup -> ff_node_cleanup -> COM_LOCK + * 2: TBD + */ void ieee80211_ff_node_cleanup(struct ieee80211_node *ni) { From owner-svn-src-head@freebsd.org Sun Jun 19 07:37:51 2016 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 85E15A7A119 for ; Sun, 19 Jun 2016 07:37:51 +0000 (UTC) (envelope-from mailing-machine@vniz.net) Received: from mail-lf0-f52.google.com (mail-lf0-f52.google.com [209.85.215.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 1413E2CF4 for ; Sun, 19 Jun 2016 07:37:50 +0000 (UTC) (envelope-from mailing-machine@vniz.net) Received: by mail-lf0-f52.google.com with SMTP id q132so20532976lfe.3 for ; Sun, 19 Jun 2016 00:37:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=0yZ7SQdGgFDYv/BaM95cN1x2JaYHZpLAaWLNfO4NRUQ=; b=dFAAE1MG1k3Be5o0t+SAIU9D2XEmN3rArnb42rBRCsojd+8pvtaZ9rH290S5CaaAsb Q/cWx5u3Q02GSKEkC2pbF5T7y/raJe7hPDguNWoVAw7+VgeEXgTQipqrs4wtKvDsUgIU syCtzuGvjjTP11iZ70UrRjIhofiL+1BfpKWYQTFPLA/wbbJKNtH3QZWZ+alaPHntN3Dz cI1vPaLgXX7g+fEoBwnEwE05hXRmWzXHEjrUrynOYpB+cEDGaPg2AhpWeJjHoACjRW2c 83oBs6se8u6eyKgwJVcrcihq2JU4y1Aj7lHc7XdjBXjwuUfsKgHRQCWq0tKI3MvxK0c0 cx4Q== X-Gm-Message-State: ALyK8tK5e/HSFIvY9unVLDXdloyRh0K+zvcVM2uG5y/b42KfOgJABOeNR5wxxTZYBErfAg== X-Received: by 10.25.88.146 with SMTP id m140mr90377lfb.217.1466321863185; Sun, 19 Jun 2016 00:37:43 -0700 (PDT) Received: from [192.168.1.2] ([89.169.173.68]) by smtp.gmail.com with ESMTPSA id l79sm3445870lfi.40.2016.06.19.00.37.42 (version=TLSv1/SSLv3 cipher=OTHER); Sun, 19 Jun 2016 00:37:42 -0700 (PDT) Subject: Re: svn commit: r302016 - in head: share/timedef tools/tools/locale/tools To: Hajimu UMEMOTO References: <201606190344.u5J3iWO6079652@repo.freebsd.org> <3387744f-7abd-417c-599f-163e78b4170e@freebsd.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org From: Andrey Chernov Message-ID: Date: Sun, 19 Jun 2016 10:37:41 +0300 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.1.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 19 Jun 2016 07:37:51 -0000 On 19.06.2016 8:31, Hajimu UMEMOTO wrote: > Hi, > >>>>>> On Sun, 19 Jun 2016 07:57:49 +0300 >>>>>> Andrey Chernov said: > > ache> Nonsense doubled formats in sr_*_RS locales and nonsense md_order there too. > > It seems there was the problem before my commit. Only saw a little, > I'm not sure were it comes. I understand, just notice that. From owner-svn-src-head@freebsd.org Sun Jun 19 08:08:10 2016 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id E6F0BA7ACEF; Sun, 19 Jun 2016 08:08:10 +0000 (UTC) (envelope-from etnapierala@gmail.com) Received: from mail-wm0-x232.google.com (mail-wm0-x232.google.com [IPv6:2a00:1450:400c:c09::232]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 78913205F; Sun, 19 Jun 2016 08:08:10 +0000 (UTC) (envelope-from etnapierala@gmail.com) Received: by mail-wm0-x232.google.com with SMTP id 187so1314544wmz.1; Sun, 19 Jun 2016 01:08:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:date:from:to:cc:subject:message-id:mail-followup-to :references:mime-version:content-disposition:in-reply-to:user-agent; bh=eV8cLX63cu50liV5LaGw+PfR1n8tUcPnjb5lEZkY4L8=; b=a8nqQUG8iMEhY7dFF7QURmqEQAMi4gKXaUCSiz6l2IBcWvXlr48QieSeuusStwHlAx tqNI7uJ1y6fXjawSVHRMBY86lB6xjF4UoXhRrqAAQSbSFFF12UxIDkaXOMwttYwi+8yB EVQwnhgOSzbnwzhh/pGPH+bGIQ9RCyA7Te0P2dBtLukcLOXv8BFrDb2sf2JuNUKgTdn6 qjv++2fLZQxLmggnkqqbaFdwyjxzyYYzBzAkhR8/fG+V3RZyor6EU8djY4EvrptCLOLo oLC6Z3IDAh52hhKqPOv3hppZFh39CLAtfEuw0/5MBWmShZ7NOCSdBwTsYjmPLPOuYCvN rCWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :in-reply-to:user-agent; bh=eV8cLX63cu50liV5LaGw+PfR1n8tUcPnjb5lEZkY4L8=; b=CWMhMeR38zl6IMfPUKq31SAceq61lS8gWmmnd5CTH47eocMiph0MDkoDdXFG1+2r+J wQ1dZ8WSb5etEcBxal1HYsjebYrBK1qrSW7u38zzVANssaww1mZPm6qbaa8BUu8+dIOr vjdCxZG4XsWAD5KkqVmR54DNHIQxXdM2EzqPXMIdoTKvoSvJaIIg/X3tN/BRZKOwp2ij KeMOdapVnlr99EnIUSoOkhV9UIJamalM4tRHeWl6T0/Gj5pqUjgBibcWxgaH22JFVEg9 LplSWXKYENfBjEF6s79VYSddCTnN7q+/WIBnHHW1xtJIYTcKH9H9sDjw8RFf8w4AmjRM Jxkg== X-Gm-Message-State: ALyK8tLc+z3Pttes87+ngFsS+7J9ALZQaAYellSdlFlSerDDGxxW4CRroGhLD6sTVBLT8A== X-Received: by 10.194.81.72 with SMTP id y8mr9997771wjx.83.1466323688074; Sun, 19 Jun 2016 01:08:08 -0700 (PDT) Received: from brick (abpy178.neoplus.adsl.tpnet.pl. [83.8.66.178]) by smtp.gmail.com with ESMTPSA id e5sm57365008wjj.10.2016.06.19.01.08.06 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 19 Jun 2016 01:08:07 -0700 (PDT) Sender: =?UTF-8?Q?Edward_Tomasz_Napiera=C5=82a?= Date: Sun, 19 Jun 2016 10:08:03 +0200 From: Edward Tomasz =?utf-8?Q?Napiera=C5=82a?= To: Jan Beich Cc: Alexander Motin , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r299448 - in head/sys/cddl/contrib/opensolaris: common/acl uts/common/fs/zfs uts/common/sys Message-ID: <20160619080803.GA1638@brick> Mail-Followup-To: Jan Beich , Alexander Motin , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org References: <201605111343.u4BDhKhp076695@repo.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.6.1 (2016-04-27) X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 19 Jun 2016 08:08:11 -0000 On 0614T0232, Jan Beich wrote: > Alexander Motin writes: > > > Author: mav > > Date: Wed May 11 13:43:20 2016 > > New Revision: 299448 > > URL: https://svnweb.freebsd.org/changeset/base/299448 > > > > Log: > > MFV r299442: 6762 POSIX write should imply DELETE_CHILD on directories - and > > some additional considerations > > > > Reviewed by: Gordon Ross > > Reviewed by: Yuri Pankov > > Author: Kevin Crowe > > > > openzfs/openzfs@d316fffc9c361532a482208561bbb614dac7f916 > > This commit confuses acl_is_trivial_np(3). Notice '+' in ls(1) and 'D' > in getfacl(1) outputs. It's not just that. Those changes: 1. Confuse acl_is_trivial_np(3), as you say. It's hard to fix in libc, because they make trivial ACLs different for files and directories, and acl_is_trivial_np(3) has no way of telling which is which. 2. They make delete deny permission take precedence over the containing directory write allow permission, which is rather different from what people expect in unix systems, and is against the NFSv4 specification, even though it might be a better fit for Windows. 3. They make umask apply to inherit_only permissions, and 4. I don't fully understand this one yet, but from the ACL regression test suite (which lives in tests/sys/acl/, and I'd appreciate people actually ran this before committing ACL-related changes) it looks like it makes umask not apply to the stuff it should. The #1 could be fixed by making ZFS not setting delete_child on write, basically reverting to the previous behaviour in that aspect. As for the others... I'm not saying each one of those is wrong, but they certainly warrant further discussion, especially #2 and #4. Basically, what I'm trying to say is that we should consider backing this out for 11.0-RELEASE, reverting to the previous semantics, verified by passing the regression tests. From owner-svn-src-head@freebsd.org Sun Jun 19 08:15:39 2016 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id D4AE3A7AE85; Sun, 19 Jun 2016 08:15:39 +0000 (UTC) (envelope-from zeising@freebsd.org) Received: from mail.daemonic.se (cloud.daemonic.se [185.34.0.151]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 8D0D5253F; Sun, 19 Jun 2016 08:15:38 +0000 (UTC) (envelope-from zeising@freebsd.org) Received: from cloud.daemonic.se (localhost [IPv6:::1]) by mail.daemonic.se (Postfix) with ESMTP id 3rXRd370rhz27L1; Sun, 19 Jun 2016 08:15:35 +0000 (UTC) X-Virus-Scanned: amavisd-new at daemonic.se Received: from mail.daemonic.se ([IPv6:::1]) (using TLS with cipher ECDHE-RSA-AES128-GCM-SHA256) by cloud.daemonic.se (mailscanner.daemonic.se [IPv6:::1]) (amavisd-new, port 10587) with ESMTPS id tR8ic_DR6-FE; Sun, 19 Jun 2016 08:15:35 +0000 (UTC) Received: from [IPv6:2001:470:dca9:2::3] (celes.daemonic.se [IPv6:2001:470:dca9:2::3]) by mail.daemonic.se (Postfix) with ESMTPSA id 3rXRd24lX5z27C0; Sun, 19 Jun 2016 08:15:34 +0000 (UTC) Subject: Re: svn commit: r288291 - head/etc To: Allan Jude , Adrian Chadd , Cy Schubert References: <2171b966-35c7-2dad-2c0f-f23061cb677a@freebsd.org> <201606190006.u5J06Qk6009591@slippy.cwsent.com> <9ca0ba1b-d9b3-6028-5645-d8d03e730f5e@freebsd.org> Cc: "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" From: Niclas Zeising Message-ID: <19333e20-7242-220f-8553-07b828d462e0@freebsd.org> Date: Sun, 19 Jun 2016 10:15:25 +0200 User-Agent: Mutt/1.5.21 MIME-Version: 1.0 In-Reply-To: <9ca0ba1b-d9b3-6028-5645-d8d03e730f5e@freebsd.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 19 Jun 2016 08:15:39 -0000 On 2016-06-19 05:45, Allan Jude wrote: > On 2016-06-18 23:32, Adrian Chadd wrote: >> i think that's fine for -11. I'd like to just move limits to /bin for >> 12. (I mean, it's 2016, why are you splitting / and /usr again? But..) >> > > bsdinstall for UFS just uses one big /, and ZFS does something similar > for boot environments. Only people who have partitioned manually, or > upgraded in place from 8.x or earlier, will still have separate / and > /usr. We can't throw those people under the bus, but, it is reasonable > to consider switching things around for 12. > I have several systems with separate /usr, done either manually or upgraded in place since forever, so this is an issue, and I expect there are several others out there in the same situation. Regards! -- Niclas From owner-svn-src-head@freebsd.org Sun Jun 19 08:18:17 2016 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 90D1CA7AF90; Sun, 19 Jun 2016 08:18:17 +0000 (UTC) (envelope-from zeising@freebsd.org) Received: from mail.daemonic.se (mail.daemonic.se [IPv6:2a00:d1e0:1000:c00::25]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 5A75E2842; Sun, 19 Jun 2016 08:18:17 +0000 (UTC) (envelope-from zeising@freebsd.org) Received: from cloud.daemonic.se (localhost [IPv6:::1]) by mail.daemonic.se (Postfix) with ESMTP id 3rXRh66Dqhz27L1; Sun, 19 Jun 2016 08:18:14 +0000 (UTC) X-Virus-Scanned: amavisd-new at daemonic.se Received: from mail.daemonic.se ([127.0.0.1]) (using TLS with cipher ECDHE-RSA-AES128-GCM-SHA256) by cloud.daemonic.se (mailscanner.daemonic.se [127.0.0.1]) (amavisd-new, port 10587) with ESMTPS id eBNDttigPqsU; Sun, 19 Jun 2016 08:18:14 +0000 (UTC) Received: from [IPv6:2001:470:dca9:2::3] (celes.daemonic.se [IPv6:2001:470:dca9:2::3]) by mail.daemonic.se (Postfix) with ESMTPSA id 3rXRh62V03z27C0; Sun, 19 Jun 2016 08:18:14 +0000 (UTC) Subject: Re: svn commit: r288291 - head/etc To: Cy Schubert , Adrian Chadd References: <201606190512.u5J5CYoL045032@slippy.cwsent.com> Cc: "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" From: Niclas Zeising Message-ID: <4e985ab9-0d98-a160-bdad-fa4924ddc5b3@freebsd.org> Date: Sun, 19 Jun 2016 10:18:12 +0200 User-Agent: Mutt/1.5.21 MIME-Version: 1.0 In-Reply-To: <201606190512.u5J5CYoL045032@slippy.cwsent.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 19 Jun 2016 08:18:17 -0000 On 2016-06-19 07:12, Cy Schubert wrote: > In message om> > , Adrian Chadd writes: >> i think that's fine for -11. I'd like to just move limits to /bin for >> 12. (I mean, it's 2016, why are you splitting / and /usr again? But..) >> >> I don't want to see differing system behaviour between limits but it's >> likely unavoidable for 11 and could do with some errata notice so >> people know what to expect. > > There aren't any daemons started prior to critical local filesystems being > mounted. I suppose one day there could be but none at this point in time. > Setting limits before filesystems are mounted is practically a NOP anyway. > (Except it could negatively affect fsck of huge UFS filesystems some day.) > > This is wrong, and how I discovered it. ddb (/etc/rc.d/ddb) starts before disks, and currently refuses to start on my systems with this issue. This means no crash dumps, unless I remember to manually start it later in the boot process, so this is an issue. Regards! Niclas From owner-svn-src-head@freebsd.org Sun Jun 19 14:08:43 2016 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id B3A17A7A284; Sun, 19 Jun 2016 14:08:43 +0000 (UTC) (envelope-from cy.schubert@komquats.com) Received: from smtp-out-so.shaw.ca (smtp-out-so.shaw.ca [64.59.136.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "Client", Issuer "CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 5DF48177B; Sun, 19 Jun 2016 14:08:42 +0000 (UTC) (envelope-from cy.schubert@komquats.com) Received: from spqr.komquats.com ([96.50.22.10]) by shaw.ca with SMTP id EdOrb3cQeBLFmEdOsbCrgq; Sun, 19 Jun 2016 08:08:36 -0600 X-Authority-Analysis: v=2.2 cv=W5d6blek c=1 sm=1 tr=0 a=jvE2nwUzI0ECrNeyr98KWA==:117 a=jvE2nwUzI0ECrNeyr98KWA==:17 a=L9H7d07YOLsA:10 a=9cW_t1CCXrUA:10 a=s5jvgZ67dGcA:10 a=pD_ry4oyNxEA:10 a=6I5d2MoRAAAA:8 a=YxBL1-UpAAAA:8 a=T2o6xq4IccvRw0ohEP4A:9 a=IjZwj45LgO3ly-622nXo:22 a=Ia-lj3WSrqcvXOmTRaiG:22 Received: from slippy.cwsent.com (slippy [10.1.1.91]) by spqr.komquats.com (Postfix) with ESMTPS id 581C413753; Sun, 19 Jun 2016 07:08:33 -0700 (PDT) Received: from slippy (localhost [127.0.0.1]) by slippy.cwsent.com (8.15.2/8.15.2) with ESMTP id u5JE8W5w053656; Sun, 19 Jun 2016 07:08:32 -0700 (PDT) (envelope-from Cy.Schubert@cschubert.com) Message-Id: <201606191408.u5JE8W5w053656@slippy.cwsent.com> X-Mailer: exmh version 2.8.0 04/21/2012 with nmh-1.6 Reply-to: Cy Schubert From: Cy Schubert X-os: FreeBSD X-Sender: cy@cwsent.com X-URL: http://www.cschubert.com/ To: Niclas Zeising cc: Cy Schubert , Adrian Chadd , "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Subject: Re: svn commit: r288291 - head/etc In-Reply-To: Message from Niclas Zeising of "Sun, 19 Jun 2016 10:18:12 +0200." <4e985ab9-0d98-a160-bdad-fa4924ddc5b3@freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Sun, 19 Jun 2016 07:08:32 -0700 X-CMAE-Envelope: MS4wfE8vIl5LajPyEMkBxO/D4UDqn/AFHLKvfemYSVSJnMCSt4Vif5W05056u7CHYmI+rXGD94dnv6EUfeUO/cDIXpphISdg1SZ+D7pdNPLGaTU35e1/1JWz KUfL2r7v1DZsiazoPWQVdomUO9OIaUfpoVp8YQfi07aYB8PumpIeImPLZwr0C20lHfL0hMjubbvXYSKxanZr1SfwCiyBPgQlzJViF89gvBP3wlGIZdQVVyZR z9FswSR/FoVSqZppfvFx/eEQjquiBITzA7JSkSzcE9NxWQd/1DzNx6dTDLZfQuyDRq/khPdqveZjo+u1LJ6Paw== X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 19 Jun 2016 14:08:43 -0000 In message <4e985ab9-0d98-a160-bdad-fa4924ddc5b3@freebsd.org>, Niclas Zeising w rites: > On 2016-06-19 07:12, Cy Schubert wrote: > > In message c > > om> > > , Adrian Chadd writes: > >> i think that's fine for -11. I'd like to just move limits to /bin for > >> 12. (I mean, it's 2016, why are you splitting / and /usr again? But..) > >> > >> I don't want to see differing system behaviour between limits but it's > >> likely unavoidable for 11 and could do with some errata notice so > >> people know what to expect. > > > > There aren't any daemons started prior to critical local filesystems being > > mounted. I suppose one day there could be but none at this point in time. > > Setting limits before filesystems are mounted is practically a NOP anyway. > > (Except it could negatively affect fsck of huge UFS filesystems some day.) > > > > > > This is wrong, and how I discovered it. ddb (/etc/rc.d/ddb) starts > before disks, and currently refuses to start on my systems with this > issue. This means no crash dumps, unless I remember to manually start > it later in the boot process, so this is an issue. ddb isn't a daemon. It's an interface into the kernel that configures DDB properties. It runs and completes. And, yes, it is affected by limits not being found in the path. My point is, since there are no daemons, as per the definition of a daemon (processes that become daemons and run in the background) prior to the filesystems being run, to say that there would be differing systems behavior before and after filesystems are started is presently false (though technically true because one day we might have daemons started before critical filesystems are mounted). I can see Adrian's point but not in the present day. In the future, possibly. Another option might be to move ddb after filesytems are mounted or this should circumvent the problem too: Index: ddb =================================================================== --- ddb (revision 302001) +++ ddb (working copy) @@ -15,6 +15,7 @@ rcvar="ddb_enable" command="/sbin/${name}" start_precmd="ddb_prestart" +start_cmd="ddb_start" stop_cmd=":" ddb_prestart() @@ -25,6 +26,11 @@ fi } +ddb_start() +{ + ${command} ${command_args} +} + load_rc_config $name required_files="${ddb_config}" -- Cheers, Cy Schubert FreeBSD UNIX: Web: http://www.FreeBSD.org The need of the many outweighs the greed of the few. From owner-svn-src-head@freebsd.org Sun Jun 19 14:28:48 2016 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 37CF4A7A648; Sun, 19 Jun 2016 14:28:48 +0000 (UTC) (envelope-from cy.schubert@komquats.com) Received: from smtp-out-no.shaw.ca (smtp-out-no.shaw.ca [64.59.134.13]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "Client", Issuer "CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 9F09F1F43; Sun, 19 Jun 2016 14:28:47 +0000 (UTC) (envelope-from cy.schubert@komquats.com) Received: from spqr.komquats.com ([96.50.22.10]) by shaw.ca with SMTP id EdiIbXkmTwsAcEdiJbCKkZ; Sun, 19 Jun 2016 08:28:40 -0600 X-Authority-Analysis: v=2.2 cv=U7HQNqju c=1 sm=1 tr=0 a=jvE2nwUzI0ECrNeyr98KWA==:117 a=jvE2nwUzI0ECrNeyr98KWA==:17 a=L9H7d07YOLsA:10 a=9cW_t1CCXrUA:10 a=s5jvgZ67dGcA:10 a=pD_ry4oyNxEA:10 a=6I5d2MoRAAAA:8 a=U4EAvKDJAAAA:8 a=YxBL1-UpAAAA:8 a=FxgTLzK3pLkextSvKCcA:9 a=IjZwj45LgO3ly-622nXo:22 a=LH9_I48XOzAQGoZ0y7Dq:22 a=Ia-lj3WSrqcvXOmTRaiG:22 Received: from slippy.cwsent.com (slippy [10.1.1.91]) by spqr.komquats.com (Postfix) with ESMTPS id C3E9413753; Sun, 19 Jun 2016 07:28:37 -0700 (PDT) Received: from slippy (localhost [127.0.0.1]) by slippy.cwsent.com (8.15.2/8.15.2) with ESMTP id u5JESbbs053857; Sun, 19 Jun 2016 07:28:37 -0700 (PDT) (envelope-from Cy.Schubert@cschubert.com) Message-Id: <201606191428.u5JESbbs053857@slippy.cwsent.com> X-Mailer: exmh version 2.8.0 04/21/2012 with nmh-1.6 Reply-to: Cy Schubert From: Cy Schubert X-os: FreeBSD X-Sender: cy@cwsent.com X-URL: http://www.cschubert.com/ To: Jan Beich , Alexander Motin , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r299448 - in head/sys/cddl/contrib/opensolaris: common/acl uts/common/fs/zfs uts/common/sys In-Reply-To: Message from Edward Tomasz =?utf-8?Q?Napiera=C5=82a?= of "Sun, 19 Jun 2016 10:08:03 +0200." <20160619080803.GA1638@brick> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Sun, 19 Jun 2016 07:28:37 -0700 X-CMAE-Envelope: MS4wfHVzaaSYuuHJQfKv8fjCDd2YDUlKQedRFglDS71I8eGOdDx2kADClzqZpOsPpoNdX5PGpj7khpRsxBGOkf3WSSHC0hcrhBc56mk1KMGgVZDAYmflLa8Y VnHSPg52EVfp5hRGpEVxBzMzIDr6PS2qT1mvKFIGGvlluod1sMaZFznNY1rhPM/75tJjqPvvGHNacaYvyW448aivE0XqnY9RqeKP1SHT/FBxlZHlntNixHts +SDLD2XmAisXZM4FQjkTN7Tu0m0njh5QLUCmDVCkI8FxUjA0+eeu6vMzHSRDZ7JxaAsgE3eq81gsNz4R+JwllA== X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 19 Jun 2016 14:28:48 -0000 In message <20160619080803.GA1638@brick>, Edward Tomasz =?utf-8?Q?Napiera=C5=82 a?= writes: > On 0614T0232, Jan Beich wrote: > > Alexander Motin writes: > > > > > Author: mav > > > Date: Wed May 11 13:43:20 2016 > > > New Revision: 299448 > > > URL: https://svnweb.freebsd.org/changeset/base/299448 > > > > > > Log: > > > MFV r299442: 6762 POSIX write should imply DELETE_CHILD on directories > - and > > > some additional considerations > > > > > > Reviewed by: Gordon Ross > > > Reviewed by: Yuri Pankov > > > Author: Kevin Crowe > > > > > > openzfs/openzfs@d316fffc9c361532a482208561bbb614dac7f916 > > > > This commit confuses acl_is_trivial_np(3). Notice '+' in ls(1) and 'D' > > in getfacl(1) outputs. > > It's not just that. > > Those changes: > > 1. Confuse acl_is_trivial_np(3), as you say. It's hard to fix in libc, > because they make trivial ACLs different for files and directories, > and acl_is_trivial_np(3) has no way of telling which is which. > > 2. They make delete deny permission take precedence over the containing > directory write allow permission, which is rather different from what > people expect in unix systems, and is against the NFSv4 specification, > even though it might be a better fit for Windows. This is Windows behavior and inconsistent with the rest of FreeBSD and any UNIX or Linux system. > > 3. They make umask apply to inherit_only permissions, and > > 4. I don't fully understand this one yet, but from the ACL regression > test suite (which lives in tests/sys/acl/, and I'd appreciate people > actually ran this before committing ACL-related changes) it looks > like it makes umask not apply to the stuff it should. > > The #1 could be fixed by making ZFS not setting delete_child on write, > basically reverting to the previous behaviour in that aspect. As for > the others... I'm not saying each one of those is wrong, but they > certainly warrant further discussion, especially #2 and #4. I think #2 is wrong behavior on any UNIX-like or POSIX system. > > Basically, what I'm trying to say is that we should consider backing > this out for 11.0-RELEASE, reverting to the previous semantics, verified > by passing the regression tests. Agreed. What in FreeBSD was this patch supposed to solve in the first place? -- Cheers, Cy Schubert FreeBSD UNIX: Web: http://www.FreeBSD.org The need of the many outweighs the greed of the few. From owner-svn-src-head@freebsd.org Sun Jun 19 14:33:51 2016 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 4C563A7A876; Sun, 19 Jun 2016 14:33:51 +0000 (UTC) (envelope-from mavbsd@gmail.com) Received: from mail-lf0-x232.google.com (mail-lf0-x232.google.com [IPv6:2a00:1450:4010:c07::232]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id BE55724F0; Sun, 19 Jun 2016 14:33:50 +0000 (UTC) (envelope-from mavbsd@gmail.com) Received: by mail-lf0-x232.google.com with SMTP id l188so23580222lfe.2; Sun, 19 Jun 2016 07:33:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:subject:to:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding; bh=PFgkSJ/ao4/s1xg/wsYbkKKmrVMkj8zIQgpBKKs/OSU=; b=QvLYL9qwpmLWTAY4bmgHAsEo2fVXBOEjmjBWekpidnIxyOTD4rSbuHRqwx45nVwA2L lvveK5HyqQWpc8BrTNCV7I2y9bzv6qCUszHBEl7Odecu8h2WTCnNWmyzi+ewUs4gCoX+ V9Tb7q+iye7d8heG8afQrdNFw45ueaBmyaS7kjxAOPDuEuREbO03IKGDZH0JGV06DWhB /pUtTeKgzc226m2QQ4TU9Ypq9KcgkWtmP+5EWx146vWsYgCwsxqFO5iOM+nsrbn2FX9F OGM2Bv7QnMLE+FYYzR4zYc8Iyz2r+fjVYmqB31b3AKeQkwfcEnl45SDvXdleSUwVt5eS a0zw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:subject:to:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=PFgkSJ/ao4/s1xg/wsYbkKKmrVMkj8zIQgpBKKs/OSU=; b=N03Cd8xB9B0014yMbVwGA5BgrG5hxq8qVdJ71zwgg63E7WMDiZUQQw7dNC23E51+s2 9DBS5qMp0CEzN55EIj08E75/+thB2YSN/JVYlJNApeb1UHq0/BkSvmcz2IOoWCEZltF8 t43lGip6GY+XH1TXZ4kZoo+bG4TuHt/5XlPIFlOUzTjIYx6Y2SiYWy2pBRuJ1lcAk/Ml Av2xTAnKVKrpsN1pDrBEc7P4HvOAQb4UjqceFoILvYYc31hXmFHCKY56h8ulgyam8VrS 8nCCsSdkpQRJ50VrLvxEXYH/aFi4NkTeaXETtQ8BHpFmQM9YKSoYPFvc0z87fIa/8mZA OVfA== X-Gm-Message-State: ALyK8tK9FhHExzbIFs2YOsRX7PAORJZfahJNFAaa9vHXdpk+2ivrzQmExi3UJ0TVziz0oQ== X-Received: by 10.46.9.2 with SMTP id 2mr2897272ljj.1.1466346828570; Sun, 19 Jun 2016 07:33:48 -0700 (PDT) Received: from mavbook.mavhome.dp.ua ([134.249.139.101]) by smtp.gmail.com with ESMTPSA id y124sm5960396lfd.0.2016.06.19.07.33.47 (version=TLSv1/SSLv3 cipher=OTHER); Sun, 19 Jun 2016 07:33:47 -0700 (PDT) Sender: Alexander Motin Subject: Re: svn commit: r299448 - in head/sys/cddl/contrib/opensolaris: common/acl uts/common/fs/zfs uts/common/sys To: Cy Schubert , Jan Beich , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org References: <201606191428.u5JESbbs053857@slippy.cwsent.com> From: Alexander Motin Message-ID: <49d3d34d-ba91-ebdf-497f-cbe1614bec53@FreeBSD.org> Date: Sun, 19 Jun 2016 17:33:45 +0300 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:45.0) Gecko/20100101 Thunderbird/45.1.1 MIME-Version: 1.0 In-Reply-To: <201606191428.u5JESbbs053857@slippy.cwsent.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 19 Jun 2016 14:33:51 -0000 On 19.06.16 17:28, Cy Schubert wrote: > In message <20160619080803.GA1638@brick>, Edward Tomasz > =?utf-8?Q?Napiera=C5=82 > a?= writes: >> On 0614T0232, Jan Beich wrote: >>> Alexander Motin writes: >>> >>>> Author: mav >>>> Date: Wed May 11 13:43:20 2016 >>>> New Revision: 299448 >>>> URL: https://svnweb.freebsd.org/changeset/base/299448 >>>> >>>> Log: >>>> MFV r299442: 6762 POSIX write should imply DELETE_CHILD on directories >> - and >>>> some additional considerations >>>> >>>> Reviewed by: Gordon Ross >>>> Reviewed by: Yuri Pankov >>>> Author: Kevin Crowe >>>> >>>> openzfs/openzfs@d316fffc9c361532a482208561bbb614dac7f916 >>> >>> This commit confuses acl_is_trivial_np(3). Notice '+' in ls(1) and 'D' >>> in getfacl(1) outputs. >> >> It's not just that. >> >> Those changes: >> >> 1. Confuse acl_is_trivial_np(3), as you say. It's hard to fix in libc, >> because they make trivial ACLs different for files and directories, >> and acl_is_trivial_np(3) has no way of telling which is which. >> >> 2. They make delete deny permission take precedence over the containing >> directory write allow permission, which is rather different from what >> people expect in unix systems, and is against the NFSv4 specification, >> even though it might be a better fit for Windows. > > This is Windows behavior and inconsistent with the rest of FreeBSD and any > UNIX or Linux system. > >> >> 3. They make umask apply to inherit_only permissions, and >> >> 4. I don't fully understand this one yet, but from the ACL regression >> test suite (which lives in tests/sys/acl/, and I'd appreciate people >> actually ran this before committing ACL-related changes) it looks >> like it makes umask not apply to the stuff it should. >> >> The #1 could be fixed by making ZFS not setting delete_child on write, >> basically reverting to the previous behaviour in that aspect. As for >> the others... I'm not saying each one of those is wrong, but they >> certainly warrant further discussion, especially #2 and #4. > > I think #2 is wrong behavior on any UNIX-like or POSIX system. > >> >> Basically, what I'm trying to say is that we should consider backing >> this out for 11.0-RELEASE, reverting to the previous semantics, verified >> by passing the regression tests. > > Agreed. > > What in FreeBSD was this patch supposed to solve in the first place? Growing divergence from OpenZFS upstream. I am not advocating this patch, but it would be good, if possible, to not revert it completely, but block wrong behavior with some minimal ifdefs to make further ZFS merges easier. Help would be appreciated. ;) -- Alexander Motin From owner-svn-src-head@freebsd.org Sun Jun 19 14:52:38 2016 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 1C67AA7AD47; Sun, 19 Jun 2016 14:52:38 +0000 (UTC) (envelope-from baptiste.daroussin@gmail.com) Received: from mail-wm0-x241.google.com (mail-wm0-x241.google.com [IPv6:2a00:1450:400c:c09::241]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id A1AB62D62; Sun, 19 Jun 2016 14:52:37 +0000 (UTC) (envelope-from baptiste.daroussin@gmail.com) Received: by mail-wm0-x241.google.com with SMTP id c82so5425599wme.3; Sun, 19 Jun 2016 07:52:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=dCzQxX+81megEQQS5IEFg+jJ0xZc5zaaR/UAF5sjsLs=; b=bk+IqefUAHgj9eFWQnU9MrxHaY9TUKkg+nNkXNz0z06Jfootl3QYGVteWBPPssQETb Kct8fQ3vXxZEUNGVUi7arhXWXezyhByjDA7QcBnM7OfqB884QLMclV6WRKLfWEkg4XPq RGXisbr0qWB2hYx2kxzvswhpFu76bTGGa/47Ti/ninYkjUVoE+fP/fEUs8Eh8bXGD2Yf ZjKL4EtDZRwRHch8m2ld6TskedyVPNPi2jix2cRH0QGKI7izDQPr0+orzp3tqPeaO9IS mHmPEo+VWtaLKL8/R6v87ck28QYwdJSvfctdkNjRfkTSrik7/GGtciXX+cxLrYNbRX9i y0bg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=dCzQxX+81megEQQS5IEFg+jJ0xZc5zaaR/UAF5sjsLs=; b=Y96JuEVFIMQP2tEbqT23C07o88Rca1TOqhmQrcCI+MvEL1jws0BMcZbZCmQQmZTst8 3U6kl1UNFOLr4d45ghCF/3YSdsI2GcSlsX+/7b7JkO31RT8HObh/2JfGccjU5EQoR9jk /Q3Z2Aaq1QdlERd9xSEBzV8Coz2g68VrDtB0Q2PgsHGZFdN3XIpTr+N6K7Z2ts4s8xMF pAPOg+N6VxQXS1BwunJFuDSv8oZEy1EV+VH28UdCJBFs+xYugHGpJDGoTSOrIhdq/A+P vju10+5677NAI+PYA8MKJgIWE+82g8E25tkSy/uepkX7uE5voX2YRE7KiPmJcrpaBYTH 7QNA== X-Gm-Message-State: ALyK8tJ3DLMrn2i41EUkcui/uXU6CQWcqPXPqAl5iS78zk7wCRAz0GJ6DTS/3youcYMDUQ== X-Received: by 10.28.129.197 with SMTP id c188mr7555574wmd.46.1466347955995; Sun, 19 Jun 2016 07:52:35 -0700 (PDT) Received: from ivaldir.etoilebsd.net ([2001:41d0:8:db4c::1]) by smtp.gmail.com with ESMTPSA id a84sm8898535wma.0.2016.06.19.07.52.34 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 19 Jun 2016 07:52:35 -0700 (PDT) Sender: Baptiste Daroussin Date: Sun, 19 Jun 2016 16:52:34 +0200 From: Baptiste Daroussin To: Andrey Chernov Cc: Hajimu UMEMOTO , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r302016 - in head: share/timedef tools/tools/locale/tools Message-ID: <20160619145233.kjnfyxjb75fdcucz@ivaldir.etoilebsd.net> References: <201606190344.u5J3iWO6079652@repo.freebsd.org> <3387744f-7abd-417c-599f-163e78b4170e@freebsd.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="uemritr6a2t6vnd4" Content-Disposition: inline In-Reply-To: <3387744f-7abd-417c-599f-163e78b4170e@freebsd.org> User-Agent: Mutt/1.6.1-neo (2016-06-11) X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 19 Jun 2016 14:52:38 -0000 --uemritr6a2t6vnd4 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Jun 19, 2016 at 07:57:49AM +0300, Andrey Chernov wrote: > On 19.06.2016 6:44, Hajimu UMEMOTO wrote: > > Log: > > - Prefer to use %d over %e where the day of the month should be zero > > filled. > > - Since %e means the day of the month as well, regard %e as same as %d > > in md_order. >=20 > Nonsense doubled formats in sr_*_RS locales and nonsense md_order there t= oo. Crap I'll dig into it, thanks for spotting it. Best regards, Bapt --uemritr6a2t6vnd4 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJXZrGxAAoJEGOJi9zxtz5aokYP/RWpDVKmRAkS8UjyUAQQ+/60 RgnqvbXwMd8Hv4lCOJZSkIxY9cyVaKCI+PdwhlTBIzEPxFM3RfZHon2jyg5Mf6/7 KbnmHAlvx/bJ+aBrmBoarSGBpHpwsI7GPGF7ull3utFAshWRiotyA7HvSL95XgQm ch982O4JMZWfIMDlRRLytNPVrUMSmEF8nFwj3ftP5fMU8g6iE/gz2Jo2s3fZD4pk oafyTRbRcmbyiibldCPNxeq1E7DyOAdy8wI62YlzwjovL+t8HYwUaIxgySX1mKIP QnuZwFI6Su2FIbwRZkkIdS46+g/wxKk6PtlmOYlfXfVppaQQsT8MqNF/IqZ3zZzr wzMgjV+Y8X7PotgA+LqOIWsbVFL7tN8AveOrJy/5k85jrKVqrfhTbIzny8CHM0nt QlcccbbrYHjNtMNrBpN5jzcnGiG+kuDMCfHJjBHxAIgNhGsO+6dbaBsshD5I8px1 /JqbZgPyZYMczpKL9qjy8C0/OMixijIA2Yl1HmWiBUNO6URMZvJMVLTGoxwq2dRl 2Z/sQF3NADyj0o35EmSaycsYJLmzutxTuP8hELm6cqghy3evIc2tyiyUxhM1jXrh BfYtyTnNI5KCMkeikrYCT8lTtw0t7tLVDDEZKZL+xj8QHCsT7Tjs+mZBOR/qArUt qJWnlvNef9GzKn7NCU/0 =125R -----END PGP SIGNATURE----- --uemritr6a2t6vnd4-- From owner-svn-src-head@freebsd.org Sun Jun 19 14:59:35 2016 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id CEA45A7AE27; Sun, 19 Jun 2016 14:59:35 +0000 (UTC) (envelope-from zeising@freebsd.org) Received: from mail.daemonic.se (cloud.daemonic.se [185.34.0.151]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 8FEE22F80; Sun, 19 Jun 2016 14:59:35 +0000 (UTC) (envelope-from zeising@freebsd.org) Received: from cloud.daemonic.se (localhost [IPv6:::1]) by mail.daemonic.se (Postfix) with ESMTP id 3rXcb800fzz27L1; Sun, 19 Jun 2016 14:59:32 +0000 (UTC) X-Virus-Scanned: amavisd-new at daemonic.se Received: from mail.daemonic.se ([127.0.0.1]) (using TLS with cipher ECDHE-RSA-AES128-GCM-SHA256) by cloud.daemonic.se (mailscanner.daemonic.se [127.0.0.1]) (amavisd-new, port 10587) with ESMTPS id n7JrC19zxNsu; Sun, 19 Jun 2016 14:59:31 +0000 (UTC) Received: from [IPv6:2001:470:dca9:2::3] (celes.daemonic.se [IPv6:2001:470:dca9:2::3]) by mail.daemonic.se (Postfix) with ESMTPSA id 3rXcb65jpdz27C0; Sun, 19 Jun 2016 14:59:30 +0000 (UTC) Subject: Re: svn commit: r288291 - head/etc To: Cy Schubert References: <201606191408.u5JE8W5w053656@slippy.cwsent.com> Cc: Adrian Chadd , "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" From: Niclas Zeising Message-ID: <658f8bf1-6ded-903f-7469-55bc4b6798fd@freebsd.org> Date: Sun, 19 Jun 2016 16:59:28 +0200 User-Agent: Mutt/1.5.21 MIME-Version: 1.0 In-Reply-To: <201606191408.u5JE8W5w053656@slippy.cwsent.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 19 Jun 2016 14:59:35 -0000 On 2016-06-19 16:08, Cy Schubert wrote: > In message <4e985ab9-0d98-a160-bdad-fa4924ddc5b3@freebsd.org>, Niclas > Zeising writes: >> >> This is wrong, and how I discovered it. ddb (/etc/rc.d/ddb) starts >> before disks, and currently refuses to start on my systems with this >> issue. This means no crash dumps, unless I remember to manually start >> it later in the boot process, so this is an issue. > > ddb isn't a daemon. It's an interface into the kernel that configures DDB > properties. It runs and completes. And, yes, it is affected by limits not > being found in the path. I think I misunderstood what you mean, I thought you meant nothing is affected by this. Apologies for that. > > My point is, since there are no daemons, as per the definition of a daemon > (processes that become daemons and run in the background) prior to the > filesystems being run, to say that there would be differing systems > behavior before and after filesystems are started is presently false > (though technically true because one day we might have daemons started > before critical filesystems are mounted). Agreed. I understand if we are too late in the release cycle for 11 to move limits to /bin, which seems like the best solutions. Are there any other reasons not to move /usr/bin/limits? I wanted to bring this to attention, since it seems noone else has noticed it, or cared enough about it. It is nothing that stops me from using FreeBSD, I will just have to remember to start ddb manually, or run the commands in case of a panic. Regards! -- Niclas From owner-svn-src-head@freebsd.org Sun Jun 19 15:49:23 2016 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 1822BA7996B; Sun, 19 Jun 2016 15:49:23 +0000 (UTC) (envelope-from baptiste.daroussin@gmail.com) Received: from mail-wm0-x243.google.com (mail-wm0-x243.google.com [IPv6:2a00:1450:400c:c09::243]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 9D75A2C6E; Sun, 19 Jun 2016 15:49:22 +0000 (UTC) (envelope-from baptiste.daroussin@gmail.com) Received: by mail-wm0-x243.google.com with SMTP id a66so3465501wme.2; Sun, 19 Jun 2016 08:49:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=V04uj9prdxixxVKGQ7M8d0TRwNWtRaUJb/sSnZj02Dc=; b=k3VchkvlF9GDu6oxny9d8Z2T4rhs5RZo/SuI3OzGssJbJHGSmzu4coK744AAPR72vN FodacZslj5IsISFLnPeBbmHtjdwiI19ps91Q8bdtgglKXFN6AkUQ6MurEw26eP7t1cC2 CSLD/llLv6Dogl4wEz7JLQ17qd2vVcGwFwkJIaPbo747RN/LvgamENKxfkCcO6VX6wZA 14AByAd1dLXZ2zDbqZ0e5C5jFLOb2SMHW+OTsq1guAmjsZ34DXeG2YidXklWa8s0okEJ teThbao3HzWWB8KFFy9urb30Kq9Ed7F02zhnhzDVApYxodLZ/eaLCsVmEDM8yyQpA6DI 3g2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=V04uj9prdxixxVKGQ7M8d0TRwNWtRaUJb/sSnZj02Dc=; b=fkZJkNzAOqm4Wnrwc3d2cRtkEZTkQ0f43Uj6cXxHc6D+V2XmYOxo22FoxdAeSwC+9n NoyvOqjUtJVuMbtLEC1+7wNQ/k6TnJEk12vjaJ6GLlut0ulYvEKsS4Cvz4OGHYnDVwFj gYlb6IKFcUh+yz2Mm1zZxkv8WhYta7Jt8QJp0F1YxstEr+6/Yw4o2uPAk0KCGoqOm5KS hZLHqE0YPXzlb1P75gw4wzLSb+3SMkkyacEbBMes12RnyXRYEXnkEFkixFKy/VzdiJSB QHQmLbBmNSbXUbhVnq3CCnb6bTP3nOVptvTmymZdU9ebNQXFCvA2vjYhphAdYADcys8u BECQ== X-Gm-Message-State: ALyK8tIZB6il5UUbfaunubxPsv7Ofl5pCa9EgAdJijEgKGB/thQADo9V2ksBYr53XJANRA== X-Received: by 10.194.88.106 with SMTP id bf10mr4991134wjb.37.1466351360466; Sun, 19 Jun 2016 08:49:20 -0700 (PDT) Received: from ivaldir.etoilebsd.net ([2001:41d0:8:db4c::1]) by smtp.gmail.com with ESMTPSA id yr4sm47735395wjc.18.2016.06.19.08.49.19 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 19 Jun 2016 08:49:19 -0700 (PDT) Sender: Baptiste Daroussin Date: Sun, 19 Jun 2016 17:49:19 +0200 From: Baptiste Daroussin To: Andrey Chernov Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Hajimu UMEMOTO Subject: Re: svn commit: r302016 - in head: share/timedef tools/tools/locale/tools Message-ID: <20160619154918.etycha7kvj4v7nrp@ivaldir.etoilebsd.net> References: <201606190344.u5J3iWO6079652@repo.freebsd.org> <3387744f-7abd-417c-599f-163e78b4170e@freebsd.org> <20160619145233.kjnfyxjb75fdcucz@ivaldir.etoilebsd.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="pc7s4e6evzu5cliy" Content-Disposition: inline In-Reply-To: <20160619145233.kjnfyxjb75fdcucz@ivaldir.etoilebsd.net> User-Agent: Mutt/1.6.1-neo (2016-06-11) X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 19 Jun 2016 15:49:23 -0000 --pc7s4e6evzu5cliy Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Jun 19, 2016 at 04:52:34PM +0200, Baptiste Daroussin wrote: > On Sun, Jun 19, 2016 at 07:57:49AM +0300, Andrey Chernov wrote: > > On 19.06.2016 6:44, Hajimu UMEMOTO wrote: > > > Log: > > > - Prefer to use %d over %e where the day of the month should be zero > > > filled. > > > - Since %e means the day of the month as well, regard %e as same as= %d > > > in md_order. > >=20 > > Nonsense doubled formats in sr_*_RS locales and nonsense md_order there= too. >=20 > Crap I'll dig into it, thanks for spotting it. >=20 > Best regards, > Bapt Should be fixed by: https://people.freebsd.org/~bapt/locale-triple-components.diff The perl script generating the locales was badly handling locales with 3 components, fixed now. Sorry about that Best regards, Bapt --pc7s4e6evzu5cliy Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJXZr7+AAoJEGOJi9zxtz5aiYcP/0yH1RQV4ivjWBKaIh+G+rZS 2PD/n1P0mMcP/LQ7seQT2P23lJHEbdxCFriYFz8w8DXwQd/RQzX7nKW/5sLI9YTM ddI4ISHC0MM8icQVnDD1xMD7H4UbcI57lAI3KV7DYhnO1yFT3AM9ttQC2RqBFKJN PHpkLU8wx3GKK0qsL6wYa8I6OulYK+/NjKeJtoeqPdVSnMnC7bWR3PNaBh0/7wMJ djUT6Ghaso1xaMjWwDbe9njsnYQj6f67E62LqmuQsY8cPKu2I6a3ovm7DVntzq3D Fj9L9zC7Dx6fQFCE89RfGH9w/Mm2CMa+aFv8GzSu4hz6dclF3qdTLjpv2FCAyHXW Mq6N/VmuBC8PxGCWBSZVV4ijnwn/SX14AtZ8mh3KRuSpZDbxrSFW1FUbNzXKsGs/ MeyuuPqMJN4IAPdL8uuZ7dNwh1tGL+p7Zq/g5HT7nmDrD8e/lcq5XIVevAKvRPt3 pFLgQ3MAP+tpwN6tEHPBO0VyWqVSVohMTokcxYPNFnk67hwqTiCYisyUNty4K4N3 JMBag8P2dRPx7iR5oR/gOD9uV7GSjYPaM3j2peoTaD+hIql1oEDr/HAGQfy6tUaB p85Bzqir+I4YJIL30V4IoN3equDTWbC9cr5YMVITaerYxgqxBG1DOhmTSU4ZPK15 GQbDwAwuLQtj2ky2mZMO =Ftn0 -----END PGP SIGNATURE----- --pc7s4e6evzu5cliy-- From owner-svn-src-head@freebsd.org Sun Jun 19 16:21:26 2016 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 062F1A7A49D; Sun, 19 Jun 2016 16:21:26 +0000 (UTC) (envelope-from allanjude@freebsd.org) Received: from mx1.scaleengine.net (mx1.scaleengine.net [209.51.186.6]) by mx1.freebsd.org (Postfix) with ESMTP id DD7112292; Sun, 19 Jun 2016 16:21:25 +0000 (UTC) (envelope-from allanjude@freebsd.org) Received: from [10.1.1.2] (unknown [10.1.1.2]) (Authenticated sender: allanjude.freebsd@scaleengine.com) by mx1.scaleengine.net (Postfix) with ESMTPSA id D8C65D758; Sun, 19 Jun 2016 16:21:24 +0000 (UTC) Subject: Re: svn commit: r288291 - head/etc To: Cy Schubert , Niclas Zeising References: <201606191408.u5JE8W5w053656@slippy.cwsent.com> Cc: Adrian Chadd , "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" From: Allan Jude Message-ID: Date: Sun, 19 Jun 2016 12:21:24 -0400 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.1.1 MIME-Version: 1.0 In-Reply-To: <201606191408.u5JE8W5w053656@slippy.cwsent.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 19 Jun 2016 16:21:26 -0000 On 2016-06-19 10:08, Cy Schubert wrote: > In message <4e985ab9-0d98-a160-bdad-fa4924ddc5b3@freebsd.org>, Niclas > Zeising w > rites: >> On 2016-06-19 07:12, Cy Schubert wrote: >>> In message > c >>> om> >>> , Adrian Chadd writes: >>>> i think that's fine for -11. I'd like to just move limits to /bin for >>>> 12. (I mean, it's 2016, why are you splitting / and /usr again? But..) >>>> >>>> I don't want to see differing system behaviour between limits but it's >>>> likely unavoidable for 11 and could do with some errata notice so >>>> people know what to expect. >>> >>> There aren't any daemons started prior to critical local filesystems being >>> mounted. I suppose one day there could be but none at this point in time. >>> Setting limits before filesystems are mounted is practically a NOP anyway. >>> (Except it could negatively affect fsck of huge UFS filesystems some day.) >>> >>> >> >> This is wrong, and how I discovered it. ddb (/etc/rc.d/ddb) starts >> before disks, and currently refuses to start on my systems with this >> issue. This means no crash dumps, unless I remember to manually start >> it later in the boot process, so this is an issue. > > ddb isn't a daemon. It's an interface into the kernel that configures DDB > properties. It runs and completes. And, yes, it is affected by limits not > being found in the path. > > My point is, since there are no daemons, as per the definition of a daemon > (processes that become daemons and run in the background) prior to the > filesystems being run, to say that there would be differing systems > behavior before and after filesystems are started is presently false > (though technically true because one day we might have daemons started > before critical filesystems are mounted). > > I can see Adrian's point but not in the present day. In the future, > possibly. > > Another option might be to move ddb after filesytems are mounted or this > should circumvent the problem too: > I think you still want ddb early, because it configures crash dumps, and another daemon or process that starts might cause a crash. -- Allan Jude From owner-svn-src-head@freebsd.org Sun Jun 19 16:25:43 2016 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 91D63A7A662; Sun, 19 Jun 2016 16:25:43 +0000 (UTC) (envelope-from jean-sebastien.pedron@dumbbell.fr) Received: from mail.made4.biz (mail.made4.biz [IPv6:2001:41d0:2:c018::1:3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 52E59271D; Sun, 19 Jun 2016 16:25:42 +0000 (UTC) (envelope-from jean-sebastien.pedron@dumbbell.fr) Received: from 141.7.19.93.rev.sfr.net ([93.19.7.141] helo=magellan.dumbbell.fr) by mail.made4.biz with esmtpsa (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.86_2 (FreeBSD)) (envelope-from ) id 1bEfXY-000HhY-9J; Sun, 19 Jun 2016 18:25:40 +0200 Subject: Re: svn commit: r288291 - head/etc To: Niclas Zeising , Cy Schubert References: <201606191408.u5JE8W5w053656@slippy.cwsent.com> <658f8bf1-6ded-903f-7469-55bc4b6798fd@freebsd.org> Cc: Adrian Chadd , "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" From: =?UTF-8?Q?Jean-S=c3=a9bastien_P=c3=a9dron?= Message-ID: Date: Sun, 19 Jun 2016 18:25:30 +0200 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:45.0) Gecko/20100101 Thunderbird/45.1.0 MIME-Version: 1.0 In-Reply-To: <658f8bf1-6ded-903f-7469-55bc4b6798fd@freebsd.org> Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="awAWXl9rb8G1sPlaXoFQCxafg6Qs2naNv" X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 19 Jun 2016 16:25:43 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --awAWXl9rb8G1sPlaXoFQCxafg6Qs2naNv Content-Type: multipart/mixed; boundary="QOVdWKCaBSo7tKojpUcOJ8KIvU3oRtHac" From: =?UTF-8?Q?Jean-S=c3=a9bastien_P=c3=a9dron?= To: Niclas Zeising , Cy Schubert Cc: Adrian Chadd , "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Message-ID: Subject: Re: svn commit: r288291 - head/etc References: <201606191408.u5JE8W5w053656@slippy.cwsent.com> <658f8bf1-6ded-903f-7469-55bc4b6798fd@freebsd.org> In-Reply-To: <658f8bf1-6ded-903f-7469-55bc4b6798fd@freebsd.org> --QOVdWKCaBSo7tKojpUcOJ8KIvU3oRtHac Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable On 19/06/2016 16:59, Niclas Zeising wrote: > I wanted to bring this to attention, since it seems noone else has > noticed it, or cared enough about it. It is nothing that stops me from= > using FreeBSD, I will just have to remember to start ddb manually, or > run the commands in case of a panic. There is a bug filed to track this issue: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D206291 I have the same problem because the system was installed a long time ago.= --=20 Jean-S=E9bastien P=E9dron --QOVdWKCaBSo7tKojpUcOJ8KIvU3oRtHac-- --awAWXl9rb8G1sPlaXoFQCxafg6Qs2naNv Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQIcBAEBCgAGBQJXZseDAAoJEDnpl2Gl/ZTM9QsQAJU8xYwd0qyN9hdCCIOuWfT4 fr+hCgp7+a0zrakiVQ8oGDxk7Hekuw7xmwWLDJeUmBLDpY24lsQWQWIr12h4cnaX 9medWYB+9wN7bbPWrAgRihdBJ2dl4cRqIuLi1HWzECPs3FBOQ+T2IXsQUNAfpT4r BdxrrGgy7qIey1PoYGGRm19ntmZE2gAAwBtQVNfVXuCr++T+w2oGt9IuZ2bOKz8T OHyBWoLWiLpKEt0gVfC1uV26gcWmyvQvY6JOzP1pbqgENoIytGEho8al2NV93fmP zcSblH0EQoDihoG1qy3KUETcyes4uZNgLi1xlj9rQk8OUg3+1tFNOE5zh2DZuYgg v63mTGT6lYmVXDI/pwYPbaCCpMTaSae6NlWBIroWiyEKFYLES3WkJ5HZcbUh/mxn 9GdqN5mvbOcaHpJIFfWLsmi6NonsvopfTk1d2ooyNoI79OWRjWrJKYU57dl4LwGL u9UC0IG9zjLnnXK8LnNk4/kSAXG4tecbxpASA6nuP9oBMZzSi3Nns4ofH/IDYLPW 9hexRyqIaEu2HTinEiL9JsTkOkFu3/0WqpfcIfHBxxLqzoO8bVMRPH43QUfvJOtj tZQsfHg2HRaJnj8+/stHteY3b/oFZHKv0qmiMogmvxjJwg6zH4buwG6GhEBeByt6 e/rwyUP7V4tA6rDxihyB =Zy73 -----END PGP SIGNATURE----- --awAWXl9rb8G1sPlaXoFQCxafg6Qs2naNv-- From owner-svn-src-head@freebsd.org Sun Jun 19 16:47:37 2016 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 55645A7AB49 for ; Sun, 19 Jun 2016 16:47:37 +0000 (UTC) (envelope-from mailing-machine@vniz.net) Received: from mail-lf0-f41.google.com (mail-lf0-f41.google.com [209.85.215.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id EBF171319 for ; Sun, 19 Jun 2016 16:47:36 +0000 (UTC) (envelope-from mailing-machine@vniz.net) Received: by mail-lf0-f41.google.com with SMTP id q132so24604507lfe.3 for ; Sun, 19 Jun 2016 09:47:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to; bh=3LpkDs9hCcTRoLtT6x9WnGgiO+9oNTcNVTmueb/D4xo=; b=BPnJVfG/q5Q+k/MY/pKqJ65kP3RWMVWjF8B4QPnSYmAhJutELVGZeAqSr7TEK3FOFg QiA2hDyCCqEg1oymjXw9gN7B8Lg4I78zWujMs1P6tHadX96MEVQHn4otkokurEIAEYzI gSHrkxXfBS7GAlJQW40uVrbsXMqXlPFjgJpmc7IVNj5HDRHrN9GyYrX3Mz4KmO6IfRr0 j38tXdLyPF9JwYTLO9REOOQUUD9cCI9sDlF4A/ZULDVvi6ozGcHs0HVKTIcCTFKrEYVU CM/f4GSsrHHympBd9o6Hw0WNZJU2z8dfRn8ROfNW+xkeVQqDknG5vbN2TeuLgq4jZnB8 Jbzg== X-Gm-Message-State: ALyK8tLzenSCN6W34zMXgRP2PaqPJDHwLwjep9JHIZ0FLtjBqA0l1aN29JShsk4QutQIEg== X-Received: by 10.46.32.28 with SMTP id g28mr2979736ljg.34.1466354849289; Sun, 19 Jun 2016 09:47:29 -0700 (PDT) Received: from [192.168.1.2] ([89.169.173.68]) by smtp.gmail.com with ESMTPSA id 25sm3685393lft.24.2016.06.19.09.47.28 (version=TLSv1/SSLv3 cipher=OTHER); Sun, 19 Jun 2016 09:47:28 -0700 (PDT) Subject: Re: svn commit: r302016 - in head: share/timedef tools/tools/locale/tools To: Baptiste Daroussin References: <201606190344.u5J3iWO6079652@repo.freebsd.org> <3387744f-7abd-417c-599f-163e78b4170e@freebsd.org> <20160619145233.kjnfyxjb75fdcucz@ivaldir.etoilebsd.net> <20160619154918.etycha7kvj4v7nrp@ivaldir.etoilebsd.net> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Hajimu UMEMOTO From: Andrey Chernov Message-ID: Date: Sun, 19 Jun 2016 19:47:27 +0300 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.1.1 MIME-Version: 1.0 In-Reply-To: <20160619154918.etycha7kvj4v7nrp@ivaldir.etoilebsd.net> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="owAtx50hIioIj6EgeutMGddJcBkh7GGR6" X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 19 Jun 2016 16:47:37 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --owAtx50hIioIj6EgeutMGddJcBkh7GGR6 Content-Type: multipart/mixed; boundary="o9vC4UbdPgfPscj79O59kWQ7hnehiBrT4" From: Andrey Chernov To: Baptiste Daroussin Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Hajimu UMEMOTO Message-ID: Subject: Re: svn commit: r302016 - in head: share/timedef tools/tools/locale/tools References: <201606190344.u5J3iWO6079652@repo.freebsd.org> <3387744f-7abd-417c-599f-163e78b4170e@freebsd.org> <20160619145233.kjnfyxjb75fdcucz@ivaldir.etoilebsd.net> <20160619154918.etycha7kvj4v7nrp@ivaldir.etoilebsd.net> In-Reply-To: <20160619154918.etycha7kvj4v7nrp@ivaldir.etoilebsd.net> --o9vC4UbdPgfPscj79O59kWQ7hnehiBrT4 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 19.06.2016 18:49, Baptiste Daroussin wrote: > On Sun, Jun 19, 2016 at 04:52:34PM +0200, Baptiste Daroussin wrote: >> On Sun, Jun 19, 2016 at 07:57:49AM +0300, Andrey Chernov wrote: >>> On 19.06.2016 6:44, Hajimu UMEMOTO wrote: >>>> Log: >>>> - Prefer to use %d over %e where the day of the month should be ze= ro >>>> filled. >>>> - Since %e means the day of the month as well, regard %e as same a= s %d >>>> in md_order. >>> >>> Nonsense doubled formats in sr_*_RS locales and nonsense md_order the= re too. >> >> Crap I'll dig into it, thanks for spotting it. >> >> Best regards, >> Bapt >=20 > Should be fixed by: > https://people.freebsd.org/~bapt/locale-triple-components.diff >=20 > The perl script generating the locales was badly handling locales with = 3 > components, fixed now. >=20 > Sorry about that >=20 > Best regards, > Bapt >=20 sr locales are badly named before anything else, proper format is language[_COUNTRY][.encoding][@variant] I.e. sr_RS.UTF-8@Latn sr_RS.ISO8859-2@Latn sr_RS.ISO8859-t@Cyrl I don't know, if out utilities (f.e. locale(1)) can handle @variant suffi= x. --o9vC4UbdPgfPscj79O59kWQ7hnehiBrT4-- --owAtx50hIioIj6EgeutMGddJcBkh7GGR6 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQEcBAEBCAAGBQJXZsyfAAoJEKUckv0MjfbKLFgH/RaDpaqA3TRHUH11YqkclUAj cnsfaN5UET0TQMfP2E0wnx/ZjxDic2FMLDcynA2N6l+2AuwRq1Y1KER7jOBpQPr7 q5HqlpCKXj0Utqst02xEUGox6PWx/HI3PGle1l1SwcFNmJLCnpiNIosdPBYw6pMd pKXA/jQaWnr1tA+uzkkYTTBe/jEKPrMDzOK2SumpY7Uxup1oQZBTqSubhua4pmLF eAJxUUiDoDOmenjnal67PZKyWWShT+6nclNcSfDDQsH9PjJj/x2r2Vn1TqsV2l82 NRi2hgWn3F0vaWRriMiHEcEn1ilHEhgeGwjG4taltcAdMxxBWbIkBa3JEcuYY2A= =/+CM -----END PGP SIGNATURE----- --owAtx50hIioIj6EgeutMGddJcBkh7GGR6-- From owner-svn-src-head@freebsd.org Sun Jun 19 16:52:22 2016 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 01D81A7AD21 for ; Sun, 19 Jun 2016 16:52:22 +0000 (UTC) (envelope-from mailing-machine@vniz.net) Received: from mail-lf0-f47.google.com (mail-lf0-f47.google.com [209.85.215.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 7C4A5181C for ; Sun, 19 Jun 2016 16:52:20 +0000 (UTC) (envelope-from mailing-machine@vniz.net) Received: by mail-lf0-f47.google.com with SMTP id f6so24726836lfg.0 for ; Sun, 19 Jun 2016 09:52:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to; bh=zEk+RXEjTCJlmJ+7g5VOH+GUhANwz+t9xPh7PyJMXsM=; b=cu8G0AHu1pWlvvBomXrRXoQYga/cRQ3cSGNv7+DBo+DACD3HBEVZ22UwePg4VB/u2+ 6ASl9dYKgtX4I/+XCweZgxaR8mjoRxYPVnvoV3sPKpTsyW7mwwTu0pRGaCo14BZ5c4ZE xjhSFWYIWdohXZMITztZBkCgrya+l3TxtmOvRWwuyKI7VKTAfe+SLRp3vTmgXVbozM04 obdJTTu9w3SPgwLJwgYbudW8UPkhpmLK8yp1vkkeehJeobBOHXlUf/tnpz922TkHgJn6 GiPOUxqcW5ZUS+uz/S8jVu8bl27vVVOJwSPpeMEIlt2W0OKnOYS+MQz8nRh2iY7T3bwY uwkg== X-Gm-Message-State: ALyK8tLBz1iQSIanWBugTq/gLgeECuA+eQlxDhi9Ud1JrDCNi0hFVDqaGyY7D6bIOt+yPg== X-Received: by 10.25.22.217 with SMTP id 86mr3232037lfw.100.1466355138771; Sun, 19 Jun 2016 09:52:18 -0700 (PDT) Received: from [192.168.1.2] ([89.169.173.68]) by smtp.gmail.com with ESMTPSA id z10sm260644lbr.12.2016.06.19.09.52.17 (version=TLSv1/SSLv3 cipher=OTHER); Sun, 19 Jun 2016 09:52:18 -0700 (PDT) Subject: Re: svn commit: r302016 - in head: share/timedef tools/tools/locale/tools To: Baptiste Daroussin References: <201606190344.u5J3iWO6079652@repo.freebsd.org> <3387744f-7abd-417c-599f-163e78b4170e@freebsd.org> <20160619145233.kjnfyxjb75fdcucz@ivaldir.etoilebsd.net> <20160619154918.etycha7kvj4v7nrp@ivaldir.etoilebsd.net> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Hajimu UMEMOTO From: Andrey Chernov Message-ID: Date: Sun, 19 Jun 2016 19:52:17 +0300 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.1.1 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="eW515PGpxbVjNUPRXLlTLhRjABBiMR5if" X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 19 Jun 2016 16:52:22 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --eW515PGpxbVjNUPRXLlTLhRjABBiMR5if Content-Type: multipart/mixed; boundary="tAbqLOkI4CX1nd1Nx5sK2VmDhm5hseT78" From: Andrey Chernov To: Baptiste Daroussin Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Hajimu UMEMOTO Message-ID: Subject: Re: svn commit: r302016 - in head: share/timedef tools/tools/locale/tools References: <201606190344.u5J3iWO6079652@repo.freebsd.org> <3387744f-7abd-417c-599f-163e78b4170e@freebsd.org> <20160619145233.kjnfyxjb75fdcucz@ivaldir.etoilebsd.net> <20160619154918.etycha7kvj4v7nrp@ivaldir.etoilebsd.net> In-Reply-To: --tAbqLOkI4CX1nd1Nx5sK2VmDhm5hseT78 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 19.06.2016 19:47, Andrey Chernov wrote: > On 19.06.2016 18:49, Baptiste Daroussin wrote: >> On Sun, Jun 19, 2016 at 04:52:34PM +0200, Baptiste Daroussin wrote: >>> On Sun, Jun 19, 2016 at 07:57:49AM +0300, Andrey Chernov wrote: >>>> On 19.06.2016 6:44, Hajimu UMEMOTO wrote: >>>>> Log: >>>>> - Prefer to use %d over %e where the day of the month should be z= ero >>>>> filled. >>>>> - Since %e means the day of the month as well, regard %e as same = as %d >>>>> in md_order. >>>> >>>> Nonsense doubled formats in sr_*_RS locales and nonsense md_order th= ere too. >>> >>> Crap I'll dig into it, thanks for spotting it. >>> >>> Best regards, >>> Bapt >> >> Should be fixed by: >> https://people.freebsd.org/~bapt/locale-triple-components.diff >> >> The perl script generating the locales was badly handling locales with= 3 >> components, fixed now. >> >> Sorry about that >> >> Best regards, >> Bapt >> >=20 > sr locales are badly named before anything else, proper format is > language[_COUNTRY][.encoding][@variant] > I.e. > sr_RS.UTF-8@Latn > sr_RS.ISO8859-2@Latn > sr_RS.ISO8859-t@Cyrl >=20 > I don't know, if out utilities (f.e. locale(1)) can handle @variant suf= fix. >=20 >=20 =3Dsr_RS.ISO8859-5@Cyrl =3Dour, and not utilities only but libc too --tAbqLOkI4CX1nd1Nx5sK2VmDhm5hseT78-- --eW515PGpxbVjNUPRXLlTLhRjABBiMR5if Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQEcBAEBCAAGBQJXZs3BAAoJEKUckv0MjfbKgC4H/0OogkzEPP42VCqvpVK+573t CNqK6VqlDJHSKB1YBrW2nTC5GjLlvLUFpcp32UM7INMxLTTS80XvEsN1vOnjsuWX c32UYSChng7W4H3qolADiK0m4Rm9pjmBeIhtM+igDq3XzRTlUv8MyB27tdJD1nyt t8tMvDPgWBFNz22TR/Bij9LJvFhQFxL5hMMlatjd1BBvT61EbKrnoyLA+7WJoE/L 4pd/0LY43OImT7aGek1fLn4IF2bq3mZIkk3aZuUkIZjE3tuT4lkaTkhtK/yOW70h wCakjNevg1gg2ESrsUYXLsP+w1aLnwI5+5+C/pn7wsCoIcG8DAccyDpwoRNoHLg= =QxXX -----END PGP SIGNATURE----- --eW515PGpxbVjNUPRXLlTLhRjABBiMR5if-- From owner-svn-src-head@freebsd.org Sun Jun 19 17:05:40 2016 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 34A3BA7A2C3 for ; Sun, 19 Jun 2016 17:05:40 +0000 (UTC) (envelope-from mailing-machine@vniz.net) Received: from mail-lf0-f46.google.com (mail-lf0-f46.google.com [209.85.215.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id B258D2036 for ; Sun, 19 Jun 2016 17:05:39 +0000 (UTC) (envelope-from mailing-machine@vniz.net) Received: by mail-lf0-f46.google.com with SMTP id h129so23959969lfh.1 for ; Sun, 19 Jun 2016 10:05:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to; bh=X/KhJLcTFWSqZ+VwnDufhH4HJ8HvyNhrSMEUyIyI9P0=; b=WmigcoB9jun2BcOgr4+92cKfaQvF7nY1yIev4k2AsRjA4WSxRbdbTEqoiGNvegLd1v JHJDy8ej8JarnkRW+4ZFqqKK2K/9RwJ6/snrLmcogm59ajHuRjuDjg1k3xp6q2sAC6Xk P9l5miiKshVtZLxC++roVDtTSKwrZoJUP+488j9keBDFCC7jNatwXvklhi0uXl0k7yTb urtH6c6j34tnO1wJ9U4MQXgJrQ2heRb0oqTH+GEbXTdA4u/0IPhjN9apWxH2wXSvUtVX WedVecc8BMdwP9/6+ecSZe89bUXCiXAv/8fguoQrMsrjVKlOnrdqyRVoanY1vJlnV6WB LVIA== X-Gm-Message-State: ALyK8tJ51CAK+S1wUBMBY5kIU2ndarwKc0p+GnZAMrJCzPzLKxMRPeArU84zDTQ1tA8PAQ== X-Received: by 10.25.18.234 with SMTP id 103mr3583249lfs.118.1466355931852; Sun, 19 Jun 2016 10:05:31 -0700 (PDT) Received: from [192.168.1.2] ([89.169.173.68]) by smtp.gmail.com with ESMTPSA id f17sm6035591lfg.35.2016.06.19.10.05.30 (version=TLSv1/SSLv3 cipher=OTHER); Sun, 19 Jun 2016 10:05:31 -0700 (PDT) Subject: Re: svn commit: r302016 - in head: share/timedef tools/tools/locale/tools To: Baptiste Daroussin References: <201606190344.u5J3iWO6079652@repo.freebsd.org> <3387744f-7abd-417c-599f-163e78b4170e@freebsd.org> <20160619145233.kjnfyxjb75fdcucz@ivaldir.etoilebsd.net> <20160619154918.etycha7kvj4v7nrp@ivaldir.etoilebsd.net> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Hajimu UMEMOTO From: Andrey Chernov Message-ID: <77076d87-41ad-0cce-c703-ed9cef1bdb8b@freebsd.org> Date: Sun, 19 Jun 2016 20:05:30 +0300 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.1.1 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="2qEDkAXlhRDV2rTRvnDjE0Mu4qdMjdnvX" X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 19 Jun 2016 17:05:40 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --2qEDkAXlhRDV2rTRvnDjE0Mu4qdMjdnvX Content-Type: multipart/mixed; boundary="Qlb6DpaT3WRgTOvCfutkB45THtThh99ir" From: Andrey Chernov To: Baptiste Daroussin Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Hajimu UMEMOTO Message-ID: <77076d87-41ad-0cce-c703-ed9cef1bdb8b@freebsd.org> Subject: Re: svn commit: r302016 - in head: share/timedef tools/tools/locale/tools References: <201606190344.u5J3iWO6079652@repo.freebsd.org> <3387744f-7abd-417c-599f-163e78b4170e@freebsd.org> <20160619145233.kjnfyxjb75fdcucz@ivaldir.etoilebsd.net> <20160619154918.etycha7kvj4v7nrp@ivaldir.etoilebsd.net> In-Reply-To: --Qlb6DpaT3WRgTOvCfutkB45THtThh99ir Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 19.06.2016 19:52, Andrey Chernov wrote: > On 19.06.2016 19:47, Andrey Chernov wrote: >> On 19.06.2016 18:49, Baptiste Daroussin wrote: >>> On Sun, Jun 19, 2016 at 04:52:34PM +0200, Baptiste Daroussin wrote: >>>> On Sun, Jun 19, 2016 at 07:57:49AM +0300, Andrey Chernov wrote: >>>>> On 19.06.2016 6:44, Hajimu UMEMOTO wrote: >>>>>> Log: >>>>>> - Prefer to use %d over %e where the day of the month should be = zero >>>>>> filled. >>>>>> - Since %e means the day of the month as well, regard %e as same= as %d >>>>>> in md_order. >>>>> >>>>> Nonsense doubled formats in sr_*_RS locales and nonsense md_order t= here too. >>>> >>>> Crap I'll dig into it, thanks for spotting it. >>>> >>>> Best regards, >>>> Bapt >>> >>> Should be fixed by: >>> https://people.freebsd.org/~bapt/locale-triple-components.diff >>> >>> The perl script generating the locales was badly handling locales wit= h 3 >>> components, fixed now. >>> >>> Sorry about that >>> >>> Best regards, >>> Bapt >>> >> >> sr locales are badly named before anything else, proper format is >> language[_COUNTRY][.encoding][@variant] >> I.e. >> sr_RS.UTF-8@Latn >> sr_RS.ISO8859-2@Latn >> sr_RS.ISO8859-t@Cyrl >> >> I don't know, if out utilities (f.e. locale(1)) can handle @variant su= ffix. >> >> > =3Dsr_RS.ISO8859-5@Cyrl > =3Dour, and not utilities only but libc too Since right now we have only single @variant per each encoding, and no @variant for other locales, we can just drop it and use right names like:= sr_RS.UTF-8 sr_RS.ISO8859-2 sr_RS.ISO8859-5 --Qlb6DpaT3WRgTOvCfutkB45THtThh99ir-- --2qEDkAXlhRDV2rTRvnDjE0Mu4qdMjdnvX Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQEcBAEBCAAGBQJXZtDaAAoJEKUckv0MjfbKobsIAMuAx1/nEwCJkLFsA/2BbLbQ TQei43xsVX5jIgYErVaH3B/nk0jTJJMC8KQdJh6yqchz5uj5xAGDsQ5YsjKepcCy 38p9tzi28TXPnQhe4bT0VFEJ8E9PacoW7hQYkvetQjUCT5ec/6lQ3wj50tXSRuOn uNIVqO0YmkLHK3QCzEUSbToNl3O78yAJ7O381Pb/eab8gwVG0MbjmScGE11DIhkQ ievblj+gw9hC3CoWNq2rnhVtt4RFqty8J4fv8JqseS3IpAvclT60MuLwYDFLGy2m jc7UQD9kMQIF6Mx968VRb8LP6jUm/MGRTDfJkBArJFA0YLtc16PAviPtxVd+/Qs= =Ndqx -----END PGP SIGNATURE----- --2qEDkAXlhRDV2rTRvnDjE0Mu4qdMjdnvX-- From owner-svn-src-head@freebsd.org Sun Jun 19 17:05:42 2016 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 39220A7A2C9; Sun, 19 Jun 2016 17:05:42 +0000 (UTC) (envelope-from baptiste.daroussin@gmail.com) Received: from mail-wm0-x243.google.com (mail-wm0-x243.google.com [IPv6:2a00:1450:400c:c09::243]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id A1DFD2095; Sun, 19 Jun 2016 17:05:41 +0000 (UTC) (envelope-from baptiste.daroussin@gmail.com) Received: by mail-wm0-x243.google.com with SMTP id a66so3748584wme.2; Sun, 19 Jun 2016 10:05:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=cQwnudjChlRHrrpHku6vh1UeGH0HtxVFTRC+lPgpVvU=; b=JjiqNOVnAd1QvwJUNt8e98B2rMOuPpzX9nv1ofvZie8j442+ECZ/7oqtHnzX6uwkhI HSOwgpusQNsuXrOM6a1hqzWTuw7x+Sgs8C+2l0mgRsC2QSESX2bkbu2Old/dVWEPW0jN QrXoWKzO7ur/hJf7B3T2VKGHTWcVJ+CPopHDaCBtNnt/DpuxJ6w5/1DoTmoGiSJ98cHA dJ6UnxeeZdvfTB6Wqp5kwwHy9wLHSXuipXVdrxSFBcbTTjMfdHxUzr/17bJaXYIPP7RU hs0r4XiTk0OShuBi2rH/68Yq5BTGj6pxvhtUzFTo2l3Ug0pxqFqikOw0gfYjr9WL+Rx3 gYvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=cQwnudjChlRHrrpHku6vh1UeGH0HtxVFTRC+lPgpVvU=; b=f4gn1Gge8iZr7uEZImVRCssn/QCRaxC98Ev9hgEvtoWmdt2LSW+91JqN8G4BAeu/Vu fD8UBSXbRD+9nHPI5ppdpFIyryMpBOmn/khT3X0R0WtxcLqD8uHcNG9sjdDs/MoVZSzl QKec5wFgNdBpHYr23EQxaPJHCtSQD0t8qO06uCbvcJhWqRbV9xHw5BWMOnZkNX6cs2Mt FQ88e487K9oc65eufVh4eei2x4cLXuswKL1Os+b5ZjVasIyzUVZvgEzvyVaY8P7xVJ6u kWjk/4uZPLCqFznD3E/4jiTIccfYm6/UjqqQ9pENHkUDmkU6qbd1yuWGploHOIr3H/Vr KevQ== X-Gm-Message-State: ALyK8tJsR4hB1AMIMxs+dn+NpqqT/T1nyZNmb6DpX4Y1d70lHKk8CESc59OzuXZbqK9adA== X-Received: by 10.28.228.69 with SMTP id b66mr6928379wmh.25.1466355940005; Sun, 19 Jun 2016 10:05:40 -0700 (PDT) Received: from ivaldir.etoilebsd.net ([2001:41d0:8:db4c::1]) by smtp.gmail.com with ESMTPSA id o10sm22607784wjs.38.2016.06.19.10.05.39 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 19 Jun 2016 10:05:39 -0700 (PDT) Sender: Baptiste Daroussin Date: Sun, 19 Jun 2016 19:05:38 +0200 From: Baptiste Daroussin To: Andrey Chernov Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Hajimu UMEMOTO Subject: Re: svn commit: r302016 - in head: share/timedef tools/tools/locale/tools Message-ID: <20160619170538.qt2kmzr5fo34ekvj@ivaldir.etoilebsd.net> References: <201606190344.u5J3iWO6079652@repo.freebsd.org> <3387744f-7abd-417c-599f-163e78b4170e@freebsd.org> <20160619145233.kjnfyxjb75fdcucz@ivaldir.etoilebsd.net> <20160619154918.etycha7kvj4v7nrp@ivaldir.etoilebsd.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="fh7brfnogevkb7bw" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.6.1-neo (2016-06-11) X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 19 Jun 2016 17:05:42 -0000 --fh7brfnogevkb7bw Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Jun 19, 2016 at 07:47:27PM +0300, Andrey Chernov wrote: > On 19.06.2016 18:49, Baptiste Daroussin wrote: > > On Sun, Jun 19, 2016 at 04:52:34PM +0200, Baptiste Daroussin wrote: > >> On Sun, Jun 19, 2016 at 07:57:49AM +0300, Andrey Chernov wrote: > >>> On 19.06.2016 6:44, Hajimu UMEMOTO wrote: > >>>> Log: > >>>> - Prefer to use %d over %e where the day of the month should be ze= ro > >>>> filled. > >>>> - Since %e means the day of the month as well, regard %e as same a= s %d > >>>> in md_order. > >>> > >>> Nonsense doubled formats in sr_*_RS locales and nonsense md_order the= re too. > >> > >> Crap I'll dig into it, thanks for spotting it. > >> > >> Best regards, > >> Bapt > >=20 > > Should be fixed by: > > https://people.freebsd.org/~bapt/locale-triple-components.diff > >=20 > > The perl script generating the locales was badly handling locales with 3 > > components, fixed now. > >=20 > > Sorry about that > >=20 > > Best regards, > > Bapt > >=20 >=20 > sr locales are badly named before anything else, proper format is > language[_COUNTRY][.encoding][@variant] > I.e. > sr_RS.UTF-8@Latn > sr_RS.ISO8859-2@Latn > sr_RS.ISO8859-t@Cyrl According to what? >=20 > I don't know, if out utilities (f.e. locale(1)) can handle @variant suffi= x. >=20 Our syntax is the syntax for the variants that has been the widly adopted: Microsoft, ICU, java, python's babel internationalisation thing, cldr (of course), CPAN components (Datime::Locales for example) This is respecting RFC 3066 with the little difference that we use '_' inst= ead of '-' Best regards, Bapt --fh7brfnogevkb7bw Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJXZtDfAAoJEGOJi9zxtz5atQYP/jMq+j78/JFlN/yBbJO9lMzn SLCRl594TJ7H6sAqB9lfzNsKCsHkhsHlHVvabsLQ2viQAYf7admZd3JTVOExwR6l otAZhUfLF8PFM6Sm2NZmcBPNQ+a3CYjrwueZF7P2OxYR/seSSPRLsx2/AFlmm25U w108Uhv/GatttIO+rWvQBMJIHuytv15mlfSF60I2q9I/aVufStHpp2xP+uagXC+n aNt71m3IQC1yAUOldNFBi70d48ZEOqrj6/0fCrIUy6tCd1rhNmAnKEINJr7D8Fo1 dRRzjsfBsNdmd0nATR9rI9FBe4sclUhauZTtFVNluLfd/VcT9pAnc1V9GQTU/3jb Ep5z8nzPc7vzFnTtfyz+3BvbjL4eueiKDCeY2FBDFqP6Keq5WjszApXYEoVdaxep CER8Unp/Juv6T9aeUQ+Vbhja+hO5/ckZQNRLDAqJ9qzOlUBeqbfh/YJJfgjzc4mi fCGm6GYSxo88Z2KPO4AoI+SH9oYXUvwPrEBrZOqfMbRR/SR/QwVlfzWFFxsGtPB4 37scBATDm141o1Rli7PRe7k7QGsgSRtTtr010Gyk3nfPI27CE1uPi1la6YK4mhgs RtCaJ+VKOysX4uMSjXtPs00YOgtG9z8MrvehRbCT+6lvx0znbKxC4MbKnV8Fec7X hlPDOnlCFuvlXpzIVkYC =6UFc -----END PGP SIGNATURE----- --fh7brfnogevkb7bw-- From owner-svn-src-head@freebsd.org Sun Jun 19 17:10:24 2016 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id EF4D7A7A4A2; Sun, 19 Jun 2016 17:10:24 +0000 (UTC) (envelope-from baptiste.daroussin@gmail.com) Received: from mail-wm0-x229.google.com (mail-wm0-x229.google.com [IPv6:2a00:1450:400c:c09::229]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 7E0DC24ED; Sun, 19 Jun 2016 17:10:24 +0000 (UTC) (envelope-from baptiste.daroussin@gmail.com) Received: by mail-wm0-x229.google.com with SMTP id r201so32336329wme.1; Sun, 19 Jun 2016 10:10:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=qHJpJx9ortWOx28KLDXqUo/N7Q49z6Wb0Pd0w02zmds=; b=EYWhyiDR2LkDIoYv/kAPeQ7pMLPpAmWLing7LTO3kIwy+TrNe9ZITUris0yLsOdZ8g A4BxeijJtX3kXeogpv3x/3a0rYHyo8ekbB3RA6QSWmv7H8+vKRYxCukXt8kCwRxURf8x DVF6EWFBpDtiuZUFuA0mTLOgcsrdTS10WIXc2fvSgBK+O8lsrf/q/cv80DHhYHxpEO/9 luroeGR+L/gTaSdEZ0nyqNpf85mFUFksyso0HfMcrGG97uLOi2U/tTvxMhQlgPNisaMq cv/7acznoJxXTqSHW/+Kl3t79z7TH5yTOEQFfNA5ZTr/z3+Xz/31LBhNCkBaiBfFKVtB xrxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=qHJpJx9ortWOx28KLDXqUo/N7Q49z6Wb0Pd0w02zmds=; b=AgrsVCzY/tl6cmGReUckjmMIeS3v1697ZCN0qeUHTH796PuVl040jrfrZplZyLxbA7 qWQfbWl8nQk6/vRU7EY6b5Jvi8KLtHVjupd4rdLVgKfuIBgt8aBSWspG4LuSiDmU30sH IEg9+++swaf3EozhlO+pWEMWFdSiE5OfPHZZ0vQyy5PiaPtTGtwiCBuGXzsUffc1TxrG 3sxK3DjvoriOiwOF+EdVan5Ue4jMn1yDsw9nIVKLDZGwkdtTKrhWqpnDkj/bgxHBtjCL 2rBzzLXoucFzxL1P/YIRe6g+O4WAj3/QcDYatGCUir3GnemCY7bGllLW+dKTqn4pyIXU mRaQ== X-Gm-Message-State: ALyK8tIdrw8Sd3xBONCjPtCQa7cO7MwxYnjd47GvkCsO2eSJhIF2N6JNzt8qXvlIo2VkPQ== X-Received: by 10.194.203.105 with SMTP id kp9mr11463431wjc.70.1466356222765; Sun, 19 Jun 2016 10:10:22 -0700 (PDT) Received: from ivaldir.etoilebsd.net ([2001:41d0:8:db4c::1]) by smtp.gmail.com with ESMTPSA id jf3sm28563493wjb.41.2016.06.19.10.10.21 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 19 Jun 2016 10:10:22 -0700 (PDT) Sender: Baptiste Daroussin Date: Sun, 19 Jun 2016 19:10:21 +0200 From: Baptiste Daroussin To: Andrey Chernov Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Hajimu UMEMOTO Subject: Re: svn commit: r302016 - in head: share/timedef tools/tools/locale/tools Message-ID: <20160619171021.7ps2te7wgoxfqznv@ivaldir.etoilebsd.net> References: <201606190344.u5J3iWO6079652@repo.freebsd.org> <3387744f-7abd-417c-599f-163e78b4170e@freebsd.org> <20160619145233.kjnfyxjb75fdcucz@ivaldir.etoilebsd.net> <20160619154918.etycha7kvj4v7nrp@ivaldir.etoilebsd.net> <77076d87-41ad-0cce-c703-ed9cef1bdb8b@freebsd.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="imdvuh4tgkvycob7" Content-Disposition: inline In-Reply-To: <77076d87-41ad-0cce-c703-ed9cef1bdb8b@freebsd.org> User-Agent: Mutt/1.6.1-neo (2016-06-11) X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 19 Jun 2016 17:10:25 -0000 --imdvuh4tgkvycob7 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Jun 19, 2016 at 08:05:30PM +0300, Andrey Chernov wrote: > On 19.06.2016 19:52, Andrey Chernov wrote: > > On 19.06.2016 19:47, Andrey Chernov wrote: > >> On 19.06.2016 18:49, Baptiste Daroussin wrote: > >>> On Sun, Jun 19, 2016 at 04:52:34PM +0200, Baptiste Daroussin wrote: > >>>> On Sun, Jun 19, 2016 at 07:57:49AM +0300, Andrey Chernov wrote: > >>>>> On 19.06.2016 6:44, Hajimu UMEMOTO wrote: > >>>>>> Log: > >>>>>> - Prefer to use %d over %e where the day of the month should be = zero > >>>>>> filled. > >>>>>> - Since %e means the day of the month as well, regard %e as same= as %d > >>>>>> in md_order. > >>>>> > >>>>> Nonsense doubled formats in sr_*_RS locales and nonsense md_order t= here too. > >>>> > >>>> Crap I'll dig into it, thanks for spotting it. > >>>> > >>>> Best regards, > >>>> Bapt > >>> > >>> Should be fixed by: > >>> https://people.freebsd.org/~bapt/locale-triple-components.diff > >>> > >>> The perl script generating the locales was badly handling locales wit= h 3 > >>> components, fixed now. > >>> > >>> Sorry about that > >>> > >>> Best regards, > >>> Bapt > >>> > >> > >> sr locales are badly named before anything else, proper format is > >> language[_COUNTRY][.encoding][@variant] > >> I.e. > >> sr_RS.UTF-8@Latn > >> sr_RS.ISO8859-2@Latn > >> sr_RS.ISO8859-t@Cyrl > >> > >> I don't know, if out utilities (f.e. locale(1)) can handle @variant su= ffix. > >> > >> > > =3Dsr_RS.ISO8859-5@Cyrl > > =3Dour, and not utilities only but libc too >=20 > Since right now we have only single @variant per each encoding, and no > @variant for other locales, we can just drop it and use right names like: > sr_RS.UTF-8 We have 2 for the above the Cyrl version and the Latn version > sr_RS.ISO8859-2 > sr_RS.ISO8859-5 We can make aliases easily for that is that is what people want, not the we= have the same for other locales: zh_Hans_CN.GB18030 zh_Hans_CN.GB2312 zh_Hans_CN.GBK zh_Hans_CN.UTF-8 zh_Hans_CN.eucCN zh_Hant_HK.UTF-8 zh_Hant_TW.Big5 zh_Hant_TW.UTF-8 With some aliases for some of the previously existing ones: zh_TW.Big5 zh_TW.UTF-8 zh_CN.GB18030 zh_CN.GB2312 zh_CN.GBK zh_CN.UTF-8 zh_CN.eucCN zh_HK.UTF-8 Some of the new locales (that didn't exist before) I have only imported the= new name format: kk_Cyrl_KZ.UTF-8 mn_Cyrl_MN.UTF-8 sr_Cyrl_RS.ISO8859-5 sr_Cyrl_RS.UTF-8 sr_Latn_RS.ISO8859-2 sr_Latn_RS.UTF-8 I would prefer staying on the new syntax given it is allowed by some RFC an= d it is slowly being adopted everywhere else. Btw another RFC: https://www.ietf.org/rfc/rfc5646.txt Best regards, Bapt --imdvuh4tgkvycob7 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJXZtH9AAoJEGOJi9zxtz5atOwP/jF5+B26EI6I0w3pafvZDbQz 9ZPLoJxWBxKEoX2y57IPOGlbSZfMf3j0OEyEUuZHMxCTO6M8lETmD/GoNOG5m2x2 txuZctZ77wJo5IQChu5MWTLYXeDi8jr0HJvKyAngkN8dJxBbDyjPQFHZPcqh8AKZ ULSBH0MakGKzAXrgwAZf7uv+52JWO+cO5YV8uyqkXWWwlma7UnrrqaEKR5zvqx59 NZ3fxz8a2AQazxQcepnh55sflUBkPRX0ycFrMpUWf4a4lJvub15oKHxfEW8lO3DY AJzNI4nXdyZFV6K7r280AaaK+CVaC2hmVZJQ/Poob+R5wkVF5fnQoBouVizKRMQw 7lfJmGlA4x+hMulsv60bNhjmQLWXj8pqr3RbFFvQxN/1oCUKZxRIUcInqNxbJkE7 CfBcDlcTDdImIZ57ORdKMNVJyp6q0g34t6oXr0blNXsANB+7FHSIGcvQgXnafTVi O0NiPxfnvAng1m6rUaB7XD4NAVekgPAqdVy4QPPRmEq8TlRWUSQNqiHNYX/kkLbJ opxIb47ofmPWf2BPujcGPRSuTkEaSLrXHFfSYAcnEKN9igRRCN0G9iVGGE492Or5 PD3uQy7Y2KRG4x0jtrfiBZXOvwrQyHSuDTyRz0rCf2eD32fG+V1JN+5mqmaBzTcv v/PsstkK1c2NPOiTjO8l =/nxt -----END PGP SIGNATURE----- --imdvuh4tgkvycob7-- From owner-svn-src-head@freebsd.org Sun Jun 19 17:16:59 2016 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 04D37A7A67B for ; Sun, 19 Jun 2016 17:16:59 +0000 (UTC) (envelope-from mailing-machine@vniz.net) Received: from mail-lf0-f47.google.com (mail-lf0-f47.google.com [209.85.215.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 7B5E9288D for ; Sun, 19 Jun 2016 17:16:58 +0000 (UTC) (envelope-from mailing-machine@vniz.net) Received: by mail-lf0-f47.google.com with SMTP id l188so24850918lfe.2 for ; Sun, 19 Jun 2016 10:16:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to; bh=KxseqSs9p8RhPX+r7OHyvsrlV2G92pWdL5+avZ3YuFM=; b=XIHuL9W6OTk5CoWo03wQ3RBsDFJJ9oocnZyiYb2cqliyUiyKKzO4HsEMqzC2ZyR6oy u4RpTW1HhC+aWYCH2t0814DJNbDnglmQSBWPEnMLdYcImAQcq9BKdUswxPJsn5nLyxFc FV/KRJU+GYRpSsGxqwfS91QuOsQRwTIHb5zGVoBKRe3SG28DURMGZvC869KFX/ticSN7 0JfUNPSgwhquE87AKgw/bwRzLVjvoMNqjYNEo9O7CyRxgRzqDrTbALJd6n0FSAX3oBKb /nuxlx9xHjGY72qrbuU48t9DrAMUD/TtU6IlhR3T5ZLRlPNKMRlcHqosMLHrpKYvDyBm gwfg== X-Gm-Message-State: ALyK8tKDh8n9N5noMNWIkMA28T4rWTmi842aQxAYFrkxNEM4kfx4TlVJkJszO1YE6Snuzg== X-Received: by 10.25.148.200 with SMTP id w191mr518788lfd.2.1466356616240; Sun, 19 Jun 2016 10:16:56 -0700 (PDT) Received: from [192.168.1.2] ([89.169.173.68]) by smtp.gmail.com with ESMTPSA id o93sm5308824lfi.5.2016.06.19.10.16.55 (version=TLSv1/SSLv3 cipher=OTHER); Sun, 19 Jun 2016 10:16:55 -0700 (PDT) Subject: Re: svn commit: r302016 - in head: share/timedef tools/tools/locale/tools To: Baptiste Daroussin References: <201606190344.u5J3iWO6079652@repo.freebsd.org> <3387744f-7abd-417c-599f-163e78b4170e@freebsd.org> <20160619145233.kjnfyxjb75fdcucz@ivaldir.etoilebsd.net> <20160619154918.etycha7kvj4v7nrp@ivaldir.etoilebsd.net> <20160619170538.qt2kmzr5fo34ekvj@ivaldir.etoilebsd.net> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Hajimu UMEMOTO From: Andrey Chernov Message-ID: <73ce250f-71f6-7bde-9340-e6b6bf7ce749@freebsd.org> Date: Sun, 19 Jun 2016 20:16:54 +0300 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.1.1 MIME-Version: 1.0 In-Reply-To: <20160619170538.qt2kmzr5fo34ekvj@ivaldir.etoilebsd.net> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="9Chb07Aorhm3nSW9RXFxUV8wR4owxwHAV" X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 19 Jun 2016 17:16:59 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --9Chb07Aorhm3nSW9RXFxUV8wR4owxwHAV Content-Type: multipart/mixed; boundary="flFCXQtdfuMgdi61K12UDpQaNU4Tbi9O3" From: Andrey Chernov To: Baptiste Daroussin Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Hajimu UMEMOTO Message-ID: <73ce250f-71f6-7bde-9340-e6b6bf7ce749@freebsd.org> Subject: Re: svn commit: r302016 - in head: share/timedef tools/tools/locale/tools References: <201606190344.u5J3iWO6079652@repo.freebsd.org> <3387744f-7abd-417c-599f-163e78b4170e@freebsd.org> <20160619145233.kjnfyxjb75fdcucz@ivaldir.etoilebsd.net> <20160619154918.etycha7kvj4v7nrp@ivaldir.etoilebsd.net> <20160619170538.qt2kmzr5fo34ekvj@ivaldir.etoilebsd.net> In-Reply-To: <20160619170538.qt2kmzr5fo34ekvj@ivaldir.etoilebsd.net> --flFCXQtdfuMgdi61K12UDpQaNU4Tbi9O3 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 19.06.2016 20:05, Baptiste Daroussin wrote: > On Sun, Jun 19, 2016 at 07:47:27PM +0300, Andrey Chernov wrote: >> On 19.06.2016 18:49, Baptiste Daroussin wrote: >>> On Sun, Jun 19, 2016 at 04:52:34PM +0200, Baptiste Daroussin wrote: >>>> On Sun, Jun 19, 2016 at 07:57:49AM +0300, Andrey Chernov wrote: >>>>> On 19.06.2016 6:44, Hajimu UMEMOTO wrote: >>>>>> Log: >>>>>> - Prefer to use %d over %e where the day of the month should be = zero >>>>>> filled. >>>>>> - Since %e means the day of the month as well, regard %e as same= as %d >>>>>> in md_order. >>>>> >>>>> Nonsense doubled formats in sr_*_RS locales and nonsense md_order t= here too. >>>> >>>> Crap I'll dig into it, thanks for spotting it. >>>> >>>> Best regards, >>>> Bapt >>> >>> Should be fixed by: >>> https://people.freebsd.org/~bapt/locale-triple-components.diff >>> >>> The perl script generating the locales was badly handling locales wit= h 3 >>> components, fixed now. >>> >>> Sorry about that >>> >>> Best regards, >>> Bapt >>> >> >> sr locales are badly named before anything else, proper format is >> language[_COUNTRY][.encoding][@variant] >> I.e. >> sr_RS.UTF-8@Latn >> sr_RS.ISO8859-2@Latn >> sr_RS.ISO8859-t@Cyrl >=20 > According to what? >> >> I don't know, if out utilities (f.e. locale(1)) can handle @variant su= ffix. >> > Our syntax is the syntax for the variants that has been the widly adopt= ed: > Microsoft, ICU, java, python's babel internationalisation thing, > cldr (of course), CPAN components (Datime::Locales for example) >=20 > This is respecting RFC 3066 with the little difference that we use '_' = instead > of '-' >=20 > Best regards, > Bapt >=20 According to POSIX, but I can't find the reference right now, it is related to XPG3 or XPG4. It was already many years. First reference from Google http://www.boost.org/doc/libs/1_60_0/libs/locale/doc/html/locale_gen.html= Next from Gentoo: https://wiki.gentoo.org/wiki/Localization/Guide Microsoft, Linux and GNU iconv understand @-syntax --flFCXQtdfuMgdi61K12UDpQaNU4Tbi9O3-- --9Chb07Aorhm3nSW9RXFxUV8wR4owxwHAV Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQEcBAEBCAAGBQJXZtOGAAoJEKUckv0MjfbKtiAH/RO4AWLQDvdvUHsIyi8amFDM QdsZjWAcW3ZBwLp0T7FRQLh6Et197pVJ4jaPIApR0Z5ALTg41H0ZWYsqy19iktbE tkC8rxj3fqWctkwnxnHVGeAuk8FQ5uV8GI1hffjMsVqYc7adovqO1gcIkBiGS9ZQ qqTZ1e/aoPjENbno1X5KwuA/ZpY3YYyesGB0/x8513L9h1mLM6jiaD2+pbcHhX6k kqeI7tHjihgB8aOYMz5to8LiRZ4KbzCEiyG3iMj+Y4QjFYdBqTfxl9+2hNK4pt65 PQOrDw2nGs2PwKKlUYdM+ER44BtF+QX93RdIqdXsqsOvO9QCJgAE0+aoiIJKc9U= =vXYA -----END PGP SIGNATURE----- --9Chb07Aorhm3nSW9RXFxUV8wR4owxwHAV-- From owner-svn-src-head@freebsd.org Sun Jun 19 17:19:38 2016 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 5D523A7A744; Sun, 19 Jun 2016 17:19:38 +0000 (UTC) (envelope-from baptiste.daroussin@gmail.com) Received: from mail-wm0-x242.google.com (mail-wm0-x242.google.com [IPv6:2a00:1450:400c:c09::242]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id DBE772A01; Sun, 19 Jun 2016 17:19:37 +0000 (UTC) (envelope-from baptiste.daroussin@gmail.com) Received: by mail-wm0-x242.google.com with SMTP id 187so8922501wmz.1; Sun, 19 Jun 2016 10:19:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=Uoh/iEoW4Qb3yOet5UgpmAem8U8Tlu1aw1/5rwYyZZc=; b=IwncSFsn51y6ZARx3X9hKwuELr0elfilYxIlqecaqSUEohwIBFHblpGmuJIvnQCO5F Lco2V0I295B3h688lPfX32LsW7+kXs/JEDdT2g1AHyJi94hrSW1pwzk3sHakb5BboSBq Ix34O8N42I+Mbr3uQm5HTOkFL6tNw8LXvraLznOGmN7SLYVDTxR5b3Eiuhs2ZBsGXLqd 4EdT+U8HeBLe2H/bt7pOZUQ/icO2BUgSma9681ShMpRmsswHBSb8jnNVL9RlD8Q8/HlH ortl93QYt/lUvodGKhaGCUzSiu4xtmQwqOVZFzf2KN1moIlJrjwCiN9mio/0pob5WQUl HrmQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=Uoh/iEoW4Qb3yOet5UgpmAem8U8Tlu1aw1/5rwYyZZc=; b=cLOitJHVLI6XPjBmHOewJ8dBwaudhyocoH10wzXH2+G/TaOgoaCKJUfMSlsSF1J1L1 zXUL0xfGHSc0ni8dO2WZqJghou/yitPUSn/YxC7jmskaDhozvxjRBJivKMIEHMclncFg uULNckPKnwK03JqixiRN/enOPVABBt3voruV/u3nb+zX1qojDKbZpUQ1y3hVK0SpHu0u X8+pRs9qA3vqDI+Zembw4HMqQah5zAnXUswCRRYPvmup4F+orSARAlIODiIo29ilv07V hDhoXAbZLTHHO+Ry0j1aIWJ4YAJOpVU4GUhFAghEVlWMWn29/7qAxyjPfPNV7b4ZSvlQ cBHA== X-Gm-Message-State: ALyK8tLnXs8kcZmtFoCy/Pl5uXAGM+Nsi30PWuBoy5Nt8GOHWiC2Od/PpeWNkHsRSYOUvg== X-Received: by 10.28.140.194 with SMTP id o185mr7071079wmd.86.1466356776371; Sun, 19 Jun 2016 10:19:36 -0700 (PDT) Received: from ivaldir.etoilebsd.net ([2001:41d0:8:db4c::1]) by smtp.gmail.com with ESMTPSA id v200sm9364734wmv.4.2016.06.19.10.19.35 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 19 Jun 2016 10:19:35 -0700 (PDT) Sender: Baptiste Daroussin Date: Sun, 19 Jun 2016 19:19:34 +0200 From: Baptiste Daroussin To: Andrey Chernov Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Hajimu UMEMOTO Subject: Re: svn commit: r302016 - in head: share/timedef tools/tools/locale/tools Message-ID: <20160619171934.5hxchhcvrbhhxvti@ivaldir.etoilebsd.net> References: <201606190344.u5J3iWO6079652@repo.freebsd.org> <3387744f-7abd-417c-599f-163e78b4170e@freebsd.org> <20160619145233.kjnfyxjb75fdcucz@ivaldir.etoilebsd.net> <20160619154918.etycha7kvj4v7nrp@ivaldir.etoilebsd.net> <20160619170538.qt2kmzr5fo34ekvj@ivaldir.etoilebsd.net> <73ce250f-71f6-7bde-9340-e6b6bf7ce749@freebsd.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="fkepdmjy6vfsgsuy" Content-Disposition: inline In-Reply-To: <73ce250f-71f6-7bde-9340-e6b6bf7ce749@freebsd.org> User-Agent: Mutt/1.6.1-neo (2016-06-11) X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 19 Jun 2016 17:19:38 -0000 --fkepdmjy6vfsgsuy Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Jun 19, 2016 at 08:16:54PM +0300, Andrey Chernov wrote: > On 19.06.2016 20:05, Baptiste Daroussin wrote: > > On Sun, Jun 19, 2016 at 07:47:27PM +0300, Andrey Chernov wrote: > >> On 19.06.2016 18:49, Baptiste Daroussin wrote: > >>> On Sun, Jun 19, 2016 at 04:52:34PM +0200, Baptiste Daroussin wrote: > >>>> On Sun, Jun 19, 2016 at 07:57:49AM +0300, Andrey Chernov wrote: > >>>>> On 19.06.2016 6:44, Hajimu UMEMOTO wrote: > >>>>>> Log: > >>>>>> - Prefer to use %d over %e where the day of the month should be = zero > >>>>>> filled. > >>>>>> - Since %e means the day of the month as well, regard %e as same= as %d > >>>>>> in md_order. > >>>>> > >>>>> Nonsense doubled formats in sr_*_RS locales and nonsense md_order t= here too. > >>>> > >>>> Crap I'll dig into it, thanks for spotting it. > >>>> > >>>> Best regards, > >>>> Bapt > >>> > >>> Should be fixed by: > >>> https://people.freebsd.org/~bapt/locale-triple-components.diff > >>> > >>> The perl script generating the locales was badly handling locales wit= h 3 > >>> components, fixed now. > >>> > >>> Sorry about that > >>> > >>> Best regards, > >>> Bapt > >>> > >> > >> sr locales are badly named before anything else, proper format is > >> language[_COUNTRY][.encoding][@variant] > >> I.e. > >> sr_RS.UTF-8@Latn > >> sr_RS.ISO8859-2@Latn > >> sr_RS.ISO8859-t@Cyrl > >=20 > > According to what? > >> > >> I don't know, if out utilities (f.e. locale(1)) can handle @variant su= ffix. > >> > > Our syntax is the syntax for the variants that has been the widly adopt= ed: > > Microsoft, ICU, java, python's babel internationalisation thing, > > cldr (of course), CPAN components (Datime::Locales for example) > >=20 > > This is respecting RFC 3066 with the little difference that we use '_' = instead > > of '-' > >=20 > > Best regards, > > Bapt > >=20 >=20 > According to POSIX, but I can't find the reference right now, it is > related to XPG3 or XPG4. It was already many years. > First reference from Google > http://www.boost.org/doc/libs/1_60_0/libs/locale/doc/html/locale_gen.html > Next from Gentoo: > https://wiki.gentoo.org/wiki/Localization/Guide > Microsoft, Linux and GNU iconv understand @-syntax >=20 >=20 As soon as our libc and locale tool support it we can make aliases to suppo= rt both syntax Best regards, Bapt --fkepdmjy6vfsgsuy Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJXZtQlAAoJEGOJi9zxtz5axGwQAM6N/UorjrdVO1iPAAsvNiNR RsCxmMGj+38WO7m4THozi0ryUaF4bDbS4yDNo5kkwuir8YMsPxjjrFg8M0fA5WZF 0JN4ljLDlh59ZOZuEvOssBB1gNVxoG5ElW+YArxv7M9BoKck0Omdx1liRjCbc2B6 1Y2qmh6T0IMOl5TOtpezpT6hIs9uCn2GzS66XpnQ0yXSsvnqtd+xb3QzAbM0f+aY 491dxmcczdy3vqicJmfVFH2P27UmyD67DWw6KyIfgwKCKMGrm2PtsRIiMJ/XdpVD pZ689njw5jLwCwFz71OOBfceLUHyT+e4nURLKZ/0zTlS5wjK3jrb/gcm9Hm/8rJd AAaveN9VY3SXvn7hkEicpb5QefRd/MfcoWS7Qw1gs7QuL0AFcrKHjiWisqV3R973 3DoCpCvse1qPCouH5ISq0ONRITTC6SDBhb7lvBt9ZiwaVTzDPkrrRIje3hxM45/7 2dz0L6rgw4SoQ2DQaA79FEAT5g6j+/CjM8NzAfrjcfoLsSO6PiMOoLOvajpSAvG7 xzredNs4Lua3KpsTyFDz0YCXNNgT+yO7xTSbJby5dauZWDOx8UB3O97fTiNRSRGV uR/98rodkiN8ObLKg+IxG/gG7lK2VGhKg2X6zvwY0bsPiw2He6Ma+hXj6rGNb6dI c1FrKgpMbGKYPehiJYoC =VA8Q -----END PGP SIGNATURE----- --fkepdmjy6vfsgsuy-- From owner-svn-src-head@freebsd.org Sun Jun 19 17:21:40 2016 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 2989DA7A7DA for ; Sun, 19 Jun 2016 17:21:40 +0000 (UTC) (envelope-from mailing-machine@vniz.net) Received: from mail-lf0-f54.google.com (mail-lf0-f54.google.com [209.85.215.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 97D2C2D2F for ; Sun, 19 Jun 2016 17:21:39 +0000 (UTC) (envelope-from mailing-machine@vniz.net) Received: by mail-lf0-f54.google.com with SMTP id l188so24885912lfe.2 for ; Sun, 19 Jun 2016 10:21:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to; bh=B6glWHyYP+n71RtPFxB53Zk1Q5RSBDu7IsUKLQiB76s=; b=j3tDg1aqKJjoe0Z51P2bmIaEFnGEhOTFO/Hyg9NJmZmUGusKAAu7ddk94BWeSDWb5l LIY4c8RUz1s8uqS9jlnWUo5Uw1whjllpSmW1SBRVglfqsDgRZJXkuycz//uuzdTtEw0a L5szav4ASmKsFARzVA2BJv7ZROPmSOSAHXkjo0heBdjPLZVupNquWRy0qkY5m4HpGJOI M4mluDG4cxDZ9qxdAOK9G9Q2d7cci/jMAAEQxa2NZ1iig0pzSBvPeAkr05j4rPIPiNK8 FgxeL5tsr3HlRZsVeWJJn6gad9BVlQkaP2u+CqAc2eU9ll+8OT4wjRK+p7xfQkkcMAVB nIYA== X-Gm-Message-State: ALyK8tKnXxuko+2uT0JKqwhg+f2lGnaXF0gGtpl15ZWm2YI204q7hlL56xz6KsLR2mG5DA== X-Received: by 10.25.26.194 with SMTP id a185mr2526427lfa.156.1466356897382; Sun, 19 Jun 2016 10:21:37 -0700 (PDT) Received: from [192.168.1.2] ([89.169.173.68]) by smtp.gmail.com with ESMTPSA id l138sm783043lfb.22.2016.06.19.10.21.36 (version=TLSv1/SSLv3 cipher=OTHER); Sun, 19 Jun 2016 10:21:36 -0700 (PDT) Subject: Re: svn commit: r302016 - in head: share/timedef tools/tools/locale/tools To: Baptiste Daroussin References: <201606190344.u5J3iWO6079652@repo.freebsd.org> <3387744f-7abd-417c-599f-163e78b4170e@freebsd.org> <20160619145233.kjnfyxjb75fdcucz@ivaldir.etoilebsd.net> <20160619154918.etycha7kvj4v7nrp@ivaldir.etoilebsd.net> <77076d87-41ad-0cce-c703-ed9cef1bdb8b@freebsd.org> <20160619171021.7ps2te7wgoxfqznv@ivaldir.etoilebsd.net> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Hajimu UMEMOTO From: Andrey Chernov Message-ID: Date: Sun, 19 Jun 2016 20:21:35 +0300 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.1.1 MIME-Version: 1.0 In-Reply-To: <20160619171021.7ps2te7wgoxfqznv@ivaldir.etoilebsd.net> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="6m75Ost4vG0OV8lve34fUTm0HoOHsRVin" X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 19 Jun 2016 17:21:40 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --6m75Ost4vG0OV8lve34fUTm0HoOHsRVin Content-Type: multipart/mixed; boundary="ljhoxWrLxihoE186QEtis6QLrjBEkHmPC" From: Andrey Chernov To: Baptiste Daroussin Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Hajimu UMEMOTO Message-ID: Subject: Re: svn commit: r302016 - in head: share/timedef tools/tools/locale/tools References: <201606190344.u5J3iWO6079652@repo.freebsd.org> <3387744f-7abd-417c-599f-163e78b4170e@freebsd.org> <20160619145233.kjnfyxjb75fdcucz@ivaldir.etoilebsd.net> <20160619154918.etycha7kvj4v7nrp@ivaldir.etoilebsd.net> <77076d87-41ad-0cce-c703-ed9cef1bdb8b@freebsd.org> <20160619171021.7ps2te7wgoxfqznv@ivaldir.etoilebsd.net> In-Reply-To: <20160619171021.7ps2te7wgoxfqznv@ivaldir.etoilebsd.net> --ljhoxWrLxihoE186QEtis6QLrjBEkHmPC Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 19.06.2016 20:10, Baptiste Daroussin wrote: > On Sun, Jun 19, 2016 at 08:05:30PM +0300, Andrey Chernov wrote: >> On 19.06.2016 19:52, Andrey Chernov wrote: >>> On 19.06.2016 19:47, Andrey Chernov wrote: >>>> On 19.06.2016 18:49, Baptiste Daroussin wrote: >>>>> On Sun, Jun 19, 2016 at 04:52:34PM +0200, Baptiste Daroussin wrote:= >>>>>> On Sun, Jun 19, 2016 at 07:57:49AM +0300, Andrey Chernov wrote: >>>>>>> On 19.06.2016 6:44, Hajimu UMEMOTO wrote: >>>>>>>> Log: >>>>>>>> - Prefer to use %d over %e where the day of the month should b= e zero >>>>>>>> filled. >>>>>>>> - Since %e means the day of the month as well, regard %e as sa= me as %d >>>>>>>> in md_order. >>>>>>> >>>>>>> Nonsense doubled formats in sr_*_RS locales and nonsense md_order= there too. >>>>>> >>>>>> Crap I'll dig into it, thanks for spotting it. >>>>>> >>>>>> Best regards, >>>>>> Bapt >>>>> >>>>> Should be fixed by: >>>>> https://people.freebsd.org/~bapt/locale-triple-components.diff >>>>> >>>>> The perl script generating the locales was badly handling locales w= ith 3 >>>>> components, fixed now. >>>>> >>>>> Sorry about that >>>>> >>>>> Best regards, >>>>> Bapt >>>>> >>>> >>>> sr locales are badly named before anything else, proper format is >>>> language[_COUNTRY][.encoding][@variant] >>>> I.e. >>>> sr_RS.UTF-8@Latn >>>> sr_RS.ISO8859-2@Latn >>>> sr_RS.ISO8859-t@Cyrl >>>> >>>> I don't know, if out utilities (f.e. locale(1)) can handle @variant = suffix. >>>> >>>> >>> =3Dsr_RS.ISO8859-5@Cyrl >>> =3Dour, and not utilities only but libc too >> >> Since right now we have only single @variant per each encoding, and no= >> @variant for other locales, we can just drop it and use right names li= ke: >> sr_RS.UTF-8 >=20 > We have 2 for the above the Cyrl version and the Latn version >=20 >> sr_RS.ISO8859-2 >> sr_RS.ISO8859-5 >=20 > We can make aliases easily for that is that is what people want, not th= e we have > the same for other locales: >=20 > zh_Hans_CN.GB18030 > zh_Hans_CN.GB2312 > zh_Hans_CN.GBK > zh_Hans_CN.UTF-8 > zh_Hans_CN.eucCN > zh_Hant_HK.UTF-8 > zh_Hant_TW.Big5 > zh_Hant_TW.UTF-8 >=20 > With some aliases for some of the previously existing ones: > zh_TW.Big5 > zh_TW.UTF-8 > zh_CN.GB18030 > zh_CN.GB2312 > zh_CN.GBK > zh_CN.UTF-8 > zh_CN.eucCN > zh_HK.UTF-8 >=20 > Some of the new locales (that didn't exist before) I have only imported= the new > name format: > kk_Cyrl_KZ.UTF-8 > mn_Cyrl_MN.UTF-8 > sr_Cyrl_RS.ISO8859-5 > sr_Cyrl_RS.UTF-8 > sr_Latn_RS.ISO8859-2 > sr_Latn_RS.UTF-8 >=20 > I would prefer staying on the new syntax given it is allowed by some RF= C and it > is slowly being adopted everywhere else. >=20 > Btw another RFC: https://www.ietf.org/rfc/rfc5646.txt >=20 > Best regards, > Bapt >=20 Old POSIX don't use RFC 5646, there are ISO-639 two-letter codes. When encodings are different, there is no needs to specify variants, they have meaning only for the same encoding. --ljhoxWrLxihoE186QEtis6QLrjBEkHmPC-- --6m75Ost4vG0OV8lve34fUTm0HoOHsRVin Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQEcBAEBCAAGBQJXZtSfAAoJEKUckv0MjfbKgIQIAMrDxXUpLz5SNUNkI3uSZg76 3oy0rRpDuvL3ZW2tR7iB90MEF9J2YJD+vBayC2wP4aYRlqk+XoGbkMHyjMZOzbFW vp09lD6K+kPOzkDy5xxnipvuGFQVMjOUaHhdJo8oX0KeCYq5UdcjqF4bvsDa+cQS EmPkGcTfCxh6CP51AwzulxLMzuThdgm7J1ymAurkn4Y14++H2tMca3EMnWC/WLUK Z5x9FHUq/ZYVu1jKvT/2JlH9zTEJ7AXPqVlDW67PyG1UfwYZ2Qy5r5B8Rx3iCpJn SaRm6236N/yGIr/3UaYXXiS+T2NR8AELUfsHmUy609WwVtofRvB/dvcG7lSI+AA= =TYfX -----END PGP SIGNATURE----- --6m75Ost4vG0OV8lve34fUTm0HoOHsRVin-- From owner-svn-src-head@freebsd.org Sun Jun 19 17:34:13 2016 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 7F05EA7AAEB; Sun, 19 Jun 2016 17:34:13 +0000 (UTC) (envelope-from cy.schubert@komquats.com) Received: from smtp-out-no.shaw.ca (smtp-out-no.shaw.ca [64.59.134.13]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "Client", Issuer "CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 191D8163C; Sun, 19 Jun 2016 17:34:12 +0000 (UTC) (envelope-from cy.schubert@komquats.com) Received: from spqr.komquats.com ([96.50.22.10]) by shaw.ca with SMTP id EgbobYWPuwsAcEgbpbCn44; Sun, 19 Jun 2016 11:34:11 -0600 X-Authority-Analysis: v=2.2 cv=U7HQNqju c=1 sm=1 tr=0 a=jvE2nwUzI0ECrNeyr98KWA==:117 a=jvE2nwUzI0ECrNeyr98KWA==:17 a=L9H7d07YOLsA:10 a=9cW_t1CCXrUA:10 a=s5jvgZ67dGcA:10 a=pD_ry4oyNxEA:10 a=6I5d2MoRAAAA:8 a=YxBL1-UpAAAA:8 a=qSgVzNnN3oH25cI-RzoA:9 a=IjZwj45LgO3ly-622nXo:22 a=Ia-lj3WSrqcvXOmTRaiG:22 Received: from slippy.cwsent.com (slippy [10.1.1.91]) by spqr.komquats.com (Postfix) with ESMTPS id 4D70A13753; Sun, 19 Jun 2016 10:34:08 -0700 (PDT) Received: from slippy (localhost [127.0.0.1]) by slippy.cwsent.com (8.15.2/8.15.2) with ESMTP id u5JHY79U055006; Sun, 19 Jun 2016 10:34:07 -0700 (PDT) (envelope-from Cy.Schubert@cschubert.com) Message-Id: <201606191734.u5JHY79U055006@slippy.cwsent.com> X-Mailer: exmh version 2.8.0 04/21/2012 with nmh-1.6 Reply-to: Cy Schubert From: Cy Schubert X-os: FreeBSD X-Sender: cy@cwsent.com X-URL: http://www.cschubert.com/ To: =?UTF-8?Q?Jean-S=c3=a9bastien_P=c3=a9dron?= cc: Niclas Zeising , Cy Schubert , Adrian Chadd , "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Subject: Re: svn commit: r288291 - head/etc In-Reply-To: Message from =?UTF-8?Q?Jean-S=c3=a9bastien_P=c3=a9dron?= of "Sun, 19 Jun 2016 18:25:30 +0200." Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Sun, 19 Jun 2016 10:34:07 -0700 X-CMAE-Envelope: MS4wfPbETxoQH9LTmmxa8OupNy2QR6ub80g8mI5pzCtS9g4IFvSQpiA/yl0cixCtwfkYl1SPOLG6W+E3b7nWF1XWErg1Ec4NwEM9Ge1mH8HqS4LVTmRw/0Xv 1qDNqR5SKuuhT97WBs7q1xwUTDIU4VbKqNbr5Y+2uB63nl2d7Cs6VcITMonneQK2gVlmNe+Iwp9q4X8K8NUPvCroXej17ZtU5ZjQ5BwUreTOmJHlYLYen2kX Ia68NTkSPqpNtHuXm41AE7OjtnYGmlGPnCAAGkWx/BrANWND9Q8ByypJIIc4xZcp0aZl4tBYzloIAcL4c2pk6HNoca/yaUl/01penrHcgHb1cyVB2yKm3/8k JAa603zmieS/HtMI76X+ueCVz9TesA== X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 19 Jun 2016 17:34:13 -0000 In message , =?UTF-8?Q?Jean-S > On 19/06/2016 16:59, Niclas Zeising wrote: > > I wanted to bring this to attention, since it seems noone else has > > noticed it, or cared enough about it. It is nothing that stops me from= > > > using FreeBSD, I will just have to remember to start ddb manually, or > > run the commands in case of a panic. > > There is a bug filed to track this issue: > https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D206291 > > I have the same problem because the system was installed a long time ago.= I have some older systems that have been upgraded over the years. If nobody minds, I'd like to assign this to myself, unless of course someone else wants it... -- Cheers, Cy Schubert FreeBSD UNIX: Web: http://www.FreeBSD.org The need of the many outweighs the greed of the few. From owner-svn-src-head@freebsd.org Sun Jun 19 18:29:44 2016 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id D5A3DA7A9D9; Sun, 19 Jun 2016 18:29:44 +0000 (UTC) (envelope-from kib@FreeBSD.org) Received: from repo.freebsd.org (repo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id A30012FED; Sun, 19 Jun 2016 18:29:44 +0000 (UTC) (envelope-from kib@FreeBSD.org) Received: from repo.freebsd.org ([127.0.1.37]) by repo.freebsd.org (8.15.2/8.15.2) with ESMTP id u5JITh9S007425; Sun, 19 Jun 2016 18:29:43 GMT (envelope-from kib@FreeBSD.org) Received: (from kib@localhost) by repo.freebsd.org (8.15.2/8.15.2/Submit) id u5JIThWV007424; Sun, 19 Jun 2016 18:29:43 GMT (envelope-from kib@FreeBSD.org) Message-Id: <201606191829.u5JIThWV007424@repo.freebsd.org> X-Authentication-Warning: repo.freebsd.org: kib set sender to kib@FreeBSD.org using -f From: Konstantin Belousov Date: Sun, 19 Jun 2016 18:29:43 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r302019 - head/sys/fs/nfsclient X-SVN-Group: head MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 19 Jun 2016 18:29:44 -0000 Author: kib Date: Sun Jun 19 18:29:43 2016 New Revision: 302019 URL: https://svnweb.freebsd.org/changeset/base/302019 Log: Do not access NFS data for reclaimed vnode. Reported and tested by: pho Sponsored by: The FreeBSD Foundation MFC after: 1 week Approved by: re (delphij) Modified: head/sys/fs/nfsclient/nfs_clvnops.c Modified: head/sys/fs/nfsclient/nfs_clvnops.c ============================================================================== --- head/sys/fs/nfsclient/nfs_clvnops.c Sun Jun 19 07:31:02 2016 (r302018) +++ head/sys/fs/nfsclient/nfs_clvnops.c Sun Jun 19 18:29:43 2016 (r302019) @@ -3097,10 +3097,14 @@ nfs_advlock(struct vop_advlock_args *ap) } } if (error == 0 && ap->a_op == F_SETLK) { - /* Mark that a file lock has been acquired. */ - mtx_lock(&np->n_mtx); - np->n_flag |= NHASBEENLOCKED; - mtx_unlock(&np->n_mtx); + error = NFSVOPLOCK(vp, LK_SHARED); + if (error == 0) { + /* Mark that a file lock has been acquired. */ + mtx_lock(&np->n_mtx); + np->n_flag |= NHASBEENLOCKED; + mtx_unlock(&np->n_mtx); + NFSVOPUNLOCK(vp, 0); + } } } return (error); From owner-svn-src-head@freebsd.org Sun Jun 19 18:32:37 2016 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 28C6CA7AC21; Sun, 19 Jun 2016 18:32:37 +0000 (UTC) (envelope-from kib@FreeBSD.org) Received: from repo.freebsd.org (repo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id D44591633; Sun, 19 Jun 2016 18:32:36 +0000 (UTC) (envelope-from kib@FreeBSD.org) Received: from repo.freebsd.org ([127.0.1.37]) by repo.freebsd.org (8.15.2/8.15.2) with ESMTP id u5JIWaSI011044; Sun, 19 Jun 2016 18:32:36 GMT (envelope-from kib@FreeBSD.org) Received: (from kib@localhost) by repo.freebsd.org (8.15.2/8.15.2/Submit) id u5JIWaNa011043; Sun, 19 Jun 2016 18:32:36 GMT (envelope-from kib@FreeBSD.org) Message-Id: <201606191832.u5JIWaNa011043@repo.freebsd.org> X-Authentication-Warning: repo.freebsd.org: kib set sender to kib@FreeBSD.org using -f From: Konstantin Belousov Date: Sun, 19 Jun 2016 18:32:36 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r302020 - head/sys/nlm X-SVN-Group: head MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 19 Jun 2016 18:32:37 -0000 Author: kib Date: Sun Jun 19 18:32:35 2016 New Revision: 302020 URL: https://svnweb.freebsd.org/changeset/base/302020 Log: Remote and local adv lock servers might de-synchronize (the added comment explains the plausible scenario), resulting in EDEADLK returned on the local registration attempt. Handle this by re-trying the local op [1]. On unmount, local registration abort is indicated as EINTR, abort the nlm call as well. Reported and tested by: pho Suggested and reviewed by: dfr (previous version, [1]) Sponsored by: The FreeBSD Foundation MFC after: 1 week Approved by: re (delphij) Modified: head/sys/nlm/nlm_advlock.c Modified: head/sys/nlm/nlm_advlock.c ============================================================================== --- head/sys/nlm/nlm_advlock.c Sun Jun 19 18:29:43 2016 (r302019) +++ head/sys/nlm/nlm_advlock.c Sun Jun 19 18:32:35 2016 (r302020) @@ -713,7 +713,37 @@ nlm_record_lock(struct vnode *vp, int op newfl.l_pid = svid; newfl.l_sysid = NLM_SYSID_CLIENT | sysid; - error = lf_advlockasync(&a, &vp->v_lockf, size); + for (;;) { + error = lf_advlockasync(&a, &vp->v_lockf, size); + if (error == EDEADLK) { + /* + * Locks are associated with the processes and + * not with threads. Suppose we have two + * threads A1 A2 in one process, A1 locked + * file f1, A2 is locking file f2, and A1 is + * unlocking f1. Then remote server may + * already unlocked f1, while local still not + * yet scheduled A1 to make the call to local + * advlock manager. The process B owns lock on + * f2 and issued the lock on f1. Remote would + * grant B the request on f1, but local would + * return EDEADLK. + */ + pause("nlmdlk", 1); + /* XXXKIB allow suspend */ + } else if (error == EINTR) { + /* + * lf_purgelocks() might wake up the lock + * waiter and removed our lock graph edges. + * There is no sense in re-trying recording + * the lock to the local manager after + * reclaim. + */ + error = 0; + break; + } else + break; + } KASSERT(error == 0 || error == ENOENT, ("Failed to register NFS lock locally - error=%d", error)); } From owner-svn-src-head@freebsd.org Sun Jun 19 19:02:33 2016 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 1C870A7A1E5 for ; Sun, 19 Jun 2016 19:02:33 +0000 (UTC) (envelope-from mailing-machine@vniz.net) Received: from mail-lf0-f41.google.com (mail-lf0-f41.google.com [209.85.215.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 9AFB113CF for ; Sun, 19 Jun 2016 19:02:32 +0000 (UTC) (envelope-from mailing-machine@vniz.net) Received: by mail-lf0-f41.google.com with SMTP id q132so25624527lfe.3 for ; Sun, 19 Jun 2016 12:02:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to; bh=q9sFnyRXmn8bT45xEDKzMeBH5XWcvcyHDwHRrdF5aek=; b=NvQrwglwtlPzn37EYyfR5KAEiwLf+Qz5RK52zYcT9mkSPifq8hcm0gkCcOjyHyrDqF swth7HThymrUzlGSSJa/Y34jQGLKBYoCB8GQxKZHaicrG0AvjzZO7RGAP8NT2otDcxfl nQnyqSAIArdRmABTurOPLN5Pmqf4miMRveSjsvNq8CFRe50YKubTVzSDjxRTSBr/bf+4 f/W4CnVCfJyihtmnnW3H5jZei8CsI3l88WclfZDu5oXcmCkyrhQ2WfYZyDgQJlfgvN3N AYaQ804P4FYdlfO6ZRDVp1aDEuEAX3/sdyBW4a1xcNhROo6/zdzrDKbUNcQF+I67k0Am sESg== X-Gm-Message-State: ALyK8tIl3NBlxKnMNqyHcMJfvXaKv+zhTZ0JybCAnSE3UKyv2yq/IQHxrBXNXYh3Jncdkg== X-Received: by 10.25.19.204 with SMTP id 73mr2471353lft.24.1466362948822; Sun, 19 Jun 2016 12:02:28 -0700 (PDT) Received: from [192.168.1.2] ([89.169.173.68]) by smtp.gmail.com with ESMTPSA id a7sm1066229lbg.31.2016.06.19.12.02.27 (version=TLSv1/SSLv3 cipher=OTHER); Sun, 19 Jun 2016 12:02:28 -0700 (PDT) Subject: Re: svn commit: r302016 - in head: share/timedef tools/tools/locale/tools To: Baptiste Daroussin References: <201606190344.u5J3iWO6079652@repo.freebsd.org> <3387744f-7abd-417c-599f-163e78b4170e@freebsd.org> <20160619145233.kjnfyxjb75fdcucz@ivaldir.etoilebsd.net> <20160619154918.etycha7kvj4v7nrp@ivaldir.etoilebsd.net> <77076d87-41ad-0cce-c703-ed9cef1bdb8b@freebsd.org> <20160619171021.7ps2te7wgoxfqznv@ivaldir.etoilebsd.net> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Hajimu UMEMOTO From: Andrey Chernov Message-ID: <1f579a9a-3aa4-e99b-f991-b42a1672a9b4@freebsd.org> Date: Sun, 19 Jun 2016 22:02:26 +0300 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.1.1 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="WoTE0oBWc3SakH7xS1VPsx0ukpJBp64nC" X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 19 Jun 2016 19:02:33 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --WoTE0oBWc3SakH7xS1VPsx0ukpJBp64nC Content-Type: multipart/mixed; boundary="1LAqo2a7sSKGut8OSAFBxCCJj96jGObXe" From: Andrey Chernov To: Baptiste Daroussin Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Hajimu UMEMOTO Message-ID: <1f579a9a-3aa4-e99b-f991-b42a1672a9b4@freebsd.org> Subject: Re: svn commit: r302016 - in head: share/timedef tools/tools/locale/tools References: <201606190344.u5J3iWO6079652@repo.freebsd.org> <3387744f-7abd-417c-599f-163e78b4170e@freebsd.org> <20160619145233.kjnfyxjb75fdcucz@ivaldir.etoilebsd.net> <20160619154918.etycha7kvj4v7nrp@ivaldir.etoilebsd.net> <77076d87-41ad-0cce-c703-ed9cef1bdb8b@freebsd.org> <20160619171021.7ps2te7wgoxfqznv@ivaldir.etoilebsd.net> In-Reply-To: --1LAqo2a7sSKGut8OSAFBxCCJj96jGObXe Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 19.06.2016 20:21, Andrey Chernov wrote: > On 19.06.2016 20:10, Baptiste Daroussin wrote: >> On Sun, Jun 19, 2016 at 08:05:30PM +0300, Andrey Chernov wrote: >>> On 19.06.2016 19:52, Andrey Chernov wrote: >>>> On 19.06.2016 19:47, Andrey Chernov wrote: >>>>> On 19.06.2016 18:49, Baptiste Daroussin wrote: >>>>>> On Sun, Jun 19, 2016 at 04:52:34PM +0200, Baptiste Daroussin wrote= : >>>>>>> On Sun, Jun 19, 2016 at 07:57:49AM +0300, Andrey Chernov wrote: >>>>>>>> On 19.06.2016 6:44, Hajimu UMEMOTO wrote: >>>>>>>>> Log: >>>>>>>>> - Prefer to use %d over %e where the day of the month should = be zero >>>>>>>>> filled. >>>>>>>>> - Since %e means the day of the month as well, regard %e as s= ame as %d >>>>>>>>> in md_order. >>>>>>>> >>>>>>>> Nonsense doubled formats in sr_*_RS locales and nonsense md_orde= r there too. >>>>>>> >>>>>>> Crap I'll dig into it, thanks for spotting it. >>>>>>> >>>>>>> Best regards, >>>>>>> Bapt >>>>>> >>>>>> Should be fixed by: >>>>>> https://people.freebsd.org/~bapt/locale-triple-components.diff >>>>>> >>>>>> The perl script generating the locales was badly handling locales = with 3 >>>>>> components, fixed now. >>>>>> >>>>>> Sorry about that >>>>>> >>>>>> Best regards, >>>>>> Bapt >>>>>> >>>>> >>>>> sr locales are badly named before anything else, proper format is >>>>> language[_COUNTRY][.encoding][@variant] >>>>> I.e. >>>>> sr_RS.UTF-8@Latn >>>>> sr_RS.ISO8859-2@Latn >>>>> sr_RS.ISO8859-t@Cyrl >>>>> >>>>> I don't know, if out utilities (f.e. locale(1)) can handle @variant= suffix. >>>>> >>>>> >>>> =3Dsr_RS.ISO8859-5@Cyrl >>>> =3Dour, and not utilities only but libc too >>> >>> Since right now we have only single @variant per each encoding, and n= o >>> @variant for other locales, we can just drop it and use right names l= ike: >>> sr_RS.UTF-8 >> >> We have 2 for the above the Cyrl version and the Latn version >> >>> sr_RS.ISO8859-2 >>> sr_RS.ISO8859-5 >> >> We can make aliases easily for that is that is what people want, not t= he we have >> the same for other locales: >> >> zh_Hans_CN.GB18030 >> zh_Hans_CN.GB2312 >> zh_Hans_CN.GBK >> zh_Hans_CN.UTF-8 >> zh_Hans_CN.eucCN >> zh_Hant_HK.UTF-8 >> zh_Hant_TW.Big5 >> zh_Hant_TW.UTF-8 >> >> With some aliases for some of the previously existing ones: >> zh_TW.Big5 >> zh_TW.UTF-8 >> zh_CN.GB18030 >> zh_CN.GB2312 >> zh_CN.GBK >> zh_CN.UTF-8 >> zh_CN.eucCN >> zh_HK.UTF-8 >> >> Some of the new locales (that didn't exist before) I have only importe= d the new >> name format: >> kk_Cyrl_KZ.UTF-8 >> mn_Cyrl_MN.UTF-8 >> sr_Cyrl_RS.ISO8859-5 >> sr_Cyrl_RS.UTF-8 >> sr_Latn_RS.ISO8859-2 >> sr_Latn_RS.UTF-8 >> >> I would prefer staying on the new syntax given it is allowed by some R= FC and it >> is slowly being adopted everywhere else. >> >> Btw another RFC: https://www.ietf.org/rfc/rfc5646.txt >> >> Best regards, >> Bapt >> >=20 > Old POSIX don't use RFC 5646, there are ISO-639 two-letter codes. When > encodings are different, there is no needs to specify vari