From owner-svn-src-user@freebsd.org Tue Mar 1 00:45:13 2016 Return-Path: Delivered-To: svn-src-user@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id A1E41AB8860 for ; Tue, 1 Mar 2016 00:45:13 +0000 (UTC) (envelope-from jgh@FreeBSD.org) Received: from repo.freebsd.org (repo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 7B057F26; Tue, 1 Mar 2016 00:45:13 +0000 (UTC) (envelope-from jgh@FreeBSD.org) Received: from repo.freebsd.org ([127.0.1.37]) by repo.freebsd.org (8.15.2/8.15.2) with ESMTP id u210jCD2058020; Tue, 1 Mar 2016 00:45:12 GMT (envelope-from jgh@FreeBSD.org) Received: (from jgh@localhost) by repo.freebsd.org (8.15.2/8.15.2/Submit) id u210jCxw058018; Tue, 1 Mar 2016 00:45:12 GMT (envelope-from jgh@FreeBSD.org) Message-Id: <201603010045.u210jCxw058018@repo.freebsd.org> X-Authentication-Warning: repo.freebsd.org: jgh set sender to jgh@FreeBSD.org using -f From: Jason Helfman Date: Tue, 1 Mar 2016 00:45:12 +0000 (UTC) To: src-committers@freebsd.org, svn-src-user@freebsd.org Subject: svn commit: r296244 - user/jgh/committers-guide X-SVN-Group: user MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-user@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the experimental " user" src tree" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 Mar 2016 00:45:13 -0000 Author: jgh (doc,ports committer) Date: Tue Mar 1 00:45:12 2016 New Revision: 296244 URL: https://svnweb.freebsd.org/changeset/base/296244 Log: - wip adding phabricator to committers guide Modified: user/jgh/committers-guide/Makefile user/jgh/committers-guide/article.xml Modified: user/jgh/committers-guide/Makefile ============================================================================== --- user/jgh/committers-guide/Makefile Tue Mar 1 00:33:32 2016 (r296243) +++ user/jgh/committers-guide/Makefile Tue Mar 1 00:45:12 2016 (r296244) @@ -16,8 +16,10 @@ SRCS= article.xml IMAGES_LIB= callouts/1.png IMAGES_LIB+= callouts/2.png IMAGES_LIB+= callouts/3.png +IMAGES_LIB+= callouts/4.png +IMAGES_LIB+= callouts/5.png URL_RELPREFIX?= ../../../.. -DOC_PREFIX?= ${.CURDIR}/../../.. +DOC_PREFIX?= ${.CURDIR}/../../../doc .include "${DOC_PREFIX}/share/mk/doc.project.mk" Modified: user/jgh/committers-guide/article.xml ============================================================================== --- user/jgh/committers-guide/article.xml Tue Mar 1 00:33:32 2016 (r296243) +++ user/jgh/committers-guide/article.xml Tue Mar 1 00:45:12 2016 (r296244) @@ -33,6 +33,7 @@ 2013 2014 2015 + 2016 The &os; Documentation Project @@ -2433,7 +2434,30 @@ freebsd-mfc-after = 2 weeksWhen the mentor decides that a mentee has learned the ropes and is ready to commit on their own, the mentor announces it with a commit to - mentors. + conf/mentors. This file is in the + svnadmin branch of each + repository: + + + + + + src + base/svnadmin/conf/mentors + + + + doc + doc/svnadmin/conf/mentors + + + + ports + ports/svnadmin/conf/mentors + + + + @@ -2924,15 +2948,176 @@ Relnotes: yes - + Phabricator - The &os; Project utilizes Phabricator - for code review requests. See the CodeReview - wiki page for details. + Phabricator is an online service that provides pre-commit + code review workflows. Revisions are created in Phabricator + with a command-line tool, reviewed by developers and committed + once changes have been accepted. + + This section describes how to use Phabricator in the context + of &os; source and ports trees by using the service hosted at + + https://reviews.freebsd.org/ + + + Setup + + Before being able to create revisions for code review, + an account is required. Additionally, command-line client + tools need to be installed. + + + + + Create an account by visiting Phabricator + Registration. Please use a &os; email address + when registrating so Phabricator admins can track who + you are. + + + + Install the client package. + + &prompt.root; pkg install php5-arcanist + + + + Setup the client resource configuration file + ~/.arcrc with the certificates + required to access the online service. This process + requires manually copy/pasting a cookie provided by the + online service. Do this by typing the command below and + following the online instructions. + + &prompt.root; arc install-certificate https://reviews.freebsd.org + + After completion, configure Arcanist to use https://reviews.freebsd.org + as the default URI: + + &prompt.root; arc set-config default https://reviews.freebsd.org/ + + + + + + Create a Revision + + Once you have finished preparing a change locally, you + are ready to send it out for review. + + Please make sure that your changeset does one thing + (and one thing only) so the review process goes smoothly. + Small and self-contained changes are much easier to + review! + + Phabricator has two groups of participants in a review: + Reviewers and Subscribers. Individuals and project groups + may be Reviewers, and at least one reviewer must accept a + revision for it to proceed. Subscribers are notified of a + revision and any changes, but are not required to accept a + revision. Subscribers may be individuals, project groups, + and mailing lists. + + + + + + From the top of the SVN or git tree, run the + following command to create a new revision for the given + paths: + + &prompt.user; arc diff --create /path/to/file + + + + Executing the previous step will open an editor with + the following template to fill in: + + +Replace this line with your Revision Title + +Summary: + +Test Plan: + +Reviewers: + +Subscribers: + +# NEW DIFFERENTIAL REVISION +# Describe the changes in this new revision. +# +# arc could not identify any existing revision in your working copy. +# If you intended to update an existing revision, use: +# +# $ arc diff --update revision + + Use these guidelines for filling in the template: + + + + + The Revision Title is + mandatory. This is a one line description of the + change. + + + + The Summary is optional. + However, this should contain verbatim content of the + commit message to be used when submitting the + change. + + + + The Test Plan is optional. + Describe how to test the patch and how the reviewer + may test it. If it is difficult to draft a plan, + please reconsider. + + + + The Reviewers is optional. + However, &os; committers that are expected to review + the patch may be listed here. If such committers have + accounts on Phabricator, they will automatically be + notified of your submission. Reviewers may be added + by their nickname: + + &prompt.user; arc diff --reviewers nick + + or by project: + + &prompt.user; arc diff --reviewers #portmgr + + + + Subscribers may be individuals, project groups, + and mailing lists. + + + + The Differential Revision cannot be added here, + however it must be in the svn commit message. + + + + + + After saving and exiting your editor, the changeset + will be creating in Phabricator and Arcanist will print + a tracking link for your revision: + + https://reviews.freebsd.org/DXXX + + + + From owner-svn-src-user@freebsd.org Tue Mar 1 00:54:08 2016 Return-Path: Delivered-To: svn-src-user@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id D9EDBAB8D44 for ; Tue, 1 Mar 2016 00:54:08 +0000 (UTC) (envelope-from jgh@FreeBSD.org) Received: from repo.freebsd.org (repo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 9A47F160A; Tue, 1 Mar 2016 00:54:08 +0000 (UTC) (envelope-from jgh@FreeBSD.org) Received: from repo.freebsd.org ([127.0.1.37]) by repo.freebsd.org (8.15.2/8.15.2) with ESMTP id u210s78m061258; Tue, 1 Mar 2016 00:54:07 GMT (envelope-from jgh@FreeBSD.org) Received: (from jgh@localhost) by repo.freebsd.org (8.15.2/8.15.2/Submit) id u210s7JI061256; Tue, 1 Mar 2016 00:54:07 GMT (envelope-from jgh@FreeBSD.org) Message-Id: <201603010054.u210s7JI061256@repo.freebsd.org> X-Authentication-Warning: repo.freebsd.org: jgh set sender to jgh@FreeBSD.org using -f From: Jason Helfman Date: Tue, 1 Mar 2016 00:54:07 +0000 (UTC) To: src-committers@freebsd.org, svn-src-user@freebsd.org Subject: svn commit: r296246 - user/jgh/committers-guide X-SVN-Group: user MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-user@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the experimental " user" src tree" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 Mar 2016 00:54:09 -0000 Author: jgh (doc,ports committer) Date: Tue Mar 1 00:54:07 2016 New Revision: 296246 URL: https://svnweb.freebsd.org/changeset/base/296246 Log: - markup cleanup Modified: user/jgh/committers-guide/Makefile user/jgh/committers-guide/article.xml Modified: user/jgh/committers-guide/Makefile ============================================================================== --- user/jgh/committers-guide/Makefile Tue Mar 1 00:50:39 2016 (r296245) +++ user/jgh/committers-guide/Makefile Tue Mar 1 00:54:07 2016 (r296246) @@ -18,8 +18,9 @@ IMAGES_LIB+= callouts/2.png IMAGES_LIB+= callouts/3.png IMAGES_LIB+= callouts/4.png IMAGES_LIB+= callouts/5.png +IMAGES_LIB+= callouts/6.png URL_RELPREFIX?= ../../../.. -DOC_PREFIX?= ${.CURDIR}/../../../doc +DOC_PREFIX?= ${.CURDIR}/../../.. .include "${DOC_PREFIX}/share/mk/doc.project.mk" Modified: user/jgh/committers-guide/article.xml ============================================================================== --- user/jgh/committers-guide/article.xml Tue Mar 1 00:50:39 2016 (r296245) +++ user/jgh/committers-guide/article.xml Tue Mar 1 00:54:07 2016 (r296246) @@ -3026,10 +3026,10 @@ Relnotes: yes - - From the top of the SVN or git tree, run the - following command to create a new revision for the given - paths: + + From the top of the SVN or git tree, run the + following command to create a new revision for the + given paths: &prompt.user; arc diff --create /path/to/file @@ -3038,8 +3038,7 @@ Relnotes: yes Executing the previous step will open an editor with the following template to fill in: - -Replace this line with your Revision Title + Replace this line with your Revision Title Summary: @@ -3055,8 +3054,8 @@ Subscribers: - - After saving and exiting your editor, the changeset - will be creating in Phabricator and Arcanist will print - a tracking link for your revision: + + After saving and exiting your editor, the changeset + will be creating in Phabricator and Arcanist will print + a tracking link for your revision: https://reviews.freebsd.org/DXXX From owner-svn-src-user@freebsd.org Tue Mar 1 01:04:54 2016 Return-Path: Delivered-To: svn-src-user@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id C0555AB9152 for ; Tue, 1 Mar 2016 01:04:54 +0000 (UTC) (envelope-from jgh@FreeBSD.org) Received: from repo.freebsd.org (repo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 7C75B1CEA; Tue, 1 Mar 2016 01:04:54 +0000 (UTC) (envelope-from jgh@FreeBSD.org) Received: from repo.freebsd.org ([127.0.1.37]) by repo.freebsd.org (8.15.2/8.15.2) with ESMTP id u2114rs2064408; Tue, 1 Mar 2016 01:04:53 GMT (envelope-from jgh@FreeBSD.org) Received: (from jgh@localhost) by repo.freebsd.org (8.15.2/8.15.2/Submit) id u2114rK2064407; Tue, 1 Mar 2016 01:04:53 GMT (envelope-from jgh@FreeBSD.org) Message-Id: <201603010104.u2114rK2064407@repo.freebsd.org> X-Authentication-Warning: repo.freebsd.org: jgh set sender to jgh@FreeBSD.org using -f From: Jason Helfman Date: Tue, 1 Mar 2016 01:04:53 +0000 (UTC) To: src-committers@freebsd.org, svn-src-user@freebsd.org Subject: svn commit: r296247 - user/jgh X-SVN-Group: user MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-user@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the experimental " user" src tree" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 Mar 2016 01:04:54 -0000 Author: jgh (doc,ports committer) Date: Tue Mar 1 01:04:53 2016 New Revision: 296247 URL: https://svnweb.freebsd.org/changeset/base/296247 Log: - this goes in doc tree Deleted: user/jgh/ From owner-svn-src-user@freebsd.org Fri Mar 4 18:17:55 2016 Return-Path: Delivered-To: svn-src-user@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 10DFFA093C0 for ; Fri, 4 Mar 2016 18:17:55 +0000 (UTC) (envelope-from glebius@FreeBSD.org) Received: from repo.freebsd.org (repo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id B876AAA7; Fri, 4 Mar 2016 18:17:54 +0000 (UTC) (envelope-from glebius@FreeBSD.org) Received: from repo.freebsd.org ([127.0.1.37]) by repo.freebsd.org (8.15.2/8.15.2) with ESMTP id u24IHrR1073886; Fri, 4 Mar 2016 18:17:53 GMT (envelope-from glebius@FreeBSD.org) Received: (from glebius@localhost) by repo.freebsd.org (8.15.2/8.15.2/Submit) id u24IHrqC073884; Fri, 4 Mar 2016 18:17:53 GMT (envelope-from glebius@FreeBSD.org) Message-Id: <201603041817.u24IHrqC073884@repo.freebsd.org> X-Authentication-Warning: repo.freebsd.org: glebius set sender to glebius@FreeBSD.org using -f From: Gleb Smirnoff Date: Fri, 4 Mar 2016 18:17:53 +0000 (UTC) To: src-committers@freebsd.org, svn-src-user@freebsd.org Subject: svn commit: r296390 - in user/cperciva/freebsd-update-build/scripts/10.3-RC1: . amd64 i386 X-SVN-Group: user MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-user@freebsd.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "SVN commit messages for the experimental " user" src tree" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Mar 2016 18:17:55 -0000 Author: glebius Date: Fri Mar 4 18:17:53 2016 New Revision: 296390 URL: https://svnweb.freebsd.org/changeset/base/296390 Log: Configuration for 10.3-RC1. Added: user/cperciva/freebsd-update-build/scripts/10.3-RC1/ - copied from r296389, user/cperciva/freebsd-update-build/scripts/10.3-BETA3/ Modified: user/cperciva/freebsd-update-build/scripts/10.3-RC1/amd64/build.conf user/cperciva/freebsd-update-build/scripts/10.3-RC1/i386/build.conf Modified: user/cperciva/freebsd-update-build/scripts/10.3-RC1/amd64/build.conf ============================================================================== --- user/cperciva/freebsd-update-build/scripts/10.3-BETA3/amd64/build.conf Fri Mar 4 17:42:59 2016 (r296389) +++ user/cperciva/freebsd-update-build/scripts/10.3-RC1/amd64/build.conf Fri Mar 4 18:17:53 2016 (r296390) @@ -1,5 +1,5 @@ -export RELH=953ec0d4a09045affaf31c9a84e2f25d895e8f3a26b2e1f503c61f270eabadf471d5742021bd8d97c027136a2f0623d0928bb295b7631334d706b6c9a411f60b -export FTP=https://people.freebsd.org/~marius/10.3-BETA3/ +export RELH=6c9fb0c0a2b8b0c35677402963fe400b0f2b70e916e24a2fd1f17257ba8d6e12f7cae70e9af32fab81e95bf04e4255c512e6f1b626cf6ab9cabe8c8df37dcc5e +export FTP=https://people.freebsd.org/~marius/10.3-RC1/ # Components of the world, source, and kernels export WORLDPARTS="base doc games lib32" @@ -7,4 +7,4 @@ export SOURCEPARTS="src" export KERNELPARTS="kernel" # EOL date -export EOL=1457136000 +export EOL=1459296000 Modified: user/cperciva/freebsd-update-build/scripts/10.3-RC1/i386/build.conf ============================================================================== --- user/cperciva/freebsd-update-build/scripts/10.3-BETA3/i386/build.conf Fri Mar 4 17:42:59 2016 (r296389) +++ user/cperciva/freebsd-update-build/scripts/10.3-RC1/i386/build.conf Fri Mar 4 18:17:53 2016 (r296390) @@ -1,5 +1,5 @@ -export RELH=6a32a343e65f4a7daf696b0b74b735f3691149258788821370374a933b3b00f9dc9495e76e8f6e39558e258c93dd0380b8f70a852864db61eca7fa2b694e4a92 -export FTP=https://people.freebsd.org/~marius/10.3-BETA3/ +export RELH=3e31d77d0d50f8a99ec4f41e0465ccdd12bb63039773d9658b754a35d58c0709fe696d40d6ba8aab2b5fd42cf31c69075c4bd00e8aa85a777bd41c01c6df0c49 +export FTP=https://people.freebsd.org/~marius/10.3-RC1/ # Components of the world, source, and kernels export WORLDPARTS="base doc games" @@ -7,4 +7,4 @@ export SOURCEPARTS="src" export KERNELPARTS="kernel" # EOL date -export EOL=1457136000 +export EOL=1459296000