From owner-freebsd-net@freebsd.org Sun Mar 5 02:14:50 2017 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id A25D6CF71CE for ; Sun, 5 Mar 2017 02:14:50 +0000 (UTC) (envelope-from freebsd@dukhovni.org) Received: from mournblade.imrryr.org (mournblade.imrryr.org [108.5.242.66]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 6923E14DA for ; Sun, 5 Mar 2017 02:14:49 +0000 (UTC) (envelope-from freebsd@dukhovni.org) Received: from [192.168.0.7] (cpe-67-241-70-168.twcny.res.rr.com [67.241.70.168]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mournblade.imrryr.org (Postfix) with ESMTPSA id BCCBC7A32D8 for ; Sun, 5 Mar 2017 02:05:36 +0000 (UTC) (envelope-from freebsd@dukhovni.org) From: Viktor Dukhovni Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Reply-To: freebsd-net@freebsd.org Mime-Version: 1.0 (Mac OS X Mail 10.2 \(3259\)) Subject: The 6to4 stf0 interface flapping in/out of tentative in FreeBSD 11.0-RELEASE-p8... Message-Id: Date: Sat, 4 Mar 2017 21:05:34 -0500 To: freebsd-net@freebsd.org X-Mailer: Apple Mail (2.3259) X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 05 Mar 2017 02:14:50 -0000 In trying to set up a 6to4 node under 11.0-RELEASE-p8, and the stf0 interface is constantly flipping in and out of "tentative" state, at seemingly 1 second intervals. Is that to be expected? Am I missing some non-obvious configuration setting? $ ifconfig stf0; echo; for i in $(seq 10); do ifconfig stf0 | grep = inet; sleep 1; done stf0: flags=3D1 metric 0 mtu 1280 inet6 2002:6c15:5974:1::1 prefixlen 16 nd6 options=3D101 groups: stf inet6 2002:6c15:5974:1::1 prefixlen 16 tentative inet6 2002:6c15:5974:1::1 prefixlen 16 inet6 2002:6c15:5974:1::1 prefixlen 16 tentative inet6 2002:6c15:5974:1::1 prefixlen 16 inet6 2002:6c15:5974:1::1 prefixlen 16 tentative inet6 2002:6c15:5974:1::1 prefixlen 16 inet6 2002:6c15:5974:1::1 prefixlen 16 tentative inet6 2002:6c15:5974:1::1 prefixlen 16 inet6 2002:6c15:5974:1::1 prefixlen 16 tentative inet6 2002:6c15:5974:1::1 prefixlen 16 My configuration is (slightly trimmed): $ ifconfig igb0 igb0: flags=3D8843 metric 0 = mtu 1500 = options=3D6403bb inet 108.21.89.116 netmask 0xffffff00 broadcast 108.21.89.255=20 inet6 2002:6c15:5974::1 prefixlen 64=20 nd6 options=3D21 status: active $ netstat -6rn ... default 2002:c058:6301:: UGS = stf0 2002::/16 link#4 U = stf0 2002:6c15:5974::/64 link#1 U = igb0 2002:6c15:5974::1 link#1 UHS = lo0 2002:6c15:5974:1::1 link#4 UHS = lo0 In /etc/rc.conf I have: stf_interface_ipv4addr=3D"108.21.89.116" stf_interface_ipv6_slaid=3D1 ifconfig_igb0_ipv6=3D"inet6 2002:6c15:5974::1 prefixlen 64" ipv6_gateway_enable=3D"YES" ipv6_defaultrouter=3D"2002:c058:6301::" ipv6_network_interfaces=3D"igb0" rtadvd_enable=3D"YES" rtadvd_interfaces=3D"igb0" Other than a slightly higher than desired packet loss rate (perhaps to = be expected with 6to4 tunnels), this does not seem to impact connectivity: $ ping6 -c 20 -n mx01.domeneshop.no PING6(56=3D40+8+8 bytes) 2002:6c15:5974:1::1 --> 2a01:5b40:0:2201::1 16 bytes from 2a01:5b40:0:2201::1, icmp_seq=3D0 hlim=3D55 time=3D105.615 = ms 16 bytes from 2a01:5b40:0:2201::1, icmp_seq=3D1 hlim=3D55 time=3D104.798 = ms 16 bytes from 2a01:5b40:0:2201::1, icmp_seq=3D2 hlim=3D55 time=3D105.384 = ms 16 bytes from 2a01:5b40:0:2201::1, icmp_seq=3D3 hlim=3D55 time=3D104.726 = ms 16 bytes from 2a01:5b40:0:2201::1, icmp_seq=3D4 hlim=3D55 time=3D105.361 = ms 16 bytes from 2a01:5b40:0:2201::1, icmp_seq=3D5 hlim=3D55 time=3D104.387 = ms 16 bytes from 2a01:5b40:0:2201::1, icmp_seq=3D6 hlim=3D55 time=3D104.730 = ms 16 bytes from 2a01:5b40:0:2201::1, icmp_seq=3D7 hlim=3D55 time=3D104.712 = ms 16 bytes from 2a01:5b40:0:2201::1, icmp_seq=3D8 hlim=3D55 time=3D104.951 = ms 16 bytes from 2a01:5b40:0:2201::1, icmp_seq=3D9 hlim=3D55 time=3D104.697 = ms 16 bytes from 2a01:5b40:0:2201::1, icmp_seq=3D10 hlim=3D55 time=3D104.718 = ms 16 bytes from 2a01:5b40:0:2201::1, icmp_seq=3D11 hlim=3D55 time=3D104.511 = ms 16 bytes from 2a01:5b40:0:2201::1, icmp_seq=3D12 hlim=3D55 time=3D105.174 = ms 16 bytes from 2a01:5b40:0:2201::1, icmp_seq=3D13 hlim=3D55 time=3D104.760 = ms 16 bytes from 2a01:5b40:0:2201::1, icmp_seq=3D14 hlim=3D55 time=3D105.056 = ms 16 bytes from 2a01:5b40:0:2201::1, icmp_seq=3D15 hlim=3D55 time=3D104.860 = ms 16 bytes from 2a01:5b40:0:2201::1, icmp_seq=3D16 hlim=3D55 time=3D104.716 = ms 16 bytes from 2a01:5b40:0:2201::1, icmp_seq=3D17 hlim=3D55 time=3D104.669 = ms 16 bytes from 2a01:5b40:0:2201::1, icmp_seq=3D18 hlim=3D55 time=3D105.137 = ms 16 bytes from 2a01:5b40:0:2201::1, icmp_seq=3D19 hlim=3D55 time=3D105.043 = ms I mostly the 100% sucsess also with www.google.com, but now and then a few pings are lost: $ ping6 www.google.com PING6(56=3D40+8+8 bytes) 2002:6c15:5974::1 --> 2607:f8b0:400d:c00::6a 16 bytes from 2607:f8b0:400d:c00::6a, icmp_seq=3D0 hlim=3D57 time=3D16.488= ms 16 bytes from 2607:f8b0:400d:c00::6a, icmp_seq=3D1 hlim=3D57 time=3D16.332= ms 16 bytes from 2607:f8b0:400d:c00::6a, icmp_seq=3D2 hlim=3D57 time=3D16.621= ms 16 bytes from 2607:f8b0:400d:c00::6a, icmp_seq=3D3 hlim=3D57 time=3D16.645= ms 16 bytes from 2607:f8b0:400d:c00::6a, icmp_seq=3D4 hlim=3D57 time=3D17.336= ms 16 bytes from 2607:f8b0:400d:c00::6a, icmp_seq=3D5 hlim=3D57 time=3D15.978= ms 16 bytes from 2607:f8b0:400d:c00::6a, icmp_seq=3D6 hlim=3D57 time=3D17.073= ms 16 bytes from 2607:f8b0:400d:c00::6a, icmp_seq=3D7 hlim=3D57 time=3D52.323= ms 16 bytes from 2607:f8b0:400d:c00::6a, icmp_seq=3D8 hlim=3D57 time=3D35.891= ms 16 bytes from 2607:f8b0:400d:c00::6a, icmp_seq=3D9 hlim=3D57 time=3D38.653= ms 16 bytes from 2607:f8b0:400d:c00::6a, icmp_seq=3D10 hlim=3D57 = time=3D45.235 ms 16 bytes from 2607:f8b0:400d:c00::6a, icmp_seq=3D11 hlim=3D57 = time=3D25.149 ms 16 bytes from 2607:f8b0:400d:c00::6a, icmp_seq=3D12 hlim=3D57 = time=3D16.357 ms 16 bytes from 2607:f8b0:400d:c00::6a, icmp_seq=3D14 hlim=3D57 = time=3D16.719 ms 16 bytes from 2607:f8b0:400d:c00::6a, icmp_seq=3D16 hlim=3D57 = time=3D17.122 ms 16 bytes from 2607:f8b0:400d:c00::6a, icmp_seq=3D17 hlim=3D57 = time=3D16.963 ms 16 bytes from 2607:f8b0:400d:c00::6a, icmp_seq=3D18 hlim=3D57 = time=3D16.130 ms 16 bytes from 2607:f8b0:400d:c00::6a, icmp_seq=3D19 hlim=3D57 = time=3D23.763 ms 16 bytes from 2607:f8b0:400d:c00::6a, icmp_seq=3D20 hlim=3D57 = time=3D16.295 ms 16 bytes from 2607:f8b0:400d:c00::6a, icmp_seq=3D21 hlim=3D57 = time=3D18.302 ms 16 bytes from 2607:f8b0:400d:c00::6a, icmp_seq=3D22 hlim=3D57 = time=3D16.994 ms 16 bytes from 2607:f8b0:400d:c00::6a, icmp_seq=3D23 hlim=3D57 = time=3D18.312 ms 16 bytes from 2607:f8b0:400d:c00::6a, icmp_seq=3D24 hlim=3D57 = time=3D16.419 ms 16 bytes from 2607:f8b0:400d:c00::6a, icmp_seq=3D25 hlim=3D57 = time=3D17.241 ms 16 bytes from 2607:f8b0:400d:c00::6a, icmp_seq=3D26 hlim=3D57 = time=3D17.931 ms 16 bytes from 2607:f8b0:400d:c00::6a, icmp_seq=3D27 hlim=3D57 = time=3D17.478 ms 16 bytes from 2607:f8b0:400d:c00::6a, icmp_seq=3D28 hlim=3D57 = time=3D17.514 ms 16 bytes from 2607:f8b0:400d:c00::6a, icmp_seq=3D29 hlim=3D57 = time=3D17.684 ms --- www.google.com ping6 statistics --- 31 packets transmitted, 28 packets received, 9.7% packet loss Possibly relevant sysctl output: $ sysctl -a | grep ip6 net.inet6.ip6.forwarding: 1 net.inet6.ip6.redirect: 1 net.inet6.ip6.hlim: 64 net.inet6.ip6.maxfragpackets: 1017650 net.inet6.ip6.accept_rtadv: 0 net.inet6.ip6.log_interval: 5 net.inet6.ip6.hdrnestlimit: 15 net.inet6.ip6.dad_count: 1 net.inet6.ip6.auto_flowlabel: 1 net.inet6.ip6.defmcasthlim: 1 net.inet6.ip6.gifhlim: 30 net.inet6.ip6.kame_version: FreeBSD net.inet6.ip6.use_deprecated: 1 net.inet6.ip6.rr_prune: 5 net.inet6.ip6.v6only: 1 net.inet6.ip6.use_tempaddr: 0 net.inet6.ip6.temppltime: 86400 net.inet6.ip6.tempvltime: 604800 net.inet6.ip6.auto_linklocal: 1 net.inet6.ip6.prefer_tempaddr: 0 net.inet6.ip6.use_defaultzone: 0 net.inet6.ip6.maxfrags: 1017650 net.inet6.ip6.mcast_pmtu: 0 net.inet6.ip6.no_radr: 0 net.inet6.ip6.norbit_raif: 0 net.inet6.ip6.rfc6204w3: 0 net.inet6.ip6.deembed_scopeid: 1 net.inet6.ip6.dad_enhanced: 0 net.inet6.ip6.mcast.loop: 1 net.inet6.ip6.mcast.maxsocksrc: 128 net.inet6.ip6.mcast.maxgrpsrc: 512 security.jail.param.ip6.saddrsel: 0 security.jail.param.ip6.: 0 --=20 Viktor. From owner-freebsd-net@freebsd.org Sun Mar 5 04:45:33 2017 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 2913ECF8C3B for ; Sun, 5 Mar 2017 04:45:33 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 18CAA10FF for ; Sun, 5 Mar 2017 04:45:33 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id v254jWN2025080 for ; Sun, 5 Mar 2017 04:45:32 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-net@FreeBSD.org Subject: [Bug 217509] [patch] netinet/netinet6: missing curly braces in inm_merge/in6m_merge Date: Sun, 05 Mar 2017 04:45:33 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: patch X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: ngie@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-net@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 05 Mar 2017 04:45:33 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D217509 --- Comment #2 from Ngie Cooper --- (In reply to Andrey V. Elsukov from comment #1) Ok. Is the proposed message accurate, or could it be improved (I wrote it up based on a quick glance at the code -- it might not be accurate). Thanks! --=20 You are receiving this mail because: You are the assignee for the bug.= From owner-freebsd-net@freebsd.org Sun Mar 5 05:03:49 2017 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id B8F79CFA34C for ; Sun, 5 Mar 2017 05:03:49 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id A87F71C2A for ; Sun, 5 Mar 2017 05:03:49 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id v2553nmW085745 for ; Sun, 5 Mar 2017 05:03:49 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-net@FreeBSD.org Subject: [Bug 216460] 82599ES 10-Gigabit SFI/SFP+ Network Connection link constantly flaps Date: Sun, 05 Mar 2017 05:03:49 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 11.0-RELEASE X-Bugzilla-Keywords: IntelNetworking X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: kbowling@freebsd.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-net@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: cc Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 05 Mar 2017 05:03:49 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D216460 Kevin Bowling changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kbowling@freebsd.org --- Comment #1 from Kevin Bowling --- I ran into a similar issue in 2014 and wasn't able to solve it, I ended up switching to Chelsio NICs. If you can build a kernel it would be interesting to have you test this tho= ugh: https://github.com/mattmacy/networking/tree/HEAD_MERGE/iflib-ixgbe-current --=20 You are receiving this mail because: You are the assignee for the bug.= From owner-freebsd-net@freebsd.org Sun Mar 5 21:01:03 2017 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 006A3CFA7C8 for ; Sun, 5 Mar 2017 21:01:03 +0000 (UTC) (envelope-from bugzilla-noreply@FreeBSD.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id E9BEF1924 for ; Sun, 5 Mar 2017 21:01:02 +0000 (UTC) (envelope-from bugzilla-noreply@FreeBSD.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id v25L01MC038950 for ; Sun, 5 Mar 2017 21:01:02 GMT (envelope-from bugzilla-noreply@FreeBSD.org) Message-Id: <201703052101.v25L01MC038950@kenobi.freebsd.org> From: bugzilla-noreply@FreeBSD.org To: freebsd-net@FreeBSD.org Subject: Problem reports for freebsd-net@FreeBSD.org that need special attention Date: Sun, 05 Mar 2017 21:01:02 +0000 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 05 Mar 2017 21:01:03 -0000 To view an individual PR, use: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=(Bug Id). The following is a listing of current problems submitted by FreeBSD users, which need special attention. These represent problem reports covering all versions including experimental development code and obsolete releases. Status | Bug Id | Description ------------+-----------+--------------------------------------------------- In Progress | 165622 | [ndis][panic][patch] Unregistered use of FPU in k In Progress | 203422 | mpd/ppoe not working with re(4) with revision 285 In Progress | 206581 | bxe_ioctl_nvram handler is faulty New | 204438 | setsockopt() handling of kern.ipc.maxsockbuf limi New | 205592 | TCP processing in IPSec causes kernel panic New | 206053 | kqueue support code of netmap causes panic New | 213410 | [carp] service netif restart causes hang only whe New | 215874 | [patch] [icmp] [mbuf_tags] teach icmp_error() opt Open | 148807 | [panic] "panic: sbdrop" and "panic: sbsndptr: soc Open | 193452 | Dell PowerEdge 210 II -- Kernel panic bce (broadc Open | 194485 | Userland cannot add IPv6 prefix routes Open | 194515 | Fatal Trap 12 Kernel with vimage Open | 199136 | [if_tap] Added down_on_close sysctl variable to t Open | 202510 | [CARP] advertisements sourced from CARP IP cause Open | 206544 | sendmsg(2) (sendto(2) too?) can fail with EINVAL; Open | 211031 | [panic] in ng_uncallout when argument is NULL Open | 211962 | bxe driver queue soft hangs and flooding tx_soft_ Open | 212018 | Enable IPSEC_NAT_T in GENERIC kernel configuratio Open | 213257 | Crash in IGB driver with ALTQ 19 problems total for which you should take action. From owner-freebsd-net@freebsd.org Mon Mar 6 05:10:41 2017 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 71227CFA1C9 for ; Mon, 6 Mar 2017 05:10:41 +0000 (UTC) (envelope-from daemon-user@freebsd.org) Received: from reviews.nyi.freebsd.org (reviews.nyi.freebsd.org [IPv6:2610:1c1:1:607c::16:b]) by mx1.freebsd.org (Postfix) with ESMTP id 3468F1753 for ; Mon, 6 Mar 2017 05:10:41 +0000 (UTC) (envelope-from daemon-user@freebsd.org) Received: by reviews.nyi.freebsd.org (Postfix, from userid 1346) id 3ED331B91B; Mon, 6 Mar 2017 05:10:40 +0000 (UTC) Date: Mon, 6 Mar 2017 05:10:40 +0000 To: freebsd-net@freebsd.org From: "jhujhiti_adjectivism.org (Erick Turnquist)" Reply-to: D9451+325+eaa6f8a0c0731bfe@reviews.freebsd.org Subject: [Differential] D9451: Constrain IPv6 interface routes to each FIB Message-ID: X-Priority: 3 X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: , , Thread-Topic: D9451: Constrain IPv6 interface routes to each FIB X-Herald-Rules: <28>, <81>, <51> X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: Precedence: bulk In-Reply-To: References: Thread-Index: MzA4MmVhNjA3MDYxYjk1ZGE4NzFjZWJhMzgyIFi871A= MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="b1_af28b28da6507256460ae036304910f5" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.23 List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 06 Mar 2017 05:10:41 -0000 --b1_af28b28da6507256460ae036304910f5 Content-Type: text/plain; charset = "utf-8" Content-Transfer-Encoding: base64 amh1amhpdGlfYWRqZWN0aXZpc20ub3JnIHVwZGF0ZWQgdGhpcyByZXZpc2lvbiB0byBEaWZmIDI2 MDIyLgpqaHVqaGl0aV9hZGplY3RpdmlzbS5vcmcgbWFya2VkIGFuIGlubGluZSBjb21tZW50IGFz IGRvbmUuCgpSRVBPU0lUT1JZCiAgclMgRnJlZUJTRCBzcmMgcmVwb3NpdG9yeQoKQ0hBTkdFUyBT SU5DRSBMQVNUIFVQREFURQogIGh0dHBzOi8vcmV2aWV3cy5mcmVlYnNkLm9yZy9EOTQ1MT92cz0y NTUxMiZpZD0yNjAyMgoKUkVWSVNJT04gREVUQUlMCiAgaHR0cHM6Ly9yZXZpZXdzLmZyZWVic2Qu b3JnL0Q5NDUxCgpBRkZFQ1RFRCBGSUxFUwogIHN5cy9uZXRpbmV0Ni9pY21wNi5jCiAgc3lzL25l dGluZXQ2L2luNi5jCiAgc3lzL25ldGluZXQ2L2luNl9zcmMuYwogIHN5cy9uZXRpbmV0Ni9uZDYu YwogIHN5cy9uZXRpbmV0Ni9uZDYuaAogIHN5cy9uZXRpbmV0Ni9uZDZfbmJyLmMKICBzeXMvbmV0 aW5ldDYvbmQ2X3J0ci5jCiAgdGVzdHMvc3lzL25ldGluZXQvZmlic190ZXN0LnNoCgpFTUFJTCBQ UkVGRVJFTkNFUwogIGh0dHBzOi8vcmV2aWV3cy5mcmVlYnNkLm9yZy9zZXR0aW5ncy9wYW5lbC9l bWFpbHByZWZlcmVuY2VzLwoKVG86IGpodWpoaXRpX2FkamVjdGl2aXNtLm9yZywgI25ldHdvcmss IGJ6LCBhc29tZXJzCkNjOiBqY2gsIGJ6LCBpbXAsIGFlLCBmcmVlYnNkLW5ldC1saXN0Cg== --b1_af28b28da6507256460ae036304910f5 Content-Type: text/x-patch; charset=utf-8; name="D9451.26022.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="D9451.26022.patch" ZGlmZiAtLWdpdCBhL3Rlc3RzL3N5cy9uZXRpbmV0L2ZpYnNfdGVzdC5zaCBiL3Rlc3RzL3N5cy9u ZXRpbmV0L2ZpYnNfdGVzdC5zaAotLS0gYS90ZXN0cy9zeXMvbmV0aW5ldC9maWJzX3Rlc3Quc2gK KysrIGIvdGVzdHMvc3lzL25ldGluZXQvZmlic190ZXN0LnNoCkBAIC00NTksOCArNDU5LDYgQEAK IAlTVUJORVQ9IjIwMDE6ZGI4OiIKIAlNQVNLPSI2NCIKIAotCWF0Zl9leHBlY3RfZmFpbCAiUFIx OTYzNjEgSVB2NiBuZXR3b3JrIHJvdXRlcyBkb24ndCByZXNwZWN0IG5ldC5hZGRfYWRkcl9hbGxm aWJzPTAiCi0KIAkjIENoZWNrIHN5c3RlbSBjb25maWd1cmF0aW9uCiAJaWYgWyAwICE9IGBzeXNj dGwgLW4gbmV0LmFkZF9hZGRyX2FsbGZpYnNgIF07IHRoZW4KIAkJYXRmX3NraXAgIlRoaXMgdGVz dCByZXF1aXJlcyBuZXQuYWRkX2FkZHJfYWxsZmlicz0wIgpkaWZmIC0tZ2l0IGEvc3lzL25ldGlu ZXQ2L25kNl9ydHIuYyBiL3N5cy9uZXRpbmV0Ni9uZDZfcnRyLmMKLS0tIGEvc3lzL25ldGluZXQ2 L25kNl9ydHIuYworKysgYi9zeXMvbmV0aW5ldDYvbmQ2X3J0ci5jCkBAIC01MDAsNyArNTAwLDcg QEAKIAogCWVycm9yID0gaW42X3J0cmVxdWVzdChSVE1fQURELCAoc3RydWN0IHNvY2thZGRyICop JmRlZiwKIAkgICAgKHN0cnVjdCBzb2NrYWRkciAqKSZnYXRlLCAoc3RydWN0IHNvY2thZGRyICop Jm1hc2ssCi0JICAgIFJURl9HQVRFV0FZLCAmbmV3cnQsIFJUX0RFRkFVTFRfRklCKTsKKwkgICAg UlRGX0dBVEVXQVksICZuZXdydCwgbmV3LT5pZnAtPmlmX2ZpYik7CiAJaWYgKG5ld3J0KSB7CiAJ CW5kNl9ydG1zZyhSVE1fQURELCBuZXdydCk7IC8qIHRlbGwgdXNlciBwcm9jZXNzICovCiAJCVJU RlJFRShuZXdydCk7CkBAIC01NTEsOCArNTUxLDggQEAKIAogLyoKICAqIFJlbW92ZSB0aGUgZGVm YXVsdCByb3V0ZSBmb3IgYSBnaXZlbiByb3V0ZXIuCi0gKiBUaGlzIGlzIGp1c3QgYSBzdWJyb3V0 aW5lIGZ1bmN0aW9uIGZvciBkZWZyb3V0ZXJfc2VsZWN0KCksIGFuZCBzaG91bGQKLSAqIG5vdCBi ZSBjYWxsZWQgZnJvbSBhbnl3aGVyZSBlbHNlLgorICogVGhpcyBpcyBqdXN0IGEgc3Vicm91dGlu ZSBmdW5jdGlvbiBmb3IgZGVmcm91dGVyX3NlbGVjdF9maWIoKSwgYW5kCisgKiBzaG91bGQgbm90 IGJlIGNhbGxlZCBmcm9tIGFueXdoZXJlIGVsc2UuCiAgKi8KIHN0YXRpYyB2b2lkCiBkZWZyb3V0 ZXJfZGVscmVxKHN0cnVjdCBuZF9kZWZyb3V0ZXIgKmRyKQpAQCAtNTcxLDcgKzU3MSw3IEBACiAK IAlpbjZfcnRyZXF1ZXN0KFJUTV9ERUxFVEUsIChzdHJ1Y3Qgc29ja2FkZHIgKikmZGVmLAogCSAg ICAoc3RydWN0IHNvY2thZGRyICopJmdhdGUsCi0JICAgIChzdHJ1Y3Qgc29ja2FkZHIgKikmbWFz aywgUlRGX0dBVEVXQVksICZvbGRydCwgUlRfREVGQVVMVF9GSUIpOworCSAgICAoc3RydWN0IHNv Y2thZGRyICopJm1hc2ssIFJURl9HQVRFV0FZLCAmb2xkcnQsIGRyLT5pZnAtPmlmX2ZpYik7CiAJ aWYgKG9sZHJ0KSB7CiAJCW5kNl9ydG1zZyhSVE1fREVMRVRFLCBvbGRydCk7CiAJCVJURlJFRShv bGRydCk7CkBAIC02OTgsMTEgKzY5OCwxMSBAQAogCiAJLyoKIAkgKiBJZiB0aGUgcm91dGVyIGlz IHRoZSBwcmltYXJ5IG9uZSwgY2hvb3NlIGEgbmV3IG9uZS4KLQkgKiBOb3RlIHRoYXQgZGVmcm91 dGVyX3NlbGVjdCgpIHdpbGwgcmVtb3ZlIHRoZSBjdXJyZW50IGdhdGV3YXkKLQkgKiBmcm9tIHRo ZSByb3V0aW5nIHRhYmxlLgorCSAqIE5vdGUgdGhhdCBkZWZyb3V0ZXJfc2VsZWN0X2ZpYigpIHdp bGwgcmVtb3ZlIHRoZSBjdXJyZW50CisgICAgICAgICAqIGdhdGV3YXkgZnJvbSB0aGUgcm91dGlu ZyB0YWJsZS4KIAkgKi8KIAlpZiAoZGVsZHIpCi0JCWRlZnJvdXRlcl9zZWxlY3QoKTsKKwkJZGVm cm91dGVyX3NlbGVjdF9maWIoZGVsZHItPmlmcC0+aWZfZmliKTsKIAogCS8qCiAJICogUmVsZWFz ZSB0aGUgbGlzdCByZWZlcmVuY2UuCkBAIC03MzAsMTMgKzczMCwyMyBAQAogICogZXZlbiB3aGVu IHRoZSBtdWx0aXBhdGggcm91dGluZyBpcyBhdmFpbGFibGUsIGJlY2F1c2Ugd2UncmUgbm90IHN1 cmUgYWJvdXQKICAqIHRoZSBiZW5lZml0cyBmb3Igc3R1YiBob3N0cyBjb21wYXJpbmcgdG8gdGhl IHJpc2sgb2YgbWFraW5nIHRoZSBjb2RlCiAgKiBjb21wbGljYXRlZCBhbmQgdGhlIHBvc3NpYmls aXR5IG9mIGludHJvZHVjaW5nIGJ1Z3MuCisgKgorICogV2UgbWFpbnRhaW4gYSBzaW5nbGUgbGlz dCBvZiByb3V0ZXJzIGZvciBtdWx0aXBsZSBGSUJzLCBvbmx5IGNvbnNpZGVyaW5nIG9uZQorICog YXQgYSB0aW1lIGJhc2VkIG9uIHRoZSByZWNlaXZpbmcgaW50ZXJmYWNlJ3MgRklCLiBJZiBAZmli bnVtIGlzIFJUX0FMTF9GSUJTLAorICogd2UgZG8gdGhlIHdob2xlIHRoaW5nIG11bHRpcGxlIHRp bWVzLgogICovCiB2b2lkCi1kZWZyb3V0ZXJfc2VsZWN0KHZvaWQpCitkZWZyb3V0ZXJfc2VsZWN0 X2ZpYihpbnQgZmlibnVtKQogewogCXN0cnVjdCBuZF9kZWZyb3V0ZXIgKmRyLCAqc2VsZWN0ZWRf ZHIsICppbnN0YWxsZWRfZHI7CiAJc3RydWN0IGxsZW50cnkgKmxuID0gTlVMTDsKIAorCWlmIChm aWJudW0gPT0gUlRfQUxMX0ZJQlMpIHsKKwkJZm9yIChmaWJudW0gPSAwOyBmaWJudW0gPCBydF9u dW1maWJzOyBmaWJudW0rKykgeworCQkJZGVmcm91dGVyX3NlbGVjdF9maWIoZmlibnVtKTsKKwkJ fQorCX0KKwogCU5ENl9STE9DSygpOwogCS8qCiAJICogTGV0J3MgaGFuZGxlIGVhc3kgY2FzZSAo MykgZmlyc3Q6CkBAIC03NTUsNyArNzY1LDcgQEAKIAlzZWxlY3RlZF9kciA9IGluc3RhbGxlZF9k ciA9IE5VTEw7CiAJVEFJTFFfRk9SRUFDSChkciwgJlZfbmRfZGVmcm91dGVyLCBkcl9lbnRyeSkg ewogCQlJRl9BRkRBVEFfUkxPQ0soZHItPmlmcCk7Ci0JCWlmIChzZWxlY3RlZF9kciA9PSBOVUxM ICYmCisJCWlmIChzZWxlY3RlZF9kciA9PSBOVUxMICYmIGRyLT5pZnAtPmlmX2ZpYiA9PSBmaWJu dW0gJiYKIAkJICAgIChsbiA9IG5kNl9sb29rdXAoJmRyLT5ydGFkZHIsIDAsIGRyLT5pZnApKSAm JgogCQkgICAgTkQ2X0lTX0xMSU5GT19QUk9CUkVBQ0gobG4pKSB7CiAJCQlzZWxlY3RlZF9kciA9 IGRyOwpAQCAtNzY3LDE0ICs3NzcsMTcgQEAKIAkJCWxuID0gTlVMTDsKIAkJfQogCi0JCWlmIChk ci0+aW5zdGFsbGVkKSB7CisJCWlmIChkci0+aW5zdGFsbGVkICYmIGRyLT5pZnAtPmlmX2ZpYiA9 PSBmaWJudW0pIHsKIAkJCWlmIChpbnN0YWxsZWRfZHIgPT0gTlVMTCkgewogCQkJCWluc3RhbGxl ZF9kciA9IGRyOwogCQkJCWRlZnJvdXRlcl9yZWYoaW5zdGFsbGVkX2RyKTsKIAkJCX0gZWxzZSB7 Ci0JCQkJLyogdGhpcyBzaG91bGQgbm90IGhhcHBlbi4gIHdhcm4gZm9yIGRpYWdub3Npcy4gKi8K LQkJCQlsb2coTE9HX0VSUiwKLQkJICAgICJkZWZyb3V0ZXJfc2VsZWN0OiBtb3JlIHRoYW4gb25l IHJvdXRlciBpcyBpbnN0YWxsZWRcbiIpOworCQkJCS8qCisJCQkJICogdGhpcyBzaG91bGQgbm90 IGhhcHBlbi4KKwkJCQkgKiB3YXJuIGZvciBkaWFnbm9zaXMuCisJCQkJICovCisJCQkJbG9nKExP R19FUlIsICJkZWZyb3V0ZXJfc2VsZWN0X2ZpYjogbW9yZSB0aGFuICIKKwkJCQkgICAgICAgICAg ICAgIm9uZSByb3V0ZXIgaXMgaW5zdGFsbGVkXG4iKTsKIAkJCX0KIAkJfQogCX0KQEAgLTc4OSwx NCArODAyLDI0IEBACiAJaWYgKHNlbGVjdGVkX2RyID09IE5VTEwpIHsKIAkJaWYgKGluc3RhbGxl ZF9kciA9PSBOVUxMIHx8CiAJCSAgICBUQUlMUV9ORVhUKGluc3RhbGxlZF9kciwgZHJfZW50cnkp ID09IE5VTEwpCi0JCQlzZWxlY3RlZF9kciA9IFRBSUxRX0ZJUlNUKCZWX25kX2RlZnJvdXRlcik7 CisJCQlkciA9IFRBSUxRX0ZJUlNUKCZWX25kX2RlZnJvdXRlcik7CiAJCWVsc2UKLQkJCXNlbGVj dGVkX2RyID0gVEFJTFFfTkVYVChpbnN0YWxsZWRfZHIsIGRyX2VudHJ5KTsKLQkJZGVmcm91dGVy X3JlZihzZWxlY3RlZF9kcik7CisJCQlkciA9IFRBSUxRX05FWFQoaW5zdGFsbGVkX2RyLCBkcl9l bnRyeSk7CisKKwkJLyogRW5zdXJlIHdlIHNlbGVjdCBhIHJvdXRlciBmb3IgdGhpcyBGSUIuICov CisJCVRBSUxRX0ZPUkVBQ0hfRlJPTShkciwgJlZfbmRfZGVmcm91dGVyLCBkcl9lbnRyeSkgewor CQkJaWYgKGRyLT5pZnAtPmlmX2ZpYiA9PSBmaWJudW0pIHsKKwkJCQlzZWxlY3RlZF9kciA9IGRy OworCQkJCWRlZnJvdXRlcl9yZWYoc2VsZWN0ZWRfZHIpOworCQkJCWJyZWFrOworCQkJfQorCQl9 CiAJfSBlbHNlIGlmIChpbnN0YWxsZWRfZHIgIT0gTlVMTCkgewogCQlJRl9BRkRBVEFfUkxPQ0so aW5zdGFsbGVkX2RyLT5pZnApOwotCQlpZiAoKGxuID0gbmQ2X2xvb2t1cCgmaW5zdGFsbGVkX2Ry LT5ydGFkZHIsIDAsIGluc3RhbGxlZF9kci0+aWZwKSkgJiYKKwkJaWYgKChsbiA9IG5kNl9sb29r dXAoJmluc3RhbGxlZF9kci0+cnRhZGRyLCAwLAorCQkgICAgICAgICAgICAgICAgICAgICBpbnN0 YWxsZWRfZHItPmlmcCkpICYmCiAJCSAgICBORDZfSVNfTExJTkZPX1BST0JSRUFDSChsbikgJiYK KwkJICAgIGluc3RhbGxlZF9kci0+aWZwLT5pZl9maWIgPT0gZmlibnVtICYmCiAJCSAgICBydHBy ZWYoc2VsZWN0ZWRfZHIpIDw9IHJ0cHJlZihpbnN0YWxsZWRfZHIpKSB7CiAJCQlkZWZyb3V0ZXJf cmVsZShzZWxlY3RlZF9kcik7CiAJCQlzZWxlY3RlZF9kciA9IGluc3RhbGxlZF9kcjsKQEAgLTgw OCwxOCArODMxLDMwIEBACiAJTkQ2X1JVTkxPQ0soKTsKIAogCS8qCi0JICogSWYgdGhlIHNlbGVj dGVkIHJvdXRlciBpcyBkaWZmZXJlbnQgdGhhbiB0aGUgaW5zdGFsbGVkIG9uZSwKLQkgKiByZW1v dmUgdGhlIGluc3RhbGxlZCByb3V0ZXIgYW5kIGluc3RhbGwgdGhlIHNlbGVjdGVkIG9uZS4KLQkg KiBOb3RlIHRoYXQgdGhlIHNlbGVjdGVkIHJvdXRlciBpcyBuZXZlciBOVUxMIGhlcmUuCisJICog SWYgd2Ugc2VsZWN0ZWQgYSByb3V0ZXIgZm9yIHRoaXMgRklCIGFuZCBpdCdzIGRpZmZlcmVudAor CSAqIHRoYW4gdGhlIGluc3RhbGxlZCBvbmUsIHJlbW92ZSB0aGUgaW5zdGFsbGVkIHJvdXRlciBh bmQKKwkgKiBpbnN0YWxsIHRoZSBzZWxlY3RlZCBvbmUgaW4gaXRzIHBsYWNlLgogCSAqLwogCWlm IChpbnN0YWxsZWRfZHIgIT0gc2VsZWN0ZWRfZHIpIHsKIAkJaWYgKGluc3RhbGxlZF9kciAhPSBO VUxMKSB7CiAJCQlkZWZyb3V0ZXJfZGVscmVxKGluc3RhbGxlZF9kcik7CiAJCQlkZWZyb3V0ZXJf cmVsZShpbnN0YWxsZWRfZHIpOwogCQl9Ci0JCWRlZnJvdXRlcl9hZGRyZXEoc2VsZWN0ZWRfZHIp OworCQlpZiAoc2VsZWN0ZWRfZHIgIT0gTlVMTCkKKwkJCWRlZnJvdXRlcl9hZGRyZXEoc2VsZWN0 ZWRfZHIpOwogCX0KLQlkZWZyb3V0ZXJfcmVsZShzZWxlY3RlZF9kcik7CisJaWYgKHNlbGVjdGVk X2RyICE9IE5VTEwpCisJCWRlZnJvdXRlcl9yZWxlKHNlbGVjdGVkX2RyKTsKK30KKworLyoKKyAq IE1haW50YWluIG9sZCBLUEkgZm9yIGRlZmF1bHQgcm91dGVyIHNlbGVjdGlvbi4KKyAqIElmIHVu c3BlY2lmaWVkLCB3ZSBjYW4gcmUtc2VsZWN0IHJvdXRlcnMgZm9yIGFsbCBGSUJzLgorICovCit2 b2lkCitkZWZyb3V0ZXJfc2VsZWN0KHZvaWQpCit7CisJZGVmcm91dGVyX3NlbGVjdF9maWIoUlRf QUxMX0ZJQlMpOwogfQogCiAvKgpAQCAtOTQyLDcgKzk3Nyw3IEBACiAJVl9uZDZfbGlzdF9nZW5p ZCsrOwogCU5ENl9XVU5MT0NLKCk7CiAKLQlkZWZyb3V0ZXJfc2VsZWN0KCk7CisJZGVmcm91dGVy X3NlbGVjdF9maWIobmV3LT5pZnAtPmlmX2ZpYik7CiAKIAlyZXR1cm4gKG4pOwogfQpAQCAtMTcz MSw3ICsxNzY2LDcgQEAKIAlzdHJ1Y3QgcnRlbnRyeSAqcnQ7CiAJc3RydWN0IHNvY2thZGRyX2lu NiBtYXNrNjsKIAl1X2xvbmcgcnRmbGFnczsKLQlpbnQgZXJyb3IsIGFfZmFpbHVyZSwgZmlibnVt OworCWludCBlcnJvciwgYV9mYWlsdXJlLCBmaWJudW0sIG1heGZpYjsKIAogCS8qCiAJICogaW42 X2lmaW5pdCgpIHNldHMgbmQ2X3J0cmVxdWVzdCB0byBpZmFfcnRyZXF1ZXN0IGZvciBhbGwgaWZh ZGRycy4KQEAgLTE3NDIsOCArMTc3NywxNSBAQAogCW1hc2s2LnNpbjZfYWRkciA9IHByLT5uZHBy X21hc2s7CiAJcnRmbGFncyA9IChpZmEtPmlmYV9mbGFncyAmIH5JRkFfUlRTRUxGKSB8IFJURl9V UDsKIAorCWlmKFZfcnRfYWRkX2FkZHJfYWxsZmlicykgeworCQlmaWJudW0gPSAwOworCQltYXhm aWIgPSBydF9udW1maWJzOworCX0gZWxzZSB7CisJCWZpYm51bSA9IGlmYS0+aWZhX2lmcC0+aWZf ZmliOworCQltYXhmaWIgPSBmaWJudW0gKyAxOworCX0KIAlhX2ZhaWx1cmUgPSAwOwotCWZvciAo ZmlibnVtID0gMDsgZmlibnVtIDwgcnRfbnVtZmliczsgZmlibnVtKyspIHsKKwlmb3IgKDsgZmli bnVtIDwgbWF4ZmliOyBmaWJudW0rKykgewogCiAJCXJ0ID0gTlVMTDsKIAkJZXJyb3IgPSBpbjZf cnRyZXF1ZXN0KFJUTV9BREQsCkBAIC0xODMxLDYgKzE4NzMsMTAgQEAKIAkJaWYgKChvcHItPm5k cHJfc3RhdGVmbGFncyAmIE5EUFJGX09OTElOSykgPT0gMCkKIAkJCWNvbnRpbnVlOwogCisJCWlm ICghVl9ydF9hZGRfYWRkcl9hbGxmaWJzICYmCisJCSAgICBvcHItPm5kcHJfaWZwLT5pZl9maWIg IT0gcHItPm5kcHJfaWZwLT5pZl9maWIpCisJCQljb250aW51ZTsKKwogCQlpZiAob3ByLT5uZHBy X3BsZW4gPT0gcHItPm5kcHJfcGxlbiAmJgogCQkgICAgaW42X2FyZV9wcmVmaXhfZXF1YWwoJnBy LT5uZHByX3ByZWZpeC5zaW42X2FkZHIsCiAJCSAgICAmb3ByLT5uZHByX3ByZWZpeC5zaW42X2Fk ZHIsIHByLT5uZHByX3BsZW4pKSB7CkBAIC0xODkxLDcgKzE5MzcsNyBAQAogCXN0cnVjdCBydGVu dHJ5ICpydDsKIAljaGFyIGlwNmJ1ZltJTkVUNl9BRERSU1RSTEVOXTsKIAl1aW50NjRfdCBnZW5p ZDsKLQlpbnQgZmlibnVtLCBhX2ZhaWx1cmU7CisJaW50IGZpYm51bSwgbWF4ZmliLCBhX2ZhaWx1 cmU7CiAKIAlORDZfT05MSU5LX0xPQ0tfQVNTRVJUKCk7CiAJTkQ2X1VOTE9DS19BU1NFUlQoKTsK QEAgLTE5MDksOCArMTk1NSwxNiBAQAogCW1hc2s2LnNpbjZfbGVuID0gc2l6ZW9mKHNhNik7CiAJ YmNvcHkoJnByLT5uZHByX21hc2ssICZtYXNrNi5zaW42X2FkZHIsIHNpemVvZihzdHJ1Y3QgaW42 X2FkZHIpKTsKIAorCWlmIChWX3J0X2FkZF9hZGRyX2FsbGZpYnMpIHsKKwkJZmlibnVtID0gMDsK KwkJbWF4ZmliID0gcnRfbnVtZmliczsKKwl9IGVsc2UgeworCQlmaWJudW0gPSBpZnAtPmlmX2Zp YjsKKwkJbWF4ZmliID0gZmlibnVtICsgMTsKKwl9CisKIAlhX2ZhaWx1cmUgPSAwOwotCWZvciAo ZmlibnVtID0gMDsgZmlibnVtIDwgcnRfbnVtZmliczsgZmlibnVtKyspIHsKKwlmb3IgKDsgZmli bnVtIDwgbWF4ZmliOyBmaWJudW0rKykgewogCQlydCA9IE5VTEw7CiAJCWVycm9yID0gaW42X3J0 cmVxdWVzdChSVE1fREVMRVRFLCAoc3RydWN0IHNvY2thZGRyICopJnNhNiwgTlVMTCwKIAkJICAg IChzdHJ1Y3Qgc29ja2FkZHIgKikmbWFzazYsIDAsICZydCwgZmlibnVtKTsKZGlmZiAtLWdpdCBh L3N5cy9uZXRpbmV0Ni9uZDZfbmJyLmMgYi9zeXMvbmV0aW5ldDYvbmQ2X25ici5jCi0tLSBhL3N5 cy9uZXRpbmV0Ni9uZDZfbmJyLmMKKysrIGIvc3lzL25ldGluZXQ2L25kNl9uYnIuYwpAQCAtMjYy LDggKzI2Miw3IEBACiAJCWJ6ZXJvKCZpbmZvLCBzaXplb2YoaW5mbykpOwogCQlpbmZvLnJ0aV9p bmZvW1JUQVhfR0FURVdBWV0gPSAoc3RydWN0IHNvY2thZGRyICopJnJ0X2dhdGV3YXk7CiAKLQkJ LyogQWx3YXlzIHVzZSB0aGUgZGVmYXVsdCBGSUIuICovCi0JCWlmIChyaWJfbG9va3VwX2luZm8o UlRfREVGQVVMVF9GSUIsIChzdHJ1Y3Qgc29ja2FkZHIgKikmZHN0NiwKKwkJaWYgKHJpYl9sb29r dXBfaW5mbyhpZnAtPmlmX2ZpYiwgKHN0cnVjdCBzb2NrYWRkciAqKSZkc3Q2LAogCQkgICAgMCwg MCwgJmluZm8pID09IDApIHsKIAkJCWlmICgoaW5mby5ydGlfZmxhZ3MgJiBSVEZfQU5OT1VOQ0Up ICE9IDAgJiYKIAkJCSAgICBydF9nYXRld2F5LnNkbF9mYW1pbHkgPT0gQUZfTElOSykgewpAQCAt NDg1LDcgKzQ4NCw3IEBACiAJCQl1aW50MzJfdCBzY29wZWlkOwogCiAJCQlpbjZfc3BsaXRzY29w ZSgmaXA2LT5pcDZfZHN0LCAmZHN0NiwgJnNjb3BlaWQpOwotCQkJZXJyb3IgPSBpbjZfc2VsZWN0 c3JjX2FkZHIoUlRfREVGQVVMVF9GSUIsICZkc3Q2LAorCQkJZXJyb3IgPSBpbjZfc2VsZWN0c3Jj X2FkZHIoZmlibnVtLCAmZHN0NiwKIAkJCSAgICBzY29wZWlkLCBpZnAsICZzcmM2LCBOVUxMKTsK IAkJCWlmIChlcnJvcikgewogCQkJCWNoYXIgaXA2YnVmW0lORVQ2X0FERFJTVFJMRU5dOwpAQCAt OTgyLDcgKzk4MSw3IEBACiAJICogU2VsZWN0IGEgc291cmNlIHdob3NlIHNjb3BlIGlzIHRoZSBz YW1lIGFzIHRoYXQgb2YgdGhlIGRlc3QuCiAJICovCiAJaW42X3NwbGl0c2NvcGUoJmRhZGRyNiwg JmRzdDYsICZzY29wZWlkKTsKLQllcnJvciA9IGluNl9zZWxlY3RzcmNfYWRkcihSVF9ERUZBVUxU X0ZJQiwgJmRzdDYsCisJZXJyb3IgPSBpbjZfc2VsZWN0c3JjX2FkZHIoZmlibnVtLCAmZHN0NiwK IAkgICAgc2NvcGVpZCwgaWZwLCAmc3JjNiwgTlVMTCk7CiAJaWYgKGVycm9yKSB7CiAJCWNoYXIg aXA2YnVmW0lORVQ2X0FERFJTVFJMRU5dOwpkaWZmIC0tZ2l0IGEvc3lzL25ldGluZXQ2L25kNi5o IGIvc3lzL25ldGluZXQ2L25kNi5oCi0tLSBhL3N5cy9uZXRpbmV0Ni9uZDYuaAorKysgYi9zeXMv bmV0aW5ldDYvbmQ2LmgKQEAgLTQ2OSw2ICs0NjksNyBAQAogdm9pZCBuZDZfcnNfaW5wdXQoc3Ry dWN0IG1idWYgKiwgaW50LCBpbnQpOwogdm9pZCBuZDZfcmFfaW5wdXQoc3RydWN0IG1idWYgKiwg aW50LCBpbnQpOwogdm9pZCBkZWZyb3V0ZXJfcmVzZXQodm9pZCk7Cit2b2lkIGRlZnJvdXRlcl9z ZWxlY3RfZmliKGludCBmaWJudW0pOwogdm9pZCBkZWZyb3V0ZXJfc2VsZWN0KHZvaWQpOwogdm9p ZCBkZWZyb3V0ZXJfcmVmKHN0cnVjdCBuZF9kZWZyb3V0ZXIgKik7CiB2b2lkIGRlZnJvdXRlcl9y ZWxlKHN0cnVjdCBuZF9kZWZyb3V0ZXIgKik7CmRpZmYgLS1naXQgYS9zeXMvbmV0aW5ldDYvbmQ2 LmMgYi9zeXMvbmV0aW5ldDYvbmQ2LmMKLS0tIGEvc3lzL25ldGluZXQ2L25kNi5jCisrKyBiL3N5 cy9uZXRpbmV0Ni9uZDYuYwpAQCAtMTU3LDYgKzE1Nyw3IEBACiAJc3RydWN0IHNvY2thZGRyX2Rs IGd3OwogCXN0cnVjdCBpZm5ldCAqaWZwOwogCWludCB0eXBlOworCWludCBmaWJudW07CiAKIAlM TEVfV0xPQ0tfQVNTRVJUKGxsZSk7CiAKQEAgLTE5NCw4ICsxOTUsOSBAQAogCXJ0aW5mby5ydGlf aW5mb1tSVEFYX0RTVF0gPSAoc3RydWN0IHNvY2thZGRyICopJmRzdDsKIAlydGluZm8ucnRpX2lu Zm9bUlRBWF9HQVRFV0FZXSA9IChzdHJ1Y3Qgc29ja2FkZHIgKikmZ3c7CiAJcnRpbmZvLnJ0aV9h ZGRycyA9IFJUQV9EU1QgfCBSVEFfR0FURVdBWTsKKwlmaWJudW0gPSBWX3J0X2FkZF9hZGRyX2Fs bGZpYnMgPyBSVF9BTExfRklCUyA6IGlmcC0+aWZfZmliOwogCXJ0X21pc3Ntc2dfZmliKHR5cGUs ICZydGluZm8sIFJURl9IT1NUIHwgUlRGX0xMREFUQSB8ICgKLQkgICAgdHlwZSA9PSBSVE1fQURE ID8gUlRGX1VQOiAwKSwgMCwgUlRfREVGQVVMVF9GSUIpOworCSAgICB0eXBlID09IFJUTV9BREQg PyBSVEZfVVA6IDApLCAwLCBmaWJudW0pOwogfQogCiAvKgpAQCAtMTIwMCw3ICsxMjAyLDcgQEAK IAogCWlmIChORF9JRklORk8oaWZwKS0+ZmxhZ3MgJiBORDZfSUZGX0FDQ0VQVF9SVEFEVikgewog CQkvKiBSZWZyZXNoIGRlZmF1bHQgcm91dGVyIGxpc3QuICovCi0JCWRlZnJvdXRlcl9zZWxlY3Qo KTsKKwkJZGVmcm91dGVyX3NlbGVjdF9maWIoaWZwLT5pZl9maWIpOwogCX0KIH0KIApAQCAtMTI1 Myw3ICsxMjU1LDcgQEAKIG5kNl9pc19uZXdfYWRkcl9uZWlnaGJvcihjb25zdCBzdHJ1Y3Qgc29j a2FkZHJfaW42ICphZGRyLCBzdHJ1Y3QgaWZuZXQgKmlmcCkKIHsKIAlzdHJ1Y3QgbmRfcHJlZml4 ICpwcjsKLQlzdHJ1Y3QgaWZhZGRyICpkc3RhZGRyOworCXN0cnVjdCBpZmFkZHIgKmlmYTsKIAlz dHJ1Y3QgcnRfYWRkcmluZm8gaW5mbzsKIAlzdHJ1Y3Qgc29ja2FkZHJfaW42IHJ0X2tleTsKIAlj b25zdCBzdHJ1Y3Qgc29ja2FkZHIgKmRzdDY7CkBAIC0xMjg3LDkgKzEyODksNiBAQAogCWJ6ZXJv KCZpbmZvLCBzaXplb2YoaW5mbykpOwogCWluZm8ucnRpX2luZm9bUlRBWF9EU1RdID0gKHN0cnVj dCBzb2NrYWRkciAqKSZydF9rZXk7CiAKLQkvKiBBbHdheXMgdXNlIHRoZSBkZWZhdWx0IEZJQiBo ZXJlLiBYWE1FIC0gd2h5PyAqLwotCWZpYm51bSA9IFJUX0RFRkFVTFRfRklCOwotCiAJLyoKIAkg KiBJZiB0aGUgYWRkcmVzcyBtYXRjaGVzIG9uZSBvZiBvdXIgYWRkcmVzc2VzLAogCSAqIGl0IHNo b3VsZCBiZSBhIG5laWdoYm9yLgpAQCAtMTMwMywxOSArMTMwMiwzMSBAQAogCQkJY29udGludWU7 CiAKIAkJaWYgKChwci0+bmRwcl9zdGF0ZWZsYWdzICYgTkRQUkZfT05MSU5LKSA9PSAwKSB7Ci0J CQkvKiBBbHdheXMgdXNlIHRoZSBkZWZhdWx0IEZJQiBoZXJlLiAqLwogCQkJZHN0NiA9IChjb25z dCBzdHJ1Y3Qgc29ja2FkZHIgKikmcHItPm5kcHJfcHJlZml4OwogCi0JCQlnZW5pZCA9IFZfbmQ2 X2xpc3RfZ2VuaWQ7Ci0JCQlORDZfUlVOTE9DSygpOwotCi0JCQkvKiBSZXN0b3JlIGxlbmd0aCBm aWVsZCBiZWZvcmUgcmV0cnlpbmcgbG9va3VwICovCi0JCQlydF9rZXkuc2luNl9sZW4gPSBzaXpl b2YocnRfa2V5KTsKLQkJCWVycm9yID0gcmliX2xvb2t1cF9pbmZvKGZpYm51bSwgZHN0NiwgMCwg MCwgJmluZm8pOworCQkJLyoKKwkJCSAqIFdlIG9ubHkgbmVlZCB0byBjaGVjayBhbGwgRklCcyBp ZiBhZGRfYWRkcl9hbGxmaWJzCisJCQkgKiBpcyB1bnNldC4gSWYgc2V0LCBjaGVja2luZyBhbnkg RklCIHdpbGwgc3VmZmljZS4KKwkJCSAqLworCQkJZmlibnVtID0gVl9ydF9hZGRfYWRkcl9hbGxm aWJzID8gcnRfbnVtZmlicyAtIDEgOiAwOworCQkJZm9yICg7IGZpYm51bSA8IHJ0X251bWZpYnM7 IGZpYm51bSsrKSB7CisJCQkJZ2VuaWQgPSBWX25kNl9saXN0X2dlbmlkOworCQkJCU5ENl9SVU5M T0NLKCk7CiAKLQkJCU5ENl9STE9DSygpOwotCQkJaWYgKGdlbmlkICE9IFZfbmQ2X2xpc3RfZ2Vu aWQpCi0JCQkJZ290byByZXN0YXJ0OworCQkJCS8qCisJCQkJICogUmVzdG9yZSBsZW5ndGggZmll bGQgYmVmb3JlCisJCQkJICogcmV0cnlpbmcgbG9va3VwCisJCQkJICovCisJCQkJcnRfa2V5LnNp bjZfbGVuID0gc2l6ZW9mKHJ0X2tleSk7CisJCQkJZXJyb3IgPSByaWJfbG9va3VwX2luZm8oZmli bnVtLCBkc3Q2LCAwLCAwLAorCQkJCQkJICAgICAgICAmaW5mbyk7CisKKwkJCQlORDZfUkxPQ0so KTsKKwkJCQlpZiAoZ2VuaWQgIT0gVl9uZDZfbGlzdF9nZW5pZCkKKwkJCQkJZ290byByZXN0YXJ0 OworCQkJCWlmIChlcnJvciA9PSAwKQorCQkJCQlicmVhazsKKwkJCX0KIAkJCWlmIChlcnJvciAh PSAwKQogCQkJCWNvbnRpbnVlOwogCkBAIC0xMzQ2LDEzICsxMzU3LDE4IEBACiAJICogSWYgdGhl IGFkZHJlc3MgaXMgYXNzaWduZWQgb24gdGhlIG5vZGUgb2YgdGhlIG90aGVyIHNpZGUgb2YKIAkg KiBhIHAycCBpbnRlcmZhY2UsIHRoZSBhZGRyZXNzIHNob3VsZCBiZSBhIG5laWdoYm9yLgogCSAq LwotCWRzdGFkZHIgPSBpZmFfaWZ3aXRoZHN0YWRkcigoY29uc3Qgc3RydWN0IHNvY2thZGRyICop YWRkciwgUlRfQUxMX0ZJQlMpOwotCWlmIChkc3RhZGRyICE9IE5VTEwpIHsKLQkJaWYgKGRzdGFk ZHItPmlmYV9pZnAgPT0gaWZwKSB7Ci0JCQlpZmFfZnJlZShkc3RhZGRyKTsKLQkJCXJldHVybiAo MSk7CisJaWYgKGlmcC0+aWZfZmxhZ3MgJiBJRkZfUE9JTlRPUE9JTlQpIHsKKwkJSUZfQUREUl9S TE9DSyhpZnApOworCQlUQUlMUV9GT1JFQUNIKGlmYSwgJmlmcC0+aWZfYWRkcmhlYWQsIGlmYV9s aW5rKSB7CisJCQlpZiAoaWZhLT5pZmFfYWRkci0+c2FfZmFtaWx5ICE9IGFkZHItPnNpbjZfZmFt aWx5KQorCQkJCWNvbnRpbnVlOworCQkJaWYgKGlmYS0+aWZhX2RzdGFkZHIgIT0gTlVMTCAmJgor CQkJICAgIHNhX2VxdWFsKGFkZHIsIGlmYS0+aWZhX2RzdGFkZHIpKSB7CisJCQkJSUZfQUREUl9S VU5MT0NLKGlmcCk7CisJCQkJcmV0dXJuIDE7CisJCQl9CiAJCX0KLQkJaWZhX2ZyZWUoZHN0YWRk cik7CisJCUlGX0FERFJfUlVOTE9DSyhpZnApOwogCX0KIAogCS8qCkBAIC0xNDg1LDcgKzE1MDEs NyBAQAogCQkJLyoKIAkJCSAqIFdlIG5lZWQgdG8gdW5sb2NrIHRvIGF2b2lkIGEgTE9SIHdpdGgg cnQ2X2ZsdXNoKCkgd2l0aCB0aGUKIAkJCSAqIHJuaCBhbmQgZm9yIHRoZSBjYWxscyB0byBwZnhs aXN0X29ubGlua19jaGVjaygpIGFuZAotCQkJICogZGVmcm91dGVyX3NlbGVjdCgpIGluIHRoZSBi bG9jayBmdXJ0aGVyIGRvd24gZm9yIGNhbGxzCisJCQkgKiBkZWZyb3V0ZXJfc2VsZWN0X2ZpYigp IGluIHRoZSBibG9jayBmdXJ0aGVyIGRvd24gZm9yIGNhbGxzCiAJCQkgKiBpbnRvIG5kNl9sb29r dXAoKS4gIFdlIHN0aWxsIGhvbGQgYSByZWYuCiAJCQkgKi8KIAkJCUxMRV9XVU5MT0NLKGxuKTsK QEAgLTE1MDAsNyArMTUxNiw3IEBACiAKIAkJaWYgKGRyKSB7CiAJCQkvKgotCQkJICogU2luY2Ug ZGVmcm91dGVyX3NlbGVjdCgpIGRvZXMgbm90IGFmZmVjdCB0aGUKKwkJCSAqIFNpbmNlIGRlZnJv dXRlcl9zZWxlY3RfZmliKCkgZG9lcyBub3QgYWZmZWN0IHRoZQogCQkJICogb24tbGluayBkZXRl cm1pbmF0aW9uIGFuZCBNSVA2IG5lZWRzIHRoZSBjaGVjawogCQkJICogYmVmb3JlIHRoZSBkZWZh dWx0IHJvdXRlciBzZWxlY3Rpb24sIHdlIHBlcmZvcm0KIAkJCSAqIHRoZSBjaGVjayBub3cuCkBA IC0xNTEwLDcgKzE1MjYsNyBAQAogCQkJLyoKIAkJCSAqIFJlZnJlc2ggZGVmYXVsdCByb3V0ZXIg bGlzdC4KIAkJCSAqLwotCQkJZGVmcm91dGVyX3NlbGVjdCgpOworCQkJZGVmcm91dGVyX3NlbGVj dF9maWIoZHItPmlmcC0+aWZfZmliKTsKIAkJfQogCiAJCS8qCkBAIC0yMTA0LDIwICsyMTIwLDIw IEBACiAJICogUXVlc3Rpb246IGNhbiB3ZSByZXN0cmljdCB0aGUgZmlyc3QgY29uZGl0aW9uIHRv IHRoZSAiaXNfbmV3ZW50cnkiCiAJICogY2FzZT8KIAkgKiBYWFg6IHdoZW4gd2UgaGVhciBhbiBS QSBmcm9tIGEgbmV3IHJvdXRlciB3aXRoIHRoZSBsaW5rLWxheWVyCi0JICogYWRkcmVzcyBvcHRp b24sIGRlZnJvdXRlcl9zZWxlY3QoKSBpcyBjYWxsZWQgdHdpY2UsIHNpbmNlCisJICogYWRkcmVz cyBvcHRpb24sIGRlZnJvdXRlcl9zZWxlY3RfZmliKCkgaXMgY2FsbGVkIHR3aWNlLCBzaW5jZQog CSAqIGRlZnJ0cmxpc3RfdXBkYXRlIGNhbGxlZCB0aGUgZnVuY3Rpb24gYXMgd2VsbC4gIEhvd2V2 ZXIsIEkgYmVsaWV2ZQogCSAqIHdlIGNhbiBjb21wcm9taXNlIHRoZSBvdmVyaGVhZCwgc2luY2Ug aXQgb25seSBoYXBwZW5zIHRoZSBmaXJzdAogCSAqIHRpbWUuCi0JICogWFhYOiBhbHRob3VnaCBk ZWZyb3V0ZXJfc2VsZWN0KCkgc2hvdWxkIG5vdCBoYXZlIGEgYmFkIGVmZmVjdAorCSAqIFhYWDog YWx0aG91Z2ggZGVmcm91dGVyX3NlbGVjdF9maWIoKSBzaG91bGQgbm90IGhhdmUgYSBiYWQgZWZm ZWN0CiAJICogZm9yIHRob3NlIGFyZSBub3QgYXV0b2NvbmZpZ3VyZWQgaG9zdHMsIHdlIGV4cGxp Y2l0bHkgYXZvaWQgc3VjaAogCSAqIGNhc2VzIGZvciBzYWZldHkuCiAJICovCiAJaWYgKChkb191 cGRhdGUgfHwgaXNfbmV3ZW50cnkpICYmIHJvdXRlciAmJgogCSAgICBORF9JRklORk8oaWZwKS0+ ZmxhZ3MgJiBORDZfSUZGX0FDQ0VQVF9SVEFEVikgewogCQkvKgogCQkgKiBndWFyYW50ZWVkIHJl Y3Vyc2lvbgogCQkgKi8KLQkJZGVmcm91dGVyX3NlbGVjdCgpOworCQlkZWZyb3V0ZXJfc2VsZWN0 X2ZpYihpZnAtPmlmX2ZpYik7CiAJfQogfQogCmRpZmYgLS1naXQgYS9zeXMvbmV0aW5ldDYvaW42 X3NyYy5jIGIvc3lzL25ldGluZXQ2L2luNl9zcmMuYwotLS0gYS9zeXMvbmV0aW5ldDYvaW42X3Ny Yy5jCisrKyBiL3N5cy9uZXRpbmV0Ni9pbjZfc3JjLmMKQEAgLTI5Nyw3ICsyOTcsNyBAQAogCSAq LwogCS8qIGdldCB0aGUgb3V0Z29pbmcgaW50ZXJmYWNlICovCiAJaWYgKChlcnJvciA9IGluNl9z ZWxlY3RpZihkc3Rzb2NrLCBvcHRzLCBtb3B0cywgJmlmcCwgb2lmcCwKLQkgICAgKGlucCAhPSBO VUxMKSA/IGlucC0+aW5wX2luYy5pbmNfZmlibnVtIDogUlRfREVGQVVMVF9GSUIpKSAhPSAwKQor CSAgICAoaW5wICE9IE5VTEwpID8gaW5wLT5pbnBfaW5jLmluY19maWJudW0gOiBmaWJudW0pKSAh PSAwKQogCQlyZXR1cm4gKGVycm9yKTsKIAogI2lmZGVmIERJQUdOT1NUSUMKQEAgLTU2Myw3ICs1 NjMsNyBAQAogCXVpbnQzMl90IGZpYm51bTsKIAlpbnQgZXJyb3I7CiAKLQlmaWJudW0gPSAoaW5w ICE9IE5VTEwpID8gaW5wLT5pbnBfaW5jLmluY19maWJudW0gOiBSVF9ERUZBVUxUX0ZJQjsKKwlm aWJudW0gPSBpbnAtPmlucF9pbmMuaW5jX2ZpYm51bTsKIAlyZXRpZnAgPSBOVUxMOwogCiAJZXJy b3IgPSBpbjZfc2VsZWN0c3JjKGZpYm51bSwgZHN0c29jaywgb3B0cywgaW5wLCBjcmVkLCAmcmV0 aWZwLCBzcmNwKTsKZGlmZiAtLWdpdCBhL3N5cy9uZXRpbmV0Ni9pbjYuYyBiL3N5cy9uZXRpbmV0 Ni9pbjYuYwotLS0gYS9zeXMvbmV0aW5ldDYvaW42LmMKKysrIGIvc3lzL25ldGluZXQ2L2luNi5j CkBAIC0xNTksNiArMTU5LDcgQEAKIAlzdHJ1Y3Qgc29ja2FkZHJfZGwgZ2F0ZXdheTsKIAlzdHJ1 Y3Qgc29ja2FkZHJfaW42IG1hc2ssIGFkZHI7CiAJc3RydWN0IHJ0ZW50cnkgcnQ7CisJaW50IGZp Ym51bTsKIAogCS8qCiAJICogaW5pdGlhbGl6ZSBmb3IgcnRtc2cgZ2VuZXJhdGlvbgpAQCAtMTc2 LDggKzE3Nyw5IEBACiAJcnQucnRfZmxhZ3MgPSBSVEZfSE9TVCB8IFJURl9TVEFUSUM7CiAJaWYg KGNtZCA9PSBSVE1fQUREKQogCQlydC5ydF9mbGFncyB8PSBSVEZfVVA7Ci0JLyogQW5ub3VuY2Ug YXJyaXZhbCBvZiBsb2NhbCBhZGRyZXNzIHRvIGFsbCBGSUJzLiAqLwotCXJ0X25ld2FkZHJtc2co Y21kLCAmaWEtPmlhX2lmYSwgMCwgJnJ0KTsKKwlmaWJudW0gPSBWX3J0X2FkZF9hZGRyX2FsbGZp YnMgPyBSVF9BTExfRklCUyA6IGlhNjJpZmEoaWEpLT5pZmFfaWZwLT5pZl9maWI7CisJLyogQW5u b3VuY2UgYXJyaXZhbCBvZiBsb2NhbCBhZGRyZXNzIHRvIHRoaXMgRklCLiAqLworCXJ0X25ld2Fk ZHJtc2dfZmliKGNtZCwgJmlhLT5pYV9pZmEsIDAsICZydCwgZmlibnVtKTsKIH0KIAogaW50CkBA IC0yMTE3LDE1ICsyMTE5LDE1IEBACiAJdWludDMyX3Qgc2NvcGVpZDsKIAlpbnQgZXJyb3I7CiAJ Y2hhciBpcDZidWZbSU5FVDZfQUREUlNUUkxFTl07CisJaW50IGZpYm51bTsKIAogCUtBU1NFUlQo bDNhZGRyLT5zYV9mYW1pbHkgPT0gQUZfSU5FVDYsCiAJICAgICgic2luX2ZhbWlseSAlZCIsIGwz YWRkci0+c2FfZmFtaWx5KSk7CiAKLQkvKiBPdXIgbG9jYWwgYWRkcmVzc2VzIGFyZSBhbHdheXMg b25seSBpbnN0YWxsZWQgb24gdGhlIGRlZmF1bHQgRklCLiAqLwotCiAJc2luNiA9IChjb25zdCBz dHJ1Y3Qgc29ja2FkZHJfaW42ICopbDNhZGRyOwogCWluNl9zcGxpdHNjb3BlKCZzaW42LT5zaW42 X2FkZHIsICZkc3QsICZzY29wZWlkKTsKLQllcnJvciA9IGZpYjZfbG9va3VwX25oX2Jhc2ljKFJU X0RFRkFVTFRfRklCLCAmZHN0LCBzY29wZWlkLCAwLCAwLCAmbmg2KTsKKwlmaWJudW0gPSBWX3J0 X2FkZF9hZGRyX2FsbGZpYnMgPyBSVF9ERUZBVUxUX0ZJQiA6IGlmcC0+aWZfZmliOworCWVycm9y ID0gZmliNl9sb29rdXBfbmhfYmFzaWMoZmlibnVtLCAmZHN0LCBzY29wZWlkLCAwLCAwLCAmbmg2 KTsKIAlpZiAoZXJyb3IgIT0gMCB8fCAobmg2Lm5oX2ZsYWdzICYgTkhGX0dBVEVXQVkpIHx8IG5o Ni5uaF9pZnAgIT0gaWZwKSB7CiAJCXN0cnVjdCBpZmFkZHIgKmlmYTsKIAkJLyoKZGlmZiAtLWdp dCBhL3N5cy9uZXRpbmV0Ni9pY21wNi5jIGIvc3lzL25ldGluZXQ2L2ljbXA2LmMKLS0tIGEvc3lz L25ldGluZXQ2L2ljbXA2LmMKKysrIGIvc3lzL25ldGluZXQ2L2ljbXA2LmMKQEAgLTIxNDcsNyAr MjE0Nyw3IEBACiAJCSAqIHNvdXJjZSBhZGRyZXNzIG9mIHRoZSBlcnJvbmVvdXMgcGFja2V0Lgog CQkgKi8KIAkJaW42X3NwbGl0c2NvcGUoJmlwNi0+aXA2X3NyYywgJmRzdDYsICZzY29wZWlkKTsK LQkJZXJyb3IgPSBpbjZfc2VsZWN0c3JjX2FkZHIoUlRfREVGQVVMVF9GSUIsICZkc3Q2LAorCQll cnJvciA9IGluNl9zZWxlY3RzcmNfYWRkcihNX0dFVEZJQihtKSwgJmRzdDYsCiAJCSAgICBzY29w ZWlkLCBOVUxMLCAmc3JjNiwgJmhsaW0pOwogCiAJCWlmIChlcnJvcikgewpAQCAtMjI4OSw3ICsy Mjg5LDcgQEAKIAl1aW50MzJfdCBzY29wZWlkOwogCiAJaW42X3NwbGl0c2NvcGUoJnJlZGRzdDYs ICZrZHN0LCAmc2NvcGVpZCk7Ci0JaWYgKGZpYjZfbG9va3VwX25oX2Jhc2ljKFJUX0RFRkFVTFRf RklCLCAma2RzdCwgc2NvcGVpZCwgMCwgMCwmbmg2KT09MCl7CisJaWYgKGZpYjZfbG9va3VwX25o X2Jhc2ljKGlmcC0+aWZfZmliLCAma2RzdCwgc2NvcGVpZCwgMCwgMCwmbmg2KT09MCl7CiAJCWlm ICgobmg2Lm5oX2ZsYWdzICYgTkhGX0dBVEVXQVkpID09IDApIHsKIAkJCW5kNmxvZygoTE9HX0VS UiwKIAkJCSAgICAiSUNNUDYgcmVkaXJlY3QgcmVqZWN0ZWQ7IG5vIHJvdXRlICIKCg== --b1_af28b28da6507256460ae036304910f5-- From owner-freebsd-net@freebsd.org Mon Mar 6 05:12:47 2017 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 711A5CFA6D1 for ; Mon, 6 Mar 2017 05:12:47 +0000 (UTC) (envelope-from daemon-user@freebsd.org) Received: from reviews.nyi.freebsd.org (reviews.nyi.freebsd.org [IPv6:2610:1c1:1:607c::16:b]) by mx1.freebsd.org (Postfix) with ESMTP id 306B91CBF for ; Mon, 6 Mar 2017 05:12:47 +0000 (UTC) (envelope-from daemon-user@freebsd.org) Received: by reviews.nyi.freebsd.org (Postfix, from userid 1346) id 4998A1BB83; Mon, 6 Mar 2017 05:12:46 +0000 (UTC) Date: Mon, 6 Mar 2017 05:12:46 +0000 To: freebsd-net@freebsd.org From: "jhujhiti_adjectivism.org (Erick Turnquist)" Reply-to: D9451+325+eaa6f8a0c0731bfe@reviews.freebsd.org Subject: [Differential] D9451: Constrain IPv6 interface routes to each FIB Message-ID: <51b001cb7f7d0dbf9c31ab6695400b7e@localhost.localdomain> X-Priority: 3 X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: Thread-Topic: D9451: Constrain IPv6 interface routes to each FIB X-Herald-Rules: <28>, <81>, <51> X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: Precedence: bulk In-Reply-To: References: Thread-Index: MzA4MmVhNjA3MDYxYjk1ZGE4NzFjZWJhMzgyIFi8784= MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.23 List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 06 Mar 2017 05:12:47 -0000 amh1amhpdGlfYWRqZWN0aXZpc20ub3JnIGFkZGVkIGlubGluZSBjb21tZW50cy4KCklOTElORSBD T01NRU5UUwoKPiBhc29tZXJzIHdyb3RlIGluIG5kNi5jOjEyOTUKPiBZZXAsIGl0J3MgdHJ1ZS4g IE9uZSB3YXkgaXMgdG8gZG8gaXQgd2l0aCBzdGF0aWMgcm91dGVzLiAgQW5vdGhlciB3YXkgaW52 b2x2ZXMgY2hhbmdpbmcgdGhlIGludGVyZmFjZXMncyBmaWIuICBGb3IgZXhhbXBsZSwgbGlrZSB0 aGlzOgo+IAo+ICAgaWZjb25maWcgdGFwMCBjcmVhdGUKPiAgIGlmY29uZmlnIHRhcDAgMTAuMS4w LjEvMjQgZmliIDIKPiAgIGlmY29uZmlnIHRhcDAgMTAuMS4xLjEvMjQgZmliIDMgYWxpYXMKClRo YXQncy4uLiBjb3VudGVyLWludHVpdGl2ZS4gQnV0IGdpdmVuIHRoYXQgYmVoYXZpb3IsIHdlIGFi c29sdXRlbHkgc2hvdWxkIGNoZWNrIG90aGVyIG90aGVyIEZJQnMgaGVyZS4gVGhlIGZ1bmN0aW9u IGlzIGFscmVhZHkgbG9vcGluZyBvdmVyIGFsbCBwcmVmaXhlcyBvbiB0aGUgaW50ZXJmYWNlIHNv IEkgaW5zZXJ0ZWQgYSBjaGVjayBvZiBhbGwgRklCcyAoaWYgbmVjZXNzYXJ5KSBpbnNpZGUgb2Yg aXQuCgo+IGFzb21lcnMgd3JvdGUgaW4gbmQ2LmM6MTM1Mwo+IFRoZSBvcmlnaW5hbCBjb2RlIHNl ZW1zIHRvbyBjb21wbGljYXRlZC4gIEkgdGhpbmsgaXQgc2hvdWxkIGdvIGEgbGl0dGxlIGxpa2Ug dGhpcyAobG9ja3MgZWxpZGVkKToKPiAKPiAgIGlmIChpZnAtPmlmX2ZsYWdzICYgSUZGX1BPSU5U T1BPSU5UKSB7Cj4gICAgICAgICAgIFRBSUxRX0ZPUkVBQ0goaWZhLCAmaWZwLT5pZl9hZGRyaGVh ZCwgaWZhX2xpbmspIHsKPiAgIAkJCWlmIChpZmEtPmlmYV9hZGRyLT5zYV9mYW1pbHkgIT0gYWRk ci0+c2FfZmFtaWx5KQo+ICAgCQkJCWNvbnRpbnVlOwo+ICAgCQkJaWYgKGlmYS0+aWZhX2RzdGFk ZHIgIT0gTlVMTCAmJgo+ICAgCQkJICAgIHNhX2VxdWFsKGFkZHIsIGlmYS0+aWZhX2RzdGFkZHIp KSB7Cj4gICAJCQkJcmV0dXJuICgxKTsKPiAgIAkJCX0KPiAgIAkJfQo+ICAgfQo+IAo+IE5vIHVu bmVjZXNzYXJ5IGxvb3Bpbmcgb3ZlciBlaXRoZXIgZmlicyBvciBpbnRlcmZhY2VzLgoKVGhpcyBz ZWVtcyBsaWtlIGEgZ29vZCBpZGVhLiBJcyB0aGlzIG5ldyBjb2RlIHdoYXQgeW91IGhhZCBpbiBt aW5kPwoKPiBuZDZfcnRyLmM6NTc0Cj4gIAkgICAgKHN0cnVjdCBzb2NrYWRkciAqKSZnYXRlLAo+ IC0JICAgIChzdHJ1Y3Qgc29ja2FkZHIgKikmbWFzaywgUlRGX0dBVEVXQVksICZvbGRydCwgUlRf REVGQVVMVF9GSUIpOwo+ICsJICAgIChzdHJ1Y3Qgc29ja2FkZHIgKikmbWFzaywgUlRGX0dBVEVX QVksICZvbGRydCwgZHItPmlmcC0+aWZfZmliKTsKPiAgCWlmIChvbGRydCkgewoKSSdtIG5vdyB3 b25kZXJpbmcgaWYgdGhpcyBpcyBpbmNvcnJlY3QuIElmIHRoZSBpbnRlcmZhY2UncyBGSUIgY2hh bmdlcyBhZnRlciB0aGUgcm91dGVyIGhhcyBiZWVuIGFkZGVkIHRvIHRoZSBsaXN0LCB3ZSB3b3Vs ZCBmYWlsIHRvIHJlbW92ZSBpdCBoZXJlLgoKU2hvdWxkIHRoZSBkZWZhdWx0IHJvdXRlciAoYW5k IG1heWJlIHByZWZpeCkgc3RydWN0cyBpbmNsdWRlIGEgbmV3IGZpZWxkIHRvIHN0b3JlIHRoZSBG SUIgaW4gd2hpY2ggdGhlIHJvdXRlcigvcHJlZml4KSB3YXMgb3JpZ2luYWxseSBsZWFybmVkPwoK UkVQT1NJVE9SWQogIHJTIEZyZWVCU0Qgc3JjIHJlcG9zaXRvcnkKClJFVklTSU9OIERFVEFJTAog IGh0dHBzOi8vcmV2aWV3cy5mcmVlYnNkLm9yZy9EOTQ1MQoKRU1BSUwgUFJFRkVSRU5DRVMKICBo dHRwczovL3Jldmlld3MuZnJlZWJzZC5vcmcvc2V0dGluZ3MvcGFuZWwvZW1haWxwcmVmZXJlbmNl cy8KClRvOiBqaHVqaGl0aV9hZGplY3RpdmlzbS5vcmcsICNuZXR3b3JrLCBieiwgYXNvbWVycwpD YzogamNoLCBieiwgaW1wLCBhZSwgZnJlZWJzZC1uZXQtbGlzdAo= From owner-freebsd-net@freebsd.org Mon Mar 6 06:50:06 2017 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 7EE38CFB10F for ; Mon, 6 Mar 2017 06:50:06 +0000 (UTC) (envelope-from sebastian.huber@embedded-brains.de) Received: from dedi548.your-server.de (dedi548.your-server.de [85.10.215.148]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 3F3531D6B for ; Mon, 6 Mar 2017 06:50:05 +0000 (UTC) (envelope-from sebastian.huber@embedded-brains.de) Received: from [88.198.220.130] (helo=sslproxy01.your-server.de) by dedi548.your-server.de with esmtpsa (TLSv1.2:DHE-RSA-AES256-GCM-SHA384:256) (Exim 4.85_2) (envelope-from ) id 1ckmSz-0006Yn-2n for freebsd-net@freebsd.org; Mon, 06 Mar 2017 07:49:57 +0100 Received: from [82.135.62.35] (helo=mail.embedded-brains.de) by sslproxy01.your-server.de with esmtpsa (TLSv1.2:DHE-RSA-AES256-GCM-SHA384:256) (Exim 4.84_2) (envelope-from ) id 1ckmSy-0006lQ-Os for freebsd-net@freebsd.org; Mon, 06 Mar 2017 07:49:56 +0100 Received: from localhost (localhost.localhost [127.0.0.1]) by mail.embedded-brains.de (Postfix) with ESMTP id 8C1EC2A1805 for ; Mon, 6 Mar 2017 07:50:04 +0100 (CET) Received: from mail.embedded-brains.de ([127.0.0.1]) by localhost (zimbra.eb.localhost [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id 1cKXrkir_mKI; Mon, 6 Mar 2017 07:50:04 +0100 (CET) Received: from localhost (localhost.localhost [127.0.0.1]) by mail.embedded-brains.de (Postfix) with ESMTP id 259822A1804; Mon, 6 Mar 2017 07:50:04 +0100 (CET) X-Virus-Scanned: amavisd-new at zimbra.eb.localhost Received: from mail.embedded-brains.de ([127.0.0.1]) by localhost (zimbra.eb.localhost [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id WEDQ_dh5jSpR; Mon, 6 Mar 2017 07:50:04 +0100 (CET) Received: from huber-linux.eb.localhost (unknown [192.168.96.129]) by mail.embedded-brains.de (Postfix) with ESMTP id 05C912A17F3; Mon, 6 Mar 2017 07:50:04 +0100 (CET) From: Sebastian Huber To: freebsd-net@freebsd.org Cc: Sebastian Huber Subject: [PATCH 1/2] if_tsec: Fix MII communication Date: Mon, 6 Mar 2017 07:49:53 +0100 Message-Id: <1488782994-9064-1-git-send-email-sebastian.huber@embedded-brains.de> X-Mailer: git-send-email 1.8.4.5 X-Authenticated-Sender: smtp-embedded@poldinet.de X-Virus-Scanned: Clear (ClamAV 0.99.2/23174/Mon Mar 6 05:58:01 2017) X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 06 Mar 2017 06:50:06 -0000 Use a common tsec_mii_wait() function to busy wait for status changes. The status indicators are not set immediatly after a command. Discard the first value. Unlock the PHY mutex after a timeout in tsec_init_locked(). Tested on the P1020RDB. --- sys/dev/tsec/if_tsec.c | 58 +++++++++++++++++++++++++++----------------------- 1 file changed, 31 insertions(+), 27 deletions(-) diff --git a/sys/dev/tsec/if_tsec.c b/sys/dev/tsec/if_tsec.c index 3fd8726..927d339 100644 --- a/sys/dev/tsec/if_tsec.c +++ b/sys/dev/tsec/if_tsec.c @@ -357,13 +357,32 @@ tsec_init(void *xsc) TSEC_GLOBAL_UNLOCK(sc); } +static int +tsec_mii_wait(struct tsec_softc *sc, uint32_t flags) +{ + int timeout; + + /* + * The status indicators are not set immediatly after a command. + * Discard the first value. + */ + TSEC_PHY_READ(sc, TSEC_REG_MIIMIND); + + timeout = TSEC_READ_RETRY; + while ((TSEC_PHY_READ(sc, TSEC_REG_MIIMIND) & flags) && --timeout) + DELAY(TSEC_READ_DELAY); + + return (timeout == 0); +} + static void tsec_init_locked(struct tsec_softc *sc) { struct tsec_desc *tx_desc = sc->tsec_tx_vaddr; struct tsec_desc *rx_desc = sc->tsec_rx_vaddr; struct ifnet *ifp = sc->tsec_ifp; - uint32_t timeout, val, i; + uint32_t val, i; + int timeout; if (ifp->if_drv_flags & IFF_DRV_RUNNING) return; @@ -422,15 +441,13 @@ tsec_init_locked(struct tsec_softc *sc) TSEC_PHY_WRITE(sc, TSEC_REG_MIIMCFG, TSEC_MIIMCFG_CLKDIV28); /* Step 8: Read MII Mgmt indicator register and check for Busy = 0 */ - timeout = TSEC_READ_RETRY; - while (--timeout && (TSEC_PHY_READ(sc, TSEC_REG_MIIMIND) & - TSEC_MIIMIND_BUSY)) - DELAY(TSEC_READ_DELAY); - if (timeout == 0) { + timeout = tsec_mii_wait(sc, TSEC_MIIMIND_BUSY); + + TSEC_PHY_UNLOCK(sc); + if (timeout) { if_printf(ifp, "tsec_init_locked(): Mgmt busy timeout\n"); return; } - TSEC_PHY_UNLOCK(sc); /* Step 9: Setup the MII Mgmt */ mii_mediachg(sc->tsec_mii); @@ -1570,7 +1587,7 @@ int tsec_miibus_readreg(device_t dev, int phy, int reg) { struct tsec_softc *sc; - uint32_t timeout; + int timeout; int rv; sc = device_get_softc(dev); @@ -1579,18 +1596,11 @@ tsec_miibus_readreg(device_t dev, int phy, int reg) TSEC_PHY_WRITE(sc, TSEC_REG_MIIMADD, (phy << 8) | reg); TSEC_PHY_WRITE(sc, TSEC_REG_MIIMCOM, 0); TSEC_PHY_WRITE(sc, TSEC_REG_MIIMCOM, TSEC_MIIMCOM_READCYCLE); - - timeout = TSEC_READ_RETRY; - while (--timeout && TSEC_PHY_READ(sc, TSEC_REG_MIIMIND) & - (TSEC_MIIMIND_NOTVALID | TSEC_MIIMIND_BUSY)) - DELAY(TSEC_READ_DELAY); - - if (timeout == 0) - device_printf(dev, "Timeout while reading from PHY!\n"); - + timeout = tsec_mii_wait(sc, TSEC_MIIMIND_NOTVALID | TSEC_MIIMIND_BUSY); rv = TSEC_PHY_READ(sc, TSEC_REG_MIIMSTAT); TSEC_PHY_UNLOCK(); - + if (timeout) + device_printf(dev, "Timeout while reading from PHY!\n"); return (rv); } @@ -1598,23 +1608,17 @@ int tsec_miibus_writereg(device_t dev, int phy, int reg, int value) { struct tsec_softc *sc; - uint32_t timeout; + int timeout; sc = device_get_softc(dev); TSEC_PHY_LOCK(); TSEC_PHY_WRITE(sc, TSEC_REG_MIIMADD, (phy << 8) | reg); TSEC_PHY_WRITE(sc, TSEC_REG_MIIMCON, value); - - timeout = TSEC_READ_RETRY; - while (--timeout && (TSEC_READ(sc, TSEC_REG_MIIMIND) & - TSEC_MIIMIND_BUSY)) - DELAY(TSEC_READ_DELAY); + timeout = tsec_mii_wait(sc, TSEC_MIIMIND_BUSY); TSEC_PHY_UNLOCK(); - - if (timeout == 0) + if (timeout) device_printf(dev, "Timeout while writing to PHY!\n"); - return (0); } -- 1.8.4.5 From owner-freebsd-net@freebsd.org Mon Mar 6 06:50:06 2017 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 7FCD1CFB110 for ; Mon, 6 Mar 2017 06:50:06 +0000 (UTC) (envelope-from sebastian.huber@embedded-brains.de) Received: from dedi548.your-server.de (dedi548.your-server.de [85.10.215.148]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 3F3121D6A for ; Mon, 6 Mar 2017 06:50:05 +0000 (UTC) (envelope-from sebastian.huber@embedded-brains.de) Received: from [88.198.220.130] (helo=sslproxy01.your-server.de) by dedi548.your-server.de with esmtpsa (TLSv1.2:DHE-RSA-AES256-GCM-SHA384:256) (Exim 4.85_2) (envelope-from ) id 1ckmSy-0006Yi-UC for freebsd-net@freebsd.org; Mon, 06 Mar 2017 07:49:56 +0100 Received: from [82.135.62.35] (helo=mail.embedded-brains.de) by sslproxy01.your-server.de with esmtpsa (TLSv1.2:DHE-RSA-AES256-GCM-SHA384:256) (Exim 4.84_2) (envelope-from ) id 1ckmSy-0006ky-Mf for freebsd-net@freebsd.org; Mon, 06 Mar 2017 07:49:56 +0100 Received: from localhost (localhost.localhost [127.0.0.1]) by mail.embedded-brains.de (Postfix) with ESMTP id 856E32A17F4 for ; Mon, 6 Mar 2017 07:50:04 +0100 (CET) Received: from mail.embedded-brains.de ([127.0.0.1]) by localhost (zimbra.eb.localhost [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id Q9eDr_BPbape; Mon, 6 Mar 2017 07:50:04 +0100 (CET) Received: from localhost (localhost.localhost [127.0.0.1]) by mail.embedded-brains.de (Postfix) with ESMTP id 2A7882A1805; Mon, 6 Mar 2017 07:50:04 +0100 (CET) X-Virus-Scanned: amavisd-new at zimbra.eb.localhost Received: from mail.embedded-brains.de ([127.0.0.1]) by localhost (zimbra.eb.localhost [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id 4kmCulwJn2KS; Mon, 6 Mar 2017 07:50:04 +0100 (CET) Received: from huber-linux.eb.localhost (unknown [192.168.96.129]) by mail.embedded-brains.de (Postfix) with ESMTP id 10B302A17F4; Mon, 6 Mar 2017 07:50:04 +0100 (CET) From: Sebastian Huber To: freebsd-net@freebsd.org Cc: Sebastian Huber Subject: [PATCH 2/2] if_tsec: Fix set but not used warnings Date: Mon, 6 Mar 2017 07:49:54 +0100 Message-Id: <1488782994-9064-2-git-send-email-sebastian.huber@embedded-brains.de> X-Mailer: git-send-email 1.8.4.5 In-Reply-To: <1488782994-9064-1-git-send-email-sebastian.huber@embedded-brains.de> References: <1488782994-9064-1-git-send-email-sebastian.huber@embedded-brains.de> X-Authenticated-Sender: smtp-embedded@poldinet.de X-Virus-Scanned: Clear (ClamAV 0.99.2/23174/Mon Mar 6 05:58:01 2017) X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 06 Mar 2017 06:50:06 -0000 --- sys/dev/tsec/if_tsec.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/sys/dev/tsec/if_tsec.c b/sys/dev/tsec/if_tsec.c index 927d339..f544bd1 100644 --- a/sys/dev/tsec/if_tsec.c +++ b/sys/dev/tsec/if_tsec.c @@ -926,11 +926,8 @@ tsec_ioctl(struct ifnet *ifp, u_long command, caddr_t data) { struct tsec_softc *sc = ifp->if_softc; struct ifreq *ifr = (struct ifreq *)data; - device_t dev; int mask, error = 0; - dev = sc->dev; - switch (command) { case SIOCSIFMTU: TSEC_GLOBAL_LOCK(sc); @@ -1289,7 +1286,6 @@ tsec_receive_intr_locked(struct tsec_softc *sc, int count) struct ifnet *ifp; struct rx_data_type *rx_data; struct mbuf *m; - device_t dev; uint32_t i; int c, rx_npkts; uint16_t flags; @@ -1298,7 +1294,6 @@ tsec_receive_intr_locked(struct tsec_softc *sc, int count) ifp = sc->tsec_ifp; rx_data = sc->rx_data; - dev = sc->dev; rx_npkts = 0; bus_dmamap_sync(sc->tsec_rx_dtag, sc->tsec_rx_dmap, -- 1.8.4.5 From owner-freebsd-net@freebsd.org Mon Mar 6 08:06:05 2017 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id BA65ECFB615 for ; Mon, 6 Mar 2017 08:06:05 +0000 (UTC) (envelope-from sepherosa@gmail.com) Received: from mail-ua0-x22c.google.com (mail-ua0-x22c.google.com [IPv6:2607:f8b0:400c:c08::22c]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 762A61726 for ; Mon, 6 Mar 2017 08:06:05 +0000 (UTC) (envelope-from sepherosa@gmail.com) Received: by mail-ua0-x22c.google.com with SMTP id u30so26476414uau.0 for ; Mon, 06 Mar 2017 00:06:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=mPQjXPN7ZjSiC3lu4vKcArGYEmU9gcatLLJTEOAsDa4=; b=dv42g8lzAG7k/Df8w9oh7MyrmnTeKvS0IX/28C1QWO8EPbvxepE0GcxkjFt+Wq4ZEd TzFHMOYhxPghBQGq4QjjLp8HXm4kunkLOIzr7evKNLHw1zzsr29V5zTms/eM+/DEYjTu 2vN9hcfNR9NjGHlxLhazXJqSJ01th1cWA8uHsPeIinLDM/y120oeqHr0NJt2p3Udut1S sZ7B0Fb919UulqQpvjWaYHKFhAlXy4r76uuOAriaZ8+HdvDjZgGIL5r2wmaPRcK/r05r IEwwxoxJQZurwKYUlyP6gnGiHsdX24htd9vY5yUMLSJHpHHkQh83q4Sei8VzKQMZBJ2V wreg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=mPQjXPN7ZjSiC3lu4vKcArGYEmU9gcatLLJTEOAsDa4=; b=IfhelsApFOJeBrXXxBTHWIK8g0LmCLotRfodvGT++0+hOzCTizwOLE9jGKWhqUP0B9 42ZDsCSBb18k464za8WrNIy2xwFsrgAkK3kWjVWdtT0vy0pbpJiNHd2qs5odbSJcMSIe IO7gIH1sqqp+B13epw9hdCxKaANTDXn9xwuVnPFpMuDZ8EY6ve9t9Y9Wj8DEFNtYb8n9 ryBdJKmtbPTq/3kTmvhi6cEDcGdKAnsS5SXot0bObDAUkZpqQupp+dl5/B/x6ndHWyqx i7yTwG+9FWuoszCMlvcAkfncU3lEOMgIJ5otPC08YMLJohH5yxiROzx/fdtcCC5lgU1N nCFw== X-Gm-Message-State: AMke39nMQ+vRxf51nsjVxmIT6gbglth46TZum/vMIg8DW4xo09cRAyifYbL+7xYIcz2VIYOq4iXx47Yd4axB1g== X-Received: by 10.176.5.38 with SMTP id 35mr7003087uax.71.1488787564526; Mon, 06 Mar 2017 00:06:04 -0800 (PST) MIME-Version: 1.0 Received: by 10.176.66.193 with HTTP; Mon, 6 Mar 2017 00:06:03 -0800 (PST) In-Reply-To: <1946092.tUUkk3b7I7@energia> References: <1946092.tUUkk3b7I7@energia> From: Sepherosa Ziehau Date: Mon, 6 Mar 2017 16:06:03 +0800 Message-ID: Subject: Re: Why is MSI-X support disabled on bce(4)? To: Kajetan Staszkiewicz Cc: "freebsd-net@freebsd.org" Content-Type: text/plain; charset=UTF-8 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 06 Mar 2017 08:06:05 -0000 On Thu, Mar 2, 2017 at 10:02 PM, Kajetan Staszkiewicz wrote: > To whom it might concern: > > Well, at least it does concern me. Why is support for multiple interrupts and > queues not enabled on bce(4)? > > Whole block of code is surrounded with #ifdef 0 ... #endif > > https://github.com/freebsd/freebsd/blob/master/sys/dev/bce/if_bce.c#L1108 It involves much more work than the commented out MSI-X allocation, like this: https://gitweb.dragonflybsd.org/dragonfly.git/commitdiff/b42386ee03a4e688c864ba8d7094064c63d93dce?hp=be5708901d52be5534d5075eec706f5570b6a0f3 Thanks, sephe -- Tomorrow Will Never Die From owner-freebsd-net@freebsd.org Mon Mar 6 10:10:23 2017 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id BE37CCFAF4E for ; Mon, 6 Mar 2017 10:10:23 +0000 (UTC) (envelope-from milosz.kaniewski@gmail.com) Received: from mail-ua0-x22d.google.com (mail-ua0-x22d.google.com [IPv6:2607:f8b0:400c:c08::22d]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 7916D1D7B for ; Mon, 6 Mar 2017 10:10:23 +0000 (UTC) (envelope-from milosz.kaniewski@gmail.com) Received: by mail-ua0-x22d.google.com with SMTP id q7so126877196uaf.2 for ; Mon, 06 Mar 2017 02:10:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=n9i/P/EB2SzpCqzitENmIxsdbcP8NV2ewJRRUM6w+wA=; b=NK9/SgwwGZSs/XZo574igPcqCZ45fd/159JW6rMiJRNs3imOFhqHP2NZXhimRV5bry FOEK+F5en9MUwDKY5kItStbgl4MUFpAkFPG0T8BPdq4Gr5BM+1qtCGFAGx17BhL0pQxi IeACtPPHy6OuSXYJQja++GqlkDzL4VkaObhceglvIIWk12byDa+JGKJ+G2RJ8mga+YGp xTUfeHne46UmV2QsAwc0JOsbfXo/OiiWfE9wjTSOYLdCyYs/xe5xPgN7RV97Eo7wBI85 is+PKoEtz9wb6jVz+yXMzOi0K9T+Gj+dMkVF0e9On84lMxVxtvwbgg6u/MV1v7LrqPr7 +JJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=n9i/P/EB2SzpCqzitENmIxsdbcP8NV2ewJRRUM6w+wA=; b=Co3z1/e70XCg8h1DUs2ja+j0FzZDWTTnw6hER6w5YorJF244khN8CGx3OSKFo4CsXk COYE13T5YNjMstT4RltsC4UJyYG1MaWDJKGuwTgiSPIwuUVduZbJ7F7XukzAxeR171pU hle2uaGL3tvHBSNgm5vhqYFU7WrdSOOpjbmsNIyC0TiQapTo/PG5mIwGVIXdBT4Flrzt 2yIkWoCNkkfzlIRa/t2Q/tUKbXZacqBL2px0i1kU/LcL73ZPPVz18KHWmndoAXkZudgj 93EcKUONXAQ1yqFIyvGyJw/2frneC0RoI3TM6f2+3jqiD0qLW/tyBH45jrfzfVUwksDh n+kA== X-Gm-Message-State: AMke39mOnn7i6kQhp+U75eR3d/UgUx3lMuG2rV8Q8zSPWfxVHGrph2U8Mb1tV0nRux9J/9xSNOSrwht8W80a8A== X-Received: by 10.31.86.3 with SMTP id k3mr1303890vkb.154.1488795022387; Mon, 06 Mar 2017 02:10:22 -0800 (PST) MIME-Version: 1.0 Received: by 10.31.60.144 with HTTP; Mon, 6 Mar 2017 02:10:21 -0800 (PST) From: =?UTF-8?Q?Mi=C5=82osz_Kaniewski?= Date: Mon, 6 Mar 2017 11:10:21 +0100 Message-ID: Subject: RSS, cxgbe, netmap and non-TCP traffic To: freebsd-net@freebsd.org Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.23 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 06 Mar 2017 10:10:23 -0000 Hello, I am trying to split my traffic into two flows: 1. TCP traffic 2. Other traffic (non-TCP traffic) On my NIC (Chelsio T540-CR) I have configured 9 queues (these are Netmap queues configured with hw.cxgbe.nnmtx/rx sysctl) . Now I would like to direct TCP traffic to queues 0-7 and non-TCP traffic to queue number 8. To achieve this I have configured two filters using cxgbetool: cxgbetool t5nex0 filter 0 proto 6 hitcnts 1 cxgbetool t5nex0 filter 1 hitcnts 1 queue 8 tcbhash 1 And it seems ok because with such configuration non-TCP traffic is placed only at queue number 8 and TCP traffic is processed by RSS. But there is a problem because RSS uses all 9 queues and in result some TCP packets are also distibuted to queue number 8. My question is how to limit the number of queues that are used by RSS to 8 (queues 0-7)? I tried to set net.inet.rss.bits to "3" but it doesn't seems to changes anything. Thanks for your help. System information: freebsd-version: 11.0-STABLE hw.cxgbe.ntxq10g=1 hw.cxgbe.nrxq10g=1 hw.cxgbe.num_vis=2 hw.cxgbe.nnmtxq_vi=9 hw.cxgbe.nnmrxq_vi=9 From owner-freebsd-net@freebsd.org Mon Mar 6 11:30:13 2017 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 339E3CFBC02 for ; Mon, 6 Mar 2017 11:30:13 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 233A51C4B for ; Mon, 6 Mar 2017 11:30:13 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id v26BUBlu080929 for ; Mon, 6 Mar 2017 11:30:13 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-net@FreeBSD.org Subject: [Bug 216460] 82599ES 10-Gigabit SFI/SFP+ Network Connection link constantly flaps Date: Mon, 06 Mar 2017 11:30:12 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 11.0-RELEASE X-Bugzilla-Keywords: IntelNetworking X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: jlegato@gmail.com X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-net@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 06 Mar 2017 11:30:13 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D216460 --- Comment #2 from John Legato --- Thanks for the reply. In the interest of time, I swapped the card out for a Mellanox NIC so I'm unable to test the Intel card. --=20 You are receiving this mail because: You are the assignee for the bug.= From owner-freebsd-net@freebsd.org Mon Mar 6 20:05:43 2017 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 11A5BCFC431 for ; Mon, 6 Mar 2017 20:05:43 +0000 (UTC) (envelope-from daemon-user@freebsd.org) Received: from reviews.nyi.freebsd.org (reviews.nyi.freebsd.org [IPv6:2610:1c1:1:607c::16:b]) by mx1.freebsd.org (Postfix) with ESMTP id DEAE9180F for ; Mon, 6 Mar 2017 20:05:42 +0000 (UTC) (envelope-from daemon-user@freebsd.org) Received: by reviews.nyi.freebsd.org (Postfix, from userid 1346) id 4E2941B031; Mon, 6 Mar 2017 20:05:42 +0000 (UTC) Date: Mon, 6 Mar 2017 20:05:42 +0000 To: freebsd-net@freebsd.org From: "asomers (Alan Somers)" Reply-to: D9451+325+eaa6f8a0c0731bfe@reviews.freebsd.org Subject: [Differential] D9451: Constrain IPv6 interface routes to each FIB Message-ID: X-Priority: 3 X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: Thread-Topic: D9451: Constrain IPv6 interface routes to each FIB X-Herald-Rules: <28>, <81>, <51> X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: Precedence: bulk In-Reply-To: References: Thread-Index: MzA4MmVhNjA3MDYxYjk1ZGE4NzFjZWJhMzgyIFi9wRY= MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.23 List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 06 Mar 2017 20:05:43 -0000 YXNvbWVycyBhZGRlZCBhIGNvbW1lbnQuCgoKICBBbG1vc3QgZG9uZS4gIEkgdGhpbmsgdGhlIG9u bHkgdGhpbmcgbGVmdCBpcyB0byBkZWxldGUgYWxsIG9mIHRoZSByZWxhdGVkIGF0Zl9leHBlY3Rf ZmFpbCBzdGF0ZW1lbnRzIGZyb20gZmlic190ZXN0LnNoLCBub3QganVzdCBvbmUuCgpJTkxJTkUg Q09NTUVOVFMKCj4gamh1amhpdGlfYWRqZWN0aXZpc20ub3JnIHdyb3RlIGluIG5kNi5jOjEzNTMK PiBUaGlzIHNlZW1zIGxpa2UgYSBnb29kIGlkZWEuIElzIHRoaXMgbmV3IGNvZGUgd2hhdCB5b3Ug aGFkIGluIG1pbmQ/CgpZZXAuCgo+IGpodWpoaXRpX2FkamVjdGl2aXNtLm9yZyB3cm90ZSBpbiBu ZDZfcnRyLmM6NTc0Cj4gSSdtIG5vdyB3b25kZXJpbmcgaWYgdGhpcyBpcyBpbmNvcnJlY3QuIElm IHRoZSBpbnRlcmZhY2UncyBGSUIgY2hhbmdlcyBhZnRlciB0aGUgcm91dGVyIGhhcyBiZWVuIGFk ZGVkIHRvIHRoZSBsaXN0LCB3ZSB3b3VsZCBmYWlsIHRvIHJlbW92ZSBpdCBoZXJlLgo+IAo+IFNo b3VsZCB0aGUgZGVmYXVsdCByb3V0ZXIgKGFuZCBtYXliZSBwcmVmaXgpIHN0cnVjdHMgaW5jbHVk ZSBhIG5ldyBmaWVsZCB0byBzdG9yZSB0aGUgRklCIGluIHdoaWNoIHRoZSByb3V0ZXIoL3ByZWZp eCkgd2FzIG9yaWdpbmFsbHkgbGVhcm5lZD8KCkkgdGhpbmsgdGhhdCdzIGEgbGltaXRhdGlvbiBv ZiB0aGUgZGVzaWduIG9mIG91ciBuZXR3b3JrIHN0YWNrLCBhbmQgSSBkb24ndCB0aGluayB0aGF0 IGZpeGluZyBpdCBzaG91bGQgYmUgYSBwYXJ0IG9mIHRoaXMgY2hhbmdlLiAgSSB0aGluayB0aGF0 IGZpeGluZyB3b3VsZCByZXF1aXJlIGVpdGhlcjoKCjEuIEFzc29jaWF0ZSBhIGZpYiB3aXRoIGVh Y2ggaWZhZGRyLCBhbmQgZGVsZXRlIHRoZSBuZXR3b3JrIGFuZCBob3N0IHJvdXRlcyB3aGVuZXZl ciB0aGUgaWZhZGRyIGlzIGRlbGV0ZWQsIG9yCjIuIFN0b3JlIGV4dHJhIGluZm9ybWF0aW9uIHdp dGggZWFjaCByb3V0ZSwgc3VjaCBhcyB3aHkgdGhleSB3ZXJlIGFkZGVkIHRvIHRoZSByb3V0aW5n IHRhYmxlLgoKUkVQT1NJVE9SWQogIHJTIEZyZWVCU0Qgc3JjIHJlcG9zaXRvcnkKClJFVklTSU9O IERFVEFJTAogIGh0dHBzOi8vcmV2aWV3cy5mcmVlYnNkLm9yZy9EOTQ1MQoKRU1BSUwgUFJFRkVS RU5DRVMKICBodHRwczovL3Jldmlld3MuZnJlZWJzZC5vcmcvc2V0dGluZ3MvcGFuZWwvZW1haWxw cmVmZXJlbmNlcy8KClRvOiBqaHVqaGl0aV9hZGplY3RpdmlzbS5vcmcsICNuZXR3b3JrLCBieiwg YXNvbWVycwpDYzogamNoLCBieiwgaW1wLCBhZSwgZnJlZWJzZC1uZXQtbGlzdAo= From owner-freebsd-net@freebsd.org Mon Mar 6 22:32:48 2017 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id D036AD00E2C for ; Mon, 6 Mar 2017 22:32:48 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id BFDA51766 for ; Mon, 6 Mar 2017 22:32:48 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id v26MWmcG043056 for ; Mon, 6 Mar 2017 22:32:48 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-net@FreeBSD.org Subject: [Bug 209581] igb vf driver does not correctly handle vlan tag Date: Mon, 06 Mar 2017 22:32:48 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 10.3-RELEASE X-Bugzilla-Keywords: IntelNetworking X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: ingenium@gmail.com X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-net@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: cc Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 06 Mar 2017 22:32:48 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D209581 ingenium@gmail.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ingenium@gmail.com --- Comment #2 from ingenium@gmail.com --- Has there been any update on this? It is also affecting me. I can supply any additional information that's needed. --=20 You are receiving this mail because: You are the assignee for the bug.= From owner-freebsd-net@freebsd.org Mon Mar 6 23:11:57 2017 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id EB7A9CFBC65 for ; Mon, 6 Mar 2017 23:11:57 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id D545C100F for ; Mon, 6 Mar 2017 23:11:57 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id v26NBvdJ043883 for ; Mon, 6 Mar 2017 23:11:57 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-net@FreeBSD.org Subject: [Bug 209581] igb vf driver does not correctly handle vlan tag Date: Mon, 06 Mar 2017 23:11:57 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 10.3-RELEASE X-Bugzilla-Keywords: IntelNetworking X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: ingenium@gmail.com X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-net@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 06 Mar 2017 23:11:58 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D209581 --- Comment #3 from ingenium@gmail.com --- (In reply to ingenium from comment #2) It looks like there may be a newer version of the Intel driver? Is it possi= ble it contains the necessary fixes? https://downloadcenter.intel.com/download/15815/Intel-Network-Adapter-Drive= r-for-82575-6-and-82580-based-Gigabit-Network-Connections-under-FreeBSD- --=20 You are receiving this mail because: You are the assignee for the bug.= From owner-freebsd-net@freebsd.org Tue Mar 7 05:48:31 2017 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 8E110D01A72 for ; Tue, 7 Mar 2017 05:48:31 +0000 (UTC) (envelope-from nparhar@gmail.com) Received: from mail-pg0-x22c.google.com (mail-pg0-x22c.google.com [IPv6:2607:f8b0:400e:c05::22c]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 5C18A1277 for ; Tue, 7 Mar 2017 05:48:31 +0000 (UTC) (envelope-from nparhar@gmail.com) Received: by mail-pg0-x22c.google.com with SMTP id b129so74895469pgc.2 for ; Mon, 06 Mar 2017 21:48:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:mail-followup-to :references:mime-version:content-disposition :content-transfer-encoding:in-reply-to:user-agent; bh=wksC5G//VuG0edyP+ofLqx18DrhqHj88CW1YGy1LoIU=; b=sfK+nfif5t6gZmqh7bqqhN9wJDbBhQ4kjD/mm7WoKUZEuWpgLjqs9Zc78SIXTZ9WWB m9geZL9MebBAf7ScPX0EG/+XakOiO9mNpAwb99JrZNU6nW3aUAVPLzwbGGF5Zz93k64G GlDI+POJ0Bom6uJ6/aGopfeYiu2pjemEqm9fXAwjqWYvc2CMHzih5p5RYCZ5jn8pbTQn vDDwT1YiAW7hjMG++kZdvBTTQa/TYmYV3HJ2BqXzxC6rFBVJxJ5l7hHSA9anUwgEsPbJ tkoYiRwy2rr2inAtVjG2ygNX+0u4dfNYK8/BKmTxNseW0mwlsfMxubFtqAhgmo3fZ65E ho1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :content-transfer-encoding:in-reply-to:user-agent; bh=wksC5G//VuG0edyP+ofLqx18DrhqHj88CW1YGy1LoIU=; b=GVETi/0p63qRpsDK/wpaxriPB2/dmSmEhdMDbmqmC192HbQFpE9pQaeUuw6QGXIUVA GFqnmkW6q63wdsxGyCNXGJ3CDPscQEvsoGkqvwIAZqhWtuzanlbXY4ezFZXkQHAG13lJ 1sTUyqVY53Pu2obObB84DOULrLq6nj9rwBDdAu4KjdVXSFPKXwypBOsKqEARybI6dwff LoQAkRSnYkP9dWzlzAhPltda3eZvSaq7t2Lrk6YDW6vq4Ko6e9yaKF2Cj1yEeAcVYyjo U/529uuENvbmdFTNSuRjrv7eIt5f3A/zBTbsWoPtC9Y18mkFlA6SnRuN24Ze+iCgrpJH Lkzw== X-Gm-Message-State: AMke39nWQq0u4PbvacTJIWLmSVCXXRKvVmILabh8KIJ8EmNWaVoLdBIBw68WpteBd1XZ+w== X-Received: by 10.84.197.3 with SMTP id m3mr31990128pld.89.1488865710683; Mon, 06 Mar 2017 21:48:30 -0800 (PST) Received: from ox ([2601:641:c000:b800:184b:905b:e95a:39fb]) by smtp.gmail.com with ESMTPSA id v186sm43073137pgv.44.2017.03.06.21.48.29 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 06 Mar 2017 21:48:29 -0800 (PST) Sender: Navdeep Parhar Date: Mon, 6 Mar 2017 21:48:27 -0800 From: Navdeep Parhar To: =?utf-8?Q?Mi=C5=82osz?= Kaniewski Cc: freebsd-net@freebsd.org Subject: Re: RSS, cxgbe, netmap and non-TCP traffic Message-ID: <20170307054827.GB12859@ox> Mail-Followup-To: =?utf-8?Q?Mi=C5=82osz?= Kaniewski , freebsd-net@freebsd.org References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 07 Mar 2017 05:48:31 -0000 On Mon, Mar 06, 2017 at 11:10:21AM +0100, Miłosz Kaniewski wrote: > Hello, > > I am trying to split my traffic into two flows: > 1. TCP traffic > 2. Other traffic (non-TCP traffic) > > On my NIC (Chelsio T540-CR) I have configured 9 queues (these are > Netmap queues configured with hw.cxgbe.nnmtx/rx sysctl) . Now I would > like to direct TCP traffic to queues 0-7 and non-TCP traffic to queue > number 8. To achieve this I have configured two filters using cxgbetool: > > cxgbetool t5nex0 filter 0 proto 6 hitcnts 1 > cxgbetool t5nex0 filter 1 hitcnts 1 queue 8 tcbhash 1 hitcnts 1 is the default, tcbhash is unnecessary, and queue# should be the cntxt_id of the netmap rxq that you want to steer traffic to. Use something like this to get the cntxt_id: # sysctl dev.cxl | grep rxq | grep cntxt_id | grep -vw fl # cxgbetool t5nex0 filter 0 proto 6 action pass # cxgbetool t5nex0 filter 1 action pass queue I'd also recommend that you explicitly provide the physical port# for the traffic you're trying to steer to avoid surprises. For example, with the above rules you'll have _all_ non-TCP traffic on all ports sent to queue . This is likely not what you want. You can refine your rules with "iport port#". # cxgbetool t5nex0 filter 1 iport 0 action pass queue (this will steer traffic that shows up on port 0 only) > > And it seems ok because with such configuration non-TCP traffic is > placed only at queue number 8 and TCP traffic is processed by RSS. But > there is a problem because RSS uses all 9 queues and in result some > TCP packets are also distibuted to queue number 8. > > My question is how to limit the number of queues that are used by RSS > to 8 (queues 0-7)? I tried to set net.inet.rss.bits to "3" but it doesn't > seems to changes anything. You'll need to modify the driver to do this. Do not put the queue for non-TCP traffic in the indirection table and traffic subject to RSS will never arrive on that queue. In this sample diff, the last queue is not put in the indirection table and you should use the cntxt_id of this queue when trying to steer non-TCP traffic to it. --- a/sys/dev/cxgbe/t4_netmap.c Tue Feb 28 12:58:56 2017 -0800 +++ b/sys/dev/cxgbe/t4_netmap.c Mon Mar 06 21:32:03 2017 -0800 @@ -384,6 +384,8 @@ cxgbe_netmap_on(struct adapter *sc, stru } for (i = 0; i < vi->rss_size;) { for_each_nm_rxq(vi, j, nm_rxq) { + if (j == vi->nnmrxq - 1) + break; vi->nm_rss[i++] = nm_rxq->iq_abs_id; if (i == vi->rss_size) break; Regards, Navdeep From owner-freebsd-net@freebsd.org Tue Mar 7 05:54:29 2017 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 8EA81D01D58 for ; Tue, 7 Mar 2017 05:54:29 +0000 (UTC) (envelope-from daemon-user@freebsd.org) Received: from reviews.nyi.freebsd.org (reviews.nyi.freebsd.org [IPv6:2610:1c1:1:607c::16:b]) by mx1.freebsd.org (Postfix) with ESMTP id 3A862198A for ; Tue, 7 Mar 2017 05:54:29 +0000 (UTC) (envelope-from daemon-user@freebsd.org) Received: by reviews.nyi.freebsd.org (Postfix, from userid 1346) id 9A8171B750; Tue, 7 Mar 2017 05:54:28 +0000 (UTC) Date: Tue, 7 Mar 2017 05:54:28 +0000 To: freebsd-net@freebsd.org From: "jhujhiti_adjectivism.org (Erick Turnquist)" Reply-to: D9451+325+eaa6f8a0c0731bfe@reviews.freebsd.org Subject: [Differential] D9451: Constrain IPv6 interface routes to each FIB Message-ID: X-Priority: 3 X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: , Thread-Topic: D9451: Constrain IPv6 interface routes to each FIB X-Herald-Rules: <28>, <81>, <51> X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: Precedence: bulk In-Reply-To: References: Thread-Index: MzA4MmVhNjA3MDYxYjk1ZGE4NzFjZWJhMzgyIFi+SxQ= MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="b1_b0d313e58e33da16a81af0fc9092492c" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.23 List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 07 Mar 2017 05:54:29 -0000 --b1_b0d313e58e33da16a81af0fc9092492c Content-Type: text/plain; charset = "utf-8" Content-Transfer-Encoding: base64 amh1amhpdGlfYWRqZWN0aXZpc20ub3JnIHVwZGF0ZWQgdGhpcyByZXZpc2lvbiB0byBEaWZmIDI2 MDUzLgpqaHVqaGl0aV9hZGplY3RpdmlzbS5vcmcgbWFya2VkIDE0IGlubGluZSBjb21tZW50cyBh cyBkb25lLgoKUkVQT1NJVE9SWQogIHJTIEZyZWVCU0Qgc3JjIHJlcG9zaXRvcnkKCkNIQU5HRVMg U0lOQ0UgTEFTVCBVUERBVEUKICBodHRwczovL3Jldmlld3MuZnJlZWJzZC5vcmcvRDk0NTE/dnM9 MjYwMjImaWQ9MjYwNTMKClJFVklTSU9OIERFVEFJTAogIGh0dHBzOi8vcmV2aWV3cy5mcmVlYnNk Lm9yZy9EOTQ1MQoKQUZGRUNURUQgRklMRVMKICBzeXMvbmV0aW5ldDYvaWNtcDYuYwogIHN5cy9u ZXRpbmV0Ni9pbjYuYwogIHN5cy9uZXRpbmV0Ni9pbjZfc3JjLmMKICBzeXMvbmV0aW5ldDYvbmQ2 LmMKICBzeXMvbmV0aW5ldDYvbmQ2LmgKICBzeXMvbmV0aW5ldDYvbmQ2X25ici5jCiAgc3lzL25l dGluZXQ2L25kNl9ydHIuYwogIHRlc3RzL3N5cy9uZXRpbmV0L2ZpYnNfdGVzdC5zaAoKRU1BSUwg UFJFRkVSRU5DRVMKICBodHRwczovL3Jldmlld3MuZnJlZWJzZC5vcmcvc2V0dGluZ3MvcGFuZWwv ZW1haWxwcmVmZXJlbmNlcy8KClRvOiBqaHVqaGl0aV9hZGplY3RpdmlzbS5vcmcsICNuZXR3b3Jr LCBieiwgYXNvbWVycwpDYzogamNoLCBieiwgaW1wLCBhZSwgZnJlZWJzZC1uZXQtbGlzdAo= --b1_b0d313e58e33da16a81af0fc9092492c Content-Type: text/x-patch; charset=utf-8; name="D9451.26053.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="D9451.26053.patch" ZGlmZiAtLWdpdCBhL3Rlc3RzL3N5cy9uZXRpbmV0L2ZpYnNfdGVzdC5zaCBiL3Rlc3RzL3N5cy9u ZXRpbmV0L2ZpYnNfdGVzdC5zaAotLS0gYS90ZXN0cy9zeXMvbmV0aW5ldC9maWJzX3Rlc3Quc2gK KysrIGIvdGVzdHMvc3lzL25ldGluZXQvZmlic190ZXN0LnNoCkBAIC0xNjMsNyArMTYzLDYgQEAK IAogbG9vcGJhY2tfYW5kX25ldHdvcmtfcm91dGVzX29uX25vbmRlZmF1bHRfZmliX2luZXQ2X2Jv ZHkoKQogewotCWF0Zl9leHBlY3RfZmFpbCAiUFIxOTYzNjEgSVB2NiBuZXR3b3JrIHJvdXRlcyBk b24ndCByZXNwZWN0IG5ldC5hZGRfYWRkcl9hbGxmaWJzPTAiCiAJIyBDb25maWd1cmUgdGhlIFRB UCBpbnRlcmZhY2UgdG8gdXNlIGEgbm9ucm91dGVhYmxlIFJGQzM4NDkKIAkjIGFkZHJlc3MgYW5k IGEgbm9uLWRlZmF1bHQgZmliCiAJQUREUj0iMjAwMTpkYjg6OjIiCkBAIC00NTksOCArNDU4LDYg QEAKIAlTVUJORVQ9IjIwMDE6ZGI4OiIKIAlNQVNLPSI2NCIKIAotCWF0Zl9leHBlY3RfZmFpbCAi UFIxOTYzNjEgSVB2NiBuZXR3b3JrIHJvdXRlcyBkb24ndCByZXNwZWN0IG5ldC5hZGRfYWRkcl9h bGxmaWJzPTAiCi0KIAkjIENoZWNrIHN5c3RlbSBjb25maWd1cmF0aW9uCiAJaWYgWyAwICE9IGBz eXNjdGwgLW4gbmV0LmFkZF9hZGRyX2FsbGZpYnNgIF07IHRoZW4KIAkJYXRmX3NraXAgIlRoaXMg dGVzdCByZXF1aXJlcyBuZXQuYWRkX2FkZHJfYWxsZmlicz0wIgpAQCAtNDc3LDYgKzQ3NCw3IEBA CiAKIAkjIENvbmZpZ3VyZSBlcGFpciBpbnRlcmZhY2VzCiAJZ2V0X2VwYWlyCisJc2xlZXAgMQog CXNldHVwX2lmYWNlICIkRVBBSVJBIiAiJEZJQjAiIGluZXQ2ICR7QUREUn0gJHtNQVNLfQogCWVj aG8gaWZjb25maWcgIiRFUEFJUkIiIHVwIGluZXQ2IGZpYiAkRklCMSAtaWZkaXNhYmxlZCBhY2Nl cHRfcnRhZHYKIAlpZmNvbmZpZyAiJEVQQUlSQiIgaW5ldDYgLWlmZGlzYWJsZWQgYWNjZXB0X3J0 YWR2IGZpYiAkRklCMSB1cApAQCAtNjg1LDggKzY4Myw2IEBACiAJVEFSR0VUPSIyMDAxOmRiODo6 MTAwIgogCVNSQ0RJUj1gYXRmX2dldF9zcmNkaXJgCiAKLQlhdGZfZXhwZWN0X2ZhaWwgIlBSMTk2 MzYxIElQdjYgbmV0d29yayByb3V0ZXMgZG9uJ3QgcmVzcGVjdCBuZXQuYWRkX2FkZHJfYWxsZmli cz0wIgotCiAJIyBDaGVjayBzeXN0ZW0gY29uZmlndXJhdGlvbgogCWlmIFsgMCAhPSBgc3lzY3Rs IC1uIG5ldC5hZGRfYWRkcl9hbGxmaWJzYCBdOyB0aGVuCiAJCWF0Zl9za2lwICJUaGlzIHRlc3Qg cmVxdWlyZXMgbmV0LmFkZF9hZGRyX2FsbGZpYnM9MCIKQEAgLTc2Nyw3ICs3NjMsNyBAQAogCWxv Y2FsIEVQQUlSRAogCiAJaWYgRVBBSVJEPWBpZmNvbmZpZyBlcGFpciBjcmVhdGVgOyB0aGVuCi0J CSMgUmVjb3JkIHRoZSBUQVAgZGV2aWNlIHNvIHdlIGNhbiBjbGVhbiBpdCB1cCBsYXRlcgorCQkj IFJlY29yZCB0aGUgZXBhaXIgZGV2aWNlIHNvIHdlIGNhbiBjbGVhbiBpdCB1cCBsYXRlcgogCQll Y2hvICR7RVBBSVJEfSA+PiAiaWZhY2VzX3RvX2NsZWFudXAiCiAJCUVQQUlSQT0ke0VQQUlSRH0K IAkJRVBBSVJCPSR7RVBBSVJEJWF9YgpkaWZmIC0tZ2l0IGEvc3lzL25ldGluZXQ2L25kNl9ydHIu YyBiL3N5cy9uZXRpbmV0Ni9uZDZfcnRyLmMKLS0tIGEvc3lzL25ldGluZXQ2L25kNl9ydHIuYwor KysgYi9zeXMvbmV0aW5ldDYvbmQ2X3J0ci5jCkBAIC01MDAsNyArNTAwLDcgQEAKIAogCWVycm9y ID0gaW42X3J0cmVxdWVzdChSVE1fQURELCAoc3RydWN0IHNvY2thZGRyICopJmRlZiwKIAkgICAg KHN0cnVjdCBzb2NrYWRkciAqKSZnYXRlLCAoc3RydWN0IHNvY2thZGRyICopJm1hc2ssCi0JICAg IFJURl9HQVRFV0FZLCAmbmV3cnQsIFJUX0RFRkFVTFRfRklCKTsKKwkgICAgUlRGX0dBVEVXQVks ICZuZXdydCwgbmV3LT5pZnAtPmlmX2ZpYik7CiAJaWYgKG5ld3J0KSB7CiAJCW5kNl9ydG1zZyhS VE1fQURELCBuZXdydCk7IC8qIHRlbGwgdXNlciBwcm9jZXNzICovCiAJCVJURlJFRShuZXdydCk7 CkBAIC01NTEsOCArNTUxLDggQEAKIAogLyoKICAqIFJlbW92ZSB0aGUgZGVmYXVsdCByb3V0ZSBm b3IgYSBnaXZlbiByb3V0ZXIuCi0gKiBUaGlzIGlzIGp1c3QgYSBzdWJyb3V0aW5lIGZ1bmN0aW9u IGZvciBkZWZyb3V0ZXJfc2VsZWN0KCksIGFuZCBzaG91bGQKLSAqIG5vdCBiZSBjYWxsZWQgZnJv bSBhbnl3aGVyZSBlbHNlLgorICogVGhpcyBpcyBqdXN0IGEgc3Vicm91dGluZSBmdW5jdGlvbiBm b3IgZGVmcm91dGVyX3NlbGVjdF9maWIoKSwgYW5kCisgKiBzaG91bGQgbm90IGJlIGNhbGxlZCBm cm9tIGFueXdoZXJlIGVsc2UuCiAgKi8KIHN0YXRpYyB2b2lkCiBkZWZyb3V0ZXJfZGVscmVxKHN0 cnVjdCBuZF9kZWZyb3V0ZXIgKmRyKQpAQCAtNTcxLDcgKzU3MSw3IEBACiAKIAlpbjZfcnRyZXF1 ZXN0KFJUTV9ERUxFVEUsIChzdHJ1Y3Qgc29ja2FkZHIgKikmZGVmLAogCSAgICAoc3RydWN0IHNv Y2thZGRyICopJmdhdGUsCi0JICAgIChzdHJ1Y3Qgc29ja2FkZHIgKikmbWFzaywgUlRGX0dBVEVX QVksICZvbGRydCwgUlRfREVGQVVMVF9GSUIpOworCSAgICAoc3RydWN0IHNvY2thZGRyICopJm1h c2ssIFJURl9HQVRFV0FZLCAmb2xkcnQsIGRyLT5pZnAtPmlmX2ZpYik7CiAJaWYgKG9sZHJ0KSB7 CiAJCW5kNl9ydG1zZyhSVE1fREVMRVRFLCBvbGRydCk7CiAJCVJURlJFRShvbGRydCk7CkBAIC02 OTgsMTEgKzY5OCwxMSBAQAogCiAJLyoKIAkgKiBJZiB0aGUgcm91dGVyIGlzIHRoZSBwcmltYXJ5 IG9uZSwgY2hvb3NlIGEgbmV3IG9uZS4KLQkgKiBOb3RlIHRoYXQgZGVmcm91dGVyX3NlbGVjdCgp IHdpbGwgcmVtb3ZlIHRoZSBjdXJyZW50IGdhdGV3YXkKLQkgKiBmcm9tIHRoZSByb3V0aW5nIHRh YmxlLgorCSAqIE5vdGUgdGhhdCBkZWZyb3V0ZXJfc2VsZWN0X2ZpYigpIHdpbGwgcmVtb3ZlIHRo ZSBjdXJyZW50CisgICAgICAgICAqIGdhdGV3YXkgZnJvbSB0aGUgcm91dGluZyB0YWJsZS4KIAkg Ki8KIAlpZiAoZGVsZHIpCi0JCWRlZnJvdXRlcl9zZWxlY3QoKTsKKwkJZGVmcm91dGVyX3NlbGVj dF9maWIoZGVsZHItPmlmcC0+aWZfZmliKTsKIAogCS8qCiAJICogUmVsZWFzZSB0aGUgbGlzdCBy ZWZlcmVuY2UuCkBAIC03MzAsMTMgKzczMCwyMyBAQAogICogZXZlbiB3aGVuIHRoZSBtdWx0aXBh dGggcm91dGluZyBpcyBhdmFpbGFibGUsIGJlY2F1c2Ugd2UncmUgbm90IHN1cmUgYWJvdXQKICAq IHRoZSBiZW5lZml0cyBmb3Igc3R1YiBob3N0cyBjb21wYXJpbmcgdG8gdGhlIHJpc2sgb2YgbWFr aW5nIHRoZSBjb2RlCiAgKiBjb21wbGljYXRlZCBhbmQgdGhlIHBvc3NpYmlsaXR5IG9mIGludHJv ZHVjaW5nIGJ1Z3MuCisgKgorICogV2UgbWFpbnRhaW4gYSBzaW5nbGUgbGlzdCBvZiByb3V0ZXJz IGZvciBtdWx0aXBsZSBGSUJzLCBvbmx5IGNvbnNpZGVyaW5nIG9uZQorICogYXQgYSB0aW1lIGJh c2VkIG9uIHRoZSByZWNlaXZpbmcgaW50ZXJmYWNlJ3MgRklCLiBJZiBAZmlibnVtIGlzIFJUX0FM TF9GSUJTLAorICogd2UgZG8gdGhlIHdob2xlIHRoaW5nIG11bHRpcGxlIHRpbWVzLgogICovCiB2 b2lkCi1kZWZyb3V0ZXJfc2VsZWN0KHZvaWQpCitkZWZyb3V0ZXJfc2VsZWN0X2ZpYihpbnQgZmli bnVtKQogewogCXN0cnVjdCBuZF9kZWZyb3V0ZXIgKmRyLCAqc2VsZWN0ZWRfZHIsICppbnN0YWxs ZWRfZHI7CiAJc3RydWN0IGxsZW50cnkgKmxuID0gTlVMTDsKIAorCWlmIChmaWJudW0gPT0gUlRf QUxMX0ZJQlMpIHsKKwkJZm9yIChmaWJudW0gPSAwOyBmaWJudW0gPCBydF9udW1maWJzOyBmaWJu dW0rKykgeworCQkJZGVmcm91dGVyX3NlbGVjdF9maWIoZmlibnVtKTsKKwkJfQorCX0KKwogCU5E Nl9STE9DSygpOwogCS8qCiAJICogTGV0J3MgaGFuZGxlIGVhc3kgY2FzZSAoMykgZmlyc3Q6CkBA IC03NTUsNyArNzY1LDcgQEAKIAlzZWxlY3RlZF9kciA9IGluc3RhbGxlZF9kciA9IE5VTEw7CiAJ VEFJTFFfRk9SRUFDSChkciwgJlZfbmRfZGVmcm91dGVyLCBkcl9lbnRyeSkgewogCQlJRl9BRkRB VEFfUkxPQ0soZHItPmlmcCk7Ci0JCWlmIChzZWxlY3RlZF9kciA9PSBOVUxMICYmCisJCWlmIChz ZWxlY3RlZF9kciA9PSBOVUxMICYmIGRyLT5pZnAtPmlmX2ZpYiA9PSBmaWJudW0gJiYKIAkJICAg IChsbiA9IG5kNl9sb29rdXAoJmRyLT5ydGFkZHIsIDAsIGRyLT5pZnApKSAmJgogCQkgICAgTkQ2 X0lTX0xMSU5GT19QUk9CUkVBQ0gobG4pKSB7CiAJCQlzZWxlY3RlZF9kciA9IGRyOwpAQCAtNzY3 LDE0ICs3NzcsMTcgQEAKIAkJCWxuID0gTlVMTDsKIAkJfQogCi0JCWlmIChkci0+aW5zdGFsbGVk KSB7CisJCWlmIChkci0+aW5zdGFsbGVkICYmIGRyLT5pZnAtPmlmX2ZpYiA9PSBmaWJudW0pIHsK IAkJCWlmIChpbnN0YWxsZWRfZHIgPT0gTlVMTCkgewogCQkJCWluc3RhbGxlZF9kciA9IGRyOwog CQkJCWRlZnJvdXRlcl9yZWYoaW5zdGFsbGVkX2RyKTsKIAkJCX0gZWxzZSB7Ci0JCQkJLyogdGhp cyBzaG91bGQgbm90IGhhcHBlbi4gIHdhcm4gZm9yIGRpYWdub3Npcy4gKi8KLQkJCQlsb2coTE9H X0VSUiwKLQkJICAgICJkZWZyb3V0ZXJfc2VsZWN0OiBtb3JlIHRoYW4gb25lIHJvdXRlciBpcyBp bnN0YWxsZWRcbiIpOworCQkJCS8qCisJCQkJICogdGhpcyBzaG91bGQgbm90IGhhcHBlbi4KKwkJ CQkgKiB3YXJuIGZvciBkaWFnbm9zaXMuCisJCQkJICovCisJCQkJbG9nKExPR19FUlIsICJkZWZy b3V0ZXJfc2VsZWN0X2ZpYjogbW9yZSB0aGFuICIKKwkJCQkgICAgICAgICAgICAgIm9uZSByb3V0 ZXIgaXMgaW5zdGFsbGVkXG4iKTsKIAkJCX0KIAkJfQogCX0KQEAgLTc4OSwxNCArODAyLDI0IEBA CiAJaWYgKHNlbGVjdGVkX2RyID09IE5VTEwpIHsKIAkJaWYgKGluc3RhbGxlZF9kciA9PSBOVUxM IHx8CiAJCSAgICBUQUlMUV9ORVhUKGluc3RhbGxlZF9kciwgZHJfZW50cnkpID09IE5VTEwpCi0J CQlzZWxlY3RlZF9kciA9IFRBSUxRX0ZJUlNUKCZWX25kX2RlZnJvdXRlcik7CisJCQlkciA9IFRB SUxRX0ZJUlNUKCZWX25kX2RlZnJvdXRlcik7CiAJCWVsc2UKLQkJCXNlbGVjdGVkX2RyID0gVEFJ TFFfTkVYVChpbnN0YWxsZWRfZHIsIGRyX2VudHJ5KTsKLQkJZGVmcm91dGVyX3JlZihzZWxlY3Rl ZF9kcik7CisJCQlkciA9IFRBSUxRX05FWFQoaW5zdGFsbGVkX2RyLCBkcl9lbnRyeSk7CisKKwkJ LyogRW5zdXJlIHdlIHNlbGVjdCBhIHJvdXRlciBmb3IgdGhpcyBGSUIuICovCisJCVRBSUxRX0ZP UkVBQ0hfRlJPTShkciwgJlZfbmRfZGVmcm91dGVyLCBkcl9lbnRyeSkgeworCQkJaWYgKGRyLT5p ZnAtPmlmX2ZpYiA9PSBmaWJudW0pIHsKKwkJCQlzZWxlY3RlZF9kciA9IGRyOworCQkJCWRlZnJv dXRlcl9yZWYoc2VsZWN0ZWRfZHIpOworCQkJCWJyZWFrOworCQkJfQorCQl9CiAJfSBlbHNlIGlm IChpbnN0YWxsZWRfZHIgIT0gTlVMTCkgewogCQlJRl9BRkRBVEFfUkxPQ0soaW5zdGFsbGVkX2Ry LT5pZnApOwotCQlpZiAoKGxuID0gbmQ2X2xvb2t1cCgmaW5zdGFsbGVkX2RyLT5ydGFkZHIsIDAs IGluc3RhbGxlZF9kci0+aWZwKSkgJiYKKwkJaWYgKChsbiA9IG5kNl9sb29rdXAoJmluc3RhbGxl ZF9kci0+cnRhZGRyLCAwLAorCQkgICAgICAgICAgICAgICAgICAgICBpbnN0YWxsZWRfZHItPmlm cCkpICYmCiAJCSAgICBORDZfSVNfTExJTkZPX1BST0JSRUFDSChsbikgJiYKKwkJICAgIGluc3Rh bGxlZF9kci0+aWZwLT5pZl9maWIgPT0gZmlibnVtICYmCiAJCSAgICBydHByZWYoc2VsZWN0ZWRf ZHIpIDw9IHJ0cHJlZihpbnN0YWxsZWRfZHIpKSB7CiAJCQlkZWZyb3V0ZXJfcmVsZShzZWxlY3Rl ZF9kcik7CiAJCQlzZWxlY3RlZF9kciA9IGluc3RhbGxlZF9kcjsKQEAgLTgwOCwxOCArODMxLDMw IEBACiAJTkQ2X1JVTkxPQ0soKTsKIAogCS8qCi0JICogSWYgdGhlIHNlbGVjdGVkIHJvdXRlciBp cyBkaWZmZXJlbnQgdGhhbiB0aGUgaW5zdGFsbGVkIG9uZSwKLQkgKiByZW1vdmUgdGhlIGluc3Rh bGxlZCByb3V0ZXIgYW5kIGluc3RhbGwgdGhlIHNlbGVjdGVkIG9uZS4KLQkgKiBOb3RlIHRoYXQg dGhlIHNlbGVjdGVkIHJvdXRlciBpcyBuZXZlciBOVUxMIGhlcmUuCisJICogSWYgd2Ugc2VsZWN0 ZWQgYSByb3V0ZXIgZm9yIHRoaXMgRklCIGFuZCBpdCdzIGRpZmZlcmVudAorCSAqIHRoYW4gdGhl IGluc3RhbGxlZCBvbmUsIHJlbW92ZSB0aGUgaW5zdGFsbGVkIHJvdXRlciBhbmQKKwkgKiBpbnN0 YWxsIHRoZSBzZWxlY3RlZCBvbmUgaW4gaXRzIHBsYWNlLgogCSAqLwogCWlmIChpbnN0YWxsZWRf ZHIgIT0gc2VsZWN0ZWRfZHIpIHsKIAkJaWYgKGluc3RhbGxlZF9kciAhPSBOVUxMKSB7CiAJCQlk ZWZyb3V0ZXJfZGVscmVxKGluc3RhbGxlZF9kcik7CiAJCQlkZWZyb3V0ZXJfcmVsZShpbnN0YWxs ZWRfZHIpOwogCQl9Ci0JCWRlZnJvdXRlcl9hZGRyZXEoc2VsZWN0ZWRfZHIpOworCQlpZiAoc2Vs ZWN0ZWRfZHIgIT0gTlVMTCkKKwkJCWRlZnJvdXRlcl9hZGRyZXEoc2VsZWN0ZWRfZHIpOwogCX0K LQlkZWZyb3V0ZXJfcmVsZShzZWxlY3RlZF9kcik7CisJaWYgKHNlbGVjdGVkX2RyICE9IE5VTEwp CisJCWRlZnJvdXRlcl9yZWxlKHNlbGVjdGVkX2RyKTsKK30KKworLyoKKyAqIE1haW50YWluIG9s ZCBLUEkgZm9yIGRlZmF1bHQgcm91dGVyIHNlbGVjdGlvbi4KKyAqIElmIHVuc3BlY2lmaWVkLCB3 ZSBjYW4gcmUtc2VsZWN0IHJvdXRlcnMgZm9yIGFsbCBGSUJzLgorICovCit2b2lkCitkZWZyb3V0 ZXJfc2VsZWN0KHZvaWQpCit7CisJZGVmcm91dGVyX3NlbGVjdF9maWIoUlRfQUxMX0ZJQlMpOwog fQogCiAvKgpAQCAtOTQyLDcgKzk3Nyw3IEBACiAJVl9uZDZfbGlzdF9nZW5pZCsrOwogCU5ENl9X VU5MT0NLKCk7CiAKLQlkZWZyb3V0ZXJfc2VsZWN0KCk7CisJZGVmcm91dGVyX3NlbGVjdF9maWIo bmV3LT5pZnAtPmlmX2ZpYik7CiAKIAlyZXR1cm4gKG4pOwogfQpAQCAtMTczMSw3ICsxNzY2LDcg QEAKIAlzdHJ1Y3QgcnRlbnRyeSAqcnQ7CiAJc3RydWN0IHNvY2thZGRyX2luNiBtYXNrNjsKIAl1 X2xvbmcgcnRmbGFnczsKLQlpbnQgZXJyb3IsIGFfZmFpbHVyZSwgZmlibnVtOworCWludCBlcnJv ciwgYV9mYWlsdXJlLCBmaWJudW0sIG1heGZpYjsKIAogCS8qCiAJICogaW42X2lmaW5pdCgpIHNl dHMgbmQ2X3J0cmVxdWVzdCB0byBpZmFfcnRyZXF1ZXN0IGZvciBhbGwgaWZhZGRycy4KQEAgLTE3 NDIsOCArMTc3NywxNSBAQAogCW1hc2s2LnNpbjZfYWRkciA9IHByLT5uZHByX21hc2s7CiAJcnRm bGFncyA9IChpZmEtPmlmYV9mbGFncyAmIH5JRkFfUlRTRUxGKSB8IFJURl9VUDsKIAorCWlmKFZf cnRfYWRkX2FkZHJfYWxsZmlicykgeworCQlmaWJudW0gPSAwOworCQltYXhmaWIgPSBydF9udW1m aWJzOworCX0gZWxzZSB7CisJCWZpYm51bSA9IGlmYS0+aWZhX2lmcC0+aWZfZmliOworCQltYXhm aWIgPSBmaWJudW0gKyAxOworCX0KIAlhX2ZhaWx1cmUgPSAwOwotCWZvciAoZmlibnVtID0gMDsg ZmlibnVtIDwgcnRfbnVtZmliczsgZmlibnVtKyspIHsKKwlmb3IgKDsgZmlibnVtIDwgbWF4Zmli OyBmaWJudW0rKykgewogCiAJCXJ0ID0gTlVMTDsKIAkJZXJyb3IgPSBpbjZfcnRyZXF1ZXN0KFJU TV9BREQsCkBAIC0xODMxLDYgKzE4NzMsMTAgQEAKIAkJaWYgKChvcHItPm5kcHJfc3RhdGVmbGFn cyAmIE5EUFJGX09OTElOSykgPT0gMCkKIAkJCWNvbnRpbnVlOwogCisJCWlmICghVl9ydF9hZGRf YWRkcl9hbGxmaWJzICYmCisJCSAgICBvcHItPm5kcHJfaWZwLT5pZl9maWIgIT0gcHItPm5kcHJf aWZwLT5pZl9maWIpCisJCQljb250aW51ZTsKKwogCQlpZiAob3ByLT5uZHByX3BsZW4gPT0gcHIt Pm5kcHJfcGxlbiAmJgogCQkgICAgaW42X2FyZV9wcmVmaXhfZXF1YWwoJnByLT5uZHByX3ByZWZp eC5zaW42X2FkZHIsCiAJCSAgICAmb3ByLT5uZHByX3ByZWZpeC5zaW42X2FkZHIsIHByLT5uZHBy X3BsZW4pKSB7CkBAIC0xODkxLDcgKzE5MzcsNyBAQAogCXN0cnVjdCBydGVudHJ5ICpydDsKIAlj aGFyIGlwNmJ1ZltJTkVUNl9BRERSU1RSTEVOXTsKIAl1aW50NjRfdCBnZW5pZDsKLQlpbnQgZmli bnVtLCBhX2ZhaWx1cmU7CisJaW50IGZpYm51bSwgbWF4ZmliLCBhX2ZhaWx1cmU7CiAKIAlORDZf T05MSU5LX0xPQ0tfQVNTRVJUKCk7CiAJTkQ2X1VOTE9DS19BU1NFUlQoKTsKQEAgLTE5MDksOCAr MTk1NSwxNiBAQAogCW1hc2s2LnNpbjZfbGVuID0gc2l6ZW9mKHNhNik7CiAJYmNvcHkoJnByLT5u ZHByX21hc2ssICZtYXNrNi5zaW42X2FkZHIsIHNpemVvZihzdHJ1Y3QgaW42X2FkZHIpKTsKIAor CWlmIChWX3J0X2FkZF9hZGRyX2FsbGZpYnMpIHsKKwkJZmlibnVtID0gMDsKKwkJbWF4ZmliID0g cnRfbnVtZmliczsKKwl9IGVsc2UgeworCQlmaWJudW0gPSBpZnAtPmlmX2ZpYjsKKwkJbWF4Zmli ID0gZmlibnVtICsgMTsKKwl9CisKIAlhX2ZhaWx1cmUgPSAwOwotCWZvciAoZmlibnVtID0gMDsg ZmlibnVtIDwgcnRfbnVtZmliczsgZmlibnVtKyspIHsKKwlmb3IgKDsgZmlibnVtIDwgbWF4Zmli OyBmaWJudW0rKykgewogCQlydCA9IE5VTEw7CiAJCWVycm9yID0gaW42X3J0cmVxdWVzdChSVE1f REVMRVRFLCAoc3RydWN0IHNvY2thZGRyICopJnNhNiwgTlVMTCwKIAkJICAgIChzdHJ1Y3Qgc29j a2FkZHIgKikmbWFzazYsIDAsICZydCwgZmlibnVtKTsKZGlmZiAtLWdpdCBhL3N5cy9uZXRpbmV0 Ni9uZDZfbmJyLmMgYi9zeXMvbmV0aW5ldDYvbmQ2X25ici5jCi0tLSBhL3N5cy9uZXRpbmV0Ni9u ZDZfbmJyLmMKKysrIGIvc3lzL25ldGluZXQ2L25kNl9uYnIuYwpAQCAtMjYyLDggKzI2Miw3IEBA CiAJCWJ6ZXJvKCZpbmZvLCBzaXplb2YoaW5mbykpOwogCQlpbmZvLnJ0aV9pbmZvW1JUQVhfR0FU RVdBWV0gPSAoc3RydWN0IHNvY2thZGRyICopJnJ0X2dhdGV3YXk7CiAKLQkJLyogQWx3YXlzIHVz ZSB0aGUgZGVmYXVsdCBGSUIuICovCi0JCWlmIChyaWJfbG9va3VwX2luZm8oUlRfREVGQVVMVF9G SUIsIChzdHJ1Y3Qgc29ja2FkZHIgKikmZHN0NiwKKwkJaWYgKHJpYl9sb29rdXBfaW5mbyhpZnAt PmlmX2ZpYiwgKHN0cnVjdCBzb2NrYWRkciAqKSZkc3Q2LAogCQkgICAgMCwgMCwgJmluZm8pID09 IDApIHsKIAkJCWlmICgoaW5mby5ydGlfZmxhZ3MgJiBSVEZfQU5OT1VOQ0UpICE9IDAgJiYKIAkJ CSAgICBydF9nYXRld2F5LnNkbF9mYW1pbHkgPT0gQUZfTElOSykgewpAQCAtNDg1LDcgKzQ4NCw3 IEBACiAJCQl1aW50MzJfdCBzY29wZWlkOwogCiAJCQlpbjZfc3BsaXRzY29wZSgmaXA2LT5pcDZf ZHN0LCAmZHN0NiwgJnNjb3BlaWQpOwotCQkJZXJyb3IgPSBpbjZfc2VsZWN0c3JjX2FkZHIoUlRf REVGQVVMVF9GSUIsICZkc3Q2LAorCQkJZXJyb3IgPSBpbjZfc2VsZWN0c3JjX2FkZHIoZmlibnVt LCAmZHN0NiwKIAkJCSAgICBzY29wZWlkLCBpZnAsICZzcmM2LCBOVUxMKTsKIAkJCWlmIChlcnJv cikgewogCQkJCWNoYXIgaXA2YnVmW0lORVQ2X0FERFJTVFJMRU5dOwpAQCAtOTgyLDcgKzk4MSw3 IEBACiAJICogU2VsZWN0IGEgc291cmNlIHdob3NlIHNjb3BlIGlzIHRoZSBzYW1lIGFzIHRoYXQg b2YgdGhlIGRlc3QuCiAJICovCiAJaW42X3NwbGl0c2NvcGUoJmRhZGRyNiwgJmRzdDYsICZzY29w ZWlkKTsKLQllcnJvciA9IGluNl9zZWxlY3RzcmNfYWRkcihSVF9ERUZBVUxUX0ZJQiwgJmRzdDYs CisJZXJyb3IgPSBpbjZfc2VsZWN0c3JjX2FkZHIoZmlibnVtLCAmZHN0NiwKIAkgICAgc2NvcGVp ZCwgaWZwLCAmc3JjNiwgTlVMTCk7CiAJaWYgKGVycm9yKSB7CiAJCWNoYXIgaXA2YnVmW0lORVQ2 X0FERFJTVFJMRU5dOwpkaWZmIC0tZ2l0IGEvc3lzL25ldGluZXQ2L25kNi5oIGIvc3lzL25ldGlu ZXQ2L25kNi5oCi0tLSBhL3N5cy9uZXRpbmV0Ni9uZDYuaAorKysgYi9zeXMvbmV0aW5ldDYvbmQ2 LmgKQEAgLTQ2OSw2ICs0NjksNyBAQAogdm9pZCBuZDZfcnNfaW5wdXQoc3RydWN0IG1idWYgKiwg aW50LCBpbnQpOwogdm9pZCBuZDZfcmFfaW5wdXQoc3RydWN0IG1idWYgKiwgaW50LCBpbnQpOwog dm9pZCBkZWZyb3V0ZXJfcmVzZXQodm9pZCk7Cit2b2lkIGRlZnJvdXRlcl9zZWxlY3RfZmliKGlu dCBmaWJudW0pOwogdm9pZCBkZWZyb3V0ZXJfc2VsZWN0KHZvaWQpOwogdm9pZCBkZWZyb3V0ZXJf cmVmKHN0cnVjdCBuZF9kZWZyb3V0ZXIgKik7CiB2b2lkIGRlZnJvdXRlcl9yZWxlKHN0cnVjdCBu ZF9kZWZyb3V0ZXIgKik7CmRpZmYgLS1naXQgYS9zeXMvbmV0aW5ldDYvbmQ2LmMgYi9zeXMvbmV0 aW5ldDYvbmQ2LmMKLS0tIGEvc3lzL25ldGluZXQ2L25kNi5jCisrKyBiL3N5cy9uZXRpbmV0Ni9u ZDYuYwpAQCAtMTU3LDYgKzE1Nyw3IEBACiAJc3RydWN0IHNvY2thZGRyX2RsIGd3OwogCXN0cnVj dCBpZm5ldCAqaWZwOwogCWludCB0eXBlOworCWludCBmaWJudW07CiAKIAlMTEVfV0xPQ0tfQVNT RVJUKGxsZSk7CiAKQEAgLTE5NCw4ICsxOTUsOSBAQAogCXJ0aW5mby5ydGlfaW5mb1tSVEFYX0RT VF0gPSAoc3RydWN0IHNvY2thZGRyICopJmRzdDsKIAlydGluZm8ucnRpX2luZm9bUlRBWF9HQVRF V0FZXSA9IChzdHJ1Y3Qgc29ja2FkZHIgKikmZ3c7CiAJcnRpbmZvLnJ0aV9hZGRycyA9IFJUQV9E U1QgfCBSVEFfR0FURVdBWTsKKwlmaWJudW0gPSBWX3J0X2FkZF9hZGRyX2FsbGZpYnMgPyBSVF9B TExfRklCUyA6IGlmcC0+aWZfZmliOwogCXJ0X21pc3Ntc2dfZmliKHR5cGUsICZydGluZm8sIFJU Rl9IT1NUIHwgUlRGX0xMREFUQSB8ICgKLQkgICAgdHlwZSA9PSBSVE1fQUREID8gUlRGX1VQOiAw KSwgMCwgUlRfREVGQVVMVF9GSUIpOworCSAgICB0eXBlID09IFJUTV9BREQgPyBSVEZfVVA6IDAp LCAwLCBmaWJudW0pOwogfQogCiAvKgpAQCAtMTIwMCw3ICsxMjAyLDcgQEAKIAogCWlmIChORF9J RklORk8oaWZwKS0+ZmxhZ3MgJiBORDZfSUZGX0FDQ0VQVF9SVEFEVikgewogCQkvKiBSZWZyZXNo IGRlZmF1bHQgcm91dGVyIGxpc3QuICovCi0JCWRlZnJvdXRlcl9zZWxlY3QoKTsKKwkJZGVmcm91 dGVyX3NlbGVjdF9maWIoaWZwLT5pZl9maWIpOwogCX0KIH0KIApAQCAtMTI1Myw3ICsxMjU1LDcg QEAKIG5kNl9pc19uZXdfYWRkcl9uZWlnaGJvcihjb25zdCBzdHJ1Y3Qgc29ja2FkZHJfaW42ICph ZGRyLCBzdHJ1Y3QgaWZuZXQgKmlmcCkKIHsKIAlzdHJ1Y3QgbmRfcHJlZml4ICpwcjsKLQlzdHJ1 Y3QgaWZhZGRyICpkc3RhZGRyOworCXN0cnVjdCBpZmFkZHIgKmlmYTsKIAlzdHJ1Y3QgcnRfYWRk cmluZm8gaW5mbzsKIAlzdHJ1Y3Qgc29ja2FkZHJfaW42IHJ0X2tleTsKIAljb25zdCBzdHJ1Y3Qg c29ja2FkZHIgKmRzdDY7CkBAIC0xMjg3LDkgKzEyODksNiBAQAogCWJ6ZXJvKCZpbmZvLCBzaXpl b2YoaW5mbykpOwogCWluZm8ucnRpX2luZm9bUlRBWF9EU1RdID0gKHN0cnVjdCBzb2NrYWRkciAq KSZydF9rZXk7CiAKLQkvKiBBbHdheXMgdXNlIHRoZSBkZWZhdWx0IEZJQiBoZXJlLiBYWE1FIC0g d2h5PyAqLwotCWZpYm51bSA9IFJUX0RFRkFVTFRfRklCOwotCiAJLyoKIAkgKiBJZiB0aGUgYWRk cmVzcyBtYXRjaGVzIG9uZSBvZiBvdXIgYWRkcmVzc2VzLAogCSAqIGl0IHNob3VsZCBiZSBhIG5l aWdoYm9yLgpAQCAtMTMwMywxOSArMTMwMiwzMSBAQAogCQkJY29udGludWU7CiAKIAkJaWYgKChw ci0+bmRwcl9zdGF0ZWZsYWdzICYgTkRQUkZfT05MSU5LKSA9PSAwKSB7Ci0JCQkvKiBBbHdheXMg dXNlIHRoZSBkZWZhdWx0IEZJQiBoZXJlLiAqLwogCQkJZHN0NiA9IChjb25zdCBzdHJ1Y3Qgc29j a2FkZHIgKikmcHItPm5kcHJfcHJlZml4OwogCi0JCQlnZW5pZCA9IFZfbmQ2X2xpc3RfZ2VuaWQ7 Ci0JCQlORDZfUlVOTE9DSygpOwotCi0JCQkvKiBSZXN0b3JlIGxlbmd0aCBmaWVsZCBiZWZvcmUg cmV0cnlpbmcgbG9va3VwICovCi0JCQlydF9rZXkuc2luNl9sZW4gPSBzaXplb2YocnRfa2V5KTsK LQkJCWVycm9yID0gcmliX2xvb2t1cF9pbmZvKGZpYm51bSwgZHN0NiwgMCwgMCwgJmluZm8pOwor CQkJLyoKKwkJCSAqIFdlIG9ubHkgbmVlZCB0byBjaGVjayBhbGwgRklCcyBpZiBhZGRfYWRkcl9h bGxmaWJzCisJCQkgKiBpcyB1bnNldC4gSWYgc2V0LCBjaGVja2luZyBhbnkgRklCIHdpbGwgc3Vm ZmljZS4KKwkJCSAqLworCQkJZmlibnVtID0gVl9ydF9hZGRfYWRkcl9hbGxmaWJzID8gcnRfbnVt ZmlicyAtIDEgOiAwOworCQkJZm9yICg7IGZpYm51bSA8IHJ0X251bWZpYnM7IGZpYm51bSsrKSB7 CisJCQkJZ2VuaWQgPSBWX25kNl9saXN0X2dlbmlkOworCQkJCU5ENl9SVU5MT0NLKCk7CiAKLQkJ CU5ENl9STE9DSygpOwotCQkJaWYgKGdlbmlkICE9IFZfbmQ2X2xpc3RfZ2VuaWQpCi0JCQkJZ290 byByZXN0YXJ0OworCQkJCS8qCisJCQkJICogUmVzdG9yZSBsZW5ndGggZmllbGQgYmVmb3JlCisJ CQkJICogcmV0cnlpbmcgbG9va3VwCisJCQkJICovCisJCQkJcnRfa2V5LnNpbjZfbGVuID0gc2l6 ZW9mKHJ0X2tleSk7CisJCQkJZXJyb3IgPSByaWJfbG9va3VwX2luZm8oZmlibnVtLCBkc3Q2LCAw LCAwLAorCQkJCQkJICAgICAgICAmaW5mbyk7CisKKwkJCQlORDZfUkxPQ0soKTsKKwkJCQlpZiAo Z2VuaWQgIT0gVl9uZDZfbGlzdF9nZW5pZCkKKwkJCQkJZ290byByZXN0YXJ0OworCQkJCWlmIChl cnJvciA9PSAwKQorCQkJCQlicmVhazsKKwkJCX0KIAkJCWlmIChlcnJvciAhPSAwKQogCQkJCWNv bnRpbnVlOwogCkBAIC0xMzQ2LDEzICsxMzU3LDE4IEBACiAJICogSWYgdGhlIGFkZHJlc3MgaXMg YXNzaWduZWQgb24gdGhlIG5vZGUgb2YgdGhlIG90aGVyIHNpZGUgb2YKIAkgKiBhIHAycCBpbnRl cmZhY2UsIHRoZSBhZGRyZXNzIHNob3VsZCBiZSBhIG5laWdoYm9yLgogCSAqLwotCWRzdGFkZHIg PSBpZmFfaWZ3aXRoZHN0YWRkcigoY29uc3Qgc3RydWN0IHNvY2thZGRyICopYWRkciwgUlRfQUxM X0ZJQlMpOwotCWlmIChkc3RhZGRyICE9IE5VTEwpIHsKLQkJaWYgKGRzdGFkZHItPmlmYV9pZnAg PT0gaWZwKSB7Ci0JCQlpZmFfZnJlZShkc3RhZGRyKTsKLQkJCXJldHVybiAoMSk7CisJaWYgKGlm cC0+aWZfZmxhZ3MgJiBJRkZfUE9JTlRPUE9JTlQpIHsKKwkJSUZfQUREUl9STE9DSyhpZnApOwor CQlUQUlMUV9GT1JFQUNIKGlmYSwgJmlmcC0+aWZfYWRkcmhlYWQsIGlmYV9saW5rKSB7CisJCQlp ZiAoaWZhLT5pZmFfYWRkci0+c2FfZmFtaWx5ICE9IGFkZHItPnNpbjZfZmFtaWx5KQorCQkJCWNv bnRpbnVlOworCQkJaWYgKGlmYS0+aWZhX2RzdGFkZHIgIT0gTlVMTCAmJgorCQkJICAgIHNhX2Vx dWFsKGFkZHIsIGlmYS0+aWZhX2RzdGFkZHIpKSB7CisJCQkJSUZfQUREUl9SVU5MT0NLKGlmcCk7 CisJCQkJcmV0dXJuIDE7CisJCQl9CiAJCX0KLQkJaWZhX2ZyZWUoZHN0YWRkcik7CisJCUlGX0FE RFJfUlVOTE9DSyhpZnApOwogCX0KIAogCS8qCkBAIC0xNDg1LDcgKzE1MDEsNyBAQAogCQkJLyoK IAkJCSAqIFdlIG5lZWQgdG8gdW5sb2NrIHRvIGF2b2lkIGEgTE9SIHdpdGggcnQ2X2ZsdXNoKCkg d2l0aCB0aGUKIAkJCSAqIHJuaCBhbmQgZm9yIHRoZSBjYWxscyB0byBwZnhsaXN0X29ubGlua19j aGVjaygpIGFuZAotCQkJICogZGVmcm91dGVyX3NlbGVjdCgpIGluIHRoZSBibG9jayBmdXJ0aGVy IGRvd24gZm9yIGNhbGxzCisJCQkgKiBkZWZyb3V0ZXJfc2VsZWN0X2ZpYigpIGluIHRoZSBibG9j ayBmdXJ0aGVyIGRvd24gZm9yIGNhbGxzCiAJCQkgKiBpbnRvIG5kNl9sb29rdXAoKS4gIFdlIHN0 aWxsIGhvbGQgYSByZWYuCiAJCQkgKi8KIAkJCUxMRV9XVU5MT0NLKGxuKTsKQEAgLTE1MDAsNyAr MTUxNiw3IEBACiAKIAkJaWYgKGRyKSB7CiAJCQkvKgotCQkJICogU2luY2UgZGVmcm91dGVyX3Nl bGVjdCgpIGRvZXMgbm90IGFmZmVjdCB0aGUKKwkJCSAqIFNpbmNlIGRlZnJvdXRlcl9zZWxlY3Rf ZmliKCkgZG9lcyBub3QgYWZmZWN0IHRoZQogCQkJICogb24tbGluayBkZXRlcm1pbmF0aW9uIGFu ZCBNSVA2IG5lZWRzIHRoZSBjaGVjawogCQkJICogYmVmb3JlIHRoZSBkZWZhdWx0IHJvdXRlciBz ZWxlY3Rpb24sIHdlIHBlcmZvcm0KIAkJCSAqIHRoZSBjaGVjayBub3cuCkBAIC0xNTEwLDcgKzE1 MjYsNyBAQAogCQkJLyoKIAkJCSAqIFJlZnJlc2ggZGVmYXVsdCByb3V0ZXIgbGlzdC4KIAkJCSAq LwotCQkJZGVmcm91dGVyX3NlbGVjdCgpOworCQkJZGVmcm91dGVyX3NlbGVjdF9maWIoZHItPmlm cC0+aWZfZmliKTsKIAkJfQogCiAJCS8qCkBAIC0yMTA0LDIwICsyMTIwLDIwIEBACiAJICogUXVl c3Rpb246IGNhbiB3ZSByZXN0cmljdCB0aGUgZmlyc3QgY29uZGl0aW9uIHRvIHRoZSAiaXNfbmV3 ZW50cnkiCiAJICogY2FzZT8KIAkgKiBYWFg6IHdoZW4gd2UgaGVhciBhbiBSQSBmcm9tIGEgbmV3 IHJvdXRlciB3aXRoIHRoZSBsaW5rLWxheWVyCi0JICogYWRkcmVzcyBvcHRpb24sIGRlZnJvdXRl cl9zZWxlY3QoKSBpcyBjYWxsZWQgdHdpY2UsIHNpbmNlCisJICogYWRkcmVzcyBvcHRpb24sIGRl ZnJvdXRlcl9zZWxlY3RfZmliKCkgaXMgY2FsbGVkIHR3aWNlLCBzaW5jZQogCSAqIGRlZnJ0cmxp c3RfdXBkYXRlIGNhbGxlZCB0aGUgZnVuY3Rpb24gYXMgd2VsbC4gIEhvd2V2ZXIsIEkgYmVsaWV2 ZQogCSAqIHdlIGNhbiBjb21wcm9taXNlIHRoZSBvdmVyaGVhZCwgc2luY2UgaXQgb25seSBoYXBw ZW5zIHRoZSBmaXJzdAogCSAqIHRpbWUuCi0JICogWFhYOiBhbHRob3VnaCBkZWZyb3V0ZXJfc2Vs ZWN0KCkgc2hvdWxkIG5vdCBoYXZlIGEgYmFkIGVmZmVjdAorCSAqIFhYWDogYWx0aG91Z2ggZGVm cm91dGVyX3NlbGVjdF9maWIoKSBzaG91bGQgbm90IGhhdmUgYSBiYWQgZWZmZWN0CiAJICogZm9y IHRob3NlIGFyZSBub3QgYXV0b2NvbmZpZ3VyZWQgaG9zdHMsIHdlIGV4cGxpY2l0bHkgYXZvaWQg c3VjaAogCSAqIGNhc2VzIGZvciBzYWZldHkuCiAJICovCiAJaWYgKChkb191cGRhdGUgfHwgaXNf bmV3ZW50cnkpICYmIHJvdXRlciAmJgogCSAgICBORF9JRklORk8oaWZwKS0+ZmxhZ3MgJiBORDZf SUZGX0FDQ0VQVF9SVEFEVikgewogCQkvKgogCQkgKiBndWFyYW50ZWVkIHJlY3Vyc2lvbgogCQkg Ki8KLQkJZGVmcm91dGVyX3NlbGVjdCgpOworCQlkZWZyb3V0ZXJfc2VsZWN0X2ZpYihpZnAtPmlm X2ZpYik7CiAJfQogfQogCmRpZmYgLS1naXQgYS9zeXMvbmV0aW5ldDYvaW42X3NyYy5jIGIvc3lz L25ldGluZXQ2L2luNl9zcmMuYwotLS0gYS9zeXMvbmV0aW5ldDYvaW42X3NyYy5jCisrKyBiL3N5 cy9uZXRpbmV0Ni9pbjZfc3JjLmMKQEAgLTI5Nyw3ICsyOTcsNyBAQAogCSAqLwogCS8qIGdldCB0 aGUgb3V0Z29pbmcgaW50ZXJmYWNlICovCiAJaWYgKChlcnJvciA9IGluNl9zZWxlY3RpZihkc3Rz b2NrLCBvcHRzLCBtb3B0cywgJmlmcCwgb2lmcCwKLQkgICAgKGlucCAhPSBOVUxMKSA/IGlucC0+ aW5wX2luYy5pbmNfZmlibnVtIDogUlRfREVGQVVMVF9GSUIpKSAhPSAwKQorCSAgICAoaW5wICE9 IE5VTEwpID8gaW5wLT5pbnBfaW5jLmluY19maWJudW0gOiBmaWJudW0pKSAhPSAwKQogCQlyZXR1 cm4gKGVycm9yKTsKIAogI2lmZGVmIERJQUdOT1NUSUMKQEAgLTU2Myw3ICs1NjMsNyBAQAogCXVp bnQzMl90IGZpYm51bTsKIAlpbnQgZXJyb3I7CiAKLQlmaWJudW0gPSAoaW5wICE9IE5VTEwpID8g aW5wLT5pbnBfaW5jLmluY19maWJudW0gOiBSVF9ERUZBVUxUX0ZJQjsKKwlmaWJudW0gPSBpbnAt PmlucF9pbmMuaW5jX2ZpYm51bTsKIAlyZXRpZnAgPSBOVUxMOwogCiAJZXJyb3IgPSBpbjZfc2Vs ZWN0c3JjKGZpYm51bSwgZHN0c29jaywgb3B0cywgaW5wLCBjcmVkLCAmcmV0aWZwLCBzcmNwKTsK ZGlmZiAtLWdpdCBhL3N5cy9uZXRpbmV0Ni9pbjYuYyBiL3N5cy9uZXRpbmV0Ni9pbjYuYwotLS0g YS9zeXMvbmV0aW5ldDYvaW42LmMKKysrIGIvc3lzL25ldGluZXQ2L2luNi5jCkBAIC0xNTksNiAr MTU5LDcgQEAKIAlzdHJ1Y3Qgc29ja2FkZHJfZGwgZ2F0ZXdheTsKIAlzdHJ1Y3Qgc29ja2FkZHJf aW42IG1hc2ssIGFkZHI7CiAJc3RydWN0IHJ0ZW50cnkgcnQ7CisJaW50IGZpYm51bTsKIAogCS8q CiAJICogaW5pdGlhbGl6ZSBmb3IgcnRtc2cgZ2VuZXJhdGlvbgpAQCAtMTc2LDggKzE3Nyw5IEBA CiAJcnQucnRfZmxhZ3MgPSBSVEZfSE9TVCB8IFJURl9TVEFUSUM7CiAJaWYgKGNtZCA9PSBSVE1f QUREKQogCQlydC5ydF9mbGFncyB8PSBSVEZfVVA7Ci0JLyogQW5ub3VuY2UgYXJyaXZhbCBvZiBs b2NhbCBhZGRyZXNzIHRvIGFsbCBGSUJzLiAqLwotCXJ0X25ld2FkZHJtc2coY21kLCAmaWEtPmlh X2lmYSwgMCwgJnJ0KTsKKwlmaWJudW0gPSBWX3J0X2FkZF9hZGRyX2FsbGZpYnMgPyBSVF9BTExf RklCUyA6IGlhNjJpZmEoaWEpLT5pZmFfaWZwLT5pZl9maWI7CisJLyogQW5ub3VuY2UgYXJyaXZh bCBvZiBsb2NhbCBhZGRyZXNzIHRvIHRoaXMgRklCLiAqLworCXJ0X25ld2FkZHJtc2dfZmliKGNt ZCwgJmlhLT5pYV9pZmEsIDAsICZydCwgZmlibnVtKTsKIH0KIAogaW50CkBAIC0yMTE3LDE1ICsy MTE5LDE1IEBACiAJdWludDMyX3Qgc2NvcGVpZDsKIAlpbnQgZXJyb3I7CiAJY2hhciBpcDZidWZb SU5FVDZfQUREUlNUUkxFTl07CisJaW50IGZpYm51bTsKIAogCUtBU1NFUlQobDNhZGRyLT5zYV9m YW1pbHkgPT0gQUZfSU5FVDYsCiAJICAgICgic2luX2ZhbWlseSAlZCIsIGwzYWRkci0+c2FfZmFt aWx5KSk7CiAKLQkvKiBPdXIgbG9jYWwgYWRkcmVzc2VzIGFyZSBhbHdheXMgb25seSBpbnN0YWxs ZWQgb24gdGhlIGRlZmF1bHQgRklCLiAqLwotCiAJc2luNiA9IChjb25zdCBzdHJ1Y3Qgc29ja2Fk ZHJfaW42ICopbDNhZGRyOwogCWluNl9zcGxpdHNjb3BlKCZzaW42LT5zaW42X2FkZHIsICZkc3Qs ICZzY29wZWlkKTsKLQllcnJvciA9IGZpYjZfbG9va3VwX25oX2Jhc2ljKFJUX0RFRkFVTFRfRklC LCAmZHN0LCBzY29wZWlkLCAwLCAwLCAmbmg2KTsKKwlmaWJudW0gPSBWX3J0X2FkZF9hZGRyX2Fs bGZpYnMgPyBSVF9ERUZBVUxUX0ZJQiA6IGlmcC0+aWZfZmliOworCWVycm9yID0gZmliNl9sb29r dXBfbmhfYmFzaWMoZmlibnVtLCAmZHN0LCBzY29wZWlkLCAwLCAwLCAmbmg2KTsKIAlpZiAoZXJy b3IgIT0gMCB8fCAobmg2Lm5oX2ZsYWdzICYgTkhGX0dBVEVXQVkpIHx8IG5oNi5uaF9pZnAgIT0g aWZwKSB7CiAJCXN0cnVjdCBpZmFkZHIgKmlmYTsKIAkJLyoKZGlmZiAtLWdpdCBhL3N5cy9uZXRp bmV0Ni9pY21wNi5jIGIvc3lzL25ldGluZXQ2L2ljbXA2LmMKLS0tIGEvc3lzL25ldGluZXQ2L2lj bXA2LmMKKysrIGIvc3lzL25ldGluZXQ2L2ljbXA2LmMKQEAgLTIxNDcsNyArMjE0Nyw3IEBACiAJ CSAqIHNvdXJjZSBhZGRyZXNzIG9mIHRoZSBlcnJvbmVvdXMgcGFja2V0LgogCQkgKi8KIAkJaW42 X3NwbGl0c2NvcGUoJmlwNi0+aXA2X3NyYywgJmRzdDYsICZzY29wZWlkKTsKLQkJZXJyb3IgPSBp bjZfc2VsZWN0c3JjX2FkZHIoUlRfREVGQVVMVF9GSUIsICZkc3Q2LAorCQllcnJvciA9IGluNl9z ZWxlY3RzcmNfYWRkcihNX0dFVEZJQihtKSwgJmRzdDYsCiAJCSAgICBzY29wZWlkLCBOVUxMLCAm c3JjNiwgJmhsaW0pOwogCiAJCWlmIChlcnJvcikgewpAQCAtMjI4OSw3ICsyMjg5LDcgQEAKIAl1 aW50MzJfdCBzY29wZWlkOwogCiAJaW42X3NwbGl0c2NvcGUoJnJlZGRzdDYsICZrZHN0LCAmc2Nv cGVpZCk7Ci0JaWYgKGZpYjZfbG9va3VwX25oX2Jhc2ljKFJUX0RFRkFVTFRfRklCLCAma2RzdCwg c2NvcGVpZCwgMCwgMCwmbmg2KT09MCl7CisJaWYgKGZpYjZfbG9va3VwX25oX2Jhc2ljKGlmcC0+ aWZfZmliLCAma2RzdCwgc2NvcGVpZCwgMCwgMCwmbmg2KT09MCl7CiAJCWlmICgobmg2Lm5oX2Zs YWdzICYgTkhGX0dBVEVXQVkpID09IDApIHsKIAkJCW5kNmxvZygoTE9HX0VSUiwKIAkJCSAgICAi SUNNUDYgcmVkaXJlY3QgcmVqZWN0ZWQ7IG5vIHJvdXRlICIKCg== --b1_b0d313e58e33da16a81af0fc9092492c-- From owner-freebsd-net@freebsd.org Tue Mar 7 05:56:12 2017 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 4CF79D01DEE for ; Tue, 7 Mar 2017 05:56:12 +0000 (UTC) (envelope-from daemon-user@freebsd.org) Received: from reviews.nyi.freebsd.org (reviews.nyi.freebsd.org [IPv6:2610:1c1:1:607c::16:b]) by mx1.freebsd.org (Postfix) with ESMTP id 289DA1AB2 for ; Tue, 7 Mar 2017 05:56:12 +0000 (UTC) (envelope-from daemon-user@freebsd.org) Received: by reviews.nyi.freebsd.org (Postfix, from userid 1346) id DE0D51B875; Tue, 7 Mar 2017 05:56:11 +0000 (UTC) Date: Tue, 7 Mar 2017 05:56:11 +0000 To: freebsd-net@freebsd.org From: "jhujhiti_adjectivism.org (Erick Turnquist)" Reply-to: D9451+325+eaa6f8a0c0731bfe@reviews.freebsd.org Subject: [Differential] D9451: Constrain IPv6 interface routes to each FIB Message-ID: <14ac8c3649478f5de2d7725334b55892@localhost.localdomain> X-Priority: 3 X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: Thread-Topic: D9451: Constrain IPv6 interface routes to each FIB X-Herald-Rules: <28>, <81>, <51> X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: Precedence: bulk In-Reply-To: References: Thread-Index: MzA4MmVhNjA3MDYxYjk1ZGE4NzFjZWJhMzgyIFi+S3s= MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.23 List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 07 Mar 2017 05:56:12 -0000 amh1amhpdGlfYWRqZWN0aXZpc20ub3JnIGFkZGVkIGEgY29tbWVudC4KCgogIEZvcmdvdCB0byBj aGFuZ2UgdGhlIG90aGVyIHRlc3RzIC0gdGhpcyBvdWdodCB0byBkbyBpdC4KICAKICBPbmUgYW5u b3lpbmcgZGV0YWlsOiB3aGlsZSBydW5uaW5nIHRoZXNlIHRlc3RzLCBJIG5vdGljZWQgaW50ZXJt aXR0ZW50IGZhaWx1cmVzIG9uIHRoZSBTTEFBQyB0ZXN0LiBJIHdhcyByZW1pbmRlZCBvZiBhIHNp bWlsYXIgaW50ZXJtaXR0ZW50IGlzc3VlIEkgaGFkIHdoaWxlIGRldmVsb3BpbmcgdGhpczogZm9y IHJlYXNvbnMgSSBjYW4gbm90IGV4cGxhaW4sIHRoZSBlcGFpcjBhIGludGVyZmFjZSAoaW4gdGhp cyBleGFtcGxlKSBvZnRlbnRpbWVzIGdldHMgY29ycmVjdGx5IGNvbmZpZ3VyZWQsIGJ1dCB0aGUg SUZESVNBQkxFRCBmbGFnIGlzIG5ldmVyIHJlbW92ZWQsIGxpa2Ugc286CiAgCiAgICBlcGFpcjBh OiBmbGFncz04ODQzPFVQLEJST0FEQ0FTVCxSVU5OSU5HLFNJTVBMRVgsTVVMVElDQVNUPiBtZXRy aWMgMCBtdHUgMTUwMAogICAgICAgICAgICBvcHRpb25zPTg8VkxBTl9NVFU+CiAgICAgICAgICAg IGV0aGVyIDAyOmZmOmUwOjAwOjA0OjBhCiAgICAgICAgICAgIGluZXQ2IDIwMDE6ZGI4OjoyIHBy ZWZpeGxlbiA2NCB0ZW50YXRpdmUgCiAgICAgICAgICAgIGluZXQ2IGZlODA6OmZmOmUwZmY6ZmUw MDo0MGElZXBhaXIwYSBwcmVmaXhsZW4gNjQgdGVudGF0aXZlIHNjb3BlaWQgMHg0IAogICAgICAg ICAgICBuZDYgb3B0aW9ucz0yOTxQRVJGT1JNTlVELElGRElTQUJMRUQsQVVUT19MSU5LTE9DQUw+ CiAgICAgICAgICAgIG1lZGlhOiBFdGhlcm5ldCAxMEdiYXNlLVQgKDEwR2Jhc2UtVCA8ZnVsbC1k dXBsZXg+KQogICAgICAgICAgICBzdGF0dXM6IGFjdGl2ZQogICAgICAgICAgICBmaWI6IDEKICAg ICAgICAgICAgZ3JvdXBzOiBlcGFpcgogIAogIEluc2VydGluZyBhIHNsZWVwIGJldHdlZW4gY3Jl YXRpb24gb2YgdGhlIGVwYWlyIGFuZCBjb25maWd1cmF0aW9uIHNvbHZlcyBpdC4gVGhlIGdvb2Qg bmV3cyBpcyB0aGF0IHRoaXMgYmVoYXZlcyBpZGVudGljYWxseSBvbiBteSBzeXN0ZW0gd2l0aG91 dCB0aGUgcGF0Y2gsIHNvIGl0J3Mgbm90IGEgbmV3IHJlZ3Jlc3Npb24uCgpJTkxJTkUgQ09NTUVO VFMKCj4gamh1amhpdGlfYWRqZWN0aXZpc20ub3JnIHdyb3RlIGluIGljbXA2LmM6MjE0Nwo+ID4g QXQgbGluZSAyMTU5LCBkbyB3ZSBrbm93IHRoZSBmaWIgb2YgdGhlIHJlY2VpdmluZyBpbnRlcmZh Y2U/Cj4gCj4gSXQgbG9va3MgbGlrZSB0aGUgbWJ1ZiBwYXNzZWQgdG8gaWNtcDZfcmVmbGVjdCgp IHdpbGwgYWx3YXlzIGhhdmUgdGhlIEZJQiBzZXQgYmFzZWQgb24gdGhlIHJlY2VpdmluZyBpbnRl cmZhY2UsIHNvIHdlIGNhbiBqdXN0IHVzZSB0aGF0ISBDYW4gYSBtb3JlIGV4cGVyaWVuY2VkIHNl dCBvZiBleWVzIGNvbmZpcm0/CgpAYXNvbWVycywgY2FuIHlvdSBjb25maXJtIHRoYXQgTV9HRVRG SUIobSkgaXMgYWx3YXlzIGNvcnJlY3RseSBzZXQgdG8gdGhlIEZJQiBvZiB0aGUgcmVjZWl2aW5n IGludGVyZmFjZT8KClJFUE9TSVRPUlkKICByUyBGcmVlQlNEIHNyYyByZXBvc2l0b3J5CgpSRVZJ U0lPTiBERVRBSUwKICBodHRwczovL3Jldmlld3MuZnJlZWJzZC5vcmcvRDk0NTEKCkVNQUlMIFBS RUZFUkVOQ0VTCiAgaHR0cHM6Ly9yZXZpZXdzLmZyZWVic2Qub3JnL3NldHRpbmdzL3BhbmVsL2Vt YWlscHJlZmVyZW5jZXMvCgpUbzogamh1amhpdGlfYWRqZWN0aXZpc20ub3JnLCAjbmV0d29yaywg YnosIGFzb21lcnMKQ2M6IGpjaCwgYnosIGltcCwgYWUsIGZyZWVic2QtbmV0LWxpc3QK From owner-freebsd-net@freebsd.org Tue Mar 7 09:07:46 2017 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id F07C7CFADAA for ; Tue, 7 Mar 2017 09:07:46 +0000 (UTC) (envelope-from sebastian.huber@embedded-brains.de) Received: from dedi548.your-server.de (dedi548.your-server.de [85.10.215.148]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id A12491753 for ; Tue, 7 Mar 2017 09:07:46 +0000 (UTC) (envelope-from sebastian.huber@embedded-brains.de) Received: from [88.198.220.130] (helo=sslproxy01.your-server.de) by dedi548.your-server.de with esmtpsa (TLSv1.2:DHE-RSA-AES256-GCM-SHA384:256) (Exim 4.85_2) (envelope-from ) id 1clB5l-0000CM-Cu for freebsd-net@freebsd.org; Tue, 07 Mar 2017 10:07:37 +0100 Received: from [82.135.62.35] (helo=mail.embedded-brains.de) by sslproxy01.your-server.de with esmtpsa (TLSv1.2:DHE-RSA-AES256-GCM-SHA384:256) (Exim 4.84_2) (envelope-from ) id 1clB5l-0003TB-0e for freebsd-net@freebsd.org; Tue, 07 Mar 2017 10:07:37 +0100 Received: from localhost (localhost.localhost [127.0.0.1]) by mail.embedded-brains.de (Postfix) with ESMTP id 179E62A1808 for ; Tue, 7 Mar 2017 10:07:46 +0100 (CET) Received: from mail.embedded-brains.de ([127.0.0.1]) by localhost (zimbra.eb.localhost [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id 52em7CyDFJpM; Tue, 7 Mar 2017 10:07:45 +0100 (CET) Received: from localhost (localhost.localhost [127.0.0.1]) by mail.embedded-brains.de (Postfix) with ESMTP id 34B032A17F4; Tue, 7 Mar 2017 10:07:45 +0100 (CET) X-Virus-Scanned: amavisd-new at zimbra.eb.localhost Received: from mail.embedded-brains.de ([127.0.0.1]) by localhost (zimbra.eb.localhost [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id MkD3vvNX_0eR; Tue, 7 Mar 2017 10:07:45 +0100 (CET) Received: from huber-linux.eb.localhost (unknown [192.168.96.129]) by mail.embedded-brains.de (Postfix) with ESMTP id 166982A17F3; Tue, 7 Mar 2017 10:07:45 +0100 (CET) From: Sebastian Huber To: freebsd-net@freebsd.org Cc: Sebastian Huber Subject: [PATCH] if_tsec: Defrag only on demand Date: Tue, 7 Mar 2017 10:07:34 +0100 Message-Id: <1488877654-9914-1-git-send-email-sebastian.huber@embedded-brains.de> X-Mailer: git-send-email 1.8.4.5 X-Authenticated-Sender: smtp-embedded@poldinet.de X-Virus-Scanned: Clear (ClamAV 0.99.2/23180/Tue Mar 7 05:59:43 2017) X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 07 Mar 2017 09:07:47 -0000 Defragment the transmit mbuf chain only if necessary. Use a method similar to the if_dwc driver. Use a wmb() before the flags of the first transmit buffer of a frame are written. Group transmit/receive structure members for better cache efficiency. Tested on P1020RDB. TCP transmit throughput increases from 60MiB/s to 90MiB/s. --- sys/dev/tsec/if_tsec.c | 237 ++++++++++++++++++++--------------------- sys/dev/tsec/if_tsec.h | 118 ++++---------------- 2 files changed, 136 insertions(+), 219 deletions(-) diff --git a/sys/dev/tsec/if_tsec.c b/sys/dev/tsec/if_tsec.c index e68d2fb..2a8c3e2 100644 --- a/sys/dev/tsec/if_tsec.c +++ b/sys/dev/tsec/if_tsec.c @@ -73,8 +73,8 @@ static int tsec_alloc_dma_desc(device_t dev, bus_dma_tag_t *dtag, bus_dmamap_t *dmap, bus_size_t dsize, void **vaddr, void *raddr, const char *dname); static void tsec_dma_ctl(struct tsec_softc *sc, int state); -static int tsec_encap(struct tsec_softc *sc, struct mbuf *m_head, - int fcb_inserted); +static void tsec_encap(struct ifnet *ifp, struct tsec_softc *sc, + struct mbuf *m0, uint16_t fcb_flags, int *start_tx); static void tsec_free_dma(struct tsec_softc *sc); static void tsec_free_dma_desc(bus_dma_tag_t dtag, bus_dmamap_t dmap, void *vaddr); static int tsec_ifmedia_upd(struct ifnet *ifp); @@ -123,8 +123,6 @@ tsec_attach(struct tsec_softc *sc) { uint8_t hwaddr[ETHER_ADDR_LEN]; struct ifnet *ifp; - bus_dmamap_t *map_ptr; - bus_dmamap_t **map_pptr; int error = 0; int i; @@ -181,7 +179,7 @@ tsec_attach(struct tsec_softc *sc) BUS_SPACE_MAXADDR, /* highaddr */ NULL, NULL, /* filtfunc, filtfuncarg */ MCLBYTES * (TSEC_TX_NUM_DESC - 1), /* maxsize */ - TSEC_TX_NUM_DESC - 1, /* nsegments */ + TSEC_TX_MAX_DMA_SEGS, /* nsegments */ MCLBYTES, 0, /* maxsegsz, flags */ NULL, NULL, /* lockfunc, lockfuncarg */ &sc->tsec_tx_mtag); /* dmat */ @@ -211,17 +209,15 @@ tsec_attach(struct tsec_softc *sc) } /* Create TX busdma maps */ - map_ptr = sc->tx_map_data; - map_pptr = sc->tx_map_unused_data; - for (i = 0; i < TSEC_TX_NUM_DESC; i++) { - map_pptr[i] = &map_ptr[i]; - error = bus_dmamap_create(sc->tsec_tx_mtag, 0, map_pptr[i]); + error = bus_dmamap_create(sc->tsec_tx_mtag, 0, + &sc->tx_bufmap[i].map); if (error) { device_printf(sc->dev, "failed to init TX ring\n"); tsec_detach(sc); return (ENXIO); } + sc->tx_bufmap[i].map_initialized = 1; } /* Create RX busdma maps and zero mbuf handlers */ @@ -745,124 +741,135 @@ static void tsec_start_locked(struct ifnet *ifp) { struct tsec_softc *sc; - struct mbuf *m0, *mtmp; struct tsec_tx_fcb *tx_fcb; - unsigned int queued = 0; - int csum_flags, fcb_inserted = 0; + int start_tx; sc = ifp->if_softc; + start_tx = 0; TSEC_TRANSMIT_LOCK_ASSERT(sc); - if ((ifp->if_drv_flags & (IFF_DRV_RUNNING | IFF_DRV_OACTIVE)) != - IFF_DRV_RUNNING) - return; - if (sc->tsec_link == 0) return; bus_dmamap_sync(sc->tsec_tx_dtag, sc->tsec_tx_dmap, BUS_DMASYNC_POSTREAD | BUS_DMASYNC_POSTWRITE); - while (!IFQ_DRV_IS_EMPTY(&ifp->if_snd)) { + for (;;) { + struct mbuf *m0; + uint16_t fcb_flags; + int csum_flags; + + if (TSEC_FREE_TX_DESC(sc) < TSEC_TX_MAX_DMA_SEGS) { + /* No free descriptors */ + ifp->if_drv_flags |= IFF_DRV_OACTIVE; + break; + } + /* Get packet from the queue */ IFQ_DRV_DEQUEUE(&ifp->if_snd, m0); if (m0 == NULL) break; /* Insert TCP/IP Off-load frame control block */ + fcb_flags = 0; csum_flags = m0->m_pkthdr.csum_flags; if (csum_flags) { - M_PREPEND(m0, sizeof(struct tsec_tx_fcb), M_NOWAIT); if (m0 == NULL) break; - tx_fcb = mtod(m0, struct tsec_tx_fcb *); - tx_fcb->flags = 0; - tx_fcb->l3_offset = ETHER_HDR_LEN; - tx_fcb->l4_offset = sizeof(struct ip); - if (csum_flags & CSUM_IP) - tx_fcb->flags |= TSEC_TX_FCB_IP4 | + fcb_flags |= TSEC_TX_FCB_IP4 | TSEC_TX_FCB_CSUM_IP; if (csum_flags & CSUM_TCP) - tx_fcb->flags |= TSEC_TX_FCB_TCP | + fcb_flags |= TSEC_TX_FCB_TCP | TSEC_TX_FCB_CSUM_TCP_UDP; if (csum_flags & CSUM_UDP) - tx_fcb->flags |= TSEC_TX_FCB_UDP | + fcb_flags |= TSEC_TX_FCB_UDP | TSEC_TX_FCB_CSUM_TCP_UDP; - fcb_inserted = 1; + tx_fcb = mtod(m0, struct tsec_tx_fcb *); + tx_fcb->flags = fcb_flags; + tx_fcb->l3_offset = ETHER_HDR_LEN; + tx_fcb->l4_offset = sizeof(struct ip); } - mtmp = m_defrag(m0, M_NOWAIT); - if (mtmp) - m0 = mtmp; - - if (tsec_encap(sc, m0, fcb_inserted)) { - IFQ_DRV_PREPEND(&ifp->if_snd, m0); - ifp->if_drv_flags |= IFF_DRV_OACTIVE; - break; - } - queued++; - BPF_MTAP(ifp, m0); + tsec_encap(ifp, sc, m0, fcb_flags, &start_tx); } bus_dmamap_sync(sc->tsec_tx_dtag, sc->tsec_tx_dmap, BUS_DMASYNC_PREREAD | BUS_DMASYNC_PREWRITE); - if (queued) { + if (start_tx) { /* Enable transmitter and watchdog timer */ TSEC_WRITE(sc, TSEC_REG_TSTAT, TSEC_TSTAT_THLT); sc->tsec_watchdog = 5; } } -static int -tsec_encap(struct tsec_softc *sc, struct mbuf *m0, int fcb_inserted) +static void +tsec_encap(struct ifnet *ifp, struct tsec_softc *sc, struct mbuf *m0, + uint16_t fcb_flags, int *start_tx) { - struct tsec_desc *tx_desc = NULL; - struct ifnet *ifp; - bus_dma_segment_t segs[TSEC_TX_NUM_DESC]; - bus_dmamap_t *mapp; - int csum_flag = 0, error, seg, nsegs; + bus_dma_segment_t segs[TSEC_TX_MAX_DMA_SEGS]; + int error, i, nsegs; + struct tsec_bufmap *tx_bufmap; + uint32_t tx_idx; + uint16_t flags; TSEC_TRANSMIT_LOCK_ASSERT(sc); - ifp = sc->tsec_ifp; - - if (TSEC_FREE_TX_DESC(sc) == 0) { - /* No free descriptors */ - return (-1); - } - - /* Fetch unused map */ - mapp = TSEC_ALLOC_TX_MAP(sc); + tx_idx = sc->tx_idx_head; + tx_bufmap = &sc->tx_bufmap[tx_idx]; /* Create mapping in DMA memory */ - error = bus_dmamap_load_mbuf_sg(sc->tsec_tx_mtag, - *mapp, m0, segs, &nsegs, BUS_DMA_NOWAIT); - if (error != 0 || nsegs > TSEC_FREE_TX_DESC(sc) || nsegs <= 0) { - bus_dmamap_unload(sc->tsec_tx_mtag, *mapp); - TSEC_FREE_TX_MAP(sc, mapp); - return ((error != 0) ? error : -1); + error = bus_dmamap_load_mbuf_sg(sc->tsec_tx_mtag, tx_bufmap->map, m0, + segs, &nsegs, BUS_DMA_NOWAIT); + if (error == EFBIG) { + /* Too many segments! Defrag and try again. */ + struct mbuf *m = m_defrag(m0, M_NOWAIT); + + if (m == NULL) { + m_freem(m0); + return; + } + m0 = m; + error = bus_dmamap_load_mbuf_sg(sc->tsec_tx_mtag, + tx_bufmap->map, m0, segs, &nsegs, BUS_DMA_NOWAIT); + } + if (error != 0) { + /* Give up. */ + m_freem(m0); + return; } - bus_dmamap_sync(sc->tsec_tx_mtag, *mapp, BUS_DMASYNC_PREWRITE); - - if ((ifp->if_flags & IFF_DEBUG) && (nsegs > 1)) - if_printf(ifp, "TX buffer has %d segments\n", nsegs); - - if (fcb_inserted) - csum_flag = TSEC_TXBD_TOE; - /* Everything is ok, now we can send buffers */ - for (seg = 0; seg < nsegs; seg++) { - tx_desc = TSEC_GET_CUR_TX_DESC(sc); + bus_dmamap_sync(sc->tsec_tx_mtag, tx_bufmap->map, + BUS_DMASYNC_PREWRITE); + tx_bufmap->mbuf = m0; - tx_desc->length = segs[seg].ds_len; - tx_desc->bufptr = segs[seg].ds_addr; + /* + * Fill in the TX descriptors back to front so that READY bit in first + * descriptor is set last. + */ + tx_idx = (tx_idx + (uint32_t)nsegs) & (TSEC_TX_NUM_DESC - 1); + sc->tx_idx_head = tx_idx; + flags = TSEC_TXBD_L | TSEC_TXBD_I | TSEC_TXBD_R | TSEC_TXBD_TC; + for (i = nsegs - 1; i >= 0; i--) { + struct tsec_desc *tx_desc; + + tx_idx = (tx_idx - 1) & (TSEC_TX_NUM_DESC - 1); + tx_desc = &sc->tsec_tx_vaddr[tx_idx]; + tx_desc->length = segs[i].ds_len; + tx_desc->bufptr = segs[i].ds_addr; + + if (i == 0) { + wmb(); + + if (fcb_flags != 0) + flags |= TSEC_TXBD_TOE; + } /* * Set flags: @@ -872,17 +879,14 @@ tsec_encap(struct tsec_softc *sc, struct mbuf *m0, int fcb_inserted) * - transmit the CRC sequence after the last data byte * - interrupt after the last buffer */ - tx_desc->flags = - (tx_desc->flags & TSEC_TXBD_W) | - ((seg == 0) ? csum_flag : 0) | TSEC_TXBD_R | TSEC_TXBD_TC | - ((seg == nsegs - 1) ? TSEC_TXBD_L | TSEC_TXBD_I : 0); - } + tx_desc->flags = (tx_idx == (TSEC_TX_NUM_DESC - 1) ? + TSEC_TXBD_W : 0) | flags; - /* Save mbuf and DMA mapping for release at later stage */ - TSEC_PUT_TX_MBUF(sc, m0); - TSEC_PUT_TX_MAP(sc, mapp); + flags &= ~(TSEC_TXBD_L | TSEC_TXBD_I); + } - return (0); + BPF_MTAP(ifp, m0); + *start_tx = 1; } static void @@ -1206,9 +1210,9 @@ tsec_free_dma(struct tsec_softc *sc) /* Free TX maps */ for (i = 0; i < TSEC_TX_NUM_DESC; i++) - if (sc->tx_map_data[i] != NULL) + if (sc->tx_bufmap[i].map_initialized) bus_dmamap_destroy(sc->tsec_tx_mtag, - sc->tx_map_data[i]); + sc->tx_bufmap[i].map); /* Destroy tag for TX mbufs */ bus_dma_tag_destroy(sc->tsec_tx_mtag); @@ -1243,8 +1247,6 @@ static void tsec_stop(struct tsec_softc *sc) { struct ifnet *ifp; - struct mbuf *m0; - bus_dmamap_t *mapp; uint32_t tmpval; TSEC_GLOBAL_LOCK_ASSERT(sc); @@ -1261,16 +1263,15 @@ tsec_stop(struct tsec_softc *sc) tsec_dma_ctl(sc, 0); /* Remove pending data from TX queue */ - while (!TSEC_EMPTYQ_TX_MBUF(sc)) { - m0 = TSEC_GET_TX_MBUF(sc); - mapp = TSEC_GET_TX_MAP(sc); - - bus_dmamap_sync(sc->tsec_tx_mtag, *mapp, + while (sc->tx_idx_tail != sc->tx_idx_head) { + bus_dmamap_sync(sc->tsec_tx_mtag, + sc->tx_bufmap[sc->tx_idx_tail].map, BUS_DMASYNC_POSTWRITE); - bus_dmamap_unload(sc->tsec_tx_mtag, *mapp); - - TSEC_FREE_TX_MAP(sc, mapp); - m_freem(m0); + bus_dmamap_unload(sc->tsec_tx_mtag, + sc->tx_bufmap[sc->tx_idx_tail].map); + m_freem(sc->tx_bufmap[sc->tx_idx_tail].mbuf); + sc->tx_idx_tail = (sc->tx_idx_tail + 1) + & (TSEC_TX_NUM_DESC - 1); } /* Disable RX and TX */ @@ -1467,11 +1468,8 @@ tsec_receive_intr(void *arg) static void tsec_transmit_intr_locked(struct tsec_softc *sc) { - struct tsec_desc *tx_desc; struct ifnet *ifp; - struct mbuf *m0; - bus_dmamap_t *mapp; - int send = 0; + uint32_t tx_idx; TSEC_TRANSMIT_LOCK_ASSERT(sc); @@ -1490,44 +1488,41 @@ tsec_transmit_intr_locked(struct tsec_softc *sc) bus_dmamap_sync(sc->tsec_tx_dtag, sc->tsec_tx_dmap, BUS_DMASYNC_POSTREAD | BUS_DMASYNC_POSTWRITE); - while (TSEC_CUR_DIFF_DIRTY_TX_DESC(sc)) { - tx_desc = TSEC_GET_DIRTY_TX_DESC(sc); + tx_idx = sc->tx_idx_tail; + while (tx_idx != sc->tx_idx_head) { + struct tsec_desc *tx_desc; + struct tsec_bufmap *tx_bufmap; + + tx_desc = &sc->tsec_tx_vaddr[tx_idx]; if (tx_desc->flags & TSEC_TXBD_R) { - TSEC_BACK_DIRTY_TX_DESC(sc); break; } - if ((tx_desc->flags & TSEC_TXBD_L) == 0) + tx_bufmap = &sc->tx_bufmap[tx_idx]; + tx_idx = (tx_idx + 1) & (TSEC_TX_NUM_DESC - 1); + if (tx_bufmap->mbuf == NULL) continue; /* * This is the last buf in this packet, so unmap and free it. */ - m0 = TSEC_GET_TX_MBUF(sc); - mapp = TSEC_GET_TX_MAP(sc); - - bus_dmamap_sync(sc->tsec_tx_mtag, *mapp, + bus_dmamap_sync(sc->tsec_tx_mtag, tx_bufmap->map, BUS_DMASYNC_POSTWRITE); - bus_dmamap_unload(sc->tsec_tx_mtag, *mapp); - - TSEC_FREE_TX_MAP(sc, mapp); - m_freem(m0); + bus_dmamap_unload(sc->tsec_tx_mtag, tx_bufmap->map); + m_freem(tx_bufmap->mbuf); + tx_bufmap->mbuf = NULL; if_inc_counter(ifp, IFCOUNTER_OPACKETS, 1); - send = 1; } + sc->tx_idx_tail = tx_idx; bus_dmamap_sync(sc->tsec_tx_dtag, sc->tsec_tx_dmap, BUS_DMASYNC_PREREAD | BUS_DMASYNC_PREWRITE); - if (send) { - /* Now send anything that was pending */ - ifp->if_drv_flags &= ~IFF_DRV_OACTIVE; - tsec_start_locked(ifp); + ifp->if_drv_flags &= ~IFF_DRV_OACTIVE; + tsec_start_locked(ifp); - /* Stop wathdog if all sent */ - if (TSEC_EMPTYQ_TX_MBUF(sc)) - sc->tsec_watchdog = 0; - } + if (sc->tx_idx_tail == sc->tx_idx_head) + sc->tsec_watchdog = 0; } void diff --git a/sys/dev/tsec/if_tsec.h b/sys/dev/tsec/if_tsec.h index d13f463..c8dca3b 100644 --- a/sys/dev/tsec/if_tsec.h +++ b/sys/dev/tsec/if_tsec.h @@ -32,6 +32,7 @@ #define TSEC_RX_NUM_DESC 256 #define TSEC_TX_NUM_DESC 256 +#define TSEC_TX_MAX_DMA_SEGS 8 /* Interrupt Coalescing types */ #define TSEC_IC_RX 0 @@ -44,6 +45,12 @@ #define TSEC_MIN_FRAME_SIZE 64 #define TSEC_MAX_FRAME_SIZE 9600 +struct tsec_bufmap { + bus_dmamap_t map; + int map_initialized; + struct mbuf *mbuf; +}; + struct tsec_softc { /* XXX MII bus requires that struct ifnet is first!!! */ struct ifnet *tsec_ifp; @@ -59,16 +66,16 @@ struct tsec_softc { bus_dma_tag_t tsec_tx_dtag; /* TX descriptors tag */ bus_dmamap_t tsec_tx_dmap; /* TX descriptors map */ - struct tsec_desc *tsec_tx_vaddr;/* vadress of TX descriptors */ - uint32_t tsec_tx_raddr; /* real address of TX descriptors */ + bus_dma_tag_t tsec_tx_mtag; /* TX mbufs tag */ + uint32_t tx_idx_head; /* TX head descriptor/bufmap index */ + uint32_t tx_idx_tail; /* TX tail descriptor/bufmap index */ + struct tsec_desc *tsec_tx_vaddr;/* virtual address of TX descriptors */ + struct tsec_bufmap tx_bufmap[TSEC_TX_NUM_DESC]; + bus_dma_tag_t tsec_rx_mtag; /* TX mbufs tag */ bus_dma_tag_t tsec_rx_dtag; /* RX descriptors tag */ bus_dmamap_t tsec_rx_dmap; /* RX descriptors map */ struct tsec_desc *tsec_rx_vaddr; /* vadress of RX descriptors */ - uint32_t tsec_rx_raddr; /* real address of RX descriptors */ - - bus_dma_tag_t tsec_tx_mtag; /* TX mbufs tag */ - bus_dma_tag_t tsec_rx_mtag; /* TX mbufs tag */ struct rx_data_type { bus_dmamap_t map; /* mbuf map */ @@ -76,8 +83,6 @@ struct tsec_softc { uint32_t paddr; /* DMA address of buffer */ } rx_data[TSEC_RX_NUM_DESC]; - uint32_t tx_cur_desc_cnt; - uint32_t tx_dirty_desc_cnt; uint32_t rx_cur_desc_cnt; struct resource *sc_rres; /* register resource */ @@ -104,24 +109,6 @@ struct tsec_softc { struct callout tsec_callout; int tsec_watchdog; - /* TX maps */ - bus_dmamap_t tx_map_data[TSEC_TX_NUM_DESC]; - - /* unused TX maps data */ - uint32_t tx_map_unused_get_cnt; - uint32_t tx_map_unused_put_cnt; - bus_dmamap_t *tx_map_unused_data[TSEC_TX_NUM_DESC]; - - /* used TX maps data */ - uint32_t tx_map_used_get_cnt; - uint32_t tx_map_used_put_cnt; - bus_dmamap_t *tx_map_used_data[TSEC_TX_NUM_DESC]; - - /* mbufs in TX queue */ - uint32_t tx_mbuf_used_get_cnt; - uint32_t tx_mbuf_used_put_cnt; - struct mbuf *tx_mbuf_used_data[TSEC_TX_NUM_DESC]; - /* interrupt coalescing */ struct mtx ic_lock; uint32_t rx_ic_time; /* RW, valid values 0..65535 */ @@ -136,6 +123,9 @@ struct tsec_softc { bus_space_tag_t phy_bst; bus_space_handle_t phy_bsh; int phy_regoff; + + uint32_t tsec_rx_raddr; /* real address of RX descriptors */ + uint32_t tsec_tx_raddr; /* real address of TX descriptors */ }; /* interface to get/put generic objects */ @@ -156,75 +146,8 @@ struct tsec_softc { (sc)->count = (wrap) - 1; \ } while (0) -/* TX maps interface */ -#define TSEC_TX_MAP_CNT_INIT(sc) do { \ - TSEC_CNT_INIT((sc)->tx_map_unused_get_cnt, TSEC_TX_NUM_DESC); \ - TSEC_CNT_INIT((sc)->tx_map_unused_put_cnt, TSEC_TX_NUM_DESC); \ - TSEC_CNT_INIT((sc)->tx_map_used_get_cnt, TSEC_TX_NUM_DESC); \ - TSEC_CNT_INIT((sc)->tx_map_used_put_cnt, TSEC_TX_NUM_DESC); \ -} while (0) - -/* interface to get/put unused TX maps */ -#define TSEC_ALLOC_TX_MAP(sc) \ - TSEC_GET_GENERIC(sc, tx_map_unused_data, tx_map_unused_get_cnt, \ - TSEC_TX_NUM_DESC) - -#define TSEC_FREE_TX_MAP(sc, val) \ - TSEC_PUT_GENERIC(sc, tx_map_unused_data, tx_map_unused_put_cnt, \ - TSEC_TX_NUM_DESC, val) - -/* interface to get/put used TX maps */ -#define TSEC_GET_TX_MAP(sc) \ - TSEC_GET_GENERIC(sc, tx_map_used_data, tx_map_used_get_cnt, \ - TSEC_TX_NUM_DESC) - -#define TSEC_PUT_TX_MAP(sc, val) \ - TSEC_PUT_GENERIC(sc, tx_map_used_data, tx_map_used_put_cnt, \ - TSEC_TX_NUM_DESC, val) - -/* interface to get/put TX mbufs in send queue */ -#define TSEC_TX_MBUF_CNT_INIT(sc) do { \ - TSEC_CNT_INIT((sc)->tx_mbuf_used_get_cnt, TSEC_TX_NUM_DESC); \ - TSEC_CNT_INIT((sc)->tx_mbuf_used_put_cnt, TSEC_TX_NUM_DESC); \ -} while (0) - -#define TSEC_GET_TX_MBUF(sc) \ - TSEC_GET_GENERIC(sc, tx_mbuf_used_data, tx_mbuf_used_get_cnt, \ - TSEC_TX_NUM_DESC) - -#define TSEC_PUT_TX_MBUF(sc, val) \ - TSEC_PUT_GENERIC(sc, tx_mbuf_used_data, tx_mbuf_used_put_cnt, \ - TSEC_TX_NUM_DESC, val) - -#define TSEC_EMPTYQ_TX_MBUF(sc) \ - ((sc)->tx_mbuf_used_get_cnt == (sc)->tx_mbuf_used_put_cnt) - -/* interface for manage tx tsec_desc */ -#define TSEC_TX_DESC_CNT_INIT(sc) do { \ - TSEC_CNT_INIT((sc)->tx_cur_desc_cnt, TSEC_TX_NUM_DESC); \ - TSEC_CNT_INIT((sc)->tx_dirty_desc_cnt, TSEC_TX_NUM_DESC); \ -} while (0) - -#define TSEC_GET_CUR_TX_DESC(sc) \ - &TSEC_GET_GENERIC(sc, tsec_tx_vaddr, tx_cur_desc_cnt, \ - TSEC_TX_NUM_DESC) - -#define TSEC_GET_DIRTY_TX_DESC(sc) \ - &TSEC_GET_GENERIC(sc, tsec_tx_vaddr, tx_dirty_desc_cnt, \ - TSEC_TX_NUM_DESC) - -#define TSEC_BACK_DIRTY_TX_DESC(sc) \ - TSEC_BACK_GENERIC(sc, tx_dirty_desc_cnt, TSEC_TX_NUM_DESC) - -#define TSEC_CUR_DIFF_DIRTY_TX_DESC(sc) \ - ((sc)->tx_cur_desc_cnt != (sc)->tx_dirty_desc_cnt) - -#define TSEC_FREE_TX_DESC(sc) \ - (((sc)->tx_cur_desc_cnt < (sc)->tx_dirty_desc_cnt) ? \ - ((sc)->tx_dirty_desc_cnt - (sc)->tx_cur_desc_cnt - 1) \ - : \ - (TSEC_TX_NUM_DESC - (sc)->tx_cur_desc_cnt \ - + (sc)->tx_dirty_desc_cnt - 1)) +#define TSEC_FREE_TX_DESC(sc) \ + (((sc)->tx_idx_tail - (sc)->tx_idx_head - 1) & (TSEC_TX_NUM_DESC - 1)) /* interface for manage rx tsec_desc */ #define TSEC_RX_DESC_CNT_INIT(sc) do { \ @@ -243,9 +166,8 @@ struct tsec_softc { /* init all counters (for init only!) */ #define TSEC_TX_RX_COUNTERS_INIT(sc) do { \ - TSEC_TX_MAP_CNT_INIT(sc); \ - TSEC_TX_MBUF_CNT_INIT(sc); \ - TSEC_TX_DESC_CNT_INIT(sc); \ + sc->tx_idx_head = 0; \ + sc->tx_idx_tail = 0; \ TSEC_RX_DESC_CNT_INIT(sc); \ } while (0) -- 1.8.4.5 From owner-freebsd-net@freebsd.org Tue Mar 7 15:11:06 2017 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id DB5F8D01CE9 for ; Tue, 7 Mar 2017 15:11:06 +0000 (UTC) (envelope-from vegeta@tuxpowered.net) Received: from mail-wm0-x230.google.com (mail-wm0-x230.google.com [IPv6:2a00:1450:400c:c09::230]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 747B21F56 for ; Tue, 7 Mar 2017 15:11:06 +0000 (UTC) (envelope-from vegeta@tuxpowered.net) Received: by mail-wm0-x230.google.com with SMTP id n11so7479239wma.0 for ; Tue, 07 Mar 2017 07:11:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tuxpowered-net.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version; bh=qezzfJfFl6eVBDJbWvMMPEVRFu56OX9va35C2FYYkis=; b=gw+PbRx8/OX8KNU1lIEhRj9HjRJkUL5G/re8j4NJFwGq+QONOSO4d85sZ7OsCdKozI XpRx36t4oJMcbRX2aKnWoMkKU3//lh9obCO65LUms3LwioJCvPvBY4Naqh3MTQrRO0rA WTfxwjwjzQMGclLyOJPI1neIwlDgKS6MJ/h9lZ6Bfk2q7YzUMqF/5ebMIO/+RCwB201N 2afERin92w6XbqEaNiFv87ASU+rd99My5sLf2phahZmrqyb6jjyh3YtDKb+THNBoFklb vQ16X4Kx3tqqJ1GRTIiMGMlUAKzycBIT5o3036SS+YeFPZXRQ+2tMWCTfilzAaBomMMD sysA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version; bh=qezzfJfFl6eVBDJbWvMMPEVRFu56OX9va35C2FYYkis=; b=LKHbAEutoCiFl6xDstdPz+mngJavXW2nb/XkkPQWa/IRgo8hWK+xeFHmE1wBmhGz14 vTX061QQ0NGRLorn89poaacrtlzlPUbMqjFgj4ph0fytrtkLkZ12ncqljyun0X/BY6+k ifAws3H07k4uXeq5Rbl1gtyTsTvZDJQDbhSXhYQTLhtPiAVWRj7s/+n2WF/Y0v7CF6cL 4tJPntBLgucjrhA219DYYB217jEEkpTtsNXVIF7BbeQEE3GomtIH6TAcq87uU2YPo/aB 3bv5VCmYqJ+rOshASXPqr94f+LCqQZVsYEfYtpJGfwh6vFmgZpeTMnFqxRDgHzXY45ol micg== X-Gm-Message-State: AMke39le/5w170dEShpyCHkyf5YbkKcQa5aLoVzYatuo3pxx1i/IXYORUCUUhIfa10/YmA== X-Received: by 10.28.18.134 with SMTP id 128mr1262853wms.53.1488899464513; Tue, 07 Mar 2017 07:11:04 -0800 (PST) Received: from energia.localnet ([2a02:8108:4b3f:d254::5]) by smtp.gmail.com with ESMTPSA id c9sm905179wmf.18.2017.03.07.07.11.02 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 07 Mar 2017 07:11:03 -0800 (PST) From: Kajetan Staszkiewicz To: Sepherosa Ziehau Cc: "freebsd-net@freebsd.org" Subject: Re: Why is MSI-X support disabled on bce(4)? Date: Tue, 07 Mar 2017 16:10:59 +0100 Message-ID: <4257854.XfJjHtrk4r@energia> Organization: tuxpowered.net User-Agent: KMail/5.2.3 (Linux/4.9.0-12.1-liquorix-amd64; KDE/5.28.0; x86_64; ; ) In-Reply-To: References: <1946092.tUUkk3b7I7@energia> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart1572770.jZC0y4Ae39"; micalg="pgp-sha1"; protocol="application/pgp-signature" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 07 Mar 2017 15:11:07 -0000 --nextPart1572770.jZC0y4Ae39 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" Dnia poniedzia=C5=82ek, 6 marca 2017 16:06:03 CET Sepherosa Ziehau pisze: > On Thu, Mar 2, 2017 at 10:02 PM, Kajetan Staszkiewicz >=20 > wrote: > > To whom it might concern: > >=20 > > Well, at least it does concern me. Why is support for multiple interrup= ts > > and queues not enabled on bce(4)? > >=20 > > Whole block of code is surrounded with #ifdef 0 ... #endif > >=20 > > https://github.com/freebsd/freebsd/blob/master/sys/dev/bce/if_bce.c#L11= 08 >=20 > It involves much more work than the commented out MSI-X allocation, like > this: > https://gitweb.dragonflybsd.org/dragonfly.git/commitdiff/b42386ee03a4e688= c8 > 64ba8d7094064c63d93dce?hp=3Dbe5708901d52be5534d5075eec706f5570b6a0f3 That is sad news. Should I assume that porting this driver from DragonflyBS= D=20 to FreeBSD would be impossible? =2D-=20 | pozdrawiam / greetings | powered by Debian, FreeBSD and CentOS | | Kajetan Staszkiewicz | jabber,email: vegeta()tuxpowered net | | Vegeta | www: http://vegeta.tuxpowered.net | `------------------------^---------------------------------------' --nextPart1572770.jZC0y4Ae39 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part. Content-Transfer-Encoding: 7Bit -----BEGIN PGP SIGNATURE----- iF0EABECAB0WIQSOEQZObv2B8mf0JbnjtFCvbXs6FAUCWL7NgwAKCRDjtFCvbXs6 FLCyAKCPuJFkNiAug8zJp0ip+U1CBupR3wCdH5/8pj4+Ht/ZrnfeKUqWGa/26LM= =UtXb -----END PGP SIGNATURE----- --nextPart1572770.jZC0y4Ae39-- From owner-freebsd-net@freebsd.org Tue Mar 7 18:21:57 2017 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id D2200D02CEB for ; Tue, 7 Mar 2017 18:21:57 +0000 (UTC) (envelope-from daemon-user@freebsd.org) Received: from reviews.nyi.freebsd.org (reviews.nyi.freebsd.org [IPv6:2610:1c1:1:607c::16:b]) by mx1.freebsd.org (Postfix) with ESMTP id AEE3A1B1C for ; Tue, 7 Mar 2017 18:21:57 +0000 (UTC) (envelope-from daemon-user@freebsd.org) Received: by reviews.nyi.freebsd.org (Postfix, from userid 1346) id 7159B1B5AA; Tue, 7 Mar 2017 18:21:57 +0000 (UTC) Date: Tue, 7 Mar 2017 18:21:57 +0000 To: freebsd-net@freebsd.org From: "asomers (Alan Somers)" Reply-to: D9451+325+eaa6f8a0c0731bfe@reviews.freebsd.org Subject: [Differential] D9451: Constrain IPv6 interface routes to each FIB Message-ID: <393c7a156a4de2d99d99ea9bfaa0611d@localhost.localdomain> X-Priority: 3 X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: Thread-Topic: D9451: Constrain IPv6 interface routes to each FIB X-Herald-Rules: <28>, <81>, <51> X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: Precedence: bulk In-Reply-To: References: Thread-Index: MzA4MmVhNjA3MDYxYjk1ZGE4NzFjZWJhMzgyIFi++kU= MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.23 List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 07 Mar 2017 18:21:57 -0000 YXNvbWVycyBhZGRlZCBpbmxpbmUgY29tbWVudHMuCgpJTkxJTkUgQ09NTUVOVFMKCj4gamh1amhp dGlfYWRqZWN0aXZpc20ub3JnIHdyb3RlIGluIGljbXA2LmM6MjE0Nwo+IEBhc29tZXJzLCBjYW4g eW91IGNvbmZpcm0gdGhhdCBNX0dFVEZJQihtKSBpcyBhbHdheXMgY29ycmVjdGx5IHNldCB0byB0 aGUgRklCIG9mIHRoZSByZWNlaXZpbmcgaW50ZXJmYWNlPwoKTm8uICBBY2NvcmRpbmcgdG8gdGhl IGNvbW1lbnQgYXQgdGhlIGJvdHRvbSBvZiBpY21wNl9lcnJvciwgaXQgaXNuJ3QsIGJlY2F1c2Ug aWNtcDZfcmVmbGVjdCBjYW4gc29tZXRpbWVzIGJlIGNhbGxlZCBmcm9tIHRoZSBvdXRwdXQgcGF0 aC4gIEluIHRoYXQgY2FzZSwgdGhlcmUgd291bGRuJ3QgYmUgYSByZWNlaXZpbmcgaW50ZXJmYWNl LiAgSG93ZXZlciwgYE1fR0VURklCKG0pYCB3aWxsIGRlZmluaXRlbHkgcmV0dXJuIF9hXyBmaWIu ICBJdCB3aWxsIGVpdGhlciBoYXZlIHRoZSBmaWIgb2YgdGhlIHJlY2VpdmluZyBpbnRlcmZhY2Ug aWYgdGhpcyBpcyBvbiB0aGUgcmVjZWl2ZSBwYXRoLCBvciB0aGUgZmliIG9mIHRoZSBzb2NrZXQg aWYgdGhpcyBpcyBvbiB0aGUgb3V0cHV0IHBhdGguICBTb2NrZXQgZmlicyBkZWZhdWx0IHRvIHRo ZSBwcm9jZXNzIGZpYiwgd2hpY2ggY2Fubm90IGJlIGBSVF9BTExfRklCU2AsIGJ1dCB0aGV5IGNh biBhbHNvIGJlIHNldCBieSBgc2V0c29ja29wdCguLi4sIFNPX1NFVEZJQiwgLi4uKWAsIHdoaWNo IGFsc28gZG9lc24ndCBhbGxvdyBgUlRfQUxMX0ZJQlNgLiAgU28gSSB0aGluayB5b3VyIGNvZGUg aXMgb2sgaGVyZS4KClJFUE9TSVRPUlkKICByUyBGcmVlQlNEIHNyYyByZXBvc2l0b3J5CgpSRVZJ U0lPTiBERVRBSUwKICBodHRwczovL3Jldmlld3MuZnJlZWJzZC5vcmcvRDk0NTEKCkVNQUlMIFBS RUZFUkVOQ0VTCiAgaHR0cHM6Ly9yZXZpZXdzLmZyZWVic2Qub3JnL3NldHRpbmdzL3BhbmVsL2Vt YWlscHJlZmVyZW5jZXMvCgpUbzogamh1amhpdGlfYWRqZWN0aXZpc20ub3JnLCAjbmV0d29yaywg YnosIGFzb21lcnMKQ2M6IGpjaCwgYnosIGltcCwgYWUsIGZyZWVic2QtbmV0LWxpc3QK From owner-freebsd-net@freebsd.org Tue Mar 7 19:36:14 2017 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 1DB78D01CED for ; Tue, 7 Mar 2017 19:36:14 +0000 (UTC) (envelope-from mike@sentex.net) Received: from smarthost2.sentex.ca (smarthost2.sentex.ca [IPv6:2607:f3e0:80:80::2]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client CN "smarthost.sentex.ca", Issuer "smarthost.sentex.ca" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id D86F817E1 for ; Tue, 7 Mar 2017 19:36:13 +0000 (UTC) (envelope-from mike@sentex.net) Received: from lava.sentex.ca (lava.sentex.ca [IPv6:2607:f3e0:0:5::11]) by smarthost2.sentex.ca (8.15.2/8.15.2) with ESMTPS id v27JaC1R081435 (version=TLSv1 cipher=DHE-RSA-CAMELLIA256-SHA bits=256 verify=NO) for ; Tue, 7 Mar 2017 14:36:12 -0500 (EST) (envelope-from mike@sentex.net) Received: from [IPv6:2607:f3e0:0:4:5c30:ed1b:e203:c55c] ([IPv6:2607:f3e0:0:4:5c30:ed1b:e203:c55c]) by lava.sentex.ca (8.15.2/8.15.2) with ESMTP id v27JaADK021848 for ; Tue, 7 Mar 2017 14:36:10 -0500 (EST) (envelope-from mike@sentex.net) To: "freebsd-net@freebsd.org" From: Mike Tancsa Subject: Chelsio netmap support ? (RELENG_11) Organization: Sentex Communications Message-ID: <93e10699-ecc7-c062-bf85-a26de0de9633@sentex.net> Date: Tue, 7 Mar 2017 14:36:11 -0500 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.78 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 07 Mar 2017 19:36:14 -0000 I have a Chelsio T520 NIC that I have been trying to get netmap working with. I see reference to the ncxl# vs cxl# interface on the lists, but I never see ncxl come up. The man pages dont say anything about having to specifically enable anything that I can see. I am using RELENG11 as of today (r314848). ---Mike t5nex0@pci0:2:0:4: class=0x020000 card=0x00001425 chip=0x54071425 rev=0x00 hdr=0x00 vendor = 'Chelsio Communications Inc' device = 'T520-SO Unified Wire Ethernet Controller' class = network subclass = ethernet bar [10] = type Memory, range 64, base 0xdd300000, size 524288, enabled bar [18] = type Memory, range 64, base 0xdc000000, size 16777216, enabled bar [20] = type Memory, range 64, base 0xdd884000, size 8192, enabled cap 01[40] = powerspec 3 supports D0 D3 current D0 cap 05[50] = MSI supports 32 messages, 64 bit, vector masks cap 10[70] = PCI-Express 2 endpoint max data 256(2048) FLR RO NS link x8(x8) speed 8.0(8.0) cap 11[b0] = MSI-X supports 256 messages, enabled Table in map 0x20[0x0], PBA in map 0x20[0x1000] cap 03[d0] = VPD ecap 0001[100] = AER 2 0 fatal 0 non-fatal 1 corrected ecap 0003[170] = Serial 1 0000000000000000 ecap 000e[190] = ARI 1 ecap 0019[1a0] = PCIe Sec 1 lane errors 0 ecap 0010[1c0] = SR-IOV 1 IOV disabled, Memory Space disabled, ARI disabled 0 VFs configured out of 0 supported First VF RID Offset 0x0008, VF RID Stride 0x0004 VF Device ID 0x5807 Page Sizes: 4096 (enabled), 8192, 65536, 262144, 1048576, 4194304 ecap 0017[200] = TPH Requester 1 netmap seems to activate on the onboard igb NICs. # dmesg | grep -i netma netmap: loaded module igb0: netmap queues/slots: TX 4/1024, RX 4/1024 igb1: netmap queues/slots: TX 4/1024, RX 4/1024 # ifconfig cxl1 cxl1: flags=8843 metric 0 mtu 1500 options=ec07bb ether 00:07:43:39:9d:b8 inet 10.151.10.1 netmask 0xffffff00 broadcast 10.151.10.255 nd6 options=29 media: Ethernet 10Gbase-Twinax status: active plugged: SFP/SFP+/SFP28 Unknown (Copper pigtail) vendor: CISCO-TYCO PN: 1-2053783-2 SN: TED1605BGWC DATE: 2016-02-01 ---Mike -- ------------------- Mike Tancsa, tel +1 519 651 3400 Sentex Communications, mike@sentex.net Providing Internet services since 1994 www.sentex.net Cambridge, Ontario Canada http://www.tancsa.com/ From owner-freebsd-net@freebsd.org Tue Mar 7 20:21:14 2017 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id ADE54D02D09 for ; Tue, 7 Mar 2017 20:21:14 +0000 (UTC) (envelope-from nparhar@gmail.com) Received: from mail-pg0-x22f.google.com (mail-pg0-x22f.google.com [IPv6:2607:f8b0:400e:c05::22f]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 8B18214F0 for ; Tue, 7 Mar 2017 20:21:14 +0000 (UTC) (envelope-from nparhar@gmail.com) Received: by mail-pg0-x22f.google.com with SMTP id 25so4377829pgy.0 for ; Tue, 07 Mar 2017 12:21:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=UBcfcjD73h/DVOuPpqh2Gg7PA6IGZkRTEq/c3q64ABw=; b=W3TqcnK7BK4/DR3KR1hrK5kVwb9chP2NL8h41MUuWrz5Aw+kb1RZOm6s32tjQxCsq7 ewts4szaWsdphPCUeu5a9z3ZUGKbCpIr23IqWeJbiCwIU9QWIyDqpfaZv2AkWj+XeyXM tgGaUTag1mzAYdMtyQFBkTAC2HQgAXK2BAzZBCagWIU6tXYgjEiLHrltDlz4cbEcgay1 9pjsyNWIgdT1D5Du3e85WToYnH+uYrT3A7zB+wVGRyf08TEbivv8Xy/miLsSEo2I7F0P +1BVN6on1hu7uGyoMRDhsxRf/22aowMLeJGW8wGurU+NxrU/oDT+Py+ZyU42rINPdype trIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=UBcfcjD73h/DVOuPpqh2Gg7PA6IGZkRTEq/c3q64ABw=; b=eMCymUvyc0WnFsXFAOZcXtSH5PjmcE6NZj04UiBWixnOkCaCW1MIniG+QV2o9I7apJ AQFJYHTGcomfWSr3ssItMy5GOTrqyLsMuGNNur5xjDZp7w8BtU9itsfdkIjYD989OJPh 818qlcpaXzhixCNI+aVwy0HccH0yvyHAWtwuszukyCXIyRkWlnb1t8rim5nQtkmrVukk LGUP5XJn5kbVL7fOxP+vQF9bHXPXlV7kBJ86mqdJ+XFrQ0xbS3w/STZ7J+qlc8P5CeeZ 7/yGBq8zwv00fWIl5tyYYqD9NWwJucE1nCJZ/piwEcY9mO56k7m3RZESJfcJmfRE3OHU JWkg== X-Gm-Message-State: AMke39ncrnh1bPWJGsc6PRt9jR+d95ZuTZGIG9OEdqz8yOH6P4Em3w1ZecCVwNMLuW/wAocA1vA7ge0UuVJxPQ== X-Received: by 10.84.192.107 with SMTP id b98mr3063757pld.160.1488918073989; Tue, 07 Mar 2017 12:21:13 -0800 (PST) MIME-Version: 1.0 Received: by 10.100.182.172 with HTTP; Tue, 7 Mar 2017 12:21:13 -0800 (PST) In-Reply-To: <93e10699-ecc7-c062-bf85-a26de0de9633@sentex.net> References: <93e10699-ecc7-c062-bf85-a26de0de9633@sentex.net> From: Navdeep Parhar Date: Tue, 7 Mar 2017 12:21:13 -0800 Message-ID: Subject: Re: Chelsio netmap support ? (RELENG_11) To: Mike Tancsa Cc: "freebsd-net@freebsd.org" Content-Type: text/plain; charset=UTF-8 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 07 Mar 2017 20:21:14 -0000 Is it possible for you to run 10-STABLE? The netmap support in cxgbe was enhanced and uses the general purpose 'vcxl' interfaces now. You can enable them with hw.cxgbe.num_vis=2 in loader.conf. If -STABLE is not an option then check if you built your kernel with device NETMAP. config -x /boot/kernel/kernel | grep -i netmap. cxgbe has compile time checks for netmap so loadable netmap module may not work. Regards, Navdeep On Tue, Mar 7, 2017 at 11:36 AM, Mike Tancsa wrote: > I have a Chelsio T520 NIC that I have been trying to get netmap working > with. I see reference to the ncxl# vs cxl# interface on the lists, but I > never see ncxl come up. The man pages dont say anything about having to > specifically enable anything that I can see. I am using RELENG11 as of > today (r314848). > > ---Mike > > t5nex0@pci0:2:0:4: class=0x020000 card=0x00001425 chip=0x54071425 > rev=0x00 hdr=0x00 > vendor = 'Chelsio Communications Inc' > device = 'T520-SO Unified Wire Ethernet Controller' > class = network > subclass = ethernet > bar [10] = type Memory, range 64, base 0xdd300000, size 524288, > enabled > bar [18] = type Memory, range 64, base 0xdc000000, size 16777216, > enabled > bar [20] = type Memory, range 64, base 0xdd884000, size 8192, enabled > cap 01[40] = powerspec 3 supports D0 D3 current D0 > cap 05[50] = MSI supports 32 messages, 64 bit, vector masks > cap 10[70] = PCI-Express 2 endpoint max data 256(2048) FLR RO NS > link x8(x8) speed 8.0(8.0) > cap 11[b0] = MSI-X supports 256 messages, enabled > Table in map 0x20[0x0], PBA in map 0x20[0x1000] > cap 03[d0] = VPD > ecap 0001[100] = AER 2 0 fatal 0 non-fatal 1 corrected > ecap 0003[170] = Serial 1 0000000000000000 > ecap 000e[190] = ARI 1 > ecap 0019[1a0] = PCIe Sec 1 lane errors 0 > ecap 0010[1c0] = SR-IOV 1 IOV disabled, Memory Space disabled, ARI > disabled > 0 VFs configured out of 0 supported > First VF RID Offset 0x0008, VF RID Stride 0x0004 > VF Device ID 0x5807 > Page Sizes: 4096 (enabled), 8192, 65536, 262144, > 1048576, 4194304 > ecap 0017[200] = TPH Requester 1 > > netmap seems to activate on the onboard igb NICs. > # dmesg | grep -i netma > netmap: loaded module > igb0: netmap queues/slots: TX 4/1024, RX 4/1024 > igb1: netmap queues/slots: TX 4/1024, RX 4/1024 > > # ifconfig cxl1 > cxl1: flags=8843 metric 0 mtu 1500 > > options=ec07bb > ether 00:07:43:39:9d:b8 > inet 10.151.10.1 netmask 0xffffff00 broadcast 10.151.10.255 > nd6 options=29 > media: Ethernet 10Gbase-Twinax > status: active > plugged: SFP/SFP+/SFP28 Unknown (Copper pigtail) > vendor: CISCO-TYCO PN: 1-2053783-2 SN: TED1605BGWC DATE: 2016-02-01 > > ---Mike > > -- > ------------------- > Mike Tancsa, tel +1 519 651 3400 > Sentex Communications, mike@sentex.net > Providing Internet services since 1994 www.sentex.net > Cambridge, Ontario Canada http://www.tancsa.com/ > _______________________________________________ > freebsd-net@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/freebsd-net > To unsubscribe, send any mail to "freebsd-net-unsubscribe@freebsd.org" From owner-freebsd-net@freebsd.org Tue Mar 7 20:24:59 2017 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 0B34BD02FDA for ; Tue, 7 Mar 2017 20:24:59 +0000 (UTC) (envelope-from nparhar@gmail.com) Received: from mail-pf0-x235.google.com (mail-pf0-x235.google.com [IPv6:2607:f8b0:400e:c00::235]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id D2D5D1957 for ; Tue, 7 Mar 2017 20:24:58 +0000 (UTC) (envelope-from nparhar@gmail.com) Received: by mail-pf0-x235.google.com with SMTP id v190so4836180pfb.1 for ; Tue, 07 Mar 2017 12:24:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=Y4/gf5JmdwkMTzRYZqB0PxjwoFFAU7XAe4BVkxXvW4g=; b=YZtVrdhuohWTkmgESVM+Mb+K56mHUX5097yYN6/4rM006bh0tTfCA77kV5/lYTkEvY sfUabsM6BrrZe8XGyfhMigPJjTBIGFGetNBrnw5a32DnGXiY8b4flMPQG/F7g10slhUM lxgxACSCltqyhrElrsUT49pdDyNsAialfW4hazVjZP5x7TbC4UgBCA0ORA1laq1qrOC2 HHWuDXcyE4FrmLnki7z+ZyCG9nmvA7hD41xpYndPOaixIxKg+WUYDV7TwJbuT8arq00l UZ2fZxyq16EnVIaWAez9hHMN51ZzE0UN4+OqRTot1v4b63DGBCD/Ew6sNOt4H8FrRqoa Pc6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=Y4/gf5JmdwkMTzRYZqB0PxjwoFFAU7XAe4BVkxXvW4g=; b=MI8913DBVfeXdjnBTw6u2wRqEPFqn+3F0lq7gqbgRt4mTGbCrODfl4iKbBZ/GwLTB5 YCxH9H0zARUZDL4O5hiC9TXpTB78wgJIUgtUdQp4U3hLoDDNopTRkFNk7AenLzaWlZXY gRpucio0osRCKe6czbZrHGocB3rC39Xu9qdHWn7uLLX0SzgjpTAjuhMciPQiuZ3V18Te LZmDgQWC5BPfO8XYjOSoAb8L+kTqABfJV/T/A3phfWjGGlnGLNsMDugXFQDZnxZCAunE wuUDAB+DZCIGmfmDndsIqA5euyjm72hfwaUPMUn5r50wb6He47RfOAmvDix3OdCu7J4K 58TQ== X-Gm-Message-State: AMke39kXx8xrTzqqwEFRurh5vrHQ6Kc9+U+Q2EAKO9DXsvVzvoqtVaVByDdlreQn0oefOXzVan5v/BbLvvbq2w== X-Received: by 10.84.210.167 with SMTP id a36mr3126243pli.40.1488918298389; Tue, 07 Mar 2017 12:24:58 -0800 (PST) MIME-Version: 1.0 Received: by 10.100.182.172 with HTTP; Tue, 7 Mar 2017 12:24:57 -0800 (PST) In-Reply-To: References: <93e10699-ecc7-c062-bf85-a26de0de9633@sentex.net> From: Navdeep Parhar Date: Tue, 7 Mar 2017 12:24:57 -0800 Message-ID: Subject: Re: Chelsio netmap support ? (RELENG_11) To: Mike Tancsa Cc: "freebsd-net@freebsd.org" Content-Type: text/plain; charset=UTF-8 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 07 Mar 2017 20:24:59 -0000 On Tue, Mar 7, 2017 at 12:21 PM, Navdeep Parhar wrote: > Is it possible for you to run 10-STABLE? I meant 11-STABLE of course. From owner-freebsd-net@freebsd.org Tue Mar 7 21:53:37 2017 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 5E39ED01E37 for ; Tue, 7 Mar 2017 21:53:37 +0000 (UTC) (envelope-from mike@sentex.net) Received: from smarthost2.sentex.ca (smarthost2.sentex.ca [IPv6:2607:f3e0:80:80::2]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client CN "smarthost.sentex.ca", Issuer "smarthost.sentex.ca" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 3B9771F11 for ; Tue, 7 Mar 2017 21:53:37 +0000 (UTC) (envelope-from mike@sentex.net) Received: from lava.sentex.ca (lava.sentex.ca [IPv6:2607:f3e0:0:5::11]) by smarthost2.sentex.ca (8.15.2/8.15.2) with ESMTPS id v27LraHa095492 (version=TLSv1 cipher=DHE-RSA-CAMELLIA256-SHA bits=256 verify=NO) for ; Tue, 7 Mar 2017 16:53:36 -0500 (EST) (envelope-from mike@sentex.net) Received: from [IPv6:2607:f3e0:0:4:e95c:7d13:e5c8:9187] ([IPv6:2607:f3e0:0:4:e95c:7d13:e5c8:9187]) by lava.sentex.ca (8.15.2/8.15.2) with ESMTP id v27LrXT6022148; Tue, 7 Mar 2017 16:53:33 -0500 (EST) (envelope-from mike@sentex.net) Subject: Re: Chelsio netmap support ? (RELENG_11) To: Navdeep Parhar , "freebsd-net@freebsd.org" References: <93e10699-ecc7-c062-bf85-a26de0de9633@sentex.net> From: Mike Tancsa Organization: Sentex Communications Message-ID: Date: Tue, 7 Mar 2017 16:53:34 -0500 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.78 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 07 Mar 2017 21:53:37 -0000 On 3/7/2017 3:34 PM, Navdeep Parhar wrote: > cxgbe's netmap support was overhauled in r302110 so it should already > be in 11.0. Try hw.cxgbe.num_vis=2 and use the vcxl interfaces for > netmap. > > https://lists.freebsd.org/pipermail/svn-src-all/2016-June/126504.html Thanks very much Navdeep! Yes indeed, adding that in boot/loader.conf did the trick # ifconfig vcxl1 vcxl1: flags=8843 metric 0 mtu 1500 options=ec07bb ether 00:07:43:39:9d:ba inet 10.151.10.1 netmask 0xffffff00 broadcast 10.151.10.255 nd6 options=29 media: Ethernet 10Gbase-Twinax status: active plugged: SFP/SFP+/SFP28 Unknown (Copper pigtail) vendor: CISCO-TYCO PN: 1-2053783-2 SN: TED1605BGWC DATE: 2016-02-01 # dmesg | grep -i netma netmap: loaded module vcxl0: netmap queues/slots: TX 2/1023, RX 2/1024 vcxl0: 1 txq, 1 rxq (NIC); 1 txq, 1 rxq (TOE); 2 txq, 2 rxq (netmap) vcxl1: netmap queues/slots: TX 2/1023, RX 2/1024 vcxl1: 1 txq, 1 rxq (NIC); 1 txq, 1 rxq (TOE); 2 txq, 2 rxq (netmap) igb0: netmap queues/slots: TX 4/1024, RX 4/1024 igb1: netmap queues/slots: TX 4/1024, RX 4/1024 Using netsend, I cant seem to blast through a single flow of packets greater than 800Kpps without packet loss. Can you point me to any performance tweaks for forwarding / routing ? I have 3 boxes, with one in the middle (netsend box) <----> (router with chelsio nics) <---> (netreceive box) #./netsend 10.151.10.3 500 100 800000 20 Sending packet of payload size 100 every 0.000001250s for 20 seconds calling time every 100 cycles start: 1488952041.000000000 finish: 1488952061.000000837 send calls: 16000000 send errors: 0 approx send rate: 800000 pps time/packet: 1250 ns approx error rate: 0 waited: 333086341 approx waits/sec: 16654317 approx wait rate: 20 dev.cxl.0.stats.rx_frames_1024_1518: 4444000 dev.cxl.0.stats.rx_frames_512_1023: 96620637 dev.cxl.0.stats.rx_frames_256_511: 5876251 dev.cxl.0.stats.rx_frames_128_255: 100581998 dev.cxl.0.stats.rx_frames_65_127: 1203 dev.cxl.0.stats.rx_frames_64: 263 dev.cxl.0.stats.rx_ucast_frames: 207523216 dev.cxl.0.stats.rx_mcast_frames: 929 dev.cxl.0.stats.rx_bcast_frames: 207 dev.cxl.0.stats.rx_frames: 207524352 dev.cxl.0.stats.rx_octets: 85804034610 dev.cxl.0.stats.tx_frames_256_511: 59 dev.cxl.0.stats.tx_frames_65_127: 406 dev.cxl.0.stats.tx_frames_64: 12 dev.cxl.0.stats.tx_ucast_frames: 414 dev.cxl.0.stats.tx_mcast_frames: 59 dev.cxl.0.stats.tx_bcast_frames: 4 dev.cxl.0.stats.tx_frames: 477 dev.cxl.0.stats.tx_octets: 59172 dev.cxl.0.max_speed: 10 dev.cxl.0.autoneg: 1 dev.cxl.0.linkdnrc: n/a dev.cxl.0.qsize_txq: 1024 dev.cxl.0.qsize_rxq: 1024 dev.cxl.0.holdoff_pktc_idx: -1 dev.cxl.0.holdoff_tmr_idx: 1 dev.cxl.0.nofldtxq: 4 dev.cxl.0.nofldrxq: 2 dev.cxl.0.rss_size: 64 dev.cxl.0.ntxq: 4 dev.cxl.0.nrxq: 4 dev.cxl.0.viid: 1224 dev.cxl.0.%parent: t5nex0 dev.cxl.0.%pnpinfo: dev.cxl.0.%location: dev.cxl.0.%driver: cxl dev.cxl.0.%desc: port 0 dev.vcxl.0.ofld_txq.0.sidx: 1023 dev.vcxl.0.ofld_txq.0.cntxt_id: 36 dev.vcxl.0.ofld_txq.0.dmalen: 65536 dev.vcxl.0.ofld_txq.0.ba: 1376874496 dev.vcxl.0.txq.0.r_starts: 477 dev.vcxl.0.txq.0.r_enqueues: 477 dev.vcxl.0.txq.0.txpkt_wrs: 477 dev.vcxl.0.txq.0.sgl_wrs: 465 dev.vcxl.0.txq.0.imm_wrs: 12 dev.vcxl.0.txq.0.txcsum: 7 dev.vcxl.0.txq.0.tc: -1 dev.vcxl.0.txq.0.sidx: 1023 dev.vcxl.0.txq.0.pidx: 489 dev.vcxl.0.txq.0.cidx: 489 dev.vcxl.0.txq.0.cntxt_id: 35 dev.vcxl.0.txq.0.abs_id: 35 dev.vcxl.0.txq.0.dmalen: 65536 dev.vcxl.0.txq.0.ba: 1376808960 dev.vcxl.0.ofld_rxq.0.fl.cluster_allocated: 32 dev.vcxl.0.ofld_rxq.0.fl.pidx: 32 dev.vcxl.0.ofld_rxq.0.fl.packing: 1 dev.vcxl.0.ofld_rxq.0.fl.padding: 1 dev.vcxl.0.ofld_rxq.0.fl.cntxt_id: 34 dev.vcxl.0.ofld_rxq.0.fl.dmalen: 8192 dev.vcxl.0.ofld_rxq.0.fl.ba: 249552896 dev.vcxl.0.ofld_rxq.0.cntxt_id: 18 dev.vcxl.0.ofld_rxq.0.abs_id: 18 dev.vcxl.0.ofld_rxq.0.dmalen: 65536 dev.vcxl.0.ofld_rxq.0.ba: 1376219136 dev.vcxl.0.rxq.0.fl.cluster_fast_recycled: 1827953 dev.vcxl.0.rxq.0.fl.cluster_recycled: 30549354 dev.vcxl.0.rxq.0.fl.cluster_allocated: 148525 dev.vcxl.0.rxq.0.fl.mbuf_inlined: 61393725 dev.vcxl.0.rxq.0.fl.mbuf_allocated: 122009392 dev.vcxl.0.rxq.0.fl.pidx: 624 dev.vcxl.0.rxq.0.fl.rx_offset: 2304 dev.vcxl.0.rxq.0.fl.cidx: 639 dev.vcxl.0.rxq.0.fl.packing: 1 dev.vcxl.0.rxq.0.fl.padding: 1 dev.vcxl.0.rxq.0.fl.cntxt_id: 33 dev.vcxl.0.rxq.0.fl.dmalen: 8192 dev.vcxl.0.rxq.0.fl.ba: 249544704 dev.vcxl.0.rxq.0.rxcsum: 183402000 dev.vcxl.0.rxq.0.cidx: 151 dev.vcxl.0.rxq.0.cntxt_id: 17 dev.vcxl.0.rxq.0.abs_id: 17 dev.vcxl.0.rxq.0.dmalen: 65536 dev.vcxl.0.rxq.0.ba: 1376153600 dev.vcxl.0.qsize_txq: 1024 dev.vcxl.0.qsize_rxq: 1024 dev.vcxl.0.holdoff_pktc_idx: -1 dev.vcxl.0.holdoff_tmr_idx: 1 dev.vcxl.0.nnmtxq: 2 dev.vcxl.0.nnmrxq: 2 dev.vcxl.0.first_ofld_txq: 4 dev.vcxl.0.first_ofld_rxq: 2 dev.vcxl.0.nofldtxq: 1 dev.vcxl.0.nofldrxq: 1 dev.vcxl.0.rss_size: 64 dev.vcxl.0.first_txq: 4 dev.vcxl.0.first_rxq: 4 dev.vcxl.0.ntxq: 1 dev.vcxl.0.nrxq: 1 dev.vcxl.0.viid: 1226 dev.vcxl.0.%parent: cxl0 dev.vcxl.0.%pnpinfo: dev.vcxl.0.%location: dev.vcxl.0.%driver: vcxl dev.vcxl.0.%desc: port 0 vi 1 ---Mike -- ------------------- Mike Tancsa, tel +1 519 651 3400 Sentex Communications, mike@sentex.net Providing Internet services since 1994 www.sentex.net Cambridge, Ontario Canada http://www.tancsa.com/ From owner-freebsd-net@freebsd.org Tue Mar 7 22:07:58 2017 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id D0C4FD02290 for ; Tue, 7 Mar 2017 22:07:58 +0000 (UTC) (envelope-from nparhar@gmail.com) Received: from mail-pf0-x22c.google.com (mail-pf0-x22c.google.com [IPv6:2607:f8b0:400e:c00::22c]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id A285216DB for ; Tue, 7 Mar 2017 22:07:58 +0000 (UTC) (envelope-from nparhar@gmail.com) Received: by mail-pf0-x22c.google.com with SMTP id w189so5790228pfb.0 for ; Tue, 07 Mar 2017 14:07:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=pRgj2xXkevcPFZdwM2zKAw9rKGCKRzIiG1nm4s47se8=; b=efb9Jg44fncrN4ALIrR0psXX/nsMWjO3WHaPzheke8kzDw2fU4RcGEwbRmf2AEeQPL z93f6WvDSOKvIKyYe5vcn8c46w/nWFJNRgwhk8/KdfDFyOiUIxRbufHCvrZw4UI5n4d5 Fo1wxhPFGVXOUBvihSdjT1QIg7/wBAG6kIFqa1DAc0FYT3xeKO/YhyzDo9uPrjoLNNCx b38RuIMA/4slBH4sH3ZDwRfeWQME6K7idLvh9b3rzEsjMqe3HnMPWNb+XaSrXShJj/1P 5Xc2EXcrwmWMgFIils/cer1mo+nmXdro1kPDAdeE+x92YFbxDYGhDgkgbCmea0OTBVcl eNmg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=pRgj2xXkevcPFZdwM2zKAw9rKGCKRzIiG1nm4s47se8=; b=kPGZwwczLxIdZWi0WsFCD9jcPr/6WU6wNE6ZdY4wJJp8I5B/lJE7vdfOb5IPpU7wis zekG9bz+aEFQDa/bPlq1yeNEBfgVFpAPbc2augXcNFVjemWq5B52h5oPvvDxg3OO2eHW f6RVlJzZ74OxG2surGgo6z9OQf6IilCE1T6qL44RkzK3Ofolh6OAoR95XoaGq9USaYOK gOFctpwsntxJ4bNQNogzGiXXiXBaHSu8izR5hoAjI4CH/AxnnykKgml0H/gPQXz9hVM4 lYKhCP0i3ciZZU2UjHZjuhea7iSxOZ+S2LtCx/HS7XBdfTTejSnkcKpMiUeaLyrQUrJV PSPw== X-Gm-Message-State: AMke39lmE+4erQ2SY6H100sNq0ghMlsjc8JmjLg3b3t6iDDqyr8L5ysOw+Dbcf14O/jRkHwkxBDB29f4ipwtow== X-Received: by 10.98.138.132 with SMTP id o4mr2934727pfk.70.1488924478179; Tue, 07 Mar 2017 14:07:58 -0800 (PST) MIME-Version: 1.0 Received: by 10.100.182.172 with HTTP; Tue, 7 Mar 2017 14:07:57 -0800 (PST) In-Reply-To: References: <93e10699-ecc7-c062-bf85-a26de0de9633@sentex.net> From: Navdeep Parhar Date: Tue, 7 Mar 2017 14:07:57 -0800 Message-ID: Subject: Re: Chelsio netmap support ? (RELENG_11) To: Mike Tancsa Cc: "freebsd-net@freebsd.org" Content-Type: text/plain; charset=UTF-8 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 07 Mar 2017 22:07:58 -0000 On Tue, Mar 7, 2017 at 1:53 PM, Mike Tancsa wrote: ... > > Using netsend, I cant seem to blast through a single flow of packets > greater than 800Kpps without packet loss. Can you point me to any > performance tweaks for forwarding / routing ? > > I have 3 boxes, with one in the middle > > (netsend box) <----> (router with chelsio nics) <---> (netreceive box) How is the router configured -- is this something netmap based? Please provide more details of the configuration. What kind of CPU/chipset is it? Do you see any PAUSE frames out of the T5? "sysctl dev.cxl dev.vcxl | grep _pause" Is any CPU core pegged at 100% during the test? Regards, Navdeep > #./netsend 10.151.10.3 500 100 800000 20 > Sending packet of payload size 100 every 0.000001250s for 20 seconds > calling time every 100 cycles > > start: 1488952041.000000000 > finish: 1488952061.000000837 > send calls: 16000000 > send errors: 0 > approx send rate: 800000 pps > time/packet: 1250 ns > approx error rate: 0 > waited: 333086341 > approx waits/sec: 16654317 > approx wait rate: 20 > > From owner-freebsd-net@freebsd.org Wed Mar 8 01:38:13 2017 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id DA7DCD013E1 for ; Wed, 8 Mar 2017 01:38:13 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id C9AF2131A for ; Wed, 8 Mar 2017 01:38:13 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id v281cDcS052514 for ; Wed, 8 Mar 2017 01:38:13 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-net@FreeBSD.org Subject: [Bug 217607] ng_cisco only sends flow control messages to nodes connected via 'inet' hook Date: Wed, 08 Mar 2017 01:38:14 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 11.0-STABLE X-Bugzilla-Keywords: patch X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: linimon@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-net@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: short_desc assigned_to keywords Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Mar 2017 01:38:14 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D217607 Mark Linimon changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|ng_cisco flow control |ng_cisco only sends flow |messages and IPv6 |control messages to nodes | |connected via 'inet' hook Assignee|freebsd-bugs@FreeBSD.org |freebsd-net@FreeBSD.org Keywords| |patch --=20 You are receiving this mail because: You are the assignee for the bug.= From owner-freebsd-net@freebsd.org Wed Mar 8 01:38:39 2017 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 09166D0148F for ; Wed, 8 Mar 2017 01:38:39 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id EC7C91471 for ; Wed, 8 Mar 2017 01:38:38 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id v281cccS053011 for ; Wed, 8 Mar 2017 01:38:38 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-net@FreeBSD.org Subject: [Bug 217606] Bridge stops working after some days Date: Wed, 08 Mar 2017 01:38:39 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 11.0-RELEASE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: linimon@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-net@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: assigned_to Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Mar 2017 01:38:39 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D217606 Mark Linimon changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|freebsd-bugs@FreeBSD.org |freebsd-net@FreeBSD.org --=20 You are receiving this mail because: You are the assignee for the bug.= From owner-freebsd-net@freebsd.org Wed Mar 8 01:39:08 2017 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id A5F42D01596 for ; Wed, 8 Mar 2017 01:39:08 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 95EF815E0 for ; Wed, 8 Mar 2017 01:39:08 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id v281d7GV053618 for ; Wed, 8 Mar 2017 01:39:08 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-net@FreeBSD.org Subject: [Bug 217600] Gateway enable not working Date: Wed, 08 Mar 2017 01:39:08 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 10.3-RELEASE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: linimon@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-net@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: assigned_to Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Mar 2017 01:39:08 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D217600 Mark Linimon changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|freebsd-bugs@FreeBSD.org |freebsd-net@FreeBSD.org --=20 You are receiving this mail because: You are the assignee for the bug.= From owner-freebsd-net@freebsd.org Wed Mar 8 01:41:51 2017 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 72885D017D8 for ; Wed, 8 Mar 2017 01:41:51 +0000 (UTC) (envelope-from daemon-user@freebsd.org) Received: from reviews.nyi.freebsd.org (reviews.nyi.freebsd.org [IPv6:2610:1c1:1:607c::16:b]) by mx1.freebsd.org (Postfix) with ESMTP id 4DB8418DE for ; Wed, 8 Mar 2017 01:41:51 +0000 (UTC) (envelope-from daemon-user@freebsd.org) Received: by reviews.nyi.freebsd.org (Postfix, from userid 1346) id CC9041B87B; Wed, 8 Mar 2017 01:41:50 +0000 (UTC) Date: Wed, 8 Mar 2017 01:41:50 +0000 To: freebsd-net@freebsd.org From: "jhujhiti_adjectivism.org (Erick Turnquist)" Reply-to: D9451+325+eaa6f8a0c0731bfe@reviews.freebsd.org Subject: [Differential] D9451: Constrain IPv6 interface routes to each FIB Message-ID: <2ad1fa2d996ed840348b4663cf81a952@localhost.localdomain> X-Priority: 3 X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: , Thread-Topic: D9451: Constrain IPv6 interface routes to each FIB X-Herald-Rules: <28>, <81>, <51> X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: Precedence: bulk In-Reply-To: References: Thread-Index: MzA4MmVhNjA3MDYxYjk1ZGE4NzFjZWJhMzgyIFi/YV4= MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.23 List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Mar 2017 01:41:51 -0000 amh1amhpdGlfYWRqZWN0aXZpc20ub3JnIG1hcmtlZCA2IGlubGluZSBjb21tZW50cyBhcyBkb25l LgpqaHVqaGl0aV9hZGplY3RpdmlzbS5vcmcgYWRkZWQgaW5saW5lIGNvbW1lbnRzLgoKSU5MSU5F IENPTU1FTlRTCgo+IGFzb21lcnMgd3JvdGUgaW4gaWNtcDYuYzoyMTQ3Cj4gTm8uICBBY2NvcmRp bmcgdG8gdGhlIGNvbW1lbnQgYXQgdGhlIGJvdHRvbSBvZiBpY21wNl9lcnJvciwgaXQgaXNuJ3Qs IGJlY2F1c2UgaWNtcDZfcmVmbGVjdCBjYW4gc29tZXRpbWVzIGJlIGNhbGxlZCBmcm9tIHRoZSBv dXRwdXQgcGF0aC4gIEluIHRoYXQgY2FzZSwgdGhlcmUgd291bGRuJ3QgYmUgYSByZWNlaXZpbmcg aW50ZXJmYWNlLiAgSG93ZXZlciwgYE1fR0VURklCKG0pYCB3aWxsIGRlZmluaXRlbHkgcmV0dXJu IF9hXyBmaWIuICBJdCB3aWxsIGVpdGhlciBoYXZlIHRoZSBmaWIgb2YgdGhlIHJlY2VpdmluZyBp bnRlcmZhY2UgaWYgdGhpcyBpcyBvbiB0aGUgcmVjZWl2ZSBwYXRoLCBvciB0aGUgZmliIG9mIHRo ZSBzb2NrZXQgaWYgdGhpcyBpcyBvbiB0aGUgb3V0cHV0IHBhdGguICBTb2NrZXQgZmlicyBkZWZh dWx0IHRvIHRoZSBwcm9jZXNzIGZpYiwgd2hpY2ggY2Fubm90IGJlIGBSVF9BTExfRklCU2AsIGJ1 dCB0aGV5IGNhbiBhbHNvIGJlIHNldCBieSBgc2V0c29ja29wdCguLi4sIFNPX1NFVEZJQiwgLi4u KWAsIHdoaWNoIGFsc28gZG9lc24ndCBhbGxvdyBgUlRfQUxMX0ZJQlNgLiAgU28gSSB0aGluayB5 b3VyIGNvZGUgaXMgb2sgaGVyZS4KCkFoIHllcywgdGhhdCdzIGhvdyBJIHNob3VsZCBoYXZlIHBo cmFzZWQgaXQgLSB2YWxpZCBGSUIgZXZlbiBpZiBjYWxsZWQgaW4gdGhlIG91dHB1dCBwYXRoLgoK PiBhc29tZXJzIHdyb3RlIGluIG5kNl9uYnIuYzoyNjUKPiBBcyB3aXRoIGBuZDZfaXNfbmV3X2Fk ZHJfbmVpZ2hib3JgLCB3ZSBzaG91bGQgZ2V0IEBieidzIHJldmlldyBoZXJlLgoKSSB0aGluayB0 aGlzIGlzIHRoZSBvbmx5IHRoaW5nIGxlZnQgdG8gY29uc2lkZXIgZm9yIHRoaXMgcGF0Y2gsIGJ1 dCBpdCBzZWVtcyB0byBtZSB0aGF0IHVzaW5nIHRoZSByZWNlaXZpbmcgaW50ZXJmYWNlJ3MgRklC IGlzIHRoZSBtb3N0IGNvcnJlY3QgdGhpbmcgdG8gZG8gaGVyZS4gQ2hlY2tpbmcgb3RoZXIgRklC cyBzZWVtcyBpbmNvcnJlY3Qgc2luY2UgdGhhdCB3b3VsZCBjYXVzZSB0aGUgcHJveHkgdG8gImxl YWsiIGFjcm9zcyBGSUIgYm91bmRhcmllcy4KClJFUE9TSVRPUlkKICByUyBGcmVlQlNEIHNyYyBy ZXBvc2l0b3J5CgpSRVZJU0lPTiBERVRBSUwKICBodHRwczovL3Jldmlld3MuZnJlZWJzZC5vcmcv RDk0NTEKCkVNQUlMIFBSRUZFUkVOQ0VTCiAgaHR0cHM6Ly9yZXZpZXdzLmZyZWVic2Qub3JnL3Nl dHRpbmdzL3BhbmVsL2VtYWlscHJlZmVyZW5jZXMvCgpUbzogamh1amhpdGlfYWRqZWN0aXZpc20u b3JnLCAjbmV0d29yaywgYnosIGFzb21lcnMKQ2M6IGpjaCwgYnosIGltcCwgYWUsIGZyZWVic2Qt bmV0LWxpc3QK From owner-freebsd-net@freebsd.org Wed Mar 8 01:46:51 2017 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id D43BFD019C7 for ; Wed, 8 Mar 2017 01:46:51 +0000 (UTC) (envelope-from mike@sentex.net) Received: from smarthost2.sentex.ca (smarthost2.sentex.ca [IPv6:2607:f3e0:80:80::2]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client CN "smarthost.sentex.ca", Issuer "smarthost.sentex.ca" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 9A78A1BF8 for ; Wed, 8 Mar 2017 01:46:51 +0000 (UTC) (envelope-from mike@sentex.net) Received: from lava.sentex.ca (lava.sentex.ca [IPv6:2607:f3e0:0:5::11]) by smarthost2.sentex.ca (8.15.2/8.15.2) with ESMTPS id v281koQV010071 (version=TLSv1 cipher=DHE-RSA-CAMELLIA256-SHA bits=256 verify=NO) for ; Tue, 7 Mar 2017 20:46:50 -0500 (EST) (envelope-from mike@sentex.net) Received: from [IPv6:2607:f3e0:0:4:e95c:7d13:e5c8:9187] ([IPv6:2607:f3e0:0:4:e95c:7d13:e5c8:9187]) by lava.sentex.ca (8.15.2/8.15.2) with ESMTP id v281klip022618; Tue, 7 Mar 2017 20:46:47 -0500 (EST) (envelope-from mike@sentex.net) Subject: Re: Chelsio netmap support ? (RELENG_11) To: Navdeep Parhar References: <93e10699-ecc7-c062-bf85-a26de0de9633@sentex.net> Cc: "freebsd-net@freebsd.org" From: Mike Tancsa Organization: Sentex Communications Message-ID: <901224a7-f3ed-84a4-5402-3542cd0e865b@sentex.net> Date: Tue, 7 Mar 2017 20:46:48 -0500 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.78 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Mar 2017 01:46:51 -0000 On 3/7/2017 5:07 PM, Navdeep Parhar wrote: > On Tue, Mar 7, 2017 at 1:53 PM, Mike Tancsa wrote: > ... >> >> Using netsend, I cant seem to blast through a single flow of packets >> greater than 800Kpps without packet loss. Can you point me to any >> performance tweaks for forwarding / routing ? >> >> I have 3 boxes, with one in the middle >> >> (netsend box) <----> (router with chelsio nics) <---> (netreceive box) > > How is the router configured -- is this something netmap based? > Please provide more details of the configuration. What kind of > CPU/chipset is it? Hi, Xeon E3-1225 v5 @ 3.30GHz Supermicro X11SSL-F Intel Skylake-S/Skylake-H/Greenlow PCI-e 3.0 slots t5iov0@pci0:2:0:0: class=0x020000 card=0x00001425 chip=0x50071425 rev=0x00 hdr=0x00 vendor = 'Chelsio Communications Inc' device = 'T520-SO Unified Wire Ethernet Controller' class = network subclass = ethernet bar [10] = type Memory, range 64, base 0xdd800000, size 524288, enabled bar [18] = type Memory, range 64, base 0xdd780000, size 524288, enabled bar [20] = type Memory, range 64, base 0xdd88c000, size 8192, enabled cap 01[40] = powerspec 3 supports D0 D3 current D0 cap 05[50] = MSI supports 8 messages, 64 bit, vector masks cap 10[70] = PCI-Express 2 endpoint max data 256(2048) FLR NS link x8(x8) speed 8.0(8.0) cap 11[b0] = MSI-X supports 34 messages Table in map 0x20[0x0], PBA in map 0x20[0x1000] cap 03[d0] = VPD ecap 0001[100] = AER 2 0 fatal 0 non-fatal 1 corrected ecap 0002[140] = VC 1 max VC1 ecap 0003[170] = Serial 1 0000000000000000 ecap 000e[190] = ARI 1 ecap 0019[1a0] = PCIe Sec 1 lane errors 0 ecap 0010[1c0] = SR-IOV 1 IOV disabled, Memory Space disabled, ARI disabled 0 VFs configured out of 16 supported First VF RID Offset 0x0008, VF RID Stride 0x0004 VF Device ID 0x5807 Page Sizes: 4096 (enabled), 8192, 65536, 262144, 1048576, 4194304 Two 10G interfaces on a switch vcxl0 (192.168.1.1) vcxl1 (10.151.10.1) 192.168.1.2 does the netsend to 10.151.10.3 so it goes through the router in question. Router in question is RELENG11 dev.cxl.0.pause_settings=0 dev.cxl.1.pause_settings=0 loader.conf kern.geom.label.disk_ident.enable="0" kern.geom.label.gptid.enable="0" zfs_load="YES" #t4fw_cfg_load="YES" t5fw_cfg_load="YES" #t6fw_cfg_load="YES" if_cxgbe_load="YES" hw.cxgbe.num_vis=2 comconsole_speed="115200" # Set the current serial console speed console="comconsole,vidconsole" # A comma separated list of console(s) comconsole_port="0x2F8" > Do you see any PAUSE frames out of the T5? "sysctl dev.cxl dev.vcxl | > grep _pause" Is any CPU core pegged at 100% during the test? dev.cxl.1.stats.rx_pause: 0 dev.cxl.1.stats.tx_pause: 0 dev.cxl.1.pause_settings: 0 dev.cxl.0.stats.rx_pause: 0 dev.cxl.0.stats.tx_pause: 0 dev.cxl.0.pause_settings: 0 while forwarding, top shows the system 25% in interrupt # dmesg | grep netm netmap: loaded module vcxl0: netmap queues/slots: TX 2/1023, RX 2/1024 vcxl0: 1 txq, 1 rxq (NIC); 1 txq, 1 rxq (TOE); 2 txq, 2 rxq (netmap) vcxl1: netmap queues/slots: TX 2/1023, RX 2/1024 vcxl1: 1 txq, 1 rxq (NIC); 1 txq, 1 rxq (TOE); 2 txq, 2 rxq (netmap) igb0: netmap queues/slots: TX 4/1024, RX 4/1024 igb1: netmap queues/slots: TX 4/1024, RX 4/1024 It maxes out at about 800Kpps with and without netmap. Is there a way to increase the queues for the Chelsio nic, like the onboard igb ? top -nCHSIzs1 last pid: 2517; load averages: 1.15, 0.45, 0.27 up 0+04:26:13 20:44:09 393 processes: 8 running, 346 sleeping, 39 waiting Mem: 10M Active, 37M Inact, 360M Wired, 15G Free ARC: 67M Total, 691K MFU, 64M MRU, 16K Anon, 430K Header, 1758K Other Swap: 32G Total, 32G Free PID USERNAME PRI NICE SIZE RES STATE C TIME CPU COMMAND 11 root -92 - 0K 672K CPU0 0 5:45 80.08% intr{irq272: t5nex0:0b0} ---Mike -- ------------------- Mike Tancsa, tel +1 519 651 3400 Sentex Communications, mike@sentex.net Providing Internet services since 1994 www.sentex.net Cambridge, Ontario Canada http://www.tancsa.com/ From owner-freebsd-net@freebsd.org Wed Mar 8 02:08:50 2017 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id ADEAACFB063 for ; Wed, 8 Mar 2017 02:08:50 +0000 (UTC) (envelope-from nparhar@gmail.com) Received: from mail-pg0-x22a.google.com (mail-pg0-x22a.google.com [IPv6:2607:f8b0:400e:c05::22a]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 7931C1527 for ; Wed, 8 Mar 2017 02:08:50 +0000 (UTC) (envelope-from nparhar@gmail.com) Received: by mail-pg0-x22a.google.com with SMTP id 187so7206392pgb.3 for ; Tue, 07 Mar 2017 18:08:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=ig4ff7scxFgzvHoAv95Fj24G5cmSbMbC1vWWPwkDV/4=; b=UUR8ZNu0al/jLBDizQx1vUqkN37rGDzhJgOcC4X5GXgI7gMgNjIm04T9ObDhipBACe SJar6islOeeDfWPtTZGTXpN+UWIcVZWD7jPyG/xd39QLLPM9Vkt5n1e/4SA/qfDnMHyU MTdLeWfd/GpPP43PwpipVeC5Ck1qDO7xd1IU60m2Rx547t984oHK6PnPlwh3yk9oFxNW J8r7u+EcoWwTFOgsoQo963evPLGLLvfGl3iDYmn+FoSFoCPtiSwNk9nKEK5lELGka/qJ d+9LcOQrVmQe16y9hl6SVvCgisbKMwV7ogPwP9XpQdzar2bXc1PDGZeNY4ibYiG+rXpE 7qow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=ig4ff7scxFgzvHoAv95Fj24G5cmSbMbC1vWWPwkDV/4=; b=QhLF8jhA17Cxs6TE7wqJSNQcALCgT/NaM+GimHMq8v0xVfCoZtCbO23r4iaepYkzZO HN+iZSsx6h0U9yX44EjQLb0HS7UKjXrFwxZaJLxU1MAkbMnPDs9VtxLhVlJXsiZ5+4bE FJM1N77R23EODKCHKvT7TVzeHa0JqFydJaiW1vTt0V7OSnS1dZhU2nZXTZYphXy+uPXJ R6vsaQv2Xnz3HpM5aITgfGKgCoyNM0R4e4tegXw17LQlMKEzG+vHG6xdSWyO8bsNFNCK nTugxk04E2fiFkSMQYx5M35Jemlf44zFJZ7GHqZrtcf0ya1u9NQkx7CkT4Gmnp9jOFci q4Qw== X-Gm-Message-State: AMke39nJ27NcvGm3ckDd04YxdNrZs+XYe8MaTyJYEzaGcpcp+ElszlmJqpmG6SmryEvzgBe7VlyQq4cKE84U0w== X-Received: by 10.84.176.131 with SMTP id v3mr4878508plb.7.1488938929811; Tue, 07 Mar 2017 18:08:49 -0800 (PST) MIME-Version: 1.0 Received: by 10.100.182.172 with HTTP; Tue, 7 Mar 2017 18:08:48 -0800 (PST) In-Reply-To: <901224a7-f3ed-84a4-5402-3542cd0e865b@sentex.net> References: <93e10699-ecc7-c062-bf85-a26de0de9633@sentex.net> <901224a7-f3ed-84a4-5402-3542cd0e865b@sentex.net> From: Navdeep Parhar Date: Tue, 7 Mar 2017 18:08:48 -0800 Message-ID: Subject: Re: Chelsio netmap support ? (RELENG_11) To: Mike Tancsa Cc: "freebsd-net@freebsd.org" Content-Type: text/plain; charset=UTF-8 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Mar 2017 02:08:50 -0000 On Tue, Mar 7, 2017 at 5:46 PM, Mike Tancsa wrote: > > # dmesg | grep netm > netmap: loaded module > vcxl0: netmap queues/slots: TX 2/1023, RX 2/1024 > vcxl0: 1 txq, 1 rxq (NIC); 1 txq, 1 rxq (TOE); 2 txq, 2 rxq (netmap) > vcxl1: netmap queues/slots: TX 2/1023, RX 2/1024 > vcxl1: 1 txq, 1 rxq (NIC); 1 txq, 1 rxq (TOE); 2 txq, 2 rxq (netmap) > igb0: netmap queues/slots: TX 4/1024, RX 4/1024 > igb1: netmap queues/slots: TX 4/1024, RX 4/1024 > > It maxes out at about 800Kpps with and without netmap. Is there a way Are you actually using a netmap based application that acts as a packet router or is this just the vcxl interface running as a normal ifnet? > to increase the queues for the Chelsio nic, like the onboard igb ? If you're not running a netmap based router get rid of the num_vis=2 and simply try with the cxl0/cxl1 interfaces. They should each have 4 rxq/4 txq on your system. In case you want to increase the number of queues, use this: # cxl0/cxl1 etc. hw.cxgbe.nrxq10g=8 hw.cxgbe.ntxq10g=8 # vcxl0/vcxl1's "normal" queues hw.cxgbe.nrxq_vi=8 hw.cxgbe.ntxq_vi=8 # vcxl0/vcxl1's netmap queues hw.cxgbe.nnmrxq_vi=8 hw.cxgbe.nnmtxq_vi=8 Check in dmesg after you reboot with your new settings > vcxl0: 1 txq, 1 rxq (NIC); 1 txq, 1 rxq (TOE); 2 txq, 2 rxq (netmap) The "NIC" queues are the normal tx/rx queues, the "netmap" queues are active when the interface is in netmap mode. Does netsend generate a single flow or multiple flows? If it's a single flow it will use a single queue only. Regards, Navdeep From owner-freebsd-net@freebsd.org Wed Mar 8 04:00:45 2017 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 3F2E0D02E2F; Wed, 8 Mar 2017 04:00:45 +0000 (UTC) (envelope-from emz@norma.perm.ru) Received: from elf.hq.norma.perm.ru (mail.norma.perm.ru [IPv6:2a00:7540:1::5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mail.norma.perm.ru", Issuer "Vivat-Trade UNIX Root CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 966D61FFD; Wed, 8 Mar 2017 04:00:43 +0000 (UTC) (envelope-from emz@norma.perm.ru) Received: from [192.168.243.2] ([192.168.243.2]) (authenticated bits=0) by elf.hq.norma.perm.ru (8.15.2/8.15.2) with ESMTPSA id v2840a2H063308 (version=TLSv1.2 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Wed, 8 Mar 2017 09:00:37 +0500 (YEKT) (envelope-from emz@norma.perm.ru) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=norma.perm.ru; s=key; t=1488945637; bh=eNsHPoYoIzGkWMtMuB6HhZQZiWU1JUHDkpjntSU4jTc=; h=To:From:Subject:Date; b=d0LRCbr8Sn5PFzQoxy0j30frGReeRTL9jW2EzzsuZUtVmamVSWy5YBPjsGgmpJiA5 jvUVg56+mR8jdocMhtR1o1EoJeaaVmG1SYc8VaN6SJcfjyhO/BGGjN/h794DhBdCrJ 8wSEuTH8Hz0TAdbSyXZCk/ujOlvpUACHsRLnAUhk= To: "stable@freebsd.org" , freebsd-net From: "Eugene M. Zheganin" Subject: about that DFBSD performance test Message-ID: Date: Wed, 8 Mar 2017 09:00:34 +0500 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Mar 2017 04:00:45 -0000 Hi. Some have probably seen this already - http://lists.dragonflybsd.org/pipermail/users/2017-March/313254.html So, could anyone explain why FreeBSD was owned that much. Test is split into two parts, one is nginx part, and the other is the IPv4 forwarding part. I understand that nginx ownage was due to SO_REUSEPORT feature, which we do formally have, but in DFBSD and Linux it does provide a kernel socket multiplexor, which eliminates locking, and ours does not. I have only found traces of discussion that DFBSD implementation is too hackish. Well, hackish or not, but it's 4 times faster, as it turns out. The IPv4 forwarding loss is pure defeat though. Please not that although they use HEAD it these tests, they also mention that this is the GENERIC-NODEBUG kernel which means this isn't related to the WITNESS stuff. Please also don't consider this trolling, I'm a big FreeBSD fan through the years, so I'm asking because I'm kind of concerned. Eugene. From owner-freebsd-net@freebsd.org Wed Mar 8 06:20:16 2017 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id BAF21D02293 for ; Wed, 8 Mar 2017 06:20:16 +0000 (UTC) (envelope-from vas@mpeks.tomsk.su) Received: from relay2.tomsk.ru (mail.sibptus.tomsk.ru [212.73.124.5]) by mx1.freebsd.org (Postfix) with ESMTP id 2FCC31006 for ; Wed, 8 Mar 2017 06:20:15 +0000 (UTC) (envelope-from vas@mpeks.tomsk.su) X-Virus-Scanned: by clamd daemon 0.98.5_1 for FreeBSD at relay2.tomsk.ru Received: from [212.73.125.240] (HELO admin.sibptus.transneft.ru) by relay2.tomsk.ru (CommuniGate Pro SMTP 5.1.16) with ESMTPS id 39632322 for freebsd-net@freebsd.org; Wed, 08 Mar 2017 12:15:43 +0600 Received: from admin.sibptus.transneft.ru (sudakov@localhost [127.0.0.1]) by admin.sibptus.transneft.ru (8.14.9/8.14.9) with ESMTP id v286KCAj065426 for ; Wed, 8 Mar 2017 13:20:12 +0700 (KRAT) (envelope-from vas@mpeks.tomsk.su) Received: (from sudakov@localhost) by admin.sibptus.transneft.ru (8.14.9/8.14.9/Submit) id v286KAns065425 for freebsd-net@freebsd.org; Wed, 8 Mar 2017 13:20:10 +0700 (KRAT) (envelope-from vas@mpeks.tomsk.su) X-Authentication-Warning: admin.sibptus.transneft.ru: sudakov set sender to vas@mpeks.tomsk.su using -f Date: Wed, 8 Mar 2017 13:20:10 +0700 From: Victor Sudakov To: freebsd-net@freebsd.org Subject: Re: GSSAPI and racoon Message-ID: <20170308062010.GA65343@admin.sibptus.transneft.ru> References: <20170303154509.GA81714@admin.sibptus.transneft.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170303154509.GA81714@admin.sibptus.transneft.ru> Organization: AO "Svyaztransneft", SibPTUS X-PGP-Key: http://www.dreamwidth.org/pubkey?user=victor_sudakov X-PGP-Fingerprint: 10E3 1171 1273 E007 C2E9 3532 0DA4 F259 9B5E C634 User-Agent: Mutt/1.7.1 (2016-10-04) X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Mar 2017 06:20:16 -0000 Victor Sudakov wrote: > > Is anyone running GSSAPI+IKE (racoon)? I'm still struggling with racoon in GSSAPI mode. racoon says 2017-03-08 13:01:59: [192.168.3.38] ERROR: failed to get valid proposal. 2017-03-08 13:01:59: [192.168.3.38] ERROR: failed to pre-process ph1 packet (side: 1, status 1). 2017-03-08 13:01:59: [192.168.3.38] ERROR: phase1 negotiation failed. I would be very grateful if someone with IPSec experience could look at my configs and logs. What am I missing? Not to clutter the list, I'm giving short URLs: racoon.conf: http://termbin.com/lk2w racoon debug log: http://termbin.com/0lol keytab: http://termbin.com/4yj9 The remote host configuration is identical, only it's called "ipsec1", not "ipsec2". BTW, does the "gss_id" parameter in the proposal section mean my id or remote's id? I interpret is as my id. PS If I comment out the GSSAPI stuff and enable the PSK stuff, everything works all right, so my SPDs at least are correct. -- Victor Sudakov, VAS4-RIPE, VAS47-RIPN AS43859 From owner-freebsd-net@freebsd.org Wed Mar 8 07:09:52 2017 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 6FA32D0260B for ; Wed, 8 Mar 2017 07:09:52 +0000 (UTC) (envelope-from sebastian.huber@embedded-brains.de) Received: from dedi548.your-server.de (dedi548.your-server.de [85.10.215.148]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 245DF10A2 for ; Wed, 8 Mar 2017 07:09:51 +0000 (UTC) (envelope-from sebastian.huber@embedded-brains.de) Received: from [88.198.220.131] (helo=sslproxy02.your-server.de) by dedi548.your-server.de with esmtpsa (TLSv1.2:DHE-RSA-AES256-GCM-SHA384:256) (Exim 4.85_2) (envelope-from ) id 1clVjI-0007tC-OH for freebsd-net@freebsd.org; Wed, 08 Mar 2017 08:09:48 +0100 Received: from [82.135.62.35] (helo=mail.embedded-brains.de) by sslproxy02.your-server.de with esmtpsa (TLSv1.2:DHE-RSA-AES256-GCM-SHA384:256) (Exim 4.84_2) (envelope-from ) id 1clVjI-0004bC-GC for freebsd-net@freebsd.org; Wed, 08 Mar 2017 08:09:48 +0100 Received: from localhost (localhost.localhost [127.0.0.1]) by mail.embedded-brains.de (Postfix) with ESMTP id A1A0A2A17F4 for ; Wed, 8 Mar 2017 08:09:58 +0100 (CET) Received: from mail.embedded-brains.de ([127.0.0.1]) by localhost (zimbra.eb.localhost [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id Qi-qCyY4dK4O; Wed, 8 Mar 2017 08:09:58 +0100 (CET) Received: from localhost (localhost.localhost [127.0.0.1]) by mail.embedded-brains.de (Postfix) with ESMTP id 541152A1804; Wed, 8 Mar 2017 08:09:58 +0100 (CET) X-Virus-Scanned: amavisd-new at zimbra.eb.localhost Received: from mail.embedded-brains.de ([127.0.0.1]) by localhost (zimbra.eb.localhost [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id AmdpqR1Eu95G; Wed, 8 Mar 2017 08:09:58 +0100 (CET) Received: from huber-linux.eb.localhost (unknown [192.168.96.129]) by mail.embedded-brains.de (Postfix) with ESMTP id 373152A17F3; Wed, 8 Mar 2017 08:09:58 +0100 (CET) From: Sebastian Huber To: freebsd-net@freebsd.org Cc: Sebastian Huber Subject: [PATCH 1/2] if_tsec: Fix input statistic counters Date: Wed, 8 Mar 2017 08:09:45 +0100 Message-Id: <1488956986-12015-1-git-send-email-sebastian.huber@embedded-brains.de> X-Mailer: git-send-email 1.8.4.5 X-Authenticated-Sender: smtp-embedded@poldinet.de X-Virus-Scanned: Clear (ClamAV 0.99.2/23184/Wed Mar 8 06:06:56 2017) X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Mar 2017 07:09:52 -0000 Do not count discared frames due to lack of buffers as input errors. --- sys/dev/tsec/if_tsec.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/sys/dev/tsec/if_tsec.c b/sys/dev/tsec/if_tsec.c index 2a8c3e2..66ee130 100644 --- a/sys/dev/tsec/if_tsec.c +++ b/sys/dev/tsec/if_tsec.c @@ -1398,7 +1398,7 @@ tsec_receive_intr_locked(struct tsec_softc *sc, int count) if (tsec_new_rxbuf(sc->tsec_rx_mtag, rx_data[i].map, &rx_data[i].mbuf, &rx_data[i].paddr)) { - if_inc_counter(ifp, IFCOUNTER_IERRORS, 1); + if_inc_counter(ifp, IFCOUNTER_IQDROPS, 1); /* * We ran out of mbufs; didn't consume current * descriptor and have to return it to the queue. @@ -1573,9 +1573,8 @@ tsec_error_intr_locked(struct tsec_softc *sc, int count) TSEC_WRITE(sc, TSEC_REG_TSTAT, TSEC_TSTAT_THLT); } - /* Check receiver errors */ + /* Check for discarded frame due to a lack of buffers */ if (eflags & TSEC_IEVENT_BSY) { - if_inc_counter(ifp, IFCOUNTER_IERRORS, 1); if_inc_counter(ifp, IFCOUNTER_IQDROPS, 1); /* Get data from RX buffers */ -- 1.8.4.5 From owner-freebsd-net@freebsd.org Wed Mar 8 07:09:52 2017 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 6FDE9D0260C for ; Wed, 8 Mar 2017 07:09:52 +0000 (UTC) (envelope-from sebastian.huber@embedded-brains.de) Received: from dedi548.your-server.de (dedi548.your-server.de [85.10.215.148]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 2462510A3 for ; Wed, 8 Mar 2017 07:09:51 +0000 (UTC) (envelope-from sebastian.huber@embedded-brains.de) Received: from [88.198.220.131] (helo=sslproxy02.your-server.de) by dedi548.your-server.de with esmtpsa (TLSv1.2:DHE-RSA-AES256-GCM-SHA384:256) (Exim 4.85_2) (envelope-from ) id 1clVjI-0007tD-PO for freebsd-net@freebsd.org; Wed, 08 Mar 2017 08:09:48 +0100 Received: from [82.135.62.35] (helo=mail.embedded-brains.de) by sslproxy02.your-server.de with esmtpsa (TLSv1.2:DHE-RSA-AES256-GCM-SHA384:256) (Exim 4.84_2) (envelope-from ) id 1clVjI-0004bK-I6 for freebsd-net@freebsd.org; Wed, 08 Mar 2017 08:09:48 +0100 Received: from localhost (localhost.localhost [127.0.0.1]) by mail.embedded-brains.de (Postfix) with ESMTP id A7F292A1808 for ; Wed, 8 Mar 2017 08:09:58 +0100 (CET) Received: from mail.embedded-brains.de ([127.0.0.1]) by localhost (zimbra.eb.localhost [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id EnxcRZ3OpXqu; Wed, 8 Mar 2017 08:09:58 +0100 (CET) Received: from localhost (localhost.localhost [127.0.0.1]) by mail.embedded-brains.de (Postfix) with ESMTP id 5F0962A1805; Wed, 8 Mar 2017 08:09:58 +0100 (CET) X-Virus-Scanned: amavisd-new at zimbra.eb.localhost Received: from mail.embedded-brains.de ([127.0.0.1]) by localhost (zimbra.eb.localhost [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id GyQCTC1IqvkY; Wed, 8 Mar 2017 08:09:58 +0100 (CET) Received: from huber-linux.eb.localhost (unknown [192.168.96.129]) by mail.embedded-brains.de (Postfix) with ESMTP id 3B7592A17F4; Wed, 8 Mar 2017 08:09:58 +0100 (CET) From: Sebastian Huber To: freebsd-net@freebsd.org Cc: Sebastian Huber Subject: [PATCH 2/2] if_tsec: Fix deadlock Date: Wed, 8 Mar 2017 08:09:46 +0100 Message-Id: <1488956986-12015-2-git-send-email-sebastian.huber@embedded-brains.de> X-Mailer: git-send-email 1.8.4.5 In-Reply-To: <1488956986-12015-1-git-send-email-sebastian.huber@embedded-brains.de> References: <1488956986-12015-1-git-send-email-sebastian.huber@embedded-brains.de> X-Authenticated-Sender: smtp-embedded@poldinet.de X-Virus-Scanned: Clear (ClamAV 0.99.2/23184/Wed Mar 8 06:06:56 2017) X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Mar 2017 07:09:52 -0000 The tsec_error_intr_locked() is called with the global lock owned (e.g. the transmit and the receive lock are both owned). We must not call tsec_receive_intr_locked() while owning the transmit lock. The normal receive interrupt takes care that frames are received, this is none of the business of the error interrupt. --- sys/dev/tsec/if_tsec.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/sys/dev/tsec/if_tsec.c b/sys/dev/tsec/if_tsec.c index 66ee130..0db552b 100644 --- a/sys/dev/tsec/if_tsec.c +++ b/sys/dev/tsec/if_tsec.c @@ -1576,9 +1576,6 @@ tsec_error_intr_locked(struct tsec_softc *sc, int count) /* Check for discarded frame due to a lack of buffers */ if (eflags & TSEC_IEVENT_BSY) { if_inc_counter(ifp, IFCOUNTER_IQDROPS, 1); - - /* Get data from RX buffers */ - tsec_receive_intr_locked(sc, count); } if (ifp->if_flags & IFF_DEBUG) -- 1.8.4.5 From owner-freebsd-net@freebsd.org Wed Mar 8 10:55:42 2017 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id F4199D02400; Wed, 8 Mar 2017 10:55:41 +0000 (UTC) (envelope-from slw@zxy.spb.ru) Received: from zxy.spb.ru (zxy.spb.ru [195.70.199.98]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id B23471EAA; Wed, 8 Mar 2017 10:55:41 +0000 (UTC) (envelope-from slw@zxy.spb.ru) Received: from slw by zxy.spb.ru with local (Exim 4.86 (FreeBSD)) (envelope-from ) id 1clZFk-000GtX-EU; Wed, 08 Mar 2017 13:55:32 +0300 Date: Wed, 8 Mar 2017 13:55:32 +0300 From: Slawa Olhovchenkov To: "Eugene M. Zheganin" Cc: "stable@freebsd.org" , freebsd-net Subject: Re: about that DFBSD performance test Message-ID: <20170308105532.GR15630@zxy.spb.ru> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) X-SA-Exim-Connect-IP: X-SA-Exim-Mail-From: slw@zxy.spb.ru X-SA-Exim-Scanned: No (on zxy.spb.ru); SAEximRunCond expanded to false X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Mar 2017 10:55:42 -0000 On Wed, Mar 08, 2017 at 09:00:34AM +0500, Eugene M. Zheganin wrote: > Hi. > > Some have probably seen this already - > http://lists.dragonflybsd.org/pipermail/users/2017-March/313254.html > > So, could anyone explain why FreeBSD was owned that much. Test is split > into two parts, one is nginx part, and the other is the IPv4 forwarding three: UFS part. And multiple simulations access to same file/block can cause page lock congestion. > part. I understand that nginx ownage was due to SO_REUSEPORT feature, > which we do formally have, but in DFBSD and Linux it does provide a > kernel socket multiplexor, which eliminates locking, and ours does not. > I have only found traces of discussion that DFBSD implementation is too > hackish. Well, hackish or not, but it's 4 times faster, as it turns out. > The IPv4 forwarding loss is pure defeat though. > > Please not that although they use HEAD it these tests, they also mention > that this is the GENERIC-NODEBUG kernel which means this isn't related > to the WITNESS stuff. > > Please also don't consider this trolling, I'm a big FreeBSD fan through > the years, so I'm asking because I'm kind of concerned. From owner-freebsd-net@freebsd.org Wed Mar 8 12:25:59 2017 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 137EED022F1 for ; Wed, 8 Mar 2017 12:25:59 +0000 (UTC) (envelope-from kevin.bowling@kev009.com) Received: from mail-oi0-x22c.google.com (mail-oi0-x22c.google.com [IPv6:2607:f8b0:4003:c06::22c]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id D21261177 for ; Wed, 8 Mar 2017 12:25:58 +0000 (UTC) (envelope-from kevin.bowling@kev009.com) Received: by mail-oi0-x22c.google.com with SMTP id m124so17729528oig.1 for ; Wed, 08 Mar 2017 04:25:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kev009.com; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=MPaeUAslqWkN3sAyZQBjftr9toXHigH7tAXnkcJ9dLo=; b=MFW4UxZnPz/OlD+mSd8biY/oEfeyCT3FhSp+Le0t12G/0onC9OBrSv+AEZHWZf0ILv F/rI1Pa0GYMbSMbT/azD9jJznURJ6Cc6GCEegcUtsDQOYMoaG4AXVNWESarTP1plxbOw aS8XzVGQH9b7vx8PH4djvbvAUv4QqbXDPf/nU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=MPaeUAslqWkN3sAyZQBjftr9toXHigH7tAXnkcJ9dLo=; b=UCVnY5C0iM3rdyexg2+BJSPJiCCSeyMYs9/fX04Q2KloLIKPm+/HC/pLjjnzWcv14B JqlrKjl08TCSMUzWU618a3PcTMpzcpCr6O+Cev7Wd88WzcpAjCx2GFpyBwai7xaBAEb4 WlMcpa77G1eqT09qWDk4qk9emEEMNuiqEx1c0zJc4sGNnc1Hq5KkF4xMgVCxpJAtmMEp pSWPD2JjatgMm3CJ5Xz3wLOJb3YmHHs7oNWFi6GdgXHQXYEKTx3l59oZR5xzQRk8mxNj Wbr8HbvKV2qzIZtdJwSxo8t4o3TdIctCE7zmcTBLGKxyJH2HeBFO9UqD0HwpcH3kOlQC NbXw== X-Gm-Message-State: AMke39mLTUiUoA6aFY7wbq3rRmJyQ2vIaGVds1liH0SUoydH5ShUrpRFsjYIy/ISHIRDWbn53djAu8HbuDAOHw== X-Received: by 10.202.105.195 with SMTP id e186mr3392878oic.160.1488975957926; Wed, 08 Mar 2017 04:25:57 -0800 (PST) MIME-Version: 1.0 Received: by 10.157.23.208 with HTTP; Wed, 8 Mar 2017 04:25:57 -0800 (PST) In-Reply-To: References: From: Kevin Bowling Date: Wed, 8 Mar 2017 05:25:57 -0700 Message-ID: Subject: Re: about that DFBSD performance test To: "Eugene M. Zheganin" Cc: freebsd-net Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.23 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Mar 2017 12:25:59 -0000 Right off the bat, FreeBSD doesn't really understand NUMA in any sufficient capacity. Unfortunately at companies like the one I work at, we take that to mean "OK buy a high bin CPU and only populate one socket" which serves us well and may ultimately be the best value but does nothing to address the reality that multi-socket NUMA systems are common place and FreeBSD should run in the same league on them as other operating systems to be taken seriously. I'd be interested in seeing how the contenders look by removing one of the CPUs as it might at least put a spotlight on that issue. With respect to SO_REUSEPORT, we are investigating implementing this round robin behavior right now. We think librss is a better way to go for content serving, but software will get written with Linux APIs in mind so I think it'll be a good idea to have a distributing SO_REUSEPORT anyway for software that does not understand librss natively. I have no commercial need for kernel IP forwarding but Matt Macy is doing a lot of driver work for me and we are at least trying to keep it in line with the legacy drivers. Since sephe's test was ixgbe, it'd be interesting to test https://github.com/mattmacy/networking/commits/HEAD_MERGE/iflib-ixgbe-current which makes the FreeBSD ixgbe driver much more like cxgbe (same ring code, improved coalescing, various prefetching insights for 10g+). In talking with Matt there's probably some low hanging fruit at the driver layer for this workload around batching and distribution. I do think the use of polling(4) in the benchmark is a bit hacky, it should be possible to get similar performance to Linux by doing batching and distribution as we are fine tuning in the iflib project. I'd be looking at netmap before polling(4) in any new product development that does heavy forwarding. But there's probably more to do up stack in routing and I don't know of anyone working on it with significant commercial backing. Ultimately I have to say congrats to DFBSD. They pulled that performance off with a small team and very little to no commercial backing. FreeBSD has a lot of full time commercial contributors, and while this is generally a good thing for longevity, I think workplace culture (even/especially at fabled places, that just means you're super busy) defeats some of the lucid insight and tenacity that ardent personal contributors are able to pull off of their own accord. Regards, On Tue, Mar 7, 2017 at 9:00 PM, Eugene M. Zheganin wrote: > Hi. > > Some have probably seen this already - http://lists.dragonflybsd.org/ > pipermail/users/2017-March/313254.html > > So, could anyone explain why FreeBSD was owned that much. Test is split > into two parts, one is nginx part, and the other is the IPv4 forwarding > part. I understand that nginx ownage was due to SO_REUSEPORT feature, which > we do formally have, but in DFBSD and Linux it does provide a kernel socket > multiplexor, which eliminates locking, and ours does not. I have only found > traces of discussion that DFBSD implementation is too hackish. Well, > hackish or not, but it's 4 times faster, as it turns out. The IPv4 > forwarding loss is pure defeat though. > > Please not that although they use HEAD it these tests, they also mention > that this is the GENERIC-NODEBUG kernel which means this isn't related to > the WITNESS stuff. > > Please also don't consider this trolling, I'm a big FreeBSD fan through > the years, so I'm asking because I'm kind of concerned. > > Eugene. > > _______________________________________________ > freebsd-net@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/freebsd-net > To unsubscribe, send any mail to "freebsd-net-unsubscribe@freebsd.org" > From owner-freebsd-net@freebsd.org Wed Mar 8 12:57:13 2017 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id B00E9D02D9F for ; Wed, 8 Mar 2017 12:57:13 +0000 (UTC) (envelope-from slw@zxy.spb.ru) Received: from zxy.spb.ru (zxy.spb.ru [195.70.199.98]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 726361352 for ; Wed, 8 Mar 2017 12:57:13 +0000 (UTC) (envelope-from slw@zxy.spb.ru) Received: from slw by zxy.spb.ru with local (Exim 4.86 (FreeBSD)) (envelope-from ) id 1clb9S-000JyK-8b; Wed, 08 Mar 2017 15:57:10 +0300 Date: Wed, 8 Mar 2017 15:57:10 +0300 From: Slawa Olhovchenkov To: Kevin Bowling Cc: "Eugene M. Zheganin" , freebsd-net Subject: Re: about that DFBSD performance test Message-ID: <20170308125710.GS15630@zxy.spb.ru> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) X-SA-Exim-Connect-IP: X-SA-Exim-Mail-From: slw@zxy.spb.ru X-SA-Exim-Scanned: No (on zxy.spb.ru); SAEximRunCond expanded to false X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Mar 2017 12:57:13 -0000 On Wed, Mar 08, 2017 at 05:25:57AM -0700, Kevin Bowling wrote: > Right off the bat, FreeBSD doesn't really understand NUMA in any sufficient > capacity. Unfortunately at companies like the one I work at, we take that > to mean "OK buy a high bin CPU and only populate one socket" which serves NUMA applicable only to high-localy computed tasks. http/https/any_network_related serving is not related to this. Indeed, on modern CPU is not important to bind NIC irq handlers to same CPU/sockets as NIC. From owner-freebsd-net@freebsd.org Wed Mar 8 13:57:36 2017 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 590A7D03285 for ; Wed, 8 Mar 2017 13:57:36 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 48B8E1B28 for ; Wed, 8 Mar 2017 13:57:36 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id v28DvaKV064076 for ; Wed, 8 Mar 2017 13:57:36 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-net@FreeBSD.org Subject: [Bug 217600] Gateway enable not working Date: Wed, 08 Mar 2017 13:57:36 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 10.3-RELEASE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: judah.levine@colorado.edu X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-net@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: attachments.created Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Mar 2017 13:57:36 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D217600 --- Comment #2 from judah.levine@colorado.edu --- Created attachment 180636 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D180636&action= =3Dedit parameters of inernal back system --=20 You are receiving this mail because: You are the assignee for the bug.= From owner-freebsd-net@freebsd.org Wed Mar 8 13:58:44 2017 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 0C7DDD032FD for ; Wed, 8 Mar 2017 13:58:44 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id F098D1C20 for ; Wed, 8 Mar 2017 13:58:43 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id v28DwhRI065607 for ; Wed, 8 Mar 2017 13:58:43 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-net@FreeBSD.org Subject: [Bug 217600] Gateway enable not working Date: Wed, 08 Mar 2017 13:58:43 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 10.3-RELEASE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: judah.levine@colorado.edu X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-net@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: attachments.created Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Mar 2017 13:58:44 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D217600 --- Comment #3 from judah.levine@colorado.edu --- Created attachment 180637 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D180637&action= =3Dedit parameters of dual-network gateway system --=20 You are receiving this mail because: You are the assignee for the bug.= From owner-freebsd-net@freebsd.org Wed Mar 8 14:28:40 2017 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 33796D03A6A for ; Wed, 8 Mar 2017 14:28:40 +0000 (UTC) (envelope-from mike@sentex.net) Received: from smarthost2.sentex.ca (smarthost2.sentex.ca [IPv6:2607:f3e0:80:80::2]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client CN "smarthost.sentex.ca", Issuer "smarthost.sentex.ca" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id DA8F81C88 for ; Wed, 8 Mar 2017 14:28:39 +0000 (UTC) (envelope-from mike@sentex.net) Received: from lava.sentex.ca (lava.sentex.ca [IPv6:2607:f3e0:0:5::11]) by smarthost2.sentex.ca (8.15.2/8.15.2) with ESMTPS id v28ESc1Y054558 (version=TLSv1 cipher=DHE-RSA-CAMELLIA256-SHA bits=256 verify=NO) for ; Wed, 8 Mar 2017 09:28:38 -0500 (EST) (envelope-from mike@sentex.net) Received: from [IPv6:2607:f3e0:0:4:5c30:ed1b:e203:c55c] ([IPv6:2607:f3e0:0:4:5c30:ed1b:e203:c55c]) by lava.sentex.ca (8.15.2/8.15.2) with ESMTP id v28ESbvY025702; Wed, 8 Mar 2017 09:28:37 -0500 (EST) (envelope-from mike@sentex.net) Subject: Re: Chelsio netmap support ? (RELENG_11) To: Navdeep Parhar References: <93e10699-ecc7-c062-bf85-a26de0de9633@sentex.net> <901224a7-f3ed-84a4-5402-3542cd0e865b@sentex.net> Cc: "freebsd-net@freebsd.org" From: Mike Tancsa Organization: Sentex Communications Message-ID: Date: Wed, 8 Mar 2017 09:28:37 -0500 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.78 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Mar 2017 14:28:40 -0000 On 3/7/2017 9:08 PM, Navdeep Parhar wrote: > On Tue, Mar 7, 2017 at 5:46 PM, Mike Tancsa wrote: > >> >> # dmesg | grep netm >> netmap: loaded module >> vcxl0: netmap queues/slots: TX 2/1023, RX 2/1024 >> vcxl0: 1 txq, 1 rxq (NIC); 1 txq, 1 rxq (TOE); 2 txq, 2 rxq (netmap) >> vcxl1: netmap queues/slots: TX 2/1023, RX 2/1024 >> vcxl1: 1 txq, 1 rxq (NIC); 1 txq, 1 rxq (TOE); 2 txq, 2 rxq (netmap) >> igb0: netmap queues/slots: TX 4/1024, RX 4/1024 >> igb1: netmap queues/slots: TX 4/1024, RX 4/1024 >> >> It maxes out at about 800Kpps with and without netmap. Is there a way > > Are you actually using a netmap based application that acts as a > packet router or is this just the vcxl interface running as a normal > ifnet? the later, vcxl running normal ifnet. I thought there would be a benefit to utilizing netmap ? Sorry, this is not clear to me. > >> to increase the queues for the Chelsio nic, like the onboard igb ? > > If you're not running a netmap based router get rid of the num_vis=2 > and simply try with the cxl0/cxl1 interfaces. They should each have 4 > rxq/4 txq on your system. In case you want to increase the number of > queues, use this: The tests with the regular cxl also show the box topping out at 0.8Mpps for forwarding. > > The "NIC" queues are the normal tx/rx queues, the "netmap" queues are > active when the interface is in netmap mode. > > Does netsend generate a single flow or multiple flows? If it's a > single flow it will use a single queue only. I think its as a single flow. However, I was using a separate box to generate a second flow as well. It still topped out at about 800Kpps before dropping packets. ---Mike -- ------------------- Mike Tancsa, tel +1 519 651 3400 Sentex Communications, mike@sentex.net Providing Internet services since 1994 www.sentex.net Cambridge, Ontario Canada http://www.tancsa.com/ From owner-freebsd-net@freebsd.org Wed Mar 8 14:52:44 2017 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 3BDB8D0219D for ; Wed, 8 Mar 2017 14:52:44 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 2BE601D03 for ; Wed, 8 Mar 2017 14:52:44 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id v28Eqiwd006030 for ; Wed, 8 Mar 2017 14:52:44 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-net@FreeBSD.org Subject: [Bug 217600] Gateway enable not working Date: Wed, 08 Mar 2017 14:52:44 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 10.3-RELEASE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: lutz@donnerhacke.de X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-net@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Mar 2017 14:52:44 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D217600 --- Comment #4 from lutz@donnerhacke.de --- The routing tables look good. So can you please verify, using tcpdump, that - the packets leave router B with the correct ether destination mac of the router b interface - the packets reach router A with the correct ether source mac of the router a interface - the packets leave the router A on the external interface If this works, everything is fine. You may not receive an answer from the Internet hosts, because your interna= l ip addresses are not known in the Internet and you did not set up NAT. If this is the case, please close this ticket and refer to the Firewall and= NAT chapter in the handbook. --=20 You are receiving this mail because: You are the assignee for the bug.= From owner-freebsd-net@freebsd.org Wed Mar 8 15:03:51 2017 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id EF5D2D02574 for ; Wed, 8 Mar 2017 15:03:51 +0000 (UTC) (envelope-from mjguzik@gmail.com) Received: from mail-wm0-x230.google.com (mail-wm0-x230.google.com [IPv6:2a00:1450:400c:c09::230]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 8D2A7643 for ; Wed, 8 Mar 2017 15:03:51 +0000 (UTC) (envelope-from mjguzik@gmail.com) Received: by mail-wm0-x230.google.com with SMTP id n11so117129804wma.1 for ; Wed, 08 Mar 2017 07:03:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=h7wFPJuamD9C4EJcFczG27zj9qBNTK7e14JP058/2jU=; b=dFi7bH6tQYgvkr7fTUMgP2UgQSQPSFkz+YFDuBZDCUDjDD7xmH7tD681fjO967+pbv O9rVgGSJ9Z3vNLnxM5tmeFYao6ruQ9weYzkPYYlIkNqwPSYo0jWaG48S8KGbAEMf65bv 7XKx2yLWmsPPeksAHGGAG4brds5inV4znM09CHKyqeRc7QgbyIuwgH9hZzV4LJXEHD50 tSMqZ2B0I4mnx2vq8a4SXhP3kZqXOgSzi6FnbhVrsKQ4PP86fNlIz8Skl14VTYvnBTnk WO19ZBUXHXhbsYc6y/FwG5bn7nQbEl99REp0Po4xlbFjwvFmP0v74xGp5J6YVK8VBWdF qHkg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=h7wFPJuamD9C4EJcFczG27zj9qBNTK7e14JP058/2jU=; b=PiIwFcTrbN+OuSAaucxFwXOrdyT0Effe+Kln+SaB2Y1tHSpH6K4VmwrZI5MMkyrN80 H/W8+JZ3qBGNjp8R0B7psbrDu60P4cLIsbc0X4fQxmaEQu81FRtgQekzkBO0ruFOMSrL fdMjfCiYtHG/Ce1iBs5IWmGEI86O9HEPJ1vGMWdYLjiDbs9ypZdonbo7wAGkIBhh+LOC yN+M2d+6CRpeFMA0/6vnjYTdWztwpWCPpU97uhWOKvLkxU0SCS8yTsNJnw4KOwp5e9ek g2fL0f7S2wB1SDj6lJ7jWX2lP/Xdt2M5nL19g43q248FecowGssjGC7cgnsPfgdePABc tR1g== X-Gm-Message-State: AMke39nXVDanUKIwhbsJJF3sECyvOAl6SRzonx9V5yKj2oxpN3wRXdLYevgal5aVTbBKOg== X-Received: by 10.28.74.221 with SMTP id n90mr5900219wmi.114.1488985429707; Wed, 08 Mar 2017 07:03:49 -0800 (PST) Received: from dft-labs.eu (n1x0n-1-pt.tunnel.tserv5.lon1.ipv6.he.net. [2001:470:1f08:1f7::2]) by smtp.gmail.com with ESMTPSA id j26sm4485219wrb.69.2017.03.08.07.03.48 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Wed, 08 Mar 2017 07:03:48 -0800 (PST) Date: Wed, 8 Mar 2017 16:03:46 +0100 From: Mateusz Guzik To: Slawa Olhovchenkov Cc: Kevin Bowling , freebsd-net , "Eugene M. Zheganin" Subject: Re: about that DFBSD performance test Message-ID: <20170308150346.GA32269@dft-labs.eu> References: <20170308125710.GS15630@zxy.spb.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20170308125710.GS15630@zxy.spb.ru> User-Agent: Mutt/1.5.21 (2010-09-15) X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Mar 2017 15:03:52 -0000 On Wed, Mar 08, 2017 at 03:57:10PM +0300, Slawa Olhovchenkov wrote: > On Wed, Mar 08, 2017 at 05:25:57AM -0700, Kevin Bowling wrote: > > > Right off the bat, FreeBSD doesn't really understand NUMA in any sufficient > > capacity. Unfortunately at companies like the one I work at, we take that > > to mean "OK buy a high bin CPU and only populate one socket" which serves > > NUMA applicable only to high-localy computed tasks. > http/https/any_network_related serving is not related to this. > Indeed, on modern CPU is not important to bind NIC irq handlers to > same CPU/sockets as NIC. > Well, for both benchmarks this is both true and false. First and foremost there is general kernel scalability. Certain counters and most locks are purely managed with atomic operations. An atomic operation grabs the entire cacheline with the particular variable (64 bytes in total) in exclusive mode. If you have to do an atomic operation you are somewhat slower than you be otherwise. If you have to do an atomic operation and another cpu has the cacheline, you are visibly slower. And if the cacheline travels a lot between cpus (e.g. because the lock is contended), the performance degrades rapidly. NUMA increases the cost of cacheline bounces, making the already bad situation even worse. Locking primitives are affected by NUMA significantly more than they have to be (I'm working on that), but any fixes in the area are just bandaids. For instancee, I reproduce the http benchmark and indeed I have about 75k req/s on 2 * 10 * 2 box, although I'm only using one client. Profiling shows excessive contention on the 'accept lock' and something else from the socket layer. The latter comes from kqueue being extremely inefficient by acquiring and releasing the same lock about 4 times per call on average (if it took it *once* it would significantly reduce lock bouncing around, including across the socket to a different node). But even taking it once is likely too bad - no matter how realistically fast this can get, if all nginx processes serialize on this lock this is not going to scale. That said, the end result would be significantly higher if lock granularity was better and I suspect numa-awareness would not be a significant factor in the http benchmark - provided locks are granular enough, they would travel across the socket only if they get pushed out of the cache (which would be rare), but there would be no contention. This is a small excerpt from a reply I intend to write to the other thread where the 'solisten' patch is discussed. It gets rid of the accept lock contention, but this increases the load on other lock and thattemporarily slows things down. -- Mateusz Guzik From owner-freebsd-net@freebsd.org Wed Mar 8 15:22:17 2017 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 7CA82D02AE5 for ; Wed, 8 Mar 2017 15:22:17 +0000 (UTC) (envelope-from slw@zxy.spb.ru) Received: from zxy.spb.ru (zxy.spb.ru [195.70.199.98]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 3889C1059 for ; Wed, 8 Mar 2017 15:22:17 +0000 (UTC) (envelope-from slw@zxy.spb.ru) Received: from slw by zxy.spb.ru with local (Exim 4.86 (FreeBSD)) (envelope-from ) id 1cldPo-000Nax-Uo; Wed, 08 Mar 2017 18:22:12 +0300 Date: Wed, 8 Mar 2017 18:22:12 +0300 From: Slawa Olhovchenkov To: Mateusz Guzik Cc: Kevin Bowling , freebsd-net , "Eugene M. Zheganin" Subject: Re: about that DFBSD performance test Message-ID: <20170308152212.GD70430@zxy.spb.ru> References: <20170308125710.GS15630@zxy.spb.ru> <20170308150346.GA32269@dft-labs.eu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170308150346.GA32269@dft-labs.eu> User-Agent: Mutt/1.5.24 (2015-08-30) X-SA-Exim-Connect-IP: X-SA-Exim-Mail-From: slw@zxy.spb.ru X-SA-Exim-Scanned: No (on zxy.spb.ru); SAEximRunCond expanded to false X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Mar 2017 15:22:17 -0000 On Wed, Mar 08, 2017 at 04:03:46PM +0100, Mateusz Guzik wrote: > On Wed, Mar 08, 2017 at 03:57:10PM +0300, Slawa Olhovchenkov wrote: > > On Wed, Mar 08, 2017 at 05:25:57AM -0700, Kevin Bowling wrote: > > > > > Right off the bat, FreeBSD doesn't really understand NUMA in any sufficient > > > capacity. Unfortunately at companies like the one I work at, we take that > > > to mean "OK buy a high bin CPU and only populate one socket" which serves > > > > NUMA applicable only to high-localy computed tasks. > > http/https/any_network_related serving is not related to this. > > Indeed, on modern CPU is not important to bind NIC irq handlers to > > same CPU/sockets as NIC. > > > > Well, for both benchmarks this is both true and false. Hmm, I am not so clear. Main may point: at time of accept connection imposible to know location [CPU/NUMA] of data need for proccess request. I.e. imposible to full use NUMA advantages. Data for request may be cached on other NUMA domain, HDD w/ data may be connect to HBA on different PCIe domain and etc. > First and foremost there is general kernel scalability. Certain counters > and most locks are purely managed with atomic operations. An atomic > operation grabs the entire cacheline with the particular variable (64 > bytes in total) in exclusive mode. > > If you have to do an atomic operation you are somewhat slower than you > be otherwise. > > If you have to do an atomic operation and another cpu has the cacheline, > you are visibly slower. And if the cacheline travels a lot between cpus > (e.g. because the lock is contended), the performance degrades rapidly. > NUMA increases the cost of cacheline bounces, making the already bad > situation even worse. travels to other die don't give significat penalty for modern CPU and correct BIOS configuration. And for older CPU too (cores on same die synced through DRAM). > Locking primitives are affected by NUMA significantly more than they > have to be (I'm working on that), but any fixes in the area are just > bandaids. > > For instancee, I reproduce the http benchmark and indeed I have about > 75k req/s on 2 * 10 * 2 box, although I'm only using one client. > > Profiling shows excessive contention on the 'accept lock' and something > else from the socket layer. The latter comes from kqueue being extremely > inefficient by acquiring and releasing the same lock about 4 times per > call on average (if it took it *once* it would significantly reduce lock > bouncing around, including across the socket to a different node). But > even taking it once is likely too bad - no matter how realistically fast > this can get, if all nginx processes serialize on this lock this is not > going to scale. Hmm, what 'events' configuration of nginx? And how many workers? Is 'accept_mutex off;' present? > That said, the end result would be significantly higher if lock > granularity was better Always true. > and I suspect numa-awareness would not be a > significant factor in the http benchmark - provided locks are granular > enough, they would travel across the socket only if they get pushed out > of the cache (which would be rare), but there would be no contention. > > This is a small excerpt from a reply I intend to write to the other > thread where the 'solisten' patch is discussed. It gets rid of the > accept lock contention, but this increases the load on other lock and > thattemporarily slows things down. > > -- > Mateusz Guzik From owner-freebsd-net@freebsd.org Wed Mar 8 15:53:03 2017 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 90670D03A26 for ; Wed, 8 Mar 2017 15:53:03 +0000 (UTC) (envelope-from ml@netfence.it) Received: from smtp208.alice.it (smtp208.alice.it [82.57.200.104]) by mx1.freebsd.org (Postfix) with ESMTP id 4F3FF17E for ; Wed, 8 Mar 2017 15:53:01 +0000 (UTC) (envelope-from ml@netfence.it) Received: from soth.ventu (82.52.25.226) by smtp208.alice.it (8.6.060.28) (authenticated as acanedi@alice.it) id 588F4293074C0D30 for freebsd-net@freebsd.org; Wed, 8 Mar 2017 16:52:42 +0100 Received: from alamar.ventu (alamar.local.netfence.it [10.1.2.18]) by soth.ventu (8.15.2/8.15.2) with ESMTP id v28FqaOb021885 for ; Wed, 8 Mar 2017 16:52:36 +0100 (CET) (envelope-from ml@netfence.it) X-Authentication-Warning: soth.ventu: Host alamar.local.netfence.it [10.1.2.18] claimed to be alamar.ventu From: Andrea Venturoli Subject: Some questions about in-kernel NAT To: freebsd-net@freebsd.org Message-ID: Date: Wed, 8 Mar 2017 16:52:36 +0100 User-Agent: Mozilla/5.0 (X11; FreeBSD i386; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Mar 2017 15:53:03 -0000 Hello. I'm using "ipfw nat" on several 10.3 boxes, but I have some questions. Let's start with a simple one: how do I list configured NATs and their details? I know I can configure a NAT with "ipfw nat 1 config ...", but how do I show what I did? Second question: _ if I issue "ipfw nat 2 config if re0", I'll see the output "ipfw nat 2 config if re0"; _ if I issue "ipfw nat 2 config ip 192.168.0.1", I'll see the output "ipfw nat 2 config ip 192.168.0.1"; _ however if I issue "ipfw nat 2 config if re0 ip 192.168.0.1", output will be "ipfw nat 2 config if re0". Does this mean the "ip" part was ignored? Are "if" and "ip" mutually exclusive? I don't think this is mentioned in the man page... Let's get to my problem now: _ at boot, my re0 interface is configured with IP 192.168.0.1, along with an alias (192.168.0.2); _ my ipfw rules get loaded, issuing a "nat 2 config ip 192.168.0.1" command; _ after that ezjail is started, featuring a jail on 192.168.0.3. From this point on, my aliased packets go out with 192.168.0.3 as source address. I have to manually run "ipfw nat 2 config ip 192.168.0.1" again, in order to have them correctly going with the desired IP. How can I avoid this (and eliminate the need of manual intervention after each boot)? Of course I could use some trick, like writing a rc.d script that runs after ezjail's, but I'd like to understand and solve (not work around) :) TIA. bye av. From owner-freebsd-net@freebsd.org Wed Mar 8 16:36:31 2017 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 287D4D038EE for ; Wed, 8 Mar 2017 16:36:31 +0000 (UTC) (envelope-from smithi@nimnet.asn.au) Received: from sola.nimnet.asn.au (paqi.nimnet.asn.au [115.70.110.159]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id AA35236B for ; Wed, 8 Mar 2017 16:36:30 +0000 (UTC) (envelope-from smithi@nimnet.asn.au) Received: from localhost (localhost [127.0.0.1]) by sola.nimnet.asn.au (8.14.2/8.14.2) with ESMTP id v28GaQVh084045; Thu, 9 Mar 2017 03:36:26 +1100 (EST) (envelope-from smithi@nimnet.asn.au) Date: Thu, 9 Mar 2017 03:36:26 +1100 (EST) From: Ian Smith To: Andrea Venturoli cc: freebsd-net@freebsd.org Subject: Re: Some questions about in-kernel NAT In-Reply-To: Message-ID: <20170309032407.M80813@sola.nimnet.asn.au> References: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Mar 2017 16:36:31 -0000 On Wed, 8 Mar 2017 16:52:36 +0100, Andrea Venturoli wrote: Just on one point: > Second question: > _ if I issue "ipfw nat 2 config if re0", I'll see the output "ipfw nat 2 > config if re0"; > _ if I issue "ipfw nat 2 config ip 192.168.0.1", I'll see the output "ipfw > nat 2 config ip 192.168.0.1"; > _ however if I issue "ipfw nat 2 config if re0 ip 192.168.0.1", output will > be "ipfw nat 2 config if re0". > Does this mean the "ip" part was ignored? Are "if" and "ip" mutually > exclusive? Yes, they are. > I don't think this is mentioned in the man page... No, it's not. The NAT description is pretty terse, virtually assuming familiarity with predecessor natd(8), which is usually worth referring to for greater detail; it mostly matches funtionality 1:1 .. see: -alias_address | -a address and -interface | -n interface which clarify that you need to specify one or the other. cheers, Ian From owner-freebsd-net@freebsd.org Wed Mar 8 16:47:16 2017 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 75D0DD03D3A for ; Wed, 8 Mar 2017 16:47:16 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 65D1D1194 for ; Wed, 8 Mar 2017 16:47:16 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id v28GlF0T084434 for ; Wed, 8 Mar 2017 16:47:16 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-net@FreeBSD.org Subject: [Bug 217637] One TCP connection accepted TWO time Date: Wed, 08 Mar 2017 16:47:15 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 10.3-STABLE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: linimon@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-net@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: assigned_to Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Mar 2017 16:47:16 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D217637 Mark Linimon changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|freebsd-bugs@FreeBSD.org |freebsd-net@FreeBSD.org --=20 You are receiving this mail because: You are the assignee for the bug.= From owner-freebsd-net@freebsd.org Wed Mar 8 17:04:01 2017 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id C9A7ED01E3A for ; Wed, 8 Mar 2017 17:04:01 +0000 (UTC) (envelope-from fjwcash@gmail.com) Received: from mail-oi0-x232.google.com (mail-oi0-x232.google.com [IPv6:2607:f8b0:4003:c06::232]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 94A251B4B for ; Wed, 8 Mar 2017 17:04:01 +0000 (UTC) (envelope-from fjwcash@gmail.com) Received: by mail-oi0-x232.google.com with SMTP id 126so22649670oig.3 for ; Wed, 08 Mar 2017 09:04:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=tEQCduUn3/eix3kUTvHv++YBjuT8SHQ3wIYzwJpe4VY=; b=Rt6gOvPFB0IKa4sB67nwTC/zlyp0f0kcuegKIv5U9ANJgbQofAx7PR2iN1cGUs5aF7 F5wkn+REA5T/Hju/6ujNGP5sssJnC/IhjHsSTguEfLHbgw8He6TLFHrH0zU3zZniuSuH 4Pa6v8G4CuJGp7r1ATYm+thKmAN0tAiEgxXwwuCo2TUsAKbXoHNp5X5Tq/Txaw1NeL+s Wr3bJKZgLnUmltrGndjP47pqNEDPaMXiNQEu+tPosNgNGKCoZSGlF84bP1jbA+Pv9aS9 JKfXYrY5fK3gbJzM2oDsJQslvb0puTgGlTGixbnXAJtT/2Dlvgl32NZ1gWIRa0lPZPn1 8H/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=tEQCduUn3/eix3kUTvHv++YBjuT8SHQ3wIYzwJpe4VY=; b=VKgnpSLhZ1YZGmZaPHeryQGa6gokPPcUoIQyNATXRPgZsd56dBv2xIZY5IS8GZU95F JC5gw5tEA8VF+tysodoCmAf1dugk4gYIGzNUq3SMTQ7i9rqvQ/2PRPcJ0Qhi7cVg/H+D bypZ1oz6iS9ZT7D34AJ/GYXQOvfO6C/xnVekgfUbgso7WSzjO7Cr1GDaDlY0eixwezV3 4of0BxQv1kDuKMKyv3Bw2+nP7RkNnccV7i1DYQOd418mAVgFqiYCFMn0+mfkRGIblL6J 9TSt9iSa5NOU29RwjzlQUQmoiIhBVFWnEVgK5Zq1GSbdB0tF0QfmKh59IZOop29OyTl+ 24NA== X-Gm-Message-State: AMke39lverqp5yOAKQ61R18itW5wKzto7XuD3G040Ft/ehqCcWqFLuM2Nr531bHDLjgpfH3y6O9DrzkznxKdTw== X-Received: by 10.200.0.25 with SMTP id a25mr8248235qtg.199.1488992639656; Wed, 08 Mar 2017 09:03:59 -0800 (PST) MIME-Version: 1.0 Received: by 10.140.28.202 with HTTP; Wed, 8 Mar 2017 09:03:59 -0800 (PST) In-Reply-To: References: From: Freddie Cash Date: Wed, 8 Mar 2017 09:03:59 -0800 Message-ID: Subject: Re: Some questions about in-kernel NAT To: Andrea Venturoli Cc: freebsd-net Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.23 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Mar 2017 17:04:01 -0000 On Wed, Mar 8, 2017 at 7:52 AM, Andrea Venturoli wrote: > Hello. > > I'm using "ipfw nat" on several 10.3 boxes, but I have some questions. > > Let's start with a simple one: how do I list configured NATs and their > details? > I know I can configure a NAT with "ipfw nat 1 config ...", but how do I > show what I did? > It's listed in the EXAMPLES section of the ipfw(8) man page. ipfw nat show config=E2=80=8B <-- view config for all nat instances ipfw nat 123 show config <-- view config for nat 123 ipfw nat 111-999 show <-- view logs for nat 111-999 > Let's get to my problem now: > _ at boot, my re0 interface is configured with IP 192.168.0.1, along with > an alias (192.168.0.2); > _ my ipfw rules get loaded, issuing a "nat 2 config ip 192.168.0.1" > command; > _ after that ezjail is started, featuring a jail on 192.168.0.3. > From this point on, my aliased packets go out with 192.168.0.3 as source > address. I have to manually run "ipfw nat 2 config ip 192.168.0.1" again, > in order to have them correctly going with the desired IP. > =E2=80=8BWhat's the ipfw command that's run at boot time? Sounds like it's configured to use the interface address instead of a specific IP address.= =E2=80=8B --=20 Freddie Cash fjwcash@gmail.com From owner-freebsd-net@freebsd.org Wed Mar 8 17:25:51 2017 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 2324FD03699 for ; Wed, 8 Mar 2017 17:25:51 +0000 (UTC) (envelope-from ml@netfence.it) Received: from smtp209.alice.it (smtp209.alice.it [82.57.200.105]) by mx1.freebsd.org (Postfix) with ESMTP id B3902128C for ; Wed, 8 Mar 2017 17:25:50 +0000 (UTC) (envelope-from ml@netfence.it) Received: from soth.ventu (82.52.25.226) by smtp209.alice.it (8.6.060.28) (authenticated as acanedi@alice.it) id 588F429D06874907; Wed, 8 Mar 2017 18:25:31 +0100 Received: from alamar.ventu (alamar.local.netfence.it [10.1.2.18]) by soth.ventu (8.15.2/8.15.2) with ESMTP id v28HPS4N038369; Wed, 8 Mar 2017 18:25:29 +0100 (CET) (envelope-from ml@netfence.it) X-Authentication-Warning: soth.ventu: Host alamar.local.netfence.it [10.1.2.18] claimed to be alamar.ventu Subject: Re: Some questions about in-kernel NAT To: Freddie Cash Cc: freebsd-net References: From: Andrea Venturoli Message-ID: <9d0b09c5-452b-7300-d081-081a64adef96@netfence.it> Date: Wed, 8 Mar 2017 18:25:28 +0100 User-Agent: Mozilla/5.0 (X11; FreeBSD i386; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Mar 2017 17:25:51 -0000 On 03/08/17 18:03, Freddie Cash wrote: > It's listed in the EXAMPLES section of the ipfw(8) man page. > > ipfw nat show config​ <-- view config for all nat instances > ipfw nat 123 show config <-- view config for nat 123 > ipfw nat 111-999 show <-- view logs for nat 111-999 Oops!!! Been working too much, lately. Sorry for overlooking this section and posting some noise. > Let's get to my problem now: > _ at boot, my re0 interface is configured with IP 192.168.0.1, along > with an alias (192.168.0.2); > _ my ipfw rules get loaded, issuing a "nat 2 config ip 192.168.0.1" > command; > _ after that ezjail is started, featuring a jail on 192.168.0.3. > From this point on, my aliased packets go out with 192.168.0.3 as > source address. I have to manually run "ipfw nat 2 config ip > 192.168.0.1" again, in order to have them correctly going with the > desired IP. > > > ​What's the ipfw command that's run at boot time? Sounds like it's > configured to use the interface address instead of a specific IP address.​ Yes and no: it uses both, i.e. "ipfw nat 2 config if re0 ip 192.168.0.1". However, later only the interface is listed from the show command; i.e.: > # ipfw nat 2 show config > ipfw nat 2 config if re0 Guess I'll have to use the "ip", not "if" then. bye & Thanks av. From owner-freebsd-net@freebsd.org Thu Mar 9 00:22:17 2017 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 559E2D01699 for ; Thu, 9 Mar 2017 00:22:17 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 45941311 for ; Thu, 9 Mar 2017 00:22:17 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id v290MGrG072745 for ; Thu, 9 Mar 2017 00:22:17 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-net@FreeBSD.org Subject: [Bug 217600] Gateway enable not working Date: Thu, 09 Mar 2017 00:22:16 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 10.3-RELEASE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: judah.levine@colorado.edu X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-net@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 Mar 2017 00:22:17 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D217600 --- Comment #5 from judah.levine@colorado.edu --- I have configured the two systems to use NAT as you suggested, and that wor= ks. The problem is solved from my perspective, and I have no objection to closi= ng the ticket.=20 However, I think there is still a problem. The diagram that I mentioned originally (section 30.2.2) supposedly does not require NAT to work. So, ei= ther there is a problem with the software or the documentation is not completely correct. The discussion that discusses that diagram is found in many places= -- in the man pages and in many books. In none of these places is there mentio= n of the requirement to add NAT. --=20 You are receiving this mail because: You are the assignee for the bug.= From owner-freebsd-net@freebsd.org Thu Mar 9 00:29:31 2017 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 145F3D01A76 for ; Thu, 9 Mar 2017 00:29:31 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 04892ADA for ; Thu, 9 Mar 2017 00:29:31 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id v290TUhC085219 for ; Thu, 9 Mar 2017 00:29:30 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-net@FreeBSD.org Subject: [Bug 217600] Gateway enable not working Date: Thu, 09 Mar 2017 00:29:30 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 10.3-RELEASE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: lutz@donnerhacke.de X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-net@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 Mar 2017 00:29:31 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D217600 --- Comment #6 from lutz@donnerhacke.de --- NAT is not a requirement for routing. You can simply use private IP addresses in you network and route them direc= tly. But if you want to take part in the Internet, you have to follow the rules there. Please close the ticket, I do not have the permissions. --=20 You are receiving this mail because: You are the assignee for the bug.= From owner-freebsd-net@freebsd.org Thu Mar 9 01:55:32 2017 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 73152D03441 for ; Thu, 9 Mar 2017 01:55:32 +0000 (UTC) (envelope-from vas@mpeks.tomsk.su) Received: from relay2.tomsk.ru (mail.sibptus.tomsk.ru [212.73.124.5]) by mx1.freebsd.org (Postfix) with ESMTP id DB5E3E46 for ; Thu, 9 Mar 2017 01:55:31 +0000 (UTC) (envelope-from vas@mpeks.tomsk.su) X-Virus-Scanned: by clamd daemon 0.98.5_1 for FreeBSD at relay2.tomsk.ru Received: from [212.73.125.240] (HELO admin.sibptus.transneft.ru) by relay2.tomsk.ru (CommuniGate Pro SMTP 5.1.16) with ESMTPS id 39633121 for freebsd-net@freebsd.org; Thu, 09 Mar 2017 07:51:01 +0600 Received: from admin.sibptus.transneft.ru (sudakov@localhost [127.0.0.1]) by admin.sibptus.transneft.ru (8.14.9/8.14.9) with ESMTP id v291tTHw074057 for ; Thu, 9 Mar 2017 08:55:29 +0700 (KRAT) (envelope-from vas@mpeks.tomsk.su) Received: (from sudakov@localhost) by admin.sibptus.transneft.ru (8.14.9/8.14.9/Submit) id v291tSuZ074055 for freebsd-net@freebsd.org; Thu, 9 Mar 2017 08:55:28 +0700 (KRAT) (envelope-from vas@mpeks.tomsk.su) X-Authentication-Warning: admin.sibptus.transneft.ru: sudakov set sender to vas@mpeks.tomsk.su using -f Date: Thu, 9 Mar 2017 08:55:28 +0700 From: Victor Sudakov To: freebsd-net@freebsd.org Subject: Re: GSSAPI and racoon Message-ID: <20170309015528.GA73893@admin.sibptus.transneft.ru> References: <20170303154509.GA81714@admin.sibptus.transneft.ru> <20170308062010.GA65343@admin.sibptus.transneft.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170308062010.GA65343@admin.sibptus.transneft.ru> Organization: AO "Svyaztransneft", SibPTUS X-PGP-Key: http://www.dreamwidth.org/pubkey?user=victor_sudakov X-PGP-Fingerprint: 10E3 1171 1273 E007 C2E9 3532 0DA4 F259 9B5E C634 User-Agent: Mutt/1.7.1 (2016-10-04) X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 Mar 2017 01:55:32 -0000 Victor Sudakov wrote: > Victor Sudakov wrote: > > > > Is anyone running GSSAPI+IKE (racoon)? > > I'm still struggling with racoon in GSSAPI mode. racoon says > > 2017-03-08 13:01:59: [192.168.3.38] ERROR: failed to get valid proposal. > 2017-03-08 13:01:59: [192.168.3.38] ERROR: failed to pre-process ph1 packet (side: 1, status 1). > 2017-03-08 13:01:59: [192.168.3.38] ERROR: phase1 negotiation failed. > > I would be very grateful if someone with IPSec experience could look > at my configs and logs. What am I missing? > > Not to clutter the list, I'm giving short URLs: > > racoon.conf: http://termbin.com/lk2w > racoon debug log: http://termbin.com/0lol > keytab: http://termbin.com/4yj9 > > The remote host configuration is identical, only it's called "ipsec1", > not "ipsec2". I forget to mention that "kinit -t /etc/krb5.keytab ike/ipsec1.sibptus.ru@SIBPTUS.RU" fetches a TGT all right, so the problem is probably not with Kerberos setup per se. -- Victor Sudakov, VAS4-RIPE, VAS47-RIPN AS43859 From owner-freebsd-net@freebsd.org Thu Mar 9 02:41:32 2017 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 819A0D034DE for ; Thu, 9 Mar 2017 02:41:32 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 717EF7AA for ; Thu, 9 Mar 2017 02:41:32 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id v292fWwL098972 for ; Thu, 9 Mar 2017 02:41:32 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-net@FreeBSD.org Subject: [Bug 212749] bridge fragment can leak mbufs Date: Thu, 09 Mar 2017 02:41:32 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: patch X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: kp@freebsd.org X-Bugzilla-Status: Closed X-Bugzilla-Resolution: FIXED X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-net@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: resolution bug_status Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 Mar 2017 02:41:32 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D212749 Kristof Provost changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|New |Closed --=20 You are receiving this mail because: You are the assignee for the bug.= From owner-freebsd-net@freebsd.org Thu Mar 9 03:01:00 2017 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id DA891D0144F for ; Thu, 9 Mar 2017 03:01:00 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id C707E1724 for ; Thu, 9 Mar 2017 03:01:00 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id v29310w1077833 for ; Thu, 9 Mar 2017 03:01:00 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-net@FreeBSD.org Subject: [Bug 217606] Bridge stops working after some days Date: Thu, 09 Mar 2017 03:01:00 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 11.0-RELEASE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: kp@freebsd.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-net@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: cc Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 Mar 2017 03:01:01 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D217606 Kristof Provost changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kp@freebsd.org --- Comment #1 from Kristof Provost --- I don't think you're running into the bridge memory leak that D7780 fixed. You'll want that patch, but I don't think that's the problem here. I also don't think that it's a pf problem, because bridge_pfil() doesn't pa= ss ARP packets to pf, so if the problem were there ARP packets should still pa= ss. Can you check if there's still free memory when you run into this problem? Being out of memory might explain it, but I don't see how bringing the interfaces down and up again would help. --=20 You are receiving this mail because: You are the assignee for the bug.= From owner-freebsd-net@freebsd.org Thu Mar 9 06:01:53 2017 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id E36C7D04005 for ; Thu, 9 Mar 2017 06:01:53 +0000 (UTC) (envelope-from daemon-user@freebsd.org) Received: from reviews.nyi.freebsd.org (reviews.nyi.freebsd.org [IPv6:2610:1c1:1:607c::16:b]) by mx1.freebsd.org (Postfix) with ESMTP id A2D791687 for ; Thu, 9 Mar 2017 06:01:53 +0000 (UTC) (envelope-from daemon-user@freebsd.org) Received: by reviews.nyi.freebsd.org (Postfix, from userid 1346) id 57B9410C86; Thu, 9 Mar 2017 06:01:53 +0000 (UTC) Date: Thu, 9 Mar 2017 06:01:53 +0000 To: freebsd-net@freebsd.org From: "oshogbo (Mariusz Zaborski)" Reply-to: D9847+325+deba385e191bfbb6@reviews.freebsd.org Subject: [Differential] D9847: Try to extract the RFC1048 data from PXE Message-ID: <4169f6b5ec04a79bd87b47067d9baedd@localhost.localdomain> X-Priority: 3 X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: , Thread-Topic: D9847: Try to extract the RFC1048 data from PXE X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: Precedence: bulk In-Reply-To: References: Thread-Index: YTlhODdhNGFiNzc3NzE3ZGRmMjFjNTkwOTA3IFjA79E= MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="b1_4169f6b5ec04a79bd87b47067d9baedd" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.23 List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 Mar 2017 06:01:54 -0000 --b1_4169f6b5ec04a79bd87b47067d9baedd Content-Type: text/plain; charset = "utf-8" Content-Transfer-Encoding: base64 VGhpcyByZXZpc2lvbiB3YXMgYXV0b21hdGljYWxseSB1cGRhdGVkIHRvIHJlZmxlY3QgdGhlIGNv bW1pdHRlZCBjaGFuZ2VzLgpDbG9zZWQgYnkgY29tbWl0IHJTMzE0OTQ4OiBUcnkgdG8gZXh0cmFj dCB0aGUgUkZDMTA0OCBkYXRhIGZyb20gUFhFLiBJZiB3ZSBnZXQgZW5vdWdoIGluZm8gd2UgY2Fu IHNraXAgKGF1dGhvcmVkIGJ5IG9zaG9nYm8pLgoKQ0hBTkdFRCBQUklPUiBUTyBDT01NSVQKICBo dHRwczovL3Jldmlld3MuZnJlZWJzZC5vcmcvRDk4NDc/dnM9MjU5MzYmaWQ9MjYwODkjdG9jCgpS RVBPU0lUT1JZCiAgclMgRnJlZUJTRCBzcmMgcmVwb3NpdG9yeQoKQ0hBTkdFUyBTSU5DRSBMQVNU IFVQREFURQogIGh0dHBzOi8vcmV2aWV3cy5mcmVlYnNkLm9yZy9EOTg0Nz92cz0yNTkzNiZpZD0y NjA4OQoKUkVWSVNJT04gREVUQUlMCiAgaHR0cHM6Ly9yZXZpZXdzLmZyZWVic2Qub3JnL0Q5ODQ3 CgpBRkZFQ1RFRCBGSUxFUwogIGhlYWQvbGliL2xpYnN0YW5kL2Jvb3RwLmMKICBoZWFkL2xpYi9s aWJzdGFuZC9ib290cC5oCiAgaGVhZC9zeXMvYm9vdC9pMzg2L2xpYmkzODYvcHhlLmMKCkVNQUlM IFBSRUZFUkVOQ0VTCiAgaHR0cHM6Ly9yZXZpZXdzLmZyZWVic2Qub3JnL3NldHRpbmdzL3BhbmVs L2VtYWlscHJlZmVyZW5jZXMvCgpUbzoga2N6ZWtpcmRhLCB0c29vbWUsIGdsZWJpdXMsIGZyZWVi c2QtbmV0LWxpc3QsICNuZXR3b3JrLCBnbm4sIGJhcHQsIG9zaG9nYm8sIHNtaApDYzogc21oCg== --b1_4169f6b5ec04a79bd87b47067d9baedd Content-Type: text/x-patch; charset=utf-8; name="D9847.26089.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="D9847.26089.patch" ZGlmZiAtLWdpdCBhL2hlYWQvc3lzL2Jvb3QvaTM4Ni9saWJpMzg2L3B4ZS5jIGIvaGVhZC9zeXMv Ym9vdC9pMzg2L2xpYmkzODYvcHhlLmMKLS0tIGEvaGVhZC9zeXMvYm9vdC9pMzg2L2xpYmkzODYv cHhlLmMKKysrIGIvaGVhZC9zeXMvYm9vdC9pMzg2L2xpYmkzODYvcHhlLmMKQEAgLTEwMSw2ICsx MDEsNyBAQAogZXh0ZXJuIHVfaW50MTZfdAkJX19weGVudnNlZzsKIGV4dGVybiB1X2ludDE2X3QJ CV9fcHhlbnZvZmY7CiBleHRlcm4gdm9pZAkJCV9fcHhlbnZlbnRyeSh2b2lkKTsKK2V4dGVybiBz dHJ1Y3QgaW5fYWRkcgkJc2VydmlwOwogCiBzdHJ1Y3QgbmV0aWZfZGlmIHB4ZV9pZnNbXSA9IHsK IC8qCWRpZl91bml0ICAgICAgICBkaWZfbnNlbCAgICAgICAgZGlmX3N0YXRzICAgICAgIGRpZl9w cml2YXRlICAgICAqLwpAQCAtMjc2LDE3ICsyNzcsMzggQEAKIAkJCX0KIAkJCWlmIChweGVfZGVi dWcpCiAJCQkJcHJpbnRmKCJweGVfb3BlbjogbmV0aWZfb3BlbigpIHN1Y2NlZWRlZFxuIik7CisK KwkJCWlmIChzb2NrdG9kZXNjKHB4ZV9zb2NrKSA9PSBOVUxMKSB7CisJCQkJcHJpbnRmKCJweGVf b3BlbjogYmFkIHNvY2tldCAlZFxuIiwgcHhlX3NvY2spOworCQkJCXJldHVybiAoRU5YSU8pOwor CQkJfQorCiAJCX0KIAkJaWYgKHJvb3RpcC5zX2FkZHIgPT0gMCkgewogCQkJLyoKLQkJCSAqIERv IGEgYm9vdHAvZGhjcCByZXF1ZXN0IHRvIGZpbmQgb3V0IHdoZXJlIG91cgorCQkJICogVHJ5IHRv IGV4dHJhY3QgdGhlIFJGQzEwNDggZGF0YSBmcm9tIFBYRS4KKwkJCSAqIElmIGZhaWwgZG8gYSBi b290cC9kaGNwIHJlcXVlc3QgdG8gZmluZCBvdXQgd2hlcmUgb3VyCiAJCQkgKiBORlMvVEZUUCBz ZXJ2ZXIgaXMuIEV2ZW4gaWYgd2UgZG9udCBnZXQgYmFjawogCQkJICogdGhlIHByb3BlciBpbmZv cm1hdGlvbiwgZmFsbCBiYWNrIHRvIHRoZSBzZXJ2ZXIKIAkJCSAqIHdoaWNoIGJyb3VnaHQgdXMg dG8gbGlmZSBhbmQgYSBkZWZhdWx0IHJvb3RwYXRoLgogCQkJICovCi0JCQlib290cChweGVfc29j aywgQk9PVFBfUFhFKTsKKworCQkJaWYgKGRoY3BfdHJ5X3JmYzEwNDgoYm9vdHBsYXllci52ZW5k b3IuZCwgQk9PVFBfREhDUFZFTkQpIDwgMCkgeworCQkJCWlmIChweGVfZGVidWcpCisJCQkJCXBy aW50ZigicHhlX29wZW46IG5vIFJGQzEwNDggZGF0YSBpbiBQWEUgQ2FjaGVcbiIpOworCQkJCWJv b3RwKHB4ZV9zb2NrLCBCT09UUF9QWEUpOworCQkJfSBlbHNlIGlmIChweGVfZGVidWcpIHsKKwkJ CQlwcmludGYoInB4ZV9vcGVuOiBsb2FkZWQgUkZDMTA0OCBkYXRhIGZyb20gUFhFIENhY2hlXG4i KTsKKwkJCX0KKwogCQkJaWYgKHJvb3RpcC5zX2FkZHIgPT0gMCkKIAkJCQlyb290aXAuc19hZGRy ID0gYm9vdHBsYXllci5zaXA7CisJCQlpZiAoZ2F0ZWlwLnNfYWRkciA9PSAwKQorCQkJCWdhdGVp cC5zX2FkZHIgPSBib290cGxheWVyLmdpcDsKKwkJCWlmIChteWlwLnNfYWRkciA9PSAwKQorCQkJ CW15aXAuc19hZGRyID0gYm9vdHBsYXllci55aXA7CisJCQlpZiAoc2VydmlwLnNfYWRkciA9PSAw KQorCQkJCXNlcnZpcCA9IHJvb3RpcDsKIAogCQkJbmV0cHJvdG8gPSBORVRfTkZTOwogCQkJaWYg KHRmdHBpcC5zX2FkZHIgIT0gMCkgewpAQCAtMzIzLDYgKzM0NSw5IEBACiAJCQlwcmludGYoInB4 ZV9vcGVuOiBzZXJ2ZXIgYWRkcjogJXNcbiIsIGluZXRfbnRvYShyb290aXApKTsKIAkJCXByaW50 ZigicHhlX29wZW46IHNlcnZlciBwYXRoOiAlc1xuIiwgcm9vdHBhdGgpOwogCQkJcHJpbnRmKCJw eGVfb3BlbjogZ2F0ZXdheSBpcDogICVzXG4iLCBpbmV0X250b2EoZ2F0ZWlwKSk7CisJCQlwcmlu dGYoInB4ZV9vcGVuOiBteSBpcDogICAgICAgJXNcbiIsIGluZXRfbnRvYShteWlwKSk7CisJCQlw cmludGYoInB4ZV9vcGVuOiBuZXRtYXNrOiAgICAgJXNcbiIsIGludG9hKG5ldG1hc2spKTsKKwkJ CXByaW50ZigicHhlX29wZW46IHNlcnZpcDogICAgICAlc1xuIiwgaW5ldF9udG9hKHNlcnZpcCkp OwogCiAJCQlpZiAobmV0cHJvdG8gPT0gTkVUX1RGVFApIHsKIAkJCQlzZXRlbnYoImJvb3QudGZ0 cHJvb3Quc2VydmVyIiwgaW5ldF9udG9hKHJvb3RpcCksIDEpOwpkaWZmIC0tZ2l0IGEvaGVhZC9s aWIvbGlic3RhbmQvYm9vdHAuaCBiL2hlYWQvbGliL2xpYnN0YW5kL2Jvb3RwLmgKLS0tIGEvaGVh ZC9saWIvbGlic3RhbmQvYm9vdHAuaAorKysgYi9oZWFkL2xpYi9saWJzdGFuZC9ib290cC5oCkBA IC0yMiw2ICsyMiw4IEBACiAgKiAkRnJlZUJTRCQKICAqLwogCisjaWZuZGVmIF9CT09UUF9IXwor I2RlZmluZSBfQk9PVFBfSF8KIAogc3RydWN0IGJvb3RwIHsKIAl1bnNpZ25lZCBjaGFyCWJwX29w OwkJLyogcGFja2V0IG9wY29kZSB0eXBlICovCkBAIC0xNDUsMyArMTQ3LDcgQEAKIAogLyogdl9m bGFncyB2YWx1ZXMgKi8KICNkZWZpbmUgVkZfU01BU0sJMQkvKiBTdWJuZXQgbWFzayBmaWVsZCBj b250YWlucyB2YWxpZCBkYXRhICovCisKK2ludAlkaGNwX3RyeV9yZmMxMDQ4KHVfY2hhciAqY3As IHVfaW50IGxlbik7CisKKyNlbmRpZiAvKiBfQk9PVFBfSF8gKi8KZGlmZiAtLWdpdCBhL2hlYWQv bGliL2xpYnN0YW5kL2Jvb3RwLmMgYi9oZWFkL2xpYi9saWJzdGFuZC9ib290cC5jCi0tLSBhL2hl YWQvbGliL2xpYnN0YW5kL2Jvb3RwLmMKKysrIGIvaGVhZC9saWIvbGlic3RhbmQvYm9vdHAuYwpA QCAtMzQ0LDYgKzM0NCwxNyBAQAogCXJldHVybiAoLTEpOwogfQogCitpbnQKK2RoY3BfdHJ5X3Jm YzEwNDgodV9jaGFyICpjcCwgdV9pbnQgbGVuKQoreworCisJZXhwZWN0ZWRfZGhjcG1zZ3R5cGUg PSBESENQQUNLOworCWlmIChiY21wKHZtX3JmYzEwNDgsIGNwLCBzaXplb2Yodm1fcmZjMTA0OCkp ID09IDApIHsKKwkJcmV0dXJuICh2ZW5kX3JmYzEwNDgoY3AsIGxlbikpOworCX0KKwlyZXR1cm4g KC0xKTsKK30KKwogc3RhdGljIGludAogdmVuZF9yZmMxMDQ4KGNwLCBsZW4pCiAJdV9jaGFyICpj cDsKCg== --b1_4169f6b5ec04a79bd87b47067d9baedd-- From owner-freebsd-net@freebsd.org Thu Mar 9 08:57:55 2017 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id AD7E9D047FE for ; Thu, 9 Mar 2017 08:57:55 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 9D050182D for ; Thu, 9 Mar 2017 08:57:55 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id v298vtE1021897 for ; Thu, 9 Mar 2017 08:57:55 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-net@FreeBSD.org Subject: [Bug 209581] igb vf driver does not correctly handle vlan tag Date: Thu, 09 Mar 2017 08:57:55 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 10.3-RELEASE X-Bugzilla-Keywords: IntelNetworking X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: kaho@elam.kais.kyoto-u.ac.jp X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-net@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: cc Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 Mar 2017 08:57:55 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D209581 Kaho Toshikazu changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kaho@elam.kais.kyoto-u.ac.j | |p --- Comment #4 from Kaho Toshikazu --- (In reply to ingenium from comment #3) Please try a patch for 11-stable. I don't test it. This functionality seems to be dropped from 12-current's iflib if_em.c. Index: sys/dev/e1000/if_igb.c =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D --- sys/dev/e1000/if_igb.c (revision 314587) +++ sys/dev/e1000/if_igb.c (working copy) @@ -5327,7 +5327,6 @@ if (adapter->vf_ifp) { e1000_rlpml_set_vf(hw, adapter->max_frame_size + VLAN_TAG_SIZE); - return; } reg =3D E1000_READ_REG(hw, E1000_CTRL); --=20 You are receiving this mail because: You are the assignee for the bug.= From owner-freebsd-net@freebsd.org Thu Mar 9 15:25:40 2017 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 21280D04939 for ; Thu, 9 Mar 2017 15:25:40 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 10C38159F for ; Thu, 9 Mar 2017 15:25:40 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id v29FPdOa015898 for ; Thu, 9 Mar 2017 15:25:39 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-net@FreeBSD.org Subject: [Bug 217600] Gateway enable not working Date: Thu, 09 Mar 2017 15:25:40 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 10.3-RELEASE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: judah.levine@colorado.edu X-Bugzilla-Status: Closed X-Bugzilla-Resolution: Overcome By Events X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-net@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: resolution bug_status Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 Mar 2017 15:25:40 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D217600 judah.levine@colorado.edu changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |Overcome By Events Status|New |Closed --=20 You are receiving this mail because: You are the assignee for the bug.= From owner-freebsd-net@freebsd.org Thu Mar 9 18:01:56 2017 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id E7FC4D05686 for ; Thu, 9 Mar 2017 18:01:56 +0000 (UTC) (envelope-from nparhar@gmail.com) Received: from mail-pg0-x235.google.com (mail-pg0-x235.google.com [IPv6:2607:f8b0:400e:c05::235]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id B758F1A7 for ; Thu, 9 Mar 2017 18:01:56 +0000 (UTC) (envelope-from nparhar@gmail.com) Received: by mail-pg0-x235.google.com with SMTP id b129so29001477pgc.2 for ; Thu, 09 Mar 2017 10:01:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=RvQ0n2o7JIxt94Fthn2SLoP/d3YSHdPFUpgJ85spgeY=; b=FhgRKw6opcWZrT51L+4tFZDaB0U56Jzv67LX6uk+s10OWtu+u14ugMLSzm2TeG7XuO IkxyHYtqnFdEprW+8KCW/2T4EBBMeJWPxzvMC80FpeqMFk64hOW7wMRf3xxi1UP/+NNP DcERM1U2BnRmnoAQTO5D/uBtB4yWduB9cjIgLOvGxdBmYl7HcJineWXrpdO+Bye6GZmM jEaFuNebaKbJUffuk2jyQvqzr8TbYMVnxEeLcV9gT6iJ8MB0E9rnKW/+2/7OcwDTvfKb IJUYjB7912Fbxd5wKKc9pyOoawJY0w/SRYMLeySmLSp6KIEfXNO+7RzOliOdRiUvm3GR jCpw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=RvQ0n2o7JIxt94Fthn2SLoP/d3YSHdPFUpgJ85spgeY=; b=DNfVtEWp+7di9+mr5TRB+JN5ZN7JjM2pYE/Xshe2+K6IeANb0c01kvBFswVXGw25F3 GGsEbjY1muGNb1ylZt+u2M84shQ16dONCvHGgfO9YQABFtzhdvOYv1opeObG2gkPl8hh 9prtHCxOakF4mCc38tKfbe0Dx6eYKCYhK9X0k9r8RsRT0VEmhWz9+vGqNvc2t/HRsjXa jRXT5hs9tnzgbhFivBU4dOisXmMvtNesHsMupY0QpoQJ0Sbf8TpR4cCw9z6a/QUSADf+ P6sQgMveP1nmBudRqQkm9U72o/kKiLqxPSzMvy27vQVAkiAsqPBfDD5MFtMmcrSxj/Zg dPdQ== X-Gm-Message-State: AMke39ls5bXGXsFYAZrFZZSZJBkeOKOXFBTMJmFbSKNkLkvqZ56eQbP5wLwXddm9gLCwzQL0bO1xPStLDb0Mdw== X-Received: by 10.99.173.69 with SMTP id y5mr15320072pgo.35.1489082516148; Thu, 09 Mar 2017 10:01:56 -0800 (PST) MIME-Version: 1.0 Received: by 10.100.182.172 with HTTP; Thu, 9 Mar 2017 10:01:55 -0800 (PST) In-Reply-To: References: <93e10699-ecc7-c062-bf85-a26de0de9633@sentex.net> <901224a7-f3ed-84a4-5402-3542cd0e865b@sentex.net> From: Navdeep Parhar Date: Thu, 9 Mar 2017 10:01:55 -0800 Message-ID: Subject: Re: Chelsio netmap support ? (RELENG_11) To: Mike Tancsa Cc: "freebsd-net@freebsd.org" Content-Type: text/plain; charset=UTF-8 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 Mar 2017 18:01:57 -0000 On Wed, Mar 8, 2017 at 6:28 AM, Mike Tancsa wrote: > On 3/7/2017 9:08 PM, Navdeep Parhar wrote: >> On Tue, Mar 7, 2017 at 5:46 PM, Mike Tancsa wrote: >> >>> >>> # dmesg | grep netm >>> netmap: loaded module >>> vcxl0: netmap queues/slots: TX 2/1023, RX 2/1024 >>> vcxl0: 1 txq, 1 rxq (NIC); 1 txq, 1 rxq (TOE); 2 txq, 2 rxq (netmap) >>> vcxl1: netmap queues/slots: TX 2/1023, RX 2/1024 >>> vcxl1: 1 txq, 1 rxq (NIC); 1 txq, 1 rxq (TOE); 2 txq, 2 rxq (netmap) >>> igb0: netmap queues/slots: TX 4/1024, RX 4/1024 >>> igb1: netmap queues/slots: TX 4/1024, RX 4/1024 >>> >>> It maxes out at about 800Kpps with and without netmap. Is there a way >> >> Are you actually using a netmap based application that acts as a >> packet router or is this just the vcxl interface running as a normal >> ifnet? > > the later, vcxl running normal ifnet. I thought there would be a benefit > to utilizing netmap ? Sorry, this is not clear to me. The kernel's routing code does not utilize netmap even if it's available. You'll need something like netmap-fwd for netmap based routing. If you're not using netmap there is no need to create the extra vcxl interfaces. > >> >>> to increase the queues for the Chelsio nic, like the onboard igb ? >> >> If you're not running a netmap based router get rid of the num_vis=2 >> and simply try with the cxl0/cxl1 interfaces. They should each have 4 >> rxq/4 txq on your system. In case you want to increase the number of >> queues, use this: > > The tests with the regular cxl also show the box topping out at 0.8Mpps > for forwarding. I would have expected multiple streams to do better. There is a lot of information about forwarding on the bsdrp.net website. Have you tried the tips there? The numbers there are significantly better than what you observe. I suspect your router is CPU-bound. https://bsdrp.net/documentation/examples/forwarding_performance_lab_of_a_hp_proliant_dl360p_gen8_with_10-gigabit_with_10-gigabit_chelsio_t540-cr https://bsdrp.net/documentation/examples/forwarding_performance_lab_of_a_superserver_5018a-ftn4_with_10-gigabit_chelsio_t540-cr There's a projects/routing branch that does much better than the stock kernel. I'm not sure what work remains to be done before it can be merged into head. https://github.com/ocochard/netbenches/blob/master/Xeon_E5-2650-8Cores-Chelsio_T540-CR/forwarding-pf-ipfw/results/fbsd11-routing.r287531/README.md Regards, Navdeep > >> >> The "NIC" queues are the normal tx/rx queues, the "netmap" queues are >> active when the interface is in netmap mode. >> >> Does netsend generate a single flow or multiple flows? If it's a >> single flow it will use a single queue only. > > I think its as a single flow. However, I was using a separate box to > generate a second flow as well. It still topped out at about 800Kpps > before dropping packets. > > ---Mike > > > > -- > ------------------- > Mike Tancsa, tel +1 519 651 3400 > Sentex Communications, mike@sentex.net > Providing Internet services since 1994 www.sentex.net > Cambridge, Ontario Canada http://www.tancsa.com/ From owner-freebsd-net@freebsd.org Thu Mar 9 18:14:28 2017 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 274E7D05EF9 for ; Thu, 9 Mar 2017 18:14:28 +0000 (UTC) (envelope-from daemon-user@freebsd.org) Received: from reviews.nyi.freebsd.org (reviews.nyi.freebsd.org [IPv6:2610:1c1:1:607c::16:b]) by mx1.freebsd.org (Postfix) with ESMTP id 0439E1153 for ; Thu, 9 Mar 2017 18:14:28 +0000 (UTC) (envelope-from daemon-user@freebsd.org) Received: by reviews.nyi.freebsd.org (Postfix, from userid 1346) id 9C5DAC8E2; Thu, 9 Mar 2017 18:14:27 +0000 (UTC) Date: Thu, 9 Mar 2017 18:14:27 +0000 To: freebsd-net@freebsd.org From: "asomers (Alan Somers)" Reply-to: D9451+325+eaa6f8a0c0731bfe@reviews.freebsd.org Subject: [Differential] D9451: Constrain IPv6 interface routes to each FIB Message-ID: <40c04b6be27ac0dbc128d567dd127094@localhost.localdomain> X-Priority: 3 X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: , Thread-Topic: D9451: Constrain IPv6 interface routes to each FIB X-Herald-Rules: <28>, <81>, <51> X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: Precedence: bulk In-Reply-To: References: Thread-Index: MzA4MmVhNjA3MDYxYjk1ZGE4NzFjZWJhMzgyIFjBm4M= MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.23 List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 Mar 2017 18:14:28 -0000 YXNvbWVycyBhY2NlcHRlZCB0aGlzIHJldmlzaW9uLgphc29tZXJzIGFkZGVkIGlubGluZSBjb21t ZW50cy4KVGhpcyByZXZpc2lvbiBoYXMgYSBwb3NpdGl2ZSByZXZpZXcuCgpJTkxJTkUgQ09NTUVO VFMKCj4gamh1amhpdGlfYWRqZWN0aXZpc20ub3JnIHdyb3RlIGluIG5kNl9uYnIuYzoyNjUKPiBJ IHRoaW5rIHRoaXMgaXMgdGhlIG9ubHkgdGhpbmcgbGVmdCB0byBjb25zaWRlciBmb3IgdGhpcyBw YXRjaCwgYnV0IGl0IHNlZW1zIHRvIG1lIHRoYXQgdXNpbmcgdGhlIHJlY2VpdmluZyBpbnRlcmZh Y2UncyBGSUIgaXMgdGhlIG1vc3QgY29ycmVjdCB0aGluZyB0byBkbyBoZXJlLiBDaGVja2luZyBv dGhlciBGSUJzIHNlZW1zIGluY29ycmVjdCBzaW5jZSB0aGF0IHdvdWxkIGNhdXNlIHRoZSBwcm94 eSB0byAibGVhayIgYWNyb3NzIEZJQiBib3VuZGFyaWVzLgoKQXQgdGhpcyBwb2ludCwgYGRzdDZg IGlzIHRoZSBkZXN0aW5hdGlvbiBhZGRyZXNzIG9mIHRoZSByZWNlaXZlZCBucyBwYWNrZXQuICBu cyBwYWNrZXRzIGFyZSBzZW50IGVpdGhlciB0byB1bmljYXN0IG9yIG11bHRpY2FzdCBhZGRyZXNz ZXMuICBJbiB0aGUgZm9ybWVyIGNhc2UsIHdlIHNob3VsZCBuZXZlciByZWNlaXZlIGEgbnMgcGFj a2V0IGV4Y2VwdCB0byBhbiBhZGRyZXNzIHdlIGFscmVhZHkgdXNlLCBhbmQgaXQgc2hvdWxkIG9u bHkgYXJyaXZlIGF0IHRoZSBpbnRlcmZhY2UgdGhhdCdzIHVzaW5nIHRoYXQgYWRkcmVzcyAodW5s ZXNzIHlvdXIgaW50ZXJmYWNlIGZpYiBpcyBkaWZmZXJlbnQgdGhhbiBmaWIgdGhlIGFkZHJlc3Mg d2FzIGNvbmZpZ3VyZWQgd2l0aCwgYnV0IEkgd291bGQgY2FsbCB0aGF0IGEgY29uZmlndXJhdGlv biBlcnJvcikuICBJZiBpdCdzIGEgbXVsdGljYXN0IHBhY2tldCwgdGhlIHNhbWUgbG9naWMgYXBw bGllcywgZXhjZXB0IHRoYXQgdGhlcmUncyBhIHNtYWxsIGNoYW5jZSBmb3IgdXMgdG8gcmVjZWl2 ZSBhIG11bHRpY2FzdCBucyBwYWNrZXQgZm9yIGFuIGFkZHJlc3MgdGhhdCdzIG5vdCBvdXJzLiAg QnV0IGV2ZW4gaW4gdGhhdCBjYXNlLCB0aGUgcGFja2V0IHNob3VsZCBhcnJpdmUgYXQgdGhlIGlu dGVyZmFjZSB0aGF0J3MgYSBtZW1iZXIgb2YgdGhhdCBtdWx0aWNhc3QgZ3JvdXAsIHVubGVzcyB0 aGUgZ3JvdXAncyB1bmljYXN0IGFkZHJlc3MgaXMgY29uZmlndXJlZCBmb3IgYSBkaWZmZXJlbnQg ZmliIHRoYW4gdGhlIGludGVyZmFjZS4gIEluIHN1bW1hcnksIEkgdGhpbmsgaXQncyBvayB0byB1 c2UgdGhlIHJlY2VpdmluZyBpbnRlcmZhY2UncyBmaWIgaGVyZS4KClJFUE9TSVRPUlkKICByUyBG cmVlQlNEIHNyYyByZXBvc2l0b3J5CgpSRVZJU0lPTiBERVRBSUwKICBodHRwczovL3Jldmlld3Mu ZnJlZWJzZC5vcmcvRDk0NTEKCkVNQUlMIFBSRUZFUkVOQ0VTCiAgaHR0cHM6Ly9yZXZpZXdzLmZy ZWVic2Qub3JnL3NldHRpbmdzL3BhbmVsL2VtYWlscHJlZmVyZW5jZXMvCgpUbzogamh1amhpdGlf YWRqZWN0aXZpc20ub3JnLCAjbmV0d29yaywgYnosIGFzb21lcnMKQ2M6IGpjaCwgYnosIGltcCwg YWUsIGZyZWVic2QtbmV0LWxpc3QK From owner-freebsd-net@freebsd.org Thu Mar 9 19:03:39 2017 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 2D72AD05068 for ; Thu, 9 Mar 2017 19:03:39 +0000 (UTC) (envelope-from no-reply@webcurso.es) Received: from p17.mxout.mta2.net (p17.mxout.mta2.net [188.165.95.240]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id E8CBA1944 for ; Thu, 9 Mar 2017 19:03:37 +0000 (UTC) (envelope-from no-reply@webcurso.es) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=webcurso.es; h=MIME-Version:Subject:Date:From:Reply-To:To:Message-ID:List-Unsubscribe:Content-Type; q=dns/txt; s=api; t=1489086224; bh=gQxccmuSYfizULASGB22h9qrkQ6hA2ntbMiV9b3uumE=; b= UO0gUZieP1HwX72P4fj3J6jrRDLETwhJLzSZhJ3U6n+TAer4UpBXytlB+WNQt62Q5DNfOJ+3B3ewgZl9q7DGNo2Egv+QGN9KN+dXrhBoLiilQldtCUzNNjKcr7ylRdQkHqg+xtmWBosz9MdCFF+tHX18+UnxAW3CyN65kH9EyLY= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=elasticemail.com; h=MIME-Version:Subject:Date:From:Reply-To:To:Message-ID:List-Unsubscribe:Content-Type; q=dns/txt; s=api; t=1489086224; bh=gQxccmuSYfizULASGB22h9qrkQ6hA2ntbMiV9b3uumE=; b= Wt/BnIl+hlM4FDvlYqXEb7qkwsQ5nrO55ktxqavxLapPZe/fbhex8kdaYeW6NOkihA9qou/VbkUenJKm1g1uqohx+hjWLdX5vvViGjiMdpoLTbv8lxJi2HiGqQ9lC5OQczWsdQpSYgxlMMarBJwWQNFZPH4EH1BwFQ/4cJ3ot40= From: Cursos bonificados para trabajadores Date: Thu, 09 Mar 2017 19:02:26 +0000 Subject: Cursos de excel para trabajadores Message-Id: <4u0qoed76pbv.ERqb-nGeENvOKRNUvm5crw2@NSFS.trk.elasticemail.com> Reply-To: no-reply@webcurso.es Sender: Cursos bonificados para trabajadores To: freebsd-net@freebsd.org X-Msg-EID: ERqb-nGeENvOKRNUvm5crw2 X-Mailer-LID: 104 X-Mailer-RecptId: 10357820 X-Mailer-SID: 375 X-Mailer-Sent-By: 1 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Content-Filtered-By: Mailman/MimeDel 2.1.23 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 Mar 2017 19:03:39 -0000 Your email client cannot read this email. To view it online, please go here: http://NSFS.trk.elasticemail.com/tracking/click?msgid=ERqb-nGeENvOKRNUvm5crw2&target=https%3a%2f%2fwww.webcurso.es%2fbulletin%2fdisplay.php%3fM%3d10357820%26C%3d4335979a5aff6098da0cde60644230e8%26S%3d375%26L%3d104%26N%3d429&v=NLEaxosknZkNS9Jlo-UpIQ2 To stop receiving these emails:http://NSFS.trk.elasticemail.com/tracking/click?msgid=ERqb-nGeENvOKRNUvm5crw2&target=https%3a%2f%2fwww.webcurso.es%2fbulletin%2funsubscribe.php%3fM%3d10357820%26C%3d4335979a5aff6098da0cde60644230e8%26L%3d104%26N%3d375&v=7B4AtkB7SrSmFMEwibunxg2 From owner-freebsd-net@freebsd.org Thu Mar 9 19:09:27 2017 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 18FD0D0529E for ; Thu, 9 Mar 2017 19:09:27 +0000 (UTC) (envelope-from citrin+bsd@citrin.ru) Received: from hz.citrin.ru (hz.citrin.ru [88.198.212.3]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id D24821EC9 for ; Thu, 9 Mar 2017 19:09:26 +0000 (UTC) (envelope-from citrin+bsd@citrin.ru) Received: from x220.lan (c-24-60-168-172.hsd1.ct.comcast.net [24.60.168.172]) by hz.citrin.ru (Postfix) with ESMTPSA id 1B54C29A342 for ; Thu, 9 Mar 2017 19:09:21 +0000 (UTC) Subject: Re: about that DFBSD performance test To: freebsd-net@freebsd.org References: <20170308125710.GS15630@zxy.spb.ru> <20170308150346.GA32269@dft-labs.eu> From: Anton Yuzhaninov Message-ID: <7d02f9f3-8dd3-9dc9-56d6-be9a34b49750@citrin.ru> Date: Thu, 9 Mar 2017 14:09:19 -0500 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 MIME-Version: 1.0 In-Reply-To: <20170308150346.GA32269@dft-labs.eu> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrin.ru; s=s0; t=1489086562; bh=dekxih+jLNednRWdyqdIqsqZssfL293yH6OMV2x3oPw=; h=Subject:To:References:From:Message-ID:Date:MIME-Version:In-Reply-To:Content-Type:Content-Transfer-Encoding; b=kvVg9SxSTewDa7DmYzrHGqDkMRS/Jj6t2Ly/e5/H7IOSnFwNLZM+vjCtOVZSNFc53aEJLGj/XbV9VcgJ+HTvW5C4wPHK0cHyspcVM005IAURspfBqgjQ7nDzhgSWvsaYM3PUnGR5GKNGX4wbkWj/DbTrZ/aJWBen6D3UmI9JRtM= X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 Mar 2017 19:09:27 -0000 On 03/08/17 10:03, Mateusz Guzik wrote: > First and foremost there is general kernel scalability. Certain counters > and most locks are purely managed with atomic operations. An atomic > operation grabs the entire cacheline with the particular variable (64 > bytes in total) in exclusive mode. Isn't problem of atomic counters was solved by counter(9) framework? From owner-freebsd-net@freebsd.org Thu Mar 9 21:32:52 2017 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 5BA00D0543C; Thu, 9 Mar 2017 21:32:52 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2610:1c1:1:6074::16:84]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "freefall.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 2FA8C25F; Thu, 9 Mar 2017 21:32:52 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from mail.xzibition.com (freefall.freebsd.org [IPv6:2610:1c1:1:6074::16:84]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by freefall.freebsd.org (Postfix) with ESMTPS id 6348575CB; Thu, 9 Mar 2017 21:32:51 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from mail.xzibition.com (localhost [172.31.3.2]) by mail.xzibition.com (Postfix) with ESMTP id 6BB4330486; Thu, 9 Mar 2017 21:32:44 +0000 (UTC) X-Virus-Scanned: amavisd-new at mail.xzibition.com Received: from mail.xzibition.com ([172.31.3.2]) by mail.xzibition.com (mail.xzibition.com [172.31.3.2]) (amavisd-new, port 10026) with LMTP id fYD-t6hPRxie; Thu, 9 Mar 2017 21:32:16 +0000 (UTC) To: current@FreeBSD.org, "freebsd-net@freebsd.org" DKIM-Filter: OpenDKIM Filter v2.9.2 mail.xzibition.com D0B4730480 From: Bryan Drewery Subject: r314708: panic: Assertion err == 0 failed at /usr/src/sys/net/iflib.c:2241 Openpgp: id=F9173CB2C3AAEA7A5C8A1F0935D771BB6E4697CF; url=http://www.shatow.net/bryan/bryan2.asc Organization: FreeBSD Message-ID: <3c8062d7-afcc-44eb-1c05-f32c2b49973d@FreeBSD.org> Date: Thu, 9 Mar 2017 13:31:56 -0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="CsddWNDgqxTRQ3BPa6GKCOEem7mqkoHee" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 Mar 2017 21:32:52 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --CsddWNDgqxTRQ3BPa6GKCOEem7mqkoHee Content-Type: multipart/mixed; boundary="jR5W7a7ELFHlCm8KKPRrBRfOlfF0jh0de"; protected-headers="v1" From: Bryan Drewery To: current@FreeBSD.org, "freebsd-net@freebsd.org" Message-ID: <3c8062d7-afcc-44eb-1c05-f32c2b49973d@FreeBSD.org> Subject: r314708: panic: Assertion err == 0 failed at /usr/src/sys/net/iflib.c:2241 --jR5W7a7ELFHlCm8KKPRrBRfOlfF0jh0de Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable This came up at shutdown in r314708. I don't yet know if I will have a core to diagnose. > panic: Assertion err =3D=3D 0 failed at /usr/src/sys/net/iflib.c:2241 > cpuid =3D 0 > KDB: stack backtrace: > db_trace_self_wrapper() at db_trace_self_wrapper+0x2b/frame 0xfffffe349= a7f9940 > vpanic() at vpanic+0x186/frame 0xfffffe349a7f99c0 > _kassert_panic() at _kassert_panic+0x12f/frame 0xfffffe349a7f9a40 > _task_fn_rx() at _task_fn_rx+0x19d/frame 0xfffffe349a7f9b20 > gtaskqueue_run_locked() at gtaskqueue_run_locked+0x139/frame 0xfffffe34= 9a7f9b80 > gtaskqueue_thread_loop() at gtaskqueue_thread_loop+0x88/frame 0xfffffe3= 49a7f9bb0 > fork_exit() at fork_exit+0x84/frame 0xfffffe349a7f9bf0 > fork_trampoline() at fork_trampoline+0xe/frame 0xfffffe349a7f9bf0 > --- trap 0, rip =3D 0, rsp =3D 0, rbp =3D 0 --- > KDB: enter: panic > [ thread pid 0 tid 100038 ] > Stopped at kdb_enter+0x3b: movq $0,kdb_why --=20 Regards, Bryan Drewery --jR5W7a7ELFHlCm8KKPRrBRfOlfF0jh0de-- --CsddWNDgqxTRQ3BPa6GKCOEem7mqkoHee Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBAgAGBQJYwcnNAAoJEDXXcbtuRpfPCq8H/jvKQH+LZ8H0KIK1PirAgDSD XR3wUz3UN46OsukHG0PJeUOz0YMsD2D00cYMpvF3hfb/vOAtNqiAc62EGZCn4ZSu o5oWAm0Emx8I6x9i7jX4fm3197W9Y1TINIULQlaRSi0cSL5QVX84Ti+vyAzXq35H W1UwZj4jr+nkq0sV9561kaDLX4DqAhHXxIERKoGS/3cuklD93prLRKvwj40UUWRk q/nltQ/67eGygbtv7jQ3kJbcWDL/9/CZ2KT4Zh9vVdh5aijQOcrJLi85B388rAXt 2t/ewkDj0YSDs6stAEIPG8Wn+s42pmt8tu7RkQ4l/PSaigfVR2Y8eZ5r+k0TiGE= =BHhn -----END PGP SIGNATURE----- --CsddWNDgqxTRQ3BPa6GKCOEem7mqkoHee-- From owner-freebsd-net@freebsd.org Fri Mar 10 01:06:17 2017 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id A50D9D056CD for ; Fri, 10 Mar 2017 01:06:17 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 94DAB1182 for ; Fri, 10 Mar 2017 01:06:17 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id v2A16Huv025679 for ; Fri, 10 Mar 2017 01:06:17 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-net@FreeBSD.org Subject: [Bug 217637] One TCP connection accepted TWO time Date: Fri, 10 Mar 2017 01:06:17 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 10.3-STABLE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: hiren@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-net@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 10 Mar 2017 01:06:17 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D217637 --- Comment #1 from Hiren Panchasara --- If possible, it'd be useful to look at real pcaps (and not text excerpts) f= rom both ends. --=20 You are receiving this mail because: You are the assignee for the bug.= From owner-freebsd-net@freebsd.org Fri Mar 10 08:27:40 2017 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 08DEFD04453 for ; Fri, 10 Mar 2017 08:27:40 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id E217612F3 for ; Fri, 10 Mar 2017 08:27:39 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id v2A8RdwV048940 for ; Fri, 10 Mar 2017 08:27:39 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-net@FreeBSD.org Subject: [Bug 217606] Bridge stops working after some days Date: Fri, 10 Mar 2017 08:27:39 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 11.0-RELEASE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: aiko@torrentkino.de X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-net@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 10 Mar 2017 08:27:40 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D217606 --- Comment #2 from Aiko Barz --- Today the other Bridge-Server had this issue. But I forget to collect the memory situation before applying the workaround= . :( My current workaround: $ ifconfig ix0 down $ ifconfig ix0 up $ ifconfig ix1 down $ ifconfig ix1 up This is the memory situation after applying the workaround: $ sysctl hw | egrep 'hw.(phys|user|real)' hw.physmem: 17095405568 hw.usermem: 14351601664 hw.realmem: 17179869184 $ grep memory /var/run/dmesg.boot real memory =3D 17179869184 (16384 MB) avail memory =3D 16531873792 (15766 MB) $ freecolor -m -o total used free shared buffers cached Mem: 15866 2625 13240 0 0 0 Swap: 8192 0 8192 $ vmstat -s 1609035107 cpu context switches 3485091537 device interrupts 11107443 software interrupts 44940504 traps 55770968 system calls 25 kernel threads created 184620 fork() calls 35599 vfork() calls 4 rfork() calls 0 swap pager pageins 0 swap pager pages paged in 0 swap pager pageouts 0 swap pager pages paged out 64250 vnode pager pageins 64954 vnode pager pages paged in 1378 vnode pager pageouts 21763 vnode pager pages paged out 0 page daemon wakeups 297604 pages examined by the page daemon 0 pages reactivated 11889396 copy-on-write faults 6627 copy-on-write optimized faults 24742122 zero fill pages zeroed 0 zero fill pages prezeroed 663 intransit blocking page faults 41093137 total VM faults taken 63984 page faults requiring I/O 0 pages affected by kernel thread creation 7838450 pages affected by fork() 1220635 pages affected by vfork() 1524 pages affected by rfork() 0 pages cached 45799762 pages freed 0 pages freed by daemon 30066607 pages freed by exiting processes 2339 pages active 17759 pages inactive 0 pages in VM cache 669862 pages wired down 3371746 pages free 4096 bytes per page 38614188 total name lookups cache hits (89% pos + 7% neg) system 0% per-directory deletions 0%, falsehits 0%, toolong 0% Those machines only run PF. Nothing else. Kind regards, Aiko --=20 You are receiving this mail because: You are the assignee for the bug.= From owner-freebsd-net@freebsd.org Fri Mar 10 09:14:48 2017 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 2DAFED05155 for ; Fri, 10 Mar 2017 09:14:48 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 12EDD17EA for ; Fri, 10 Mar 2017 09:14:48 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id v2A9El3v007836 for ; Fri, 10 Mar 2017 09:14:47 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-net@FreeBSD.org Subject: [Bug 217606] Bridge stops working after some days Date: Fri, 10 Mar 2017 09:14:47 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 11.0-RELEASE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: kp@freebsd.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-net@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 10 Mar 2017 09:14:48 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D217606 --- Comment #3 from Kristof Provost --- It doesn't look like it's running out of memory. It'd be good to confirm th= is when it's in the faulty state, just to be sure. --=20 You are receiving this mail because: You are the assignee for the bug.= From owner-freebsd-net@freebsd.org Fri Mar 10 09:36:24 2017 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id B4BD1D05A97 for ; Fri, 10 Mar 2017 09:36:24 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id A4703699 for ; Fri, 10 Mar 2017 09:36:24 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id v2A9aO5d051495 for ; Fri, 10 Mar 2017 09:36:24 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-net@FreeBSD.org Subject: [Bug 217637] One TCP connection accepted TWO time Date: Fri, 10 Mar 2017 09:36:24 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 10.3-STABLE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: alexandre.martins@stormshield.eu X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-net@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: attachments.created Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 10 Mar 2017 09:36:24 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D217637 --- Comment #2 from Alexandre martins --- Created attachment 180691 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D180691&action= =3Dedit Server side view capture --=20 You are receiving this mail because: You are the assignee for the bug.= From owner-freebsd-net@freebsd.org Fri Mar 10 09:36:47 2017 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 43885D05B36 for ; Fri, 10 Mar 2017 09:36:47 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 3336279F for ; Fri, 10 Mar 2017 09:36:47 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id v2A9alSi051928 for ; Fri, 10 Mar 2017 09:36:47 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-net@FreeBSD.org Subject: [Bug 217637] One TCP connection accepted TWO time Date: Fri, 10 Mar 2017 09:36:47 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 10.3-STABLE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: alexandre.martins@stormshield.eu X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-net@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: attachments.created Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 10 Mar 2017 09:36:47 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D217637 --- Comment #3 from Alexandre martins --- Created attachment 180692 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D180692&action= =3Dedit Client side view --=20 You are receiving this mail because: You are the assignee for the bug.= From owner-freebsd-net@freebsd.org Fri Mar 10 09:41:09 2017 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 566E1D05C8D for ; Fri, 10 Mar 2017 09:41:09 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4668E9B1 for ; Fri, 10 Mar 2017 09:41:09 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id v2A9f9KL060481 for ; Fri, 10 Mar 2017 09:41:09 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-net@FreeBSD.org Subject: [Bug 217637] One TCP connection accepted TWO time Date: Fri, 10 Mar 2017 09:41:09 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 10.3-STABLE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: alexandre.martins@stormshield.eu X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-net@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 10 Mar 2017 09:41:09 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D217637 --- Comment #4 from Alexandre martins --- I attached the capture of the most simple test that I made to reproduce the bug. The connection pass through a firewall that drop the TCP reset. The server logs that connection is accepted two time. --=20 You are receiving this mail because: You are the assignee for the bug.= From owner-freebsd-net@freebsd.org Fri Mar 10 16:47:19 2017 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id D0332D06C03 for ; Fri, 10 Mar 2017 16:47:19 +0000 (UTC) (envelope-from cr2025x1@gmail.com) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id AE8A87DA for ; Fri, 10 Mar 2017 16:47:19 +0000 (UTC) (envelope-from cr2025x1@gmail.com) Received: by mailman.ysv.freebsd.org (Postfix) id AAFDAD06C01; Fri, 10 Mar 2017 16:47:19 +0000 (UTC) Delivered-To: net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id AAA31D06C00 for ; Fri, 10 Mar 2017 16:47:19 +0000 (UTC) (envelope-from cr2025x1@gmail.com) Received: from mail-pf0-x234.google.com (mail-pf0-x234.google.com [IPv6:2607:f8b0:400e:c00::234]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 7C0057D8 for ; Fri, 10 Mar 2017 16:47:19 +0000 (UTC) (envelope-from cr2025x1@gmail.com) Received: by mail-pf0-x234.google.com with SMTP id w189so43791370pfb.0 for ; Fri, 10 Mar 2017 08:47:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=message-id:mime-version:to:from:subject:date:importance; bh=fxoOIeqELyI66nAe9ViQkJ6CCdQUE4eyPX8v2mOkSgs=; b=MBDf9vcC7HkzsSg+eKxuAxI9rehtNvmi5d1ynh8axIN4N/WMzNA38Lp15HrzpXcBN1 jxi9jTcgkiHTBzlGAis6p5wjl2A8/BXHGDXlksbWzBb5R0PrDIXRVZlqJiNXBbLF/r9N EGzU9h6xIaqTr+9ry7FwuF2Pf4VGOLwMH+Q839dWjJ9n9BNCOosxP3HdXKSQ+I592alk 77BVPxH6g3RJWc+kATfTbD+t5FnXqQx++c36ZWANnIiguwLYrUCexN3494JauMg1sXe0 5DvZaoNr/E/8hovcU3IkHuaAHKS09qIzdYuLY60SqUUTYSuhZRIC/F+2CY2pyesPlLR8 xBJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:mime-version:to:from:subject:date :importance; bh=fxoOIeqELyI66nAe9ViQkJ6CCdQUE4eyPX8v2mOkSgs=; b=VWzqvt0Y6f+TUUEjAzJyZMDbeMft0giarC1vGnLEWHcOsZJDLQrQrQdVMDdTxCJXxF rUKPDcmrd06k2Ob1NElIqwCA9S4Cai7ijo6QZMMALHY3UU/Jwu/2NhXt4udJljlXmqEi Ypf+7tHrtWysBMz/EChr9RfBTVEJPSx7qw+2uJSM/a9yMnALOy2gJhc2XIo6BknigQq4 qlHeI3q+W2haOj2CVOD0zwVq7wR3QlrKl0bjt52Tgv8XaUspbVDpBLTELytHLesce++I KCFuoaWVHaUlkoDhVzdmevNb44MXJUx0VUkuNtLbq8pgtNAcV6KKVt7XtU1RQA07iz+U L7oQ== X-Gm-Message-State: AMke39kFcpujwJi6Z93FHFsDcXRLwKElAM2xgMqGXbmececE0ZG0HPzpMLYIpe4SiRz2Dw== X-Received: by 10.98.42.151 with SMTP id q145mr21724241pfq.175.1489164438643; Fri, 10 Mar 2017 08:47:18 -0800 (PST) Received: from ?IPv6:::ffff:192.168.55.197? ([210.125.84.248]) by smtp.gmail.com with ESMTPSA id b195sm19636798pfb.106.2017.03.10.08.47.17 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 10 Mar 2017 08:47:18 -0800 (PST) Message-ID: <58c2d896.cc1b620a.f8ef7.cc2e@mx.google.com> MIME-Version: 1.0 To: "net@freebsd.org" From: Subject: Suspected broken driver qlxgb for FreeBSD 10.3 Date: Sat, 11 Mar 2017 01:47:18 +0900 Importance: normal X-Priority: 3 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.23 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 10 Mar 2017 16:47:19 -0000 Hello, I have a dual 10Gbps Ethernet LAN Card using QLE3242 and I=E2=80=99m trying= to use it at pfSense based on FreeBSD. However, I=E2=80=99m facing errors and unable to use it. The log is: ql0: qla_hw_send: (nsegs[1, 42, 0x0] > Q8_TX_MAX_SEGMENTS) ql0: qla_dump_buf8: qla_hw_send: wrong pkt 0x2a dump start ql0: 0x00000000: 00 1b 21 2f 1c 1b 2c 27 d7 4e ce e0 08 06 00 01 ql0: 0x00000010: 08 00 06 04 00 02 2c 27 d7 4e ce e0 0a 0a 0a 01 ql0: 0x00000020: 00 1b 21 2f 1c 1b 0a 0a 0a 02 ql0: qla_dump_buf8: qla_hw_send: wrong pkt dump end ql0: qla_hw_send: (nsegs[1, 42, 0x0] > Q8_TX_MAX_SEGMENTS) ql0: qla_dump_buf8: qla_hw_send: wrong pkt 0x2a dump start ql0: 0x00000000: 00 1b 21 2f 1c 1b 2c 27 d7 4e ce e0 08 06 00 01 ql0: 0x00000010: 08 00 06 04 00 02 2c 27 d7 4e ce e0 0a 0a 0a 01 ql0: 0x00000020: 00 1b 21 2f 1c 1b 0a 0a 0a 02 ql0: qla_dump_buf8: qla_hw_send: wrong pkt dump end ql0: qla_hw_send: (nsegs[1, 42, 0x0] > Q8_TX_MAX_SEGMENTS) ql0: qla_dump_buf8: qla_hw_send: wrong pkt 0x2a dump start ql0: 0x00000000: 00 1b 21 2f 1c 1b 2c 27 d7 4e ce e0 08 06 00 01 ql0: 0x00000010: 08 00 06 04 00 02 2c 27 d7 4e ce e0 0a 0a 0a 01 ql0: 0x00000020: 00 1b 21 2f 1c 1b 0a 0a 0a 02 ql0: qla_dump_buf8: qla_hw_send: wrong pkt dump end ql0: qla_hw_send: (nsegs[1, 42, 0x0] > Q8_TX_MAX_SEGMENTS) ql0: qla_dump_buf8: qla_hw_send: wrong pkt 0x2a dump start ql0: 0x00000000: 00 1b 21 2f 1c 1b 2c 27 d7 4e ce e0 08 06 00 01 ql0: 0x00000010: 08 00 06 04 00 02 2c 27 d7 4e ce e0 0a 0a 0a 01 ql0: 0x00000020: 00 1b 21 2f 1c 1b 0a 0a 0a 02 ql0: qla_dump_buf8: qla_hw_send: wrong pkt dump end After searching the Internet, I=E2=80=99m thinking the driver for QLE3242 i= s broken on FreeBSD 10. The following link is from FreeNAS bug tracker. The issue is about Ethernet= card with QLogic 8214 failing at FreeNAS 9.10. https://bugs.freenas.org/issues/14925 The original poster says it was OK when using FreeNAS 9.3, which is based o= n FreeBSD 9.3 but it was broken when using FreeNAS 9.10, which is based on = FreeBSD 10.3. The next link is from FreeBSD forum, also showing similar symptom. The OP t= ries to use HP NC523SFP, the card with QLE3242. https://forums.freebsd.org/threads/52033/ The OP is using the version of pfSense based on FreeBSD 10.1. The next link is from FreeBSD mailing list, also with the same symptom. The= OP also using HP NC523SFP. https://lists.freebsd.org/pipermail/freebsd-net/2014-February/037840.html The reply says the same driver on FreeBSD 9.0 doesn=E2=80=99t show any prob= lem. Mine and those three cases all use qlxgb driver, the driver for FreeBSD for= these chips.=20 And it seems the driver worked before FreeBSD 10.x, but it wasn=E2=80=99t o= n FreeBSD 10.x. Would you help me solve this problem? Sincerely, MJ Kang. Sent from Mail for Windows 10 From owner-freebsd-net@freebsd.org Sat Mar 11 00:29:51 2017 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 54FDDD042FA for ; Sat, 11 Mar 2017 00:29:51 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 39ED71725 for ; Sat, 11 Mar 2017 00:29:51 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id v2B0Tpl4010581 for ; Sat, 11 Mar 2017 00:29:51 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-net@FreeBSD.org Subject: [Bug 217667] arp "moved" log message gives incorrect "from" MAC Date: Sat, 11 Mar 2017 00:29:51 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 11.0-STABLE X-Bugzilla-Keywords: patch X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: linimon@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-net@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: assigned_to keywords Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 11 Mar 2017 00:29:51 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D217667 Mark Linimon changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|freebsd-bugs@FreeBSD.org |freebsd-net@FreeBSD.org Keywords| |patch --=20 You are receiving this mail because: You are the assignee for the bug.= From owner-freebsd-net@freebsd.org Sat Mar 11 00:57:42 2017 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 79D0ED04F3D for ; Sat, 11 Mar 2017 00:57:42 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 5F13E882 for ; Sat, 11 Mar 2017 00:57:42 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id v2B0vfR6076879 for ; Sat, 11 Mar 2017 00:57:42 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-net@FreeBSD.org Subject: [Bug 217637] One TCP connection accepted TWO time Date: Sat, 11 Mar 2017 00:57:41 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 10.3-STABLE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: hiren@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-net@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: cc Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 11 Mar 2017 00:57:42 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D217637 Hiren Panchasara changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tuexen@freebsd.org --- Comment #5 from Hiren Panchasara --- Adding Michael for inputs as he had done some cleanup in this area. What FreeBSD version are you running on both sides? Is it 10,3R as reported= in the bug? Do you mind trying -head to rule out any fixes? Server sends FIN and on the following request sends RST which gets dropped somehow and doesn't reach client. But even after receiving first FIN, client asks for data to which servers reopens the connection (which seems like the real bug), sends data and again sends FIN after that. Now client acks that = FIN and sends its own FIN which server acks but client now doesn't like it. So = it keeps sending FIN which server keeps acking. Also, client and server seem off by 10seconds? --=20 You are receiving this mail because: You are the assignee for the bug.= From owner-freebsd-net@freebsd.org Sat Mar 11 04:58:44 2017 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 2AA75D07191 for ; Sat, 11 Mar 2017 04:58:44 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 191261AE for ; Sat, 11 Mar 2017 04:58:44 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id v2B4wh8X057327 for ; Sat, 11 Mar 2017 04:58:43 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-net@FreeBSD.org Subject: [Bug 217667] arp "moved" log message gives incorrect "from" MAC Date: Sat, 11 Mar 2017 04:58:44 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 11.0-STABLE X-Bugzilla-Keywords: patch X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: commit-hook@freebsd.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-net@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 11 Mar 2017 04:58:44 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D217667 --- Comment #1 from commit-hook@freebsd.org --- A commit references this bug: Author: ae Date: Sat Mar 11 04:57:52 UTC 2017 New revision: 315050 URL: https://svnweb.freebsd.org/changeset/base/315050 Log: Fix the L2 address printed in the "arp: %s moved from %*D" message. In the r292978 struct llentry was changed and the ll_addr field become the pointer. PR: 217667 MFC after: 1 week Changes: head/sys/netinet/if_ether.c --=20 You are receiving this mail because: You are the assignee for the bug.= From owner-freebsd-net@freebsd.org Sat Mar 11 07:55:12 2017 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 8DF58D074A1 for ; Sat, 11 Mar 2017 07:55:12 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 634E9CFF for ; Sat, 11 Mar 2017 07:55:12 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id v2B7t9oO032005 for ; Sat, 11 Mar 2017 07:55:12 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-net@FreeBSD.org Subject: [Bug 213257] Crash in IGB driver with ALTQ Date: Sat, 11 Mar 2017 07:55:09 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 10.3-STABLE X-Bugzilla-Keywords: crash, needs-qa X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: commit-hook@freebsd.org X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-net@FreeBSD.org X-Bugzilla-Flags: mfc-stable9? mfc-stable10? mfc-stable11? X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 11 Mar 2017 07:55:12 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D213257 --- Comment #27 from commit-hook@freebsd.org --- A commit references this bug: Author: loos Date: Sat Mar 11 07:54:05 UTC 2017 New revision: 315060 URL: https://svnweb.freebsd.org/changeset/base/315060 Log: MFC of r314281: Disable the driver managed queue for igb(4) when the legacy transmit interface is used. The legacy API (IGB_LEGACY_TX) is enabled when ALTQ is built into kernel. As noted in altq(9), it is responsibility of the caller to protect this queue against concurrent access and, in the igb case, the interface send queue is protected by tx queue mutex. This obviously cannot protect the driver managed queue against concurrent access from different tx queues and leads to numerous and quite strange panic traces (usually shown as packets disappearing into thin air). Improving the locking to cope with this means serialize all access to this (single) queue and produces no gain, it actually affects the performance quite noticeabily. The driver managed queue is already disabled when an ALTQ queue discipline is set on interface (in altq_enable()), because the driver managed queue can interfere with ALTQ timing (whence the reports that setting an ALTQ queue discipline on interface also fixes the issue). Disabling this additional queue keeps the ability to use if_start() to send packets to individual NIC queues while it simply eliminate the race. This is a direct commit to stable/11 as -head driver does not support ALTQ anymore. PR: 213257 PR: 212413 Discussed with: sbruno Tested by: Konstantin Kormashev Obtained from: pfSense Sponsored by: Rubicon Communications, LLC (Netgate) Changes: _U stable/10/ stable/10/sys/dev/e1000/if_igb.c --=20 You are receiving this mail because: You are the assignee for the bug.= From owner-freebsd-net@freebsd.org Sat Mar 11 07:56:59 2017 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 65A19D0765D for ; Sat, 11 Mar 2017 07:56:59 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 5517BE6A for ; Sat, 11 Mar 2017 07:56:59 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id v2B7uwMC035398 for ; Sat, 11 Mar 2017 07:56:59 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-net@FreeBSD.org Subject: [Bug 213257] Crash in IGB driver with ALTQ Date: Sat, 11 Mar 2017 07:56:58 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 10.3-STABLE X-Bugzilla-Keywords: crash, needs-qa X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: loos@FreeBSD.org X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-net@FreeBSD.org X-Bugzilla-Flags: mfc-stable9- mfc-stable10+ mfc-stable11- X-Bugzilla-Changed-Fields: flagtypes.name Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 11 Mar 2017 07:56:59 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D213257 Luiz Otavio O Souza,+55 (14) 99772-1255 changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|mfc-stable9?, |mfc-stable9-, |mfc-stable10?, |mfc-stable10+, |mfc-stable11? |mfc-stable11- --=20 You are receiving this mail because: You are the assignee for the bug.= From owner-freebsd-net@freebsd.org Sat Mar 11 08:27:31 2017 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 581ADD071DC for ; Sat, 11 Mar 2017 08:27:31 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 47A831EB4 for ; Sat, 11 Mar 2017 08:27:31 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id v2B8RVoH031372 for ; Sat, 11 Mar 2017 08:27:31 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-net@FreeBSD.org Subject: [Bug 217637] One TCP connection accepted TWO time Date: Sat, 11 Mar 2017 08:27:31 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 10.3-STABLE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: tuexen@freebsd.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-net@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 11 Mar 2017 08:27:31 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D217637 --- Comment #6 from Michael Tuexen --- Which OSes are used on the client and on the server side? Both FreeBSD 10.3? --=20 You are receiving this mail because: You are the assignee for the bug.= From owner-freebsd-net@freebsd.org Sat Mar 11 21:23:50 2017 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id B82A8D08A2F for ; Sat, 11 Mar 2017 21:23:50 +0000 (UTC) (envelope-from hoomanfazaeli@gmail.com) Received: from mail-wr0-x235.google.com (mail-wr0-x235.google.com [IPv6:2a00:1450:400c:c0c::235]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 64342F0F for ; Sat, 11 Mar 2017 21:23:50 +0000 (UTC) (envelope-from hoomanfazaeli@gmail.com) Received: by mail-wr0-x235.google.com with SMTP id u108so83111251wrb.3 for ; Sat, 11 Mar 2017 13:23:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=message-id:date:from:user-agent:mime-version:to:subject :content-transfer-encoding; bh=+LC0VXlSfyB7AIS60D6AQ1qGUkFHJbY7W02On6aD+Zg=; b=RCbOdF8Dn1Shj/Awe8K3MnlBOvrtEEeRBAUbnduzTmD3dNM5hfr6XZUI2KJYQy0AZ4 KF35nRGAv3cWduJ/Q7U2wOGiswJ9lmFxJF8GuXaZ9n2CrdJVZPms6nGjF8o5DwPxMl7O wKIxByhbreEwHnnXte2ZGeGtHlqZw/SU0gesas3TgWtWtNIoCFUF4gdlsYaseoGTTlki zwWbJGygqLQ2XpUF5QNUzLKFsToekgM4wmkxJmwDAswVXAY3e6EDVu4Mt1WPVgCSx1Z8 K/VNXT+Mhvi9Gdb4m/qKVTXobTdEs1PwG3zo/GgeKiibey+plBjSAxhcFOEdq38620IN 9SsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to :subject:content-transfer-encoding; bh=+LC0VXlSfyB7AIS60D6AQ1qGUkFHJbY7W02On6aD+Zg=; b=OyxGPsHi56WWBSlDu+wdS+hryQyRQztlarRjqZZeZv8eECklfKSvPpuWANCSrkj4bk KhJf9+rw3qx65vRA0w8/l7o/+Wf73XnTAXbHY2T9sgOahuJP6olgTdsNOZqNdo1ijHhs /ZBLYx6TlFRL9a6bLBX0S6sNSsSCD+UBJLoqK9l6ltNcegEy3boYqU/yk0h9/oGgR19N XJyK7w0LqAE7yiVQGLmSelICXm1GIv8rZ9wLqu31koGifbVXmtbzt7rjSE/UArlFo8VC dx0zoT1q5Hmf1YmPJ9Z4p7q1bS96+TIxUMAeBg/OD1oovIBVxAbuK3R6ZIh0bad0PmLZ 4Pow== X-Gm-Message-State: AMke39nZ4LT5FJuapr6T0IME7LXpx9rPhhw6rVSKw1heLC2FucMoXbnGdt8nypTPntZkTw== X-Received: by 10.223.171.239 with SMTP id s102mr20770652wrc.23.1489267427654; Sat, 11 Mar 2017 13:23:47 -0800 (PST) Received: from [192.168.2.30] ([89.219.198.145]) by smtp.googlemail.com with ESMTPSA id q4sm18689463wrc.35.2017.03.11.13.23.46 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 11 Mar 2017 13:23:47 -0800 (PST) Message-ID: <58C46AE0.7050408@gmail.com> Date: Sun, 12 Mar 2017 00:53:44 +0330 From: Hooman Fazaeli User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/20130215 Thunderbird/17.0.3 MIME-Version: 1.0 To: "freebsd-net@freebsd.org" Subject: ipsec with ipfw Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 11 Mar 2017 21:23:50 -0000 Hi, As you know the ipsec/setkey provide limited syntax to define security policies: only a single subnet/host, protocol number and optional port may be used to specify traffic's source and destination. I was thinking about the idea of using ipfw as the packet selector for ipsec, much like it is used with dummeynet. Something like: ipfw add 100 ipsec 2 tcp from to 80,443,110,139 What do you think? Are you interested in such a feature? Is it worth the effort? What are the implementation challenges? -- Best regards Hooman Fazaeli From owner-freebsd-net@freebsd.org Sat Mar 11 22:16:28 2017 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 08CD7D0884F for ; Sat, 11 Mar 2017 22:16:28 +0000 (UTC) (envelope-from slw@zxy.spb.ru) Received: from zxy.spb.ru (zxy.spb.ru [195.70.199.98]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id C12E2D0F for ; Sat, 11 Mar 2017 22:16:27 +0000 (UTC) (envelope-from slw@zxy.spb.ru) Received: from slw by zxy.spb.ru with local (Exim 4.86 (FreeBSD)) (envelope-from ) id 1cmpJD-0003KO-Aw; Sun, 12 Mar 2017 01:16:19 +0300 Date: Sun, 12 Mar 2017 01:16:19 +0300 From: Slawa Olhovchenkov To: Hooman Fazaeli Cc: "freebsd-net@freebsd.org" Subject: Re: ipsec with ipfw Message-ID: <20170311221619.GU15630@zxy.spb.ru> References: <58C46AE0.7050408@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <58C46AE0.7050408@gmail.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-SA-Exim-Connect-IP: X-SA-Exim-Mail-From: slw@zxy.spb.ru X-SA-Exim-Scanned: No (on zxy.spb.ru); SAEximRunCond expanded to false X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 11 Mar 2017 22:16:28 -0000 On Sun, Mar 12, 2017 at 12:53:44AM +0330, Hooman Fazaeli wrote: > Hi, > > As you know the ipsec/setkey provide limited syntax to define security > policies: only a single subnet/host, protocol number and optional port > may be used to specify traffic's source and destination. > > I was thinking about the idea of using ipfw as the packet selector for ipsec, > much like it is used with dummeynet. Something like: > > ipfw add 100 ipsec 2 tcp from to 80,443,110,139 > > What do you think? Are you interested in such a feature? > Is it worth the effort? What are the implementation challenges? security policies is subject of ike protocol exchange, do you plened to extend this protocol too?