From owner-freebsd-net@freebsd.org  Sun Apr 16 11:11:53 2017
Return-Path: <owner-freebsd-net@freebsd.org>
Delivered-To: freebsd-net@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 34F34D416EE
 for <freebsd-net@mailman.ysv.freebsd.org>;
 Sun, 16 Apr 2017 11:11:53 +0000 (UTC)
 (envelope-from bugzilla-noreply@freebsd.org)
Received: from kenobi.freebsd.org (kenobi.freebsd.org
 [IPv6:2001:1900:2254:206a::16:76])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 107BD82D
 for <freebsd-net@FreeBSD.org>; Sun, 16 Apr 2017 11:11:53 +0000 (UTC)
 (envelope-from bugzilla-noreply@freebsd.org)
Received: from bugs.freebsd.org ([127.0.1.118])
 by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id v3GBBnNb031414
 for <freebsd-net@FreeBSD.org>; Sun, 16 Apr 2017 11:11:52 GMT
 (envelope-from bugzilla-noreply@freebsd.org)
From: bugzilla-noreply@freebsd.org
To: freebsd-net@FreeBSD.org
Subject: [Bug 211219] NIC status does not pass into a state of "no carrier"
 after disconnecting the cable.
Date: Sun, 16 Apr 2017 11:11:49 +0000
X-Bugzilla-Reason: AssignedTo
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: Base System
X-Bugzilla-Component: bin
X-Bugzilla-Version: 10.3-RELEASE
X-Bugzilla-Keywords: IntelNetworking
X-Bugzilla-Severity: Affects Some People
X-Bugzilla-Who: franco@opnsense.org
X-Bugzilla-Status: Closed
X-Bugzilla-Resolution: FIXED
X-Bugzilla-Priority: ---
X-Bugzilla-Assigned-To: freebsd-net@FreeBSD.org
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-211219-2472-4sXW3DkBtS@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-211219-2472@https.bugs.freebsd.org/bugzilla/>
References: <bug-211219-2472@https.bugs.freebsd.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: freebsd-net@freebsd.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-net>,
 <mailto:freebsd-net-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net/>
List-Post: <mailto:freebsd-net@freebsd.org>
List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-net>,
 <mailto:freebsd-net-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 16 Apr 2017 11:11:53 -0000

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D211219

--- Comment #18 from Franco Fichtner <franco@opnsense.org> ---
The second line in the if statement still differs in the way introduced by =
the
original commit causing the regression:

Original Intel driver and requested in this this PR/attached commit:

ims_mask |=3D EM_MSIX_MASK;

Current state on all branches:

ims_mask |=3D adapter->ims;

In our conversations you asked me which of the two lines were needed, becau=
se
the chip documentation wasn't clear.

The testing result for a good result (for two distinct devices I have) was:

if (hw->mac.type =3D=3D e1000_82574) {
    E1000_WRITE_REG(hw, EM_EIAC, adapter->ims);
}=20

The current FreeBSD state was changed to read this:

if (hw->mac.type =3D=3D e1000_82574) {
    E1000_WRITE_REG(hw, EM_EIAC, adapter->ims);
    ims_mask |=3D adapter->ims;
}

Which still differs from the good tested result or the original Intel state.

Either the second line should be dropped or changed to how it reads in the
Intel driver.


Cheers,
Franco

--=20
You are receiving this mail because:
You are the assignee for the bug.=