From owner-svn-src-all@freebsd.org Sun Mar 5 00:16:51 2017 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 39FFBCF9E90 for ; Sun, 5 Mar 2017 00:16:51 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-it0-x22e.google.com (mail-it0-x22e.google.com [IPv6:2607:f8b0:4001:c0b::22e]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 001A215AE for ; Sun, 5 Mar 2017 00:16:50 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-it0-x22e.google.com with SMTP id 203so31987076ith.0 for ; Sat, 04 Mar 2017 16:16:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=ZMYt84Xd/X+M1A9keEW1VKxszrdgRAYN+oEdcestnjw=; b=kZL9TPtvn6/1eVI03dyMXQmpLeyPS5QAHkD7smXJJJwhyXMbSd1hflBTsxvKCxx6tJ 9Zn4uzBOLKvr/6VDdgcympskGh1ZieiBfytv0BNnWHLtRbHSJ6ElfGgnxw1BNJ86tl15 maDSyU8+6j3byuDfIydmumN9eLz5V48sxqY3iOoOfrOMG0J2MjENdeXFCxAdlBq6UWKV WbaUSB9vETujjmakFKniUkWIvYxJvH9fGvbIem982Xrtk72nkHM4NEjzCgrlNWyDbKcL Z9vrHVnMT2kU9J3j9fggGpWWK3s8iC1vp2kEUIMCUA7yhNmgKk3VDxKk80khxw+nK5CM t7dA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=ZMYt84Xd/X+M1A9keEW1VKxszrdgRAYN+oEdcestnjw=; b=Rd8eGbRGjy1/pjIx1ZSMGJVb7h2LhQjgrkMCx/3ITzXeIi+BuJ6bQXUqppq0XpGnPq 6+mVHzpuCbfW8B0zp5lJcUwYSV3E1aNH73hr0RqN6tqOzfQmTmryGiIsDXCqTPcB7g24 0EyAZlhf38jC+gSM7etmtnW/n5GHZbD1Fheh+yrH2BylmQqMwDUXTzSfHFgf1NU1zIDA bTkZRQy53wOqgOOrZGGJ1hrq4tOHYhLYHXYUypwxYMbobRCKWeG3WC/1B5w7SzXZG9EK 1EH+87SMcc/6Sz7W7vAwPMOPHeQI69hdHEmRnscC0NoDXn6kM1V/wydHTLoP8DWi1mxA xXCw== X-Gm-Message-State: AMke39kVYqHKydnVElOvJ3pcSwmyF8qHpwqhagzGfJxFfhlFSRFNVz7UJo/Q53Fq0wfLYh2QJ83L1e7lcH3nqA== X-Received: by 10.36.147.71 with SMTP id y68mr8868469itd.85.1488673010329; Sat, 04 Mar 2017 16:16:50 -0800 (PST) MIME-Version: 1.0 Sender: wlosh@bsdimp.com Received: by 10.79.134.129 with HTTP; Sat, 4 Mar 2017 16:16:49 -0800 (PST) X-Originating-IP: [69.53.245.200] In-Reply-To: <201703042232.v24MW9jt079229@pdx.rh.CN85.dnsmgr.net> References: <201703042232.v24MW9jt079229@pdx.rh.CN85.dnsmgr.net> From: Warner Losh Date: Sat, 4 Mar 2017 17:16:49 -0700 X-Google-Sender-Auth: N-rbKWn82lX7-Cp7z3WVj3pDtc0 Message-ID: Subject: Re: svn commit: r314657 - in head/kerberos5: . lib/libgssapi_krb5 lib/libgssapi_ntlm lib/libgssapi_spnego lib/libhdb lib/libkafs5 lib/libkrb5 libexec/hprop libexec/kpasswdd tools/asn1_compile tools/slc To: rgrimes@freebsd.org Cc: Ngie Cooper , Bryan Drewery , Ngie Cooper , src-committers , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Content-Type: text/plain; charset=UTF-8 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 05 Mar 2017 00:16:51 -0000 On Sat, Mar 4, 2017 at 3:32 PM, Rodney W. Grimes wrote: >> >> > On Mar 4, 2017, at 13:43, Warner Losh wrote: >> > >> >> On Sat, Mar 4, 2017 at 1:25 PM, Bryan Drewery wrote: >> >>> On 3/4/2017 12:20 PM, Rodney W. Grimes wrote: >> >>> -- Start of PGP signed section. >> >>> [ Charset windows-1252 unsupported, converting... ] >> >>>>> On 3/4/2017 7:34 AM, Rodney W. Grimes wrote: >> >>>>> What is ${.CURDIR:H:H} ????? Yes that seems to work but now we are obscuring >> >>>>> ../.. into makefile syntax magic, probably not a grand idea. >> >>>> It just trims off the last directory component. This both reduces >> >>>> namecache lookups, lessens the amount of data in a log, and makes >> >>>> debugging a log simpler by not having a crazy path like: >> >>>> /home/bdrewery/big/git/buildserver/sys/modules/usb/template/../../../dev/usb/template/usb_template.c >> >>>> >> >>>> It's far simpler to understand and work with: >> >>>> /home/bdrewery/big/git/buildserver/sys/dev/usb/template/usb_template.c >> >>>> >> >>>> The only downside is it is slightly more obscure in a Makefile, but once >> >>>> you know what :H is then it's not a problem. This is why SRCTOP is even >> >>>> better than this as it is far more clear than even :H and avoids the >> >>>> ../../ problems. >> >>> Lets do one or the other, but not both ${SRCTOP} and :H:H:H. It appears >> >>> that we now have a mix and mashed up some one way others the other. >> >> >> >> That I can agree with. I would prefer to standardize on SRCTOP as :H is >> >> too obscure without learning about make details. >> > >> > :H is insane in 90% of the cases I've seen it used. Let's roll with >> > SRCTOP everywhere we can. That's safer from directory motion anyway... >> >> Ok, I have 3 votes for SRCTOP, so I'll implement the remaining change using SRCTOP (for usr.bin), and reimplement the previous changes using SRCTOP. > > And that some how over rides the 3 votes for not doing any of these changes? > Slow down please. We dont need a bike shed, but I think we need a clear > target and a consense larger than 3+ 3- and less than a 6 hour wall clock > of discussion. > > It would also be best if it was this change and only this change committed > in very large (preferably about 20) commits. We've had about 200-300 commits in the build system in the past year. There's no real need to slow down. It's a real mess (though a lot less of one thanks to Bryan) and SRCTOP is a definite cleanup. Warner