From owner-svn-src-all@freebsd.org Sun Jun 4 01:18:43 2017 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 30FF0BFCACD for ; Sun, 4 Jun 2017 01:18:43 +0000 (UTC) (envelope-from pfg@FreeBSD.org) Received: from nm28-vm1.bullet.mail.ne1.yahoo.com (nm28-vm1.bullet.mail.ne1.yahoo.com [98.138.91.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id EE53683BC6 for ; Sun, 4 Jun 2017 01:18:42 +0000 (UTC) (envelope-from pfg@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1496538989; bh=r2y3yuq1TEeiGvKtFYXOCvcgXxofVVqzgrjz95ffJbM=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From:Subject; b=ul5cXIe/xW8eBBEjLltAckbQweEC6LCPneOtp9nCq6yNdWTk1n4ZSjFF8Bms4L1eCHATb9yQz08MCg21kPQKXk12/S9R8Zuk9w6ZK8CX4S9RDQ9cf/RUqviAiM/EHvqm1x/stG3UPrEsUP7Kx/7Tk6cKcM9ev1nhDNCrVmF/eg+RpTwVV37PN2QtiG+MWGkQTxXouN//TwwMYqHuKxKfyhlsW+o77o2I1J3a8fOwWK/o24MibSEYrwa7PlzCRucmZZSGsK22/DM1aCM7jGlS9VbFCLfYyS9cD4m1pfDM+mdzufmRCiXJ4HjNHCZUdJTWWRvmYzI0m4QRmXr5zEtMDQ== Received: from [98.138.100.114] by nm28.bullet.mail.ne1.yahoo.com with NNFMP; 04 Jun 2017 01:16:29 -0000 Received: from [98.138.226.63] by tm105.bullet.mail.ne1.yahoo.com with NNFMP; 04 Jun 2017 01:16:29 -0000 Received: from [127.0.0.1] by smtp214.mail.ne1.yahoo.com with NNFMP; 04 Jun 2017 01:16:29 -0000 X-Yahoo-Newman-Id: 759129.98589.bm@smtp214.mail.ne1.yahoo.com X-Yahoo-Newman-Property: ymail-3 X-YMail-OSG: XFvQdqkVM1mK4em8byRNMHnS1tiYP8.VaUMx1e52hyLkEkb lP7n4w5NRW_n3mFneVMA6usCMHHLKoLUJIAFyFpWMB00k8LzOv1jTE83atw5 ouTmtQLxmzpmQxNT.97TJeSfnmWoK4jMpuhoiMF44ijYfMOKNK6rxDAr5t4H O9kjmiSpX_oTv2l9ukqM_eMHjl2Lw68Is6rpHAcTp6n84VVeaCK6i0CGBTye JyS.9ArdjOZLV.9G57bngNI4KzzxJOz5y53V0w1hMTk0uO66q4071OY7I6ys JcVIQQKyeF_5_Ggr1KFI_hLU.VGY0lwBksJM9t.5BQDyJhZ92LNqqLsT3aYk 3r1MGOh.wrOx7dLoGmXtH2qEMpab3W4xF0wL7hEdOsaU1WdakruR4eK3UUk2 xgj.aZtH0whX9oSlK72vk8S4.IMkL_83aCYYYS0GhBdeX6vBuoss.pahSrw8 PFWrqSsjLB5ThUJLmzaprTwvJ6NaOxtcdytW5XW7.9_RcdlXsM6demQJJ5so vFV.2A1OPYXhZ0PnT4rH4QDJwbVJxM_i0jAop2bdA4.Cj X-Yahoo-SMTP: xcjD0guswBAZaPPIbxpWwLcp9Unf Subject: Re: svn commit: r319557 - head/sys/fs/ext2fs To: "Ngie Cooper (yaneurabeya)" , Conrad Meyer Cc: src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org References: <201706032230.v53MUUAB056536@repo.freebsd.org> <25EB123A-EAF7-4ADD-8834-93C2618315B6@gmail.com> From: Pedro Giffuni Organization: FreeBSD Project Message-ID: Date: Sat, 3 Jun 2017 20:16:32 -0500 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: <25EB123A-EAF7-4ADD-8834-93C2618315B6@gmail.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 04 Jun 2017 01:18:43 -0000 On 03/06/2017 17:54, Ngie Cooper (yaneurabeya) wrote: >> On Jun 3, 2017, at 15:30, Conrad Meyer wrote: >> >> Author: cem >> Date: Sat Jun 3 22:30:30 2017 >> New Revision: 319557 >> URL: https://svnweb.freebsd.org/changeset/base/319557 >> >> Log: >> ext2fs(4): Fix a number of broken flag checks >> >> Introduced in r319071. >> >> Reported by: Coverity >> CIDs: 1375847, 1375848, 1375849 >> Sponsored by: Dell EMC Isilon > Did pjg review this? I don't know about pjg, but I wasn't even aware about the Coverity issues. I never added myself to the MAINTAINERS list so it's OK, I will just have the code submitter confirm the fixes. Luckily this is code that has not been MFC'd because I don't consider it bullet-proof and more eyes are always welcome. Pedro.