From owner-freebsd-numerics@freebsd.org Thu Dec 27 22:09:47 2018 Return-Path: Delivered-To: freebsd-numerics@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 0D352142489E for ; Thu, 27 Dec 2018 22:09:47 +0000 (UTC) (envelope-from chmeeedalf@gmail.com) Received: from mail-io1-xd2b.google.com (mail-io1-xd2b.google.com [IPv6:2607:f8b0:4864:20::d2b]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 33B1D8DF59 for ; Thu, 27 Dec 2018 22:09:43 +0000 (UTC) (envelope-from chmeeedalf@gmail.com) Received: by mail-io1-xd2b.google.com with SMTP id a2so3735257ios.10 for ; Thu, 27 Dec 2018 14:09:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:subject:message-id:mime-version; bh=fqp7WI+cTGAS7Hve7ODuw+Mp8U8n6HKQ9BQ3OSBvpl4=; b=trOyWj0D2O83eAITU8KQ9bkN3EMTeHWtHrsXFSw8+VMnkD7qParWczqB9MYqWtgTma MZ6d9hPkdlpF5bxcTlp2PaAD/xrM+hCBBxPwszGIh+JudNsogGRCORPY2EJb+WuEOhPl z9WQHsfktmUeQTn4U4PCPpMsa+soRYLLuwLa1nORHksh+cYy6OniZST/e+cwXCWLNLDN EsdIsi4Q7031bNcrpktAMNWfC0CJrgZYAmK3uyxzzGZHDwEi0C+v3TTp1E+mDi/HMfZD FgzSw4MuQ8e0Tpby6MvE5JqLYb3CH85G+Z6l7XxXqgUq2biETf3jv+X/XnTHpmrrHIC6 WXyg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:subject:message-id:mime-version; bh=fqp7WI+cTGAS7Hve7ODuw+Mp8U8n6HKQ9BQ3OSBvpl4=; b=WWqjpzC2zkk4RYrLU9lqLrKUVZt20DRy12TCWfoyOodVj8k+X0P/LRtGOkBg7gJ6IB 9PMZk59rqB29msDTNt576fRCR2a7j6IF47fsCiY/CLVl32St2nXy212+eAay1l9dd6cj xo0AKa/YutezQuU0X0zR9jdS7K0lmVpTHR71q1vsW30Rr/F1Oo1p2MXNnt1wndXfJKhE k7w7epfSZPKB2KeHEg6VgV8Sj1hYaBZbwz+PGOH/l3kH6Sp2cq562xQyn6MQzCHAf4B1 a9mIFgA/xr/wOF0KDN5I/8O5hnJDZ7r6VsFq7w5w9mf4eMnTrUqAwhM27lrc3E3XyPzk OWSw== X-Gm-Message-State: AJcUukdcFGglzbRrHHy7dmXf7GRCtKrE+nzFocZBh8SRtyPMxDvfDdrw osWkfhDuU3TG7fP6KyptTCrmt5uO X-Google-Smtp-Source: ALg8bN5T4lUhd69UjeBd5XnTd+aa5cPRmxnpzArhSf11wwk9kJESpuy5hDyOd6dnCOoyj23lrcR+KQ== X-Received: by 2002:a6b:b556:: with SMTP id e83mr18270355iof.195.1545948582193; Thu, 27 Dec 2018 14:09:42 -0800 (PST) Received: from ralga.knownspace (173-25-245-129.client.mchsi.com. [173.25.245.129]) by smtp.gmail.com with ESMTPSA id z133sm14309572itb.36.2018.12.27.14.09.41 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 27 Dec 2018 14:09:41 -0800 (PST) Date: Thu, 27 Dec 2018 16:09:37 -0600 From: Justin Hibbits To: freebsd-numerics@freebsd.org Subject: Expose all math *l functions as aliases for the * functions when long double == double Message-ID: <20181227160937.51cfe9a5@ralga.knownspace> X-Mailer: Claws Mail 3.17.2 (GTK+ 2.24.32; powerpc64-portbld-freebsd13.0) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="MP_/Fu/I+MQ6e+w2g.0.QYDYusY" X-Rspamd-Queue-Id: 33B1D8DF59 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20161025 header.b=trOyWj0D; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (mx1.freebsd.org: domain of chmeeedalf@gmail.com designates 2607:f8b0:4864:20::d2b as permitted sender) smtp.mailfrom=chmeeedalf@gmail.com X-Spamd-Result: default: False [-6.25 / 15.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36]; FREEMAIL_FROM(0.00)[gmail.com]; HAS_ATTACHMENT(0.00)[]; TO_DN_NONE(0.00)[]; RCVD_COUNT_THREE(0.00)[3]; DKIM_TRACE(0.00)[gmail.com:+]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; MX_GOOD(-0.01)[cached: alt3.gmail-smtp-in.l.google.com]; NEURAL_HAM_SHORT(-0.98)[-0.980,0]; FROM_EQ_ENVFROM(0.00)[]; IP_SCORE(-2.36)[ip: (-8.38), ipnet: 2607:f8b0::/32(-1.86), asn: 15169(-1.50), country: US(-0.08)]; MIME_TRACE(0.00)[0:+,1:+,2:~]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; DWL_DNSWL_NONE(0.00)[gmail.com.dwl.dnswl.org : 127.0.5.0]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20161025]; FROM_HAS_DN(0.00)[]; MIME_UNKNOWN(0.10)[text/x-patch]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[multipart/mixed,text/plain]; PREVIOUSLY_DELIVERED(0.00)[freebsd-numerics@freebsd.org]; RCPT_COUNT_ONE(0.00)[1]; RCVD_TLS_LAST(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[b.2.d.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0] X-BeenThere: freebsd-numerics@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Discussions of high quality implementation of libm functions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 27 Dec 2018 22:09:47 -0000 --MP_/Fu/I+MQ6e+w2g.0.QYDYusY Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Content-Disposition: inline When building editors/calligra on powerpc64 it failed with undefined references to erfl and erfcl. Some digging it turns out that these functions aren't being exposed as weak symbols in libm on platforms where long double is 64 bits, because LDBL_MANT_DIG is not defined in the files defining these functions. The attached patch fixes that case. It's only been compile-tested for powerpc64, but should have no negative impact on any other platform. - Justin --MP_/Fu/I+MQ6e+w2g.0.QYDYusY Content-Type: text/x-patch Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=msun_ldbl64.diff Index: lib/msun/src/s_cbrt.c =================================================================== --- lib/msun/src/s_cbrt.c (revision 342107) +++ lib/msun/src/s_cbrt.c (working copy) @@ -15,6 +15,7 @@ #include __FBSDID("$FreeBSD$"); +#include #include "math.h" #include "math_private.h" Index: lib/msun/src/s_cproj.c =================================================================== --- lib/msun/src/s_cproj.c (revision 342107) +++ lib/msun/src/s_cproj.c (working copy) @@ -30,6 +30,7 @@ __FBSDID("$FreeBSD$"); #include +#include #include #include "math_private.h" Index: lib/msun/src/s_erf.c =================================================================== --- lib/msun/src/s_erf.c (revision 342107) +++ lib/msun/src/s_erf.c (working copy) @@ -107,7 +107,7 @@ * erfc/erf(NaN) is NaN */ - +#include #include "math.h" #include "math_private.h" --MP_/Fu/I+MQ6e+w2g.0.QYDYusY-- From owner-freebsd-numerics@freebsd.org Thu Dec 27 22:26:26 2018 Return-Path: Delivered-To: freebsd-numerics@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 6BC4F14252FC for ; Thu, 27 Dec 2018 22:26:26 +0000 (UTC) (envelope-from sgk@troutmask.apl.washington.edu) Received: from troutmask.apl.washington.edu (troutmask.apl.washington.edu [128.95.76.21]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "troutmask", Issuer "troutmask" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id E7F5C8EA4E for ; Thu, 27 Dec 2018 22:26:24 +0000 (UTC) (envelope-from sgk@troutmask.apl.washington.edu) Received: from troutmask.apl.washington.edu (localhost [127.0.0.1]) by troutmask.apl.washington.edu (8.15.2/8.15.2) with ESMTPS id wBRMFNfq005207 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Thu, 27 Dec 2018 14:15:23 -0800 (PST) (envelope-from sgk@troutmask.apl.washington.edu) Received: (from sgk@localhost) by troutmask.apl.washington.edu (8.15.2/8.15.2/Submit) id wBRMFNnd005206; Thu, 27 Dec 2018 14:15:23 -0800 (PST) (envelope-from sgk) Date: Thu, 27 Dec 2018 14:15:23 -0800 From: Steve Kargl To: Justin Hibbits Cc: freebsd-numerics@freebsd.org Subject: Re: Expose all math *l functions as aliases for the * functions when long double == double Message-ID: <20181227221523.GA5197@troutmask.apl.washington.edu> Reply-To: sgk@troutmask.apl.washington.edu References: <20181227160937.51cfe9a5@ralga.knownspace> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181227160937.51cfe9a5@ralga.knownspace> User-Agent: Mutt/1.10.1 (2018-07-13) X-Rspamd-Queue-Id: E7F5C8EA4E X-Spamd-Bar: + Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [1.37 / 15.00]; ARC_NA(0.00)[]; HAS_REPLYTO(0.00)[sgk@troutmask.apl.washington.edu]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; NEURAL_SPAM_SHORT(0.93)[0.932,0]; NEURAL_HAM_LONG(-0.45)[-0.447,0]; MIME_GOOD(-0.10)[text/plain]; RCVD_TLS_LAST(0.00)[]; DMARC_NA(0.00)[washington.edu]; AUTH_NA(1.00)[]; REPLYTO_ADDR_EQ_FROM(0.00)[]; RCVD_COUNT_THREE(0.00)[3]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_IN_DNSWL_MED(-0.20)[21.76.95.128.list.dnswl.org : 127.0.11.2]; RCPT_COUNT_TWO(0.00)[2]; MX_GOOD(-0.01)[troutmask.apl.washington.edu]; NEURAL_SPAM_MEDIUM(0.01)[0.005,0]; R_SPF_NA(0.00)[]; FREEMAIL_TO(0.00)[gmail.com]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:73, ipnet:128.95.0.0/16, country:US]; MID_RHS_MATCH_FROM(0.00)[]; IP_SCORE(0.19)[ip: (0.57), ipnet: 128.95.0.0/16(0.29), asn: 73(0.19), country: US(-0.08)] X-BeenThere: freebsd-numerics@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Discussions of high quality implementation of libm functions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 27 Dec 2018 22:26:26 -0000 On Thu, Dec 27, 2018 at 04:09:37PM -0600, Justin Hibbits wrote: > When building editors/calligra on powerpc64 it failed with undefined > references to erfl and erfcl. Some digging it turns out that these > functions aren't being exposed as weak symbols in libm on platforms > where long double is 64 bits, because LDBL_MANT_DIG is not defined in > the files defining these functions. The attached patch fixes that > case. It's only been compile-tested for powerpc64, but should have no > negative impact on any other platform. > > - Justin Looks OK to me. -- Steve From owner-freebsd-numerics@freebsd.org Fri Dec 28 15:00:42 2018 Return-Path: Delivered-To: freebsd-numerics@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 8C1D6143B2F7 for ; Fri, 28 Dec 2018 15:00:42 +0000 (UTC) (envelope-from chmeeedalf@gmail.com) Received: from mail-it1-x133.google.com (mail-it1-x133.google.com [IPv6:2607:f8b0:4864:20::133]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 9BC598DE83 for ; Fri, 28 Dec 2018 15:00:41 +0000 (UTC) (envelope-from chmeeedalf@gmail.com) Received: by mail-it1-x133.google.com with SMTP id h65so27286788ith.3 for ; Fri, 28 Dec 2018 07:00:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=k8aLQi1QGVy561F1K2LCcsPTEMCNJv2jouxXv6m6Ei8=; b=mcwtRSU7isCcsyLm8p/EPcNgX+U+g80rT47JfwmblSyafENU6YnTwNylBE6to4ExG+ V3wPlXr1TTMKAbIrl1SFxLxMupuFFZHZdqD4mOxm3uPd0e8LktTqSxcZzX2ZPar/DVd4 TPyB2Adti7ryeJZimN2ynDLm2Ozt748hVkgu2ejs+zcTUgesj9zOX06RoYyPb3YvZptu J1CHExb+bf0gWqDu2/pU+BZw04Arm47rNxv42Oo5sq2p/719xCWqVVja8Z4u5Aorcr8g Pj9RvT91AnHuz7wjILqRJz+4UVUX10nsprxVQaGL7xglSxsXNtsAeV62BatPeDWQLXuY cBpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=k8aLQi1QGVy561F1K2LCcsPTEMCNJv2jouxXv6m6Ei8=; b=uIIe/lOw791GKk0DV485l/t9Dh59AhKhVWJrKe4qQZkGltbpg1STLrgY8BjvSe48vB CeTAytn8h27lsnyt2yAAw1ZsqgS21PGkH45Mqc9sk0PhvXkuFI6kidgcZ/hhxO0zciu3 WksIFmjyKJa9CoNHppGyVaktPg1VdzCLG9Hrh8pBYy4tIC68bh/iCnyaboik5i97Pe5v B5o3MJhEBDZRR7NrL14bgvNRbKoJwjrSwsMMdXOtTlXhK9ylk69pImUAZ1G0N8oElSrh 55c2sn7+Pg5gB2YDAoBmcVx0xNaFJeFT40f9WZnEse+XJgpFpcqmzjsfF5H41mll/2O9 Hbvg== X-Gm-Message-State: AJcUukfhRT0+AAzr617JgCP3i95y5b2y1nQ6eg5en72vtXucjpa4gbYF fmBQZPNbC3hjdn3rW5ivgWY7UcdM X-Google-Smtp-Source: ALg8bN4Xd2newiEncdmQNAXj0r8vwhdoV/GqWT2KtWenwz7eO3mqjgp10s1SdWViYqNees4g3BjKPA== X-Received: by 2002:a24:6201:: with SMTP id d1mr15378354itc.67.1546009240943; Fri, 28 Dec 2018 07:00:40 -0800 (PST) Received: from ralga.knownspace (173-25-245-129.client.mchsi.com. [173.25.245.129]) by smtp.gmail.com with ESMTPSA id c25sm18302394ioa.86.2018.12.28.07.00.40 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 28 Dec 2018 07:00:40 -0800 (PST) Date: Fri, 28 Dec 2018 09:00:36 -0600 From: Justin Hibbits To: Steve Kargl Cc: freebsd-numerics@freebsd.org Subject: Re: Expose all math *l functions as aliases for the * functions when long double == double Message-ID: <20181228090036.3ce73ee5@ralga.knownspace> In-Reply-To: <20181227221523.GA5197@troutmask.apl.washington.edu> References: <20181227160937.51cfe9a5@ralga.knownspace> <20181227221523.GA5197@troutmask.apl.washington.edu> X-Mailer: Claws Mail 3.17.2 (GTK+ 2.24.32; powerpc64-portbld-freebsd13.0) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 9BC598DE83 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20161025 header.b=mcwtRSU7; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (mx1.freebsd.org: domain of chmeeedalf@gmail.com designates 2607:f8b0:4864:20::133 as permitted sender) smtp.mailfrom=chmeeedalf@gmail.com X-Spamd-Result: default: False [-6.41 / 15.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36]; FREEMAIL_FROM(0.00)[gmail.com]; RCVD_COUNT_THREE(0.00)[3]; DKIM_TRACE(0.00)[gmail.com:+]; RCPT_COUNT_TWO(0.00)[2]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; MX_GOOD(-0.01)[cached: alt3.gmail-smtp-in.l.google.com]; NEURAL_HAM_SHORT(-0.99)[-0.994,0]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; RCVD_TLS_LAST(0.00)[]; DWL_DNSWL_NONE(0.00)[gmail.com.dwl.dnswl.org : 127.0.5.0]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20161025]; FROM_HAS_DN(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[text/plain]; PREVIOUSLY_DELIVERED(0.00)[freebsd-numerics@freebsd.org]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[3.3.1.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; IP_SCORE(-2.40)[ip: (-8.53), ipnet: 2607:f8b0::/32(-1.88), asn: 15169(-1.51), country: US(-0.08)] X-BeenThere: freebsd-numerics@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Discussions of high quality implementation of libm functions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 28 Dec 2018 15:00:42 -0000 On Thu, 27 Dec 2018 14:15:23 -0800 Steve Kargl wrote: > On Thu, Dec 27, 2018 at 04:09:37PM -0600, Justin Hibbits wrote: > > When building editors/calligra on powerpc64 it failed with undefined > > references to erfl and erfcl. Some digging it turns out that these > > functions aren't being exposed as weak symbols in libm on platforms > > where long double is 64 bits, because LDBL_MANT_DIG is not defined > > in the files defining these functions. The attached patch fixes > > that case. It's only been compile-tested for powerpc64, but should > > have no negative impact on any other platform. > > > > - Justin > > Looks OK to me. > Thanks Steve. I figured there would be no issue, but since this is listed in MAINTAINERS, better to avoid a possibility of post-commit backlash. - Justin From owner-freebsd-numerics@freebsd.org Fri Dec 28 18:21:05 2018 Return-Path: Delivered-To: freebsd-numerics@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id C18BF141E24A for ; Fri, 28 Dec 2018 18:21:05 +0000 (UTC) (envelope-from sgk@troutmask.apl.washington.edu) Received: from troutmask.apl.washington.edu (troutmask.apl.washington.edu [128.95.76.21]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "troutmask", Issuer "troutmask" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 185B394ABC for ; Fri, 28 Dec 2018 18:21:04 +0000 (UTC) (envelope-from sgk@troutmask.apl.washington.edu) Received: from troutmask.apl.washington.edu (localhost [127.0.0.1]) by troutmask.apl.washington.edu (8.15.2/8.15.2) with ESMTPS id wBSIL1GI026051 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Fri, 28 Dec 2018 10:21:01 -0800 (PST) (envelope-from sgk@troutmask.apl.washington.edu) Received: (from sgk@localhost) by troutmask.apl.washington.edu (8.15.2/8.15.2/Submit) id wBSIL1SX026050; Fri, 28 Dec 2018 10:21:01 -0800 (PST) (envelope-from sgk) Date: Fri, 28 Dec 2018 10:21:01 -0800 From: Steve Kargl To: Justin Hibbits Cc: freebsd-numerics@freebsd.org Subject: Re: Expose all math *l functions as aliases for the * functions when long double == double Message-ID: <20181228182101.GA26033@troutmask.apl.washington.edu> Reply-To: sgk@troutmask.apl.washington.edu References: <20181227160937.51cfe9a5@ralga.knownspace> <20181227221523.GA5197@troutmask.apl.washington.edu> <20181228090036.3ce73ee5@ralga.knownspace> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181228090036.3ce73ee5@ralga.knownspace> User-Agent: Mutt/1.10.1 (2018-07-13) X-Rspamd-Queue-Id: 185B394ABC X-Spamd-Bar: + Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [1.12 / 15.00]; ARC_NA(0.00)[]; HAS_REPLYTO(0.00)[sgk@troutmask.apl.washington.edu]; NEURAL_HAM_MEDIUM(-0.20)[-0.203,0]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; NEURAL_SPAM_SHORT(0.89)[0.894,0]; NEURAL_HAM_LONG(-0.45)[-0.452,0]; MIME_GOOD(-0.10)[text/plain]; RCVD_TLS_LAST(0.00)[]; DMARC_NA(0.00)[washington.edu]; AUTH_NA(1.00)[]; REPLYTO_ADDR_EQ_FROM(0.00)[]; RCVD_COUNT_THREE(0.00)[3]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_IN_DNSWL_MED(-0.20)[21.76.95.128.list.dnswl.org : 127.0.11.2]; MX_GOOD(-0.01)[cached: troutmask.apl.washington.edu]; RCPT_COUNT_TWO(0.00)[2]; R_SPF_NA(0.00)[]; FREEMAIL_TO(0.00)[gmail.com]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:73, ipnet:128.95.0.0/16, country:US]; MID_RHS_MATCH_FROM(0.00)[]; IP_SCORE(0.19)[ip: (0.54), ipnet: 128.95.0.0/16(0.28), asn: 73(0.19), country: US(-0.08)] X-BeenThere: freebsd-numerics@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Discussions of high quality implementation of libm functions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 28 Dec 2018 18:21:05 -0000 On Fri, Dec 28, 2018 at 09:00:36AM -0600, Justin Hibbits wrote: > On Thu, 27 Dec 2018 14:15:23 -0800 > Steve Kargl wrote: > > > On Thu, Dec 27, 2018 at 04:09:37PM -0600, Justin Hibbits wrote: > > > When building editors/calligra on powerpc64 it failed with undefined > > > references to erfl and erfcl. Some digging it turns out that these > > > functions aren't being exposed as weak symbols in libm on platforms > > > where long double is 64 bits, because LDBL_MANT_DIG is not defined > > > in the files defining these functions. The attached patch fixes > > > that case. It's only been compile-tested for powerpc64, but should > > > have no negative impact on any other platform. > > > > > > - Justin > > > > Looks OK to me. > > > > Thanks Steve. I figured there would be no issue, but since this is > listed in MAINTAINERS, better to avoid a possibility of post-commit > backlash. > I'm actually surprised that it took 7 years, 9 months to discover the issue with cbrtl() and 4 years, 5 months with erfl(). -- Steve