Date: Sun, 17 Jun 2018 12:54:03 +0000 From: bugzilla-noreply@freebsd.org To: pf@FreeBSD.org Subject: [Bug 226850] [pf] Matching but failed rules block without return Message-ID: <bug-226850-16861-uzTxFJyTu0@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-226850-16861@https.bugs.freebsd.org/bugzilla/> References: <bug-226850-16861@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D226850 --- Comment #15 from Kristof Provost <kp@freebsd.org> --- (In reply to vegeta from comment #14) Thanks for the patch. I think it looks good, but I've got one question. I see that you removed the (r->rule_flag & PFRULE_RETURNRST) || (r->rule_fl= ag & PFRULE_RETURN)) condition from the IPPROTO_TCP case. I think that might res= ult in a subtle behaviour change for rules which have PFRULE_RETURNICMP set (but not one of the other returns). (I.e. it'd return a TCP RST, where it didn't= use to do so. Am I missing something, or should those checks be kept? --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-226850-16861-uzTxFJyTu0>