Date: Wed, 31 Oct 2018 14:11:58 +0000 From: "Bjoern A. Zeeb" <bzeeb-lists@lists.zabbadoz.net> To: freebsd-transport@freebsd.org Cc: "Hackers freeBSD" <freebsd-hackers@freebsd.org> Subject: Re: TCP RTT estimate for connections not using timestamps Message-ID: <FE43FFD6-FFB5-4BE0-9B58-D63AC73E1BA1@lists.zabbadoz.net> In-Reply-To: <CALX0vxCLYdrVyVTdwdh_K1RjYp6VW-0uBvFk5arRiZ5xMKV9QQ@mail.gmail.com> References: <CALX0vxCLYdrVyVTdwdh_K1RjYp6VW-0uBvFk5arRiZ5xMKV9QQ@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 31 Oct 2018, at 14:04, Jacques Fourie wrote: Copying to transport@ please respect Reply-To to there. > Hi, > > > While testing with traffic generators that don’t enable the TCP timestamp > option I noticed a couple of cases where tcp_xmit_timer() was called with a > 0 value for rtt with the current smoothed rtt (t_srtt) non zero. This leads > to a left shift of -1 which is undefined. Looking at the code for the case > where timestamps are enabled I see that tcp_xmit_timer() is always called > with TCP_TS_TO_TICKS(t) + 1 for the rtt. Do we need a +1 in the non > timestamp case as well? > > > Thanks, > > Jacques > _______________________________________________ > freebsd-hackers@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/freebsd-hackers > To unsubscribe, send any mail to "freebsd-hackers-unsubscribe@freebsd.org"
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?FE43FFD6-FFB5-4BE0-9B58-D63AC73E1BA1>