From owner-freebsd-uboot@freebsd.org Mon Aug 13 12:56:15 2018 Return-Path: Delivered-To: freebsd-uboot@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 9B27E1071C77 for ; Mon, 13 Aug 2018 12:56:15 +0000 (UTC) (envelope-from jmg@gold.funkthat.com) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id 3BCDC77FD4 for ; Mon, 13 Aug 2018 12:56:15 +0000 (UTC) (envelope-from jmg@gold.funkthat.com) Received: by mailman.ysv.freebsd.org (Postfix) id F1A0C1071C76; Mon, 13 Aug 2018 12:56:14 +0000 (UTC) Delivered-To: uboot@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id E04521071C75 for ; Mon, 13 Aug 2018 12:56:14 +0000 (UTC) (envelope-from jmg@gold.funkthat.com) Received: from gold.funkthat.com (gate2.funkthat.com [208.87.223.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "gate2.funkthat.com", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 6DB9877FD2 for ; Mon, 13 Aug 2018 12:56:14 +0000 (UTC) (envelope-from jmg@gold.funkthat.com) Received: from gold.funkthat.com (localhost [127.0.0.1]) by gold.funkthat.com (8.15.2/8.15.2) with ESMTPS id w7DCuBRJ087882 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO) for ; Mon, 13 Aug 2018 05:56:12 -0700 (PDT) (envelope-from jmg@gold.funkthat.com) Received: (from jmg@localhost) by gold.funkthat.com (8.15.2/8.15.2/Submit) id w7DCuBTJ087881 for uboot@FreeBSD.org; Mon, 13 Aug 2018 05:56:11 -0700 (PDT) (envelope-from jmg) Date: Mon, 13 Aug 2018 05:56:11 -0700 From: John-Mark Gurney To: uboot@FreeBSD.org Subject: u-boot-master slight mismatch in Makefile... Message-ID: <20180813125611.GJ97145@funkthat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Operating-System: FreeBSD 11.0-RELEASE-p7 amd64 X-PGP-Fingerprint: D87A 235F FB71 1F3F 55B7 ED9B D5FF 5A51 C0AC 3D65 X-Files: The truth is out there X-URL: https://www.funkthat.com/ X-Resume: https://www.funkthat.com/~jmg/resume.html X-TipJar: bitcoin:13Qmb6AeTgQecazTWph4XasEsP7nGRbAPE X-to-the-FBI-CIA-and-NSA: HI! HOW YA DOIN? can i haz chizburger? User-Agent: Mutt/1.6.1 (2016-04-27) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.4.3 (gold.funkthat.com [127.0.0.1]); Mon, 13 Aug 2018 05:56:12 -0700 (PDT) X-Mailman-Approved-At: Mon, 13 Aug 2018 13:00:51 +0000 X-BeenThere: freebsd-uboot@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: Discussions about the use of uboot with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 Aug 2018 12:56:15 -0000 In the Makefile for u-boot-master: 63 # Overrides for ALLWINNER family 64 UBOOT_PLIST_ALLWINNER=u-boot-sunxi-with-spl.bin 65 UBOOT_METADATA_ALLWINNER_FILES= ${UBOOT_PLIST_ALLWINNER} 66 UBOOT_METADATA_ALLWINNER_METHOD= raw 67 UBOOT_METADATA_ALLWINNER_RAW_OFFSET= 8 68 UBOOT_METADATA_ALLWINNER_RAW_BS= 1k 69 70 # Overrides for ALLWINNER64 family 71 UBOOT_PLIST_ALLWINNER64=u-boot-sunxi-with-spl.bin 72 UBOOT_ARCH_ALLWINNER64=aarch64 73 UBOOT_METADATA_ALLWINNER64_FILES= ${UBOOT_PLIST_ALLWINNER} This last line should probably be: 73 UBOOT_METADATA_ALLWINNER64_FILES= ${UBOOT_PLIST_ALLWINNER64} and to make the change cascading since 71 and 64 are the same: 71 UBOOT_PLIST_ALLWINNER64=${UBOOT_PLIST_ALLWINNER} These changes won't change the behavior, but prevent POLA when someone changes UBOOT_PLIST_ALLWINNER64 and nothing changes... -- John-Mark Gurney Voice: +1 415 225 5579 "All that I will do, has been done, All that I have, has not." From owner-freebsd-uboot@freebsd.org Wed Aug 15 15:00:21 2018 Return-Path: Delivered-To: freebsd-uboot@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id E50BE1058D4A for ; Wed, 15 Aug 2018 15:00:20 +0000 (UTC) (envelope-from manu@bidouilliste.com) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id 83B7591186 for ; Wed, 15 Aug 2018 15:00:20 +0000 (UTC) (envelope-from manu@bidouilliste.com) Received: by mailman.ysv.freebsd.org (Postfix) id 4598B1058D49; Wed, 15 Aug 2018 15:00:20 +0000 (UTC) Delivered-To: uboot@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 342881058D47 for ; Wed, 15 Aug 2018 15:00:20 +0000 (UTC) (envelope-from manu@bidouilliste.com) Received: from mail.blih.net (mail.blih.net [212.83.177.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mail.blih.net", Issuer "mail.blih.net" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 9DAA391183 for ; Wed, 15 Aug 2018 15:00:19 +0000 (UTC) (envelope-from manu@bidouilliste.com) Received: from mail.blih.net (mail.blih.net [212.83.177.182]) by mail.blih.net (OpenSMTPD) with ESMTP id 505c47f0; Wed, 15 Aug 2018 17:00:17 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=bidouilliste.com; h=date :from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-type:content-transfer-encoding; s=mail; bh=crKTM4KkDlw19Xd33aYdutPOV78=; b=ImZ2DXbhvdO2SK9aZ62aVkkScBIV iml8yaBsS4lR7G98xGuq16WqLuz0uEeHy0DlkRq9MQJ4AFDEAroAshUAt55H3wka 3yhwfhPQ27lxmROqealy0C7UIj9x7frWx414CsKU7W+IobM89/hqZykvdTWGotJF wsPj0yai/tvi/JU= DomainKey-Signature: a=rsa-sha1; c=nofws; d=bidouilliste.com; h=date :from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-type:content-transfer-encoding; q=dns; s= mail; b=Qk2+865+xO6L5tFNXEw6+OsKoHPTleEJmCG/H+dX/gyc0PMkJFkv6gQ+ uBCUhXqeNmH/4TYtchE7afkoUSSJCawO7x3A5vENq1XaN+pgNByJrWx/rRDLXGgA Q1g3NfM/dkI4kCljbKaetXthj2PKgexEzZfPOhcWvX7lUv5NdIM= Received: from knuckles.blih.net (global-5-13.nat-1.net.cam.ac.uk [131.111.5.13]) by mail.blih.net (OpenSMTPD) with ESMTPSA id ab6f2fb1 TLS version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO; Wed, 15 Aug 2018 17:00:14 +0200 (CEST) Date: Wed, 15 Aug 2018 17:00:13 +0200 From: Emmanuel Vadot To: John-Mark Gurney Cc: uboot@FreeBSD.org Subject: Re: u-boot-master slight mismatch in Makefile... Message-Id: <20180815170013.a299dff7583871835ddc5651@bidouilliste.com> In-Reply-To: <20180813125611.GJ97145@funkthat.com> References: <20180813125611.GJ97145@funkthat.com> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.32; amd64-portbld-freebsd12.0) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: freebsd-uboot@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: Discussions about the use of uboot with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Aug 2018 15:00:21 -0000 On Mon, 13 Aug 2018 05:56:11 -0700 John-Mark Gurney wrote: > In the Makefile for u-boot-master: > 63 # Overrides for ALLWINNER family > 64 UBOOT_PLIST_ALLWINNER=u-boot-sunxi-with-spl.bin > 65 UBOOT_METADATA_ALLWINNER_FILES= ${UBOOT_PLIST_ALLWINNER} > 66 UBOOT_METADATA_ALLWINNER_METHOD= raw > 67 UBOOT_METADATA_ALLWINNER_RAW_OFFSET= 8 > 68 UBOOT_METADATA_ALLWINNER_RAW_BS= 1k > 69 > 70 # Overrides for ALLWINNER64 family > 71 UBOOT_PLIST_ALLWINNER64=u-boot-sunxi-with-spl.bin > 72 UBOOT_ARCH_ALLWINNER64=aarch64 > 73 UBOOT_METADATA_ALLWINNER64_FILES= ${UBOOT_PLIST_ALLWINNER} > > This last line should probably be: > 73 UBOOT_METADATA_ALLWINNER64_FILES= ${UBOOT_PLIST_ALLWINNER64} > > and to make the change cascading since 71 and 64 are the same: > 71 UBOOT_PLIST_ALLWINNER64=${UBOOT_PLIST_ALLWINNER} > > These changes won't change the behavior, but prevent POLA when someone > changes UBOOT_PLIST_ALLWINNER64 and nothing changes... > > -- > John-Mark Gurney Voice: +1 415 225 5579 > > "All that I will do, has been done, All that I have, has not." > _______________________________________________ > freebsd-uboot@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/freebsd-uboot > To unsubscribe, send any mail to "freebsd-uboot-unsubscribe@freebsd.org" Thanks, Fixed in r477232. -- Emmanuel Vadot