Date: Mon, 18 Jun 2018 18:11:00 +0530 From: Pratyush Yadav <pratyush@freebsd.org> To: FreeBSD-Xen <freebsd-xen@freebsd.org> Cc: =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= <royger@freebsd.org> Subject: gnttab_end_foreign_access_ref() leaking grant entries? Message-ID: <CA%2BX=3TKXTo6OjKXyhYwCBT=o5C_tXkuNf9OTQTcZLEW_gr0z%2BQ@mail.gmail.com>
next in thread | raw e-mail | index | archive | help
Hi everyone, I was looking at gnttab_end_foreign_access_ref() and I notice that while gnttab_end_foreign_access_ref() ends the foreign access, it does not free the grant reference. gnttab_end_foreign_access() free the reference by calling put_free_entry(ref). gnttab_end_foreign_access_references() also frees the grant entries. Shouldn't gnttab_end_foreign_access_ref() also free the grant entry? It is an inconsistency at best and a bug at worst. Is it ok if I submit a patch that calls put_free_entry(ref) in gnttab_end_foreign_access_ref()? -- Regards, Pratyush Yadav
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CA%2BX=3TKXTo6OjKXyhYwCBT=o5C_tXkuNf9OTQTcZLEW_gr0z%2BQ>