From owner-freebsd-rc@freebsd.org Sun Aug 11 21:01:11 2019 Return-Path: Delivered-To: freebsd-rc@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id C0AB4C2163 for ; Sun, 11 Aug 2019 21:01:11 +0000 (UTC) (envelope-from bugzilla-noreply@FreeBSD.org) Received: from mailman.nyi.freebsd.org (mailman.nyi.freebsd.org [IPv6:2610:1c1:1:606c::50:13]) by mx1.freebsd.org (Postfix) with ESMTP id 466BGb4Yytz4N4N for ; Sun, 11 Aug 2019 21:01:11 +0000 (UTC) (envelope-from bugzilla-noreply@FreeBSD.org) Received: by mailman.nyi.freebsd.org (Postfix) id 9A598C215F; Sun, 11 Aug 2019 21:01:11 +0000 (UTC) Delivered-To: rc@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 9A22AC215C for ; Sun, 11 Aug 2019 21:01:11 +0000 (UTC) (envelope-from bugzilla-noreply@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 466BGb3X33z4N4H for ; Sun, 11 Aug 2019 21:01:11 +0000 (UTC) (envelope-from bugzilla-noreply@FreeBSD.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4C7F01C04D for ; Sun, 11 Aug 2019 21:01:11 +0000 (UTC) (envelope-from bugzilla-noreply@FreeBSD.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id x7BL1BD0060965 for ; Sun, 11 Aug 2019 21:01:11 GMT (envelope-from bugzilla-noreply@FreeBSD.org) Received: (from bugzilla@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id x7BL1Bx7060961 for rc@FreeBSD.org; Sun, 11 Aug 2019 21:01:11 GMT (envelope-from bugzilla-noreply@FreeBSD.org) Message-Id: <201908112101.x7BL1Bx7060961@kenobi.freebsd.org> X-Authentication-Warning: kenobi.freebsd.org: bugzilla set sender to bugzilla-noreply@FreeBSD.org using -f From: bugzilla-noreply@FreeBSD.org To: rc@FreeBSD.org Subject: Problem reports for rc@FreeBSD.org that need special attention Date: Sun, 11 Aug 2019 21:01:11 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 11 Aug 2019 21:01:11 -0000 To view an individual PR, use: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=(Bug Id). The following is a listing of current problems submitted by FreeBSD users, which need special attention. These represent problem reports covering all versions including experimental development code and obsolete releases. Status | Bug Id | Description ------------+-----------+--------------------------------------------------- Open | 178818 | gmirror savecore support / gmirror(8) says to use Open | 235122 | rc.subr limits call breaks non-root usage 2 problems total for which you should take action. From owner-freebsd-rc@freebsd.org Mon Aug 12 07:46:35 2019 Return-Path: Delivered-To: freebsd-rc@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 952CDA850E; Mon, 12 Aug 2019 07:46:35 +0000 (UTC) (envelope-from agapon@gmail.com) Received: from mail-pl1-f193.google.com (mail-pl1-f193.google.com [209.85.214.193]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 466SbG4hL7z3x6w; Mon, 12 Aug 2019 07:46:34 +0000 (UTC) (envelope-from agapon@gmail.com) Received: by mail-pl1-f193.google.com with SMTP id c2so47540599plz.13; Mon, 12 Aug 2019 00:46:34 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:openpgp:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=bfIabdTHs8nmQNWDc3vNesAa9dnnuRt6RxNCllJF4y4=; b=uO9yfDK65T6BwyKbPXNUtYwhPL0NmUIA8CAJSyGVTTJDdv6PUTw7A3KTObexrJxuZZ hcdAYRtPDGCxFG9dTOIh6mO7SdWHS7uiSiMhJjV8k5W5dmCLXOTQ+xAIcdzEynvbFfFN qXc5gxvelStGnWUoX8v+gfjUDfrboST/w4jJZNVxP1nCzL7JmnmiR6V7dPE9Vr/yTRHZ lNX1LYbsLunTRgcq93PLkHaR1uVB2DSFELcnDAnjluWD6xC+JCxWvffrHQzJMOOFhv8M WsnOsxRxpTT6BW4ga13QI1dKPS6S4SgfFjeUU+8C6ZpbllW3wjyBiqJ67YHI8gCzAYHx oK3Q== X-Gm-Message-State: APjAAAUQv4CHDVrfCs+0ZMB55soaXWZKdV/D0ouYKpoUjwfj7kYTp1Ya JvbuYIbIGKaF+nIwxgk1P28iegai X-Google-Smtp-Source: APXvYqwwQMjE/V4jUGII6Rc+qEjLcYCtQB7WWCSjqcZ/AL/A/fhYKS5oFtHXYCN9iS738l9J3lnM3g== X-Received: by 2002:a17:902:bb81:: with SMTP id m1mr32098809pls.125.1565595992458; Mon, 12 Aug 2019 00:46:32 -0700 (PDT) Received: from [192.168.1.36] (broadband-82-140-206-197.atc.tvcom.ru. [82.140.206.197]) by smtp.googlemail.com with ESMTPSA id dw7sm11628532pjb.21.2019.08.12.00.46.29 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 12 Aug 2019 00:46:31 -0700 (PDT) Subject: Re: rc script: manual stop vs system shutdown To: Ian Lepore , Warner Losh , "Rodney W. Grimes" Cc: FreeBSD Current , freebsd-rc@freebsd.org References: <2e50fb67-8a19-412b-19d2-14f5f20b61f8@FreeBSD.org> <201908011553.x71FrTCd060252@gndrsh.dnsmgr.net> From: Andriy Gapon Openpgp: preference=signencrypt Message-ID: <91d1a853-c449-481a-b001-7c1f54e28fdd@FreeBSD.org> Date: Mon, 12 Aug 2019 10:46:29 +0300 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 466SbG4hL7z3x6w X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of agapon@gmail.com designates 209.85.214.193 as permitted sender) smtp.mailfrom=agapon@gmail.com X-Spamd-Result: default: False [-4.14 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip4:209.85.128.0/17]; RCVD_TLS_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[FreeBSD.org]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; RWL_MAILSPIKE_GOOD(0.00)[193.214.85.209.rep.mailspike.net : 127.0.0.18]; RCPT_COUNT_FIVE(0.00)[5]; RCVD_COUNT_THREE(0.00)[3]; TO_MATCH_ENVRCPT_SOME(0.00)[]; NEURAL_HAM_SHORT(-0.97)[-0.972,0]; RCVD_IN_DNSWL_NONE(0.00)[193.214.85.209.list.dnswl.org : 127.0.5.0]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; IP_SCORE(-1.16)[ipnet: 209.85.128.0/17(-3.38), asn: 15169(-2.39), country: US(-0.05)]; FORGED_SENDER(0.30)[avg@FreeBSD.org,agapon@gmail.com]; RECEIVED_SPAMHAUS_PBL(0.00)[197.206.140.82.khpj7ygk5idzvmvt5x4ziurxhy.zen.dq.spamhaus.net : 127.0.0.11]; MIME_TRACE(0.00)[0:+]; R_DKIM_NA(0.00)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; FROM_NEQ_ENVFROM(0.00)[avg@FreeBSD.org,agapon@gmail.com] X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Aug 2019 07:46:35 -0000 On 01/08/2019 22:51, Ian Lepore wrote: > On Thu, 2019-08-01 at 21:14 +0300, Andriy Gapon wrote: >> On 01/08/2019 19:12, Warner Losh wrote: >>> >>> >>> On Thu, Aug 1, 2019, 10:53 AM Rodney W. Grimes >>> > >>> wrote: >>> >>> > >>> > Is it possible in an rc script to distinguish between a manual stop >>> > (e.g., service foo stop) and a stop during a system shutdown (via >>> > rc.shutdown) ? >>> > Are there any marker variables for that? >>> > Or something in the global system state? >>> >>> Not that I can think of, but I like this idea, >>> I am sure that use cases exist. >>> >>> >>> What is the use case that needs to disambiguate the two cases... >> >> I have one use case in mind and it's a truly special case. >> I want rc.d/watchdogd to gracefully stop watchdogd and to disable the >> watchdog timer when the stop action is requested manually. And I want >> it to stop watchdogd and set the watchdog timer to a special shutdown >> timeout during the shutdown. If the special timeout is configured, of >> course. >> > > The shutdown timeout is already supported: you just set '-x ' > in watchdogd_flags in rc.conf; no changes to the rc.d script needed. > > I think probably you don't even need the first part of what you want. > The -x arg covers you in the reboot case; most people probably won't > use it. But if you are using it, and you want to truly kill the dog, > you would just do "watchdog -t 0" after "service watchdogd stop". If > you really felt the need to cover that with a single service command, > then how about using "service watchdogd cancel" where the cancel verb > does the -t 0 after killing the daemon? I guess that there is more than one way to achieve what I want or something similar to that. Rather than "expend words" on a theoretical discussion, I decided to do this: https://reviews.freebsd.org/D21221 However, I am still open to the discussion and suggestions. One thing that I would prefer, though, is to make the watchdogd service as smart as possible -- but not smarter :-) -- that is, I would prefer to do without adding any new command verbs to it. -- Andriy Gapon From owner-freebsd-rc@freebsd.org Mon Aug 12 10:46:07 2019 Return-Path: Delivered-To: freebsd-rc@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 759E6ADEA3; Mon, 12 Aug 2019 10:46:07 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 466XZR0yY1z48gv; Mon, 12 Aug 2019 10:46:06 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from tom.home (kib@localhost [127.0.0.1]) by kib.kiev.ua (8.15.2/8.15.2) with ESMTPS id x7CAjoGY051464 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Mon, 12 Aug 2019 13:45:54 +0300 (EEST) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.10.3 kib.kiev.ua x7CAjoGY051464 Received: (from kostik@localhost) by tom.home (8.15.2/8.15.2/Submit) id x7CAjo7W051463; Mon, 12 Aug 2019 13:45:50 +0300 (EEST) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Mon, 12 Aug 2019 13:45:50 +0300 From: Konstantin Belousov To: Andriy Gapon Cc: Ian Lepore , Warner Losh , "Rodney W. Grimes" , FreeBSD Current , freebsd-rc@freebsd.org Subject: Re: rc script: manual stop vs system shutdown Message-ID: <20190812104550.GA2738@kib.kiev.ua> References: <2e50fb67-8a19-412b-19d2-14f5f20b61f8@FreeBSD.org> <201908011553.x71FrTCd060252@gndrsh.dnsmgr.net> <91d1a853-c449-481a-b001-7c1f54e28fdd@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <91d1a853-c449-481a-b001-7c1f54e28fdd@FreeBSD.org> User-Agent: Mutt/1.12.1 (2019-06-15) X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FORGED_GMAIL_RCVD,FREEMAIL_FROM, NML_ADSP_CUSTOM_MED autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on tom.home X-Rspamd-Queue-Id: 466XZR0yY1z48gv X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-6.91 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; REPLY(-4.00)[]; NEURAL_HAM_SHORT(-0.91)[-0.908,0] X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Aug 2019 10:46:07 -0000 On Mon, Aug 12, 2019 at 10:46:29AM +0300, Andriy Gapon wrote: > On 01/08/2019 22:51, Ian Lepore wrote: > > On Thu, 2019-08-01 at 21:14 +0300, Andriy Gapon wrote: > >> On 01/08/2019 19:12, Warner Losh wrote: > >>> > >>> > >>> On Thu, Aug 1, 2019, 10:53 AM Rodney W. Grimes > >>> > > >>> wrote: > >>> > >>> > > >>> > Is it possible in an rc script to distinguish between a manual stop > >>> > (e.g., service foo stop) and a stop during a system shutdown (via > >>> > rc.shutdown) ? > >>> > Are there any marker variables for that? > >>> > Or something in the global system state? > >>> > >>> Not that I can think of, but I like this idea, > >>> I am sure that use cases exist. > >>> > >>> > >>> What is the use case that needs to disambiguate the two cases... > >> > >> I have one use case in mind and it's a truly special case. > >> I want rc.d/watchdogd to gracefully stop watchdogd and to disable the > >> watchdog timer when the stop action is requested manually. And I want > >> it to stop watchdogd and set the watchdog timer to a special shutdown > >> timeout during the shutdown. If the special timeout is configured, of > >> course. > >> > > > > The shutdown timeout is already supported: you just set '-x ' > > in watchdogd_flags in rc.conf; no changes to the rc.d script needed. > > > > I think probably you don't even need the first part of what you want. > > The -x arg covers you in the reboot case; most people probably won't > > use it. But if you are using it, and you want to truly kill the dog, > > you would just do "watchdog -t 0" after "service watchdogd stop". If > > you really felt the need to cover that with a single service command, > > then how about using "service watchdogd cancel" where the cancel verb > > does the -t 0 after killing the daemon? > > I guess that there is more than one way to achieve what I want or > something similar to that. > Rather than "expend words" on a theoretical discussion, I decided to do > this: https://reviews.freebsd.org/D21221 > However, I am still open to the discussion and suggestions. > One thing that I would prefer, though, is to make the watchdogd service > as smart as possible -- but not smarter :-) -- that is, I would prefer > to do without adding any new command verbs to it. Did you considered exporting kern_shutdown.c:rebooting as a sysctl ? From owner-freebsd-rc@freebsd.org Mon Aug 12 10:58:03 2019 Return-Path: Delivered-To: freebsd-rc@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id DF5ECAEA91; Mon, 12 Aug 2019 10:58:02 +0000 (UTC) (envelope-from agapon@gmail.com) Received: from mail-pg1-f171.google.com (mail-pg1-f171.google.com [209.85.215.171]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 466Xr947Hqz4BMk; Mon, 12 Aug 2019 10:58:00 +0000 (UTC) (envelope-from agapon@gmail.com) Received: by mail-pg1-f171.google.com with SMTP id w10so49288009pgj.7; Mon, 12 Aug 2019 03:58:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:openpgp:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=4LqhkQRnmKW8hGKhSBsc8eCpnVHck4fPH6v4vmVJMq4=; b=IN4+dNiuN70ZzgU8emVMvScV0IlBINxa1vqjbnH+8gYVnuTRJPD9Mm3poq80fWWmX4 KILVcxWuyjO30Dp5iNxaGo98lCz7sw9kmovtCvXVerkObt6/DwurE0fOBuBB6Oz8oPYP zRXDGFCZZzH2yqwbIMHJ4mfMz9kM0tQ+/s5UZN2NJz4mSLS1k7FoL5GSSgN2Q6+jfcdM 3AthOsFJavRK8kBvqnXWDOA8dKt8Vp/cJ8Lg8HArFXZ4CZs5tgqeTrPc/iw1qSBGmmH6 Ld+3WNs2ZUV2+PgUuU2oxFogv1OBK5gqfK2/FJe+o3HjAjzw5FeNAHEyR8kOR1KmrjqX +MFw== X-Gm-Message-State: APjAAAX99ExnLKLGBC3f3J4TPU8ErevN4oe4kQnISjAkkXdSWBWWTl/6 Pi8gzsZK4ZofX6/7HYJQ+jJhlTg5 X-Google-Smtp-Source: APXvYqy5DNsFc12FFTeOQ5P+s16BN5HiNpdfevJTBnezWfOp0BW3LT+M8pLdzqZnyZUZ19VvZLhK4w== X-Received: by 2002:a17:90a:fa0a:: with SMTP id cm10mr7197125pjb.133.1565607479074; Mon, 12 Aug 2019 03:57:59 -0700 (PDT) Received: from [192.168.1.36] (broadband-82-140-206-197.atc.tvcom.ru. [82.140.206.197]) by smtp.googlemail.com with ESMTPSA id f6sm107879175pga.50.2019.08.12.03.57.56 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 12 Aug 2019 03:57:58 -0700 (PDT) Subject: Re: rc script: manual stop vs system shutdown To: Konstantin Belousov Cc: Ian Lepore , Warner Losh , "Rodney W. Grimes" , FreeBSD Current , freebsd-rc@FreeBSD.org References: <2e50fb67-8a19-412b-19d2-14f5f20b61f8@FreeBSD.org> <201908011553.x71FrTCd060252@gndrsh.dnsmgr.net> <91d1a853-c449-481a-b001-7c1f54e28fdd@FreeBSD.org> <20190812104550.GA2738@kib.kiev.ua> From: Andriy Gapon Openpgp: preference=signencrypt Message-ID: <52b2eac3-83de-a7c7-5126-c742e2f195a8@FreeBSD.org> Date: Mon, 12 Aug 2019 13:57:55 +0300 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20190812104550.GA2738@kib.kiev.ua> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 466Xr947Hqz4BMk X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of agapon@gmail.com designates 209.85.215.171 as permitted sender) smtp.mailfrom=agapon@gmail.com X-Spamd-Result: default: False [-6.10 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCVD_TLS_ALL(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip4:209.85.128.0/17:c]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[text/plain]; MIME_TRACE(0.00)[0:+]; DMARC_NA(0.00)[FreeBSD.org]; RCPT_COUNT_FIVE(0.00)[6]; RCVD_COUNT_THREE(0.00)[3]; TO_MATCH_ENVRCPT_SOME(0.00)[]; NEURAL_HAM_SHORT(-0.98)[-0.982,0]; RCVD_IN_DNSWL_NONE(0.00)[171.215.85.209.list.dnswl.org : 127.0.5.0]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; IP_SCORE(-3.11)[ip: (-9.74), ipnet: 209.85.128.0/17(-3.38), asn: 15169(-2.39), country: US(-0.05)]; FORGED_SENDER(0.30)[avg@FreeBSD.org,agapon@gmail.com]; FREEMAIL_TO(0.00)[gmail.com]; RECEIVED_SPAMHAUS_PBL(0.00)[197.206.140.82.khpj7ygk5idzvmvt5x4ziurxhy.zen.dq.spamhaus.net : 127.0.0.11]; R_DKIM_NA(0.00)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; FROM_NEQ_ENVFROM(0.00)[avg@FreeBSD.org,agapon@gmail.com]; MID_RHS_MATCH_FROM(0.00)[] X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Aug 2019 10:58:03 -0000 On 12/08/2019 13:45, Konstantin Belousov wrote: > On Mon, Aug 12, 2019 at 10:46:29AM +0300, Andriy Gapon wrote: >> I guess that there is more than one way to achieve what I want or >> something similar to that. >> Rather than "expend words" on a theoretical discussion, I decided to do >> this: https://reviews.freebsd.org/D21221 >> However, I am still open to the discussion and suggestions. >> One thing that I would prefer, though, is to make the watchdogd service >> as smart as possible -- but not smarter :-) -- that is, I would prefer >> to do without adding any new command verbs to it. > > Did you considered exporting kern_shutdown.c:rebooting as a sysctl ? No, I didn't it. Thank you for the suggestion. Let me investigate it. -- Andriy Gapon From owner-freebsd-rc@freebsd.org Mon Aug 12 11:03:42 2019 Return-Path: Delivered-To: freebsd-rc@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 4B5E7AF47A; Mon, 12 Aug 2019 11:03:42 +0000 (UTC) (envelope-from agapon@gmail.com) Received: from mail-pg1-f194.google.com (mail-pg1-f194.google.com [209.85.215.194]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 466Xyj3BKnz4CLs; Mon, 12 Aug 2019 11:03:41 +0000 (UTC) (envelope-from agapon@gmail.com) Received: by mail-pg1-f194.google.com with SMTP id x15so38948480pgg.8; Mon, 12 Aug 2019 04:03:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:from:to:cc:references:openpgp:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=RRR0XCQP3z/2zeJdSqlcwArQibmy44WNvk4Q1dSuGKQ=; b=hee2lpAicXLeYWOmdUG+XVgLdVRreOaCW19jGN8V4W0X9waFVLY+WrOQR0QE5sOIYH Yh23sh8/jr0+v/qrNUbq5t+u3/yWxNx0VFm7lZbAXEQrnOiTPWp3jxlA3ld1guaPdPLF HU1XWC/dbe/7LEYt7AeWfOUQueCwR2anrSOuvjLI8mL2zWAbndJC8VgdVJVmEvzLj5j7 Uo59AGxbEpyn8DLCfrfcx5o3ohDSmweLxDCAh0anOyY7EqwF1bkTcUhQ6ZYqSElOgS1/ HZ+MsrW9fGgCuFvvpe8z6VsHN2z32Dh6HSC5H8qancY8SBGZ0UkYPR/fIFV78GueG5bf POpA== X-Gm-Message-State: APjAAAX0n/dXt4WV/8IL0/xTCvQnuUrUBMOGp7p9UPG8RCla1hbZT41E SuYK5qUwk9WTzs1Y30R/W9XSOO9C X-Google-Smtp-Source: APXvYqxzcVENPbG4JbzXIRY7wJfGw+78mMJWuwykNqLg5cba5jsC2yuq0ESBmVo9OEcEBG9NnWiIrg== X-Received: by 2002:a63:6d6:: with SMTP id 205mr30440430pgg.262.1565607818831; Mon, 12 Aug 2019 04:03:38 -0700 (PDT) Received: from [192.168.1.36] (broadband-82-140-206-197.atc.tvcom.ru. [82.140.206.197]) by smtp.googlemail.com with ESMTPSA id s24sm71032523pgm.3.2019.08.12.04.03.35 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 12 Aug 2019 04:03:37 -0700 (PDT) Subject: Re: rc script: manual stop vs system shutdown From: Andriy Gapon To: Konstantin Belousov Cc: Ian Lepore , Warner Losh , "Rodney W. Grimes" , FreeBSD Current , freebsd-rc@FreeBSD.org References: <2e50fb67-8a19-412b-19d2-14f5f20b61f8@FreeBSD.org> <201908011553.x71FrTCd060252@gndrsh.dnsmgr.net> <91d1a853-c449-481a-b001-7c1f54e28fdd@FreeBSD.org> <20190812104550.GA2738@kib.kiev.ua> <52b2eac3-83de-a7c7-5126-c742e2f195a8@FreeBSD.org> Openpgp: preference=signencrypt Message-ID: <7a72dcf7-899f-a67b-d66a-cc48a094c7cf@FreeBSD.org> Date: Mon, 12 Aug 2019 14:03:34 +0300 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <52b2eac3-83de-a7c7-5126-c742e2f195a8@FreeBSD.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 466Xyj3BKnz4CLs X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of agapon@gmail.com designates 209.85.215.194 as permitted sender) smtp.mailfrom=agapon@gmail.com X-Spamd-Result: default: False [-4.13 / 15.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip4:209.85.128.0/17:c]; RWL_MAILSPIKE_GOOD(0.00)[194.215.85.209.rep.mailspike.net : 127.0.0.18]; RCPT_COUNT_FIVE(0.00)[6]; RCVD_COUNT_THREE(0.00)[3]; NEURAL_HAM_SHORT(-0.97)[-0.970,0]; FORGED_SENDER(0.30)[avg@FreeBSD.org,agapon@gmail.com]; FREEMAIL_TO(0.00)[gmail.com]; RECEIVED_SPAMHAUS_PBL(0.00)[197.206.140.82.khpj7ygk5idzvmvt5x4ziurxhy.zen.dq.spamhaus.net : 127.0.0.11]; MIME_TRACE(0.00)[0:+]; R_DKIM_NA(0.00)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; FROM_NEQ_ENVFROM(0.00)[avg@FreeBSD.org,agapon@gmail.com]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; MID_RHS_MATCH_FROM(0.00)[]; FROM_HAS_DN(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[FreeBSD.org]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[194.215.85.209.list.dnswl.org : 127.0.5.0]; IP_SCORE(-1.16)[ipnet: 209.85.128.0/17(-3.38), asn: 15169(-2.39), country: US(-0.05)]; RCVD_TLS_ALL(0.00)[] X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Aug 2019 11:03:42 -0000 On 12/08/2019 13:57, Andriy Gapon wrote: > On 12/08/2019 13:45, Konstantin Belousov wrote: >> On Mon, Aug 12, 2019 at 10:46:29AM +0300, Andriy Gapon wrote: >>> I guess that there is more than one way to achieve what I want or >>> something similar to that. >>> Rather than "expend words" on a theoretical discussion, I decided to do >>> this: https://reviews.freebsd.org/D21221 >>> However, I am still open to the discussion and suggestions. >>> One thing that I would prefer, though, is to make the watchdogd service >>> as smart as possible -- but not smarter :-) -- that is, I would prefer >>> to do without adding any new command verbs to it. >> >> Did you considered exporting kern_shutdown.c:rebooting as a sysctl ? > > No, I didn't it. Thank you for the suggestion. > Let me investigate it. 'rebooting' seems to be too late, it's set when the actual reboot system call is made. rc.shutdown is run before that. I think that the kernel is generally[*] not aware of an imminent shutdown between the time init(8) is signaled and the time init(8) calls reboot(2). [*] -- except for cases where the kernel is an initiator of the shutdown. -- Andriy Gapon From owner-freebsd-rc@freebsd.org Mon Aug 12 15:29:44 2019 Return-Path: Delivered-To: freebsd-rc@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 64A95B6A8F for ; Mon, 12 Aug 2019 15:29:44 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (mailman.nyi.freebsd.org [IPv6:2610:1c1:1:606c::50:13]) by mx1.freebsd.org (Postfix) with ESMTP id 466fsh24XMz4Td6 for ; Mon, 12 Aug 2019 15:29:44 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id 456A9B6A8E; Mon, 12 Aug 2019 15:29:44 +0000 (UTC) Delivered-To: rc@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 452A9B6A8D for ; Mon, 12 Aug 2019 15:29:44 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 466fsh18xYz4Td5 for ; Mon, 12 Aug 2019 15:29:44 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 09AE790D for ; Mon, 12 Aug 2019 15:29:44 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id x7CFTh2c087329 for ; Mon, 12 Aug 2019 15:29:43 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id x7CFThtC087328 for rc@FreeBSD.org; Mon, 12 Aug 2019 15:29:43 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: rc@FreeBSD.org Subject: [Bug 239692] rc: Environment variables set via ${name}_env are not passed to ${rc_arg}_cmd (e.g., start_cmd) Date: Mon, 12 Aug 2019 15:29:43 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: conf X-Bugzilla-Version: 11.2-RELEASE X-Bugzilla-Keywords: needs-qa X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: 0mp@FreeBSD.org X-Bugzilla-Status: In Progress X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: rc@FreeBSD.org X-Bugzilla-Flags: mfc-stable11? mfc-stable12? X-Bugzilla-Changed-Fields: bug_status Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Aug 2019 15:29:44 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D239692 Mateusz Piotrowski <0mp@FreeBSD.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Open |In Progress --- Comment #1 from Mateusz Piotrowski <0mp@FreeBSD.org> --- I've posted an attempt at addressing this issue: https://reviews.freebsd.org/D21228 --=20 You are receiving this mail because: You are the assignee for the bug.= From owner-freebsd-rc@freebsd.org Tue Aug 13 17:53:48 2019 Return-Path: Delivered-To: freebsd-rc@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id AA472B74A4 for ; Tue, 13 Aug 2019 17:53:48 +0000 (UTC) (envelope-from jgh@helfman.org) Received: from sender-of-o52.zoho.com (sender-of-o52.zoho.com [135.84.80.217]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 467L1R4MZMz49hS for ; Tue, 13 Aug 2019 17:53:47 +0000 (UTC) (envelope-from jgh@helfman.org) ARC-Seal: i=1; a=rsa-sha256; t=1565718823; cv=none; d=zoho.com; s=zohoarc; b=QDU1sl/spaGHKdb78qE7U/HzbD3LVFj1EEd16rBFIOm/YaaXaQBuYFGlUFMWFv56+TM8VasOe8LzWVD1j5XUYimsyWyCe1BU4kRNuRqkBTB72gM30CtKfk6whD9i2vJWc9wDL8NX3vTe0ZcIbBDXEMgwkB6KpySrQQ+c6yz6+hs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1565718823; h=Content-Type:Content-Transfer-Encoding:Date:From:MIME-Version:Message-ID:Subject:To:ARC-Authentication-Results; bh=mOoQg/yf8Wwl6YLfWdwJ2syrIfHW55gcaWoqEKXUit0=; b=DnEzQErLPvezFuRgYJQ1APSxSSW48cl24xjy+2jjFK/ApIXOZHG2G0ZxRhIvfwYukTwN2I2R1OjeVa2Lv0hsYmLCMVvlD+D9EkRm5lxUin2lM6sweezLYNhOQ8lGGOLUNSV7/XXKBRmnd/H0Bv6s7Y9ynuG6YWheMIVhFakMoA8= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=pass header.i=FreeBSD.org; spf=pass smtp.mailfrom=jgh@helfman.org; dmarc=pass header.from= header.from= Received: from mail.zoho.com by mx.zohomail.com with SMTP id 15657188230154.106257338716546; Tue, 13 Aug 2019 10:53:43 -0700 (PDT) Date: Tue, 13 Aug 2019 10:53:43 -0700 From: jgh To: "freebsd-rc" Message-ID: <16c8c1d4065.fd16db4736539.6365863228667199360@FreeBSD.org> In-Reply-To: Subject: issues with htpdate using args twice, and not able to get status MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Priority: Medium User-Agent: Zoho Mail X-Mailer: Zoho Mail X-Rspamd-Queue-Id: 467L1R4MZMz49hS X-Spamd-Bar: ------- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of jgh@helfman.org designates 135.84.80.217 as permitted sender) smtp.mailfrom=jgh@helfman.org X-Spamd-Result: default: False [-7.57 / 15.00]; RCVD_TLS_LAST(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; RCVD_COUNT_TWO(0.00)[2]; XM_UA_NO_VERSION(0.01)[]; FROM_HAS_DN(0.00)[]; R_SPF_ALLOW(-0.20)[+ip4:135.84.80.192/26]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[FreeBSD.org]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; ARC_ALLOW(-1.00)[i=1]; RCPT_COUNT_ONE(0.00)[1]; IP_SCORE(-3.59)[ip: (-9.87), ipnet: 135.84.80.0/24(-4.69), asn: 2639(-3.36), country: US(-0.05)]; TO_DN_ALL(0.00)[]; NEURAL_HAM_SHORT(-0.99)[-0.991,0]; RCVD_IN_DNSWL_NONE(0.00)[217.80.84.135.list.dnswl.org : 127.0.15.0]; FORGED_SENDER(0.30)[jgh@FreeBSD.org,jgh@helfman.org]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:2639, ipnet:135.84.80.0/24, country:US]; FROM_NEQ_ENVFROM(0.00)[jgh@FreeBSD.org,jgh@helfman.org]; MID_RHS_MATCH_FROM(0.00)[]; TO_DOM_EQ_FROM_DOM(0.00)[] X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Aug 2019 17:53:48 -0000 Hello, I am trying to fix htpdate startup script, and am having issues figuring this out. Was hoping someone would have an idea what is going on....? I commented out the stop, because even though the process writes out a pid file, status is unable to detect the running process. It seems that the process is writing out a pid file, however that pid file is perhaps to another pid that spawned off another process to actually start the service. This used to work, and not sure if something changed in the software, or in rc.subr. The diff also addresses issues picked up in rclint. Behavior I am trying to fix: Status should work and return the correct pid. Command_args should only have the args once, and not repeated. Thanks in advance! -jgh Here is my current diff of the port: Index: Makefile =================================================================== --- Makefile (revision 508805) +++ Makefile (working copy) @@ -3,7 +3,7 @@ PORTNAME= htpdate PORTVERSION= 1.2.1 -PORTREVISION= 2 +PORTREVISION= 3 CATEGORIES= net ipv6 MASTER_SITES= http://www.vervest.org/htp/archive/c/ \ http://twekkel.home.xs4all.nl/htp/ Index: files/htpdate.in =================================================================== --- files/htpdate.in (revision 508805) +++ files/htpdate.in (working copy) @@ -3,8 +3,7 @@ # $FreeBSD$ # PROVIDE: htpdate -# REQUIRE: NETWORKING SERVERS -# BEFORE: DAEMON +# REQUIRE: NETWORKING syslogd # KEYWORD: shutdown # Add the following line to /etc/rc.conf to enable htpdate: @@ -14,31 +13,33 @@ . /etc/rc.subr -load_rc_config htpdate +name=htpdate +desc="HTTP Time Protocol daemon" +rcvar=htpdate_enable +load_rc_config ${name} + htpdate_enable="${htpdate_enable:-"NO"}" htpdate_servers="${htpdate_servers:-"www.example.com"}" -htpdate_flags="${htpdate_flags:-"-l -s -D"}" +htpdate_flags="${htpdate_flags:-"-lsD"}" -name=htpdate -rcvar=htpdate_enable -servers=${htpdate_servers} +command=/usr/local/bin/htpdate pidfile=/var/run/htpdate.pid -command="/usr/local/bin/htpdate" -command_args="${htpdate_flags} $servers" -stop_cmd=htpdate_stop +command_args="$htpdate_flags $htpdate_servers" -htpdate_stop () -{ - if [ -f ${pidfile} ]; then - echo "Stopping htpdate." - kill `cat ${pidfile}` - else - echo "htpdate is not running." - fi +#stop_cmd=htpdate_stop - rm -f ${pidfile} -} +#htpdate_stop() +#{ +# if [ -f ${pidfile} ]; then +# echo "Stopping ${name}." +# kill `cat ${pidfile}` +# else +# echo "${name} is not running." +# fi +# +# rm -f ${pidfile} +#} Here is the output with debugging turned on: run_rc_command "$1" + htpdate_enable=YES + local_unbound_enable=YES + sourced_files=:/etc/rc.conf::/etc/rc.conf.local: + [ -r /etc/rc.conf.local ] + _rc_conf_loaded=true + [ -n htpdate ] + _d=/etc + [ -f /etc/rc.conf.d/htpdate ] + [ -d /etc/rc.conf.d/htpdate ] + _d=/usr/local/etc + [ -f /usr/local/etc/rc.conf.d/htpdate ] + [ -d /usr/local/etc/rc.conf.d/htpdate ] + eval '_defval=$htpdate_enable_defval' + _defval='' + [ -n '' ] + htpdate_enable=YES + htpdate_servers=www.example.com + htpdate_flags=-lsD + command=/usr/local/bin/htpdate + pidfile=/var/run/htpdate.pid + command_args='-lsD www.example.com' + run_rc_command restart + _return=0 + rc_arg=restart + [ -z htpdate ] + shift 1 + rc_extra_args='' + _rc_prefix='' + eval '_override_command=$htpdate_program' + _override_command='' + command=/usr/local/bin/htpdate + _keywords='start stop restart rcvar enable disable delete enabled describe extracommands ' + rc_pid='' + _pidcmd='' + _procname=/usr/local/bin/htpdate + [ -n /usr/local/bin/htpdate ] + [ -n /var/run/htpdate.pid ] + _pidcmd='rc_pid=$(check_pidfile /var/run/htpdate.pid /usr/local/bin/htpdate )' + _keywords='start stop restart rcvar enable disable delete enabled describe extracommands status poll' + [ -z restart ] + [ restart '=' enabled ] + [ -n '' ] + eval 'rc_flags=$htpdate_flags' + rc_flags=-lsD + eval '_chdir=$htpdate_chdir' '_chroot=$htpdate_chroot' '_nice=$htpdate_nice' '_user=$htpdate_user' '_group=$htpdate_group' '_groups=$htpdate_groups' '_fib=$htpdate_fib' '_env=$htpdate_env' '_prepend=$htpdate_prepend' '_login_class=${htpdate_login_class:-daemon}' '_limits=$htpdate_limits' '_oomprotect=$htpdate_oomprotect' '_env_file=$htpdate_env_file' + _chdir='' _chroot='' _nice='' _user='' _group='' _groups='' _fib='' _env='' _prepend='' _login_class=daemon _limits='' _oomprotect='' _env_file='' + [ -n '' ] + [ -n '' ] + [ -z '' ] + eval 'rc_pid=$(check_pidfile' /var/run/htpdate.pid /usr/local/bin/htpdate ')' + check_pidfile /var/run/htpdate.pid /usr/local/bin/htpdate + _pidfile=/var/run/htpdate.pid + _procname=/usr/local/bin/htpdate + _interpreter='' + [ -z /var/run/htpdate.pid -o -z /usr/local/bin/htpdate ] + [ ! -f /var/run/htpdate.pid ] + debug 'pid file (/var/run/htpdate.pid): not readable.' + return + rc_pid='' + [ start '!=' restart ] + continue + [ stop '!=' restart ] + continue + [ restart '!=' restart ] + [ -n htpdate_enable -a restart '!=' rcvar -a restart '!=' stop -a restart '!=' delete -a restart '!=' enable -a restart '!=' describe ] + checkyesno htpdate_enable + eval '_value=$htpdate_enable' + _value=YES + debug 'checkyesno: htpdate_enable is set to YES.' + return 0 + [ restart '=' start -a -z '' -a -n '' ] + eval '_cmd=$restart_cmd' '_precmd=$restart_precmd' '_postcmd=$restart_postcmd' + _cmd='' _precmd='' _postcmd='' + [ -n '' ] + false + _rc_restart_done=true + _run_rc_precmd + check_required_before restart + local _f + return 0 + [ -n '' ] + check_required_after restart + local _f _args + return 0 + return 0 + run_rc_command stop + _return=0 + rc_arg=stop + [ -z htpdate ] + shift 1 + rc_extra_args='' + _rc_prefix='' + eval '_override_command=$htpdate_program' + _override_command='' + command=/usr/local/bin/htpdate + _keywords='start stop restart rcvar enable disable delete enabled describe extracommands ' + rc_pid='' + _pidcmd='' + _procname=/usr/local/bin/htpdate + [ -n /usr/local/bin/htpdate ] + [ -n /var/run/htpdate.pid ] + _pidcmd='rc_pid=$(check_pidfile /var/run/htpdate.pid /usr/local/bin/htpdate )' + _keywords='start stop restart rcvar enable disable delete enabled describe extracommands status poll' + [ -z stop ] + [ stop '=' enabled ] + [ -n '' ] + eval 'rc_flags=$htpdate_flags' + rc_flags=-lsD + eval '_chdir=$htpdate_chdir' '_chroot=$htpdate_chroot' '_nice=$htpdate_nice' '_user=$htpdate_user' '_group=$htpdate_group' '_groups=$htpdate_groups' '_fib=$htpdate_fib' '_env=$htpdate_env' '_prepend=$htpdate_prepend' '_login_class=${htpdate_login_class:-daemon}' '_limits=$htpdate_limits' '_oomprotect=$htpdate_oomprotect' '_env_file=$htpdate_env_file' + _chdir='' _chroot='' _nice='' _user='' _group='' _groups='' _fib='' _env='' _prepend='' _login_class=daemon _limits='' _oomprotect='' _env_file='' + [ -n '' ] + [ -n '' ] + [ -z '' ] + eval 'rc_pid=$(check_pidfile' /var/run/htpdate.pid /usr/local/bin/htpdate ')' + check_pidfile /var/run/htpdate.pid /usr/local/bin/htpdate + _pidfile=/var/run/htpdate.pid + _procname=/usr/local/bin/htpdate + _interpreter='' + [ -z /var/run/htpdate.pid -o -z /usr/local/bin/htpdate ] + [ ! -f /var/run/htpdate.pid ] + debug 'pid file (/var/run/htpdate.pid): not readable.' + return + rc_pid='' + [ start '!=' stop ] + continue + [ stop '!=' stop ] + [ -n htpdate_enable -a stop '!=' rcvar -a stop '!=' stop -a stop '!=' delete -a stop '!=' enable -a stop '!=' describe ] + [ -n htpdate_enable -a stop '=' stop -a -z '' ] + checkyesno htpdate_enable + eval '_value=$htpdate_enable' + _value=YES + debug 'checkyesno: htpdate_enable is set to YES.' + return 0 + [ stop '=' start -a -z '' -a -n '' ] + eval '_cmd=$stop_cmd' '_precmd=$stop_precmd' '_postcmd=$stop_postcmd' + _cmd='' _precmd='' _postcmd='' + [ -n '' ] + [ -z '' ] + [ -n '' ] + _run_rc_notrunning + local _pidmsg + [ -n /var/run/htpdate.pid ] + _pidmsg=' (check /var/run/htpdate.pid).' + echo 'htpdate not running? (check /var/run/htpdate.pid).' htpdate not running? (check /var/run/htpdate.pid). + return 1 + run_rc_command start + _return=0 + rc_arg=start + [ -z htpdate ] + shift 1 + rc_extra_args='' + _rc_prefix='' + eval '_override_command=$htpdate_program' + _override_command='' + command=/usr/local/bin/htpdate + _keywords='start stop restart rcvar enable disable delete enabled describe extracommands ' + rc_pid='' + _pidcmd='' + _procname=/usr/local/bin/htpdate + [ -n /usr/local/bin/htpdate ] + [ -n /var/run/htpdate.pid ] + _pidcmd='rc_pid=$(check_pidfile /var/run/htpdate.pid /usr/local/bin/htpdate )' + _keywords='start stop restart rcvar enable disable delete enabled describe extracommands status poll' + [ -z start ] + [ start '=' enabled ] + [ -n '' ] + eval 'rc_flags=$htpdate_flags' + rc_flags=-lsD + eval '_chdir=$htpdate_chdir' '_chroot=$htpdate_chroot' '_nice=$htpdate_nice' '_user=$htpdate_user' '_group=$htpdate_group' '_groups=$htpdate_groups' '_fib=$htpdate_fib' '_env=$htpdate_env' '_prepend=$htpdate_prepend' '_login_class=${htpdate_login_class:-daemon}' '_limits=$htpdate_limits' '_oomprotect=$htpdate_oomprotect' '_env_file=$htpdate_env_file' + _chdir='' _chroot='' _nice='' _user='' _group='' _groups='' _fib='' _env='' _prepend='' _login_class=daemon _limits='' _oomprotect='' _env_file='' + [ -n '' ] + [ -n '' ] + [ -z '' ] + eval 'rc_pid=$(check_pidfile' /var/run/htpdate.pid /usr/local/bin/htpdate ')' + check_pidfile /var/run/htpdate.pid /usr/local/bin/htpdate + _pidfile=/var/run/htpdate.pid + _procname=/usr/local/bin/htpdate + _interpreter='' + [ -z /var/run/htpdate.pid -o -z /usr/local/bin/htpdate ] + [ ! -f /var/run/htpdate.pid ] + debug 'pid file (/var/run/htpdate.pid): not readable.' + return + rc_pid='' + [ start '!=' start ] + [ -n htpdate_enable -a start '!=' rcvar -a start '!=' stop -a start '!=' delete -a start '!=' enable -a start '!=' describe ] + checkyesno htpdate_enable + eval '_value=$htpdate_enable' + _value=YES + debug 'checkyesno: htpdate_enable is set to YES.' + return 0 + [ start '=' start -a -z '' -a -n '' ] + eval '_cmd=$start_cmd' '_precmd=$start_precmd' '_postcmd=$start_postcmd' + _cmd='' _precmd='' _postcmd='' + [ -n '' ] + [ ! -x /usr/local/bin/htpdate ] + _run_rc_precmd + check_required_before start + local _f + return 0 + [ -n '' ] + check_required_after start + local _f _args + return 0 + return 0 + check_startmsgs + [ -n '' ] + return 0 + echo 'Starting htpdate.' Starting htpdate. + [ -n '' ] + _cd='' + _doit='/usr/local/bin/htpdate -lsD -lsD www.example.com' + [ -n '' ] + [ -n '' ] + [ -n '' ] + _doit=' limits -C daemon /usr/local/bin/htpdate -lsD -lsD www.example.com' + _run_rc_doit ' limits -C daemon /usr/local/bin/htpdate -lsD -lsD www.example.com' + debug 'run_rc_command: doit: limits -C daemon /usr/local/bin/htpdate -lsD -lsD www.example.com' + eval ' limits -C daemon /usr/local/bin/htpdate -lsD -lsD www.example.com' + limits -C daemon /usr/local/bin/htpdate -lsD -lsD www.example.com + _return=0 + [ 0 -ne 0 ] + return 0 + _run_rc_postcmd + [ -n '' ] + return 0 + [ -n '' ] + return 0 + _return=0 + [ 0 -ne 0 ] + _run_rc_postcmd + [ -n '' ] + return 0 + return 0 From owner-freebsd-rc@freebsd.org Wed Aug 14 09:43:01 2019 Return-Path: Delivered-To: freebsd-rc@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id BECA9CD24A for ; Wed, 14 Aug 2019 09:43:01 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id 467l4j4l8qz44XD for ; Wed, 14 Aug 2019 09:43:01 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id A0CC6CD249; Wed, 14 Aug 2019 09:43:01 +0000 (UTC) Delivered-To: rc@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id A0928CD248 for ; Wed, 14 Aug 2019 09:43:01 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 467l4j3hN9z44XC for ; Wed, 14 Aug 2019 09:43:01 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 5D4922604B for ; Wed, 14 Aug 2019 09:43:01 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id x7E9h1gl070899 for ; Wed, 14 Aug 2019 09:43:01 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id x7E9h16m070898 for rc@FreeBSD.org; Wed, 14 Aug 2019 09:43:01 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: rc@FreeBSD.org Subject: [Bug 211928] [pf] /etc/rc.d/pf should REQUIRE routing Date: Wed, 14 Aug 2019 09:43:01 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: conf X-Bugzilla-Version: 11.2-RELEASE X-Bugzilla-Keywords: patch X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: rs@bytecamp.net X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: rc@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: version Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Aug 2019 09:43:01 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D211928 Robert Schulze changed: What |Removed |Added ---------------------------------------------------------------------------- Version|10.3-RELEASE |11.2-RELEASE --=20 You are receiving this mail because: You are the assignee for the bug.=