Date: Sat, 11 May 2019 20:31:11 -0500 From: Doug Moore <unkadoug@gmail.com> To: Bruce Evans <brde@optusnet.com.au>, Doug Moore <dougm@freebsd.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r347484 - head/sys/kern Message-ID: <c26c6fa5-abc5-dace-f68c-f224bdaddd1a@gmail.com> In-Reply-To: <20190511202741.H1251@besplex.bde.org> References: <201905110909.x4B99A5L006389@repo.freebsd.org> <20190511202741.H1251@besplex.bde.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 5/11/19 5:52 AM, Bruce Evans wrote: > On Sat, 11 May 2019, Doug Moore wrote: >> +#ifdef HAVE_INLINE_FFS >> + case sizeof(int): >> + return (ffs(mask) - 1); >> +#endif > > This is unreachable, since sizeof(int) is 4 on all supported arches, and > sizeof(mask) is 8 on all arches. > Another FreeBSD developer has expressed to me that sizeof(mask) ought to become 4 on some 32-bit arches before too long, and I added this case in anticipation of that. I see now that I should have waited. Doug Moore
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?c26c6fa5-abc5-dace-f68c-f224bdaddd1a>