From owner-svn-src-projects@freebsd.org Mon Mar 11 02:57:02 2019 Return-Path: Delivered-To: svn-src-projects@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 458F3152A0B2 for ; Mon, 11 Mar 2019 02:57:02 +0000 (UTC) (envelope-from ngie@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id A2D2474F4F; Mon, 11 Mar 2019 02:57:01 +0000 (UTC) (envelope-from ngie@FreeBSD.org) Received: from repo.freebsd.org (repo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id D7F0F498E; Mon, 11 Mar 2019 02:57:00 +0000 (UTC) (envelope-from ngie@FreeBSD.org) Received: from repo.freebsd.org ([127.0.1.37]) by repo.freebsd.org (8.15.2/8.15.2) with ESMTP id x2B2v0Gf038196; Mon, 11 Mar 2019 02:57:00 GMT (envelope-from ngie@FreeBSD.org) Received: (from ngie@localhost) by repo.freebsd.org (8.15.2/8.15.2/Submit) id x2B2v08Y038195; Mon, 11 Mar 2019 02:57:00 GMT (envelope-from ngie@FreeBSD.org) Message-Id: <201903110257.x2B2v08Y038195@repo.freebsd.org> X-Authentication-Warning: repo.freebsd.org: ngie set sender to ngie@FreeBSD.org using -f From: Enji Cooper Date: Mon, 11 Mar 2019 02:57:00 +0000 (UTC) To: src-committers@freebsd.org, svn-src-projects@freebsd.org Subject: svn commit: r344996 - projects/import-googletest-1.8.1/contrib/googletest/googlemock/test X-SVN-Group: projects X-SVN-Commit-Author: ngie X-SVN-Commit-Paths: projects/import-googletest-1.8.1/contrib/googletest/googlemock/test X-SVN-Commit-Revision: 344996 X-SVN-Commit-Repository: base MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: A2D2474F4F X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-2.95 / 15.00]; local_wl_from(0.00)[FreeBSD.org]; NEURAL_HAM_MEDIUM(-1.00)[-0.996,0]; NEURAL_HAM_SHORT(-0.96)[-0.957,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; ASN(0.00)[asn:11403, ipnet:2610:1c1:1::/48, country:US] X-BeenThere: svn-src-projects@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the src " projects" tree" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Mar 2019 02:57:02 -0000 Author: ngie Date: Mon Mar 11 02:57:00 2019 New Revision: 344996 URL: https://svnweb.freebsd.org/changeset/base/344996 Log: Expect `WhenDynamicCastToTest.AmbiguousCast` to fail on FreeBSD Casting `AmbiguousCastTypes::DerivedSub1` to `Base` currently succeeds, when it's expected to fail. See https://github.com/google/googletest/issues/2172 for more details. Modified: projects/import-googletest-1.8.1/contrib/googletest/googlemock/test/gmock-matchers_test.cc Modified: projects/import-googletest-1.8.1/contrib/googletest/googlemock/test/gmock-matchers_test.cc ============================================================================== --- projects/import-googletest-1.8.1/contrib/googletest/googlemock/test/gmock-matchers_test.cc Mon Mar 11 02:42:49 2019 (r344995) +++ projects/import-googletest-1.8.1/contrib/googletest/googlemock/test/gmock-matchers_test.cc Mon Mar 11 02:57:00 2019 (r344996) @@ -3767,6 +3767,12 @@ TEST(WhenDynamicCastToTest, AmbiguousCast) { AmbiguousCastTypes::DerivedSub1 sub1; AmbiguousCastTypes::ManyDerivedInHierarchy many_derived; // Multiply derived from Base. dynamic_cast<> returns NULL. + + // This testcase fails on FreeBSD. See this GitHub issue for more details: + // https://github.com/google/googletest/issues/2172 +#ifdef __FreeBSD__ + EXPECT_NONFATAL_FAILURE({ +#endif Base* as_base_ptr = static_cast(&many_derived); EXPECT_THAT(as_base_ptr, @@ -3775,6 +3781,9 @@ TEST(WhenDynamicCastToTest, AmbiguousCast) { EXPECT_THAT( as_base_ptr, WhenDynamicCastTo(Not(IsNull()))); +#ifdef __FreeBSD__ + }, ""); +#endif } TEST(WhenDynamicCastToTest, Describe) {