From owner-freebsd-arch@freebsd.org Wed Mar 4 10:18:53 2020 Return-Path: Delivered-To: freebsd-arch@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 9DAF926ACFC for ; Wed, 4 Mar 2020 10:18:53 +0000 (UTC) (envelope-from gbergling@gmail.com) Received: from mail-wm1-x335.google.com (mail-wm1-x335.google.com [IPv6:2a00:1450:4864:20::335]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 48XVGL2lwfz4X51 for ; Wed, 4 Mar 2020 10:18:49 +0000 (UTC) (envelope-from gbergling@gmail.com) Received: by mail-wm1-x335.google.com with SMTP id p9so1357731wmc.2 for ; Wed, 04 Mar 2020 02:18:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=6f227rWceFT3t6SVOTYPjE0q7+hHhQQSwSI+l3O5pbA=; b=Tfa+xSjH9g65JlLuZO8bY4w172tqohqaeSbSbV+QgUh4rHOnkrIq8C/NXIWUuwfhp+ jXO5/nVNo8itDmeLgOA4DReykC02CBZCJpDRgG9EUMg0hEhD7Jq7K9ka+TPEB4pPUwMJ scCb+r9ZWfRS62S0VMXRAS+1wav1TMK+7pNByJbfErd0asNZwv89QyJPTn7Dd1PdCBu/ 141Kyzuwo6zBJaSFJYLap0IA+5B/VhKb3wd4j8QBFnLoNct0tSmq24UN3FsQDgZBNIQ/ hTI0K7fMAlhU+ruJwS/XRuvO6yiz3VZnbQQjpQB6bzHyDN6yYkiPctQc+ujxMcBLZ585 UCxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=6f227rWceFT3t6SVOTYPjE0q7+hHhQQSwSI+l3O5pbA=; b=JlkWiZmLepMzds3lGoThlrYY3f2tthZhKy1KRodPwtLSMIFU7c+0hkhfDpAcyulAa6 zXj/ll4xXf7yWYpWy7zPn+RZ+nvgAcMgvMDuWTWd/haWjS9KPsuh+wj14/FyB45vUQmV zCcQa3HZ+CC0BzZuSBewhR8wLUl+UitzHeFa6vPE35Ou1H840BgsnK2tic2Yg65UUu7T lw2GeUNiy0jQGWOb+lI8CFeSadRzp7Oa0b99nnLEi9fn+Y0NE0/8zdqESzqzVK9Jti2q HbW7YoLOTwPwEVjeb63wHSBy+/rcXNMmGLITfRuhv52xVvv1kwBlceNBJlMMpwuwpwH/ Dj4Q== X-Gm-Message-State: ANhLgQ33rj6CaUSbMwhLcl4SFO8gmJpv/WeCCSagCCedZH8b2F62nu2D S7UDaQYKBb9X86f5f7VR6IhW6Kb7Fq4= X-Google-Smtp-Source: ADFU+vtv95zsJTvcZ3CYJVbX2O//4xs+e8o/Z1EL4QRmOBG9mPjLnP/Ea5ABGKYQu9XC+VoY+J6CXg== X-Received: by 2002:a1c:66c3:: with SMTP id a186mr3052660wmc.9.1583317126778; Wed, 04 Mar 2020 02:18:46 -0800 (PST) Received: from [10.0.1.111] (p4FD3AF8F.dip0.t-ipconnect.de. [79.211.175.143]) by smtp.gmail.com with ESMTPSA id l5sm3474688wml.3.2020.03.04.02.18.45 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 04 Mar 2020 02:18:46 -0800 (PST) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 13.0 \(3608.60.0.2.5\)) Subject: Re: updating cron and atrun From: Gordon Bergling In-Reply-To: Date: Wed, 4 Mar 2020 11:18:44 +0100 Cc: freebsd-arch@freebsd.org Content-Transfer-Encoding: quoted-printable Message-Id: References: To: Josh Aas X-Mailer: Apple Mail (2.3608.60.0.2.5) X-Rspamd-Queue-Id: 48XVGL2lwfz4X51 X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20161025 header.b=Tfa+xSjH; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (mx1.freebsd.org: domain of gbergling@gmail.com designates 2a00:1450:4864:20::335 as permitted sender) smtp.mailfrom=gbergling@gmail.com X-Spamd-Result: default: False [-2.50 / 15.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip6:2a00:1450:4000::/36]; FREEMAIL_FROM(0.00)[gmail.com]; MV_CASE(0.50)[]; RCVD_COUNT_THREE(0.00)[3]; DKIM_TRACE(0.00)[gmail.com:+]; RCPT_COUNT_TWO(0.00)[2]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; RECEIVED_SPAMHAUS_PBL(0.00)[143.175.211.79.khpj7ygk5idzvmvt5x4ziurxhy.zen.dq.spamhaus.net : 127.0.0.10]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2a00:1450::/32, country:US]; MID_RHS_MATCH_FROM(0.00)[]; DWL_DNSWL_NONE(0.00)[gmail.com.dwl.dnswl.org : 127.0.5.0]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-0.998,0]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20161025]; FROM_HAS_DN(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[text/plain]; PREVIOUSLY_DELIVERED(0.00)[freebsd-arch@freebsd.org]; IP_SCORE_FREEMAIL(0.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[5.3.3.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.5.4.1.0.0.a.2.list.dnswl.org : 127.0.5.0]; IP_SCORE(0.00)[ip: (-8.92), ipnet: 2a00:1450::/32(-2.40), asn: 15169(-1.66), country: US(-0.05)]; RCVD_TLS_ALL(0.00)[] X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 Mar 2020 10:18:53 -0000 Hi Josh, did you had the time to setup a code repository where we can have a look = at the progress you made? You did a fairly detailed analysis of the = current =E2=80=9ECRON-situation=E2=80=9C and I hope you will make a step = further on this. Kind regards, Gordon > Am 07.02.2020 um 15:19 schrieb Josh Aas : >=20 > I was looking for a way to contribute to FreeBSD and I decided to look > into the cron/atrun project listed on this page: >=20 > = https://wiki.freebsd.org/IdeasPage#Improve_cron.288.29_and_atrun.288.29 >=20 > I looked into the current code, commits from the past decade, and the > lineage of other versions of cron to see if there is a reasonable plan > for updating FreeBSD=E2=80=99s cron based on another version. It = doesn't seem > like there are any particularly productive new path to take here. ISC > cron is old and unmaintained, and I don=E2=80=99t think NetBSD or = OpenBSD cron > is interesting enough to be worth entirely rebasing on. On top of > that, FreeBSD cron seems to have some FreeBSD-specific functionality > that we=E2=80=99d still need to maintain or =E2=80=9Cupstream=E2=80=9D = elsewhere. >=20 > I=E2=80=99d recommend continuing with the current status quo - keep = FreeBSD=E2=80=99s > version of cron and occasionally pull in security/stability patches as > applicable from OpenBSD or NetBSD. The other options are a lot of work > for little (if any) gain. Happy to hear other opinions though. >=20 > Integrating atrun into cron might be nice but isn=E2=80=99t very = interesting > IMO. Seems very possible that the cost of that churn outweighs the > benefit. I=E2=80=99d love to hear more about why this is a = particularly good > idea if people believe it is. Maybe I=E2=80=99m missing something. >=20 > If people agree I=E2=80=99d recommend removing the cron and atrun = suggestion > on the Ideas Page. Maintaining that page seems like a pain though, > might I recommend keeping track of these ideas as bugzilla bugs, > tagged with something like =E2=80=9Cideaslist=E2=80=9D? Then you can = just link to that > search. >=20 > --=20 > Josh Aas > _______________________________________________ > freebsd-arch@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/freebsd-arch > To unsubscribe, send any mail to = "freebsd-arch-unsubscribe@freebsd.org" From owner-freebsd-arch@freebsd.org Thu Mar 5 14:26:27 2020 Return-Path: Delivered-To: freebsd-arch@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 1461926B01E for ; Thu, 5 Mar 2020 14:26:27 +0000 (UTC) (envelope-from josh@kflag.net) Received: from mail-lj1-x22d.google.com (mail-lj1-x22d.google.com [IPv6:2a00:1450:4864:20::22d]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 48YCjY2rTSz3Lpc for ; Thu, 5 Mar 2020 14:26:25 +0000 (UTC) (envelope-from josh@kflag.net) Received: by mail-lj1-x22d.google.com with SMTP id w1so6285077ljh.5 for ; Thu, 05 Mar 2020 06:26:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kflag.net; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=lN0vZkLlZcNi5AgdZvgCps70VX9w1XWJL9d9naCwSaQ=; b=qFNmfyH7qnYRH07bNzDW/I9doUU9UUJa2Cld7IODG9Xca6jZfgMhGowvbXwQ5rI9J/ CWvUf2fgaPWby/yb2uW53wBMK3QgQv1QMwwW/iOL+D6kbLFxVEy2WgJUu/e9Erp2eJK5 gGDr/eToeokX4q5aCjRaQrMypBnTIHAg9awgg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=lN0vZkLlZcNi5AgdZvgCps70VX9w1XWJL9d9naCwSaQ=; b=mde+sC0AzVtESsiA3C6Dnjuqy6t5qj3E2Im1Zr4W7bORug8hcS42GOi4xzx0f3BDLU yVxdS1kNX9Scc8TVjeL3H5W07cnmsorcClUwU1INCmolRfFBU9r40jUOjrW0TUBXTfjJ YmGiGg0ZYAn51Lg0yPVcN9ZhpuzAxqam4qmphvYY6YYO6Zzduix2RvyYmD7d+2/grgfY UlOYYNXMXZuIGlQabVv2WWBioYK9VdoTKeXQ7CplD6kZ/eMNyoSc9sNBEG5Wm+lNlfWZ ZiwoAU77F2FFay6623Wg/p821dSWWaYhQhsyQFEmsuFAzbQOHwSiCGVCVC0A/kTtgNRD 4rhw== X-Gm-Message-State: ANhLgQ0V+otsaU4MWqmOT3wjyItNeow+UuFhddBZOfB43BRxyo7wuWyP sGiGFFGOpOyhReqridCyxT8wa+GSNUYDZUgU22/zQdCz X-Google-Smtp-Source: ADFU+vsh9WjBLAg7wgsaaE9uX+F3SBYSlR4WAydzj3cmckaObuA3xJFKkcrA1jO31FkeReXR8kyxsy34QDA1Cmokmg4= X-Received: by 2002:a2e:93c5:: with SMTP id p5mr5395885ljh.192.1583418383061; Thu, 05 Mar 2020 06:26:23 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Josh Aas Date: Thu, 5 Mar 2020 09:26:11 -0500 Message-ID: Subject: Re: updating cron and atrun To: Gordon Bergling Cc: freebsd-arch@freebsd.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 48YCjY2rTSz3Lpc X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=kflag.net header.s=google header.b=qFNmfyH7; dmarc=none; spf=none (mx1.freebsd.org: domain of josh@kflag.net has no SPF policy when checking 2a00:1450:4864:20::22d) smtp.mailfrom=josh@kflag.net X-Spamd-Result: default: False [-4.94 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; R_DKIM_ALLOW(-0.20)[kflag.net:s=google]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[text/plain]; PREVIOUSLY_DELIVERED(0.00)[freebsd-arch@freebsd.org]; DMARC_NA(0.00)[kflag.net]; TO_MATCH_ENVRCPT_SOME(0.00)[]; DKIM_TRACE(0.00)[kflag.net:+]; RCPT_COUNT_TWO(0.00)[2]; RCVD_IN_DNSWL_NONE(0.00)[d.2.2.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.5.4.1.0.0.a.2.list.dnswl.org : 127.0.5.0]; R_SPF_NA(0.00)[]; FREEMAIL_TO(0.00)[gmail.com]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; IP_SCORE(-2.64)[ip: (-9.07), ipnet: 2a00:1450::/32(-2.40), asn: 15169(-1.65), country: US(-0.05)]; ASN(0.00)[asn:15169, ipnet:2a00:1450::/32, country:US]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[] X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 Mar 2020 14:26:27 -0000 My recommendation after looking into the situation was that FreeBSD just continue as things are going with cron/at (see my original email for why), and as such I wasn't planning to work on it. I think FreeBSD should remove it from the list of project ideas, or think of some more compelling structural improvements to cron/at that bring more value than just sloshing code and minor feature behavior around between the various BSDs. They're close enough already for most purposes and the last mile is expensive without much to gain. Based on some replies I thought it was worth considering removing "at", but there seems to be some disagreement and I don't have any personal interest in whether or not that actually happens so I didn't pursue it. On Wed, Mar 4, 2020 at 5:18 AM Gordon Bergling wrote: > > Hi Josh, > > did you had the time to setup a code repository where we can have a look = at the progress you made? You did a fairly detailed analysis of the current= =E2=80=9ECRON-situation=E2=80=9C and I hope you will make a step further o= n this. > > Kind regards, > > Gordon > > > Am 07.02.2020 um 15:19 schrieb Josh Aas : > > > > I was looking for a way to contribute to FreeBSD and I decided to look > > into the cron/atrun project listed on this page: > > > > https://wiki.freebsd.org/IdeasPage#Improve_cron.288.29_and_atrun.288.29 > > > > I looked into the current code, commits from the past decade, and the > > lineage of other versions of cron to see if there is a reasonable plan > > for updating FreeBSD=E2=80=99s cron based on another version. It doesn'= t seem > > like there are any particularly productive new path to take here. ISC > > cron is old and unmaintained, and I don=E2=80=99t think NetBSD or OpenB= SD cron > > is interesting enough to be worth entirely rebasing on. On top of > > that, FreeBSD cron seems to have some FreeBSD-specific functionality > > that we=E2=80=99d still need to maintain or =E2=80=9Cupstream=E2=80=9D = elsewhere. > > > > I=E2=80=99d recommend continuing with the current status quo - keep Fre= eBSD=E2=80=99s > > version of cron and occasionally pull in security/stability patches as > > applicable from OpenBSD or NetBSD. The other options are a lot of work > > for little (if any) gain. Happy to hear other opinions though. > > > > Integrating atrun into cron might be nice but isn=E2=80=99t very intere= sting > > IMO. Seems very possible that the cost of that churn outweighs the > > benefit. I=E2=80=99d love to hear more about why this is a particularly= good > > idea if people believe it is. Maybe I=E2=80=99m missing something. > > > > If people agree I=E2=80=99d recommend removing the cron and atrun sugge= stion > > on the Ideas Page. Maintaining that page seems like a pain though, > > might I recommend keeping track of these ideas as bugzilla bugs, > > tagged with something like =E2=80=9Cideaslist=E2=80=9D? Then you can ju= st link to that > > search. > > > > -- > > Josh Aas > > _______________________________________________ > > freebsd-arch@freebsd.org mailing list > > https://lists.freebsd.org/mailman/listinfo/freebsd-arch > > To unsubscribe, send any mail to "freebsd-arch-unsubscribe@freebsd.org" > -- Josh Aas (215) 206-2020 From owner-freebsd-arch@freebsd.org Thu Mar 5 14:42:21 2020 Return-Path: Delivered-To: freebsd-arch@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id C382226B5F3 for ; Thu, 5 Mar 2020 14:42:21 +0000 (UTC) (envelope-from melifaro@ipfw.ru) Received: from forward501o.mail.yandex.net (forward501o.mail.yandex.net [37.140.190.203]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 48YD3v1GhVz4YLK for ; Thu, 5 Mar 2020 14:42:18 +0000 (UTC) (envelope-from melifaro@ipfw.ru) Received: from mxback10q.mail.yandex.net (mxback10q.mail.yandex.net [IPv6:2a02:6b8:c0e:1b4:0:640:b6ef:cb3]) by forward501o.mail.yandex.net (Yandex) with ESMTP id 339761E8037A; Thu, 5 Mar 2020 17:42:15 +0300 (MSK) Received: from localhost (localhost [::1]) by mxback10q.mail.yandex.net (mxback/Yandex) with ESMTP id fDBBOOCanU-gE9mxaed; Thu, 05 Mar 2020 17:42:14 +0300 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ipfw.ru; s=mail; t=1583419334; bh=GCVnjsNC4tVUf9Tp7Pdrmm+p5LH9kxZo2lNnTKXrvqo=; h=References:Date:Message-Id:Subject:In-Reply-To:To:From; b=XCnNGVH6qORRy4YRLVpf+oi0BQKWk20eWnOU41WSDsIVkiZm8mPFD8HpSNctrS4gM VeisjxvYfWcUNuBsYeCp+OY3zL4PQ7eklLwt/2yKaGzQr6evdPli5S86TWEiTG3n29 mXJsQklKCjOFr4WY2Ta6CZUE2kV7ntd7AXtiUkkY= Received: by vla1-19f0dde8b070.qloud-c.yandex.net with HTTP; Thu, 05 Mar 2020 17:42:14 +0300 From: Alexander V. Chernikov To: Nick Hibma , FreeBSD Architecture Mailing List In-Reply-To: References: Subject: Re: change divert socket to use a sockaddr_div struct MIME-Version: 1.0 X-Mailer: Yamail [ http://yandex.ru ] 5.0 Date: Thu, 05 Mar 2020 14:42:14 +0000 Message-Id: <8181583419268@vla1-c477e3898c96.qloud-c.yandex.net> Content-Transfer-Encoding: 7bit Content-Type: text/plain X-Rspamd-Queue-Id: 48YD3v1GhVz4YLK X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=ipfw.ru header.s=mail header.b=XCnNGVH6; dmarc=none; spf=pass (mx1.freebsd.org: domain of melifaro@ipfw.ru designates 37.140.190.203 as permitted sender) smtp.mailfrom=melifaro@ipfw.ru X-Spamd-Result: default: False [-4.34 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-0.995,0]; R_DKIM_ALLOW(-0.20)[ipfw.ru:s=mail]; FROM_HAS_DN(0.00)[]; R_SPF_ALLOW(-0.20)[+ip4:37.140.128.0/18]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[ipfw.ru]; RCVD_COUNT_THREE(0.00)[3]; TO_MATCH_ENVRCPT_SOME(0.00)[]; TO_DN_ALL(0.00)[]; DKIM_TRACE(0.00)[ipfw.ru:+]; RCPT_COUNT_TWO(0.00)[2]; IP_SCORE(-1.74)[ipnet: 37.140.128.0/18(-4.89), asn: 13238(-3.84), country: RU(0.01)]; RCVD_IN_DNSWL_LOW(-0.10)[203.190.140.37.list.dnswl.org : 127.0.5.1]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:13238, ipnet:37.140.128.0/18, country:RU]; RCVD_TLS_LAST(0.00)[] X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 Mar 2020 14:42:21 -0000 27.02.2020, 09:16, "Nick Hibma" : > Folks, Hi Nick, > > We would like to use FIBs for routing, but currently cannot because the FIB is lost when the packet goes through a divert socket for processing. I've attached a patch that should fix this situation, and while there fix the limit of 7 characters for the interface name which some people got bitten by. This fix was suggested some time ago by Warner Losh. It looks like the patch got stripped by the mailing list. Could you please publish it on https://reviews.freebsd.org ? > > I've changed the sockaddr_in to a sockaddr_di struct to pass the FIB number and the complete interface, and other info in and out. But this seems to lead to memory corruption. Perhaps someone who knows the API can tell me where I should look for memory corruption issues, because this patch causes random crashes. I assume it's because of overwriting random memory. > > Thanks in advance. > > Nick Hibma > nick@van-laarhoven.org > > -- Open Source: We stand on the shoulders of giants. > > _______________________________________________ > freebsd-arch@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/freebsd-arch > To unsubscribe, send any mail to "freebsd-arch-unsubscribe@freebsd.org" From owner-freebsd-arch@freebsd.org Thu Mar 5 16:29:52 2020 Return-Path: Delivered-To: freebsd-arch@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 801BC26DD11 for ; Thu, 5 Mar 2020 16:29:52 +0000 (UTC) (envelope-from nick@van-laarhoven.org) Received: from violet.van-laarhoven.org (violet.van-laarhoven.org [IPv6:2a01:4f8:1c0c:72ba::3]) by mx1.freebsd.org (Postfix) with ESMTP id 48YGRy5WzNz3R2W for ; Thu, 5 Mar 2020 16:29:50 +0000 (UTC) (envelope-from nick@van-laarhoven.org) Received: from [192.168.177.3] (D4B295F2.static.ziggozakelijk.nl [212.178.149.242]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by violet.van-laarhoven.org (Postfix) with ESMTPSA id DDED29CE59; Thu, 5 Mar 2020 17:29:37 +0100 (CET) From: Nick Hibma Message-Id: Mime-Version: 1.0 (Mac OS X Mail 13.0 \(3608.60.0.2.5\)) Subject: Re: change divert socket to use a sockaddr_div struct Date: Thu, 5 Mar 2020 17:29:36 +0100 In-Reply-To: <8181583419268@vla1-c477e3898c96.qloud-c.yandex.net> Cc: FreeBSD Architecture Mailing List To: "Alexander V. Chernikov" References: <8181583419268@vla1-c477e3898c96.qloud-c.yandex.net> X-Mailer: Apple Mail (2.3608.60.0.2.5) X-Rspamd-Queue-Id: 48YGRy5WzNz3R2W X-Spamd-Bar: - Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of nick@van-laarhoven.org designates 2a01:4f8:1c0c:72ba::3 as permitted sender) smtp.mailfrom=nick@van-laarhoven.org X-Spamd-Result: default: False [-1.12 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; NEURAL_HAM_MEDIUM(-0.59)[-0.594,0]; FROM_HAS_DN(0.00)[]; R_SPF_ALLOW(-0.20)[+mx]; MV_CASE(0.50)[]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; DMARC_NA(0.00)[van-laarhoven.org]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; URI_COUNT_ODD(1.00)[9]; TO_MATCH_ENVRCPT_SOME(0.00)[]; TO_DN_ALL(0.00)[]; RCPT_COUNT_TWO(0.00)[2]; IP_SCORE(-0.83)[ipnet: 2a01:4f8::/29(-2.55), asn: 24940(-1.56), country: DE(-0.02)]; RCVD_NO_TLS_LAST(0.10)[]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+,1:+,2:~]; ASN(0.00)[asn:24940, ipnet:2a01:4f8::/29, country:DE]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_COUNT_TWO(0.00)[2] Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 Mar 2020 16:29:52 -0000 Thanks for the prod. I've created a diff in Phabricator: https://reviews.freebsd.org/D23972 I would appreciate comments on this. Nick Hibma nick@van-laarhoven.org -- Open Source: We stand on the shoulders of giants. > On 05/03 /2020, at 15:42, Alexander V. Chernikov = wrote: >=20 > 27.02.2020, 09:16, "Nick Hibma" : >> Folks, > Hi Nick, >>=20 >> We would like to use FIBs for routing, but currently cannot because = the FIB is lost when the packet goes through a divert socket for = processing. I've attached a patch that should fix this situation, and = while there fix the limit of 7 characters for the interface name which = some people got bitten by. This fix was suggested some time ago by = Warner Losh. > It looks like the patch got stripped by the mailing list. > Could you please publish it on https://reviews.freebsd.org ? >>=20 >> I've changed the sockaddr_in to a sockaddr_di struct to pass the FIB = number and the complete interface, and other info in and out. But this = seems to lead to memory corruption. Perhaps someone who knows the API = can tell me where I should look for memory corruption issues, because = this patch causes random crashes. I assume it's because of overwriting = random memory. >>=20 >> Thanks in advance. >>=20 >> Nick Hibma >> nick@van-laarhoven.org >>=20 >> -- Open Source: We stand on the shoulders of giants. >>=20 >> _______________________________________________ >> freebsd-arch@freebsd.org mailing list >> https://lists.freebsd.org/mailman/listinfo/freebsd-arch >> To unsubscribe, send any mail to = "freebsd-arch-unsubscribe@freebsd.org" >=20 From owner-freebsd-arch@freebsd.org Sat Mar 7 06:21:59 2020 Return-Path: Delivered-To: freebsd-arch@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id E0F0125C987 for ; Sat, 7 Mar 2020 06:21:59 +0000 (UTC) (envelope-from damjan.jov@gmail.com) Received: from mail-io1-xd36.google.com (mail-io1-xd36.google.com [IPv6:2607:f8b0:4864:20::d36]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 48ZDsg044lz3MSh for ; Sat, 7 Mar 2020 06:21:58 +0000 (UTC) (envelope-from damjan.jov@gmail.com) Received: by mail-io1-xd36.google.com with SMTP id f21so130697iol.6 for ; Fri, 06 Mar 2020 22:21:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=L2H00BoBGpHDbSQKleMsLiGGmpFiQaX7n9hcxGiaxqc=; b=Mb0xtQ1R/hYTYGd++6OJOn/jwijAYmVUR1WlUXTgydzhKjfGXKU+ZEoy80iSCsc0Ka kVMN6HrbaT1xIrsbbQNr7FJejXjh/8eYAp1PhjBpOjZJQWcSMBLJhtRkaZHDDjFxGeZ3 0+KLj4Mghegh2CnFsraWqHZbZVzKkFFVGmH9c0Tv/TrmSJ5JhWxL13mx+yxubZQaOasq NEu313PySTnkzC8VEw1Wi9dSvUrDmevDOei7dQEwQNybYMCy5AnLm6zJcBLRcS+RyGtd aMdPI5pUSkctjwQ0Xm+q8rSKemzNy2qFMZVyKV1uePTddqIEWL9wLFhCX3HewAFcQkzW cSiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=L2H00BoBGpHDbSQKleMsLiGGmpFiQaX7n9hcxGiaxqc=; b=TFCeJYzKXCBubLs46Cqy5c144ZHEKBMxEGcbDNrijtzrAU5tAYjO7GN4cpK4Vm8FNZ EXYkoxYkOvOC0W+74haZdlOUjLo/zKXPckMgx0Qq2aS4F9q4WZ7nLN6G2lXoTZ1qH5Ck njLoNVhWvAu9Nu0dcUXxQGDJoVJB/5QymN5oxRwvGYUA9DmElo1ObzWVb9IBU0Q4dI7x Gn2NLLc4aLzFrCyu5R+/kjIdx/lP7Ck3+fNDUMgaxJ0KplGEUHFCUz19lOqUl5nEQqbb 23SbxgaWLT2qbxbgOe6yOPo6K+ZqCZdKwpffmlcRRXI4XUrdknXp54K1VmXgd+8GNoKr N4VQ== X-Gm-Message-State: ANhLgQ3ryWQT2UPj1pvbnF+3TZC5NCxHUIBlTRnH5+Mq72eE6ZnjbDRQ 1ybrgqHh1clIgohe5tMFWaiXZPgidttBqwkmh/luqChKTd4= X-Google-Smtp-Source: ADFU+vukkVyPHgx5mfuN6L2Ha30iAoZe7qGFPAmwM0kx4m8Qqv8XPQKl+8nPnSH2IC6vVTrYAN6JOG7tdlf/CiqYvP0= X-Received: by 2002:a5e:c805:: with SMTP id y5mr5771677iol.193.1583562117993; Fri, 06 Mar 2020 22:21:57 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Damjan Jovanovic Date: Sat, 7 Mar 2020 08:21:46 +0200 Message-ID: Subject: Re: Removing: bktr(4) Brooktree Video Capture card To: Warner Losh Cc: "freebsd-arch@freebsd.org" X-Rspamd-Queue-Id: 48ZDsg044lz3MSh X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20161025 header.b=Mb0xtQ1R; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (mx1.freebsd.org: domain of damjanjov@gmail.com designates 2607:f8b0:4864:20::d36 as permitted sender) smtp.mailfrom=damjanjov@gmail.com X-Spamd-Result: default: False [-3.00 / 15.00]; TO_DN_EQ_ADDR_SOME(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36:c]; FREEMAIL_FROM(0.00)[gmail.com]; DKIM_TRACE(0.00)[gmail.com:+]; RCPT_COUNT_TWO(0.00)[2]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; FROM_EQ_ENVFROM(0.00)[]; IP_SCORE(0.00)[ip: (-6.46), ipnet: 2607:f8b0::/32(-1.86), asn: 15169(-1.65), country: US(-0.05)]; MIME_TRACE(0.00)[0:+,1:+,2:~]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; TAGGED_FROM(0.00)[]; DWL_DNSWL_NONE(0.00)[gmail.com.dwl.dnswl.org : 127.0.5.0]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20161025]; FROM_HAS_DN(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; PREVIOUSLY_DELIVERED(0.00)[freebsd-arch@freebsd.org]; IP_SCORE_FREEMAIL(0.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[6.3.d.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 07 Mar 2020 06:22:00 -0000 On Wed, Feb 26, 2020 at 2:46 AM Warner Losh wrote: > Greetings, > > I think that the time has come to remove bktr(4) from the tree. This is for > PCI-only hardware that can't do better than SD capture. For its time > (~2000) it was a cool card. However, it's no longer relevant to FreeBSD and > is completely unused as far as I can tell. The bread crumbs in my searches > end around 2006 in the NYCBUG dmesg database. > > Comments? > > Among emulated network cards in a VM/emulator, a FreeBSD guest is more likely to find the NE2000 than the latest 100 Gbps Ethernet card, among emulated graphics cards, the Voodoo 3dfx (which DOSBox and MAME already support) instead of the latest NVidia card. VirtualBox can already emulate a webcam to the guest. I am not sure what device it emulates, and doubt it uses bktr(4), but my point is, operating systems are likely to find old "hardware" when running as a guest. Retrocomputing is also a thing. Damjan From owner-freebsd-arch@freebsd.org Sat Mar 7 17:04:41 2020 Return-Path: Delivered-To: freebsd-arch@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 4B35726A941 for ; Sat, 7 Mar 2020 17:04:41 +0000 (UTC) (envelope-from linimon@lonesome.com) Received: from mail.soaustin.net (mail.soaustin.net [18.222.6.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mail.soaustin.net", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 48ZW7D4H2cz4GtN for ; Sat, 7 Mar 2020 17:04:40 +0000 (UTC) (envelope-from linimon@lonesome.com) Received: from lonesome.com (unknown [18.188.142.31]) by mail.soaustin.net (Postfix) with ESMTPSA id 9CB1413AD6; Sat, 7 Mar 2020 17:04:39 +0000 (UTC) Date: Sat, 7 Mar 2020 17:04:38 +0000 From: Mark Linimon To: Damjan Jovanovic Cc: Warner Losh , "freebsd-arch@freebsd.org" Subject: Re: Removing: bktr(4) Brooktree Video Capture card Message-ID: <20200307170437.GB8125@lonesome.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-Rspamd-Queue-Id: 48ZW7D4H2cz4GtN X-Spamd-Bar: - Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=none (mx1.freebsd.org: domain of linimon@lonesome.com has no SPF policy when checking 18.222.6.11) smtp.mailfrom=linimon@lonesome.com X-Spamd-Result: default: False [-1.10 / 15.00]; ARC_NA(0.00)[]; TO_DN_EQ_ADDR_SOME(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; TO_DN_SOME(0.00)[]; IP_SCORE(-0.17)[ip: (0.04), ipnet: 18.220.0.0/14(0.19), asn: 16509(-1.05), country: US(-0.05)]; TAGGED_RCPT(0.00)[]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[lonesome.com]; AUTH_NA(1.00)[]; NEURAL_HAM_LONG(-0.99)[-0.985,0]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_IN_DNSWL_MED(-0.20)[11.6.222.18.list.dnswl.org : 127.0.5.2]; NEURAL_HAM_MEDIUM(-0.64)[-0.636,0]; R_SPF_NA(0.00)[]; FREEMAIL_TO(0.00)[gmail.com]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:16509, ipnet:18.220.0.0/14, country:US]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_TLS_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2] X-Mailman-Approved-At: Sat, 07 Mar 2020 20:07:58 +0000 X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 07 Mar 2020 17:04:41 -0000 bktr(4) is a card that allowed people (including me) to have a small window running in which I could watch my cable TV feed. Its usable timeframe was around 18-24 months. I have not used my own card since it was last installed in a machine which IIRC was running Windows 2000. Please go back and look at the original proposal; it detailed what we look for when deprecate things. mcl