From owner-freebsd-current@freebsd.org Sun Jul 19 23:34:36 2020 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 4776A36CCD0 for ; Sun, 19 Jul 2020 23:34:36 +0000 (UTC) (envelope-from rmacklem@uoguelph.ca) Received: from CAN01-QB1-obe.outbound.protection.outlook.com (mail-eopbgr660045.outbound.protection.outlook.com [40.107.66.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mail.protection.outlook.com", Issuer "GlobalSign Organization Validation CA - SHA256 - G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4B91RG2NgMz4Bx0; Sun, 19 Jul 2020 23:34:33 +0000 (UTC) (envelope-from rmacklem@uoguelph.ca) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QdKyiEveEmVe/tZ3zz+6SaYinXBmVvB8/2rGmsdDq03mrocUgvBZk1hG4bTcbpsVHGs9tFIg4CwkCqQ6VR24BsCDA3neMHANBOBdnqBggAbuVGzrw6bgEQfAjW+vZGysjotDNItsQQA4W/ol/EKWdOPhfXKPG90hc4B5PFWF2FMFQ7mUcdH10olAhjgi4Q7lYIflToZmaOOCchYRWSsizytT78o0ZrpQyfkcv6ouFSr9o5cfa49ttHZ/O7jZljvU++vQSi8F2JZoU9W2W6MUHb/6nMPAD8lCbqpjpuIF02b3BI1DsSKHpolGAZnviKP+2WqjYvz64XynFzFge5m+Bw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qsv7M4SzoDBvhWytsfEr52wNquIgVfhSQrpCWHlkeF4=; b=njlzEl7+morRKbVjIvPTO9e99y4R2sUHo6y5Kq2AY8MMLiiWqSfltdyS5NlHglpPyF+1BNNq5vGlOwjfwXs+kyuD+PeluRe2j+E04qeunYuPSIyBsQQhh47Ij4uFIjavDMw9eo/TST0LZZL3iRlTHr1yFShzCQbmxTSp69ruV3FCcwI8XwlyTF4nGSr/6fwoB9hPzbmpbCYAMb4tyDoKC2zrntHi3SoUI01cTrYbMo6d2jxv0UocBuBrGlbXYJKGPp6Il1LfIpv1WVQR850jNZgg/9v8xNkMw2iwqG9G2GpyiisISbed+RRiGVT4H6B7dtLsNA00SnMADD4heyov0w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=uoguelph.ca; dmarc=pass action=none header.from=uoguelph.ca; dkim=pass header.d=uoguelph.ca; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=uoguelph.ca; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qsv7M4SzoDBvhWytsfEr52wNquIgVfhSQrpCWHlkeF4=; b=KsTdFcOVeXKN8N7VrnaOoOQuf/mSQg7XJk2obdpDQIzmC3Fg36I5M0oUxugt35/1Ao53CO9qqP4Wb+FfX0rHoLOV7VQErg7io+e2vlW2o++S6tG6sSUK2CHj1XDBx8mTVH5n9wNdIetRJbCy2Qpj3J211vTyjWiONZ8vFrvEnDhTr564oS/fZhYGbLz0rdIctUku86Wx8RhTQhjF6HZVU0GgOiSTsOHXvE32RGvO+JYV99GPrQrdrnPmf2Vj6SRfNrLBtDuMNyv8udtd28EkOGs3K75OjIJ1cfLLOr/x616ZvKcg7Qo4ga0Su3kS0AGADxlV1gEccwM03uGxlx1f3g== Received: from QB1PR01MB3364.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c00:38::14) by YQXPR01MB3205.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c00:43::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3195.25; Sun, 19 Jul 2020 23:34:32 +0000 Received: from QB1PR01MB3364.CANPRD01.PROD.OUTLOOK.COM ([fe80::60f3:4ca2:8a4a:1e91]) by QB1PR01MB3364.CANPRD01.PROD.OUTLOOK.COM ([fe80::60f3:4ca2:8a4a:1e91%7]) with mapi id 15.20.3195.025; Sun, 19 Jul 2020 23:34:24 +0000 From: Rick Macklem To: "freebsd-current@FreeBSD.org" CC: "jhb@FreeBSD.org" , "gallatin@freebsd.org" , Gleb Smirnoff Subject: RFC: ktls and krpc using M_EXTPG mbufs Thread-Topic: RFC: ktls and krpc using M_EXTPG mbufs Thread-Index: AQHWXiFLFxOPU111VUSvS2ovnXgBPw== Date: Sun, 19 Jul 2020 23:34:24 +0000 Message-ID: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 7a5fccc3-c70a-4562-7133-08d82c3c4578 x-ms-traffictypediagnostic: YQXPR01MB3205: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6790; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: O7nWW6g6PbLhe8yxbHSaMlnDxENXU/uenvC4gtziw4hCTpJjNFStwuHn0gdv418Yg9opjuWdRCw9FcJ8dDQ8mGUr2g4R7nu1IWc/yXWxmn3+G3BCOah9ZwX3XTOClsYm0HUJqPdn8WwT6hj3LQVeLJf0hKJwkpuOkyf2u21m+G8RvH1MtFdfThxyK8mYaAj12w6C/BqKn90lWtcazg32DFS4pL0ReBj9JMEWGG4dIjqFLmqX/v3bHFkucSc5+5Edt1LgHHXjmC4zRiOu2NYv1sK5stPwU8f/3vXEL3uZdl7l5MliYUH8yva1sduoCwJQEEHKkC11NLdpxVvuqg2eMQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:QB1PR01MB3364.CANPRD01.PROD.OUTLOOK.COM; PTR:; CAT:NONE; SFTY:; SFS:(39850400004)(396003)(376002)(366004)(346002)(136003)(9686003)(186003)(786003)(316002)(7696005)(83380400001)(55016002)(33656002)(6916009)(6506007)(450100002)(4326008)(64756008)(8676002)(2906002)(52536014)(8936002)(54906003)(71200400001)(5660300002)(86362001)(66556008)(91956017)(76116006)(66446008)(66946007)(478600001)(66476007); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: valzXIRInwUjAtPSaGnc2oMOiRmkaEI+jRsZRVEGQ3ZFFU/RBG8uhpALimKiua9UhsKxRq8lQWjCWepypyGzmwQeYlt3MSv9SrvghMesWCQNm6OqRh6GdqANP8xW1MMosjP2m3uQUYHX2X2z7BFLh/Pb94ylSZV7A0o970SdxeV9L0xsw57zUKw4F78kZrWRWs2ADKZo700dUoLRZRiEJ3R6MD7BzcmCdKGj+3m0Dec3AVCQAuqWWrfHq1njL3xFoKLkHKZM/9iGMzEporLuWV11PIOfx6Dd1J+QfwPoifiGl4Qdh5/jlmHYA5gdiZ8FigH/zajSkLDtk6+SiicAVVB6/L8lqEutarSFDiRr858OdXXN9/sdu1QaGqQ5UGzhFI6qdvLTEgVygAk1kjhwt7jeSZtIjn0eYLjMQmu9If3HWSZ7+cn5EK3Bm2028F0lxmHvvYm0IdrL6EmtV4KHb1fOW20l911JuOP2wSa8Eu2nbOJMXc2oUSHYOKbHCm16egvoRulyrCbq0BSWOj+zZWzAZwzjFK8j777cLCUTXeU= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: uoguelph.ca X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: QB1PR01MB3364.CANPRD01.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-Network-Message-Id: 7a5fccc3-c70a-4562-7133-08d82c3c4578 X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Jul 2020 23:34:24.7236 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: be62a12b-2cad-49a1-a5fa-85f4f3156a7d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: SJi85S08s6GkeOGsP3B1iRdKZ4KLEW3XuJeKVTzsOXvjuxdx8I3AWAt8vVCg+FV5zU2OHCkQZIjNs1YLsxYaig== X-MS-Exchange-Transport-CrossTenantHeadersStamped: YQXPR01MB3205 X-Rspamd-Queue-Id: 4B91RG2NgMz4Bx0 X-Spamd-Bar: ----- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=uoguelph.ca header.s=selector1 header.b=KsTdFcOV; dmarc=none; spf=pass (mx1.freebsd.org: domain of rmacklem@uoguelph.ca designates 40.107.66.45 as permitted sender) smtp.mailfrom=rmacklem@uoguelph.ca X-Spamd-Result: default: False [-5.39 / 15.00]; TO_DN_EQ_ADDR_SOME(0.00)[]; NEURAL_HAM_MEDIUM(-1.03)[-1.031]; R_DKIM_ALLOW(-0.20)[uoguelph.ca:s=selector1]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; R_SPF_ALLOW(-0.20)[+ip4:40.107.0.0/16]; DMARC_NA(0.00)[uoguelph.ca]; DWL_DNSWL_LOW(-1.00)[uoguelph.ca:dkim]; RCVD_COUNT_THREE(0.00)[3]; DKIM_TRACE(0.00)[uoguelph.ca:+]; NEURAL_HAM_SHORT(-0.89)[-0.893]; RCVD_IN_DNSWL_NONE(0.00)[40.107.66.45:from]; NEURAL_HAM_LONG(-0.97)[-0.967]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_TLS_LAST(0.00)[]; ASN(0.00)[asn:8075, ipnet:40.104.0.0/14, country:US]; ARC_ALLOW(-1.00)[microsoft.com:s=arcselector9901:i=1]; RWL_MAILSPIKE_POSSIBLE(0.00)[40.107.66.45:from] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 19 Jul 2020 23:34:36 -0000 I spent a little time chasing a problem in the nfs-over-tls code, where it= =0A= would sometimes end up with corrupted data in the file(s) of a mirrored=0A= pNFS configuration.=0A= =0A= I think the problem was that the code filled the data to be written into=0A= anonymous page M_EXTPG mbufs, then did a m_copym() { copy by=0A= reference } and used the copies for the mirrored writes.=0A= --> In ktls_encrypt(), the encryption was done to the same pages and,=0A= sometimes, the encrypted data got encrypted again during the=0A= sosend() of the other copy.=0A= =0A= Although I haven't reproduced it, a regular kernel write RPC could suffer t= he=0A= same consequences if the RPC is retried (it keeps an m_copym() copy=0A= of the request in the krpc for an RPC retry).=0A= =0A= At this time, the code in projects/nfs-over-tls works correctly, since it= =0A= always fills the data to be written into mbuf clusters, m_copym()s those=0A= and then copies those { real copying using memcpy() } via=0A= mb_mapped_to_unmapped() just before calling sosend().=0A= --> This works, but it would be nice to avoid the mb_mapped_to_unmapped()= =0A= copying for all the data being written via an NFS over TLS connection= .=0A= =0A= For the TCP_TLS_MODE_SW case:=0A= --> The NFS code can fill the written data into anonymous pages on M_EXTPG= =0A= mbufs.=0A= Then, the ktls_encrypt() could be modified to=0A= allocate a new set of anonymous pages for the destination side of=0A= the encryption (it already does this for the sendfile case) and put those= =0A= in a new mbuf list.=0A= --> This would result in new anonymous pages and mbufs being allocated,=0A= but would not do memcpy()s.=0A= After encryption, it would just do a m_freem() on the unencrypted list.=0A= --> For the krpc client case, this call would only decrement the reference= =0A= count on the unencrypted list and it could be used for a retry by the= krpc=0A= and then be free'd { m_freem() call } after a reply is received.=0A= =0A= If doing this for all the sosend()s of anonymous page M_EXTPG mbufs seems= =0A= like unnecessary overhead, the above could be enabled via a setsockopt()=0A= on the socket.=0A= =0A= What do others think of this?=0A= =0A= For the hardware offload case:=0A= - Can I assume that the anonymous pages in M_EXTPG mbufs will remain=0A= unchanged?=0A= --> If so, and it won't change to TCP_TLS_MODE_SW, the NFS code could=0A= fill the data to be written into M_EXTPG mbufs safely.=0A= =0A= - And, if so, can I safely use the ktls_session mode field to decide if off= load=0A= is happening?=0A= I see the TCP_TXTLS_MODE socket opt which seems to=0A= switch the mode to TCP_TLS_MODE_SW.=0A= When does this happen? Or, can this happen to a session once in use?=0A= =0A= Thanks for any/all comments on this, rick=0A= =0A= From owner-freebsd-current@freebsd.org Mon Jul 20 10:41:10 2020 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 0AE4B3585C0; Mon, 20 Jul 2020 10:41:10 +0000 (UTC) (envelope-from lwhsu@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2610:1c1:1:6074::16:84]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "freefall.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4B9JDP4lYLz3Wvw; Mon, 20 Jul 2020 10:41:09 +0000 (UTC) (envelope-from lwhsu@freebsd.org) Received: by freefall.freebsd.org (Postfix, from userid 1129) id 6F442B24C; Mon, 20 Jul 2020 10:41:09 +0000 (UTC) Date: Mon, 20 Jul 2020 10:41:09 +0000 From: Li-Wen Hsu To: freebsd-testing@freebsd.org Cc: freebsd-current@freebsd.org, freebsd-stable@freebsd.org Subject: FreeBSD CI Weekly Report 2020-07-19 Message-ID: <20200720104109.GA21360@freefall.freebsd.org> Reply-To: freebsd-testing@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 20 Jul 2020 10:41:10 -0000 (Please send the followup to freebsd-testing@ and note Reply-To is set.) FreeBSD CI Weekly Report 2020-07-19 =================================== Here is a summary of the FreeBSD Continuous Integration results for the period from 2020-07-13 to 2020-07-19. During this period, we have: * 1699 builds (93.3% (-2.4) passed, 6.7% (+2.4) failed) of buildworld and buildkernel (GENERIC and LINT) were executed on aarch64, amd64, armv6, armv7, i386, mips, mips64, powerpc, powerpc64, powerpcspe, riscv64, sparc64 architectures for head, stable/12, stable/11 branches. * 191 test runs (88.0% (+1.3) passed, 12.0% (+0) unstable, 0% (-1.3) exception) were executed on amd64, i386, riscv64 architectures for head, stable/12, stable/11 branches. * 36 doc and www builds (100% (+0) passed) Test case status (on 2020-07-19 23:59): | Branch/Architecture | Total | Pass | Fail | Skipped | | ------------------- | -------- | --------- | ----- | ------- | | head/amd64 | 7859 (0) | 7768 (+1) | 0 (0) | 91 (-1) | | head/i386 | 7857 (0) | 7759 (+1) | 0 (0) | 98 (-1) | | 12-STABLE/amd64 | 7617 (0) | 7557 (0) | 0 (0) | 60 (0) | | 12-STABLE/i386 | 7615 (0) | 7550 (+3) | 0 (0) | 65 (-3) | | 11-STABLE/amd64 | 6912 (0) | 6861 (0) | 0 (0) | 51 (0) | | 11-STABLE/i386 | 6910 (0) | 6854 (0) | 0 (0) | 56 (0) | (The statistics from experimental jobs are omitted) If any of the issues found by CI are in your area of interest or expertise please investigate the PRs listed below. The latest web version of this report is available at https://hackmd.io/@FreeBSD-CI/report-20200719 and archive is available at https://hackmd.io/@FreeBSD-CI/ , any help is welcomed. ## Failing jobs * https://ci.freebsd.org/job/FreeBSD-head-amd64-gcc6_build/ ``` /usr/local/bin/x86_64-unknown-freebsd12.1-ld: /tmp/obj/workspace/src/amd64.amd64/lib/clang/liblldb/liblldb.a(IOHandlerCursesGUI.o): in function `curses::Window::Box(unsigned int, unsigned int)': /workspace/src/contrib/llvm-project/lldb/source/Core/IOHandlerCursesGUI.cpp:361: undefined reference to `box' /usr/local/bin/x86_64-unknown-freebsd12.1-ld: /workspace/src/contrib/llvm-project/lldb/source/Core/IOHandlerCursesGUI.cpp:361: undefined reference to `box' collect2: error: ld returned 1 exit status ``` From kevans@: one of ncurses' scripts that generates box and a bunch of other symbols is shooting blanks with gcc6, however it seems fine on gcc9. ## Regressions * lib.libexecinfo.backtrace_test.backtrace_fmt_basic starts failing on amd64 after r360915 https://bugs.freebsd.org/246537 * lib.msun.ctrig_test.test_inf_inputs starts failing after llvm10 import https://bugs.freebsd.org/244732 * Lock-order reversals triggered by tests under sys.net.if_lagg_test.* on i386 https://bugs.freebsd.org/244163 Discovered by newly endabled sys.net.* tests. ([r357857](https://svnweb.freebsd.org/changeset/base/357857)) * sys.net.if_lagg_test.lacp_linkstate_destroy_stress panics i386 kernel https://bugs.freebsd.org/244168 Discovered by newly endabled sys.net.* tests. ([r357857](https://svnweb.freebsd.org/changeset/base/357857)) Fix in review: https://reviews.freebsd.org/D25284 ## Failing and Flaky tests (from experimental jobs) * https://ci.freebsd.org/job/FreeBSD-head-amd64-dtrace_test/ * cddl.usr.sbin.dtrace.common.misc.t_dtrace_contrib.tst_dynopt_d * https://bugs.freebsd.org/237641 * https://ci.freebsd.org/job/FreeBSD-head-amd64-test_zfs/ * There are ~13 failing and ~109 skipped cases, including flakey ones, see https://ci.freebsd.org/job/FreeBSD-head-amd64-test_zfs/lastCompletedBuild/testReport/ for more details * Work for cleaning these failing cass are in progress * https://ci.freebsd.org/job/FreeBSD-head-amd64-test_ltp/ * Total 3749 tests, 2277 success, 647 failures, 825 skipped ## Disabled Tests * sys.fs.tmpfs.mount_test.large https://bugs.freebsd.org/212862 * sys.fs.tmpfs.link_test.kqueue https://bugs.freebsd.org/213662 * sys.kqueue.libkqueue.kqueue_test.main https://bugs.freebsd.org/233586 * sys.kern.ptrace_test.ptrace__PT_KILL_competing_stop https://bugs.freebsd.org/220841 * lib.libc.regex.exhaust_test.regcomp_too_big (i386 only) https://bugs.freebsd.org/237450 * sys.netinet.socket_afinet.socket_afinet_bind_zero https://bugs.freebsd.org/238781 * sys.netpfil.pf.names.names * sys.netpfil.pf.synproxy.synproxy https://bugs.freebsd.org/238870 * sys.kern.ptrace_test.ptrace__follow_fork_child_detached_unrelated_debugger https://bugs.freebsd.org/239292 * sys.kern.ptrace_test.ptrace__follow_fork_both_attached_unrelated_debugger https://bugs.freebsd.org/239397 * sys.kern.ptrace_test.ptrace__parent_sees_exit_after_child_debugger https://bugs.freebsd.org/239399 * sys.kern.ptrace_test.ptrace__follow_fork_parent_detached_unrelated_debugger https://bugs.freebsd.org/239425 * sys.sys.qmath_test.qdivq_s64q https://bugs.freebsd.org/240219 * sys.kern.ptrace_test.ptrace__getppid https://bugs.freebsd.org/240510 * lib.libc.sys.stat_test.stat_socket https://bugs.freebsd.org/240621 * lib.libarchive.functional_test.test_write_filter_zstd https://bugs.freebsd.org/240683 * lib.libcasper.services.cap_dns.dns_test.main https://bugs.freebsd.org/241435 * local.kyua.* (31 cases) & local.lutok.* (3 cases) on 11-i386 https://ci.freebsd.org/job/FreeBSD-stable-11-i386-test/2278/testReport/ * sys.kern.ptrace_test.ptrace__procdesc_reparent_wait_child https://bugs.freebsd.org/243605 * sys.kern.ptrace_test.ptrace__parent_wait_after_attach https://bugs.freebsd.org/244055 * sys.kern.ptrace_test.ptrace__parent_exits_before_child https://bugs.freebsd.org/244056 * sys.net.if_lagg_test.witness (i386) https://bugs.freebsd.org/244163 * PipePdfork.WildcardWait in sys.capsicum.capsicum-test.main https://bugs.freebsd.org/244165 * sys.net.if_lagg_test.lacp_linkstate_destroy_stress (i386) https://bugs.freebsd.org/244168 * sys.netinet6.frag6.frag6_07.frag6_07 https://bugs.freebsd.org/244170 * sys.netinet.fibs_test.udp_dontroute6 https://bugs.freebsd.org/244172 * sys.netpfil.pf.nat.exhaust https://bugs.freebsd.org/244703 * sys.geom.class.gate.ggate_test.ggated (i386) https://bugs.freebsd.org/244737 * sys.kern.sysv_test.msg https://bugs.freebsd.org/233649 ## Issues ### Cause build fails * https://bugs.freebsd.org/233769 Possible build race: ld: error: unable to find library -lgcc_s ### Cause kernel panics * https://bugs.freebsd.org/238870 sys.netpfil.pf.names.names and sys.netpfil.pf.synproxy.synproxy cause panic ### Open * https://bugs.freebsd.org/237403 Tests in sys/opencrypto should be converted to Python3 * https://bugs.freebsd.org/237641 Flakey test case: common.misc.t_dtrace_contrib.tst_dynopt_d * https://bugs.freebsd.org/237656 "Freed UMA keg (rtentry) was not empty (18 items). Lost 1 pages of memory." seen when running sys/netipsec tests * https://bugs.freebsd.org/238781 sys.netinet.socket_afinet.socket_afinet_bind_zero does not work when mac_portacl(4) loaded * https://bugs.freebsd.org/239292 Flakey test case: sys.kern.ptrace_test.ptrace__follow_fork_child_detached_unrelated_debugger * https://bugs.freebsd.org/239397 Flakey test case: sys.kern.ptrace_test.ptrace__follow_fork_both_attached_unrelated_debugger * https://bugs.freebsd.org/239399 Flakey test case: sys.kern.ptrace_test.ptrace__parent_sees_exit_after_child_debugger * https://bugs.freebsd.org/239425 Flakey test case: sys.kern.ptrace_test.ptrace__follow_fork_parent_detached_unrelated_debugger * https://bugs.freebsd.org/241662 Flakey test case: lib.libarchive.functional_test.test_fuzz_iso9660 * https://bugs.freebsd.org/246443 sys.net.if_clone_test.epair_stress sometimes exceeds timeout limit but not caught by kyua * https://bugs.freebsd.org/247510 sys.net.if_lagg_test.status_stress panics kernel on i386 ### Others * [Tickets related to testing@](https://preview.tinyurl.com/y9maauwg) From owner-freebsd-current@freebsd.org Mon Jul 20 19:12:15 2020 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id CF656367576; Mon, 20 Jul 2020 19:12:15 +0000 (UTC) (envelope-from jmg@gold.funkthat.com) Received: from gold.funkthat.com (gate2.funkthat.com [208.87.223.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "gate2.funkthat.com", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4B9WZ66lNZz4SFB; Mon, 20 Jul 2020 19:12:14 +0000 (UTC) (envelope-from jmg@gold.funkthat.com) Received: from gold.funkthat.com (localhost [127.0.0.1]) by gold.funkthat.com (8.15.2/8.15.2) with ESMTPS id 06KJCDO9045685 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Mon, 20 Jul 2020 12:12:13 -0700 (PDT) (envelope-from jmg@gold.funkthat.com) Received: (from jmg@localhost) by gold.funkthat.com (8.15.2/8.15.2/Submit) id 06KJCD7n045684; Mon, 20 Jul 2020 12:12:13 -0700 (PDT) (envelope-from jmg) Date: Mon, 20 Jul 2020 12:12:13 -0700 From: John-Mark Gurney To: freebsd-net@FreeBSD.org, freebsd-current@FreeBSD.org Subject: test suite for NIC features... Message-ID: <20200720191213.GB4213@funkthat.com> Mail-Followup-To: freebsd-net@FreeBSD.org, freebsd-current@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Operating-System: FreeBSD 11.3-STABLE amd64 X-PGP-Fingerprint: D87A 235F FB71 1F3F 55B7 ED9B D5FF 5A51 C0AC 3D65 X-Files: The truth is out there X-URL: https://www.funkthat.com/ X-Resume: https://www.funkthat.com/~jmg/resume.html X-TipJar: bitcoin:13Qmb6AeTgQecazTWph4XasEsP7nGRbAPE X-to-the-FBI-CIA-and-NSA: HI! HOW YA DOIN? can i haz chizburger? User-Agent: Mutt/1.6.1 (2016-04-27) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.4.3 (gold.funkthat.com [127.0.0.1]); Mon, 20 Jul 2020 12:12:13 -0700 (PDT) X-Rspamd-Queue-Id: 4B9WZ66lNZz4SFB X-Spamd-Bar: ++ Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=none (mx1.freebsd.org: domain of jmg@gold.funkthat.com has no SPF policy when checking 208.87.223.18) smtp.mailfrom=jmg@gold.funkthat.com X-Spamd-Result: default: False [2.72 / 15.00]; RCVD_TLS_ALL(0.00)[]; ARC_NA(0.00)[]; FROM_HAS_DN(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_SPAM_SHORT(0.24)[0.240]; MIME_GOOD(-0.10)[text/plain]; TO_DN_NONE(0.00)[]; DMARC_NA(0.00)[funkthat.com]; AUTH_NA(1.00)[]; NEURAL_SPAM_MEDIUM(0.63)[0.632]; RCPT_COUNT_TWO(0.00)[2]; NEURAL_SPAM_LONG(0.65)[0.650]; R_SPF_NA(0.00)[no SPF record]; FORGED_SENDER(0.30)[jmg@funkthat.com,jmg@gold.funkthat.com]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:32354, ipnet:208.87.216.0/21, country:US]; MID_RHS_MATCH_FROM(0.00)[]; FROM_NEQ_ENVFROM(0.00)[jmg@funkthat.com,jmg@gold.funkthat.com]; RCVD_COUNT_TWO(0.00)[2] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 20 Jul 2020 19:12:15 -0000 Has anyone compiled a script/test suite for testing various NIC features to make sure they work/function properly? That is, being able to run a couple interfaces back to back, and turn off the features off on one, and make sure things like checksum offload and the like work properly? -- John-Mark Gurney Voice: +1 415 225 5579 "All that I will do, has been done, All that I have, has not." From owner-freebsd-current@freebsd.org Mon Jul 20 19:21:46 2020 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 766B536801B; Mon, 20 Jul 2020 19:21:46 +0000 (UTC) (envelope-from pi@opsec.eu) Received: from home.opsec.eu (home.opsec.eu [IPv6:2001:14f8:200::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4B9Wn45xm4z4Tbp; Mon, 20 Jul 2020 19:21:44 +0000 (UTC) (envelope-from pi@opsec.eu) Received: from pi by home.opsec.eu with local (Exim 4.92.3 (FreeBSD)) (envelope-from ) id 1jxbLy-000FE3-Cr; Mon, 20 Jul 2020 21:21:34 +0200 Date: Mon, 20 Jul 2020 21:21:34 +0200 From: Kurt Jaeger To: freebsd-net@freebsd.org, freebsd-current@freebsd.org Subject: Re: test suite for NIC features... Message-ID: <20200720192134.GC5015@home.opsec.eu> References: <20200720191213.GB4213@funkthat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200720191213.GB4213@funkthat.com> X-Rspamd-Queue-Id: 4B9Wn45xm4z4Tbp X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of pi@opsec.eu designates 2001:14f8:200::1 as permitted sender) smtp.mailfrom=pi@opsec.eu X-Spamd-Result: default: False [-2.56 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-0.89)[-0.889]; FROM_HAS_DN(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; R_SPF_ALLOW(-0.20)[+mx]; MIME_GOOD(-0.10)[text/plain]; TO_DN_NONE(0.00)[]; DMARC_NA(0.00)[opsec.eu]; NEURAL_HAM_LONG(-1.01)[-1.011]; NEURAL_HAM_SHORT(-0.36)[-0.363]; RCPT_COUNT_TWO(0.00)[2]; FROM_EQ_ENVFROM(0.00)[]; RCVD_TLS_LAST(0.00)[]; R_DKIM_NA(0.00)[]; ASN(0.00)[asn:12502, ipnet:2001:14f8::/32, country:DE]; MIME_TRACE(0.00)[0:+]; RCVD_COUNT_TWO(0.00)[2] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 20 Jul 2020 19:21:46 -0000 Hi! > Has anyone compiled a script/test suite for testing various NIC > features to make sure they work/function properly? > > That is, being able to run a couple interfaces back to back, and turn > off the features off on one, and make sure things like checksum offload > and the like work properly? I don't know of any project of that kind, but it sounds very useful. -- pi@opsec.eu +49 171 3101372 Now what ? From owner-freebsd-current@freebsd.org Mon Jul 20 22:56:34 2020 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id C2F0336C216; Mon, 20 Jul 2020 22:56:34 +0000 (UTC) (envelope-from mmacy@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4B9cXy3VGVz4g3M; Mon, 20 Jul 2020 22:56:34 +0000 (UTC) (envelope-from mmacy@freebsd.org) Received: from mail-lf1-f51.google.com (mail-lf1-f51.google.com [209.85.167.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) (Authenticated sender: mmacy) by smtp.freebsd.org (Postfix) with ESMTPSA id 565E01D9E2; Mon, 20 Jul 2020 22:56:34 +0000 (UTC) (envelope-from mmacy@freebsd.org) Received: by mail-lf1-f51.google.com with SMTP id u12so10598371lff.2; Mon, 20 Jul 2020 15:56:34 -0700 (PDT) X-Gm-Message-State: AOAM5326c6IZFEwxjVGV26lAo7xLdUdlT9pL56aoDI7UfoIhJ/u6ya5e ptmhcE/TyEeVVJ3IS5emfBAapc2/dK/3iwoRzJ8= X-Google-Smtp-Source: ABdhPJyybhoOwXo3KGOOm6PHWsvpvL+V4+z3eHcXTkIWSCzyU+SOXXYfEufND/xd+h77Y1nHHWkLhFJoQx684BSM4ok= X-Received: by 2002:ac2:51a1:: with SMTP id f1mr11992204lfk.173.1595285792273; Mon, 20 Jul 2020 15:56:32 -0700 (PDT) MIME-Version: 1.0 From: Matthew Macy Date: Mon, 20 Jul 2020 15:56:20 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: CFT for vendor openzfs - week 3 reminder To: freebsd-current , freebsd-fs , freebsd-hackers@freebsd.org Content-Type: text/plain; charset="UTF-8" X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 20 Jul 2020 22:56:34 -0000 On Wednesday, July 8th I issued the initial call for testing for the update to HEAD to vendored openzfs. We'd like to give users roughly a month to test before merging. I'm pushing the tentative merge date out by a week to August 17th as I wasn't able to spend any time working on this myself last week. Again, I hope it's not terribly controversial to point out that it really rests with users of non amd64 platforms to test to avoid any unpleasant surprises the next time they update their trees following the merge. ========================================================== NB: Do NOT zpool upgrade unless you are willing to live without the ability to ever rollback to the legacy zfs kmod. Checkout updated HEAD: % git clone https://github.com/mattmacy/networking.git -b projects/openzfs_vendor freebsd Checkout updated openzfs in to sys/contrib: % git clone https://github.com/zfsonfreebsd/ZoF.git -b projects/openzfs_vendor freebsd/sys/contrib/openzfs Build world and kernel with whatever your usual configuration is. Where possible the openzfs kmod is backward compatible with the cmd utils in HEAD so common operations work with existing tools and the new kmod. In the projects/openzfs_vendor branch of ZoF ozfs libraries are backward compatible with the zfs kmod in HEAD. Although ideally one would test this in a separate boot environment, the interoperability should allow one to rollback without too much difficulty. Thanks in advance for your time. From owner-freebsd-current@freebsd.org Tue Jul 21 09:16:59 2020 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id DDF0337C98A; Tue, 21 Jul 2020 09:16:59 +0000 (UTC) (envelope-from jmg@gold.funkthat.com) Received: from gold.funkthat.com (gate2.funkthat.com [208.87.223.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "gate2.funkthat.com", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4B9tJp4NLqz4MZp; Tue, 21 Jul 2020 09:16:57 +0000 (UTC) (envelope-from jmg@gold.funkthat.com) Received: from gold.funkthat.com (localhost [127.0.0.1]) by gold.funkthat.com (8.15.2/8.15.2) with ESMTPS id 06L9GtIH082111 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Tue, 21 Jul 2020 02:16:55 -0700 (PDT) (envelope-from jmg@gold.funkthat.com) Received: (from jmg@localhost) by gold.funkthat.com (8.15.2/8.15.2/Submit) id 06L9Gtul082110; Tue, 21 Jul 2020 02:16:55 -0700 (PDT) (envelope-from jmg) Date: Tue, 21 Jul 2020 02:16:55 -0700 From: John-Mark Gurney To: freebsd-net@FreeBSD.org, freebsd-current@FreeBSD.org Subject: somewhat reproducable vimage panic Message-ID: <20200721091654.GC4213@funkthat.com> Mail-Followup-To: freebsd-net@FreeBSD.org, freebsd-current@FreeBSD.org MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="tK3TaB1xs9ylLrl6" Content-Disposition: inline X-Operating-System: FreeBSD 11.3-STABLE amd64 X-PGP-Fingerprint: D87A 235F FB71 1F3F 55B7 ED9B D5FF 5A51 C0AC 3D65 X-Files: The truth is out there X-URL: https://www.funkthat.com/ X-Resume: https://www.funkthat.com/~jmg/resume.html X-TipJar: bitcoin:13Qmb6AeTgQecazTWph4XasEsP7nGRbAPE X-to-the-FBI-CIA-and-NSA: HI! HOW YA DOIN? can i haz chizburger? User-Agent: Mutt/1.6.1 (2016-04-27) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.4.3 (gold.funkthat.com [127.0.0.1]); Tue, 21 Jul 2020 02:16:55 -0700 (PDT) X-Rspamd-Queue-Id: 4B9tJp4NLqz4MZp X-Spamd-Bar: ++++ Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=none (mx1.freebsd.org: domain of jmg@gold.funkthat.com has no SPF policy when checking 208.87.223.18) smtp.mailfrom=jmg@gold.funkthat.com X-Spamd-Result: default: False [4.10 / 15.00]; MID_RHS_MATCH_FROM(0.00)[]; ARC_NA(0.00)[]; FROM_HAS_DN(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_SPAM_SHORT(0.63)[0.630]; MIME_GOOD(-0.10)[multipart/mixed,text/plain]; HAS_ATTACHMENT(0.00)[]; TO_DN_NONE(0.00)[]; AUTH_NA(1.00)[]; DMARC_NA(0.00)[funkthat.com]; NEURAL_SPAM_MEDIUM(0.62)[0.619]; CTYPE_MIXED_BOGUS(1.00)[]; RCPT_COUNT_TWO(0.00)[2]; NEURAL_SPAM_LONG(0.65)[0.653]; R_SPF_NA(0.00)[no SPF record]; FORGED_SENDER(0.30)[jmg@funkthat.com,jmg@gold.funkthat.com]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+,1:+,2:+]; ASN(0.00)[asn:32354, ipnet:208.87.216.0/21, country:US]; FROM_NEQ_ENVFROM(0.00)[jmg@funkthat.com,jmg@gold.funkthat.com]; RCVD_TLS_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Jul 2020 09:16:59 -0000 --tK3TaB1xs9ylLrl6 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline I'm running: FreeBSD test 13.0-CURRENT FreeBSD 13.0-CURRENT #0 r362596: Thu Jun 25 05:02:51 UTC 2020 root@releng1.nyi.freebsd.org:/usr/obj/usr/src/amd64.amd64/sys/GENERIC amd64 and I'm working on improve the if_ure driver. I've put together a little script that I've attached that I'm using to test the driver.. It puts a couple ue interfaces each into their own jail, configures them, and tries to pass traffic. This assumes that the two interfaces are connected together. Pretty regularly when destroying the jails, I get the following panic: CURVNET_SET at /usr/src/sys/netinet/in_mcast.c:626 inm_release() curvnet=0 vnet=0xfffff80154c82a80 (kgdb) #0 __curthread () at /usr/src/sys/amd64/include/pcpu_aux.h:55 #1 doadump (textdump=1) at /usr/src/sys/kern/kern_shutdown.c:394 #2 0xffffffff80bc6250 in kern_reboot (howto=260) at /usr/src/sys/kern/kern_shutdown.c:481 #3 0xffffffff80bc66aa in vpanic (fmt=, ap=) at /usr/src/sys/kern/kern_shutdown.c:913 #4 0xffffffff80bc6403 in panic (fmt=) at /usr/src/sys/kern/kern_shutdown.c:839 #5 0xffffffff80d6553b in inm_release (inm=0xfffff80029043700) at /usr/src/sys/netinet/in_mcast.c:630 #6 inm_release_task (arg=, pending=) at /usr/src/sys/netinet/in_mcast.c:312 #7 0xffffffff80c2521a in taskqueue_run_locked (queue=0xfffff80003116b00) at /usr/src/sys/kern/subr_taskqueue.c:476 #8 0xffffffff80c26294 in taskqueue_thread_loop (arg=) at /usr/src/sys/kern/subr_taskqueue.c:793 #9 0xffffffff80b830f0 in fork_exit ( callout=0xffffffff80c26200 , arg=0xffffffff81cf4f70 , frame=0xfffffe0049e99b80) at /usr/src/sys/kern/kern_fork.c:1052 #10 (kgdb) I have the core files so I can get additional information. Let me know if you need any additional information. -- John-Mark Gurney Voice: +1 415 225 5579 "All that I will do, has been done, All that I have, has not." --tK3TaB1xs9ylLrl6 Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename="testinterfaces.txt" #!/bin/sh - # # ls testinterfaces.sh | entr sh -c 'fsync testinterfaces.sh && sh testinterfaces.sh ue0 ue1' # testiface="$1" checkiface="$2" echo starting, test $1, check $2 # ifconfig -m to get caps getcaps() { ifconfig -m "$1" | awk '$1 ~ /^capabilities=/ { split($0, a, "<"); split(a[2], b, ">"); split(b[1], caps, ","); for (i in caps) print caps[i] }' } if ! testjail=$(jail -i -c persist=1 path=/ name=testjail vnet=new vnet.interface="$testiface"); then echo failed to start test jail exit 1 fi if ! checkjail=$(jail -i -c persist=1 path=/ name=checkjail vnet=new vnet.interface="$checkiface"); then echo failed to start check jail exit 1 fi cleanup() { jail -r "$testjail" jail -r "$checkjail" } trap cleanup EXIT run() { if [ x"$1" = x"check" ]; then jid="$checkjail" elif [ x"$1" = x"test" ]; then jid="$testjail" else echo Invalid: "$1" >&2 exit 1 fi shift jexec "$jid" "$@" } ifjail() { if [ x"$1" = x"check" ]; then iface="$checkiface" elif [ x"$1" = x"test" ]; then iface="$testiface" else echo Invalid: "$1" >&2 exit 1 fi j="$1" shift run "$j" ifconfig "$iface" "$@" } waitcarrier() { local i for i in test check; do while :; do if ifjail "$i" | grep 1000baseT >/dev/null; then break fi sleep .5 done done } hwvlantest() { run test ifconfig lo0 up run check ifconfig lo0 up for i in "vlanhwtag" "-vlanhwtag"; do ifjail test down ifjail check down ifjail test "$i" ifjail check -vlanhwtag ifjail test up ifjail check up sleep 2 run test ifconfig $testiface.42 create 172.30.5.5/24 run check ifconfig $checkiface.42 create 172.30.5.4/24 waitcarrier run check tcpdump -p -q -c 2 -n -i "$checkiface" vlan 42 and icmp & sleep 1 if ! run test ping -c 1 -t 2 172.30.5.4; then echo FAILED on "$i"!!!! exit 1 fi done } hwvlantest --tK3TaB1xs9ylLrl6-- From owner-freebsd-current@freebsd.org Tue Jul 21 09:31:50 2020 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 200C737D781; Tue, 21 Jul 2020 09:31:50 +0000 (UTC) (envelope-from zec@fer.hr) Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-eopbgr80077.outbound.protection.outlook.com [40.107.8.77]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mail.protection.outlook.com", Issuer "GlobalSign Organization Validation CA - SHA256 - G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4B9tdx0mzLz4P7V; Tue, 21 Jul 2020 09:31:48 +0000 (UTC) (envelope-from zec@fer.hr) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NanXPt7oZbM+77hSu91MACot7WIBh2LSL26QMYXGfvXP7p9A16Ph58650/LbHxIFOydapozZU+QXkkEFcGXZirRQgoGS8m5kk66Ocw/ugCtiJ9RZVZx7Kamgb5pd6rQwRVCHu7Ah3+bDmJ3VafpDNRHRvkKs/GTwA6I/eyS0LLFdRVAE2VhSAFnpP6pEf7ZBxKe/lTos0EejJeThh3RxJf9ALQ/4yvztD1hnbLJ+IvfVMzcm5WBcZvIlRek7KKGS0/E/AHTBet/LpghgwLzZ+FgFuHPRHViJeZttLRuvgfFA0PTkJ+5m7rENFbYFwnI4aWkg7Kirahu/fimtZuX4qw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=D6OQ+xHFL+NVGQjN+5NApzHhlZANQLB2J2jnOaXuELc=; b=exa/ud0fKwly0CpnO922fZU1Bf3e7PHLs9O6RxbHyMbFqfEFWQdzPf6l9Yg3YZ31r9WbRFEj6AzhQaS50QdIXejF+pdjAsgeBBEG6/UsjiUbpg1gmXAlWwvE58yQ9rz7m36LQMOHJKLOByUBM7UpHCnVYHFNUaCKLoIyGXV2fyhp1sYA9B+TUl8ZF0C0zXhTasvmBLtaqrCCDHTDc7IrQY6WAH5Nq8r8yoj9HKX6tXTpLUGuu2Z0AWezhf5oI4y5nrGfpdYh2muMXfsVJzGYbvMBSGmF/GZJd6dB0tN4rIKz74jE6T8pgIdLSiHmBgZz6D2gaGVhu9M1GO6gAfrlKA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=fer.hr; dmarc=pass action=none header.from=fer.hr; dkim=pass header.d=fer.hr; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ferhr.onmicrosoft.com; s=selector2-ferhr-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=D6OQ+xHFL+NVGQjN+5NApzHhlZANQLB2J2jnOaXuELc=; b=RDEkSkXyMvCFGhUgeqveWlic4azrYEddmjxXjmmG8HirYq7wk+gs9jbSHfdMq5qO8v04cPv9Q3wureiaREwZrrH3oIQzCOxLcauiUTLdOhRX//zE4x3FVr43D58JNfKJyyJh6R7hnX/teuxfpJ2ACPaWc2tNYi0gOE88E473QYU= Received: from VE1PR08MB4783.eurprd08.prod.outlook.com (2603:10a6:802:a9::16) by VI1PR08MB4240.eurprd08.prod.outlook.com (2603:10a6:803:102::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3195.17; Tue, 21 Jul 2020 09:31:46 +0000 Received: from VE1PR08MB4783.eurprd08.prod.outlook.com ([fe80::c8e:e335:c7:319b]) by VE1PR08MB4783.eurprd08.prod.outlook.com ([fe80::c8e:e335:c7:319b%3]) with mapi id 15.20.3195.025; Tue, 21 Jul 2020 09:31:46 +0000 Date: Tue, 21 Jul 2020 11:31:53 +0200 From: Marko Zec To: John-Mark Gurney Cc: freebsd-net@freebsd.org, freebsd-current@freebsd.org Subject: Re: somewhat reproducable vimage panic Message-ID: <20200721113153.42d83119@x23> In-Reply-To: <20200721091654.GC4213@funkthat.com> References: <20200721091654.GC4213@funkthat.com> X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; amd64-portbld-freebsd11.3) Content-Type: multipart/mixed; boundary="MP_/YcpTgPso.vPHN47rj82525a" X-ClientProxiedBy: ZR0P278CA0021.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:1c::8) To VE1PR08MB4783.eurprd08.prod.outlook.com (2603:10a6:802:a9::16) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from x23 (161.53.19.9) by ZR0P278CA0021.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:1c::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3195.18 via Frontend Transport; Tue, 21 Jul 2020 09:31:45 +0000 X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; amd64-portbld-freebsd11.3) X-Originating-IP: [161.53.19.9] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 2388a74f-27d6-488c-8eac-08d82d58e2ed X-MS-TrafficTypeDiagnostic: VI1PR08MB4240: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:6430; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: tpJ1w6RKmXaPj07Tz6fVijlzuLMZe9TEFyCrhsIuUTsTUs9XYZb0V+Xz6XkoVKWLChsaZQVf12h/SLyghY6chPWhx+mzR2a0EKhJ5sYPHacbATgHuMhqYuJDmUhVnk+evscyVBCdjq+4agucse5sS1/O266jntnmUlfVlV2UCIvrUUE0uzUZCY45YbIY7Is8psL8Cq42SmqiW8FaptXnGvP4oKXVW70s/dz3fBc7d00ATQv31TM4m5qAXBAyBxIivlWYB/5gMOqG8Iql9fIr2m8POmmNvALODr+3s09uQpzX6SW3H8YS/NCR3+UdllV1LgIdmKh825Ed9rFZA1Ypnw== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VE1PR08MB4783.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(376002)(396003)(366004)(39850400004)(136003)(346002)(2906002)(83380400001)(8676002)(66616009)(33716001)(66556008)(5660300002)(235185007)(66946007)(66476007)(86362001)(1076003)(4326008)(3480700007)(316002)(478600001)(786003)(8936002)(9686003)(9576002)(6916009)(6496006)(55016002)(16526019)(26005)(44144004)(956004)(186003)(52116002)(6666004); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData: M2tPNUb44sICEOHdUk/d/4MgCqzw3fN/Dvbj1QEqUA7FB3M22lrdAHRMOy36HNPRx1LhN2QNaVmfq7nvTs5ullcORCHTlvQ4ZZDV+z+M0ttp3aiDRMd4Uuo0mVD3vzvafFDGPFe41MUG69I5qPaCOScO4xybbQNX+YS9SSH2o7f2GEGeS+0QlJ6Tzwj1axEyFABAo76wRcOecuAMpmICxaSGav9vl0qUk9Vr/pKu2sMsmgbmD9P26Us9n5g4xEUG0uqNs5YpRqyXIwiBNhcAgbaF60N8QWuuJlbJmsshqNRkmv2ZDJ+CuxHNXs5/Q0Vr4bY3nvgI/LG2FuDlIxOFl3uBOGprAa+6u2pEolqum9xC4Ky6m8sDEHk5ZJZWOEntM1X14I7Oc0C/vpLHu+oFPlJcVt++DRXHBzbOGJfXENI0CWfFXehBbKSrZbYFs1QsuZ7mT0IhTXLbCYbTKGbabkFOyCOxM9M08EjCF58q7Do= X-OriginatorOrg: fer.hr X-MS-Exchange-CrossTenant-Network-Message-Id: 2388a74f-27d6-488c-8eac-08d82d58e2ed X-MS-Exchange-CrossTenant-AuthSource: VE1PR08MB4783.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Jul 2020 09:31:46.2315 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: ca71eddc-cc7b-4e5b-95bd-55b658e696be X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: qLz+iouXhfeXeLoRMAF1srRM3s2s+qbZHQIDabwGr/YuebXo80/l5U7+EbNEVDC6 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB4240 X-Rspamd-Queue-Id: 4B9tdx0mzLz4P7V X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=ferhr.onmicrosoft.com header.s=selector2-ferhr-onmicrosoft-com header.b=RDEkSkXy; dmarc=none; spf=pass (mx1.freebsd.org: domain of zec@fer.hr designates 40.107.8.77 as permitted sender) smtp.mailfrom=zec@fer.hr X-Spamd-Result: default: False [-3.59 / 15.00]; NEURAL_HAM_MEDIUM(-1.01)[-1.005]; R_DKIM_ALLOW(-0.20)[ferhr.onmicrosoft.com:s=selector2-ferhr-onmicrosoft-com]; HAS_XOIP(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip4:40.107.0.0/16]; MIME_GOOD(-0.10)[multipart/mixed,text/plain,text/x-patch]; HAS_ATTACHMENT(0.00)[]; DMARC_NA(0.00)[fer.hr]; ARC_ALLOW(-1.00)[microsoft.com:s=arcselector9901:i=1]; NEURAL_HAM_LONG(-1.03)[-1.029]; RCVD_COUNT_THREE(0.00)[4]; TO_MATCH_ENVRCPT_SOME(0.00)[]; DKIM_TRACE(0.00)[ferhr.onmicrosoft.com:+]; NEURAL_HAM_SHORT(-0.45)[-0.454]; RWL_MAILSPIKE_POSSIBLE(0.00)[40.107.8.77:from]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+,1:+,2:+]; RCVD_TLS_LAST(0.00)[]; ASN(0.00)[asn:8075, ipnet:40.104.0.0/14, country:US]; MID_RHS_NOT_FQDN(0.50)[]; RCVD_IN_DNSWL_LOW(-0.10)[40.107.8.77:from] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Jul 2020 09:31:50 -0000 --MP_/YcpTgPso.vPHN47rj82525a Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Content-Disposition: inline On Tue, 21 Jul 2020 02:16:55 -0700 John-Mark Gurney wrote: > I'm running: > FreeBSD test 13.0-CURRENT FreeBSD 13.0-CURRENT #0 r362596: Thu Jun 25 > 05:02:51 UTC 2020 > root@releng1.nyi.freebsd.org:/usr/obj/usr/src/amd64.amd64/sys/GENERIC > amd64 > > and I'm working on improve the if_ure driver. I've put together a > little script that I've attached that I'm using to test the driver.. > It puts a couple ue interfaces each into their own jail, configures > them, and tries to pass traffic. This assumes that the two interfaces > are connected together. > > Pretty regularly when destroying the jails, I get the following > panic: CURVNET_SET at /usr/src/sys/netinet/in_mcast.c:626 > inm_release() curvnet=0 vnet=0xfffff80154c82a80 Perhaps the attached patch could help? (disclaimer: not even compile-tested) Marko > (kgdb) #0 __curthread () at /usr/src/sys/amd64/include/pcpu_aux.h:55 > #1 doadump (textdump=1) at /usr/src/sys/kern/kern_shutdown.c:394 > #2 0xffffffff80bc6250 in kern_reboot (howto=260) > at /usr/src/sys/kern/kern_shutdown.c:481 > #3 0xffffffff80bc66aa in vpanic (fmt=, ap= out>) at /usr/src/sys/kern/kern_shutdown.c:913 > #4 0xffffffff80bc6403 in panic (fmt=) > at /usr/src/sys/kern/kern_shutdown.c:839 > #5 0xffffffff80d6553b in inm_release (inm=0xfffff80029043700) > at /usr/src/sys/netinet/in_mcast.c:630 > #6 inm_release_task (arg=, pending=) > at /usr/src/sys/netinet/in_mcast.c:312 > #7 0xffffffff80c2521a in taskqueue_run_locked > (queue=0xfffff80003116b00) at /usr/src/sys/kern/subr_taskqueue.c:476 > #8 0xffffffff80c26294 in taskqueue_thread_loop (arg=) > at /usr/src/sys/kern/subr_taskqueue.c:793 > #9 0xffffffff80b830f0 in fork_exit ( > callout=0xffffffff80c26200 , > arg=0xffffffff81cf4f70 , > frame=0xfffffe0049e99b80) at /usr/src/sys/kern/kern_fork.c:1052 > #10 > (kgdb) > > I have the core files so I can get additional information. > > Let me know if you need any additional information. > --MP_/YcpTgPso.vPHN47rj82525a Content-Type: text/x-patch Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=in_mcast.diff Index: sys/netinet/in_mcast.c =================================================================== --- sys/netinet/in_mcast.c (revision 363386) +++ sys/netinet/in_mcast.c (working copy) @@ -309,8 +309,10 @@ IN_MULTI_LOCK(); SLIST_FOREACH_SAFE(inm, &inm_free_tmp, inm_nrele, tinm) { SLIST_REMOVE_HEAD(&inm_free_tmp, inm_nrele); + CURVNET_SET(inm->inm_ifp->if_vnet); MPASS(inm); inm_release(inm); + CURVNET_RESTORE(); } IN_MULTI_UNLOCK(); } --MP_/YcpTgPso.vPHN47rj82525a-- From owner-freebsd-current@freebsd.org Tue Jul 21 20:23:36 2020 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id E600D366DDB; Tue, 21 Jul 2020 20:23:36 +0000 (UTC) (envelope-from jmg@gold.funkthat.com) Received: from gold.funkthat.com (gate2.funkthat.com [208.87.223.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "gate2.funkthat.com", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4BB95z61v6z4Bjc; Tue, 21 Jul 2020 20:23:35 +0000 (UTC) (envelope-from jmg@gold.funkthat.com) Received: from gold.funkthat.com (localhost [127.0.0.1]) by gold.funkthat.com (8.15.2/8.15.2) with ESMTPS id 06LKNNiF005654 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Tue, 21 Jul 2020 13:23:23 -0700 (PDT) (envelope-from jmg@gold.funkthat.com) Received: (from jmg@localhost) by gold.funkthat.com (8.15.2/8.15.2/Submit) id 06LKNNOk005653; Tue, 21 Jul 2020 13:23:23 -0700 (PDT) (envelope-from jmg) Date: Tue, 21 Jul 2020 13:23:23 -0700 From: John-Mark Gurney To: Marko Zec Cc: freebsd-net@freebsd.org, freebsd-current@freebsd.org Subject: Re: somewhat reproducable vimage panic Message-ID: <20200721202323.GE4213@funkthat.com> Mail-Followup-To: Marko Zec , freebsd-net@freebsd.org, freebsd-current@freebsd.org References: <20200721091654.GC4213@funkthat.com> <20200721113153.42d83119@x23> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200721113153.42d83119@x23> X-Operating-System: FreeBSD 11.3-STABLE amd64 X-PGP-Fingerprint: D87A 235F FB71 1F3F 55B7 ED9B D5FF 5A51 C0AC 3D65 X-Files: The truth is out there X-URL: https://www.funkthat.com/ X-Resume: https://www.funkthat.com/~jmg/resume.html X-TipJar: bitcoin:13Qmb6AeTgQecazTWph4XasEsP7nGRbAPE X-to-the-FBI-CIA-and-NSA: HI! HOW YA DOIN? can i haz chizburger? User-Agent: Mutt/1.6.1 (2016-04-27) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.4.3 (gold.funkthat.com [127.0.0.1]); Tue, 21 Jul 2020 13:23:23 -0700 (PDT) X-Rspamd-Queue-Id: 4BB95z61v6z4Bjc X-Spamd-Bar: / Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=none (mx1.freebsd.org: domain of jmg@gold.funkthat.com has no SPF policy when checking 208.87.223.18) smtp.mailfrom=jmg@gold.funkthat.com X-Spamd-Result: default: False [0.80 / 15.00]; MID_RHS_MATCH_FROM(0.00)[]; ARC_NA(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; TO_DN_SOME(0.00)[]; NEURAL_HAM_LONG(-0.28)[-0.281]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[funkthat.com]; AUTH_NA(1.00)[]; NEURAL_SPAM_MEDIUM(0.00)[0.001]; TO_MATCH_ENVRCPT_SOME(0.00)[]; NEURAL_HAM_SHORT(-0.12)[-0.124]; R_SPF_NA(0.00)[no SPF record]; FORGED_SENDER(0.30)[jmg@funkthat.com,jmg@gold.funkthat.com]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:32354, ipnet:208.87.216.0/21, country:US]; FROM_NEQ_ENVFROM(0.00)[jmg@funkthat.com,jmg@gold.funkthat.com]; RCVD_TLS_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Jul 2020 20:23:37 -0000 Marko Zec wrote this message on Tue, Jul 21, 2020 at 11:31 +0200: > On Tue, 21 Jul 2020 02:16:55 -0700 > John-Mark Gurney wrote: > > > I'm running: > > FreeBSD test 13.0-CURRENT FreeBSD 13.0-CURRENT #0 r362596: Thu Jun 25 > > 05:02:51 UTC 2020 > > root@releng1.nyi.freebsd.org:/usr/obj/usr/src/amd64.amd64/sys/GENERIC > > amd64 > > > > and I'm working on improve the if_ure driver. I've put together a > > little script that I've attached that I'm using to test the driver.. > > It puts a couple ue interfaces each into their own jail, configures > > them, and tries to pass traffic. This assumes that the two interfaces > > are connected together. > > > > Pretty regularly when destroying the jails, I get the following > > panic: CURVNET_SET at /usr/src/sys/netinet/in_mcast.c:626 > > inm_release() curvnet=0 vnet=0xfffff80154c82a80 > > Perhaps the attached patch could help? (disclaimer: not even > compile-tested) The patch compiled, but it just moved the panic earlier than before. #4 0xffffffff80bc2123 in panic (fmt=) at ../../../kern/kern_shutdown.c:839 #5 0xffffffff80d61726 in inm_release_task (arg=, pending=) at ../../../netinet/in_mcast.c:633 #6 0xffffffff80c2166a in taskqueue_run_locked (queue=0xfffff800033cfd00) at ../../../kern/subr_taskqueue.c:476 #7 0xffffffff80c226e4 in taskqueue_thread_loop (arg=) at ../../../kern/subr_taskqueue.c:793 Now it panics at the location of the new CURVNET_SET and not the old one.. Ok, decided to dump the contents of the vnet, and it looks like it's a use after free: (kgdb) print/x *(struct vnet *)0xfffff8012a283140 $2 = {vnet_le = {le_next = 0xdeadc0dedeadc0de, le_prev = 0xdeadc0dedeadc0de}, vnet_magic_n = 0xdeadc0de, vnet_ifcnt = 0xdeadc0de, vnet_sockcnt = 0xdeadc0de, vnet_state = 0xdeadc0de, vnet_data_mem = 0xdeadc0dedeadc0de, vnet_data_base = 0xdeadc0dedeadc0de, vnet_shutdown = 0xde} The patch did seem to make it happen quicker, or maybe I was just more lucky this morning... > > (kgdb) #0 __curthread () at /usr/src/sys/amd64/include/pcpu_aux.h:55 > > #1 doadump (textdump=1) at /usr/src/sys/kern/kern_shutdown.c:394 > > #2 0xffffffff80bc6250 in kern_reboot (howto=260) > > at /usr/src/sys/kern/kern_shutdown.c:481 > > #3 0xffffffff80bc66aa in vpanic (fmt=, ap= > out>) at /usr/src/sys/kern/kern_shutdown.c:913 > > #4 0xffffffff80bc6403 in panic (fmt=) > > at /usr/src/sys/kern/kern_shutdown.c:839 > > #5 0xffffffff80d6553b in inm_release (inm=0xfffff80029043700) > > at /usr/src/sys/netinet/in_mcast.c:630 > > #6 inm_release_task (arg=, pending=) > > at /usr/src/sys/netinet/in_mcast.c:312 > > #7 0xffffffff80c2521a in taskqueue_run_locked > > (queue=0xfffff80003116b00) at /usr/src/sys/kern/subr_taskqueue.c:476 > > #8 0xffffffff80c26294 in taskqueue_thread_loop (arg=) > > at /usr/src/sys/kern/subr_taskqueue.c:793 > > #9 0xffffffff80b830f0 in fork_exit ( > > callout=0xffffffff80c26200 , > > arg=0xffffffff81cf4f70 , > > frame=0xfffffe0049e99b80) at /usr/src/sys/kern/kern_fork.c:1052 > > #10 > > (kgdb) > > > > I have the core files so I can get additional information. > > > > Let me know if you need any additional information. > > > > Index: sys/netinet/in_mcast.c > =================================================================== > --- sys/netinet/in_mcast.c (revision 363386) > +++ sys/netinet/in_mcast.c (working copy) > @@ -309,8 +309,10 @@ > IN_MULTI_LOCK(); > SLIST_FOREACH_SAFE(inm, &inm_free_tmp, inm_nrele, tinm) { > SLIST_REMOVE_HEAD(&inm_free_tmp, inm_nrele); > + CURVNET_SET(inm->inm_ifp->if_vnet); > MPASS(inm); > inm_release(inm); > + CURVNET_RESTORE(); > } > IN_MULTI_UNLOCK(); > } -- John-Mark Gurney Voice: +1 415 225 5579 "All that I will do, has been done, All that I have, has not." From owner-freebsd-current@freebsd.org Wed Jul 22 06:05:24 2020 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 37C6A372876; Wed, 22 Jul 2020 06:05:24 +0000 (UTC) (envelope-from jmg@gold.funkthat.com) Received: from gold.funkthat.com (gate2.funkthat.com [208.87.223.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "gate2.funkthat.com", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4BBQ1G4LVkz3TnC; Wed, 22 Jul 2020 06:05:21 +0000 (UTC) (envelope-from jmg@gold.funkthat.com) Received: from gold.funkthat.com (localhost [127.0.0.1]) by gold.funkthat.com (8.15.2/8.15.2) with ESMTPS id 06M65FTI041270 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Tue, 21 Jul 2020 23:05:15 -0700 (PDT) (envelope-from jmg@gold.funkthat.com) Received: (from jmg@localhost) by gold.funkthat.com (8.15.2/8.15.2/Submit) id 06M65EBK041269; Tue, 21 Jul 2020 23:05:14 -0700 (PDT) (envelope-from jmg) Date: Tue, 21 Jul 2020 23:05:14 -0700 From: John-Mark Gurney To: Peter Libassi Cc: Marko Zec , freebsd-net@freebsd.org, freebsd-current@freebsd.org Subject: Re: somewhat reproducable vimage panic Message-ID: <20200722060514.GF4213@funkthat.com> Mail-Followup-To: Peter Libassi , Marko Zec , freebsd-net@freebsd.org, freebsd-current@freebsd.org References: <20200721091654.GC4213@funkthat.com> <20200721113153.42d83119@x23> <20200721202323.GE4213@funkthat.com> <38F5A3A6-B578-4BA4-8F69-C248163CB6E0@libassi.se> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <38F5A3A6-B578-4BA4-8F69-C248163CB6E0@libassi.se> X-Operating-System: FreeBSD 11.3-STABLE amd64 X-PGP-Fingerprint: D87A 235F FB71 1F3F 55B7 ED9B D5FF 5A51 C0AC 3D65 X-Files: The truth is out there X-URL: https://www.funkthat.com/ X-Resume: https://www.funkthat.com/~jmg/resume.html X-TipJar: bitcoin:13Qmb6AeTgQecazTWph4XasEsP7nGRbAPE X-to-the-FBI-CIA-and-NSA: HI! HOW YA DOIN? can i haz chizburger? User-Agent: Mutt/1.6.1 (2016-04-27) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.4.3 (gold.funkthat.com [127.0.0.1]); Tue, 21 Jul 2020 23:05:15 -0700 (PDT) X-Rspamd-Queue-Id: 4BBQ1G4LVkz3TnC X-Spamd-Bar: + Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=none (mx1.freebsd.org: domain of jmg@gold.funkthat.com has no SPF policy when checking 208.87.223.18) smtp.mailfrom=jmg@gold.funkthat.com X-Spamd-Result: default: False [1.96 / 15.00]; RCVD_TLS_ALL(0.00)[]; ARC_NA(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; TO_DN_SOME(0.00)[]; NEURAL_HAM_LONG(-0.19)[-0.192]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[funkthat.com]; AUTH_NA(1.00)[]; NEURAL_SPAM_MEDIUM(0.06)[0.056]; NEURAL_SPAM_SHORT(0.90)[0.901]; TO_MATCH_ENVRCPT_SOME(0.00)[]; R_SPF_NA(0.00)[no SPF record]; FORGED_SENDER(0.30)[jmg@funkthat.com,jmg@gold.funkthat.com]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_COUNT_TWO(0.00)[2]; MID_RHS_MATCH_FROM(0.00)[]; FROM_NEQ_ENVFROM(0.00)[jmg@funkthat.com,jmg@gold.funkthat.com]; ASN(0.00)[asn:32354, ipnet:208.87.216.0/21, country:US] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 Jul 2020 06:05:24 -0000 Peter Libassi wrote this message on Wed, Jul 22, 2020 at 06:54 +0200: > Is this related to > > https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=234985 and https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=238326 Definitely not 234985.. I'm using ue interfaces, and so they don't get destroyed while the jail is going away... I don't think it's 238326 either. This is 100% reliable and it's in the IP multicast code.. It looks like in_multi isn't holding an interface or address lock waiting for things to free up... > > 21 juli 2020 kl. 22:23 skrev John-Mark Gurney : > > > > Marko Zec wrote this message on Tue, Jul 21, 2020 at 11:31 +0200: > >> On Tue, 21 Jul 2020 02:16:55 -0700 > >> John-Mark Gurney wrote: > >> > >>> I'm running: > >>> FreeBSD test 13.0-CURRENT FreeBSD 13.0-CURRENT #0 r362596: Thu Jun 25 > >>> 05:02:51 UTC 2020 > >>> root@releng1.nyi.freebsd.org:/usr/obj/usr/src/amd64.amd64/sys/GENERIC > >>> amd64 > >>> > >>> and I'm working on improve the if_ure driver. I've put together a > >>> little script that I've attached that I'm using to test the driver.. > >>> It puts a couple ue interfaces each into their own jail, configures > >>> them, and tries to pass traffic. This assumes that the two interfaces > >>> are connected together. > >>> > >>> Pretty regularly when destroying the jails, I get the following > >>> panic: CURVNET_SET at /usr/src/sys/netinet/in_mcast.c:626 > >>> inm_release() curvnet=0 vnet=0xfffff80154c82a80 > >> > >> Perhaps the attached patch could help? (disclaimer: not even > >> compile-tested) > > > > The patch compiled, but it just moved the panic earlier than before. > > > > #4 0xffffffff80bc2123 in panic (fmt=) > > at ../../../kern/kern_shutdown.c:839 > > #5 0xffffffff80d61726 in inm_release_task (arg=, > > pending=) at ../../../netinet/in_mcast.c:633 > > #6 0xffffffff80c2166a in taskqueue_run_locked (queue=0xfffff800033cfd00) > > at ../../../kern/subr_taskqueue.c:476 > > #7 0xffffffff80c226e4 in taskqueue_thread_loop (arg=) > > at ../../../kern/subr_taskqueue.c:793 > > > > Now it panics at the location of the new CURVNET_SET and not the > > old one.. > > > > Ok, decided to dump the contents of the vnet, and it looks like > > it's a use after free: > > (kgdb) print/x *(struct vnet *)0xfffff8012a283140 > > $2 = {vnet_le = {le_next = 0xdeadc0dedeadc0de, le_prev = 0xdeadc0dedeadc0de}, vnet_magic_n = 0xdeadc0de, > > vnet_ifcnt = 0xdeadc0de, vnet_sockcnt = 0xdeadc0de, vnet_state = 0xdeadc0de, vnet_data_mem = 0xdeadc0dedeadc0de, > > vnet_data_base = 0xdeadc0dedeadc0de, vnet_shutdown = 0xde} > > > > The patch did seem to make it happen quicker, or maybe I was just more > > lucky this morning... > > > >>> (kgdb) #0 __curthread () at /usr/src/sys/amd64/include/pcpu_aux.h:55 > >>> #1 doadump (textdump=1) at /usr/src/sys/kern/kern_shutdown.c:394 > >>> #2 0xffffffff80bc6250 in kern_reboot (howto=260) > >>> at /usr/src/sys/kern/kern_shutdown.c:481 > >>> #3 0xffffffff80bc66aa in vpanic (fmt=, ap= >>> out>) at /usr/src/sys/kern/kern_shutdown.c:913 > >>> #4 0xffffffff80bc6403 in panic (fmt=) > >>> at /usr/src/sys/kern/kern_shutdown.c:839 > >>> #5 0xffffffff80d6553b in inm_release (inm=0xfffff80029043700) > >>> at /usr/src/sys/netinet/in_mcast.c:630 > >>> #6 inm_release_task (arg=, pending=) > >>> at /usr/src/sys/netinet/in_mcast.c:312 > >>> #7 0xffffffff80c2521a in taskqueue_run_locked > >>> (queue=0xfffff80003116b00) at /usr/src/sys/kern/subr_taskqueue.c:476 > >>> #8 0xffffffff80c26294 in taskqueue_thread_loop (arg=) > >>> at /usr/src/sys/kern/subr_taskqueue.c:793 > >>> #9 0xffffffff80b830f0 in fork_exit ( > >>> callout=0xffffffff80c26200 , > >>> arg=0xffffffff81cf4f70 , > >>> frame=0xfffffe0049e99b80) at /usr/src/sys/kern/kern_fork.c:1052 > >>> #10 > >>> (kgdb) > >>> > >>> I have the core files so I can get additional information. > >>> > >>> Let me know if you need any additional information. > >>> > >> > > > >> Index: sys/netinet/in_mcast.c > >> =================================================================== > >> --- sys/netinet/in_mcast.c (revision 363386) > >> +++ sys/netinet/in_mcast.c (working copy) > >> @@ -309,8 +309,10 @@ > >> IN_MULTI_LOCK(); > >> SLIST_FOREACH_SAFE(inm, &inm_free_tmp, inm_nrele, tinm) { > >> SLIST_REMOVE_HEAD(&inm_free_tmp, inm_nrele); > >> + CURVNET_SET(inm->inm_ifp->if_vnet); > >> MPASS(inm); > >> inm_release(inm); > >> + CURVNET_RESTORE(); > >> } > >> IN_MULTI_UNLOCK(); > >> } -- John-Mark Gurney Voice: +1 415 225 5579 "All that I will do, has been done, All that I have, has not." From owner-freebsd-current@freebsd.org Wed Jul 22 19:35:06 2020 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id B2A0C35DF0F; Wed, 22 Jul 2020 19:35:06 +0000 (UTC) (envelope-from jmg@gold.funkthat.com) Received: from gold.funkthat.com (gate2.funkthat.com [208.87.223.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "gate2.funkthat.com", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4BBlzY5DQBz4f2B; Wed, 22 Jul 2020 19:35:05 +0000 (UTC) (envelope-from jmg@gold.funkthat.com) Received: from gold.funkthat.com (localhost [127.0.0.1]) by gold.funkthat.com (8.15.2/8.15.2) with ESMTPS id 06MJYxxJ072229 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Wed, 22 Jul 2020 12:34:59 -0700 (PDT) (envelope-from jmg@gold.funkthat.com) Received: (from jmg@localhost) by gold.funkthat.com (8.15.2/8.15.2/Submit) id 06MJYhij072209; Wed, 22 Jul 2020 12:34:43 -0700 (PDT) (envelope-from jmg) Date: Wed, 22 Jul 2020 12:34:43 -0700 From: John-Mark Gurney To: Peter Libassi , Marko Zec , freebsd-net@freebsd.org, freebsd-current@freebsd.org Subject: Re: somewhat reproducable vimage panic Message-ID: <20200722193443.GG4213@funkthat.com> Mail-Followup-To: Peter Libassi , Marko Zec , freebsd-net@freebsd.org, freebsd-current@freebsd.org References: <20200721091654.GC4213@funkthat.com> <20200721113153.42d83119@x23> <20200721202323.GE4213@funkthat.com> <38F5A3A6-B578-4BA4-8F69-C248163CB6E0@libassi.se> <20200722060514.GF4213@funkthat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200722060514.GF4213@funkthat.com> X-Operating-System: FreeBSD 11.3-STABLE amd64 X-PGP-Fingerprint: D87A 235F FB71 1F3F 55B7 ED9B D5FF 5A51 C0AC 3D65 X-Files: The truth is out there X-URL: https://www.funkthat.com/ X-Resume: https://www.funkthat.com/~jmg/resume.html X-TipJar: bitcoin:13Qmb6AeTgQecazTWph4XasEsP7nGRbAPE X-to-the-FBI-CIA-and-NSA: HI! HOW YA DOIN? can i haz chizburger? User-Agent: Mutt/1.6.1 (2016-04-27) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.4.3 (gold.funkthat.com [127.0.0.1]); Wed, 22 Jul 2020 12:34:59 -0700 (PDT) X-Rspamd-Queue-Id: 4BBlzY5DQBz4f2B X-Spamd-Bar: + Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=none (mx1.freebsd.org: domain of jmg@gold.funkthat.com has no SPF policy when checking 208.87.223.18) smtp.mailfrom=jmg@gold.funkthat.com X-Spamd-Result: default: False [1.44 / 15.00]; MID_RHS_MATCH_FROM(0.00)[]; ARC_NA(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; TO_DN_SOME(0.00)[]; NEURAL_HAM_LONG(-0.29)[-0.290]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[funkthat.com]; AUTH_NA(1.00)[]; NEURAL_SPAM_MEDIUM(0.67)[0.670]; TO_MATCH_ENVRCPT_SOME(0.00)[]; NEURAL_HAM_SHORT(-0.14)[-0.141]; R_SPF_NA(0.00)[no SPF record]; FORGED_SENDER(0.30)[jmg@funkthat.com,jmg@gold.funkthat.com]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:32354, ipnet:208.87.216.0/21, country:US]; FROM_NEQ_ENVFROM(0.00)[jmg@funkthat.com,jmg@gold.funkthat.com]; RCVD_TLS_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 Jul 2020 19:35:06 -0000 John-Mark Gurney wrote this message on Tue, Jul 21, 2020 at 23:05 -0700: > Peter Libassi wrote this message on Wed, Jul 22, 2020 at 06:54 +0200: > > Is this related to > > > > https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=234985 and https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=238326 > > Definitely not 234985.. I'm using ue interfaces, and so they don't > get destroyed while the jail is going away... > > I don't think it's 238326 either. This is 100% reliable and it's in > the IP multicast code.. It looks like in_multi isn't holding an > interface or address lock waiting for things to free up... Did a little more poking, and it looks like the vnet is free'd before the ifnet is free'd causing this problem: (kgdb) print inm->inm_ifp[0].if_refcount $5 = 1 (kgdb) print inm->inm_ifp[0].if_vnet[0] $6 = {vnet_le = {le_next = 0xdeadc0dedeadc0de, le_prev = 0xdeadc0dedeadc0de}, vnet_magic_n = 3735929054, vnet_ifcnt = 3735929054, vnet_sockcnt = 3735929054, vnet_state = 3735929054, vnet_data_mem = 0xdeadc0dedeadc0de, vnet_data_base = 16045693110842147038, vnet_shutdown = 222} So the multicast code is fine, it holds and releases a reference to ifnet.. The issue is that the reference to the ifnet doesn't involve a reference to the vnet/prison. I have noticed that a number of times after a jail destroy that one of my interfaces doesn't make it back to the main OS.. it's just gone.. I can "make" it reappear by reseting the hardware, but that does imply that an ifnet is hanging out in limbo... -- John-Mark Gurney Voice: +1 415 225 5579 "All that I will do, has been done, All that I have, has not." From owner-freebsd-current@freebsd.org Wed Jul 22 20:43:20 2020 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 678AD360384; Wed, 22 Jul 2020 20:43:20 +0000 (UTC) (envelope-from bzeeb-lists@lists.zabbadoz.net) Received: from mx1.sbone.de (mx1.sbone.de [IPv6:2a01:4f8:13b:39f::9f:25]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mx1.sbone.de", Issuer "SBone.DE" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4BBnVH3jjhz4kYJ; Wed, 22 Jul 2020 20:43:19 +0000 (UTC) (envelope-from bzeeb-lists@lists.zabbadoz.net) Received: from mail.sbone.de (mail.sbone.de [IPv6:fde9:577b:c1a9:31::2013:587]) (using TLSv1 with cipher ADH-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by mx1.sbone.de (Postfix) with ESMTPS id 7F6538D4A161; Wed, 22 Jul 2020 20:43:10 +0000 (UTC) Received: from content-filter.sbone.de (content-filter.sbone.de [IPv6:fde9:577b:c1a9:31::2013:2742]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.sbone.de (Postfix) with ESMTPS id 0A6ACE707BD; Wed, 22 Jul 2020 20:43:10 +0000 (UTC) X-Virus-Scanned: amavisd-new at sbone.de Received: from mail.sbone.de ([IPv6:fde9:577b:c1a9:31::2013:587]) by content-filter.sbone.de (content-filter.sbone.de [fde9:577b:c1a9:31::2013:2742]) (amavisd-new, port 10024) with ESMTP id V7G1p1hKwsis; Wed, 22 Jul 2020 20:43:08 +0000 (UTC) Received: from [127.0.0.1] (unknown [IPv6:fde9:577b:c1a9:4902:5ca3:9f20:8345:9910]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.sbone.de (Postfix) with ESMTPSA id 2473EE707BC; Wed, 22 Jul 2020 20:43:07 +0000 (UTC) From: "Bjoern A. Zeeb" To: "John-Mark Gurney" Cc: freebsd-net@freebsd.org, freebsd-current@freebsd.org Subject: Re: somewhat reproducable vimage panic Date: Wed, 22 Jul 2020 20:43:06 +0000 X-Mailer: MailMate (2.0BETAr6146) Message-ID: <6C149617-55BB-4A87-B993-195E5E133790@lists.zabbadoz.net> In-Reply-To: <20200722193443.GG4213@funkthat.com> References: <20200721091654.GC4213@funkthat.com> <20200721113153.42d83119@x23> <20200721202323.GE4213@funkthat.com> <38F5A3A6-B578-4BA4-8F69-C248163CB6E0@libassi.se> <20200722060514.GF4213@funkthat.com> <20200722193443.GG4213@funkthat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 4BBnVH3jjhz4kYJ X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of bzeeb-lists@lists.zabbadoz.net designates 2a01:4f8:13b:39f::9f:25 as permitted sender) smtp.mailfrom=bzeeb-lists@lists.zabbadoz.net X-Spamd-Result: default: False [-2.50 / 15.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[]; RCVD_COUNT_FIVE(0.00)[5]; NEURAL_HAM_MEDIUM(-0.96)[-0.962]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip6:2a01:4f8:13b:39f::9f:25]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[zabbadoz.net]; NEURAL_HAM_LONG(-0.98)[-0.983]; TO_MATCH_ENVRCPT_SOME(0.00)[]; NEURAL_HAM_SHORT(-0.25)[-0.254]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:24940, ipnet:2a01:4f8::/29, country:DE]; RCVD_TLS_LAST(0.00)[]; MID_RHS_MATCH_FROM(0.00)[] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 Jul 2020 20:43:20 -0000 On 22 Jul 2020, at 19:34, John-Mark Gurney wrote: > John-Mark Gurney wrote this message on Tue, Jul 21, 2020 at 23:05 > -0700: >> Peter Libassi wrote this message on Wed, Jul 22, 2020 at 06:54 +0200: >>> Is this related to >>> >>> https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=234985 >>> and >>> https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=238326 >>> >> >> Definitely not 234985.. I'm using ue interfaces, and so they don't >> get destroyed while the jail is going away... >> >> I don't think it's 238326 either. This is 100% reliable and it's in >> the IP multicast code.. It looks like in_multi isn't holding an >> interface or address lock waiting for things to free up... > > Did a little more poking, and it looks like the vnet is free'd before > the ifnet is free'd causing this problem: > (kgdb) print inm->inm_ifp[0].if_refcount > $5 = 1 > (kgdb) print inm->inm_ifp[0].if_vnet[0] > $6 = {vnet_le = {le_next = 0xdeadc0dedeadc0de, le_prev = > 0xdeadc0dedeadc0de}, > vnet_magic_n = 3735929054, vnet_ifcnt = 3735929054, > vnet_sockcnt = 3735929054, vnet_state = 3735929054, > vnet_data_mem = 0xdeadc0dedeadc0de, vnet_data_base = > 16045693110842147038, > vnet_shutdown = 222} > > So the multicast code is fine, it holds and releases a reference to > ifnet.. > > The issue is that the reference to the ifnet doesn't involve a > reference to the vnet/prison. Does it need to? The ifnet cannot go away while something holds a reference to it, right? Sounds more like the teardown order is wrong (again)? There should be no more multicast when IP etc. is gone. That means MC doesn’t properly cleanup itself. I guess I should go back now and re-read your original problem statement on how you trigger this.. /bz From owner-freebsd-current@freebsd.org Wed Jul 22 22:15:17 2020 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id A1B5C36298B; Wed, 22 Jul 2020 22:15:17 +0000 (UTC) (envelope-from jmg@gold.funkthat.com) Received: from gold.funkthat.com (gate2.funkthat.com [208.87.223.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "gate2.funkthat.com", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4BBqXN6QTJz4qhT; Wed, 22 Jul 2020 22:15:16 +0000 (UTC) (envelope-from jmg@gold.funkthat.com) Received: from gold.funkthat.com (localhost [127.0.0.1]) by gold.funkthat.com (8.15.2/8.15.2) with ESMTPS id 06MMF9EO080536 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Wed, 22 Jul 2020 15:15:09 -0700 (PDT) (envelope-from jmg@gold.funkthat.com) Received: (from jmg@localhost) by gold.funkthat.com (8.15.2/8.15.2/Submit) id 06MMF9Am080535; Wed, 22 Jul 2020 15:15:09 -0700 (PDT) (envelope-from jmg) Date: Wed, 22 Jul 2020 15:15:09 -0700 From: John-Mark Gurney To: "Bjoern A. Zeeb" Cc: freebsd-net@freebsd.org, freebsd-current@freebsd.org Subject: Re: somewhat reproducable vimage panic Message-ID: <20200722221509.GI4213@funkthat.com> Mail-Followup-To: "Bjoern A. Zeeb" , freebsd-net@freebsd.org, freebsd-current@freebsd.org References: <20200721091654.GC4213@funkthat.com> <20200721113153.42d83119@x23> <20200721202323.GE4213@funkthat.com> <38F5A3A6-B578-4BA4-8F69-C248163CB6E0@libassi.se> <20200722060514.GF4213@funkthat.com> <20200722193443.GG4213@funkthat.com> <6C149617-55BB-4A87-B993-195E5E133790@lists.zabbadoz.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6C149617-55BB-4A87-B993-195E5E133790@lists.zabbadoz.net> X-Operating-System: FreeBSD 11.3-STABLE amd64 X-PGP-Fingerprint: D87A 235F FB71 1F3F 55B7 ED9B D5FF 5A51 C0AC 3D65 X-Files: The truth is out there X-URL: https://www.funkthat.com/ X-Resume: https://www.funkthat.com/~jmg/resume.html X-TipJar: bitcoin:13Qmb6AeTgQecazTWph4XasEsP7nGRbAPE X-to-the-FBI-CIA-and-NSA: HI! HOW YA DOIN? can i haz chizburger? User-Agent: Mutt/1.6.1 (2016-04-27) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.4.3 (gold.funkthat.com [127.0.0.1]); Wed, 22 Jul 2020 15:15:09 -0700 (PDT) X-Rspamd-Queue-Id: 4BBqXN6QTJz4qhT X-Spamd-Bar: + Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=none (mx1.freebsd.org: domain of jmg@gold.funkthat.com has no SPF policy when checking 208.87.223.18) smtp.mailfrom=jmg@gold.funkthat.com X-Spamd-Result: default: False [1.93 / 15.00]; MID_RHS_MATCH_FROM(0.00)[]; ARC_NA(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; TO_DN_SOME(0.00)[]; NEURAL_HAM_LONG(-0.28)[-0.283]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[funkthat.com]; AUTH_NA(1.00)[]; NEURAL_SPAM_MEDIUM(0.67)[0.675]; NEURAL_SPAM_SHORT(0.34)[0.336]; TO_MATCH_ENVRCPT_SOME(0.00)[]; R_SPF_NA(0.00)[no SPF record]; FORGED_SENDER(0.30)[jmg@funkthat.com,jmg@gold.funkthat.com]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:32354, ipnet:208.87.216.0/21, country:US]; FROM_NEQ_ENVFROM(0.00)[jmg@funkthat.com,jmg@gold.funkthat.com]; RCVD_TLS_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 Jul 2020 22:15:17 -0000 Bjoern A. Zeeb wrote this message on Wed, Jul 22, 2020 at 20:43 +0000: > On 22 Jul 2020, at 19:34, John-Mark Gurney wrote: > > > John-Mark Gurney wrote this message on Tue, Jul 21, 2020 at 23:05 > > -0700: > >> Peter Libassi wrote this message on Wed, Jul 22, 2020 at 06:54 +0200: > >>> Is this related to > >>> > >>> https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=234985 > >>> and > >>> https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=238326 > >>> > >> > >> Definitely not 234985.. I'm using ue interfaces, and so they don't > >> get destroyed while the jail is going away... > >> > >> I don't think it's 238326 either. This is 100% reliable and it's in > >> the IP multicast code.. It looks like in_multi isn't holding an > >> interface or address lock waiting for things to free up... > > > > Did a little more poking, and it looks like the vnet is free'd before > > the ifnet is free'd causing this problem: > > (kgdb) print inm->inm_ifp[0].if_refcount > > $5 = 1 > > (kgdb) print inm->inm_ifp[0].if_vnet[0] > > $6 = {vnet_le = {le_next = 0xdeadc0dedeadc0de, le_prev = > > 0xdeadc0dedeadc0de}, > > vnet_magic_n = 3735929054, vnet_ifcnt = 3735929054, > > vnet_sockcnt = 3735929054, vnet_state = 3735929054, > > vnet_data_mem = 0xdeadc0dedeadc0de, vnet_data_base = > > 16045693110842147038, > > vnet_shutdown = 222} > > > > So the multicast code is fine, it holds and releases a reference to > > ifnet.. > > > > The issue is that the reference to the ifnet doesn't involve a > > reference to the vnet/prison. > > Does it need to? The ifnet cannot go away while something holds a > reference to it, right? It's the other way around that's the problem.. the ifnet is holding an invalid vnet pointer that got free'd. Maybe the problem isn't the tear down, but that the vnet pointer isn't changed/restored before the free? > Sounds more like the teardown order is wrong (again)? > > There should be no more multicast when IP etc. is gone. That means MC > doesn???t properly cleanup itself. Don't know, just know that it's easy to trigger right now... I haven't tested on prior releases, but if you'd like me to, it isn't too hard for me to test... > I guess I should go back now and re-read your original problem statement > on how you trigger this.. So, it's pretty easy to trigger, just attach a couple USB ethernet adapters, in my case, they were ure, but likely any two spare ethernet interfaces will work, and wire them back to back.. Run the script attached earlier in the thread, providing it the name of the two interfaces as arguments, and run it a few times. You might get failures or not. It shouldn't matter. After a few runs, it'll panic... I just tested this (to make sure my ure changes weren't causing addition problems) using FreeBSD-13.0-CURRENT-amd64-20200625-r362596-memstick.img.xz, so it's stock reproducable. Thanks for looking into this! -- John-Mark Gurney Voice: +1 415 225 5579 "All that I will do, has been done, All that I have, has not." From owner-freebsd-current@freebsd.org Thu Jul 23 07:19:48 2020 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 8D46E373C83; Thu, 23 Jul 2020 07:19:48 +0000 (UTC) (envelope-from kp@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4BC3ch3C31z49FC; Thu, 23 Jul 2020 07:19:48 +0000 (UTC) (envelope-from kp@FreeBSD.org) Received: from venus.codepro.be (venus.codepro.be [5.9.86.228]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mx1.codepro.be", Issuer "Let's Encrypt Authority X3" (verified OK)) (Authenticated sender: kp) by smtp.freebsd.org (Postfix) with ESMTPSA id 3733A17ECB; Thu, 23 Jul 2020 07:19:48 +0000 (UTC) (envelope-from kp@FreeBSD.org) Received: by venus.codepro.be (Postfix, authenticated sender kp) id 1614F3D0DC; Thu, 23 Jul 2020 09:19:45 +0200 (CEST) From: "Kristof Provost" To: "John-Mark Gurney" Cc: "Bjoern A. Zeeb" , freebsd-net@freebsd.org, freebsd-current@freebsd.org Subject: Re: somewhat reproducable vimage panic Date: Thu, 23 Jul 2020 09:19:45 +0200 X-Mailer: MailMate (1.13.1r5671) Message-ID: <2FFC49F9-83DE-4FA1-A47F-1D8A7AF4B241@FreeBSD.org> In-Reply-To: <20200722221509.GI4213@funkthat.com> References: <20200721091654.GC4213@funkthat.com> <20200721113153.42d83119@x23> <20200721202323.GE4213@funkthat.com> <38F5A3A6-B578-4BA4-8F69-C248163CB6E0@libassi.se> <20200722060514.GF4213@funkthat.com> <20200722193443.GG4213@funkthat.com> <6C149617-55BB-4A87-B993-195E5E133790@lists.zabbadoz.net> <20200722221509.GI4213@funkthat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-Content-Filtered-By: Mailman/MimeDel 2.1.33 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Jul 2020 07:19:48 -0000 On 23 Jul 2020, at 0:15, John-Mark Gurney wrote: > So, it's pretty easy to trigger, just attach a couple USB ethernet > adapters, in my case, they were ure, but likely any two spare ethernet > interfaces will work, and wire them back to back.. > I’ve been able to trigger it using epair as well: `sudo sh testinterfaces.txt epair0a epair0b` I did have to comment out the waitcarrier() check. Best regards, Kristof From owner-freebsd-current@freebsd.org Thu Jul 23 08:09:31 2020 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 5C1123759D9; Thu, 23 Jul 2020 08:09:31 +0000 (UTC) (envelope-from kp@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4BC4k31rjvz4DQR; Thu, 23 Jul 2020 08:09:31 +0000 (UTC) (envelope-from kp@FreeBSD.org) Received: from venus.codepro.be (venus.codepro.be [5.9.86.228]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mx1.codepro.be", Issuer "Let's Encrypt Authority X3" (verified OK)) (Authenticated sender: kp) by smtp.freebsd.org (Postfix) with ESMTPSA id E7E0E17F2D; Thu, 23 Jul 2020 08:09:30 +0000 (UTC) (envelope-from kp@FreeBSD.org) Received: by venus.codepro.be (Postfix, authenticated sender kp) id 6D7823D5E4; Thu, 23 Jul 2020 10:09:29 +0200 (CEST) From: "Kristof Provost" To: "John-Mark Gurney" Cc: "Bjoern A. Zeeb" , freebsd-net@freebsd.org, freebsd-current@freebsd.org Subject: Re: somewhat reproducable vimage panic Date: Thu, 23 Jul 2020 10:09:25 +0200 X-Mailer: MailMate (1.13.1r5671) Message-ID: <6847FB6B-0B1A-43C7-B567-15BF21AB5D56@FreeBSD.org> In-Reply-To: <2FFC49F9-83DE-4FA1-A47F-1D8A7AF4B241@FreeBSD.org> References: <20200721091654.GC4213@funkthat.com> <20200721113153.42d83119@x23> <20200721202323.GE4213@funkthat.com> <38F5A3A6-B578-4BA4-8F69-C248163CB6E0@libassi.se> <20200722060514.GF4213@funkthat.com> <20200722193443.GG4213@funkthat.com> <6C149617-55BB-4A87-B993-195E5E133790@lists.zabbadoz.net> <20200722221509.GI4213@funkthat.com> <2FFC49F9-83DE-4FA1-A47F-1D8A7AF4B241@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Content-Filtered-By: Mailman/MimeDel 2.1.33 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Jul 2020 08:09:31 -0000 On 23 Jul 2020, at 9:19, Kristof Provost wrote: > On 23 Jul 2020, at 0:15, John-Mark Gurney wrote: >> So, it's pretty easy to trigger, just attach a couple USB ethernet >> adapters, in my case, they were ure, but likely any two spare >> ethernet >> interfaces will work, and wire them back to back.. >> > I’ve been able to trigger it using epair as well: > > `sudo sh testinterfaces.txt epair0a epair0b` > > I did have to comment out the waitcarrier() check. > I’ve done a little bit of digging, and I think I’m starting to see how this breaks. This always affects the jailed vlan interfaces. They’re getting deleted, but the ifp doesn’t go away just yet because it’s still in use by the multicast code. The multicast code does its cleanup in task queues, so by the time it gets around to doing that the ifp is already marked as dying and the vnet is gone. There are still references to the ifp though, and when the multicast code tries to do its cleanup we get the panic. This hack stops the panic for me, but I don’t know if this is the best solution: diff --git a/sys/net/if.c b/sys/net/if.c index 59dd38267cf..bd0c87eddf1 100644 --- a/sys/net/if.c +++ b/sys/net/if.c @@ -3681,6 +3685,10 @@ if_delmulti_ifma_flags(struct ifmultiaddr *ifma, int flags) ifp = NULL; } #endif + + if (ifp && ifp->if_flags & IFF_DYING) + return; + /* * If and only if the ifnet instance exists: Acquire the address lock. */ diff --git a/sys/netinet/in_mcast.c b/sys/netinet/in_mcast.c index 39fc82c5372..6493e2a5bfb 100644 --- a/sys/netinet/in_mcast.c +++ b/sys/netinet/in_mcast.c @@ -623,7 +623,7 @@ inm_release(struct in_multi *inm) /* XXX this access is not covered by IF_ADDR_LOCK */ CTR2(KTR_IGMPV3, "%s: purging ifma %p", __func__, ifma); - if (ifp != NULL) { + if (ifp != NULL && (ifp->if_flags & IFF_DYING) == 0) { CURVNET_SET(ifp->if_vnet); inm_purge(inm); free(inm, M_IPMADDR); Best regards, Kristof From owner-freebsd-current@freebsd.org Thu Jul 23 09:00:19 2020 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 17184377514; Thu, 23 Jul 2020 09:00:19 +0000 (UTC) (envelope-from bzeeb-lists@lists.zabbadoz.net) Received: from mx1.sbone.de (mx1.sbone.de [IPv6:2a01:4f8:13b:39f::9f:25]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mx1.sbone.de", Issuer "SBone.DE" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4BC5rd66t0z4HMv; Thu, 23 Jul 2020 09:00:17 +0000 (UTC) (envelope-from bzeeb-lists@lists.zabbadoz.net) Received: from mail.sbone.de (mail.sbone.de [IPv6:fde9:577b:c1a9:31::2013:587]) (using TLSv1 with cipher ADH-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by mx1.sbone.de (Postfix) with ESMTPS id 9A6F08D4A156; Thu, 23 Jul 2020 09:00:13 +0000 (UTC) Received: from content-filter.sbone.de (content-filter.sbone.de [IPv6:fde9:577b:c1a9:31::2013:2742]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.sbone.de (Postfix) with ESMTPS id 17B2AE708CD; Thu, 23 Jul 2020 09:00:13 +0000 (UTC) X-Virus-Scanned: amavisd-new at sbone.de Received: from mail.sbone.de ([IPv6:fde9:577b:c1a9:31::2013:587]) by content-filter.sbone.de (content-filter.sbone.de [fde9:577b:c1a9:31::2013:2742]) (amavisd-new, port 10024) with ESMTP id WBYfcBpt6JUQ; Thu, 23 Jul 2020 09:00:11 +0000 (UTC) Received: from [127.0.0.1] (unknown [IPv6:fde9:577b:c1a9:4902:5ca3:9f20:8345:9910]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.sbone.de (Postfix) with ESMTPSA id 40A2EE707BC; Thu, 23 Jul 2020 09:00:10 +0000 (UTC) From: "Bjoern A. Zeeb" To: "Kristof Provost" Cc: "John-Mark Gurney" , freebsd-net@freebsd.org, freebsd-current@freebsd.org Subject: Re: somewhat reproducable vimage panic Date: Thu, 23 Jul 2020 09:00:09 +0000 X-Mailer: MailMate (2.0BETAr6146) Message-ID: <8B72C0B9-9CF0-4557-81D7-77190775805C@lists.zabbadoz.net> In-Reply-To: <6847FB6B-0B1A-43C7-B567-15BF21AB5D56@FreeBSD.org> References: <20200721091654.GC4213@funkthat.com> <20200721113153.42d83119@x23> <20200721202323.GE4213@funkthat.com> <38F5A3A6-B578-4BA4-8F69-C248163CB6E0@libassi.se> <20200722060514.GF4213@funkthat.com> <20200722193443.GG4213@funkthat.com> <6C149617-55BB-4A87-B993-195E5E133790@lists.zabbadoz.net> <20200722221509.GI4213@funkthat.com> <2FFC49F9-83DE-4FA1-A47F-1D8A7AF4B241@FreeBSD.org> <6847FB6B-0B1A-43C7-B567-15BF21AB5D56@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 4BC5rd66t0z4HMv X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of bzeeb-lists@lists.zabbadoz.net designates 2a01:4f8:13b:39f::9f:25 as permitted sender) smtp.mailfrom=bzeeb-lists@lists.zabbadoz.net X-Spamd-Result: default: False [-2.87 / 15.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[]; RCVD_COUNT_FIVE(0.00)[5]; NEURAL_HAM_MEDIUM(-0.96)[-0.956]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip6:2a01:4f8:13b:39f::9f:25]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[zabbadoz.net]; NEURAL_HAM_LONG(-1.02)[-1.020]; TO_MATCH_ENVRCPT_SOME(0.00)[]; NEURAL_HAM_SHORT(-0.59)[-0.591]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:24940, ipnet:2a01:4f8::/29, country:DE]; RCVD_TLS_LAST(0.00)[]; MID_RHS_MATCH_FROM(0.00)[] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Jul 2020 09:00:19 -0000 On 23 Jul 2020, at 8:09, Kristof Provost wrote: > On 23 Jul 2020, at 9:19, Kristof Provost wrote: >> On 23 Jul 2020, at 0:15, John-Mark Gurney wrote: >>> So, it's pretty easy to trigger, just attach a couple USB ethernet >>> adapters, in my case, they were ure, but likely any two spare >>> ethernet >>> interfaces will work, and wire them back to back.. >>> >> I’ve been able to trigger it using epair as well: >> >> `sudo sh testinterfaces.txt epair0a epair0b` >> >> I did have to comment out the waitcarrier() check. >> > I’ve done a little bit of digging, and I think I’m starting to see > how this breaks. > > This always affects the jailed vlan interfaces. They’re getting > deleted, but the ifp doesn’t go away just yet because it’s still > in use by the multicast code. > The multicast code does its cleanup in task queues, Wow, did I miss that back then? Did I review a change and not notice? Sorry if that was the case. Vnet teardown is blocking and forceful. Doing deferred cleanup work isn’t a good idea at all. I think that is the real problem here. I’d rather have us fix this than putting more bandaids into the code. /bz PS: I love that you can repro this with epairs, means we can write a generic test code piece for this and commit it. > so by the time it gets around to doing that the ifp is already marked > as dying and the vnet is gone. > There are still references to the ifp though, and when the multicast > code tries to do its cleanup we get the panic. > > This hack stops the panic for me, but I don’t know if this is the > best solution: > > diff --git a/sys/net/if.c b/sys/net/if.c > index 59dd38267cf..bd0c87eddf1 100644 > --- a/sys/net/if.c > +++ b/sys/net/if.c > @@ -3681,6 +3685,10 @@ if_delmulti_ifma_flags(struct ifmultiaddr > *ifma, int flags) > ifp = NULL; > } > #endif > + > + if (ifp && ifp->if_flags & IFF_DYING) > + return; > + > /* > * If and only if the ifnet instance exists: Acquire the address > lock. > */ > diff --git a/sys/netinet/in_mcast.c b/sys/netinet/in_mcast.c > index 39fc82c5372..6493e2a5bfb 100644 > --- a/sys/netinet/in_mcast.c > +++ b/sys/netinet/in_mcast.c > @@ -623,7 +623,7 @@ inm_release(struct in_multi *inm) > > /* XXX this access is not covered by IF_ADDR_LOCK */ > CTR2(KTR_IGMPV3, "%s: purging ifma %p", __func__, ifma); > - if (ifp != NULL) { > + if (ifp != NULL && (ifp->if_flags & IFF_DYING) == 0) { > CURVNET_SET(ifp->if_vnet); > inm_purge(inm); > free(inm, M_IPMADDR); > > Best regards, > Kristof From owner-freebsd-current@freebsd.org Thu Jul 23 09:02:04 2020 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 343E03776CB; Thu, 23 Jul 2020 09:02:04 +0000 (UTC) (envelope-from kp@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4BC5tg5hktz4Hbg; Thu, 23 Jul 2020 09:02:03 +0000 (UTC) (envelope-from kp@FreeBSD.org) Received: from venus.codepro.be (venus.codepro.be [5.9.86.228]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mx1.codepro.be", Issuer "Let's Encrypt Authority X3" (verified OK)) (Authenticated sender: kp) by smtp.freebsd.org (Postfix) with ESMTPSA id 9209A18D33; Thu, 23 Jul 2020 09:02:03 +0000 (UTC) (envelope-from kp@FreeBSD.org) Received: by venus.codepro.be (Postfix, authenticated sender kp) id DD3AF3D804; Thu, 23 Jul 2020 11:02:01 +0200 (CEST) From: "Kristof Provost" To: "Bjoern A. Zeeb" Cc: "John-Mark Gurney" , freebsd-net@freebsd.org, freebsd-current@freebsd.org Subject: Re: somewhat reproducable vimage panic Date: Thu, 23 Jul 2020 11:02:01 +0200 X-Mailer: MailMate (1.13.1r5671) Message-ID: In-Reply-To: <8B72C0B9-9CF0-4557-81D7-77190775805C@lists.zabbadoz.net> References: <20200721091654.GC4213@funkthat.com> <20200721113153.42d83119@x23> <20200721202323.GE4213@funkthat.com> <38F5A3A6-B578-4BA4-8F69-C248163CB6E0@libassi.se> <20200722060514.GF4213@funkthat.com> <20200722193443.GG4213@funkthat.com> <6C149617-55BB-4A87-B993-195E5E133790@lists.zabbadoz.net> <20200722221509.GI4213@funkthat.com> <2FFC49F9-83DE-4FA1-A47F-1D8A7AF4B241@FreeBSD.org> <6847FB6B-0B1A-43C7-B567-15BF21AB5D56@FreeBSD.org> <8B72C0B9-9CF0-4557-81D7-77190775805C@lists.zabbadoz.net> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Jul 2020 09:02:04 -0000 On 23 Jul 2020, at 11:00, Bjoern A. Zeeb wrote: > On 23 Jul 2020, at 8:09, Kristof Provost wrote: > >> On 23 Jul 2020, at 9:19, Kristof Provost wrote: >>> On 23 Jul 2020, at 0:15, John-Mark Gurney wrote: >>>> So, it's pretty easy to trigger, just attach a couple USB ethernet >>>> adapters, in my case, they were ure, but likely any two spare >>>> ethernet >>>> interfaces will work, and wire them back to back.. >>>> >>> I’ve been able to trigger it using epair as well: >>> >>> `sudo sh testinterfaces.txt epair0a epair0b` >>> >>> I did have to comment out the waitcarrier() check. >>> >> I’ve done a little bit of digging, and I think I’m starting to >> see how this breaks. >> >> This always affects the jailed vlan interfaces. They’re getting >> deleted, but the ifp doesn’t go away just yet because it’s still >> in use by the multicast code. >> The multicast code does its cleanup in task queues, > > Wow, did I miss that back then? Did I review a change and not notice? > Sorry if that was the case. > > Vnet teardown is blocking and forceful. > Doing deferred cleanup work isn’t a good idea at all. > I think that is the real problem here. > > I’d rather have us fix this than putting more bandaids into the > code. > Yeah, agreed. I think hselasky has a better fix: https://reviews.freebsd.org/D24914 I just saw his e-mail in a different thread. Best regards, Kristof From owner-freebsd-current@freebsd.org Thu Jul 23 09:27:45 2020 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 00B043785CD; Thu, 23 Jul 2020 09:27:45 +0000 (UTC) (envelope-from zec@fer.hr) Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04on0602.outbound.protection.outlook.com [IPv6:2a01:111:f400:fe0d::602]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mail.protection.outlook.com", Issuer "GlobalSign Organization Validation CA - SHA256 - G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4BC6SJ3WH2z4Kgr; Thu, 23 Jul 2020 09:27:43 +0000 (UTC) (envelope-from zec@fer.hr) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hT1FaocwDVGtXBPyaT9VHpfEbkZPnrJme5CjfdSfAswoj5WAf4UAS5JdYm3B9KIdi6WXaMI0fJnuDn7VdBuWX/QKIilkQZcwlGIvpE/3itlepdPItpl3LKQGxChkagnG18jY544kMbSv4py+1TetNGpUqAFIV0xrTxnw7WtPPe4CXFo5G92g5A2PHGaoXtRk0T27g4Tc7pZ/oVtdR85T31U806R+g/FE8DW4H9wGnbjDKrwVtdpOE9KW4iPjYppuWGLbKaIGW9dcLoj0JU4D8vIRx3wIY55SZwKKR/CugVsVj3lPwrfyvkHahuUPaGi6FDDOjIKFNuWxAjZjYrncdg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1jtPa+Htpj9/oJqYQ+PsEwy4V2JR6EG54B4NFtiKSVc=; b=eFvjjRAknkbSzPNJ5ehJzMJYib6atC/stJYhemrK/YZBhTqjT8JxXDYCXmyNVa+917dbg813kZvx7T5EUVSUXDpTY3KH17E+eeJk+Y1HhAZvyUOCLm+GPf5FjCB53GtuexXJ0hHhDjt12Oga6FyE1I97qx2XhwtJEMvV1mCybCa2f9a++jRZOz9C6gvhmgtPAiVLQ0GlF/Ay9y3GWkyrDNoCXtzmG1dm2kKOLQjUCePVPXyQF8TznMDV3CgRKWxyvCwElGj30WOBRYN4eq/ssQqZdf86Ceupn/fSMS52TeBx6MHazixbSTNBgcLShRkVHgut/Js0Qp7DUQXIr4W+iQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=fer.hr; dmarc=pass action=none header.from=fer.hr; dkim=pass header.d=fer.hr; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ferhr.onmicrosoft.com; s=selector2-ferhr-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1jtPa+Htpj9/oJqYQ+PsEwy4V2JR6EG54B4NFtiKSVc=; b=E4uDGGXX16TeICwMEgq2qDXGl8Yipar2Q1eoEOtDEbjqy6MNiIDOjTUv3C791jlrzbP9+OtCpE6iMPJ/nQhCOBxPS1txBgnU1Qh9aVzUj773cXeEu1z26Z48UKL+dgWdooQqm5UWC/i/T0CgHma6SS9CauiXIdG51zvdZlIbc8U= Received: from DBBPR08MB4775.eurprd08.prod.outlook.com (2603:10a6:10:da::19) by DBBPR08MB4537.eurprd08.prod.outlook.com (2603:10a6:10:c5::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3216.20; Thu, 23 Jul 2020 09:27:41 +0000 Received: from DBBPR08MB4775.eurprd08.prod.outlook.com ([fe80::608f:e143:490f:256d]) by DBBPR08MB4775.eurprd08.prod.outlook.com ([fe80::608f:e143:490f:256d%7]) with mapi id 15.20.3216.023; Thu, 23 Jul 2020 09:27:41 +0000 Date: Thu, 23 Jul 2020 11:27:51 +0200 From: Marko Zec To: "Kristof Provost" Cc: "Bjoern A. Zeeb" , "John-Mark Gurney" , freebsd-net@freebsd.org, freebsd-current@freebsd.org Subject: Re: somewhat reproducable vimage panic Message-ID: <20200723112751.0428fabc@x23> In-Reply-To: References: <20200721091654.GC4213@funkthat.com> <20200721113153.42d83119@x23> <20200721202323.GE4213@funkthat.com> <38F5A3A6-B578-4BA4-8F69-C248163CB6E0@libassi.se> <20200722060514.GF4213@funkthat.com> <20200722193443.GG4213@funkthat.com> <6C149617-55BB-4A87-B993-195E5E133790@lists.zabbadoz.net> <20200722221509.GI4213@funkthat.com> <2FFC49F9-83DE-4FA1-A47F-1D8A7AF4B241@FreeBSD.org> <6847FB6B-0B1A-43C7-B567-15BF21AB5D56@FreeBSD.org> <8B72C0B9-9CF0-4557-81D7-77190775805C@lists.zabbadoz.net> X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; amd64-portbld-freebsd11.3) Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-ClientProxiedBy: ZRAP278CA0007.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:10::17) To DBBPR08MB4775.eurprd08.prod.outlook.com (2603:10a6:10:da::19) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from x23 (161.53.19.9) by ZRAP278CA0007.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:10::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3216.20 via Frontend Transport; Thu, 23 Jul 2020 09:27:41 +0000 X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; amd64-portbld-freebsd11.3) X-Originating-IP: [161.53.19.9] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 34c73706-fc8e-4e62-78bc-08d82eeaa5f7 X-MS-TrafficTypeDiagnostic: DBBPR08MB4537: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:4303; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: BV29R9n2Z+mA+Bj9GjgUmE44HI6hGAPGF5BIEIs970Vbhu5KMfELyj3L2/mQtQeFrvA3uoO6w+hx9dKX+t7cFxJ1colqLy6wmJDWPWodggqkdAoVPg/80HmY2PzgAtTG2E6ja3cXnKjfbwdJqufZ41w9nKsuS9fcBBlgNvEfCVW9AujAePX4XixcsiTBSLZsH3baMIjC+NOCU/o0RkYOI6tXsmu5wRMpE9iCqnGRkaoMrKDjFKKRJn/MNuEjBX/s8ccSjXKaLVMHkPnZbEEGDiCjWs9s4CTfzSK++/zSla7oHwE9Dsvr96WHr8IWGPRNvT8CCpeijkQZlNw0bRCyqy4jbdluSLEriBXuYgePvm8vyjpwuHyXgioX/c9+udHJ+Bs7KY1bH05KT0Zi3VKrDQ== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DBBPR08MB4775.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(396003)(39850400004)(366004)(136003)(376002)(346002)(4326008)(6916009)(478600001)(5660300002)(9686003)(55016002)(966005)(956004)(8936002)(6666004)(9576002)(33716001)(52116002)(66946007)(66556008)(66476007)(3480700007)(786003)(186003)(26005)(16526019)(54906003)(86362001)(1076003)(4744005)(6496006)(2906002)(316002)(8676002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData: ZlLR9GL3uRK2vNnOnz0wBb0VlMX9kwEQPNZ2CIUh1DPXdq+AVVFCOFRKPLHry0aohCviAthmCEqpwEaE+rzs77fCr9Tq3P85PdO255SJuVj9dBgSDUsV/CfXqN0djbpC4L8wbz0ab2MpnVVp2EYi6HEe8PCnlIeMsG+EroCLclyMEiovoZsVsiu4a4gU0InhRxj1knjtXy6pw0gMhrvAi+6yB5F7uI/hgDdvtiFGoy+uGYh4/YKyoyutBn7bvpv0L07r76dZrzNJ2nR4E0EMVnwO8YwS37vXhBNlEwwHq9Q23gdJGmhk/NpC/K7JlicieR1l+USsbjU69o+HuB1VXy+lMBhCCIvKUcp88xU2aWeaTwkK8FYMAvqjetOBvoOiEdc1oYmHyk+5HZ31A6kSEMfonOtNSxpGUxmNOxLfgggoeNCxFYUkd/57RaLEms+7NTDe/NwBAB5sfRN0KNY1DoLjKTQFfLpm/QcQy0LEzBQ= X-OriginatorOrg: fer.hr X-MS-Exchange-CrossTenant-Network-Message-Id: 34c73706-fc8e-4e62-78bc-08d82eeaa5f7 X-MS-Exchange-CrossTenant-AuthSource: DBBPR08MB4775.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Jul 2020 09:27:41.7217 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: ca71eddc-cc7b-4e5b-95bd-55b658e696be X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: oWE8xifnTZE8rifw99NMxH22jP6t9D0jW1f+4Zai5uOX/BIXw6dNFsODH7sc9/xR X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR08MB4537 X-Rspamd-Queue-Id: 4BC6SJ3WH2z4Kgr X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:8075, ipnet:2a01:111:f000::/36, country:US] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Jul 2020 09:27:45 -0000 On Thu, 23 Jul 2020 11:02:01 +0200 "Kristof Provost" wrote: > Yeah, agreed. I think hselasky has a better fix: > https://reviews.freebsd.org/D24914 Yup, that should be it. > > I just saw his e-mail in a different thread. > > Best regards, > Kristof > _______________________________________________ > freebsd-current@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/freebsd-current > To unsubscribe, send any mail to > "freebsd-current-unsubscribe@freebsd.org" From owner-freebsd-current@freebsd.org Thu Jul 23 19:26:50 2020 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id E3173360FDD; Thu, 23 Jul 2020 19:26:50 +0000 (UTC) (envelope-from bzeeb-lists@lists.zabbadoz.net) Received: from mx1.sbone.de (cross.sbone.de [195.201.62.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mx1.sbone.de", Issuer "SBone.DE" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4BCMlZ0DYFz43Q0; Thu, 23 Jul 2020 19:26:49 +0000 (UTC) (envelope-from bzeeb-lists@lists.zabbadoz.net) Received: from mail.sbone.de (mail.sbone.de [IPv6:fde9:577b:c1a9:31::2013:587]) (using TLSv1 with cipher ADH-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by mx1.sbone.de (Postfix) with ESMTPS id 6F5B48D4A156; Thu, 23 Jul 2020 19:26:42 +0000 (UTC) Received: from content-filter.sbone.de (content-filter.sbone.de [IPv6:fde9:577b:c1a9:31::2013:2742]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.sbone.de (Postfix) with ESMTPS id D9125E708CD; Thu, 23 Jul 2020 19:26:41 +0000 (UTC) X-Virus-Scanned: amavisd-new at sbone.de Received: from mail.sbone.de ([IPv6:fde9:577b:c1a9:31::2013:587]) by content-filter.sbone.de (content-filter.sbone.de [fde9:577b:c1a9:31::2013:2742]) (amavisd-new, port 10024) with ESMTP id M1plGXSJ2cS3; Thu, 23 Jul 2020 19:26:40 +0000 (UTC) Received: from [127.0.0.1] (unknown [IPv6:fde9:577b:c1a9:4902:7c3a:ebfc:75b:b9a6]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.sbone.de (Postfix) with ESMTPSA id C73A4E708CA; Thu, 23 Jul 2020 19:26:38 +0000 (UTC) From: "Bjoern A. Zeeb" To: "Kristof Provost" , "Hans Petter Selasky" Cc: "John-Mark Gurney" , freebsd-net@freebsd.org, freebsd-current@freebsd.org Subject: Re: somewhat reproducable vimage panic Date: Thu, 23 Jul 2020 19:26:38 +0000 X-Mailer: MailMate (2.0BETAr6146) Message-ID: In-Reply-To: References: <20200721091654.GC4213@funkthat.com> <20200721113153.42d83119@x23> <20200721202323.GE4213@funkthat.com> <38F5A3A6-B578-4BA4-8F69-C248163CB6E0@libassi.se> <20200722060514.GF4213@funkthat.com> <20200722193443.GG4213@funkthat.com> <6C149617-55BB-4A87-B993-195E5E133790@lists.zabbadoz.net> <20200722221509.GI4213@funkthat.com> <2FFC49F9-83DE-4FA1-A47F-1D8A7AF4B241@FreeBSD.org> <6847FB6B-0B1A-43C7-B567-15BF21AB5D56@FreeBSD.org> <8B72C0B9-9CF0-4557-81D7-77190775805C@lists.zabbadoz.net> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 4BCMlZ0DYFz43Q0 X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of bzeeb-lists@lists.zabbadoz.net designates 195.201.62.131 as permitted sender) smtp.mailfrom=bzeeb-lists@lists.zabbadoz.net X-Spamd-Result: default: False [-2.81 / 15.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[]; RCVD_COUNT_FIVE(0.00)[5]; NEURAL_HAM_MEDIUM(-1.02)[-1.017]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip4:195.201.62.131]; NEURAL_HAM_LONG(-1.02)[-1.024]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[zabbadoz.net]; RCPT_COUNT_FIVE(0.00)[5]; TO_MATCH_ENVRCPT_SOME(0.00)[]; NEURAL_HAM_SHORT(-0.47)[-0.469]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:24940, ipnet:195.201.0.0/16, country:DE]; RCVD_TLS_LAST(0.00)[]; MID_RHS_MATCH_FROM(0.00)[] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Jul 2020 19:26:50 -0000 On 23 Jul 2020, at 9:02, Kristof Provost wrote: > On 23 Jul 2020, at 11:00, Bjoern A. Zeeb wrote: >> On 23 Jul 2020, at 8:09, Kristof Provost wrote: >> >>> On 23 Jul 2020, at 9:19, Kristof Provost wrote: >>>> On 23 Jul 2020, at 0:15, John-Mark Gurney wrote: >>>>> So, it's pretty easy to trigger, just attach a couple USB ethernet >>>>> adapters, in my case, they were ure, but likely any two spare >>>>> ethernet >>>>> interfaces will work, and wire them back to back.. >>>>> >>>> I’ve been able to trigger it using epair as well: >>>> >>>> `sudo sh testinterfaces.txt epair0a epair0b` >>>> >>>> I did have to comment out the waitcarrier() check. >>>> >>> I’ve done a little bit of digging, and I think I’m starting to >>> see how this breaks. >>> >>> This always affects the jailed vlan interfaces. They’re getting >>> deleted, but the ifp doesn’t go away just yet because it’s still >>> in use by the multicast code. >>> The multicast code does its cleanup in task queues, >> >> Wow, did I miss that back then? Did I review a change and not notice? >> Sorry if that was the case. >> >> Vnet teardown is blocking and forceful. >> Doing deferred cleanup work isn’t a good idea at all. >> I think that is the real problem here. >> >> I’d rather have us fix this than putting more bandaids into the >> code. >> > Yeah, agreed. I think hselasky has a better fix: > https://reviews.freebsd.org/D24914 > > I just saw his e-mail in a different thread. That’ll probably work; still, the deferred teardown work seems wrong to me; I haven’t investigated; the patch kind-of says exactly that as well: if “wait until deferred stuff is done” is all we are doing, why can we not do it on the spot then? /bz From owner-freebsd-current@freebsd.org Thu Jul 23 23:49:35 2020 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 9A129367A00; Thu, 23 Jul 2020 23:49:35 +0000 (UTC) (envelope-from jmg@gold.funkthat.com) Received: from gold.funkthat.com (gate2.funkthat.com [208.87.223.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "gate2.funkthat.com", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4BCTZl0tCsz4K5G; Thu, 23 Jul 2020 23:49:34 +0000 (UTC) (envelope-from jmg@gold.funkthat.com) Received: from gold.funkthat.com (localhost [127.0.0.1]) by gold.funkthat.com (8.15.2/8.15.2) with ESMTPS id 06NNnQoL053031 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Thu, 23 Jul 2020 16:49:26 -0700 (PDT) (envelope-from jmg@gold.funkthat.com) Received: (from jmg@localhost) by gold.funkthat.com (8.15.2/8.15.2/Submit) id 06NNnPdb053030; Thu, 23 Jul 2020 16:49:25 -0700 (PDT) (envelope-from jmg) Date: Thu, 23 Jul 2020 16:49:25 -0700 From: John-Mark Gurney To: Kristof Provost Cc: "Bjoern A. Zeeb" , freebsd-net@freebsd.org, freebsd-current@freebsd.org Subject: Re: somewhat reproducable vimage panic Message-ID: <20200723234925.GL4213@funkthat.com> Mail-Followup-To: Kristof Provost , "Bjoern A. Zeeb" , freebsd-net@freebsd.org, freebsd-current@freebsd.org References: <20200721202323.GE4213@funkthat.com> <38F5A3A6-B578-4BA4-8F69-C248163CB6E0@libassi.se> <20200722060514.GF4213@funkthat.com> <20200722193443.GG4213@funkthat.com> <6C149617-55BB-4A87-B993-195E5E133790@lists.zabbadoz.net> <20200722221509.GI4213@funkthat.com> <2FFC49F9-83DE-4FA1-A47F-1D8A7AF4B241@FreeBSD.org> <6847FB6B-0B1A-43C7-B567-15BF21AB5D56@FreeBSD.org> <8B72C0B9-9CF0-4557-81D7-77190775805C@lists.zabbadoz.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Operating-System: FreeBSD 11.3-STABLE amd64 X-PGP-Fingerprint: D87A 235F FB71 1F3F 55B7 ED9B D5FF 5A51 C0AC 3D65 X-Files: The truth is out there X-URL: https://www.funkthat.com/ X-Resume: https://www.funkthat.com/~jmg/resume.html X-TipJar: bitcoin:13Qmb6AeTgQecazTWph4XasEsP7nGRbAPE X-to-the-FBI-CIA-and-NSA: HI! HOW YA DOIN? can i haz chizburger? User-Agent: Mutt/1.6.1 (2016-04-27) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.4.3 (gold.funkthat.com [127.0.0.1]); Thu, 23 Jul 2020 16:49:26 -0700 (PDT) X-Rspamd-Queue-Id: 4BCTZl0tCsz4K5G X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:32354, ipnet:208.87.216.0/21, country:US] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Jul 2020 23:49:35 -0000 Kristof Provost wrote this message on Thu, Jul 23, 2020 at 11:02 +0200: > On 23 Jul 2020, at 11:00, Bjoern A. Zeeb wrote: > > On 23 Jul 2020, at 8:09, Kristof Provost wrote: > > > >> On 23 Jul 2020, at 9:19, Kristof Provost wrote: > >>> On 23 Jul 2020, at 0:15, John-Mark Gurney wrote: > >>>> So, it's pretty easy to trigger, just attach a couple USB ethernet > >>>> adapters, in my case, they were ure, but likely any two spare > >>>> ethernet > >>>> interfaces will work, and wire them back to back.. > >>>> > >>> I???ve been able to trigger it using epair as well: > >>> > >>> `sudo sh testinterfaces.txt epair0a epair0b` > >>> > >>> I did have to comment out the waitcarrier() check. > >>> > >> I???ve done a little bit of digging, and I think I???m starting to > >> see how this breaks. > >> > >> This always affects the jailed vlan interfaces. They???re getting > >> deleted, but the ifp doesn???t go away just yet because it???s still > >> in use by the multicast code. > >> The multicast code does its cleanup in task queues, > > > > Wow, did I miss that back then? Did I review a change and not notice? > > Sorry if that was the case. > > > > Vnet teardown is blocking and forceful. > > Doing deferred cleanup work isn???t a good idea at all. > > I think that is the real problem here. > > > > I???d rather have us fix this than putting more bandaids into the > > code. > > > Yeah, agreed. I think hselasky has a better fix: > https://reviews.freebsd.org/D24914 > > I just saw his e-mail in a different thread. I'm testing out this patch now, and let people know how it goes.. It'll be nice to not have to worry about these panics.. -- John-Mark Gurney Voice: +1 415 225 5579 "All that I will do, has been done, All that I have, has not." From owner-freebsd-current@freebsd.org Fri Jul 24 14:02:20 2020 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 4E6BD366E97 for ; Fri, 24 Jul 2020 14:02:20 +0000 (UTC) (envelope-from webmaster@freebsd.org) Received: from mailman.nyi.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id 4BCrVh1Syfz4YnY for ; Fri, 24 Jul 2020 14:02:20 +0000 (UTC) (envelope-from webmaster@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id 326A6367089; Fri, 24 Jul 2020 14:02:20 +0000 (UTC) Delivered-To: current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 322CF366CF2 for ; Fri, 24 Jul 2020 14:02:20 +0000 (UTC) (envelope-from webmaster@freebsd.org) Received: from svrs.nwpowerster.co.za (svrs.nwpowerster.co.za [46.166.161.93]) by mx1.freebsd.org (Postfix) with ESMTP id 4BCrVg3XwHz4YZC for ; Fri, 24 Jul 2020 14:02:19 +0000 (UTC) (envelope-from webmaster@freebsd.org) Received: from dell.com (unknown [104.206.99.60]) by svrs.nwpowerster.co.za (Postfix) with ESMTPA id 4F9004C1AE0 for ; Fri, 24 Jul 2020 13:55:53 +0000 (UTC) Reply-To: freebsd.org From: freebsd.org To: current@freebsd.org Subject: current@freebsd.org Email Security Protocol Update Date: 24 Jul 2020 13:55:52 +0200 Message-ID: <20200724135552.A539E8216F06B3D1@freebsd.org> X-Rspamd-Queue-Id: 4BCrVg3XwHz4YZC X-Spamd-Bar: / Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [0.00 / 15.00]; ASN(0.00)[asn:16125, ipnet:46.166.160.0/21, country:LT]; local_wl_from(0.00)[freebsd.org] MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" X-Content-Filtered-By: Mailman/MimeDel 2.1.33 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Jul 2020 14:02:20 -0000 From owner-freebsd-current@freebsd.org Fri Jul 24 20:24:52 2020 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 95158372E69 for ; Fri, 24 Jul 2020 20:24:52 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4BD1043QtBz4F9p for ; Fri, 24 Jul 2020 20:24:52 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: from mail-qt1-f177.google.com (mail-qt1-f177.google.com [209.85.160.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) (Authenticated sender: kevans) by smtp.freebsd.org (Postfix) with ESMTPSA id 594AF28E10 for ; Fri, 24 Jul 2020 20:24:52 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: by mail-qt1-f177.google.com with SMTP id h21so1440451qtp.11 for ; Fri, 24 Jul 2020 13:24:52 -0700 (PDT) X-Gm-Message-State: AOAM533HNdTeYEYlgkzKEH4oSLdhBVEeZMP2rhT6D2bR+NQgfiF0Ozrp uL6VR78s0yofxflLLunZFa4cEp9fv45hOD6QwsM= X-Google-Smtp-Source: ABdhPJwJ46bEV2uCE7uiBbeQWikSFeh0jOIFq42tgw4YPwOnMdNDWg7eT7u74BsONVG614QzXRubykbgXPkMotxWMIY= X-Received: by 2002:aed:2822:: with SMTP id r31mr4421652qtd.310.1595622291891; Fri, 24 Jul 2020 13:24:51 -0700 (PDT) MIME-Version: 1.0 From: Kyle Evans Date: Fri, 24 Jul 2020 15:24:40 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: [CFT] Updated devel/valgrind-devel port To: FreeBSD Current Content-Type: text/plain; charset="UTF-8" X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Jul 2020 20:24:52 -0000 Hello! Just a little bit ago, I committed an update[0] to the valgrind-devel port that updates it to Paul Floyd's branch, where he has rebased us forward to 3.17.0 and largely fixed valgrind operation on both 12.x and -CURRENT. He's put in significant effort to get the test suite to pass on FreeBSD, the status of which is summarized here: - https://github.com/paulfloyd/freebsd_valgrind/wiki/Regtest-status Some outstanding issues: - https://github.com/paulfloyd/freebsd_valgrind/issues Please go forth and test it! Thanks, Kyle Evans [0] https://svnweb.freebsd.org/changeset/ports/543273 From owner-freebsd-current@freebsd.org Fri Jul 24 20:31:47 2020 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id A9F743735A5 for ; Fri, 24 Jul 2020 20:31:47 +0000 (UTC) (envelope-from manu@bidouilliste.com) Received: from mailman.nyi.freebsd.org (mailman.nyi.freebsd.org [IPv6:2610:1c1:1:606c::50:13]) by mx1.freebsd.org (Postfix) with ESMTP id 4BD1832pZwz4FnZ for ; Fri, 24 Jul 2020 20:31:47 +0000 (UTC) (envelope-from manu@bidouilliste.com) Received: by mailman.nyi.freebsd.org (Postfix) id 604B13735A4; Fri, 24 Jul 2020 20:31:47 +0000 (UTC) Delivered-To: current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 601143737B2 for ; Fri, 24 Jul 2020 20:31:47 +0000 (UTC) (envelope-from manu@bidouilliste.com) Received: from mx.blih.net (mx.blih.net [212.83.155.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "mx.blih.net", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4BD1812F6Nz4FXQ; Fri, 24 Jul 2020 20:31:44 +0000 (UTC) (envelope-from manu@bidouilliste.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bidouilliste.com; s=mx; t=1595622696; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LIY0MtP8gp6L3nstKgPwsfLbnzVAHB4aKMjrdW8BElc=; b=FYAVQmNtI7kSkANI+TZZfAU/wGAtGKp+MMaobVpLV78QqRswMWfiOtggJzDQQgfSwq4Fpv fQN1NI8i8lemu/Ot9hT204v9HYtvBlvE/LkrD5GEIwl/s6BcEGGTStVIN3ZcDx5ha44zao ZGSI20tsiqwENOIMFilOetmioy8G3WU= Received: from skull.home.blih.net (lfbn-idf2-1-1138-237.w90-92.abo.wanadoo.fr [90.92.20.237]) by mx.blih.net (OpenSMTPD) with ESMTPSA id fab77090 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Fri, 24 Jul 2020 20:31:36 +0000 (UTC) Date: Fri, 24 Jul 2020 22:31:35 +0200 From: Emmanuel Vadot To: Glen Barber Cc: current@freebsd.org, re@freebsd.org Subject: Re: nightly snapshot for CURRENT ? Message-Id: <20200724223135.7f3522f97968ce82b9b245ad@bidouilliste.com> In-Reply-To: <20200609220407.d745b7a073f58254ff2db714@bidouilliste.com> References: <20200609214756.13e9cbbc2de12bbb78839875@bidouilliste.com> <20200609195630.GN97889@FreeBSD.org> <20200609220407.d745b7a073f58254ff2db714@bidouilliste.com> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.32; amd64-portbld-freebsd13.0) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 4BD1812F6Nz4FXQ X-Spamd-Bar: - Authentication-Results: mx1.freebsd.org; dkim=pass header.d=bidouilliste.com header.s=mx header.b=FYAVQmNt; dmarc=pass (policy=none) header.from=bidouilliste.com; spf=pass (mx1.freebsd.org: domain of manu@bidouilliste.com designates 212.83.155.74 as permitted sender) smtp.mailfrom=manu@bidouilliste.com X-Spamd-Result: default: False [-1.71 / 15.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[]; R_DKIM_ALLOW(-0.20)[bidouilliste.com:s=mx]; MID_RHS_MATCH_FROM(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; MV_CASE(0.50)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; R_SPF_ALLOW(-0.20)[+mx]; NEURAL_HAM_LONG(-1.03)[-1.026]; TO_DN_SOME(0.00)[]; NEURAL_HAM_MEDIUM(-0.96)[-0.956]; DKIM_TRACE(0.00)[bidouilliste.com:+]; DMARC_POLICY_ALLOW(-0.50)[bidouilliste.com,none]; NEURAL_HAM_SHORT(-0.23)[-0.226]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; SUBJECT_ENDS_QUESTION(1.00)[]; ASN(0.00)[asn:12876, ipnet:212.83.128.0/19, country:FR]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Jul 2020 20:31:47 -0000 On Tue, 9 Jun 2020 22:04:07 +0200 Emmanuel Vadot wrote: > On Tue, 9 Jun 2020 19:56:30 +0000 > Glen Barber wrote: > > > On Tue, Jun 09, 2020 at 09:47:56PM +0200, Emmanuel Vadot wrote: > > > > > > Hello all, > > > > > > I've just hit again something that I've hit (and probably others too) > > > often. > > > If a change in base break some ports and it's snapshoted in the txz > > > available at download.freebsd.org, you need to wait a week for the next > > > tarball to be available. > > > Since poudriere uses the tarball when you setup a jail it means that > > > the only solution you have is to recreate your jail by building it, and > > > since building world nowdays is very expensive that delay your work too > > > much. > > > Would it be possible to generate the tarballs every day instead of > > > every week ? At least for tier-1 arches. > > > > > > > Let's revisit this sometime next week after 11.4 is out. > > > > Glen > > > > Sure, works for me. > > Thanks, > Ping ? -- Emmanuel Vadot From owner-freebsd-current@freebsd.org Fri Jul 24 22:06:10 2020 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 873C637552A for ; Fri, 24 Jul 2020 22:06:10 +0000 (UTC) (envelope-from gjb@freebsd.org) Received: from mailman.nyi.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id 4BD3Dy37V3z4LGk for ; Fri, 24 Jul 2020 22:06:10 +0000 (UTC) (envelope-from gjb@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id 69B59375529; Fri, 24 Jul 2020 22:06:10 +0000 (UTC) Delivered-To: current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 6972B375528 for ; Fri, 24 Jul 2020 22:06:10 +0000 (UTC) (envelope-from gjb@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [96.47.72.132]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "freefall.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4BD3Dy2Bjbz4LVZ; Fri, 24 Jul 2020 22:06:10 +0000 (UTC) (envelope-from gjb@freebsd.org) Received: from FreeBSD.org (freefall.freebsd.org [IPv6:2610:1c1:1:6074::16:84]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by freefall.freebsd.org (Postfix) with ESMTPS id E24AC17D25; Fri, 24 Jul 2020 22:06:09 +0000 (UTC) (envelope-from gjb@freebsd.org) Date: Fri, 24 Jul 2020 22:06:07 +0000 From: Glen Barber To: Emmanuel Vadot Cc: current@freebsd.org, re@freebsd.org Subject: Re: nightly snapshot for CURRENT ? Message-ID: <20200724220607.GG34565@FreeBSD.org> References: <20200609214756.13e9cbbc2de12bbb78839875@bidouilliste.com> <20200609195630.GN97889@FreeBSD.org> <20200609220407.d745b7a073f58254ff2db714@bidouilliste.com> <20200724223135.7f3522f97968ce82b9b245ad@bidouilliste.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="wLAMOaPNJ0fu1fTG" Content-Disposition: inline In-Reply-To: <20200724223135.7f3522f97968ce82b9b245ad@bidouilliste.com> X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Jul 2020 22:06:10 -0000 --wLAMOaPNJ0fu1fTG Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jul 24, 2020 at 10:31:35PM +0200, Emmanuel Vadot wrote: > On Tue, 9 Jun 2020 22:04:07 +0200 > Emmanuel Vadot wrote: >=20 > > On Tue, 9 Jun 2020 19:56:30 +0000 > > Glen Barber wrote: > >=20 > > > On Tue, Jun 09, 2020 at 09:47:56PM +0200, Emmanuel Vadot wrote: > > > >=20 > > > > Hello all, > > > >=20 > > > > I've just hit again something that I've hit (and probably others t= oo) > > > > often. > > > > If a change in base break some ports and it's snapshoted in the txz > > > > available at download.freebsd.org, you need to wait a week for the = next > > > > tarball to be available. > > > > Since poudriere uses the tarball when you setup a jail it means th= at > > > > the only solution you have is to recreate your jail by building it,= and > > > > since building world nowdays is very expensive that delay your work= too > > > > much. > > > > Would it be possible to generate the tarballs every day instead of > > > > every week ? At least for tier-1 arches. > > > >=20 > > >=20 > > > Let's revisit this sometime next week after 11.4 is out. > > >=20 > > > Glen > > >=20 > >=20 > > Sure, works for me. > >=20 > > Thanks, > >=20 >=20 > Ping ? >=20 I thought the artifacts from the jenkins builder for CI were sufficient. Glen --wLAMOaPNJ0fu1fTG Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEjRJAPC5sqwhs9k2jAxRYpUeP4pMFAl8bW0oACgkQAxRYpUeP 4pOi+Q/6AploQZcuInDV0Lk2DpErbUmLpWNaP44QvuTGu5w+iO6zxnLRJ1jsmMbs +81clVqGwcqy0MsSRLhKn17ziGsAlsXAzoNaoo6TnGIl48843LIwsGGQUwhDG/M4 bsRFh8ilRPDiJaqxax9yHyTLiauFjifQtXWHxg38NfA26K2tAI6N/TVjguQwqwYD cuIurXl7fhgvMAusVFxzdfaoh27XMkzmkMtbnKccy/P/hXZPPamD38pz7Hah744D oR2GUKEKP+hYsK0sjmNH8M2wnqE5xtnHUjmgRmpIBlxLMWPPW3c42KagxWOnk80e 8obIgbktaZOBR7oenirQ0lvTN9fzTQwcebwfpXqnPINP+geMnchq+FQJOk/1qoPw o/+2X51iO7+Qx6Arqq3PbUQXYPS4KJeq18gC6bdaTwNxK5gcPY16klMocTHO82q7 +w92+fy36iDBRLJ/w8O4qJerFOimxHVg1yBMkRSrPIuxAsq6DPLaAXKux9ymUYHS olNrS+praDryfXFNdLeDG6mOooVsQKthd064iVbLpEaCTilJZYd5DUcTNcO3Oqbc z8kaI8iV1eskGRwSfpKnxDH3Ptr2dZLfRQTuHWD0/XN1nOdpEuV8LlHAm+JMmY8e NY5AC81DVaXi6pklH04kOOg3KG4CXPqq6ntkw6qy5rEuKgZDyyE= =9X2o -----END PGP SIGNATURE----- --wLAMOaPNJ0fu1fTG-- From owner-freebsd-current@freebsd.org Fri Jul 24 22:14:57 2020 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 74DF6375B91 for ; Fri, 24 Jul 2020 22:14:57 +0000 (UTC) (envelope-from manu@bidouilliste.com) Received: from mailman.nyi.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id 4BD3R50fzhz4Lt9 for ; Fri, 24 Jul 2020 22:14:57 +0000 (UTC) (envelope-from manu@bidouilliste.com) Received: by mailman.nyi.freebsd.org (Postfix) id 14C4937589C; Fri, 24 Jul 2020 22:14:57 +0000 (UTC) Delivered-To: current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 148503758E1 for ; Fri, 24 Jul 2020 22:14:57 +0000 (UTC) (envelope-from manu@bidouilliste.com) Received: from mx.blih.net (mx.blih.net [212.83.155.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "mx.blih.net", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4BD3R34xpgz4M4X; Fri, 24 Jul 2020 22:14:55 +0000 (UTC) (envelope-from manu@bidouilliste.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bidouilliste.com; s=mx; t=1595628893; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Rj5lVYzMMepEDaLptcna404al1nJWsxteMtSqVKWG4I=; b=YOpc7aRsc8Cll54co1sQCZdMp/PA/TrpSDd219bbEj1GMvjWHt4PW0jyCK67JNyk5vCvqR f8rgin5CdYza839loASbI1Lqr6wPLklr7VKpYsDCmdNhWhKMW3t/9JTEnCK1phfo5Bd5/8 8XU47g3py9h3Jl1QVP9fbU2Jqb5q1mQ= Received: from skull.home.blih.net (lfbn-idf2-1-1138-237.w90-92.abo.wanadoo.fr [90.92.20.237]) by mx.blih.net (OpenSMTPD) with ESMTPSA id 3c027fd9 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Fri, 24 Jul 2020 22:14:53 +0000 (UTC) Date: Sat, 25 Jul 2020 00:14:52 +0200 From: Emmanuel Vadot To: Glen Barber Cc: current@freebsd.org, re@freebsd.org Subject: Re: nightly snapshot for CURRENT ? Message-Id: <20200725001452.152479d2afe405bfc4302863@bidouilliste.com> In-Reply-To: <20200724220607.GG34565@FreeBSD.org> References: <20200609214756.13e9cbbc2de12bbb78839875@bidouilliste.com> <20200609195630.GN97889@FreeBSD.org> <20200609220407.d745b7a073f58254ff2db714@bidouilliste.com> <20200724223135.7f3522f97968ce82b9b245ad@bidouilliste.com> <20200724220607.GG34565@FreeBSD.org> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.32; amd64-portbld-freebsd13.0) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 4BD3R34xpgz4M4X X-Spamd-Bar: - Authentication-Results: mx1.freebsd.org; dkim=pass header.d=bidouilliste.com header.s=mx header.b=YOpc7aRs; dmarc=pass (policy=none) header.from=bidouilliste.com; spf=pass (mx1.freebsd.org: domain of manu@bidouilliste.com designates 212.83.155.74 as permitted sender) smtp.mailfrom=manu@bidouilliste.com X-Spamd-Result: default: False [-1.43 / 15.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[]; R_DKIM_ALLOW(-0.20)[bidouilliste.com:s=mx]; MID_RHS_MATCH_FROM(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; MV_CASE(0.50)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; R_SPF_ALLOW(-0.20)[+mx]; NEURAL_HAM_LONG(-1.03)[-1.026]; TO_DN_SOME(0.00)[]; NEURAL_SPAM_SHORT(0.05)[0.052]; NEURAL_HAM_MEDIUM(-0.96)[-0.956]; DKIM_TRACE(0.00)[bidouilliste.com:+]; DMARC_POLICY_ALLOW(-0.50)[bidouilliste.com,none]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; SUBJECT_ENDS_QUESTION(1.00)[]; ASN(0.00)[asn:12876, ipnet:212.83.128.0/19, country:FR]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Jul 2020 22:14:57 -0000 On Fri, 24 Jul 2020 22:06:07 +0000 Glen Barber wrote: > On Fri, Jul 24, 2020 at 10:31:35PM +0200, Emmanuel Vadot wrote: > > On Tue, 9 Jun 2020 22:04:07 +0200 > > Emmanuel Vadot wrote: > > > > > On Tue, 9 Jun 2020 19:56:30 +0000 > > > Glen Barber wrote: > > > > > > > On Tue, Jun 09, 2020 at 09:47:56PM +0200, Emmanuel Vadot wrote: > > > > > > > > > > Hello all, > > > > > > > > > > I've just hit again something that I've hit (and probably others too) > > > > > often. > > > > > If a change in base break some ports and it's snapshoted in the txz > > > > > available at download.freebsd.org, you need to wait a week for the next > > > > > tarball to be available. > > > > > Since poudriere uses the tarball when you setup a jail it means that > > > > > the only solution you have is to recreate your jail by building it, and > > > > > since building world nowdays is very expensive that delay your work too > > > > > much. > > > > > Would it be possible to generate the tarballs every day instead of > > > > > every week ? At least for tier-1 arches. > > > > > > > > > > > > > Let's revisit this sometime next week after 11.4 is out. > > > > > > > > Glen > > > > > > > > > > Sure, works for me. > > > > > > Thanks, > > > > > > > Ping ? > > > > I thought the artifacts from the jenkins builder for CI were sufficient. > > Glen > Yes and no, I can add something to poudriere for getting the tarballs from the CI artifacts but that won't be by default. -- Emmanuel Vadot From owner-freebsd-current@freebsd.org Fri Jul 24 22:28:42 2020 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 72491375DAF for ; Fri, 24 Jul 2020 22:28:42 +0000 (UTC) (envelope-from gjb@freebsd.org) Received: from mailman.nyi.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id 4BD3ky2VXsz4MCP for ; Fri, 24 Jul 2020 22:28:42 +0000 (UTC) (envelope-from gjb@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id 55C3F375DAE; Fri, 24 Jul 2020 22:28:42 +0000 (UTC) Delivered-To: current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 558AE375F1D for ; Fri, 24 Jul 2020 22:28:42 +0000 (UTC) (envelope-from gjb@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [96.47.72.132]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "freefall.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4BD3ky1cdNz4Mj4; Fri, 24 Jul 2020 22:28:42 +0000 (UTC) (envelope-from gjb@freebsd.org) Received: from FreeBSD.org (freefall.freebsd.org [IPv6:2610:1c1:1:6074::16:84]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by freefall.freebsd.org (Postfix) with ESMTPS id C020017FDB; Fri, 24 Jul 2020 22:28:41 +0000 (UTC) (envelope-from gjb@freebsd.org) Date: Fri, 24 Jul 2020 22:28:39 +0000 From: Glen Barber To: Emmanuel Vadot Cc: current@freebsd.org, re@freebsd.org Subject: Re: nightly snapshot for CURRENT ? Message-ID: <20200724222839.GG61041@FreeBSD.org> References: <20200609214756.13e9cbbc2de12bbb78839875@bidouilliste.com> <20200609195630.GN97889@FreeBSD.org> <20200609220407.d745b7a073f58254ff2db714@bidouilliste.com> <20200724223135.7f3522f97968ce82b9b245ad@bidouilliste.com> <20200724220607.GG34565@FreeBSD.org> <20200725001452.152479d2afe405bfc4302863@bidouilliste.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="9teSV9pdwBI9hpI9" Content-Disposition: inline In-Reply-To: <20200725001452.152479d2afe405bfc4302863@bidouilliste.com> X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Jul 2020 22:28:42 -0000 --9teSV9pdwBI9hpI9 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Jul 25, 2020 at 12:14:52AM +0200, Emmanuel Vadot wrote: > On Fri, 24 Jul 2020 22:06:07 +0000 > Glen Barber wrote: >=20 > > On Fri, Jul 24, 2020 at 10:31:35PM +0200, Emmanuel Vadot wrote: > > > On Tue, 9 Jun 2020 22:04:07 +0200 > > > Emmanuel Vadot wrote: > > >=20 > > > > On Tue, 9 Jun 2020 19:56:30 +0000 > > > > Glen Barber wrote: > > > >=20 > > > > > On Tue, Jun 09, 2020 at 09:47:56PM +0200, Emmanuel Vadot wrote: > > > > > >=20 > > > > > > Hello all, > > > > > >=20 > > > > > > I've just hit again something that I've hit (and probably othe= rs too) > > > > > > often. > > > > > > If a change in base break some ports and it's snapshoted in th= e txz > > > > > > available at download.freebsd.org, you need to wait a week for = the next > > > > > > tarball to be available. > > > > > > Since poudriere uses the tarball when you setup a jail it mean= s that > > > > > > the only solution you have is to recreate your jail by building= it, and > > > > > > since building world nowdays is very expensive that delay your = work too > > > > > > much. > > > > > > Would it be possible to generate the tarballs every day instea= d of > > > > > > every week ? At least for tier-1 arches. > > > > > >=20 > > > > >=20 > > > > > Let's revisit this sometime next week after 11.4 is out. > > > > >=20 > > > > > Glen > > > > >=20 > > > >=20 > > > > Sure, works for me. > > > >=20 > > > > Thanks, > > > >=20 > > >=20 > > > Ping ? > > >=20 > >=20 > > I thought the artifacts from the jenkins builder for CI were sufficient. > >=20 > > Glen > >=20 >=20 > Yes and no, >=20 > I can add something to poudriere for getting the tarballs from the CI > artifacts but that won't be by default. >=20 To be honest, that would be the preferred route, since updating the various *.txz distribution sets would break things like bootonly.iso, mini-memstick.img, and so on. In other words, we already have a system in place that generates these archive files, so I personally see no need to disrupt the "official" snapshot build process to appease a subset of the user base while unnecessarily adding a pain point for the rest. Glen --9teSV9pdwBI9hpI9 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEjRJAPC5sqwhs9k2jAxRYpUeP4pMFAl8bYJcACgkQAxRYpUeP 4pMehQ//VPioG9VOfzI5SLJK03acz7eIyjaCBafjFhMpzii/qFiMtw+GTDUwP37j 04jrSkmNFTLrqIXAqeq9vdfiF0/JkgEkMHrG+MeCS0Eb8HHHE7eKmdntZk3qN/5D AOInODmIb5SPXuHK9gRHZOjbBdTEiecXIIxD9LZJPMVB6DCCzQTR6+iT3nxNJ6Pp el4uFMRjURQfBCk3o8wUwg2btNgxxsiXM0Wv0NhEvWD1QCAABCint0o3diRreIJS zWGcjE4RClNQDPy9idZFG/pAT6PcTk2R09bOXXMUYJk4l90QBEGC9hgBR3QrVQ9H HWnTa+J76XDvEkJqVPsZsLRdoUjHtnIodVPXR9ArFrF5Nqa79P/M70CF6od2NRrg HFCNrFZyauxBHXqs71SZ1CJnTPi2mMawk/p7uZcr/8fzJkHwElapfaySjcIkjhxh h9rnQ2FfaopMY2JGGsdRWqCZK0UInL/lVvedmm0DIxFNtMZWtYP1AVUH3xRKUmBT +aluAaE5Ck6NmEyIhlAeylpRbAWDUyKjw4Prl6h+NoPYClw86brRWyEg2LtHLDdg NbF8jvi/b+QlcFTpUI4SnBlx8OQBuP6wRLgATZljdO3FOrL/bhxCa6a2Mn9Qlsu9 dH/iA7klKwNBOUKvHlojBk+RGzzxjsAv5Qh2lX+ILx/KEwDi99A= =odJe -----END PGP SIGNATURE----- --9teSV9pdwBI9hpI9-- From owner-freebsd-current@freebsd.org Sat Jul 25 10:36:25 2020 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 3C2C63A6A02 for ; Sat, 25 Jul 2020 10:36:25 +0000 (UTC) (envelope-from manu@bidouilliste.com) Received: from mailman.nyi.freebsd.org (mailman.nyi.freebsd.org [IPv6:2610:1c1:1:606c::50:13]) by mx1.freebsd.org (Postfix) with ESMTP id 4BDMtc6kC4z43d0 for ; Sat, 25 Jul 2020 10:36:24 +0000 (UTC) (envelope-from manu@bidouilliste.com) Received: by mailman.nyi.freebsd.org (Postfix) id E6AED3A682E; Sat, 25 Jul 2020 10:36:24 +0000 (UTC) Delivered-To: current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id E67653A6935 for ; Sat, 25 Jul 2020 10:36:24 +0000 (UTC) (envelope-from manu@bidouilliste.com) Received: from mx.blih.net (mx.blih.net [212.83.155.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "mx.blih.net", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4BDMtb5lZmz43Xc; Sat, 25 Jul 2020 10:36:23 +0000 (UTC) (envelope-from manu@bidouilliste.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bidouilliste.com; s=mx; t=1595672982; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=NT2VXqSThcOcnkFX8+adnXhXOPK0AXbay4dw9mTR1sg=; b=HLTIc8GIyT8MKeEmaGEQekp2Pj9MHPaMC3EyVaFkKNppIbtBWsSia66cOOKir+QA4vPB3z ntjJDYKSQ39kIahYOmBSjmpklTwhP4zjF72gPBLLb99Rj5LuBvmhnSp4NMMEwTpRzGcHYZ 7w00swLTFmNGVQrlWTY6AyxzFTsKUQw= X-Spam-Score: 6.481066 / 15 X-Spam-Status: Yes, score=6.481 required=15.000 tests=[ARC_NA=0.000, ASN=0.000, BAYES_SPAM=5.081, DKIM_SIGNED=0.000 FROM_EQ_ENVFROM=0.000, FROM_HAS_DN=0.000, MID_RHS_MATCH_FROM=0.000 MIME_GOOD=-0.100, MIME_TRACE=0.000, MV_CASE=0.500, NEURAL_HAM=-0.000 RCPT_COUNT_THREE=0.000, RCVD_COUNT_ONE=0.000, RCVD_TLS_ALL=0.000 RCVD_VIA_SMTP_AUTH=0.000, SUBJECT_ENDS_QUESTION=1.000 TO_DN_SOME=0.000, TO_MATCH_ENVRCPT_ALL=0.000] Received: from skull.home.blih.net (lfbn-idf2-1-1138-237.w90-92.abo.wanadoo.fr [90.92.20.237]) by mx.blih.net (OpenSMTPD) with ESMTPSA id e1b38318 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Sat, 25 Jul 2020 10:29:42 +0000 (UTC) Date: Sat, 25 Jul 2020 12:29:42 +0200 From: Emmanuel Vadot To: Glen Barber Cc: current@freebsd.org, re@freebsd.org Subject: Re: nightly snapshot for CURRENT ? Message-Id: <20200725122942.dcdfc0211bf6ab0706c86587@bidouilliste.com> In-Reply-To: <20200724222839.GG61041@FreeBSD.org> References: <20200609214756.13e9cbbc2de12bbb78839875@bidouilliste.com> <20200609195630.GN97889@FreeBSD.org> <20200609220407.d745b7a073f58254ff2db714@bidouilliste.com> <20200724223135.7f3522f97968ce82b9b245ad@bidouilliste.com> <20200724220607.GG34565@FreeBSD.org> <20200725001452.152479d2afe405bfc4302863@bidouilliste.com> <20200724222839.GG61041@FreeBSD.org> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.32; amd64-portbld-freebsd13.0) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 4BDMtb5lZmz43Xc X-Spamd-Bar: +++ Authentication-Results: mx1.freebsd.org; dkim=pass header.d=bidouilliste.com header.s=mx header.b=HLTIc8GI; dmarc=pass (policy=none) header.from=bidouilliste.com; spf=pass (mx1.freebsd.org: domain of manu@bidouilliste.com designates 212.83.155.74 as permitted sender) smtp.mailfrom=manu@bidouilliste.com X-Spamd-Result: default: False [3.66 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; R_DKIM_ALLOW(-0.20)[bidouilliste.com:s=mx]; SPAM_FLAG(5.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; R_SPF_ALLOW(-0.20)[+mx:c]; MV_CASE(0.50)[]; MIME_GOOD(-0.10)[text/plain]; TO_MATCH_ENVRCPT_ALL(0.00)[]; GREYLIST(0.00)[pass,body]; TO_DN_SOME(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; NEURAL_HAM_LONG(-1.03)[-1.027]; NEURAL_HAM_MEDIUM(-0.96)[-0.957]; NEURAL_SPAM_SHORT(0.14)[0.145]; DKIM_TRACE(0.00)[bidouilliste.com:+]; DMARC_POLICY_ALLOW(-0.50)[bidouilliste.com,none]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; SUBJECT_ENDS_QUESTION(1.00)[]; ASN(0.00)[asn:12876, ipnet:212.83.128.0/19, country:FR]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[] X-Spam: Yes X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 25 Jul 2020 10:36:25 -0000 On Fri, 24 Jul 2020 22:28:39 +0000 Glen Barber wrote: > On Sat, Jul 25, 2020 at 12:14:52AM +0200, Emmanuel Vadot wrote: > > On Fri, 24 Jul 2020 22:06:07 +0000 > > Glen Barber wrote: > > > > > On Fri, Jul 24, 2020 at 10:31:35PM +0200, Emmanuel Vadot wrote: > > > > On Tue, 9 Jun 2020 22:04:07 +0200 > > > > Emmanuel Vadot wrote: > > > > > > > > > On Tue, 9 Jun 2020 19:56:30 +0000 > > > > > Glen Barber wrote: > > > > > > > > > > > On Tue, Jun 09, 2020 at 09:47:56PM +0200, Emmanuel Vadot wrote: > > > > > > > > > > > > > > Hello all, > > > > > > > > > > > > > > I've just hit again something that I've hit (and probably others too) > > > > > > > often. > > > > > > > If a change in base break some ports and it's snapshoted in the txz > > > > > > > available at download.freebsd.org, you need to wait a week for the next > > > > > > > tarball to be available. > > > > > > > Since poudriere uses the tarball when you setup a jail it means that > > > > > > > the only solution you have is to recreate your jail by building it, and > > > > > > > since building world nowdays is very expensive that delay your work too > > > > > > > much. > > > > > > > Would it be possible to generate the tarballs every day instead of > > > > > > > every week ? At least for tier-1 arches. > > > > > > > > > > > > > > > > > > > Let's revisit this sometime next week after 11.4 is out. > > > > > > > > > > > > Glen > > > > > > > > > > > > > > > > Sure, works for me. > > > > > > > > > > Thanks, > > > > > > > > > > > > > Ping ? > > > > > > > > > > I thought the artifacts from the jenkins builder for CI were sufficient. > > > > > > Glen > > > > > > > Yes and no, > > > > I can add something to poudriere for getting the tarballs from the CI > > artifacts but that won't be by default. > > > > To be honest, that would be the preferred route, since updating the > various *.txz distribution sets would break things like bootonly.iso, > mini-memstick.img, and so on. Why would it break things ? > In other words, we already have a system in place that generates these > archive files, so I personally see no need to disrupt the "official" > snapshot build process to appease a subset of the user base while > unnecessarily adding a pain point for the rest. > > Glen > If only the sets are generated each day I don't see how it can cause a pain to anyone. -- Emmanuel Vadot From owner-freebsd-current@freebsd.org Sat Jul 25 19:21:39 2020 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id EAE7536D1B3; Sat, 25 Jul 2020 19:21:39 +0000 (UTC) (envelope-from jmg@gold.funkthat.com) Received: from gold.funkthat.com (gate2.funkthat.com [208.87.223.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "gate2.funkthat.com", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4BDbXf7492z4YTH; Sat, 25 Jul 2020 19:21:38 +0000 (UTC) (envelope-from jmg@gold.funkthat.com) Received: from gold.funkthat.com (localhost [127.0.0.1]) by gold.funkthat.com (8.15.2/8.15.2) with ESMTPS id 06PJLUYR082228 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Sat, 25 Jul 2020 12:21:30 -0700 (PDT) (envelope-from jmg@gold.funkthat.com) Received: (from jmg@localhost) by gold.funkthat.com (8.15.2/8.15.2/Submit) id 06PJLUsu082227; Sat, 25 Jul 2020 12:21:30 -0700 (PDT) (envelope-from jmg) Date: Sat, 25 Jul 2020 12:21:30 -0700 From: John-Mark Gurney To: Kristof Provost , "Bjoern A. Zeeb" , freebsd-net@freebsd.org, freebsd-current@freebsd.org Subject: Re: somewhat reproducable vimage panic Message-ID: <20200725192129.GN4213@funkthat.com> Mail-Followup-To: Kristof Provost , "Bjoern A. Zeeb" , freebsd-net@freebsd.org, freebsd-current@freebsd.org References: <38F5A3A6-B578-4BA4-8F69-C248163CB6E0@libassi.se> <20200722060514.GF4213@funkthat.com> <20200722193443.GG4213@funkthat.com> <6C149617-55BB-4A87-B993-195E5E133790@lists.zabbadoz.net> <20200722221509.GI4213@funkthat.com> <2FFC49F9-83DE-4FA1-A47F-1D8A7AF4B241@FreeBSD.org> <6847FB6B-0B1A-43C7-B567-15BF21AB5D56@FreeBSD.org> <8B72C0B9-9CF0-4557-81D7-77190775805C@lists.zabbadoz.net> <20200723234925.GL4213@funkthat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200723234925.GL4213@funkthat.com> X-Operating-System: FreeBSD 11.3-STABLE amd64 X-PGP-Fingerprint: D87A 235F FB71 1F3F 55B7 ED9B D5FF 5A51 C0AC 3D65 X-Files: The truth is out there X-URL: https://www.funkthat.com/ X-Resume: https://www.funkthat.com/~jmg/resume.html X-TipJar: bitcoin:13Qmb6AeTgQecazTWph4XasEsP7nGRbAPE X-to-the-FBI-CIA-and-NSA: HI! HOW YA DOIN? can i haz chizburger? User-Agent: Mutt/1.6.1 (2016-04-27) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.4.3 (gold.funkthat.com [127.0.0.1]); Sat, 25 Jul 2020 12:21:30 -0700 (PDT) X-Rspamd-Queue-Id: 4BDbXf7492z4YTH X-Spamd-Bar: + Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=none (mx1.freebsd.org: domain of jmg@gold.funkthat.com has no SPF policy when checking 208.87.223.18) smtp.mailfrom=jmg@gold.funkthat.com X-Spamd-Result: default: False [1.68 / 15.00]; RCVD_TLS_ALL(0.00)[]; ARC_NA(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; TO_DN_SOME(0.00)[]; NEURAL_HAM_LONG(-0.19)[-0.193]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[funkthat.com]; AUTH_NA(1.00)[]; NEURAL_SPAM_MEDIUM(0.65)[0.646]; NEURAL_SPAM_SHORT(0.03)[0.026]; TO_MATCH_ENVRCPT_SOME(0.00)[]; R_SPF_NA(0.00)[no SPF record]; FORGED_SENDER(0.30)[jmg@funkthat.com,jmg@gold.funkthat.com]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_COUNT_TWO(0.00)[2]; MID_RHS_MATCH_FROM(0.00)[]; FROM_NEQ_ENVFROM(0.00)[jmg@funkthat.com,jmg@gold.funkthat.com]; ASN(0.00)[asn:32354, ipnet:208.87.216.0/21, country:US] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 25 Jul 2020 19:21:40 -0000 John-Mark Gurney wrote this message on Thu, Jul 23, 2020 at 16:49 -0700: > Kristof Provost wrote this message on Thu, Jul 23, 2020 at 11:02 +0200: > > On 23 Jul 2020, at 11:00, Bjoern A. Zeeb wrote: > > > On 23 Jul 2020, at 8:09, Kristof Provost wrote: > > > > > >> On 23 Jul 2020, at 9:19, Kristof Provost wrote: > > >>> On 23 Jul 2020, at 0:15, John-Mark Gurney wrote: > > >>>> So, it's pretty easy to trigger, just attach a couple USB ethernet > > >>>> adapters, in my case, they were ure, but likely any two spare > > >>>> ethernet > > >>>> interfaces will work, and wire them back to back.. > > >>>> > > >>> I???ve been able to trigger it using epair as well: > > >>> > > >>> `sudo sh testinterfaces.txt epair0a epair0b` > > >>> > > >>> I did have to comment out the waitcarrier() check. > > >>> > > >> I???ve done a little bit of digging, and I think I???m starting to > > >> see how this breaks. > > >> > > >> This always affects the jailed vlan interfaces. They???re getting > > >> deleted, but the ifp doesn???t go away just yet because it???s still > > >> in use by the multicast code. > > >> The multicast code does its cleanup in task queues, > > > > > > Wow, did I miss that back then? Did I review a change and not notice? > > > Sorry if that was the case. > > > > > > Vnet teardown is blocking and forceful. > > > Doing deferred cleanup work isn???t a good idea at all. > > > I think that is the real problem here. > > > > > > I???d rather have us fix this than putting more bandaids into the > > > code. > > > > > Yeah, agreed. I think hselasky has a better fix: > > https://reviews.freebsd.org/D24914 > > > > I just saw his e-mail in a different thread. > > I'm testing out this patch now, and let people know how it goes.. It'll > be nice to not have to worry about these panics.. So far so good... I am getting these on occasion: in6_purgeaddr: err=65, destination address delete failed But that's more that the patch prevented a panic. The other issue that I'm now seeing is that because we don't forcefully clear out the multicast task, it can take a good 20+ seconds from the time a jail is destroyed to the interface appearing again in vnet0. Pretty sure this is related to the dmesg from above... -- John-Mark Gurney Voice: +1 415 225 5579 "All that I will do, has been done, All that I have, has not." From owner-freebsd-current@freebsd.org Sat Jul 25 23:13:22 2020 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 9980B3737A5; Sat, 25 Jul 2020 23:13:22 +0000 (UTC) (envelope-from jmg@gold.funkthat.com) Received: from gold.funkthat.com (gate2.funkthat.com [208.87.223.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "gate2.funkthat.com", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4BDhh05RRrz3XVv; Sat, 25 Jul 2020 23:13:20 +0000 (UTC) (envelope-from jmg@gold.funkthat.com) Received: from gold.funkthat.com (localhost [127.0.0.1]) by gold.funkthat.com (8.15.2/8.15.2) with ESMTPS id 06PNDIo1092170 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Sat, 25 Jul 2020 16:13:18 -0700 (PDT) (envelope-from jmg@gold.funkthat.com) Received: (from jmg@localhost) by gold.funkthat.com (8.15.2/8.15.2/Submit) id 06PNDIm5092169; Sat, 25 Jul 2020 16:13:18 -0700 (PDT) (envelope-from jmg) Date: Sat, 25 Jul 2020 16:13:18 -0700 From: John-Mark Gurney To: freebsd-net@FreeBSD.org, freebsd-current@FreeBSD.org Subject: CFT: major update to if_ure Message-ID: <20200725231318.GO4213@funkthat.com> Mail-Followup-To: freebsd-net@FreeBSD.org, freebsd-current@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Operating-System: FreeBSD 11.3-STABLE amd64 X-PGP-Fingerprint: D87A 235F FB71 1F3F 55B7 ED9B D5FF 5A51 C0AC 3D65 X-Files: The truth is out there X-URL: https://www.funkthat.com/ X-Resume: https://www.funkthat.com/~jmg/resume.html X-TipJar: bitcoin:13Qmb6AeTgQecazTWph4XasEsP7nGRbAPE X-to-the-FBI-CIA-and-NSA: HI! HOW YA DOIN? can i haz chizburger? User-Agent: Mutt/1.6.1 (2016-04-27) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.4.3 (gold.funkthat.com [127.0.0.1]); Sat, 25 Jul 2020 16:13:18 -0700 (PDT) X-Rspamd-Queue-Id: 4BDhh05RRrz3XVv X-Spamd-Bar: ++ Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=none (mx1.freebsd.org: domain of jmg@gold.funkthat.com has no SPF policy when checking 208.87.223.18) smtp.mailfrom=jmg@gold.funkthat.com X-Spamd-Result: default: False [2.74 / 15.00]; RCVD_TLS_ALL(0.00)[]; ARC_NA(0.00)[]; FROM_HAS_DN(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_SPAM_SHORT(0.16)[0.159]; MIME_GOOD(-0.10)[text/plain]; TO_DN_NONE(0.00)[]; DMARC_NA(0.00)[funkthat.com]; AUTH_NA(1.00)[]; NEURAL_SPAM_MEDIUM(0.82)[0.819]; RCPT_COUNT_TWO(0.00)[2]; NEURAL_SPAM_LONG(0.56)[0.560]; R_SPF_NA(0.00)[no SPF record]; FORGED_SENDER(0.30)[jmg@funkthat.com,jmg@gold.funkthat.com]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:32354, ipnet:208.87.216.0/21, country:US]; MID_RHS_MATCH_FROM(0.00)[]; FROM_NEQ_ENVFROM(0.00)[jmg@funkthat.com,jmg@gold.funkthat.com]; RCVD_COUNT_TWO(0.00)[2] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 25 Jul 2020 23:13:22 -0000 Hello, I'd like people who have ure (RealTek) based USB devices to test review D25809[0]. This update adds support for: - HW VLAN tagging - HW checksum offload for IPv4 and IPv6 - tx and rx aggreegation (for full gige speeds) - multiple transactions In my testing, I am able to get 900-950Mbps depending upon TCP or UDP, which is a significant improvement over the previous 91Mbps (~8kint/sec*1500bytes/packet*1packet/int). Thanks. [0] https://reviews.freebsd.org/D25809 -- John-Mark Gurney Voice: +1 415 225 5579 "All that I will do, has been done, All that I have, has not."