From owner-freebsd-dtrace@freebsd.org Mon Nov 30 13:50:58 2020 Return-Path: Delivered-To: freebsd-dtrace@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id A035A47CF44; Mon, 30 Nov 2020 13:50:58 +0000 (UTC) (envelope-from avg@FreeBSD.org) Received: from relay1-d.mail.gandi.net (relay1-d.mail.gandi.net [217.70.183.193]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4Cl6816VXtz3QM6; Mon, 30 Nov 2020 13:50:57 +0000 (UTC) (envelope-from avg@FreeBSD.org) X-Originating-IP: 93.72.151.96 Received: from [192.168.0.88] (east.meadow.volia.net [93.72.151.96]) (Authenticated sender: andriy.gapon@uabsd.com) by relay1-d.mail.gandi.net (Postfix) with ESMTPSA id E8500240008; Mon, 30 Nov 2020 13:50:54 +0000 (UTC) Subject: Re: dtrace: give %'d a chance? To: Mark Johnston Cc: FreeBSD Current , freebsd-dtrace@freebsd.org References: From: Andriy Gapon Openpgp: preference=signencrypt Autocrypt: addr=avg@FreeBSD.org; keydata= mDMEX1iFDhYJKwYBBAHaRw8BAQdAiu8JG/oLFkVkOAJqJc7Dx5KI/Q6C3SBI20EQm+DXnAu0 HkFuZHJpeSBHYXBvbiA8YXZnQEZyZWVCU0Qub3JnPoiWBBMWCAA+FiEEyCHHZM09l0OE3Ir/ 1A1+Gq8+L1EFAl9YhQ4CGwMFCQeEzgAFCwkIBwIGFQoJCAsCBBYCAwECHgECF4AACgkQ1A1+ Gq8+L1Fc0wD/ZjmhHfbCJywZU3aOxXIPjcz73FYEGMvqMCCLAWyLbSABALFL+1ZNrjV3BGjq 889cOYFuboA/Yn3eWezS+tfqYBsGuDgEX1iFDhIKKwYBBAGXVQEFAQEHQL6B20Xi600TrkpG P9fWjl7JtHNxqrHKhX6Kg7kgb4ILAwEIB4h+BBgWCAAmFiEEyCHHZM09l0OE3Ir/1A1+Gq8+ L1EFAl9YhQ4CGwwFCQeEzgAACgkQ1A1+Gq8+L1F3cgEAktp4h+IJUJxL1vn6zMOt//znni/J TanKfQuA8wGXcGkBAKpZJhqMkg+pKk7MGvJhgJ6nCpTZ+rMK6vZVZLUWc3QF Message-ID: <5b87b1af-2c19-7f41-60f0-1e578c72e17d@FreeBSD.org> Date: Mon, 30 Nov 2020 15:50:53 +0200 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:60.0) Gecko/20100101 Firefox/60.0 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 4Cl6816VXtz3QM6 X-Spamd-Bar: / Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [0.00 / 15.00]; local_wl_from(0.00)[FreeBSD.org]; ASN(0.00)[asn:29169, ipnet:217.70.176.0/20, country:FR] X-BeenThere: freebsd-dtrace@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: "A discussion list for developers working on DTrace in FreeBSD." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Nov 2020 13:50:58 -0000 On 19/11/2020 16:57, Mark Johnston wrote: > On Thu, Nov 19, 2020 at 01:28:56PM +0200, Andriy Gapon wrote: >> >> what do people think about adding >> setlocale(LC_NUMERIC, ""); >> to dtrace's main function? > > That seems reasonable to me. > >> My primary interest is to (pretty-)print some numbers with a thousands separator. >> >> Not sure if any other LC_ types are worth bothering. > > Maybe LC_TIME? libdtrace a couple of date formatters, %T and %Y. A > locale-aware formatter might be worth having. FWIW, I've just discovered that despite what http://dtrace.org/guide/chp-fmt.html says about %Y its output is not dependent on locale settings. A quick look at the code confirms that -- pfprint_time uses ctime_r. But %T (undocumented at the above link) indeed depends on LC_TIME as pfprint_time822 uses strftime("%a, %d %b %G %T %Z"). Sample output in C locale: 10000000 Mon, 30 Nov 2020 13:47:24 UTC 2020 Nov 30 13:47:24 The same formats (%'d, %T, %Y) in uk_UA locale: 10 000 000 Пн, 30 лист. 2020 13:43:11 UTC 2020 Nov 30 13:43:11 -- Andriy Gapon