From owner-freebsd-net@freebsd.org Sun Jan 26 02:08:53 2020 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 043EC22B7EA for ; Sun, 26 Jan 2020 02:08:53 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (mailman.nyi.freebsd.org [IPv6:2610:1c1:1:606c::50:13]) by mx1.freebsd.org (Postfix) with ESMTP id 484xBX6Nvgz4Q2F for ; Sun, 26 Jan 2020 02:08:52 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id DB59A22B7E7; Sun, 26 Jan 2020 02:08:52 +0000 (UTC) Delivered-To: net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id DB23E22B7E6 for ; Sun, 26 Jan 2020 02:08:52 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 484xBX5S40z4Q2D for ; Sun, 26 Jan 2020 02:08:52 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id B679A19D44 for ; Sun, 26 Jan 2020 02:08:52 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 00Q28qwf082190 for ; Sun, 26 Jan 2020 02:08:52 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 00Q28qJo082185 for net@FreeBSD.org; Sun, 26 Jan 2020 02:08:52 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: net@FreeBSD.org Subject: [Bug 243590] TCP ECN not adhering extremely strictly to RFC3168 can cause massive TCP perf issues Date: Sun, 26 Jan 2020 02:08:52 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 11.2-STABLE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: linimon@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: net@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: assigned_to Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 26 Jan 2020 02:08:53 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D243590 Mark Linimon changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|bugs@FreeBSD.org |net@FreeBSD.org --=20 You are receiving this mail because: You are the assignee for the bug.= From owner-freebsd-net@freebsd.org Sun Jan 26 02:10:07 2020 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 63A3F22BB0A for ; Sun, 26 Jan 2020 02:10:07 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (mailman.nyi.freebsd.org [IPv6:2610:1c1:1:606c::50:13]) by mx1.freebsd.org (Postfix) with ESMTP id 484xCz24YKz4QFs for ; Sun, 26 Jan 2020 02:10:07 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id 4725822BB08; Sun, 26 Jan 2020 02:10:07 +0000 (UTC) Delivered-To: net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 46E3F22BB07 for ; Sun, 26 Jan 2020 02:10:07 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 484xCz1FCzz4QFq for ; Sun, 26 Jan 2020 02:10:07 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 24AB619D55 for ; Sun, 26 Jan 2020 02:10:07 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 00Q2A7Uc084521 for ; Sun, 26 Jan 2020 02:10:07 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 00Q2A70L084520 for net@FreeBSD.org; Sun, 26 Jan 2020 02:10:07 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: net@FreeBSD.org Subject: [Bug 243554] multicast packets not seen on PHY bridge member Date: Sun, 26 Jan 2020 02:10:06 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 12.1-RELEASE X-Bugzilla-Keywords: patch X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: linimon@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: net@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: assigned_to keywords Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 26 Jan 2020 02:10:07 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D243554 Mark Linimon changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|bugs@FreeBSD.org |net@FreeBSD.org Keywords| |patch --=20 You are receiving this mail because: You are the assignee for the bug.= From owner-freebsd-net@freebsd.org Sun Jan 26 06:58:56 2020 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 7DF52231F44 for ; Sun, 26 Jan 2020 06:58:56 +0000 (UTC) (envelope-from ozkan.kirik@gmail.com) Received: from mail-ua1-x935.google.com (mail-ua1-x935.google.com [IPv6:2607:f8b0:4864:20::935]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4853dC4lt4z4d8L for ; Sun, 26 Jan 2020 06:58:55 +0000 (UTC) (envelope-from ozkan.kirik@gmail.com) Received: by mail-ua1-x935.google.com with SMTP id f7so2340150uaa.8 for ; Sat, 25 Jan 2020 22:58:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=+iumTTC4mjGNt4jffEG1sAmXnhzj9U4szsh61MXFPzg=; b=Tnij4HkvhQoanM8hnBiOdiKf3LMqlkFUvprV78Jd100D+wOa6s6htcso6tU/ZViGXj NN7Zm2AOsLNE4gv+lKOrJTmtpeVizWHqqAJsDq81zXCWHoY/0UAgQalnCa3gzVtOSHtr K9eovw5v47jIaCLLoHcMcUObn/fJmR/WEtuEoPnMK79nlBtD/rc9Eb6wr4AZC7Me825j xNiJFpqDxbSbUJuThzLhMojkRtDXIINjW4iPO3TirRbEVPoTmFUclPBxT8RBDLivVUvu fjatjGl5iB+A9b+wE/FtLWEcIAH7rexFuj8Fl5OkWA6bhyDwKvNe2+Vi7JH47nkdXwMf 5/nw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=+iumTTC4mjGNt4jffEG1sAmXnhzj9U4szsh61MXFPzg=; b=N8Lha0TGhhx/+VJuKm+by4/ZP/ZRbiN1FC7HgWzBvHgLeT7AVRGuotKWuquyMljR0X l1iWQyOCGNg9iPMID2k9CYfNO84ztL/DGGPrRm79JfQ813N8gpRFUJP2DjCwb/YsLHwe 0iyk5xPpe4pNg+wfvrf4SAeKvicG4R4r5vBErYHjBgpdVYa6nWP2Lp2HImU4oU7sCcje rzq9Kd8V589C+jfk8tn1cSGmgeIuEbs8S0Q2u+9KsbyzuSZ01IexMHYKBH4A7Vy4T7vE M1RT8d48wys7cHN4idhmObIezHJD5DoLN/wXIjePHueUFQ0fDZPJ0kaUAJbU9ziEJJ7L XIzA== X-Gm-Message-State: APjAAAWIUe6huMb2XpgZRdRbtmI9MDb/nlzh2HR0E+FmPm4bXC299Hxu /VBiN6HQ5GdDET+iqVOhh7xgOLOYphUjJJ6ueIo= X-Google-Smtp-Source: APXvYqxHlRCQvzy+n307/uO/HfcYNZU3/8VBAuwlVwLtrYDcxHG50CbF14xV1r52x1zpzcG0wev1dLgkR3ygvDe5RWA= X-Received: by 2002:ab0:7411:: with SMTP id r17mr6541873uap.31.1580021934068; Sat, 25 Jan 2020 22:58:54 -0800 (PST) MIME-Version: 1.0 References: <893da640-3414-d079-e126-c0f3235eb8e4@yandex.ru> In-Reply-To: <893da640-3414-d079-e126-c0f3235eb8e4@yandex.ru> From: =?UTF-8?B?w5Z6a2FuIEtJUklL?= Date: Sun, 26 Jan 2020 09:58:42 +0300 Message-ID: Subject: Re: pf (rules and nat) + (ipfw + dummynet) To: "Andrey V. Elsukov" Cc: freebsd-net@freebsd.org X-Rspamd-Queue-Id: 4853dC4lt4z4d8L X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20161025 header.b=Tnij4Hkv; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (mx1.freebsd.org: domain of ozkankirik@gmail.com designates 2607:f8b0:4864:20::935 as permitted sender) smtp.mailfrom=ozkankirik@gmail.com X-Spamd-Result: default: False [-3.00 / 15.00]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36]; FREEMAIL_FROM(0.00)[gmail.com]; DKIM_TRACE(0.00)[gmail.com:+]; RCPT_COUNT_TWO(0.00)[2]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; FREEMAIL_TO(0.00)[yandex.ru]; FROM_EQ_ENVFROM(0.00)[]; IP_SCORE(0.00)[ip: (-9.64), ipnet: 2607:f8b0::/32(-2.05), asn: 15169(-1.79), country: US(-0.05)]; MIME_TRACE(0.00)[0:+,1:+,2:~]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; TAGGED_FROM(0.00)[]; DWL_DNSWL_NONE(0.00)[gmail.com.dwl.dnswl.org : 127.0.5.0]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20161025]; FROM_HAS_DN(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; PREVIOUSLY_DELIVERED(0.00)[freebsd-net@freebsd.org]; IP_SCORE_FREEMAIL(0.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[5.3.9.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 26 Jan 2020 06:58:56 -0000 Hello Andrey, Have you started to rewrite dummynet? If yes, I can test and give feedbacks in different scenarios. Regards On Mon, Aug 19, 2019 at 12:53 PM Andrey V. Elsukov wrote: > On 18.08.2019 00:25, Andrew White wrote: > > I also see some work underway to separate dummynet from ipfw, is there > any > > docs for the goals or timelines, will this allow dummynet anchors and use > > of dnctl to use pf with dummynet like in macos ? > > JFYI, > > dummynet uses single exclusive mutex and this kills performance on > modern hardware. If you don't have some patches that are ready for > committing, I think after several months this code will be significantly > rewritten by me and your WIP patches will become stale. > > -- > WBR, Andrey V. Elsukov > > From owner-freebsd-net@freebsd.org Sun Jan 26 20:52:52 2020 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 3DD111FB527 for ; Sun, 26 Jan 2020 20:52:52 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id 485Q7S0xTbz4V1T for ; Sun, 26 Jan 2020 20:52:52 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id 2029E1FB526; Sun, 26 Jan 2020 20:52:52 +0000 (UTC) Delivered-To: net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 1FF301FB525 for ; Sun, 26 Jan 2020 20:52:52 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 485Q7S04DBz4V1S for ; Sun, 26 Jan 2020 20:52:52 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id F201C26F0A for ; Sun, 26 Jan 2020 20:52:51 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 00QKqpkm095976 for ; Sun, 26 Jan 2020 20:52:51 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 00QKqpxP095975 for net@FreeBSD.org; Sun, 26 Jan 2020 20:52:51 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: net@FreeBSD.org Subject: [Bug 207261] netmap: Doesn't do TX sync with kqueue Date: Sun, 26 Jan 2020 20:52:51 +0000 X-Bugzilla-Reason: CC AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 10.2-STABLE X-Bugzilla-Keywords: needs-patch, needs-qa X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: vmaffione@FreeBSD.org X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: net@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback? mfc-stable12? mfc-stable11? mfc-stable10? X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 26 Jan 2020 20:52:52 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D207261 --- Comment #9 from Vincenzo Maffione --- Sorry for being unresponsive on this. The root of the problem is that when netmap was designed, kqueue was not ta= ken in consideration. Support for kqueue was added afterwards. Because of that, there are some locking issues that make it hard for netmap to work well with kqueue. The massive taskqueue usage that you observe are due to recent changes (r34= 3579 and r344253) that fixed a possible deadlock (e.g. with bhyve guests). It's unfortunate that netmap works so bad with kqueue. I would really like = to improve the situation, as soon as I have some time to spend on this. It wou= ld also really help to have some opinion from people that know the kqueue internals, as I currently have very little knowledge. --=20 You are receiving this mail because: You are on the CC list for the bug. You are the assignee for the bug.= From owner-freebsd-net@freebsd.org Mon Jan 27 15:42:58 2020 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 811CF1F9D5F for ; Mon, 27 Jan 2020 15:42:58 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id 485vCQ2x0Tz4W5c for ; Mon, 27 Jan 2020 15:42:58 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id 62B111F9D5E; Mon, 27 Jan 2020 15:42:58 +0000 (UTC) Delivered-To: net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 627981F9D5D for ; Mon, 27 Jan 2020 15:42:58 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 485vCQ1zxPz4W5b for ; Mon, 27 Jan 2020 15:42:58 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 3FA9FC5D9 for ; Mon, 27 Jan 2020 15:42:58 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 00RFgwPA076742 for ; Mon, 27 Jan 2020 15:42:58 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 00RFgw39076741 for net@FreeBSD.org; Mon, 27 Jan 2020 15:42:58 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: net@FreeBSD.org Subject: [Bug 243463] ix0: Watchdog timeout Date: Mon, 27 Jan 2020 15:42:57 +0000 X-Bugzilla-Reason: AssignedTo CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 12.1-RELEASE X-Bugzilla-Keywords: IntelNetworking, needs-qa X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: silence@cnw.cz X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: net@FreeBSD.org X-Bugzilla-Flags: mfc-stable12? mfc-stable11? X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 Jan 2020 15:42:58 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D243463 --- Comment #4 from Jiri --- I tried to switch on/off optical link to my ix0 - manually remove fibers. Kernel doesn't detect any outage, no message ix0 down/up in log. (was about= 7 sec - info from switch). No errors appear in log, system running about 5 days from recommended patch. Strange, but it looks like fully operable. --=20 You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug.= From owner-freebsd-net@freebsd.org Tue Jan 28 04:33:06 2020 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 4967223B098 for ; Tue, 28 Jan 2020 04:33:06 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (mailman.nyi.freebsd.org [IPv6:2610:1c1:1:606c::50:13]) by mx1.freebsd.org (Postfix) with ESMTP id 486DJ21GfVz4fS1 for ; Tue, 28 Jan 2020 04:33:06 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id 2B87323B097; Tue, 28 Jan 2020 04:33:06 +0000 (UTC) Delivered-To: net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 2B3C323B096 for ; Tue, 28 Jan 2020 04:33:06 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 486DJ20QCFz4fS0 for ; Tue, 28 Jan 2020 04:33:06 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 09BF61D71A for ; Tue, 28 Jan 2020 04:33:06 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 00S4X5sU056368 for ; Tue, 28 Jan 2020 04:33:05 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 00S4X5kS056367 for net@FreeBSD.org; Tue, 28 Jan 2020 04:33:05 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: net@FreeBSD.org Subject: [Bug 242270] if_vlan(4): Network stack leaks ifnet references when creating VLAN Date: Tue, 28 Jan 2020 04:33:05 +0000 X-Bugzilla-Reason: CC AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: needs-qa, patch X-Bugzilla-Severity: Affects Many People X-Bugzilla-Who: koobs@FreeBSD.org X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: net@FreeBSD.org X-Bugzilla-Flags: mfc-stable12? mfc-stable11? X-Bugzilla-Changed-Fields: keywords bug_status short_desc cc flagtypes.name Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Jan 2020 04:33:06 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D242270 Kubilay Kocak changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |needs-qa Status|New |Open Summary|Network stack leaks ifnet |if_vlan(4): Network stack |references when creating |leaks ifnet references when |VLAN |creating VLAN CC| |net@FreeBSD.org Flags| |mfc-stable12?, | |mfc-stable11? --=20 You are receiving this mail because: You are on the CC list for the bug. You are the assignee for the bug.= From owner-freebsd-net@freebsd.org Tue Jan 28 04:35:51 2020 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id C735F23B28E for ; Tue, 28 Jan 2020 04:35:51 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (mailman.nyi.freebsd.org [IPv6:2610:1c1:1:606c::50:13]) by mx1.freebsd.org (Postfix) with ESMTP id 486DMC4wCLz4ff3 for ; Tue, 28 Jan 2020 04:35:51 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id A8B5623B28D; Tue, 28 Jan 2020 04:35:51 +0000 (UTC) Delivered-To: net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id A87F523B28C for ; Tue, 28 Jan 2020 04:35:51 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 486DMC43XDz4ff2 for ; Tue, 28 Jan 2020 04:35:51 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 868C51D725 for ; Tue, 28 Jan 2020 04:35:51 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 00S4ZpD2059653 for ; Tue, 28 Jan 2020 04:35:51 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 00S4ZpfY059652 for net@FreeBSD.org; Tue, 28 Jan 2020 04:35:51 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: net@FreeBSD.org Subject: [Bug 196501] [em] Intel 82573 nic built on my pdsbm-ln2 1U server and only one port will work. Date: Tue, 28 Jan 2020 04:35:50 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 10.1-RELEASE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Many People X-Bugzilla-Who: koobs@FreeBSD.org X-Bugzilla-Status: Closed X-Bugzilla-Resolution: Overcome By Events X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: net@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: resolution Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Jan 2020 04:35:51 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D196501 Kubilay Kocak changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|FIXED |Overcome By Events --- Comment #10 from Kubilay Kocak --- ^Triage: Correct resolution, not technically resolved (worked around: comme= nt 6) --=20 You are receiving this mail because: You are the assignee for the bug.= From owner-freebsd-net@freebsd.org Tue Jan 28 10:15:11 2020 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 89D7B1FD1B9 for ; Tue, 28 Jan 2020 10:15:11 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (mailman.nyi.freebsd.org [IPv6:2610:1c1:1:606c::50:13]) by mx1.freebsd.org (Postfix) with ESMTP id 486Mtl39gxz3DL5 for ; Tue, 28 Jan 2020 10:15:11 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id 6CE8C1FD1B8; Tue, 28 Jan 2020 10:15:11 +0000 (UTC) Delivered-To: net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 6CAC71FD1B7 for ; Tue, 28 Jan 2020 10:15:11 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 486Mtl2JQDz3DL4 for ; Tue, 28 Jan 2020 10:15:11 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4A916215C7 for ; Tue, 28 Jan 2020 10:15:11 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 00SAFBu7072200 for ; Tue, 28 Jan 2020 10:15:11 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 00SAFBJU072199 for net@FreeBSD.org; Tue, 28 Jan 2020 10:15:11 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: net@FreeBSD.org Subject: [Bug 243392] if_vmx(4): Input buffer corruption Date: Tue, 28 Jan 2020 10:15:11 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 12.1-RELEASE X-Bugzilla-Keywords: needs-qa X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: avg@FreeBSD.org X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: net@FreeBSD.org X-Bugzilla-Flags: mfc-stable12? X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Jan 2020 10:15:11 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D243392 --- Comment #6 from Andriy Gapon --- I probably should open a new bug for my side of the things as my problem ca= n be different from the original problem reported here. But for the moment here is a new bit of information. I tried to gather a little bit more of information with tcpdump and I got a very surprising result. If I run tcpdump on the vmx side, then the copy speed never degrades. If I start copying before starting tcpdump then the speed can degrade, but = as soon as I start tcpdump (on the vmx side) the speed immediately recovers. I have tested that many times with the same result. It seems that enabling bpf changes the packet processing flow and works aro= und whatever problem there is. Does anyone have an idea what that change could be and where to dig further? Thanks! --=20 You are receiving this mail because: You are the assignee for the bug.= From owner-freebsd-net@freebsd.org Tue Jan 28 10:50:41 2020 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 877EF1FE20A for ; Tue, 28 Jan 2020 10:50:41 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id 486Ngj32w3z3G1Z for ; Tue, 28 Jan 2020 10:50:41 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id 66A6C1FE206; Tue, 28 Jan 2020 10:50:41 +0000 (UTC) Delivered-To: net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 666371FE204 for ; Tue, 28 Jan 2020 10:50:41 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 486Ngj26Nhz3G1W for ; Tue, 28 Jan 2020 10:50:41 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 29C2921B95 for ; Tue, 28 Jan 2020 10:50:41 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 00SAofMv074654 for ; Tue, 28 Jan 2020 10:50:41 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 00SAofD9074653 for net@FreeBSD.org; Tue, 28 Jan 2020 10:50:41 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: net@FreeBSD.org Subject: [Bug 243392] if_vmx(4): Input buffer corruption Date: Tue, 28 Jan 2020 10:50:41 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 12.1-RELEASE X-Bugzilla-Keywords: needs-qa X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: avg@FreeBSD.org X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: net@FreeBSD.org X-Bugzilla-Flags: mfc-stable12? X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Jan 2020 10:50:41 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D243392 --- Comment #7 from Andriy Gapon --- When I run tcpdump on the other end, there is no effect on the speed. There are some potentially interesting snippets in the capture. Here is one where 10.25.200.199 is the vmx side and 10.180.0.51 is the other host that sends data to the vmx host: 115 02:16:28.787281 IP 10.180.0.51.17739 > 10.25.200.199.22: Flags [.], = seq 81774:83160, ack 1, win 1026, options [nop,nop,TS val 3595053000 ecr 1184721692], length 1386 116 02:16:28.787284 IP 10.180.0.51.17739 > 10.25.200.199.22: Flags [.], = seq 83160:84546, ack 1, win 1026, options [nop,nop,TS val 3595053000 ecr 1184721692], length 1386 117 02:16:28.787304 IP 10.180.0.51.17739 > 10.25.200.199.22: Flags [.], = seq 84546:85932, ack 1, win 1026, options [nop,nop,TS val 3595053000 ecr 1184721692], length 1386 118 02:16:28.787307 IP 10.180.0.51.17739 > 10.25.200.199.22: Flags [.], = seq 85932:87318, ack 1, win 1026, options [nop,nop,TS val 3595053000 ecr 1184721692], length 1386 119 02:16:28.883545 IP 10.25.200.199.22 > 10.180.0.51.17739: Flags [.], = ack 83160, win 2192, options [nop,nop,TS val 1184721792 ecr 3595053000], length= 0 120 02:16:28.883576 IP 10.180.0.51.17739 > 10.25.200.199.22: Flags [.], = seq 87318:88704, ack 1, win 1026, options [nop,nop,TS val 3595053097 ecr 1184721792], length 1386 121 02:16:28.887035 IP 10.25.200.199.22 > 10.180.0.51.17739: Flags [.], = ack 83160, win 2192, options [nop,nop,TS val 1184721792 ecr 3595053000,nop,nop,= sack 1 {87318:88704}], length 0 122 02:16:29.336381 IP 10.180.0.51.17739 > 10.25.200.199.22: Flags [.], = seq 83160:84546, ack 1, win 1026, options [nop,nop,TS val 3595053549 ecr 1184721792], length 1386 My reading of the above. Packets 115-118: data packets Packet 119: ack for packet 115 Packet 120: another data packet Packet 121: appears to be exact duplicate of the packet 119 (ack) Packet 122: looks like a retransmission of packet 116 after a noticeable de= lay (0.44s) Well, on another look, packets 119 and 121 are not exactly the same. 121 has this "sack 1 {87318:88704}" that 119 does not have. And it seems like packet 121 is what "confuses" the sending side as the pau= se and retransmission. Not a TCP expert, so don't know if anything is wrong here. --=20 You are receiving this mail because: You are the assignee for the bug.= From owner-freebsd-net@freebsd.org Tue Jan 28 10:58:12 2020 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 55EDA1FE6A3 for ; Tue, 28 Jan 2020 10:58:12 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id 486NrM4VH4z3GWp for ; Tue, 28 Jan 2020 10:58:11 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id 9A4511FE6A0; Tue, 28 Jan 2020 10:58:11 +0000 (UTC) Delivered-To: net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 9A0DE1FE69F for ; Tue, 28 Jan 2020 10:58:11 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 486NrM0K50z3GWm for ; Tue, 28 Jan 2020 10:58:10 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id EB1FE21D75 for ; Tue, 28 Jan 2020 10:58:10 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 00SAwAdL096910 for ; Tue, 28 Jan 2020 10:58:10 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 00SAwArq096908 for net@FreeBSD.org; Tue, 28 Jan 2020 10:58:10 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: net@FreeBSD.org Subject: [Bug 243392] if_vmx(4): Input buffer corruption Date: Tue, 28 Jan 2020 10:58:10 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 12.1-RELEASE X-Bugzilla-Keywords: needs-qa X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: avg@FreeBSD.org X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: net@FreeBSD.org X-Bugzilla-Flags: mfc-stable12? X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Jan 2020 10:58:12 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D243392 --- Comment #8 from Andriy Gapon --- (In reply to Andriy Gapon from comment #7) It seems like packets 116 (seq 84546) and 117 (seq 85932) were never ack-ed and, thus, lost (presumably by the vmx side) ? Packet 115 was ack-ed, packets 118 and 120 were sack-ed. --=20 You are receiving this mail because: You are the assignee for the bug.= From owner-freebsd-net@freebsd.org Tue Jan 28 13:44:21 2020 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id AB1B422D449 for ; Tue, 28 Jan 2020 13:44:21 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (mailman.nyi.freebsd.org [IPv6:2610:1c1:1:606c::50:13]) by mx1.freebsd.org (Postfix) with ESMTP id 486SX540C7z3y3K for ; Tue, 28 Jan 2020 13:44:21 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id 88FF922D448; Tue, 28 Jan 2020 13:44:21 +0000 (UTC) Delivered-To: net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 88C4B22D447 for ; Tue, 28 Jan 2020 13:44:21 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 486SX51Gvhz3y3J for ; Tue, 28 Jan 2020 13:44:21 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 2723123E4F for ; Tue, 28 Jan 2020 13:44:21 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 00SDiL72031113 for ; Tue, 28 Jan 2020 13:44:21 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 00SDiLaE031111 for net@FreeBSD.org; Tue, 28 Jan 2020 13:44:21 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: net@FreeBSD.org Subject: [Bug 243392] if_vmx(4): Input buffer corruption Date: Tue, 28 Jan 2020 13:44:20 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 12.1-RELEASE X-Bugzilla-Keywords: needs-qa X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: avg@FreeBSD.org X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: net@FreeBSD.org X-Bugzilla-Flags: mfc-stable12? X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Jan 2020 13:44:21 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D243392 --- Comment #9 from Andriy Gapon --- A few additional datapoints. Running tcpdump with -p (no promiscuous mode) does not prevent the speed degradation. tcpdump shows many incoming tcp packets are received out of order. Disabling LRO works around the problem. --=20 You are receiving this mail because: You are the assignee for the bug.= From owner-freebsd-net@freebsd.org Tue Jan 28 17:22:01 2020 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 8AACE234473 for ; Tue, 28 Jan 2020 17:22:01 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (mailman.nyi.freebsd.org [IPv6:2610:1c1:1:606c::50:13]) by mx1.freebsd.org (Postfix) with ESMTP id 486YMF35nbz4Fwj for ; Tue, 28 Jan 2020 17:22:01 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id 6A43D234471; Tue, 28 Jan 2020 17:22:01 +0000 (UTC) Delivered-To: net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 6A031234470 for ; Tue, 28 Jan 2020 17:22:01 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 486YMD5xGGz4Fwb for ; Tue, 28 Jan 2020 17:22:00 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id C731526786 for ; Tue, 28 Jan 2020 17:22:00 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 00SHM0Fm088874 for ; Tue, 28 Jan 2020 17:22:00 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 00SHM0Zi088840 for net@FreeBSD.org; Tue, 28 Jan 2020 17:22:00 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: net@FreeBSD.org Subject: [Bug 243675] IPv6 checksum is wrong in output packets with extension headers Date: Tue, 28 Jan 2020 17:22:00 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: ipv6 X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: bz@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: net@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: keywords cc assigned_to Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Jan 2020 17:22:01 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D243675 Bjoern A. Zeeb changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |ipv6 CC| |bz@FreeBSD.org Assignee|bugs@FreeBSD.org |net@FreeBSD.org --=20 You are receiving this mail because: You are the assignee for the bug.= From owner-freebsd-net@freebsd.org Tue Jan 28 17:39:10 2020 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 0A04C235197 for ; Tue, 28 Jan 2020 17:39:10 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (mailman.nyi.freebsd.org [IPv6:2610:1c1:1:606c::50:13]) by mx1.freebsd.org (Postfix) with ESMTP id 486Yl16bTRz4HQk for ; Tue, 28 Jan 2020 17:39:09 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id E22E7235196; Tue, 28 Jan 2020 17:39:09 +0000 (UTC) Delivered-To: net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id E1E9F235195 for ; Tue, 28 Jan 2020 17:39:09 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 486Yl15k9bz4HQd for ; Tue, 28 Jan 2020 17:39:09 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id BF417269C8 for ; Tue, 28 Jan 2020 17:39:09 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 00SHd9Nk014727 for ; Tue, 28 Jan 2020 17:39:09 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from bugzilla@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 00SHd9jv014726 for net@FreeBSD.org; Tue, 28 Jan 2020 17:39:09 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: bugzilla set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: net@FreeBSD.org Subject: [Bug 240787] netgraph/ng_bridge: Replace NG_BRIDGE_MAX_LINKS with auto-incrementing (Unlimited) links Date: Tue, 28 Jan 2020 17:39:08 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 12.0-STABLE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: commit-hook@freebsd.org X-Bugzilla-Status: In Progress X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bz@FreeBSD.org X-Bugzilla-Flags: mfc-stable12? mfc-stable11? X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Jan 2020 17:39:10 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D240787 --- Comment #22 from commit-hook@freebsd.org --- A commit references this bug: Author: bz Date: Tue Jan 28 17:39:03 UTC 2020 New revision: 357206 URL: https://svnweb.freebsd.org/changeset/base/357206 Log: MFC r353026,353030,354244 (glebius), r356386: Remove the compile time limit for number of links a ng_bridge node can handle. Instead using an array on node private data, use per-hook private data. Reestablish old ABI. PR: 240787 Submitted by: Lutz Donnerhacke (lutz donnerhacke.de) Changes: _U stable/12/ stable/12/share/man/man4/ng_bridge.4 stable/12/sys/netgraph/ng_bridge.c stable/12/sys/netgraph/ng_bridge.h --=20 You are receiving this mail because: You are on the CC list for the bug.= From owner-freebsd-net@freebsd.org Tue Jan 28 17:40:51 2020 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id CFA28235370 for ; Tue, 28 Jan 2020 17:40:51 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id 486Ymz5BRrz4HYb for ; Tue, 28 Jan 2020 17:40:51 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id B1FF623536F; Tue, 28 Jan 2020 17:40:51 +0000 (UTC) Delivered-To: net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id B1C7023536E for ; Tue, 28 Jan 2020 17:40:51 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 486Ymz4P87z4HYZ for ; Tue, 28 Jan 2020 17:40:51 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 92393269F0 for ; Tue, 28 Jan 2020 17:40:51 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 00SHepAC016926 for ; Tue, 28 Jan 2020 17:40:51 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 00SHepOT016925 for net@FreeBSD.org; Tue, 28 Jan 2020 17:40:51 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: net@FreeBSD.org Subject: [Bug 240787] netgraph/ng_bridge: Replace NG_BRIDGE_MAX_LINKS with auto-incrementing (Unlimited) links Date: Tue, 28 Jan 2020 17:40:51 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 12.0-STABLE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: bz@FreeBSD.org X-Bugzilla-Status: Closed X-Bugzilla-Resolution: FIXED X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bz@FreeBSD.org X-Bugzilla-Flags: mfc-stable12+ mfc-stable11- X-Bugzilla-Changed-Fields: cc bug_status resolution flagtypes.name Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Jan 2020 17:40:51 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D240787 Bjoern A. Zeeb changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bz@FreeBSD.org Status|In Progress |Closed Resolution|--- |FIXED Flags|mfc-stable12?, |mfc-stable12+, |mfc-stable11? |mfc-stable11- --- Comment #23 from Bjoern A. Zeeb --- Merged to FreeBSD 12 as discussed in this thread with the follow-up work fr= om Lutz to re-establish the old API. --=20 You are receiving this mail because: You are on the CC list for the bug.= From owner-freebsd-net@freebsd.org Tue Jan 28 21:47:06 2020 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 5B771242176 for ; Tue, 28 Jan 2020 21:47:06 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id 486gF61kcxz3C57 for ; Tue, 28 Jan 2020 21:47:06 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id 39369242170; Tue, 28 Jan 2020 21:47:06 +0000 (UTC) Delivered-To: net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 38F5224216F for ; Tue, 28 Jan 2020 21:47:06 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 486gF60FY9z3C55 for ; Tue, 28 Jan 2020 21:47:06 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id EF5C81A19 for ; Tue, 28 Jan 2020 21:47:05 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 00SLl5Tm060787 for ; Tue, 28 Jan 2020 21:47:05 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 00SLl5Zm060786 for net@FreeBSD.org; Tue, 28 Jan 2020 21:47:05 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: net@FreeBSD.org Subject: [Bug 243675] IPv6 checksum is wrong in output packets with extension headers Date: Tue, 28 Jan 2020 21:47:05 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: ipv6, patch X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: bz@FreeBSD.org X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bz@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: assigned_to keywords bug_status Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Jan 2020 21:47:06 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D243675 Bjoern A. Zeeb changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|net@FreeBSD.org |bz@FreeBSD.org Keywords| |patch Status|New |Open --- Comment #2 from Bjoern A. Zeeb --- Thanks Francis. Great find and thank you for the detailed explanation and = the patch. Made it a lot easier to understand the problem! I've confirmed the length issues including the extension header length and = your patch seems fine for those. I'll have a look at SCTP tomorrow and also include tests for the FreeBSD te= st suite and get the fix in. --=20 You are receiving this mail because: You are the assignee for the bug.= From owner-freebsd-net@freebsd.org Wed Jan 29 04:02:43 2020 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 688311B63F6 for ; Wed, 29 Jan 2020 04:02:43 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (mailman.nyi.freebsd.org [IPv6:2610:1c1:1:606c::50:13]) by mx1.freebsd.org (Postfix) with ESMTP id 486qZW2DMdz44WD for ; Wed, 29 Jan 2020 04:02:43 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id 4C3271B63F5; Wed, 29 Jan 2020 04:02:43 +0000 (UTC) Delivered-To: net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 4BF611B63F4 for ; Wed, 29 Jan 2020 04:02:43 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 486qZW1Lplz44WC for ; Wed, 29 Jan 2020 04:02:43 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 29C4D63A9 for ; Wed, 29 Jan 2020 04:02:43 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 00T42hss076921 for ; Wed, 29 Jan 2020 04:02:43 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 00T42hdM076920 for net@FreeBSD.org; Wed, 29 Jan 2020 04:02:43 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: net@FreeBSD.org Subject: [Bug 243554] multicast packets not seen on PHY bridge member Date: Wed, 29 Jan 2020 04:02:42 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 12.1-RELEASE X-Bugzilla-Keywords: patch X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: james.blachly@gmail.com X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: net@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Jan 2020 04:02:43 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D243554 --- Comment #4 from James Blachly --- @Kyle Evans: Patch did not do the trick. I can try to tcpdump this weekend (perhaps) to prove it, but behavior is same as before. Also I note that the patch adds the call to ETHER_BPF_MTAP at a different p= lace than in HEAD -- in the patch it adds right before bridge_enque, but in HEAD (but not in 12.1) the call is higher, outside the if{} block: https://github.com/freebsd/freebsd/blob/0f0a35a04846fc4f4bdb6caa2852336d7de= 9447d/sys/net/if_bridge.c#L2058-L2060 I am sure this is intended but just thought I'd mention here for others. Anyway, thanks for looking at this. If you can think of other diagnostics I= can do that would be helpful, let me know. --=20 You are receiving this mail because: You are the assignee for the bug.= From owner-freebsd-net@freebsd.org Wed Jan 29 04:16:30 2020 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 3A06B1B6CA5 for ; Wed, 29 Jan 2020 04:16:30 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id 486qtQ0sgPz455h for ; Wed, 29 Jan 2020 04:16:30 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id 1DB0E1B6CA4; Wed, 29 Jan 2020 04:16:30 +0000 (UTC) Delivered-To: net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 1D74E1B6CA2 for ; Wed, 29 Jan 2020 04:16:30 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 486qtQ02psz455g for ; Wed, 29 Jan 2020 04:16:30 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id F11396578 for ; Wed, 29 Jan 2020 04:16:29 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 00T4GTfU010063 for ; Wed, 29 Jan 2020 04:16:29 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 00T4GTOS010062 for net@FreeBSD.org; Wed, 29 Jan 2020 04:16:29 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: net@FreeBSD.org Subject: [Bug 243554] multicast packets not seen on PHY bridge member Date: Wed, 29 Jan 2020 04:16:29 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 12.1-RELEASE X-Bugzilla-Keywords: patch X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: kevans@freebsd.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: net@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Jan 2020 04:16:30 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D243554 --- Comment #5 from Kyle Evans --- (In reply to James Blachly from comment #4) Interesting- re-reading your original post... so the proper packets are appearing via tcpdump, but they're not being tapped off to avahi? That may be indicative of an architectural problem that we can't actually solve, and would instead require something like switch(4) [that we don't ha= ve yet] with a cleaner separation between the interface receiving local packets and the physical interface. --=20 You are receiving this mail because: You are the assignee for the bug.= From owner-freebsd-net@freebsd.org Wed Jan 29 08:50:18 2020 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 8769A1C741D for ; Wed, 29 Jan 2020 08:50:18 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id 486xyL2XzDz4Jsp for ; Wed, 29 Jan 2020 08:50:18 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id 4FF1B1C741C; Wed, 29 Jan 2020 08:50:18 +0000 (UTC) Delivered-To: net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 4FAF71C741B for ; Wed, 29 Jan 2020 08:50:18 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 486xyL0Sl3z4Jsl for ; Wed, 29 Jan 2020 08:50:18 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 031279697 for ; Wed, 29 Jan 2020 08:50:18 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 00T8oH6U073528 for ; Wed, 29 Jan 2020 08:50:17 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 00T8oHAL073527 for net@FreeBSD.org; Wed, 29 Jan 2020 08:50:17 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: net@FreeBSD.org Subject: [Bug 243392] if_vmx(4): Input buffer corruption Date: Wed, 29 Jan 2020 08:50:17 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 12.1-RELEASE X-Bugzilla-Keywords: needs-qa X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: alexandr.oleynikov@gmail.com X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: net@FreeBSD.org X-Bugzilla-Flags: mfc-stable12? X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Jan 2020 08:50:18 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D243392 --- Comment #10 from alexandr.oleynikov@gmail.com --- Disabling all possible options except jumbo frames is not workaround for a problem edited rc.conf & reboot. After receiving approx 300-400 MBytes network beco= me unavailable # ifconfig vmx1 vmx1: flags=3D8843 metric 0 mtu 9000 options=3D800020 ether 00:50:56:be:f0:13 inet 172.31.255.2 netmask 0xffffff00 broadcast 172.31.255.255 media: Ethernet autoselect status: active nd6 options=3D29 # iperf3 -s -p 1234 ----------------------------------------------------------- Server listening on 1234 ----------------------------------------------------------- Accepted connection from 172.31.255.5, port 52124 [ 5] local 172.31.255.2 port 1234 connected to 172.31.255.5 port 51022 [ ID] Interval Transfer Bitrate [ 5] 0.00-1.02 sec 320 MBytes 2.64 Gbits/sec [ 5] 1.02-2.02 sec 0.00 Bytes 0.00 bits/sec [ 5] 2.02-3.02 sec 0.00 Bytes 0.00 bits/sec [ 5] 3.02-4.01 sec 0.00 Bytes 0.00 bits/sec [ 5] 4.01-5.02 sec 0.00 Bytes 0.00 bits/sec [ 5] 5.02-6.02 sec 0.00 Bytes 0.00 bits/sec [ 5] 6.02-7.01 sec 0.00 Bytes 0.00 bits/sec [ 5] 7.01-8.02 sec 0.00 Bytes 0.00 bits/sec [ 5] 8.02-9.01 sec 0.00 Bytes 0.00 bits/sec [ 5] 9.01-10.01 sec 0.00 Bytes 0.00 bits/sec [ 5] 10.01-10.19 sec 0.00 Bytes 0.00 bits/sec - - - - - - - - - - - - - - - - - - - - - - - - - [ ID] Interval Transfer Bitrate [ 5] 0.00-10.19 sec 320 MBytes 263 Mbits/sec recei= ver ----------------------------------------------------------- Server listening on 1234 ----------------------------------------------------------- --=20 You are receiving this mail because: You are the assignee for the bug.= From owner-freebsd-net@freebsd.org Wed Jan 29 08:58:42 2020 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 7737C1C79D9 for ; Wed, 29 Jan 2020 08:58:42 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id 486y822f4Dz4KSB for ; Wed, 29 Jan 2020 08:58:42 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id 58F311C79D8; Wed, 29 Jan 2020 08:58:42 +0000 (UTC) Delivered-To: net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 58A421C79D6 for ; Wed, 29 Jan 2020 08:58:42 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 486y821kMnz4KS8 for ; Wed, 29 Jan 2020 08:58:42 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 328E1985A for ; Wed, 29 Jan 2020 08:58:42 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 00T8wg5F095758 for ; Wed, 29 Jan 2020 08:58:42 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 00T8wgVR095757 for net@FreeBSD.org; Wed, 29 Jan 2020 08:58:42 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: net@FreeBSD.org Subject: [Bug 243392] if_vmx(4): Input buffer corruption Date: Wed, 29 Jan 2020 08:58:42 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 12.1-RELEASE X-Bugzilla-Keywords: needs-qa X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: alexandr.oleynikov@gmail.com X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: net@FreeBSD.org X-Bugzilla-Flags: mfc-stable12? X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Jan 2020 08:58:42 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D243392 --- Comment #11 from alexandr.oleynikov@gmail.com --- For additional: ifconfig down & up temporary fix problem but after receiveing again approx 300-500 Mbytes in short period network become unavailable again or kernel p= anic (50%/50%) # ifconfig vmx1 down && ifconfig vmx1 up && iperf3 -s -p 1234 ----------------------------------------------------------- Server listening on 1234 ----------------------------------------------------------- Accepted connection from 172.31.255.5, port 39861 [ 5] local 172.31.255.2 port 1234 connected to 172.31.255.5 port 39030 --- kernel panic ----=20 Fatal trap 12: page fault while in kernel mode cpuid =3D 1; apic id =3D 02 fault virtual address =3D 0x0 fault code =3D supervisor write data, page not present instruction pointer =3D 0x20:0xffffffff80cef252 stack pointer =3D 0x28:0xfffffe00753547c0 frame pointer =3D 0x28:0xfffffe00753548a0 code segment =3D base 0x0, limit 0xfffff, type 0x1b =3D DPL 0, pres 1, long 1, def32 0, gran 1 processor eflags =3D interrupt enabled, resume, IOPL =3D 0 current process =3D 0 (if_io_tqg_1) trap number =3D 12 panic: page fault cpuid =3D 1 time =3D 1580287973 KDB: stack backtrace: #0 0xffffffff80c1d297 at kdb_backtrace+0x67 #1 0xffffffff80bd05cd at vpanic+0x19d #2 0xffffffff80bd0423 at panic+0x43 #3 0xffffffff810a7dcc at trap_fatal+0x39c #4 0xffffffff810a7e19 at trap_pfault+0x49 #5 0xffffffff810a740f at trap+0x29f #6 0xffffffff81081a0c at calltrap+0x8 #7 0xffffffff80ce9be5 at _task_fn_rx+0x75 #8 0xffffffff80c1bb54 at gtaskqueue_run_locked+0x144 #9 0xffffffff80c1b7b8 at gtaskqueue_thread_loop+0x98 #10 0xffffffff80b90c23 at fork_exit+0x83 #11 0xffffffff81082a4e at fork_trampoline+0xe Uptime: 11m47s And from sending side: root@bsd_template:/usr/home/ao # iperf3 -c 172.31.255.2 -p 1234 Connecting to host 172.31.255.2, port 1234 [ 5] local 172.31.255.5 port 39030 connected to 172.31.255.2 port 1234 [ ID] Interval Transfer Bitrate Retr Cwnd [ 5] 0.00-1.01 sec 614 MBytes 5.07 Gbits/sec 1 8.74 KBytes [ 5] 1.01-2.03 sec 0.00 Bytes 0.00 bits/sec 3 8.74 KBytes [ 5] 2.03-3.02 sec 0.00 Bytes 0.00 bits/sec 1 8.74 KBytes [ 5] 3.02-4.03 sec 0.00 Bytes 0.00 bits/sec 1 8.74 KBytes [ 5] 4.03-5.03 sec 0.00 Bytes 0.00 bits/sec 0 8.74 KBytes [ 5] 5.03-6.02 sec 0.00 Bytes 0.00 bits/sec 1 8.74 KBytes [ 5] 6.02-7.03 sec 0.00 Bytes 0.00 bits/sec 0 8.74 KBytes [ 5] 7.03-8.03 sec 0.00 Bytes 0.00 bits/sec 0 8.74 KBytes [ 5] 8.03-9.03 sec 0.00 Bytes 0.00 bits/sec 0 8.74 KBytes --=20 You are receiving this mail because: You are the assignee for the bug.= From owner-freebsd-net@freebsd.org Wed Jan 29 18:42:08 2020 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 64E401F93C0 for ; Wed, 29 Jan 2020 18:42:08 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (mailman.nyi.freebsd.org [IPv6:2610:1c1:1:606c::50:13]) by mx1.freebsd.org (Postfix) with ESMTP id 487C5D253wz3ws4 for ; Wed, 29 Jan 2020 18:42:08 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id 478B81F93BF; Wed, 29 Jan 2020 18:42:08 +0000 (UTC) Delivered-To: net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 475661F93BD for ; Wed, 29 Jan 2020 18:42:08 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 487C5D13XSz3ws2 for ; Wed, 29 Jan 2020 18:42:08 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 1FABF1882C for ; Wed, 29 Jan 2020 18:42:08 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 00TIg8HH043528 for ; Wed, 29 Jan 2020 18:42:08 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from bugzilla@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 00TIg8cY043527 for net@FreeBSD.org; Wed, 29 Jan 2020 18:42:08 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: bugzilla set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: net@FreeBSD.org Subject: [Bug 242270] if_vlan(4): Network stack leaks ifnet references when creating VLAN Date: Wed, 29 Jan 2020 18:42:08 +0000 X-Bugzilla-Reason: AssignedTo CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: needs-qa, patch X-Bugzilla-Severity: Affects Many People X-Bugzilla-Who: commit-hook@freebsd.org X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: net@FreeBSD.org X-Bugzilla-Flags: mfc-stable12? mfc-stable11? X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Jan 2020 18:42:08 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D242270 --- Comment #1 from commit-hook@freebsd.org --- A commit references this bug: Author: melifaro Date: Wed Jan 29 18:41:35 UTC 2020 New revision: 357263 URL: https://svnweb.freebsd.org/changeset/base/357263 Log: Plug parent iface refcount leak on .X vlan creation. PR: kern/242270 Submitted by: Andrew Boyer MFC after: 2 weeks Changes: head/sys/net/if_vlan.c --=20 You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug.= From owner-freebsd-net@freebsd.org Wed Jan 29 18:56:59 2020 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 1DFF51F9A5F for ; Wed, 29 Jan 2020 18:56:59 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id 487CQM009kz3xrJ for ; Wed, 29 Jan 2020 18:56:59 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id F213C1F9A5E; Wed, 29 Jan 2020 18:56:58 +0000 (UTC) Delivered-To: net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id F1DC71F9A5D for ; Wed, 29 Jan 2020 18:56:58 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 487CQL64Lvz3xrH for ; Wed, 29 Jan 2020 18:56:58 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id C784918A45 for ; Wed, 29 Jan 2020 18:56:58 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 00TIuwJ9080588 for ; Wed, 29 Jan 2020 18:56:58 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 00TIuwt7080587 for net@FreeBSD.org; Wed, 29 Jan 2020 18:56:58 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: net@FreeBSD.org Subject: [Bug 242270] if_vlan(4): Network stack leaks ifnet references when creating VLAN Date: Wed, 29 Jan 2020 18:56:58 +0000 X-Bugzilla-Reason: AssignedTo CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: needs-qa, patch X-Bugzilla-Severity: Affects Many People X-Bugzilla-Who: melifaro@FreeBSD.org X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: net@FreeBSD.org X-Bugzilla-Flags: mfc-stable12? mfc-stable11? X-Bugzilla-Changed-Fields: cc Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Jan 2020 18:56:59 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D242270 Alexander V. Chernikov changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |melifaro@FreeBSD.org --- Comment #2 from Alexander V. Chernikov --- Committed to -HEAD. Thank you for the detailed analysis&patch! --=20 You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug.= From owner-freebsd-net@freebsd.org Wed Jan 29 21:31:10 2020 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id ECC891FF76E for ; Wed, 29 Jan 2020 21:31:10 +0000 (UTC) (envelope-from ricera10@gmail.com) Received: from mail-lj1-f169.google.com (mail-lj1-f169.google.com [209.85.208.169]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 487GrG21xjz4D4y for ; Wed, 29 Jan 2020 21:31:10 +0000 (UTC) (envelope-from ricera10@gmail.com) Received: by mail-lj1-f169.google.com with SMTP id y6so1045614lji.0 for ; Wed, 29 Jan 2020 13:31:10 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=VxnkWfCqndfeB5XxxE248eMspySmN3CKd9h5v6VL1eA=; b=BYlO6JexNliUrLhX8OhsDv5dNTghldU/3EKEARqgNgQAe5SarnASm1EHWCLvfVfleg Ol7/4XArZ8DEi67mM7MS6dUGpwfNqd+I84XFAkOYb3J+yOMjLBvg83U1VzVI1NX/0Y/4 /JV6xWT/1scEsJrNQCxil1rMM17eaZ4NtK0m6wp7NWiIdtKCCczAmZq34AVBaV+Wcmg8 /A2NSJ11i1iMeo5Eqi+XwKqH5SP55WfMvdbS1k5lRydJ0BljVXIpqbmD/3UwthQHpFhC TQDOHZZG1Kh1m5w+mhcOCrrnxtS7y3NYa4AVrcu5IzXvvbP6VIKr6fzc+DwR0Rl3IcK2 lKWA== X-Gm-Message-State: APjAAAVLYQIKi+aDzWnX9v3OB2dO6Xs0WD34WNFw3hHjyVBWRs2J9ZK7 tPv3xZPr70UehhbkUd3/9uMAc/SD X-Google-Smtp-Source: APXvYqzTSQha76e+c/0CYK1AvAKqXzYwr43BY5R6QLAyTHVgaPmY6IJXiAseuKaPwGxOvhaViXalDQ== X-Received: by 2002:a2e:978c:: with SMTP id y12mr672984lji.167.1580333467981; Wed, 29 Jan 2020 13:31:07 -0800 (PST) Received: from mail-lj1-f175.google.com (mail-lj1-f175.google.com. [209.85.208.175]) by smtp.gmail.com with ESMTPSA id 4sm1632516lfj.75.2020.01.29.13.31.07 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 29 Jan 2020 13:31:07 -0800 (PST) Received: by mail-lj1-f175.google.com with SMTP id o11so1003759ljc.6 for ; Wed, 29 Jan 2020 13:31:07 -0800 (PST) X-Received: by 2002:a2e:844e:: with SMTP id u14mr686118ljh.183.1580333466679; Wed, 29 Jan 2020 13:31:06 -0800 (PST) MIME-Version: 1.0 From: Eric Joyner Date: Wed, 29 Jan 2020 13:30:55 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Issue with epoch_drain_callbacks and unloading iavf(4) [using iflib] To: freebsd-net@freebsd.org X-Rspamd-Queue-Id: 487GrG21xjz4D4y X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of ricera10@gmail.com designates 209.85.208.169 as permitted sender) smtp.mailfrom=ricera10@gmail.com X-Spamd-Result: default: False [-3.06 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; FROM_HAS_DN(0.00)[]; R_SPF_ALLOW(-0.20)[+ip4:209.85.128.0/17]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; PREVIOUSLY_DELIVERED(0.00)[freebsd-net@freebsd.org]; TO_DN_NONE(0.00)[]; RCPT_COUNT_ONE(0.00)[1]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; RCVD_COUNT_THREE(0.00)[4]; MIME_TRACE(0.00)[0:+,1:+,2:~]; RCVD_IN_DNSWL_NONE(0.00)[169.208.85.209.list.dnswl.org : 127.0.5.0]; IP_SCORE(-1.06)[ip: (-0.42), ipnet: 209.85.128.0/17(-3.05), asn: 15169(-1.78), country: US(-0.05)]; FORGED_SENDER(0.30)[erj@freebsd.org,ricera10@gmail.com]; DMARC_NA(0.00)[freebsd.org]; R_DKIM_NA(0.00)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; FROM_NEQ_ENVFROM(0.00)[erj@freebsd.org,ricera10@gmail.com]; RCVD_TLS_ALL(0.00)[]; TO_DOM_EQ_FROM_DOM(0.00)[] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Jan 2020 21:31:11 -0000 Hi freebsd-net, We've encountered an issue with unloading the iavf(4) driver on FreeBSD 12.1 (and stable). On a VM with two iavf(4) interfaces, if we send heavy traffic to iavf1 and try to kldunload the driver, the kldunload process hangs on iavf0 until iavf1 stops receiving traffic. After some debugging, it looks like epoch_drain_callbacks() [via if_detach_internal()] tries to switch CPUs to run on one that iavf1 is using for RX processing, but since iavf1 is busy, it can't make the switch, so cpu_switch() just hangs and nothing happens until iavf1's RX thread stops being busy. I can work around this by inserting a kern_yield(PRI_USER) somewhere in one of the iavf txrx functions that iflib calls into (e.g. iavf_isc_rxd_available), but that's not a proper fix. Does anyone know what to do to prevent this from happening? Wildly guessing, does maybe epoch_drain_callbacks() need a higher priority than the PI_SOFT used in the group taskqueues used in iflib's RX processing? - Eric From owner-freebsd-net@freebsd.org Wed Jan 29 21:41:51 2020 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 6925A1F8048 for ; Wed, 29 Jan 2020 21:41:51 +0000 (UTC) (envelope-from hps@selasky.org) Received: from mail.turbocat.net (turbocat.net [IPv6:2a01:4f8:c17:6c4b::2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 487H4b1px6z4F5F; Wed, 29 Jan 2020 21:41:49 +0000 (UTC) (envelope-from hps@selasky.org) Received: from hps2020.home.selasky.org (unknown [62.141.129.235]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by mail.turbocat.net (Postfix) with ESMTPSA id 0C21F260165; Wed, 29 Jan 2020 22:41:47 +0100 (CET) Subject: Re: Issue with epoch_drain_callbacks and unloading iavf(4) [using iflib] To: Eric Joyner , freebsd-net@freebsd.org References: From: Hans Petter Selasky Message-ID: <0e2e97f2-df75-3c6f-9bdd-e8c2ab7bf79e@selasky.org> Date: Wed, 29 Jan 2020 22:41:29 +0100 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:68.0) Gecko/20100101 Thunderbird/68.3.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 487H4b1px6z4F5F X-Spamd-Bar: ----- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-6.00 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-0.999,0]; REPLY(-4.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0] X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Jan 2020 21:41:51 -0000 On 2020-01-29 22:30, Eric Joyner wrote: > Hi freebsd-net, > > We've encountered an issue with unloading the iavf(4) driver on FreeBSD > 12.1 (and stable). On a VM with two iavf(4) interfaces, if we send heavy > traffic to iavf1 and try to kldunload the driver, the kldunload process > hangs on iavf0 until iavf1 stops receiving traffic. > > After some debugging, it looks like epoch_drain_callbacks() [via > if_detach_internal()] tries to switch CPUs to run on one that iavf1 is > using for RX processing, but since iavf1 is busy, it can't make the switch, > so cpu_switch() just hangs and nothing happens until iavf1's RX thread > stops being busy. > > I can work around this by inserting a kern_yield(PRI_USER) somewhere in one > of the iavf txrx functions that iflib calls into (e.g. > iavf_isc_rxd_available), but that's not a proper fix. Does anyone know what > to do to prevent this from happening? > > Wildly guessing, does maybe epoch_drain_callbacks() need a higher priority > than the PI_SOFT used in the group taskqueues used in iflib's RX processing? > Hi, Which scheduler is this? ULE or BSD? EPOCH(9) expects some level of round-robin scheduling on the same priority level. Setting a higher priority on EPOCH(9) might cause epoch to start spinning w/o letting the lower priority thread which holds the EPOCH() section to finish. --HPS From owner-freebsd-net@freebsd.org Wed Jan 29 21:44:59 2020 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 141AA1F85F5 for ; Wed, 29 Jan 2020 21:44:59 +0000 (UTC) (envelope-from ricera10@gmail.com) Received: from mail-lj1-f175.google.com (mail-lj1-f175.google.com [209.85.208.175]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 487H8B26PLz4FWj for ; Wed, 29 Jan 2020 21:44:58 +0000 (UTC) (envelope-from ricera10@gmail.com) Received: by mail-lj1-f175.google.com with SMTP id h23so1028100ljc.8 for ; Wed, 29 Jan 2020 13:44:57 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=0kUUG1LZPcT5U3Ev0PQvQOLeoXoB1GQrwj/VwvnD39o=; b=k5lUHb3yUxKueBxxSDrJLV0ehlMkIh3MWHTsVKvNg2jTHcT0+7Xg9uu+kjVBUvirH0 WH8lUFdaRDqVy5hoORKf+3/Q+nffnuVKfiTs4ZV8FMD8/SMDhW25TY+6iKKoBTUCfPv9 yIZmIqJgOiu6+ZA33TuHrkOEPz68XqK9qtpgGNKiU/bcjwYHufEbcMO1LxP7bG6X3G8/ piKaj7lOpgySYZRL7RfPWAiWtp9mDQ6mbiCR7/RxRipZJnS7l5X1v4EOBTcy52f3503/ OpLvkOd2PA4MF0nD7i+A1eSsERi6HFwIBIttpskWVoZKDTgG7xEYSk/a3k3xC/hSH9cv wLOw== X-Gm-Message-State: APjAAAV7koz2NqMg8Pf8NsiWLCvx+otnJ3Quo1k9J9Kc9XKpD43ejkwt vNJaMB3BAEkiFVjgJgDpfWxSdtnq X-Google-Smtp-Source: APXvYqxDeDiL0Z0uTgGqFXkbR/K55W1ysMTH664enrpK7tn0MvkTVlWL3QpfjCSeuWsDuQYStA2SBA== X-Received: by 2002:a05:651c:20f:: with SMTP id y15mr772833ljn.7.1580334296041; Wed, 29 Jan 2020 13:44:56 -0800 (PST) Received: from mail-lf1-f53.google.com (mail-lf1-f53.google.com. [209.85.167.53]) by smtp.gmail.com with ESMTPSA id f11sm1972452lfa.9.2020.01.29.13.44.55 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 29 Jan 2020 13:44:55 -0800 (PST) Received: by mail-lf1-f53.google.com with SMTP id n25so794069lfl.0 for ; Wed, 29 Jan 2020 13:44:55 -0800 (PST) X-Received: by 2002:a19:c210:: with SMTP id l16mr712109lfc.35.1580334295008; Wed, 29 Jan 2020 13:44:55 -0800 (PST) MIME-Version: 1.0 References: <0e2e97f2-df75-3c6f-9bdd-e8c2ab7bf79e@selasky.org> In-Reply-To: <0e2e97f2-df75-3c6f-9bdd-e8c2ab7bf79e@selasky.org> From: Eric Joyner Date: Wed, 29 Jan 2020 13:44:44 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: Issue with epoch_drain_callbacks and unloading iavf(4) [using iflib] To: Hans Petter Selasky Cc: freebsd-net@freebsd.org X-Rspamd-Queue-Id: 487H8B26PLz4FWj X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of ricera10@gmail.com designates 209.85.208.175 as permitted sender) smtp.mailfrom=ricera10@gmail.com X-Spamd-Result: default: False [-3.06 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip4:209.85.128.0/17]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; PREVIOUSLY_DELIVERED(0.00)[freebsd-net@freebsd.org]; DMARC_NA(0.00)[freebsd.org]; RCVD_COUNT_THREE(0.00)[4]; MIME_TRACE(0.00)[0:+,1:+,2:~]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCPT_COUNT_TWO(0.00)[2]; RCVD_IN_DNSWL_NONE(0.00)[175.208.85.209.list.dnswl.org : 127.0.5.0]; IP_SCORE(-1.06)[ip: (-0.43), ipnet: 209.85.128.0/17(-3.05), asn: 15169(-1.78), country: US(-0.05)]; FORGED_SENDER(0.30)[erj@freebsd.org,ricera10@gmail.com]; RWL_MAILSPIKE_POSSIBLE(0.00)[175.208.85.209.rep.mailspike.net : 127.0.0.17]; R_DKIM_NA(0.00)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; FROM_NEQ_ENVFROM(0.00)[erj@freebsd.org,ricera10@gmail.com]; RCVD_TLS_ALL(0.00)[] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Jan 2020 21:44:59 -0000 On Wed, Jan 29, 2020 at 1:41 PM Hans Petter Selasky wrote: > On 2020-01-29 22:30, Eric Joyner wrote: > > Hi freebsd-net, > > > > We've encountered an issue with unloading the iavf(4) driver on FreeBSD > > 12.1 (and stable). On a VM with two iavf(4) interfaces, if we send heavy > > traffic to iavf1 and try to kldunload the driver, the kldunload process > > hangs on iavf0 until iavf1 stops receiving traffic. > > > > After some debugging, it looks like epoch_drain_callbacks() [via > > if_detach_internal()] tries to switch CPUs to run on one that iavf1 is > > using for RX processing, but since iavf1 is busy, it can't make the > switch, > > so cpu_switch() just hangs and nothing happens until iavf1's RX thread > > stops being busy. > > > > I can work around this by inserting a kern_yield(PRI_USER) somewhere in > one > > of the iavf txrx functions that iflib calls into (e.g. > > iavf_isc_rxd_available), but that's not a proper fix. Does anyone know > what > > to do to prevent this from happening? > > > > Wildly guessing, does maybe epoch_drain_callbacks() need a higher > priority > > than the PI_SOFT used in the group taskqueues used in iflib's RX > processing? > > > > Hi, > > Which scheduler is this? ULE or BSD? > > EPOCH(9) expects some level of round-robin scheduling on the same > priority level. Setting a higher priority on EPOCH(9) might cause epoch > to start spinning w/o letting the lower priority thread which holds the > EPOCH() section to finish. > > --HPS > > Hi Hans, kern.sched.name gives me "ULE" - Eric From owner-freebsd-net@freebsd.org Wed Jan 29 23:06:16 2020 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 443D71FB2B3 for ; Wed, 29 Jan 2020 23:06:16 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id 487Jy014CYz4LNl for ; Wed, 29 Jan 2020 23:06:16 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id 22CED1FB2B1; Wed, 29 Jan 2020 23:06:16 +0000 (UTC) Delivered-To: net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 228F71FB2B0 for ; Wed, 29 Jan 2020 23:06:16 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 487Jy00BT7z4LNk for ; Wed, 29 Jan 2020 23:06:16 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id F1E361BAF6 for ; Wed, 29 Jan 2020 23:06:15 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 00TN6F2g037134 for ; Wed, 29 Jan 2020 23:06:15 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 00TN6FLG037131 for net@FreeBSD.org; Wed, 29 Jan 2020 23:06:15 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: net@FreeBSD.org Subject: [Bug 242270] if_vlan(4): Network stack leaks ifnet references when creating VLAN Date: Wed, 29 Jan 2020 23:06:16 +0000 X-Bugzilla-Reason: AssignedTo CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: patch X-Bugzilla-Severity: Affects Many People X-Bugzilla-Who: koobs@FreeBSD.org X-Bugzilla-Status: In Progress X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: melifaro@FreeBSD.org X-Bugzilla-Flags: mfc-stable12? mfc-stable11? X-Bugzilla-Changed-Fields: assigned_to keywords bug_status Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Jan 2020 23:06:16 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D242270 Kubilay Kocak changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|net@FreeBSD.org |melifaro@FreeBSD.org Keywords|needs-qa | Status|Open |In Progress --=20 You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug.= From owner-freebsd-net@freebsd.org Thu Jan 30 00:58:17 2020 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 616A21FE68C for ; Thu, 30 Jan 2020 00:58:17 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (mailman.nyi.freebsd.org [IPv6:2610:1c1:1:606c::50:13]) by mx1.freebsd.org (Postfix) with ESMTP id 487MRF1z8Dz4RRK for ; Thu, 30 Jan 2020 00:58:17 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id 43ABA1FE68B; Thu, 30 Jan 2020 00:58:17 +0000 (UTC) Delivered-To: net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 4371F1FE68A for ; Thu, 30 Jan 2020 00:58:17 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 487MRF17NVz4RRH for ; Thu, 30 Jan 2020 00:58:17 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 2242B1CEE1 for ; Thu, 30 Jan 2020 00:58:17 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 00U0wHF4036062 for ; Thu, 30 Jan 2020 00:58:17 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 00U0wHlR036061 for net@FreeBSD.org; Thu, 30 Jan 2020 00:58:17 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: net@FreeBSD.org Subject: [Bug 243712] vxlan setup mtu according parent interface when cloning Date: Thu, 30 Jan 2020 00:58:14 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: patch X-Bugzilla-Severity: Affects Many People X-Bugzilla-Who: linimon@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: net@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: assigned_to keywords Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 30 Jan 2020 00:58:17 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D243712 Mark Linimon changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|bugs@FreeBSD.org |net@FreeBSD.org Keywords| |patch --=20 You are receiving this mail because: You are the assignee for the bug.= From owner-freebsd-net@freebsd.org Thu Jan 30 01:12:17 2020 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id DEEA71FF0D0 for ; Thu, 30 Jan 2020 01:12:17 +0000 (UTC) (envelope-from hps@selasky.org) Received: from mail.turbocat.net (turbocat.net [IPv6:2a01:4f8:c17:6c4b::2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 487MlP5DFFz4SMn; Thu, 30 Jan 2020 01:12:17 +0000 (UTC) (envelope-from hps@selasky.org) Received: from hps2020.home.selasky.org (unknown [62.141.129.235]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by mail.turbocat.net (Postfix) with ESMTPSA id 1A2A72600DC; Thu, 30 Jan 2020 02:12:13 +0100 (CET) Subject: Re: Issue with epoch_drain_callbacks and unloading iavf(4) [using iflib] To: Eric Joyner Cc: freebsd-net@freebsd.org References: <0e2e97f2-df75-3c6f-9bdd-e8c2ab7bf79e@selasky.org> From: Hans Petter Selasky Message-ID: Date: Thu, 30 Jan 2020 02:12:05 +0100 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:68.0) Gecko/20100101 Thunderbird/68.3.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 487MlP5DFFz4SMn X-Spamd-Bar: ----- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-6.00 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-0.999,0]; REPLY(-4.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0] X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 30 Jan 2020 01:12:17 -0000 On 2020-01-29 22:44, Eric Joyner wrote: > On Wed, Jan 29, 2020 at 1:41 PM Hans Petter Selasky wrote: > >> On 2020-01-29 22:30, Eric Joyner wrote: >>> Hi freebsd-net, >>> >>> We've encountered an issue with unloading the iavf(4) driver on FreeBSD >>> 12.1 (and stable). On a VM with two iavf(4) interfaces, if we send heavy >>> traffic to iavf1 and try to kldunload the driver, the kldunload process >>> hangs on iavf0 until iavf1 stops receiving traffic. >>> >>> After some debugging, it looks like epoch_drain_callbacks() [via >>> if_detach_internal()] tries to switch CPUs to run on one that iavf1 is >>> using for RX processing, but since iavf1 is busy, it can't make the >> switch, >>> so cpu_switch() just hangs and nothing happens until iavf1's RX thread >>> stops being busy. >>> >>> I can work around this by inserting a kern_yield(PRI_USER) somewhere in >> one >>> of the iavf txrx functions that iflib calls into (e.g. >>> iavf_isc_rxd_available), but that's not a proper fix. Does anyone know >> what >>> to do to prevent this from happening? >>> >>> Wildly guessing, does maybe epoch_drain_callbacks() need a higher >> priority >>> than the PI_SOFT used in the group taskqueues used in iflib's RX >> processing? >>> >> >> Hi, >> >> Which scheduler is this? ULE or BSD? >> >> EPOCH(9) expects some level of round-robin scheduling on the same >> priority level. Setting a higher priority on EPOCH(9) might cause epoch >> to start spinning w/o letting the lower priority thread which holds the >> EPOCH() section to finish. >> >> --HPS >> >> > Hi Hans, > > kern.sched.name gives me "ULE" > Hi Eric, epoch_drain_callbacks() depends on that epoch_call_task() gets execution which is executed from a GTASKQUEUE at PI_SOFT. Also epoch_drain_callbacks() runs at the priority of the calling thread, and if this is lower than PI_SOFT, and a gtaskqueue is spinning heavily, then that won't work. For a single CPU system you will be toast in this situation regardless if there is no free time on a CPU for EPOCH(). In general if epoch_call_task() doesn't get execution time, you will have a problem. Maybe add a flag to iflib which stops the grouptask's before detaching the network interface? --HPS From owner-freebsd-net@freebsd.org Thu Jan 30 01:29:10 2020 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 515DF1FF5CE for ; Thu, 30 Jan 2020 01:29:10 +0000 (UTC) (envelope-from ricera10@gmail.com) Received: from mail-qk1-f173.google.com (mail-qk1-f173.google.com [209.85.222.173]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 487N6s2H0hz4Ss5 for ; Thu, 30 Jan 2020 01:29:08 +0000 (UTC) (envelope-from ricera10@gmail.com) Received: by mail-qk1-f173.google.com with SMTP id g195so1345600qke.13 for ; Wed, 29 Jan 2020 17:29:08 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=GLI5xkKWCiGcMn9+w09d44JdZaA+pfei5ltHUrP1CWs=; b=B8rj0BzTVIN0ygyTHIyuKZr6BdRVwneFr2dsOZXc4HXIvWt7c3xcOyW5tdm4bQ93WL fqo01gc5Og2QoxNVSUUtwVDLGfQL5UHoeLV8GFdC1tPNBPRk4FmBBVUflkypM9TwYtcj WL1sYEQ4Dnn2VXQPHpcpwMNd/3V+D7Cgdbf3ngPlT3cXTdVLxk+GI5qaL7xviUaKZSMK 5NBhKIi+YwsHnttdI9tvwLUXZFn7BpTC8QlENgP4/9NW/7zhi07/CANXXw7PiK1ZxYXL WbgmLyyX6EN+BJY8nT1jswpkIrR5qauzlpdyQYNRmZdFccwmlmrKD/3g043V6CLBnfFN LOBw== X-Gm-Message-State: APjAAAURgwnL5CH9JQoZaNGPEaxNwQSmS5DrrdcaRbOQ/Bpc3g5bY7qV 80l5PsqSu/YSMRsgq0FOrE1nM+3mJuo= X-Google-Smtp-Source: APXvYqycakIl97r5eDIJ3Z4CHAReQXLPUDRyrmwLFeJhKum+f0xjoWtCN3/ffS7mNdBlEihQrksB7Q== X-Received: by 2002:ae9:c205:: with SMTP id j5mr2807274qkg.58.1580347747977; Wed, 29 Jan 2020 17:29:07 -0800 (PST) Received: from mail-qk1-f170.google.com (mail-qk1-f170.google.com. [209.85.222.170]) by smtp.gmail.com with ESMTPSA id s20sm1913228qkg.131.2020.01.29.17.29.07 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 29 Jan 2020 17:29:07 -0800 (PST) Received: by mail-qk1-f170.google.com with SMTP id w25so1423677qki.3 for ; Wed, 29 Jan 2020 17:29:07 -0800 (PST) X-Received: by 2002:ae9:e892:: with SMTP id a140mr2825142qkg.47.1580347747208; Wed, 29 Jan 2020 17:29:07 -0800 (PST) MIME-Version: 1.0 References: <0e2e97f2-df75-3c6f-9bdd-e8c2ab7bf79e@selasky.org> In-Reply-To: From: Eric Joyner Date: Wed, 29 Jan 2020 17:28:31 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: Issue with epoch_drain_callbacks and unloading iavf(4) [using iflib] To: Hans Petter Selasky Cc: freebsd-net@freebsd.org X-Rspamd-Queue-Id: 487N6s2H0hz4Ss5 X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of ricera10@gmail.com designates 209.85.222.173 as permitted sender) smtp.mailfrom=ricera10@gmail.com X-Spamd-Result: default: False [-2.54 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip4:209.85.128.0/17]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; PREVIOUSLY_DELIVERED(0.00)[freebsd-net@freebsd.org]; DMARC_NA(0.00)[freebsd.org]; URI_COUNT_ODD(1.00)[5]; RCVD_COUNT_THREE(0.00)[4]; MIME_TRACE(0.00)[0:+,1:+,2:~]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCPT_COUNT_TWO(0.00)[2]; RCVD_IN_DNSWL_NONE(0.00)[173.222.85.209.list.dnswl.org : 127.0.5.0]; IP_SCORE(-1.54)[ip: (-2.84), ipnet: 209.85.128.0/17(-3.05), asn: 15169(-1.78), country: US(-0.05)]; FORGED_SENDER(0.30)[erj@freebsd.org,ricera10@gmail.com]; RWL_MAILSPIKE_POSSIBLE(0.00)[173.222.85.209.rep.mailspike.net : 127.0.0.17]; R_DKIM_NA(0.00)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; FROM_NEQ_ENVFROM(0.00)[erj@freebsd.org,ricera10@gmail.com]; RCVD_TLS_ALL(0.00)[] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 30 Jan 2020 01:29:10 -0000 On Wed, Jan 29, 2020 at 5:12 PM Hans Petter Selasky wrote: > On 2020-01-29 22:44, Eric Joyner wrote: > > On Wed, Jan 29, 2020 at 1:41 PM Hans Petter Selasky > wrote: > > > >> On 2020-01-29 22:30, Eric Joyner wrote: > >>> Hi freebsd-net, > >>> > >>> We've encountered an issue with unloading the iavf(4) driver on FreeBSD > >>> 12.1 (and stable). On a VM with two iavf(4) interfaces, if we send > heavy > >>> traffic to iavf1 and try to kldunload the driver, the kldunload process > >>> hangs on iavf0 until iavf1 stops receiving traffic. > >>> > >>> After some debugging, it looks like epoch_drain_callbacks() [via > >>> if_detach_internal()] tries to switch CPUs to run on one that iavf1 is > >>> using for RX processing, but since iavf1 is busy, it can't make the > >> switch, > >>> so cpu_switch() just hangs and nothing happens until iavf1's RX thread > >>> stops being busy. > >>> > >>> I can work around this by inserting a kern_yield(PRI_USER) somewhere in > >> one > >>> of the iavf txrx functions that iflib calls into (e.g. > >>> iavf_isc_rxd_available), but that's not a proper fix. Does anyone know > >> what > >>> to do to prevent this from happening? > >>> > >>> Wildly guessing, does maybe epoch_drain_callbacks() need a higher > >> priority > >>> than the PI_SOFT used in the group taskqueues used in iflib's RX > >> processing? > >>> > >> > >> Hi, > >> > >> Which scheduler is this? ULE or BSD? > >> > >> EPOCH(9) expects some level of round-robin scheduling on the same > >> priority level. Setting a higher priority on EPOCH(9) might cause epoch > >> to start spinning w/o letting the lower priority thread which holds the > >> EPOCH() section to finish. > >> > >> --HPS > >> > >> > > Hi Hans, > > > > kern.sched.name gives me "ULE" > > > > Hi Eric, > > epoch_drain_callbacks() depends on that epoch_call_task() gets execution > which is executed from a GTASKQUEUE at PI_SOFT. Also > epoch_drain_callbacks() runs at the priority of the calling thread, and > if this is lower than PI_SOFT, and a gtaskqueue is spinning heavily, > then that won't work. > > For a single CPU system you will be toast in this situation regardless > if there is no free time on a CPU for EPOCH(). > > In general if epoch_call_task() doesn't get execution time, you will > have a problem. > > Maybe add a flag to iflib which stops the grouptask's before detaching > the network interface? > > --HPS > _______________________________________________ > freebsd-net@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/freebsd-net > To unsubscribe, send any mail to "freebsd-net-unsubscribe@freebsd.org" > Hi Hans, Maybe add a flag to iflib which stops the grouptask's before detaching > the network interface? That was something we considered, but it only seemed like that would work for kldunload. This would result in undesired behavior if you used "devctl detach iavf0" to just remove iavf0, and didn't expect that to affect iavf1. But, if stopping traffic on iavf1 in order to unload iavf0 is acceptable, then that might be a solution. - Eric From owner-freebsd-net@freebsd.org Thu Jan 30 03:09:21 2020 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 1A343229D9E for ; Thu, 30 Jan 2020 03:09:21 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: from mail-qt1-x843.google.com (mail-qt1-x843.google.com [IPv6:2607:f8b0:4864:20::843]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 487QLR6ftmz4YvL; Thu, 30 Jan 2020 03:09:19 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: by mail-qt1-x843.google.com with SMTP id l19so1315030qtq.8; Wed, 29 Jan 2020 19:09:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=KEG8gEYTl5AW4Emi6WOyAMRuvBVOJlYDAOBiQ3fye3I=; b=V5MDkm1HLp81L9XHt2Lof7LqPlRV43D1vwv/Kq3Ar5phgaNAH4+1SgITT4mmI/Qq6J 1FjY8y++qtJ79iSYWEOA/EqJt4QBT80wBw4z1V/XtAfa7+//Cc872FlygEtOOgE8dzaq 4/8PzCHC7moSSBIPXCbRsNIkHp7FDv1bbhC11r3qX3U0MXFNI8rh/dqFsYNyniRXJA13 eJdJHgO43tbgOf9PPQnz7APohV3h5FPjF08kxc6Ha8t7U7xRbnBB94iXgXMJl2IxJDsB LOTpuKLjqHaMjRaIpk/3FjK20IcJ3TLqH46xVfCraJEYJKtS+SnaX+jJnSUdtkG2WTij MyIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to; bh=KEG8gEYTl5AW4Emi6WOyAMRuvBVOJlYDAOBiQ3fye3I=; b=UuuqpXdvimq/JQ5IJ2bW58I/KLa2OFUuueBIbcXElKMwm6mCSZ3Qe/BCWYYhSrwpET RKpRAjo+97tAxJ57G3JLsoG+UZiDAv9LK/5jm1vXSwuSw235zutxbbzhaTjE58LsPdG5 tzBjActvkNc+eKgTmlBZGnt16ov4UnsagZCBLLqd+YMRbDYTtcmOM8FtnLdA/GS+Sve+ ZAYVB7xSUGnxdVM06gn0leNyRi18wA/1/Zl4YRTxOV3fgFzOAoIXJQrO/V+WotHUPWVE RkczRFZnp4Th/OketS4Jt47xAzc2/NSoybBj4Wf6we9f+51zPGqz/Gv/joFOHS+04dgb b9AA== X-Gm-Message-State: APjAAAU5Y3oSpVzrpuvajPFj9I9sNBAWEjXUfISog3ha69bqiLrKy+sG o9cziUyfp4XF/SYmbM8n6rgfQ2QS X-Google-Smtp-Source: APXvYqyOZW+jUWLmmpthgAjCycoHjMQSoLGcOBozA+UhumRNYtRJakkl71kwsH0Jj08TKCYbAX4uhA== X-Received: by 2002:ac8:4e94:: with SMTP id 20mr2679575qtp.335.1580353758534; Wed, 29 Jan 2020 19:09:18 -0800 (PST) Received: from spy (dhcp-108-168-17-189.cable.user.start.ca. [108.168.17.189]) by smtp.gmail.com with ESMTPSA id s48sm2229873qtc.96.2020.01.29.19.09.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Jan 2020 19:09:17 -0800 (PST) Sender: Mark Johnston Date: Wed, 29 Jan 2020 22:09:11 -0500 From: Mark Johnston To: Hans Petter Selasky Cc: Eric Joyner , freebsd-net@freebsd.org Subject: Re: Issue with epoch_drain_callbacks and unloading iavf(4) [using iflib] Message-ID: <20200130030911.GA15281@spy> References: <0e2e97f2-df75-3c6f-9bdd-e8c2ab7bf79e@selasky.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 487QLR6ftmz4YvL X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20161025 header.b=V5MDkm1H; dmarc=none; spf=pass (mx1.freebsd.org: domain of markjdb@gmail.com designates 2607:f8b0:4864:20::843 as permitted sender) smtp.mailfrom=markjdb@gmail.com X-Spamd-Result: default: False [-2.03 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20161025]; NEURAL_HAM_MEDIUM(-1.00)[-0.995,0]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36]; NEURAL_HAM_LONG(-0.99)[-0.986,0]; MIME_GOOD(-0.10)[text/plain]; MIME_TRACE(0.00)[0:+]; DMARC_NA(0.00)[freebsd.org]; TO_DN_SOME(0.00)[]; RCVD_COUNT_THREE(0.00)[3]; TO_MATCH_ENVRCPT_SOME(0.00)[]; DKIM_TRACE(0.00)[gmail.com:+]; RCVD_IN_DNSWL_NONE(0.00)[3.4.8.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; IP_SCORE(-0.35)[ip: (2.13), ipnet: 2607:f8b0::/32(-2.03), asn: 15169(-1.78), country: US(-0.05)]; FORGED_SENDER(0.30)[markj@freebsd.org,markjdb@gmail.com]; MID_RHS_NOT_FQDN(0.50)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; FROM_NEQ_ENVFROM(0.00)[markj@freebsd.org,markjdb@gmail.com]; RCVD_TLS_ALL(0.00)[] X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 30 Jan 2020 03:09:21 -0000 On Thu, Jan 30, 2020 at 02:12:05AM +0100, Hans Petter Selasky wrote: > On 2020-01-29 22:44, Eric Joyner wrote: > > On Wed, Jan 29, 2020 at 1:41 PM Hans Petter Selasky wrote: > > > > > On 2020-01-29 22:30, Eric Joyner wrote: > > > > Hi freebsd-net, > > > > > > > > We've encountered an issue with unloading the iavf(4) driver on FreeBSD > > > > 12.1 (and stable). On a VM with two iavf(4) interfaces, if we send heavy > > > > traffic to iavf1 and try to kldunload the driver, the kldunload process > > > > hangs on iavf0 until iavf1 stops receiving traffic. > > > > > > > > After some debugging, it looks like epoch_drain_callbacks() [via > > > > if_detach_internal()] tries to switch CPUs to run on one that iavf1 is > > > > using for RX processing, but since iavf1 is busy, it can't make the > > > switch, > > > > so cpu_switch() just hangs and nothing happens until iavf1's RX thread > > > > stops being busy. > > > > > > > > I can work around this by inserting a kern_yield(PRI_USER) somewhere in > > > one > > > > of the iavf txrx functions that iflib calls into (e.g. > > > > iavf_isc_rxd_available), but that's not a proper fix. Does anyone know > > > what > > > > to do to prevent this from happening? > > > > > > > > Wildly guessing, does maybe epoch_drain_callbacks() need a higher > > > priority > > > > than the PI_SOFT used in the group taskqueues used in iflib's RX > > > processing? > > > > > > > > > > Hi, > > > > > > Which scheduler is this? ULE or BSD? > > > > > > EPOCH(9) expects some level of round-robin scheduling on the same > > > priority level. Setting a higher priority on EPOCH(9) might cause epoch > > > to start spinning w/o letting the lower priority thread which holds the > > > EPOCH() section to finish. > > > > > > --HPS > > > > > > > > Hi Hans, > > > > kern.sched.name gives me "ULE" > > > > Hi Eric, > > epoch_drain_callbacks() depends on that epoch_call_task() gets execution > which is executed from a GTASKQUEUE at PI_SOFT. Also epoch_drain_callbacks() > runs at the priority of the calling thread, and if this is lower than > PI_SOFT, and a gtaskqueue is spinning heavily, then that won't work. I think we can fix this so that the epoch_drain_callbacks() caller's priority does not matter. Eric, can you try the patch below? It is a bit hacky, but the idea is to ensure that all pending callbacks can be invoked, and then wait for each cb task to run though at least once. In your case I think the callback task threads should still be able to run. > For a single CPU system you will be toast in this situation regardless if > there is no free time on a CPU for EPOCH(). > > In general if epoch_call_task() doesn't get execution time, you will have a > problem. That's not the issue here, though there is at least one related problem: if a thread in an epoch read section is preempted and the CPU is consumed by a high priority receive processing thread, for example due to a DOS, we have no mechanism to boost the priority of the preempted thread except by calling epoch_synchronize_wait(). In other words, nothing guarantees that deferred callbacks will eventually get executed in such a scenario. diff --git a/sys/kern/subr_epoch.c b/sys/kern/subr_epoch.c index 0a477e1d6f7b..4ed7e7e11a3e 100644 --- a/sys/kern/subr_epoch.c +++ b/sys/kern/subr_epoch.c @@ -74,15 +74,19 @@ typedef struct epoch_record { volatile struct epoch_tdlist er_tdlist; volatile uint32_t er_gen; uint32_t er_cpuid; + int er_drain_state; } __aligned(EPOCH_ALIGN) *epoch_record_t; +#define EPOCH_DRAIN_START 2 +#define EPOCH_DRAIN_RUNNING 1 +#define EPOCH_DRAIN_DONE 0 + struct epoch { struct ck_epoch e_epoch __aligned(EPOCH_ALIGN); epoch_record_t e_pcpu_record; int e_idx; int e_flags; struct sx e_drain_sx; - struct mtx e_drain_mtx; volatile int e_drain_count; const char *e_name; }; @@ -335,7 +339,6 @@ epoch_alloc(const char *name, int flags) epoch->e_idx = epoch_count; epoch->e_name = name; sx_init(&epoch->e_drain_sx, "epoch-drain-sx"); - mtx_init(&epoch->e_drain_mtx, "epoch-drain-mtx", NULL, MTX_DEF); allepochs[epoch_count++] = epoch; return (epoch); } @@ -348,7 +351,6 @@ epoch_free(epoch_t epoch) allepochs[epoch->e_idx] = NULL; epoch_wait(global_epoch); uma_zfree_pcpu(pcpu_zone_record, epoch->e_pcpu_record); - mtx_destroy(&epoch->e_drain_mtx); sx_destroy(&epoch->e_drain_sx); free(epoch, M_EPOCH); } @@ -699,14 +701,24 @@ epoch_call_task(void *arg __unused) epoch_t epoch; ck_stack_t cb_stack; int i, npending, total; + bool draining; + + KASSERT(curthread->td_pinned > 0, + ("%s: callback task thread is not pinned", __func__)); ck_stack_init(&cb_stack); critical_enter(); epoch_enter(global_epoch); - for (total = i = 0; i < epoch_count; i++) { + for (total = i = 0, draining = false; i < epoch_count; i++) { if (__predict_false((epoch = allepochs[i]) == NULL)) continue; er = epoch_currecord(epoch); + if (atomic_load_int(&er->er_drain_state) == EPOCH_DRAIN_START) { + atomic_store_int(&er->er_drain_state, + EPOCH_DRAIN_RUNNING); + draining = true; + } + record = &er->er_record; if ((npending = record->n_pending) == 0) continue; @@ -728,6 +740,20 @@ epoch_call_task(void *arg __unused) next = CK_STACK_NEXT(cursor); entry->function(entry); } + + if (__predict_false(draining)) { + epoch_enter(global_epoch); + for (i = 0; i < epoch_count; i++) { + if (__predict_false((epoch = allepochs[i]) == NULL)) + continue; + er = epoch_currecord(epoch); + if (atomic_load_int(&er->er_drain_state) == + EPOCH_DRAIN_RUNNING) + atomic_store_int(&er->er_drain_state, + EPOCH_DRAIN_DONE); + } + epoch_exit(global_epoch); + } } int @@ -769,27 +795,18 @@ in_epoch(epoch_t epoch) } static void -epoch_drain_cb(struct epoch_context *ctx) +epoch_drain_handler(struct ck_epoch *global __unused, + ck_epoch_record_t *cr __unused, void *arg __unused) { - struct epoch *epoch = - __containerof(ctx, struct epoch_record, er_drain_ctx)->er_parent; - - if (atomic_fetchadd_int(&epoch->e_drain_count, -1) == 1) { - mtx_lock(&epoch->e_drain_mtx); - wakeup(epoch); - mtx_unlock(&epoch->e_drain_mtx); - } + maybe_yield(); } void epoch_drain_callbacks(epoch_t epoch) { epoch_record_t er; - struct thread *td; - int was_bound; - int old_pinned; - int old_cpu; - int cpu; + int cpu, state; + bool pending; WITNESS_WARN(WARN_GIANTOK | WARN_SLEEPOK, NULL, "epoch_drain_callbacks() may sleep!"); @@ -802,45 +819,28 @@ epoch_drain_callbacks(epoch_t epoch) return; #endif DROP_GIANT(); - sx_xlock(&epoch->e_drain_sx); - mtx_lock(&epoch->e_drain_mtx); - td = curthread; - thread_lock(td); - old_cpu = PCPU_GET(cpuid); - old_pinned = td->td_pinned; - was_bound = sched_is_bound(td); - sched_unbind(td); - td->td_pinned = 0; + /* Make sure that all pending callbacks are available. */ + ck_epoch_synchronize_wait(&epoch->e_epoch, epoch_drain_handler, NULL); - CPU_FOREACH(cpu) - epoch->e_drain_count++; CPU_FOREACH(cpu) { er = zpcpu_get_cpu(epoch->e_pcpu_record, cpu); - sched_bind(td, cpu); - epoch_call(epoch, &epoch_drain_cb, &er->er_drain_ctx); + atomic_store_int(&er->er_drain_state, EPOCH_DRAIN_START); + GROUPTASK_ENQUEUE(DPCPU_ID_PTR(cpu, epoch_cb_task)); } - /* restore CPU binding, if any */ - if (was_bound != 0) { - sched_bind(td, old_cpu); - } else { - /* get thread back to initial CPU, if any */ - if (old_pinned != 0) - sched_bind(td, old_cpu); - sched_unbind(td); - } - /* restore pinned after bind */ - td->td_pinned = old_pinned; - - thread_unlock(td); - - while (epoch->e_drain_count != 0) - msleep(epoch, &epoch->e_drain_mtx, PZERO, "EDRAIN", 0); + do { + pending = false; + CPU_FOREACH(cpu) { + er = zpcpu_get_cpu(epoch->e_pcpu_record, cpu); + state = atomic_load_int(&er->er_drain_state); + if (state != EPOCH_DRAIN_DONE) + pending = true; + } + pause("edrain", 1); + } while (pending); - mtx_unlock(&epoch->e_drain_mtx); sx_xunlock(&epoch->e_drain_sx); - PICKUP_GIANT(); } From owner-freebsd-net@freebsd.org Thu Jan 30 23:10:19 2020 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 116EB22AAA5 for ; Thu, 30 Jan 2020 23:10:19 +0000 (UTC) (envelope-from rmacklem@uoguelph.ca) Received: from CAN01-QB1-obe.outbound.protection.outlook.com (mail-eopbgr660060.outbound.protection.outlook.com [40.107.66.60]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mail.protection.outlook.com", Issuer "GlobalSign Organization Validation CA - SHA256 - G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 487x0B03M6z3JvZ for ; Thu, 30 Jan 2020 23:10:17 +0000 (UTC) (envelope-from rmacklem@uoguelph.ca) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TRtNCIPBayQYj50OBTJTwifO15s9+7IbNt359fHrIPB2u17/1mzTtADbtVWi6vKAr0iJRZorbpFfSuE0JWNl7RWd1dJYyEF2hGbpJtg+3xj6e4JqYk9TnSY7wwkq97BI4mQQ1fmCR2fS5jo1EwjXF1VxP81UsDjU7Yb6PsFQ8GcIl6HZsAm0N8KySnZFmrF4xQCuXAK8Yl3qzYn7kTGqRZE4+GSFZsQomkfTD0XAUuZwcIAJS34nOSxnuN+G5rWYGaKADonlp4pQFSQDjc46ATvZNmbq6nVwXKkfHCMXpc8UkFuw2WeXk/lC06QzUI695chdksi+wyzPVLzGMRKo+g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LSai98NsFfuBYjnczVKr8f4NIf+kCneWcCjD0QO5WGM=; b=lH/2oXTfrQsy0U9aepgNCpWxl72QJtv1Vs8rAGqEwszBINMDl93WA1DXoCa9/borkC92CM5QA8ClaIZ2eZ1IRsLwTAM8m3PSvHJMjp+oqGNTCBQx6aTyr7InnWsviTh0kyifVcSfyBzHv+glC3BCXYsKEh+YGDUZkEiKDRvzA2kKH4B7zDz0jGGwFCiv6uacC17VIXzklC7sKDm/gsv/bOWzYiKkVyp+HWtaM5xj4GO3qzbHfJ5msZfXmkRhb4KACtO+rS6hz/8n3vN8/LIQiDSM0HCCUvg6nqgRrgODnxVQc5ixUziSkWTW79wKInoO1xOpVpoPSja8YG2vOSnhqA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=uoguelph.ca; dmarc=pass action=none header.from=uoguelph.ca; dkim=pass header.d=uoguelph.ca; arc=none Received: from YTBPR01MB3374.CANPRD01.PROD.OUTLOOK.COM (10.255.46.82) by YTBPR01MB2416.CANPRD01.PROD.OUTLOOK.COM (10.255.13.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2665.22; Thu, 30 Jan 2020 23:10:16 +0000 Received: from YTBPR01MB3374.CANPRD01.PROD.OUTLOOK.COM ([fe80::410e:652b:6fbc:9aa4]) by YTBPR01MB3374.CANPRD01.PROD.OUTLOOK.COM ([fe80::410e:652b:6fbc:9aa4%3]) with mapi id 15.20.2686.025; Thu, 30 Jan 2020 23:10:16 +0000 From: Rick Macklem To: freebsd-net Subject: NFS performance depends on low latency reception of small TCP segments Thread-Topic: NFS performance depends on low latency reception of small TCP segments Thread-Index: AQHV18GQFrKXcHa270y7CKj+bcj9Ug== Date: Thu, 30 Jan 2020 23:10:16 +0000 Message-ID: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: a14bbe21-5293-4f7e-576a-08d7a5d9916d x-ms-traffictypediagnostic: YTBPR01MB2416: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-forefront-prvs: 02981BE340 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(366004)(189003)(199004)(8936002)(4744005)(8676002)(81166006)(81156014)(6916009)(26005)(2906002)(186003)(6506007)(5660300002)(9686003)(52536014)(7696005)(86362001)(66446008)(76116006)(71200400001)(33656002)(55016002)(498600001)(64756008)(66476007)(66556008)(66946007)(91956017); DIR:OUT; SFP:1101; SCL:1; SRVR:YTBPR01MB2416; H:YTBPR01MB3374.CANPRD01.PROD.OUTLOOK.COM; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: uoguelph.ca does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: B9Q54MSQIC356Npi6ZzQapdDtOyX1P/u8zsW58h/W/ImD31e4CE9CSAEqJWxwSFrdYoYkq5FZJsGzqtJXc1mI9rTCNGuc6QgkJ0E8BnRG2oYdQGWyzQYwOlelT8hqRCx81MiLhN70hh6bT3/vRal31FF2qzQp/Ayy7xDuQNIpalvF361HKCrLmoa5inCeLbJmh3uINz2B6c9fQ2+7VJ/F7g2SGqM6csGYv6GOfBQu380SGPU3Y6wVULrKjeVRI+WdOQ9R/CZ3E4MixNVKTLytua4XK/RqumLskh46nFaY63n6tfQv3UuZ9BIGvjRPhxCX9EbRCqFWe5XpzItk9QGukiXBhWxGLgCfJAg8qmOtheb2hXRpeC4qGiz+rPgNZYfk1eiDdlYQs+/CosA2aPHFyIyE/I1UklaFxOIDYGrlQt6fiHGLGmkXSfcmrTrKb4o x-ms-exchange-antispam-messagedata: x058lHgi26f63ipD9uGmoJZD9flKFsl+3QN1iszVZrpE0JqJDHXN0iRFlMIXoQHb3jGsefLo2/C+OA4IGRVsH6UeTdOKEluzcG/A3ADB524LlXAiZEec3De+/mF8lQo+XXBZGih2Dd3uSZbfgdOpgg== x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: uoguelph.ca X-MS-Exchange-CrossTenant-Network-Message-Id: a14bbe21-5293-4f7e-576a-08d7a5d9916d X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Jan 2020 23:10:16.1603 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: be62a12b-2cad-49a1-a5fa-85f4f3156a7d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: ZxdfCSHTiIIAmDAagN5zo4JrHT6KQYUA1RXWyrWjxS8I744MtntggUscR/Y+snmIpHh0GuDyaqBqOzqNA1qilQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: YTBPR01MB2416 X-Rspamd-Queue-Id: 487x0B03M6z3JvZ X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of rmacklem@uoguelph.ca designates 40.107.66.60 as permitted sender) smtp.mailfrom=rmacklem@uoguelph.ca X-Spamd-Result: default: False [-4.69 / 15.00]; RCVD_TLS_LAST(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; FROM_HAS_DN(0.00)[]; R_SPF_ALLOW(-0.20)[+ip4:40.107.0.0/16]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[uoguelph.ca]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; RCPT_COUNT_ONE(0.00)[1]; RCVD_COUNT_THREE(0.00)[3]; IP_SCORE(-1.39)[ipnet: 40.64.0.0/10(-3.85), asn: 8075(-3.06), country: US(-0.05)]; TO_DN_ALL(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[60.66.107.40.list.dnswl.org : 127.0.3.0]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:8075, ipnet:40.64.0.0/10, country:US]; ARC_ALLOW(-1.00)[i=1] X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 30 Jan 2020 23:10:19 -0000 Hi,=0A= =0A= I have seen recent discussion related to NET_EPOCH.=0A= This is way out of my expertise, but...=0A= =0A= NFS traffic is basically bi-directional small messages.=0A= If a change increases the latency of reception of a small=0A= message (TCP segment) which is not followed by further=0A= TCP segments in the same direction...=0A= --> A significant NFS performance hit could be observed.=0A= =0A= I don't have hardware that can do reasonable benchmarking,=0A= so if some else can test for NFS performance regressions=0A= when making TCP stack changes, it would be appreciated.=0A= --> The time it takes to do a fairly large build like a kernel=0A= or buildworld over NFS on fast hardware with fast networking=0A= would probably do it.=0A= =0A= Just wanted the people doing TCP stack work to be aware of this, rick=0A= From owner-freebsd-net@freebsd.org Fri Jan 31 19:45:10 2020 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 8AA621EAC04 for ; Fri, 31 Jan 2020 19:45:10 +0000 (UTC) (envelope-from ricera10@gmail.com) Received: from mail-qv1-f52.google.com (mail-qv1-f52.google.com [209.85.219.52]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 488SP03Cl5z48LS; Fri, 31 Jan 2020 19:45:08 +0000 (UTC) (envelope-from ricera10@gmail.com) Received: by mail-qv1-f52.google.com with SMTP id dp13so3819965qvb.7; Fri, 31 Jan 2020 11:45:08 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=GIoh4x3/LTC7BlaaOuR75SVYJRFzkSkc8OPz3etzNlc=; b=OWjyWeBLlonu5vnvr1plBbftZGHjkOX18DpiepIVneNO0hQy/apRydEXOPa8Q5lE+x 9H/2i4R8zwB1aXlDpO0BBldVUxFzdZUzTL3iTbtdmDDsE8bF92ETFC7hSMRd8+g7UmZP wD1aQwmjjRlAZfreu332HAJbKC1fi5OfCDQ1vZk3sKKbOsMhHhhLv6Jp2i9NHMavpa/4 5wBmI2Y29j9fYUC1m/8C7qIIHgmpCVmVNpgmwp1IfPp+YHiw5pV8h/E/3TGXxbSDLzDH hIe8lqOoPmOrmBkXPiTEjPAbgoxbgvAOFK6AlSev9wtR6v7A8VP91CfOrDwQqBjBVoL8 fNSg== X-Gm-Message-State: APjAAAXkLE0I0VWuAN9HQSsr+J1c40jobJf7eC4fS5lfAqN+HwEX/I+S piT4HE1lcvlA9ojgOL0zfnvuQx3i3SY= X-Google-Smtp-Source: APXvYqwFXtoXVRx1iPRneR2qqBqDDArGa9TqK2mU7cLCbwbes/mc3w2zfaC0tzvL+E7C2cc/H94NtA== X-Received: by 2002:ad4:4e73:: with SMTP id ec19mr11540504qvb.78.1580499906740; Fri, 31 Jan 2020 11:45:06 -0800 (PST) Received: from mail-qt1-f171.google.com (mail-qt1-f171.google.com. [209.85.160.171]) by smtp.gmail.com with ESMTPSA id y26sm5190275qtv.28.2020.01.31.11.45.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 31 Jan 2020 11:45:06 -0800 (PST) Received: by mail-qt1-f171.google.com with SMTP id w8so6313113qts.11; Fri, 31 Jan 2020 11:45:06 -0800 (PST) X-Received: by 2002:ac8:4445:: with SMTP id m5mr12509772qtn.124.1580499906039; Fri, 31 Jan 2020 11:45:06 -0800 (PST) MIME-Version: 1.0 References: <0e2e97f2-df75-3c6f-9bdd-e8c2ab7bf79e@selasky.org> <20200130030911.GA15281@spy> In-Reply-To: <20200130030911.GA15281@spy> From: Eric Joyner Date: Fri, 31 Jan 2020 11:44:30 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: Issue with epoch_drain_callbacks and unloading iavf(4) [using iflib] To: Mark Johnston Cc: Hans Petter Selasky , freebsd-net@freebsd.org X-Rspamd-Queue-Id: 488SP03Cl5z48LS X-Spamd-Bar: - Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of ricera10@gmail.com designates 209.85.219.52 as permitted sender) smtp.mailfrom=ricera10@gmail.com X-Spamd-Result: default: False [-1.97 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCVD_TLS_ALL(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; R_SPF_ALLOW(-0.20)[+ip4:209.85.128.0/17]; NEURAL_HAM_LONG(-1.00)[-0.999,0]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; DMARC_NA(0.00)[freebsd.org]; NEURAL_HAM_MEDIUM(-1.00)[-0.997,0]; TO_DN_SOME(0.00)[]; URI_COUNT_ODD(1.00)[5]; RCVD_COUNT_THREE(0.00)[4]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[52.219.85.209.list.dnswl.org : 127.0.5.0]; IP_SCORE(-0.97)[ipnet: 209.85.128.0/17(-3.05), asn: 15169(-1.77), country: US(-0.05)]; FORGED_SENDER(0.30)[erj@freebsd.org,ricera10@gmail.com]; RWL_MAILSPIKE_POSSIBLE(0.00)[52.219.85.209.rep.mailspike.net : 127.0.0.17]; MIME_TRACE(0.00)[0:+,1:+,2:~]; R_DKIM_NA(0.00)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; FROM_NEQ_ENVFROM(0.00)[erj@freebsd.org,ricera10@gmail.com] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 31 Jan 2020 19:45:10 -0000 On Wed, Jan 29, 2020 at 7:09 PM Mark Johnston wrote: > On Thu, Jan 30, 2020 at 02:12:05AM +0100, Hans Petter Selasky wrote: > > On 2020-01-29 22:44, Eric Joyner wrote: > > > On Wed, Jan 29, 2020 at 1:41 PM Hans Petter Selasky > wrote: > > > > > > > On 2020-01-29 22:30, Eric Joyner wrote: > > > > > Hi freebsd-net, > > > > > > > > > > We've encountered an issue with unloading the iavf(4) driver on > FreeBSD > > > > > 12.1 (and stable). On a VM with two iavf(4) interfaces, if we send > heavy > > > > > traffic to iavf1 and try to kldunload the driver, the kldunload > process > > > > > hangs on iavf0 until iavf1 stops receiving traffic. > > > > > > > > > > After some debugging, it looks like epoch_drain_callbacks() [via > > > > > if_detach_internal()] tries to switch CPUs to run on one that > iavf1 is > > > > > using for RX processing, but since iavf1 is busy, it can't make the > > > > switch, > > > > > so cpu_switch() just hangs and nothing happens until iavf1's RX > thread > > > > > stops being busy. > > > > > > > > > > I can work around this by inserting a kern_yield(PRI_USER) > somewhere in > > > > one > > > > > of the iavf txrx functions that iflib calls into (e.g. > > > > > iavf_isc_rxd_available), but that's not a proper fix. Does anyone > know > > > > what > > > > > to do to prevent this from happening? > > > > > > > > > > Wildly guessing, does maybe epoch_drain_callbacks() need a higher > > > > priority > > > > > than the PI_SOFT used in the group taskqueues used in iflib's RX > > > > processing? > > > > > > > > > > > > > Hi, > > > > > > > > Which scheduler is this? ULE or BSD? > > > > > > > > EPOCH(9) expects some level of round-robin scheduling on the same > > > > priority level. Setting a higher priority on EPOCH(9) might cause > epoch > > > > to start spinning w/o letting the lower priority thread which holds > the > > > > EPOCH() section to finish. > > > > > > > > --HPS > > > > > > > > > > > Hi Hans, > > > > > > kern.sched.name gives me "ULE" > > > > > > > Hi Eric, > > > > epoch_drain_callbacks() depends on that epoch_call_task() gets execution > > which is executed from a GTASKQUEUE at PI_SOFT. Also > epoch_drain_callbacks() > > runs at the priority of the calling thread, and if this is lower than > > PI_SOFT, and a gtaskqueue is spinning heavily, then that won't work. > > I think we can fix this so that the epoch_drain_callbacks() caller's > priority does not matter. Eric, can you try the patch below? It is a > bit hacky, but the idea is to ensure that all pending callbacks can be > invoked, and then wait for each cb task to run though at least once. In > your case I think the callback task threads should still be able to run. > > > For a single CPU system you will be toast in this situation regardless if > > there is no free time on a CPU for EPOCH(). > > > > In general if epoch_call_task() doesn't get execution time, you will > have a > > problem. > > That's not the issue here, though there is at least one related problem: > if a thread in an epoch read section is preempted and the CPU is > consumed by a high priority receive processing thread, for example due > to a DOS, we have no mechanism to boost the priority of the preempted > thread except by calling epoch_synchronize_wait(). In other words, > nothing guarantees that deferred callbacks will eventually get executed > in such a scenario. > > diff --git a/sys/kern/subr_epoch.c b/sys/kern/subr_epoch.c > index 0a477e1d6f7b..4ed7e7e11a3e 100644 > --- a/sys/kern/subr_epoch.c > +++ b/sys/kern/subr_epoch.c > @@ -74,15 +74,19 @@ typedef struct epoch_record { > volatile struct epoch_tdlist er_tdlist; > volatile uint32_t er_gen; > uint32_t er_cpuid; > + int er_drain_state; > } __aligned(EPOCH_ALIGN) *epoch_record_t; > > +#define EPOCH_DRAIN_START 2 > +#define EPOCH_DRAIN_RUNNING 1 > +#define EPOCH_DRAIN_DONE 0 > + > struct epoch { > struct ck_epoch e_epoch __aligned(EPOCH_ALIGN); > epoch_record_t e_pcpu_record; > int e_idx; > int e_flags; > struct sx e_drain_sx; > - struct mtx e_drain_mtx; > volatile int e_drain_count; > const char *e_name; > }; > @@ -335,7 +339,6 @@ epoch_alloc(const char *name, int flags) > epoch->e_idx = epoch_count; > epoch->e_name = name; > sx_init(&epoch->e_drain_sx, "epoch-drain-sx"); > - mtx_init(&epoch->e_drain_mtx, "epoch-drain-mtx", NULL, MTX_DEF); > allepochs[epoch_count++] = epoch; > return (epoch); > } > @@ -348,7 +351,6 @@ epoch_free(epoch_t epoch) > allepochs[epoch->e_idx] = NULL; > epoch_wait(global_epoch); > uma_zfree_pcpu(pcpu_zone_record, epoch->e_pcpu_record); > - mtx_destroy(&epoch->e_drain_mtx); > sx_destroy(&epoch->e_drain_sx); > free(epoch, M_EPOCH); > } > @@ -699,14 +701,24 @@ epoch_call_task(void *arg __unused) > epoch_t epoch; > ck_stack_t cb_stack; > int i, npending, total; > + bool draining; > + > + KASSERT(curthread->td_pinned > 0, > + ("%s: callback task thread is not pinned", __func__)); > > ck_stack_init(&cb_stack); > critical_enter(); > epoch_enter(global_epoch); > - for (total = i = 0; i < epoch_count; i++) { > + for (total = i = 0, draining = false; i < epoch_count; i++) { > if (__predict_false((epoch = allepochs[i]) == NULL)) > continue; > er = epoch_currecord(epoch); > + if (atomic_load_int(&er->er_drain_state) == > EPOCH_DRAIN_START) { > + atomic_store_int(&er->er_drain_state, > + EPOCH_DRAIN_RUNNING); > + draining = true; > + } > + > record = &er->er_record; > if ((npending = record->n_pending) == 0) > continue; > @@ -728,6 +740,20 @@ epoch_call_task(void *arg __unused) > next = CK_STACK_NEXT(cursor); > entry->function(entry); > } > + > + if (__predict_false(draining)) { > + epoch_enter(global_epoch); > + for (i = 0; i < epoch_count; i++) { > + if (__predict_false((epoch = allepochs[i]) == > NULL)) > + continue; > + er = epoch_currecord(epoch); > + if (atomic_load_int(&er->er_drain_state) == > + EPOCH_DRAIN_RUNNING) > + atomic_store_int(&er->er_drain_state, > + EPOCH_DRAIN_DONE); > + } > + epoch_exit(global_epoch); > + } > } > > int > @@ -769,27 +795,18 @@ in_epoch(epoch_t epoch) > } > > static void > -epoch_drain_cb(struct epoch_context *ctx) > +epoch_drain_handler(struct ck_epoch *global __unused, > + ck_epoch_record_t *cr __unused, void *arg __unused) > { > - struct epoch *epoch = > - __containerof(ctx, struct epoch_record, > er_drain_ctx)->er_parent; > - > - if (atomic_fetchadd_int(&epoch->e_drain_count, -1) == 1) { > - mtx_lock(&epoch->e_drain_mtx); > - wakeup(epoch); > - mtx_unlock(&epoch->e_drain_mtx); > - } > + maybe_yield(); > } > > void > epoch_drain_callbacks(epoch_t epoch) > { > epoch_record_t er; > - struct thread *td; > - int was_bound; > - int old_pinned; > - int old_cpu; > - int cpu; > + int cpu, state; > + bool pending; > > WITNESS_WARN(WARN_GIANTOK | WARN_SLEEPOK, NULL, > "epoch_drain_callbacks() may sleep!"); > @@ -802,45 +819,28 @@ epoch_drain_callbacks(epoch_t epoch) > return; > #endif > DROP_GIANT(); > - > sx_xlock(&epoch->e_drain_sx); > - mtx_lock(&epoch->e_drain_mtx); > > - td = curthread; > - thread_lock(td); > - old_cpu = PCPU_GET(cpuid); > - old_pinned = td->td_pinned; > - was_bound = sched_is_bound(td); > - sched_unbind(td); > - td->td_pinned = 0; > + /* Make sure that all pending callbacks are available. */ > + ck_epoch_synchronize_wait(&epoch->e_epoch, epoch_drain_handler, > NULL); > > - CPU_FOREACH(cpu) > - epoch->e_drain_count++; > CPU_FOREACH(cpu) { > er = zpcpu_get_cpu(epoch->e_pcpu_record, cpu); > - sched_bind(td, cpu); > - epoch_call(epoch, &epoch_drain_cb, &er->er_drain_ctx); > + atomic_store_int(&er->er_drain_state, EPOCH_DRAIN_START); > + GROUPTASK_ENQUEUE(DPCPU_ID_PTR(cpu, epoch_cb_task)); > } > > - /* restore CPU binding, if any */ > - if (was_bound != 0) { > - sched_bind(td, old_cpu); > - } else { > - /* get thread back to initial CPU, if any */ > - if (old_pinned != 0) > - sched_bind(td, old_cpu); > - sched_unbind(td); > - } > - /* restore pinned after bind */ > - td->td_pinned = old_pinned; > - > - thread_unlock(td); > - > - while (epoch->e_drain_count != 0) > - msleep(epoch, &epoch->e_drain_mtx, PZERO, "EDRAIN", 0); > + do { > + pending = false; > + CPU_FOREACH(cpu) { > + er = zpcpu_get_cpu(epoch->e_pcpu_record, cpu); > + state = atomic_load_int(&er->er_drain_state); > + if (state != EPOCH_DRAIN_DONE) > + pending = true; > + } > + pause("edrain", 1); > + } while (pending); > > - mtx_unlock(&epoch->e_drain_mtx); > sx_xunlock(&epoch->e_drain_sx); > - > PICKUP_GIANT(); > } > _______________________________________________ > freebsd-net@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/freebsd-net > To unsubscribe, send any mail to "freebsd-net-unsubscribe@freebsd.org" > Hi Mark, I applied your patch to a FreeBSD-current VM and reran the test I was running originally, and I still see the same behavior. Your patch doesn't appear to fix the problem. - Eric From owner-freebsd-net@freebsd.org Sat Feb 1 20:05:51 2020 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 8D16E22A2A0 for ; Sat, 1 Feb 2020 20:05:51 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (mailman.nyi.freebsd.org [IPv6:2610:1c1:1:606c::50:13]) by mx1.freebsd.org (Postfix) with ESMTP id 4894pR3GFHz40VH for ; Sat, 1 Feb 2020 20:05:51 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id 6FF9E22A29F; Sat, 1 Feb 2020 20:05:51 +0000 (UTC) Delivered-To: net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 6FC3622A29D for ; Sat, 1 Feb 2020 20:05:51 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4894pR2Qw9z40VF for ; Sat, 1 Feb 2020 20:05:51 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4ED8744FD for ; Sat, 1 Feb 2020 20:05:51 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 011K5pa9053253 for ; Sat, 1 Feb 2020 20:05:51 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 011K5pJ2053252 for net@FreeBSD.org; Sat, 1 Feb 2020 20:05:51 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: net@FreeBSD.org Subject: [Bug 166724] [re] if_re watchdog timeout Date: Sat, 01 Feb 2020 20:05:45 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 11.1-RELEASE X-Bugzilla-Keywords: needs-patch X-Bugzilla-Severity: Affects Many People X-Bugzilla-Who: bob@novanet.org X-Bugzilla-Status: In Progress X-Bugzilla-Resolution: X-Bugzilla-Priority: Normal X-Bugzilla-Assigned-To: yongari@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 01 Feb 2020 20:05:51 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D166724 --- Comment #42 from Bob Smith --- (In reply to Chris Hutchinson from comment #40) Could you share what specific values worked for you? My default values seem pretty high on FreeBSD 12.1. kern.ipc.nmbjumbop: 496998 kern.ipc.nmbclusters: 993998 --=20 You are receiving this mail because: You are on the CC list for the bug.=