From owner-freebsd-net@freebsd.org Sun Feb 23 15:48:08 2020 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 98C782403CA for ; Sun, 23 Feb 2020 15:48:08 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (mailman.nyi.freebsd.org [IPv6:2610:1c1:1:606c::50:13]) by mx1.freebsd.org (Postfix) with ESMTP id 48QV2w3XrJz4GdS for ; Sun, 23 Feb 2020 15:48:08 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id 7333E2403C9; Sun, 23 Feb 2020 15:48:08 +0000 (UTC) Delivered-To: net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 72E152403C7 for ; Sun, 23 Feb 2020 15:48:08 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 48QV2w1q74z4Gcs for ; Sun, 23 Feb 2020 15:48:08 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 357E1EBA7 for ; Sun, 23 Feb 2020 15:48:08 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 01NFm88G078695 for ; Sun, 23 Feb 2020 15:48:08 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 01NFm8vL078692 for net@FreeBSD.org; Sun, 23 Feb 2020 15:48:08 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: net@FreeBSD.org Subject: [Bug 218579] Wake on Lan doesn't work for bge NIC driver Date: Sun, 23 Feb 2020 15:48:06 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 11.2-STABLE X-Bugzilla-Keywords: needs-qa, patch, regression X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: yntses@gmail.com X-Bugzilla-Status: In Progress X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: cy@FreeBSD.org X-Bugzilla-Flags: mfc-stable11? mfc-stable10? X-Bugzilla-Changed-Fields: cc Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 23 Feb 2020 15:48:08 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D218579 Yiannis changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |yntses@gmail.com --- Comment #15 from Yiannis --- Any hope to make it work please ? I have an old but full functional HP Microserver and I can't upgrade becaus= e of this issue. A fix would really appreciated --=20 You are receiving this mail because: You are on the CC list for the bug.= From owner-freebsd-net@freebsd.org Sun Feb 23 17:24:01 2020 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 1A965242C9B for ; Sun, 23 Feb 2020 17:24:01 +0000 (UTC) (envelope-from daemon-user@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 48QX9X6xk5z4R7B; Sun, 23 Feb 2020 17:24:00 +0000 (UTC) (envelope-from daemon-user@freebsd.org) Received: from reviews.nyi.freebsd.org (reviews.nyi.freebsd.org [IPv6:2610:1c1:1:607c::16:b]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id E830FFEF1; Sun, 23 Feb 2020 17:24:00 +0000 (UTC) (envelope-from daemon-user@freebsd.org) Received: by reviews.nyi.freebsd.org (Postfix, from userid 1346) id E76AD361CD1; Sun, 23 Feb 2020 17:24:00 +0000 (UTC) Date: Sun, 23 Feb 2020 17:24:00 +0000 To: Phabricator From: "hrs (Hiroki Sato)" Cc: freebsd-net@freebsd.org Reply-to: "hrs (Hiroki Sato)" Subject: [Differential] D23788: DRAFT: ng_ksocket: IPv6 address parsing and unparsing Message-ID: X-Priority: 3 X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: , , X-Herald-Rules: <28>, <125>, <128>, <67> X-Phabricator-Projects: <#network> X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: Precedence: bulk Thread-Topic: PHID-DREV-isgti776xdsdvju2ufh3 X-Phabricator-Mail-ID: 1834714 X-Phabricator-Send-Attempt: 4ty3fvgepnbuqeuy In-Reply-To: References: Thread-Index: MWQ0ZDVhYmNlZTMxYjNlZWMyN2FmZTk4YjlhIF5StTA= X-Phabricator-Stamps: actor(@hrs) application(Differential) author(@neel_neelc.org) herald(H28) herald(H67) herald(H125) herald(H128) monogram(D23788) object-type(DREV) phid(PHID-DREV-isgti776xdsdvju2ufh3) reviewer(@hrs) revision-repository(rS) revision-status(needs-revision) subscriber(#contributor_reviews_base) subscriber(@freebsd-net-list) subscriber(@hrs) subscriber(@imp) subscriber(@lutz_donnerhacke.de) subscriber(@melifaro) tag(#network) via(web) MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.29 List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 23 Feb 2020 17:24:01 -0000 aHJzIHJlcXVlc3RlZCBjaGFuZ2VzIHRvIHRoaXMgcmV2aXNpb24uCmhycyBhZGRlZCBpbmxpbmUg Y29tbWVudHMuClRoaXMgcmV2aXNpb24gbm93IHJlcXVpcmVzIGNoYW5nZXMgdG8gcHJvY2VlZC4K CklOTElORSBDT01NRU5UUwoKPiBuZ19rc29ja2V0LmM6MzE5Cj4gKwo+ICsJCWZvciAoaSA9IDA7 IGkgPCA4OyBpKyspIHsKPiArCQkJdV9sb25nIHZhbDsKCmluZXRfcHRvbiBpbiBsaWJrZXJuIHNo b3VsZCBiZSB1c2VkIHRvIHBhcnNlIGFuIElQdjYgYWRkcmVzcy4gIEFsc28sIHlvdSBzaG91bGQg Y29uc2lkZXIgdG8gc3VwcG9ydCBhIGxpbmstbG9jYWwgYWRkcmVzcyB3aXRoIGFuIGludGVyZmFj ZSBpZGVudGlmaWVyIHN1Y2ggYXMgW2ZlODA6OjElZW0wXTo4MC4KCj4gbmdfa3NvY2tldC5jOjQx MAo+ICsKPiArCQlzbGVuICs9IHNucHJpbnRmKGNidWYsIGNidWZsZW4sICJpbmV0Ni9bJXU6JXU6 JXU6JXU6JXU6JXU6JXU6JXVdIiwKPiArCQkgICgoY29uc3QgdV9pbnQgKikmc2luNi0+c2luNl9h ZGRyLl9fdTZfYWRkci5fX3U2X2FkZHIxNilbMF0sCgpQbGVhc2UgdXNlIGluZXRfbnRvcCgpLiAg QW5kIHNpbjYtPnNpbjZfc2NvcGVfaWQgbXVzdCBub3QgYmUgaWdub3JlZC4gIFRoZSBpbi1rZXJu ZWwgcmVwcmVzZW50YXRpb24gb2YgYW4gbGluay1sb2NhbCBhZGRyZXNzIGhhcyBlbWJlZGRlZCBz Y29wZSB6b25lIGlkIGluc2lkZSB0aGUgYWRkcmVzcyBpdHNlbGYsIHNvIHlvdSBtaWdodCB3YW50 IHRvIGRvdWJsZS1jaGVjayB0aGUgc2NvcGUgYW5kIHZhbHVlIG9mIHNpbjZfYWRkci5zNl9hZGRy MTZbMV0gaW4gYm90aCBjYXNlcyBvZiBudG9wIGFuZCBwdG9uLgoKUkVQT1NJVE9SWQogIHJTIEZy ZWVCU0Qgc3JjIHJlcG9zaXRvcnkKCkNIQU5HRVMgU0lOQ0UgTEFTVCBBQ1RJT04KICBodHRwczov L3Jldmlld3MuZnJlZWJzZC5vcmcvRDIzNzg4L25ldy8KClJFVklTSU9OIERFVEFJTAogIGh0dHBz Oi8vcmV2aWV3cy5mcmVlYnNkLm9yZy9EMjM3ODgKCkVNQUlMIFBSRUZFUkVOQ0VTCiAgaHR0cHM6 Ly9yZXZpZXdzLmZyZWVic2Qub3JnL3NldHRpbmdzL3BhbmVsL2VtYWlscHJlZmVyZW5jZXMvCgpU bzogbmVlbF9uZWVsYy5vcmcsIGhycwpDYzogaHJzLCBpbXAsIGx1dHpfZG9ubmVyaGFja2UuZGUs IG1lbGlmYXJvLCAjY29udHJpYnV0b3JfcmV2aWV3c19iYXNlLCBmcmVlYnNkLW5ldC1saXN0LCBt bWFjeSwga3ByYXZlZW4ubGttbF9nbWFpbC5jb20sIG1hcmNuYXJjX2dtYWlsLmNvbSwgc2ltb252 ZWxsYV9nbWFpbC5jb20sIG5vdmljZV90ZWNoaWUuY29tLCB0b21taS5wZXJuaWxhX2lraS5maQo= From owner-freebsd-net@freebsd.org Sun Feb 23 21:00:58 2020 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id C7201248B63 for ; Sun, 23 Feb 2020 21:00:58 +0000 (UTC) (envelope-from bugzilla-noreply@FreeBSD.org) Received: from mailman.nyi.freebsd.org (mailman.nyi.freebsd.org [IPv6:2610:1c1:1:606c::50:13]) by mx1.freebsd.org (Postfix) with ESMTP id 48Qczt0QRFz49Hq for ; Sun, 23 Feb 2020 21:00:57 +0000 (UTC) (envelope-from bugzilla-noreply@FreeBSD.org) Received: by mailman.nyi.freebsd.org (Postfix) id CEAD9248B59; Sun, 23 Feb 2020 21:00:57 +0000 (UTC) Delivered-To: net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id CD5FE248B57 for ; Sun, 23 Feb 2020 21:00:57 +0000 (UTC) (envelope-from bugzilla-noreply@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 48Qczs4LKqz49HS for ; Sun, 23 Feb 2020 21:00:57 +0000 (UTC) (envelope-from bugzilla-noreply@FreeBSD.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 8B2F01A79C for ; Sun, 23 Feb 2020 21:00:57 +0000 (UTC) (envelope-from bugzilla-noreply@FreeBSD.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 01NL0vJr094176 for ; Sun, 23 Feb 2020 21:00:57 GMT (envelope-from bugzilla-noreply@FreeBSD.org) Received: (from bugzilla@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 01NL0vuE094173 for net@FreeBSD.org; Sun, 23 Feb 2020 21:00:57 GMT (envelope-from bugzilla-noreply@FreeBSD.org) Message-Id: <202002232100.01NL0vuE094173@kenobi.freebsd.org> X-Authentication-Warning: kenobi.freebsd.org: bugzilla set sender to bugzilla-noreply@FreeBSD.org using -f From: bugzilla-noreply@FreeBSD.org To: net@FreeBSD.org Subject: Problem reports for net@FreeBSD.org that need special attention Date: Sun, 23 Feb 2020 21:00:57 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 23 Feb 2020 21:00:58 -0000 To view an individual PR, use: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=(Bug Id). The following is a listing of current problems submitted by FreeBSD users, which need special attention. These represent problem reports covering all versions including experimental development code and obsolete releases. Status | Bug Id | Description ------------+-----------+--------------------------------------------------- In Progress | 221146 | [ixgbe] Problem with second laggport In Progress | 235700 | oce(4) driver causes fatal trap 12 on boot with e New | 204438 | setsockopt() handling of kern.ipc.maxsockbuf limi New | 205592 | TCP processing in IPSec causes kernel panic New | 213410 | [carp] service netif restart causes hang only whe Open | 193452 | Dell PowerEdge 210 II -- Kernel panic bce (broadc Open | 194453 | dummynet(4): pipe config bw parameter limited to Open | 200319 | Bridge+CARP crashes/freezes Open | 202510 | [CARP] advertisements sourced from CARP IP cause Open | 207261 | netmap: Doesn't do TX sync with kqueue Open | 210726 | tcp connect() can return invalid EADDRINUSE (Eg: Open | 222273 | igb(4): Kernel panic (fatal trap 12) due to netwo Open | 225438 | panic in6_unlink_ifa() due to race Open | 225792 | ECMP is broken since tryforward() Open | 227720 | Kernel panic in ppp server Open | 230807 | if_alc(4): Driver not working for Killer Networki Open | 235524 | igb(4): Ethernet interface loses active link stat Open | 236888 | ppp daemon: Allow MTU to be overridden for PPPoE Open | 236983 | bnxt(4) VLAN not operational unless explicit "ifc Open | 237072 | netgraph(4): performance issue [on HardenedBSD]? Open | 237391 | route get returns no result for network addresses Open | 237840 | Removed dummynet dependency on ipfw Open | 238324 | Add XG-C100C/AQtion AQC107 10GbE NIC driver Open | 240530 | netgraph/ng_source: Allow ng_source to inject int Open | 240608 | if_vmx(4): iflib - Panic with INVARIANTS: Memory Open | 240944 | em(4): Crash with Intel 82571EB NIC with AMD Pile Open | 240969 | netinet6: Neighbour reachability detection broken Open | 241106 | tun/ppp: panic: vm_fault: fault on nofault entry Open | 241162 | Panic in closefp() triggered by nginx (uwsgi with Open | 241191 | route flush panic with RADIX_MPATH Open | 243463 | ix0: Watchdog timeout Open | 244066 | divert: Add sysctls for divert socket send and re 32 problems total for which you should take action. From owner-freebsd-net@freebsd.org Mon Feb 24 00:28:52 2020 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 80A8424D5C6 for ; Mon, 24 Feb 2020 00:28:52 +0000 (UTC) (envelope-from daemon-user@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 48Qjbm1Ldfz45dJ; Mon, 24 Feb 2020 00:28:52 +0000 (UTC) (envelope-from daemon-user@freebsd.org) Received: from reviews.nyi.freebsd.org (reviews.nyi.freebsd.org [IPv6:2610:1c1:1:607c::16:b]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id AF00E1CE97; Mon, 24 Feb 2020 00:28:51 +0000 (UTC) (envelope-from daemon-user@freebsd.org) Received: by reviews.nyi.freebsd.org (Postfix, from userid 1346) id AE5E43683B9; Mon, 24 Feb 2020 00:28:51 +0000 (UTC) Date: Mon, 24 Feb 2020 00:28:51 +0000 To: Phabricator From: "neel_neelc.org (Neel Chauhan)" Cc: freebsd-net@freebsd.org Reply-to: "neel_neelc.org (Neel Chauhan)" Subject: [Differential] D23788: DRAFT: ng_ksocket: IPv6 address parsing and unparsing Message-ID: <7f315e2e02d30d21a3a41fe18ec9a959@localhost.localdomain> X-Priority: 3 X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: , , X-Herald-Rules: <28>, <125>, <128>, <67> X-Phabricator-Projects: <#network> X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: Precedence: bulk Thread-Topic: PHID-DREV-isgti776xdsdvju2ufh3 X-Phabricator-Mail-ID: 1835362 X-Phabricator-Send-Attempt: h7mtelj7qgagihda In-Reply-To: References: Thread-Index: MWQ0ZDVhYmNlZTMxYjNlZWMyN2FmZTk4YjlhIF5TGMM= X-Phabricator-Stamps: actor(@neel_neelc.org) application(Differential) author(@neel_neelc.org) herald(H28) herald(H67) herald(H125) herald(H128) monogram(D23788) object-type(DREV) phid(PHID-DREV-isgti776xdsdvju2ufh3) reviewer(@hrs) revision-repository(rS) revision-status(needs-review) subscriber(#contributor_reviews_base) subscriber(@freebsd-net-list) subscriber(@hrs) subscriber(@imp) subscriber(@lutz_donnerhacke.de) subscriber(@melifaro) tag(#network) via(web) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="b1_7f315e2e02d30d21a3a41fe18ec9a959" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.29 List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 24 Feb 2020 00:28:52 -0000 --b1_7f315e2e02d30d21a3a41fe18ec9a959 Content-Type: text/plain; charset = "utf-8" Content-Transfer-Encoding: base64 bmVlbF9uZWVsYy5vcmcgdXBkYXRlZCB0aGlzIHJldmlzaW9uIHRvIERpZmYgNjg3MjkuCm5lZWxf bmVlbGMub3JnIGVkaXRlZCB0aGUgc3VtbWFyeSBvZiB0aGlzIHJldmlzaW9uLgpuZWVsX25lZWxj Lm9yZyBlZGl0ZWQgdGhlIHRlc3QgcGxhbiBmb3IgdGhpcyByZXZpc2lvbi4KbmVlbF9uZWVsYy5v cmcgYWRkZWQgYSBjb21tZW50LgoKCiAgSGVyZSwgSSB1c2UgaW5ldF9wdG9uIGFuZCBpbmV0X250 b3AuIEkgZGlkbid0IGtub3cgdGhpcyB3YXMgcG9zc2libGUgaW4gdGhlIGtlcm5lbCwgc28gdGhh dCdzIHdoeSB0aGUgZmlyc3QgcmV2aXNpb24gbGFja2VkIHRoaXMuCiAgCiAgSSBzdGlsbCBnZXQg Im5nY3RsOiBzZW5kIG1zZzogSW52YWxpZCBhcmd1bWVudCIgZXJyb3JzIHdpdGggdGhlIGNvbW1h bmRzIGluIHRoZSBUZXN0IFBsYW4uIEFtIEkgZG9pbmcgYW55dGhpbmcgd3Jvbmc/CgpSRVBPU0lU T1JZCiAgclMgRnJlZUJTRCBzcmMgcmVwb3NpdG9yeQoKQ0hBTkdFUyBTSU5DRSBMQVNUIFVQREFU RQogIGh0dHBzOi8vcmV2aWV3cy5mcmVlYnNkLm9yZy9EMjM3ODg/dnM9Njg2NjImaWQ9Njg3MjkK CkNIQU5HRVMgU0lOQ0UgTEFTVCBBQ1RJT04KICBodHRwczovL3Jldmlld3MuZnJlZWJzZC5vcmcv RDIzNzg4L25ldy8KClJFVklTSU9OIERFVEFJTAogIGh0dHBzOi8vcmV2aWV3cy5mcmVlYnNkLm9y Zy9EMjM3ODgKCkFGRkVDVEVEIEZJTEVTCiAgc3lzL25ldGdyYXBoL25nX2tzb2NrZXQuYwoKRU1B SUwgUFJFRkVSRU5DRVMKICBodHRwczovL3Jldmlld3MuZnJlZWJzZC5vcmcvc2V0dGluZ3MvcGFu ZWwvZW1haWxwcmVmZXJlbmNlcy8KClRvOiBuZWVsX25lZWxjLm9yZywgaHJzCkNjOiBocnMsIGlt cCwgbHV0el9kb25uZXJoYWNrZS5kZSwgbWVsaWZhcm8sICNjb250cmlidXRvcl9yZXZpZXdzX2Jh c2UsIGZyZWVic2QtbmV0LWxpc3QsIG1tYWN5LCBrcHJhdmVlbi5sa21sX2dtYWlsLmNvbSwgbWFy Y25hcmNfZ21haWwuY29tLCBzaW1vbnZlbGxhX2dtYWlsLmNvbSwgbm92aWNlX3RlY2hpZS5jb20s IHRvbW1pLnBlcm5pbGFfaWtpLmZpCg== --b1_7f315e2e02d30d21a3a41fe18ec9a959 Content-Type: text/x-patch; charset=utf-8; name="D23788.68729.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="D23788.68729.patch" ZGlmZiAtLWdpdCBhL3N5cy9uZXRncmFwaC9uZ19rc29ja2V0LmMgYi9zeXMvbmV0Z3JhcGgvbmdf a3NvY2tldC5jCi0tLSBhL3N5cy9uZXRncmFwaC9uZ19rc29ja2V0LmMKKysrIGIvc3lzL25ldGdy YXBoL25nX2tzb2NrZXQuYwpAQCAtMTQ5LDYgKzE0OSwxOSBAQAogCXsgImVuY2FwIiwJSVBQUk9U T19FTkNBUCwJCVBGX0lORVQJCX0sCiAJeyAiZGl2ZXJ0IiwJSVBQUk9UT19ESVZFUlQsCQlQRl9J TkVUCQl9LAogCXsgInBpbSIsCUlQUFJPVE9fUElNLAkJUEZfSU5FVAkJfSwKKwl7ICJpcDYiLAlJ UFBST1RPX0lQVjYsCQlQRl9JTkVUNgl9LAorCXsgInJhdzYiLAlJUFBST1RPX1JBVywJCVBGX0lO RVQ2CX0sCisJeyAiaWNtcDYiLAlJUFBST1RPX0lDTVBWNiwJCVBGX0lORVQ2CX0sCisJeyAiaWdt cDYiLAlJUFBST1RPX0lHTVAsCQlQRl9JTkVUNgl9LAorCXsgInRjcDYiLAlJUFBST1RPX1RDUCwJ CVBGX0lORVQ2CX0sCisJeyAidWRwNiIsCUlQUFJPVE9fVURQLAkJUEZfSU5FVDYJfSwKKwl7ICJn cmU2IiwJSVBQUk9UT19HUkUsCQlQRl9JTkVUNgl9LAorCXsgImVzcDYiLAlJUFBST1RPX0VTUCwJ CVBGX0lORVQ2CX0sCisJeyAiYWg2IiwJSVBQUk9UT19BSCwJCVBGX0lORVQ2CX0sCisJeyAic3dp cGU2IiwJSVBQUk9UT19TV0lQRSwJCVBGX0lORVQ2CX0sCisJeyAiZW5jYXA2IiwJSVBQUk9UT19F TkNBUCwJCVBGX0lORVQ2CX0sCisJeyAiZGl2ZXJ0NiIsCUlQUFJPVE9fRElWRVJULAkJUEZfSU5F VDYJfSwKKwl7ICJwaW02IiwJSVBQUk9UT19QSU0sCQlQRl9JTkVUNgl9LAogCXsgTlVMTCwJCS0x CQkJCQl9LAogfTsKIApAQCAtMjk0LDEwICszMDcsNDIgQEAKIAkJYnJlYWs7CiAJICAgIH0KIAot I2lmIDAKLQljYXNlIFBGX0lORVQ2OgkvKiBYWFggaW1wbGVtZW50IHRoaXMgc29tZWRheSAqLwot I2VuZGlmCisJY2FzZSBQRl9JTkVUNjoKKwkgICAgeworCQlzdHJ1Y3Qgc29ja2FkZHJfaW42ICpj b25zdCBzaW42ID0gKHN0cnVjdCBzb2NrYWRkcl9pbjYgKilzYTsKKwkJY2hhciAqZXB0cjsKKwkJ Y2hhciBhZGRyW0lORVQ2X0FERFJTVFJMRU5dOworCQljaGFyIGludGlkWzE2XTsKKwkJdV9sb25n IHBvcnQ7CisJCWJvb2wgaGFzaW50aWQgPSB0cnVlOwogCisJCWlmIChzWypvZmZdID09ICdbJykK KwkJCSgqb2ZmKSsrOworCQlpZiAoKGVwdHIgPSBzdHJzdHIoJnNbKm9mZl0sICIlIikpID09IE5V TEwpIHsKKwkJCWhhc2ludGlkID0gZmFsc2U7CisJCQllcHRyID0gc3Ryc3RyKCZzWypvZmZdLCAi XSIpOworCQl9CisJCXNucHJpbnRmKGFkZHIsIGVwdHIgLSAocyArICpvZmYpLCAiJXMiLCAmc1sq b2ZmXSk7CisJCSpvZmYgKz0gKGVwdHIgLSAocyArICpvZmYpKTsKKwkJaWYgKCFpbmV0X3B0b24o QUZfSU5FVDYsIGFkZHIsICZzaW42LT5zaW42X2FkZHIpKQorCQkJcmV0dXJuIChFSU5WQUwpOwor CisJCWlmIChoYXNpbnRpZCkgeworCQkJZXB0ciA9IHN0cnN0cihOVUxMLCAiXSIpOworCQkJc25w cmludGYoaW50aWQsIGVwdHIgLSAocyArICpvZmYpLCAiJXMiLCAmc1sqb2ZmXSk7CisJCQkqb2Zm ICs9IChlcHRyIC0gKHMgKyAqb2ZmKSk7CisJCX0KKworCQlpZiAoc1sqb2ZmXSA9PSAnWycpIHsK KwkJCSgqb2ZmKSsrOworCQkJcG9ydCA9IHN0cnRvdWwocyArICpvZmYsICZlcHRyLCAxMCk7CisJ CQlpZiAocG9ydCA+IDB4ZmZmZiB8fCBlcHRyID09IHMgKyAqb2ZmKQorCQkJCXJldHVybiAoRUlO VkFMKTsKKwkJCXNpbjYtPnNpbjZfcG9ydCA9IGh0b25zKHBvcnQpOworCQl9CisJCWJyZWFrOwor CSAgICB9CisKIAlkZWZhdWx0OgogCQlyZXR1cm4gKEVJTlZBTCk7CiAJfQpAQCAtMzU2LDkgKzQw MSwyMCBAQAogCQlyZXR1cm4oMCk7CiAJICAgIH0KIAotI2lmIDAKLQljYXNlIFBGX0lORVQ2Ogkv KiBYWFggaW1wbGVtZW50IHRoaXMgc29tZWRheSAqLwotI2VuZGlmCisJY2FzZSBQRl9JTkVUNjoK KwkgICAgeworCQljb25zdCBzdHJ1Y3Qgc29ja2FkZHJfaW42ICpzaW42ID0gKGNvbnN0IHN0cnVj dCBzb2NrYWRkcl9pbjYgKilzYTsKKwkJY2hhciBhZGRyW0lORVQ2X0FERFJTVFJMRU5dOworCQkK KwkJaW5ldF9udG9wKEFGX0lORVQ2LCAmc2luNi0+c2luNl9hZGRyLCBhZGRyLCBJTkVUNl9BRERS U1RSTEVOKTsKKwkJc2xlbiArPSBzbnByaW50ZihjYnVmLCBjYnVmbGVuLCAiaW5ldDYvWyVzXSIs IGFkZHIpOworCisJCWlmIChzaW42LT5zaW42X3BvcnQgIT0gMCkgeworCQkJc2xlbiArPSBzbnBy aW50ZihjYnVmICsgc3RybGVuKGNidWYpLAorCQkJICAgIGNidWZsZW4gLSBzdHJsZW4oY2J1Ziks ICI6JWQiLAorCQkJICAgICh1X2ludCludG9ocyhzaW42LT5zaW42X3BvcnQpKTsKKwkJfQorCSAg ICB9CiAKIAlkZWZhdWx0OgogCQlyZXR1cm4gKCpuZ19rc29ja2V0X2dlbmVyaWNfc29ja2FkZHJf dHlwZS5zdXBlcnR5cGUtPnVucGFyc2UpCgo= --b1_7f315e2e02d30d21a3a41fe18ec9a959-- From owner-freebsd-net@freebsd.org Mon Feb 24 00:29:25 2020 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 7CE7524D643 for ; Mon, 24 Feb 2020 00:29:25 +0000 (UTC) (envelope-from daemon-user@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 48QjcP1DCSz45wg; Mon, 24 Feb 2020 00:29:25 +0000 (UTC) (envelope-from daemon-user@freebsd.org) Received: from reviews.nyi.freebsd.org (reviews.nyi.freebsd.org [IPv6:2610:1c1:1:607c::16:b]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id B72441CEA5; Mon, 24 Feb 2020 00:29:24 +0000 (UTC) (envelope-from daemon-user@freebsd.org) Received: by reviews.nyi.freebsd.org (Postfix, from userid 1346) id B68DC368596; Mon, 24 Feb 2020 00:29:24 +0000 (UTC) Date: Mon, 24 Feb 2020 00:29:24 +0000 To: Phabricator From: "neel_neelc.org (Neel Chauhan)" Cc: freebsd-net@freebsd.org Reply-to: "neel_neelc.org (Neel Chauhan)" Subject: [Differential] D23788: DRAFT: ng_ksocket: IPv6 address parsing and unparsing Message-ID: <05ce360db445c8822148bd773bab6bb0@localhost.localdomain> X-Priority: 3 X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: X-Herald-Rules: <28>, <125>, <128>, <67> X-Phabricator-Projects: <#network> X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: Precedence: bulk Thread-Topic: PHID-DREV-isgti776xdsdvju2ufh3 X-Phabricator-Mail-ID: 1835380 X-Phabricator-Send-Attempt: 6ptebtynodf23opv In-Reply-To: References: Thread-Index: MWQ0ZDVhYmNlZTMxYjNlZWMyN2FmZTk4YjlhIF5TGOQ= X-Phabricator-Stamps: actor(@neel_neelc.org) application(Differential) author(@neel_neelc.org) herald(H28) herald(H67) herald(H125) herald(H128) monogram(D23788) object-type(DREV) phid(PHID-DREV-isgti776xdsdvju2ufh3) reviewer(@hrs) revision-repository(rS) revision-status(needs-review) subscriber(#contributor_reviews_base) subscriber(@freebsd-net-list) subscriber(@hrs) subscriber(@imp) subscriber(@lutz_donnerhacke.de) subscriber(@melifaro) tag(#network) via(web) MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.29 List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 24 Feb 2020 00:29:25 -0000 bmVlbF9uZWVsYy5vcmcgZWRpdGVkIHRoZSBzdW1tYXJ5IG9mIHRoaXMgcmV2aXNpb24uCgpSRVBP U0lUT1JZCiAgclMgRnJlZUJTRCBzcmMgcmVwb3NpdG9yeQoKQ0hBTkdFUyBTSU5DRSBMQVNUIEFD VElPTgogIGh0dHBzOi8vcmV2aWV3cy5mcmVlYnNkLm9yZy9EMjM3ODgvbmV3LwoKUkVWSVNJT04g REVUQUlMCiAgaHR0cHM6Ly9yZXZpZXdzLmZyZWVic2Qub3JnL0QyMzc4OAoKRU1BSUwgUFJFRkVS RU5DRVMKICBodHRwczovL3Jldmlld3MuZnJlZWJzZC5vcmcvc2V0dGluZ3MvcGFuZWwvZW1haWxw cmVmZXJlbmNlcy8KClRvOiBuZWVsX25lZWxjLm9yZywgaHJzCkNjOiBocnMsIGltcCwgbHV0el9k b25uZXJoYWNrZS5kZSwgbWVsaWZhcm8sICNjb250cmlidXRvcl9yZXZpZXdzX2Jhc2UsIGZyZWVi c2QtbmV0LWxpc3QsIG1tYWN5LCBrcHJhdmVlbi5sa21sX2dtYWlsLmNvbSwgbWFyY25hcmNfZ21h aWwuY29tLCBzaW1vbnZlbGxhX2dtYWlsLmNvbSwgbm92aWNlX3RlY2hpZS5jb20sIHRvbW1pLnBl cm5pbGFfaWtpLmZpCg== From owner-freebsd-net@freebsd.org Mon Feb 24 01:17:09 2020 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 64AAB24E830 for ; Mon, 24 Feb 2020 01:17:09 +0000 (UTC) (envelope-from daemon-user@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 48QkgS4sK7z48cj; Mon, 24 Feb 2020 01:17:08 +0000 (UTC) (envelope-from daemon-user@freebsd.org) Received: from reviews.nyi.freebsd.org (reviews.nyi.freebsd.org [IPv6:2610:1c1:1:607c::16:b]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id D4A2B1D7A7; Mon, 24 Feb 2020 01:17:07 +0000 (UTC) (envelope-from daemon-user@freebsd.org) Received: by reviews.nyi.freebsd.org (Postfix, from userid 1346) id D01DA35283D; Mon, 24 Feb 2020 01:17:07 +0000 (UTC) Date: Mon, 24 Feb 2020 01:17:07 +0000 To: Phabricator From: "neel_neelc.org (Neel Chauhan)" Cc: freebsd-net@freebsd.org Reply-to: "neel_neelc.org (Neel Chauhan)" Subject: [Differential] D23788: DRAFT: ng_ksocket: IPv6 address parsing and unparsing Message-ID: <908bb35e1ef376946b9b58e228b670d7@localhost.localdomain> X-Priority: 3 X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: , X-Herald-Rules: <28>, <125>, <128>, <67> X-Phabricator-Projects: <#network> X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: Precedence: bulk Thread-Topic: PHID-DREV-isgti776xdsdvju2ufh3 X-Phabricator-Mail-ID: 1835398 X-Phabricator-Send-Attempt: 76pp6vesllyno7wp In-Reply-To: References: Thread-Index: MWQ0ZDVhYmNlZTMxYjNlZWMyN2FmZTk4YjlhIF5TJBM= X-Phabricator-Stamps: actor(@neel_neelc.org) application(Differential) author(@neel_neelc.org) herald(H28) herald(H67) herald(H125) herald(H128) monogram(D23788) object-type(DREV) phid(PHID-DREV-isgti776xdsdvju2ufh3) reviewer(@hrs) revision-status(needs-review) subscriber(#contributor_reviews_base) subscriber(@freebsd-net-list) subscriber(@hrs) subscriber(@imp) subscriber(@lutz_donnerhacke.de) subscriber(@melifaro) tag(#network) via(web) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="b1_908bb35e1ef376946b9b58e228b670d7" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.29 List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 24 Feb 2020 01:17:09 -0000 --b1_908bb35e1ef376946b9b58e228b670d7 Content-Type: text/plain; charset = "utf-8" Content-Transfer-Encoding: base64 bmVlbF9uZWVsYy5vcmcgdXBkYXRlZCB0aGlzIHJldmlzaW9uIHRvIERpZmYgNjg3MzAuCm5lZWxf bmVlbGMub3JnIGVkaXRlZCB0aGUgc3VtbWFyeSBvZiB0aGlzIHJldmlzaW9uLgoKQ0hBTkdFUyBT SU5DRSBMQVNUIFVQREFURQogIGh0dHBzOi8vcmV2aWV3cy5mcmVlYnNkLm9yZy9EMjM3ODg/dnM9 Njg3MjkmaWQ9Njg3MzAKCkNIQU5HRVMgU0lOQ0UgTEFTVCBBQ1RJT04KICBodHRwczovL3Jldmll d3MuZnJlZWJzZC5vcmcvRDIzNzg4L25ldy8KClJFVklTSU9OIERFVEFJTAogIGh0dHBzOi8vcmV2 aWV3cy5mcmVlYnNkLm9yZy9EMjM3ODgKCkFGRkVDVEVEIEZJTEVTCiAgc3lzL25ldGdyYXBoL25n X2tzb2NrZXQuYwoKRU1BSUwgUFJFRkVSRU5DRVMKICBodHRwczovL3Jldmlld3MuZnJlZWJzZC5v cmcvc2V0dGluZ3MvcGFuZWwvZW1haWxwcmVmZXJlbmNlcy8KClRvOiBuZWVsX25lZWxjLm9yZywg aHJzCkNjOiBocnMsIGltcCwgbHV0el9kb25uZXJoYWNrZS5kZSwgbWVsaWZhcm8sICNjb250cmli dXRvcl9yZXZpZXdzX2Jhc2UsIGZyZWVic2QtbmV0LWxpc3QsIG1tYWN5LCBrcHJhdmVlbi5sa21s X2dtYWlsLmNvbSwgbWFyY25hcmNfZ21haWwuY29tLCBzaW1vbnZlbGxhX2dtYWlsLmNvbSwgbm92 aWNlX3RlY2hpZS5jb20sIHRvbW1pLnBlcm5pbGFfaWtpLmZpCg== --b1_908bb35e1ef376946b9b58e228b670d7 Content-Type: text/x-patch; charset=utf-8; name="D23788.68730.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="D23788.68730.patch" ZGlmZiAtLWdpdCBhL3N5cy9uZXRncmFwaC9uZ19rc29ja2V0LmMgYi9zeXMvbmV0Z3JhcGgvbmdf a3NvY2tldC5jCi0tLSBhL3N5cy9uZXRncmFwaC9uZ19rc29ja2V0LmMKKysrIGIvc3lzL25ldGdy YXBoL25nX2tzb2NrZXQuYwpAQCAtNjAsNiArNjAsOSBAQAogI2luY2x1ZGUgPHN5cy91aW8uaD4K ICNpbmNsdWRlIDxzeXMvdW4uaD4KIAorI2luY2x1ZGUgPG5ldC9pZi5oPgorI2luY2x1ZGUgPG5l dC9pZl92YXIuaD4KKwogI2luY2x1ZGUgPG5ldGdyYXBoL25nX21lc3NhZ2UuaD4KICNpbmNsdWRl IDxuZXRncmFwaC9uZXRncmFwaC5oPgogI2luY2x1ZGUgPG5ldGdyYXBoL25nX3BhcnNlLmg+CkBA IC02OCw2ICs3MSw4IEBACiAjaW5jbHVkZSA8bmV0aW5ldC9pbi5oPgogI2luY2x1ZGUgPG5ldGlu ZXQvaXAuaD4KIAorI2luY2x1ZGUgPG5ldGluZXQ2L3Njb3BlNl92YXIuaD4KKwogI2lmZGVmIE5H X1NFUEFSQVRFX01BTExPQwogc3RhdGljIE1BTExPQ19ERUZJTkUoTV9ORVRHUkFQSF9LU09DS0VU LCAibmV0Z3JhcGhfa3NvY2siLAogICAgICJuZXRncmFwaCBrc29jayBub2RlIik7CkBAIC0xNDks NiArMTU0LDE5IEBACiAJeyAiZW5jYXAiLAlJUFBST1RPX0VOQ0FQLAkJUEZfSU5FVAkJfSwKIAl7 ICJkaXZlcnQiLAlJUFBST1RPX0RJVkVSVCwJCVBGX0lORVQJCX0sCiAJeyAicGltIiwJSVBQUk9U T19QSU0sCQlQRl9JTkVUCQl9LAorCXsgImlwNiIsCUlQUFJPVE9fSVBWNiwJCVBGX0lORVQ2CX0s CisJeyAicmF3NiIsCUlQUFJPVE9fUkFXLAkJUEZfSU5FVDYJfSwKKwl7ICJpY21wNiIsCUlQUFJP VE9fSUNNUFY2LAkJUEZfSU5FVDYJfSwKKwl7ICJpZ21wNiIsCUlQUFJPVE9fSUdNUCwJCVBGX0lO RVQ2CX0sCisJeyAidGNwNiIsCUlQUFJPVE9fVENQLAkJUEZfSU5FVDYJfSwKKwl7ICJ1ZHA2IiwJ SVBQUk9UT19VRFAsCQlQRl9JTkVUNgl9LAorCXsgImdyZTYiLAlJUFBST1RPX0dSRSwJCVBGX0lO RVQ2CX0sCisJeyAiZXNwNiIsCUlQUFJPVE9fRVNQLAkJUEZfSU5FVDYJfSwKKwl7ICJhaDYiLAlJ UFBST1RPX0FILAkJUEZfSU5FVDYJfSwKKwl7ICJzd2lwZTYiLAlJUFBST1RPX1NXSVBFLAkJUEZf SU5FVDYJfSwKKwl7ICJlbmNhcDYiLAlJUFBST1RPX0VOQ0FQLAkJUEZfSU5FVDYJfSwKKwl7ICJk aXZlcnQ2IiwJSVBQUk9UT19ESVZFUlQsCQlQRl9JTkVUNgl9LAorCXsgInBpbTYiLAlJUFBST1RP X1BJTSwJCVBGX0lORVQ2CX0sCiAJeyBOVUxMLAkJLTEJCQkJCX0sCiB9OwogCkBAIC0yOTQsMTAg KzMxMiw1MCBAQAogCQlicmVhazsKIAkgICAgfQogCi0jaWYgMAotCWNhc2UgUEZfSU5FVDY6CS8q IFhYWCBpbXBsZW1lbnQgdGhpcyBzb21lZGF5ICovCi0jZW5kaWYKKwljYXNlIFBGX0lORVQ2Ogor CSAgICB7CisJCXN0cnVjdCBzb2NrYWRkcl9pbjYgKmNvbnN0IHNpbjYgPSAoc3RydWN0IHNvY2th ZGRyX2luNiAqKXNhOworCQljaGFyICplcHRyOworCQljaGFyIGFkZHJbSU5FVDZfQUREUlNUUkxF Tl07CisJCWNoYXIgaWZuYW1lWzE2XTsKKwkJdV9sb25nIHBvcnQ7CisJCWJvb2wgaGFzaWZuYW1l ID0gdHJ1ZTsKIAorCQlpZiAoc1sqb2ZmXSA9PSAnWycpCisJCQkoKm9mZikrKzsKKwkJaWYgKChl cHRyID0gc3Ryc3RyKCZzWypvZmZdLCAiJSIpKSA9PSBOVUxMKSB7CisJCQloYXNpZm5hbWUgPSBm YWxzZTsKKwkJCWVwdHIgPSBzdHJzdHIoJnNbKm9mZl0sICJdIik7CisJCX0KKwkJc25wcmludGYo YWRkciwgZXB0ciAtIChzICsgKm9mZiksICIlcyIsICZzWypvZmZdKTsKKwkJKm9mZiArPSAoZXB0 ciAtIChzICsgKm9mZikpOworCQlpZiAoIWluZXRfcHRvbihBRl9JTkVUNiwgYWRkciwgJnNpbjYt PnNpbjZfYWRkcikpCisJCQlyZXR1cm4gKEVJTlZBTCk7CisKKwkJaWYgKGhhc2lmbmFtZSkgewor CQkJdWludDE2X3Qgc2NvcGU7CisKKwkJCWVwdHIgPSBzdHJzdHIoTlVMTCwgIl0iKTsKKwkJCXNu cHJpbnRmKGlmbmFtZSwgZXB0ciAtIChzICsgKm9mZiksICIlcyIsICZzWypvZmZdKTsKKwkJCSpv ZmYgKz0gKGVwdHIgLSAocyArICpvZmYpKTsKKworCQkJaWYgKG50b2hsKHNpbjYtPnNpbjZfYWRk ci5zNl9hZGRyMTZbMF0pICE9IDB4ZmU4MCkKKwkJCQlyZXR1cm4gKEVJTlZBTCk7CisJCQlzY29w ZSA9IGluNl9nZXRzY29wZSgmc2luNi0+c2luNl9hZGRyKTsKKwkJCXNpbjYtPnNpbjZfc2NvcGVf aWQgPQorCQkJICAgIGluNl9nZXRzY29wZXpvbmUoaWZ1bml0KGlmbmFtZSksIHNjb3BlKTsKKwkJ fQorCisJCWlmIChzWypvZmZdID09ICdbJykgeworCQkJKCpvZmYpKys7CisJCQlwb3J0ID0gc3Ry dG91bChzICsgKm9mZiwgJmVwdHIsIDEwKTsKKwkJCWlmIChwb3J0ID4gMHhmZmZmIHx8IGVwdHIg PT0gcyArICpvZmYpCisJCQkJcmV0dXJuIChFSU5WQUwpOworCQkJc2luNi0+c2luNl9wb3J0ID0g aHRvbnMocG9ydCk7CisJCX0KKwkJYnJlYWs7CisJICAgIH0KKwogCWRlZmF1bHQ6CiAJCXJldHVy biAoRUlOVkFMKTsKIAl9CkBAIC0zNTYsOSArNDE0LDIwIEBACiAJCXJldHVybigwKTsKIAkgICAg fQogCi0jaWYgMAotCWNhc2UgUEZfSU5FVDY6CS8qIFhYWCBpbXBsZW1lbnQgdGhpcyBzb21lZGF5 ICovCi0jZW5kaWYKKwljYXNlIFBGX0lORVQ2OgorCSAgICB7CisJCWNvbnN0IHN0cnVjdCBzb2Nr YWRkcl9pbjYgKnNpbjYgPSAoY29uc3Qgc3RydWN0IHNvY2thZGRyX2luNiAqKXNhOworCQljaGFy IGFkZHJbSU5FVDZfQUREUlNUUkxFTl07CisJCQorCQlpbmV0X250b3AoQUZfSU5FVDYsICZzaW42 LT5zaW42X2FkZHIsIGFkZHIsIElORVQ2X0FERFJTVFJMRU4pOworCQlzbGVuICs9IHNucHJpbnRm KGNidWYsIGNidWZsZW4sICJpbmV0Ni9bJXNdIiwgYWRkcik7CisKKwkJaWYgKHNpbjYtPnNpbjZf cG9ydCAhPSAwKSB7CisJCQlzbGVuICs9IHNucHJpbnRmKGNidWYgKyBzdHJsZW4oY2J1ZiksCisJ CQkgICAgY2J1ZmxlbiAtIHN0cmxlbihjYnVmKSwgIjolZCIsCisJCQkgICAgKHVfaW50KW50b2hz KHNpbjYtPnNpbjZfcG9ydCkpOworCQl9CisJICAgIH0KIAogCWRlZmF1bHQ6CiAJCXJldHVybiAo Km5nX2tzb2NrZXRfZ2VuZXJpY19zb2NrYWRkcl90eXBlLnN1cGVydHlwZS0+dW5wYXJzZSkKCg== --b1_908bb35e1ef376946b9b58e228b670d7-- From owner-freebsd-net@freebsd.org Mon Feb 24 09:58:51 2020 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 1445825775A for ; Mon, 24 Feb 2020 09:58:51 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id 48QyFQ682gz3KVw for ; Mon, 24 Feb 2020 09:58:50 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id A5012257759; Mon, 24 Feb 2020 09:58:50 +0000 (UTC) Delivered-To: net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id A4B54257758 for ; Mon, 24 Feb 2020 09:58:50 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 48QyFQ3Q05z3KTw for ; Mon, 24 Feb 2020 09:58:50 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 47F4E23778 for ; Mon, 24 Feb 2020 09:58:50 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 01O9woD2078477 for ; Mon, 24 Feb 2020 09:58:50 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from bugzilla@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 01O9woTk078476 for net@FreeBSD.org; Mon, 24 Feb 2020 09:58:50 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: bugzilla set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: net@FreeBSD.org Subject: [Bug 244002] Kernel panic while trying to read multicast stream Date: Mon, 24 Feb 2020 09:58:50 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 12.1-RELEASE X-Bugzilla-Keywords: panic X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: commit-hook@freebsd.org X-Bugzilla-Status: Closed X-Bugzilla-Resolution: FIXED X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: net@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 24 Feb 2020 09:58:51 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D244002 --- Comment #23 from commit-hook@freebsd.org --- A commit references this bug: Author: hselasky Date: Mon Feb 24 09:57:48 UTC 2020 New revision: 358273 URL: https://svnweb.freebsd.org/changeset/base/358273 Log: MFC r358013: Fix kernel panic while trying to read multicast stream. When VIMAGE is enabled make sure the "m_pkthdr.rcvif" pointer is set for all mbufs being input by the IGMP/MLD6 code. Else there will be a NULL-pointer dereference in the netisr code when trying to set the VNET based on the incoming mbuf. Add an assert to catch this when queueing mbufs on a netisr to make debugging of similar cases easier. Found by: Vladislav V. Prodan PR: 244002 Reviewed by: bz@ Sponsored by: Mellanox Technologies Changes: _U stable/12/ stable/12/sys/net/netisr.c stable/12/sys/netinet/igmp.c stable/12/sys/netinet6/mld6.c --=20 You are receiving this mail because: You are the assignee for the bug.= From owner-freebsd-net@freebsd.org Mon Feb 24 09:59:53 2020 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id E2EB1257891 for ; Mon, 24 Feb 2020 09:59:53 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (mailman.nyi.freebsd.org [IPv6:2610:1c1:1:606c::50:13]) by mx1.freebsd.org (Postfix) with ESMTP id 48QyGd5glRz3MV3 for ; Mon, 24 Feb 2020 09:59:53 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id C2AFC257890; Mon, 24 Feb 2020 09:59:53 +0000 (UTC) Delivered-To: net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id C250225788F for ; Mon, 24 Feb 2020 09:59:53 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 48QyGd2kjfz3MTb for ; Mon, 24 Feb 2020 09:59:53 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 3429E23787 for ; Mon, 24 Feb 2020 09:59:53 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 01O9xrKX079747 for ; Mon, 24 Feb 2020 09:59:53 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from bugzilla@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 01O9xrfn079746 for net@FreeBSD.org; Mon, 24 Feb 2020 09:59:53 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: bugzilla set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: net@FreeBSD.org Subject: [Bug 244002] Kernel panic while trying to read multicast stream Date: Mon, 24 Feb 2020 09:59:52 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 12.1-RELEASE X-Bugzilla-Keywords: panic X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: commit-hook@freebsd.org X-Bugzilla-Status: Closed X-Bugzilla-Resolution: FIXED X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: net@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 24 Feb 2020 09:59:54 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D244002 --- Comment #24 from commit-hook@freebsd.org --- A commit references this bug: Author: hselasky Date: Mon Feb 24 09:58:58 UTC 2020 New revision: 358274 URL: https://svnweb.freebsd.org/changeset/base/358274 Log: MFC r358013: Fix kernel panic while trying to read multicast stream. When VIMAGE is enabled make sure the "m_pkthdr.rcvif" pointer is set for all mbufs being input by the IGMP/MLD6 code. Else there will be a NULL-pointer dereference in the netisr code when trying to set the VNET based on the incoming mbuf. Add an assert to catch this when queueing mbufs on a netisr to make debugging of similar cases easier. Found by: Vladislav V. Prodan PR: 244002 Reviewed by: bz@ Sponsored by: Mellanox Technologies Changes: _U stable/11/ stable/11/sys/net/netisr.c stable/11/sys/netinet/igmp.c stable/11/sys/netinet6/mld6.c --=20 You are receiving this mail because: You are the assignee for the bug.= From owner-freebsd-net@freebsd.org Mon Feb 24 15:56:06 2020 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id BF86F2389D4 for ; Mon, 24 Feb 2020 15:56:06 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id 48R69f4QyRz41sd for ; Mon, 24 Feb 2020 15:56:06 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id 5F6DE2389D3; Mon, 24 Feb 2020 15:56:06 +0000 (UTC) Delivered-To: net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 5EB622389D0 for ; Mon, 24 Feb 2020 15:56:06 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 48R69f0vCsz41rH for ; Mon, 24 Feb 2020 15:56:06 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id E033927A08 for ; Mon, 24 Feb 2020 15:56:05 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 01OFu5dE090866 for ; Mon, 24 Feb 2020 15:56:05 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 01OFu52k090865 for net@FreeBSD.org; Mon, 24 Feb 2020 15:56:05 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: net@FreeBSD.org Subject: [Bug 244004] vxlan(4) does not support setting of tunnelfib Date: Mon, 24 Feb 2020 15:56:04 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 12.1-RELEASE X-Bugzilla-Keywords: patch X-Bugzilla-Severity: Affects Many People X-Bugzilla-Who: bryanv@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bryanv@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: cc assigned_to Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 24 Feb 2020 15:56:06 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D244004 Bryan Venteicher changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bryanv@FreeBSD.org Assignee|net@FreeBSD.org |bryanv@FreeBSD.org --=20 You are receiving this mail because: You are the assignee for the bug.= From owner-freebsd-net@freebsd.org Mon Feb 24 22:41:36 2020 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 5F4352464EA for ; Mon, 24 Feb 2020 22:41:36 +0000 (UTC) (envelope-from rmacklem@uoguelph.ca) Received: from CAN01-QB1-obe.outbound.protection.outlook.com (mail-qb1can01on060d.outbound.protection.outlook.com [IPv6:2a01:111:f400:fe5c::60d]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mail.protection.outlook.com", Issuer "GlobalSign Organization Validation CA - SHA256 - G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 48RH9T5mb1z3MFf for ; Mon, 24 Feb 2020 22:41:33 +0000 (UTC) (envelope-from rmacklem@uoguelph.ca) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ApKPVed9tCdN+PmuaE7Yr+bVQTR1EaUMSA1MKmHqYT3LyX+p+i1zKnq4SxaMtlrOaxMi6jeumnSp2/gWHv25MZbLYsGNKPmbNH9UZ3rV70C590tkm4Pb8f89Xd2bNK7BP1umQ02tn+lfei4SRhxNZMr73wuVA95UFEGtel/TXBpHkOJcbsb3nqdAkt7SBG2eDkdlqRAQ2N30MAZqhyhIdsYgSH6euxJzHq95KHowSLgZlqhXkglScYBAkWmkeN12Tl1pHbdD0LfH+o4tSSdXqsUAxErPqZt753Jsi4TRR2s2fxRc6hSXC4+ba0aRLlu8vV/ki6y0YWg79wZ6up8PCg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OuoyoDxfm6TGrBozHjkJWJ+1gV3XVp576B7DLSF8kPo=; b=TyfF0m9mVQWw00QgT+E5YgY3a2C5/VSTNqK+A5lbrEA1apnbQuHUGWEeGNaxQAHmGbmLhs7ModmCFxoQuZ7VPlVheCPQSVbHNj/UnuaoyarHskfGQ1LpTJ+gtmreMmmenaVTvT9NRq9aRFk38MpzwXvi82/3CvDJjoG3lQ6CPjUrB//JHw9E08AM+efMMjo1U/UVF+4kXAFGrF0OahH243DQBMTF7nO0A7icaKyHyO6+61pbb9ZVOaHI9cRf+3HpOlUonqPdw8jAuaQDdWqybFMboD/7gvRpBbuUNPNNsbiD/G2DQxoz18m+tUnHRvRfa5shwMhHTCKtR8tHeW+f/g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=uoguelph.ca; dmarc=pass action=none header.from=uoguelph.ca; dkim=pass header.d=uoguelph.ca; arc=none Received: from YTBPR01MB3374.CANPRD01.PROD.OUTLOOK.COM (10.255.46.82) by YTBPR01MB2334.CANPRD01.PROD.OUTLOOK.COM (10.255.12.155) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2750.21; Mon, 24 Feb 2020 22:41:30 +0000 Received: from YTBPR01MB3374.CANPRD01.PROD.OUTLOOK.COM ([fe80::410e:652b:6fbc:9aa4]) by YTBPR01MB3374.CANPRD01.PROD.OUTLOOK.COM ([fe80::410e:652b:6fbc:9aa4%3]) with mapi id 15.20.2750.021; Mon, 24 Feb 2020 22:41:30 +0000 From: Rick Macklem To: freebsd-net Subject: use of m_copym() for ext_pgs mbufs? Thread-Topic: use of m_copym() for ext_pgs mbufs? Thread-Index: AQHV62MkFCvYXPmQLka8RBheYR9quA== Date: Mon, 24 Feb 2020 22:41:30 +0000 Message-ID: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 14b30caa-aedc-4890-d94a-08d7b97ab155 x-ms-traffictypediagnostic: YTBPR01MB2334: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:5797; x-forefront-prvs: 032334F434 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(396003)(366004)(136003)(346002)(376002)(39860400002)(199004)(189003)(91956017)(66476007)(33656002)(76116006)(66556008)(66446008)(26005)(5660300002)(186003)(2906002)(9686003)(66946007)(64756008)(558084003)(52536014)(55016002)(786003)(316002)(478600001)(8936002)(81156014)(86362001)(71200400001)(7696005)(81166006)(8676002)(6506007)(6916009); DIR:OUT; SFP:1101; SCL:1; SRVR:YTBPR01MB2334; H:YTBPR01MB3374.CANPRD01.PROD.OUTLOOK.COM; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: uoguelph.ca does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 897fjMfmTnhE3QDZmoF6SdWn9hq9D6F1J71KFPPJXOpssUo5AijSOfLfqX22l40/8T7wbLdEWRGrOEMJ8prq8WPyDb2GdclLY/zeK4iFYXse8nIgaByCAKAW3aC5SwUzUm+Hxl0IBmLbK04oeSZhOrFWb6x7j6U067a01V8/J/mJJMyrLuPBND8OGbYrNqQUkfacPMt7cvuxgarMw4ET/n6cRxqAqBzBMctE9A9qkED3nBZXhGyh0L8vAuYa2SuRyRNU/lR2WZzrHvyTKlmY42+9/bd2ZHeS3dcfUu4X7eRD5MW1FI5r78INfPRdoS4PeW1mfsuh2nHvnjJPlC4RW4+edl5xQZ7TMG7DkMX2E0HV6Xq9jFcfCDz2KEAvVGGRfp9l2KSfbPQid0Jgo/8ygBSf4swVGCTtwPB9HYudrSHXwCznzGpTBBy+Jt+G3rG0 x-ms-exchange-antispam-messagedata: ENUn/vt+y9/7K8CHCTaRKEWFRR9qWFq+qcyQgjsM47cSkXLqPSIEo+hj6/n07AxcL8BDjLgRpVEUzf4PFaGwcuad4QiEO7+WS23iHDynSZ3qt7fqLCAippLugJpCSVM0298k0+kBRPiTJBPPKE7Emw== x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: uoguelph.ca X-MS-Exchange-CrossTenant-Network-Message-Id: 14b30caa-aedc-4890-d94a-08d7b97ab155 X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Feb 2020 22:41:30.7317 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: be62a12b-2cad-49a1-a5fa-85f4f3156a7d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 5WcPDRQzjbh2Snlf/bJGcq+6opPVXeY4P3vGVydcrYjT4ODOIzylFHyQVh8gbak6RqdlXxenxWjEkUD5oaapYQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: YTBPR01MB2334 X-Rspamd-Queue-Id: 48RH9T5mb1z3MFf X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of rmacklem@uoguelph.ca designates 2a01:111:f400:fe5c::60d as permitted sender) smtp.mailfrom=rmacklem@uoguelph.ca X-Spamd-Result: default: False [-3.73 / 15.00]; RCVD_TLS_LAST(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; FROM_HAS_DN(0.00)[]; R_SPF_ALLOW(-0.20)[+ip6:2a01:111:f400::/48]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[uoguelph.ca]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; RCPT_COUNT_ONE(0.00)[1]; RCVD_COUNT_THREE(0.00)[3]; IP_SCORE(-1.43)[ipnet: 2a01:111:f000::/36(-3.98), asn: 8075(-3.12), country: US(-0.05)]; TO_DN_ALL(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; R_DKIM_NA(0.00)[]; ASN(0.00)[asn:8075, ipnet:2a01:111:f000::/36, country:US]; SUBJECT_ENDS_QUESTION(1.00)[]; ARC_ALLOW(-1.00)[i=1] X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 24 Feb 2020 22:41:36 -0000 Hi,=0A= =0A= Since I am just figuring out ext_pgs mbufs, I thought I'd check...=0A= It looks like using m_copym() on a list of ext_pgs mbufs is ok=0A= only if it copying the entire list (ie. m_copym(m, 0, M_COPYALL,..)).=0A= =0A= Is that correct?=0A= =0A= Thanks, rick=0A= From owner-freebsd-net@freebsd.org Tue Feb 25 02:58:47 2020 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 61B8524DC1F for ; Tue, 25 Feb 2020 02:58:47 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id 48RNtF70sPz4LFJ for ; Tue, 25 Feb 2020 02:58:45 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id 8A40524DC1E; Tue, 25 Feb 2020 02:58:45 +0000 (UTC) Delivered-To: net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 85A4424DC1D for ; Tue, 25 Feb 2020 02:58:45 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 48RNtF1BXbz4LCd for ; Tue, 25 Feb 2020 02:58:45 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id E9F747AA4 for ; Tue, 25 Feb 2020 02:58:44 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 01P2wija053809 for ; Tue, 25 Feb 2020 02:58:44 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 01P2wiVt053806 for net@FreeBSD.org; Tue, 25 Feb 2020 02:58:44 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: net@FreeBSD.org Subject: [Bug 243319] em(4): Panic results in Intel 82579LM taking down local switch Date: Tue, 25 Feb 2020 02:58:44 +0000 X-Bugzilla-Reason: AssignedTo CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: IntelNetworking X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: koobs@FreeBSD.org X-Bugzilla-Status: Closed X-Bugzilla-Resolution: Not A Bug X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: net@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: resolution keywords Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 25 Feb 2020 02:58:47 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D243319 Kubilay Kocak changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|FIXED |Not A Bug Keywords|needs-qa | --=20 You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug.= From owner-freebsd-net@freebsd.org Tue Feb 25 02:59:37 2020 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 9A3EA24DCF8 for ; Tue, 25 Feb 2020 02:59:37 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id 48RNvF2s6qz4N95 for ; Tue, 25 Feb 2020 02:59:37 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id 5E63624DCF7; Tue, 25 Feb 2020 02:59:37 +0000 (UTC) Delivered-To: net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 5DC6A24DCF6 for ; Tue, 25 Feb 2020 02:59:37 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 48RNvF1sprz4N8r for ; Tue, 25 Feb 2020 02:59:37 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 3A53F7AA8 for ; Tue, 25 Feb 2020 02:59:37 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 01P2xb50054859 for ; Tue, 25 Feb 2020 02:59:37 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 01P2xb0F054858 for net@FreeBSD.org; Tue, 25 Feb 2020 02:59:37 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: net@FreeBSD.org Subject: [Bug 244002] Kernel panic while trying to read multicast stream Date: Tue, 25 Feb 2020 02:59:37 +0000 X-Bugzilla-Reason: CC AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 12.1-RELEASE X-Bugzilla-Keywords: panic X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: koobs@FreeBSD.org X-Bugzilla-Status: Closed X-Bugzilla-Resolution: FIXED X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: hselasky@FreeBSD.org X-Bugzilla-Flags: mfc-stable12+ mfc-stable11+ X-Bugzilla-Changed-Fields: assigned_to cc flagtypes.name Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 25 Feb 2020 02:59:37 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D244002 Kubilay Kocak changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|net@FreeBSD.org |hselasky@FreeBSD.org CC| |net@FreeBSD.org Flags| |mfc-stable12+, | |mfc-stable11+ --=20 You are receiving this mail because: You are on the CC list for the bug. You are the assignee for the bug.= From owner-freebsd-net@freebsd.org Tue Feb 25 04:41:09 2020 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 1EA1725032A for ; Tue, 25 Feb 2020 04:41:09 +0000 (UTC) (envelope-from pkelsey@gmail.com) Received: from mail-io1-f53.google.com (mail-io1-f53.google.com [209.85.166.53]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 48RR8M3pc0z4C1t; Tue, 25 Feb 2020 04:41:07 +0000 (UTC) (envelope-from pkelsey@gmail.com) Received: by mail-io1-f53.google.com with SMTP id z1so1704255iom.9; Mon, 24 Feb 2020 20:41:07 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=iHg5WNSHUR5+HVi6kYC3sXjUQ50jMq77D7zVjKbQJ+M=; b=kQFl0Fo0gV7SplWDuLxHB2hbK1ZnKM1FdoBUsrMr4D0htCLpz689dgWe2uK4kyH9kb LcnTzWp+w/MD3QgfUSAxIMTa1Ph1ZgdOC75/Co9gVnL4w15JxK/vrVHRyppaorJ8pu0n N6r1k+FpP/ueEcx0MU1zOj/HeoWqxsVnwOCGExk1ONNea1hzlb7qShwsW2sbBX8NUsX6 cbmj61SC8g7/XNn1be+umSbdDXzr5pWYJaMZTeqV8QlrD/5hrUfSc3EfheecLCJFWSya 68vU3o+lksbe5gtOzRMdwaUqdcVxkXiZ1BdJA/wL3QJvNYGV1gGrhBnWg1DooXL7KxyB 7XKA== X-Gm-Message-State: APjAAAU/REhMpQL++jMccbETte07UzP2v69FYpQ6j+F5MPyF8mYuXiYx 8bcbJJLhX0tui5MhAqFXT0CdI6WyiyHj66a3CiSFd01T X-Google-Smtp-Source: APXvYqzH3Ba+/5djr3wMOKl2JGyGkyaO3Kb0LRKVxHRBj0dL/2L8V8FDAJV5/rJK+8wD9WbhEYMD4D6Ma2NKKFO62ts= X-Received: by 2002:a6b:e202:: with SMTP id z2mr3970669ioc.23.1582605665020; Mon, 24 Feb 2020 20:41:05 -0800 (PST) MIME-Version: 1.0 References: <40c4a4df-3df6-d95d-53c2-eef905ff45b1@FreeBSD.org> <5e5d423b-0711-7454-626a-cc9cb4b004cd@FreeBSD.org> In-Reply-To: From: Patrick Kelsey Date: Mon, 24 Feb 2020 23:40:52 -0500 Message-ID: Subject: Re: terrible if_vmx / vmxnet3 rx performance with lro (post iflib) To: Josh Paetzel Cc: freebsd-net X-Rspamd-Queue-Id: 48RR8M3pc0z4C1t X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of pkelsey@gmail.com designates 209.85.166.53 as permitted sender) smtp.mailfrom=pkelsey@gmail.com X-Spamd-Result: default: False [-2.45 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-0.999,0]; RCVD_TLS_ALL(0.00)[]; FROM_HAS_DN(0.00)[]; R_SPF_ALLOW(-0.20)[+ip4:209.85.128.0/17]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; DMARC_NA(0.00)[freebsd.org]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; URI_COUNT_ODD(1.00)[15]; IP_SCORE(-1.45)[ip: (-2.53), ipnet: 209.85.128.0/17(-2.99), asn: 15169(-1.67), country: US(-0.05)]; TO_DN_ALL(0.00)[]; RCPT_COUNT_TWO(0.00)[2]; RCVD_IN_DNSWL_NONE(0.00)[53.166.85.209.list.dnswl.org : 127.0.5.0]; FORGED_SENDER(0.30)[pkelsey@freebsd.org,pkelsey@gmail.com]; RWL_MAILSPIKE_POSSIBLE(0.00)[53.166.85.209.rep.mailspike.net : 127.0.0.17]; MIME_TRACE(0.00)[0:+,1:+,2:~]; R_DKIM_NA(0.00)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; FROM_NEQ_ENVFROM(0.00)[pkelsey@freebsd.org,pkelsey@gmail.com]; RCVD_COUNT_TWO(0.00)[2] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 25 Feb 2020 04:41:09 -0000 On Thu, Feb 20, 2020 at 4:58 PM Josh Paetzel wrote: > > > On Wed, Feb 19, 2020, at 7:17 AM, Andriy Gapon wrote: > > On 18/02/2020 16:09, Andriy Gapon wrote: > > > My general experience with post-iflib vmxnet3 is that vmxnet3 has some > > > peculiarities that result in a certain "impedance mismatch" with iflib. > > > Although we now have a bit less code and it is a bit more regular, > there are a > > > few significant (for us, at least) problems: > > > - https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=243126 > > > - https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=240608 > > > > By the way, we (Panzura) use these changes to fix or work around the > above two > > problems: https://people.freebsd.org/~avg/iflib-vmx.pz.diff > > > > Questions / comments are welcome. > > Especially from people who worked on iflib. > > > > > - https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=243392 > > > - the problem described above > > > - a couple of issues that we already fixed or worked around > > > > > > We are contemplating locally reverting to the pre-iflib vmxnet3 and we > are > > > wondering if the conversion was really worth it in general. > > > > > > -- > > Andriy Gapon > > _______________________________________________ > > freebsd-net@freebsd.org mailing list > > https://lists.freebsd.org/mailman/listinfo/freebsd-net > > To unsubscribe, send any mail to "freebsd-net-unsubscribe@freebsd.org" > > > > I'd like to follow this up just to make it 100% clear. The problem is a > ~4x regression in RX performance. It affects stock FreeBSD, including > 12.1-RELEASE. > > In my 40Gbps connected lab single thread iperf receive went from 9Gbps to > 2.5Gbps. > > If this can't be fixed or looked at I'd heavily suggest looking at > reverting "iflib"ing change in stock FreeBSD. > > Consider these datapoints I collected this evening: Hypervisor: ESXi 6.7.0 Build 8169922 Hardware: Xeon E5-1650 v3 @ 3.50GHz (6 physical cores, HT disabled) iperf3 client: a VM on the same vswitch as the VM under test, running Ubuntu 18.04.3 LTS with 2 vCPUs, 4GB RAM, and a VMXNET3 interface used only for traffic to the VM under test (this VMXNET3 has checksum offload, TSO/GSO, and LRO/GRO enabled) iperf3 server: running on the VM under test, either a 12.0-RELEASE VM (this is before the vmx iflib conversion), or a 12.1-RELEASE VM (this is after the vmx iflib conversion) with r356703 applied (the recent TSO bug fix). Both VMs have 3 vCPUs, but the vmx interface only uses 1 tx and 1 rx queue, as hw.pci.honor_msi_blacklist is at its default of 0, so MSI is used. Test 1: 12.0-RELEASE, single TCP stream receive, standard mtu, TSO enabled, LRO disabled ====== vmx0: flags=8843 metric 0 mtu 1500 options=60039b $ iperf3 -c <12.0 VM IP> -p 1234 Connecting to host <12.0 VM IP>, port 1234 [ 4] local port 44664 connected to <12.0 VM IP> port 1234 [ ID] Interval Transfer Bandwidth Retr Cwnd [ 4] 0.00-1.00 sec 1.11 GBytes 9.52 Gbits/sec 1144 529 KBytes [ 4] 1.00-2.00 sec 1.09 GBytes 9.40 Gbits/sec 1272 369 KBytes [ 4] 2.00-3.00 sec 1.11 GBytes 9.51 Gbits/sec 1249 344 KBytes [ 4] 3.00-4.00 sec 1.06 GBytes 9.12 Gbits/sec 1973 369 KBytes [ 4] 4.00-5.00 sec 1.11 GBytes 9.50 Gbits/sec 1860 370 KBytes [ 4] 5.00-6.00 sec 1.08 GBytes 9.28 Gbits/sec 1342 396 KBytes [ 4] 6.00-7.00 sec 1.09 GBytes 9.38 Gbits/sec 1278 563 KBytes [ 4] 7.00-8.00 sec 1.05 GBytes 8.99 Gbits/sec 1226 372 KBytes [ 4] 8.00-9.00 sec 1.03 GBytes 8.87 Gbits/sec 1145 400 KBytes [ 4] 9.00-10.00 sec 1.08 GBytes 9.28 Gbits/sec 1317 354 KBytes - - - - - - - - - - - - - - - - - - - - - - - - - [ ID] Interval Transfer Bandwidth Retr [ 4] 0.00-10.00 sec 10.8 GBytes 9.28 Gbits/sec 13806 sender [ 4] 0.00-10.00 sec 10.8 GBytes 9.28 Gbits/sec receiver Test 2: 12.0-RELEASE, single TCP stream receive, standard mtu, TSO enabled, LRO enabled ====== vmx0: flags=8843 metric 0 mtu 1500 options=60079b $ iperf3 -c <12.0 VM IP> -p 1234 Connecting to host <12.0 VM IP>, port 1234 [ 4] local port 44714 connected to <12.0 VM IP> port 1234 [ ID] Interval Transfer Bandwidth Retr Cwnd [ 4] 0.00-1.00 sec 3.48 GBytes 29.9 Gbits/sec 0 887 KBytes [ 4] 1.00-2.00 sec 1.93 GBytes 16.6 Gbits/sec 0 994 KBytes [ 4] 2.00-3.00 sec 2.03 GBytes 17.5 Gbits/sec 0 1.10 MBytes [ 4] 3.00-4.00 sec 1.99 GBytes 17.1 Gbits/sec 0 1.10 MBytes [ 4] 4.00-5.00 sec 2.00 GBytes 17.1 Gbits/sec 0 1.10 MBytes [ 4] 5.00-6.00 sec 1.93 GBytes 16.6 Gbits/sec 0 1.10 MBytes [ 4] 6.00-7.00 sec 2.04 GBytes 17.5 Gbits/sec 0 1.10 MBytes [ 4] 7.00-8.00 sec 2.01 GBytes 17.3 Gbits/sec 0 1.10 MBytes [ 4] 8.00-9.00 sec 1.97 GBytes 16.9 Gbits/sec 0 1.10 MBytes [ 4] 9.00-10.00 sec 1.98 GBytes 17.0 Gbits/sec 0 1.10 MBytes - - - - - - - - - - - - - - - - - - - - - - - - - [ ID] Interval Transfer Bandwidth Retr [ 4] 0.00-10.00 sec 21.4 GBytes 18.3 Gbits/sec 0 sender [ 4] 0.00-10.00 sec 21.4 GBytes 18.3 Gbits/sec receiver Test 3: 12.0-RELEASE, single TCP stream receive, standard mtu, TSO enabled, LRO disabled (LRO disabled and test run after Test 2 above) ====== vmx0: flags=8843 metric 0 mtu 1500 options=60039b $ iperf3 -c <12.0 VM IP> -p 1234 Connecting to host <12.0 VM IP>, port 1234 [ 4] local port 44718 connected to <12.0 VM IP> port 1234 [ ID] Interval Transfer Bandwidth Retr Cwnd [ 4] 0.00-1.00 sec 1.14 GBytes 9.76 Gbits/sec 1871 338 KBytes [ 4] 1.00-2.00 sec 483 MBytes 4.05 Gbits/sec 1307 1.41 KBytes [ 4] 2.00-3.00 sec 0.00 Bytes 0.00 bits/sec 1 1.41 KBytes [ 4] 3.00-4.00 sec 0.00 Bytes 0.00 bits/sec 0 1.41 KBytes [ 4] 4.00-5.00 sec 0.00 Bytes 0.00 bits/sec 1 1.41 KBytes [ 4] 5.00-6.00 sec 0.00 Bytes 0.00 bits/sec 0 1.41 KBytes [ 4] 6.00-7.00 sec 0.00 Bytes 0.00 bits/sec 0 1.41 KBytes [ 4] 7.00-8.00 sec 0.00 Bytes 0.00 bits/sec 1 1.41 KBytes [ 4] 8.00-9.00 sec 0.00 Bytes 0.00 bits/sec 0 1.41 KBytes [ 4] 9.00-10.00 sec 0.00 Bytes 0.00 bits/sec 0 1.41 KBytes - - - - - - - - - - - - - - - - - - - - - - - - - [ ID] Interval Transfer Bandwidth Retr [ 4] 0.00-10.00 sec 1.61 GBytes 1.38 Gbits/sec 3181 sender [ 4] 0.00-10.00 sec 1.60 GBytes 1.38 Gbits/sec receiver Test 4: 12.0-RELEASE, single TCP stream transmit, standard mtu, TSO enabled, LRO enabled ====== vmx0: flags=8843 metric 0 mtu 1500 options=60079b $ iperf3 -R -c <12.0 VM IP> -p 1234 Connecting to host <12.0 VM IP>, port 1234 Reverse mode, remote host <12.0 VM IP> is sending [ 4] local port 44726 connected to <12.0 VM IP> port 1234 [ ID] Interval Transfer Bandwidth [ 4] 0.00-1.00 sec 4.28 GBytes 36.8 Gbits/sec [ 4] 1.00-2.00 sec 3.31 GBytes 28.4 Gbits/sec [ 4] 2.00-3.00 sec 3.85 GBytes 33.1 Gbits/sec [ 4] 3.00-4.00 sec 4.24 GBytes 36.5 Gbits/sec [ 4] 4.00-5.00 sec 3.16 GBytes 27.1 Gbits/sec [ 4] 5.00-6.00 sec 3.54 GBytes 30.4 Gbits/sec [ 4] 6.00-7.00 sec 4.03 GBytes 34.6 Gbits/sec [ 4] 7.00-8.00 sec 2.93 GBytes 25.1 Gbits/sec [ 4] 8.00-9.00 sec 3.42 GBytes 29.4 Gbits/sec [ 4] 9.00-10.00 sec 3.93 GBytes 33.8 Gbits/sec - - - - - - - - - - - - - - - - - - - - - - - - - [ ID] Interval Transfer Bandwidth Retr [ 4] 0.00-10.00 sec 36.7 GBytes 31.5 Gbits/sec 280 sender [ 4] 0.00-10.00 sec 36.7 GBytes 31.5 Gbits/sec receiver Test 5: 12.1-RELEASE with r356703 applied, single stream receive, standard mtu, TSO enabled, LRO disabled ====== vmx0: flags=8843 metric 0 mtu 1500 options=e403bb $ iperf3 -c <12.1 VM IP> -p 1234 Connecting to host <12.1 VM IP>, port 1234 [ 4] local port 48392 connected to <12.1 VM IP> port 1234 [ ID] Interval Transfer Bandwidth Retr Cwnd [ 4] 0.00-1.00 sec 828 MBytes 6.95 Gbits/sec 1247 335 KBytes [ 4] 1.00-2.00 sec 901 MBytes 7.56 Gbits/sec 1841 345 KBytes [ 4] 2.00-3.00 sec 909 MBytes 7.62 Gbits/sec 1805 356 KBytes [ 4] 3.00-4.00 sec 909 MBytes 7.62 Gbits/sec 2337 322 KBytes [ 4] 4.00-5.00 sec 907 MBytes 7.61 Gbits/sec 1834 354 KBytes [ 4] 5.00-6.00 sec 907 MBytes 7.61 Gbits/sec 1984 352 KBytes [ 4] 6.00-7.00 sec 909 MBytes 7.62 Gbits/sec 2189 329 KBytes [ 4] 7.00-8.00 sec 908 MBytes 7.62 Gbits/sec 2000 338 KBytes [ 4] 8.00-9.00 sec 907 MBytes 7.61 Gbits/sec 2006 315 KBytes [ 4] 9.00-10.00 sec 908 MBytes 7.61 Gbits/sec 1764 332 KBytes - - - - - - - - - - - - - - - - - - - - - - - - - [ ID] Interval Transfer Bandwidth Retr [ 4] 0.00-10.00 sec 8.78 GBytes 7.54 Gbits/sec 19007 sender [ 4] 0.00-10.00 sec 8.78 GBytes 7.54 Gbits/sec receiver Test 6: 12.1-RELEASE with r356703 applied, single stream receive, standard mtu, TSO enabled, LRO disabled, sysctl dev.vmx.0.iflib.tx_abdicate=1 ====== vmx0: flags=8843 metric 0 mtu 1500 options=e403bb $ iperf3 -c <12.1 VM IP> -p 1234 Connecting to host <12.1 VM IP>, port 1234 [ 4] local port 48416 connected to <12.1 VM IP> port 1234 [ ID] Interval Transfer Bandwidth Retr Cwnd [ 4] 0.00-1.00 sec 1.29 GBytes 11.1 Gbits/sec 3016 290 KBytes [ 4] 1.00-2.00 sec 1.33 GBytes 11.4 Gbits/sec 4133 322 KBytes [ 4] 2.00-3.00 sec 1.34 GBytes 11.5 Gbits/sec 5409 335 KBytes [ 4] 3.00-4.00 sec 1.35 GBytes 11.6 Gbits/sec 3899 376 KBytes [ 4] 4.00-5.00 sec 1.35 GBytes 11.6 Gbits/sec 4609 300 KBytes [ 4] 5.00-6.00 sec 1.35 GBytes 11.6 Gbits/sec 4603 303 KBytes [ 4] 6.00-7.00 sec 1.36 GBytes 11.7 Gbits/sec 4417 293 KBytes [ 4] 7.00-8.00 sec 1.34 GBytes 11.5 Gbits/sec 5680 290 KBytes [ 4] 8.00-9.00 sec 1.33 GBytes 11.5 Gbits/sec 5461 359 KBytes [ 4] 9.00-10.00 sec 1.03 GBytes 8.86 Gbits/sec 5060 329 KBytes - - - - - - - - - - - - - - - - - - - - - - - - - [ ID] Interval Transfer Bandwidth Retr [ 4] 0.00-10.00 sec 13.1 GBytes 11.2 Gbits/sec 46287 sender [ 4] 0.00-10.00 sec 13.1 GBytes 11.2 Gbits/sec receiver Test 7: 12.1-RELEASE with r356703 applied, single stream receive, standard mtu, TSO enabled, LRO enabled ====== vmx0: flags=8843 metric 0 mtu 1500 options=e407bb $ iperf3 -c <12.1 VM IP> -p 1234 Connecting to host <12.1 VM IP>, port 1234 [ 4] local port 48396 connected to <12.1 VM IP> port 1234 [ ID] Interval Transfer Bandwidth Retr Cwnd [ 4] 0.00-1.00 sec 98.5 MBytes 826 Mbits/sec 129 2.83 KBytes [ 4] 1.00-2.00 sec 63.6 KBytes 521 Kbits/sec 25 2.83 KBytes [ 4] 2.00-3.00 sec 0.00 Bytes 0.00 bits/sec 25 2.83 KBytes [ 4] 3.00-4.00 sec 0.00 Bytes 0.00 bits/sec 16 2.83 KBytes [ 4] 4.00-5.00 sec 0.00 Bytes 0.00 bits/sec 15 2.83 KBytes [ 4] 5.00-6.00 sec 63.6 KBytes 521 Kbits/sec 15 2.83 KBytes [ 4] 6.00-7.00 sec 0.00 Bytes 0.00 bits/sec 15 2.83 KBytes [ 4] 7.00-8.00 sec 0.00 Bytes 0.00 bits/sec 12 2.83 KBytes [ 4] 8.00-9.00 sec 0.00 Bytes 0.00 bits/sec 15 2.83 KBytes [ 4] 9.00-10.00 sec 0.00 Bytes 0.00 bits/sec 11 1.41 KBytes - - - - - - - - - - - - - - - - - - - - - - - - - [ ID] Interval Transfer Bandwidth Retr [ 4] 0.00-10.00 sec 98.7 MBytes 82.8 Mbits/sec 278 sender [ 4] 0.00-10.00 sec 97.8 MBytes 82.0 Mbits/sec receiver Test 8: 12.1-RELEASE with r356703 applied, single stream transmit, standard mtu, TSO enabled, LRO disabled ====== vmx0: flags=8843 metric 0 mtu 1500 options=e403bb $ iperf3 -R -c <12.1 VM IP> -p 1234 Connecting to host <12.1 VM IP>, port 1234 Reverse mode, remote host <12.1 VM IP> is sending [ 4] local port 48400 connected to <12.1 VM IP> port 1234 [ ID] Interval Transfer Bandwidth [ 4] 0.00-1.00 sec 4.25 GBytes 36.5 Gbits/sec [ 4] 1.00-2.00 sec 3.29 GBytes 28.3 Gbits/sec [ 4] 2.00-3.00 sec 3.61 GBytes 31.0 Gbits/sec [ 4] 3.00-4.00 sec 3.93 GBytes 33.8 Gbits/sec [ 4] 4.00-5.00 sec 4.17 GBytes 35.8 Gbits/sec [ 4] 5.00-6.00 sec 3.53 GBytes 30.3 Gbits/sec [ 4] 6.00-7.00 sec 3.22 GBytes 27.7 Gbits/sec [ 4] 7.00-8.00 sec 3.90 GBytes 33.5 Gbits/sec [ 4] 8.00-9.00 sec 2.80 GBytes 24.1 Gbits/sec [ 4] 9.00-10.00 sec 2.78 GBytes 23.9 Gbits/sec - - - - - - - - - - - - - - - - - - - - - - - - - [ ID] Interval Transfer Bandwidth Retr [ 4] 0.00-10.00 sec 35.5 GBytes 30.5 Gbits/sec 571 sender [ 4] 0.00-10.00 sec 35.5 GBytes 30.5 Gbits/sec receiver Based on the above, it looks like: (1) The non-LRO single-stream TCP receive performance of the iflib vmx driver in 12.1 release lags behind the non-LRO single-stream TCP receive performance of the pre-iflib vmx driver in 12.0 (by about 20%, 7.54 Gbps [Test 5] vs 9.28 Gbps [Test 1]), unless tx_abdicate is enabled, in which case the vmx driver performs better (by about 20%, 11.2 Gbps [Test 6] vs 9.28 Gbps [Test 1]). (2) The TSO-enabled single-stream TCP send performance of the iflib vmx driver in 12.1 release (with TSO bug patch applied) is at parity with the pre-iflib vmx driver in 12.0 (30.5 Gbps [Test 8] and 31.5 Gbps [Test 4]). (3) There are LRO-related bugs in both the pre-iflib vmx driver in 12.0 (see Test 3) and the iflib vmx driver in 12.1 (see Test 7), they just surface differently. The categories of root causes for bugs and performance issues are: bugs in the vmx driver, bugs in iflib, and behavioral variations across the many fielded versions of the VMXNET3 virtual device. Indeed, all of these categories have been encountered in the past year. Also, there is a rich set of driver configuration and operating environment parameters, which makes advancing the overall robustness of the driver (instead of just shifting issues into or out of one's own operating parameter space) an arduous task. I think the right way to approach this is to continue to fill out the test matrix and root cause and resolve all of the issues encountered, rather than argue for reverting to the old driver out of frustration based on a narrow set of (so far, rather poorly characterized) circumstances. I'm in a position to do this, from the standpoint of substantial knowledge of the vmx driver and virtual device, as well as of iflib internals, and I will be doing this, as non-work cycles become available. Best, Patrick From owner-freebsd-net@freebsd.org Tue Feb 25 06:13:13 2020 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id E92E6251C98 for ; Tue, 25 Feb 2020 06:13:13 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id 48RTBd5kShz41H5 for ; Tue, 25 Feb 2020 06:13:13 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id C3CAB251C97; Tue, 25 Feb 2020 06:13:13 +0000 (UTC) Delivered-To: net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id C3734251C96 for ; Tue, 25 Feb 2020 06:13:13 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 48RTBd4p87z41Gj for ; Tue, 25 Feb 2020 06:13:13 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 9B27E9FB2 for ; Tue, 25 Feb 2020 06:13:13 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 01P6DDu3028594 for ; Tue, 25 Feb 2020 06:13:13 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 01P6DDYR028586 for net@FreeBSD.org; Tue, 25 Feb 2020 06:13:13 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: net@FreeBSD.org Subject: [Bug 244247] Kernel panic due to racecondition in ng_eiface shutdown Date: Tue, 25 Feb 2020 06:13:12 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 12.1-STABLE X-Bugzilla-Keywords: crash X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: aleksandr.fedorov@itglobal.com X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: net@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: cc Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 25 Feb 2020 06:13:14 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D244247 Aleksandr Fedorov changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleksandr.fedorov@itglobal. | |com --- Comment #10 from Aleksandr Fedorov --- It seems that there are a race in the function ng_eiface_rmnode(). 613 static int 614 ng_eiface_rmnode(node_p node) 615 { 616 const priv_p priv =3D NG_NODE_PRIVATE(node); 617 struct ifnet *const ifp =3D priv->ifp; 618=20=20=20=20=20 619 /* 620 * the ifnet may be in a different vnet than the netgraph n= ode,=20 621 * hence we have to change the current vnet context here. 622 */ 623 CURVNET_SET_QUIET(ifp->if_vnet); 624 ifmedia_removeall(&priv->media); ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Remove media 625 ether_ifdetach(ifp); ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Detach interface. Remove interface from ifnet's list which protected by WLOCK(). 626 if_free(ifp); 627 CURVNET_RESTORE(); 628 free_unr(V_ng_eiface_unit, priv->unit); 629 free(priv, M_NETGRAPH); 630 NG_NODE_SET_PRIVATE(node, NULL); 631 NG_NODE_UNREF(node); 632 return (0); 633 } So, the media is already removed, but the interface is still available. I think the order should be different, like other interfaces do: 1) Detach interface. 2) Free used resources. Can you test the next patch: Index: sys/netgraph/ng_eiface.c =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D --- sys/netgraph/ng_eiface.c (revision 358308) +++ sys/netgraph/ng_eiface.c (working copy) @@ -621,9 +621,9 @@ * hence we have to change the current vnet context here. */ CURVNET_SET_QUIET(ifp->if_vnet); - ifmedia_removeall(&priv->media); ether_ifdetach(ifp); if_free(ifp); + ifmedia_removeall(&priv->media); CURVNET_RESTORE(); free_unr(V_ng_eiface_unit, priv->unit); free(priv, M_NETGRAPH); --=20 You are receiving this mail because: You are the assignee for the bug.= From owner-freebsd-net@freebsd.org Tue Feb 25 15:57:42 2020 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 2B74925EF7C for ; Tue, 25 Feb 2020 15:57:42 +0000 (UTC) (envelope-from slw@zxy.spb.ru) Received: from zxy.spb.ru (zxy.spb.ru [195.70.199.98]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 48Rk9010gpz4NB7 for ; Tue, 25 Feb 2020 15:57:39 +0000 (UTC) (envelope-from slw@zxy.spb.ru) Received: from slw by zxy.spb.ru with local (Exim 4.86 (FreeBSD)) (envelope-from ) id 1j6caW-000CIV-Vx for freebsd-net@freebsd.org; Tue, 25 Feb 2020 18:57:36 +0300 Date: Tue, 25 Feb 2020 18:57:36 +0300 From: Slawa Olhovchenkov To: freebsd-net@freebsd.org Subject: Re: Chelsio NETMAP performance Message-ID: <20200225155736.GN8012@zxy.spb.ru> References: <20200203201728.GC8028@zxy.spb.ru> <863de9e1-42cc-6f3a-5c1f-1bf737714c9f@FreeBSD.org> <20200203222321.GB8012@zxy.spb.ru> <6868f207-d054-3d45-b60d-eaf7115760c1@FreeBSD.org> <20200204162005.GC8012@zxy.spb.ru> <3a8dfebd-aa26-84ad-a03a-0271b61a89a3@FreeBSD.org> <20200205113832.GE8012@zxy.spb.ru> <20200206015914.GA7071@x270> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200206015914.GA7071@x270> User-Agent: Mutt/1.5.24 (2015-08-30) X-SA-Exim-Connect-IP: X-SA-Exim-Mail-From: slw@zxy.spb.ru X-SA-Exim-Scanned: No (on zxy.spb.ru); SAEximRunCond expanded to false X-Rspamd-Queue-Id: 48Rk9010gpz4NB7 X-Spamd-Bar: / Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=none (mx1.freebsd.org: domain of slw@zxy.spb.ru has no SPF policy when checking 195.70.199.98) smtp.mailfrom=slw@zxy.spb.ru X-Spamd-Result: default: False [0.40 / 15.00]; ARC_NA(0.00)[]; FROM_HAS_DN(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_HAM_LONG(-0.84)[-0.837,0]; MIME_GOOD(-0.10)[text/plain]; TO_DN_NONE(0.00)[]; DMARC_NA(0.00)[zxy.spb.ru]; AUTH_NA(1.00)[]; RCPT_COUNT_ONE(0.00)[1]; NEURAL_SPAM_MEDIUM(0.26)[0.258,0]; RCVD_TLS_LAST(0.00)[]; R_SPF_NA(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:5495, ipnet:195.70.192.0/19, country:RU]; MID_RHS_MATCH_FROM(0.00)[]; IP_SCORE(0.08)[asn: 5495(0.38), country: RU(0.01)]; RCVD_COUNT_TWO(0.00)[2] X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 25 Feb 2020 15:57:42 -0000 On Wed, Feb 05, 2020 at 05:59:14PM -0800, Navdeep Parhar wrote: > On Wed, Feb 05, 2020 at 02:38:32PM +0300, Slawa Olhovchenkov wrote: > > On Tue, Feb 04, 2020 at 12:37:08PM -0800, Navdeep Parhar wrote: > > > > > >> nm_holdoff_tmr_idx is a 0-based index into the list above. So if the > > > >> tmr idx is 0 you are using the 0th (first) value from the list of > > > >> timers. Try increasing nm_holdoff_tmr_idx and see if that brings down > > > >> the interrupt rate under control. > > > >> > > > >> # sysctl hw.cxgbe.nm_holdoff_tmr_idx=3/4/5 > > > > > > > > OK, interrupt rate go down, but interrupt time about same. > > > > (interrupt rate for intel card about 0, compared to 25% chelsio). > > > > > > I think iflib runs a lot of stuff in taskqueues rather than the driver > > > ithread so the CPU accounting may vary. Use dtrace to see if > > > > Don't think this is impact: worker's CPU core w/o any syscalls and > > only w/ bunding workker thread and NIC irq handler show about 100% > > user CPU time. > > > > May be some cache-miss work performed later, at poll(2) time in case > > of intel driver compared to chelsio (do at interrupt time)? > > Could be. While we are here, is it possible for you to try the patches > in these two? > > https://reviews.freebsd.org/D17868 about ~10% performance drop > https://reviews.freebsd.org/D17869 about ~3-5% performance rise. > > > > > netmap_rx_irq is being called by an ithread or a taskqueue to figure out > > > what driver does what. > > > > Can you explain some more? > > I am not sure about dtrace probe to use and later evaluation > > # dtrace -n 'fbt::netmap_rx_irq:entry {stack()}' > > Take a look at the stack and see if it's an ithread or one of iflib's > taskqueues that called netmap_rx_irq. > > Regards, > Navdeep From owner-freebsd-net@freebsd.org Wed Feb 26 05:07:53 2020 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 6AD1A24BC67 for ; Wed, 26 Feb 2020 05:07:53 +0000 (UTC) (envelope-from pkelsey@gmail.com) Received: from mail-io1-f42.google.com (mail-io1-f42.google.com [209.85.166.42]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 48S3hk4hQPz4jkr; Wed, 26 Feb 2020 05:07:50 +0000 (UTC) (envelope-from pkelsey@gmail.com) Received: by mail-io1-f42.google.com with SMTP id h8so1965258iob.2; Tue, 25 Feb 2020 21:07:50 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=4Y4JqzSDdldrh4z0NhmltbkmQbFqiXAJE6X2fpdcC3A=; b=K5XmLcOCjmIVsuGukxlNbPEsPIGRbTf4zbeNGFnfZUSvK+Wh8y5LnBhsLgJ1COLZ6x Rnz35g5gR3ht91i0Vhf6ZjAEdig/7J0kAAg5bknOrkWEpxLdUwyacECcrva9fty10Ojy D9goaJwVfn9G/UenMyuIGq+fUETla3fF//LEKqeSvzBkJ6Ghh6e46UWECz6EZYwldmtm RjNzY86PZmPdIrq0e5k3jGtLI7XMovdu9DprNMq1YBRqOqzff9fUlbTH3Q1XQ++YVXld c4W/aWE2YYg/GjHOa/L1VlL/v4tZzYGL/aI4hHhg5p/gyLL1+ANXmcxlyU7SFXb+0APv klqQ== X-Gm-Message-State: APjAAAXEbOBHtO62lW1rfby/545rq3eK0AtZRiIxbNi4T4zANoNiMpOU up/PwBnMAvldWf/yQvtp8cPvGdxB20aaXEz3scQ9pQ== X-Google-Smtp-Source: APXvYqxz3aC8LsMyF+BLftU1iVyqiCxfKJUdFiYcmQvRVpeUJZaH2DbiowiTZDfjZC957sQ7gCV/MopMW/ufNg3AEmw= X-Received: by 2002:a6b:e202:: with SMTP id z2mr2371788ioc.23.1582693667501; Tue, 25 Feb 2020 21:07:47 -0800 (PST) MIME-Version: 1.0 References: <40c4a4df-3df6-d95d-53c2-eef905ff45b1@FreeBSD.org> <5e5d423b-0711-7454-626a-cc9cb4b004cd@FreeBSD.org> In-Reply-To: From: Patrick Kelsey Date: Wed, 26 Feb 2020 00:07:33 -0500 Message-ID: Subject: Re: terrible if_vmx / vmxnet3 rx performance with lro (post iflib) To: Josh Paetzel , Andriy Gapon Cc: freebsd-net X-Rspamd-Queue-Id: 48S3hk4hQPz4jkr X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of pkelsey@gmail.com designates 209.85.166.42 as permitted sender) smtp.mailfrom=pkelsey@gmail.com X-Spamd-Result: default: False [-3.02 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-0.999,0]; RCVD_TLS_ALL(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; R_SPF_ALLOW(-0.20)[+ip4:209.85.128.0/17]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; DMARC_NA(0.00)[freebsd.org]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; URI_COUNT_ODD(1.00)[15]; IP_SCORE(-2.02)[ip: (-5.37), ipnet: 209.85.128.0/17(-2.99), asn: 15169(-1.67), country: US(-0.05)]; TO_DN_ALL(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[42.166.85.209.list.dnswl.org : 127.0.5.0]; FORGED_SENDER(0.30)[pkelsey@freebsd.org,pkelsey@gmail.com]; RWL_MAILSPIKE_POSSIBLE(0.00)[42.166.85.209.rep.mailspike.net : 127.0.0.17]; MIME_TRACE(0.00)[0:+,1:+,2:~]; R_DKIM_NA(0.00)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; FROM_NEQ_ENVFROM(0.00)[pkelsey@freebsd.org,pkelsey@gmail.com]; RCVD_COUNT_TWO(0.00)[2] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 26 Feb 2020 05:07:53 -0000 On Mon, Feb 24, 2020 at 11:40 PM Patrick Kelsey wrote: > > > On Thu, Feb 20, 2020 at 4:58 PM Josh Paetzel wrote: > >> >> >> On Wed, Feb 19, 2020, at 7:17 AM, Andriy Gapon wrote: >> > On 18/02/2020 16:09, Andriy Gapon wrote: >> > > My general experience with post-iflib vmxnet3 is that vmxnet3 has some >> > > peculiarities that result in a certain "impedance mismatch" with >> iflib. >> > > Although we now have a bit less code and it is a bit more regular, >> there are a >> > > few significant (for us, at least) problems: >> > > - https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=243126 >> > > - https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=240608 >> > >> > By the way, we (Panzura) use these changes to fix or work around the >> above two >> > problems: https://people.freebsd.org/~avg/iflib-vmx.pz.diff >> > >> > Questions / comments are welcome. >> > Especially from people who worked on iflib. >> > >> > > - https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=243392 >> > > - the problem described above >> > > - a couple of issues that we already fixed or worked around >> > > >> > > We are contemplating locally reverting to the pre-iflib vmxnet3 and >> we are >> > > wondering if the conversion was really worth it in general. >> > >> > >> > -- >> > Andriy Gapon >> > _______________________________________________ >> > freebsd-net@freebsd.org mailing list >> > https://lists.freebsd.org/mailman/listinfo/freebsd-net >> > To unsubscribe, send any mail to "freebsd-net-unsubscribe@freebsd.org" >> > >> >> I'd like to follow this up just to make it 100% clear. The problem is a >> ~4x regression in RX performance. It affects stock FreeBSD, including >> 12.1-RELEASE. >> >> In my 40Gbps connected lab single thread iperf receive went from 9Gbps to >> 2.5Gbps. >> >> If this can't be fixed or looked at I'd heavily suggest looking at >> reverting "iflib"ing change in stock FreeBSD. >> >> > Consider these datapoints I collected this evening: > > Hypervisor: ESXi 6.7.0 Build 8169922 > Hardware: Xeon E5-1650 v3 @ 3.50GHz (6 physical cores, HT disabled) > > iperf3 client: a VM on the same vswitch as the VM under test, running > Ubuntu 18.04.3 LTS with 2 vCPUs, 4GB RAM, and a VMXNET3 interface used only > for traffic to the VM under test (this VMXNET3 has checksum offload, > TSO/GSO, and LRO/GRO enabled) > iperf3 server: running on the VM under test, either a 12.0-RELEASE VM > (this is before the vmx iflib conversion), or a 12.1-RELEASE VM (this is > after the vmx iflib conversion) with r356703 applied (the recent TSO bug > fix). Both VMs have 3 vCPUs, but the vmx interface only uses 1 tx and 1 rx > queue, as hw.pci.honor_msi_blacklist is at its default of 0, so MSI is used. > > > Test 1: 12.0-RELEASE, single TCP stream receive, standard mtu, TSO > enabled, LRO disabled > ====== > vmx0: flags=8843 metric 0 mtu 1500 > > options=60039b > $ iperf3 -c <12.0 VM IP> -p 1234 > Connecting to host <12.0 VM IP>, port 1234 > [ 4] local port 44664 connected to <12.0 VM IP> port 1234 > [ ID] Interval Transfer Bandwidth Retr Cwnd > [ 4] 0.00-1.00 sec 1.11 GBytes 9.52 Gbits/sec 1144 529 KBytes > [ 4] 1.00-2.00 sec 1.09 GBytes 9.40 Gbits/sec 1272 369 KBytes > [ 4] 2.00-3.00 sec 1.11 GBytes 9.51 Gbits/sec 1249 344 KBytes > [ 4] 3.00-4.00 sec 1.06 GBytes 9.12 Gbits/sec 1973 369 KBytes > [ 4] 4.00-5.00 sec 1.11 GBytes 9.50 Gbits/sec 1860 370 KBytes > [ 4] 5.00-6.00 sec 1.08 GBytes 9.28 Gbits/sec 1342 396 KBytes > [ 4] 6.00-7.00 sec 1.09 GBytes 9.38 Gbits/sec 1278 563 KBytes > [ 4] 7.00-8.00 sec 1.05 GBytes 8.99 Gbits/sec 1226 372 KBytes > [ 4] 8.00-9.00 sec 1.03 GBytes 8.87 Gbits/sec 1145 400 KBytes > [ 4] 9.00-10.00 sec 1.08 GBytes 9.28 Gbits/sec 1317 354 KBytes > - - - - - - - - - - - - - - - - - - - - - - - - - > [ ID] Interval Transfer Bandwidth Retr > [ 4] 0.00-10.00 sec 10.8 GBytes 9.28 Gbits/sec 13806 > sender > [ 4] 0.00-10.00 sec 10.8 GBytes 9.28 Gbits/sec > receiver > > > Test 2: 12.0-RELEASE, single TCP stream receive, standard mtu, TSO > enabled, LRO enabled > ====== > vmx0: flags=8843 metric 0 mtu 1500 > > options=60079b > $ iperf3 -c <12.0 VM IP> -p 1234 > Connecting to host <12.0 VM IP>, port 1234 > [ 4] local port 44714 connected to <12.0 VM IP> port 1234 > [ ID] Interval Transfer Bandwidth Retr Cwnd > [ 4] 0.00-1.00 sec 3.48 GBytes 29.9 Gbits/sec 0 887 KBytes > [ 4] 1.00-2.00 sec 1.93 GBytes 16.6 Gbits/sec 0 994 KBytes > [ 4] 2.00-3.00 sec 2.03 GBytes 17.5 Gbits/sec 0 1.10 MBytes > [ 4] 3.00-4.00 sec 1.99 GBytes 17.1 Gbits/sec 0 1.10 MBytes > [ 4] 4.00-5.00 sec 2.00 GBytes 17.1 Gbits/sec 0 1.10 MBytes > [ 4] 5.00-6.00 sec 1.93 GBytes 16.6 Gbits/sec 0 1.10 MBytes > [ 4] 6.00-7.00 sec 2.04 GBytes 17.5 Gbits/sec 0 1.10 MBytes > [ 4] 7.00-8.00 sec 2.01 GBytes 17.3 Gbits/sec 0 1.10 MBytes > [ 4] 8.00-9.00 sec 1.97 GBytes 16.9 Gbits/sec 0 1.10 MBytes > [ 4] 9.00-10.00 sec 1.98 GBytes 17.0 Gbits/sec 0 1.10 MBytes > - - - - - - - - - - - - - - - - - - - - - - - - - > [ ID] Interval Transfer Bandwidth Retr > [ 4] 0.00-10.00 sec 21.4 GBytes 18.3 Gbits/sec 0 > sender > [ 4] 0.00-10.00 sec 21.4 GBytes 18.3 Gbits/sec > receiver > > > Test 3: 12.0-RELEASE, single TCP stream receive, standard mtu, TSO > enabled, LRO disabled (LRO disabled and test run after Test 2 above) > ====== > vmx0: flags=8843 metric 0 mtu 1500 > > options=60039b > $ iperf3 -c <12.0 VM IP> -p 1234 > Connecting to host <12.0 VM IP>, port 1234 > [ 4] local port 44718 connected to <12.0 VM IP> port 1234 > [ ID] Interval Transfer Bandwidth Retr Cwnd > [ 4] 0.00-1.00 sec 1.14 GBytes 9.76 Gbits/sec 1871 338 KBytes > [ 4] 1.00-2.00 sec 483 MBytes 4.05 Gbits/sec 1307 1.41 KBytes > [ 4] 2.00-3.00 sec 0.00 Bytes 0.00 bits/sec 1 1.41 KBytes > [ 4] 3.00-4.00 sec 0.00 Bytes 0.00 bits/sec 0 1.41 KBytes > [ 4] 4.00-5.00 sec 0.00 Bytes 0.00 bits/sec 1 1.41 KBytes > [ 4] 5.00-6.00 sec 0.00 Bytes 0.00 bits/sec 0 1.41 KBytes > [ 4] 6.00-7.00 sec 0.00 Bytes 0.00 bits/sec 0 1.41 KBytes > [ 4] 7.00-8.00 sec 0.00 Bytes 0.00 bits/sec 1 1.41 KBytes > [ 4] 8.00-9.00 sec 0.00 Bytes 0.00 bits/sec 0 1.41 KBytes > [ 4] 9.00-10.00 sec 0.00 Bytes 0.00 bits/sec 0 1.41 KBytes > - - - - - - - - - - - - - - - - - - - - - - - - - > [ ID] Interval Transfer Bandwidth Retr > [ 4] 0.00-10.00 sec 1.61 GBytes 1.38 Gbits/sec 3181 > sender > [ 4] 0.00-10.00 sec 1.60 GBytes 1.38 Gbits/sec > receiver > > > Test 4: 12.0-RELEASE, single TCP stream transmit, standard mtu, TSO > enabled, LRO enabled > ====== > vmx0: flags=8843 metric 0 mtu 1500 > > options=60079b > $ iperf3 -R -c <12.0 VM IP> -p 1234 > Connecting to host <12.0 VM IP>, port 1234 > Reverse mode, remote host <12.0 VM IP> is sending > [ 4] local port 44726 connected to <12.0 VM IP> port 1234 > [ ID] Interval Transfer Bandwidth > [ 4] 0.00-1.00 sec 4.28 GBytes 36.8 Gbits/sec > [ 4] 1.00-2.00 sec 3.31 GBytes 28.4 Gbits/sec > [ 4] 2.00-3.00 sec 3.85 GBytes 33.1 Gbits/sec > [ 4] 3.00-4.00 sec 4.24 GBytes 36.5 Gbits/sec > [ 4] 4.00-5.00 sec 3.16 GBytes 27.1 Gbits/sec > [ 4] 5.00-6.00 sec 3.54 GBytes 30.4 Gbits/sec > [ 4] 6.00-7.00 sec 4.03 GBytes 34.6 Gbits/sec > [ 4] 7.00-8.00 sec 2.93 GBytes 25.1 Gbits/sec > [ 4] 8.00-9.00 sec 3.42 GBytes 29.4 Gbits/sec > [ 4] 9.00-10.00 sec 3.93 GBytes 33.8 Gbits/sec > - - - - - - - - - - - - - - - - - - - - - - - - - > [ ID] Interval Transfer Bandwidth Retr > [ 4] 0.00-10.00 sec 36.7 GBytes 31.5 Gbits/sec 280 > sender > [ 4] 0.00-10.00 sec 36.7 GBytes 31.5 Gbits/sec > receiver > > > Test 5: 12.1-RELEASE with r356703 applied, single stream receive, standard > mtu, TSO enabled, LRO disabled > ====== > vmx0: flags=8843 metric 0 mtu 1500 > > options=e403bb > $ iperf3 -c <12.1 VM IP> -p 1234 > Connecting to host <12.1 VM IP>, port 1234 > [ 4] local port 48392 connected to <12.1 VM IP> port 1234 > [ ID] Interval Transfer Bandwidth Retr Cwnd > [ 4] 0.00-1.00 sec 828 MBytes 6.95 Gbits/sec 1247 335 KBytes > [ 4] 1.00-2.00 sec 901 MBytes 7.56 Gbits/sec 1841 345 KBytes > [ 4] 2.00-3.00 sec 909 MBytes 7.62 Gbits/sec 1805 356 KBytes > [ 4] 3.00-4.00 sec 909 MBytes 7.62 Gbits/sec 2337 322 KBytes > [ 4] 4.00-5.00 sec 907 MBytes 7.61 Gbits/sec 1834 354 KBytes > [ 4] 5.00-6.00 sec 907 MBytes 7.61 Gbits/sec 1984 352 KBytes > [ 4] 6.00-7.00 sec 909 MBytes 7.62 Gbits/sec 2189 329 KBytes > [ 4] 7.00-8.00 sec 908 MBytes 7.62 Gbits/sec 2000 338 KBytes > [ 4] 8.00-9.00 sec 907 MBytes 7.61 Gbits/sec 2006 315 KBytes > [ 4] 9.00-10.00 sec 908 MBytes 7.61 Gbits/sec 1764 332 KBytes > - - - - - - - - - - - - - - - - - - - - - - - - - > [ ID] Interval Transfer Bandwidth Retr > [ 4] 0.00-10.00 sec 8.78 GBytes 7.54 Gbits/sec 19007 > sender > [ 4] 0.00-10.00 sec 8.78 GBytes 7.54 Gbits/sec > receiver > > > Test 6: 12.1-RELEASE with r356703 applied, single stream receive, standard > mtu, TSO enabled, LRO disabled, sysctl dev.vmx.0.iflib.tx_abdicate=1 > ====== > vmx0: flags=8843 metric 0 mtu 1500 > > options=e403bb > $ iperf3 -c <12.1 VM IP> -p 1234 > Connecting to host <12.1 VM IP>, port 1234 > [ 4] local port 48416 connected to <12.1 VM IP> port 1234 > [ ID] Interval Transfer Bandwidth Retr Cwnd > [ 4] 0.00-1.00 sec 1.29 GBytes 11.1 Gbits/sec 3016 290 KBytes > [ 4] 1.00-2.00 sec 1.33 GBytes 11.4 Gbits/sec 4133 322 KBytes > [ 4] 2.00-3.00 sec 1.34 GBytes 11.5 Gbits/sec 5409 335 KBytes > [ 4] 3.00-4.00 sec 1.35 GBytes 11.6 Gbits/sec 3899 376 KBytes > [ 4] 4.00-5.00 sec 1.35 GBytes 11.6 Gbits/sec 4609 300 KBytes > [ 4] 5.00-6.00 sec 1.35 GBytes 11.6 Gbits/sec 4603 303 KBytes > [ 4] 6.00-7.00 sec 1.36 GBytes 11.7 Gbits/sec 4417 293 KBytes > [ 4] 7.00-8.00 sec 1.34 GBytes 11.5 Gbits/sec 5680 290 KBytes > [ 4] 8.00-9.00 sec 1.33 GBytes 11.5 Gbits/sec 5461 359 KBytes > [ 4] 9.00-10.00 sec 1.03 GBytes 8.86 Gbits/sec 5060 329 KBytes > - - - - - - - - - - - - - - - - - - - - - - - - - > [ ID] Interval Transfer Bandwidth Retr > [ 4] 0.00-10.00 sec 13.1 GBytes 11.2 Gbits/sec 46287 > sender > [ 4] 0.00-10.00 sec 13.1 GBytes 11.2 Gbits/sec > receiver > > > Test 7: 12.1-RELEASE with r356703 applied, single stream receive, standard > mtu, TSO enabled, LRO enabled > ====== > vmx0: flags=8843 metric 0 mtu 1500 > > options=e407bb > $ iperf3 -c <12.1 VM IP> -p 1234 > Connecting to host <12.1 VM IP>, port 1234 > [ 4] local port 48396 connected to <12.1 VM IP> port 1234 > [ ID] Interval Transfer Bandwidth Retr Cwnd > [ 4] 0.00-1.00 sec 98.5 MBytes 826 Mbits/sec 129 2.83 KBytes > [ 4] 1.00-2.00 sec 63.6 KBytes 521 Kbits/sec 25 2.83 KBytes > [ 4] 2.00-3.00 sec 0.00 Bytes 0.00 bits/sec 25 2.83 KBytes > [ 4] 3.00-4.00 sec 0.00 Bytes 0.00 bits/sec 16 2.83 KBytes > [ 4] 4.00-5.00 sec 0.00 Bytes 0.00 bits/sec 15 2.83 KBytes > [ 4] 5.00-6.00 sec 63.6 KBytes 521 Kbits/sec 15 2.83 KBytes > [ 4] 6.00-7.00 sec 0.00 Bytes 0.00 bits/sec 15 2.83 KBytes > [ 4] 7.00-8.00 sec 0.00 Bytes 0.00 bits/sec 12 2.83 KBytes > [ 4] 8.00-9.00 sec 0.00 Bytes 0.00 bits/sec 15 2.83 KBytes > [ 4] 9.00-10.00 sec 0.00 Bytes 0.00 bits/sec 11 1.41 KBytes > - - - - - - - - - - - - - - - - - - - - - - - - - > [ ID] Interval Transfer Bandwidth Retr > [ 4] 0.00-10.00 sec 98.7 MBytes 82.8 Mbits/sec 278 > sender > [ 4] 0.00-10.00 sec 97.8 MBytes 82.0 Mbits/sec > receiver > > > Test 8: 12.1-RELEASE with r356703 applied, single stream transmit, > standard mtu, TSO enabled, LRO disabled > ====== > vmx0: flags=8843 metric 0 mtu 1500 > > options=e403bb > $ iperf3 -R -c <12.1 VM IP> -p 1234 > Connecting to host <12.1 VM IP>, port 1234 > Reverse mode, remote host <12.1 VM IP> is sending > [ 4] local port 48400 connected to <12.1 VM IP> port 1234 > [ ID] Interval Transfer Bandwidth > [ 4] 0.00-1.00 sec 4.25 GBytes 36.5 Gbits/sec > [ 4] 1.00-2.00 sec 3.29 GBytes 28.3 Gbits/sec > [ 4] 2.00-3.00 sec 3.61 GBytes 31.0 Gbits/sec > [ 4] 3.00-4.00 sec 3.93 GBytes 33.8 Gbits/sec > [ 4] 4.00-5.00 sec 4.17 GBytes 35.8 Gbits/sec > [ 4] 5.00-6.00 sec 3.53 GBytes 30.3 Gbits/sec > [ 4] 6.00-7.00 sec 3.22 GBytes 27.7 Gbits/sec > [ 4] 7.00-8.00 sec 3.90 GBytes 33.5 Gbits/sec > [ 4] 8.00-9.00 sec 2.80 GBytes 24.1 Gbits/sec > [ 4] 9.00-10.00 sec 2.78 GBytes 23.9 Gbits/sec > - - - - - - - - - - - - - - - - - - - - - - - - - > [ ID] Interval Transfer Bandwidth Retr > [ 4] 0.00-10.00 sec 35.5 GBytes 30.5 Gbits/sec 571 > sender > [ 4] 0.00-10.00 sec 35.5 GBytes 30.5 Gbits/sec > receiver > > > Based on the above, it looks like: > > (1) The non-LRO single-stream TCP receive performance of the iflib vmx > driver in 12.1 release lags behind the non-LRO single-stream TCP receive > performance of the pre-iflib vmx driver in 12.0 (by about 20%, 7.54 Gbps > [Test 5] vs 9.28 Gbps [Test 1]), unless tx_abdicate is enabled, in which > case the vmx driver performs better (by about 20%, 11.2 Gbps [Test 6] vs > 9.28 Gbps [Test 1]). > > (2) The TSO-enabled single-stream TCP send performance of the iflib vmx > driver in 12.1 release (with TSO bug patch applied) is at parity with the > pre-iflib vmx driver in 12.0 (30.5 Gbps [Test 8] and 31.5 Gbps [Test 4]). > > (3) There are LRO-related bugs in both the pre-iflib vmx driver in 12.0 > (see Test 3) and the iflib vmx driver in 12.1 (see Test 7), they just > surface differently. > > The categories of root causes for bugs and performance issues are: bugs in > the vmx driver, bugs in iflib, and behavioral variations across the many > fielded versions of the VMXNET3 virtual device. Indeed, all of these > categories have been encountered in the past year. Also, there is a rich > set of driver configuration and operating environment parameters, which > makes advancing the overall robustness of the driver (instead of just > shifting issues into or out of one's own operating parameter space) an > arduous task. > > I think the right way to approach this is to continue to fill out the test > matrix and root cause and resolve all of the issues encountered, rather > than argue for reverting to the old driver out of frustration based on a > narrow set of (so far, rather poorly characterized) circumstances. I'm in > a position to do this, from the standpoint of substantial knowledge of the > vmx driver and virtual device, as well as of iflib internals, and I will be > doing this, as non-work cycles become available. > > I spent a bit of time poking at this, and I believe I have root caused all of the reported issues and developed patches (to both iflib and the vmx driver) that solve them. My test system running 12.1 with these patches applied (as well as the TSO patch) operates correctly with and without TSO and/or LRO enabled, and with large MTU values. It exhibits throughput performance parity or better compared to the pre-iflib driver for the single-core / single-stream tests that I am currently using to assess correctness. The primary issue (that resulted in the reported free-list related assertion failures, use-after-free panics, trouble related to jumbo frames, and trouble with LRO) was that both the vmx driver and iflib needed to be fixed in order to correctly handle the case where the vmx virtual device skips descriptors. It's not known why the virtual device sometimes skips descriptors, but this seems to occur frequently, at least under ESXi, when packets span multiple descriptors. A secondary issue was fixed (secondary in that it impacts performance but not correctness) in which the vmx driver was only ever using cluster-sized receive buffers regardless of the MTU, instead of switching to page-sized buffers when the MTU is sufficiently large. There remains an open question as to whether the vmx virtual device consumes a buffer descriptor or not when the completion descriptor indicates zero length. So far I haven't been able to cause zero-length completions to occur. There also remains a concept fail in iflib concerning the refill of receive descriptor rings that can be worked around, to a point, with a sysctl, but that at some point needs to be fixed properly. iflib limits the number of received packets it will process during a receive interrupt according to a budget value, and then it also limits the number of receive descriptors it will refill according to that same budget value (with a magic constant added to it). Generally, packets can span multiple descriptors, and limiting the refill to essentially the number of packets processed completely fails to address this multiplicity, resulting in terrible performance degradation when multi-segment packets are in heavy use (e.g., with LRO or large MTUs). It will take a bit more time to write up all the associated details, post the patches for review, and update the bugs. I think avg@ will recognize in those details the completion of a number of thoughts that he had while trying to debug this. I also think the TSO patch, as well as the correctness fixes noted above, should at some point wind up in an errata release for 12.1. -Patrick From owner-freebsd-net@freebsd.org Wed Feb 26 12:49:05 2020 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id A1493257420 for ; Wed, 26 Feb 2020 12:49:05 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id 48SFwx1rGhz479V for ; Wed, 26 Feb 2020 12:49:05 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id C062125741F; Wed, 26 Feb 2020 12:49:04 +0000 (UTC) Delivered-To: net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id BB7DE25741E for ; Wed, 26 Feb 2020 12:49:04 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 48SFww2x4Gz4780 for ; Wed, 26 Feb 2020 12:49:04 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id D791D27863 for ; Wed, 26 Feb 2020 12:49:03 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 01QCn3Zm048029 for ; Wed, 26 Feb 2020 12:49:03 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 01QCn3Pn048028 for net@FreeBSD.org; Wed, 26 Feb 2020 12:49:03 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: net@FreeBSD.org Subject: [Bug 187835] ngctl(8) strange behavior when adding more than 530 vlan through netgraph Date: Wed, 26 Feb 2020 12:49:02 +0000 X-Bugzilla-Reason: AssignedTo CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: bin X-Bugzilla-Version: 12.1-STABLE X-Bugzilla-Keywords: needs-qa X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: lutz@donnerhacke.de X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: net@FreeBSD.org X-Bugzilla-Flags: mfc-stable12? mfc-stable11? X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 26 Feb 2020 12:49:05 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D187835 --- Comment #15 from lutz@donnerhacke.de --- Please have a look at D23840 and discuss it in Phabricator. --=20 You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug.= From owner-freebsd-net@freebsd.org Wed Feb 26 12:49:43 2020 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id C8D0A2574A9 for ; Wed, 26 Feb 2020 12:49:43 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id 48SFxg3ZjKz48Tx for ; Wed, 26 Feb 2020 12:49:43 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id 54CBA2574A6; Wed, 26 Feb 2020 12:49:43 +0000 (UTC) Delivered-To: net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 53D312574A5 for ; Wed, 26 Feb 2020 12:49:43 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 48SFxg1P2Lz48TN for ; Wed, 26 Feb 2020 12:49:43 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 0EC662786C for ; Wed, 26 Feb 2020 12:49:43 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 01QCngfr048789 for ; Wed, 26 Feb 2020 12:49:42 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 01QCng4E048788 for net@FreeBSD.org; Wed, 26 Feb 2020 12:49:42 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: net@FreeBSD.org Subject: [Bug 187835] ngctl(8) strange behavior when adding more than 530 vlan through netgraph Date: Wed, 26 Feb 2020 12:49:42 +0000 X-Bugzilla-Reason: CC AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: bin X-Bugzilla-Version: 12.1-STABLE X-Bugzilla-Keywords: needs-qa X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: lutz@donnerhacke.de X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: net@FreeBSD.org X-Bugzilla-Flags: mfc-stable12? mfc-stable11? X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 26 Feb 2020 12:49:43 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D187835 --- Comment #16 from lutz@donnerhacke.de --- (In reply to lutz from comment #15) Link to the patch https://reviews.freebsd.org/D23840 --=20 You are receiving this mail because: You are on the CC list for the bug. You are the assignee for the bug.= From owner-freebsd-net@freebsd.org Wed Feb 26 17:29:55 2020 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 899CB25E1F8 for ; Wed, 26 Feb 2020 17:29:55 +0000 (UTC) (envelope-from daemon-user@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 48SN8z1LWSz441w; Wed, 26 Feb 2020 17:29:54 +0000 (UTC) (envelope-from daemon-user@freebsd.org) Received: from reviews.nyi.freebsd.org (reviews.nyi.freebsd.org [IPv6:2610:1c1:1:607c::16:b]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 6895B2E2B; Wed, 26 Feb 2020 17:29:54 +0000 (UTC) (envelope-from daemon-user@freebsd.org) Received: by reviews.nyi.freebsd.org (Postfix, from userid 1346) id 679E32A1706; Wed, 26 Feb 2020 17:29:54 +0000 (UTC) Date: Wed, 26 Feb 2020 17:29:54 +0000 To: Phabricator From: "neel_neelc.org (Neel Chauhan)" Cc: freebsd-net@freebsd.org Reply-to: "neel_neelc.org (Neel Chauhan)" Subject: [Differential] D23788: DRAFT: ng_ksocket: IPv6 address parsing and unparsing Message-ID: X-Priority: 3 X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: X-Herald-Rules: <28>, <125>, <128>, <67> X-Phabricator-Projects: <#network> X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: Precedence: bulk Thread-Topic: PHID-DREV-isgti776xdsdvju2ufh3 X-Phabricator-Mail-ID: 1840460 X-Phabricator-Send-Attempt: cquznois6vps2i5c In-Reply-To: References: Thread-Index: MWQ0ZDVhYmNlZTMxYjNlZWMyN2FmZTk4YjlhIF5WqxI= X-Phabricator-Stamps: actor(@neel_neelc.org) application(Differential) author(@neel_neelc.org) herald(H28) herald(H67) herald(H125) herald(H128) monogram(D23788) object-type(DREV) phid(PHID-DREV-isgti776xdsdvju2ufh3) reviewer(@hrs) revision-status(needs-review) subscriber(#contributor_reviews_base) subscriber(@freebsd-net-list) subscriber(@hrs) subscriber(@imp) subscriber(@lutz_donnerhacke.de) subscriber(@melifaro) tag(#network) via(web) MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.29 List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 26 Feb 2020 17:29:55 -0000 bmVlbF9uZWVsYy5vcmcgbWFya2VkIDIgaW5saW5lIGNvbW1lbnRzIGFzIGRvbmUuCgpDSEFOR0VT IFNJTkNFIExBU1QgQUNUSU9OCiAgaHR0cHM6Ly9yZXZpZXdzLmZyZWVic2Qub3JnL0QyMzc4OC9u ZXcvCgpSRVZJU0lPTiBERVRBSUwKICBodHRwczovL3Jldmlld3MuZnJlZWJzZC5vcmcvRDIzNzg4 CgpFTUFJTCBQUkVGRVJFTkNFUwogIGh0dHBzOi8vcmV2aWV3cy5mcmVlYnNkLm9yZy9zZXR0aW5n cy9wYW5lbC9lbWFpbHByZWZlcmVuY2VzLwoKVG86IG5lZWxfbmVlbGMub3JnLCBocnMKQ2M6IGhy cywgaW1wLCBsdXR6X2Rvbm5lcmhhY2tlLmRlLCBtZWxpZmFybywgI2NvbnRyaWJ1dG9yX3Jldmll d3NfYmFzZSwgZnJlZWJzZC1uZXQtbGlzdCwgbW1hY3ksIGtwcmF2ZWVuLmxrbWxfZ21haWwuY29t LCBtYXJjbmFyY19nbWFpbC5jb20sIHNpbW9udmVsbGFfZ21haWwuY29tLCBub3ZpY2VfdGVjaGll LmNvbSwgdG9tbWkucGVybmlsYV9pa2kuZmkK From owner-freebsd-net@freebsd.org Wed Feb 26 17:49:39 2020 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 9D4BD25EFB2 for ; Wed, 26 Feb 2020 17:49:39 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id 48SNbk6D3sz4brG for ; Wed, 26 Feb 2020 17:49:38 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id 1732425EFAF; Wed, 26 Feb 2020 17:49:38 +0000 (UTC) Delivered-To: net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 089B225EFAE for ; Wed, 26 Feb 2020 17:49:38 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 48SNbj1rBsz4bpr for ; Wed, 26 Feb 2020 17:49:37 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id D56E631FA for ; Wed, 26 Feb 2020 17:49:36 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 01QHnaUv019934 for ; Wed, 26 Feb 2020 17:49:36 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 01QHnabA019933 for net@FreeBSD.org; Wed, 26 Feb 2020 17:49:36 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: net@FreeBSD.org Subject: [Bug 244247] Kernel panic due to racecondition in ng_eiface shutdown Date: Wed, 26 Feb 2020 17:49:36 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 12.1-STABLE X-Bugzilla-Keywords: crash X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: admin@support.od.ua X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: net@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 26 Feb 2020 17:49:39 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D244247 --- Comment #11 from Vladislav V. Prodan --- I applied the patch and rebuilt the kernel. Kernel panic is no longer there, but in the logs /var/log/messages messages= of the form: ... Feb 26 21:43:17 core kernel: ngeth504: link state changed to DOWN Feb 26 21:43:17 core dhclient[3168]: receive_packet failed on ngeth504: Dev= ice not configured Feb 26 21:43:17 core dhclient[3168]: ioctl(SIOCGIFFLAGS) on ngeth504: Opera= tion not permitted Feb 26 21:43:17 core kernel: if_delmulti_locked: detaching ifnet instance 0xfffff80059e8b000 Feb 26 21:43:17 core syslogd: last message repeated 1 times Feb 26 21:43:17 core kernel: ifaddr cache =3D 0xfffff8000ddf5600 is deleted Feb 26 21:43:17 core kernel: if_delmulti_locked: detaching ifnet instance 0xfffff80059e8b000 Feb 26 21:43:17 core syslogd: last message repeated 3 times Feb 26 21:43:17 core dhclient[3168]: Interface ngeth504 no longer appears valid. Feb 26 21:43:17 core dhclient[3168]: No live interfaces to poll on - exitin= g. Feb 26 21:43:17 core dhclient[3168]: exiting. Feb 26 21:43:17 core dhclient[3168]: connection closed Feb 26 21:43:17 core dhclient[3168]: exiting. Feb 26 21:43:17 core root[3259]: /etc/rc.d/dhclient: WARNING: failed to sta= rt dhclient ... Feb 26 21:46:11 core kernel: ngeth0: link state changed to DOWN Feb 26 21:46:11 core dhclient[3521]: receive_packet failed on ngeth0: Device not configured Feb 26 21:46:11 core dhclient[3521]: ioctl(SIOCGIFFLAGS) on ngeth0: Operati= on not permitted Feb 26 21:46:11 core dhclient[3521]: Interface ngeth0 no longer appears val= id. Feb 26 21:46:11 core dhclient[3521]: No live interfaces to poll on - exitin= g. Feb 26 21:46:11 core dhclient[3521]: exiting. Feb 26 21:46:11 core dhclient[3521]: connection closed Feb 26 21:46:11 core dhclient[3521]: exiting. Feb 26 21:46:11 core root[10207]: /etc/rc.d/dhclient: WARNING: failed to st= art dhclient Feb 26 21:46:11 core kernel: if_delmulti_locked: detaching ifnet instance 0xfffff80059e8e000 Feb 26 21:46:11 core kernel: ifaddr cache =3D 0xfffff80059db2800 is deleted Feb 26 21:46:11 core kernel: if_delmulti_locked: detaching ifnet instance 0xfffff80059e8e000 Feb 26 21:46:11 core syslogd: last message repeated 4 times ... --=20 You are receiving this mail because: You are the assignee for the bug.= From owner-freebsd-net@freebsd.org Wed Feb 26 17:51:20 2020 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id BE81525F1F7 for ; Wed, 26 Feb 2020 17:51:20 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id 48SNdh0YQFz4dkh for ; Wed, 26 Feb 2020 17:51:20 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id 5EE8B25F1F4; Wed, 26 Feb 2020 17:51:19 +0000 (UTC) Delivered-To: net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 5DE2E25F1F3 for ; Wed, 26 Feb 2020 17:51:19 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 48SNdf6Rscz4djl for ; Wed, 26 Feb 2020 17:51:18 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id EF36E324B for ; Wed, 26 Feb 2020 17:51:17 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 01QHpHQK027455 for ; Wed, 26 Feb 2020 17:51:17 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 01QHpHah027454 for net@FreeBSD.org; Wed, 26 Feb 2020 17:51:17 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: net@FreeBSD.org Subject: [Bug 244247] Kernel panic due to racecondition in ng_eiface shutdown Date: Wed, 26 Feb 2020 17:51:17 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 12.1-STABLE X-Bugzilla-Keywords: crash X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: admin@support.od.ua X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: net@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 26 Feb 2020 17:51:20 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D244247 --- Comment #12 from Vladislav V. Prodan --- (In reply to Vladislav V. Prodan from comment #11) And output debug.log: ... Dec 29 04:20:59 core newsyslog[883]: logfile first created Feb 19 18:28:50 core dhclient[1023]: em3 link state up -> down Feb 19 18:28:50 core dhclient[1000]: em2 link state up -> down Feb 19 18:28:50 core dhclient[977]: em1 link state up -> down Feb 19 18:28:50 core dhclient[899]: em0 link state up -> down Feb 19 18:28:53 core dhclient[1023]: em3 link state down -> up Feb 19 18:28:53 core dhclient[1000]: em2 link state down -> up Feb 19 18:28:53 core dhclient[977]: em1 link state down -> up Feb 19 18:28:53 core dhclient[899]: em0 link state down -> up Feb 20 00:52:33 core dhclient[16136]: ioctl(SIOCGIFMEDIA) on ngeth490: Devi= ce not configured Feb 20 00:53:09 core dhclient[20775]: ioctl(SIOCGIFMEDIA) on ngeth500: Devi= ce not configured Feb 20 19:45:32 core dhclient[9911]: ioctl(SIOCGIFMEDIA) on ngeth560: Device not configured Feb 20 20:00:49 core dhclient[1665]: ngeth0 link state up -> down Feb 20 20:12:18 core dhclient[1619]: ioctl(SIOCGIFMEDIA) on ngeth0: Device = not configured Feb 20 20:12:22 core dhclient[3063]: ioctl(SIOCGIFMEDIA) on ngeth409: Device not configured Feb 20 20:22:27 core dhclient[1538]: ioctl(SIOCGIFMEDIA) on ngeth0: Device = not configured Feb 20 20:22:52 core dhclient[7627]: ioctl(SIOCGIFMEDIA) on ngeth0: Device = not configured Feb 20 20:23:19 core dhclient[9421]: ioctl(SIOCGIFMEDIA) on ngeth0: Device = not configured Feb 26 21:43:09 core dhclient[2734]: ioctl(SIOCGIFMEDIA) on ngeth266: Device not configured Feb 26 21:43:15 core dhclient[2963]: ioctl(SIOCGIFMEDIA) on ngeth408: Device not configured Feb 26 21:43:17 core dhclient[3168]: ioctl(SIOCGIFMEDIA) on ngeth504: Device not configured Feb 26 21:46:11 core dhclient[3521]: ngeth0 link state up -> down ... --=20 You are receiving this mail because: You are the assignee for the bug.= From owner-freebsd-net@freebsd.org Wed Feb 26 17:52:37 2020 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id F318825F2F0 for ; Wed, 26 Feb 2020 17:52:36 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id 48SNg844nhz3Br5 for ; Wed, 26 Feb 2020 17:52:36 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id 7B14625F2EF; Wed, 26 Feb 2020 17:52:35 +0000 (UTC) Delivered-To: net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 7821425F2EE for ; Wed, 26 Feb 2020 17:52:35 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 48SNg66FSWz3BpR for ; Wed, 26 Feb 2020 17:52:34 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 43AAD33E3 for ; Wed, 26 Feb 2020 17:52:34 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 01QHqYnf034913 for ; Wed, 26 Feb 2020 17:52:34 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 01QHqYjn034912 for net@FreeBSD.org; Wed, 26 Feb 2020 17:52:34 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: net@FreeBSD.org Subject: [Bug 244247] Kernel panic due to racecondition in ng_eiface shutdown Date: Wed, 26 Feb 2020 17:52:34 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 12.1-STABLE X-Bugzilla-Keywords: crash X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: admin@support.od.ua X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: net@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 26 Feb 2020 17:52:37 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D244247 --- Comment #13 from Vladislav V. Prodan --- (In reply to Vladislav V. Prodan from comment #12) root@core:~ # date Wed Feb 26 21:52:03 EET 2020 --=20 You are receiving this mail because: You are the assignee for the bug.= From owner-freebsd-net@freebsd.org Wed Feb 26 19:03:51 2020 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id B7FB324125B for ; Wed, 26 Feb 2020 19:03:51 +0000 (UTC) (envelope-from daemon-user@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 48SQFM4PR5z443c; Wed, 26 Feb 2020 19:03:51 +0000 (UTC) (envelope-from daemon-user@freebsd.org) Received: from reviews.nyi.freebsd.org (reviews.nyi.freebsd.org [IPv6:2610:1c1:1:607c::16:b]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 9280A44D9; Wed, 26 Feb 2020 19:03:51 +0000 (UTC) (envelope-from daemon-user@freebsd.org) Received: by reviews.nyi.freebsd.org (Postfix, from userid 1346) id 919C43210BE; Wed, 26 Feb 2020 19:03:51 +0000 (UTC) Date: Wed, 26 Feb 2020 19:03:51 +0000 To: Phabricator From: "neel_neelc.org (Neel Chauhan)" Cc: freebsd-net@freebsd.org Reply-to: "neel_neelc.org (Neel Chauhan)" Subject: [Differential] D23788: DRAFT: ng_ksocket: IPv6 address parsing and unparsing Message-ID: X-Priority: 3 X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: , , , X-Herald-Rules: <28>, <125>, <128>, <67>, <8> X-Phabricator-Projects: <#network> X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: Precedence: bulk Thread-Topic: PHID-DREV-isgti776xdsdvju2ufh3 X-Phabricator-Mail-ID: 1840970 X-Phabricator-Send-Attempt: 75qubkfadj4567bn In-Reply-To: References: Thread-Index: MWQ0ZDVhYmNlZTMxYjNlZWMyN2FmZTk4YjlhIF5WwRc= X-Phabricator-Stamps: actor(@neel_neelc.org) application(Differential) author(@neel_neelc.org) herald(H8) herald(H28) herald(H67) herald(H125) herald(H128) monogram(D23788) object-type(DREV) phid(PHID-DREV-isgti776xdsdvju2ufh3) reviewer(#manpages) reviewer(@hrs) revision-repository(rS) revision-status(needs-review) subscriber(#contributor_reviews_base) subscriber(@freebsd-net-list) subscriber(@hrs) subscriber(@imp) subscriber(@lutz_donnerhacke.de) subscriber(@melifaro) tag(#network) via(web) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="b1_fb98b79466cc2c1743d1bafc53b3adc4" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.29 List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 26 Feb 2020 19:03:51 -0000 --b1_fb98b79466cc2c1743d1bafc53b3adc4 Content-Type: text/plain; charset = "utf-8" Content-Transfer-Encoding: base64 bmVlbF9uZWVsYy5vcmcgdXBkYXRlZCB0aGlzIHJldmlzaW9uIHRvIERpZmYgNjg4NTAuCm5lZWxf bmVlbGMub3JnIGVkaXRlZCB0aGUgc3VtbWFyeSBvZiB0aGlzIHJldmlzaW9uLgpuZWVsX25lZWxj Lm9yZyBhZGRlZCBhIGNvbW1lbnQuCkhlcmFsZCBhZGRlZCBhIHJldmlld2VyOiBtYW5wYWdlcy4K CgogIExldCdzIGluY2x1ZGUgYSBtYW4gcGFnZS4KClJFUE9TSVRPUlkKICByUyBGcmVlQlNEIHNy YyByZXBvc2l0b3J5CgpDSEFOR0VTIFNJTkNFIExBU1QgVVBEQVRFCiAgaHR0cHM6Ly9yZXZpZXdz LmZyZWVic2Qub3JnL0QyMzc4OD92cz02ODczMCZpZD02ODg1MAoKQ0hBTkdFUyBTSU5DRSBMQVNU IEFDVElPTgogIGh0dHBzOi8vcmV2aWV3cy5mcmVlYnNkLm9yZy9EMjM3ODgvbmV3LwoKUkVWSVNJ T04gREVUQUlMCiAgaHR0cHM6Ly9yZXZpZXdzLmZyZWVic2Qub3JnL0QyMzc4OAoKQUZGRUNURUQg RklMRVMKICBzaGFyZS9tYW4vbWFuNC9uZ19rc29ja2V0LjQKICBzeXMvbmV0Z3JhcGgvbmdfa3Nv Y2tldC5jCgpFTUFJTCBQUkVGRVJFTkNFUwogIGh0dHBzOi8vcmV2aWV3cy5mcmVlYnNkLm9yZy9z ZXR0aW5ncy9wYW5lbC9lbWFpbHByZWZlcmVuY2VzLwoKVG86IG5lZWxfbmVlbGMub3JnLCBocnMs ICNtYW5wYWdlcwpDYzogaHJzLCBpbXAsIGx1dHpfZG9ubmVyaGFja2UuZGUsIG1lbGlmYXJvLCAj Y29udHJpYnV0b3JfcmV2aWV3c19iYXNlLCBmcmVlYnNkLW5ldC1saXN0LCBtbWFjeSwga3ByYXZl ZW4ubGttbF9nbWFpbC5jb20sIG1hcmNuYXJjX2dtYWlsLmNvbSwgc2ltb252ZWxsYV9nbWFpbC5j b20sIG5vdmljZV90ZWNoaWUuY29tLCB0b21taS5wZXJuaWxhX2lraS5maQo= --b1_fb98b79466cc2c1743d1bafc53b3adc4 Content-Type: text/x-patch; charset=utf-8; name="D23788.68850.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="D23788.68850.patch" ZGlmZiAtLWdpdCBhL3N5cy9uZXRncmFwaC9uZ19rc29ja2V0LmMgYi9zeXMvbmV0Z3JhcGgvbmdf a3NvY2tldC5jCi0tLSBhL3N5cy9uZXRncmFwaC9uZ19rc29ja2V0LmMKKysrIGIvc3lzL25ldGdy YXBoL25nX2tzb2NrZXQuYwpAQCAtNjAsNiArNjAsOSBAQAogI2luY2x1ZGUgPHN5cy91aW8uaD4K ICNpbmNsdWRlIDxzeXMvdW4uaD4KIAorI2luY2x1ZGUgPG5ldC9pZi5oPgorI2luY2x1ZGUgPG5l dC9pZl92YXIuaD4KKwogI2luY2x1ZGUgPG5ldGdyYXBoL25nX21lc3NhZ2UuaD4KICNpbmNsdWRl IDxuZXRncmFwaC9uZXRncmFwaC5oPgogI2luY2x1ZGUgPG5ldGdyYXBoL25nX3BhcnNlLmg+CkBA IC02OCw2ICs3MSw4IEBACiAjaW5jbHVkZSA8bmV0aW5ldC9pbi5oPgogI2luY2x1ZGUgPG5ldGlu ZXQvaXAuaD4KIAorI2luY2x1ZGUgPG5ldGluZXQ2L3Njb3BlNl92YXIuaD4KKwogI2lmZGVmIE5H X1NFUEFSQVRFX01BTExPQwogc3RhdGljIE1BTExPQ19ERUZJTkUoTV9ORVRHUkFQSF9LU09DS0VU LCAibmV0Z3JhcGhfa3NvY2siLAogICAgICJuZXRncmFwaCBrc29jayBub2RlIik7CkBAIC0xNDks NiArMTU0LDE5IEBACiAJeyAiZW5jYXAiLAlJUFBST1RPX0VOQ0FQLAkJUEZfSU5FVAkJfSwKIAl7 ICJkaXZlcnQiLAlJUFBST1RPX0RJVkVSVCwJCVBGX0lORVQJCX0sCiAJeyAicGltIiwJSVBQUk9U T19QSU0sCQlQRl9JTkVUCQl9LAorCXsgImlwNiIsCUlQUFJPVE9fSVBWNiwJCVBGX0lORVQ2CX0s CisJeyAicmF3NiIsCUlQUFJPVE9fUkFXLAkJUEZfSU5FVDYJfSwKKwl7ICJpY21wNiIsCUlQUFJP VE9fSUNNUFY2LAkJUEZfSU5FVDYJfSwKKwl7ICJpZ21wNiIsCUlQUFJPVE9fSUdNUCwJCVBGX0lO RVQ2CX0sCisJeyAidGNwNiIsCUlQUFJPVE9fVENQLAkJUEZfSU5FVDYJfSwKKwl7ICJ1ZHA2IiwJ SVBQUk9UT19VRFAsCQlQRl9JTkVUNgl9LAorCXsgImdyZTYiLAlJUFBST1RPX0dSRSwJCVBGX0lO RVQ2CX0sCisJeyAiZXNwNiIsCUlQUFJPVE9fRVNQLAkJUEZfSU5FVDYJfSwKKwl7ICJhaDYiLAlJ UFBST1RPX0FILAkJUEZfSU5FVDYJfSwKKwl7ICJzd2lwZTYiLAlJUFBST1RPX1NXSVBFLAkJUEZf SU5FVDYJfSwKKwl7ICJlbmNhcDYiLAlJUFBST1RPX0VOQ0FQLAkJUEZfSU5FVDYJfSwKKwl7ICJk aXZlcnQ2IiwJSVBQUk9UT19ESVZFUlQsCQlQRl9JTkVUNgl9LAorCXsgInBpbTYiLAlJUFBST1RP X1BJTSwJCVBGX0lORVQ2CX0sCiAJeyBOVUxMLAkJLTEJCQkJCX0sCiB9OwogCkBAIC0yOTQsMTAg KzMxMiw1MCBAQAogCQlicmVhazsKIAkgICAgfQogCi0jaWYgMAotCWNhc2UgUEZfSU5FVDY6CS8q IFhYWCBpbXBsZW1lbnQgdGhpcyBzb21lZGF5ICovCi0jZW5kaWYKKwljYXNlIFBGX0lORVQ2Ogor CSAgICB7CisJCXN0cnVjdCBzb2NrYWRkcl9pbjYgKmNvbnN0IHNpbjYgPSAoc3RydWN0IHNvY2th ZGRyX2luNiAqKXNhOworCQljaGFyICplcHRyOworCQljaGFyIGFkZHJbSU5FVDZfQUREUlNUUkxF Tl07CisJCWNoYXIgaWZuYW1lWzE2XTsKKwkJdV9sb25nIHBvcnQ7CisJCWJvb2wgaGFzaWZuYW1l ID0gdHJ1ZTsKIAorCQlpZiAoc1sqb2ZmXSA9PSAnWycpCisJCQkoKm9mZikrKzsKKwkJaWYgKChl cHRyID0gc3Ryc3RyKCZzWypvZmZdLCAiJSIpKSA9PSBOVUxMKSB7CisJCQloYXNpZm5hbWUgPSBm YWxzZTsKKwkJCWVwdHIgPSBzdHJzdHIoJnNbKm9mZl0sICJdIik7CisJCX0KKwkJc25wcmludGYo YWRkciwgZXB0ciAtIChzICsgKm9mZiksICIlcyIsICZzWypvZmZdKTsKKwkJKm9mZiArPSAoZXB0 ciAtIChzICsgKm9mZikpOworCQlpZiAoIWluZXRfcHRvbihBRl9JTkVUNiwgYWRkciwgJnNpbjYt PnNpbjZfYWRkcikpCisJCQlyZXR1cm4gKEVJTlZBTCk7CisKKwkJaWYgKGhhc2lmbmFtZSkgewor CQkJdWludDE2X3Qgc2NvcGU7CisKKwkJCWVwdHIgPSBzdHJzdHIoTlVMTCwgIl0iKTsKKwkJCXNu cHJpbnRmKGlmbmFtZSwgZXB0ciAtIChzICsgKm9mZiksICIlcyIsICZzWypvZmZdKTsKKwkJCSpv ZmYgKz0gKGVwdHIgLSAocyArICpvZmYpKTsKKworCQkJaWYgKG50b2hsKHNpbjYtPnNpbjZfYWRk ci5zNl9hZGRyMTZbMF0pICE9IDB4ZmU4MCkKKwkJCQlyZXR1cm4gKEVJTlZBTCk7CisJCQlzY29w ZSA9IGluNl9nZXRzY29wZSgmc2luNi0+c2luNl9hZGRyKTsKKwkJCXNpbjYtPnNpbjZfc2NvcGVf aWQgPQorCQkJICAgIGluNl9nZXRzY29wZXpvbmUoaWZ1bml0KGlmbmFtZSksIHNjb3BlKTsKKwkJ fQorCisJCWlmIChzWypvZmZdID09ICdbJykgeworCQkJKCpvZmYpKys7CisJCQlwb3J0ID0gc3Ry dG91bChzICsgKm9mZiwgJmVwdHIsIDEwKTsKKwkJCWlmIChwb3J0ID4gMHhmZmZmIHx8IGVwdHIg PT0gcyArICpvZmYpCisJCQkJcmV0dXJuIChFSU5WQUwpOworCQkJc2luNi0+c2luNl9wb3J0ID0g aHRvbnMocG9ydCk7CisJCX0KKwkJYnJlYWs7CisJICAgIH0KKwogCWRlZmF1bHQ6CiAJCXJldHVy biAoRUlOVkFMKTsKIAl9CkBAIC0zNTYsOSArNDE0LDIwIEBACiAJCXJldHVybigwKTsKIAkgICAg fQogCi0jaWYgMAotCWNhc2UgUEZfSU5FVDY6CS8qIFhYWCBpbXBsZW1lbnQgdGhpcyBzb21lZGF5 ICovCi0jZW5kaWYKKwljYXNlIFBGX0lORVQ2OgorCSAgICB7CisJCWNvbnN0IHN0cnVjdCBzb2Nr YWRkcl9pbjYgKnNpbjYgPSAoY29uc3Qgc3RydWN0IHNvY2thZGRyX2luNiAqKXNhOworCQljaGFy IGFkZHJbSU5FVDZfQUREUlNUUkxFTl07CisJCQorCQlpbmV0X250b3AoQUZfSU5FVDYsICZzaW42 LT5zaW42X2FkZHIsIGFkZHIsIElORVQ2X0FERFJTVFJMRU4pOworCQlzbGVuICs9IHNucHJpbnRm KGNidWYsIGNidWZsZW4sICJpbmV0Ni9bJXNdIiwgYWRkcik7CisKKwkJaWYgKHNpbjYtPnNpbjZf cG9ydCAhPSAwKSB7CisJCQlzbGVuICs9IHNucHJpbnRmKGNidWYgKyBzdHJsZW4oY2J1ZiksCisJ CQkgICAgY2J1ZmxlbiAtIHN0cmxlbihjYnVmKSwgIjolZCIsCisJCQkgICAgKHVfaW50KW50b2hz KHNpbjYtPnNpbjZfcG9ydCkpOworCQl9CisJICAgIH0KIAogCWRlZmF1bHQ6CiAJCXJldHVybiAo Km5nX2tzb2NrZXRfZ2VuZXJpY19zb2NrYWRkcl90eXBlLnN1cGVydHlwZS0+dW5wYXJzZSkKZGlm ZiAtLWdpdCBhL3NoYXJlL21hbi9tYW40L25nX2tzb2NrZXQuNCBiL3NoYXJlL21hbi9tYW40L25n X2tzb2NrZXQuNAotLS0gYS9zaGFyZS9tYW4vbWFuNC9uZ19rc29ja2V0LjQKKysrIGIvc2hhcmUv bWFuL21hbjQvbmdfa3NvY2tldC40CkBAIC0xODUsNyArMTg1LDggQEAKIGVxdWl2YWxlbnQgb2Yg dGhlIEMgc3RydWN0dXJlCiBpcyBhbiBhY2NlcHRhYmxlIGZvcm0uCiBGb3IgdGhlCi0uRHYgUEZf SU5FVAorLkR2IFBGX0lORVQgLAorLkR2IFBGX0lORVQ2CiBhbmQKIC5EdiBQRl9MT0NBTAogYWRk cmVzcyBmYW1pbGllcywgYSBtb3JlIGNvbnZlbmllbnQgZm9ybSBpcyBhbHNvIHVzZWQsIHdoaWNo IGlzCkBAIC0xOTMsOCArMTk0LDEyIEBACiBhZGRyZXNzLgogRm9yCiAuRHYgUEZfSU5FVCAsCi10 aGUgYWRkcmVzcyBpcyBhbiBJUCBhZGRyZXNzIGZvbGxvd2VkIGJ5IGFuIG9wdGlvbmFsIGNvbG9u IGFuZCBwb3J0IG51bWJlci4KK3RoZSBhZGRyZXNzIGlzIGFuIElQdjQgYWRkcmVzcyBmb2xsb3dl ZCBieSBhbiBvcHRpb25hbCBjb2xvbiBhbmQgcG9ydCBudW1iZXIuCiBGb3IKKy5EdiBQRl9JTkVU NiAsCit0aGUgYWRkcmVzcyBpcyBhbiBJUHY2IGFkZHJlc3MgcG9zc2libHkgZW5jbG9zZWQgaW4g c3F1YXJlIGJyYWNrZXRzIGZvbGxvd2VkCitieSBhbiBvcHRpb25hbCBjb2xvbiBhbmQgcG9ydCBu dW1iZXIuCitGb3IKIC5EdiBQRl9MT0NBTCAsCiB0aGUgYWRkcmVzcyBpcyB0aGUgcGF0aG5hbWUg YXMgYSBkb3VibHkgcXVvdGVkIHN0cmluZy4KIC5QcApAQCAtMjA0LDYgKzIwOSw4IEBACiBsb2Nh bC8iL3RtcC9mb28uc29ja2V0IgogLkl0IER2IFBGX0lORVQKIGluZXQvMTkyLjE2OC4xLjE6MTIz NAorLkl0IER2IFBGX0lORVQKK2luZXQ2L1syMDAxOjoxXToxMjM0CiAuSXQgT3RoZXIKIC5EdiAi XCZ7IGZhbWlseT0xNiBsZW49MTYgZGF0YT1bMHg3MCAweDAwIDB4MDEgMHgyM10gXCZ9IgogLkVs Cgo= --b1_fb98b79466cc2c1743d1bafc53b3adc4-- From owner-freebsd-net@freebsd.org Wed Feb 26 21:56:39 2020 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 87B78247F46 for ; Wed, 26 Feb 2020 21:56:39 +0000 (UTC) (envelope-from daemon-user@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 48SV4l19Jlz3yjk; Wed, 26 Feb 2020 21:56:39 +0000 (UTC) (envelope-from daemon-user@freebsd.org) Received: from reviews.nyi.freebsd.org (reviews.nyi.freebsd.org [IPv6:2610:1c1:1:607c::16:b]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 29D3465E9; Wed, 26 Feb 2020 21:56:38 +0000 (UTC) (envelope-from daemon-user@freebsd.org) Received: by reviews.nyi.freebsd.org (Postfix, from userid 1346) id 26D7136A83B; Wed, 26 Feb 2020 21:56:38 +0000 (UTC) Date: Wed, 26 Feb 2020 21:56:38 +0000 To: Phabricator From: "bcr (Benedict Reuschling)" Cc: freebsd-net@freebsd.org Reply-to: "bcr (Benedict Reuschling)" Subject: [Differential] D23788: DRAFT: ng_ksocket: IPv6 address parsing and unparsing Message-ID: <353c33ae1786af90b56ba7c820b26dd2@localhost.localdomain> X-Priority: 3 X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: , , X-Herald-Rules: <28>, <125>, <128>, <67>, <8> X-Phabricator-Projects: <#network> X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: Precedence: bulk Thread-Topic: PHID-DREV-isgti776xdsdvju2ufh3 X-Phabricator-Mail-ID: 1841509 X-Phabricator-Send-Attempt: f5hwxha2ae635s3w In-Reply-To: References: Thread-Index: MWQ0ZDVhYmNlZTMxYjNlZWMyN2FmZTk4YjlhIF5W6ZY= X-Phabricator-Stamps: actor(@bcr) application(Differential) author(@neel_neelc.org) herald(H8) herald(H28) herald(H67) herald(H125) herald(H128) monogram(D23788) object-type(DREV) phid(PHID-DREV-isgti776xdsdvju2ufh3) reviewer(#manpages) reviewer(@hrs) revision-repository(rS) revision-status(needs-review) subscriber(#contributor_reviews_base) subscriber(@bcr) subscriber(@freebsd-net-list) subscriber(@hrs) subscriber(@imp) subscriber(@lutz_donnerhacke.de) subscriber(@melifaro) tag(#network) via(web) MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.29 List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 26 Feb 2020 21:56:39 -0000 YmNyIGFjY2VwdGVkIHRoaXMgcmV2aXNpb24gYXM6IG1hbnBhZ2VzLgpiY3IgYWRkZWQgYSBjb21t ZW50LgoKCiAgT0sgZnJvbSBtYW5wYWdlcy4KClJFUE9TSVRPUlkKICByUyBGcmVlQlNEIHNyYyBy ZXBvc2l0b3J5CgpDSEFOR0VTIFNJTkNFIExBU1QgQUNUSU9OCiAgaHR0cHM6Ly9yZXZpZXdzLmZy ZWVic2Qub3JnL0QyMzc4OC9uZXcvCgpSRVZJU0lPTiBERVRBSUwKICBodHRwczovL3Jldmlld3Mu ZnJlZWJzZC5vcmcvRDIzNzg4CgpFTUFJTCBQUkVGRVJFTkNFUwogIGh0dHBzOi8vcmV2aWV3cy5m cmVlYnNkLm9yZy9zZXR0aW5ncy9wYW5lbC9lbWFpbHByZWZlcmVuY2VzLwoKVG86IG5lZWxfbmVl bGMub3JnLCBocnMsICNtYW5wYWdlcwpDYzogYmNyLCBocnMsIGltcCwgbHV0el9kb25uZXJoYWNr ZS5kZSwgbWVsaWZhcm8sICNjb250cmlidXRvcl9yZXZpZXdzX2Jhc2UsIGZyZWVic2QtbmV0LWxp c3QsIG1tYWN5LCBrcHJhdmVlbi5sa21sX2dtYWlsLmNvbSwgbWFyY25hcmNfZ21haWwuY29tLCBz aW1vbnZlbGxhX2dtYWlsLmNvbSwgbm92aWNlX3RlY2hpZS5jb20sIHRvbW1pLnBlcm5pbGFfaWtp LmZpCg== From owner-freebsd-net@freebsd.org Thu Feb 27 04:40:01 2020 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 617FD2546EE for ; Thu, 27 Feb 2020 04:40:01 +0000 (UTC) (envelope-from sfourman@gmail.com) Received: from mail-ed1-x544.google.com (mail-ed1-x544.google.com [IPv6:2a00:1450:4864:20::544]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 48Sg263jvKz4Nwd for ; Thu, 27 Feb 2020 04:39:57 +0000 (UTC) (envelope-from sfourman@gmail.com) Received: by mail-ed1-x544.google.com with SMTP id p14so1588799edy.13 for ; Wed, 26 Feb 2020 20:39:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=AupGxkv5Q5KqL8DSiR1jxDGsAajHmmeD68DONUVUAz0=; b=IptEgswSVX7VqowezhjlfIt5ttdaM4f0NIafY0sAk3E4P0EUuw94epfu7D02VVRw76 rvM4Px/gubbwtUrkjLGT+EwSV7+8BH6pa6pXOMXGL8IpqTzSqpAloly8sYvvxkWU8wun 5Vfj+3vqDE12/SutfWQYciU9aJcxQnCkURQLBbUhHRCPdiuiL153CKGC4X5LE9OPvQrS 0kp1mlP9qyx1pi963XxYW0SuJKwUsExvI98aIy8EfacIZXQlJ2kNCmzU5W/Z2WIyoLOB 5MDLvJwJeHDaKM7qr62iZj4DS87t4doUXGNgD39pcj+qwRpVf+4WWgGLUYSO3tBzUzQD PciQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=AupGxkv5Q5KqL8DSiR1jxDGsAajHmmeD68DONUVUAz0=; b=dDlZFCpcg6PIWQ4A5edjMOCGwLRBwcSJZ0LdUZXZcKkZvYtpBRZoP+V4eoR9+zuP8o CtpFwo2nW/1FuAOl7khcDnENqCkTkNbI7kGEllqtHYiROIKtVOzj4GOxXIwTjQb9CYxK M8toHhUtgSdgph5/VO007hRAIbGe4LjF5nnRjfq9aUSGdK6lKZB20nlZGZdSkH3DKiaH EhlQhlAVekxjvaahB8e+RABgnXheZzcMPkWURJ1dYTuEpEAXrOWgll9UkEWb14OHAugP 6W5yEVxTWev67vvnqCyw2R+cOoC6yG6Zvw8xvRGvR8HpDe3C9IQ3u4hzkP5oWJkT6gKa FKKw== X-Gm-Message-State: APjAAAXQASU21pWUUqCFKaFOAtqDh2H0cl+HSzRGBQLR8S272SW61szI QG8W22owD2gW5XRYJKwFDAwgu98I/DhwtG6f/cTfjQ== X-Google-Smtp-Source: APXvYqyog2IQRBsy4HaiwgTYmrX9muxsH5grkodfWl/3osePd4+OaKvP1ns8Oa5BB2PZNQtPW+6o3H26F89R96gxT7Q= X-Received: by 2002:a05:6402:16dc:: with SMTP id r28mr1230331edx.268.1582778395286; Wed, 26 Feb 2020 20:39:55 -0800 (PST) MIME-Version: 1.0 References: <20191217070332.GA32902@admin.sibptus.ru> <20191218161217.GA87036@admin.sibptus.ru> In-Reply-To: <20191218161217.GA87036@admin.sibptus.ru> From: Sam Fourman Date: Wed, 26 Feb 2020 23:39:43 -0500 Message-ID: Subject: Re: l2tp+IPsec client on FreeBSD, VPN gateway on Windows To: Victor Sudakov Cc: freebsd-net@freebsd.org X-Rspamd-Queue-Id: 48Sg263jvKz4Nwd X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20161025 header.b=IptEgswS; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (mx1.freebsd.org: domain of sfourman@gmail.com designates 2a00:1450:4864:20::544 as permitted sender) smtp.mailfrom=sfourman@gmail.com X-Spamd-Result: default: False [-3.00 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20161025]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip6:2a00:1450:4000::/36]; FREEMAIL_FROM(0.00)[gmail.com]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; PREVIOUSLY_DELIVERED(0.00)[freebsd-net@freebsd.org]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; IP_SCORE_FREEMAIL(0.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; DKIM_TRACE(0.00)[gmail.com:+]; RCPT_COUNT_TWO(0.00)[2]; RCVD_IN_DNSWL_NONE(0.00)[4.4.5.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.5.4.1.0.0.a.2.list.dnswl.org : 127.0.5.0]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; IP_SCORE(0.00)[ip: (0.31), ipnet: 2a00:1450::/32(-2.41), asn: 15169(-1.67), country: US(-0.05)]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+,1:+,2:~]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2a00:1450::/32, country:US]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; DWL_DNSWL_NONE(0.00)[gmail.com.dwl.dnswl.org : 127.0.5.0] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 27 Feb 2020 04:40:01 -0000 I am also interested to see a working configuration, I need to connect a FreeBSD client to a Windows Server via L2TP+IPSEC pre-shared key. - Sam Fourman On Wed, Dec 18, 2019 at 11:12 AM Victor Sudakov wrote: > Victor Sudakov wrote: > > > > Could anyone share a working (e.g. personally tested) IPSec+l2tp > > *client* configuration for FreeBSD as VPN client? The VPN gateway is a > > Windows server with a preshared key. > > > > I have a working configuration of mpd5 in l2tp client mode (works just > > fine when the Windows admin makes IPSec optional). > > > > If anyone could suggest an idea why I cannot get past phase 2 with the > following error messages, I'd be most grateful: > > 2019-12-18 21:31:53: INFO: @(#)ipsec-tools 0.8.2 ( > http://ipsec-tools.sourceforge.net) > 2019-12-18 21:31:53: INFO: @(#)This product linked OpenSSL 1.1.1d-freebsd > 10 Sep 2019 (http://www.ope > 2019-12-18 21:31:53: INFO: Reading configuration from > "/usr/local/etc/racoon/racoon.conf" > 2019-12-18 21:31:53: INFO: x.x.x.x[500] used as isakmp port (fd=6) > 2019-12-18 21:31:58: INFO: IPsec-SA request for 176.120.29.249 queued due > to no phase1 found. > 2019-12-18 21:31:58: INFO: initiate new phase 1 negotiation: > x.x.x.x[500]<=>176.120.29.249[500] > 2019-12-18 21:31:58: INFO: begin Identity Protection mode. > 2019-12-18 21:31:58: INFO: received Vendor ID: > draft-ietf-ipsra-isakmp-xauth-06.txt > 2019-12-18 21:31:58: INFO: received Vendor ID: DPD > 2019-12-18 21:31:58: INFO: ISAKMP-SA established > x.x.x.x[500]-176.120.29.249[500] spi:b0457c4692285a7a > 2019-12-18 21:31:59: INFO: initiate new phase 2 negotiation: > x.x.x.x[500]<=>176.120.29.249[500] > 2019-12-18 21:31:59: [176.120.29.249] ERROR: notification > NO-PROPOSAL-CHOSEN received in informational > 2019-12-18 21:32:19: [176.120.29.249] ERROR: notification > INVALID-HASH-INFORMATION received in informa > 2019-12-18 21:32:23: INFO: initiate new phase 2 negotiation: > x.x.x.x[500]<=>176.120.29.249[1701] > 2019-12-18 21:32:23: [176.120.29.249] ERROR: notification > NO-PROPOSAL-CHOSEN received in informational > 2019-12-18 21:32:29: ERROR: 176.120.29.249 give up to get IPsec-SA due to > time up to wait. > 2019-12-18 21:32:43: [176.120.29.249] ERROR: notification > INVALID-HASH-INFORMATION received in informa > 2019-12-18 21:32:53: ERROR: 176.120.29.249 give up to get IPsec-SA due to > time up to wait. > > Here is my racoon.conf: https://termbin.com/82tr > > -- > Victor Sudakov, VAS4-RIPE, VAS47-RIPN > 2:5005/49@fidonet http://vas.tomsk.ru/ > -- Sam Fourman From owner-freebsd-net@freebsd.org Thu Feb 27 15:09:34 2020 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 1DF77244338 for ; Thu, 27 Feb 2020 15:09:34 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (mailman.nyi.freebsd.org [IPv6:2610:1c1:1:606c::50:13]) by mx1.freebsd.org (Postfix) with ESMTP id 48Sx0Y3xdkz4fyr for ; Thu, 27 Feb 2020 15:09:33 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id 2DEB7244324; Thu, 27 Feb 2020 15:09:33 +0000 (UTC) Delivered-To: net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 2A780244323 for ; Thu, 27 Feb 2020 15:09:33 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 48Sx0X1fhpz4fxr for ; Thu, 27 Feb 2020 15:09:32 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 01FD71A90F for ; Thu, 27 Feb 2020 15:09:31 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 01RF9VVR039835 for ; Thu, 27 Feb 2020 15:09:31 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from bugzilla@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 01RF9VXs039832 for net@FreeBSD.org; Thu, 27 Feb 2020 15:09:31 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: bugzilla set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: net@FreeBSD.org Subject: [Bug 242890] vmxnet3: Problem when RSS option is configured Date: Thu, 27 Feb 2020 15:09:30 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: regression X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: commit-hook@freebsd.org X-Bugzilla-Status: In Progress X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: avg@FreeBSD.org X-Bugzilla-Flags: mfc-stable12? mfc-stable11- X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 27 Feb 2020 15:09:34 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D242890 --- Comment #6 from commit-hook@freebsd.org --- A commit references this bug: Author: avg Date: Thu Feb 27 15:08:44 UTC 2020 New revision: 358386 URL: https://svnweb.freebsd.org/changeset/base/358386 Log: MFC r357042: vmxnet3: add support for RSS kernel option We observe at least one problem: if a UDP socket is connect(2)-ed, then a received packet that matches the connection cannot be matched to the corresponding PCB because of an incorrect flow ID. That was oberved for = DNS requests from the libc resolver. We got this problem because FreeBSD r343291 enabled code that can set rsstype of received packets to values other than M_HASHTYPE_OPAQUE_HASH. Earlier that code was under 'ifdef notyet'. The essence of this change is to use the system-wide RSS key instead of some historic hardcoded key when the software RSS is enabled and it is configured to use Toeplitz algorithm (the default). In all other cases, the driver reports the opaque hash type for received packets while still using Toeplitz algorithm with the internal key. PR: 242890 Sponsored by: Panzura Changes: _U stable/12/ stable/12/sys/dev/vmware/vmxnet3/if_vmx.c stable/12/sys/dev/vmware/vmxnet3/if_vmxvar.h stable/12/sys/modules/vmware/vmxnet3/Makefile --=20 You are receiving this mail because: You are on the CC list for the bug.= From owner-freebsd-net@freebsd.org Thu Feb 27 15:11:22 2020 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id A45612444B9 for ; Thu, 27 Feb 2020 15:11:22 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id 48Sx2d75RKz3Dxc for ; Thu, 27 Feb 2020 15:11:21 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id EFDE82444B6; Thu, 27 Feb 2020 15:11:21 +0000 (UTC) Delivered-To: net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id EF5892444B4 for ; Thu, 27 Feb 2020 15:11:21 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 48Sx2c41DRz3Dvs for ; Thu, 27 Feb 2020 15:11:20 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 7834B1A95A for ; Thu, 27 Feb 2020 15:11:20 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 01RFBK9h005181 for ; Thu, 27 Feb 2020 15:11:20 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 01RFBKlY005176 for net@FreeBSD.org; Thu, 27 Feb 2020 15:11:20 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: net@FreeBSD.org Subject: [Bug 242890] vmxnet3: Problem when RSS option is configured Date: Thu, 27 Feb 2020 15:11:20 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: regression X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: avg@FreeBSD.org X-Bugzilla-Status: Closed X-Bugzilla-Resolution: FIXED X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: avg@FreeBSD.org X-Bugzilla-Flags: mfc-stable12? mfc-stable11- X-Bugzilla-Changed-Fields: resolution bug_status Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 27 Feb 2020 15:11:22 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D242890 Andriy Gapon changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|In Progress |Closed --=20 You are receiving this mail because: You are on the CC list for the bug.= From owner-freebsd-net@freebsd.org Thu Feb 27 17:19:04 2020 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 1B47A24831A for ; Thu, 27 Feb 2020 17:19:04 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (mailman.nyi.freebsd.org [IPv6:2610:1c1:1:606c::50:13]) by mx1.freebsd.org (Postfix) with ESMTP id 48Szsz4Nysz3GSZ for ; Thu, 27 Feb 2020 17:19:02 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id B0E39248319; Thu, 27 Feb 2020 17:19:01 +0000 (UTC) Delivered-To: net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id B09F9248318 for ; Thu, 27 Feb 2020 17:19:01 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 48Szsw2t8Nz3GQw for ; Thu, 27 Feb 2020 17:19:00 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 3AFE91C20B for ; Thu, 27 Feb 2020 17:18:59 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 01RHIwhx039937 for ; Thu, 27 Feb 2020 17:18:58 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 01RHIwov039936 for net@FreeBSD.org; Thu, 27 Feb 2020 17:18:58 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: net@FreeBSD.org Subject: [Bug 244247] Kernel panic due to racecondition in ng_eiface shutdown Date: Thu, 27 Feb 2020 17:18:58 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 12.1-STABLE X-Bugzilla-Keywords: crash X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: aleksandr.fedorov@itglobal.com X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: net@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 27 Feb 2020 17:19:04 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D244247 --- Comment #14 from Aleksandr Fedorov --- These messages looks to me as expected: Feb 26 21:46:11 core dhclient[3521]: receive_packet failed on ngeth0: Device not configured Feb 26 21:46:11 core dhclient[3521]: ioctl(SIOCGIFFLAGS) on ngeth0: Operati= on not permitted Feb 26 21:46:11 core dhclient[3521]: Interface ngeth0 no longer appears val= id. Feb 26 21:46:11 core dhclient[3521]: No live interfaces to poll on - exitin= g. Feb 26 21:46:11 core dhclient[3521]: exiting. Feb 26 21:46:11 core dhclient[3521]: connection closed Feb 26 21:46:11 core dhclient[3521]: exiting. But these need further research: Feb 26 21:43:17 core kernel: ifaddr cache =3D 0xfffff8000ddf5600 is deleted Feb 26 21:43:17 core kernel: if_delmulti_locked: detaching ifnet instance 0xfffff80059e8b000 --=20 You are receiving this mail because: You are the assignee for the bug.= From owner-freebsd-net@freebsd.org Fri Feb 28 02:37:54 2020 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id C2A52256F86 for ; Fri, 28 Feb 2020 02:37:54 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id 48TDGp4Qtmz3Nn8 for ; Fri, 28 Feb 2020 02:37:54 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id 97D3A256F85; Fri, 28 Feb 2020 02:37:54 +0000 (UTC) Delivered-To: net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 977C9256F84 for ; Fri, 28 Feb 2020 02:37:54 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 48TDGp3N00z3Nmy for ; Fri, 28 Feb 2020 02:37:54 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 6EF4222BAB for ; Fri, 28 Feb 2020 02:37:54 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 01S2bs0F045179 for ; Fri, 28 Feb 2020 02:37:54 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 01S2bsWx045178 for net@FreeBSD.org; Fri, 28 Feb 2020 02:37:54 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: net@FreeBSD.org Subject: [Bug 221445] The absence of the accept_rtadv option causes an error "ping6: sendmsg: No buffer space available" Date: Fri, 28 Feb 2020 02:37:53 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: bin X-Bugzilla-Version: 11.1-STABLE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: admin@support.od.ua X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: net@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 28 Feb 2020 02:37:54 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D221445 --- Comment #5 from Vladislav V. Prodan --- A similar problem. Hetzner data center. The server is loaded into rescue mode with FreeBSD 12.0 x64. [root@rescue ~]# uname -a FreeBSD core.domain.com 12.0-RELEASE FreeBSD 12.0-RELEASE r341666 GENERIC=20 amd64 # I turn on ipv6 sysctl net.inet6.ip6.accept_rtadv=3D1 ifconfig igb0 inet6 2a01:4f8:241:XXXX::2/64 route -6 add default -iface igb0 # ping6 -c 4 ya.ru PING6(56=3D40+8+8 bytes) 2a01:4f8:241:XXXX::2 --> 2a02:6b8::2:242 ping6: sendmsg: No buffer space available ping6: wrote ya.ru 16 chars, ret=3D-1 ping6: sendmsg: No buffer space available ping6: wrote ya.ru 16 chars, ret=3D-1 ping6: sendmsg: No buffer space available ping6: wrote ya.ru 16 chars, ret=3D-1 ping6: sendmsg: No buffer space available ping6: wrote ya.ru 16 chars, ret=3D-1 --- ya.ru ping6 statistics --- 4 packets transmitted, 0 packets received, 100.0% packet loss [root@rescue ~]# ifconfig igb0: flags=3D8843 metric 0 mtu 1500 =20=20=20=20=20=20=20 options=3De507bb ether 00:1e:67:b4:f9:e7 inet 116.202.XXX.XXX netmask 0xffffffc0 broadcast 116.202.XXX.XXX inet6 2a01:4f8:241:XXXX::2 prefixlen 64 inet6 fe80::21e:67ff:feb4:f9e7%igb0 prefixlen 64 scopeid 0x1 media: Ethernet autoselect (1000baseT ) status: active nd6 options=3D21 lo0: flags=3D8049 metric 0 mtu 16384 options=3D680003 inet6 ::1 prefixlen 128 inet6 fe80::1%lo0 prefixlen 64 scopeid 0x2 inet 127.0.0.1 netmask 0xff000000 groups: lo nd6 options=3D21 [root@rescue ~]# netstat -rn6 Routing tables Internet6: Destination Gateway Flags N= etif Expire ::/96 ::1 UGRS = lo0 default 00:1e:67:b4:f9:e7 US = igb0 ::1 link#2 UH = lo0 ::ffff:0.0.0.0/96 ::1 UGRS = lo0 2a01:4f8:241:XXXX::/64 link#1 U = igb0 2a01:4f8:241:XXXX::2 link#1 UHS = lo0 fe80::/10 ::1 UGRS = lo0 fe80::%igb0/64 link#1 U = igb0 fe80::21e:67ff:feb4:f9e7%igb0 link#1 UHS = lo0 fe80::%lo0/64 link#2 U = lo0 fe80::1%lo0 link#2 UHS = lo0 ff02::/16 ::1 UGRS = lo0 --=20 You are receiving this mail because: You are the assignee for the bug.= From owner-freebsd-net@freebsd.org Fri Feb 28 02:38:52 2020 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 14C1625706E for ; Fri, 28 Feb 2020 02:38:52 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (mailman.nyi.freebsd.org [IPv6:2610:1c1:1:606c::50:13]) by mx1.freebsd.org (Postfix) with ESMTP id 48TDHv6h3Sz3PZ9 for ; Fri, 28 Feb 2020 02:38:51 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id E02D225706D; Fri, 28 Feb 2020 02:38:51 +0000 (UTC) Delivered-To: net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id DFE0225706C for ; Fri, 28 Feb 2020 02:38:51 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 48TDHv5KTCz3PYr for ; Fri, 28 Feb 2020 02:38:51 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id AD8E822BAF for ; Fri, 28 Feb 2020 02:38:51 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 01S2cp1r046403 for ; Fri, 28 Feb 2020 02:38:51 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 01S2cpbZ046400 for net@FreeBSD.org; Fri, 28 Feb 2020 02:38:51 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: net@FreeBSD.org Subject: [Bug 221445] The absence of the accept_rtadv option causes an error "ping6: sendmsg: No buffer space available" Date: Fri, 28 Feb 2020 02:38:52 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: bin X-Bugzilla-Version: 11.1-STABLE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: admin@support.od.ua X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: net@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 28 Feb 2020 02:38:52 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D221445 --- Comment #6 from Vladislav V. Prodan --- (In reply to Vladislav V. Prodan from comment #5) [root@rescue ~]# kldstat Id Refs Address Size Name 1 14 0xffffffff80200000 243cd00 kernel 2 1 0xffffffff89e21000 81f0 tmpfs.ko 3 1 0xffffffff89e2a000 247e20 zfs.ko 4 1 0xffffffff8a072000 7628 opensolaris.ko 5 1 0xffffffff8a07a000 1fd4 geom_nop.ko [root@rescue ~]# netstat -m 4196/4669/8865 mbufs in use (current/cache/total) 4103/2671/6774/4000000 mbuf clusters in use (current/cache/total/max) 7/2017 mbuf+clusters out of packet secondary zone in use (current/cache) 0/17/17/1004726 4k (page size) jumbo clusters in use (current/cache/total/m= ax) 0/0/0/297696 9k jumbo clusters in use (current/cache/total/max) 0/0/0/167454 16k jumbo clusters in use (current/cache/total/max) 9255K/6577K/15832K bytes allocated to network (current/cache/total) 0/0/0 requests for mbufs denied (mbufs/clusters/mbuf+clusters) 0/0/0 requests for mbufs delayed (mbufs/clusters/mbuf+clusters) 0/0/0 requests for jumbo clusters delayed (4k/9k/16k) 0/0/0 requests for jumbo clusters denied (4k/9k/16k) 0 sendfile syscalls 0 sendfile syscalls completed without I/O request 0 requests for I/O initiated by sendfile 0 pages read by sendfile as part of a request 0 pages were valid at time of a sendfile request 0 pages were valid and substituted to bogus page 0 pages were requested for read ahead by applications 0 pages were read ahead by sendfile 0 times sendfile encountered an already busy page 0 requests for sfbufs denied 0 requests for sfbufs delayed --=20 You are receiving this mail because: You are the assignee for the bug.= From owner-freebsd-net@freebsd.org Fri Feb 28 02:43:15 2020 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 7ABC9257464 for ; Fri, 28 Feb 2020 02:43:15 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (mailman.nyi.freebsd.org [IPv6:2610:1c1:1:606c::50:13]) by mx1.freebsd.org (Postfix) with ESMTP id 48TDNz2DNGz3ydY for ; Fri, 28 Feb 2020 02:43:15 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id 4C392257463; Fri, 28 Feb 2020 02:43:15 +0000 (UTC) Delivered-To: net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 4BFFA257461 for ; Fri, 28 Feb 2020 02:43:15 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 48TDNz1BV9z3ydN for ; Fri, 28 Feb 2020 02:43:15 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 2176522D8D for ; Fri, 28 Feb 2020 02:43:15 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 01S2hFN0065818 for ; Fri, 28 Feb 2020 02:43:15 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 01S2hF0I065817 for net@FreeBSD.org; Fri, 28 Feb 2020 02:43:15 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: net@FreeBSD.org Subject: [Bug 221445] The absence of the accept_rtadv option causes an error "ping6: sendmsg: No buffer space available" Date: Fri, 28 Feb 2020 02:43:15 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: bin X-Bugzilla-Version: 11.1-STABLE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: admin@support.od.ua X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: net@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 28 Feb 2020 02:43:15 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D221445 --- Comment #7 from Vladislav V. Prodan --- (In reply to Vladislav V. Prodan from comment #6) I apologize, it was necessary to assign the gateway for ipv6 correctly. route -6 change default fe80::1%igb0 --=20 You are receiving this mail because: You are the assignee for the bug.= From owner-freebsd-net@freebsd.org Fri Feb 28 14:51:11 2020 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 53E71264689 for ; Fri, 28 Feb 2020 14:51:11 +0000 (UTC) (envelope-from slw@zxy.spb.ru) Received: from zxy.spb.ru (zxy.spb.ru [195.70.199.98]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 48TXXr49F1z4HnC for ; Fri, 28 Feb 2020 14:51:08 +0000 (UTC) (envelope-from slw@zxy.spb.ru) Received: from slw by zxy.spb.ru with local (Exim 4.86 (FreeBSD)) (envelope-from ) id 1j7gyl-000LAa-Bi; Fri, 28 Feb 2020 17:51:03 +0300 Date: Fri, 28 Feb 2020 17:51:03 +0300 From: Slawa Olhovchenkov To: Hans Petter Selasky Cc: Nick Rogers , "freebsd-net@freebsd.org" Subject: Re: Intel ix staled under heavy load Message-ID: <20200228145103.GQ8012@zxy.spb.ru> References: <20200114145443.GG38096@zxy.spb.ru> <1deada88-beae-9747-d505-5fe142dd5c37@selasky.org> <20200114150740.GH38096@zxy.spb.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) X-SA-Exim-Connect-IP: X-SA-Exim-Mail-From: slw@zxy.spb.ru X-SA-Exim-Scanned: No (on zxy.spb.ru); SAEximRunCond expanded to false X-Rspamd-Queue-Id: 48TXXr49F1z4HnC X-Spamd-Bar: / Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=none (mx1.freebsd.org: domain of slw@zxy.spb.ru has no SPF policy when checking 195.70.199.98) smtp.mailfrom=slw@zxy.spb.ru X-Spamd-Result: default: False [0.57 / 15.00]; ARC_NA(0.00)[]; TO_DN_EQ_ADDR_SOME(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; TO_DN_SOME(0.00)[]; IP_SCORE(0.08)[asn: 5495(0.38), country: RU(0.01)]; MIME_GOOD(-0.10)[text/plain]; RCVD_TLS_LAST(0.00)[]; DMARC_NA(0.00)[zxy.spb.ru]; AUTH_NA(1.00)[]; NEURAL_SPAM_MEDIUM(0.05)[0.047,0]; NEURAL_HAM_LONG(-0.46)[-0.457,0]; TO_MATCH_ENVRCPT_SOME(0.00)[]; R_SPF_NA(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:5495, ipnet:195.70.192.0/19, country:RU]; FREEMAIL_CC(0.00)[gmail.com]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_COUNT_TWO(0.00)[2] X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 28 Feb 2020 14:51:11 -0000 On Wed, Jan 15, 2020 at 09:41:06AM +0100, Hans Petter Selasky wrote: > On 2020-01-14 19:26, Nick Rogers wrote: > > On Tue, Jan 14, 2020 at 10:09 AM Hans Petter Selasky > > wrote: > > > >> On 2020-01-14 16:07, Slawa Olhovchenkov wrote: > >>>> this is a known issue in iflib. > >>> Unresolved? > >> > >> See mail I sent off-list. > >> > > > > I would be interested to know if this is resolved or not as well. > > > > No, not yet. > > Slawa, can you dump the iflib sysctl's when the card is in the stalled > state? I am see individual stalled RX queue. For this case: a) rxd_tail == rxd_head (in normal case w/o traffic rxd_tail == rxd_head-1) b) rxq_fl0.cidx == rxd_tail (in normal case w/o traffic rxq_fl0.cidx == rxd_head) For example1: # sysctl dev.ix | grep -e rxd_ -e rxq_fl0.cidx dev.ix.1.queue3.rxd_tail: 1693 dev.ix.1.queue3.rxd_head: 1694 dev.ix.1.queue2.rxd_tail: 1917 dev.ix.1.queue2.rxd_head: 1918 dev.ix.1.queue1.rxd_tail: 1628 dev.ix.1.queue1.rxd_head: 1629 dev.ix.1.queue0.rxd_tail: 161 dev.ix.1.queue0.rxd_head: 162 dev.ix.1.iflib.rxq3.rxq_fl0.cidx: 1694 dev.ix.1.iflib.rxq2.rxq_fl0.cidx: 1918 dev.ix.1.iflib.rxq1.rxq_fl0.cidx: 1629 dev.ix.1.iflib.rxq0.rxq_fl0.cidx: 162 dev.ix.0.queue3.rxd_tail: 1141 dev.ix.0.queue3.rxd_head: 1142 dev.ix.0.queue2.rxd_tail: 1598 dev.ix.0.queue2.rxd_head: 1598 ^^^^^^^^^^^ dev.ix.0.queue1.rxd_tail: 720 dev.ix.0.queue1.rxd_head: 721 dev.ix.0.queue0.rxd_tail: 1356 dev.ix.0.queue0.rxd_head: 1356 ^^^^^^^ dev.ix.0.iflib.rxq3.rxq_fl0.cidx: 1142 dev.ix.0.iflib.rxq2.rxq_fl0.cidx: 1598 dev.ix.0.iflib.rxq1.rxq_fl0.cidx: 721 dev.ix.0.iflib.rxq0.rxq_fl0.cidx: 1356 For example2: # sysctl dev.ix | grep -e rxd_ -e rxq_fl0.cidx dev.ix.0.queue3.rxd_tail: 205 dev.ix.0.queue3.rxd_head: 240 dev.ix.0.queue2.rxd_tail: 1566 dev.ix.0.queue2.rxd_head: 1566 ^^^^^^^^^^^^^^ dev.ix.0.queue1.rxd_tail: 1371 dev.ix.0.queue1.rxd_head: 1456 dev.ix.0.queue0.rxd_tail: 1120 dev.ix.0.queue0.rxd_head: 1120 ^^^^^^^^^^ dev.ix.0.iflib.rxq3.rxq_fl0.cidx: 708 dev.ix.0.iflib.rxq2.rxq_fl0.cidx: 1566 dev.ix.0.iflib.rxq1.rxq_fl0.cidx: 1764 dev.ix.0.iflib.rxq0.rxq_fl0.cidx: 1120 From owner-freebsd-net@freebsd.org Fri Feb 28 17:31:48 2020 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 3D526267E20 for ; Fri, 28 Feb 2020 17:31:48 +0000 (UTC) (envelope-from vmaffione@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 48Tc6C6ktSz3Pys for ; Fri, 28 Feb 2020 17:31:47 +0000 (UTC) (envelope-from vmaffione@freebsd.org) Received: from mail-qk1-f182.google.com (mail-qk1-f182.google.com [209.85.222.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) (Authenticated sender: vmaffione) by smtp.freebsd.org (Postfix) with ESMTPSA id B22B43334 for ; Fri, 28 Feb 2020 17:31:47 +0000 (UTC) (envelope-from vmaffione@freebsd.org) Received: by mail-qk1-f182.google.com with SMTP id u124so3664635qkh.13 for ; Fri, 28 Feb 2020 09:31:47 -0800 (PST) X-Gm-Message-State: APjAAAW/dZFJI2i6wKYZoM0h6au6NMwdwdikFVUGhyY+hetQZN3tX2By CzAvb1FwObIv9M8z0ZnZFouwoJ2gBh/P+lXSudA= X-Google-Smtp-Source: APXvYqxc3uIz2C7tCvmoQP+E6DFmQlSe4NwwOBGAmMLjFYBZjBByzNnTExAaEudQqJ/kv+JR+nvdA9w3X0kCqb2nfIo= X-Received: by 2002:a37:61c3:: with SMTP id v186mr5420920qkb.96.1582911106943; Fri, 28 Feb 2020 09:31:46 -0800 (PST) MIME-Version: 1.0 References: <20200203204447.GD8028@zxy.spb.ru> <20200225150924.GM8012@zxy.spb.ru> <20200227201650.GO8012@zxy.spb.ru> In-Reply-To: <20200227201650.GO8012@zxy.spb.ru> From: Vincenzo Maffione Date: Fri, 28 Feb 2020 18:31:36 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: Intel NETMAP performance and packet type To: Slawa Olhovchenkov , FreeBSD Net Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 28 Feb 2020 17:31:48 -0000 Il giorno gio 27 feb 2020 alle ore 21:17 Slawa Olhovchenkov ha scritto: > On Thu, Feb 27, 2020 at 06:51:54PM +0100, Vincenzo Maffione wrote: > > > Hi, > > So, the issue is not the payload. > > If you look at the avg_batch statistics reported by pkt-gen, you'll see > > that in the ACK-flood experiment you have 4.92, whereas in the SYN-flood > > case you have 17.5. The batch is the number of packets (well, actually > > netmap descriptors, but in this case it's the same) that you receive (or > > transmit) for each poll() invocation. > > So in the first case you end up doing much more poll() calls, hence the > > higher per-packet overhead and the lower packet-rate. > > > > Why is the poll() called more frequently? That depends on packet timing > and > > interrupt rate. There must be something different on your packet > generator > > that produces this effect (e.g. different burstiness, or maybe the packet > > generator is not able to saturate the 10G link)? > > No, I am capture netstat output -- raw packet rate is the same. > Also, I am change card to chelsio T5 and don't see issuse. > > This is payload issuse, at driver level. > That's not possible, since netmap does not even look into the payload. Can you please report the per-queue interrupt rate in both cases (ACK-flood and SYN-flood)? You can use something like `vmstat -i -w1 | grep ix` to monitor the interrupt rate. Or probably you can also use `sysctl -a dev.ix | grep interrupt_rate` > > In any case, I would suggest measuring the RX interrupt rate, and check > > that it's higher in the ACK-flood case. Then you can try to lower the > > interrupt rate by tuning the interrupt moderation features of the Intel > NIC > > (e,g. limit hw.ix.max_interrupt_rate and disable hw.ix.enable_aim or > > similar). > > By playing with the interrupt moderation you should be able to increase > the > > avg_batch, and then increase throghput. > > Already limited. > Limited to which value? Have you tried to decrease max_interrupt_rate even more? > > > Cheers, > > Vincenzo > > > From owner-freebsd-net@freebsd.org Fri Feb 28 17:37:35 2020 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 2E70F24026C for ; Fri, 28 Feb 2020 17:37:35 +0000 (UTC) (envelope-from vmaffione@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 48TcDt4xP3z48rT for ; Fri, 28 Feb 2020 17:37:34 +0000 (UTC) (envelope-from vmaffione@freebsd.org) Received: from mail-qk1-f175.google.com (mail-qk1-f175.google.com [209.85.222.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) (Authenticated sender: vmaffione) by smtp.freebsd.org (Postfix) with ESMTPSA id 276A83337 for ; Fri, 28 Feb 2020 17:37:34 +0000 (UTC) (envelope-from vmaffione@freebsd.org) Received: by mail-qk1-f175.google.com with SMTP id m2so3722364qka.7 for ; Fri, 28 Feb 2020 09:37:34 -0800 (PST) X-Gm-Message-State: APjAAAXG2IMmzorPhh2uqPlHl49Aci+MDXobg/lQbA4bAzwy3LwqFqM9 wJCx5fsfmtYrGqE6WG+yZNGFGf6slxhL8gWfUqI= X-Google-Smtp-Source: APXvYqwFuchNJkKc+zmev0av1VhvsQ4UyoD0pqODdYIVplrdcbRq/Pqi6JEpYfmAvhfhR62t6aHTu2+avtjvKDYEATA= X-Received: by 2002:ae9:c119:: with SMTP id z25mr4868153qki.407.1582911453736; Fri, 28 Feb 2020 09:37:33 -0800 (PST) MIME-Version: 1.0 References: <20200203204447.GD8028@zxy.spb.ru> <20200225150924.GM8012@zxy.spb.ru> <20200227201650.GO8012@zxy.spb.ru> <20200228112602.GP8012@zxy.spb.ru> In-Reply-To: <20200228112602.GP8012@zxy.spb.ru> From: Vincenzo Maffione Date: Fri, 28 Feb 2020 18:37:22 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: Intel NETMAP performance and packet type To: Slawa Olhovchenkov , FreeBSD Net Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 28 Feb 2020 17:37:35 -0000 Il giorno ven 28 feb 2020 alle ore 12:26 Slawa Olhovchenkov ha scritto: > On Thu, Feb 27, 2020 at 11:16:50PM +0300, Slawa Olhovchenkov wrote: > > > On Thu, Feb 27, 2020 at 06:51:54PM +0100, Vincenzo Maffione wrote: > > > > > Hi, > > > So, the issue is not the payload. > > > If you look at the avg_batch statistics reported by pkt-gen, you'll see > > > that in the ACK-flood experiment you have 4.92, whereas in the > SYN-flood > > > case you have 17.5. The batch is the number of packets (well, actually > > > netmap descriptors, but in this case it's the same) that you receive > (or > > > transmit) for each poll() invocation. > > > So in the first case you end up doing much more poll() calls, hence the > > > higher per-packet overhead and the lower packet-rate. > > > > > > Why is the poll() called more frequently? That depends on packet > timing and > > > interrupt rate. There must be something different on your packet > generator > > > that produces this effect (e.g. different burstiness, or maybe the > packet > > > generator is not able to saturate the 10G link)? > > > > No, I am capture netstat output -- raw packet rate is the same. > > Also, I am change card to chelsio T5 and don't see issuse. > > > > This is payload issuse, at driver level. > > > > > In any case, I would suggest measuring the RX interrupt rate, and check > > > that it's higher in the ACK-flood case. Then you can try to lower the > > > interrupt rate by tuning the interrupt moderation features of the > Intel NIC > > > (e,g. limit hw.ix.max_interrupt_rate and disable hw.ix.enable_aim or > > > similar). > > > By playing with the interrupt moderation you should be able to > increase the > > > avg_batch, and then increase throghput. > > > > Already limited. > > Also, is this normal (rxd_tail == rxd_head): > > dev.ix.0.queue0.rx_discarded: 0 > dev.ix.0.queue0.rx_copies: 0 > dev.ix.0.queue0.rx_bytes: 612041623304 > dev.ix.0.queue0.rx_packets: 9563149414 > dev.ix.0.queue0.rxd_tail: 1120 > dev.ix.0.queue0.rxd_head: 1120 > dev.ix.0.queue0.irqs: 40154885 > dev.ix.0.queue0.interrupt_rate: 16129 > dev.ix.0.queue0.tx_packets: 553897984 > dev.ix.0.queue0.tso_tx: 0 > dev.ix.0.queue0.txd_tail: 0 > dev.ix.0.queue0.txd_head: 0 > > I am see this RX queue is stoped. > Yes, (rxd_tail == rxd_head) means that the NIC ran out of RX buffers. rxd_head is the next descriptor that the NIC will use. rxd_tail is the next descriptor that the driver will replenish. RX buffers are replenished by the netmap NIOCRXSYNC routine, which is called on poll(). However, rx_discarded is 0, which means that the NIC is not dropping packets. So the problem should not be that poll() is not called frequently enough. You should check rx_discarded for all the queues. Another thing you need to check is how the load is balanced across the receive queues. How many have you configured? Maybe the two workloads (SYN-flood and ACK-flood) load different queues in different ways. From owner-freebsd-net@freebsd.org Fri Feb 28 19:40:05 2020 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id B665C243936 for ; Fri, 28 Feb 2020 19:40:05 +0000 (UTC) (envelope-from slw@zxy.spb.ru) Received: from zxy.spb.ru (zxy.spb.ru [195.70.199.98]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 48TfyB5DKdz4kJv; Fri, 28 Feb 2020 19:40:02 +0000 (UTC) (envelope-from slw@zxy.spb.ru) Received: from slw by zxy.spb.ru with local (Exim 4.86 (FreeBSD)) (envelope-from ) id 1j7lUM-000MgM-4T; Fri, 28 Feb 2020 22:39:58 +0300 Date: Fri, 28 Feb 2020 22:39:58 +0300 From: Slawa Olhovchenkov To: Vincenzo Maffione Cc: FreeBSD Net Subject: Re: Intel NETMAP performance and packet type Message-ID: <20200228193958.GR8012@zxy.spb.ru> References: <20200203204447.GD8028@zxy.spb.ru> <20200225150924.GM8012@zxy.spb.ru> <20200227201650.GO8012@zxy.spb.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) X-SA-Exim-Connect-IP: X-SA-Exim-Mail-From: slw@zxy.spb.ru X-SA-Exim-Scanned: No (on zxy.spb.ru); SAEximRunCond expanded to false X-Rspamd-Queue-Id: 48TfyB5DKdz4kJv X-Spamd-Bar: + Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=none (mx1.freebsd.org: domain of slw@zxy.spb.ru has no SPF policy when checking 195.70.199.98) smtp.mailfrom=slw@zxy.spb.ru X-Spamd-Result: default: False [1.51 / 15.00]; ARC_NA(0.00)[]; FROM_HAS_DN(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_HAM_LONG(-0.08)[-0.078,0]; MIME_GOOD(-0.10)[text/plain]; RCVD_TLS_LAST(0.00)[]; DMARC_NA(0.00)[zxy.spb.ru]; AUTH_NA(1.00)[]; NEURAL_SPAM_MEDIUM(0.61)[0.606,0]; IP_SCORE(0.08)[asn: 5495(0.38), country: RU(0.01)]; TO_DN_ALL(0.00)[]; RCPT_COUNT_TWO(0.00)[2]; R_SPF_NA(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:5495, ipnet:195.70.192.0/19, country:RU]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_COUNT_TWO(0.00)[2] X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 28 Feb 2020 19:40:05 -0000 On Fri, Feb 28, 2020 at 06:31:36PM +0100, Vincenzo Maffione wrote: > Il giorno gio 27 feb 2020 alle ore 21:17 Slawa Olhovchenkov > ha scritto: > > > On Thu, Feb 27, 2020 at 06:51:54PM +0100, Vincenzo Maffione wrote: > > > > > Hi, > > > So, the issue is not the payload. > > > If you look at the avg_batch statistics reported by pkt-gen, you'll see > > > that in the ACK-flood experiment you have 4.92, whereas in the SYN-flood > > > case you have 17.5. The batch is the number of packets (well, actually > > > netmap descriptors, but in this case it's the same) that you receive (or > > > transmit) for each poll() invocation. > > > So in the first case you end up doing much more poll() calls, hence the > > > higher per-packet overhead and the lower packet-rate. > > > > > > Why is the poll() called more frequently? That depends on packet timing > > and > > > interrupt rate. There must be something different on your packet > > generator > > > that produces this effect (e.g. different burstiness, or maybe the packet > > > generator is not able to saturate the 10G link)? > > > > No, I am capture netstat output -- raw packet rate is the same. > > Also, I am change card to chelsio T5 and don't see issuse. > > > > This is payload issuse, at driver level. > > > > That's not possible, since netmap does not even look into the payload. Netmap don't look, NIC can look. I mean driver don't coretly/filly switch off all acceleration and ACK flood caused badly handled event in Intel driver. Don't see for chelsio. > Can you please report the per-queue interrupt rate in both cases (ACK-flood > and SYN-flood)? > You can use something like `vmstat -i -w1 | grep ix` to monitor the > interrupt rate. > Or probably you can also use `sysctl -a dev.ix | grep interrupt_rate` > > > > > In any case, I would suggest measuring the RX interrupt rate, and check > > > that it's higher in the ACK-flood case. Then you can try to lower the > > > interrupt rate by tuning the interrupt moderation features of the Intel > > NIC > > > (e,g. limit hw.ix.max_interrupt_rate and disable hw.ix.enable_aim or > > > similar). > > > By playing with the interrupt moderation you should be able to increase > > the > > > avg_batch, and then increase throghput. > > > > Already limited. > > > > Limited to which value? Have you tried to decrease max_interrupt_rate even > more? 16000, don't try different values for this case. From owner-freebsd-net@freebsd.org Fri Feb 28 19:52:21 2020 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 6E751243F74 for ; Fri, 28 Feb 2020 19:52:21 +0000 (UTC) (envelope-from slw@zxy.spb.ru) Received: from zxy.spb.ru (zxy.spb.ru [195.70.199.98]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 48TgDN1T1wz3MPF; Fri, 28 Feb 2020 19:52:20 +0000 (UTC) (envelope-from slw@zxy.spb.ru) Received: from slw by zxy.spb.ru with local (Exim 4.86 (FreeBSD)) (envelope-from ) id 1j7lgI-000MkQ-FK; Fri, 28 Feb 2020 22:52:18 +0300 Date: Fri, 28 Feb 2020 22:52:18 +0300 From: Slawa Olhovchenkov To: Vincenzo Maffione Cc: FreeBSD Net Subject: Re: Intel NETMAP performance and packet type Message-ID: <20200228195218.GS8012@zxy.spb.ru> References: <20200203204447.GD8028@zxy.spb.ru> <20200225150924.GM8012@zxy.spb.ru> <20200227201650.GO8012@zxy.spb.ru> <20200228112602.GP8012@zxy.spb.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) X-SA-Exim-Connect-IP: X-SA-Exim-Mail-From: slw@zxy.spb.ru X-SA-Exim-Scanned: No (on zxy.spb.ru); SAEximRunCond expanded to false X-Rspamd-Queue-Id: 48TgDN1T1wz3MPF X-Spamd-Bar: + Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=none (mx1.freebsd.org: domain of slw@zxy.spb.ru has no SPF policy when checking 195.70.199.98) smtp.mailfrom=slw@zxy.spb.ru X-Spamd-Result: default: False [1.46 / 15.00]; ARC_NA(0.00)[]; FROM_HAS_DN(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_HAM_LONG(-0.14)[-0.137,0]; MIME_GOOD(-0.10)[text/plain]; RCVD_TLS_LAST(0.00)[]; DMARC_NA(0.00)[zxy.spb.ru]; AUTH_NA(1.00)[]; NEURAL_SPAM_MEDIUM(0.62)[0.616,0]; IP_SCORE(0.08)[asn: 5495(0.38), country: RU(0.01)]; TO_DN_ALL(0.00)[]; RCPT_COUNT_TWO(0.00)[2]; R_SPF_NA(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:5495, ipnet:195.70.192.0/19, country:RU]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_COUNT_TWO(0.00)[2] X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 28 Feb 2020 19:52:21 -0000 On Fri, Feb 28, 2020 at 06:37:22PM +0100, Vincenzo Maffione wrote: > Il giorno ven 28 feb 2020 alle ore 12:26 Slawa Olhovchenkov > ha scritto: > > > On Thu, Feb 27, 2020 at 11:16:50PM +0300, Slawa Olhovchenkov wrote: > > > > > On Thu, Feb 27, 2020 at 06:51:54PM +0100, Vincenzo Maffione wrote: > > > > > > > Hi, > > > > So, the issue is not the payload. > > > > If you look at the avg_batch statistics reported by pkt-gen, you'll see > > > > that in the ACK-flood experiment you have 4.92, whereas in the > > SYN-flood > > > > case you have 17.5. The batch is the number of packets (well, actually > > > > netmap descriptors, but in this case it's the same) that you receive > > (or > > > > transmit) for each poll() invocation. > > > > So in the first case you end up doing much more poll() calls, hence the > > > > higher per-packet overhead and the lower packet-rate. > > > > > > > > Why is the poll() called more frequently? That depends on packet > > timing and > > > > interrupt rate. There must be something different on your packet > > generator > > > > that produces this effect (e.g. different burstiness, or maybe the > > packet > > > > generator is not able to saturate the 10G link)? > > > > > > No, I am capture netstat output -- raw packet rate is the same. > > > Also, I am change card to chelsio T5 and don't see issuse. > > > > > > This is payload issuse, at driver level. > > > > > > > In any case, I would suggest measuring the RX interrupt rate, and check > > > > that it's higher in the ACK-flood case. Then you can try to lower the > > > > interrupt rate by tuning the interrupt moderation features of the > > Intel NIC > > > > (e,g. limit hw.ix.max_interrupt_rate and disable hw.ix.enable_aim or > > > > similar). > > > > By playing with the interrupt moderation you should be able to > > increase the > > > > avg_batch, and then increase throghput. > > > > > > Already limited. > > > > Also, is this normal (rxd_tail == rxd_head): > > > > dev.ix.0.queue0.rx_discarded: 0 > > dev.ix.0.queue0.rx_copies: 0 > > dev.ix.0.queue0.rx_bytes: 612041623304 > > dev.ix.0.queue0.rx_packets: 9563149414 > > dev.ix.0.queue0.rxd_tail: 1120 > > dev.ix.0.queue0.rxd_head: 1120 > > dev.ix.0.queue0.irqs: 40154885 > > dev.ix.0.queue0.interrupt_rate: 16129 > > dev.ix.0.queue0.tx_packets: 553897984 > > dev.ix.0.queue0.tso_tx: 0 > > dev.ix.0.queue0.txd_tail: 0 > > dev.ix.0.queue0.txd_head: 0 > > > > I am see this RX queue is stoped. > > Ah, may fault. This is different case on same Intel card, this is no ACK-flood. And I am see this on production traffic. > Yes, (rxd_tail == rxd_head) means that the NIC ran out of RX buffers. > rxd_head is the next descriptor that the NIC will use. rxd_tail is the next > descriptor that the driver will replenish. RX buffers are replenished by > the netmap NIOCRXSYNC routine, which is called on poll(). poll() still called frequenced but rxd_head/rxd_tail stalled. > However, rx_discarded is 0, which means that the NIC is not dropping > packets. So the problem should not be that poll() is not called frequently > enough. poll() called for all queue synchronously for multiple queue, stalled only one. > You should check rx_discarded for all the queues. All zero. > Another thing you need to check is how the load is balanced across the > receive queues. How many have you configured? Maybe the two workloads > (SYN-flood and ACK-flood) load different queues in different ways. Sorry, this is different case: after some time (after hour, for example) some queue stalled infinitly. Rest queue handle traffic. This is Intel card, iflib variant. From owner-freebsd-net@freebsd.org Sat Feb 29 06:28:03 2020 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 354F62571FD for ; Sat, 29 Feb 2020 06:28:03 +0000 (UTC) (envelope-from tao@yikedadz.com) Received: from m177134.mail.qiye.163.com (m177134.mail.qiye.163.com [123.58.177.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 48TxKr1G2gz4FS7 for ; Sat, 29 Feb 2020 06:27:58 +0000 (UTC) (envelope-from tao@yikedadz.com) Received: from kotvrkh (unknown [113.82.128.180]) by m17618.mail.qiye.163.com (Hmail) with ESMTPA id 146A54E0FD0 for ; Sat, 29 Feb 2020 07:19:20 +0800 (CST) Reply-To: tao@yikedadz.com From: Tao To: freebsd-net Subject: Re: New and original Resistors & Capacitors parts from manufacturers Date: Sat, 29 Feb 2020 07:19:01 +0800 X-HM-Spam-Status: e1kfGhgUHx5ZQUlXWQgYFAkeWUFZQ1VCQkpLS0tKTE5PTE1LTFlXWShZQU hPN1dZLVlBSVdZCQ4XHghZQVk1NCk2OjckKS43PlkG Message-Id: <20200229071920.146A54E0FD0@m17618.mail.qiye.163.com> X-HM-Sender-Digest: e1kMHhlZQR0aFwgeV1kSHx4VD1lBWUc6OTY6NRw6GDg6OUw#QxU6Qgsi KigaC01VSlVKTkNJQkhKQk1LSUNOVTMWGhIXVQ8aFDsCEhAeHxofAVUYFBZFWVdZEgtZQVlKSkhV Q0lVSklDVUpDS1lXWQgBWUFMSUlJNwY+ X-HM-Tid: 0a708e18e1399376kuws146a54e0fd0 X-Rspamd-Queue-Id: 48TxKr1G2gz4FS7 X-Spamd-Bar: +++++++ Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of tao@yikedadz.com designates 123.58.177.134 as permitted sender) smtp.mailfrom=tao@yikedadz.com X-Spamd-Result: default: False [7.92 / 15.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; HAS_REPLYTO(0.00)[tao@yikedadz.com]; R_SPF_ALLOW(-0.20)[+ip4:123.58.177.0/24]; MISSING_MIME_VERSION(2.00)[]; REPLYTO_ADDR_EQ_FROM(0.00)[]; URI_COUNT_ODD(1.00)[1]; TO_DN_ALL(0.00)[]; MIME_BASE64_TEXT(0.10)[]; RECEIVED_SPAMHAUS_PBL(0.00)[180.128.82.113.khpj7ygk5idzvmvt5x4ziurxhy.zen.dq.spamhaus.net : 127.0.0.11]; RCVD_TLS_LAST(0.00)[]; R_DKIM_NA(0.00)[]; ASN(0.00)[asn:45062, ipnet:123.58.160.0/19, country:CN]; MIME_TRACE(0.00)[0:+,1:+,2:~]; FROM_EQ_ENVFROM(0.00)[]; ARC_NA(0.00)[]; FAKE_REPLY(1.00)[]; FROM_HAS_DN(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; HEADER_FORGED_MDN(2.00)[]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; PREVIOUSLY_DELIVERED(0.00)[freebsd-net@freebsd.org]; DMARC_NA(0.00)[yikedadz.com]; NEURAL_SPAM_MEDIUM(0.99)[0.994,0]; RCPT_COUNT_ONE(0.00)[1]; IP_SCORE(0.13)[ip: (0.36), ipnet: 123.58.160.0/19(0.08), asn: 45062(0.17), country: CN(0.02)]; NEURAL_SPAM_LONG(1.00)[0.999,0]; RCVD_IN_DNSWL_NONE(0.00)[134.177.58.123.list.dnswl.org : 127.0.5.0]; RCVD_COUNT_TWO(0.00)[2]; GREYLIST(0.00)[pass,body] X-Spam: Yes Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 29 Feb 2020 06:28:03 -0000 DQpEZWFyIEN1c3RvbWVycywNCkdvb2QgZGF577yBDQogIFdlIGFyZSBhIGRpc3RyaWJ1dG9yIGZv ciBlbGVjdHJvbmljIGNvbXBvbmVudHMsIGluY2x1ZGluZyBJQ3MsIFRyYW5zaXN0b3JzLCBEaW9k ZXMsIFJlc2lzdG9ycywgQ2FwYWNpdG9ycywgYW5kIHNvIG9uLiBJZiB5b3UgbmVlZCBhbnkgcGFy dHMsIHBsZWFzZSBzZW5kIHVzIGlucXVpcmllcywgd2UnbGwgb2ZmZXIgeW91IG1vcmUgYmV0dGVy IHByaWNlIGFuZCBtb3JlIGJldHRlciBzZXJ2aWNlISANCg0KVGhhbmsgeW91IQ0KLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0NCk15IGNvbXBhbnkncyBtYWluIGJ1c2luZXNzIGlzIG1lbW9yeSBJQyBj b21wb25lbnRzLg0KIENoZWNrIGJlbG93IHRoZSBicmFuZHMgdGhhdCB3ZSBkaXN0cmlidXRlLg0K TUVNT1JZOlFVQUxDT01NLFNBTlNVTkcsU0FORElTSyxUT1NISUJBLE1JQ1JPTixTS2h5bml4LFJF TkVTQVMgDQpJQ3PvvJpBTFRFUkEsWElMSU5YLE1JQ1JPQ0hJUCxSZW5lc2FzLEFUTUVMLEFELE1B WElNDQpDYXBhY2l0b3Jz77yaQVZYLEtFTUVULFZJU0hBWSxTQU1TVU5HLE5FQyxUREssTVVSQVRB DQpMRURz77yaT3NyYW0sIFJvaG0sIEFnaWxlbnQsTmljaGlhLCBFdmVybGlnaHQNCklHQlQgTW9k dWxlc++8mk1JVFNVQklTSEksSVhZUyxQQU5KSVQsVE9TSElCQSxGVUpJLFNFTUlLUk9OLElORklO RU9ODQoNCiANCg0KQmVzdCBSZWdhcmRzIQ0KVGFvIENoYW4gDQpTYWxlcyBEaXJlY3Rvcg0KDQpN SVQgSU5URVJOQVRJT05BTCBMSU1JVEVELg0KIzI4MDEgQkxEIEEsIFNUQVJTIFBMQVpBLEhVQVFJ QU5HIE5PUlRIIFJELEZVVElBTiBESVNULFNIRU5aSEVOLCBDSElOQSwgNTE4MDAwDQoNCkNoaW5h DQpUYW8gQ2hlbg0KVGVsOiArODYtNzU1LTg0NTIyMDk2DQpGYXg6ICs4Ni03NTUtMjgzNDUxOTcN CkVtYWlsOnRhb0B5aWtlZGFkei5jb20NCldlYnNpdGU6IHd3dy5taXRjaGlwcy5jb20NCg==