From owner-freebsd-net@freebsd.org Sun Apr 19 17:20:42 2020 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 29A6A27BC09 for ; Sun, 19 Apr 2020 17:20:42 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (mailman.nyi.freebsd.org [IPv6:2610:1c1:1:606c::50:13]) by mx1.freebsd.org (Postfix) with ESMTP id 494xRt0LMNz4d35 for ; Sun, 19 Apr 2020 17:20:42 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id 09DA427BC07; Sun, 19 Apr 2020 17:20:42 +0000 (UTC) Delivered-To: net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 09A0A27BC06 for ; Sun, 19 Apr 2020 17:20:42 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 494xRs6XPKz4d34 for ; Sun, 19 Apr 2020 17:20:41 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id DBD6E1569 for ; Sun, 19 Apr 2020 17:20:41 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 03JHKfv1018758 for ; Sun, 19 Apr 2020 17:20:41 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 03JHKfm0018586 for net@FreeBSD.org; Sun, 19 Apr 2020 17:20:41 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: net@FreeBSD.org Subject: [Bug 242070] if_vmx: scp on 12.1p1-RELEASE is painfully slow Date: Sun, 19 Apr 2020 17:20:40 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 12.1-RELEASE X-Bugzilla-Keywords: needs-qa, performance, regression X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: eugen@freebsd.org X-Bugzilla-Status: Closed X-Bugzilla-Resolution: DUPLICATE X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: net@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback? X-Bugzilla-Changed-Fields: bug_status resolution Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 19 Apr 2020 17:20:42 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D242070 Eugene Grosbein changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Open |Closed Resolution|--- |DUPLICATE --- Comment #9 from Eugene Grosbein --- Closed as duplicate of the PR 236999 which has a fix. *** This bug has been marked as a duplicate of bug 236999 *** --=20 You are receiving this mail because: You are the assignee for the bug.= From owner-freebsd-net@freebsd.org Sun Apr 19 21:00:02 2020 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id BAAF92A9F4D for ; Sun, 19 Apr 2020 21:00:02 +0000 (UTC) (envelope-from bugzilla-noreply@FreeBSD.org) Received: from mailman.nyi.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id 4952Jy4XWnz3ytS for ; Sun, 19 Apr 2020 21:00:02 +0000 (UTC) (envelope-from bugzilla-noreply@FreeBSD.org) Received: by mailman.nyi.freebsd.org (Postfix) id 9BB4F2A9F4A; Sun, 19 Apr 2020 21:00:02 +0000 (UTC) Delivered-To: net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 9B7B82A9F49 for ; Sun, 19 Apr 2020 21:00:02 +0000 (UTC) (envelope-from bugzilla-noreply@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4952Jy3jN1z3ytR for ; Sun, 19 Apr 2020 21:00:02 +0000 (UTC) (envelope-from bugzilla-noreply@FreeBSD.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 7AB8E41A6 for ; Sun, 19 Apr 2020 21:00:02 +0000 (UTC) (envelope-from bugzilla-noreply@FreeBSD.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 03JL0221082971 for ; Sun, 19 Apr 2020 21:00:02 GMT (envelope-from bugzilla-noreply@FreeBSD.org) Received: (from bugzilla@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 03JL02xA082970 for net@FreeBSD.org; Sun, 19 Apr 2020 21:00:02 GMT (envelope-from bugzilla-noreply@FreeBSD.org) Message-Id: <202004192100.03JL02xA082970@kenobi.freebsd.org> X-Authentication-Warning: kenobi.freebsd.org: bugzilla set sender to bugzilla-noreply@FreeBSD.org using -f From: bugzilla-noreply@FreeBSD.org To: net@FreeBSD.org Subject: Problem reports for net@FreeBSD.org that need special attention Date: Sun, 19 Apr 2020 21:00:02 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 19 Apr 2020 21:00:02 -0000 To view an individual PR, use: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=(Bug Id). The following is a listing of current problems submitted by FreeBSD users, which need special attention. These represent problem reports covering all versions including experimental development code and obsolete releases. Status | Bug Id | Description ------------+-----------+--------------------------------------------------- In Progress | 221146 | [ixgbe] Problem with second laggport In Progress | 235700 | oce(4) driver causes fatal trap 12 on boot with e New | 204438 | setsockopt() handling of kern.ipc.maxsockbuf limi New | 205592 | TCP processing in IPSec causes kernel panic New | 213410 | [carp] service netif restart causes hang only whe Open | 7556 | ppp: sl_compress_init() will fail if called anyth Open | 187835 | ngctl(8) strange behavior when adding more than 5 Open | 193452 | Dell PowerEdge 210 II -- Kernel panic bce (broadc Open | 194453 | dummynet(4): pipe config bw parameter limited to Open | 202510 | [CARP] advertisements sourced from CARP IP cause Open | 207261 | netmap: Doesn't do TX sync with kqueue Open | 210726 | tcp connect() can return invalid EADDRINUSE (Eg: Open | 222273 | igb(4): Kernel panic (fatal trap 12) due to netwo Open | 225438 | panic in6_unlink_ifa() due to race Open | 227720 | Kernel panic in ppp server Open | 230807 | if_alc(4): Driver not working for Killer Networki Open | 235524 | igb(4): Ethernet interface loses active link stat Open | 236888 | ppp daemon: Allow MTU to be overridden for PPPoE Open | 236983 | bnxt(4) VLAN not operational unless explicit "ifc Open | 237072 | netgraph(4): performance issue [on HardenedBSD]? Open | 237840 | Removed dummynet dependency on ipfw Open | 238324 | Add XG-C100C/AQtion AQC107 10GbE NIC driver Open | 240530 | netgraph/ng_source: Allow ng_source to inject int Open | 240944 | em(4): Crash with Intel 82571EB NIC with AMD Pile Open | 240969 | netinet6: Neighbour reachability detection broken Open | 241106 | tun/ppp: panic: vm_fault: fault on nofault entry Open | 241162 | Panic in closefp() triggered by nginx (uwsgi with Open | 243463 | ix0: Watchdog timeout Open | 244066 | divert: Add sysctls for divert socket send and re Open | 118111 | rc: network.subr Add MAC address based interface 30 problems total for which you should take action. From owner-freebsd-net@freebsd.org Mon Apr 20 13:35:47 2020 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 8F3192C30EB for ; Mon, 20 Apr 2020 13:35:47 +0000 (UTC) (envelope-from ankitraheja09@gmail.com) Received: from mail-wr1-x431.google.com (mail-wr1-x431.google.com [IPv6:2a00:1450:4864:20::431]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 495SPt6XZQz4MWb for ; Mon, 20 Apr 2020 13:35:46 +0000 (UTC) (envelope-from ankitraheja09@gmail.com) Received: by mail-wr1-x431.google.com with SMTP id i10so12159823wrv.10 for ; Mon, 20 Apr 2020 06:35:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=dwFaPcS+NZ6RGvOUqPyibYVD4MPtfDkLiW4w3C5ZW3o=; b=LAulvDNpgBbqU68f/TIaZ9urz4l5eYTkNu2Ju3UnwcBCYR8Pj2OJRVzrsyT8qOLszr zihkZx+Z+IVoElBOpjJVBbdsTPrBCrbnRSgebLVw+l67t8/zOap0Nkq6GYCwBXFst2Xc Rr4Za3crRy0K7cp0+rimnBgzkJJmW/ivzLdzZ+/NYjjUnG5MdljnsPJbbbaEMB5ONl+k SJ7UxU5LRPEoaD8vU2wqHQt1dy9eWX30p/xMH9a8lgVWJ1L+zilNL3Jo4wPsjCnyttq3 465wx/wDmD81ZFV5OeeSPXPH+WuzyhzpQlJSfssVKCmYGO6wt2XCEutTYmPQO07rpLS+ 4Mng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=dwFaPcS+NZ6RGvOUqPyibYVD4MPtfDkLiW4w3C5ZW3o=; b=rH+qnNh0e8xKSaYo6JzzHh22VfIYpJculawshCruKskg9iCphegjb/KvQJ6QrVbvWn 7RYWospb0pyUZvxshR9oIynaPYmsvZx7QbOhoW3431uKr2Ic7axFH35xdVnk0oyyUjnb hueOBcLckmIJd9RLDjOQOoYXW0Pim/5p4sIUUl+qDOdpFCsmLT1dDC6Sc790X3GUPGUK AEMobVRxu2Vc67SLjVLTkq4FN5xi5y5Lu6qQOkW3mkmdag/OUnfkgVj5kBwrlmelcvUv KpI0cqqTsKMvi3raG+vt7z/R3pLgTI9l+b6O+MN9vOGL9VO9Wxzgk/c3IRVGu/eWc6yE NxOA== X-Gm-Message-State: AGi0PubLAMa4EqWH3B1QKNHPkhFqQs775efJAnZHmUr4FfuqcbKssOGg PyhirEssyy6IfPMaADfEO0UJ9izhcqYwRME0KJ9rxc+YwdI= X-Google-Smtp-Source: APiQypKcY/8RrpzALUuFNFdmHgwbnndYRNGKe2DWdGZipHEOk8MEVBaF+nYiv7qPTN5HMEvVMH2XY0yX/NgMnkWTKgs= X-Received: by 2002:adf:f450:: with SMTP id f16mr18842148wrp.346.1587389744885; Mon, 20 Apr 2020 06:35:44 -0700 (PDT) MIME-Version: 1.0 From: ankit raheja Date: Mon, 20 Apr 2020 19:05:32 +0530 Message-ID: Subject: BBR States transition from ProbeRTT to StartUP To: freebsd-net@freebsd.org X-Rspamd-Queue-Id: 495SPt6XZQz4MWb X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20161025 header.b=LAulvDNp; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (mx1.freebsd.org: domain of ankitraheja09@gmail.com designates 2a00:1450:4864:20::431 as permitted sender) smtp.mailfrom=ankitraheja09@gmail.com X-Spamd-Result: default: False [-3.00 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20161025]; FROM_HAS_DN(0.00)[]; R_SPF_ALLOW(-0.20)[+ip6:2a00:1450:4000::/36]; FREEMAIL_FROM(0.00)[gmail.com]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; PREVIOUSLY_DELIVERED(0.00)[freebsd-net@freebsd.org]; TO_DN_NONE(0.00)[]; IP_SCORE_FREEMAIL(0.00)[]; RCPT_COUNT_ONE(0.00)[1]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; IP_SCORE(0.00)[ip: (-9.09), ipnet: 2a00:1450::/32(-2.34), asn: 15169(-0.43), country: US(-0.05)]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DKIM_TRACE(0.00)[gmail.com:+]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; RCVD_IN_DNSWL_NONE(0.00)[1.3.4.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.5.4.1.0.0.a.2.list.dnswl.org : 127.0.5.0]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+,1:+,2:~]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2a00:1450::/32, country:US]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; DWL_DNSWL_NONE(0.00)[gmail.com.dwl.dnswl.org : 127.0.5.0] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 20 Apr 2020 13:35:47 -0000 Hi, I have a query regarding BBR States transition from ProbeRTT to Startup State. As per the code, when a TCP connection leaves Startup State, the variable "bbr->rc_filled_pipe" gets set to 1. When the same connection decided to exit from the ProbeRTT state, it invokes the bbr_exit_probe_rtt() API, where it tried to transit either to Startup State or ProbeBW state based upon the bbr->rc_filled_pipe. If the bbr->rc_filled_pipe has a value 1, it will transit to ProbeBW otherwise to Startup State. *Further, no where in the code, the bbr->rc_filled_pipe is getting set to 0.* Can you please help me, under which scenario the connection can again enter to Startup state? Or It would never get into the Startup State again? Should not we set the rc_filled_pipe = 0 when we come to the Probe state from Drain or Startup state. In addition to this if we get into the state of SUB_DRAIN then we can set this to rc_filled_pipe. Any time we transition to any state then it should be set to 0. Please provide your valuable inputs on the same. Thanks, Ankit From owner-freebsd-net@freebsd.org Mon Apr 20 23:39:49 2020 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 46C1F2B320D for ; Mon, 20 Apr 2020 23:39:49 +0000 (UTC) (envelope-from ricera10@gmail.com) Received: from mail-ej1-f52.google.com (mail-ej1-f52.google.com [209.85.218.52]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 495jpr1Hrmz4Kcp; Mon, 20 Apr 2020 23:39:48 +0000 (UTC) (envelope-from ricera10@gmail.com) Received: by mail-ej1-f52.google.com with SMTP id n4so9432565ejs.11; Mon, 20 Apr 2020 16:39:47 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=55fQHNAwzeUqJw9l0yZZGYEWcgkrv1HcyOIOrNf0Kxw=; b=FzxS91ri4dbPqxDYX7yWtxUyItQhxA0ctdoJ8v5IZ5pUaZ4epVks6fS+jyWprT4z9K PLM5Uh1ImW8FUARvmQmqwemyDZVOsTnkL8IWUxS7i8AkNZaT9LE6v+9cjo5K5vaL/Y7s vrPdt4lsRo32CvUxwf0ZMSCu4juF5Rw07YvJBkylxTnQIn3XM3usLPg/3quLrRYbvwcC wWEITLhe3ApZxgOpspQuqpQATOC8Lm/RAZd0Tal2XQM5DFGCgygjfHS/IDEcRCP8ccR5 GDQ1IdbRYgZ27aZw9UrE9Lrx3gojeWNzMOvjkaNb5e0v7LPY5U22fOqPnlPCgb+w13be dS3g== X-Gm-Message-State: AGi0PuYbYZoHSF9YvF8alvqO5AknYhKhh+6iA6MC14++w29dXBL3oS57 G0is4ajanJCaQPF31tSB2kU33gVnv1c= X-Google-Smtp-Source: APiQypIUcEsOCKnHv2S4ShMT1q247FX+2LCAEerQTdtaJioFyoz1qi636xvx6z0WGaa4om+8caDGLQ== X-Received: by 2002:a17:906:412:: with SMTP id d18mr17257450eja.54.1587425986436; Mon, 20 Apr 2020 16:39:46 -0700 (PDT) Received: from mail-ed1-f45.google.com (mail-ed1-f45.google.com. [209.85.208.45]) by smtp.gmail.com with ESMTPSA id sa29sm62826ejb.39.2020.04.20.16.39.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 20 Apr 2020 16:39:46 -0700 (PDT) Received: by mail-ed1-f45.google.com with SMTP id t12so5537736edw.3; Mon, 20 Apr 2020 16:39:45 -0700 (PDT) X-Received: by 2002:aa7:d5d5:: with SMTP id d21mr17048133eds.160.1587425985715; Mon, 20 Apr 2020 16:39:45 -0700 (PDT) MIME-Version: 1.0 References: <20200212222219.GE83892@raichu> <20200328225150.GA82767@raichu> <20200331192024.GE97238@raichu> <20200406212903.GA55712@raichu> <20200407232347.GA5605@raichu> In-Reply-To: From: Eric Joyner Date: Mon, 20 Apr 2020 16:39:07 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: Issue with epoch_drain_callbacks and unloading iavf(4) [using iflib] To: Mark Johnston Cc: Hans Petter Selasky , freebsd-net@freebsd.org, shurd , John Baldwin , Drew Gallatin X-Rspamd-Queue-Id: 495jpr1Hrmz4Kcp X-Spamd-Bar: / Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of ricera10@gmail.com designates 209.85.218.52 as permitted sender) smtp.mailfrom=ricera10@gmail.com X-Spamd-Result: default: False [-0.99 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCVD_TLS_ALL(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip4:209.85.128.0/17]; NEURAL_HAM_LONG(-0.86)[-0.856,0]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; DMARC_NA(0.00)[freebsd.org]; NEURAL_HAM_MEDIUM(-0.96)[-0.958,0]; RWL_MAILSPIKE_GOOD(0.00)[52.218.85.209.rep.mailspike.net : 127.0.0.18]; URI_COUNT_ODD(1.00)[3]; RCPT_COUNT_FIVE(0.00)[6]; RCVD_COUNT_THREE(0.00)[4]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[52.218.85.209.list.dnswl.org : 127.0.5.0]; IP_SCORE(-0.17)[ipnet: 209.85.128.0/17(-0.40), asn: 15169(-0.43), country: US(-0.05)]; FORGED_SENDER(0.30)[erj@freebsd.org,ricera10@gmail.com]; MIME_TRACE(0.00)[0:+,1:+,2:~]; R_DKIM_NA(0.00)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; FROM_NEQ_ENVFROM(0.00)[erj@freebsd.org,ricera10@gmail.com] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 20 Apr 2020 23:39:49 -0000 On Thu, Apr 9, 2020 at 2:29 PM Eric Joyner wrote: > On Thu, Apr 9, 2020 at 2:02 PM Eric Joyner wrote: > >> On Tue, Apr 7, 2020 at 4:24 PM Mark Johnston wrote: >> >>> I spent some time looking at the core. It looks like we have yet >>> another problem: the gtaskqueue code won't exit the net epoch if it is >>> constantly running a net task. Could you please retry with the patches >>> from before, and this one included? >>> >>> diff --git a/sys/kern/subr_gtaskqueue.c b/sys/kern/subr_gtaskqueue.c >>> index f52f32204644..2b1386a612ee 100644 >>> --- a/sys/kern/subr_gtaskqueue.c >>> +++ b/sys/kern/subr_gtaskqueue.c >>> @@ -345,7 +345,7 @@ gtaskqueue_run_locked(struct gtaskqueue *queue) >>> struct epoch_tracker et; >>> struct gtaskqueue_busy tb; >>> struct gtask *gtask; >>> - bool in_net_epoch; >>> + bool in net_epoch; >>> >>> KASSERT(queue != NULL, ("tq is NULL")); >>> TQ_ASSERT_LOCKED(queue); >>> @@ -361,20 +361,19 @@ gtaskqueue_run_locked(struct gtaskqueue *queue) >>> TQ_UNLOCK(queue); >>> >>> KASSERT(gtask->ta_func != NULL, ("task->ta_func is >>> NULL")); >>> - if (!in_net_epoch && TASK_IS_NET(gtask)) { >>> - in_net_epoch = true; >>> + if (TASK_IS_NET(gtask)) { >>> NET_EPOCH_ENTER(et); >>> - } else if (in_net_epoch && !TASK_IS_NET(gtask)) { >>> + in_net_epoch = true; >>> + } >>> + gtask->ta_func(gtask->ta_context); >>> + if (in_net_epoch) { >>> NET_EPOCH_EXIT(et); >>> in_net_epoch = false; >>> } >>> - gtask->ta_func(gtask->ta_context); >>> >>> TQ_LOCK(queue); >>> wakeup(gtask); >>> } >>> - if (in_net_epoch) >>> - NET_EPOCH_EXIT(et); >>> LIST_REMOVE(&tb, tb_link); >>> } >>> >>> _______________________________________________ >>> freebsd-net@freebsd.org mailing list >>> https://lists.freebsd.org/mailman/listinfo/freebsd-net >>> To unsubscribe, send any mail to "freebsd-net-unsubscribe@freebsd.org" >>> >> >> Yeah, I'll give it a spin and try to get back to you before the end of >> the week. >> >> - Eric >> > > I was able to try it out just now, and it looks this (and all of the other > patches) finally causes the problem to not appear! I can unload the driver > while iavf1 is receiving heavy traffic! > > - Eric > Hi Mark, Are you planning to commit these patches to HEAD? I see the reviews for D24214 and D24215 are still up, and I don't know if you created a review for the patch you put in this email chain. - Eric From owner-freebsd-net@freebsd.org Tue Apr 21 13:06:17 2020 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 61BAD2CCDB7 for ; Tue, 21 Apr 2020 13:06:17 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (mailman.nyi.freebsd.org [IPv6:2610:1c1:1:606c::50:13]) by mx1.freebsd.org (Postfix) with ESMTP id 4963jP201mz4Hjh for ; Tue, 21 Apr 2020 13:06:17 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id 4433A2CCDB6; Tue, 21 Apr 2020 13:06:17 +0000 (UTC) Delivered-To: net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 43FBC2CCDB5 for ; Tue, 21 Apr 2020 13:06:17 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4963jP17pZz4Hjg for ; Tue, 21 Apr 2020 13:06:17 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 2286015CE for ; Tue, 21 Apr 2020 13:06:17 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 03LD6HGn001880 for ; Tue, 21 Apr 2020 13:06:17 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from bugzilla@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 03LD6Hw0001879 for net@FreeBSD.org; Tue, 21 Apr 2020 13:06:17 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: bugzilla set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: net@FreeBSD.org Subject: [Bug 235256] [net] IW10 without ABC leads to initial window of 11 Segments Date: Tue, 21 Apr 2020 13:06:16 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: commit-hook@freebsd.org X-Bugzilla-Status: In Progress X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: tuexen@freebsd.org X-Bugzilla-Flags: mfc-stable12+ mfc-stable11? X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Apr 2020 13:06:17 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D235256 --- Comment #7 from commit-hook@freebsd.org --- A commit references this bug: Author: rscheff Date: Tue Apr 21 13:05:45 UTC 2020 New revision: 360143 URL: https://svnweb.freebsd.org/changeset/base/360143 Log: Correctly set up the initial TCP congestion window in all cases, by adjust snd_una right after the connection initialization, to include the one byte in sequence space occupied by the SYN bit. This does not change the regular ACK processing, while making the BYTES_THIS_ACK macro to work properly. PR: 235256 Reviewed by: tuexen (mentor), rgrimes (mentor) Approved by: tuexen (mentor), rgrimes (mentor) MFC after: 2 weeks Sponsored by: NetApp, Inc. Differential Revision: https://reviews.freebsd.org/D19000 Changes: head/sys/netinet/tcp_input.c head/sys/netinet/tcp_stacks/bbr.c head/sys/netinet/tcp_stacks/rack.c --=20 You are receiving this mail because: You are on the CC list for the bug.= From owner-freebsd-net@freebsd.org Tue Apr 21 17:30:22 2020 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id A5C142B17EF for ; Tue, 21 Apr 2020 17:30:22 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: from mail-qt1-x82c.google.com (mail-qt1-x82c.google.com [IPv6:2607:f8b0:4864:20::82c]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4969Z63zrRz3DdJ; Tue, 21 Apr 2020 17:30:22 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: by mail-qt1-x82c.google.com with SMTP id r19so2335905qtu.11; Tue, 21 Apr 2020 10:30:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=kHns07+EjZq5ngSI4Jekz9inK9W9e/2+8UVlc63OLfk=; b=CT7c0LSlQEmry+mGkG9Ui5Ecz28KIJUOAh+ycXvaxohlytXj5q1Ibo9dSmOpg9pJh8 iZK0tOrBfU9rLFCcsJEUoPQ4zCpAnDdeJjNmoGEYlHdG6sJX1g0SpyQYDTksT3kfiQhv daUkVHcK9WPh2f/UOkGx1EPQWrTUcF+w+0+P2C905rYdyYISweU3ldTOIZzTHj8reBo4 KzV/l7aasGmfYG+hv0u/Amod6gpjQEeNyBMf5n7BMrVdiO/QfT9tBnyNLPW8D8OqUpbi d/ghaxVug4NMOF6u1RB+1updbPaQTT1TMclyWdSYPyEK0DkOMecRKuva9yFlY1tSw7dE Uo6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to; bh=kHns07+EjZq5ngSI4Jekz9inK9W9e/2+8UVlc63OLfk=; b=VCW6SGz+A6qP69Mewu/+Ault29iWjgGDP/gUJ01ghmYNE4Y8H+Em3Kzt3qI9mewowR cEXHN6WOWZmInzFp/9O1qpK6rzjTc3glOwBrSbM7rXzyASuZz4SbGhnNKzTJ+ZmTwS/I MV8oLC6Om2EBUd/aVmahjYOIo1K1LW1k7bbsOATbX/hCQbxsdkTJrH26N9vHYITp2BVo /juGxn+FbbH30w9d/PSjgsq4smMOyCNJh9K9Ti/00yd7Ynqq9PDk6gDB6ZIkRuxmyVBx zvVK/aSmkJhQM8vsiduJREMNkmkhZlj+H+YH6CtA9CskumEGcIYhlbTfrMOcr1Ycumbm 84CQ== X-Gm-Message-State: AGi0PubFWc7+vUJ/N46fNSZ+xtNjNJnJjVNrGKiccM4PN7gFPEDSfpKJ EqQwNc+oYh+VTo+tMAbZkbwrlyMw X-Google-Smtp-Source: APiQypJjDnErkvlNG0m8kD6lQZ2G7Xgccf90eGeWYqwNY/aaVoE/SDnlJPKpKLADtiljFQtf4Cephg== X-Received: by 2002:ac8:550a:: with SMTP id j10mr22115683qtq.193.1587490220874; Tue, 21 Apr 2020 10:30:20 -0700 (PDT) Received: from raichu (toroon0560w-lp130-10-174-94-17-182.dsl.bell.ca. [174.94.17.182]) by smtp.gmail.com with ESMTPSA id r9sm2118995qke.5.2020.04.21.10.30.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Apr 2020 10:30:20 -0700 (PDT) Sender: Mark Johnston Date: Tue, 21 Apr 2020 13:30:18 -0400 From: Mark Johnston To: Eric Joyner Cc: freebsd-net@freebsd.org Subject: Re: Issue with epoch_drain_callbacks and unloading iavf(4) [using iflib] Message-ID: <20200421173018.GD86922@raichu> References: <20200331192024.GE97238@raichu> <20200406212903.GA55712@raichu> <20200407232347.GA5605@raichu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 4969Z63zrRz3DdJ X-Spamd-Bar: ----- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-6.00 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; REPLY(-4.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0] X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Apr 2020 17:30:22 -0000 On Mon, Apr 20, 2020 at 04:39:07PM -0700, Eric Joyner wrote: > On Thu, Apr 9, 2020 at 2:29 PM Eric Joyner wrote: > > > On Thu, Apr 9, 2020 at 2:02 PM Eric Joyner wrote: > > > >> On Tue, Apr 7, 2020 at 4:24 PM Mark Johnston wrote: > >> > >>> I spent some time looking at the core. It looks like we have yet > >>> another problem: the gtaskqueue code won't exit the net epoch if it is > >>> constantly running a net task. Could you please retry with the patches > >>> from before, and this one included? > >>> > >>> diff --git a/sys/kern/subr_gtaskqueue.c b/sys/kern/subr_gtaskqueue.c > >>> index f52f32204644..2b1386a612ee 100644 > >>> --- a/sys/kern/subr_gtaskqueue.c > >>> +++ b/sys/kern/subr_gtaskqueue.c > >>> @@ -345,7 +345,7 @@ gtaskqueue_run_locked(struct gtaskqueue *queue) > >>> struct epoch_tracker et; > >>> struct gtaskqueue_busy tb; > >>> struct gtask *gtask; > >>> - bool in_net_epoch; > >>> + bool in net_epoch; > >>> > >>> KASSERT(queue != NULL, ("tq is NULL")); > >>> TQ_ASSERT_LOCKED(queue); > >>> @@ -361,20 +361,19 @@ gtaskqueue_run_locked(struct gtaskqueue *queue) > >>> TQ_UNLOCK(queue); > >>> > >>> KASSERT(gtask->ta_func != NULL, ("task->ta_func is > >>> NULL")); > >>> - if (!in_net_epoch && TASK_IS_NET(gtask)) { > >>> - in_net_epoch = true; > >>> + if (TASK_IS_NET(gtask)) { > >>> NET_EPOCH_ENTER(et); > >>> - } else if (in_net_epoch && !TASK_IS_NET(gtask)) { > >>> + in_net_epoch = true; > >>> + } > >>> + gtask->ta_func(gtask->ta_context); > >>> + if (in_net_epoch) { > >>> NET_EPOCH_EXIT(et); > >>> in_net_epoch = false; > >>> } > >>> - gtask->ta_func(gtask->ta_context); > >>> > >>> TQ_LOCK(queue); > >>> wakeup(gtask); > >>> } > >>> - if (in_net_epoch) > >>> - NET_EPOCH_EXIT(et); > >>> LIST_REMOVE(&tb, tb_link); > >>> } > >>> > >>> _______________________________________________ > >>> freebsd-net@freebsd.org mailing list > >>> https://lists.freebsd.org/mailman/listinfo/freebsd-net > >>> To unsubscribe, send any mail to "freebsd-net-unsubscribe@freebsd.org" > >>> > >> > >> Yeah, I'll give it a spin and try to get back to you before the end of > >> the week. > >> > >> - Eric > >> > > > > I was able to try it out just now, and it looks this (and all of the other > > patches) finally causes the problem to not appear! I can unload the driver > > while iavf1 is receiving heavy traffic! > > > > - Eric > > > > Hi Mark, > > Are you planning to commit these patches to HEAD? I see the reviews for > D24214 and D24215 are still up, and I don't know if you created a review > for the patch you put in this email chain. Hi Eric, Yes, I'm working on getting those patches reviewed and committed. The patch above was just to verify a theory, we still need a proper solution. From owner-freebsd-net@freebsd.org Thu Apr 23 01:09:51 2020 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 62DFB2C7C12 for ; Thu, 23 Apr 2020 01:09:51 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (mailman.nyi.freebsd.org [IPv6:2610:1c1:1:606c::50:13]) by mx1.freebsd.org (Postfix) with ESMTP id 496zjq1Pg7z4CK3 for ; Thu, 23 Apr 2020 01:09:51 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id 2E0052C7C11; Thu, 23 Apr 2020 01:09:51 +0000 (UTC) Delivered-To: net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 2C8E72C7C10 for ; Thu, 23 Apr 2020 01:09:51 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 496zjq073yz4CK2 for ; Thu, 23 Apr 2020 01:09:51 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id EF71523E86 for ; Thu, 23 Apr 2020 01:09:50 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 03N19omb046348 for ; Thu, 23 Apr 2020 01:09:50 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 03N19oZo046347 for net@FreeBSD.org; Thu, 23 Apr 2020 01:09:50 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: net@FreeBSD.org Subject: [Bug 226217] if_qlxgb (QLogic cLOM8214) not working for me when configured via netif Date: Thu, 23 Apr 2020 01:09:50 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 11.1-STABLE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: novacrash_@hotmail.com X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: net@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: cc attachments.created Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Apr 2020 01:09:51 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D226217 Christian Valli=C3=A8res changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |novacrash_@hotmail.com --- Comment #4 from Christian Valli=C3=A8res --- Created attachment 213710 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D213710&action= =3Dedit Fix that mtu not initialized bug MTU need to be initialized before qla_os:685 ha->max_frame_size =3D ifp->if_mtu + ETHER_HDR_LEN + ETHER_CRC_LEN; Otherwise packet is always flagged as too big in qla_hw.c:1003 if ((mp->m_pkthdr.len > ha->max_frame_size)||(nsegs > Q8_TX_MAX_SEGMENTS)) { I also moved qla_os:694 ifp->if_capabilities =3D IFCAP_LINKSTATE; Before qla_os:687 ether_ifattach(ifp, qla_get_mac_addr(ha)); Like in qlxgbe/ql_os:877 because I had trouble doing ifconfig ql0 up for bridge. --=20 You are receiving this mail because: You are the assignee for the bug.= From owner-freebsd-net@freebsd.org Thu Apr 23 12:15:12 2020 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 53EB12B45D2 for ; Thu, 23 Apr 2020 12:15:12 +0000 (UTC) (envelope-from daemon-user@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 497GTX1bB0z4vYV for ; Thu, 23 Apr 2020 12:15:12 +0000 (UTC) (envelope-from daemon-user@freebsd.org) Received: from reviews.nyi.freebsd.org (reviews.nyi.freebsd.org [IPv6:2610:1c1:1:607c::16:b]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 2D896443D for ; Thu, 23 Apr 2020 12:15:12 +0000 (UTC) (envelope-from daemon-user@freebsd.org) Received: by reviews.nyi.freebsd.org (Postfix, from userid 1346) id 2C813438333; Thu, 23 Apr 2020 12:15:12 +0000 (UTC) Date: Thu, 23 Apr 2020 12:15:12 +0000 To: freebsd-net@freebsd.org From: "ae (Andrey V. Elsukov)" Reply-to: "ae (Andrey V. Elsukov)" Subject: [Differential] D24061: Hyper-V socket implementation for FreeBSD guest Message-ID: X-Priority: 3 X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: , X-Herald-Rules: <28>, <76> X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: Precedence: bulk Thread-Topic: PHID-DREV-jw7sxemgfjxsdvkov4cn X-Phabricator-Mail-ID: 1920879 X-Phabricator-Send-Attempt: 35dcyh3egakt6vgd In-Reply-To: References: Thread-Index: MzZiZTcyYjBkYTFiNDZhYjY1NmQ1MTYwZmJiIF6hhtA= X-Phabricator-Stamps: actor(@ae) application(Differential) author(@whu) herald(H28) herald(H76) monogram(D24061) object-type(DREV) phid(PHID-DREV-jw7sxemgfjxsdvkov4cn) reviewer(@decui_microsoft.com) reviewer(@freebsd-net-list) revision-repository(rS) revision-status(needs-review) subscriber(@ae) subscriber(@greg_unrelenting.technology) subscriber(@imp) via(web) MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.29 List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Apr 2020 12:15:12 -0000 YWUgYWRkZWQgYSBjb21tZW50LgoKCiAgRG8geW91IGhhdmUgcGVyZm9ybWFuY2UgdGVzdCByZXN1 bHRzIGZvciBhbHJlYWR5IGV4aXN0aW5nIGxpbnV4IGltcGxlbWVudGF0aW9uPwogIEZyb20gYSBx dWljayBsb29rIGl0IHNlZW1zIHRvIG1lIHRoZXJlIHdpbGwgYmUgYm90dGxlbmVjayByZWdhcmRp bmcgbG9ja2luZyB0aGF0IHNlZW1zIGNhbiBiZSByZWR1Y2VkIHVzaW5nIENLIGFuZCBlcG9jaC4g QnV0IHRoaXMgdGFzayBjYW4gYmUgZG9uZSBpbiBmdXR1cmUsIGlmIHlvdSBwbGFuIHN1cHBvcnQg dGhpcyBjb2RlLgoKUkVQT1NJVE9SWQogIHJTIEZyZWVCU0Qgc3JjIHJlcG9zaXRvcnkKCkNIQU5H RVMgU0lOQ0UgTEFTVCBBQ1RJT04KICBodHRwczovL3Jldmlld3MuZnJlZWJzZC5vcmcvRDI0MDYx L25ldy8KClJFVklTSU9OIERFVEFJTAogIGh0dHBzOi8vcmV2aWV3cy5mcmVlYnNkLm9yZy9EMjQw NjEKCkVNQUlMIFBSRUZFUkVOQ0VTCiAgaHR0cHM6Ly9yZXZpZXdzLmZyZWVic2Qub3JnL3NldHRp bmdzL3BhbmVsL2VtYWlscHJlZmVyZW5jZXMvCgpUbzogd2h1LCBkZWN1aV9taWNyb3NvZnQuY29t LCBmcmVlYnNkLW5ldC1saXN0CkNjOiBhZSwgZ3JlZ191bnJlbGVudGluZy50ZWNobm9sb2d5LCBp bXAK From owner-freebsd-net@freebsd.org Fri Apr 24 01:13:51 2020 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 76F0A2C984A for ; Fri, 24 Apr 2020 01:13:51 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id 497blz2bvHz4Zwk for ; Fri, 24 Apr 2020 01:13:51 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id 595302C9849; Fri, 24 Apr 2020 01:13:51 +0000 (UTC) Delivered-To: net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 5919D2C9848 for ; Fri, 24 Apr 2020 01:13:51 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 497blz1l65z4Zwj for ; Fri, 24 Apr 2020 01:13:51 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 37200DD37 for ; Fri, 24 Apr 2020 01:13:51 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 03O1Dpo0004760 for ; Fri, 24 Apr 2020 01:13:51 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 03O1DpGD004759 for net@FreeBSD.org; Fri, 24 Apr 2020 01:13:51 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: net@FreeBSD.org Subject: [Bug 226217] if_qlxgb (QLogic cLOM8214) not working for me when configured via netif Date: Fri, 24 Apr 2020 01:13:50 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 11.1-STABLE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: novacrash_@hotmail.com X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: net@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Apr 2020 01:13:51 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D226217 --- Comment #5 from Christian Valli=C3=A8res --- Comment on attachment 213710 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D213710 Fix that mtu not initialized bug diff --git a/sys/dev/qlxgb/qla_os.c b/sys/dev/qlxgb/qla_os.c index 0b5daa98891..997f1eccf76 100644 --- a/sys/dev/qlxgb/qla_os.c +++ b/sys/dev/qlxgb/qla_os.c @@ -672,6 +672,9 @@ qla_init_ifnet(device_t dev, qla_host_t *ha) if_initname(ifp, device_get_name(dev), device_get_unit(dev)); ifp->if_baudrate =3D IF_Gbps(10); + ifp->if_capabilities =3D IFCAP_LINKSTATE; + ifp->if_mtu =3D ETHERMTU; + ifp->if_init =3D qla_init; ifp->if_softc =3D ha; ifp->if_flags =3D IFF_BROADCAST | IFF_SIMPLEX | IFF_MULTICAST; @@ -691,7 +694,6 @@ qla_init_ifnet(device_t dev, qla_host_t *ha) IFCAP_JUMBO_MTU; ifp->if_capabilities |=3D IFCAP_VLAN_HWTAGGING | IFCAP_VLAN_MTU; - ifp->if_capabilities |=3D IFCAP_LINKSTATE; #if defined(__FreeBSD_version) && (__FreeBSD_version < 900002) ifp->if_timer =3D 0; --=20 You are receiving this mail because: You are the assignee for the bug.=